[GitHub] cloudstack pull request #1689: Switched to the official SolidFire SDK for Py...

2016-09-23 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/1689

Switched to the official SolidFire SDK for Python

SolidFire has recently released an official SDK for Python.

I have converted all of the SolidFire integration tests over to making use 
of this new SDK.

For testing, I re-ran each test and observed success.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack use_sf_python_sdk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1689


commit 04c1c689ed86df61e1fdda6d9be134199e223944
Author: Mike Tutkowski 
Date:   2016-09-24T05:47:04Z

Switched to the official SolidFire SDK for Python




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1451: CLOUDSTACK-9319: Use timeout when applying config to...

2016-09-23 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1451
  
@insom do not worry, actually I am +1 with this PR. I agree with what you 
said.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1451: CLOUDSTACK-9319: Use timeout when applying config to...

2016-09-23 Thread insom
Github user insom commented on the issue:

https://github.com/apache/cloudstack/pull/1451
  
@ustcweizhou A _side effect_ of this PR is setting the minimal timeout to 
120, but that's what the original code intended - except that because of not 
passing through the timeout to `applyConfigToVR` it wasn't taking effect.

What this PR really does is make the code work as intended. I'm up for 
improvements but if this is blocking upgrades (and at least iWeb and one other 
CloudStack user were hit by it) seems like merging this and _then_ moving it to 
a per-host setting would be a good idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1451: CLOUDSTACK-9319: Use timeout when applying config to...

2016-09-23 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1451
  
many people thought that changing router.aggregation.command.each.timeout 
in global setting will increase the timeout. Actually it is not, at least for 
KVM.

for KVM hypervisors, we need to put 
router.aggregation.command.each.timeout=??? in agent.properties and restart 
cloudstack-agent.

This PR increases the minimal timeout to 120 seconds which is helpful but 
does not really fix the issue.

I think it is better to add host-level setting for each host in the future, 
like we did for domain/account, zone/cluster.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: vmware macchinina template

2016-09-23 Thread Nux!
Hi,

I am away for a few days, won't have a chance to look at this till next week. 
There should be an 'old' dir on the same location, can you give that a try, see 
if it has the driver?

-- 
Sent from my mobile device. Please excuse my brevity.

On 23 September 2016 13:05:26 CEST, Paul Angus  wrote:
>Hi Nux,
>
>How are you doing?
>
>I'm fixing the marvin tests to point to
>http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova
>
>But Serg points out that the vmware template doesn't have an E1000
>(intel pro/1000) driver in it so can't enable interfaces.
>Could you fix or let me know how I can build a template to pass back to
>you pls.
>
>
>
>Kind regards,
>
>Paul Angus
>
>
>paul.an...@shapeblue.com 
>www.shapeblue.com
>53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>@shapeblue
>  
> 


[GitHub] cloudstack issue #872: Strongswan vpn feature

2016-09-23 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/872
  
I got it to build, will be testing it soon...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1688: Marvin Tests: Fix VPC network offering select...

2016-09-23 Thread PaulAngus
GitHub user PaulAngus opened a pull request:

https://github.com/apache/cloudstack/pull/1688

Marvin Tests: Fix VPC network offering selection

It appears that original code did not expect there to be an alternate 
default VPC offering (Nuage) .
VPC selection uses isdefault=True which selects the Nuage Network offering, 
stopping the test from being run.
Fix was to look for name="Default VPC Offering" instead.

Replaces PR #1652 (same content, differenet branch)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 
4.8-marvintest-vpcofferingfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1688


commit 3bafd509caa5368bd7adbd81c65682dda5685b2f
Author: Paul Angus 
Date:   2016-09-23T19:40:36Z

Marvin Tests: Fix VPC network offering selection




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1687: Marvintests vpcofferingfix

2016-09-23 Thread PaulAngus
Github user PaulAngus closed the pull request at:

https://github.com/apache/cloudstack/pull/1687


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Trillian test result (tid-47)
Environment: vmware-55u3 (x2), Advanced Networking
Total time taken: 31689s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1685-t47-vmware-55u3.zip
Test completed. 39 look ok, 14 have errors


Test | Result | Time (s)
--- | --- | ---
test_10_attachAndDetach_iso | `Failure` | 60.174
test_04_rvpc_privategw_static_routes | `Failure` | 334.268
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 208.561
test_02_vpc_privategw_static_routes | `Failure` | 188.238
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 587.605
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
360.164
test_01_vpc_privategw_acl | `Failure` | 112.611
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 417.532
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
340.583
test_router_dhcphosts | `Error` | 798.123
test_oobm_issue_power_off | `Error` | 15.587
test_isolate_network_password_server | `Error` | 822.509
test_extendPhysicalNetworkVlan | `Error` | 0.034
test_dedicatePublicIpRange | `Error` | 0.373
test_CreateTemplateWithDuplicateName | `Error` | 5.209
test_09_reboot_router | `Error` | 151.189
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 452.163
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 356.432
test_02_routervm_iptables_policies | `Error` | 856.922
test_01_vpc_site2site_vpn | `Error` | 477.246
test_01_vpc_remote_access_vpn | `Error` | 0.095
test_01_test_vm_volume_snapshot | `Error` | 116.316
test_01_single_VPC_iptables_policies | `Error` | 984.092
test_01_redundant_vpc_site2site_vpn | `Error` | 678.713
test_01_create_template | `Error` | 5.234
ContextSuite context=TestTemplates>:setup | `Error` | 216.513
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 819.170
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.714
test_router_dns_externalipquery | Success | 0.051
test_rolepermission_lifecycle_update | Success | 7.390
test_rolepermission_lifecycle_list | Success | 7.246
test_rolepermission_lifecycle_delete | Success | 6.859
test_rolepermission_lifecycle_create | Success | 6.899
test_rolepermission_lifecycle_concurrent_updates | Success | 7.249
test_role_lifecycle_update_role_inuse | Success | 6.968
test_role_lifecycle_update | Success | 12.124
test_role_lifecycle_list | Success | 7.037
test_role_lifecycle_delete | Success | 12.202
test_role_lifecycle_create | Success | 6.956
test_role_inuse_deletion | Success | 6.979
test_role_account_acls_multiple_mgmt_servers | Success | 10.834
test_role_account_acls | Success | 11.008
test_releaseIP | Success | 254.528
test_reboot_router | Success | 575.966
test_public_ip_user_account | Success | 10.305
test_public_ip_admin_account | Success | 40.341
test_oobm_zchange_password | Success | 20.638
test_oobm_multiple_mgmt_server_ownership | Success | 14.583
test_oobm_issue_power_status | Success | 10.574
test_oobm_issue_power_soft | Success | 15.618
test_oobm_issue_power_reset | Success | 15.593
test_oobm_issue_power_on | Success | 15.623
test_oobm_issue_power_cycle | Success | 15.619
test_oobm_enabledisable_across_clusterzones | Success | 49.471
test_oobm_enable_feature_valid | Success | 5.198
test_oobm_enable_feature_invalid | Success | 0.126
test_oobm_disable_feature_valid | Success | 5.224
test_oobm_disable_feature_invalid | Success | 0.122
test_oobm_configure_invalid_driver | Success | 0.098
test_oobm_configure_default_driver | Success | 0.126
test_oobm_background_powerstate_sync | Success | 11.578
test_nic_secondaryip_add_remove | Success | 218.784
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 
72.043
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.885
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.363
test_network_acl | Success | 146.773
test_deployvm_userdispersing | Success | 55.920
test_deployvm_userdata_post | Success | 25.808
test_deployvm_userdata | Success | 162.075
test_deployvm_userconcentrated | Success | 55.984
test_deployvm_firstfit | Success | 191.936
test_deploy_vm_multiple | Success | 178.442
test_deploy_vm_from_iso | Success | 570.744
test_deploy_vm | Success | 0.032
test_delete_account | Success | 309.314
test_default_role_deletion | Success | 7.176
test_create_pvlan_network | Success | 5.250
test_createRegion | Success | 0.057
test_createPortablePublicIPRange | Success | 15.418

[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
/cc @jburwell @karuturi this is an example PR to show various combinations 
of Trillian environments (hypervisors and mgmt server os).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Trillian test result (tid-45)
Environment: vmware-60u2 (x2), Advanced Networking
Total time taken: 29784s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1685-t45-vmware-60u2.zip
Test completed. 41 look ok, 12 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 102.915
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 183.262
test_02_vpc_privategw_static_routes | `Failure` | 188.393
test_02_revert_vm_snapshots | `Failure` | 90.333
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 532.555
test_01_vpc_privategw_acl | `Failure` | 87.564
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 418.757
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
319.195
test_router_dhcphosts | `Error` | 825.430
test_isolate_network_password_server | `Error` | 814.910
test_extendPhysicalNetworkVlan | `Error` | 0.040
test_dedicatePublicIpRange | `Error` | 0.375
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 401.716
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 301.262
test_03_restart_network_cleanup | `Error` | 136.192
test_02_routervm_iptables_policies | `Error` | 941.560
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
233.300
test_01_vpc_site2site_vpn | `Error` | 443.090
test_01_vpc_remote_access_vpn | `Error` | 0.109
test_01_test_vm_volume_snapshot | `Error` | 131.433
test_01_single_VPC_iptables_policies | `Error` | 991.467
test_01_redundant_vpc_site2site_vpn | `Error` | 628.698
test_01_create_vm_snapshots | `Error` | 161.712
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 841.666
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.795
test_router_dns_externalipquery | Success | 0.086
test_rolepermission_lifecycle_update | Success | 8.343
test_rolepermission_lifecycle_list | Success | 7.245
test_rolepermission_lifecycle_delete | Success | 7.112
test_rolepermission_lifecycle_create | Success | 7.127
test_rolepermission_lifecycle_concurrent_updates | Success | 7.333
test_role_lifecycle_update_role_inuse | Success | 6.874
test_role_lifecycle_update | Success | 12.183
test_role_lifecycle_list | Success | 6.945
test_role_lifecycle_delete | Success | 12.011
test_role_lifecycle_create | Success | 7.457
test_role_inuse_deletion | Success | 7.081
test_role_account_acls_multiple_mgmt_servers | Success | 9.585
test_role_account_acls | Success | 9.802
test_releaseIP | Success | 219.078
test_reboot_router | Success | 515.907
test_public_ip_user_account | Success | 10.345
test_public_ip_admin_account | Success | 40.363
test_oobm_zchange_password | Success | 21.160
test_oobm_multiple_mgmt_server_ownership | Success | 12.554
test_oobm_issue_power_status | Success | 10.578
test_oobm_issue_power_soft | Success | 15.619
test_oobm_issue_power_reset | Success | 15.615
test_oobm_issue_power_on | Success | 15.614
test_oobm_issue_power_off | Success | 15.663
test_oobm_issue_power_cycle | Success | 15.631
test_oobm_enabledisable_across_clusterzones | Success | 58.985
test_oobm_enable_feature_valid | Success | 5.222
test_oobm_enable_feature_invalid | Success | 0.142
test_oobm_disable_feature_valid | Success | 5.324
test_oobm_disable_feature_invalid | Success | 0.390
test_oobm_configure_invalid_driver | Success | 0.199
test_oobm_configure_default_driver | Success | 0.131
test_oobm_background_powerstate_sync | Success | 13.682
test_nic_secondaryip_add_remove | Success | 168.588
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 
77.103
test_network_rules_acquired_public_ip_2_nat_rule | Success | 62.049
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.874
test_network_acl | Success | 126.694
test_deployvm_userdispersing | Success | 56.210
test_deployvm_userdata_post | Success | 20.619
test_deployvm_userdata | Success | 272.938
test_deployvm_userconcentrated | Success | 46.201
test_deployvm_firstfit | Success | 141.768
test_deploy_vm_multiple | Success | 193.580
test_deploy_vm_from_iso | Success | 344.001
test_deploy_vm | Success | 0.029
test_delete_account | Success | 254.056
test_default_role_deletion | Success | 7.156
test_create_pvlan_network | Success | 5.321
test_createRegion | Success | 0.053
test_createPortablePublicIPRange | Success | 15.416
test_createPortablePublicIPAcquire | Success | 15.778
test_assign_and_removal_lb | Success | 138.614

[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Trillian test result (tid-46)
Environment: kvm-centos6 (x2), Advanced Networking
Total time taken: 28905s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1685-t46-kvm-centos6.zip
Test completed. 41 look ok, 12 have errors


Test | Result | Time (s)
--- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 325.548
test_04_rvpc_privategw_static_routes | `Failure` | 178.293
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 92.678
test_02_vpc_privategw_static_routes | `Failure` | 102.706
test_01_vpc_privategw_acl | `Failure` | 42.231
test_router_dhcphosts | `Error` | 822.529
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
743.675
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 738.096
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 746.366
test_isolate_network_password_server | `Error` | 814.585
test_extendPhysicalNetworkVlan | `Error` | 0.038
test_dedicatePublicIpRange | `Error` | 0.362
test_02_routervm_iptables_policies | `Error` | 778.513
test_01_vpc_remote_access_vpn | `Error` | 0.093
test_01_snapshot_root_disk | `Error` | 0.067
test_01_single_VPC_iptables_policies | `Error` | 901.924
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 879.016
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 106.905
test_router_dns_externalipquery | Success | 0.055
test_rolepermission_lifecycle_update | Success | 7.299
test_rolepermission_lifecycle_list | Success | 7.013
test_rolepermission_lifecycle_delete | Success | 6.851
test_rolepermission_lifecycle_create | Success | 6.880
test_rolepermission_lifecycle_concurrent_updates | Success | 7.046
test_role_lifecycle_update_role_inuse | Success | 7.012
test_role_lifecycle_update | Success | 12.058
test_role_lifecycle_list | Success | 6.943
test_role_lifecycle_delete | Success | 11.962
test_role_lifecycle_create | Success | 6.901
test_role_inuse_deletion | Success | 6.846
test_role_account_acls_multiple_mgmt_servers | Success | 9.208
test_role_account_acls | Success | 9.744
test_releaseIP | Success | 249.134
test_reboot_router | Success | 596.077
test_public_ip_user_account | Success | 10.424
test_public_ip_admin_account | Success | 40.337
test_oobm_zchange_password | Success | 21.114
test_oobm_multiple_mgmt_server_ownership | Success | 7.531
test_oobm_issue_power_status | Success | 10.569
test_oobm_issue_power_soft | Success | 15.596
test_oobm_issue_power_reset | Success | 15.595
test_oobm_issue_power_on | Success | 15.600
test_oobm_issue_power_off | Success | 15.598
test_oobm_issue_power_cycle | Success | 15.605
test_oobm_enabledisable_across_clusterzones | Success | 48.831
test_oobm_enable_feature_valid | Success | 5.240
test_oobm_enable_feature_invalid | Success | 0.131
test_oobm_disable_feature_valid | Success | 5.238
test_oobm_disable_feature_invalid | Success | 0.140
test_oobm_configure_invalid_driver | Success | 0.089
test_oobm_configure_default_driver | Success | 0.121
test_oobm_background_powerstate_sync | Success | 13.570
test_nic_secondaryip_add_remove | Success | 198.753
test_network_acl | Success | 71.418
test_deployvm_userdispersing | Success | 20.802
test_deployvm_userdata_post | Success | 10.562
test_deployvm_userdata | Success | 101.361
test_deployvm_userconcentrated | Success | 20.777
test_deployvm_firstfit | Success | 60.990
test_deploy_vm_multiple | Success | 259.607
test_deploy_vm_from_iso | Success | 484.024
test_deploy_vm | Success | 0.032
test_delete_account | Success | 258.852
test_default_role_deletion | Success | 7.049
test_create_pvlan_network | Success | 5.237
test_createRegion | Success | 0.053
test_createPortablePublicIPRange | Success | 15.560
test_createPortablePublicIPAcquire | Success | 15.724
test_assign_and_removal_lb | Success | 134.166
test_advZoneVirtualRouter | Success | 0.023
test_UpdateStorageOverProvisioningFactor | Success | 0.166
test_UpdateConfigParamWithScope | Success | 0.168
test_DeployVmAntiAffinityGroup_in_project | Success | 106.838
test_DeployVmAntiAffinityGroup | Success | 71.238
test_CreateTemplateWithDuplicateName | Success | 50.652
test_10_destroy_cpvm | Success | 161.939
test_10_attachAndDetach_iso | Success | 71.713
test_09_reboot_router | Success | 40.408
test_09_expunge_vm | Success | 125.284
test_09_destroy_ssvm | Success | 164.822
test_09_delete_detached_volume | Success | 15.715
test_08_start_router | Success | 

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@abhinandanprateek this issue also affects 4.8.  Would it be possible to 
[change the base 
branch](https://github.com/blog/2224-change-the-base-branch-of-a-pull-request) 
of this PR to 4.8?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@jburwell a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1684
  
LGTM for code.

@pdion891 could you re-execute your upgrade scenario to verify that 
CLOUDSTACK-9489 is fixed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1687: Marvintests vpcofferingfix

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1687
  
@PaulAngus it looks like a bunch of commits got picked up inadvertently 
triggering a large number of unrelated changes.  Ping me, and I will help 
reduce down to the one expected change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1451: CLOUDSTACK-9319: Use timeout when applying config to...

2016-09-23 Thread insom
Github user insom commented on the issue:

https://github.com/apache/cloudstack/pull/1451
  
I got contacted directly by someone else hit by this bug and looking for a 
fix. They saw I had commits relating to their problem. What needs to happen to 
get it merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Trillian test result (tid-43)
Environment: kvm-centos7 (x2), Advanced Networking
Total time taken: 26861s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1685-t43-kvm-centos7.zip
Test completed. 40 look ok, 13 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 158.138
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 82.561
test_02_vpc_privategw_static_routes | `Failure` | 72.459
test_01_vpc_privategw_acl | `Failure` | 42.176
test_router_dhcphosts | `Error` | 812.988
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
738.063
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 745.598
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 734.523
test_isolate_network_password_server | `Error` | 819.585
test_extendPhysicalNetworkVlan | `Error` | 0.038
test_deploy_vm_from_iso | `Error` | 302.083
test_dedicatePublicIpRange | `Error` | 0.345
test_06_download_detached_volume | `Error` | 15.352
test_03_delete_template | `Error` | 5.120
test_02_routervm_iptables_policies | `Error` | 780.096
test_01_vpc_remote_access_vpn | `Error` | 0.094
test_01_snapshot_root_disk | `Error` | 0.068
test_01_single_VPC_iptables_policies | `Error` | 867.368
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 864.277
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_router_dns_guestipquery | Success | 76.891
test_router_dns_externalipquery | Success | 0.084
test_rolepermission_lifecycle_update | Success | 7.223
test_rolepermission_lifecycle_list | Success | 6.979
test_rolepermission_lifecycle_delete | Success | 6.813
test_rolepermission_lifecycle_create | Success | 6.847
test_rolepermission_lifecycle_concurrent_updates | Success | 7.026
test_role_lifecycle_update_role_inuse | Success | 6.887
test_role_lifecycle_update | Success | 12.000
test_role_lifecycle_list | Success | 6.902
test_role_lifecycle_delete | Success | 11.919
test_role_lifecycle_create | Success | 6.889
test_role_inuse_deletion | Success | 6.824
test_role_account_acls_multiple_mgmt_servers | Success | 9.323
test_role_account_acls | Success | 9.492
test_releaseIP | Success | 244.089
test_reboot_router | Success | 394.832
test_public_ip_user_account | Success | 10.353
test_public_ip_admin_account | Success | 40.342
test_oobm_zchange_password | Success | 20.631
test_oobm_multiple_mgmt_server_ownership | Success | 24.638
test_oobm_issue_power_status | Success | 10.567
test_oobm_issue_power_soft | Success | 10.568
test_oobm_issue_power_reset | Success | 15.595
test_oobm_issue_power_on | Success | 15.604
test_oobm_issue_power_off | Success | 15.605
test_oobm_issue_power_cycle | Success | 15.610
test_oobm_enabledisable_across_clusterzones | Success | 58.883
test_oobm_enable_feature_valid | Success | 5.233
test_oobm_enable_feature_invalid | Success | 0.136
test_oobm_disable_feature_valid | Success | 5.239
test_oobm_disable_feature_invalid | Success | 0.144
test_oobm_configure_invalid_driver | Success | 0.095
test_oobm_configure_default_driver | Success | 0.110
test_oobm_background_powerstate_sync | Success | 13.944
test_nic_secondaryip_add_remove | Success | 193.780
test_network_acl | Success | 61.287
test_deployvm_userdispersing | Success | 20.697
test_deployvm_userdata_post | Success | 10.453
test_deployvm_userdata | Success | 60.833
test_deployvm_userconcentrated | Success | 21.349
test_deployvm_firstfit | Success | 55.816
test_deploy_vm_multiple | Success | 243.913
test_deploy_vm | Success | 0.029
test_delete_account | Success | 263.999
test_default_role_deletion | Success | 6.984
test_create_pvlan_network | Success | 5.251
test_createRegion | Success | 0.047
test_createPortablePublicIPRange | Success | 15.431
test_createPortablePublicIPAcquire | Success | 15.761
test_assign_and_removal_lb | Success | 133.933
test_advZoneVirtualRouter | Success | 0.024
test_UpdateStorageOverProvisioningFactor | Success | 0.149
test_UpdateConfigParamWithScope | Success | 0.160
test_DeployVmAntiAffinityGroup_in_project | Success | 96.628
test_DeployVmAntiAffinityGroup | Success | 61.088
test_CreateTemplateWithDuplicateName | Success | 60.744
test_10_destroy_cpvm | Success | 131.660
test_10_attachAndDetach_iso | Success | 71.662
test_09_reboot_router | Success | 35.357
test_09_expunge_vm | Success | 125.265
test_09_destroy_ssvm | Success | 168.685
test_09_delete_detached_volume | Success | 15.724
test_08_start_router | Success | 30.320

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@jburwell a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
LGTM based on code review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-23 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@milamberspace to pile onto @rhtyd's comment, I would like to get this 
change into 4.10.0.0 which freezes Sunday (25 Sept 2016).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Trillian test result (tid-39)
Environment: xenserver-65sp1 (x2), Advanced Networking
Total time taken: 31973s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1638-t39-xenserver-65sp1.zip
Test completed. 37 look ok, 15 have errors


Test | Result | Time (s)
--- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 545.505
test_04_rvpc_privategw_static_routes | `Failure` | 344.960
test_04_rvpc_network_garbage_collector_nics | `Failure` | 631.797
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 188.289
test_02_vpc_privategw_static_routes | `Failure` | 188.330
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 548.016
test_01_vpc_privategw_acl | `Failure` | 82.568
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 542.792
test_router_dhcphosts | `Error` | 765.726
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
755.787
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 751.149
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 741.637
test_isolate_network_password_server | `Error` | 753.384
test_extendPhysicalNetworkVlan | `Error` | 0.040
test_dedicatePublicIpRange | `Error` | 0.356
test_04_extract_template | `Error` | 5.110
test_03_delete_template | `Error` | 5.109
test_02_routervm_iptables_policies | `Error` | 846.988
test_01_vpc_remote_access_vpn | `Error` | 0.096
test_01_test_vm_volume_snapshot | `Error` | 126.373
test_01_single_VPC_iptables_policies | `Error` | 914.058
test_01_primary_storage_iscsi | `Error` | 0.114
test_01_create_template | `Error` | 50.562
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 826.959
ContextSuite context=TestDeployvGPUenabledVM>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_rolepermission_lifecycle_update | Success | 7.453
test_rolepermission_lifecycle_list | Success | 7.036
test_rolepermission_lifecycle_delete | Success | 6.776
test_rolepermission_lifecycle_create | Success | 6.822
test_rolepermission_lifecycle_concurrent_updates | Success | 6.936
test_role_lifecycle_update_role_inuse | Success | 6.871
test_role_lifecycle_update | Success | 11.909
test_role_lifecycle_list | Success | 6.848
test_role_lifecycle_delete | Success | 11.909
test_role_lifecycle_create | Success | 6.886
test_role_inuse_deletion | Success | 7.100
test_role_account_acls_multiple_mgmt_servers | Success | 9.455
test_role_account_acls | Success | 10.000
test_releaseIP | Success | 259.302
test_reboot_router | Success | 586.886
test_public_ip_user_account | Success | 10.779
test_public_ip_admin_account | Success | 40.336
test_oobm_zchange_password | Success | 20.631
test_oobm_multiple_mgmt_server_ownership | Success | 12.574
test_oobm_issue_power_status | Success | 10.567
test_oobm_issue_power_soft | Success | 15.608
test_oobm_issue_power_reset | Success | 15.609
test_oobm_issue_power_on | Success | 15.609
test_oobm_issue_power_off | Success | 15.614
test_oobm_issue_power_cycle | Success | 15.655
test_oobm_enabledisable_across_clusterzones | Success | 48.612
test_oobm_enable_feature_valid | Success | 5.211
test_oobm_enable_feature_invalid | Success | 0.148
test_oobm_disable_feature_valid | Success | 5.266
test_oobm_disable_feature_invalid | Success | 0.147
test_oobm_configure_invalid_driver | Success | 0.099
test_oobm_configure_default_driver | Success | 0.105
test_oobm_background_powerstate_sync | Success | 13.874
test_nic_secondaryip_add_remove | Success | 194.080
test_network_acl | Success | 111.698
test_deployvm_userdispersing | Success | 40.853
test_deployvm_userdata_post | Success | 20.583
test_deployvm_userdata | Success | 106.307
test_deployvm_userconcentrated | Success | 45.987
test_deployvm_firstfit | Success | 151.465
test_deploy_vm_multiple | Success | 168.246
test_deploy_vm_from_iso | Success | 313.358
test_deploy_vm | Success | 0.029
test_delete_account | Success | 309.896
test_default_role_deletion | Success | 6.990
test_create_pvlan_network | Success | 5.277
test_createRegion | Success | 0.049
test_createPortablePublicIPRange | Success | 15.435
test_createPortablePublicIPAcquire | Success | 15.744
test_assign_and_removal_lb | Success | 148.943
test_advZoneVirtualRouter | Success | 0.025
test_UpdateStorageOverProvisioningFactor | Success | 0.175
test_UpdateConfigParamWithScope | Success | 0.171
test_DeployVmAntiAffinityGroup_in_project | Success | 187.396
test_DeployVmAntiAffinityGroup | Success | 141.693
test_CreateTemplateWithDuplicateName 

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1669
  
@milamberspace since this changes the way translations are consumed, would 
you help review/test this? Thanks. FYI - this does not change how translation 
workflow works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1638
  
Trillian test result (tid-41)
Environment: kvm-centos6 (x2), Advanced Networking
Total time taken: 28228s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1638-t41-kvm-centos6.zip
Test completed. 41 look ok, 11 have errors


Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 178.204
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 92.561
test_02_vpc_privategw_static_routes | `Failure` | 102.697
test_01_vpc_privategw_acl | `Failure` | 52.308
test_router_dhcphosts | `Error` | 814.345
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 
741.824
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 736.817
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 726.896
test_isolate_network_password_server | `Error` | 818.773
test_extendPhysicalNetworkVlan | `Error` | 0.035
test_dedicatePublicIpRange | `Error` | 0.326
test_02_routervm_iptables_policies | `Error` | 777.315
test_01_vpc_remote_access_vpn | `Error` | 0.086
test_01_snapshot_root_disk | `Error` | 0.055
test_01_single_VPC_iptables_policies | `Error` | 894.418
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 880.686
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_rolepermission_lifecycle_update | Success | 7.227
test_rolepermission_lifecycle_list | Success | 7.099
test_rolepermission_lifecycle_delete | Success | 6.869
test_rolepermission_lifecycle_create | Success | 6.880
test_rolepermission_lifecycle_concurrent_updates | Success | 7.062
test_role_lifecycle_update_role_inuse | Success | 6.921
test_role_lifecycle_update | Success | 12.501
test_role_lifecycle_list | Success | 7.207
test_role_lifecycle_delete | Success | 12.195
test_role_lifecycle_create | Success | 6.925
test_role_inuse_deletion | Success | 7.257
test_role_account_acls_multiple_mgmt_servers | Success | 9.263
test_role_account_acls | Success | 9.897
test_releaseIP | Success | 259.053
test_reboot_router | Success | 429.910
test_public_ip_user_account | Success | 10.459
test_public_ip_admin_account | Success | 41.007
test_oobm_zchange_password | Success | 20.632
test_oobm_multiple_mgmt_server_ownership | Success | 18.606
test_oobm_issue_power_status | Success | 10.563
test_oobm_issue_power_soft | Success | 15.591
test_oobm_issue_power_reset | Success | 15.606
test_oobm_issue_power_on | Success | 15.598
test_oobm_issue_power_off | Success | 15.597
test_oobm_issue_power_cycle | Success | 10.571
test_oobm_enabledisable_across_clusterzones | Success | 58.473
test_oobm_enable_feature_valid | Success | 5.199
test_oobm_enable_feature_invalid | Success | 0.115
test_oobm_disable_feature_valid | Success | 5.229
test_oobm_disable_feature_invalid | Success | 0.138
test_oobm_configure_invalid_driver | Success | 0.091
test_oobm_configure_default_driver | Success | 0.104
test_oobm_background_powerstate_sync | Success | 21.644
test_nic_secondaryip_add_remove | Success | 204.213
test_network_acl | Success | 66.183
test_deployvm_userdispersing | Success | 20.857
test_deployvm_userdata_post | Success | 10.519
test_deployvm_userdata | Success | 55.930
test_deployvm_userconcentrated | Success | 20.746
test_deployvm_firstfit | Success | 55.864
test_deploy_vm_multiple | Success | 263.750
test_deploy_vm_from_iso | Success | 363.769
test_deploy_vm | Success | 0.026
test_delete_account | Success | 263.904
test_default_role_deletion | Success | 7.114
test_create_pvlan_network | Success | 5.258
test_createRegion | Success | 0.042
test_createPortablePublicIPRange | Success | 15.405
test_createPortablePublicIPAcquire | Success | 15.672
test_assign_and_removal_lb | Success | 133.964
test_advZoneVirtualRouter | Success | 0.021
test_UpdateStorageOverProvisioningFactor | Success | 0.157
test_UpdateConfigParamWithScope | Success | 0.161
test_DeployVmAntiAffinityGroup_in_project | Success | 96.771
test_DeployVmAntiAffinityGroup | Success | 71.300
test_CreateTemplateWithDuplicateName | Success | 45.538
test_10_destroy_cpvm | Success | 162.134
test_10_attachAndDetach_iso | Success | 71.692
test_09_reboot_router | Success | 40.373
test_09_expunge_vm | Success | 125.260
test_09_destroy_ssvm | Success | 164.008
test_09_delete_detached_volume | Success | 15.710
test_08_start_router | Success | 35.362
test_08_resize_volume | Success | 15.430
test_08_reboot_cpvm | Success | 132.025
test_08_migrate_vm | Success | 41.716

[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Trillian test result (tid-44)
Environment: xenserver-65sp1 (x2), Advanced Networking
Total time taken: 18399s
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1685-t44-xenserver-65sp1.zip
Test completed. 20 look ok, 33 have errors


Test | Result | Time (s)
--- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 254.915
test_04_rvpc_privategw_static_routes | `Failure` | 339.528
test_04_rvpc_network_garbage_collector_nics | `Failure` | 249.125
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 168.259
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 218.894
test_02_vpc_privategw_static_routes | `Failure` | 158.350
test_02_redundant_VPC_default_routes | `Failure` | 269.457
test_02_VPC_default_routes | `Failure` | 143.337
test_01_vpc_privategw_acl | `Failure` | 92.501
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 228.907
test_01_VPC_nics_after_destroy | `Failure` | 143.314
test_releaseIP | `Error` | 107.706
test_reboot_router | `Error` | 132.960
test_oobm_enabledisable_across_clusterzones | `Error` | 63.518
test_nic_secondaryip_add_remove | `Error` | 112.876
test_network_acl | `Error` | 141.886
test_extendPhysicalNetworkVlan | `Error` | 0.039
test_deployvm_userdispersing | `Error` | 30.675
test_deployvm_userdata_post | `Error` | 30.607
test_deployvm_userdata | `Error` | 137.080
test_deployvm_userconcentrated | `Error` | 30.700
test_deployvm_firstfit | `Error` | 111.526
test_delete_account | `Error` | 127.885
test_dedicatePublicIpRange | `Error` | 0.374
test_DeployVmAntiAffinityGroup_in_project | `Error` | 111.419
test_DeployVmAntiAffinityGroup | `Error` | 121.282
test_05_rvpc_multi_tiers | `Error` | 300.578
test_04_rvpc_network_garbage_collector_nics | `Error` | 299.832
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 259.561
test_03_RVR_Network_check_router_state | `Error` | 249.283
test_02_routervm_iptables_policies | `Error` | 126.227
test_02_redundant_VPC_default_routes | `Error` | 320.325
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 
101.125
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 
255.132
test_01_vpc_site2site_vpn | `Error` | 495.052
test_01_vpc_remote_access_vpn | `Error` | 0.103
test_01_test_vm_volume_snapshot | `Error` | 348.541
test_01_single_VPC_iptables_policies | `Error` | 152.210
test_01_single_VPC_iptables_policies | `Error` | 126.743
test_01_redundant_vpc_site2site_vpn | `Error` | 676.207
test_01_primary_storage_iscsi | `Error` | 0.107
test_01_nic | `Error` | 103.198
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 101.176
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 274.603
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 254.000
ContextSuite context=TestVolumes>:setup | `Error` | 0.000
ContextSuite context=TestVmSnapshot>:setup | `Error` | 718.098
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.000
ContextSuite context=TestTemplates>:setup | `Error` | 0.000
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.000
ContextSuite context=TestServiceOfferings>:setup | `Error` | 133.407
ContextSuite context=TestScaleVm>:setup | `Error` | 0.000
ContextSuite context=TestRouterServices>:setup | `Error` | 0.000
ContextSuite context=TestRouterRules>:setup | `Error` | 215.412
ContextSuite context=TestRouterDns>:setup | `Error` | 0.000
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.000
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.000
ContextSuite context=TestPortForwarding>:setup | `Error` | 245.635
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.000
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.000
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 
0.000
ContextSuite context=TestDeployvGPUenabledVM>:setup | `Error` | 0.000
ContextSuite context=TestDeployVM>:setup | `Error` | 0.000
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.000
test_rolepermission_lifecycle_update | Success | 7.653
test_rolepermission_lifecycle_list | Success | 7.060
test_rolepermission_lifecycle_delete | Success | 6.979
test_rolepermission_lifecycle_create | Success | 7.294
test_rolepermission_lifecycle_concurrent_updates | Success | 7.693
test_role_lifecycle_update_role_inuse | Success | 7.293
test_role_lifecycle_update | Success | 12.961
test_role_lifecycle_list | Success | 7.032

[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

2016-09-23 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
@rhtyd I think you meant guest_os_type not guest_os_id. In this case the 
issue is not only that it returns ID instead of UUID but also that it doesn't 
return ID of os type. In the sample output ostypeid":12 is not correct OS type 
which is supposed to be 1 ( CentOs). The right response seems to be
userVmResponse.setOsTypeId(userVm.getGuestType().toString());
vs
userVmResponse.setOsTypeId(userVm.getGuestOsUuid());



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

2016-09-23 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
@rhtyd Somehow it works fine without this patch
curl 
"http://localhost:8096//client/api?command=listVirtualMachines=true=json;

{"listvirtualmachinesresponse":{"count":1,"virtualmachine":[{"id":"beb85d73-17cd-4de5-8c35-61f70d88e5e1","name":"TEST-3DGPU-NICO","displayname":"TEST-3DGPU-NICO","account":"admin","userid":"d557133a-3fcc-11e5-9c45-005056ad45b7","username":"admin","domainid":"5a7ffa07-3fca-11e5-9c45-005056ad45b7","domain":"ROOT","created":"2016-08-30T16:21:45-0700","state":"Stopped","haenable":false,"zoneid":"0d074f25-ed31-482f-8bc5-44c9314fc417","zonename":"ECS-NSX","templateid":"d6584e60-d500-40cd-9a33-1700a59c464c","templatename":"VMXNET3
 template-287NCX","templatedisplaytext":"VMXNET3 
Template","passwordenabled":false,"serviceofferingid":"0b9dab64-60ec-4c19-8a36-8725660d37d1","serviceofferingname":"Tiny
 Instance","cpunumber":1,"cpuspeed":100,"memory":128,"**## 
guestosid":"5aadaacc-3fca-11e5-9c45-005056ad45b7",**"rootdeviceid":0,"rootdevicetype":"ROOT","securitygroup":[],"nic":[{"id":"08e0b3fe-219f-46bb-a766-70717a15a7fd","networkid":"c05a5c09-eb29-49bc-9cfd-705becc7a909","networkname":"VLAN13"
 
,"netmask":"255.255.255.0","gateway":"10.140.13.1","ipaddress":"10.140.13.81","isolationuri":"vlan://13","broadcasturi":"vlan://13","traffictype":"Guest","type":"Shared","isdefault":true,"macaddress":"06:0a:d0:00:36:d9","secondaryip":[]}],"hypervisor":"VMware","instancename":"i-2-9253-VM","affinitygroup":[],"displayvm":true,"isdynamicallyscalable":false,"ostypeid":12,"tags":[]}]}}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

2016-09-23 Thread murali-reddy
Github user murali-reddy commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
@cloudmonger error seems to be due to 'physicalnetwork 200 has allocated 
vnets in the range 731-732' This is same error seen in test run. After test run 
in done, please see if there is network that was not cleaned and reason for 
that.

This patch is contained to VPN user add/delete functionality, unrelated to 
the error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

2016-09-23 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1680
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 103
 Hypervisor xenserver
 NetworkType Advanced
 Passed=102
 Failed=1
 Skipped=4

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_ssvm.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


vmware macchinina template

2016-09-23 Thread Paul Angus
Hi Nux,

How are you doing?

I'm fixing the marvin tests to point to 
http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.ova

But Serg points out that the vmware template doesn't have an E1000 (intel 
pro/1000) driver in it so can't enable interfaces.
Could you fix or let me know how I can build a template to pass back to you pls.



Kind regards,

Paul Angus


paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack pull request #1687: Marvintests vpcofferingfix

2016-09-23 Thread PaulAngus
GitHub user PaulAngus opened a pull request:

https://github.com/apache/cloudstack/pull/1687

Marvintests vpcofferingfix

It appears that original code did not expect there to be an alternate 
default VPC offering (Nuage) .
VPC selection uses isdefault=True which selects the Nuage Network offering, 
stopping the test from being run.
Fix was to look for name="Default VPC Offering" instead.

Replaces PR #1652  (same content, differenet branch)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 
marvintests-vpcofferingfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1687


commit 456680dbb2328e2ac613d9ea422351a06a412601
Author: Will Stevens 
Date:   2016-05-11T04:08:44Z

Merge pull request #880 from SudharmaJain/cs-8901

CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads The 
thread pool was hardcoded to use 8 threads,
com.cloud.template.TemplateManagerImpl.configure(String, Map):
_preloadExecutor = Executors.newFixedThreadPool(8, new 
NamedThreadFactory("Template-Preloader"));

Added the change to pick threadpool size from configuration.

* pr/880:
  CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads

Signed-off-by: Will Stevens 

commit 95abb6efc350189cb2be0cfd655c1205ced42155
Author: Rohit Yadav 
Date:   2016-04-21T10:13:04Z

CLOUDSTACK-9361: Centrally handle API validations

Validate API arguments based on annotations. Introduces:
- NotNullOrEmpty: for doing null and empty string checks
- PositiveNumber: number > 0 (natural number)

Signed-off-by: Rohit Yadav 

commit 4347776ac6ef9ae86fb016862f4a6b2376f8319a
Author: Rohit Yadav 
Date:   2016-03-15T08:16:06Z

CLOUDSTACK-8562: DB-Backed Dynamic Role Based API Access Checker

This feature allows root administrators to define new roles and associate 
API
permissions to them.

A limited form of role-based access control for the CloudStack management 
server
API is provided through a properties file, commands.properties, embedded in 
the
WAR distribution. Therefore, customizing API permissions requires unpacking 
the
distribution and modifying this file consistently on all servers. The old 
system
also does not permit the specification of additional roles.

FS:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+Role+Based+API+Access+Checker+for+CloudStack

DB-Backed Dynamic Role Based API Access Checker for CloudStack brings 
following
changes, features and use-cases:
- Moves the API access definitions from commands.properties to the mgmt 
server DB
- Allows defining custom roles (such as a read-only ROOT admin) beyond the
  current set of four (4) roles
- All roles will resolve to one of the four known roles types (Admin, 
Resource
  Admin, Domain Admin and User) which maintains this association by 
requiring
  all new defined roles to specify a role type.
- Allows changes to roles and API permissions per role at runtime including 
additions or
  removal of roles and/or modifications of permissions, without the need
  of restarting management server(s)

Upgrade/installation notes:
- The feature will be enabled by default for new installations, existing
  deployments will continue to use the older static role based api access 
checker
  with an option to enable this feature
- During fresh installation or upgrade, the upgrade paths will add four 
default
  roles based on the four default role types
- For ease of migration, at the time of upgrade commands.properties will be 
used
  to add existing set of permissions to the default roles. cloud.account
  will have a new role_id column which will be populated based on default 
roles
  as well

Dynamic-roles migration tool: scripts/util/migrate-dynamicroles.py
- Allows admins to migrate to the dynamic role based checker at a future 
date
- Performs a harder one-way migrate and update
- Migrates rules from existing commands.properties file into db and 
deprecates it
- Enables an internal hidden switch to enable dynamic role based checker 
feature

Signed-off-by: Rohit Yadav 

commit afcbd270b2eb9086a76dda83c0f9ba2e034b0afd
Author: Rohit Yadav 
Date:   2016-04-29T19:10:47Z

CLOUDSTACK-8562: Deprecate commands.properties

- Removes commands.properties file
- Fixes apidocs 

Re: Request for comments: Moving to Spring 4 and Java 8

2016-09-23 Thread John Burwell
All,

Reviving this thread as it would be a Good Thing(tm) to get Spring 4 merged for 
4.10.0.0.  Based on Rohit’s original question, it appears that the only issue 
is F5 on Java8 (not on Java7).  Is there someone available with F5 knowledge 
who can investigate it?  If not, would it be acceptable to limit F5 users of 
4.10.0.0 to Java7 due to this issue? 

Thanks,
-John

> 
john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

On Aug 12, 2016, at 8:14 AM, Rohit Yadav  wrote:
> 
> All,
> 
> 
> It's about time to migrate master to Java 8 JDK and Spring 4. Please help 
> review the following PRs:
> 
> https://github.com/apache/cloudstack/pull/1638
> 
> 
> There are three outstanding issues that I need help and feedback on:
> 
> 
> 1. F5 plugin fails to build due to issue likely in the axis dependency 
> library, I've disabled it from the build now. Do we have a F5 
> developer/maintainer who can look at it.
> 
> 
> 2. Two unit tests failures due to Spring 4 migration:
> 
> com/cloud/vm/DeploymentPlanningManagerImplTest.java
> 
> com/globo/globodns/cloudstack/resource/GloboDnsResourceTest.java
> 
> 
> Do we have anyone who can help fix the above tests? Deployment planner 
> developers, or globo-dns plugin maintainers?
> 
> 
> 3. In general, the end-to-end testing of plugins. There may be plugins which 
> are not maintained or used anymore, we need discuss how to deal with them 
> moving forward. As a first step we may want to start disable them from the 
> build, especially those failing builds.
> 
> 
> Comments, feedback? Thanks.
> 
> 
> Regards.
> 
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
> 
> 
> 



[GitHub] cloudstack issue #1663: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS reflectio...

2016-09-23 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1663
  
@s-seitz the fix should work for newly deployed VRs, for existing VR there 
may be existing rules or chains blocking the intended fix. Are you getting 
issues or seeing the same behaviour with new VRs? If yes, can you send a fix. 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1686: CLOUDSTACK-9507: ListVM response's guest_os id shoul...

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1686
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1686: CLOUDSTACK-9507: ListVM response's guest_os i...

2016-09-23 Thread rhtyd
GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1686

CLOUDSTACK-9507: ListVM response's guest_os id should be a UUID

The listVirtualMachines API response contains a guest os_type_id field which
is an integer, and therefore not useful or easily consumable. This fixes and
migrates the returned type from an id (integer) to a uuid (string). It makes
the response consistent with other API responses such as those of 
listTemplates
and allow end users to consume this uuid.

/cc @jburwell @karuturi -- this is a minor change. It may be debatable if 
this break api response compatibility, please advise.

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack listvm-ostype-uuidfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1686






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208194
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtModifySshKeysCommandWrapper.java
 ---
@@ -108,7 +108,7 @@ public Answer execute(final ModifySshKeysCommand 
command, final LibvirtComputing
 result = "Write file " + sshprvkeypath + ":" + 
e.toString();
 s_logger.debug(result);
 }
-final Script script = new Script("chmod", 
libvirtComputingResource.getTimeout(), s_logger);
+final Script script = new Script("chmod", 
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208106
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3229,7 +3230,7 @@ protected boolean post_default_network_rules(final 
Connect conn, final String vm
 final String brname = intf.getBrName();
 final String vif = intf.getDevName();
 
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208121
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3255,7 +3256,7 @@ public boolean 
configureDefaultNetworkRulesForSystemVm(final Connect conn, final
 return false;
 }
 
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208151
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3300,7 +3301,7 @@ public boolean 
configureNetworkRulesVMSecondaryIP(final Connect conn, final Stri
 return false;
 }
 
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208295
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java
 ---
@@ -87,7 +88,7 @@ public Answer execute(final PvlanSetupCommand command, 
final LibvirtComputingRes
 } else if (command.getType() == PvlanSetupCommand.Type.VM) {
 final String ovsPvlanVmPath = 
libvirtComputingResource.getOvsPvlanVmPath();
 
-final Script script = new Script(ovsPvlanVmPath, timeout, 
s_logger);
+final Script script = new Script(ovsPvlanVmPath, 
timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208208
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsCreateTunnelCommandWrapper.java
 ---
@@ -40,14 +40,11 @@ public Answer execute(final OvsCreateTunnelCommand 
command, final LibvirtComputi
 try {
 if 
(!libvirtComputingResource.findOrCreateTunnelNetwork(bridge)) {
 s_logger.debug("Error during bridge setup");
-return new OvsCreateTunnelAnswer(command, false,
-"Cannot create network", bridge);
+return new OvsCreateTunnelAnswer(command, false, "Cannot 
create network", bridge);
 }
 
-
libvirtComputingResource.configureTunnelNetwork(command.getNetworkId(), 
command.getFrom(),
-command.getNetworkName());
-
-final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout(), s_logger);
+
libvirtComputingResource.configureTunnelNetwork(command.getNetworkId(), 
command.getFrom(), command.getNetworkName());
+final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208282
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java
 ---
@@ -58,11 +59,11 @@ public Answer execute(final PvlanSetupCommand command, 
final LibvirtComputingRes
 String result = null;
 try {
 final String guestBridgeName = 
libvirtComputingResource.getGuestBridgeName();
-final int timeout = libvirtComputingResource.getTimeout();
+final Duration timeout = libvirtComputingResource.getTimeout();
 
 if (command.getType() == PvlanSetupCommand.Type.DHCP) {
 final String ovsPvlanDhcpHostPath = 
libvirtComputingResource.getOvsPvlanDhcpHostPath();
-final Script script = new Script(ovsPvlanDhcpHostPath, 
timeout, s_logger);
+final Script script = new Script(ovsPvlanDhcpHostPath, 
timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208251
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsVpcPhysicalTopologyConfigCommandWrapper.java
 ---
@@ -36,7 +36,7 @@
 @Override
 public Answer execute(final OvsVpcPhysicalTopologyConfigCommand 
command, final LibvirtComputingResource libvirtComputingResource) {
 try {
-final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout(), s_logger);
+final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208171
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3327,7 +3328,7 @@ public boolean cleanupRules() {
 }
 
 public String getRuleLogsForVms() {
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208135
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3273,7 +3274,7 @@ public boolean addNetworkRules(final String vmName, 
final String vmId, final Str
 }
 
 final String newRules = rules.replace(" ", ";");
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208262
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsVpcRoutingPolicyConfigCommandWrapper.java
 ---
@@ -36,7 +36,7 @@
 @Override
 public Answer execute(final OvsVpcRoutingPolicyConfigCommand command, 
final LibvirtComputingResource libvirtComputingResource) {
 try {
-final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout(), s_logger);
+final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208159
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3317,7 +3318,7 @@ public boolean cleanupRules() {
 if (!_canBridgeFirewall) {
 return false;
 }
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208231
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsDestroyTunnelCommandWrapper.java
 ---
@@ -42,7 +42,7 @@ public Answer execute(final OvsDestroyTunnelCommand 
command, final LibvirtComput
 return new Answer(command, false, "No network found");
 }
 
-final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout(), s_logger);
+final Script scriptCommand = new 
Script(libvirtComputingResource.getOvsTunnelPath(), 
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208089
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3197,7 +3198,7 @@ public boolean defaultNetworkRules(final Connect 
conn, final String vmName, fina
 final String brname = intf.getBrName();
 final String vif = intf.getDevName();
 
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208062
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3150,7 +3151,7 @@ protected long getMemoryFreeInKBs(Domain dm) throws 
LibvirtException {
 }
 
 private boolean canBridgeFirewall(final String prvNic) {
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208042
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -2973,7 +2974,7 @@ public Domain getDomain(final Connect conn, final 
String vmName) throws LibvirtE
 }
 
 private String executeBashScript(final String script) {
-final Script command = new Script("/bin/bash", _timeout, s_logger);
+final Script command = new Script("/bin/bash", 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80208075
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -3170,7 +3171,7 @@ public boolean destroyNetworkRulesForVM(final Connect 
conn, final String vmName)
 final InterfaceDef intf = intfs.get(0);
 vif = intf.getDevName();
 }
-final Script cmd = new Script(_securityGroupPath, _timeout, 
s_logger);
+final Script cmd = new Script(_securityGroupPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80207993
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1319,7 +1320,7 @@ public Answer executeRequest(final Command cmd) {
 public synchronized boolean destroyTunnelNetwork(final String bridge) {
 findOrCreateTunnelNetwork(bridge);
 
-final Script cmd = new Script(_ovsTunnelPath, _timeout, s_logger);
+final Script cmd = new Script(_ovsTunnelPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80207999
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1373,7 +1374,7 @@ public synchronized boolean 
configureTunnelNetwork(final long networkId,
 }
 }
 if (!configured) {
-final Script cmd = new Script(_ovsTunnelPath, _timeout, 
s_logger);
+final Script cmd = new Script(_ovsTunnelPath, 
_timeout.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1678#discussion_r80207941
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -279,12 +280,12 @@
 
 @Override
 public ExecutionResult executeInVR(final String routerIp, final String 
script, final String args) {
-return executeInVR(routerIp, script, args, _timeout / 1000);
+return executeInVR(routerIp, script, args, _timeout);
 }
 
 @Override
-public ExecutionResult executeInVR(final String routerIp, final String 
script, final String args, final int timeout) {
-final Script command = new Script(_routerProxyPath, timeout * 
1000, s_logger);
+public ExecutionResult executeInVR(final String routerIp, final String 
script, final String args, final Duration milli) {
+final Script command = new Script(_routerProxyPath, 
milli.getMillis(), s_logger);
--- End diff --

Scripts is an external package, hope they will upgrade to Duration after 
Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-23 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1685
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1685: IGNORE this PR

2016-09-23 Thread rhtyd
GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1685

IGNORE this PR

This tests @blueorangutan and Trillian job as a ref for 4.9 branch.

@blueorangutan package

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.9-refbotrl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1685


commit 1d231626951351d5d5130a027d6b04969c91f15e
Author: Rohit Yadav 
Date:   2016-09-23T08:24:19Z

README: ignorable change

This tests @blueorangutan and Trillian job as a ref for 4.9 branch.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-23 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
@murali-reddy Makes sense to get fresh listing of virtual NICs in next 
iteration as the first iteration might have missed the hot-plugged virtual NIC 
(for VPC tier being configured). Though one side effect is we will loop through 
all the virtual NICs, except the newly hot-plugged NIC, at least one more time. 
Can you please see if we can avoid repeating the command 'ip address show' 
for the virtual NICs that were already verified to be not matching.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1681
  
The fix looks like the correct thing to do. 
@muali-reddy LGTM for code review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---