Re: IP Address Discrepancy with VMware

[Tutkowski, Mike]

Thanks, Paul!

> On Jan 11, 2018, at 12:49 AM, Paul Angus  wrote:
> 
> I'll have a look @ mike
> 
> 
> 
> Kind regards,
> 
> Paul Angus
> 
> paul.an...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
> 
> 
> 
> 
> -Original Message-
> From: Tutkowski, Mike [mailto:mike.tutkow...@netapp.com] 
> Sent: 11 January 2018 07:31
> To: dev@cloudstack.apache.org
> Subject: IP Address Discrepancy with VMware
> 
> Hi,
> 
> While I was running some tests related to 4.11 tonight, I noticed the 
> following discrepancy with regards to the IP address given to a VM of mine:
> 
> https://imgur.com/3ODXHNe
> 
> According to CloudStack, the IP address should be 10.117.40.28. However, when 
> I run ifconfig, I get 10.117.40.115.
> 
> In this situation, I’m running only with VMware (no other hypervisor type in 
> use) in a Basic Zone where the root disk of the VM is on NFS.
> 
> Anyone else able to reproduce this issue?
> 
> Thanks,
> Mike

RE: IP Address Discrepancy with VMware

[Paul Angus]

I'll have a look @ mike



Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: Tutkowski, Mike [mailto:mike.tutkow...@netapp.com] 
Sent: 11 January 2018 07:31
To: dev@cloudstack.apache.org
Subject: IP Address Discrepancy with VMware

Hi,

While I was running some tests related to 4.11 tonight, I noticed the following 
discrepancy with regards to the IP address given to a VM of mine:

https://imgur.com/3ODXHNe

According to CloudStack, the IP address should be 10.117.40.28. However, when I 
run ifconfig, I get 10.117.40.115.

In this situation, I’m running only with VMware (no other hypervisor type in 
use) in a Basic Zone where the root disk of the VM is on NFS.

Anyone else able to reproduce this issue?

Thanks,
Mike

IP Address Discrepancy with VMware

[Tutkowski, Mike]

Hi,

While I was running some tests related to 4.11 tonight, I noticed the following 
discrepancy with regards to the IP address given to a VM of mine:

https://imgur.com/3ODXHNe

According to CloudStack, the IP address should be 10.117.40.28. However, when I 
run ifconfig, I get 10.117.40.115.

In this situation, I’m running only with VMware (no other hypervisor type in 
use) in a Basic Zone where the root disk of the VM is on NFS.

Anyone else able to reproduce this issue?

Thanks,
Mike

Re: Which StringUtils to use?

[Ron Wheeler]

Certainly better to find the references and remove them if you can get 
that done in a single effort.


Just a technical question: Could one not just add the Warning to the 
constructor?

Might have to create a null (log warning only) constructor.

Ron

On 10/01/2018 3:58 PM, Daan Hoogland wrote:

We can add log messages to each of the methods in StringUtils but I do not
think that is a good way to go. Any method you touch you can reform or
remove anyhow.

On Wed, Jan 10, 2018 at 9:51 PM, Ron Wheeler  wrote:


Is it possible to mark it as deprecated and have it log a warning when
used?

Ron


On 10/01/2018 2:26 PM, Daan Hoogland wrote:


I think we could start with giving it an explicit non standard name like
CloudStackLocalStringUtils or something a little shorter. Making sure
that
we prefer for these types of utils to be imported from other projects.

On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander 
wrote:



On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:

Instead of creating a PR for that, we could do the bit by bit job

(hopefully one day we finish the job).
Every time we see a code using ACS's StringUtils, we check if it can be
replaced by Apache's one.


Yes, but that will slip from peoples attention and we will probably see

cases where people still use the old one by accident.

I've created a issue: https://issues.apache.org/jira
/browse/CLOUDSTACK-10225

I also started on some low hanging fruit as some methods in StringUtils
are not used or are very easy to replace.


Wido

On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander 


wrote:


On 01/10/2018 12:01 PM, Daan Hoogland wrote:

I'd say remove as much functionality as we can from 'our' StringUtils
and


phase them out asap.


Yes, but such a PR would be invasive and would be difficult to merge
and


also break a lot of other code.

It's not easy since it will touch a lot, but I mean, a lot of files.

Our StringUtils was a very good solution, but the Apache one is
better I
think.

Wido


On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 

wrote:

Hi,

We have com.cloud.utils.StringUtils which has a few nice functions,

but
throughout the code I also see org.apache.commons.lang.StringUtils

They both provide about the same functionality, but which one do we
prefer?

I'd say org.apache.commons.lang.StringUtils as that allows us to
remove
our own StringUtils, but we could also have 'our' StringUtils simply
be a
wrapper around org.apache.commons.lang.StringUtils

Opinions?

Wido







--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102




--
Daan


--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102







--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: Which StringUtils to use?

[Daan Hoogland]

We can add log messages to each of the methods in StringUtils but I do not
think that is a good way to go. Any method you touch you can reform or
remove anyhow.

On Wed, Jan 10, 2018 at 9:51 PM, Ron Wheeler  wrote:

> Agreed about deprecation.
> A logged WARNing would be detected during testing as well as at run-time.
>
> Ron
>
> On 10/01/2018 3:34 PM, Daan Hoogland wrote:
>
> Ron, we could but that would only log during compile-time, not on runtime.
> I am doing some analysis and commenting in Wido's ticket.
>
> On Wed, Jan 10, 2018 at 9:23 PM, Ron Wheeler  com> wrote:
>
>> Is it possible to mark it as deprecated and have it log a warning when
>> used?
>>
>> Ron
>>
>>
>> On 10/01/2018 2:26 PM, Daan Hoogland wrote:
>>
>>> I think we could start with giving it an explicit non standard name like
>>> CloudStackLocalStringUtils or something a little shorter. Making sure
>>> that
>>> we prefer for these types of utils to be imported from other projects.
>>>
>>> On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander 
>>> wrote:
>>>
>>>
 On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:

 Instead of creating a PR for that, we could do the bit by bit job
> (hopefully one day we finish the job).
> Every time we see a code using ACS's StringUtils, we check if it can be
> replaced by Apache's one.
>
>
> Yes, but that will slip from peoples attention and we will probably see
 cases where people still use the old one by accident.

 I've created a issue: https://issues.apache.org/jira
 /browse/CLOUDSTACK-10225

 I also started on some low hanging fruit as some methods in StringUtils
 are not used or are very easy to replace.


 Wido

 On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander 

> wrote:
>
>
> On 01/10/2018 12:01 PM, Daan Hoogland wrote:
>>
>> I'd say remove as much functionality as we can from 'our' StringUtils
>> and
>>
>>> phase them out asap.
>>>
>>>
>>> Yes, but such a PR would be invasive and would be difficult to merge
>>> and
>>>
>> also break a lot of other code.
>>
>> It's not easy since it will touch a lot, but I mean, a lot of files.
>>
>> Our StringUtils was a very good solution, but the Apache one is
>> better I
>> think.
>>
>> Wido
>>
>>
>> On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 
>>
>> wrote:
>>>
>>> Hi,
>>>
>>> We have com.cloud.utils.StringUtils which has a few nice functions,
 but
 throughout the code I also see org.apache.commons.lang.StringUtils

 They both provide about the same functionality, but which one do we
 prefer?

 I'd say org.apache.commons.lang.StringUtils as that allows us to
 remove
 our own StringUtils, but we could also have 'our' StringUtils simply
 be a
 wrapper around org.apache.commons.lang.StringUtils

 Opinions?

 Wido




>>>
>>>
>
>>>
>> --
>> Ron Wheeler
>> President
>> Artifact Software Inc
>> email: rwhee...@artifact-software.com
>> skype: ronaldmwheeler
>> phone: 866-970-2435, ext 102
>>
>>
>
>
> --
> Daan
>
>
> --
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwhee...@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
>
>


-- 
Daan

Re: Which StringUtils to use?

[Ron Wheeler]

Agreed about deprecation.
A logged WARNing would be detected during testing as well as at run-time.

Ron
On 10/01/2018 3:34 PM, Daan Hoogland wrote:
Ron, we could but that would only log during compile-time, not on 
runtime. I am doing some analysis and commenting in Wido's ticket.


On Wed, Jan 10, 2018 at 9:23 PM, Ron Wheeler 
> wrote:


Is it possible to mark it as deprecated and have it log a warning
when used?

Ron


On 10/01/2018 2:26 PM, Daan Hoogland wrote:

I think we could start with giving it an explicit non standard
name like
CloudStackLocalStringUtils or something a little shorter.
Making sure that
we prefer for these types of utils to be imported from other
projects.

On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander
> wrote:


On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:

Instead of creating a PR for that, we could do the bit
by bit job
(hopefully one day we finish the job).
Every time we see a code using ACS's StringUtils, we
check if it can be
replaced by Apache's one.


Yes, but that will slip from peoples attention and we will
probably see
cases where people still use the old one by accident.

I've created a issue: https://issues.apache.org/jira
/browse/CLOUDSTACK-10225

I also started on some low hanging fruit as some methods
in StringUtils
are not used or are very easy to replace.


Wido

On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander
>

wrote:


On 01/10/2018 12:01 PM, Daan Hoogland wrote:

I'd say remove as much functionality as we can
from 'our' StringUtils and

phase them out asap.


Yes, but such a PR would be invasive and would
be difficult to merge and

also break a lot of other code.

It's not easy since it will touch a lot, but I
mean, a lot of files.

Our StringUtils was a very good solution, but the
Apache one is better I
think.

Wido


On Wed, Jan 10, 2018 at 11:59 AM, Wido den
Hollander >

wrote:

Hi,

We have com.cloud.utils.StringUtils which
has a few nice functions, but
throughout the code I also see
org.apache.commons.lang.StringUtils

They both provide about the same
functionality, but which one do we
prefer?

I'd say
org.apache.commons.lang.StringUtils as
that allows us to
remove
our own StringUtils, but we could also
have 'our' StringUtils simply
be a
wrapper around
org.apache.commons.lang.StringUtils

Opinions?

Wido








-- 
Ron Wheeler

President
Artifact Software Inc
email: rwhee...@artifact-software.com

skype: ronaldmwheeler
phone: 866-970-2435, ext 102




--
Daan



--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: cloudstack Wikipedia page

[Ron Wheeler]

Can someone update the important technical sections  - Key Features, 
Supported Hypervisors and Bare Metal Hosts.

It looks like Cloudstack stopped being worked on in 2012.

Can these sections be replaced by a link to the correct CloudStack wiki 
pages so we do not have to keep updating this info?


The user list may also need updating or changed to a reference to to a 
page that is kept up to date.


I suspect that the history section captures too many details. There 
seems to be too much about the shift to Apache and whole process of 
incubation. Perhaps this process was very exciting and fresh when it was 
written but looking back from today, perhaps it is less important. 
Dropping one or 2 ideas and adding some more recent events might make sense


Is it true that Citrix has ceased involvement as it says?

Perhaps there are other companies that have made a significant 
investment in Cloudstack more recently that deserve mention.


Is it worth mentioning that there is an active community with specific 
reference to community meetings and events?


Ron

On 09/01/2018 5:58 AM, Daan Hoogland wrote:

just anonymously removed it, Giles

On Tue, Jan 9, 2018 at 11:21 AM, Giles Sirett 
wrote:


Somebody has made an edit to the cloudstack wikipedia entry

https://en.wikipedia.org/w/index.php?diff=819108440=815849996

In essence, they have changed the start of the history section to give a
history of the cloud.com domain name. I do not think that is either
relevant or appropriate to the history of cloudstack itself

Has anybody here got experience in editing on Wikipedia and able to
object/change this edit ?

I'm happy to take this task on, but have no experience in the process,
policies, etc


Kind regards
Giles


giles.sir...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue








--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: Which StringUtils to use?

[Daan Hoogland]

Ron, we could but that would only log during compile-time, not on runtime.
I am doing some analysis and commenting in Wido's ticket.

On Wed, Jan 10, 2018 at 9:23 PM, Ron Wheeler  wrote:

> Is it possible to mark it as deprecated and have it log a warning when
> used?
>
> Ron
>
>
> On 10/01/2018 2:26 PM, Daan Hoogland wrote:
>
>> I think we could start with giving it an explicit non standard name like
>> CloudStackLocalStringUtils or something a little shorter. Making sure that
>> we prefer for these types of utils to be imported from other projects.
>>
>> On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander 
>> wrote:
>>
>>
>>> On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:
>>>
>>> Instead of creating a PR for that, we could do the bit by bit job
 (hopefully one day we finish the job).
 Every time we see a code using ACS's StringUtils, we check if it can be
 replaced by Apache's one.


 Yes, but that will slip from peoples attention and we will probably see
>>> cases where people still use the old one by accident.
>>>
>>> I've created a issue: https://issues.apache.org/jira
>>> /browse/CLOUDSTACK-10225
>>>
>>> I also started on some low hanging fruit as some methods in StringUtils
>>> are not used or are very easy to replace.
>>>
>>>
>>> Wido
>>>
>>> On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander 
>>>
 wrote:


 On 01/10/2018 12:01 PM, Daan Hoogland wrote:
>
> I'd say remove as much functionality as we can from 'our' StringUtils
> and
>
>> phase them out asap.
>>
>>
>> Yes, but such a PR would be invasive and would be difficult to merge
>> and
>>
> also break a lot of other code.
>
> It's not easy since it will touch a lot, but I mean, a lot of files.
>
> Our StringUtils was a very good solution, but the Apache one is better
> I
> think.
>
> Wido
>
>
> On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 
>
> wrote:
>>
>> Hi,
>>
>> We have com.cloud.utils.StringUtils which has a few nice functions,
>>> but
>>> throughout the code I also see org.apache.commons.lang.StringUtils
>>>
>>> They both provide about the same functionality, but which one do we
>>> prefer?
>>>
>>> I'd say org.apache.commons.lang.StringUtils as that allows us to
>>> remove
>>> our own StringUtils, but we could also have 'our' StringUtils simply
>>> be a
>>> wrapper around org.apache.commons.lang.StringUtils
>>>
>>> Opinions?
>>>
>>> Wido
>>>
>>>
>>>
>>>
>>
>>

>>
> --
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwhee...@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
>
>


-- 
Daan

Re: Which StringUtils to use?

[Ron Wheeler]

Is it possible to mark it as deprecated and have it log a warning when used?

Ron

On 10/01/2018 2:26 PM, Daan Hoogland wrote:

I think we could start with giving it an explicit non standard name like
CloudStackLocalStringUtils or something a little shorter. Making sure that
we prefer for these types of utils to be imported from other projects.

On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander  wrote:



On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:


Instead of creating a PR for that, we could do the bit by bit job
(hopefully one day we finish the job).
Every time we see a code using ACS's StringUtils, we check if it can be
replaced by Apache's one.



Yes, but that will slip from peoples attention and we will probably see
cases where people still use the old one by accident.

I've created a issue: https://issues.apache.org/jira
/browse/CLOUDSTACK-10225

I also started on some low hanging fruit as some methods in StringUtils
are not used or are very easy to replace.


Wido

On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander 

wrote:



On 01/10/2018 12:01 PM, Daan Hoogland wrote:

I'd say remove as much functionality as we can from 'our' StringUtils and

phase them out asap.


Yes, but such a PR would be invasive and would be difficult to merge and

also break a lot of other code.

It's not easy since it will touch a lot, but I mean, a lot of files.

Our StringUtils was a very good solution, but the Apache one is better I
think.

Wido


On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 


wrote:

Hi,


We have com.cloud.utils.StringUtils which has a few nice functions, but
throughout the code I also see org.apache.commons.lang.StringUtils

They both provide about the same functionality, but which one do we
prefer?

I'd say org.apache.commons.lang.StringUtils as that allows us to
remove
our own StringUtils, but we could also have 'our' StringUtils simply
be a
wrapper around org.apache.commons.lang.StringUtils

Opinions?

Wido












--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: Which StringUtils to use?

[Daan Hoogland]

I think we could start with giving it an explicit non standard name like
CloudStackLocalStringUtils or something a little shorter. Making sure that
we prefer for these types of utils to be imported from other projects.

On Wed, Jan 10, 2018 at 4:26 PM, Wido den Hollander  wrote:

>
>
> On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:
>
>> Instead of creating a PR for that, we could do the bit by bit job
>> (hopefully one day we finish the job).
>> Every time we see a code using ACS's StringUtils, we check if it can be
>> replaced by Apache's one.
>>
>>
> Yes, but that will slip from peoples attention and we will probably see
> cases where people still use the old one by accident.
>
> I've created a issue: https://issues.apache.org/jira
> /browse/CLOUDSTACK-10225
>
> I also started on some low hanging fruit as some methods in StringUtils
> are not used or are very easy to replace.
>
>
> Wido
>
> On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander 
>> wrote:
>>
>>
>>>
>>> On 01/10/2018 12:01 PM, Daan Hoogland wrote:
>>>
>>> I'd say remove as much functionality as we can from 'our' StringUtils and
 phase them out asap.


 Yes, but such a PR would be invasive and would be difficult to merge and
>>> also break a lot of other code.
>>>
>>> It's not easy since it will touch a lot, but I mean, a lot of files.
>>>
>>> Our StringUtils was a very good solution, but the Apache one is better I
>>> think.
>>>
>>> Wido
>>>
>>>
>>> On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 
>>>
 wrote:

 Hi,

>
> We have com.cloud.utils.StringUtils which has a few nice functions, but
> throughout the code I also see org.apache.commons.lang.StringUtils
>
> They both provide about the same functionality, but which one do we
> prefer?
>
> I'd say org.apache.commons.lang.StringUtils as that allows us to
> remove
> our own StringUtils, but we could also have 'our' StringUtils simply
> be a
> wrapper around org.apache.commons.lang.StringUtils
>
> Opinions?
>
> Wido
>
>
>



>>
>>


-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

[Daan Hoogland]

I hope we understand each other correctly: No-one running an earlier
version then 4.11 should miss out on any functionality they are using now.

So if you use ipv6 and multiple cidrs now it must continue to work with no
loss of functionality. see my question below.

On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev 
wrote:

> Daan, yes this sounds reasonable, I suppose who would like to fix, could
> do custom build for himself...
>
> But still it should be aknowledged somehow, if you use several cidrs for
> network, don't use v6, or don't upgrade to 4.11 because things will stop
> running well.
>
​Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?


if yes; it is a blocker

if no; you might as well upgrade for other features as it doesn't work now
either.

-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

[Ivan Kudryavtsev]

Daan, yes this sounds reasonable, I suppose who would like to fix, could do
custom build for himself...

But still it should be aknowledged somehow, if you use several cidrs for
network, don't use v6, or don't upgrade to 4.11 because things will stop
running well.

11 янв. 2018 г. 1:00 пользователь "Daan Hoogland" 
написал:

Ivan,
I was composing an answer but i think we agree:

Only if that functionality worked in the past. ipv6 support is still rather
new and must be considered experimental. I think we should fix it in a
maintenance release and not block the release for it. If it was working
before and broke, it should go in. To put it less mildly, I expect more
then ACS can deliver and we can't wait until all my wishes are implemented.


On Wed, Jan 10, 2018 at 6:58 PM, Ivan Kudryavtsev 
wrote:

> Sorry, to clarify, I mean (if I correctly understand) that if someone has
> a network with several CIDRs in the basic zone and, lets say, 4.9.3
> upgraded to 4.11, which results that VMs stop getting DHCP announces for
> additional CIDRs from VR, it's a blocker thing...
>
> 2018-01-11 0:52 GMT+07:00 Ivan Kudryavtsev :
>
>> I suppose the bug, reported by Wido prevents adding additional CIDRs to
>> Network if IPv6 configured? If so, it's definitely a blocker thing because
>> everyone expects it's possible, because the function is implemented in ACS.
>>
>> 2018-01-11 0:41 GMT+07:00 Rohit Yadav :
>>
>>> +1 what Dasn said.
>>>
>>> Wido - are you seeing (upgrade) failure, or something fails to work
>>> without this fix in basic zone?
>>> 
>>> From: Daan Hoogland 
>>> Sent: Wednesday, January 10, 2018 10:50:22 PM
>>> To: dev
>>> Cc: Rohit Yadav
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> I think that we agreed in th3 past that a blocker is either something
>>> that prevents ACS to start or upgrade, or something that breaks prior
>>> functionality.
>>>
>>>
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> 
>>> 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander >> > wrote:
>>>
>>>
>>> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>>> All,
>>>
>>>
>>> I want to thank all the reviewers, contributors and PR authors for their
>>> hard work, support and collaboration. We managed to review, test and merge
>>> more than 100 PRs towards the 4.11 milestone!
>>>
>>>
>>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>>> recently added features:
>>>
>>> https://github.com/apache/cloudstack/milestone/3
>>>
>>>
>>> To keep up with the release schedule, I think it's time we should focus
>>> on stabilizing master, testing it, fix any regressions and blockers.
>>>
>>>
>>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>>> schedule and master will be open for PRs with following merge criteria:
>>>
>>> - Blocker fixes, especially those blocking the release
>>>
>>> - Test failure and regression fixes
>>>
>>> - Release related fixes for example - upgrade blockers, database path,
>>> packaging and systemvmtemplate related etc.
>>>
>>>
>>> Thoughts, objections?
>>>
>>>
>>> Awesome!
>>>
>>> I'm looking for the definition for a blocker, I recently found this one:
>>> https://github.com/apache/cloudstack/pull/2396
>>>
>>> For us this is a big problem as we keep running into it, but probably
>>> nobody else. I don't want to promote my own PR as a blocker, but what is
>>> the definition?
>>>
>>> Because it's my own PR I didn't add the 4.11 milestone.
>>>
>>> Looking forward to 4.11!
>>>
>>>
>>> Wido
>>>
>>>
>>> - Rohit
>>>
>>> 
>>>
>>>
>>>
>>> 
>>> From: Khosrow Moossavi > kmooss...@cloudops.com>>
>>> Sent: Monday, January 8, 2018 8:59:30 PM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> +1 Daan and Rohit
>>>
>>> Khosrow Moossavi
>>>
>>> Cloud Infrastructure Developer
>>>
>>> t 514.447.3456
>>>
>>> 
>>>
>>>
>>>
>>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>>> boris.stoya...@shapeblue.com
>>> wrote:
>>>
>>> Yes let’s do that.
>>>
>>>
>>> boris.stoya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> 
>>> 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>>
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, 

Re: [DISCUSS] Freezing master for 4.11

[Daan Hoogland]

Ivan,
I was composing an answer but i think we agree:

Only if that functionality worked in the past. ipv6 support is still rather
new and must be considered experimental. I think we should fix it in a
maintenance release and not block the release for it. If it was working
before and broke, it should go in. To put it less mildly, I expect more
then ACS can deliver and we can't wait until all my wishes are implemented.


On Wed, Jan 10, 2018 at 6:58 PM, Ivan Kudryavtsev 
wrote:

> Sorry, to clarify, I mean (if I correctly understand) that if someone has
> a network with several CIDRs in the basic zone and, lets say, 4.9.3
> upgraded to 4.11, which results that VMs stop getting DHCP announces for
> additional CIDRs from VR, it's a blocker thing...
>
> 2018-01-11 0:52 GMT+07:00 Ivan Kudryavtsev :
>
>> I suppose the bug, reported by Wido prevents adding additional CIDRs to
>> Network if IPv6 configured? If so, it's definitely a blocker thing because
>> everyone expects it's possible, because the function is implemented in ACS.
>>
>> 2018-01-11 0:41 GMT+07:00 Rohit Yadav :
>>
>>> +1 what Dasn said.
>>>
>>> Wido - are you seeing (upgrade) failure, or something fails to work
>>> without this fix in basic zone?
>>> 
>>> From: Daan Hoogland 
>>> Sent: Wednesday, January 10, 2018 10:50:22 PM
>>> To: dev
>>> Cc: Rohit Yadav
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> I think that we agreed in th3 past that a blocker is either something
>>> that prevents ACS to start or upgrade, or something that breaks prior
>>> functionality.
>>>
>>>
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> 
>>> 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander >> > wrote:
>>>
>>>
>>> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>>> All,
>>>
>>>
>>> I want to thank all the reviewers, contributors and PR authors for their
>>> hard work, support and collaboration. We managed to review, test and merge
>>> more than 100 PRs towards the 4.11 milestone!
>>>
>>>
>>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>>> recently added features:
>>>
>>> https://github.com/apache/cloudstack/milestone/3
>>>
>>>
>>> To keep up with the release schedule, I think it's time we should focus
>>> on stabilizing master, testing it, fix any regressions and blockers.
>>>
>>>
>>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>>> schedule and master will be open for PRs with following merge criteria:
>>>
>>> - Blocker fixes, especially those blocking the release
>>>
>>> - Test failure and regression fixes
>>>
>>> - Release related fixes for example - upgrade blockers, database path,
>>> packaging and systemvmtemplate related etc.
>>>
>>>
>>> Thoughts, objections?
>>>
>>>
>>> Awesome!
>>>
>>> I'm looking for the definition for a blocker, I recently found this one:
>>> https://github.com/apache/cloudstack/pull/2396
>>>
>>> For us this is a big problem as we keep running into it, but probably
>>> nobody else. I don't want to promote my own PR as a blocker, but what is
>>> the definition?
>>>
>>> Because it's my own PR I didn't add the 4.11 milestone.
>>>
>>> Looking forward to 4.11!
>>>
>>>
>>> Wido
>>>
>>>
>>> - Rohit
>>>
>>> 
>>>
>>>
>>>
>>> 
>>> From: Khosrow Moossavi > kmooss...@cloudops.com>>
>>> Sent: Monday, January 8, 2018 8:59:30 PM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> +1 Daan and Rohit
>>>
>>> Khosrow Moossavi
>>>
>>> Cloud Infrastructure Developer
>>>
>>> t 514.447.3456
>>>
>>> 
>>>
>>>
>>>
>>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>>> boris.stoya...@shapeblue.com
>>> wrote:
>>>
>>> Yes let’s do that.
>>>
>>>
>>> boris.stoya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> 
>>> 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>>
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> 
>>> 4HSUK
>>> @shapeblue
>>>
>>> On 8 Jan 2018, at 14:41, Wido den Hollander > w...@widodh.nl>> wrote:
>>>
>>>
>>>
>>> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
>>> All,
>>> Thank you everyone for your feedback. 

Re: [DISCUSS] Freezing master for 4.11

[Ivan Kudryavtsev]

Sorry, to clarify, I mean (if I correctly understand) that if someone has a
network with several CIDRs in the basic zone and, lets say, 4.9.3 upgraded
to 4.11, which results that VMs stop getting DHCP announces for additional
CIDRs from VR, it's a blocker thing...

2018-01-11 0:52 GMT+07:00 Ivan Kudryavtsev :

> I suppose the bug, reported by Wido prevents adding additional CIDRs to
> Network if IPv6 configured? If so, it's definitely a blocker thing because
> everyone expects it's possible, because the function is implemented in ACS.
>
> 2018-01-11 0:41 GMT+07:00 Rohit Yadav :
>
>> +1 what Dasn said.
>>
>> Wido - are you seeing (upgrade) failure, or something fails to work
>> without this fix in basic zone?
>> 
>> From: Daan Hoogland 
>> Sent: Wednesday, January 10, 2018 10:50:22 PM
>> To: dev
>> Cc: Rohit Yadav
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> I think that we agreed in th3 past that a blocker is either something
>> that prevents ACS to start or upgrade, or something that breaks prior
>> functionality.
>>
>>
>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander > > wrote:
>>
>>
>> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>> All,
>>
>>
>> I want to thank all the reviewers, contributors and PR authors for their
>> hard work, support and collaboration. We managed to review, test and merge
>> more than 100 PRs towards the 4.11 milestone!
>>
>>
>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>> recently added features:
>>
>> https://github.com/apache/cloudstack/milestone/3
>>
>>
>> To keep up with the release schedule, I think it's time we should focus
>> on stabilizing master, testing it, fix any regressions and blockers.
>>
>>
>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>> schedule and master will be open for PRs with following merge criteria:
>>
>> - Blocker fixes, especially those blocking the release
>>
>> - Test failure and regression fixes
>>
>> - Release related fixes for example - upgrade blockers, database path,
>> packaging and systemvmtemplate related etc.
>>
>>
>> Thoughts, objections?
>>
>>
>> Awesome!
>>
>> I'm looking for the definition for a blocker, I recently found this one:
>> https://github.com/apache/cloudstack/pull/2396
>>
>> For us this is a big problem as we keep running into it, but probably
>> nobody else. I don't want to promote my own PR as a blocker, but what is
>> the definition?
>>
>> Because it's my own PR I didn't add the 4.11 milestone.
>>
>> Looking forward to 4.11!
>>
>>
>> Wido
>>
>>
>> - Rohit
>>
>> 
>>
>>
>>
>> 
>> From: Khosrow Moossavi  kmooss...@cloudops.com>>
>> Sent: Monday, January 8, 2018 8:59:30 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> +1 Daan and Rohit
>>
>> Khosrow Moossavi
>>
>> Cloud Infrastructure Developer
>>
>> t 514.447.3456
>>
>> 
>>
>>
>>
>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>> boris.stoya...@shapeblue.com
>> wrote:
>>
>> Yes let’s do that.
>>
>>
>> boris.stoya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>>
>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>> On 8 Jan 2018, at 14:41, Wido den Hollander  w...@widodh.nl>> wrote:
>>
>>
>>
>> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
>> All,
>> Thank you everyone for your feedback. Given we're in agreement with
>> Daan's proposal, I'll summarize and add strategy:
>> - We'll freeze the 4.11 milestone to only these 9 PRs:
>> https://github.com/apache/cloudstack/milestone/3
>> - In addition, only blocker, test fixes, and release/packaging related
>> fixes may be accepted in master now.
>> - If we don't hear from authors within a day, the PRs may be removed
>> from the milestone.
>> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
>> Does this look agreeable? Thanks.
>>
>> Yes, it does! When the first RC comes out we should be able to run
>> tests, fix what's broken and focus in the release and 4.12 afterwards.
>>
>> Wido
>>
>> - Rohit
>> 
>> 
>> From: Daan Hoogland  daan.hoogl...@gmail.com>>
>> Sent: Monday, January 8, 2018 4:21:00 PM
>> To: dev
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>> slow display of 

Re: [DISCUSS] Freezing master for 4.11

[Ivan Kudryavtsev]

I suppose the bug, reported by Wido prevents adding additional CIDRs to
Network if IPv6 configured? If so, it's definitely a blocker thing because
everyone expects it's possible, because the function is implemented in ACS.

2018-01-11 0:41 GMT+07:00 Rohit Yadav :

> +1 what Dasn said.
>
> Wido - are you seeing (upgrade) failure, or something fails to work
> without this fix in basic zone?
> 
> From: Daan Hoogland 
> Sent: Wednesday, January 10, 2018 10:50:22 PM
> To: dev
> Cc: Rohit Yadav
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> I think that we agreed in th3 past that a blocker is either something that
> prevents ACS to start or upgrade, or something that breaks prior
> functionality.
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander  > wrote:
>
>
> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
> All,
>
>
> I want to thank all the reviewers, contributors and PR authors for their
> hard work, support and collaboration. We managed to review, test and merge
> more than 100 PRs towards the 4.11 milestone!
>
>
> Out of 11 open PRs on Monday, the list is down to 2 now which were
> recently added features:
>
> https://github.com/apache/cloudstack/milestone/3
>
>
> To keep up with the release schedule, I think it's time we should focus on
> stabilizing master, testing it, fix any regressions and blockers.
>
>
> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
> schedule and master will be open for PRs with following merge criteria:
>
> - Blocker fixes, especially those blocking the release
>
> - Test failure and regression fixes
>
> - Release related fixes for example - upgrade blockers, database path,
> packaging and systemvmtemplate related etc.
>
>
> Thoughts, objections?
>
>
> Awesome!
>
> I'm looking for the definition for a blocker, I recently found this one:
> https://github.com/apache/cloudstack/pull/2396
>
> For us this is a big problem as we keep running into it, but probably
> nobody else. I don't want to promote my own PR as a blocker, but what is
> the definition?
>
> Because it's my own PR I didn't add the 4.11 milestone.
>
> Looking forward to 4.11!
>
>
> Wido
>
>
> - Rohit
>
> 
>
>
>
> 
> From: Khosrow Moossavi >
> Sent: Monday, January 8, 2018 8:59:30 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> +1 Daan and Rohit
>
> Khosrow Moossavi
>
> Cloud Infrastructure Developer
>
> t 514.447.3456
>
> 
>
>
>
> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
> boris.stoya...@shapeblue.com
> wrote:
>
> Yes let’s do that.
>
>
> boris.stoya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
> On 8 Jan 2018, at 14:41, Wido den Hollander  widodh.nl>> wrote:
>
>
>
> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> All,
> Thank you everyone for your feedback. Given we're in agreement with
> Daan's proposal, I'll summarize and add strategy:
> - We'll freeze the 4.11 milestone to only these 9 PRs:
> https://github.com/apache/cloudstack/milestone/3
> - In addition, only blocker, test fixes, and release/packaging related
> fixes may be accepted in master now.
> - If we don't hear from authors within a day, the PRs may be removed
> from the milestone.
> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> Does this look agreeable? Thanks.
>
> Yes, it does! When the first RC comes out we should be able to run
> tests, fix what's broken and focus in the release and 4.12 afterwards.
>
> Wido
>
> - Rohit
> 
> 
> From: Daan Hoogland >
> Sent: Monday, January 8, 2018 4:21:00 PM
> To: dev
> Subject: Re: [DISCUSS] Freezing master for 4.11
> slow display of arrogance in reacting this time ; yeeaahhh
> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> igor.voloshane...@gmail.com> wrote:
> You again faster than me )))
>
> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> igor.voloshane...@gmail.com
> :
>
> :D tnx )
> Updated by my colleague already
>
> 2018-01-08 12:06 GMT+02:00 Daan Hoogland >:
>
> yeah, way ahead of you 

Re: [DISCUSS] Freezing master for 4.11

[Rohit Yadav]

+1 what Dasn said.

Wido - are you seeing (upgrade) failure, or something fails to work without 
this fix in basic zone?

From: Daan Hoogland 
Sent: Wednesday, January 10, 2018 10:50:22 PM
To: dev
Cc: Rohit Yadav
Subject: Re: [DISCUSS] Freezing master for 4.11

I think that we agreed in th3 past that a blocker is either something that 
prevents ACS to start or upgrade, or something that breaks prior functionality.


rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander 
> wrote:


On 01/10/2018 05:47 PM, Rohit Yadav wrote:
All,


I want to thank all the reviewers, contributors and PR authors for their hard 
work, support and collaboration. We managed to review, test and merge more than 
100 PRs towards the 4.11 milestone!


Out of 11 open PRs on Monday, the list is down to 2 now which were recently 
added features:

https://github.com/apache/cloudstack/milestone/3


To keep up with the release schedule, I think it's time we should focus on 
stabilizing master, testing it, fix any regressions and blockers.


I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the schedule and 
master will be open for PRs with following merge criteria:

- Blocker fixes, especially those blocking the release

- Test failure and regression fixes

- Release related fixes for example - upgrade blockers, database path, 
packaging and systemvmtemplate related etc.


Thoughts, objections?


Awesome!

I'm looking for the definition for a blocker, I recently found this one: 
https://github.com/apache/cloudstack/pull/2396

For us this is a big problem as we keep running into it, but probably nobody 
else. I don't want to promote my own PR as a blocker, but what is the 
definition?

Because it's my own PR I didn't add the 4.11 milestone.

Looking forward to 4.11!


Wido


- Rohit






From: Khosrow Moossavi >
Sent: Monday, January 8, 2018 8:59:30 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456





On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov 

wrote:

Yes let’s do that.


boris.stoya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

On 8 Jan 2018, at 14:41, Wido den Hollander 
> wrote:



On 01/08/2018 01:30 PM, Rohit Yadav wrote:
All,
Thank you everyone for your feedback. Given we're in agreement with
Daan's proposal, I'll summarize and add strategy:
- We'll freeze the 4.11 milestone to only these 9 PRs:
https://github.com/apache/cloudstack/milestone/3
- In addition, only blocker, test fixes, and release/packaging related
fixes may be accepted in master now.
- If we don't hear from authors within a day, the PRs may be removed
from the milestone.
- We'll re-assess the list again by EOD, Wed 10 Jan 2018.
Does this look agreeable? Thanks.

Yes, it does! When the first RC comes out we should be able to run
tests, fix what's broken and focus in the release and 4.12 afterwards.

Wido

- Rohit


From: Daan Hoogland >
Sent: Monday, January 8, 2018 4:21:00 PM
To: dev
Subject: Re: [DISCUSS] Freezing master for 4.11
slow display of arrogance in reacting this time ; yeeaahhh
On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:
You again faster than me )))

2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
igor.voloshane...@gmail.com
:

:D tnx )
Updated by my colleague already

2018-01-08 12:06 GMT+02:00 Daan Hoogland 
>:

yeah, way ahead of you Igor ;) I asked a question about it

On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

Updates posted to https://github.com/apache/cloudstack/pull/2389
Can you please review?

2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
igor.voloshane...@gmail.com
:

Sure. Got it.

Will post update soon

2018-01-08 11:38 GMT+02:00 Daan Hoogland 

:

Igor, I remember your 

Re: [DISCUSS] Freezing master for 4.11

[Daan Hoogland]

I think that we agreed in th3 past that a blocker is either something that
prevents ACS to start or upgrade, or something that breaks prior
functionality.

On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander  wrote:

>
>
> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>
>> All,
>>
>>
>> I want to thank all the reviewers, contributors and PR authors for their
>> hard work, support and collaboration. We managed to review, test and merge
>> more than 100 PRs towards the 4.11 milestone!
>>
>>
>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>> recently added features:
>>
>> https://github.com/apache/cloudstack/milestone/3
>>
>>
>> To keep up with the release schedule, I think it's time we should focus
>> on stabilizing master, testing it, fix any regressions and blockers.
>>
>>
>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>> schedule and master will be open for PRs with following merge criteria:
>>
>> - Blocker fixes, especially those blocking the release
>>
>> - Test failure and regression fixes
>>
>> - Release related fixes for example - upgrade blockers, database path,
>> packaging and systemvmtemplate related etc.
>>
>>
>> Thoughts, objections?
>>
>>
> Awesome!
>
> I'm looking for the definition for a blocker, I recently found this one:
> https://github.com/apache/cloudstack/pull/2396
>
> For us this is a big problem as we keep running into it, but probably
> nobody else. I don't want to promote my own PR as a blocker, but what is
> the definition?
>
> Because it's my own PR I didn't add the 4.11 milestone.
>
> Looking forward to 4.11!
>
>
> Wido
>
>
>> - Rohit
>>
>> 
>>
>>
>>
>> 
>> From: Khosrow Moossavi 
>> Sent: Monday, January 8, 2018 8:59:30 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> +1 Daan and Rohit
>>
>> Khosrow Moossavi
>>
>> Cloud Infrastructure Developer
>>
>> t 514.447.3456
>>
>> 
>>
>>
>>
>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>> boris.stoya...@shapeblue.com
>>
>>> wrote:
>>>
>>
>> Yes let’s do that.
>>>
>>>
>>> boris.stoya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>>
>>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>> On 8 Jan 2018, at 14:41, Wido den Hollander  wrote:
>>>



 On 01/08/2018 01:30 PM, Rohit Yadav wrote:

> All,
> Thank you everyone for your feedback. Given we're in agreement with
>
 Daan's proposal, I'll summarize and add strategy:
>>>
 - We'll freeze the 4.11 milestone to only these 9 PRs:
>
 https://github.com/apache/cloudstack/milestone/3
>>>
 - In addition, only blocker, test fixes, and release/packaging related
>
 fixes may be accepted in master now.
>>>
 - If we don't hear from authors within a day, the PRs may be removed
>
 from the milestone.
>>>
 - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> Does this look agreeable? Thanks.
>

 Yes, it does! When the first RC comes out we should be able to run

>>> tests, fix what's broken and focus in the release and 4.12 afterwards.
>>>

 Wido

 - Rohit
> 
> 
> From: Daan Hoogland 
> Sent: Monday, January 8, 2018 4:21:00 PM
> To: dev
> Subject: Re: [DISCUSS] Freezing master for 4.11
> slow display of arrogance in reacting this time ; yeeaahhh
> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> igor.voloshane...@gmail.com> wrote:
>
>> You again faster than me )))
>>
>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
>>
> igor.voloshane...@gmail.com
>>>
 :
>>>
>>
>> :D tnx )
>>> Updated by my colleague already
>>>
>>> 2018-01-08 12:06 GMT+02:00 Daan Hoogland :
>>>
>>> yeah, way ahead of you Igor ;) I asked a question about it

 On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
 igor.voloshane...@gmail.com> wrote:

 Updates posted to https://github.com/apache/cloudstack/pull/2389
> Can you please review?
>
> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
>
 igor.voloshane...@gmail.com

> :
>>
>
> Sure. Got it.
>>
>> Will post update soon
>>
>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland >
> :

>
>> Igor, I remember your PR and think it is fine. It can also be
>>>
>> argued
>>
>>> that
>
>> it needs to go in as a security feature. 

Re: [DISCUSS] Freezing master for 4.11

[Wido den Hollander]

On 01/10/2018 05:47 PM, Rohit Yadav wrote:

All,


I want to thank all the reviewers, contributors and PR authors for their hard 
work, support and collaboration. We managed to review, test and merge more than 
100 PRs towards the 4.11 milestone!


Out of 11 open PRs on Monday, the list is down to 2 now which were recently 
added features:

https://github.com/apache/cloudstack/milestone/3


To keep up with the release schedule, I think it's time we should focus on 
stabilizing master, testing it, fix any regressions and blockers.


I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the schedule and 
master will be open for PRs with following merge criteria:

- Blocker fixes, especially those blocking the release

- Test failure and regression fixes

- Release related fixes for example - upgrade blockers, database path, 
packaging and systemvmtemplate related etc.


Thoughts, objections?



Awesome!

I'm looking for the definition for a blocker, I recently found this one: 
https://github.com/apache/cloudstack/pull/2396


For us this is a big problem as we keep running into it, but probably 
nobody else. I don't want to promote my own PR as a blocker, but what is 
the definition?


Because it's my own PR I didn't add the 4.11 milestone.

Looking forward to 4.11!

Wido



- Rohit






From: Khosrow Moossavi 
Sent: Monday, January 8, 2018 8:59:30 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456





On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov 
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue





rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
   
  


On 8 Jan 2018, at 14:41, Wido den Hollander  wrote:




On 01/08/2018 01:30 PM, Rohit Yadav wrote:

All,
Thank you everyone for your feedback. Given we're in agreement with

Daan's proposal, I'll summarize and add strategy:

- We'll freeze the 4.11 milestone to only these 9 PRs:

https://github.com/apache/cloudstack/milestone/3

- In addition, only blocker, test fixes, and release/packaging related

fixes may be accepted in master now.

- If we don't hear from authors within a day, the PRs may be removed

from the milestone.

- We'll re-assess the list again by EOD, Wed 10 Jan 2018.
Does this look agreeable? Thanks.


Yes, it does! When the first RC comes out we should be able to run

tests, fix what's broken and focus in the release and 4.12 afterwards.


Wido


- Rohit


From: Daan Hoogland 
Sent: Monday, January 8, 2018 4:21:00 PM
To: dev
Subject: Re: [DISCUSS] Freezing master for 4.11
slow display of arrogance in reacting this time ; yeeaahhh
On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

You again faster than me )))

2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <

igor.voloshane...@gmail.com

:



:D tnx )
Updated by my colleague already

2018-01-08 12:06 GMT+02:00 Daan Hoogland :


yeah, way ahead of you Igor ;) I asked a question about it

On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:


Updates posted to https://github.com/apache/cloudstack/pull/2389
Can you please review?

2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <

igor.voloshane...@gmail.com

:



Sure. Got it.

Will post update soon

2018-01-08 11:38 GMT+02:00 Daan Hoogland  wrote:


Guys, can we please include https://github.com/apache/clou

dstack/pull/2389

into 4.11
PR very small and updates will be published in next few hours.

As we have this for a while in production for 4.8 branch.

2018-01-08 11:15 GMT+02:00 Boris Stoyanov <

boris.stoya...@shapeblue.com

:


+1 Daan


boris.stoya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




On 8 Jan 2018, at 10:47, Daan Hoogland <

daan.hoogl...@gmail.com>

wrote:


Rohit, Ivan,

I think we can argue that the five open PRs on the milestone

can

still

go

in as long as active work on them continues. I have not

looked

at

Ivan's

PRs yet but can see they were entered in december and he is

actively

working on it so why not include those in 

Re: [DISCUSS] Freezing master for 4.11

[Ivan Kudryavtsev]

Congratulations, waiting for RC to do UAT on our dev cloud and switching
cloudstack-ui to 4.11

10 янв. 2018 г. 23:48 пользователь "Rohit Yadav" 
написал:

> All,
>
>
> I want to thank all the reviewers, contributors and PR authors for their
> hard work, support and collaboration. We managed to review, test and merge
> more than 100 PRs towards the 4.11 milestone!
>
>
> Out of 11 open PRs on Monday, the list is down to 2 now which were
> recently added features:
>
> https://github.com/apache/cloudstack/milestone/3
>
>
> To keep up with the release schedule, I think it's time we should focus on
> stabilizing master, testing it, fix any regressions and blockers.
>
>
> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
> schedule and master will be open for PRs with following merge criteria:
>
> - Blocker fixes, especially those blocking the release
>
> - Test failure and regression fixes
>
> - Release related fixes for example - upgrade blockers, database path,
> packaging and systemvmtemplate related etc.
>
>
> Thoughts, objections?
>
>
> - Rohit
>
> 
>
>
>
> 
> From: Khosrow Moossavi 
> Sent: Monday, January 8, 2018 8:59:30 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> +1 Daan and Rohit
>
> Khosrow Moossavi
>
> Cloud Infrastructure Developer
>
> t 514.447.3456
>
> 
>
>
>
> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
> boris.stoya...@shapeblue.com
> > wrote:
>
> > Yes let’s do that.
> >
> >
> > boris.stoya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> > On 8 Jan 2018, at 14:41, Wido den Hollander  wrote:
> > >
> > >
> > >
> > > On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> > >> All,
> > >> Thank you everyone for your feedback. Given we're in agreement with
> > Daan's proposal, I'll summarize and add strategy:
> > >> - We'll freeze the 4.11 milestone to only these 9 PRs:
> > https://github.com/apache/cloudstack/milestone/3
> > >> - In addition, only blocker, test fixes, and release/packaging related
> > fixes may be accepted in master now.
> > >> - If we don't hear from authors within a day, the PRs may be removed
> > from the milestone.
> > >> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> > >> Does this look agreeable? Thanks.
> > >
> > > Yes, it does! When the first RC comes out we should be able to run
> > tests, fix what's broken and focus in the release and 4.12 afterwards.
> > >
> > > Wido
> > >
> > >> - Rohit
> > >> 
> > >> 
> > >> From: Daan Hoogland 
> > >> Sent: Monday, January 8, 2018 4:21:00 PM
> > >> To: dev
> > >> Subject: Re: [DISCUSS] Freezing master for 4.11
> > >> slow display of arrogance in reacting this time ; yeeaahhh
> > >> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> > >> igor.voloshane...@gmail.com> wrote:
> > >>> You again faster than me )))
> > >>>
> > >>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> > igor.voloshane...@gmail.com
> >  :
> > >>>
> >  :D tnx )
> >  Updated by my colleague already
> > 
> >  2018-01-08 12:06 GMT+02:00 Daan Hoogland :
> > 
> > > yeah, way ahead of you Igor ;) I asked a question about it
> > >
> > > On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> > > igor.voloshane...@gmail.com> wrote:
> > >
> > >> Updates posted to https://github.com/apache/cloudstack/pull/2389
> > >> Can you please review?
> > >>
> > >> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> > > igor.voloshane...@gmail.com
> > >>> :
> > >>
> > >>> Sure. Got it.
> > >>>
> > >>> Will post update soon
> > >>>
> > >>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland <
> daan.hoogl...@gmail.com
> > >:
> > >>>
> >  Igor, I remember your PR and think it is fine. It can also be
> > >>> argued
> > >> that
> >  it needs to go in as a security feature. For an RM it is
> > >>> unthinkably
> > >> late,
> >  but fortunately it is very small. I will however -1 it if it
> leads
> > > to a
> >  plethora of last minute PRs to include.
> > 
> >  On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> >  igor.voloshane...@gmail.com> wrote:
> > 
> > > Guys, can we please include https://github.com/apache/clou
> >  dstack/pull/2389
> > > into 4.11
> > > PR very small and updates will be published in next few hours.
> > >
> > > As we have this for a while in production for 4.8 branch.
> > >
> > > 2018-01-08 

Re: [DISCUSS] Freezing master for 4.11

[Rohit Yadav]

All,


I want to thank all the reviewers, contributors and PR authors for their hard 
work, support and collaboration. We managed to review, test and merge more than 
100 PRs towards the 4.11 milestone!


Out of 11 open PRs on Monday, the list is down to 2 now which were recently 
added features:

https://github.com/apache/cloudstack/milestone/3


To keep up with the release schedule, I think it's time we should focus on 
stabilizing master, testing it, fix any regressions and blockers.


I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the schedule and 
master will be open for PRs with following merge criteria:

- Blocker fixes, especially those blocking the release

- Test failure and regression fixes

- Release related fixes for example - upgrade blockers, database path, 
packaging and systemvmtemplate related etc.


Thoughts, objections?


- Rohit






From: Khosrow Moossavi 
Sent: Monday, January 8, 2018 8:59:30 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456





On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov  wrote:

> Yes let’s do that.
>
>
> boris.stoya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> 
rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On 8 Jan 2018, at 14:41, Wido den Hollander  wrote:
> >
> >
> >
> > On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> >> All,
> >> Thank you everyone for your feedback. Given we're in agreement with
> Daan's proposal, I'll summarize and add strategy:
> >> - We'll freeze the 4.11 milestone to only these 9 PRs:
> https://github.com/apache/cloudstack/milestone/3
> >> - In addition, only blocker, test fixes, and release/packaging related
> fixes may be accepted in master now.
> >> - If we don't hear from authors within a day, the PRs may be removed
> from the milestone.
> >> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> >> Does this look agreeable? Thanks.
> >
> > Yes, it does! When the first RC comes out we should be able to run
> tests, fix what's broken and focus in the release and 4.12 afterwards.
> >
> > Wido
> >
> >> - Rohit
> >> 
> >> 
> >> From: Daan Hoogland 
> >> Sent: Monday, January 8, 2018 4:21:00 PM
> >> To: dev
> >> Subject: Re: [DISCUSS] Freezing master for 4.11
> >> slow display of arrogance in reacting this time ; yeeaahhh
> >> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> >> igor.voloshane...@gmail.com> wrote:
> >>> You again faster than me )))
> >>>
> >>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> igor.voloshane...@gmail.com
>  :
> >>>
>  :D tnx )
>  Updated by my colleague already
> 
>  2018-01-08 12:06 GMT+02:00 Daan Hoogland :
> 
> > yeah, way ahead of you Igor ;) I asked a question about it
> >
> > On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> > igor.voloshane...@gmail.com> wrote:
> >
> >> Updates posted to https://github.com/apache/cloudstack/pull/2389
> >> Can you please review?
> >>
> >> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> > igor.voloshane...@gmail.com
> >>> :
> >>
> >>> Sure. Got it.
> >>>
> >>> Will post update soon
> >>>
> >>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland  >:
> >>>
>  Igor, I remember your PR and think it is fine. It can also be
> >>> argued
> >> that
>  it needs to go in as a security feature. For an RM it is
> >>> unthinkably
> >> late,
>  but fortunately it is very small. I will however -1 it if it leads
> > to a
>  plethora of last minute PRs to include.
> 
>  On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
>  igor.voloshane...@gmail.com> wrote:
> 
> > Guys, can we please include https://github.com/apache/clou
>  dstack/pull/2389
> > into 4.11
> > PR very small and updates will be published in next few hours.
> >
> > As we have this for a while in production for 4.8 branch.
> >
> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> >> boris.stoya...@shapeblue.com
> > :
> >
> >> +1 Daan
> >>
> >>
> >> boris.stoya...@shapeblue.com
> >> www.shapeblue.com
> >> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >> @shapeblue
> >>
> >>
> >>
> >>> On 8 Jan 2018, at 10:47, Daan Hoogland <
> > daan.hoogl...@gmail.com>
> > 

Re: Which StringUtils to use?

[Wido den Hollander]

On 01/10/2018 01:09 PM, Rafael Weingärtner wrote:

Instead of creating a PR for that, we could do the bit by bit job
(hopefully one day we finish the job).
Every time we see a code using ACS's StringUtils, we check if it can be
replaced by Apache's one.



Yes, but that will slip from peoples attention and we will probably see 
cases where people still use the old one by accident.


I've created a issue: https://issues.apache.org/jira/browse/CLOUDSTACK-10225

I also started on some low hanging fruit as some methods in StringUtils 
are not used or are very easy to replace.


Wido


On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander  wrote:




On 01/10/2018 12:01 PM, Daan Hoogland wrote:


I'd say remove as much functionality as we can from 'our' StringUtils and
phase them out asap.



Yes, but such a PR would be invasive and would be difficult to merge and
also break a lot of other code.

It's not easy since it will touch a lot, but I mean, a lot of files.

Our StringUtils was a very good solution, but the Apache one is better I
think.

Wido


On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 

wrote:

Hi,


We have com.cloud.utils.StringUtils which has a few nice functions, but
throughout the code I also see org.apache.commons.lang.StringUtils

They both provide about the same functionality, but which one do we
prefer?

I'd say org.apache.commons.lang.StringUtils as that allows us to remove
our own StringUtils, but we could also have 'our' StringUtils simply be a
wrapper around org.apache.commons.lang.StringUtils

Opinions?

Wido

Re: How to achieve SUM (N * M) with ACS DAO

[Rafael Weingärtner]

You can always use a raw SQL.

On Wed, Jan 10, 2018 at 10:45 AM, Ivan Kudryavtsev  wrote:

> Hmmm, I don't think the math works that way, multiplication and sum are not
> same order operations. Right now the only way I found is to fetch all rows
> with required fields from db and do computation in the code, but it doesn't
> look efficient though.
>
> 10 янв. 2018 г. 19:41 пользователь "Marc-Aurèle Brothier" <
> ma...@exoscale.ch>
> написал:
>
> Hmm, yeah that's what I realized after sending the email. With the DAO, you
> can only apply function on a single column / entity attribute, therefore it
> won't be possible as you want. Another way to achieve this would be to do
> SELECT SUM(A), SUM(B) FROM T with the DAO, and on the Java side do the
> multiplication. Woud that work for your use-case?
>
>
> On Wed, Jan 10, 2018 at 1:27 PM, Ivan Kudryavtsev <
> kudryavtsev...@bw-sw.com>
> wrote:
>
> > Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum
> > usage everywhere in the codebase. It's aggregation over single field.
> What
> > I need is to pass multuplication of two fields (cores x speed) inside the
> > sum, but I don't understand how to do it with dao... Thank you.
> >
> > 10 янв. 2018 г. 19:12 пользователь "Marc-Aurèle Brothier" <
> > ma...@exoscale.ch>
> > написал:
> >
> > > Have a look here:
> > > https://github.com/apache/cloudstack/blob/master/engine/
> > > schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347
> > >
> > > Or you can search other example in the code base with this string
> > > "Func.SUM": thttps://
> > > github.com/apache/cloudstack/blob/master/engine/schema/src/
> > > com/cloud/storage/dao/VolumeDaoImpl.java#L347
> > >
> > > On Wed, Jan 10, 2018 at 9:42 AM, Ivan Kudryavtsev <
> > > kudryavtsev...@bw-sw.com>
> > > wrote:
> > >
> > > > Hello, colleagues, please could anyone guide me how to implement
> > > > aggregation SUM over two fields multiplication? Many thanks in
> advance.
> > > >
> > > > I'm trying to achieve:
> > > > SELECT SUM(A * B) FROM T with DAO
> > > >
> > > >
> > > >
> > > > --
> > > > With best regards, Ivan Kudryavtsev
> > > > Bitworks Software, Ltd.
> > > > Cell: +7-923-414-1515
> > > > WWW: http://bitworks.software/ 
> > > >
> > >
> >
>



-- 
Rafael Weingärtner

Re: How to achieve SUM (N * M) with ACS DAO

[Marc-Aurèle Brothier]

Oups, my bad, very bad actually. I had in mind you had the same speed Mhz

You can always run a raw SQL query, there're a lot in the CapacityDao due
to the limitation on the mix of functions + group by.

On Wed, Jan 10, 2018 at 1:45 PM, Ivan Kudryavtsev 
wrote:

> Hmmm, I don't think the math works that way, multiplication and sum are not
> same order operations. Right now the only way I found is to fetch all rows
> with required fields from db and do computation in the code, but it doesn't
> look efficient though.
>
> 10 янв. 2018 г. 19:41 пользователь "Marc-Aurèle Brothier" <
> ma...@exoscale.ch>
> написал:
>
> Hmm, yeah that's what I realized after sending the email. With the DAO, you
> can only apply function on a single column / entity attribute, therefore it
> won't be possible as you want. Another way to achieve this would be to do
> SELECT SUM(A), SUM(B) FROM T with the DAO, and on the Java side do the
> multiplication. Woud that work for your use-case?
>
>
> On Wed, Jan 10, 2018 at 1:27 PM, Ivan Kudryavtsev <
> kudryavtsev...@bw-sw.com>
> wrote:
>
> > Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum
> > usage everywhere in the codebase. It's aggregation over single field.
> What
> > I need is to pass multuplication of two fields (cores x speed) inside the
> > sum, but I don't understand how to do it with dao... Thank you.
> >
> > 10 янв. 2018 г. 19:12 пользователь "Marc-Aurèle Brothier" <
> > ma...@exoscale.ch>
> > написал:
> >
> > > Have a look here:
> > > https://github.com/apache/cloudstack/blob/master/engine/
> > > schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347
> > >
> > > Or you can search other example in the code base with this string
> > > "Func.SUM": thttps://
> > > github.com/apache/cloudstack/blob/master/engine/schema/src/
> > > com/cloud/storage/dao/VolumeDaoImpl.java#L347
> > >
> > > On Wed, Jan 10, 2018 at 9:42 AM, Ivan Kudryavtsev <
> > > kudryavtsev...@bw-sw.com>
> > > wrote:
> > >
> > > > Hello, colleagues, please could anyone guide me how to implement
> > > > aggregation SUM over two fields multiplication? Many thanks in
> advance.
> > > >
> > > > I'm trying to achieve:
> > > > SELECT SUM(A * B) FROM T with DAO
> > > >
> > > >
> > > >
> > > > --
> > > > With best regards, Ivan Kudryavtsev
> > > > Bitworks Software, Ltd.
> > > > Cell: +7-923-414-1515
> > > > WWW: http://bitworks.software/ 
> > > >
> > >
> >
>

Re: How to achieve SUM (N * M) with ACS DAO

[Ivan Kudryavtsev]

Hmmm, I don't think the math works that way, multiplication and sum are not
same order operations. Right now the only way I found is to fetch all rows
with required fields from db and do computation in the code, but it doesn't
look efficient though.

10 янв. 2018 г. 19:41 пользователь "Marc-Aurèle Brothier" 
написал:

Hmm, yeah that's what I realized after sending the email. With the DAO, you
can only apply function on a single column / entity attribute, therefore it
won't be possible as you want. Another way to achieve this would be to do
SELECT SUM(A), SUM(B) FROM T with the DAO, and on the Java side do the
multiplication. Woud that work for your use-case?


On Wed, Jan 10, 2018 at 1:27 PM, Ivan Kudryavtsev 
wrote:

> Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum
> usage everywhere in the codebase. It's aggregation over single field. What
> I need is to pass multuplication of two fields (cores x speed) inside the
> sum, but I don't understand how to do it with dao... Thank you.
>
> 10 янв. 2018 г. 19:12 пользователь "Marc-Aurèle Brothier" <
> ma...@exoscale.ch>
> написал:
>
> > Have a look here:
> > https://github.com/apache/cloudstack/blob/master/engine/
> > schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347
> >
> > Or you can search other example in the code base with this string
> > "Func.SUM": thttps://
> > github.com/apache/cloudstack/blob/master/engine/schema/src/
> > com/cloud/storage/dao/VolumeDaoImpl.java#L347
> >
> > On Wed, Jan 10, 2018 at 9:42 AM, Ivan Kudryavtsev <
> > kudryavtsev...@bw-sw.com>
> > wrote:
> >
> > > Hello, colleagues, please could anyone guide me how to implement
> > > aggregation SUM over two fields multiplication? Many thanks in
advance.
> > >
> > > I'm trying to achieve:
> > > SELECT SUM(A * B) FROM T with DAO
> > >
> > >
> > >
> > > --
> > > With best regards, Ivan Kudryavtsev
> > > Bitworks Software, Ltd.
> > > Cell: +7-923-414-1515
> > > WWW: http://bitworks.software/ 
> > >
> >
>

Re: How to achieve SUM (N * M) with ACS DAO

[Marc-Aurèle Brothier]

Hmm, yeah that's what I realized after sending the email. With the DAO, you
can only apply function on a single column / entity attribute, therefore it
won't be possible as you want. Another way to achieve this would be to do
SELECT SUM(A), SUM(B) FROM T with the DAO, and on the Java side do the
multiplication. Woud that work for your use-case?


On Wed, Jan 10, 2018 at 1:27 PM, Ivan Kudryavtsev 
wrote:

> Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum
> usage everywhere in the codebase. It's aggregation over single field. What
> I need is to pass multuplication of two fields (cores x speed) inside the
> sum, but I don't understand how to do it with dao... Thank you.
>
> 10 янв. 2018 г. 19:12 пользователь "Marc-Aurèle Brothier" <
> ma...@exoscale.ch>
> написал:
>
> > Have a look here:
> > https://github.com/apache/cloudstack/blob/master/engine/
> > schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347
> >
> > Or you can search other example in the code base with this string
> > "Func.SUM": thttps://
> > github.com/apache/cloudstack/blob/master/engine/schema/src/
> > com/cloud/storage/dao/VolumeDaoImpl.java#L347
> >
> > On Wed, Jan 10, 2018 at 9:42 AM, Ivan Kudryavtsev <
> > kudryavtsev...@bw-sw.com>
> > wrote:
> >
> > > Hello, colleagues, please could anyone guide me how to implement
> > > aggregation SUM over two fields multiplication? Many thanks in advance.
> > >
> > > I'm trying to achieve:
> > > SELECT SUM(A * B) FROM T with DAO
> > >
> > >
> > >
> > > --
> > > With best regards, Ivan Kudryavtsev
> > > Bitworks Software, Ltd.
> > > Cell: +7-923-414-1515
> > > WWW: http://bitworks.software/ 
> > >
> >
>

Re: How to achieve SUM (N * M) with ACS DAO

[Ivan Kudryavtsev]

Hello, Marc-Aurele, thank you for the snippet, but it looks like the sum
usage everywhere in the codebase. It's aggregation over single field. What
I need is to pass multuplication of two fields (cores x speed) inside the
sum, but I don't understand how to do it with dao... Thank you.

10 янв. 2018 г. 19:12 пользователь "Marc-Aurèle Brothier" 
написал:

> Have a look here:
> https://github.com/apache/cloudstack/blob/master/engine/
> schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347
>
> Or you can search other example in the code base with this string
> "Func.SUM": thttps://
> github.com/apache/cloudstack/blob/master/engine/schema/src/
> com/cloud/storage/dao/VolumeDaoImpl.java#L347
>
> On Wed, Jan 10, 2018 at 9:42 AM, Ivan Kudryavtsev <
> kudryavtsev...@bw-sw.com>
> wrote:
>
> > Hello, colleagues, please could anyone guide me how to implement
> > aggregation SUM over two fields multiplication? Many thanks in advance.
> >
> > I'm trying to achieve:
> > SELECT SUM(A * B) FROM T with DAO
> >
> >
> >
> > --
> > With best regards, Ivan Kudryavtsev
> > Bitworks Software, Ltd.
> > Cell: +7-923-414-1515
> > WWW: http://bitworks.software/ 
> >
>

Re: How to achieve SUM (N * M) with ACS DAO

[Marc-Aurèle Brothier]

Have a look here:
https://github.com/apache/cloudstack/blob/master/engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347

Or you can search other example in the code base with this string
"Func.SUM": thttps://
github.com/apache/cloudstack/blob/master/engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java#L347

On Wed, Jan 10, 2018 at 9:42 AM, Ivan Kudryavtsev 
wrote:

> Hello, colleagues, please could anyone guide me how to implement
> aggregation SUM over two fields multiplication? Many thanks in advance.
>
> I'm trying to achieve:
> SELECT SUM(A * B) FROM T with DAO
>
>
>
> --
> With best regards, Ivan Kudryavtsev
> Bitworks Software, Ltd.
> Cell: +7-923-414-1515
> WWW: http://bitworks.software/ 
>

Re: Which StringUtils to use?

[Rafael Weingärtner]

Instead of creating a PR for that, we could do the bit by bit job
(hopefully one day we finish the job).
Every time we see a code using ACS's StringUtils, we check if it can be
replaced by Apache's one.

On Wed, Jan 10, 2018 at 10:01 AM, Wido den Hollander  wrote:

>
>
> On 01/10/2018 12:01 PM, Daan Hoogland wrote:
>
>> I'd say remove as much functionality as we can from 'our' StringUtils and
>> phase them out asap.
>>
>>
> Yes, but such a PR would be invasive and would be difficult to merge and
> also break a lot of other code.
>
> It's not easy since it will touch a lot, but I mean, a lot of files.
>
> Our StringUtils was a very good solution, but the Apache one is better I
> think.
>
> Wido
>
>
> On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 
>> wrote:
>>
>> Hi,
>>>
>>> We have com.cloud.utils.StringUtils which has a few nice functions, but
>>> throughout the code I also see org.apache.commons.lang.StringUtils
>>>
>>> They both provide about the same functionality, but which one do we
>>> prefer?
>>>
>>> I'd say org.apache.commons.lang.StringUtils as that allows us to remove
>>> our own StringUtils, but we could also have 'our' StringUtils simply be a
>>> wrapper around org.apache.commons.lang.StringUtils
>>>
>>> Opinions?
>>>
>>> Wido
>>>
>>>
>>
>>
>>


-- 
Rafael Weingärtner

Re: Which StringUtils to use?

[Wido den Hollander]

On 01/10/2018 12:01 PM, Daan Hoogland wrote:

I'd say remove as much functionality as we can from 'our' StringUtils and
phase them out asap.



Yes, but such a PR would be invasive and would be difficult to merge and 
also break a lot of other code.


It's not easy since it will touch a lot, but I mean, a lot of files.

Our StringUtils was a very good solution, but the Apache one is better I 
think.


Wido


On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander  wrote:


Hi,

We have com.cloud.utils.StringUtils which has a few nice functions, but
throughout the code I also see org.apache.commons.lang.StringUtils

They both provide about the same functionality, but which one do we prefer?

I'd say org.apache.commons.lang.StringUtils as that allows us to remove
our own StringUtils, but we could also have 'our' StringUtils simply be a
wrapper around org.apache.commons.lang.StringUtils

Opinions?

Wido

Re: Which StringUtils to use?

[Rafael Weingärtner]

+1 to what Daan's said

On Wed, Jan 10, 2018 at 9:01 AM, Daan Hoogland 
wrote:

> I'd say remove as much functionality as we can from 'our' StringUtils and
> phase them out asap.
>
> On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander 
> wrote:
>
> > Hi,
> >
> > We have com.cloud.utils.StringUtils which has a few nice functions, but
> > throughout the code I also see org.apache.commons.lang.StringUtils
> >
> > They both provide about the same functionality, but which one do we
> prefer?
> >
> > I'd say org.apache.commons.lang.StringUtils as that allows us to remove
> > our own StringUtils, but we could also have 'our' StringUtils simply be a
> > wrapper around org.apache.commons.lang.StringUtils
> >
> > Opinions?
> >
> > Wido
> >
>
>
>
> --
> Daan
>



-- 
Rafael Weingärtner

Re: Which StringUtils to use?

[Daan Hoogland]

I'd say remove as much functionality as we can from 'our' StringUtils and
phase them out asap.

On Wed, Jan 10, 2018 at 11:59 AM, Wido den Hollander  wrote:

> Hi,
>
> We have com.cloud.utils.StringUtils which has a few nice functions, but
> throughout the code I also see org.apache.commons.lang.StringUtils
>
> They both provide about the same functionality, but which one do we prefer?
>
> I'd say org.apache.commons.lang.StringUtils as that allows us to remove
> our own StringUtils, but we could also have 'our' StringUtils simply be a
> wrapper around org.apache.commons.lang.StringUtils
>
> Opinions?
>
> Wido
>



-- 
Daan

Which StringUtils to use?

[Wido den Hollander]

Hi,

We have com.cloud.utils.StringUtils which has a few nice functions, but 
throughout the code I also see org.apache.commons.lang.StringUtils


They both provide about the same functionality, but which one do we prefer?

I'd say org.apache.commons.lang.StringUtils as that allows us to remove 
our own StringUtils, but we could also have 'our' StringUtils simply be 
a wrapper around org.apache.commons.lang.StringUtils


Opinions?

Wido

Re: Squeeze another PR (#2398) in 4.11 milestone

[Rohit Yadav]

Hi all,


I think the criteria for any additional PRs to be considered for 4.11.0.0 
release should be:

- Is it a blocker, especially blocking the release?

- Is is fixing any test failures or regressions?

- Is it release related, for example - packaging, systemvmtemplate, db-upgrade 
path related


Is this agreeable?


In case we miss any bugfix PRs, they may be sent to the 4.11 branch (to be cut 
soon), and in future and make its way to a minor release such as 4.11.1.0 etc.


For the purpose of keeping up with the release schedule, I think we should be 
reluctant to move the goal post again. I'll update on outstanding milestone PRs 
by EOD today. Thanks for your understanding.


- Rohit






From: Khosrow Moossavi 
Sent: Tuesday, January 9, 2018 10:55:59 PM
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org
Subject: Squeeze another PR (#2398) in 4.11 milestone

Hi community

We've found [1] and fixed [2] an issue in 4.10 regarding snapshots
remaining on primary storage (XenServer + Swift) which causes VDI chain
gets full after some time and user cannot take another snapshot.

Please include this in 4.11 milestone if you see fit.

[1]: https://issues.apache.org/jira/browse/CLOUDSTACK-10222
[2]: https://github.com/apache/cloudstack/pull/2398

Thanks
Khosrow

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

How to achieve SUM (N * M) with ACS DAO

[Ivan Kudryavtsev]

Hello, colleagues, please could anyone guide me how to implement
aggregation SUM over two fields multiplication? Many thanks in advance.

I'm trying to achieve:
SELECT SUM(A * B) FROM T with DAO



-- 
With best regards, Ivan Kudryavtsev
Bitworks Software, Ltd.
Cell: +7-923-414-1515
WWW: http://bitworks.software/