Re: [DISCUSS]/[PROPOSAL] draft PRs
Hi Daan, K. I will look where I can put it into the confluence. Maybe or hope I will find a place. will say that I got this email. Maybe someone don’t get this mail eg another dev and then it’s easy to say there is an entry in the conf. Mailing lists are like a waterfall. you forget or don’t see it again in the moment it passes. Cheers Sven __ Sven Vogel Teamlead Platform EWERK DIGITAL GmbH Brühl 24, D-04109 Leipzig P +49 341 42649 - 99 F +49 341 42649 - 98 s.vo...@ewerk.com www.ewerk.com Geschäftsführer: Dr. Erik Wende, Hendrik Schubert, Frank Richter Registergericht: Leipzig HRB 9065 Zertifiziert nach: ISO/IEC 27001:2013 DIN EN ISO 9001:2015 DIN ISO/IEC 2-1:2011 EWERK-Blog | LinkedIn | Xing | Twitter | Facebook Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. Disclaimer Privacy: Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank. The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you. > Am 14.02.2020 um 23:37 schrieb Daan Hoogland : > > Feel free to do so, Sven. I'm not aware that the initial proposal got to > confluence, but it should be added there if it did. > >> On Fri, 14 Feb 2020, 22:33 Sven Vogel, wrote: >> >> Should we add this to the confluence? >> >> >> __ >> >> Sven Vogel >> Teamlead Platform >> >> EWERK DIGITAL GmbH >> Brühl 24, D-04109 Leipzig >> P +49 341 42649 - 99 >> F +49 341 42649 - 98 >> s.vo...@ewerk.com >> www.ewerk.com >> >> Geschäftsführer: >> Dr. Erik Wende, Hendrik Schubert, Frank Richter >> Registergericht: Leipzig HRB 9065 >> >> Zertifiziert nach: >> ISO/IEC 27001:2013 >> DIN EN ISO 9001:2015 >> DIN ISO/IEC 2-1:2011 >> >> EWERK-Blog | LinkedIn | Xing | Twitter | Facebook >> >> Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. >> >> Disclaimer Privacy: >> Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist >> vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der >> bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, >> Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte >> informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie >> die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. >> Vielen Dank. >> >> The contents of this e-mail (including any attachments) are confidential >> and may be legally privileged. If you are not the intended recipient of >> this e-mail, any disclosure, copying, distribution or use of its contents >> is strictly prohibited, and you should please notify the sender immediately >> and then delete it (including any attachments) from your system. Thank you. Am 14.02.2020 um 19:45 schrieb Daan Hoogland : >>> >>> Thanks all for the swift responses. Let's just start doing this. No need >>> for a vote until someone starts a discussion on the subject. Agree? >>> On Fri, 14 Feb 2020, 17:04 Rohit Yadav, >> wrote: +1 (better than changing the PR subject, putting wip-labels or [WIP]) Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com rohit.ya...@shapeblue.com www.shapeblue.com @shapeblue -- *From:* Daan Hoogland *Sent:* Friday, February 14, 2020 17:33 *To:* dev *Subject:* [DISCUSS]/[PROPOSAL] draft PRs devs, I thought I had already sent a mail about this but i cannot find >> it. I'm sure i had mentioned it somewhere (probably on github). this is a follow up on [1] and hopefully you'll agree, a slight improvement. here it comes: At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in >> the title. This title stands the chance of being merged once we agree the >> PR is ready for merge. It also clutters the title. Github has introduced a nice feature a while ago; draft PR. When >> creating a PR you can opt not to open it for merge but as draft. Choose a button >> left of the "Create pull request" button, marked "Create draft PR". It will >> be a full PR with all CI and discussion possibilities open. The only >> difference is the merge button being disabled. One will than have to make/mark it "ready for merge" before i
Re: [DISCUSS]/[PROPOSAL] draft PRs
Feel free to do so, Sven. I'm not aware that the initial proposal got to confluence, but it should be added there if it did. On Fri, 14 Feb 2020, 22:33 Sven Vogel, wrote: > Should we add this to the confluence? > > > __ > > Sven Vogel > Teamlead Platform > > EWERK DIGITAL GmbH > Brühl 24, D-04109 Leipzig > P +49 341 42649 - 99 > F +49 341 42649 - 98 > s.vo...@ewerk.com > www.ewerk.com > > Geschäftsführer: > Dr. Erik Wende, Hendrik Schubert, Frank Richter > Registergericht: Leipzig HRB 9065 > > Zertifiziert nach: > ISO/IEC 27001:2013 > DIN EN ISO 9001:2015 > DIN ISO/IEC 2-1:2011 > > EWERK-Blog | LinkedIn | Xing | Twitter | Facebook > > Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. > > Disclaimer Privacy: > Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist > vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der > bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, > Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte > informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie > die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. > Vielen Dank. > > The contents of this e-mail (including any attachments) are confidential > and may be legally privileged. If you are not the intended recipient of > this e-mail, any disclosure, copying, distribution or use of its contents > is strictly prohibited, and you should please notify the sender immediately > and then delete it (including any attachments) from your system. Thank you. > > Am 14.02.2020 um 19:45 schrieb Daan Hoogland : > > > > Thanks all for the swift responses. Let's just start doing this. No need > > for a vote until someone starts a discussion on the subject. Agree? > > > >> On Fri, 14 Feb 2020, 17:04 Rohit Yadav, > wrote: > >> > >> +1 (better than changing the PR subject, putting wip-labels or [WIP]) > >> > >> Regards, > >> > >> Rohit Yadav > >> > >> Software Architect, ShapeBlue > >> https://www.shapeblue.com > >> > >> rohit.ya...@shapeblue.com > >> www.shapeblue.com > >> @shapeblue > >> > >> > >> > >> -- > >> *From:* Daan Hoogland > >> *Sent:* Friday, February 14, 2020 17:33 > >> *To:* dev > >> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs > >> > >> devs, I thought I had already sent a mail about this but i cannot find > it. > >> I'm sure i had mentioned it somewhere (probably on github). > >> this is a follow up on [1] and hopefully you'll agree, a slight > >> improvement. > >> > >> here it comes: > >> > >> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in > the > >> title. This title stands the chance of being merged once we agree the > PR is > >> ready for merge. It also clutters the title. > >> > >> Github has introduced a nice feature a while ago; draft PR. When > creating a > >> PR you can opt not to open it for merge but as draft. Choose a button > left > >> of the "Create pull request" button, marked "Create draft PR". It will > be a > >> full PR with all CI and discussion possibilities open. The only > difference > >> is the merge button being disabled. One will than have to make/mark it > >> "ready for merge" before it *can* be merged. > >> > >> [1] > >> > >> > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E > >> please shoot any comments you may have back at me, > >> thanks > >> > >> -- > >> Daan > >> >
Re: [DISCUSS]/[PROPOSAL] draft PRs
Should we add this to the confluence? __ Sven Vogel Teamlead Platform EWERK DIGITAL GmbH Brühl 24, D-04109 Leipzig P +49 341 42649 - 99 F +49 341 42649 - 98 s.vo...@ewerk.com www.ewerk.com Geschäftsführer: Dr. Erik Wende, Hendrik Schubert, Frank Richter Registergericht: Leipzig HRB 9065 Zertifiziert nach: ISO/IEC 27001:2013 DIN EN ISO 9001:2015 DIN ISO/IEC 2-1:2011 EWERK-Blog | LinkedIn | Xing | Twitter | Facebook Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. Disclaimer Privacy: Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank. The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you. > Am 14.02.2020 um 19:45 schrieb Daan Hoogland : > > Thanks all for the swift responses. Let's just start doing this. No need > for a vote until someone starts a discussion on the subject. Agree? > >> On Fri, 14 Feb 2020, 17:04 Rohit Yadav, wrote: >> >> +1 (better than changing the PR subject, putting wip-labels or [WIP]) >> >> Regards, >> >> Rohit Yadav >> >> Software Architect, ShapeBlue >> https://www.shapeblue.com >> >> rohit.ya...@shapeblue.com >> www.shapeblue.com >> @shapeblue >> >> >> >> -- >> *From:* Daan Hoogland >> *Sent:* Friday, February 14, 2020 17:33 >> *To:* dev >> *Subject:* [DISCUSS]/[PROPOSAL] draft PRs >> >> devs, I thought I had already sent a mail about this but i cannot find it. >> I'm sure i had mentioned it somewhere (probably on github). >> this is a follow up on [1] and hopefully you'll agree, a slight >> improvement. >> >> here it comes: >> >> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the >> title. This title stands the chance of being merged once we agree the PR is >> ready for merge. It also clutters the title. >> >> Github has introduced a nice feature a while ago; draft PR. When creating a >> PR you can opt not to open it for merge but as draft. Choose a button left >> of the "Create pull request" button, marked "Create draft PR". It will be a >> full PR with all CI and discussion possibilities open. The only difference >> is the merge button being disabled. One will than have to make/mark it >> "ready for merge" before it *can* be merged. >> >> [1] >> >> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E >> please shoot any comments you may have back at me, >> thanks >> >> -- >> Daan >>
Re: [DISCUSS]/[PROPOSAL] draft PRs
Thanks all for the swift responses. Let's just start doing this. No need for a vote until someone starts a discussion on the subject. Agree? On Fri, 14 Feb 2020, 17:04 Rohit Yadav, wrote: > +1 (better than changing the PR subject, putting wip-labels or [WIP]) > > Regards, > > Rohit Yadav > > Software Architect, ShapeBlue > https://www.shapeblue.com > > rohit.ya...@shapeblue.com > www.shapeblue.com > @shapeblue > > > > -- > *From:* Daan Hoogland > *Sent:* Friday, February 14, 2020 17:33 > *To:* dev > *Subject:* [DISCUSS]/[PROPOSAL] draft PRs > > devs, I thought I had already sent a mail about this but i cannot find it. > I'm sure i had mentioned it somewhere (probably on github). > this is a follow up on [1] and hopefully you'll agree, a slight > improvement. > > here it comes: > > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the > title. This title stands the chance of being merged once we agree the PR is > ready for merge. It also clutters the title. > > Github has introduced a nice feature a while ago; draft PR. When creating a > PR you can opt not to open it for merge but as draft. Choose a button left > of the "Create pull request" button, marked "Create draft PR". It will be a > full PR with all CI and discussion possibilities open. The only difference > is the merge button being disabled. One will than have to make/mark it > "ready for merge" before it *can* be merged. > > [1] > > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E > please shoot any comments you may have back at me, > thanks > > -- > Daan >
Re: [DISCUSS]/[PROPOSAL] draft PRs
+1 (better than changing the PR subject, putting wip-labels or [WIP]) Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com From: Daan Hoogland Sent: Friday, February 14, 2020 17:33 To: dev Subject: [DISCUSS]/[PROPOSAL] draft PRs devs, I thought I had already sent a mail about this but i cannot find it. I'm sure i had mentioned it somewhere (probably on github). this is a follow up on [1] and hopefully you'll agree, a slight improvement. here it comes: At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the title. This title stands the chance of being merged once we agree the PR is ready for merge. It also clutters the title. Github has introduced a nice feature a while ago; draft PR. When creating a PR you can opt not to open it for merge but as draft. Choose a button left of the "Create pull request" button, marked "Create draft PR". It will be a full PR with all CI and discussion possibilities open. The only difference is the merge button being disabled. One will than have to make/mark it "ready for merge" before it *can* be merged. [1] https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E please shoot any comments you may have back at me, thanks -- Daan rohit.ya...@shapeblue.com www.shapeblue.com 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK @shapeblue
Re: [DISCUSS]/[PROPOSAL] draft PRs
+1 From: Daan Hoogland Sent: Friday, February 14, 2020 6:03 AM To: dev Subject: [DISCUSS]/[PROPOSAL] draft PRs devs, I thought I had already sent a mail about this but i cannot find it. I'm sure i had mentioned it somewhere (probably on github). this is a follow up on [1] and hopefully you'll agree, a slight improvement. here it comes: At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the title. This title stands the chance of being merged once we agree the PR is ready for merge. It also clutters the title. Github has introduced a nice feature a while ago; draft PR. When creating a PR you can opt not to open it for merge but as draft. Choose a button left of the "Create pull request" button, marked "Create draft PR". It will be a full PR with all CI and discussion possibilities open. The only difference is the merge button being disabled. One will than have to make/mark it "ready for merge" before it *can* be merged. [1] https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E please shoot any comments you may have back at me, thanks -- Daan
Re: [DISCUSS]/[PROPOSAL] draft PRs
good idea. it seems all checks and tests can still work, from example https://github.com/apache/cloudstack/pull/3768 -Wei On Fri, 14 Feb 2020 at 13:03, Daan Hoogland wrote: > devs, I thought I had already sent a mail about this but i cannot find it. > I'm sure i had mentioned it somewhere (probably on github). > this is a follow up on [1] and hopefully you'll agree, a slight > improvement. > > here it comes: > > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the > title. This title stands the chance of being merged once we agree the PR is > ready for merge. It also clutters the title. > > Github has introduced a nice feature a while ago; draft PR. When creating a > PR you can opt not to open it for merge but as draft. Choose a button left > of the "Create pull request" button, marked "Create draft PR". It will be a > full PR with all CI and discussion possibilities open. The only difference > is the merge button being disabled. One will than have to make/mark it > "ready for merge" before it *can* be merged. > > [1] > > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E > please shoot any comments you may have back at me, > thanks > > -- > Daan >
Re: [DISCUSS]/[PROPOSAL] draft PRs
+1 from me :) On Fri, Feb 14, 2020, 09:48 Sven Vogel wrote: > +1 (The title are better readable) > > > __ > > Sven Vogel > Teamlead Platform > > EWERK DIGITAL GmbH > Brühl 24, D-04109 Leipzig > P +49 341 42649 - 99 > F +49 341 42649 - 98 > s.vo...@ewerk.com > www.ewerk.com > > Geschäftsführer: > Dr. Erik Wende, Hendrik Schubert, Frank Richter > Registergericht: Leipzig HRB 9065 > > Zertifiziert nach: > ISO/IEC 27001:2013 > DIN EN ISO 9001:2015 > DIN ISO/IEC 2-1:2011 > > EWERK-Blog | LinkedIn | Xing | Twitter | Facebook > > Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. > > Disclaimer Privacy: > Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist > vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der > bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, > Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte > informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie > die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. > Vielen Dank. > > The contents of this e-mail (including any attachments) are confidential > and may be legally privileged. If you are not the intended recipient of > this e-mail, any disclosure, copying, distribution or use of its contents > is strictly prohibited, and you should please notify the sender immediately > and then delete it (including any attachments) from your system. Thank you. > > Am 14.02.2020 um 13:42 schrieb Andrija Panic : > > > > +1 > > > >> On Fri, 14 Feb 2020 at 13:18, Wido den Hollander > wrote: > >> > >> > >> > >>> On 2/14/20 1:03 PM, Daan Hoogland wrote: > >>> devs, I thought I had already sent a mail about this but i cannot find > >> it. > >>> I'm sure i had mentioned it somewhere (probably on github). > >>> this is a follow up on [1] and hopefully you'll agree, a slight > >> improvement. > >>> > >>> here it comes: > >>> > >>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in > >> the > >>> title. This title stands the chance of being merged once we agree the > PR > >> is > >>> ready for merge. It also clutters the title. > >>> > >>> Github has introduced a nice feature a while ago; draft PR. When > >> creating a > >>> PR you can opt not to open it for merge but as draft. Choose a button > >> left > >>> of the "Create pull request" button, marked "Create draft PR". It will > >> be a > >>> full PR with all CI and discussion possibilities open. The only > >> difference > >>> is the merge button being disabled. One will than have to make/mark it > >>> "ready for merge" before it *can* be merged. > >>> > >> > >> That sounds like a good idea! Would be a +1 from me :-) > >> > >> Wido > >> > >>> [1] > >>> > >> > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E > >>> please shoot any comments you may have back at me, > >>> thanks > >>> > >> > > > > > > -- > > > > Andrija Panić >
[GitHub] [cloudstack-primate] shwstppr closed pull request #124: [WIP DO NOT MERGE] Add offering custom action
shwstppr closed pull request #124: [WIP DO NOT MERGE] Add offering custom action URL: https://github.com/apache/cloudstack-primate/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] shwstppr opened a new pull request #124: [WIP DO NOT MERGE] Add offering custom action
shwstppr opened a new pull request #124: [WIP DO NOT MERGE] Add offering custom action URL: https://github.com/apache/cloudstack-primate/pull/124 TODO: - [x] Compute Offering - [x] System offering - [x] Disk offering - [ ] Network offering - [x] VPC offering This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [DISCUSS]/[PROPOSAL] draft PRs
+1 (The title are better readable) __ Sven Vogel Teamlead Platform EWERK DIGITAL GmbH Brühl 24, D-04109 Leipzig P +49 341 42649 - 99 F +49 341 42649 - 98 s.vo...@ewerk.com www.ewerk.com Geschäftsführer: Dr. Erik Wende, Hendrik Schubert, Frank Richter Registergericht: Leipzig HRB 9065 Zertifiziert nach: ISO/IEC 27001:2013 DIN EN ISO 9001:2015 DIN ISO/IEC 2-1:2011 EWERK-Blog | LinkedIn | Xing | Twitter | Facebook Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. Disclaimer Privacy: Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank. The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you. > Am 14.02.2020 um 13:42 schrieb Andrija Panic : > > +1 > >> On Fri, 14 Feb 2020 at 13:18, Wido den Hollander wrote: >> >> >> >>> On 2/14/20 1:03 PM, Daan Hoogland wrote: >>> devs, I thought I had already sent a mail about this but i cannot find >> it. >>> I'm sure i had mentioned it somewhere (probably on github). >>> this is a follow up on [1] and hopefully you'll agree, a slight >> improvement. >>> >>> here it comes: >>> >>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in >> the >>> title. This title stands the chance of being merged once we agree the PR >> is >>> ready for merge. It also clutters the title. >>> >>> Github has introduced a nice feature a while ago; draft PR. When >> creating a >>> PR you can opt not to open it for merge but as draft. Choose a button >> left >>> of the "Create pull request" button, marked "Create draft PR". It will >> be a >>> full PR with all CI and discussion possibilities open. The only >> difference >>> is the merge button being disabled. One will than have to make/mark it >>> "ready for merge" before it *can* be merged. >>> >> >> That sounds like a good idea! Would be a +1 from me :-) >> >> Wido >> >>> [1] >>> >> https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E >>> please shoot any comments you may have back at me, >>> thanks >>> >> > > > -- > > Andrija Panić
Re: [DISCUSS]/[PROPOSAL] draft PRs
+1 On Fri, 14 Feb 2020 at 13:18, Wido den Hollander wrote: > > > On 2/14/20 1:03 PM, Daan Hoogland wrote: > > devs, I thought I had already sent a mail about this but i cannot find > it. > > I'm sure i had mentioned it somewhere (probably on github). > > this is a follow up on [1] and hopefully you'll agree, a slight > improvement. > > > > here it comes: > > > > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in > the > > title. This title stands the chance of being merged once we agree the PR > is > > ready for merge. It also clutters the title. > > > > Github has introduced a nice feature a while ago; draft PR. When > creating a > > PR you can opt not to open it for merge but as draft. Choose a button > left > > of the "Create pull request" button, marked "Create draft PR". It will > be a > > full PR with all CI and discussion possibilities open. The only > difference > > is the merge button being disabled. One will than have to make/mark it > > "ready for merge" before it *can* be merged. > > > > That sounds like a good idea! Would be a +1 from me :-) > > Wido > > > [1] > > > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E > > please shoot any comments you may have back at me, > > thanks > > > -- Andrija Panić
Re: [DISCUSS]/[PROPOSAL] draft PRs
On 2/14/20 1:03 PM, Daan Hoogland wrote: > devs, I thought I had already sent a mail about this but i cannot find it. > I'm sure i had mentioned it somewhere (probably on github). > this is a follow up on [1] and hopefully you'll agree, a slight improvement. > > here it comes: > > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the > title. This title stands the chance of being merged once we agree the PR is > ready for merge. It also clutters the title. > > Github has introduced a nice feature a while ago; draft PR. When creating a > PR you can opt not to open it for merge but as draft. Choose a button left > of the "Create pull request" button, marked "Create draft PR". It will be a > full PR with all CI and discussion possibilities open. The only difference > is the merge button being disabled. One will than have to make/mark it > "ready for merge" before it *can* be merged. > That sounds like a good idea! Would be a +1 from me :-) Wido > [1] > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E > please shoot any comments you may have back at me, > thanks >
[DISCUSS]/[PROPOSAL] draft PRs
devs, I thought I had already sent a mail about this but i cannot find it. I'm sure i had mentioned it somewhere (probably on github). this is a follow up on [1] and hopefully you'll agree, a slight improvement. here it comes: At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in the title. This title stands the chance of being merged once we agree the PR is ready for merge. It also clutters the title. Github has introduced a nice feature a while ago; draft PR. When creating a PR you can opt not to open it for merge but as draft. Choose a button left of the "Create pull request" button, marked "Create draft PR". It will be a full PR with all CI and discussion possibilities open. The only difference is the merge button being disabled. One will than have to make/mark it "ready for merge" before it *can* be merged. [1] https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bc68932%40%3Cdev.cloudstack.apache.org%3E please shoot any comments you may have back at me, thanks -- Daan
[GitHub] [cloudstack-primate] Pearl1594 commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form
Pearl1594 commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form URL: https://github.com/apache/cloudstack-primate/pull/154#issuecomment-586202478 @rhtyd I've added the Assigned VMs tab This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP] Feature/vm wizard
rhtyd commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586149008 @utchoang cc @svenvogel some review comments from testing the current branch: - Maybe template and ISO could be show in tabs instead of collapse? - Minor: show search bar like other steps for template/iso; the search bar could be above near to the place that may render on the right side of tabbed template/iso options - Once I accidently select disk offering, no way to de-select it. Give a radio button to say no disk offering etc. - Initially on the network step, if I select two networks, both are selected as default by the radio button - Given option (radio button) to not select any ssh key (if we select one, there is no way to de-select) - Minor nit: the launch button icon uses poweroff icon, instead maybe use a play or rocket icon? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #146: [WIP] Feature/vm wizard
rhtyd commented on issue #146: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/146#issuecomment-586146044 Nice @utchoang - is this complete, ready for review/testing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form
rhtyd commented on issue #154: [WIP] VPC: Add Internal LB form and Assign VM to LB rule form URL: https://github.com/apache/cloudstack-primate/pull/154#issuecomment-586143106 Please follow my changes/fixes @Pearl1594, the only remaining item is the assigned VMs tab  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
