Re: [PR] project: note on project roles [cloudstack-documentation]

2024-06-06 Thread via GitHub


shwstppr commented on PR #403:
URL: 
https://github.com/apache/cloudstack-documentation/pull/403#issuecomment-2154144603

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] project: note on project roles [cloudstack-documentation]

2024-06-06 Thread via GitHub


vishesh92 commented on code in PR #403:
URL: 
https://github.com/apache/cloudstack-documentation/pull/403#discussion_r1630687547


##
source/adminguide/projects.rst:
##
@@ -288,6 +288,16 @@ to add members in CloudStack, but only one way is enabled 
at a time:
the UI.
 
 
+Working with Project Roles
+--
+CloudStack allows adding project members with a desired project role. A
+project role will be assigned to the member in addition to their base
+account role. Project Roles are retrictive in nature and can be used to
+further restrict certain API access to the members within the project.
+Project roles can be created or managed using `Project roles` tab in the
+project details UI.

Review Comment:
   @shwstppr Just added the below line to be more clear.
   ```
It is important to note that a project role cannot be used to elevate an 
existing user's permissions.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] project: note on project roles [cloudstack-documentation]

2024-06-06 Thread via GitHub


vishesh92 commented on code in PR #403:
URL: 
https://github.com/apache/cloudstack-documentation/pull/403#discussion_r1630686861


##
source/adminguide/projects.rst:
##
@@ -288,6 +288,16 @@ to add members in CloudStack, but only one way is enabled 
at a time:
the UI.
 
 
+Working with Project Roles
+--
+CloudStack allows adding project members with a desired project role. A
+project role will be assigned to the member in addition to their base
+account role. Project Roles are retrictive in nature and can be used to
+further restrict certain API access to the members within the project.
+Project roles can be created or managed using `Project roles` tab in the
+project details UI.

Review Comment:
   ```suggestion
   further restrict certain API access to the members within the project.
   It is important to note that a project role cannot be used to elevate an
   existing user's permissions. Project roles can be created or managed
   using `Project roles` tab in the project details UI.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] project: note on project roles [cloudstack-documentation]

2024-06-06 Thread via GitHub


shwstppr commented on code in PR #403:
URL: 
https://github.com/apache/cloudstack-documentation/pull/403#discussion_r1630679591


##
source/adminguide/projects.rst:
##
@@ -288,6 +288,16 @@ to add members in CloudStack, but only one way is enabled 
at a time:
the UI.
 
 
+Working with Project Roles
+--
+CloudStack allows adding project members with a desired project role. A
+project role will be assigned to the member in addition to their base
+account role. Project Roles are retrictive in nature and can be used to
+further restrict certain API access to the members within the project.
+Project roles can be created or managed using `Project roles` tab in the
+project details UI.

Review Comment:
   I don't have any example. IMO, I don't see any utility of project roles in 
its current form. So, I just added what was informed to me. Happy to accept 
changes or close the PR for better changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] project: note on project roles [cloudstack-documentation]

2024-06-06 Thread via GitHub


vishesh92 commented on code in PR #403:
URL: 
https://github.com/apache/cloudstack-documentation/pull/403#discussion_r1630663862


##
source/adminguide/projects.rst:
##
@@ -288,6 +288,16 @@ to add members in CloudStack, but only one way is enabled 
at a time:
the UI.
 
 
+Working with Project Roles
+--
+CloudStack allows adding project members with a desired project role. A
+project role will be assigned to the member in addition to their base
+account role. Project Roles are retrictive in nature and can be used to
+further restrict certain API access to the members within the project.
+Project roles can be created or managed using `Project roles` tab in the
+project details UI.

Review Comment:
   IMO, this seems a little confusing. It will be good to add an example to 
explain this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fail when both network_id & vpc_id are set in ipaddress [cloudstack-terraform-provider]

2024-06-06 Thread via GitHub


vishesh92 commented on PR #99:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/99#issuecomment-2152883196

   > Why was this necessary, though @vishesh92? Is it implied that when using a 
network, it'll use the ID of the VPC that the network belongs to?
   > 
   > What about the following scenario:
   > 
   > ```
   > Error: Error associating a new IP address: Undefined error: 
{"errorcode":431,"errortext":"Can't assign ip to the network directly when 
network belongs to VPC.Specify vpcId to associate ip address to VPC"}
   > ```
   > 
   > Maybe a comment outlining this could be useful. I'm glad to add it if 
y'all agree that my statement is correct.
   
   @klaussilveira Yes. Public IPs get assigned to the VPC itself, which is the 
parent of its network tiers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fail when both network_id & vpc_id are set in ipaddress [cloudstack-terraform-provider]

2024-06-06 Thread via GitHub


klaussilveira commented on PR #99:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/99#issuecomment-2152849406

   Why was this necessary, though @vishesh92? Is it implied that when using a 
network, it'll use the ID of the VPC that the network belongs to?
   
   Maybe a comment outlining this could be useful. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-06-06 Thread via GitHub


vishesh92 commented on code in PR #46:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/46#discussion_r1629766415


##
util.go:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package cloudstack
+
+import (
+   "fmt"
+   "regexp"
+   "strings"
+)
+
+// If Instances.InstanceID or cloudprovider.GetInstanceProviderID is changed, 
the regexp should be changed too.
+var providerIDRegexp = regexp.MustCompile(`^` + ProviderName + 
`://([^/]*)/([^/]+)$`)

Review Comment:
   ```suggestion
   var providerIDRegexp = regexp.MustCompile(`^` + ProviderName + 
`://?([^/]*)/([^/]+)$`)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



RE: [Proposal] Storage Filesystem as a First Class Feature

2024-06-06 Thread Alex Mattioli
Fair points, thanks for the input.

Cheers
Alex

 


-Original Message-
From: Wido den Hollander  
Sent: Thursday, June 6, 2024 4:38 PM
To: dev@cloudstack.apache.org; Wei ZHOU 
Cc: Wei Zhou ; Abhisar Sinha 
; us...@cloudstack.apache.org
Subject: Re: [Proposal] Storage Filesystem as a First Class Feature



Op 06/06/2024 om 11:26 schreef Wei ZHOU:
>> @Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
>> implementation of IPv6) it should automatically get an IPv6 IP, correct?
> 
> yes,it should get Ipv6 addr advertised by cloudstack VR. @Alexblue.com 
> we need to make sure IPv6 is enabled in the storagefs vm (Ipv6 is 
> disabled by default in systemvm template as far as I know), and proper 
> firewall rules are applied.

Don't forget that you also need to make sure that your NFS /etc/exports file 
contains the IPv6 addresses of VMs who want to mount it. Otherwise it still 
doesn't work.

> 
>> @Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it 
>> take to add support to VirtioFS?  I'm not super aware of it, what would the 
>> benefits be? (I've quickly looked at Wido's links, but I rather get info 
>> from you guys directly).
> I see the benefits . However I do not know a strong use case of it.
> maybe @wido can advise ?

I haven't used it before because the support in Qemu + Libvirt is fairly new. 
The main benefit is that the end-user never has access to the NAS or storage 
network. The VM doesn't know if it's NFS or CephFS underneath, it simply has a 
filesystem. This takes away a lot of configuration inside the VM or needed 
software (CephFS drivers).

It adds additional security since the VM doesn't need to be able to talk to the 
storage device(s), only the hypervisors do this.

In the future Virtio-FS maybe gets support for rate limiting or other features. 
I personally think this is the way forward.

I would at least make sure it's understood that it exists and the code already 
takes this into account without making it a proper implementation from day one.

You would need to mount the FS on the hypervisor and then re-export it to the 
VM. This requires hooks to be executed for example.

Wido

> 
> On Thu, Jun 6, 2024 at 11:01 AM Alex Mattioli 
>  wrote:
>>
>>
>> @Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
>> implementation of IPv6) it should automatically get an IPv6 IP, correct?
>>
>> @Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it 
>> take to add support to VirtioFS?  I'm not super aware of it, what would the 
>> benefits be? (I've quickly looked at Wido's links, but I rather get info 
>> from you guys directly).
>>
>> Cheers
>> Alex
>>
>>
>>
>>
>> -Original Message-
>> From: Wei ZHOU 
>> Sent: Thursday, June 6, 2024 10:50 AM
>> To: dev@cloudstack.apache.org
>> Cc: Abhisar Sinha 
>> Subject: Re: [Proposal] Storage Filesystem as a First Class Feature
>>
>> Hi Wido,
>>
>> Thanks for your feedback.
>>
>> It is a great idea to support virtio-fs. We could add VIRTIOFS as a valid 
>> value of enum ExportProtocol, and implement it in a separate plugin in the 
>> future.
>> Have you tested virtio-fs before ? Could you share more info if possible?
>> - is it supported by libvirt-java ?
>> - does it support hot plug or hot unplug ?
>>
>> I agree with you that we should consider IPv6 (ip and firewall rules) in 
>> storagefs vm.
>> cc abhisar.si...@shapeblue.com
>>
>>
>> Kind regards,
>> Wei
>>
>> On Thu, Jun 6, 2024 at 6:43 AM Wido den Hollander  
>> wrote:
>>>
>>>
>>>
>>> Op 04/06/2024 om 06:04 schreef Abhisar Sinha:
 Hi,

 I would like to propose supporting storage filesystem as a first-class 
 feature in Cloudstack.
 The File Share can be associated with one or more guest networks or vpc 
 tiers and can be used by any VM on the network in a shared manner. It is 
 designed to be resizable and highly available. This feature can later be 
 used as integration endpoints with the CSI driver, go-sdk, Terraform, 
 Ansible and others.

 The draft functional spec is here :
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+File
 s
 ystem+as+a+First+Class+Feature

 Looking forward to your comments and suggestions.

>>>
>>> I think this is great! Especially the Storage VM. Few things to keep 
>>> in
>>> mind:
>>>
>>> - Have we thought about passthrough of FileSystems coming from the 
>>> HV and being passed through to the VM [0]
>>> - The StorageFsVm, can we make sure it supports IPv6 from the start, 
>>> best would be if it. Make sure all the code at least supports this 
>>> for ACLs and such. The VM itself should obtain an IPv6 address when 
>>> possible and open the proper ports in it's firewall
>>>
>>> Wido
>>>
>>> [0]:
>>> - https://virtio-fs.gitlab.io/
>>> - https://chrisirwin.ca/posts/sharing-host-files-with-kvm/
>>>
>>>
 Thanks,
 Abhisar






Re: [Proposal] Storage Filesystem as a First Class Feature

2024-06-06 Thread Wido den Hollander




Op 06/06/2024 om 11:26 schreef Wei ZHOU:

@Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
implementation of IPv6) it should automatically get an IPv6 IP, correct?


yes,it should get Ipv6 addr advertised by cloudstack VR. @Alexblue.com
we need to make sure IPv6 is enabled in the storagefs vm (Ipv6 is
disabled by default in systemvm template as far as I know), and proper
firewall rules are applied.


Don't forget that you also need to make sure that your NFS /etc/exports 
file contains the IPv6 addresses of VMs who want to mount it. Otherwise 
it still doesn't work.





@Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it take 
to add support to VirtioFS?  I'm not super aware of it, what would the benefits 
be? (I've quickly looked at Wido's links, but I rather get info from you guys 
directly).

I see the benefits . However I do not know a strong use case of it.
maybe @wido can advise ?


I haven't used it before because the support in Qemu + Libvirt is fairly 
new. The main benefit is that the end-user never has access to the NAS 
or storage network. The VM doesn't know if it's NFS or CephFS 
underneath, it simply has a filesystem. This takes away a lot of 
configuration inside the VM or needed software (CephFS drivers).


It adds additional security since the VM doesn't need to be able to talk 
to the storage device(s), only the hypervisors do this.


In the future Virtio-FS maybe gets support for rate limiting or other 
features. I personally think this is the way forward.


I would at least make sure it's understood that it exists and the code 
already takes this into account without making it a proper 
implementation from day one.


You would need to mount the FS on the hypervisor and then re-export it 
to the VM. This requires hooks to be executed for example.


Wido



On Thu, Jun 6, 2024 at 11:01 AM Alex Mattioli
 wrote:



@Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
implementation of IPv6) it should automatically get an IPv6 IP, correct?

@Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it take 
to add support to VirtioFS?  I'm not super aware of it, what would the benefits 
be? (I've quickly looked at Wido's links, but I rather get info from you guys 
directly).

Cheers
Alex




-Original Message-
From: Wei ZHOU 
Sent: Thursday, June 6, 2024 10:50 AM
To: dev@cloudstack.apache.org
Cc: Abhisar Sinha 
Subject: Re: [Proposal] Storage Filesystem as a First Class Feature

Hi Wido,

Thanks for your feedback.

It is a great idea to support virtio-fs. We could add VIRTIOFS as a valid value 
of enum ExportProtocol, and implement it in a separate plugin in the future.
Have you tested virtio-fs before ? Could you share more info if possible?
- is it supported by libvirt-java ?
- does it support hot plug or hot unplug ?

I agree with you that we should consider IPv6 (ip and firewall rules) in 
storagefs vm.
cc abhisar.si...@shapeblue.com


Kind regards,
Wei

On Thu, Jun 6, 2024 at 6:43 AM Wido den Hollander  
wrote:




Op 04/06/2024 om 06:04 schreef Abhisar Sinha:

Hi,

I would like to propose supporting storage filesystem as a first-class feature 
in Cloudstack.
The File Share can be associated with one or more guest networks or vpc tiers 
and can be used by any VM on the network in a shared manner. It is designed to 
be resizable and highly available. This feature can later be used as 
integration endpoints with the CSI driver, go-sdk, Terraform, Ansible and 
others.

The draft functional spec is here :
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Files
ystem+as+a+First+Class+Feature

Looking forward to your comments and suggestions.



I think this is great! Especially the Storage VM. Few things to keep
in
mind:

- Have we thought about passthrough of FileSystems coming from the HV
and being passed through to the VM [0]
- The StorageFsVm, can we make sure it supports IPv6 from the start,
best would be if it. Make sure all the code at least supports this for
ACLs and such. The VM itself should obtain an IPv6 address when
possible and open the proper ports in it's firewall

Wido

[0]:
- https://virtio-fs.gitlab.io/
- https://chrisirwin.ca/posts/sharing-host-files-with-kvm/



Thanks,
Abhisar






Re: [PR] add APIs [cloudstack-go]

2024-06-06 Thread via GitHub


ahmedali6 commented on PR #88:
URL: https://github.com/apache/cloudstack-go/pull/88#issuecomment-2152680006

   @rohityadavcloud 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-06-06 Thread via GitHub


weizhouapache commented on PR #46:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152665390

   > Yes. I did change that. Before that pod was crashing due to wrong provider 
name.
   
   According to the pr, the providerID should have 3 slashes instead of 2.
   
   cloudstack://2d35066b should be cloudstack:///2d35066b


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-06-06 Thread via GitHub


vishesh92 commented on PR #46:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152646446

   Yes. I did change that. Before that pod was crashing due to wrong provider 
name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-06-06 Thread via GitHub


weizhouapache commented on PR #46:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152641282

   > I am seeing the below errors after applying the changes. I am not sure 
about the root cause.
   > I launched a CKS cluster and updated the image.
   > ```go
   > E0606 13:02:31.408425   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:36.515139   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:37.025198   1 node_controller.go:249] Error getting 
instance metadata for node addresses: ProviderID "" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:37.025248   1 node_controller.go:249] Error getting 
instance metadata for node addresses: ProviderID "" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:37.025255   1 node_controller.go:249] Error getting 
instance metadata for node addresses: ProviderID "" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:37.025261   1 node_controller.go:249] Error getting 
instance metadata for node addresses: ProviderID "" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:37.025267   1 node_controller.go:249] Error getting 
instance metadata for node addresses: ProviderID "" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:41.584449   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   > E0606 13:02:46.648644   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   > ```
   
   @vishesh92 did you change the provider name from external-cloudstack to 
cloudstack?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-06-06 Thread via GitHub


vishesh92 commented on PR #46:
URL: 
https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2152411619

   I am seeing the below errors after applying the changes. I am not sure about 
the root cause.
   I launched a CKS cluster and updated the image.
   ```go
   E0606 13:02:31.408425   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   E0606 13:02:36.515139   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   E0606 13:02:37.025198   1 node_controller.go:249] Error getting instance 
metadata for node addresses: ProviderID "" didn't match expected format 
"cloudstack://region/InstanceID"
   E0606 13:02:37.025248   1 node_controller.go:249] Error getting instance 
metadata for node addresses: ProviderID "" didn't match expected format 
"cloudstack://region/InstanceID"
   E0606 13:02:37.025255   1 node_controller.go:249] Error getting instance 
metadata for node addresses: ProviderID "" didn't match expected format 
"cloudstack://region/InstanceID"
   E0606 13:02:37.025261   1 node_controller.go:249] Error getting instance 
metadata for node addresses: ProviderID "" didn't match expected format 
"cloudstack://region/InstanceID"
   E0606 13:02:37.025267   1 node_controller.go:249] Error getting instance 
metadata for node addresses: ProviderID "" didn't match expected format 
"cloudstack://region/InstanceID"
   E0606 13:02:41.584449   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   E0606 13:02:46.648644   1 node_lifecycle_controller.go:149] error 
checking if node k8s-1273-node-18f3588c91c exists: ProviderID 
"cloudstack://2d35066b-a8e4-4c2a-b400-256db0a7d2cd" didn't match expected 
format "cloudstack://region/InstanceID"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



CSEUG Germany - Frankfurt, September 12th

2024-06-06 Thread Ivet Petrova
Hi all,

I am writing to remind that on September 12th, we will be having the CloudStack 
EU User Group, organised and hosted by proIO in Frankfurt, Germany.
The CFP is now open and will close on August 2nd: 
https://forms.gle/KzvUp5cAHaoJQLjf7
Please, submit a talk on the form above. All talks - from user stories to 
technical presentations and workshops are welcome. However considering this is 
a 1-day event, there is limited capacity for speakers, so ensure you submit a 
talk fast.

Also you can register for the event here: 
https://www.eventbrite.com/e/cloudstack-european-user-group-germany-tickets-879369205967



Best regards,


 



[PR] project: note on project roles [cloudstack-documentation]

2024-06-06 Thread via GitHub


shwstppr opened a new pull request, #403:
URL: https://github.com/apache/cloudstack-documentation/pull/403

   Addresses https://github.com/apache/cloudstack/issues/9071


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: Help setting up Cloud Stack development environment

2024-06-06 Thread Wei ZHOU
Hi Gaurav,

Welcome to the community.

I suggest you create a docker container (for instance, rocky8/9 or
ubuntu 22.04). The doc is out-of-date.

-Wei

On Thu, Jun 6, 2024 at 12:43 PM gaurav joshi  wrote:
>
> Hi,
>
> I have been trying to set up my cloudstack dev environment in Windows but I 
> am facing some issues. It will be helpful if I can get some guidance as I am 
> new to this environment and cloud on whole.
> I followed the steps as mentioned in this link :
> Setting up a CloudStack dev environment on Windows - Apache Cloudstack - 
> Apache Software Foundation
>
> I installed cygwin and followed all the steps as mentioned . On executing 
> step 13
> And running command :
> mvn -Pdeveloper,systemvm clean install -DskipTests
>
> I receive the following error
> "Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec"
>
> I have attached the screenshot of the error for your reference.
>
> I am using OS - Windows 11 Pro
> I am running this code after taking the
> git clone https://github.com/apache/cloudstack.git
> git checkout 4.19
>
> Also I would like to ask if there is an updated version of this document.
>
> I would be really grateful for any help on this topic.
>
> Thanks and Regards,
> Gaurav Joshi
>


Re: Help setting up Cloud Stack development environment

2024-06-06 Thread Daan Hoogland
Gaurav,
please attach the textual errors (screenshots are less helpful and
usually filtered of this mailing list).

On Thu, Jun 6, 2024 at 12:42 PM gaurav joshi  wrote:
>
> Hi,
>
> I have been trying to set up my cloudstack dev environment in Windows but I 
> am facing some issues. It will be helpful if I can get some guidance as I am 
> new to this environment and cloud on whole.
> I followed the steps as mentioned in this link :
> Setting up a CloudStack dev environment on Windows - Apache Cloudstack - 
> Apache Software Foundation
>
> I installed cygwin and followed all the steps as mentioned . On executing 
> step 13
> And running command :
> mvn -Pdeveloper,systemvm clean install -DskipTests
>
> I receive the following error
> "Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec"
>
> I have attached the screenshot of the error for your reference.
>
> I am using OS - Windows 11 Pro
> I am running this code after taking the
> git clone https://github.com/apache/cloudstack.git
> git checkout 4.19
>
> Also I would like to ask if there is an updated version of this document.
>
> I would be really grateful for any help on this topic.
>
> Thanks and Regards,
> Gaurav Joshi
>


-- 
Daan


Help setting up Cloud Stack development environment

2024-06-06 Thread gaurav joshi
Hi,

I have been trying to set up my cloudstack dev environment in Windows but I am 
facing some issues. It will be helpful if I can get some guidance as I am new 
to this environment and cloud on whole.
I followed the steps as mentioned in this link :
Setting up a CloudStack dev environment on Windows - Apache Cloudstack - Apache 
Software 
Foundation

I installed cygwin and followed all the steps as mentioned . On executing step 
13
And running command :
mvn -Pdeveloper,systemvm clean install -DskipTests

I receive the following error
"Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec"

I have attached the screenshot of the error for your reference.

I am using OS - Windows 11 Pro
I am running this code after taking the
git clone https://github.com/apache/cloudstack.git
git checkout 4.19

Also I would like to ask if there is an updated version of this document.

I would be really grateful for any help on this topic.

Thanks and Regards,
Gaurav Joshi



Re: [Proposal] Storage Filesystem as a First Class Feature

2024-06-06 Thread Wei ZHOU
> @Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
> implementation of IPv6) it should automatically get an IPv6 IP, correct?

yes,it should get Ipv6 addr advertised by cloudstack VR. @Alexblue.com
we need to make sure IPv6 is enabled in the storagefs vm (Ipv6 is
disabled by default in systemvm template as far as I know), and proper
firewall rules are applied.

> @Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it 
> take to add support to VirtioFS?  I'm not super aware of it, what would the 
> benefits be? (I've quickly looked at Wido's links, but I rather get info from 
> you guys directly).
I see the benefits . However I do not know a strong use case of it.
maybe @wido can advise ?

On Thu, Jun 6, 2024 at 11:01 AM Alex Mattioli
 wrote:
>
>
> @Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
> implementation of IPv6) it should automatically get an IPv6 IP, correct?
>
> @Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it 
> take to add support to VirtioFS?  I'm not super aware of it, what would the 
> benefits be? (I've quickly looked at Wido's links, but I rather get info from 
> you guys directly).
>
> Cheers
> Alex
>
>
>
>
> -Original Message-
> From: Wei ZHOU 
> Sent: Thursday, June 6, 2024 10:50 AM
> To: dev@cloudstack.apache.org
> Cc: Abhisar Sinha 
> Subject: Re: [Proposal] Storage Filesystem as a First Class Feature
>
> Hi Wido,
>
> Thanks for your feedback.
>
> It is a great idea to support virtio-fs. We could add VIRTIOFS as a valid 
> value of enum ExportProtocol, and implement it in a separate plugin in the 
> future.
> Have you tested virtio-fs before ? Could you share more info if possible?
> - is it supported by libvirt-java ?
> - does it support hot plug or hot unplug ?
>
> I agree with you that we should consider IPv6 (ip and firewall rules) in 
> storagefs vm.
> cc abhisar.si...@shapeblue.com
>
>
> Kind regards,
> Wei
>
> On Thu, Jun 6, 2024 at 6:43 AM Wido den Hollander  
> wrote:
> >
> >
> >
> > Op 04/06/2024 om 06:04 schreef Abhisar Sinha:
> > > Hi,
> > >
> > > I would like to propose supporting storage filesystem as a first-class 
> > > feature in Cloudstack.
> > > The File Share can be associated with one or more guest networks or vpc 
> > > tiers and can be used by any VM on the network in a shared manner. It is 
> > > designed to be resizable and highly available. This feature can later be 
> > > used as integration endpoints with the CSI driver, go-sdk, Terraform, 
> > > Ansible and others.
> > >
> > > The draft functional spec is here :
> > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Files
> > > ystem+as+a+First+Class+Feature
> > >
> > > Looking forward to your comments and suggestions.
> > >
> >
> > I think this is great! Especially the Storage VM. Few things to keep
> > in
> > mind:
> >
> > - Have we thought about passthrough of FileSystems coming from the HV
> > and being passed through to the VM [0]
> > - The StorageFsVm, can we make sure it supports IPv6 from the start,
> > best would be if it. Make sure all the code at least supports this for
> > ACLs and such. The VM itself should obtain an IPv6 address when
> > possible and open the proper ports in it's firewall
> >
> > Wido
> >
> > [0]:
> > - https://virtio-fs.gitlab.io/
> > - https://chrisirwin.ca/posts/sharing-host-files-with-kvm/
> >
> >
> > > Thanks,
> > > Abhisar
> > >
> > >
> > >
> > >


Re: [PR] Update documentation for strict host tags [cloudstack-documentation]

2024-06-06 Thread via GitHub


andrijapanicsb commented on PR #398:
URL: 
https://github.com/apache/cloudstack-documentation/pull/398#issuecomment-2151803819

   I think it makes more sense now, yes. Thanks Vishesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



RE: [Proposal] Storage Filesystem as a First Class Feature

2024-06-06 Thread Alex Mattioli

@Wei Zhou If the network into which the StorageVM runs IPv6 (as per your 
implementation of IPv6) it should automatically get an IPv6 IP, correct?

@Wido den Hollander @Wei ZhouHow much effort do you guys thing it would it take 
to add support to VirtioFS?  I'm not super aware of it, what would the benefits 
be? (I've quickly looked at Wido's links, but I rather get info from you guys 
directly).

Cheers
Alex 

 


-Original Message-
From: Wei ZHOU  
Sent: Thursday, June 6, 2024 10:50 AM
To: dev@cloudstack.apache.org
Cc: Abhisar Sinha 
Subject: Re: [Proposal] Storage Filesystem as a First Class Feature

Hi Wido,

Thanks for your feedback.

It is a great idea to support virtio-fs. We could add VIRTIOFS as a valid value 
of enum ExportProtocol, and implement it in a separate plugin in the future.
Have you tested virtio-fs before ? Could you share more info if possible?
- is it supported by libvirt-java ?
- does it support hot plug or hot unplug ?

I agree with you that we should consider IPv6 (ip and firewall rules) in 
storagefs vm.
cc abhisar.si...@shapeblue.com


Kind regards,
Wei

On Thu, Jun 6, 2024 at 6:43 AM Wido den Hollander  
wrote:
>
>
>
> Op 04/06/2024 om 06:04 schreef Abhisar Sinha:
> > Hi,
> >
> > I would like to propose supporting storage filesystem as a first-class 
> > feature in Cloudstack.
> > The File Share can be associated with one or more guest networks or vpc 
> > tiers and can be used by any VM on the network in a shared manner. It is 
> > designed to be resizable and highly available. This feature can later be 
> > used as integration endpoints with the CSI driver, go-sdk, Terraform, 
> > Ansible and others.
> >
> > The draft functional spec is here : 
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Files
> > ystem+as+a+First+Class+Feature
> >
> > Looking forward to your comments and suggestions.
> >
>
> I think this is great! Especially the Storage VM. Few things to keep 
> in
> mind:
>
> - Have we thought about passthrough of FileSystems coming from the HV 
> and being passed through to the VM [0]
> - The StorageFsVm, can we make sure it supports IPv6 from the start, 
> best would be if it. Make sure all the code at least supports this for 
> ACLs and such. The VM itself should obtain an IPv6 address when 
> possible and open the proper ports in it's firewall
>
> Wido
>
> [0]:
> - https://virtio-fs.gitlab.io/
> - https://chrisirwin.ca/posts/sharing-host-files-with-kvm/
>
>
> > Thanks,
> > Abhisar
> >
> >
> >
> >


Re: [Proposal] Storage Filesystem as a First Class Feature

2024-06-06 Thread Wei ZHOU
Hi Wido,

Thanks for your feedback.

It is a great idea to support virtio-fs. We could add VIRTIOFS as a
valid value of enum ExportProtocol, and implement it in a separate
plugin in the future.
Have you tested virtio-fs before ? Could you share more info if possible?
- is it supported by libvirt-java ?
- does it support hot plug or hot unplug ?

I agree with you that we should consider IPv6 (ip and firewall rules)
in storagefs vm.
cc abhisar.si...@shapeblue.com


Kind regards,
Wei

On Thu, Jun 6, 2024 at 6:43 AM Wido den Hollander
 wrote:
>
>
>
> Op 04/06/2024 om 06:04 schreef Abhisar Sinha:
> > Hi,
> >
> > I would like to propose supporting storage filesystem as a first-class 
> > feature in Cloudstack.
> > The File Share can be associated with one or more guest networks or vpc 
> > tiers and can be used by any VM on the network in a shared manner. It is 
> > designed to be resizable and highly available. This feature can later be 
> > used as integration endpoints with the CSI driver, go-sdk, Terraform, 
> > Ansible and others.
> >
> > The draft functional spec is here : 
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Filesystem+as+a+First+Class+Feature
> >
> > Looking forward to your comments and suggestions.
> >
>
> I think this is great! Especially the Storage VM. Few things to keep in
> mind:
>
> - Have we thought about passthrough of FileSystems coming from the HV
> and being passed through to the VM [0]
> - The StorageFsVm, can we make sure it supports IPv6 from the start,
> best would be if it. Make sure all the code at least supports this for
> ACLs and such. The VM itself should obtain an IPv6 address when possible
> and open the proper ports in it's firewall
>
> Wido
>
> [0]:
> - https://virtio-fs.gitlab.io/
> - https://chrisirwin.ca/posts/sharing-host-files-with-kvm/
>
>
> > Thanks,
> > Abhisar
> >
> >
> >
> >


RE: [Proposal] Storage Filesystem as a First Class Feature

2024-06-06 Thread Alex Mattioli
Hi Wido,

The StorageVM will receive an IP from the Isolated network (or VPC tier) it 
belongs to. If that network is setup for IPv6 (or dual-stack), then the 
StorageVM will use IPv6. 

Regarding file system pass through, that's definitely an possible enhancement 
for a future version, we'd like to keep this one as simple as we can for now.

Cheers
Alex

 


-Original Message-
From: Wido den Hollander  
Sent: Thursday, June 6, 2024 6:43 AM
To: dev@cloudstack.apache.org; Abhisar Sinha 
Subject: Re: [Proposal] Storage Filesystem as a First Class Feature



Op 04/06/2024 om 06:04 schreef Abhisar Sinha:
> Hi,
> 
> I would like to propose supporting storage filesystem as a first-class 
> feature in Cloudstack.
> The File Share can be associated with one or more guest networks or vpc tiers 
> and can be used by any VM on the network in a shared manner. It is designed 
> to be resizable and highly available. This feature can later be used as 
> integration endpoints with the CSI driver, go-sdk, Terraform, Ansible and 
> others.
> 
> The draft functional spec is here : 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Filesys
> tem+as+a+First+Class+Feature
> 
> Looking forward to your comments and suggestions.
> 

I think this is great! Especially the Storage VM. Few things to keep in
mind:

- Have we thought about passthrough of FileSystems coming from the HV and being 
passed through to the VM [0]
- The StorageFsVm, can we make sure it supports IPv6 from the start, best would 
be if it. Make sure all the code at least supports this for ACLs and such. The 
VM itself should obtain an IPv6 address when possible and open the proper ports 
in it's firewall

Wido

[0]:
- https://virtio-fs.gitlab.io/
- https://chrisirwin.ca/posts/sharing-host-files-with-kvm/


> Thanks,
> Abhisar
> 
>   
> 
> 


H10 Tribeca Hotel and other hotels- CloudStack Collaboration Conference 2024

2024-06-06 Thread Ivet Petrova
Hi all,

I am writing to share that we have agreed with the H10 Tribeca Hotel in Madrid 
to be the official accommodation for all people, who would like to book a room 
for the yearly CloudStack Collaboration Conference 2024.
https://www.h10hotels.com/en/madrid-hotels/h10-tribeca/booking

If you would like to stay at the same place as the other event attendees, 
please book a room there. The prices for the hotel fluctuate on a daily basis, 
and we agreed for a fixed price of 175 EUR for a twin room with breakfast 
included.
However, I would suggest you check what price the hotel will offer without and 
with promo code and then make the final booking to get the best price.
The team at ShapeBlue and a few other people already booked our rooms there.

In terms of the booking, I would like to remind the event agenda:
Nov 20 - Hackathon
Nov 21 - official event opening, talks, workshops, drinks in the eveing
Nov 22  - talks, workshops, event closes.

Other hotels, which are nearby the event space Orense 34 
(https://www.meetingplace.es/en/orense-34/) are:
1. AC Hotel Aitana
2. NYX Madrid
3. Canopy by Hilton Madrid Castellana
4. Espahotel Plaza Basílica
5. Hotel Luze Castellana


Best regards,