Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50417 --- Commit 76cecc325fca5ead8b610c49608cb8fe8a4395c5 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=76cecc3 ] CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- (Updated Aug. 12, 2014, 11:04 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7284 https://issues.apache.org/jira/browse/CLOUDSTACK-7284 Repository: cloudstack-git Description --- The test case was failing while listing the VM after destroying it and verifying that it is destroyed. As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. Diffs - test/integration/component/test_add_remove_network.py 2bd6ec2 Diff: https://reviews.apache.org/r/24599/diff/ Testing --- Yes. Log: update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === ok -- Ran 1 test in 394.165s OK Thanks, Gaurav Aradhye
Re: Review Request 24544: CLOUDSTACK-7294: Passing listall =True for listUsers api admin call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24544/#review50421 --- Commit 9d7b85153747dfe378031455fc1231bcd6088d08 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9d7b851 ] CLOUDSTACK-7294: Passing listall=True for listUser api admin call - ASF Subversion and Git Services On Aug. 11, 2014, 10:20 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24544/ --- (Updated Aug. 11, 2014, 10:20 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7294 https://issues.apache.org/jira/browse/CLOUDSTACK-7294 Repository: cloudstack-git Description --- According to API changes (https://cwiki.apache.org/confluence/display/CLOUDSTACK/List*+API+commands+rules), listall parameter is necessary when admin wants to list the resources which belong to some other account. Adding domainid and listall parameter while making listUsers api call through admin. Diffs - tools/marvin/marvin/cloudstackTestClient.py 1ca79ee Diff: https://reviews.apache.org/r/24544/diff/ Testing --- Yes. Tested two failing test cases with this change. Test Deploy VM with 4 core CPU verify the usage ... === TestName: test_01_multiple_core_vm_start_stop_instance | Status : SUCCESS === ok -- Ran 1 test in 627.195s OK @summary: Test List IP Addresses pagination ... === TestName: test_01_list_ipaddresses_pagination | Status : SUCCESS === ok -- Ran 1 test in 32.022s OK Thanks, Gaurav Aradhye
Re: Review Request 24644: CLOUDSTACK-7329: Fixed issues in test_region_vpc.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24644/#review50446 --- Commit 525ee4a4aada2aa90bf53b301151f20111788e65 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=525ee4a ] CLOUDSTACK-7329: Fixed issues in test_region_vpc.py Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 13, 2014, 11:08 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24644/ --- (Updated Aug. 13, 2014, 11:08 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7329 https://issues.apache.org/jira/browse/CLOUDSTACK-7329 Repository: cloudstack-git Description --- 1) Fixed imports 2) Changed the services input, it should be read from the test case itself 3) Corrected the attribute names 4) Removed unused variables 5) Added check for OVS network service provider is enabled or not. Skip the test case if it is not enabled, in that case creating region level VPC is not possible. Diffs - test/integration/component/test_region_vpc.py e348065 Diff: https://reviews.apache.org/r/24644/diff/ Testing --- Yes: I have tested on setup with Ovs disabled. Log: Test create VPC offering ... === TestName: test_01_create_vpc_offering_with_regionlevelvpc_service_capability | Status : SUCCESS === ok Test create VPC offering ... SKIP: OVS plugin should be enabled to run this test case Test deploy virtual machines in VPC networks ... SKIP: OVS plugin should be enabled to run this test case -- Ran 3 tests in 16.914s OK (SKIP=2) Thanks, Gaurav Aradhye
Re: Review Request 24643: CLOUDSTACK-7330: fixed ListNetworks issue in test_portable_ip.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24643/#review50448 --- Commit b7c4259d9750cffe0cd0796b1434b39bff185b4d in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b7c4259 ] CLOUDSTACK-7330: Fixing ListNetworks issue in test_portable_ip.py Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 13, 2014, 10:47 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24643/ --- (Updated Aug. 13, 2014, 10:47 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7330 https://issues.apache.org/jira/browse/CLOUDSTACK-7330 Repository: cloudstack-git Description --- ListNetwork was failing because listall=True was not passed. Also fixed other issues in the test case. Diffs - test/integration/component/test_persistent_networks.py b242579 tools/marvin/marvin/lib/common.py 62d409c Diff: https://reviews.apache.org/r/24643/diff/ Testing --- Yes. Log: test_vpc_delete_account (test_persistent_networks.TestVPCNetworkOperations) ... SKIP: skip test_vpc_force_delete_domain (test_persistent_networks.TestVPCNetworkOperations) ... === TestName: test_vpc_force_delete_domain | Status : SUCCESS === ok test_vpc_private_gateway_static_route (test_persistent_networks.TestVPCNetworkOperations) ... SKIP: WIP -- Ran 3 tests in 340.698s OK (SKIP=2) Thanks, Gaurav Aradhye
Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50449 --- Commit f6bde7b46bb09aa13cb35049716bd7e1fc5b7774 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f6bde7b ] CLOUDSTACK-7284: Fixed string issue in test_snapshots.py - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- (Updated Aug. 12, 2014, 11:04 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7284 https://issues.apache.org/jira/browse/CLOUDSTACK-7284 Repository: cloudstack-git Description --- The test case was failing while listing the VM after destroying it and verifying that it is destroyed. As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. Diffs - test/integration/component/test_add_remove_network.py 2bd6ec2 Diff: https://reviews.apache.org/r/24599/diff/ Testing --- Yes. Log: update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === ok -- Ran 1 test in 394.165s OK Thanks, Gaurav Aradhye
Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50453 --- Commit 5f893daa2cab381aef6ac59eeebe923373c4ea80 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5f893da ] CLOUDSTACK-7284: Fixed regression issue in test_escalations_instances.py - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- (Updated Aug. 12, 2014, 11:04 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7284 https://issues.apache.org/jira/browse/CLOUDSTACK-7284 Repository: cloudstack-git Description --- The test case was failing while listing the VM after destroying it and verifying that it is destroyed. As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. Diffs - test/integration/component/test_add_remove_network.py 2bd6ec2 Diff: https://reviews.apache.org/r/24599/diff/ Testing --- Yes. Log: update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === ok -- Ran 1 test in 394.165s OK Thanks, Gaurav Aradhye
Re: Review Request 24549: CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24549/#review50301 --- Commit 6568e0bb31103ec9148a5c967db6563ca9af4307 in cloudstack's branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6568e0b ] CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO Signed-off-by: Koushik Das kous...@apache.org - ASF Subversion and Git Services On Aug. 12, 2014, 11:03 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24549/ --- (Updated Aug. 12, 2014, 11:03 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-7305 https://issues.apache.org/jira/browse/CLOUDSTACK-7305 Repository: cloudstack-git Description --- CLOUDSTACK-7305: User vms are not expunging which are failed to deploy from ISO when hypervisor parameter is not passed hypervisor type parameter is mandatory when deploying VM using ISO Diffs - api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8ceccb9 server/src/com/cloud/vm/UserVmManagerImpl.java 05cc183 Diff: https://reviews.apache.org/r/24549/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't apply
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23982/#review50306 --- Commit d75961d973021fbfec5058d907923f885ac8906a in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d75961d ] CLOUDSTACK-7192: Skip tests on Hyper-V which don't apply - ASF Subversion and Git Services On Aug. 6, 2014, 2:41 p.m., John Dilley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23982/ --- (Updated Aug. 6, 2014, 2:41 p.m.) Review request for cloudstack, sanjeev n and Santhosh Edukulla. Bugs: CLOUDSTACK-7192 https://issues.apache.org/jira/browse/CLOUDSTACK-7192 Repository: cloudstack-git Description --- A number of tests in the following files don't apply to Hyper-V. This patch means they are skipped if an attempt is made to run them. test_nic.py test_primary_storage.py test_scale_vm.py test_snapshots.py test_vm_snapshots.py test_volumes.py(test7 and test8 only) Diffs - test/integration/smoke/test_nic.py dd6de96 test/integration/smoke/test_primary_storage.py 66aec59 test/integration/smoke/test_scale_vm.py b5c89be test/integration/smoke/test_snapshots.py 8b6fdd1 test/integration/smoke/test_vm_snapshots.py 01626f5 test/integration/smoke/test_volumes.py 6e9ea75 Diff: https://reviews.apache.org/r/23982/diff/ Testing --- Thanks, John Dilley
Re: Review Request 24547: CLOUDSTACK-7304: Fixed Exception not raised issue in portable IP test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24547/#review50312 --- Commit d3f75618e7aeca5586d494c217ad5b6d3dcfd3c2 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d3f7561 ] CLOUDSTACK-7304: Fixed Exception not raised issue in portable IP test cases Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 11, 2014, 12:14 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24547/ --- (Updated Aug. 11, 2014, 12:14 p.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7304 https://issues.apache.org/jira/browse/CLOUDSTACK-7304 Repository: cloudstack-git Description --- The test cases failed because the list API did not throw exception, but returned None. Discussed with Alena, in case of IP addresses, when the IP is disassociated then it will return None for list call as it is retained in the database but is not in allocated state. Changed the test case accordingly. These two cases failed from past 4 builds only. Diffs - test/integration/component/test_portable_ip.py b9c9059 Diff: https://reviews.apache.org/r/24547/diff/ Testing --- Yes. Log: test delete account with portable ip with no services enabled ... === TestName: test_delete_account_services_disabled | Status : SUCCESS === ok test delete account with portable ip with PF and firewall services enabled ... === TestName: test_delete_account_services_enabled | Status : SUCCESS === ok -- Ran 2 tests in 359.275s OK Thanks, Gaurav Aradhye
Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50321 --- Commit 07abf7d7c1cd4953bea0322f21aeb8379fc49e14 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=07abf7d ] CLOUDSTACK-7284: Fixed VM delete issue, expunge not allowed by user api client - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- (Updated Aug. 12, 2014, 11:04 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7284 https://issues.apache.org/jira/browse/CLOUDSTACK-7284 Repository: cloudstack-git Description --- The test case was failing while listing the VM after destroying it and verifying that it is destroyed. As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. Diffs - test/integration/component/test_add_remove_network.py 2bd6ec2 Diff: https://reviews.apache.org/r/24599/diff/ Testing --- Yes. Log: update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === ok -- Ran 1 test in 394.165s OK Thanks, Gaurav Aradhye
Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50320 --- Commit 045a290cec2dbdf9b284934a4cd92836c227d513 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=045a290 ] CLOUDSTACK-7284: Fixed cleanup issue in test_escalations_snapshots.py - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- (Updated Aug. 12, 2014, 11:04 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7284 https://issues.apache.org/jira/browse/CLOUDSTACK-7284 Repository: cloudstack-git Description --- The test case was failing while listing the VM after destroying it and verifying that it is destroyed. As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. Diffs - test/integration/component/test_add_remove_network.py 2bd6ec2 Diff: https://reviews.apache.org/r/24599/diff/ Testing --- Yes. Log: update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === ok -- Ran 1 test in 394.165s OK Thanks, Gaurav Aradhye
Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50322 --- Commit 97ecd5575c4b408ecb4e08a1b81933bb703b324a in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=97ecd55 ] CLOUDSTACK-7284: Fixed cleanup issue in test_escalations_instances.py, VM should be deleted before deleting the network - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/ --- (Updated Aug. 12, 2014, 11:04 a.m.) Review request for cloudstack, Doug Clark and Santhosh Edukulla. Bugs: CLOUDSTACK-7284 https://issues.apache.org/jira/browse/CLOUDSTACK-7284 Repository: cloudstack-git Description --- The test case was failing while listing the VM after destroying it and verifying that it is destroyed. As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. Diffs - test/integration/component/test_add_remove_network.py 2bd6ec2 Diff: https://reviews.apache.org/r/24599/diff/ Testing --- Yes. Log: update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === ok -- Ran 1 test in 394.165s OK Thanks, Gaurav Aradhye
Re: Review Request 24542: CLOUDSTACK-7302: UI: Removed Hover Interaction from breadcrumbs at top page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24542/#review50351 --- Commit af377430453ecf1fb9b44ed3e29541b7f20ce5d5 in cloudstack's branch refs/heads/master from Mihaela Stoica [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=af37743 ] CLOUDSTACK-7302: UI: Remove Hover Interaction from breadcrumbs at top page Signed-off-by: Mihaela Stoica mihaela.sto...@citrix.com - ASF Subversion and Git Services On Aug. 11, 2014, 8:06 a.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24542/ --- (Updated Aug. 11, 2014, 8:06 a.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Removed the pop-up displayed when hovering over breadcrumbs at the top of the page. Diffs - ui/scripts/ui/widgets/cloudBrowser.js 31ac533 Diff: https://reviews.apache.org/r/24542/diff/ Testing --- Thanks, Mihaela Stoica
Re: Review Request 22939: CLOUDSTACK-6460 - CLVM primary storage migration fails due to incorrect identification of source format.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22939/#review50023 --- Commit 536ec0578111cf85e93122deaf9a95270d66f778 in cloudstack's branch refs/heads/hotfix/4.4-6460 from Simon Weller [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=536ec05 ] CLOUDSTACK-6460 - Force RAW when storage type is CLVM. Fixes primary storage migration for CLVM Signed-off-by: Daan Hoogland d...@onecht.net - ASF Subversion and Git Services On July 23, 2014, 4:30 p.m., Simon Weller wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22939/ --- (Updated July 23, 2014, 4:30 p.m.) Review request for cloudstack, edison su and Marcus Sorensen. Bugs: CLOUDSTACK-6460 https://issues.apache.org/jira/browse/CLOUDSTACK-6460 Repository: cloudstack-git Description --- Addresses CLOUDSTACK-6460. CLVM storage source was being identified as QCOW2, rather than raw when attempting a primary storage migration. This caused the migration to fail when qemu-img attempted to image the file back from secondary storage to the new primary storage selected. This patch forces CLVM to be treated as RAW while continuing to acquire sourceFormat from other storage types via disk.getFormat(); Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java ecf3e08 Diff: https://reviews.apache.org/r/22939/diff/ Testing --- Stop VM. Migrate from one primary storage to another. Migration completes successfully. Start vm. Thanks, Simon Weller
Re: Review Request 24314: CLOUDSTACK-6695: UI: Added support for uploading a chain of certificates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24314/#review50054 --- Commit 57f611df16c48419e582f41c1e630faa739c11c5 in cloudstack's branch refs/heads/master from Mihaela Stoica [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=57f611d ] CLOUDSTACK-6695: Added support to the UI for uploading a chain of certificates In the SSL Certificate dialog we added: - new field for the root certificate; - a button to add intermediate certificates if necessary; when this is pressed, a new field, called Intermediate certificate 1 is added; pressed again, Intermediate certificate 2 field is added, and so on. We upload the certificates in order: first the root certificate (with id=1), then the intermediate certificates (with id=2,3,..) and finally the server certificate. When uploading a certificate, we wait for the upload to be completed successfully and only then we proceed to uploading the next one. If one fails, we report failure and don't continue with the remaining. Signed-off-by: Mihaela Stoica mihaela.sto...@citrix.com - ASF Subversion and Git Services On Aug. 5, 2014, 9:03 p.m., Mihaela Stoica wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24314/ --- (Updated Aug. 5, 2014, 9:03 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Nitin Mehta. Repository: cloudstack-git Description --- CLOUDSTACK-6695: Added support to the UI for uploading a chain of certificates In the SSL Certificate dialog we added: - new field for the root certificate; - a button to add intermediate certificates if necessary; when this is pressed, a new field, called Intermediate certificate 1 is added; pressed again, Intermediate certificate 2 field is added, and so on. We upload the certificates in order: first the root certificate (with id=1), then the intermediate certificates (with id=2,3,..) and finally the server certificate. When uploading a certificate, we wait for the upload to be completed succesfully and only then we proceed to uploading the next one. If one fails, we report failure and don't continue with the remaining. Diffs - client/WEB-INF/classes/resources/messages.properties a0205e1 ui/css/cloudstack3.css 23681a7 ui/dictionary.jsp 10aeaf9 ui/scripts/ui-custom/physicalResources.js ac379b4 Diff: https://reviews.apache.org/r/24314/diff/ Testing --- Yes, with a sample certificate chain. Thanks, Mihaela Stoica
Re: Review Request 24298: CLOUDSTACK-6873: Moved test cases that run only on simulator and those should be run serially to misc folder and also tagged them with required_hardware='simulator only'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24298/#review49874 --- Commit 1e3a689793278bb58a864a6fce266240f8f2c827 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1e3a689 ] CLOUDSTACK-6873: Moved test cases that run only on simulator and those should be run serially to misc folder and also tagged them with required_hardware='simulator only' Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 7, 2014, 6:19 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24298/ --- (Updated Aug. 7, 2014, 6:19 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6873 https://issues.apache.org/jira/browse/CLOUDSTACK-6873 Repository: cloudstack-git Description --- The tests in test suites test_deploy_vm.py and test_vm_ha.py need to be run serially, hence moved them to misc folder. Also tagged the tests as required_hardware='simulator only' which require to be run only on simulator. Moved the normal tests (for which above criteria don't apply) from test_deploy_vm.py to test_vm_life_cycle.py in smoke folder. Diffs - test/integration/smoke/misc/__init__.py PRE-CREATION test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION test/integration/smoke/misc/test_vm_ha.py PRE-CREATION test/integration/smoke/test_deploy_vm.py 29cdb96 test/integration/smoke/test_vm_ha.py c7d1648 test/integration/smoke/test_vm_life_cycle.py eef4dc1 Diff: https://reviews.apache.org/r/24298/diff/ Testing --- Yes, tested test_vm_life_cycle.py with python command. Thanks, Gaurav Aradhye
Re: Review Request 24383: CLOUDSTACK-7271: Accept any hypervisor in error message for integration.smoke.test_deploy_vm_root_resize.TestDeployVM.test_00_deploy_vm_root_resize
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24383/#review49883 --- Commit 5f816e3e3fcee259fbdd2153d72625254126ba25 in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5f816e3 ] CLOUDSTACK-7271: Accept any hypervisor in error message Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 6, 2014, 2:57 p.m., John Dilley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24383/ --- (Updated Aug. 6, 2014, 2:57 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7271 https://issues.apache.org/jira/browse/CLOUDSTACK-7271 Repository: cloudstack-git Description --- In test integration.smoke.test_deploy_vm_root_resize.TestDeployVM.test_00_deploy_vm_root_resize, the error message should accept any hypervisor in the error message Diffs - test/integration/smoke/test_deploy_vm_root_resize.py 029e7db Diff: https://reviews.apache.org/r/24383/diff/ Testing --- Tested on VMWare Thanks, John Dilley
Re: Review Request 24378: CLOUDSTACK-7268: Ignore already exists error in createEgressFirewallRule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24378/#review49885 --- Commit 7ff7e9cf5ae4d5ababa0bf7e7ccb4a8cb1064045 in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7ff7e9c ] CLOUDSTACK-7268: Ignore already exists error in createEgressFirewallRule Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 7, 2014, 7:41 a.m., John Dilley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24378/ --- (Updated Aug. 7, 2014, 7:41 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7268 https://issues.apache.org/jira/browse/CLOUDSTACK-7268 Repository: cloudstack-git Description --- Although we could search for an existing firewall rule, this fix is simpler, and also less prone to race conditions if multiple threads are running. Diffs - tools/marvin/marvin/lib/base.py 3a1f7e6 Diff: https://reviews.apache.org/r/24378/diff/ Testing --- Tested on KVM advanced zone Thanks, John Dilley
Re: Review Request 24302: CLOUDSTACK-7241: Fixed error in test_escalations_ipaddresses.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24302/#review49720 --- Commit adcfdf2547ffccced8bcb06a627274bbb0664d7c in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=adcfdf2 ] CLOUDSTACK-7241: Fixed error in test_escalations_ipaddresses.py Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 5, 2014, 12:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24302/ --- (Updated Aug. 5, 2014, 12:04 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7241 https://issues.apache.org/jira/browse/CLOUDSTACK-7241 Repository: cloudstack-git Description --- Test cases failed due to invalid expung (should have been expunge). But now expunge method call is not needed as by default the VMs will get expunged when destroyed. Diffs - test/integration/component/test_escalations_ipaddresses.py 66be52e Diff: https://reviews.apache.org/r/24302/diff/ Testing --- Yes. @summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS === ok -- Ran 1 test in 423.142s OK Thanks, Gaurav Aradhye
Re: Review Request 24313: CLOUDSTACK-7255: Fixed marvin issue related to creating random account usernames
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24313/#review49724 --- Commit 0a7af329f5386fa5fb2a2f9ebc02a2ca38bb9b17 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0a7af32 ] CLOUDSTACK-7255: Fixed marvin issue related to creating random account usernames Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 6, 2014, 9:49 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24313/ --- (Updated Aug. 6, 2014, 9:49 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7255 https://issues.apache.org/jira/browse/CLOUDSTACK-7255 Repository: cloudstack-git Description --- Few test cases failed with Entity already exists while creating account because the account name already existed in the setup. We append random string to the username to make account names unique. Also the account name should be less than 99 chars. But in case where the original username becomes greater than 99 chars, appending random string to it and trimming it back to 99 chars does not make any difference to the original string. In this case the username should be trimmed first and then random string should be appended to make the account name unique. Diffs - tools/marvin/marvin/lib/base.py 3a1f7e6 Diff: https://reviews.apache.org/r/24313/diff/ Testing --- Yes. Test router internal basic zone ... SKIP: Marvin configuration has no host credentials to check router services -- Ran 1 test in 141.558s OK (SKIP=1) Thanks, Gaurav Aradhye
Re: Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23837/#review49581 --- Commit 2dfd278625a5d569a5cce2fec5ccb0d7c515c9e8 in cloudstack's branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2dfd278 ] CLOUDSTACK-7087: Latest OS X VPN client not working Downgrading openswan version to 1:2.6.37-3 Reviewed-by: Abhinandan Signed-off-by: Sheng Yang - ASF Subversion and Git Services On Aug. 5, 2014, 6:55 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23837/ --- (Updated Aug. 5, 2014, 6:55 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7087 https://issues.apache.org/jira/browse/CLOUDSTACK-7087 Repository: cloudstack-git Description --- CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client Downgrading openswan version to 1:2.6.37-3 Diffs - tools/appliance/definitions/systemvm64template/postinstall.sh 8763a9f tools/appliance/definitions/systemvmtemplate/postinstall.sh 587d44d Diff: https://reviews.apache.org/r/23837/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in test_persistent_networks.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24305/#review49591 --- Commit c76302cdd8a70498a792db5d7fbe82ad43b7f8b5 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c76302c ] CLOUDSTACK-7240: Fixed expunge VM issue in test_persistent_networks.py Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 5, 2014, 9:45 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24305/ --- (Updated Aug. 5, 2014, 9:45 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7240 https://issues.apache.org/jira/browse/CLOUDSTACK-7240 Repository: cloudstack-git Description --- Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True. Diffs - test/integration/component/test_persistent_networks.py 210063e Diff: https://reviews.apache.org/r/24305/diff/ Testing --- Yes. test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS === ok -- Ran 1 test in 437.852s OK Thanks, Gaurav Aradhye
Re: Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24306/#review49594 --- Commit fce2880b9f20a372dd0a005c4575ffab526bac0b in cloudstack's branch refs/heads/master from namita.chaudhari [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fce2880 ] CLOUDSTACK-2694: Able to configure duplicate firewall rule with protocol and no ports Signed-off-by: Jayapal jaya...@apache.org - ASF Subversion and Git Services On Aug. 5, 2014, 10 a.m., Namita Chaudhari wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24306/ --- (Updated Aug. 5, 2014, 10 a.m.) Review request for cloudstack and Jayapal Reddy. Bugs: CLOUDSTACK-2694 and https://issues.apache.org/jira/browse/CLOUDSTACK-2694 https://issues.apache.org/jira/browse/CLOUDSTACK-2694 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694 Repository: cloudstack-git Description --- CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports When a duplicate firewall rule is created with same cidr, protocol and no ports, an error popup appears for duplicate firewall rule. Diffs - server/src/com/cloud/network/firewall/FirewallManagerImpl.java dd928d8 Diff: https://reviews.apache.org/r/24306/diff/ Testing --- Testing done based on the test cases updated in the bug. Thanks, Namita Chaudhari
Re: Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24154/#review49448 --- Commit c32b19a07d0eaa6dc0195ecf1aa9b952a91dc997 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c32b19a ] CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On July 31, 2014, 2:58 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24154/ --- (Updated July 31, 2014, 2:58 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7215 https://issues.apache.org/jira/browse/CLOUDSTACK-7215 Repository: cloudstack-git Description --- In almost 90% of the scenarios where VMs are created through test case, VMs are added to cleanup list and the delete method is called for them through cleanup_resources method in utils.py file. These VMs remain in destroyed state for long time and keep blocking the resources (IP Address etc) and hence the load on the setup on which regression build is fired increases. Making expunge=True as default parameter in destroyVirtualMachine api call through base library will make all these VMs expunge quickly making resources available for next test cases. Also, it can be passed as False whenever we don't want VM to expunge immediately, and in case when we recover the VM through test case after destroying it. Pass expunge=False for all such scenarios. This will hugely boost the test cases execution speed too. Diffs - test/integration/component/test_advancedsg_networks.py 2794f96 test/integration/component/test_multiple_ips_per_nic.py 24b85df test/integration/component/test_ps_domain_limits.py afb0955 test/integration/component/test_ps_limits.py 1993e93 test/integration/component/test_vpc_vm_life_cycle.py fd995cd tools/marvin/marvin/lib/base.py 58033c6 Diff: https://reviews.apache.org/r/24154/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24182/#review49457 --- Commit 0c77b2007e3918b10a8de560b2f63bd0f0f2cbdd in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0c77b20 ] CLOUDSTACK-7223: Wait for system VM agent state to be up before verification Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 4, 2014, 2:50 p.m., John Dilley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24182/ --- (Updated Aug. 4, 2014, 2:50 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7223 https://issues.apache.org/jira/browse/CLOUDSTACK-7223 Repository: cloudstack-git Description --- This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy system VMs before verifying that they are functioning properly. Diffs - test/integration/smoke/test_ssvm.py ac4079e Diff: https://reviews.apache.org/r/24182/diff/ Testing --- Tested against KVM advanced zone Thanks, John Dilley
Re: Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23813/#review49444 --- Commit 98e2a0444f74e3e8f6993319c822cc12bc491931 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=98e2a04 ] Revert CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file This reverts commit 613eb12104af5c27935091127a1a19941f96e336. - ASF Subversion and Git Services On July 22, 2014, 3:54 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23813/ --- (Updated July 22, 2014, 3:54 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7044 https://issues.apache.org/jira/browse/CLOUDSTACK-7044 Repository: cloudstack-git Description --- Changes: 1. Removing method getPortableIpRangeServices from common.py file 2. Reading the portable IP range data from test_data.py file Diffs - test/integration/component/test_portable_ip.py ce27dd8 tools/marvin/marvin/config/test_data.py 19b9aa4 tools/marvin/marvin/lib/common.py bc6b9c7 Diff: https://reviews.apache.org/r/23813/diff/ Testing --- Yes. Tested on KVM Advanced setup. Thanks, Ashutosh Kelkar
Re: Review Request 24174: CLOUDSTACK-7220: fixed hyper-v agent broken in 4.4 branch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24174/#review49335 --- Commit cda088470b069b4361e87e12e96f2769305e96d9 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cda0884 ] CLOUDSTACK-7220: fixed building hyper-v agent is broken, commits were not applied in correct order while cherry picking from 4.4-forward to 4.4 - ASF Subversion and Git Services On Aug. 1, 2014, 5:21 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24174/ --- (Updated Aug. 1, 2014, 5:21 a.m.) Review request for cloudstack, daan Hoogland and Devdeep Singh. Bugs: CLOUDSTACK-7220 https://issues.apache.org/jira/browse/CLOUDSTACK-7220 Repository: cloudstack-git Description --- the commits were not applied in correct order while cherry picking from 4.4-forward to 4.4 Diffs - plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0ad95b8 plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 2f404ff Diff: https://reviews.apache.org/r/24174/diff/ Testing --- verified building on my local setup Thanks, Anshul Gangwar
Re: Review Request 24185: CLOUDSTACK-7224: Fixed marvin code for async jobs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24185/#review49354 --- Commit 93c64cd7f210f4a11b1e8b71f8cf7edcc8eb in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=93c64cd ] CLOUDSTACK-7224: Fixed marvin code for async jobs Signed-off-by: Santhosh Edukulla santhosh.eduku...@gmail.com - ASF Subversion and Git Services On Aug. 1, 2014, 4:23 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24185/ --- (Updated Aug. 1, 2014, 4:23 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7224 https://issues.apache.org/jira/browse/CLOUDSTACK-7224 Repository: cloudstack-git Description --- ResponseType is not passed from asyncJobMgr to marvinRequest function, only command is passed. In this case responseType parameter should not be set as mandatory in marvinReqest. Make it optional. Also remove connection.close() , as there is no close method for cloudstackConnection. Closing the connection is not required as the copy of cloudstackConnection which is created for every worker thread will be deleted once it goes out of scope. Diffs - tools/marvin/marvin/asyncJobMgr.py 00e8c19 tools/marvin/marvin/cloudstackConnection.py a8c35f6 Diff: https://reviews.apache.org/r/24185/diff/ Testing --- Test perform concurrent snapshots and migrate the vm from one host ... === TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS === ok Test stop running VM while performing concurrent snapshot on volume ... SKIP: skip Test while parent concurrent snapshot job in progress,create ... SKIP: skip Test while parent concurrent snapshot job in progress,create volume ... SKIP: skip -- Ran 4 tests in 201.910s OK (SKIP=3) Thanks, Gaurav Aradhye
Re: Review Request 21554: CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21554/#review49093 --- Commit a40f2315fdc761309107cc5c88fbd44932edf7e3 in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a40f231 ] CLOUDSTACK-6657: Adding condition for checking error code 530 across test cases Signed-off-by: SrikanteswaraRao Talluri tall...@apache.org (cherry picked from commit 8eca37056f5bb1eee10f0bedee785142d7c3437a) Conflicts: test/integration/smoke/test_network.py - ASF Subversion and Git Services On May 16, 2014, 2:03 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21554/ --- (Updated May 16, 2014, 2:03 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6657 https://issues.apache.org/jira/browse/CLOUDSTACK-6657 Repository: cloudstack-git Description --- Adding explicit check for error code 530 in the response received form the server wherever applicable. I have made these changes in all those files which failed due to having wrong assert (Build #348 KVM regression). Will add more of these changes in other files whenever found failing due to above reason in the build logs. Diffs - test/integration/component/test_accounts.py cf5f2b6 test/integration/component/test_add_remove_network.py c17293d test/integration/component/test_affinity_groups.py d0fa2f7 test/integration/component/test_assign_vm.py 24b63a6 test/integration/component/test_ip_reservation.py c84f63c test/integration/component/test_non_contiguous_vlan.py 4609af9 test/integration/component/test_projects.py c593fb6 test/integration/component/test_volumes.py b5b08e2 test/integration/component/test_vpc.py e9d396e8 test/integration/component/test_vpc_network.py a449948 test/integration/component/test_vpc_network_lbrules.py a5625e7 test/integration/component/test_vpc_vms_deployment.py 1c1f93d test/integration/smoke/test_network.py 6beb071 test/integration/smoke/test_nic.py 592a839 test/integration/smoke/test_primary_storage.py 3147d86 test/integration/smoke/test_volumes.py 5908e2b Diff: https://reviews.apache.org/r/21554/diff/ Testing --- Tested all test suites with python command. Tested only few test suites by running them, not all. Same working change has been applied to all files. File Attachments Rebased patch against master https://reviews.apache.org/media/uploaded/files/2014/05/16/23566db1-7f6c-46bf-9444-878d9a6e7630__0001-CLOUDSTACK-6657-Adding-condition-for-checking-error-.patch Thanks, Gaurav Aradhye
Re: Review Request 21858: CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21858/#review49095 --- Commit 34f3a5fd44cd7af9f53f628b71f48d854d498eff in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=34f3a5f ] CLOUDSTACK-6758: [Marvin] Detect failed job and throw exception Signed-off-by: Abhinandan Prateek aprat...@apache.org (cherry picked from commit d9066f8d2931acc44ae66fc33f9eaa87b572de6a) - ASF Subversion and Git Services On May 23, 2014, 12:31 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21858/ --- (Updated May 23, 2014, 12:31 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6758 https://issues.apache.org/jira/browse/CLOUDSTACK-6758 Repository: cloudstack-git Description --- Whenever API returns error message for failed job (not exception), in this case it is returned to test cases as it is. Instead it should throw exceptions for failed jobs. With this change, reverted changes done in the test cases (Checking for ERROR_CODE_530) with commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=8eca37056f5bb1eee10f0bedee785142d7c3437a Diffs - test/integration/component/test_accounts.py 9b9ae75 test/integration/component/test_add_remove_network.py 969d94c test/integration/component/test_affinity_groups.py d31746a test/integration/component/test_assign_vm.py 0b07e9f test/integration/component/test_ip_reservation.py eb193d1 test/integration/component/test_non_contiguous_vlan.py 1f74252 test/integration/component/test_projects.py cf6cec8 test/integration/component/test_volumes.py 4a91e5d test/integration/component/test_vpc.py 31b421c test/integration/component/test_vpc_network.py 8d12ec6 test/integration/component/test_vpc_network_lbrules.py 47bdce5 test/integration/component/test_vpc_vms_deployment.py 19aa448 test/integration/smoke/test_network.py 7cd3973 test/integration/smoke/test_nic.py a76e858 test/integration/smoke/test_primary_storage.py 5b24b64 test/integration/smoke/test_volumes.py cc76e49 tools/marvin/marvin/cloudstackConnection.py 8044da7 tools/marvin/marvin/codes.py c72a6bd Diff: https://reviews.apache.org/r/21858/diff/ Testing --- Tested all the changed test cases on VMware. Thanks, Gaurav Aradhye
Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any host addition fails.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20621/#review49094 --- Commit 25a78acee127e7b195e4508bd8c1740d9fe227ed in cloudstack's branch refs/heads/4.4 from santhosh [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=25a78ac ] Added fix for CLOUDSTACK-6529 Fixed to continue adding all hosts, even if any addition fails and remove unused args from host class. Signed-off-by: santhosh santhosh.eduku...@gmail.com Signed-off-by: Abhinandan Prateek aprat...@apache.org (cherry picked from commit 6f3ff068270f48e00531c462de4f7d76395658ff) Conflicts: tools/marvin/marvin/deployDataCenter.py - ASF Subversion and Git Services On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20621/ --- (Updated May 23, 2014, 12:39 p.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-6529 https://issues.apache.org/jira/browse/CLOUDSTACK-6529 Repository: cloudstack-git Description --- 1. In deployDataCenter when a host addition fails, it is not continuing further. Added a change, to continue adding all hosts, even if any addition fails. Do a cleanup only when all host addition fails. Tested the changes on local setup 2. Removed another unwanted arguments from class host which are not part of addHost call. 3. Added an exit check based upon correct input file path type. Diffs - tools/marvin/marvin/configGenerator.py 66609da tools/marvin/marvin/deployDataCenter.py 4d8be58 Diff: https://reviews.apache.org/r/20621/diff/ Testing --- Tested the changes that it is not breaking existing deployDataCenter. Thanks, Santhosh Edukulla
Re: Review Request 22256: CLOUDSTACK-6830 :[hyper-v] fixed vm migration failing between different clusters if volumes are on zone wide primary store
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22256/#review49098 --- Commit 8b9166ae0bf437f35bf51dfb8dcfda3e4835a8ee in cloudstack's branch refs/heads/4.4 from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8b9166a ] CLOUDSTACK-6830: Fixed [hyper-v] during VM migration, volumes on zone wide primary store requires storage migration resulting in failure of VM migration. This also improves the hostsformigration api. Firstly we were trying to list all hosts and then finding suitable storage pools for all volumes and then we were checking whether vm migration requires storage migration to that host. Now the process is updated. We are checking for only those volumes which are not in zone wide primary store. We are verifying by comparing volumes-poolid-clusterid to host clusterid. If it uses local or clusterids are different then verifying whether host has suitable storage pools for the volume of the vm to be migrated too. (cherry picked from commit 64153a43711420224655bfbe248b4b87474a1f23) - ASF Subversion and Git Services On June 20, 2014, 10:21 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22256/ --- (Updated June 20, 2014, 10:21 a.m.) Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-6830 https://issues.apache.org/jira/browse/CLOUDSTACK-6830 Repository: cloudstack-git Description --- fixed vm migration failing between different clusters if volumes are on zone primary store. During VM migration, volumes on zone wide primary store requiring storage migration resulting in failure of VM migration This also improves the hostsformigration api. Firstly we were ttrying to list all hosts and then finding suitable storage pools for all volumes and then we were checking for whether vm migration requires storage migration Now the process is reversed, We are checking for only those volumes which are not in zone wide primary store and only verifying that volumes-poolid-clusterid is different from host clusterid and usesLocal then only it requires storage migration Diffs - engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4502365 server/src/com/cloud/server/ManagementServerImpl.java dd4ce0f Diff: https://reviews.apache.org/r/22256/diff/ Testing --- tested following scenarios on my local setup. 1. VM migration for volumes on zone wide primary store is working fine 2. VM migration for volumes on cluster wide primary store is working fine 3. VM migration for volumes on local storage is working fine Thanks, Anshul Gangwar
Re: Review Request 24098: CLOUDSTACK-6873: Removing BugId from test cases to enable them
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24098/#review49101 --- Commit e1be035870d6b40285166e0ae0633e39509662c0 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e1be035 ] CLOUDSTACK-6873: Removing BugId from tests - ASF Subversion and Git Services On July 30, 2014, 12:22 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24098/ --- (Updated July 30, 2014, 12:22 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6873 https://issues.apache.org/jira/browse/CLOUDSTACK-6873 Repository: cloudstack-git Description --- Removing BugId from test cases to monitor results in next run. Diffs - test/integration/smoke/test_deploy_vm.py 0810752 Diff: https://reviews.apache.org/r/24098/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 24096: CLOUDSTACK-7205: Passing expunge=True while deleting VMs to speed up test case execution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24096/#review49113 --- Commit 42a861e5908b110bbb41145b09394bd86ef318e1 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=42a861e ] CLOUDSTACK-7205: Adding expunge=True while deleting VM for test case execution speed improvement - ASF Subversion and Git Services On July 30, 2014, 11:34 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24096/ --- (Updated July 30, 2014, 11:34 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7205 https://issues.apache.org/jira/browse/CLOUDSTACK-7205 Repository: cloudstack-git Description --- Passing expunge=True will ensure immediate expunging of VM, so that we don't have to wait till it gets expunged. This will increase the execution speed of test cases. Diffs - test/integration/component/test_brocade_vcs.py 556de28 test/integration/component/test_eip_elb.py 0613c4d test/integration/component/test_escalations_networks.py 2bf5735 test/integration/component/test_multiple_ips_per_nic.py 570ddd2 test/integration/component/test_nuage_vsp.py 143fe39 test/integration/component/test_persistent_networks.py 016a391 test/integration/component/test_project_resources.py 4f61cb0 test/integration/component/test_project_usage.py e8ed1b1 test/integration/component/test_reset_ssh_keypair.py d0ddb18 test/integration/component/test_security_groups.py 6343613 test/integration/component/test_usage.py fe80da7 test/integration/component/test_vm_passwdenabled.py 2f68257 Diff: https://reviews.apache.org/r/24096/diff/ Testing --- Yes Thanks, Gaurav Aradhye
Re: Review Request 24050: CLOUDSTACK-7173 Make getNewMinIops and getNewMaxIops return Longs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24050/#review49193 --- Commit b919da8a5c54ec0f7d0c370203ccfb058cbe1a54 in cloudstack's branch refs/heads/master from Mike Tutkowski [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b919da8 ] CLOUDSTACK-7173 - ASF Subversion and Git Services On July 29, 2014, 12:56 p.m., Alex Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24050/ --- (Updated July 29, 2014, 12:56 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7173 https://issues.apache.org/jira/browse/CLOUDSTACK-7173 Repository: cloudstack-git Description --- The functions getNewMinIops and getNewMaxIops were returning long primitives, this can throw a NPE as the underlying Long objects could be null, which was causing volume resizes to fail. The only place this getter is called is expecting a Long object, so changing it to return a Long rather than long should be safe. Diffs - server/src/com/cloud/storage/VmWorkResizeVolume.java 1caab10 Diff: https://reviews.apache.org/r/24050/diff/ Testing --- Verified cloudstack still builds Thanks, Alex Brett
Re: Review Request 23976: CLOUDSTACK-7190: Fix Hyper-V issue when attempting SSH to System VMs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23976/#review48839 --- Commit 57ee142dede5be035a4501dcfb0816c9bfb8ddaa in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=57ee142 ] CLOUDSTACK-7190: Fix Hyper-V issue when attempting SSH to System VMs - ASF Subversion and Git Services On July 28, 2014, 10:34 a.m., John Dilley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23976/ --- (Updated July 28, 2014, 10:34 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7190 https://issues.apache.org/jira/browse/CLOUDSTACK-7190 Repository: cloudstack-git Description --- Hyper-V system VMs need to be accessed in the same way as VMWare system VMs - i.e. via the management server to the private IP rather than via the hypervisor host to the link-local IP. This patch makes Hyper-V and VMWare behave in the same way. Diffs - test/integration/component/maint/test_redundant_router.py 66bb477 test/integration/component/test_VirtualRouter_alerts.py e6f0a82 test/integration/component/test_deploy_vm_userdata_reg.py 1c9f35c test/integration/component/test_persistent_networks.py b90d621 test/integration/smoke/test_routers.py f77d11a test/integration/smoke/test_ssvm.py 9b8d19d Diff: https://reviews.apache.org/r/23976/diff/ Testing --- Thanks, John Dilley
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23879/#review48850 --- Commit d5220a88a085385ebc4b783a40f27d128ea7d28f in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d5220a8 ] CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case (cherry picked from commit ca59f01602823a6d6fe84233f3a3d3ea499efa06) - ASF Subversion and Git Services On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23879/ --- (Updated July 24, 2014, 2:44 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7127 https://issues.apache.org/jira/browse/CLOUDSTACK-7127 Repository: cloudstack-git Description --- We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use. It is better to start the range from 2, as 1 will most likely be used in existing setup. Diffs - test/integration/component/test_regions.py 7b7c4a4 Diff: https://reviews.apache.org/r/23879/diff/ Testing --- Yes. Log: Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS === ok Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS === ok Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS === ok -- Ran 3 tests in 2.845s OK Thanks, Gaurav Aradhye
Re: Review Request 23606: CLOUDSTACK-7025: Resolving test script issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23606/#review48847 --- Commit 843e60475798a2cb06daeaa00708c816fb819650 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=843e604 ] CLOUDSTACK-7025: Resolving test script issue (cherry picked from commit 33fdfbc83407037b45624ca84ca436fab72e59ab) - ASF Subversion and Git Services On July 17, 2014, 8:53 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23606/ --- (Updated July 17, 2014, 8:53 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7025 https://issues.apache.org/jira/browse/CLOUDSTACK-7025 Repository: cloudstack-git Description --- defaultNetworkId was not specified. Specified it in the setupClass. Diffs - test/integration/component/test_add_remove_network.py 4222f7a Diff: https://reviews.apache.org/r/23606/diff/ Testing --- 4 Test cases fixed by this. Log: Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to stopped VM ... SKIP: skip Add network to stopped VM ... SKIP: skip Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS === ok Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS === ok Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS === ok Add VPC network to stopped VM belonging to isolated network ... SKIP: skip Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS === ok Add network with invalid ip address to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to VM with maximum network limit reached ... SKIP: skip -- Ran 14 tests in 1523.655s OK (SKIP=10) Thanks, Ashutosh Kelkar
Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23882/#review48849 --- Commit 724c8dc7c98574dcdf669c0c2d7549981667ab77 in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=724c8dc ] CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedU' state (cherry picked from commit 4395308bd8b469fb02fc71d1e22f25c7d89b6dff) - ASF Subversion and Git Services On July 24, 2014, 2:43 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23882/ --- (Updated July 24, 2014, 2:43 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7125 https://issues.apache.org/jira/browse/CLOUDSTACK-7125 Repository: cloudstack-git Description --- After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py. Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail. Diffs - test/integration/component/test_blocker_bugs.py ba15b18 Diff: https://reviews.apache.org/r/23882/diff/ Testing --- Did not run the test cases as already existing library function is used. Checked for sytax/import errors using pyflakes and python command. Thanks, Gaurav Aradhye
Re: Review Request 23608: CLOUDSTACK-7014: Resolving test script related to affinity groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23608/#review48848 --- Commit e9d658e16edbe55a380aefa779c89d690b368d24 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e9d658e ] CLOUDSTACK-7014: Resolving test script related to affinity groups tests (cherry picked from commit 1cc6317b5e744afb74b63af6600af32bdfedb888) - ASF Subversion and Git Services On July 17, 2014, 9:23 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23608/ --- (Updated July 17, 2014, 9:23 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7014 https://issues.apache.org/jira/browse/CLOUDSTACK-7014 Repository: cloudstack-git Description --- Changing __cleanup to _cleanup Diffs - test/integration/component/test_affinity_groups.py de5f007 Diff: https://reviews.apache.org/r/23608/diff/ Testing --- Yes Thanks, Ashutosh Kelkar
Re: Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20701/#review48855 --- Commit 8fb89cdc8e2dff60d49fecd3e51a9bf997061035 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8fb89cd ] CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code (cherry picked from commit 66f8e0e1b5c81cbfde926c0c65c4d5969767cab9) Conflicts: plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs - ASF Subversion and Git Services On April 25, 2014, 6:14 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20701/ --- (Updated April 25, 2014, 6:14 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6504 https://issues.apache.org/jira/browse/CLOUDSTACK-6504 Repository: cloudstack-git Description --- removed the warnings coming in building hyper-v agent code. One warning related to System.Net.Http dependency is still there. All other warnings have been removed. Diffs - plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs c222102 plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0f084db plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs d0d3d83 plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073 Diff: https://reviews.apache.org/r/20701/diff/ Testing --- tested by creating the fresh setup after the removal of warnings. Thanks, Anshul Gangwar
Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/#review48856 --- Commit 75d2a331ee5876c3c456c8a3c12258c3b8f07f00 in cloudstack's branch refs/heads/4.4 from Koushik Das [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=75d2a33 ] CLOUDSTACK-6873: Tagged tests based on the limitation described in the bug (cherry picked from commit 89a03c7099fb5f0d6a3a892b036d064bfc2acb71) - ASF Subversion and Git Services On July 3, 2014, 1:32 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23195/ --- (Updated July 3, 2014, 1:32 p.m.) Review request for cloudstack, Koushik Das and Santhosh Edukulla. Bugs: CLOUDSTACK-6873 https://issues.apache.org/jira/browse/CLOUDSTACK-6873 Repository: cloudstack-git Description --- Moving tests using SimulatorMock into maint folder. Also removed duplicate test cases from test_deploy_vm.py. These tests are already covered in test_vm_life_cycle.py Diffs - test/integration/smoke/misc/__init__.py PRE-CREATION test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION test/integration/smoke/misc/test_vm_ha.py PRE-CREATION test/integration/smoke/test_deploy_vm.py ed5dfaf test/integration/smoke/test_vm_ha.py 1d9021c test/integration/smoke/test_vm_life_cycle.py 240ab68 Diff: https://reviews.apache.org/r/23195/diff/ Testing --- File Attachments Patch for master https://reviews.apache.org/media/uploaded/files/2014/07/03/1fba76b3-3eab-4281-afa9-7a3f38dc2c0d__0001-CLOUDSTACK-6873-Moving-the-tests-using-SimulatorMock.patch Thanks, Gaurav Aradhye
Re: Review Request 22614: CLOUDSTACK-6887: Code enhancement to ensure better cleanup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22614/#review48857 --- Commit 8c37e46807b92ac32c63cd36d33ca5d68bb75f30 in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8c37e46 ] CLOUDSTACK-6887: Fixing account cleanup issue across multiple test cases (cherry picked from commit b849b7ee3d9b4a141c2eb3fd689d197ed20c4581) - ASF Subversion and Git Services On June 18, 2014, 3:22 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22614/ --- (Updated June 18, 2014, 3:22 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6887 https://issues.apache.org/jira/browse/CLOUDSTACK-6887 Repository: cloudstack-git Description --- Adding patch fixing few more test suites for better cleanup. Diffs - test/integration/component/test_accounts.py f71dea5 test/integration/component/test_add_remove_network.py 7479cee test/integration/component/test_affinity_groups.py d0fa2f7 test/integration/component/test_portable_ip.py 538318d test/integration/component/test_vpc_network.py a449948 Diff: https://reviews.apache.org/r/22614/diff/ Testing --- Tested with python command. Thanks, Gaurav Aradhye
Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review48858
---
Commit 2fdf789a28ce01571eabd5ccb8edfea72624ea3c in cloudstack's branch
refs/heads/4.4 from John Dilley
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2fdf789 ]
CLOUDSTACK-6909 - fix marvin's handling of SMB credentials for storage
Signed-off-by: Daan Hoogland d...@onecht.net
(cherry picked from commit 477a812a6f7aaab74122c11488713f417dfe4d89)
(cherry picked from commit 2498f65683bd529b2b03bac9a6cfd2fdbf65aca2)
- ASF Subversion and Git Services
On June 23, 2014, 3:53 p.m., John Dilley wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/
---
(Updated June 23, 2014, 3:53 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-6909
https://issues.apache.org/jira/browse/CLOUDSTACK-6909
Repository: cloudstack-git
Description
---
Fix marvin's handling of details field for primary and secondary storage to
cope with SMB credentials. This allows Hyper-V to work.
Diffs
-
tools/marvin/marvin/configGenerator.py 191f08e
tools/marvin/marvin/deployDataCenter.py 22b78ab
Diff: https://reviews.apache.org/r/22554/diff/
Testing
---
Tested deploydataCenter with this JSON:
{
dbSvr:{
dbSvr:10.220.137.39,
passwd:cloud,
db:cloud,
port:3306,
user:cloud
},
zones:[
{
name:XenRT-Zone-0,
guestcidraddress:192.168.200.0/24,
dns1:10.220.160.11,
physical_networks:[
{
XRT_VLANRangeSize:10,
name:AdvPhyNetwork,
providers:[
{
broadcastdomainrange:ZONE,
name:VirtualRouter
},
{
broadcastdomainrange:ZONE,
name:VpcVirtualRouter
},
{
broadcastdomainrange:ZONE,
name:InternalLbVm
}
],
broadcastdomainrange:Zone,
vlan:3000-3009,
traffictypes:[
{
typ:Guest
},
{
typ:Management
},
{
typ:Public
}
],
isolationmethods:[
VLAN
]
}
],
ipranges:[
{
startip:10.220.164.0,
endip:10.220.164.9,
netmask:255.255.240.0,
XRT_GuestIPRangeSize:10,
gateway:10.220.160.1
}
],
networktype:Advanced,
pods:[
{
XRT_PodIPRangeSize:10,
name:XenRT-Zone-0-Pod-0,
endip:10.220.164.39,
startip:10.220.164.30,
netmask:255.255.240.0,
clusters:[
{
XRT_HyperVHostIds:0,
clustername:XenRT-Zone-0-Pod-0-Cluster-0,
hypervisor:hyperv,
primaryStorages:[
{
url:cifs://10.220.163.45/storage/primary,
name:XenRT-Zone-0-Pod-0-Primary-Store,
details:{
user:Administrator,
password:xenroot01T,
domain:XSQA
}
}
],
clustertype:CloudManaged,
hosts:[
{
url:http://10.220.163.45;,
username:root,
password:xenroot
}
],
XRT_Hosts:1
}
],
gateway:10.220.160.1
}
],
internaldns1:10.220.160.11,
secondaryStorages:[
{
url:cifs://10.220.163.45/storage/secondary,
details:{
domain:XSQA,
password:xenroot01T,
user:Administrator
},
provider:SMB
}
]
}
],
mgtSvr:[
{
mgtSvrIp:10.220.137.39,
passwd:xenroot,
port:8096,
user:root
Re: Review Request 23613: CLOUDSTACK-7022: Fixed typo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/#review48859 --- Commit e33d4a5732e81f590489f37b7fbcc947d2929de6 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e33d4a5 ] CLOUDSTACK-7022: Fixed typo (cherry picked from commit 967b82f16b93bf1df4473b7ce8dd314f015098e8) - ASF Subversion and Git Services On July 17, 2014, 11:03 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/ --- (Updated July 17, 2014, 11:03 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7022 https://issues.apache.org/jira/browse/CLOUDSTACK-7022 Repository: cloudstack-git Description --- Fixed typo. Diffs - test/integration/component/test_usage.py 4f9d1d7 Diff: https://reviews.apache.org/r/23613/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 23884: Fixed CLOUDSTACK-5212: [UI]Need Support for the LXC for the Report sockets
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23884/#review48880 --- Commit f1039b782e5fdef8129088929c42fdf2f2909b5a in cloudstack's branch refs/heads/master from Rajani Karuturi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f1039b7 ] Fixed CLOUDSTACK-5212: [UI]Need Support for the LXC for the Report sockets - ASF Subversion and Git Services On July 24, 2014, 11:51 a.m., Rajani Karuturi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23884/ --- (Updated July 24, 2014, 11:51 a.m.) Review request for cloudstack and Jessica Wang. Bugs: CLOUDSTACK-5212 https://issues.apache.org/jira/browse/CLOUDSTACK-5212 Repository: cloudstack-git Description --- added LXC to the list of hypervisors in js. Diffs - ui/scripts/system.js 9012580 Diff: https://reviews.apache.org/r/23884/diff/ Testing --- manually tested that it shows up in the sockets page Thanks, Rajani Karuturi
Re: Review Request 23922: Fixed CLOUDSTACK-6980: UI for RegisterTemplate API does not expose requireshvm parameter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23922/#review48886 --- Commit 32e8fda965252322eccda01e14f854051d665ed0 in cloudstack's branch refs/heads/master from Rajani Karuturi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=32e8fda ] Fixed CLOUDSTACK-6980: UI for RegisterTemplate API does not expose requireshvm parameter - ASF Subversion and Git Services On July 25, 2014, 9:58 a.m., Rajani Karuturi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23922/ --- (Updated July 25, 2014, 9:58 a.m.) Review request for cloudstack and Jessica Wang. Bugs: CLOUDSTACK-6980 https://issues.apache.org/jira/browse/CLOUDSTACK-6980 Repository: cloudstack-git Description --- added requireshvm to the create form fields Diffs - client/WEB-INF/classes/resources/messages.properties 271ffec ui/dictionary.jsp beb082b ui/scripts/docs.js 2075e30 ui/scripts/templates.js e12927c Diff: https://reviews.apache.org/r/23922/diff/ Testing --- manually tested register template Thanks, Rajani Karuturi
Re: Review Request 20659: CLOUDSTACK-5674: Fixed cloudstackConnection.py to return FAILED in case of well handled exceptions returning from server having jobresultcode as 530
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20659/#review48899 --- Commit 4a99cf851966512ae90633b7ed7d7954b6d0ac9a in cloudstack's branch refs/heads/4.4 from SrikanteswaraRao Talluri [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a99cf8 ] CLOUDSTACK-5674:Fixed pep8 errors in python files in marvin folder Signed-off-by: SrikanteswaraRao Talluri tall...@apache.org (cherry picked from commit 4f1f182cba5579da2fc7ce1f02019a0afa00efeb) Conflicts: tools/marvin/marvin/lib/base.py - ASF Subversion and Git Services On May 12, 2014, 6:04 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20659/ --- (Updated May 12, 2014, 6:04 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5674 https://issues.apache.org/jira/browse/CLOUDSTACK-5674 Repository: cloudstack-git Description --- In case of well handled exceptions returned from the server with proper error message, the response was as it is returned. Instead, it should check the jobresultcode. If the jobresultcode is 530, it means that exception is returned from server. In this case we should return FAILED. Diffs - tools/marvin/marvin/cloudstackConnection.py 8044da7 tools/marvin/marvin/codes.py ef49c0c Diff: https://reviews.apache.org/r/20659/diff/ Testing --- Yes Thanks, Gaurav Aradhye
Re: Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/#review48901 --- Commit f055ec52d9d751df86e42aeb6a2aace2ceea4567 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f055ec5 ] CLOUDSTACK-7024: Resolved cleanup issue in test script (cherry picked from commit ec49669f1cf525b207889ae13a8a2b01a0271933) - ASF Subversion and Git Services On July 18, 2014, 12:08 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/ --- (Updated July 18, 2014, 12:08 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7024 https://issues.apache.org/jira/browse/CLOUDSTACK-7024 Repository: cloudstack-git Description --- Resolved issue related to order of cleanup items. The project must be removed before the account which manages it. Diffs - test/integration/component/test_project_usage.py 5e0dda5 Diff: https://reviews.apache.org/r/23677/diff/ Testing --- Yes. Log: Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS === ok -- Ran 1 test in 285.451s OK Thanks, Ashutosh Kelkar
Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23611/#review48900 --- Commit 6b66fe92ca89633ec64397cedb0d1572d0089c93 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b66fe9 ] CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py (cherry picked from commit f99a96f38a1f2433cb01bd7af25890789716e070) - ASF Subversion and Git Services On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23611/ --- (Updated July 17, 2014, 10:24 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7013 https://issues.apache.org/jira/browse/CLOUDSTACK-7013 Repository: cloudstack-git Description --- Corrected typo. cls.append to cls._cleanup.append Diffs - test/integration/component/test_add_remove_network.py dbba59b Diff: https://reviews.apache.org/r/23611/diff/ Testing --- Yes. Log: Try to remove nic from a vm providing wrong vm id to API ... === TestName: test_19_remove_nic_wrong_vm_id | Status : SUCCESS === ok -- Ran 1 test in 172.776s OK Thanks, Ashutosh Kelkar
Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/#review48902 --- Commit 1ca9abd6dc8013dd1dc4e4f9ca1eabb71785cc37 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1ca9abd ] CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py (cherry picked from commit 8d8190ea4e00edb0f7ce9665535adcc7a5b5097d) - ASF Subversion and Git Services On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/ --- (Updated July 22, 2014, 7:05 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7137 https://issues.apache.org/jira/browse/CLOUDSTACK-7137 Repository: cloudstack-git Description --- Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation. Also, removed the unnecessary imports. Diffs - test/integration/component/test_escalations_securitygroups.py 8934088 Diff: https://reviews.apache.org/r/23793/diff/ Testing --- Yes. Log: @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS === ok @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip -- Ran 3 tests in 5.845s OK (SKIP=2) Thanks, Ashutosh Kelkar
Re: Review Request 23885: CLOUDSTACK-7178: Correcting imports in test_escalations* test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23885/#review48904 --- Commit 2025f359c4fbff6b24132d39e8cf587315a2a981 in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2025f35 ] CLOUDSTACK-7178: Correcting imports in test_escalations* test cases (cherry picked from commit 4e45b296891f71fc7991dc507dc7ae9cec6f5496) - ASF Subversion and Git Services On July 24, 2014, 12:10 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23885/ --- (Updated July 24, 2014, 12:10 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7178 https://issues.apache.org/jira/browse/CLOUDSTACK-7178 Repository: cloudstack-git Description --- Correcting the imports to resolve the import error. Diffs - test/integration/component/test_escalations_ipaddresses.py 0b31d2e test/integration/component/test_escalations_snapshots.py 0aa36c3 Diff: https://reviews.apache.org/r/23885/diff/ Testing --- Yes. Tested with python command. Thanks, Gaurav Aradhye
Re: Review Request 23814: CLOUDSTACK-7148: Adding missing list in method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/#review48903 --- Commit 58987452994f1abc621a2f8f7fcdd24b443cf0e9 in cloudstack's branch refs/heads/4.4 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5898745 ] CLOUDSTACK-7148: Adding missing list method (cherry picked from commit dd138ceec5faa5d5b0fcdfe5cc655199b8f9187b) - ASF Subversion and Git Services On July 22, 2014, 3:55 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/ --- (Updated July 22, 2014, 3:55 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7148 https://issues.apache.org/jira/browse/CLOUDSTACK-7148 Repository: cloudstack-git Description --- Adding missing list in method call. Diffs - test/integration/component/test_redundant_router_cleanups.py 444fa3a Diff: https://reviews.apache.org/r/23814/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23918: CLOUDSTACK-7180: Tagging test case with product bug ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23918/#review48724 --- Commit 853d66a439148eb0cef8037d2c85a6c387c05f27 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=853d66a ] CLOUDSTACK-7180: Tagging test case with product bug ID - ASF Subversion and Git Services On July 25, 2014, 7:50 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23918/ --- (Updated July 25, 2014, 7:50 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7180 https://issues.apache.org/jira/browse/CLOUDSTACK-7180 Repository: cloudstack-git Description --- Tagging test case with product Bug ID - CLOUDSTACK-7180 Diffs - test/integration/component/test_dynamic_compute_offering.py 3939777 Diff: https://reviews.apache.org/r/23918/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 23920: CLOUDSTACK-7181: Skip tests on KVM - changing service offering when VM is in running state - not supported on KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23920/#review48730 --- Commit 12ce5115e4c1879626bfdfabf27b71ca26fbccee in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=12ce511 ] CLOUDSTACK-7181: Skip tests on KVM - changing service offering when VM is in running state - not supported on KVM - ASF Subversion and Git Services On July 25, 2014, 9:19 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23920/ --- (Updated July 25, 2014, 9:19 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7181 https://issues.apache.org/jira/browse/CLOUDSTACK-7181 Repository: cloudstack-git Description --- Skipping the tests which try to change the service offering of VM when it is in running state on KVM as the feature is not supported for KVM hypervisor. Diffs - test/integration/component/test_dynamic_compute_offering.py 3939777 Diff: https://reviews.apache.org/r/23920/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 23885: CLOUDSTACK-7178: Correcting imports in test_escalations* test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23885/#review48650 --- Commit 78a6d557f86db354a073090fc92ea693ee235e1f in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=78a6d55 ] CLOUDSTACK-7178: Correcting imports in test_escalations* test cases - ASF Subversion and Git Services On July 24, 2014, 12:10 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23885/ --- (Updated July 24, 2014, 12:10 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7178 https://issues.apache.org/jira/browse/CLOUDSTACK-7178 Repository: cloudstack-git Description --- Correcting the imports to resolve the import error. Diffs - test/integration/component/test_escalations_ipaddresses.py 0b31d2e test/integration/component/test_escalations_snapshots.py 0aa36c3 Diff: https://reviews.apache.org/r/23885/diff/ Testing --- Yes. Tested with python command. Thanks, Gaurav Aradhye
Re: Review Request 23885: CLOUDSTACK-7178: Correcting imports in test_escalations* test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23885/#review48651 --- Commit 4e45b296891f71fc7991dc507dc7ae9cec6f5496 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4e45b29 ] CLOUDSTACK-7178: Correcting imports in test_escalations* test cases - ASF Subversion and Git Services On July 24, 2014, 12:10 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23885/ --- (Updated July 24, 2014, 12:10 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7178 https://issues.apache.org/jira/browse/CLOUDSTACK-7178 Repository: cloudstack-git Description --- Correcting the imports to resolve the import error. Diffs - test/integration/component/test_escalations_ipaddresses.py 0b31d2e test/integration/component/test_escalations_snapshots.py 0aa36c3 Diff: https://reviews.apache.org/r/23885/diff/ Testing --- Yes. Tested with python command. Thanks, Gaurav Aradhye
Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23882/#review48652 --- Commit 49005b324f18e19166bcbb801bcd07609e44d8db in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=49005b3 ] CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedU' state - ASF Subversion and Git Services On July 24, 2014, 2:43 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23882/ --- (Updated July 24, 2014, 2:43 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7125 https://issues.apache.org/jira/browse/CLOUDSTACK-7125 Repository: cloudstack-git Description --- After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py. Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail. Diffs - test/integration/component/test_blocker_bugs.py ba15b18 Diff: https://reviews.apache.org/r/23882/diff/ Testing --- Did not run the test cases as already existing library function is used. Checked for sytax/import errors using pyflakes and python command. Thanks, Gaurav Aradhye
Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23882/#review48653 --- Commit 4395308bd8b469fb02fc71d1e22f25c7d89b6dff in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4395308 ] CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedU' state - ASF Subversion and Git Services On July 24, 2014, 2:43 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23882/ --- (Updated July 24, 2014, 2:43 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7125 https://issues.apache.org/jira/browse/CLOUDSTACK-7125 Repository: cloudstack-git Description --- After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py. Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail. Diffs - test/integration/component/test_blocker_bugs.py ba15b18 Diff: https://reviews.apache.org/r/23882/diff/ Testing --- Did not run the test cases as already existing library function is used. Checked for sytax/import errors using pyflakes and python command. Thanks, Gaurav Aradhye
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23879/#review48654 --- Commit 59c77fbaa4c07e2de9578369e69f47d0e71039b8 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59c77fb ] CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case - ASF Subversion and Git Services On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23879/ --- (Updated July 24, 2014, 2:44 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7127 https://issues.apache.org/jira/browse/CLOUDSTACK-7127 Repository: cloudstack-git Description --- We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use. It is better to start the range from 2, as 1 will most likely be used in existing setup. Diffs - test/integration/component/test_regions.py 7b7c4a4 Diff: https://reviews.apache.org/r/23879/diff/ Testing --- Yes. Log: Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS === ok Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS === ok Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS === ok -- Ran 3 tests in 2.845s OK Thanks, Gaurav Aradhye
Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23879/#review48655 --- Commit ca59f01602823a6d6fe84233f3a3d3ea499efa06 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ca59f01 ] CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case - ASF Subversion and Git Services On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23879/ --- (Updated July 24, 2014, 2:44 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7127 https://issues.apache.org/jira/browse/CLOUDSTACK-7127 Repository: cloudstack-git Description --- We are choosing random region id while passing it to addRegion test case. The test case failed when region id 1 was passed because the region id was already in use. It is better to start the range from 2, as 1 will most likely be used in existing setup. Diffs - test/integration/component/test_regions.py 7b7c4a4 Diff: https://reviews.apache.org/r/23879/diff/ Testing --- Yes. Log: Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId | Status : SUCCESS === ok Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName | Status : SUCCESS === ok Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS === ok -- Ran 3 tests in 2.845s OK Thanks, Gaurav Aradhye
Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22863/#review48486 --- Commit 628d8e66f77053de9819436739325720710175ed in cloudstack's branch refs/heads/master from Ritu Sabharwal [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=628d8e6 ] CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - ASF Subversion and Git Services On July 22, 2014, 9:44 p.m., Ritu Sabharwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22863/ --- (Updated July 22, 2014, 9:44 p.m.) Review request for cloudstack and Hugo Trippaers. Bugs: CLOUDSTACK-6823 https://issues.apache.org/jira/browse/CLOUDSTACK-6823 Repository: cloudstack-git Description --- First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity. Please create a new branch for Brocade plugin. Diffs - api/src/com/cloud/network/Network.java 0a08f28 api/src/com/cloud/network/Networks.java 1ad3350 api/src/com/cloud/network/PhysicalNetwork.java 024b3ce api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java e73f526 client/WEB-INF/classes/resources/messages.properties bb75b08 client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 client/pom.xml 410cb19 client/tomcatconf/commands.properties.in aa03949 plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd PRE-CREATION plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd PRE-CREATION plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd PRE-CREATION plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties PRE-CREATION plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java PRE-CREATION plugins/network-elements/brocade-vcs/src/com/cloud
Re: Review Request 23838: CLOUDSTACK-5986: Test scipt to verify the fix in isolated network for non-vpc networks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23838/#review48504 --- Commit 9f4f9211d0aecbfeadfa626b6202109f40200125 in cloudstack's branch refs/heads/master from sanjeev [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9f4f921 ] CLOUDSTACK-5986: Test scipt to verify the fix in isolated network for non-vpc networks Signed-off-by: sanjeev sanj...@apache.org - ASF Subversion and Git Services On July 23, 2014, 9:14 a.m., sanjeev n wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23838/ --- (Updated July 23, 2014, 9:14 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CS-5986 https://issues.apache.org/jira/browse/CS-5986 Repository: cloudstack-git Description --- Test script is to verify the fix for dnsmasq lease issue while reallocating the same ip address to new vm. Test does the following: Deploy two vms: VM1 used name: VM1, 10.1.1.10 VM2 used name: VM2, 10.1.1.11 Destroy both the vms Deploy vm3 with name VM1 and ip 10.1.1.11 Deploy vm4 with name vm3 and ip 10.1.1.10 Before fix vm4 would not get the ip because of dnsmasq lease issue. After fix vm4 would get the ip address properly. Diffs - test/integration/component/test_escalations_instances.py 79fd3b1 Diff: https://reviews.apache.org/r/23838/diff/ Testing --- Yes Thanks, sanjeev n
Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/#review48626 --- Commit 0f85e649b64b38cf80bc1e86ac15b206bef65117 in cloudstack's branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0f85e64 ] CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack - ASF Subversion and Git Services On March 13, 2014, 7:31 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17736/ --- (Updated March 13, 2014, 7:31 a.m.) Review request for cloudstack, John Burwell and Murali Reddy. Bugs: CLOUDSTACK-5999 https://issues.apache.org/jira/browse/CLOUDSTACK-5999 Repository: cloudstack-git Description --- When a guest is rebooted from CloudStack, if the virtual router managing the guest network of that guest is down, CloudStack will not start the virtual router. However the router is started in case the guest vm is stopped and then started. To mantain similarity between the 2 process it is necessary to start the VR in case it is not running. The fix will address the same. Diffs - server/src/com/cloud/vm/UserVmManagerImpl.java be00aa8 Diff: https://reviews.apache.org/r/17736/diff/ Testing --- Testing: 1) vm in a single guest network : vm Reboot : If the VR is stopped: VR is first started and then the VM reboots. vm Reboot : If the VR is running, VM reboots as it used to. vm Stop/Start continue to work the same. 2) vm having nics in multi networks : vm Reboot : If VR in any/all network is stopped: VRs are first started and then the VM reboots. vm Reboot : If the VRs are running, VM reboots as it used to. vm Stop/Start continue to work the same. 3) vpc : Tested the above scenarios for vpc also, works fine. Patch applies cleanly. Build passes succesfully. FindBug is passed. Rebased against latest master. Thanks, Saksham Srivastava
Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/#review48385 --- Commit 45888e214c949d1e48d800339b366c42a7990641 in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=45888e2 ] CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py - ASF Subversion and Git Services On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/ --- (Updated July 22, 2014, 7:05 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7137 https://issues.apache.org/jira/browse/CLOUDSTACK-7137 Repository: cloudstack-git Description --- Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation. Also, removed the unnecessary imports. Diffs - test/integration/component/test_escalations_securitygroups.py 8934088 Diff: https://reviews.apache.org/r/23793/diff/ Testing --- Yes. Log: @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS === ok @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip -- Ran 3 tests in 5.845s OK (SKIP=2) Thanks, Ashutosh Kelkar
Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/#review48386 --- Commit 8d8190ea4e00edb0f7ce9665535adcc7a5b5097d in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8d8190e ] CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py - ASF Subversion and Git Services On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/ --- (Updated July 22, 2014, 7:05 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7137 https://issues.apache.org/jira/browse/CLOUDSTACK-7137 Repository: cloudstack-git Description --- Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation. Also, removed the unnecessary imports. Diffs - test/integration/component/test_escalations_securitygroups.py 8934088 Diff: https://reviews.apache.org/r/23793/diff/ Testing --- Yes. Log: @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS === ok @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip -- Ran 3 tests in 5.845s OK (SKIP=2) Thanks, Ashutosh Kelkar
Re: Review Request 23814: CLOUDSTACK-7148: Adding missing list in method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/#review48389 --- Commit 981becc73585c9a789b377e18af623c325b0bc7f in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=981becc ] CLOUDSTACK-7148: Adding missing list method - ASF Subversion and Git Services On July 22, 2014, 3:55 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/ --- (Updated July 22, 2014, 3:55 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7148 https://issues.apache.org/jira/browse/CLOUDSTACK-7148 Repository: cloudstack-git Description --- Adding missing list in method call. Diffs - test/integration/component/test_redundant_router_cleanups.py 444fa3a Diff: https://reviews.apache.org/r/23814/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23814: CLOUDSTACK-7148: Adding missing list in method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/#review48390 --- Commit dd138ceec5faa5d5b0fcdfe5cc655199b8f9187b in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=dd138ce ] CLOUDSTACK-7148: Adding missing list method - ASF Subversion and Git Services On July 22, 2014, 3:55 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/ --- (Updated July 22, 2014, 3:55 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7148 https://issues.apache.org/jira/browse/CLOUDSTACK-7148 Repository: cloudstack-git Description --- Adding missing list in method call. Diffs - test/integration/component/test_redundant_router_cleanups.py 444fa3a Diff: https://reviews.apache.org/r/23814/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23813/#review48393 --- Commit 613eb12104af5c27935091127a1a19941f96e336 in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=613eb12 ] CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file - ASF Subversion and Git Services On July 22, 2014, 3:54 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23813/ --- (Updated July 22, 2014, 3:54 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7044 https://issues.apache.org/jira/browse/CLOUDSTACK-7044 Repository: cloudstack-git Description --- Changes: 1. Removing method getPortableIpRangeServices from common.py file 2. Reading the portable IP range data from test_data.py file Diffs - test/integration/component/test_portable_ip.py ce27dd8 tools/marvin/marvin/config/test_data.py 19b9aa4 tools/marvin/marvin/lib/common.py bc6b9c7 Diff: https://reviews.apache.org/r/23813/diff/ Testing --- Yes. Tested on KVM Advanced setup. Thanks, Ashutosh Kelkar
Re: Review Request 23812: CLOUDSTACK-7147: Resolving test script issue in test_ip_reservation.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23812/#review48401 --- Commit 2c0765195a4a01ee51973c48d0561261d4fb01c6 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2c07651 ] CLOUDSTACK-7147: Resolving test script issue in test_ip_reservation.py - ASF Subversion and Git Services On July 22, 2014, 3:22 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23812/ --- (Updated July 22, 2014, 3:22 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7147 https://issues.apache.org/jira/browse/CLOUDSTACK-7147 Repository: cloudstack-git Description --- Removed the unnecessary check for failure. FAIL was returned in old marvin, which is discarded now. Now direct exception is thrown from marvin library, hence no need of explicit FAIL check. Diffs - test/integration/component/test_ip_reservation.py ce76c1a Diff: https://reviews.apache.org/r/23812/diff/ Testing --- Yes. Thanks, Gaurav Aradhye
Re: Review Request 23605: CLOUDSTACK-7107: Disabling failed test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/#review48203 --- Commit 43dffaad5fd197c87a8dab087066f677a095dee7 in cloudstack's branch refs/heads/master from Koushik Das [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=43dffaa ] Revert CLOUDSTACK-7107: Disabling failed test case This reverts commit 186606a0bf82402e7755cd7998f133023cc96c6c. - ASF Subversion and Git Services On July 17, 2014, 7:47 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23605/ --- (Updated July 17, 2014, 7:47 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7074 and CLOUDSTACK-7107 https://issues.apache.org/jira/browse/CLOUDSTACK-7074 https://issues.apache.org/jira/browse/CLOUDSTACK-7107 Repository: cloudstack-git Description --- Disabling failed test cases on master. Diffs - test/integration/smoke/test_primary_storage.py 66aec59 test/integration/smoke/test_vm_life_cycle.py 240ab68 Diff: https://reviews.apache.org/r/23605/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 23282: CLOUDSTACK-6845 : First Code drop for NuageVsp Network plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23282/#review48207 --- Commit 03de9cc33507400e0e06ccd84a36334a4660ef4e in cloudstack's branch refs/heads/master from Suresh Ramamurthy [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=03de9cc ] CLOUDSTACK-6845 : NuageVsp Network plugin Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - ASF Subversion and Git Services On July 19, 2014, 12:49 a.m., Suresh Ramamurthy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23282/ --- (Updated July 19, 2014, 12:49 a.m.) Review request for cloudstack, Alena Prokharchyk, Hugo Trippaers, and Sheng Yang. Bugs: CLOUDSTACK-6845 https://issues.apache.org/jira/browse/CLOUDSTACK-6845 Repository: cloudstack-git Description --- This is first code drop for NuageVsp Network plugin support that will bring the Nuage VSP network virtualization technology to CloudStack. We need a new branch to checkin the fixes once the review is done. Please create a new branch for NuageVsp plugin. Diffs - api/src/com/cloud/event/EventTypes.java 71bfdb6 api/src/com/cloud/network/Network.java 885bffe api/src/com/cloud/network/Networks.java 1e4d229 api/src/com/cloud/network/PhysicalNetwork.java 8cc214e client/WEB-INF/classes/resources/messages.properties b192cb0 client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 client/pom.xml 46933d9 client/tomcatconf/commands.properties.in b9ac27b plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 8e4c710 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0922765 plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java a2b9625 plugins/network-elements/nuage-vsp/pom.xml PRE-CREATION plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/module.properties PRE-CREATION plugins/network-elements/nuage-vsp/resources/META-INF/cloudstack/vsp/spring-vsp-context.xml PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/StartupVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReleaseVmVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspCommand.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AddNuageVspDeviceCmd.java PRE-CREATION plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DeleteNuageVspDeviceCmd.java PRE-CREATION
Re: Review Request 23603: Fixed CLOUDSTACK-6983: unable to register lxc template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23603/#review48211 --- Commit 58bad41910970fb3b08aa4d21875af6d04c8bf2e in cloudstack's branch refs/heads/master from Rajani Karuturi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58bad41 ] Fixed CLOUDSTACK-6983: unable to register lxc template added a check for tar.gz format in checktemplate - ASF Subversion and Git Services On July 21, 2014, 9:53 a.m., Rajani Karuturi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23603/ --- (Updated July 21, 2014, 9:53 a.m.) Review request for cloudstack, Kishan Kavala and Marcus Sorensen. Bugs: CLOUDSTACK-6983 https://issues.apache.org/jira/browse/CLOUDSTACK-6983 Repository: cloudstack-git Description --- added a check for tar.gz format in checktemplate Diffs - utils/src/org/apache/cloudstack/utils/template/TemplateUtils.java bad94de Diff: https://reviews.apache.org/r/23603/diff/ Testing --- manually tested register template on lxc Thanks, Rajani Karuturi
Re: Review Request 23679: CLOUDSTACK-7130: Tagging failed test cases with product bug Id
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23679/#review48342 --- Commit 88f35179ef90dc4f7696b6fe2e8ee7ca4d00586c in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=88f3517 ] Revert CLOUDSTACK-7130: Adding BugId to failed test cases This reverts commit 24da72f37395a6bb612ea1d073db0155289cf000. - ASF Subversion and Git Services On July 18, 2014, 1:52 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23679/ --- (Updated July 18, 2014, 1:52 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7130 https://issues.apache.org/jira/browse/CLOUDSTACK-7130 Repository: cloudstack-git Description --- Tagging failed test cases with product bug Id. Diffs - test/integration/smoke/test_volumes.py 7fbcc21 Diff: https://reviews.apache.org/r/23679/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 23547: CLOUDSTACK-7113: Ability to reset password when Router VM is stopped
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23547/#review48115 --- Commit 0069037573247e2cbe545e8d01d609040444e453 in cloudstack's branch refs/heads/master from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0069037 ] CLOUDSTACK-7113: Ability to reset password when Router VM is stopped With this improvement password reset also happens when router is in stopped state on resetPasswordCmd and restoreVM - ASF Subversion and Git Services On July 16, 2014, 10:06 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23547/ --- (Updated July 16, 2014, 10:06 a.m.) Review request for cloudstack, Jayapal Reddy and Kishan Kavala. Bugs: CLOUDSTACK-7113 https://issues.apache.org/jira/browse/CLOUDSTACK-7113 Repository: cloudstack-git Description --- CLOUDSTACK-7113: Ability to reset password when Router VM is stopped With this improvement password reset also happens when router is in stopped state on resetPasswordCmd and restoreVM Diffs - server/src/com/cloud/network/element/VirtualRouterElement.java 3b3cacd server/src/com/cloud/vm/UserVmManagerImpl.java dac4acf Diff: https://reviews.apache.org/r/23547/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/#review48122 --- Commit ec49669f1cf525b207889ae13a8a2b01a0271933 in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ec49669 ] CLOUDSTACK-7024: Resolved cleanup issue in test script - ASF Subversion and Git Services On July 18, 2014, 12:08 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/ --- (Updated July 18, 2014, 12:08 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7024 https://issues.apache.org/jira/browse/CLOUDSTACK-7024 Repository: cloudstack-git Description --- Resolved issue related to order of cleanup items. The project must be removed before the account which manages it. Diffs - test/integration/component/test_project_usage.py 5e0dda5 Diff: https://reviews.apache.org/r/23677/diff/ Testing --- Yes. Log: Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS === ok -- Ran 1 test in 285.451s OK Thanks, Ashutosh Kelkar
Re: Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/#review48124 --- Commit 5f87056e950e0cae042d0c836f10a091800b8dbc in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5f87056 ] CLOUDSTACK-7024: Resolved cleanup issue in test script - ASF Subversion and Git Services On July 18, 2014, 12:08 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/ --- (Updated July 18, 2014, 12:08 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7024 https://issues.apache.org/jira/browse/CLOUDSTACK-7024 Repository: cloudstack-git Description --- Resolved issue related to order of cleanup items. The project must be removed before the account which manages it. Diffs - test/integration/component/test_project_usage.py 5e0dda5 Diff: https://reviews.apache.org/r/23677/diff/ Testing --- Yes. Log: Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS === ok -- Ran 1 test in 285.451s OK Thanks, Ashutosh Kelkar
Re: Review Request 23679: CLOUDSTACK-7130: Tagging failed test cases with product bug Id
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23679/#review48125 --- Commit 24da72f37395a6bb612ea1d073db0155289cf000 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=24da72f ] CLOUDSTACK-7130: Adding BugId to failed test cases - ASF Subversion and Git Services On July 18, 2014, 1:52 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23679/ --- (Updated July 18, 2014, 1:52 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7130 https://issues.apache.org/jira/browse/CLOUDSTACK-7130 Repository: cloudstack-git Description --- Tagging failed test cases with product bug Id. Diffs - test/integration/smoke/test_volumes.py 7fbcc21 Diff: https://reviews.apache.org/r/23679/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 23604: CLOUDSTACK-7108: Reading provisioningtype in library for sparse and fat provisioning types
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23604/#review47986 --- Commit 6f9b3cc9d13bd1bc002ce0afad3ed416b590f882 in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6f9b3cc ] CLOUDSTACK-7108: Reading provisioningtype for disk offering in base.py - ASF Subversion and Git Services On July 17, 2014, 7:25 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23604/ --- (Updated July 17, 2014, 7:25 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7108 https://issues.apache.org/jira/browse/CLOUDSTACK-7108 Repository: cloudstack-git Description --- The provisioning type was passes through test case, but was not read in the library, hence not passed to the API. Hence the test cases failed as the provioning type would be thin by default instead of sparse/fat. Diffs - tools/marvin/marvin/lib/base.py fe257f0 Diff: https://reviews.apache.org/r/23604/diff/ Testing --- Yes. Log: Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === ok Test to update existing disk offering ... SKIP: skip Test to delete disk offering ... SKIP: skip -- Ran 5 tests in 0.301s OK (SKIP=2) Thanks, Ashutosh Kelkar
Re: Review Request 23606: CLOUDSTACK-7025: Resolving test script issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23606/#review47994 --- Commit 33fdfbc83407037b45624ca84ca436fab72e59ab in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=33fdfbc ] CLOUDSTACK-7025: Resolving test script issue - ASF Subversion and Git Services On July 17, 2014, 8:53 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23606/ --- (Updated July 17, 2014, 8:53 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7025 https://issues.apache.org/jira/browse/CLOUDSTACK-7025 Repository: cloudstack-git Description --- defaultNetworkId was not specified. Specified it in the setupClass. Diffs - test/integration/component/test_add_remove_network.py 4222f7a Diff: https://reviews.apache.org/r/23606/diff/ Testing --- 4 Test cases fixed by this. Log: Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to stopped VM ... SKIP: skip Add network to stopped VM ... SKIP: skip Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS === ok Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS === ok Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS === ok Add VPC network to stopped VM belonging to isolated network ... SKIP: skip Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS === ok Add network with invalid ip address to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to VM with maximum network limit reached ... SKIP: skip -- Ran 14 tests in 1523.655s OK (SKIP=10) Thanks, Ashutosh Kelkar
Re: Review Request 23606: CLOUDSTACK-7025: Resolving test script issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23606/#review47995 --- Commit 28a4ae3713af85b95bc0aae52f7fff032ee595aa in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=28a4ae3 ] CLOUDSTACK-7025: Resolving test script issue - ASF Subversion and Git Services On July 17, 2014, 8:53 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23606/ --- (Updated July 17, 2014, 8:53 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7025 https://issues.apache.org/jira/browse/CLOUDSTACK-7025 Repository: cloudstack-git Description --- defaultNetworkId was not specified. Specified it in the setupClass. Diffs - test/integration/component/test_add_remove_network.py 4222f7a Diff: https://reviews.apache.org/r/23606/diff/ Testing --- 4 Test cases fixed by this. Log: Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to stopped VM ... SKIP: skip Add network to stopped VM ... SKIP: skip Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS === ok Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS === ok Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS === ok Add VPC network to stopped VM belonging to isolated network ... SKIP: skip Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS === ok Add network with invalid ip address to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to running VM ... SKIP: skip Add network to VM with maximum network limit reached ... SKIP: skip -- Ran 14 tests in 1523.655s OK (SKIP=10) Thanks, Ashutosh Kelkar
Re: Review Request 23607: CLOUDSTACK-7020:Fixed test script issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23607/#review47996 --- Commit b7d445873c36d523571896ea1c51a49f65024445 in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b7d4458 ] CLOUDSTACK-7020:Fixed test script issue - ASF Subversion and Git Services On July 17, 2014, 9:02 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23607/ --- (Updated July 17, 2014, 9:02 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7020 https://issues.apache.org/jira/browse/CLOUDSTACK-7020 Repository: cloudstack-git Description --- Fixed test script issue related to cleanup Diffs - test/integration/component/test_usage.py 4413f43 Diff: https://reviews.apache.org/r/23607/diff/ Testing --- Yes. Log: Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS === ok -- Ran 1 test in 573.037s OK Thanks, Ashutosh Kelkar
Re: Review Request 23608: CLOUDSTACK-7014: Resolving test script related to affinity groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23608/#review47999 --- Commit 1cc6317b5e744afb74b63af6600af32bdfedb888 in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1cc6317 ] CLOUDSTACK-7014: Resolving test script related to affinity groups tests - ASF Subversion and Git Services On July 17, 2014, 9:23 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23608/ --- (Updated July 17, 2014, 9:23 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7014 https://issues.apache.org/jira/browse/CLOUDSTACK-7014 Repository: cloudstack-git Description --- Changing __cleanup to _cleanup Diffs - test/integration/component/test_affinity_groups.py de5f007 Diff: https://reviews.apache.org/r/23608/diff/ Testing --- Yes Thanks, Ashutosh Kelkar
Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23611/#review48001 --- Commit 332191b1bf2935bcad4c05a9fd61d0ebc30f035b in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=332191b ] CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py - ASF Subversion and Git Services On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23611/ --- (Updated July 17, 2014, 10:24 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7013 https://issues.apache.org/jira/browse/CLOUDSTACK-7013 Repository: cloudstack-git Description --- Corrected typo. cls.append to cls._cleanup.append Diffs - test/integration/component/test_add_remove_network.py dbba59b Diff: https://reviews.apache.org/r/23611/diff/ Testing --- Yes. Log: Try to remove nic from a vm providing wrong vm id to API ... === TestName: test_19_remove_nic_wrong_vm_id | Status : SUCCESS === ok -- Ran 1 test in 172.776s OK Thanks, Ashutosh Kelkar
Re: Review Request 23613: CLOUDSTACK-7022: Fixed typo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/#review48006 --- Commit 4bab99972f5e87bb6059f34cd0a302db703342f7 in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4bab999 ] CLOUDSTACK-7022: Fixed typo - ASF Subversion and Git Services On July 17, 2014, 11:03 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/ --- (Updated July 17, 2014, 11:03 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7022 https://issues.apache.org/jira/browse/CLOUDSTACK-7022 Repository: cloudstack-git Description --- Fixed typo. Diffs - test/integration/component/test_usage.py 4f9d1d7 Diff: https://reviews.apache.org/r/23613/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 23613: CLOUDSTACK-7022: Fixed typo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/#review48008 --- Commit 967b82f16b93bf1df4473b7ce8dd314f015098e8 in cloudstack's branch refs/heads/4.4-forward from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=967b82f ] CLOUDSTACK-7022: Fixed typo - ASF Subversion and Git Services On July 17, 2014, 11:03 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/ --- (Updated July 17, 2014, 11:03 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7022 https://issues.apache.org/jira/browse/CLOUDSTACK-7022 Repository: cloudstack-git Description --- Fixed typo. Diffs - test/integration/component/test_usage.py 4f9d1d7 Diff: https://reviews.apache.org/r/23613/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/#review47647 --- Commit ba389819338a9be23f1cb604b9d586afb5598795 in cloudstack's branch refs/heads/master from Koushik Das [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ba38981 ] CLOUDSTACK-7062: Enabled back the test as not able to repro - ASF Subversion and Git Services On July 3, 2014, 12:19 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/ --- (Updated July 3, 2014, 12:19 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7062 https://issues.apache.org/jira/browse/CLOUDSTACK-7062 Repository: cloudstack-git Description --- Tagging test_01_primary_storage_iscsi with BugId Diffs - test/integration/smoke/test_primary_storage.py 66aec59 Diff: https://reviews.apache.org/r/23258/diff/ Testing --- File Attachments Patch for master https://reviews.apache.org/media/uploaded/files/2014/07/03/172621ab-42ad-4d11-91b9-1f43f5d290b1__0001-CLOUDSTACK-7062-Tagging-test-case-with-bug-Id.patch Thanks, Gaurav Aradhye
Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/#review47648 --- Commit 5e181acbdb0865c0d26307c4e5359ec9c615f615 in cloudstack's branch refs/heads/4.4-forward from Koushik Das [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5e181ac ] CLOUDSTACK-7062: Enabled back the test as not able to repro - ASF Subversion and Git Services On July 3, 2014, 12:19 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/ --- (Updated July 3, 2014, 12:19 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7062 https://issues.apache.org/jira/browse/CLOUDSTACK-7062 Repository: cloudstack-git Description --- Tagging test_01_primary_storage_iscsi with BugId Diffs - test/integration/smoke/test_primary_storage.py 66aec59 Diff: https://reviews.apache.org/r/23258/diff/ Testing --- File Attachments Patch for master https://reviews.apache.org/media/uploaded/files/2014/07/03/172621ab-42ad-4d11-91b9-1f43f5d290b1__0001-CLOUDSTACK-7062-Tagging-test-case-with-bug-Id.patch Thanks, Gaurav Aradhye
Re: Review Request 21685: Fixed Regression Issues for CLOUDSTACK-6708
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21685/#review47652 --- Commit aab6e1222fc75a37f8015ba1d2c7bc923c1cf614 in cloudstack's branch refs/heads/master from santhosh [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aab6e12 ] Fixed Regression issues mentioned under CLOUDSTACK-6708 Signed-off-by: santhosh santhosh.eduku...@gmail.com Conflicts: test/integration/smoke/test_deploy_vm.py test/integration/smoke/test_network.py test/integration/smoke/test_routers.py test/integration/smoke/test_vm_life_cycle.py - ASF Subversion and Git Services On May 20, 2014, 11:50 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21685/ --- (Updated May 20, 2014, 11:50 a.m.) Review request for cloudstack, daan Hoogland and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-6708 https://issues.apache.org/jira/browse/CLOUDSTACK-6708 Repository: cloudstack-git Description --- There were few failures observed under regression. Fixed them. Added Bugids to few test cases so that they will not run till bugs are fixed. Diffs - test/integration/smoke/test_deploy_vm.py 473b020 test/integration/smoke/test_hosts.py 52827aa test/integration/smoke/test_network.py 85b417c test/integration/smoke/test_routers.py 2aa83c3 test/integration/smoke/test_vm_life_cycle.py 62a807d Diff: https://reviews.apache.org/r/21685/diff/ Testing --- Yes, ran on simulator and they works fine. Thanks, Santhosh Edukulla
Re: Review Request 23169: CLOUDSTACK-7010: Add domain to createZones in marvin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23169/#review47453 --- Commit 63ba1ddfb9ddfb47c7e0c564fea3ad8edf2bd19a in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=63ba1dd ] CLOUDSTACK-7010: Add domain to createZones in marvin - ASF Subversion and Git Services On July 8, 2014, 9:48 a.m., John Dilley wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23169/ --- (Updated July 8, 2014, 9:48 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7010 https://issues.apache.org/jira/browse/CLOUDSTACK-7010 Repository: cloudstack-git Description --- Add domain to createZones in deployDataCenter Diffs - tools/marvin/marvin/configGenerator.py 8d9 tools/marvin/marvin/deployDataCenter.py c097238 Diff: https://reviews.apache.org/r/23169/diff/ Testing --- Tested deployDataCenter, both with and without specifying a domain Thanks, John Dilley
Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/#review47291 --- Commit f5139f78395146ee99b9e0fdc376351b28c34063 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f5139f7 ] CLOUDSTACK-7062: Tagging test case with BugId - ASF Subversion and Git Services On July 3, 2014, 10:45 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/ --- (Updated July 3, 2014, 10:45 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7062 https://issues.apache.org/jira/browse/CLOUDSTACK-7062 Repository: cloudstack-git Description --- Tagging test_01_primary_storage_iscsi with BugId Diffs - test/integration/smoke/test_primary_storage.py 66aec59 Diff: https://reviews.apache.org/r/23258/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/#review47295 --- Commit 8c61566d612700f79b26e4e074502274cd676dcb in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8c61566 ] CLOUDSTACK-7062: Tagging test case with bug Id - ASF Subversion and Git Services On July 3, 2014, 12:19 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23258/ --- (Updated July 3, 2014, 12:19 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7062 https://issues.apache.org/jira/browse/CLOUDSTACK-7062 Repository: cloudstack-git Description --- Tagging test_01_primary_storage_iscsi with BugId Diffs - test/integration/smoke/test_primary_storage.py 66aec59 Diff: https://reviews.apache.org/r/23258/diff/ Testing --- File Attachments Patch for master https://reviews.apache.org/media/uploaded/files/2014/07/03/172621ab-42ad-4d11-91b9-1f43f5d290b1__0001-CLOUDSTACK-7062-Tagging-test-case-with-bug-Id.patch Thanks, Gaurav Aradhye
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/#review47190 --- Commit 6d0650bbcd26a7147857548c5f20949d2c986f76 in cloudstack's branch refs/heads/4.3 from Joris van Lieshout [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6d0650b ] CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases. Signed-off-by: Sebastien Goasguen run...@gmail.com - ASF Subversion and Git Services On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/ --- (Updated May 20, 2014, 9:05 a.m.) Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang. Bugs: cloudstack-6665 https://issues.apache.org/jira/browse/cloudstack-6665 Repository: cloudstack-git Description --- The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance. Diffs - systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6 Diff: https://reviews.apache.org/r/21431/diff/ Testing --- Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand. Thanks, Joris van Lieshout
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/#review47191 --- Commit 0e50cb1246f762e9d1f0ece937395ffb193c6452 in cloudstack's branch refs/heads/4.3 from Joris van Lieshout [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0e50cb1 ] CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases. Author: John Nielsen j...@betterservers.com Signed-off-by: Sebastien Goasguen run...@gmail.com - ASF Subversion and Git Services On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21431/ --- (Updated May 20, 2014, 9:05 a.m.) Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang. Bugs: cloudstack-6665 https://issues.apache.org/jira/browse/cloudstack-6665 Repository: cloudstack-git Description --- The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance. Diffs - systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6 Diff: https://reviews.apache.org/r/21431/diff/ Testing --- Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand. Thanks, Joris van Lieshout
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces the NullPointerException in ZoneWideStorageAllocator filter method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/#review47175 --- Commit 1e72e5a818b7bcc738262a2b10794a17fbb0076b in cloudstack's branch refs/heads/master from ynojima [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1e72e5a ] CLOUDSTACK-6935 remove iSCSI storage filtering logic for Root volume since there is no reason to filter it out - ASF Subversion and Git Services On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/ --- (Updated June 23, 2014, 5:30 a.m.) Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-6965 https://issues.apache.org/jira/browse/CLOUDSTACK-6965 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method. In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type. But cluster is null for ZoneWideStoragePool and Hence the exception. Diffs - engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6 Diff: https://reviews.apache.org/r/22807/diff/ Testing --- Thanks, Anshul Gangwar
Re: Review Request 23150: CLOUDSTACK-7006: Restore template ID in ROOT volume usages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23150/#review46974 --- Commit caa102c23d352d8e9f2f8a4f4159a3fc7d776f26 in cloudstack's branch refs/heads/4.3 from Olivier Lemasle [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=caa102c ] CLOUDSTACK-7006: Restore template ID in ROOT volume usages Signed-off-by: Sebastien Goasguen run...@gmail.com - ASF Subversion and Git Services On June 30, 2014, 8:53 a.m., Olivier Lemasle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23150/ --- (Updated June 30, 2014, 8:53 a.m.) Review request for cloudstack, Kishan Kavala and Sebastien Goasguen. Bugs: CLOUDSTACK-7006 https://issues.apache.org/jira/browse/CLOUDSTACK-7006 Repository: cloudstack-git Description --- This patch restore the template ID in usages, for ROOT volume created from a template (see CLOUDSTACK-7006). The regression was on the class com.cloud.storage.VolumeManagerImpl (module cloud-server) but it has been renamed org.apache.cloudstack.engine.orchestration.VolumeOrchestrator (module cloud-engine-orchestration). The patch applies on branchs master and branch 4.4. I've attached another patch for branch 4.3 (the only difference is formatting). Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 9ba3451 Diff: https://reviews.apache.org/r/23150/diff/ Testing --- Tested in ACS 4.3. 1. Deploy a new VM from a template. 2. Check if usages for the ROOT volume has the right templateId. 3. Deploy a new VM from an ISO, and add a DATA volume. 4. Check that there is no regression for these two types of volume usages without templateId. File Attachments patch version for ACS 4.3 https://reviews.apache.org/media/uploaded/files/2014/06/29/eee8a901-4141-46e7-b4ce-d9cbcfd8c85f__cloudstack-7006-for-ACS4.3.patch Thanks, Olivier Lemasle
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces the NullPointerException in ZoneWideStorageAllocator filter method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/#review46868 --- Commit 80f2694443e2795f289c95b10776285cc449f779 in cloudstack's branch refs/heads/4.4 from Daan Hoogland [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80f2694 ] Revert CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic This reverts commit 99dd86e588fd28dedd5fb3b830297a8a4f885760. - ASF Subversion and Git Services On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/ --- (Updated June 23, 2014, 5:30 a.m.) Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-6965 https://issues.apache.org/jira/browse/CLOUDSTACK-6965 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method. In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type. But cluster is null for ZoneWideStoragePool and Hence the exception. Diffs - engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6 Diff: https://reviews.apache.org/r/22807/diff/ Testing --- Thanks, Anshul Gangwar
Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces the NullPointerException in ZoneWideStorageAllocator filter method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/#review46869 --- Commit 7959c1faf0828c0974de6d891d7685c2916122d7 in cloudstack's branch refs/heads/4.4-forward from Daan Hoogland [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7959c1f ] Revert CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic This reverts commit 45f0c7367680f4bfbcee470139b708d69322be78. - ASF Subversion and Git Services On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/ --- (Updated June 23, 2014, 5:30 a.m.) Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-6965 https://issues.apache.org/jira/browse/CLOUDSTACK-6965 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method. In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type. But cluster is null for ZoneWideStoragePool and Hence the exception. Diffs - engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6 Diff: https://reviews.apache.org/r/22807/diff/ Testing --- Thanks, Anshul Gangwar
Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46722 --- Commit 039878b49a821cd1fd52e0ead0f528c3e9371a0c in cloudstack's branch refs/heads/4.4-forward from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=039878b ] CLOUDSTACK-6984: Re-enable the testcase - ASF Subversion and Git Services On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46728 --- Commit 7bc997f4fbaa80ed6335ba3658baaee5c9cb8e48 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7bc997f ] CLOUDSTACK-6984: Re-enable the testcase - ASF Subversion and Git Services On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
