[GitHub] cloudstack issue #2006: CLOUDSTACK-9833: Move configuration parameters from ...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/2006 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 In the travis ci the tests are failing it could be because of timeout. But when I run some of the test locally it is passing. The same test test_invalid_gw_nm is failing in travis ci. =my local xenserver setup test run == nosetests-2.7 --with-marvin --marvin-config=/Users/jayapal_uradi/dev/advanced.cfg --with-xunit --xunit-file=/tmp/test/testslog /Users/jayapal_uradi/dev/github/cloudstack/test/integration/component/test_invalid_gw_nm.py --zone=zone1 --hypervisor=xenserver Marvin Init Started === Marvin Parse Config Successful === === Marvin Setting TestData Successful=== Log Folder Path: /tmp//MarvinLogs//Apr_14_2017_10_30_49_WKRPUW. All logs will be available here === Marvin Init Logging Successful=== Marvin Init Successful ===final results are now copied to: /tmp//MarvinLogs/test_invalid_gw_nm_XQRFQU=== HSL007948:cloudstack jayapal_uradi$ vi /tmp//MarvinLogs/test_invalid_gw_nm_XQRFQU/ failed_plus_exceptions.txt results.txt runinfo.txt HSL007948:cloudstack jayapal_uradi$ vi /tmp//MarvinLogs/test_invalid_gw_nm_XQRFQU/results.txt HSL007948:cloudstack jayapal_uradi$ cat /tmp//MarvinLogs/test_invalid_gw_nm_XQRFQU/results.txt test_isolated_nw_invalid_gw (integration.component.test_invalid_gw_nm.TestIsolatedNetworkInvalidGw) ... === TestName: test_isolated_nw_invalid_gw | Status : SUCCESS === ok -- Ran 1 test in 5.837s OK == End of my local setup test run == https://travis-ci.org/apache/cloudstack/jobs/221647779 The command ./tools/travis/script.sh component/test_cpu_max_limits component/test_cpu_project_limits component/test_deploy_vm_userdata_multi_nic component/test_egress_fw_rules component/test_invalid_gw_nm component/test_ip_reservation component/test_lb_secondary_ip exited with 1 ContextSuite context=TestIsolatedNetw | exceptions.T | 0 | test_invalid_gw_nm | | orkInvalidGw>:setup | ypeError || --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon Jenkins and CI is passed, Can you please give LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 @koushik-das I have updated for your review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 Jenkins got timed out. I am force pushing again to trigger jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854129
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final
PublicIpAddress o2) {
associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
}
+// for network if the ips does not have any rules, then only
last ip
+List userIps =
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(),
FirewallRule.State.Active) > 0 ) {
--- End diff --
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854097 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v.i WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL) AND (d.name = 'cpuNumber' OR d.name = 'cpuSpeed' OR d.name = 'memory'); +<<<<<<< 1c48deefe9b534198cad19b5528ce0dcfa8d04a5 -- CLOUDSTACK-9827: Storage tags stored in multiple places DROP VIEW IF EXISTS `cloud`.`storage_tag_view`; + +ALTER TABLE `user_ip_address` ADD COLUMN `rule_state` VARCHAR(32) COMMENT 'static rule state while removing'; +=== --- End diff -- Corrected --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854055 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v.i WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL) AND (d.name = 'cpuNumber' OR d.name = 'cpuSpeed' OR d.name = 'memory'); +<<<<<<< 1c48deefe9b534198cad19b5528ce0dcfa8d04a5 --- End diff -- My bad, on multiple times rebase some how I missed it. Corrected now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110818988
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected ExecutionResult
cleanupNetworkElementCommand(final IpAssocCommand cmd)
// there is only one ip in this public vlan and removing
it, so
// remove the nic
-if (ipsCount == 1 && !ip.isAdd()) {
-removeVif = true;
+if (lastIp != null && lastIp.equalsIgnoreCase("true") &&
!ip.isAdd()) {
--- End diff --
@ProjectMoon
Updated to use org.apache.commons.lang.StringUtils
Can you please review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 It seems there is issue in CI due to that test are failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/2018 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110112007
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
PublicIpAddress o2) {
associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
}
+// for network if the ips does not have any rules, then only
last ip
+List userIps =
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(),
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+// check onetoonenat and also check if the ip "add":false.
If there are 2 PF remove 1 static nat add
+if (ip.isOneToOneNat() && ip.getRuleState() == null) {
+ipsStaticNat++;
+}
+}
+
final IpAssocCommand cmd = new IpAssocCommand(ipsToSend);
cmd.setAccessDetail(NetworkElementCommand.ROUTER_IP,
_routerControlHelper.getRouterControlIp(router.getId()));
cmd.setAccessDetail(NetworkElementCommand.ROUTER_GUEST_IP,
_routerControlHelper.getRouterIpInNetwork(associatedWithNetworkId,
router.getId()));
cmd.setAccessDetail(NetworkElementCommand.ROUTER_NAME,
router.getInstanceName());
final DataCenterVO dcVo =
_dcDao.findById(router.getDataCenterId());
cmd.setAccessDetail(NetworkElementCommand.ZONE_NETWORK_TYPE,
dcVo.getNetworkType().toString());
+// if there 1 static nat then it will be checked for remove at
the resource
+if (ipsWithrules == 0 && ipsStaticNat == 0 ) {
--- End diff --
If we check the ipsStaticNat=1 then we will miss the case of disabling
static nat on network with 1 with static nat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r11089
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
PublicIpAddress o2) {
associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
}
+// for network if the ips does not have any rules, then only
last ip
+List userIps =
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(),
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+// check onetoonenat and also check if the ip "add":false.
If there are 2 PF remove 1 static nat add
+if (ip.isOneToOneNat() && ip.getRuleState() == null) {
--- End diff --
In this case rule state is not set. It is null. I will improve the comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110082664
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -1764,9 +1765,12 @@ protected ExecutionResult
cleanupNetworkElementCommand(final IpAssocCommand cmd)
}
nicNum =
broadcastUriAllocatedToVM.get(ip.getBroadcastUri());
-if (numOfIps == 1 && !ip.isAdd()) {
-vifHotUnPlug(conn, routerName, ip.getVifMacAddress());
-networkUsage(routerIp, "deleteVif", "eth" + nicNum);
+if (lastIp != null && lastIp.equalsIgnoreCase("true") &&
!ip.isAdd()) {
--- End diff --
In CitrixresourceBase StringUtils is used from the
com.cloud.utils.StringUtils. So using StringUtils from java.lang will be
ambiguous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110082657
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected ExecutionResult
cleanupNetworkElementCommand(final IpAssocCommand cmd)
// there is only one ip in this public vlan and removing
it, so
// remove the nic
-if (ipsCount == 1 && !ip.isAdd()) {
-removeVif = true;
+if (lastIp != null && lastIp.equalsIgnoreCase("true") &&
!ip.isAdd()) {
--- End diff --
In CitrixresourceBase StringUtils is used from the
com.cloud.utils.StringUtils. So using StringUtils from java.lang will be
ambiguous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/2018
@wido
In the patch it can be observed that it is ("-A FIREWALL_%s DROP" % )
running without '-j' and it is not caught. There is duplicate rule due this the
impact is not seen.
So I have added the checking the iptables add command exit status, with
this iptables add command failure are caught. If there is error or exception
then it error will be returned to management server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1997 @DaanHoogland In the case of VM_POWER_STATE handler, if PowerOff or PowerReportMissing state is encountered, handlePowerOffReportWithNoPendingJobsOnVM() is called. If the VM is already in stopped state, so in DB the host ID is set to NULL. But in the above function, the sendStop() is still called on the empty hostID. So added condition in the sendStop() itself to check for the host id --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1917: CLOUDSTACK-9756: Configure to ignore the ipassoc fai...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1917 There are two LGTMs and there are not test failures in the test results. So marking tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1997 @ramkatru I am not sure about Daan comments. The tests results are positive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 @rhtyd Once this PR got the LGTMs, I can rebase it on 4.9. Can you please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2018: CLOUDSTACK-9848: Added exit status checking f...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/2018 CLOUDSTACK-9848: Added exit status checking for the iptables commands Added the checking exist status of iptables command. On exception return error so that it will be populated to management server You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack exitstatus Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2018.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2018 commit ab087cce9584c319a1e6144731aec32c2dcea0da Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-03-23T13:16:55Z CLOUDSTACK-9848: Added exit status checking for the iptables commands --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 @ustcweizhou I will add disable and CLOUDSTACK-9413 in new feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1993: CLOUDSTACK-8931: Fail to deploy VM instance when use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1993 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1993: CLOUDSTACK-8931: Fail to deploy VM instance when use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1993 @borisstoyanov Updated with jira ticket --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1997 CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE handler- Fixed This PR closes PR #1307 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack vmpoweroff Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1997.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1997 commit d7eae25322155810ba68aa6109978db287459736 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-03-09T10:30:16Z CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE handler- Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1996 CLOUDSTACK-9099: SecretKey is returned from the APIs This PR closes the PR #1152 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack secretkey Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1996.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1993: Fail to deploy VM instance when use.system.pu...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1993 Fail to deploy VM instance when use.system.public.ips=false This PR closes PR #907 Reproducing steps: 1. Create an account 2. Dedicate public ip range to this account. Infrastructure > physicalnetwork>physicalnet -> public: select Add account and add account created in step1 3. Create a shared network scope domain. Network->Add guest network 4. login to the account 5.Deploy Vm in the shared network. 6. Deploy vm is failing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack sharednw Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1993.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1993 commit 935193ae7a32e4bdf0072a060533e8d4a81a Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-03-08T05:03:11Z Fail to deploy VM instance when use.system.public.ips=false --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1965 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1970: CLOUDSTACK-9725 Failed to update VPC Network during ...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1970 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 Two LGTMs and no test failures from cloudmonger test results. @ustcweizhou waited for your comments for this, I am putting the mergeready tag. If you have anything to bring up let me know. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon Can you please review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1991 Updated the patch. Tested it no issues found. Please review this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1991#discussion_r104414236 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -1267,9 +1267,9 @@ def cache_ipset_keyword(): type = getIpsetType() tmpname = 'ipsetqzvxtmp' try: -util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type]) +util.pread2(['/bin/bash', '-c', 'ipset', '-N ', tmpname , type]) --- End diff -- Updated the patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1991 I am testing it again. Please wait till I update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1991#discussion_r104405081 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -1267,9 +1267,9 @@ def cache_ipset_keyword(): type = getIpsetType() tmpname = 'ipsetqzvxtmp' try: -util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type]) +util.pread2(['/bin/bash', '-c', 'ipset', '-N ', tmpname , type]) --- End diff -- Spaces will not cause any issues. Anyway I removed the spaces, tested and update the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1991 CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone Fixed issue in deploying vm in basic zone. There is issue in ipset command with xenserver 6.5. In util.pread2 ipset and -N is passed as single string and it caused the issue in command failure. util.pread2(['/bin/bash', '-c', 'ipset', '-N ', tmpname , type]) You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9821 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1991.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1991 commit c8819c0876582ffa1685b26bbb5aa4ed145d4723 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-03-06T11:10:05Z CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon
I have today this PR after rebasing latest master. I did not observe the
add:true for the removed ip.
Here is output from the ips.json and ip addr show output.
Here is the output:
4: eth2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state
UP qlen 1000
link/ether 06:f6:cc:00:00:0e brd ff:ff:ff:ff:ff:ff
inet 10.147.46.102/24 brd 10.147.46.255 scope global eth2
inet 10.147.46.112/24 brd 10.147.46.255 scope global secondary eth2
"eth2": [
{
"add": true,
"broadcast": "10.147.46.255",
"cidr": "10.147.46.102/24",
"device": "eth2",
"first_i_p": true,
"gateway": "10.147.46.1",
"netmask": "255.255.255.0",
"network": "10.147.46.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": false,
"public_ip": "10.147.46.102",
"size": "24",
"source_nat": true,
"vif_mac_address": "06:4a:54:00:00:0e"
},
{
"add": false,
"broadcast": "10.147.46.255",
"cidr": "10.147.46.107/24",
"device": "eth2",
"first_i_p": true,
"gateway": "10.147.46.1",
"netmask": "255.255.255.0",
"network": "10.147.46.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": true,
"public_ip": "10.147.46.107",
"size": "24",
"source_nat": true,
"vif_mac_address": "06:b5:36:00:00:13"
},
{
"add": false,
"broadcast": "10.147.46.255",
"cidr": "10.147.46.108/24",
"device": "eth2",
"first_i_p": true,
"gateway": "10.147.46.1",
"netmask": "255.255.255.0",
"network": "10.147.46.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": true,
"public_ip": "10.147.46.108",
"size": "24",
"source_nat": true,
"vif_mac_address": "06:6d:c8:00:00:14"
},
{
"add": false,
"broadcast": "10.147.46.255",
"cidr": "10.147.46.111/24",
"device": "eth2",
"first_i_p": true,
"gateway": "10.147.46.1",
"netmask": "255.255.255.0",
"network": "10.147.46.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": true,
"public_ip": "10.147.46.111",
"size": "24",
"source_nat": true,
"vif_mac_address": "06:32:90:00:00:17"
},
{
"add": true,
"broadcast": "10.147.46.255",
"cidr": "10.147.46.112/24",
"device": "eth2",
"first_i_p": true,
"gateway": "10.147.46.1",
"netmask": "255.255.255.0",
"network": "10.147.46.0/24",
"new_nic": false,
"nic_dev_id": 2,
"nw_type": "public",
"one_to_one_nat": true,
"public_ip": "10.147.46.112",
"size": "24",
"source_nat": true,
"vif_mac_address": "06:83:68:00:00:18"
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1917#discussion_r103897727
--- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java
---
@@ -43,6 +43,9 @@
"If true, when account has dedicated public ip range(s), once the
ips dedicated to the account have been consumed ips will be acquired from the
system pool",
true, ConfigKey.Scope.Account);
+static final ConfigKey RulesContinueOnError = new
ConfigKey("Advanced", Boolean.class,
"network.rule.delete.ignoreerror", "true",
--- End diff --
To continue with the existing behavior it is set to true. If some one want
to enable they can set to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1866: Advanced isolated network egress destination cidr su...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1866 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1866#discussion_r103863373
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java
---
@@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade() {
@Override
public void performDataMigration(Connection conn) {
+updateSourceCidrs(conn);
--- End diff --
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon The ip issue can be worked as separate ticket/PR. It is an isolated issue, it is not having any dependency with this PR. So we will get this PR in and create a separate ticket for the ip issue. What do you say ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon I have seen the issue of ips.json having the "add:true" while I am testing this PR. I tested this PR by manually removing the ip or setting add to false. Also I tested with the cleanup restart. With correct ips.json I did not see any issues with this PR. I think the ips.json problem is independent of this PR that need to be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1886 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1883 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1866: Advanced isolated network egress destination cidr su...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1866 I tested manually test_02_isolate_network_FW_PF_default_routes_egress_false Failed. It worked for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1824: CLOUDSTACK-9657: Fixed security group ipset issues w...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1824 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1886#discussion_r103136343 --- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java --- @@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer getPublicIpBytesSentAndReceived(DirectNetworkUs answer.put(publicIp, bytesSentAndReceived); } } +os.close(); --- End diff -- Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 Jenkins and travis are failing because of its internal failures. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1922 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 @ustcweizhou changes for kvm were in new file. It is missed while commiting, added now. Thanks for catching. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102888327
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId, final long accountId, f
}
@Override
-public String getNextAvailableMacAddress(final long networkConfigId) {
+public String getNextAvailableMacAddress(final long networkConfigId,
Integer zoneMacIdentifier) {
--- End diff --
I tried writing unit test cases for it. I have difficulty in call static
method. I tried with the PowerMockito.mockStatic but still I face NPE in
fetch.getNextSequence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1883 There are no marvin tests available for this. The unique mac address supposed for the two different deployments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102651320
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId, final long accountId, f
}
@Override
-public String getNextAvailableMacAddress(final long networkConfigId) {
+public String getNextAvailableMacAddress(final long networkConfigId,
Integer zoneMacIdentifier) {
final SequenceFetcher fetch = SequenceFetcher.getInstance();
-
long seq = fetch.getNextSequence(Long.class, _tgMacAddress,
networkConfigId);
-seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) << 16 &
0xl;
+if(zoneMacIdentifier!=0){
+seq = seq | _prefix << 40 | (long)zoneMacIdentifier << 32 |
networkConfigId << 16 & 0xl;
+}
+else {
+seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) <<
16 & 0xl;
+
+}
--- End diff --
formatted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102651284
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId, final long accountId, f
}
@Override
-public String getNextAvailableMacAddress(final long networkConfigId) {
+public String getNextAvailableMacAddress(final long networkConfigId,
Integer zoneMacIdentifier) {
final SequenceFetcher fetch = SequenceFetcher.getInstance();
-
long seq = fetch.getNextSequence(Long.class, _tgMacAddress,
networkConfigId);
-seq = seq | _prefix << 40 | _rand.nextInt(Short.MAX_VALUE) << 16 &
0xl;
+if(zoneMacIdentifier!=0){
--- End diff --
Added null check for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102649918
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -83,9 +83,19 @@
public final static int DEFAULT_AUTOSCALE_POLICY_INTERVAL_TIME = 30;
public final static int DEFAULT_AUTOSCALE_POLICY_QUIET_TIME = 5 * 60;
private final static Random s_rand = new
Random(System.currentTimeMillis());
-
-public static long createSequenceBasedMacAddress(final long
macAddress) {
-return macAddress | 0x0600l | (long)s_rand.nextInt(32768)
<< 25 & 0x00fffe00l;
+private final static long prefix = 0x1e;
+
+public static long createSequenceBasedMacAddress(final long
macAddress, long globalConfig) {
--- End diff --
It is not possible for macAddress, globalConfig to less than zero.
For globalconfig maximum value 255 is allowed.
macAddress value is coming from the DB (ipVO)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd This is basic zone related changes. In the above results failures are not related to the changes. Can you please review the changes once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...
GitHub user jayapalu reopened a pull request: https://github.com/apache/cloudstack/pull/1922 CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet Acquire ip from additional public subnet and configure nat on that ip. After this pick any from that network and access additional public subnet from this vm. Traffic is supposed to go via additional public subnet interface in the VR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack vpcApub Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1922.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1922 commit 0645cbe14c33c8271bd2f13785288c0be0c8038c Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-02-22T10:50:48Z CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/1922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1922#discussion_r102432766
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final
VirtualRouter router, final
sourceNatIpAdd = new Pair<IpAddressTO, Long>(ip,
ipAddr.getNetworkId());
addSourceNat = add;
}
+
+if (!firstIP || add) {
+firstIP = false;
+}
--- End diff --
for additional public subnet on delete it is not sure which ip is set to
first ip. So on delete we want to set sourcenat to true for all ips to delete
source nat rules.
@ramkatru
I will add above comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 There are not failed test cases on CI run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1824#discussion_r102192868
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
return txt
+#using all the iptables chain names length to 24 because cleanup_rules
groups the vm chain excluding -def,-eg
+#to avoid multiple iptables chains for single vm there using length 24
def chain_name(vm_name):
if vm_name.startswith('i-') or vm_name.startswith('r-'):
if vm_name.endswith('untagged'):
return '-'.join(vm_name.split('-')[:-1])
if len(vm_name) > 28:
--- End diff --
Updated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd nethash is supported in xenserver 6.2 but the problem is when configure /32 cidr giving the error ' Out of range cidr `10.147.52.30/32' specified'. Please see the bug for more details. I have also update the ipset version check. If version less than 6 use iptreemap else nethash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1885 Failed test cases are not related to this PR code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1874: CLOUDSTACK-9711: Fixed error reporting while ...
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/1874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1917: CLOUDSTACK-9756: Configure to ignore the ipassoc fai...
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1917
Travis CI test_outofbandmanagement is failing which is not related to this
PR changes. It seems there is problem with the test case.
@rhtyd Do you have any idea on this ?
Running tests: smoke/test_outofbandmanagement smoke/test_over_provisioning
smoke/test_password_server smoke/test_portable_publicip
smoke/test_primary_storage smoke/test_privategw_acl smoke/test_public_ip_range
smoke/test_pvlan smoke/test_regions smoke/test_reset_vm_on_reboot
smoke/test_resource_detail smoke/test_router_dhcphosts smoke/test_router_dns
smoke/test_routers smoke/test_routers_iptables_default_policy
smoke/test_routers_network_ops smoke/test_scale_vm smoke/test_secondary_storage
smoke/test_service_offerings smoke/test_snapshots smoke/test_ssvm
smoke/test_staticroles smoke/test_templates smoke/test_usage_events
smoke/test_vm_life_cycle smoke/test_vm_snapshots smoke/test_volumes
smoke/test_vpc_redundant smoke/test_vpc_router_nics smoke/test_vpc_vpn
smoke/misc/test_deploy_vm smoke/misc/test_escalations_templates
smoke/misc/test_vm_ha smoke/misc/test_vm_sync
Traceback (most recent call last):
File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 596, in
process_request_thread
self.finish_request(request, client_address)
File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 331, in
finish_request
self.RequestHandlerClass(request, client_address, self)
File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 652, in
__init__
self.handle()
File
"/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 436,
in handle
return IpmiServerContext().handle(data, address, socket)
File
"/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 112,
in handle
self.initiate_session(data, address, self.session)
File
"/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 143,
in initiate_session
myaddr, netfnlun = struct.unpack('2B', data[14:16])
error: unpack requires a string argument of length 2
Traceback (most recent call last):
File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 596, in
process_request_thread
self.finish_request(request, client_address)
File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 331, in
finish_request
self.RequestHandlerClass(request, client_address, self)
File "/opt/python/2.7.12/lib/python2.7/SocketServer.py", line 652, in
__init__
self.handle()
File
"/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 436,
in handle
return IpmiServerContext().handle(data, address, socket)
File
"/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 112,
in handle
self.initiate_session(data, address, self.session)
File
"/home/travis/.local/lib/python2.7/site-packages/ipmisim/ipmisim.py", line 143,
in initiate_session
myaddr, netfnlun = struct.unpack('2B', data[14:16])
error: unpack requires a string argument of length 2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1886 @rafaelweingartner Traffic sentinel supports the post request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1379: CLOUDSTACK-8324: config drive data set/get scripts f...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1379 These scripts CI tests are not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1379: CLOUDSTACK-8324: config drive data set/get scripts f...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1379 These scripts are for config drive feature. Deploy vm in shared network without services then vm with config drive will be deployed. Place these scripts in vm template to set VM password and ssh keys. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1379: CLOUDSTACK-8324: config drive data set/get sc...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1379#discussion_r101223451 --- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in --- @@ -0,0 +1,107 @@ +#!/bin/bash +# +# Init file for SSH Public Keys Download Client +# +# chkconfig: 345 98 02 +# description: SSH Public Keys Download Client + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +# Modify this line to specify the user (default is root) +user=root + +mountdir=/mnt/configdrive + --- End diff -- Added mktemp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1379: CLOUDSTACK-8324: config drive data set/get sc...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1379#discussion_r101223426
--- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in ---
@@ -0,0 +1,107 @@
+#!/bin/bash
+#
+# Init file for SSH Public Keys Download Client
+#
+# chkconfig: 345 98 02
+# description: SSH Public Keys Download Client
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# Modify this line to specify the user (default is root)
+user=root
+
+mountdir=/mnt/configdrive
+
+# If lable name is other than config, please change the below line as
required
+DefaultDisk=/dev/disk/by-label/config
+
+SSHKey_File=$mountdir/cloudstack/metadata/public_keys.txt
+keys_received=0
+
+function prepare_mount
+{
+if [ ! -e $mountdir ]; then
+mkdir $mountdir
+chmod 700 $mountdir
+fi
+
+if [ -e $DefaultDisk ]; then
+Disk=$DefaultDisk
+else
+BLOCK_DEVICE=$(blkid -t LABEL='config' /dev/hd? /dev/sd? /dev/xvd?
-o device)
--- End diff --
Updated the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #872: Strongswan vpn feature
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/872 PR#1741 is closed. So closed this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #872: Strongswan vpn feature
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 Rebased against master. This PR changes are for basic zone. CI runs test cases for advanced zone. So tested manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1885#discussion_r100985099
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network,
boolean postApplyRules, List 0) {
+if (network.getVpcId() != null) {
--- End diff --
Improved. Added more details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1939 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #858: CLOUDSTACK-8886: Limitations is listUsageRecords outp...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/858 created new #PR 1939 for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1939: CLOUDSTACK-8886: Limitations is listUsageReco...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1939 CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRec⦠As @kansal is inactive created new branch and raised the PR. This is continuation of PR#858 https://github.com/apache/cloudstack/pull/858 Problem: Only domainid is returned by usageReports API call. In cloudstack documention it mentions "domain" as being in the usage response. The API should really be returning the domain as account information has both account and accountid. Fix: Missing setDomainName at the time of creating response. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8886 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1939.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1939 commit f17d27dd93e7c1b0ba60afdf78276a8b07c4dff0 Author: Kshitij Kansal <kansa...@gmail.com> Date: 2015-09-21T06:18:17Z CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRecords does not return domain - Fixed and tests added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #843: Security group ingress/egress issues with xens...
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/843#discussion_r100766384 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -356,18 +356,25 @@ def allow_egress_traffic(session): return 'false' return 'true' +def getIpsetType(): +try: +util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 6'"]) +return 'nethash' --- End diff -- For xenserver 6.5 the ipset version is 6. For xenserver version less than 6.5 (i.e 6.2) the ipset version is 4.x. if ipset version is 6 then it uses nethash otherwise it uses iptreemap The getIpsetType method is as below. def getIpsetType(): try: util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 6'"]) return 'nethash' except: return 'iptreemap' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill I have tested this PR with systemvm template with strongswan installed long back. The s2s vpn worked fine. LGTM from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1922 CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet Acquire ip from additional public subnet and configure nat on that ip. After this pick any from that network and access additional public subnet from this vm. Traffic is supposed to go via additional public subnet interface in the VR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack vpcApub Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1922.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1922 commit 5baacad1f97152f85f2f5a72a6ab0295539a6dcf Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-01-31T09:53:56Z CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1917 CLOUDSTACK-9756: Configure to ignore the ipassoc failure On failure of ip assoc in back end (In VR), added config option to ignore or not to ignore failure. Using this failures won't be ignored and ip address will not set to free in DB. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack RvRipRel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1917.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1917 commit 66b0033cc9456dd875425387f92169dbdec005bf Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-01-24T09:53:17Z CLOUDSTACK-9756: Configure to ignore the ipassoc failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1450 @ProjectMoon Added the new PR https://github.com/apache/cloudstack/pull/1908 for addressing missing issues in this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1908 CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface FIxed issue in disabling multiple static nat simultaneously. This patch has taken changes from the PR 1450 and added the missing parts https://github.com/apache/cloudstack/pull/1450 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack staticnat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1908.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1908 commit 7e9c436c904dd7e21844aa34177854eda42a82ee Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-01-17T09:50:16Z CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1450 @ProjectMoon I am working on it. I will be updating the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1450 I tested this patch with below steps. It is not removing the ip addresses on the VR interface. Some times observed that even there is one ip with static nat but the interface got removed. Steps to test this: 1. Configure additional public subnet and acquire 4 ip addresses 2. Enabled static nat on the 4 public ip addresses. 3. Go to VR console and see the new public interface created and ips are configured on the interface. 4. Disable static on all 4 public addresses (disable from UI one by one quickly) expected: inteface should get removed from the VR. But the interface is there in VR In another case in step4 disable static nat on only 3 public ip addresses. expected: interface with one ip supposed to be there. But the interface is deleted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1886 CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response Url generated by CCP to request traffic sentinel for usage stats is too long causing HTTP 414 Request-URI Too Long error response. This is because we are using the GET request to send the data to the traffic sentinel instance and url size exceeds the max length of GET request. Changing the request method to POST You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack trafficsentinel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1886.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1886 commit 021eae4f55f4dba9eb267d68a17893d7f31e0d99 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-01-02T10:59:17Z CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1885 CLOUDSTACK-9724: Fixed missing additional public ip on tier network w⦠In VPC tier network acquire an ip and configure the PF service on it. VR now will have the two ip addresses on the interface. Now restart the VPC tier network with cleanup option. After router comes up the public interface has only one ip (source nat ip) Fixed the above issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack vpctier Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1885.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1885 commit f678e5d70886b1177b3087e521bfdebb6f945a06 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2017-01-02T09:02:46Z CLOUDSTACK-9724: Fixed missing additional public ip on tier network with cleanup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1883 CLOUDSTACK-9723: Enable unique mac address across the zones Enable unique mac address across different deployments and networks. If there two networks in two different deployment zones then this feature will avoid mac address collision. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack uniqueMac Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1883.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1883 commit c3f1ff9533fe8d433580dc13209b7bcf4020bc3a Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-30T07:10:25Z CLOUDSTACK-9723: Enable unique mac address across the zones --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #838: CLOUDSTACK-8857 listProjects doesn't return tags vmst...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/838 Code changes are fine. Test results are there LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1876: CLOUDSTACK-9715: Update somaxconn value to de...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1876 CLOUDSTACK-9715: Update somaxconn value to default value Updated the somaxconn value to detault value 65535 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack somaxconn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1876 commit 94777f53330e6d7244334294df9dc575fd2678dc Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-29T10:09:53Z CLOUDSTACK-9715: Update somaxconn value to default value --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1874: CLOUDSTACK-9711: Fixed error reporting while ...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1874 CLOUDSTACK-9711: Fixed error reporting while adding vpn user If configuring vpn user in one of the network fails the failure is ignored, failure should be shown in API response. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack RAvpn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1874.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1874 commit 9805f0ed5aadd4496380f36535fd7a31440a32d0 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-28T09:52:23Z CLOUDSTACK-9711: Fixed error reporting while adding vpn user --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1873: CLOUDSTACK-9709: Updated the vm ip fetch task...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1873 CLOUDSTACK-9709: Updated the vm ip fetch task to use the correct the ⦠Updated the vm ip fetch task to use the seperate thread executor Also fixed in this If a vm with iso attached is restarted it would not have the attached iso after restart. Detect vmware tools mount status ahead to restore after reboot. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack dhcpOffloadFix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1873.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1873 commit 36658a60d85e6a8926fd1367b138508fefdcb9f1 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-27T09:04:28Z CLOUDSTACK-9709: Updated the vm ip fetch task to use the correct the thread Also fixed in this If a vm with iso attached is restarted it would not have the attached iso after restart. Detect vmware tools mount status ahead to restore after reboot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1866 Advanced isolated network egress destination cidr support added Added the destination cidr support for the advanced zone isolated network egress rule. With this now user can control both source and destination ip address of the egress firewall rules. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack egresdcidr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1866.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1866 commit e1351a1b2efd31e2546a203092da6bf458973161 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-23T09:59:11Z CLOUDSTACK-9669:egress destination UI changes commit 45533d16505339fd580349f1b7556270b7dcfc86 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-26T05:52:58Z CLOUDSTACK-9669:egress destination cidr VR python script changes commit 56286970e3a6fb3cc618a33aac6dd2c2516a3b49 Author: Jayapal <jayapal.ur...@accelerite.com> Date: 2016-12-26T07:08:53Z CLOUDSTACK-9669:egress destination API and orchestration changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1782: CLOUDSTACK-9617: Fixed enabling remote access after ...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1782 Rebased on 4.9 and added changes for @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1783: CLOUDSTACK-9615: Fixd applying ingress rules without...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1783 @rhtyd It is already rebased on 4.9 and also added changes for @ustcweizhou comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1782: CLOUDSTACK-9617: Fixed enabling remote access after ...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1782 @ustcweizhou I am updating code for the LB rules as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1824 CLOUDSTACK-9657: Fixed security group ipset issues with long vm name ipset set name max length allowed is 31 char. If the vm name has longer name then the trimming of set has done in this fix. Also cleanup of rules are taken care. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jayapalu/cloudstack SGipset Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1824.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1824 commit 32357d0b7c62bbef983967e3b7b690f9d3d68426 Author: Jayapalu <jaya...@apache.org> Date: 2016-12-08T10:35:21Z CLOUDSTACK-9657: Fixed security group ipset issues with long vm name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1783: CLOUDSTACK-9615: Fixd applying ingress rules without...
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1783 rebased it on 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1741 @rhtyd While testing this feature public ip order change on reboot issue blocked this. My suggestion is that public ip out of order is different issue. If vpn functionalities working except the reboot with multiple ips then we will go ahead with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
