[GitHub] cloudstack pull request: Remove AWS api bridge
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/44#issuecomment-64081042 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/63 CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's' Signed-off-by: René Moser You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/deleteisoapi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit c7ebd13d02948fd2ca2d6e4245127e01a2f7579e Author: René Moser Date: 2015-01-13T15:23:31Z CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's' Signed-off-by: René Moser --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1999 CLOUDSTACK-9600: listVirtualMachines: add VPC ID to response Currently, the listVirtualMachines takes the vpcid as a param but does not return it in a response. It also solves expensive operation for finding out if a VM is in a VPC. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/CLOUDSTACK-9600-vms-vpc-id Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1999.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1999 commit 705336af9d03b680c3254d37376ae22b146e97e8 Author: Rene Moser Date: 2017-03-03T14:34:40Z CLOUDSTACK-9600: listVirtualMachines: add VPC ID to response --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2000: CLOUDSTACK-8873: add zonename in load balance...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/2000 CLOUDSTACK-8873: add zonename in load balancer response add zonename in response for consistency. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/CLOUDSTACK-8873 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2000.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2000 commit 0ff7600a18ef82747a27bae7effabd7139127f87 Author: Rene Moser Date: 2017-03-10T10:49:49Z CLOUDSTACK-8873: add zonename in load balancer response --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou (1) I don't fully understand that question, there are network ids on the nics https://github.com/resmo/cloudstack/blob/705336af9d03b680c3254d37376ae22b146e97e8/server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java#L236 , I didn't change anything related to networkid. (2) Correct me if I am wrong, but a IMHO a VM can not be part of more than one VPC, but can be connected of different VPC tiers with corresponds in networks in VPC. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou I can add another VPC tier in the _same_ VPC to the VM, but it is still the same VPC. I am still convinced this PR is valid unless you prove otherwise. I am ok with adding the VPC id to the nic's network response but this does not solve my issue completely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou let us discuss this on ML. I am now doing exactly this querying ListNetworks for each network for each VM which is stupid expensive operation to only find out if a VM is in a VPC. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC...
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1999 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 Ok, then. Thanks @ustcweizhou and @remibergsma for the clarification, changing the code to add vpcid on the nic's network response. Closing this PR in favor of a new and fresh one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76288584 @bhaisaab This also fails on cloudstack 4.4.2 on debian 7. fix worked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76355991 @bhaisaab Seems I overlooked the fix yesterday. All good in 4.4 branch. never mind. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76358975 @runseb * 4.5 https://github.com/apache/cloudstack/commit/7885a6c4efe13a07b3966ef8684152dda5108f8b * master https://github.com/apache/cloudstack/commit/396936ea5e84d079394664fd1d0596a94e159855 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/94 CreatePortForwardingRuleCmd: Fix typo in description You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit 7028541210fc427f3b293d2dbf85324a811098ea Author: René Moser Date: 2015-03-04T12:27:29Z CreatePortForwardingRuleCmd: Fix typo in doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/94#issuecomment-77149699 @runseb ah yes, sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/94#issuecomment-77151592 Did some more text stylings. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Debian package improvements
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/96#discussion_r25807707 --- Diff: debian/control --- @@ -3,26 +3,26 @@ Section: libs Priority: extra Maintainer: Wido den Hollander Build-Depends: debhelper (>= 7), openjdk-7-jdk, genisoimage, - python-mysqldb, maven3 | maven (>= 3), python (>= 2.6.6-3~) + python-mysqldb, maven (>= 3) | maven3, python-all (>= 2.6.6-3~) Standards-Version: 3.8.1 Homepage: http://www.cloudstack.org/ Package: cloudstack-common Architecture: all -Depends: bash, genisoimage, nfs-common +Depends: ${misc:Depends}, ${python:Depends}, genisoimage, nfs-common Conflicts: cloud-scripts, cloud-utils, cloud-system-iso, cloud-console-proxy, cloud-daemonize, cloud-deps, cloud-python, cloud-setup Description: A common package which contains files which are shared by several CloudStack packages Package: cloudstack-management Architecture: all -Depends: cloudstack-common (= ${source:Version}), tomcat6, sysvinit-utils, sudo, jsvc, python-mysqldb, libmysql-java, python-paramiko, augeas-tools, mysql-client +Depends: ${misc:Depends}, ${python:Depends}, cloudstack-common (= ${source:Version}), tomcat6, sudo, jsvc, python-mysqldb, libmysql-java, python-paramiko, augeas-tools, mysql-client, adduser --- End diff -- It has been confirmed that tomcat7 is also working (RHEL7 in packaging). I suggest to change `tomcat6` to `tomcat6 | tomcat7`to support Debian Jessie. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Debian package improvements
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/96#issuecomment-77235301 +1 from me @debfx I recently also saw there is quite a hack in the debian init script for setting `JAVA_HOME` (https://github.com/apache/cloudstack/blob/master/packaging/debian/init/cloud-management#L73). I suggest to replace it with: ~~~ JAVA_HOME=/usr/lib/jvm/default-java ~~~ Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/103 systemvm: use Debian http redirector for apt repositories * No offline mirrors * No out of date mirrors * New mirrors are used * Load-balancing * Faster downloads (when APT is used, via parallel downloads) * Great on mobility Also see http://http.debian.net/ for more information. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/debian Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit 1d852f0c4468445c8b3d21ec12f68a596ce4e34a Author: René Moser Date: 2015-03-09T22:51:22Z systemvm: use Debian http redirector for apt repositories * No offline mirrors * No out of date mirrors * New mirrors are used * Load-balancing * Faster downloads (when APT is used, via parallel downloads) * Great on mobility Also see http://http.debian.net/ for more information. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/104 systemvm: correct sftp subsystem path of debian wheezy The sftp subsystem path is `/usr/lib/openssh/sftp-server` according https://packages.debian.org/wheezy/amd64/openssh-server/filelist and checked with plain wheezy install. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/debian-sshd-config Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit 865f3367ad31df5855bc380c9916cdf84c570c08 Author: René Moser Date: 2015-03-09T23:04:22Z systemvm: correct sftp subsystem path of debian wheezy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/104#issuecomment-78016126 @karuturi we use [Ansible](http://docs.ansible.com/) to manage the routers ad-hoc (config fixes, package updates, security fixes, etc). Ansible uses SFTP for file transfer per default (but it can be configured to use SCP as fallback). So we discovered this issue while debugging. I can not confirm SFTP works without this patch. This patch fixed the SFTP functionality for us. I see no reason why the SFTP subsystem should be removed. On the other hand, SFTP has less overhead then SCP (aka faster) and in a big environment of hundreds of routers, this is performance gain. So voting against removing the subsystem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/8e953fe8593cf624c37213d94f79ea9e17a12f27#commitcomment-10121450 In systemvm/patches/debian/config/opt/cloud/bin/savepassword.sh: In systemvm/patches/debian/config/opt/cloud/bin/savepassword.sh on line 33: * The intention is not clear here to me. Should the value be `true` if cat fails? * Recommending to add quotes. ~~~bash TOKEN="" if [ -r /tmp/passwdsrvrtoken ]; then TOKEN="$(cat /tmp/passwdsrvrtoken)" fi ~~~ or ~~~bash TOKEN=true if [ -r /tmp/passwdsrvrtoken ]; then TOKEN="$(cat /tmp/passwdsrvrtoken)" fi ~~~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/103#issuecomment-78066339 @bhaisaab would you mind cherry-picking this commit into 4.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: fix/improve irqbalance on multi...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/119 systemvm: fix/improve irqbalance on multicore VR. This is a known issue in irqbalance 1.0.3 and was partially fixed in 1.0.4. Using the package 1.0.6 from wheezy backports helped on many VRs balancing the interrupts, but not on all. It seems only 1.0.7 fixes all issues regarding this, also see thread in user ML http://mail-archives.apache.org/mod_mbox/cloudstack-users/201503.mbox/%3C5508540E.4090302%40renemoser.net%3E You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/systemvm-irqbalance Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #119 commit 33d2445eb9202891e88d5211e9a7071331a77f84 Author: Rene Moser Date: 2015-03-19T10:19:03Z systemvm: fix/improve irqbalance on multicore VR. This is a known issue in irqbalance 1.0.3 and was partially fixed in 1.0.4. Using the package 1.0.6 from wheezy backports helped on many VRs balancing the interrupts, but not on all. It seems only 1.0.7 fixes all issues regarding this, also see thread in user ML http://mail-archives.apache.org/mod_mbox/cloudstack-users/201503.mbox/%3C5508540E.4090302%40renemoser.net%3E --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: fix/improve irqbalance on multi...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/119#issuecomment-84888161 yes please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: fix/improve irqbalance on multi...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/119#issuecomment-84899117 @bhaisaab I tested the irqbalance from backports, but I did not test the building of the systemvm. I assumed it must be set up in this script. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/123 systemvm: use Debian http redirector for backports You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/debian-http-redirector-backports Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 commit d266cc59f35de1d299d68ec267a1f71ddc9cc63a Author: Rene Moser Date: 2015-03-23T09:28:27Z systemvm: use Debian http redirector for backports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request:
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/d0e65d7c3429d3a582632005d526c668f071c3fe#commitcomment-10534427 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-6885: fix logrotate on VR to d...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/162 CLOUDSTACK-6885: fix logrotate on VR to depend on size In 6ac06e5e5e3ceed4a3e3a86ea5f82ffb59c266f2 logrotate was changed to run hourly. Some logrotate configs still have set `daily` only which results in logs not rotated hourly. The only way to ensure the log is rotated is to use size. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/conntrackd-logrotate-daily Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 3dbbc737d6977caf592e1a2261eec2943c4afb32 Author: Rene Moser Date: 2015-04-13T15:59:13Z CLOUDSTACK-6885: fix logrotate on VR to depend on size In 6ac06e5e5e3ceed4a3e3a86ea5f82ffb59c266f2 logrotate was changed to run hourly. Some logrotate configs still have set `daily` only which results in logs not rotated hourly. The only way to ensure the log is rotated is to use size. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CreateVMSnapshot: fix typo in API descrip...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/161 CreateVMSnapshot: fix typo in API description You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/createvmsnapshot-typo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #161 commit e334ea653f65a99141e4ded711306fd7d5ec3561 Author: Rene Moser Date: 2015-04-13T16:54:33Z CreateVMSnapshot: fix typo in API description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the routers iptables config persiste...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/167#issuecomment-93027681 There is a Debian package for this functionality called `iptables-persistent`. It is implemented using a init script. The rules are expected to be in `/etc/iptables/rules.v4` / `/etc/iptables/rules.v6` Rules can be loaded using `/etc/init.d/iptables-persistent start` and saved to file by ` /etc/init.d/iptables-persistent save`. Because of existing functionality in a Debian package (maintained, well known, supported in future Debian releases), I would like to use this package in favor of this commit. Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the routers iptables config persiste...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/167#issuecomment-93054007 hi @wilderrodrigues, never had any problems with it but didn't use it on a "router". It would be great if you can provide more details. I expected you didn't know about the package, but if you tested it, that is fine for me for now as well. Btw (@bhaisaab?) could you cherry-pick it into 4.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Make the routers iptables config persiste...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/167#issuecomment-93387973 Okay, I see. In this case cherry-picking does not make any sense. I may implement a workaround by saving the iptables periodically on the routers in our env. This is not a big overhead. Thanks guys @bhaisaab @wilderrodrigues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: RFC: improve iptables persistent on VR
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/178 RFC: improve iptables persistent on VR Iptables rules were loaded in `iptables-persistent` service during boot. So the first try was to save them where `iptables-persistent` reads them in /etc/iptables/rules.v4 / .v6. The problem was, that the service `cloud-early-config` resets /etc/iptables/rules.v4 / .v6 to the setup state. So even if you save iptables rules, they were overwritten during boot. That is why a fix was made in 2fad87d to workaround the problem. I reverted the workaround and made sure /etc/iptables/rules.v4 / .v6. won't get overwritten by `cloud-early-config` Signed-off-by: Rene Moser You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/iptables-persistent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #178 commit 1740c15b6b212318c8dccd0db87c273d845883ef Author: Rene Moser Date: 2015-04-17T09:17:11Z Revert "Make the routers persistent" This reverts commit 2fad87d3f3fec380ba5d595ee95f5caa88b37ee8. commit cc2fc0a63fd496b816a3540463903ba21988f9d6 Author: Rene Moser Date: 2015-04-17T09:37:43Z make iptables persistent on VR Iptables rules were loaded in `iptables-persistent` service during boot. So the first try was to save them where `iptables-persistent` reads them in /etc/iptables/rules.v4 / .v6. The problem was, that the service `cloud-early-config` resets /etc/iptables/rules.v4 / .v6 to the setup state. So even if you save iptables rules, they were overwritten during boot. That is why a fix was made in 2fad87d3f3fec380ba5d595ee95f5caa88b37ee8 to workaround the problem. I reverted the workaround and made sure /etc/iptables/rules.v4 / .v6. won't get overwritten by `cloud-early-config` Signed-off-by: Rene Moser --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: RFC: improve iptables persistent on VR
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Enhance VR performance
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r49976226 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def main(argv): +# The file we are currently processing, if it is "cmd_line.json" everything will be processed. +process_file = argv[1] + +# process_file can be None, if so assume cmd_line.json +if process_file is None: +process_file = "cmd_line.json" + +# Track if changes need to be committed to NetFilter +iptables_change = False + +# The "GLOBAL" Configuration object config = CsConfig() + logging.basicConfig(filename=config.get_logger(), level=config.get_level(), format=config.get_format()) + +# Load stored ip adresses from disk to CsConfig() config.set_address() logging.debug("Configuring ip addresses") -# IP configuration config.address().compare() config.address().process() -logging.debug("Configuring vmpassword") -password = CsPassword("vmpassword", config) -password.process() +if process_file == "cmd_line.json" or process_file == "guest_network.json": --- End diff -- small hint: for better readability I suggest this syntax instead: ~~~python if process_file in ['cmd_line.json', 'guest_network.json']: ~~~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: UI: improve filter dropdown width
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1354 UI: improve filter dropdown width Giving a little more space to fix new line, see [after and before](https://photos.google.com/share/AF1QipP6ZeMO4B_fSLCBocr0MQmgbbq3gAf0vDY8Hy4YjUgqLH_VY8vpP2y5U6RMWL9Vfw?key=ZFVxcjUxcXZvVmZGTTQzOER6VUxYWENVODJfXzhB) You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/ui-div-filter-width Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1354.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1354 commit d53dd0a671e635edcefcae332e1b7d428ac7600b Author: Rene Moser Date: 2016-01-20T12:22:34Z UI: improve filter dropdown width --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: SystemVM cleanups
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1414 SystemVM cleanups from the logrotate docs > size - With this, the log file is rotated when the specified size is reached. Size may be specified in bytes (default), kilobytes (sizek), or megabytes (sizem). > Note: If size and time interval options are specified at same time, only size option take effect. it causes log files to be rotated without regard for the last rotation time. If both log size and timestamp of a log file need to be considered by logrotate, the minsize option should be used. logrotate will rotate log file when they grow bigger than minsize, but not before the additionally specified time interval. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1414.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1414 commit 4a3bc1e3024a7bd1608d25068963328f456b0aa2 Author: Rene Moser Date: 2016-02-16T10:21:30Z systemvm, logrotate: remove daily explicitly as it is ignored If the size directive is used, logrotate will ignore the daily, weekly, monthly, and yearly directives. Signed-off-by: Rene Moser commit eb3cd8f487e4c573ff92d98cc7969a93891b1155 Author: Rene Moser Date: 2016-02-16T10:25:48Z remove cloud-cleanup This script does not do anything because it fails due missing /var/log/cloud directory. Logrotate is used for this functionality. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: SystemVM cleanups
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1414#issuecomment-185579250 Actually the logrotating is running every hour (by size), which can not be done with logrotate time interval. We have had problems in the past filling up /var (and / when it wasn't a separate partition). This PR does not change functionality, it just make it explicitely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-187360919 @sureshanaparti yes, that would be great --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: speedup iptables setup
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-204500797 LGTM! please merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8740: add custom.css to make c...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/704 CLOUDSTACK-8740: add custom.css to make custom UI styles easier You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/CLOUDSTACK-8740 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/704.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #704 commit b1978a1169cb3df4f09a8982dbc965b77b0e1bea Author: Rene Moser Date: 2015-08-17T12:09:12Z CLOUDSTACK-8740: add custom.css to make custom UI styles easier --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed typo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/708#issuecomment-132072808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/777 config: doc: add default value 10 in description for vm.network.nic.m⦠â¦ax.secondary.ipaddresses value hardcoded by commit 4925b9f6a126454215531998c461bf376ac6ab67 You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/config-string Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/777.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #777 commit 0b956bbc1f198f72ad5a60ade21e42c0e23ec15c Author: Rene Moser Date: 2015-09-04T13:58:55Z config: doc: add default value 10 in description for vm.network.nic.max.secondary.ipaddresses value hardcoded by commit 4925b9f6a126454215531998c461bf376ac6ab67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137751754 Salut Vincent I agree, but AFAIK there is a `/etc/sysctl.d` directory intended for persistent sysctl configs. What about adding a `cloud.conf` to `/etc/sysctl.d` with these settings as well? Any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: debian: Updated dependencies for Packages
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/783#issuecomment-138463931 IMHO we need some more changes here, and it might be more clear and easier to handle if we would make a package per ubuntu release and debian release, beginning from ubuntu 12.04.x and debian 7.x Some problems I have identified. * tomcat6.conf in https://github.com/apache/cloudstack/blob/master/debian/cloudstack-management.install#L28 * jvm hardcoded https://github.com/apache/cloudstack/blob/master/packaging/debian/init/cloud-management#L68 * tomcat6.conf in https://github.com/apache/cloudstack/blob/master/packaging/debian/init/cloud-management#L38 * TOMCAT6_USER=tomcat6 in https://github.com/apache/cloudstack/blob/master/packaging/debian/init/cloud-management#L64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138465486 I prefer a persistent config (you know where to search for it) and not a dynamic one with hard coded values. If these would be dynamic, then it is clear to use the .py. but they are not so why not write them down? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: debian: Updated dependencies for Packages
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/783#issuecomment-138466873 It depends, openjdk-8 would not work with current init script in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change while configur...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/791#issuecomment-139223195 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139913727 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140879864 @remibergsma does not look related to me, the keyword seems to be PowerReportMissing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141407138 @koushik-das @DaanHoogland unless we have a "better" solution I would like to go with @anshul1886 suggested fix. It seems the best way not breaking anything else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142882541 @anshul1886 @koushik-das @DaanHoogland and I had a debug session last friday, and since he is off for the next couple of days I can give you more details about we analysed. The powerReportMissing is not the problem, it is only the trigger. The graceful period is the problem. The calculation of this period is relaying (see https://github.com/apache/cloudstack/blob/4.5.2/engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java#L114) on the field `update_time` in table `vm_instance`. But if I look at the value it seems it doesn't get updated. So the grace period has most likely always passed. I tried to do a workaround doing the following, I ran an update sql for every 5 seconds which updated the `update_time` for my router r-342 which I was migrating around esx cluster nodes: ~~~ mysql -e 'update cloud.vm_instance set update_time=NOW() where id=342;' ~~~ And the router didn't get rebooted: ~~~ 2015-09-24 11:47:07,685 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-218:ctx-5849bd19) VM state report. host: 25, vm id: 342, power state: PowerOn 2015-09-24 11:47:07,696 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-218:ctx-5849bd19) VM state report is updated. host: 25, vm id: 342, power state: PowerOn 2015-09-24 11:48:06,462 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-55:ctx-84cd4323) VM state report. host: 19, vm id: 342, power state: PowerOn 2015-09-24 11:48:06,471 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-55:ctx-84cd4323) VM state report is updated. host: 19, vm id: 342, power state: PowerOn 2015-09-24 11:48:06,493 WARN [o.a.c.alerts] (DirectAgentCronJob-55:ctx-84cd4323) alertType:: 9 // dataCenterId:: 1 // podId:: 1 // clusterId:: null // message:: Router has been migrated out of band: r-342-VM 2015-09-24 11:49:06,539 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-29:ctx-2a57d676) Detected missing VM. host: 19, vm id: 342, power state: PowerReportMissing, last state update: 1443095344000 2015-09-24 11:49:06,539 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-29:ctx-2a57d676) vm id: 342 - time since last state update(-7197461ms) has not passed graceful period yet 2015-09-24 11:49:07,719 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-444:ctx-fdd4c055) VM state report. host: 20, vm id: 342, power state: PowerOn ~~~ Which means this patch is not fix the root cause. To me the root cause is that `update_time` is not updated or the gracePeriod calculation is wrong. Any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142901959 Increasing the grace period for a few minutes won't help. If you look at these update_time values I queried from 10 running routers, you see these are days, weeks behind. ~~~ mysql> select instance_name, type, update_time from vm_instance where instance_name like 'r-%' and removed is NULL and state = 'Running' limit 10\G; *** 1. row *** instance_name: r-2978-VM type: DomainRouter update_time: 2015-08-24 21:54:42 *** 2. row *** instance_name: r-3650-VM type: DomainRouter update_time: 2015-08-24 22:23:53 *** 3. row *** instance_name: r-3651-VM type: DomainRouter update_time: 2015-08-26 00:57:40 *** 4. row *** instance_name: r-3652-VM type: DomainRouter update_time: 2015-09-17 06:44:14 *** 5. row *** instance_name: r-3653-VM type: DomainRouter update_time: 2015-08-24 22:18:43 *** 6. row *** instance_name: r-3654-VM type: DomainRouter update_time: 2015-09-17 06:44:11 *** 7. row *** instance_name: r-3655-VM type: DomainRouter update_time: 2015-09-15 05:34:30 *** 8. row *** instance_name: r-3656-VM type: DomainRouter update_time: 2015-08-24 21:53:57 *** 9. row *** instance_name: r-3657-VM type: DomainRouter update_time: 2015-08-24 22:33:40 *** 10. row *** instance_name: r-3659-VM type: DomainRouter update_time: 2015-08-26 00:33:54 10 rows in set (0.01 sec) ~~~ But not updating the powerState (which would also update the update_date I assume) results in the gracePeriod uses a update_time weeks, months back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142906721 This is perfectly clear to me. The problem is we are relaying on the `update_time` (not to mix up with `power_state_update_time`). ~~~ *** 1. row *** instance_name: r-2978-VM type: DomainRouter update_time: 2015-08-24 21:54:42 power_state_update_time: 2015-09-09 08:30:42 power_state_update_count: 3 1 row in set (0.00 sec) ~~~ here ~~~java // 2 times of sync-update interval for graceful period long milliSecondsGracefullPeriod = PingInterval.value() * 2000L; for (VMInstanceVO instance : vmsThatAreMissingReport) { Date vmStateUpdateTime = instance.getUpdateTime(); //... long milliSecondsSinceLastStateUpdate = currentTime.getTime() - vmStateUpdateTime.getTime(); if (milliSecondsSinceLastStateUpdate > milliSecondsGracefullPeriod) { ~~~ so this calculation would do this: ~~~ milliSecondsSinceLastStateUpdate = currentTime.getTime() - vmStateUpdateTime.getTime() 2015-09-24 13:46:48 - 2015-08-24 21:54:42 ~= 1 month if (1 month > 2 minutes grace period) ~~~ still the opinion, increasing grace period would help? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142912573 Cloud you follow my explanations? If this would help, I must set the ping interval to a year or somewhat identical. Are you REALLY followed my explanations? What did I miss? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142940617 So I made a new PR #885 as a replacement for new discussion how this issue can be solved. IMHO this PR can be closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-142941464 /cc @DaanHoogland @koushik-das @anshul1886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/885 CLOUDSTACK-8848: ensure power state is up to date when handling missi⦠â¦ng VMs in powerReport There 2 things which has been changed. * We look on power_state_update_time instead of update_time. Didn't make sense to me to look at the update_time. * Due DB update optimisation, powerState will only be updated if < MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT; so we can not really rely on these information if we can not make sure these are up to date. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8848 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/885.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #885 commit d235255a55883745bac99d5640c965a5a4172a81 Author: Rene Moser Date: 2015-09-24T13:59:36Z CLOUDSTACK-8848: ensure power state is up to date when handling missing VMs in powerReport There 2 things which has been changed. * We look on power_state_update_time instead of update_time. Didn't make sense to me to look at the update_time. * Due DB update optimisation, powerState will only be updated if < MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT; so we can not really rely on these information if we can not make sure these are up to date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-142945491 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-142950081 It is actually not easy to test because you must hit a race condition. What I do is on vCenter make a few migrations of a VR to another hosts and look on the management server log for `Run missing VM report`. If you see this VR is missing, then you hit the race condition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143227931 I successfully tested the patch on 4.5.2: ~~~ 2015-09-25 15:38:11,953 WARN [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-7:ctx-65344d8a) Detected missing VM but power state is outdated, wait for another process report run for VM id: 342 2015-09-25 15:38:13,109 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-2:ctx-d782bbcb) VM state report. host: 25, vm id: 342, power state: PowerOn 2015-09-25 15:38:13,120 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-2:ctx-d782bbcb) VM state report is updated. host: 25, vm id: 342, power state: PowerOn 2015-09-25 15:38:13,145 WARN [o.a.c.alerts] (DirectAgentCronJob-2:ctx-d782bbcb) alertType:: 9 // dataCenterId:: 1 // podId:: 1 // clusterId:: null // message:: Router has been migrated out of band: r-342-VM 2015-09-25 15:39:11,869 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-14:ctx-1a38e77e) VM state report. host: 19, vm id: 342, power state: PowerOn 2015-09-25 15:39:11,879 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-14:ctx-1a38e77e) VM state report is updated. host: 19, vm id: 342, power state: PowerOn 2015-09-25 15:39:11,906 WARN [o.a.c.alerts] (DirectAgentCronJob-14:ctx-1a38e77e) alertType:: 9 // dataCenterId:: 1 // podId:: 1 // clusterId:: null // message:: Router has been migrated out of band: r-342-VM 2015-09-25 15:40:11,928 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-8:ctx-631f9ddc) Detected missing VM. host: 19, vm id: 342, power state: PowerReportMissing, last state update: 1443188351000 2015-09-25 15:40:11,928 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-8:ctx-631f9ddc) vm id: 342 - time since last state update(60925ms) has not passed graceful period yet 2015-09-25 15:40:13,095 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-3:ctx-1c07d7f5) VM state report. host: 25, vm id: 342, power state: PowerOn 2015-09-25 15:40:13,105 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-3:ctx-1c07d7f5) VM state report is updated. host: 25, vm id: 342, power state: PowerOn 2015-09-25 15:40:13,128 WARN [o.a.c.alerts] (DirectAgentCronJob-3:ctx-1c07d7f5) alertType:: 9 // dataCenterId:: 1 // podId:: 1 // clusterId:: null // message:: Router has been migrated out of band: r-342-VM 2015-09-25 15:40:48,537 DEBUG [c.c.a.t.Request] (DirectAgent-38:ctx-9baa3adc) Seq 25-594475150812905490: Processing: { Ans: , MgmtId: 345051122106, via: 25, Ver: v1, Flags: 10, [{"com.cloud.agent.api.NetworkUsageAnswer":{"routerName":"r-342-VM","bytesSent":1435260,"bytesReceived":1356600,"result":true,"details":"","wait":0}}] } 2015-09-25 15:41:13,104 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-18:ctx-9fbec9c7) VM state report. host: 25, vm id: 342, power state: PowerOn 2015-09-25 15:41:13,114 DEBUG [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-18:ctx-9fbec9c7) VM state report is updated. host: 25, vm id: 342, power state: PowerOn ~~~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/890#issuecomment-143290823 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143544132 @karuturi I understand what @anshul1886 trying to point out: the powerState should already be updated to the new state `powerReportMissing`. And because it changes state, MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT is not relevant. I'll check that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143549250 @karuturi @anshul1886 So, I 'll checked the handling again and what I see is, it will not work with this one line change only: ~~~ Date vmStateUpdateTime = instance.getPowerStateUpdateTime(); ~~~ because powerState will only be updated to `powerReportMissing` __after__ grace period handling. Which is too late. Otherwise we would completely change the logic and move the `updatePowerState` for state `powerReportMissing` outside the grace period handing. This would be a much bigger change, for which I can not say if anything else would break. I am still for my solution in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143591694 @remibergsma done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-144346880 well I need it in 4.5.3. I would suggest we take this fix for now for 4.6 as well and make a proper refactor for 4.7/5.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8848: ensure power state...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/922 [4.5] CLOUDSTACK-8848: ensure power state is up to date for missing PowerState handling 1:1 cherry-picks, see #909 You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/4.5-8848 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/922.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #922 commit 30c704915c882f8ac2ab551aa157d0b7a0bdb47f Author: Rene Moser Date: 2015-09-24T19:10:26Z CLOUDSTACK-8848: ensure power state is up to date when handling missing VMs in powerReport There 2 things which has been changed. * We look on power_state_update_time instead of update_time. Didn't make sense to me at all to look at update_time. * Due DB update optimisation, powerState will only be updated if < MAX_CONSECUTIVE_SAME_STATE_UPDATE_COUNT. That is why we can not rely on these information unless we make sure these are up to date. commit 968991e0965d2279ba5f5c9e6496dc1a39dbccac Author: Daan Hoogland Date: 2015-10-02T09:42:42Z CLOUDSTACK-8848: added null pointer guard to new public method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447 hmm, in a advanced network setup, these IP address would be the private IPs but if it has a static NAT, the VM would also have a public IP. For a user, it might not be obvious what kind of "IP Address" these are, public or private. And you removed "displayname"? By mistake? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454 Yes I see, but the label "IP address" does not indicate that it is the first NIC's IP address :). It might make sense to change the label to be more precise in that. This is what I wanted to mention. Regarding displayname, I don't know, but if it has a _display_ name then we should how it. Maybe we can reuse the name row and also add the displayname in a new line or at least as a html title attribute e.g. "http://www.w3schools.com/tags/att_global_title.asp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152302053 is 4.5 also affected by this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216354228 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: SystemVM cleanups
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1414#issuecomment-216683077 @rhtyd rebased and squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.4] CLOUDSTACK-9042: VR: DHCP: fix miss...
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219975396 We use, when ever possible, openjdk as we get support from the distribution. Support for openjdk be it 7 or 8, manually patching oraclejdk is time consuming. RHEL support both openjdk 7 (June 2018) and 8 (October 2020) (see https://access.redhat.com/articles/1299013), to me it would make sense to keep openjdk 8 support in cloudstack. It seems, travis does not support openjdk 8 yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-220141803 @rhtyd I am not aware of any no. Just wanted to point out that oracle "sucks" and openjdk should be the jdk that should be tested and supported in the first place as it became the default in all distributions. Same for mariadb btw. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-221216726 would like to see this fixed, @sureshanaparti can I help you out? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: listFirewallRules: cleanup and fix duplic...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/246 listFirewallRules: cleanup and fix duplicate params in API The parts deleted are already defined in the extended class. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/cleanup_firewall_rules_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #246 commit 273312d667802273b0d080f87a4cde93949aa282 Author: Rene Moser Date: 2015-05-12T22:20:28Z listFirewallRules: cleanup and fix duplicate params in API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: debian: allow tomcat7 as optional depende...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/247 debian: allow tomcat7 as optional dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/debian-tomcat7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/247.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #247 commit be01a033125461b7d24c45ca25b9a6dbdec62457 Author: Rene Moser Date: 2015-05-12T23:06:13Z debian: allow tomcat7 as optional dependency --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: listPortForwardingRules: fix typo in doc
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/248 listPortForwardingRules: fix typo in doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/listPortForwardingRules_typo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #248 commit 8878f59289fe17127b48b4b8d0643ad20fa9cba7 Author: Rene Moser Date: 2015-05-12T23:13:00Z listPortForwardingRules: fix typo in doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: listFirewallRules: cleanup and fix duplic...
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an⦠â¦d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/cleanup_egress_firewallrules_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 556ebd9ce8197ebd3b3ef38bda6986050d38cd46 Author: Rene Moser Date: 2015-05-13T08:07:20Z ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd and cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
GitHub user resmo reopened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an⦠â¦d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/cleanup_egress_firewallrules_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 7991dd015e9dae9df91b8b8bf7eab63b04b02370 Author: Rene Moser Date: 2015-05-13T08:12:30Z ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd and cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103429103 @bhaisaab It's been a while since I coded JAVA, have no clue, why it is failing. May I ask you for a hint? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
GitHub user resmo reopened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an⦠â¦d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/cleanup_egress_firewallrules_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit bcd0a2ce83e648593badde004133d06b7c86d7e7 Author: Rene Moser Date: 2015-05-19T14:10:58Z ListFirewallEgressRulesCmd: add interfaces and minor cleanup This commit does not implement new functionality: * Fixes duplicate parameter in API docs. * Fixes a bunch of typos. * Add interfaces to make it easier for the FirewallService interface. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: WIP: affinitygroup: implement project sup...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/264 WIP: affinitygroup: implement project support You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/project-affinitygroup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/264.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #264 commit 358a4d8b3b52b4b6e36cbf91cf7754328df6665a Author: Rene Moser Date: 2015-05-19T18:09:42Z affinitygroup: implement project support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103890479 @bhaisaab a good IDE helps indeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Typo fixes and various cleanups
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/275 Typo fixes and various cleanups I gave parts of the API descriptions some love. Capitalized the abbreviations and fixed many typos. You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/cleanups Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #275 commit 909f9bd6dad2b90a16e1af66623969c8a454464e Author: Rene Moser Date: 2015-05-20T18:58:15Z queryService: fix style, remove public statement on interfaces commit 9010d723b58710e2084181c68d791a69c9143e17 Author: Rene Moser Date: 2015-05-20T19:13:12Z instanceGroupResponse: fix description commit e6c242efea6ffc5beeeb4f2d36945b8945981c18 Author: Rene Moser Date: 2015-05-20T19:29:51Z fix typos balacner -> balancer commit dda50bf5225830e8735a15deb6170e4ec729f840 Author: Rene Moser Date: 2015-05-21T07:36:27Z api: account: fix and reformat descriptions commit cebc86b965719663d990ff301863dfafef0e307c Author: Rene Moser Date: 2015-05-21T07:37:27Z api: address: fix and reformat descriptions commit ce9dbd2914cca5f4aa8817a88611e540568ad159 Author: Rene Moser Date: 2015-05-21T07:38:12Z api: affinitygroup: fix and reformat descriptions commit 9729ecc7ee5a3336b4a1dfdf538882db89203f6e Author: Rene Moser Date: 2015-05-21T07:52:53Z api: firewall: fix and reformat descriptions commit ef0f017dade5af9aa79711511558a07d543a19c7 Author: Rene Moser Date: 2015-05-21T07:56:13Z api: iso: fix and reformat descriptions commit 01473fe171f871e21b2b559421f7475dd2cca7e7 Author: Rene Moser Date: 2015-05-21T08:14:33Z api: loadbalancer: fix and reformat descriptions commit 3b5d2b29f22392a91a4a4663a68075678af20ca5 Author: Rene Moser Date: 2015-05-21T08:43:14Z api: network: fix and reformat descriptions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: template, api: fix format desc, add OVA f...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/331 template, api: fix format desc, add OVA format You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #331 commit 8548757aedcaf6e15a4acb6e227d5f849041c6a6 Author: René Moser Date: 2015-05-29T18:44:12Z template, api: fix format desc, add OVA format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/466#issuecomment-112762271 @DaanHoogland thanks for picking it up, btw do you port plan to fix it in 4.5 and master as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/508 [WIP] CLOUDSTACK-6276: project support in affinitygroups You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/6276-project-affinitygroup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit 2e129b3ef7b55fc79584305d667b59ae839c2ff2 Author: Rene Moser Date: 2015-06-22T14:46:33Z CLOUDSTACK-6276: add project support to AffinityGroupJoinVO and API commit c6b91fef14739ab4373e1637d74847180d0d1e0f Author: Rene Moser Date: 2015-06-22T14:49:16Z CLOUDSTACK-6276: implement searchForAffinityGroups in QueryService commit 45a88be1d4f0c2b59e81c5e904679dab388ad88f Author: Rene Moser Date: 2015-06-22T14:53:24Z CLOUDSTACK-6276: use query service for listAffinityGroups commit 7b322969ab47d943931eda876d54418980adf817 Author: Rene Moser Date: 2015-06-22T14:55:41Z CLOUDSTACK-6276: add project support in AffinityGroupService in create and delete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: affinitygroup: imp...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/264#issuecomment-114142748 closing this in favour of re-based and updated PR #508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: affinitygroup: imp...
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/510 CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach⦠â¦ines when zone is specified You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/510.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #510 commit 477fdef6d6b07de8f0b8c4fd2a99315be054264b Author: Rene Moser Date: 2015-06-23T08:17:25Z CLOUDSTACK-8578: fix listVirtualMachines does not return deleted machines when zone is specified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114465874 @DaanHoogland We already do :). User permissions API is **not affected** of this change however. The API does already return VMs `listVirtualMacines` in `destroyed` state if you have *admin* permissions. But if you provide `zoneid` in `listVirtualMacines` with *admin* permissions, it does not return VMs in `destroyed` state. This makes no sense to me. The bug was already fixed in CLOUDSTACK-284 but then the bug was reimplemented by accident. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 @bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. `present` which returns all VMs in states `starting, running, stopped, stopping'. So the *old* behaviour could be used as well in a proper way. Any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/513 CLOUDSTACK-8578: implement old behaviour for listing only non-destroy⦠â¦ed VMs using state=present Also see https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 RFC @bhaisaab You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8578-extend Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/513.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #513 commit bf67382521e6df3e12b311fd11f21569564e3920 Author: Rene Moser Date: 2015-06-23T13:47:06Z CLOUDSTACK-8578: implement old behaviour for listing only non-destroyed VMs using state=present --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/513#discussion_r33126603 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -968,7 +968,11 @@ } if (state != null) { -sc.setParameters("stateEQ", state); +if (state.equalsIgnoreCase("present")) { --- End diff -- Good catch, IMHO `Expunged` is not necessary but `Expunging` like we use for user e.g. https://github.com/resmo/cloudstack/blob/fix/CLOUDSTACK-8578-extend/server/src/com/cloud/api/query/QueryManagerImpl.java#L984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121846292 hey @bhaisaab, still WIP. I ask for some help to finish it on the ML, because I will not have time to work on it the next months. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---