Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24812 --- Ship it! commit 059e4b2ae0a44205a8567a79bf9a154a54a83492 Author: Kelven Yang Date: Wed Aug 7 10:28:47 2013 -0700 CLOUDSTACK-3886: check in for review request https://reviews.apache.org/r/13008/ - Kelven Yang On Aug. 6, 2013, 9:10 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13008/ > --- > > (Updated Aug. 6, 2013, 9:10 p.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, > Sateesh Chodapuneedi, and William Chan. > > > Bugs: CLOUDSTACK-3886 > > > Repository: cloudstack-git > > > Description > --- > > The vminstancename flag has been incorrectly used to simply append the > displayname to the internal VM name that shows up on vCenter in vmware > deployments. It was intended to show the actual name supplied as hostname, on > the hypervisor. This helps admins and deployers to quickly identify VMs and > resolve issues related to those VMs. Its usage is very limited as it stands > now. This fix corrects it to ensure that the name of the VM on the hypervisor > matches the hostname if it is supplied, and if the vm.instancename.flag is > set to true. > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java > 96fb1d9 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 292f7e9 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 8d6bdb8 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > 6b721de > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > d395425 > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java > fe127e3 > server/src/com/cloud/configuration/Config.java ad8e3aa > server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 > server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 > setup/db/db/schema-410to420.sql b3206af > vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 > vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java > 11bc157 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > d20eb6f > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java > cb97b26 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > ac14328 > > Diff: https://reviews.apache.org/r/13008/diff/ > > > Testing > --- > > Post this change, all major VM operations, namely > creation/destruction/expunging/start/stop/reboot of the VM have been tested > and observed to work correctly. Part of this patch also puts in a fix for > VMSync operations where the CS mgmt server doesn't detect that a guest VM is > down, if the guest VM has been shut down/powered off in vCenter. Other > operations such as VM snapshot, volume snapshots of disks belonging to the > VM, volume migration across primaries, volume attach/detach have also been > tested and they are working as expected. This is a functional change, and > completely transparent to any of cloudstack's existing functionalities and > all the test cases that cover the above code paths and APIs - all existing > tests should and do pass - no new tests are necessary. > > > UPDATE for 08/05/2013 > = > 4.2 code has diverged - need to refactor the patch on top of latest 4.2. Will > test out refactored patch and resubmit. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ --- (Updated Aug. 6, 2013, 9:10 p.m.) Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. Changes --- Updating refactored patch that applies on top of latest 4.2 branch. All testing as described previously was redone with the new patch and all cases passed. Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description --- The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Diffs (updated) - engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java 96fb1d9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 292f7e9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 8d6bdb8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 6b721de plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d395425 plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java fe127e3 server/src/com/cloud/configuration/Config.java ad8e3aa server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 setup/db/db/schema-410to420.sql b3206af vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 11bc157 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java d20eb6f vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java cb97b26 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java ac14328 Diff: https://reviews.apache.org/r/13008/diff/ Testing --- Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. UPDATE for 08/05/2013 = 4.2 code has diverged - need to refactor the patch on top of latest 4.2. Will test out refactored patch and resubmit. Thanks, Venkata Siva Vijayendra Bhamidipati
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ --- (Updated Aug. 5, 2013, 9:30 p.m.) Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description --- The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Diffs - engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java 96fb1d9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 292f7e9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 8d6bdb8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 10b6de9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 1216e17 plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 112a0cb server/src/com/cloud/configuration/Config.java 0d72694 server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d35539 setup/db/db/schema-410to420.sql 3f25c3b vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 11bc157 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java dd0f889 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java e2dd789 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java ac14328 Diff: https://reviews.apache.org/r/13008/diff/ Testing (updated) --- Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. UPDATE for 08/05/2013 = 4.2 code has diverged - need to refactor the patch on top of latest 4.2. Will test out refactored patch and resubmit. Thanks, Venkata Siva Vijayendra Bhamidipati
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24602 --- Ship it! Ship It! - Kelven Yang On Aug. 2, 2013, 12:49 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13008/ > --- > > (Updated Aug. 2, 2013, 12:49 a.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, > Sateesh Chodapuneedi, and William Chan. > > > Bugs: CLOUDSTACK-3886 > > > Repository: cloudstack-git > > > Description > --- > > The vminstancename flag has been incorrectly used to simply append the > displayname to the internal VM name that shows up on vCenter in vmware > deployments. It was intended to show the actual name supplied as hostname, on > the hypervisor. This helps admins and deployers to quickly identify VMs and > resolve issues related to those VMs. Its usage is very limited as it stands > now. This fix corrects it to ensure that the name of the VM on the hypervisor > matches the hostname if it is supplied, and if the vm.instancename.flag is > set to true. > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java > 96fb1d9 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 292f7e9 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 8d6bdb8 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > 10b6de9 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 1216e17 > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java > 112a0cb > server/src/com/cloud/configuration/Config.java 0d72694 > server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 > server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d35539 > setup/db/db/schema-410to420.sql 3f25c3b > vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 > vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java > 11bc157 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > dd0f889 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java > e2dd789 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > ac14328 > > Diff: https://reviews.apache.org/r/13008/diff/ > > > Testing > --- > > Post this change, all major VM operations, namely > creation/destruction/expunging/start/stop/reboot of the VM have been tested > and observed to work correctly. Part of this patch also puts in a fix for > VMSync operations where the CS mgmt server doesn't detect that a guest VM is > down, if the guest VM has been shut down/powered off in vCenter. Other > operations such as VM snapshot, volume snapshots of disks belonging to the > VM, volume migration across primaries, volume attach/detach have also been > tested and they are working as expected. This is a functional change, and > completely transparent to any of cloudstack's existing functionalities and > all the test cases that cover the above code paths and APIs - all existing > tests should and do pass - no new tests are necessary. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ --- (Updated Aug. 2, 2013, 12:49 a.m.) Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. Changes --- Uploading patch rebased against latest 4.2. This patch also corrects the vm.instancename.flag description in Config.java and the 410-420 schema upgrade sql script. Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description --- The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Diffs (updated) - engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java 96fb1d9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 292f7e9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 8d6bdb8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 10b6de9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 1216e17 plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 112a0cb server/src/com/cloud/configuration/Config.java 0d72694 server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d35539 setup/db/db/schema-410to420.sql 3f25c3b vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 11bc157 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java dd0f889 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java e2dd789 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java ac14328 Diff: https://reviews.apache.org/r/13008/diff/ Testing --- Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. Thanks, Venkata Siva Vijayendra Bhamidipati
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ --- (Updated July 30, 2013, 3:46 a.m.) Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. Changes --- Updating the review request with a patch that now uses a custom field by name CLOUD_INTERNAL_VM_NAME instead of the annotation field. All testing as before has been carried out with these new changes and confirmed to work as expected. Please note that this patch is for 4.2 only and will not apply on master and hence a failure message will show up on this request. Requesting that the committer use git am to apply the patch to ensure that patch application goes through smoothly. Regards, Vijay Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description --- The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Diffs (updated) - engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java 96fb1d9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java d1392c4 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 8d6bdb8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 3dece6e plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java a33b94e plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 6451828 server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 server/src/com/cloud/hypervisor/HypervisorGuruBase.java 478baf3 server/src/com/cloud/vm/UserVmManagerImpl.java 280f7e9 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 45aa50c vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 11bc157 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java dd0f889 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java e2dd789 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java ac14328 Diff: https://reviews.apache.org/r/13008/diff/ Testing --- Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. Thanks, Venkata Siva Vijayendra Bhamidipati
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote: > > Review 13008 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #65 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ > > Venkata Siva Vijayendra Bhamidipati wrote: > This patch is for 4.2 and has been tested on 4.2 as described - the patch > will not apply on the master branch. The above failure message is for master > branch. Requesting reviewers to review patch for 4.2. > > Kelven Yang wrote: > It would be better to use existing custom field facility to tag > attributes to vCenter objects. Since content of object annotation in vCenter > is plain string leterals, we can't store information there in a structural > way, which will lead us to add additional logic to enable sharing annotation > field from mulitple sources. > > Another problem with using annotation is that since the field in vCenter > is designed to allow vCenter administrators to label object with custom > comments, it is editable in vCenter UI, if we use it for special control > purpose, it will open a door for people to mess up CloudStack meta > information stored in vCenter. > > I would suggest to change to custom field facility > > > Thanks for the review Kelven! I'll try out the custom field instead of the annotation field and update the request with the new diffs. Regards, Vijay - Venkata Siva Vijayendra --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24078 --- On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13008/ > --- > > (Updated July 29, 2013, 1:55 a.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, > Sateesh Chodapuneedi, and William Chan. > > > Bugs: CLOUDSTACK-3886 > > > Repository: cloudstack-git > > > Description > --- > > The vminstancename flag has been incorrectly used to simply append the > displayname to the internal VM name that shows up on vCenter in vmware > deployments. It was intended to show the actual name supplied as hostname, on > the hypervisor. This helps admins and deployers to quickly identify VMs and > resolve issues related to those VMs. Its usage is very limited as it stands > now. This fix corrects it to ensure that the name of the VM on the hypervisor > matches the hostname if it is supplied, and if the vm.instancename.flag is > set to true. > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java > 96fb1d9 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > d1392c4 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > e5c33cc > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 439163a > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java > 02e4e64 > server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 > server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba > vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > dd0f889 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java > e2dd789 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > ac14328 > > Diff: https://reviews.apache.org/r/13008/diff/ > > > Testing > --- > > Post this change, all major VM operations, namely > creation/destruction/expunging/start/stop/reboot of the VM have been tested > and observed to work correctly. Part of this patch also puts in a fix for > VMSync operations where the CS mgmt server doesn't detect that a guest VM is > down, if the guest VM has been shut down/powered off in vCenter. Other > operations such as VM snapshot, volume snapshots of disks belonging to the > VM, volume migration across primaries, volume attach/detach have also been > tested and they are working as expected. This is a functional change, and > completely transparent to any of cloudstack's existing functionalities and > all the test cases that cover the above code paths and APIs - all existing > tests should and do pass - no new tests are necessary. > > > Thanks, > > Venkata Siva Vijayendra Bhamidi
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote: > > Review 13008 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #65 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ > > Venkata Siva Vijayendra Bhamidipati wrote: > This patch is for 4.2 and has been tested on 4.2 as described - the patch > will not apply on the master branch. The above failure message is for master > branch. Requesting reviewers to review patch for 4.2. It would be better to use existing custom field facility to tag attributes to vCenter objects. Since content of object annotation in vCenter is plain string leterals, we can't store information there in a structural way, which will lead us to add additional logic to enable sharing annotation field from mulitple sources. Another problem with using annotation is that since the field in vCenter is designed to allow vCenter administrators to label object with custom comments, it is editable in vCenter UI, if we use it for special control purpose, it will open a door for people to mess up CloudStack meta information stored in vCenter. I would suggest to change to custom field facility - Kelven --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24078 --- On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13008/ > --- > > (Updated July 29, 2013, 1:55 a.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, > Sateesh Chodapuneedi, and William Chan. > > > Bugs: CLOUDSTACK-3886 > > > Repository: cloudstack-git > > > Description > --- > > The vminstancename flag has been incorrectly used to simply append the > displayname to the internal VM name that shows up on vCenter in vmware > deployments. It was intended to show the actual name supplied as hostname, on > the hypervisor. This helps admins and deployers to quickly identify VMs and > resolve issues related to those VMs. Its usage is very limited as it stands > now. This fix corrects it to ensure that the name of the VM on the hypervisor > matches the hostname if it is supplied, and if the vm.instancename.flag is > set to true. > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java > 96fb1d9 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > d1392c4 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > e5c33cc > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 439163a > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java > 02e4e64 > server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 > server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba > vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > dd0f889 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java > e2dd789 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > ac14328 > > Diff: https://reviews.apache.org/r/13008/diff/ > > > Testing > --- > > Post this change, all major VM operations, namely > creation/destruction/expunging/start/stop/reboot of the VM have been tested > and observed to work correctly. Part of this patch also puts in a fix for > VMSync operations where the CS mgmt server doesn't detect that a guest VM is > down, if the guest VM has been shut down/powered off in vCenter. Other > operations such as VM snapshot, volume snapshots of disks belonging to the > VM, volume migration across primaries, volume attach/detach have also been > tested and they are working as expected. This is a functional change, and > completely transparent to any of cloudstack's existing functionalities and > all the test cases that cover the above code paths and APIs - all existing > tests should and do pass - no new tests are necessary. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote: > > Review 13008 failed the build test : FAILURE > > The url of build cloudstack-master-with-patch #65 is : > > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ This patch is for 4.2 and has been tested on 4.2 as described - the patch will not apply on the master branch. The above failure message is for master branch. Requesting reviewers to review patch for 4.2. - Venkata Siva Vijayendra --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24078 --- On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13008/ > --- > > (Updated July 29, 2013, 1:55 a.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, > Sateesh Chodapuneedi, and William Chan. > > > Bugs: CLOUDSTACK-3886 > > > Repository: cloudstack-git > > > Description > --- > > The vminstancename flag has been incorrectly used to simply append the > displayname to the internal VM name that shows up on vCenter in vmware > deployments. It was intended to show the actual name supplied as hostname, on > the hypervisor. This helps admins and deployers to quickly identify VMs and > resolve issues related to those VMs. Its usage is very limited as it stands > now. This fix corrects it to ensure that the name of the VM on the hypervisor > matches the hostname if it is supplied, and if the vm.instancename.flag is > set to true. > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java > 96fb1d9 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > d1392c4 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > e5c33cc > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 439163a > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java > 02e4e64 > server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 > server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba > vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > dd0f889 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java > e2dd789 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > ac14328 > > Diff: https://reviews.apache.org/r/13008/diff/ > > > Testing > --- > > Post this change, all major VM operations, namely > creation/destruction/expunging/start/stop/reboot of the VM have been tested > and observed to work correctly. Part of this patch also puts in a fix for > VMSync operations where the CS mgmt server doesn't detect that a guest VM is > down, if the guest VM has been shut down/powered off in vCenter. Other > operations such as VM snapshot, volume snapshots of disks belonging to the > VM, volume migration across primaries, volume attach/detach have also been > tested and they are working as expected. This is a functional change, and > completely transparent to any of cloudstack's existing functionalities and > all the test cases that cover the above code paths and APIs - all existing > tests should and do pass - no new tests are necessary. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
RE: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
+dev (the older dev@incubator mail id showed up in the previous mail - probably needs to be fixed in jenkins) From: Vijayendra Bhamidipati [vijayendra.bhamidip...@citrix.com] Sent: Sunday, July 28, 2013 9:11 PM To: Jenkins Cloudstack.org; Kelven Yang; Sateesh Chodapuneedi; Will Chan; Chip Childers; Alex Huang Cc: cloudstack; Hugo com> Subject: Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor Hugo, My patch was intended for the 4.2 branch and not for master (it won't apply cleanly on master) – looks like jenkins is trying to patch this against the master branch and I'm seeing this failure – do I need to do something here? I can create a patch for master but I need this to go into 4.2 as well. Please advise. Also, I specified that the branch was 4.2 in the branch field of the review request – won't your scripts pick that up?? Regards, Vijay From: "Jenkins Cloudstack.org" mailto:h...@apache.org>> Reply-To: "Jenkins Cloudstack.org" mailto:h...@apache.org>> Date: Sunday, July 28, 2013 8:59 PM To: Kelven Yang mailto:kelven.y...@citrix.com>>, Sateesh Chodapuneedi mailto:sateesh.chodapune...@citrix.com>>, Will Chan mailto:will.c...@citrix.com>>, Chip Childers mailto:chipchild...@apache.org>>, Alex Huang mailto:alex.hu...@citrix.com>> Cc: Vijayendra Bhamidipati mailto:vijayendra.bhamidip...@citrix.com>>, "cloudstack-...@incubator.apache.org<mailto:cloudstack-...@incubator.apache.org>" mailto:cloudstack-...@incubator.apache.org>>, "Jenkins Cloudstack.org" mailto:h...@apache.org>> Subject: Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ Review 13008 failed the build test : FAILURE The url of build cloudstack-master-with-patch #65 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ - Jenkins Cloudstack.org On July 29th, 2013, 1:55 a.m. UTC, Venkata Siva Vijayendra Bhamidipati wrote: Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. By Venkata Siva Vijayendra Bhamidipati. Updated July 29, 2013, 1:55 a.m. Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Testing Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. Diffs * engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java (96fb1d9) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java (d1392c4) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java (e5c33cc) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java (439163a) * plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java (02e4e64) * server/src/com/cloud/ha/HighAvailabilityManagerImpl.java (25c5a04) * server/src/com/cloud/hypervisor/HypervisorGuruBase.java (ec68529) * server/src/com/cloud/vm/UserVmManagerImpl.java (3831f88) * server/src/com/cloud/vm/VirtualMachineManagerImpl.java (a3187ba) * vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java (04ef0f8) * vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java (2735fb0) * vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java (dd0f889) * vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java (e2dd789) * vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java (ac14328) View Diff<https://reviews.apache.org/r/13008/diff/>
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
Hugo, My patch was intended for the 4.2 branch and not for master (it won't apply cleanly on master) – looks like jenkins is trying to patch this against the master branch and I'm seeing this failure – do I need to do something here? I can create a patch for master but I need this to go into 4.2 as well. Please advise. Also, I specified that the branch was 4.2 in the branch field of the review request – won't your scripts pick that up?? Regards, Vijay From: "Jenkins Cloudstack.org" mailto:h...@apache.org>> Reply-To: "Jenkins Cloudstack.org" mailto:h...@apache.org>> Date: Sunday, July 28, 2013 8:59 PM To: Kelven Yang mailto:kelven.y...@citrix.com>>, Sateesh Chodapuneedi mailto:sateesh.chodapune...@citrix.com>>, Will Chan mailto:will.c...@citrix.com>>, Chip Childers mailto:chipchild...@apache.org>>, Alex Huang mailto:alex.hu...@citrix.com>> Cc: Vijayendra Bhamidipati mailto:vijayendra.bhamidip...@citrix.com>>, "cloudstack-...@incubator.apache.org<mailto:cloudstack-...@incubator.apache.org>" mailto:cloudstack-...@incubator.apache.org>>, "Jenkins Cloudstack.org" mailto:h...@apache.org>> Subject: Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ Review 13008 failed the build test : FAILURE The url of build cloudstack-master-with-patch #65 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ - Jenkins Cloudstack.org On July 29th, 2013, 1:55 a.m. UTC, Venkata Siva Vijayendra Bhamidipati wrote: Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. By Venkata Siva Vijayendra Bhamidipati. Updated July 29, 2013, 1:55 a.m. Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Testing Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. Diffs * engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java (96fb1d9) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java (d1392c4) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java (e5c33cc) * plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java (439163a) * plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java (02e4e64) * server/src/com/cloud/ha/HighAvailabilityManagerImpl.java (25c5a04) * server/src/com/cloud/hypervisor/HypervisorGuruBase.java (ec68529) * server/src/com/cloud/vm/UserVmManagerImpl.java (3831f88) * server/src/com/cloud/vm/VirtualMachineManagerImpl.java (a3187ba) * vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java (04ef0f8) * vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java (2735fb0) * vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java (dd0f889) * vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java (e2dd789) * vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java (ac14328) View Diff<https://reviews.apache.org/r/13008/diff/>
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24078 --- Review 13008 failed the build test : FAILURE The url of build cloudstack-master-with-patch #65 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ - Jenkins Cloudstack.org On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13008/ > --- > > (Updated July 29, 2013, 1:55 a.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, > Sateesh Chodapuneedi, and William Chan. > > > Bugs: CLOUDSTACK-3886 > > > Repository: cloudstack-git > > > Description > --- > > The vminstancename flag has been incorrectly used to simply append the > displayname to the internal VM name that shows up on vCenter in vmware > deployments. It was intended to show the actual name supplied as hostname, on > the hypervisor. This helps admins and deployers to quickly identify VMs and > resolve issues related to those VMs. Its usage is very limited as it stands > now. This fix corrects it to ensure that the name of the VM on the hypervisor > matches the hostname if it is supplied, and if the vm.instancename.flag is > set to true. > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java > 96fb1d9 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > d1392c4 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java > e5c33cc > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 439163a > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java > 02e4e64 > server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 > server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba > vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > dd0f889 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java > e2dd789 > vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java > ac14328 > > Diff: https://reviews.apache.org/r/13008/diff/ > > > Testing > --- > > Post this change, all major VM operations, namely > creation/destruction/expunging/start/stop/reboot of the VM have been tested > and observed to work correctly. Part of this patch also puts in a fix for > VMSync operations where the CS mgmt server doesn't detect that a guest VM is > down, if the guest VM has been shut down/powered off in vCenter. Other > operations such as VM snapshot, volume snapshots of disks belonging to the > VM, volume migration across primaries, volume attach/detach have also been > tested and they are working as expected. This is a functional change, and > completely transparent to any of cloudstack's existing functionalities and > all the test cases that cover the above code paths and APIs - all existing > tests should and do pass - no new tests are necessary. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
