Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 --- Ship it! Ship It! - Rajani Karuturi On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: Ship It! Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa will merge to master as well. - Rajani --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 --- On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: Ship It! Rajani Karuturi wrote: Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa will merge to master as well. master 02ca6f2e5b7d8ffdc917ed09d8600c38e668ea17 - Rajani --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 --- On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
On Nov. 25, 2014, 8:14 a.m., Rajani Karuturi wrote: Ship It! Rajani Karuturi wrote: Thanks for adding tests. pushed to 4.5 c919ff83d81528b89017b5f5731b2e46350e3dfa will merge to master as well. Rajani Karuturi wrote: master 02ca6f2e5b7d8ffdc917ed09d8600c38e668ea17 Thanks Rajani - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review62950 --- On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 24, 2014, 4:23 p.m.) Review request for cloudstack. Changes --- Updated diff to include 2 new unit tests Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs (updated) - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/28049/diff/ Testing (updated) --- Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java - Test to guarantee that validate is being called when updating LB rule - Test to guarantee that it throws exception if LB rule is not validated by provider Ran integration tests (smoke), all seems OK. Thanks, Daniel Vega Simoes
Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 14, 2014, 7:42 p.m.) Review request for cloudstack. Repository: cloudstack-git Description (updated) --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Thanks, Daniel Vega Simoes
Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review61631 --- Can you please update the testing section? probably a new test case if possible? It might break some of the existing unit or integration tests. Did you run them? information about running/writing new tests can be found here https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python - Rajani Karuturi On Nov. 14, 2014, 7:42 p.m., Daniel Vega Simoes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/ --- (Updated Nov. 14, 2014, 7:42 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 Validate Load Balancer rule with provider before commiting to DB and applying new rule. Diffs - server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 Diff: https://reviews.apache.org/r/28049/diff/ Testing --- Thanks, Daniel Vega Simoes
