[continuum] BUILD SUCCESSFUL: Commons - Commons BeanUtils -
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=164282projectId=156 Build statistics: State: Ok Previous State: Error Started at: Sat 14 Mar 2009 23:47:33 -0700 Finished at: Sat 14 Mar 2009 23:49:38 -0700 Total time: 2m 4s Build Trigger: Schedule Build Number: 49 Exit code: 0 Building machine hostname: vmbuild.apache.org Operating system : Linux(unknown) Java Home version : java version 1.6.0_05 Java(TM) SE Runtime Environment (build 1.6.0_05-b13) Java HotSpot(TM) Client VM (build 10.0-b19, mixed mode, sharing) Builder version : Maven version: 2.0.9 Java version: 1.6.0_05 OS name: linux version: 2.6.20-16-server arch: i386 Family: unix SCM Changes: No files changed Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean deploy Arguments: --batch-mode -DaltDeploymentRepository=vmbuild.repo::default::file://localhost/home/continuum/data/commons -Pci Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: JDK 6 Description: Test Summary: Tests: 1156 Failures: 0 Total time: 43.27601 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [compress] Todos before release 1
Its SANDBOX-302 now: https://issues.apache.org/jira/browse/SANDBOX-302 Medium isnt in the system, I tagged it minor now. Major is the new Medium :) It's the default, so everyone treats it as medium. Aaaah ok :-) I updated the prio now. Thanks Christian - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[g...@vmgump]: Project commons-configuration (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration has an issue affecting its community integration. This issue affects 16 projects, and has been outstanding for 32 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-configuration : Apache Commons - commons-configuration-test : Apache Commons - commons-jelly-tags-ojb : Commons Jelly - db-ojb-from-packages-1-0-release : ObjectRelationalBridge - db-torque : Persistence Layer - fulcrum-cache : Services Framework - fulcrum-configuration-impl : Services Framework - fulcrum-intake : Services Framework - fulcrum-parser : Services Framework - fulcrum-security-memory : Services Framework - fulcrum-security-nt : Services Framework - fulcrum-template : Services Framework - jakarta-turbine-jcs : Cache - portals-jetspeed-1 : Enterprise Information Portal - test-ojb-from-packages-1-0-release : ObjectRelationalBridge - turbine-core : A servlet based framework. Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-configuration-1.7-SNAPSHOT.jar] identifier set to project name -DEBUG- (Gump generated) Maven2 Settings in: /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/configuration/pom.xml -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration/gump_work/build_apache-commons_commons-configuration.html Work Name: build_apache-commons_commons-configuration (Type: Build) Work ended in a state of : Failed Elapsed: 31 secs Command Line: mvn --batch-mode -Dmaven.test.skip=true --settings /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml package [Working Directory: /srv/gump/public/workspace/apache-commons/configuration] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/junit/dist/junit-15032009.jar - required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[197,45] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[202,39] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[207,37] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[212,46] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[217,63] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[447,43] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[452,44] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java:[157,61] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable
[lang] Findbugs, performance, fun
Findbugs claims we should be writing Integer.valueOf not new Integer
as it's guaranteed to be faster. The same for the other primitive
wrappers. I can't let such a statement of surety go untested, so I had
a play and used the following as a test:
public class Perf {
public static void main(String[] args) throws Exception {
int count = Integer.parseInt(args[0]);
for(int i=0; i100; i++) {
System.out.println(Valueof faster: + test(count));
}
}
public static boolean test(int count) {
int step = count / 2;
long ln = System.nanoTime();
testIntCache(step);
testIntCache(step);
ln = (System.nanoTime() - ln)/1000;
System.out.println(Time for + count + valueOf Int: + ln);
long ln2 = System.nanoTime();
testIntCreate(step);
testIntCreate(step);
ln2 = (System.nanoTime() - ln2)/1000;
System.out.println(Time for + count + new Int: + ln2);
return ln ln2;
}
public static void testIntCache(int count) {
Integer in = null;
for(int i=0; icount; i++) {
in = Integer.valueOf(i);
}
}
public static void testIntCreate(int count) {
Integer in = null;
for(int i=0; icount; i++) {
in = new Integer(i);
}
}
}
I found on the Apple JVM 1.5.0_16 that valueOf is faster when:
count = 100 - Faster about 94% of the time.
count = 1000 - Faster about 89% of the time.
count = 1 - Faster about 32% of the time.
count = 10 - Faster about 3% of the time.
valueOf is always much slower for the first loop (building cache
presumably). Also often much slower on the third loop too. Weird.
new Int is always much slower on the fourth loop - more so for smaller
counts. Maybe JIT happening, interesting that it would JIT more for
new than valueOf if that's the case.
Ideally I should discard these first four loops, but it wouldn't
change the above too much.
Anyway... amusing play stuff when I should be sleeping; and not
believing FindBugs too much. Need to try for Double, Long etc; maybe
this lore holds more true there. Plus maybe it's Apple's JVM being
interesting and this holds true in Sun land.
Hen
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] 3.0, what's in; what's out
On 15/03/2009, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: Henri Yandell [mailto:flame...@gmail.com] Sent: Saturday, March 14, 2009 8:05 PM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out On Sat, Mar 14, 2009 at 7:53 PM, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: news [mailto:n...@ger.gmane.org] On Behalf Of Jörg Schaible Sent: Saturday, March 14, 2009 1:29 PM To: dev@commons.apache.org Subject: RE: [lang] 3.0, what's in; what's out Gary Gregory wrote: -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Saturday, March 14, 2009 4:52 AM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out And the various other backwards incompatible changes that people have been requesting. Removal of AllxxxTest classes that just group other tests. These just tend to get out of date, potentially complicate the POM, and IMO don't offer much added value. -1 I use package-level test suites all the time from Eclipse. Running all tests in a given package is a very reasonable thing to do IMO. Otherwise I am forced to the command line where I often cannot ask Ant or Maven to even run tests in a given package. I am stuck with whatever the build's test target does. Not only that but I'd have to sit through a build every time... Especially with Eclipse there's no need. Open the context menu of the package and select run as unit test (or the project to run all tests at once). For me those AllXxxxTest suites are simply annoying. I had missed that menu item in Eclipse! Thanks Jörg. Is that -1 rescinded for deleting the Suites, Gary? Rescinded, retracted and recanted. I've just discovered one minor issue - EntriesPerformanceTest. This is in the main lang directory, but not in the LangTestSuite - deliberately, I suspect, as it take over 100 seconds on my system. Perhaps it could be moved into a different package (would have to fix some access rights), or maybe into a different source tree (same package - one can run tests from the navigator as well in Eclipse)? Gary Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] Dumb code?
On 15/03/2009, Henri Yandell flame...@gmail.com wrote: StandardToStringStyle seems to have nothing in but super calls to ToStringStyle. I'm thinking why? Looks like it just needs to exist and have the serialID and maybe the constructor. The rest of it is just noise. Any +1s to deleting all that code, or am I missing something? Or delete it entirely - AFAICS it's the same as the nested class DefaultStringStyle, and it's confusing to have two different ways of using the classes. Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
I assumed it was where the next 2.x release would come from.
Or will there be no further releases supporting versions of Java prior to 1.5?
On 15/03/2009, Matt Benson gudnabr...@yahoo.com wrote:
Are we still using this branch? I created it for work on the reflect
subpackage but later merged back to trunk... :|
-Matt
--- On Sat, 3/14/09, s...@apache.org s...@apache.org wrote:
From: s...@apache.org s...@apache.org
Subject: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: comm...@commons.apache.org
Date: Saturday, March 14, 2009, 8:43 PM
Author: sebb
Date: Sun Mar 15 01:43:20 2009
New Revision: 754584
URL: http://svn.apache.org/viewvc?rev=754584view=rev
Log:
Replace deprecated method calls to appendIdentityToString
with identityToString
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
Sun Mar 15 01:43:20 2009
@@ -945,7 +945,7 @@
* @since 2.0
*/
public ToStringBuilder
appendAsObjectToString(Object object) {
-
ObjectUtils.appendIdentityToString(this.getStringBuffer(),
object);
+
ObjectUtils.identityToString(this.getStringBuffer(),
object);
return this;
}
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Sun Mar 15 01:43:20 2009
@@ -562,7 +562,7 @@
* @since 2.2
*/
protected void
appendCyclicObject(StringBuffer buffer, String fieldName,
Object value) {
-
ObjectUtils.appendIdentityToString(buffer,
value);
+
ObjectUtils.identityToString(buffer,
value);
}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] Findbugs, performance, fun
On 15/03/2009, Henri Yandell flame...@gmail.com wrote:
Findbugs claims we should be writing Integer.valueOf not new Integer
as it's guaranteed to be faster. The same for the other primitive
wrappers. I can't let such a statement of surety go untested, so I had
a play and used the following as a test:
public class Perf {
public static void main(String[] args) throws Exception {
int count = Integer.parseInt(args[0]);
for(int i=0; i100; i++) {
System.out.println(Valueof faster: + test(count));
}
}
public static boolean test(int count) {
int step = count / 2;
long ln = System.nanoTime();
testIntCache(step);
testIntCache(step);
ln = (System.nanoTime() - ln)/1000;
System.out.println(Time for + count + valueOf Int: + ln);
long ln2 = System.nanoTime();
testIntCreate(step);
testIntCreate(step);
ln2 = (System.nanoTime() - ln2)/1000;
System.out.println(Time for + count + new Int: + ln2);
return ln ln2;
}
public static void testIntCache(int count) {
Integer in = null;
for(int i=0; icount; i++) {
in = Integer.valueOf(i);
}
}
public static void testIntCreate(int count) {
Integer in = null;
for(int i=0; icount; i++) {
in = new Integer(i);
}
}
}
I found on the Apple JVM 1.5.0_16 that valueOf is faster when:
count = 100 - Faster about 94% of the time.
count = 1000 - Faster about 89% of the time.
count = 1 - Faster about 32% of the time.
count = 10 - Faster about 3% of the time.
valueOf is always much slower for the first loop (building cache
presumably). Also often much slower on the third loop too. Weird.
new Int is always much slower on the fourth loop - more so for smaller
counts. Maybe JIT happening, interesting that it would JIT more for
new than valueOf if that's the case.
Ideally I should discard these first four loops, but it wouldn't
change the above too much.
Anyway... amusing play stuff when I should be sleeping; and not
believing FindBugs too much. Need to try for Double, Long etc; maybe
this lore holds more true there. Plus maybe it's Apple's JVM being
interesting and this holds true in Sun land.
I think you treat equal times unfairly - they are neither slower nor faster.
Also, the variables are not used, so the compiler could well optimise
the loop away.
Hen
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] 3.0, what's in; what's out
On Sun, Mar 15, 2009 at 7:31 AM, sebb seb...@gmail.com wrote: I've just discovered one minor issue - EntriesPerformanceTest. This is in the main lang directory, but not in the LangTestSuite - deliberately, I suspect, as it take over 100 seconds on my system. Perhaps it could be moved into a different package (would have to fix some access rights), or maybe into a different source tree (same package - one can run tests from the navigator as well in Eclipse)? Perhaps we can upgrade to use TestNG (now that we're JDK5) and mark this thing as a different type of test that doesn't run by default? - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] Item looking for work - LANG-396
I put a comment on the issue saying I'd take care of those if nobody else has already taken the ball and started running with it. On Sat, Mar 14, 2009 at 11:03 PM, Henri Yandell flame...@gmail.com wrote: Just in case anyone is sitting and wanting to do something on Lang and not seeing the right thing to hit, LANG-396 has a good attachment from Richard Wheeldon suggesting areas to apply varargs that needs someone thinking about and sinking their teeth into. Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] Findbugs, performance, fun
On 15/03/2009, sebb seb...@gmail.com wrote:
On 15/03/2009, Henri Yandell flame...@gmail.com wrote:
Findbugs claims we should be writing Integer.valueOf not new Integer
as it's guaranteed to be faster. The same for the other primitive
wrappers. I can't let such a statement of surety go untested, so I had
a play and used the following as a test:
public class Perf {
public static void main(String[] args) throws Exception {
int count = Integer.parseInt(args[0]);
for(int i=0; i100; i++) {
System.out.println(Valueof faster: + test(count));
}
}
public static boolean test(int count) {
int step = count / 2;
long ln = System.nanoTime();
testIntCache(step);
testIntCache(step);
ln = (System.nanoTime() - ln)/1000;
System.out.println(Time for + count + valueOf Int: + ln);
long ln2 = System.nanoTime();
testIntCreate(step);
testIntCreate(step);
ln2 = (System.nanoTime() - ln2)/1000;
System.out.println(Time for + count + new Int: + ln2);
return ln ln2;
}
public static void testIntCache(int count) {
Integer in = null;
for(int i=0; icount; i++) {
in = Integer.valueOf(i);
}
}
public static void testIntCreate(int count) {
Integer in = null;
for(int i=0; icount; i++) {
in = new Integer(i);
}
}
}
I found on the Apple JVM 1.5.0_16 that valueOf is faster when:
count = 100 - Faster about 94% of the time.
count = 1000 - Faster about 89% of the time.
count = 1 - Faster about 32% of the time.
count = 10 - Faster about 3% of the time.
valueOf is always much slower for the first loop (building cache
presumably). Also often much slower on the third loop too. Weird.
new Int is always much slower on the fourth loop - more so for smaller
counts. Maybe JIT happening, interesting that it would JIT more for
new than valueOf if that's the case.
Ideally I should discard these first four loops, but it wouldn't
change the above too much.
Anyway... amusing play stuff when I should be sleeping; and not
believing FindBugs too much. Need to try for Double, Long etc; maybe
this lore holds more true there. Plus maybe it's Apple's JVM being
interesting and this holds true in Sun land.
I think you treat equal times unfairly - they are neither slower nor faster.
Also, the variables are not used, so the compiler could well optimise
the loop away.
Found an article about it:
http://tech.puredanger.com/2007/02/01/valueof/
which has an alternative benchmark. It uses a static variable as the output.
Note that the java options will make a difference - at least on
Windows, there are -client and -server options which affect memory use
and optimisation strategy.
Hen
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[g...@vmgump]: Project commons-configuration (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration has an issue affecting its community integration. This issue affects 16 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-configuration : Apache Commons - commons-configuration-test : Apache Commons - commons-jelly-tags-ojb : Commons Jelly - db-ojb-from-packages-1-0-release : ObjectRelationalBridge - db-torque : Persistence Layer - fulcrum-cache : Services Framework - fulcrum-configuration-impl : Services Framework - fulcrum-intake : Services Framework - fulcrum-parser : Services Framework - fulcrum-security-memory : Services Framework - fulcrum-security-nt : Services Framework - fulcrum-template : Services Framework - jakarta-turbine-jcs : Cache - portals-jetspeed-1 : Enterprise Information Portal - test-ojb-from-packages-1-0-release : ObjectRelationalBridge - turbine-core : A servlet based framework. Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-configuration-1.7-SNAPSHOT.jar] identifier set to project name -DEBUG- (Gump generated) Maven2 Settings in: /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/configuration/pom.xml -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration/gump_work/build_apache-commons_commons-configuration.html Work Name: build_apache-commons_commons-configuration (Type: Build) Work ended in a state of : Failed Elapsed: 33 secs Command Line: mvn --batch-mode -Dmaven.test.skip=true --settings /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml package [Working Directory: /srv/gump/public/workspace/apache-commons/configuration] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/junit/dist/junit-15032009.jar - required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[197,45] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[202,39] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[207,37] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[212,46] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[217,63] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[447,43] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[452,44] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/plist/PropertyListConfiguration.java:[157,61] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable
[LANG] 3.0 StrTokenizer API change for next()
StrTokenizer implements ListIterator currently. Given that it only deals in Strings, it could implement ListIteratorString, however that would mean changing public Object next() to public String next() Any objections to implementing the above? - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] 3.0 StrTokenizer API change for next()
--- On Sun, 3/15/09, sebb seb...@gmail.com wrote: From: sebb seb...@gmail.com Subject: [LANG] 3.0 StrTokenizer API change for next() To: Commons Developers List dev@commons.apache.org Date: Sunday, March 15, 2009, 11:31 AM StrTokenizer implements ListIterator currently. Given that it only deals in Strings, it could implement ListIteratorString, however that would mean changing public Object next() to public String next() Any objections to implementing the above? 1. A String _is_ an Object; I am convinced that narrowed return types are the right thing to do in Java5-compatible code. What reason could there be against it? 2. We have no obligation to be BC anyway. -Matt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [g...@vmgump]: Project commons-configuration (in module apache-commons) failed
Not sure what is going on here. Could it be that [configuration] is the first victim of the changes of the exception classes in the new [lang] trunk? Our exception classes used to be derived from the [lang] nestable exception classes. Oliver Gump schrieb: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration has an issue affecting its community integration. This issue affects 16 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-configuration : Apache Commons - commons-configuration-test : Apache Commons - commons-jelly-tags-ojb : Commons Jelly - db-ojb-from-packages-1-0-release : ObjectRelationalBridge - db-torque : Persistence Layer - fulcrum-cache : Services Framework - fulcrum-configuration-impl : Services Framework - fulcrum-intake : Services Framework - fulcrum-parser : Services Framework - fulcrum-security-memory : Services Framework - fulcrum-security-nt : Services Framework - fulcrum-template : Services Framework - jakarta-turbine-jcs : Cache - portals-jetspeed-1 : Enterprise Information Portal - test-ojb-from-packages-1-0-release : ObjectRelationalBridge - turbine-core : A servlet based framework. Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-configuration-1.7-SNAPSHOT.jar] identifier set to project name -DEBUG- (Gump generated) Maven2 Settings in: /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/configuration/pom.xml -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-configuration/gump_work/build_apache-commons_commons-configuration.html Work Name: build_apache-commons_commons-configuration (Type: Build) Work ended in a state of : Failed Elapsed: 33 secs Command Line: mvn --batch-mode -Dmaven.test.skip=true --settings /srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml package [Working Directory: /srv/gump/public/workspace/apache-commons/configuration] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/junit/dist/junit-15032009.jar - required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[197,45] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[202,39] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[207,37] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[212,46] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[217,63] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[447,43] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable /srv/gump/public/workspace/apache-commons/configuration/src/java/org/apache/commons/configuration/AbstractHierarchicalFileConfiguration.java:[452,44] incompatible types found : org.apache.commons.configuration.ConfigurationException required: java.lang.Throwable
RE: [lang] 3.0, what's in; what's out
-Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Sunday, March 15, 2009 4:32 AM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out On 15/03/2009, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: Henri Yandell [mailto:flame...@gmail.com] Sent: Saturday, March 14, 2009 8:05 PM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out On Sat, Mar 14, 2009 at 7:53 PM, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: news [mailto:n...@ger.gmane.org] On Behalf Of Jörg Schaible Sent: Saturday, March 14, 2009 1:29 PM To: dev@commons.apache.org Subject: RE: [lang] 3.0, what's in; what's out Gary Gregory wrote: -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Saturday, March 14, 2009 4:52 AM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out And the various other backwards incompatible changes that people have been requesting. Removal of AllxxxTest classes that just group other tests. These just tend to get out of date, potentially complicate the POM, and IMO don't offer much added value. -1 I use package-level test suites all the time from Eclipse. Running all tests in a given package is a very reasonable thing to do IMO. Otherwise I am forced to the command line where I often cannot ask Ant or Maven to even run tests in a given package. I am stuck with whatever the build's test target does. Not only that but I'd have to sit through a build every time... Especially with Eclipse there's no need. Open the context menu of the package and select run as unit test (or the project to run all tests at once). For me those AllXxxxTest suites are simply annoying. I had missed that menu item in Eclipse! Thanks Jörg. Is that -1 rescinded for deleting the Suites, Gary? Rescinded, retracted and recanted. I've just discovered one minor issue - EntriesPerformanceTest. This is in the main lang directory, but not in the LangTestSuite - deliberately, I suspect, as it take over 100 seconds on my system. Perhaps it could be moved into a different package (would have to fix some access rights), or maybe into a different source tree (same package - one can run tests from the navigator as well in Eclipse)? new CanOfWorms(.*EntriesPerformanceTest).open() Well, the performance tests surely are interesting. It would be great to run such tests from build to build and check for performance degradation. The issue becomes where is the performance data stored? As a data file in CVS? OK. Does the build then commits it on every build? Nah... The commit process should probably be manual. So we'd need a task/goal for that... Gary Gary Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] 3.0, what's in; what's out
On 15/03/2009, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Sunday, March 15, 2009 4:32 AM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out On 15/03/2009, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: Henri Yandell [mailto:flame...@gmail.com] Sent: Saturday, March 14, 2009 8:05 PM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out On Sat, Mar 14, 2009 at 7:53 PM, Gary Gregory ggreg...@seagullsoftware.com wrote: -Original Message- From: news [mailto:n...@ger.gmane.org] On Behalf Of Jörg Schaible Sent: Saturday, March 14, 2009 1:29 PM To: dev@commons.apache.org Subject: RE: [lang] 3.0, what's in; what's out Gary Gregory wrote: -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: Saturday, March 14, 2009 4:52 AM To: Commons Developers List Subject: Re: [lang] 3.0, what's in; what's out And the various other backwards incompatible changes that people have been requesting. Removal of AllxxxTest classes that just group other tests. These just tend to get out of date, potentially complicate the POM, and IMO don't offer much added value. -1 I use package-level test suites all the time from Eclipse. Running all tests in a given package is a very reasonable thing to do IMO. Otherwise I am forced to the command line where I often cannot ask Ant or Maven to even run tests in a given package. I am stuck with whatever the build's test target does. Not only that but I'd have to sit through a build every time... Especially with Eclipse there's no need. Open the context menu of the package and select run as unit test (or the project to run all tests at once). For me those AllXxxxTest suites are simply annoying. I had missed that menu item in Eclipse! Thanks Jörg. Is that -1 rescinded for deleting the Suites, Gary? Rescinded, retracted and recanted. I've just discovered one minor issue - EntriesPerformanceTest. This is in the main lang directory, but not in the LangTestSuite - deliberately, I suspect, as it take over 100 seconds on my system. Perhaps it could be moved into a different package (would have to fix some access rights), or maybe into a different source tree (same package - one can run tests from the navigator as well in Eclipse)? new CanOfWorms(.*EntriesPerformanceTest).open() Well, the performance tests surely are interesting. It would be great to run such tests from build to build and check for performance degradation. The issue becomes where is the performance data stored? As a data file in CVS? OK. Does the build then commits it on every build? Nah... The commit process should probably be manual. So we'd need a task/goal for that... Or just store an upper bound for the elapsed time in the POM? Gary Gary Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
We can branch 2.4 if needed.
The biggest choice is whether we attempt to fix bugs in both, while
reserving changes and new features for the 3.0 branch.
Ideally wed have the 2.4 one going, but that would be quite a cultural
development change from the usual 1 trunk way we do things. I'm
expecting us not to do anything unless we have a serious enough bug
that requires change.
For example LANG-331... no real solution and I'm expecting that this
needs to be resolved as a known-issue.
Hen
On Sun, Mar 15, 2009 at 4:52 AM, sebb seb...@gmail.com wrote:
I assumed it was where the next 2.x release would come from.
Or will there be no further releases supporting versions of Java prior to 1.5?
On 15/03/2009, Matt Benson gudnabr...@yahoo.com wrote:
Are we still using this branch? I created it for work on the reflect
subpackage but later merged back to trunk... :|
-Matt
--- On Sat, 3/14/09, s...@apache.org s...@apache.org wrote:
From: s...@apache.org s...@apache.org
Subject: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: comm...@commons.apache.org
Date: Saturday, March 14, 2009, 8:43 PM
Author: sebb
Date: Sun Mar 15 01:43:20 2009
New Revision: 754584
URL: http://svn.apache.org/viewvc?rev=754584view=rev
Log:
Replace deprecated method calls to appendIdentityToString
with identityToString
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
Sun Mar 15 01:43:20 2009
@@ -945,7 +945,7 @@
* @since 2.0
*/
public ToStringBuilder
appendAsObjectToString(Object object) {
-
ObjectUtils.appendIdentityToString(this.getStringBuffer(),
object);
+
ObjectUtils.identityToString(this.getStringBuffer(),
object);
return this;
}
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Sun Mar 15 01:43:20 2009
@@ -562,7 +562,7 @@
* @since 2.2
*/
protected void
appendCyclicObject(StringBuffer buffer, String fieldName,
Object value) {
-
ObjectUtils.appendIdentityToString(buffer,
value);
+
ObjectUtils.identityToString(buffer,
value);
}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] Findbugs, performance, fun
On 15/03/2009, Henri Yandell flame...@gmail.com wrote: On Sun, Mar 15, 2009 at 5:08 AM, sebb seb...@gmail.com wrote: On 15/03/2009, Henri Yandell flame...@gmail.com wrote: Anyway... amusing play stuff when I should be sleeping; and not believing FindBugs too much. Need to try for Double, Long etc; maybe this lore holds more true there. Plus maybe it's Apple's JVM being interesting and this holds true in Sun land. I think you treat equal times unfairly - they are neither slower nor faster. Also, the variables are not used, so the compiler could well optimise the loop away. Agreed, but I didn't see an equals at any point in the output so it's again lost in the noise. I think I'd have seen radical differences if the compiler was optimizing the loop away as one or both of the numbers would have been 0 (or at least constant). I get very different results using your code and the one in the link (I editted that to provide the loop count on the command line). The other test consistently showed that valueOf was faster. Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release of DbUtils 1.2 RC2
sebb wrote: OK, I'd not noticed that the class was usable without the DataSource. Of course the alternative is to document the class as thread-unsafe... I would guess that the reason we've never seen a bug filed on this issue is that nobody uses setDataSource after the class is created. For these users, QueryRunner is thread-safe. I think just formalizing that state is best. I would not attempt to synchronize this class, just leave it unsafe and let users synchronize. We should document more explicitly that (unlike some other classes in DbUtils) it's unsafe. I'm not sure that the class can be made thread-safe externally. It's easy enough to override the setters with synchronized versions, but the getters need to be synchronized as well to ensure that the data is published correctly. However the class stores the unsynchronized getters in the Map. So it would be necessary to override invoke() as well. If this is done, then the whole class has been overridden - one might as well say it has been rewritten. I didn't mean that users would synchronize externally by extending/overriding, but just by synchronizing access to an instance member, or just not sharing them across threads. *shrug* -Dan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [lang] Findbugs, performance, fun
On Sun, Mar 15, 2009 at 11:20 AM, sebb seb...@gmail.com wrote: On 15/03/2009, Henri Yandell flame...@gmail.com wrote: On Sun, Mar 15, 2009 at 5:08 AM, sebb seb...@gmail.com wrote: On 15/03/2009, Henri Yandell flame...@gmail.com wrote: Anyway... amusing play stuff when I should be sleeping; and not believing FindBugs too much. Need to try for Double, Long etc; maybe this lore holds more true there. Plus maybe it's Apple's JVM being interesting and this holds true in Sun land. I think you treat equal times unfairly - they are neither slower nor faster. Also, the variables are not used, so the compiler could well optimise the loop away. Agreed, but I didn't see an equals at any point in the output so it's again lost in the noise. I think I'd have seen radical differences if the compiler was optimizing the loop away as one or both of the numbers would have been 0 (or at least constant). I get very different results using your code and the one in the link (I editted that to provide the loop count on the command line). The other test consistently showed that valueOf was faster. It's a good article - though they're testing different things. That code is testing that 0 can be created many times etc which should be faster for valueOf's cache. Mine was testing every number. Reading that caching only happens for a small set of numbers, it makes sense that valueOf is going to be worse, and that smaller sets are faster. So I think findbugs is being quite wrong in this case unless Integers are in the cache of 255 cached values. It'd be a surprise if Long/Float/Double were faster as you'd not expect them to have large caches, but you would expect Char (due to predominant ascii use), Short, Boolean and Byte to be worth using valueOf on. Something to test :) Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
Matt - if we did keep a 2.x branch, would the POST-2.4 branch be of
value, or should we be branching from the 2.4 tag?
Hen
On Sun, Mar 15, 2009 at 11:20 AM, Henri Yandell flame...@gmail.com wrote:
We can branch 2.4 if needed.
The biggest choice is whether we attempt to fix bugs in both, while
reserving changes and new features for the 3.0 branch.
Ideally wed have the 2.4 one going, but that would be quite a cultural
development change from the usual 1 trunk way we do things. I'm
expecting us not to do anything unless we have a serious enough bug
that requires change.
For example LANG-331... no real solution and I'm expecting that this
needs to be resolved as a known-issue.
Hen
On Sun, Mar 15, 2009 at 4:52 AM, sebb seb...@gmail.com wrote:
I assumed it was where the next 2.x release would come from.
Or will there be no further releases supporting versions of Java prior to
1.5?
On 15/03/2009, Matt Benson gudnabr...@yahoo.com wrote:
Are we still using this branch? I created it for work on the reflect
subpackage but later merged back to trunk... :|
-Matt
--- On Sat, 3/14/09, s...@apache.org s...@apache.org wrote:
From: s...@apache.org s...@apache.org
Subject: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: comm...@commons.apache.org
Date: Saturday, March 14, 2009, 8:43 PM
Author: sebb
Date: Sun Mar 15 01:43:20 2009
New Revision: 754584
URL: http://svn.apache.org/viewvc?rev=754584view=rev
Log:
Replace deprecated method calls to appendIdentityToString
with identityToString
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
Sun Mar 15 01:43:20 2009
@@ -945,7 +945,7 @@
* @since 2.0
*/
public ToStringBuilder
appendAsObjectToString(Object object) {
-
ObjectUtils.appendIdentityToString(this.getStringBuffer(),
object);
+
ObjectUtils.identityToString(this.getStringBuffer(),
object);
return this;
}
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Sun Mar 15 01:43:20 2009
@@ -562,7 +562,7 @@
* @since 2.2
*/
protected void
appendCyclicObject(StringBuffer buffer, String fieldName,
Object value) {
-
ObjectUtils.appendIdentityToString(buffer,
value);
+
ObjectUtils.identityToString(buffer,
value);
}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
I suppose it depends whether we want the reflect stuff ported from [beanutils].
Personally I'd say yes, but since the same code exists, more-or-less, in
another component it's not _critical_.
-Matt
--- On Sun, 3/15/09, Henri Yandell flame...@gmail.com wrote:
From: Henri Yandell flame...@gmail.com
Subject: Re: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: Commons Developers List dev@commons.apache.org
Date: Sunday, March 15, 2009, 1:29 PM
Matt - if we did keep a 2.x branch,
would the POST-2.4 branch be of
value, or should we be branching from the 2.4 tag?
Hen
On Sun, Mar 15, 2009 at 11:20 AM, Henri Yandell flame...@gmail.com
wrote:
We can branch 2.4 if needed.
The biggest choice is whether we attempt to fix bugs
in both, while
reserving changes and new features for the 3.0
branch.
Ideally wed have the 2.4 one going, but that would be
quite a cultural
development change from the usual 1 trunk way we do
things. I'm
expecting us not to do anything unless we have a
serious enough bug
that requires change.
For example LANG-331... no real solution and I'm
expecting that this
needs to be resolved as a known-issue.
Hen
On Sun, Mar 15, 2009 at 4:52 AM, sebb seb...@gmail.com
wrote:
I assumed it was where the next 2.x release would
come from.
Or will there be no further releases supporting
versions of Java prior to 1.5?
On 15/03/2009, Matt Benson gudnabr...@yahoo.com
wrote:
Are we still using this branch? I created
it for work on the reflect subpackage but later merged back
to trunk... :|
-Matt
--- On Sat, 3/14/09, s...@apache.org
s...@apache.org
wrote:
From: s...@apache.org
s...@apache.org
Subject: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: comm...@commons.apache.org
Date: Saturday, March 14, 2009, 8:43
PM
Author: sebb
Date: Sun Mar 15 01:43:20 2009
New Revision: 754584
URL: http://svn.apache.org/viewvc?rev=754584view=rev
Log:
Replace deprecated method calls to
appendIdentityToString
with identityToString
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
Sun Mar 15 01:43:20 2009
@@ -945,7 +945,7 @@
* @since 2.0
*/
public ToStringBuilder
appendAsObjectToString(Object object)
{
-
ObjectUtils.appendIdentityToString(this.getStringBuffer(),
object);
+
ObjectUtils.identityToString(this.getStringBuffer(),
object);
return this;
}
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Sun Mar 15 01:43:20 2009
@@ -562,7 +562,7 @@
* @since 2.2
*/
protected void
appendCyclicObject(StringBuffer buffer,
String fieldName,
Object value) {
-
ObjectUtils.appendIdentityToString(buffer,
value);
+
ObjectUtils.identityToString(buffer,
value);
}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release of DbUtils 1.2 RC2
On 15/03/2009, Dan Fabulich d...@fabulich.com wrote: sebb wrote: OK, I'd not noticed that the class was usable without the DataSource. Of course the alternative is to document the class as thread-unsafe... I would guess that the reason we've never seen a bug filed on this issue is that nobody uses setDataSource after the class is created. For these users, QueryRunner is thread-safe. I think just formalizing that state is best. If you mean nobody uses setDataSource at all, then I agree that cannot affect thread-safety. However, if anyone uses setDataSource (which has to be after creation) and passes the instance to another thread, then the receiving thread may not see the updated value for the ds variable, i.e. it would not be thread-safe. I would not attempt to synchronize this class, just leave it unsafe and let users synchronize. We should document more explicitly that (unlike some other classes in DbUtils) it's unsafe. I'm not sure that the class can be made thread-safe externally. It's easy enough to override the setters with synchronized versions, but the getters need to be synchronized as well to ensure that the data is published correctly. However the class stores the unsynchronized getters in the Map. So it would be necessary to override invoke() as well. If this is done, then the whole class has been overridden - one might as well say it has been rewritten. I didn't mean that users would synchronize externally by extending/overriding, but just by synchronizing access to an instance member, or just not sharing them across threads. *shrug* For a mutable instance field to be thread-safe, both writes and reads need to be synchronized (or volatile). It's not enough to synch. just the writes, and readers and writers must all use the same lock. -Dan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[VOTE] Release of DbUtils 1.2 RC3
My third attempt at releasing a commons project; please test rigorously! RC3 includes an API change to QueryRunner to guarantee thread-safety. (DBUTILS-52) NOTE: No one has yet explicitly said on-list that they have tested DbUtils 1.2 with a real database. We should not release it until somebody tries it out with a real live Oracle database, as described below. Compatibility warnings: * API change in QueryRunner: the setDataSource method was removed in order to fix a thread-safety bug (DBUTILS-52) * We upgraded the JVM dependency from JDK 1.3 to JDK 1.4 (DBUTILS-31) * Users who may have extended BeanListHandler.handleRow will find that this method no longer exists (is no longer called) in DbUtils 1.2 (DBUTILS-37) * Users who may have extended KeyedHandler will find that its protected members are now final (to guarantee thread safety). (DBUTILS-51) PLEASE TEST THIS RELEASE WITH A REAL DATABASE! Although this project has reasonable unit tests, it has no integration tests with any actual databases; it is quite possible that the fix for DBUTILS-31 has broken something on Oracle, MS SQL Server, Derby, or your favorite database. To verify DBUTILS-31, use QueryRunner to put a null value in a field, e.g. with QueryRunner.update. Ideally it would be good to verify putting nulls in fields of various types: char, varchar, int, boolean, date, etc. -- Tag: https://svn.apache.org/repos/asf/commons/proper/dbutils/tags/DBUTILS_1_2 Site: http://people.apache.org/builds/commons/dbutils/1.2/RC3/site/index.html Binaries: http://people.apache.org/builds/commons/dbutils/1.2/RC3/staged/commons-dbutils/commons-dbutils/1.2/ [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release of DbUtils 1.2 RC3
On 15/03/2009, Dan Fabulich d...@fabulich.com wrote: My third attempt at releasing a commons project; please test rigorously! RC3 includes an API change to QueryRunner to guarantee thread-safety. (DBUTILS-52) NOTE: No one has yet explicitly said on-list that they have tested DbUtils 1.2 with a real database. We should not release it until somebody tries it out with a real live Oracle database, as described below. Compatibility warnings: * API change in QueryRunner: the setDataSource method was removed in order to fix a thread-safety bug (DBUTILS-52) * We upgraded the JVM dependency from JDK 1.3 to JDK 1.4 (DBUTILS-31) * Users who may have extended BeanListHandler.handleRow will find that this method no longer exists (is no longer called) in DbUtils 1.2 (DBUTILS-37) * Users who may have extended KeyedHandler will find that its protected members are now final (to guarantee thread safety). (DBUTILS-51) PLEASE TEST THIS RELEASE WITH A REAL DATABASE! Although this project has reasonable unit tests, it has no integration tests with any actual databases; it is quite possible that the fix for DBUTILS-31 has broken something on Oracle, MS SQL Server, Derby, or your favorite database. To verify DBUTILS-31, use QueryRunner to put a null value in a field, e.g. with QueryRunner.update. Ideally it would be good to verify putting nulls in fields of various types: char, varchar, int, boolean, date, etc. Is there a simple ready-made example I could run? -- Tag: https://svn.apache.org/repos/asf/commons/proper/dbutils/tags/DBUTILS_1_2 Site: http://people.apache.org/builds/commons/dbutils/1.2/RC3/site/index.html Binaries: http://people.apache.org/builds/commons/dbutils/1.2/RC3/staged/commons-dbutils/commons-dbutils/1.2/ [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release of DbUtils 1.2 RC3
sebb wrote: On 15/03/2009, Dan Fabulich d...@fabulich.com wrote: PLEASE TEST THIS RELEASE WITH A REAL DATABASE! Although this project has reasonable unit tests, it has no integration tests with any actual databases; it is quite possible that the fix for DBUTILS-31 has broken something on Oracle, MS SQL Server, Derby, or your favorite database. To verify DBUTILS-31, use QueryRunner to put a null value in a field, e.g. with QueryRunner.update. Ideally it would be good to verify putting nulls in fields of various types: char, varchar, int, boolean, date, etc. Is there a simple ready-made example I could run? Not really, partly because I'm not sure I could write one effectively without access to an Oracle instance (in which case I'd just run the test myself). I think you'd need to start by creating the table: http://www.ss64.com/orasyntax/datatypes.html CREATE TABLE dbutilstest ( varchar2_column varchar2(50), nvarchar2_column nvarchar2(50), varchar_column varchar(50), char_column char(50), nchar_column char(50), number_column number(9), long_column long, date_column date, timestamp_column timestamp, year_interval_column interval year to month, day_interval_column interval day to second, raw_column raw(50), long_raw_column long_raw(50), rowid_column rowid, urowid_column urowid, clob_column clob, nclob_column nclob, blob_column blob, bfile_column bfile, xmltype_column xmltype ); (am I missing any important column types?) Then you could do something like: QueryRunner.update(insert into dbutilstest values(?, ?, ?, ?, ?, ?,+ + ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, new Object[20]); I can try to answer further questions if this isn't enough... -Dan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r754584 - in /commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder: ToStringBuilder.java ToStringStyle.java
I'm thinking no then. Personally I wouldn't want to be developing a
parallel 2.x with new features, just putting in major bugfixes on a
2.x if we feel the need.
On Sun, Mar 15, 2009 at 11:40 AM, Matt Benson gudnabr...@yahoo.com wrote:
I suppose it depends whether we want the reflect stuff ported from
[beanutils]. Personally I'd say yes, but since the same code exists,
more-or-less, in another component it's not _critical_.
-Matt
--- On Sun, 3/15/09, Henri Yandell flame...@gmail.com wrote:
From: Henri Yandell flame...@gmail.com
Subject: Re: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: Commons Developers List dev@commons.apache.org
Date: Sunday, March 15, 2009, 1:29 PM
Matt - if we did keep a 2.x branch,
would the POST-2.4 branch be of
value, or should we be branching from the 2.4 tag?
Hen
On Sun, Mar 15, 2009 at 11:20 AM, Henri Yandell flame...@gmail.com
wrote:
We can branch 2.4 if needed.
The biggest choice is whether we attempt to fix bugs
in both, while
reserving changes and new features for the 3.0
branch.
Ideally wed have the 2.4 one going, but that would be
quite a cultural
development change from the usual 1 trunk way we do
things. I'm
expecting us not to do anything unless we have a
serious enough bug
that requires change.
For example LANG-331... no real solution and I'm
expecting that this
needs to be resolved as a known-issue.
Hen
On Sun, Mar 15, 2009 at 4:52 AM, sebb seb...@gmail.com
wrote:
I assumed it was where the next 2.x release would
come from.
Or will there be no further releases supporting
versions of Java prior to 1.5?
On 15/03/2009, Matt Benson gudnabr...@yahoo.com
wrote:
Are we still using this branch? I created
it for work on the reflect subpackage but later merged back
to trunk... :|
-Matt
--- On Sat, 3/14/09, s...@apache.org
s...@apache.org
wrote:
From: s...@apache.org
s...@apache.org
Subject: svn commit: r754584 - in
/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder:
ToStringBuilder.java ToStringStyle.java
To: comm...@commons.apache.org
Date: Saturday, March 14, 2009, 8:43
PM
Author: sebb
Date: Sun Mar 15 01:43:20 2009
New Revision: 754584
URL: http://svn.apache.org/viewvc?rev=754584view=rev
Log:
Replace deprecated method calls to
appendIdentityToString
with identityToString
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringBuilder.java
Sun Mar 15 01:43:20 2009
@@ -945,7 +945,7 @@
* @since 2.0
*/
public ToStringBuilder
appendAsObjectToString(Object object)
{
-
ObjectUtils.appendIdentityToString(this.getStringBuffer(),
object);
+
ObjectUtils.identityToString(this.getStringBuffer(),
object);
return this;
}
Modified:
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java?rev=754584r1=754583r2=754584view=diff
==
---
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
(original)
+++
commons/proper/lang/branches/LANG_POST_2_4/src/java/org/apache/commons/lang/builder/ToStringStyle.java
Sun Mar 15 01:43:20 2009
@@ -562,7 +562,7 @@
* @since 2.2
*/
protected void
appendCyclicObject(StringBuffer buffer,
String fieldName,
Object value) {
-
ObjectUtils.appendIdentityToString(buffer,
value);
+
ObjectUtils.identityToString(buffer,
value);
}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail:
Re: [LANG] 3.0 StrTokenizer API change for next()
On Sun, Mar 15, 2009 at 9:36 AM, sebb seb...@gmail.com wrote: On 15/03/2009, sebb seb...@gmail.com wrote: StrTokenizer implements ListIterator currently. Given that it only deals in Strings, it could implement ListIteratorString, however that would mean changing public Object next() to public String next() Oops I forgot about previous(). Also add() and set(), which throw UnsupportedOperationException. Any objections to implementing the above? No objections. +1. Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release of DbUtils 1.2 RC3
sebb wrote: Having a ready-made test app might encourage others to test as well. What do you have in mind here? An OracleTestApp class checked into our tests? Or an IntegrationTestApp that would work against multiple vendors? I can certainly imagine an OracleTestApp, but naturally I'm not in a good position to write it since I don't actually have Oracle. (Also, would we have to add the Oracle JDBC driver to our POM?) The problem gets even more complicated if we tried to write a generic IntegrationTestApp to work against multiple venders. How would the IntegrationTestApp know what column types are possible? How would it manage access to the DataSource in a vendor-agnostic way? Would we have to add a dozen (closed source?) DB drivers to our test classpath? -Dan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release of DbUtils 1.2 RC3
On 15/03/2009, Dan Fabulich d...@fabulich.com wrote: sebb wrote: Having a ready-made test app might encourage others to test as well. What do you have in mind here? An OracleTestApp class checked into our tests? Or an IntegrationTestApp that would work against multiple vendors? I can certainly imagine an OracleTestApp, but naturally I'm not in a good position to write it since I don't actually have Oracle. (Also, would we have to add the Oracle JDBC driver to our POM?) The problem gets even more complicated if we tried to write a generic IntegrationTestApp to work against multiple venders. How would the IntegrationTestApp know what column types are possible? How would it manage access to the DataSource in a vendor-agnostic way? Would we have to add a dozen (closed source?) DB drivers to our test classpath? I thought that DBUtils used JDBC, which is a common API? So to run a test, one would have to acquire the appropriate driver for one's database. No need to add the drivers to SVN. -Dan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[VOTE] Release commons-exec-1.0 based on RC5
Hi folks, here is the next release candidate for commons-exec-1.0 +) the findbugs configuration file is now part of the source distribution so the site can be rebuild based on the source distribution alone +) using version number 1.0 instead of 1.0.0 +) I failed to create an extended manifest for sources and javadoc jars (not really important and a parent pom issue) Cheers, Siegfried Goeschl --- Tag: https://svn.apache.org/repos/asf/commons/proper/exec/tags/EXEC_1_0 Site: http://people.apache.org/builds/commons/exec/1.0/RC5/site/index.html Binaries: http://people.apache.org/builds/commons/exec/1.0/RC5/staged/org/apache/commons/commons-exec/1.0/ [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
