[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 69 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-proxy-test : Apache Commons Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -WARNING- Overriding Maven settings: [/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml] -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/proxy/pom.xml -INFO- Project Reports in: /srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/gump_work/build_apache-commons_commons-proxy-test.html Work Name: build_apache-commons_commons-proxy-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml test [Working Directory: /srv/gump/public/workspace/apache-commons/proxy] M2_HOME: /opt/maven2 - Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.commons.proxy.factory.util.TestMethodSignature Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.provider.TestConstantProvider Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.commons.proxy.interceptor.TestFilteredInterceptor Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec Running org.apache.commons.proxy.interceptor.filter.TestPatternFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.commons.proxy.interceptor.TestSerializingInterceptor Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec Running org.apache.commons.proxy.interceptor.TestInterceptorChain Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running org.apache.commons.proxy.invoker.TestNullInvoker Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 sec Running org.apache.commons.proxy.provider.remoting.TestBurlapProvider Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running org.apache.commons.proxy.exception.TestDelegateProviderException Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.invoker.TestChainInvoker Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec Running org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory Tests run: 37, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec Running org.apache.commons.proxy.exception.TestProxyFactoryException Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.interceptor.filter.TestReturnTypeFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.commons.proxy.provider.TestBeanProvider Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Results : Tests in error: testInvalidHandlerName(org.apache.commons.proxy.invoker.TestXmlRpcInvoker) Tests run: 179, Failures: 0, Errors: 1, Skipped: 0 [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] There are test failures. Please refer to /srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports for the individual test results. [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 13 seconds [INFO] Finished at: Wed May 11 06:01:00 UTC 2011 [INFO] Final Memory: 24M/58M [INFO] - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/rss.xml - Atom:
[continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8190projectId=97 Build statistics: State: Failed Previous State: Ok Started at: Wed 11 May 2011 07:21:51 + Finished at: Wed 11 May 2011 07:23:32 + Total time: 1m 41s Build Trigger: Schedule Build Number: 289 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: Changed: luc @ Wed 11 May 2011 06:57:47 + Comment: Avoid some remaining array copying in ArrayFieldVector, AbstractFieldMAtrix and AbstractRealMatrix. JIRA: MATH-573 Files changed: /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/AbstractFieldMatrix.java ( 1101763 ) /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/AbstractRealMatrix.java ( 1101763 ) /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/ArrayFieldVector.java ( 1101763 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode -Pjava-1.5 Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.5) Test Summary: Tests: 2391 Failures: 1 Errors: 0 Success Rate: 99 Total time: 66.045975 Test Failures: RandomAdaptorTest testNextLong : java.lang.AssertionError java.lang.AssertionError: chi-square test -- will fail about 1 in 1000 times at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.apache.commons.math.random.RandomDataTest.testNextLong(RandomDataTest.java:145) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.apache.commons.math.RetryRunner$1.evaluate(RetryRunner.java:59) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:115) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
+1 (as I have understand the goal is to be under the commons umbrella). What about the java package ? (ognl - org.apache.commons.ognl ? ) 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
Salut Olivier! yes, the goal is promoting OGNL under commons, once incubation is over so java package should be org.apache.commons.ognl, feel free to fill an issue and work on it if you have spare time! What someone else thinks about it? Many thanks in advance!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 10:54 AM, Olivier Lamy ol...@apache.org wrote: +1 (as I have understand the goal is to be under the commons umbrella). What about the java package ? (ognl - org.apache.commons.ognl ? ) 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
+1 for refactoring the package to o.a.c.ognl I'd like to keep the version history (so I vote in favor of 4.0.0), sometimes is very difficult to understand that a 2.xx version is older than a 1.xx version. On 11 May 2011 10:54, Olivier Lamy ol...@apache.org wrote: +1 (as I have understand the goal is to be under the commons umbrella). What about the java package ? (ognl - org.apache.commons.ognl ? ) 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Maurizio Cucchiara - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
Le 10/05/2011 16:13, sebb a écrit : This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it +1 I just noticed you didn't put yourself in the developers section of the pom file. With all the work you have done, you should get some credit. Luc [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
Hi Mau, I understand your POV, but at the same time this is apache commons-ognl and no more ognl... Anyway, do we have other cases of projects that joined the incubator during their life cycle to see how they managed that situation? I thing Apache OpenNPL is one of this case, let me bug that people... :P Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 11:02 AM, Maurizio Cucchiara maurizio.cucchi...@gmail.com wrote: +1 for refactoring the package to o.a.c.ognl I'd like to keep the version history (so I vote in favor of 4.0.0), sometimes is very difficult to understand that a 2.xx version is older than a 1.xx version. On 11 May 2011 10:54, Olivier Lamy ol...@apache.org wrote: +1 (as I have understand the goal is to be under the commons umbrella). What about the java package ? (ognl - org.apache.commons.ognl ? ) 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Maurizio Cucchiara - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! yes, the goal is promoting OGNL under commons, once incubation is over so java package should be org.apache.commons.ognl, feel free to fill an issue and work on it if you have spare time! Issue loaded here https://issues.apache.org/jira/browse/OGNL-5 (waiting for comments if any) I will probably wait some days before doing this big change. Maybe wait license header change first ? or we can do this after the java package name change ? Let me know. What someone else thinks about it? Many thanks in advance!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 10:54 AM, Olivier Lamy ol...@apache.org wrote: +1 (as I have understand the goal is to be under the commons umbrella). What about the java package ? (ognl - org.apache.commons.ognl ? ) 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101779 - /incubator/ognl/trunk/pom.xml
Merci Olivier! I think they are interchangeable and non respective blocking, thanks for taking care of it! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 11:24 AM, Olivier Lamy ol...@apache.org wrote: 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! yes, the goal is promoting OGNL under commons, once incubation is over so java package should be org.apache.commons.ognl, feel free to fill an issue and work on it if you have spare time! Issue loaded here https://issues.apache.org/jira/browse/OGNL-5 (waiting for comments if any) I will probably wait some days before doing this big change. Maybe wait license header change first ? or we can do this after the java package name change ? Let me know. What someone else thinks about it? Many thanks in advance!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 10:54 AM, Olivier Lamy ol...@apache.org wrote: +1 (as I have understand the goal is to be under the commons umbrella). What about the java package ? (ognl - org.apache.commons.ognl ? ) 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier! hi all! Since the OGNL version we'll release is the ASF one, I wonder if: - groupId should be org.apache.commons - artifactId should be commons-ognl - version should be 1.0-incubating-SNAPSHOT WDYT? Have a nice day, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 9:55 AM, ol...@apache.org wrote: Author: olamy Date: Wed May 11 07:55:33 2011 New Revision: 1101779 URL: http://svn.apache.org/viewvc?rev=1101779view=rev Log: use a SNAPSHOT version in the pom Modified: incubator/ognl/trunk/pom.xml Modified: incubator/ognl/trunk/pom.xml URL: http://svn.apache.org/viewvc/incubator/ognl/trunk/pom.xml?rev=1101779r1=1101778r2=1101779view=diff == --- incubator/ognl/trunk/pom.xml (original) +++ incubator/ognl/trunk/pom.xml Wed May 11 07:55:33 2011 @@ -5,7 +5,7 @@ groupIdognl/groupId artifactIdognl/artifactId packagingjar/packaging - version3.0.1/version + version3.0.2-SNAPSHOT/version nameOGNL - Object Graph Navigation Library/name descriptionOGNL - Object Graph Navigation Library/description - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)
On Wed, May 11, 2011 at 07:23:34AM +, Continuum@vmbuild wrote: [...] Test Summary: Tests: 2391 Failures: 1 Errors: 0 Success Rate: 99 Total time: 66.045975 Test Failures: RandomAdaptorTest testNextLong : java.lang.AssertionError java.lang.AssertionError: chi-square test -- will fail about 1 in 1000 times at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.apache.commons.math.random.RandomDataTest.testNextLong(RandomDataTest.java:145) ^^ at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.apache.commons.math.RetryRunner$1.evaluate(RetryRunner.java:59) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:35) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:115) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:97) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103) at $Proxy0.invoke(Unknown Source) at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150) at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69) RandomAdaptorTest reruns all the tests in RandomDataTest (because it inherits from it). This seems odd. Regards, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
On 11 May 2011 10:02, Luc Maisonobe luc.maison...@free.fr wrote: Le 10/05/2011 16:13, sebb a écrit : This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it +1 I just noticed you didn't put yourself in the developers section of the pom file. With all the work you have done, you should get some credit. Thanks, but I don't want to add my name to it. SVN history and changes anyway show which code I've updated. Luc [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101678 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
On 11/05/2011 01:18, Phil Steitz wrote:
Please raise issues and/or update changes.xml to keep track of these
changes.
Will do. My focus so far has been on seeing if it is possible to get
DBCP to a point where it is on a par with jdbc-pool performance-wise. I
purposely skipped a lot of house-keeping along the way in case it didn't
work. Now it has (DBCP is a lot closer but still not quite as fast as
jdbc-pool) I'll go back and do the house-keeping.
I guess in this case, we might want to doc the fact that we are just
tracking what dbcp thinks the state of the connection is. If access
to the underlying connection is allowed and it gets modified, all
bets are off.
Absolutely. Better still, I think the caching should be configurable
(one attribute controls all state caching). Note that currently setting
state always updates the cache.
One more little nit - can we agree to stop adding / get rid of the
_'s in front of variable names?
Happy to. I was just following the existing coding conventions.
Mark
Phil
On 5/10/11 4:27 PM, ma...@apache.org wrote:
Author: markt
Date: Tue May 10 23:27:13 2011
New Revision: 1101678
URL: http://svn.apache.org/viewvc?rev=1101678view=rev
Log:
Cache current values of autoCommit and readOnly so DB queries are not
required for every call to the getter
Modified:
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
Modified:
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
URL:
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java?rev=1101678r1=1101677r2=1101678view=diff
==
---
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
(original)
+++
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java
Tue May 10 23:27:13 2011
@@ -75,6 +75,10 @@ public class DelegatingConnection extend
protected boolean _closed = false;
+
+private Boolean _autoCommitCached = null;
+private Boolean _readOnlyCached = null;
+
/**
* Create a wrapper for the Connection which traces this
* Connection in the AbandonedObjectPool.
@@ -344,9 +348,20 @@ public class DelegatingConnection extend
{ checkOpen(); try { _conn.commit(); } catch (SQLException e) {
handleException(e); } }
@Override
-public boolean getAutoCommit() throws SQLException
-{ checkOpen(); try { return _conn.getAutoCommit(); } catch
(SQLException e) { handleException(e); return false; }
+public boolean getAutoCommit() throws SQLException {
+checkOpen();
+if (_autoCommitCached != null) {
+return _autoCommitCached.booleanValue();
+}
+try {
+_autoCommitCached = Boolean.valueOf(_conn.getAutoCommit());
+return _autoCommitCached.booleanValue();
+} catch (SQLException e) {
+handleException(e);
+return false;
+}
}
+
@Override
public String getCatalog() throws SQLException
{ checkOpen(); try { return _conn.getCatalog(); } catch (SQLException
e) { handleException(e); return null; } }
@@ -375,9 +390,20 @@ public class DelegatingConnection extend
{ checkOpen(); try { return _conn.getWarnings(); } catch (SQLException
e) { handleException(e); return null; } }
@Override
-public boolean isReadOnly() throws SQLException
-{ checkOpen(); try { return _conn.isReadOnly(); } catch (SQLException
e) { handleException(e); return false; } }
-
+public boolean isReadOnly() throws SQLException {
+checkOpen();
+if (_readOnlyCached != null) {
+return _readOnlyCached.booleanValue();
+}
+try {
+_readOnlyCached = Boolean.valueOf(_conn.isReadOnly());
+return _readOnlyCached.booleanValue();
+} catch (SQLException e) {
+handleException(e);
+return false;
+}
+}
+
@Override
public String nativeSQL(String sql) throws SQLException
{ checkOpen(); try { return _conn.nativeSQL(sql); } catch (SQLException
e) { handleException(e); return null; } }
@@ -387,16 +413,32 @@ public class DelegatingConnection extend
{ checkOpen(); try { _conn.rollback(); } catch (SQLException e) {
handleException(e); } }
@Override
-public void setAutoCommit(boolean autoCommit) throws SQLException
-{ checkOpen(); try { _conn.setAutoCommit(autoCommit); } catch
(SQLException e) { handleException(e); } }
+public void setAutoCommit(boolean autoCommit) throws SQLException {
+checkOpen();
+try {
+_conn.setAutoCommit(autoCommit);
+_autoCommitCached = Boolean.valueOf(autoCommit);
+} catch
Re: svn commit: r1101516 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericObjectPool.java PooledObject.java PooledObjectState.java
On 11/05/2011 01:59, Phil Steitz wrote:
On 5/10/11 8:48 AM, ma...@apache.org wrote:
snip/
Could be I am not following the logic here, but seems to me that
better names below would be startMaintenance / endMaintenance
Phil
+public synchronized boolean startEvictionTest() {
I did think about this but decided to wait until I had finished the
validation related changes (to come) before deciding on the final names.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101516 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericObjectPool.java PooledObject.java PooledObjectState.java
On 11/05/2011 03:26, Phil Steitz wrote: On 5/10/11 8:48 AM, ma...@apache.org wrote: Author: markt Date: Tue May 10 15:48:22 2011 New Revision: 1101516 URL: http://svn.apache.org/viewvc?rev=1101516view=rev Log: Move to using LinkedBlockingDeque for the queue of idle objects. Definitely simpler, cleaner code, but seems there will be no easy way to enable fairness and some badly unfair stuff can happen when clients get instances under maintenance. In theory, an unlucky client could wait forever. Do we have any data on how unfair LinkedBlockingDeque can be? No. I suspect it will be as bad as the old non-fair DBCP implementation. ArrayBlockingQueue is an alternative that does support fairness; but then I guess we lose LIFO/FIFO control and probably performance. Losing LIFO/FIFO is a non-starter in my view. Any ideas how we could get fairness, or at least some control over fairness to work? My best ideas so far was to copy jdbc-pool's approach and wrap the Deque and provide fair locking in the wrapper. Another thing to think about is whether clients are better off waiting for the state change on instances under maintenance than getting back in line for the next available instance. (I now see the fairness TODO in TestGOP :) It depends how busy the pool is. If there are other idle instances, getting back in line will be fine. If the pool is exhausted, better to wait for the instance currently being tested. On reflection, it should be possible to allow borrowing to over-ride an in-progress eviction test. That should always be the fastest solution. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101516 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericObjectPool.java PooledObject.java PooledObjectState.java
On 11/05/2011 04:34, Phil Steitz wrote: On 5/10/11 7:26 PM, Phil Steitz wrote: On 5/10/11 8:48 AM, ma...@apache.org wrote: Author: markt Date: Tue May 10 15:48:22 2011 New Revision: 1101516 URL: http://svn.apache.org/viewvc?rev=1101516view=rev Log: Move to using LinkedBlockingDeque for the queue of idle objects. Definitely simpler, cleaner code, but seems there will be no easy way to enable fairness and some badly unfair stuff can happen when clients get instances under maintenance. In theory, an unlucky client could wait forever. Do we have any data on how unfair LinkedBlockingDeque can be? ArrayBlockingQueue is an alternative that does support fairness; but then I guess we lose LIFO/FIFO control and probably performance. Any ideas how we could get fairness, or at least some control over fairness to work? Another thing to think about is whether clients are better off waiting for the state change on instances under maintenance than getting back in line for the next available instance. (I now see the fairness TODO in TestGOP :) After looking quickly at the Harmony code for LinkedBlockingDeque, we may be able to solve both the 1.6 problem and fairness by bringing that source in and just making the ReentrantLock that it uses configurable to be either fair or not (as ArrayBlockingQueue does). Might be naive, but might work. I like it. A lot. Great idea. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[continuum] BUILD FAILURE: Apache Commons - Commons DBCP - Default Maven 2 Build Definition (Java 1.6)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8196projectId=73 Build statistics: State: Failed Previous State: Failed Started at: Wed 11 May 2011 11:21:38 + Finished at: Wed 11 May 2011 11:21:53 + Total time: 15s Build Trigger: Schedule Build Number: 24 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: Changed: markt @ Wed 11 May 2011 10:49:55 + Comment: Update the release notes for work completed to date on DBCP 2 Files changed: /commons/proper/dbcp/trunk/RELEASE-NOTES.txt ( 1101829 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.6) Test Summary: Tests: 0 Failures: 0 Errors: 0 Total time: 0.0 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[OGNL] startup questions
Hi all guys, as you maybe already noticed, we started working on OGNL codebase, I some question that PMCs/Mentors can help to reply: * is it fine updating groupId to `org.apache.commons` and artifactId `commons-ognl` even if under incubation? * version number: there are 2 way of thinking about it. For someone is fine continuing from the old version number, IMHO it should be 0.1-incubating, since in my mind ognl != commons-ognl. Which one sounds better? I tried to see how running projects managed that situation, once under Apache incubator, but didn't have success. Thoughts? * it sounds reasonable to me plug the commons-parent pom to OGNL pom, WDYT? Many thanks in advance, all the best! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
Hi Simone, Simone Tripodi wrote: Hi all guys, as you maybe already noticed, we started working on OGNL codebase, I some question that PMCs/Mentors can help to reply: * is it fine updating groupId to `org.apache.commons` and artifactId `commons-ognl` even if under incubation? +1 * version number: there are 2 way of thinking about it. For someone is fine continuing from the old version number, IMHO it should be 0.1-incubating, since in my mind ognl != commons-ognl. Which one sounds better? I tried to see how running projects managed that situation, once under Apache incubator, but didn't have success. Thoughts? I'd continue with the next major release number. Actually users don't really care about, where the project is hosted, for them it's still ongl. You would have been surprised also if Subversion started over with 1.0 again, didn't you? * it sounds reasonable to me plug the commons-parent pom to OGNL pom, WDYT? Definitely. Many thanks in advance, all the best! Cheers, Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
2011/5/11 Jörg Schaible joerg.schai...@scalaris.com * version number: there are 2 way of thinking about it. For someone is fine continuing from the old version number, IMHO it should be 0.1-incubating, since in my mind ognl != commons-ognl. Which one sounds better? I tried to see how running projects managed that situation, once under Apache incubator, but didn't have success. Thoughts? I'd continue with the next major release number. That is 4.0.0. Antonio
[continuum] BUILD FAILURE: Apache Commons - Commons Pool - Default Maven 2 Build Definition (Java 1.5)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8198projectId=98 Build statistics: State: Failed Previous State: Failed Started at: Wed 11 May 2011 12:22:12 + Finished at: Wed 11 May 2011 12:22:23 + Total time: 11s Build Trigger: Schedule Build Number: 83 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: Changed: markt @ Wed 11 May 2011 12:03:35 + Comment: Add a TODO Files changed: /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java ( 1101849 ) Changed: markt @ Wed 11 May 2011 12:05:29 + Comment: Update changelog Files changed: /commons/proper/pool/trunk/src/changes/changes.xml ( 1101850 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode -Pjava-1.5 Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.5) Test Summary: Tests: 0 Failures: 0 Errors: 0 Total time: 0.0 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[continuum] BUILD FAILURE: Apache Commons - Commons DBCP - Default Maven 2 Build Definition (Java 1.6)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8199projectId=73 Build statistics: State: Failed Previous State: Failed Started at: Wed 11 May 2011 12:22:25 + Finished at: Wed 11 May 2011 12:22:35 + Total time: 9s Build Trigger: Schedule Build Number: 24 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: Changed: markt @ Wed 11 May 2011 11:39:54 + Comment: Make state cahcing optional Files changed: /commons/proper/dbcp/trunk/RELEASE-NOTES.txt ( 1101837 ) /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1101837 ) /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1101837 ) /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1101837 ) /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1101837 ) /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1101837 ) Changed: markt @ Wed 11 May 2011 11:42:48 + Comment: Remove the 1.3 build files Files changed: /commons/proper/dbcp/trunk/build-1.3.xml ( 1101838 ) /commons/proper/dbcp/trunk/pom-1.3.xml ( 1101838 ) Changed: markt @ Wed 11 May 2011 11:48:38 + Comment: Update changes rather than release notes (which are auto-generated). Files changed: /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1101843 ) Changed: markt @ Wed 11 May 2011 11:52:32 + Comment: Update for 2.0.x release (may need some tweaks) Files changed: /commons/proper/dbcp/trunk/release-process.txt ( 1101846 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.6) Test Summary: Tests: 0 Failures: 0 Errors: 0 Total time: 0.0 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
On 11 May 2011 13:00, Jörg Schaible joerg.schai...@scalaris.com wrote: Hi Simone, Simone Tripodi wrote: Hi all guys, as you maybe already noticed, we started working on OGNL codebase, I some question that PMCs/Mentors can help to reply: * is it fine updating groupId to `org.apache.commons` and artifactId `commons-ognl` even if under incubation? +1 I'd be inclined to keep the current package name and Maven ids during (most of) incubation. While the code is still incubating, I think it would be OK to break compatibility without forcing a package name change or Maven id change. Once OGNL is accepted into Commons, we need to be much more careful about backwards compatibility. Changing to the final names now might force another change if the API needs to be changed later. * version number: there are 2 way of thinking about it. For someone is fine continuing from the old version number, IMHO it should be 0.1-incubating, since in my mind ognl != commons-ognl. Which one sounds better? I tried to see how running projects managed that situation, once under Apache incubator, but didn't have success. Thoughts? I'd continue with the next major release number. Actually users don't really care about, where the project is hosted, for them it's still ongl. You would have been surprised also if Subversion started over with 1.0 again, didn't you? * it sounds reasonable to me plug the commons-parent pom to OGNL pom, WDYT? Definitely. Many thanks in advance, all the best! Cheers, Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101516 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericObjectPool.java PooledObject.java PooledObjectState.java
On 11/05/2011 11:31, Mark Thomas wrote: On 11/05/2011 04:34, Phil Steitz wrote: On 5/10/11 7:26 PM, Phil Steitz wrote: On 5/10/11 8:48 AM, ma...@apache.org wrote: Author: markt Date: Tue May 10 15:48:22 2011 New Revision: 1101516 URL: http://svn.apache.org/viewvc?rev=1101516view=rev Log: Move to using LinkedBlockingDeque for the queue of idle objects. Definitely simpler, cleaner code, but seems there will be no easy way to enable fairness and some badly unfair stuff can happen when clients get instances under maintenance. In theory, an unlucky client could wait forever. Do we have any data on how unfair LinkedBlockingDeque can be? ArrayBlockingQueue is an alternative that does support fairness; but then I guess we lose LIFO/FIFO control and probably performance. Any ideas how we could get fairness, or at least some control over fairness to work? Another thing to think about is whether clients are better off waiting for the state change on instances under maintenance than getting back in line for the next available instance. (I now see the fairness TODO in TestGOP :) After looking quickly at the Harmony code for LinkedBlockingDeque, we may be able to solve both the 1.6 problem and fairness by bringing that source in and just making the ReentrantLock that it uses configurable to be either fair or not (as ArrayBlockingQueue does). Might be naive, but might work. I like it. A lot. Great idea. Better still, it is faster than whatever Oracle wrote for Java 6 :) With this in place, DBCP is slightly faster than jdbc-pool for jdbc-pools checkout thread tests. This is only two microbenchmarks (there are lots of other tests where jdbc-pool is faster but I haven't optimized DBCP for those yet) but it is a promising sign. I just need to tidy up the code before I check it in. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101862 - in /commons/proper/pool/trunk: ./ src/changes/ src/java/org/apache/commons/pool2/impl/
that is *great*, congrats!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 2:50 PM, ma...@apache.org wrote: Author: markt Date: Wed May 11 12:50:33 2011 New Revision: 1101862 URL: http://svn.apache.org/viewvc?rev=1101862view=rev Log: Restore Java 1.5 support by using the LinkedBlockingDeque from Apache Harmony. Added: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java (contents, props changed) - copied, changed from r1101857, harmony/enhanced/java/branches/java6/classlib/modules/concurrent/src/main/java/java/util/concurrent/LinkedBlockingDeque.java Modified: commons/proper/pool/trunk/NOTICE.txt commons/proper/pool/trunk/build.xml commons/proper/pool/trunk/pom.xml commons/proper/pool/trunk/src/changes/changes.xml commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/PooledObject.java Modified: commons/proper/pool/trunk/NOTICE.txt URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/NOTICE.txt?rev=1101862r1=1101861r2=1101862view=diff == --- commons/proper/pool/trunk/NOTICE.txt (original) +++ commons/proper/pool/trunk/NOTICE.txt Wed May 11 12:50:33 2011 @@ -3,3 +3,8 @@ Copyright 2001-2011 The Apache Software This product includes software developed by The Apache Software Foundation (http://www.apache.org/). + +The LinkedBlockingDeque implementation is based on an implementation written by +Doug Lea with assistance from members of JCP JSR-166 Expert Group and released +to the public domain, as explained at +http://creativecommons.org/licenses/publicdomain \ No newline at end of file Modified: commons/proper/pool/trunk/build.xml URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/build.xml?rev=1101862r1=1101861r2=1101862view=diff == --- commons/proper/pool/trunk/build.xml (original) +++ commons/proper/pool/trunk/build.xml Wed May 11 12:50:33 2011 @@ -61,8 +61,8 @@ property name=javac.optimize value=false/ property name=javac.debug value=true/ property name=javac.deprecation value=true/ - property name=javac.target.version value=1.6/ - property name=javac.src.version value=1.6/ + property name=javac.target.version value=1.5/ + property name=javac.src.version value=1.5/ /target !-- # -- Modified: commons/proper/pool/trunk/pom.xml URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1101862r1=1101861r2=1101862view=diff == --- commons/proper/pool/trunk/pom.xml (original) +++ commons/proper/pool/trunk/pom.xml Wed May 11 12:50:33 2011 @@ -135,8 +135,8 @@ properties project.build.sourceEncodingUTF-8/project.build.sourceEncoding project.reporting.outputEncodingUTF-8/project.reporting.outputEncoding - maven.compile.source1.6/maven.compile.source - maven.compile.target1.6/maven.compile.target + maven.compile.source1.5/maven.compile.source + maven.compile.target1.5/maven.compile.target commons.componentidpool/commons.componentid commons.release.version2.0/commons.release.version commons.jira.idPOOL/commons.jira.id Modified: commons/proper/pool/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/changes/changes.xml?rev=1101862r1=1101861r2=1101862view=diff == --- commons/proper/pool/trunk/src/changes/changes.xml (original) +++ commons/proper/pool/trunk/src/changes/changes.xml Wed May 11 12:50:33 2011 @@ -28,7 +28,9 @@ Developer documentation and examples have to be updated once the 2.0 repackaging has been done /action action dev=markt type=update - Switch GOP to use a pooling mechanism based on java.util.concurrent. + Switch GOP to use a pooling mechanism based on java.util.concurrent and a + LinkedBlockingQueue implementation from Apache Harmony (originally by Doug + Lea and the JSR-166 expert group). /action /release release version=1.5.6 date=2011-04-03 description=This is a patch release, including bugfixes only. Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java?rev=1101862r1=1101861r2=1101862view=diff == ---
[continuum] BUILD FAILURE: Apache Commons - Commons DBCP - Default Maven 2 Build Definition (Java 1.6)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8202projectId=73 Build statistics: State: Failed Previous State: Failed Started at: Wed 11 May 2011 13:26:28 + Finished at: Wed 11 May 2011 13:27:27 + Total time: 59s Build Trigger: Schedule Build Number: 24 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: No files changed Dependencies Changes: org.apache.commons:commons-pool2:2.0-SNAPSHOT Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.6) Test Summary: Tests: 443 Failures: 1 Errors: 0 Success Rate: 99 Total time: 45.655994 Test Failures: TestManagedDataSourceInTx testAutoCommitBehavior : junit.framework.AssertionFailedError junit.framework.AssertionFailedError: Auto-commit should be disabled at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at junit.framework.Assert.assertFalse(Assert.java:34) at org.apache.commons.dbcp2.managed.TestManagedDataSourceInTx.testAutoCommitBehavior(TestManagedDataSourceInTx.java:246) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
On Wed, May 11, 2011 at 2:28 PM, sebb seb...@gmail.com wrote: I'd be inclined to keep the current package name and Maven ids during (most of) incubation. Disagreed. Changing package names etc. should be the first steps in incubation. As should be the publication of an early release with the new package names. This allows end users to pick up as soon as possible while still be upwards compatible. If you don't do that, then users might prefer to wait until the major change is done. -- I Am What I Am And That's All What I Yam (Popeye) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
On May 11, 2011, at 9:36, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: On Wed, May 11, 2011 at 2:28 PM, sebb seb...@gmail.com wrote: I'd be inclined to keep the current package name and Maven ids during (most of) incubation. Disagreed. Changing package names etc. should be the first steps in incubation. As should be the publication of an early release with the new package names. This allows end users to pick up as soon as possible while still be upwards compatible. +1 Gary If you don't do that, then users might prefer to wait until the major change is done. -- I Am What I Am And That's All What I Yam (Popeye) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
Would you guys be willing to start at 4.0-SNAPSHOT so there's a direct continuation of versioning? Just a novel thought since it might help others to see it's not a re-invention of OGNL, per se, but the continuation of it. On Wed, May 11, 2011 at 8:38 AM, Gary Gregory garydgreg...@gmail.com wrote: On May 11, 2011, at 9:36, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: On Wed, May 11, 2011 at 2:28 PM, sebb seb...@gmail.com wrote: I'd be inclined to keep the current package name and Maven ids during (most of) incubation. Disagreed. Changing package names etc. should be the first steps in incubation. As should be the publication of an early release with the new package names. This allows end users to pick up as soon as possible while still be upwards compatible. +1 Gary If you don't do that, then users might prefer to wait until the major change is done. -- I Am What I Am And That's All What I Yam (Popeye) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
On 11 May 2011 14:36, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: On Wed, May 11, 2011 at 2:28 PM, sebb seb...@gmail.com wrote: I'd be inclined to keep the current package name and Maven ids during (most of) incubation. Disagreed. Changing package names etc. should be the first steps in incubation. As should be the publication of an early release with the new package names. This allows end users to pick up as soon as possible while still be upwards compatible. However, if a breaking API change is needed, then the package name/Maven ids will *have* to be changed. If you don't do that, then users might prefer to wait until the major change is done. Depending on incubator code is akin to depending on alpha code, i.e. the user should be prepared for API instability. If the user is not prepared to deal with that, then they should not be using incubator code in my view. But if the OGNL developers don't mind potentially ending up with something other than o.a.c.ognl that is up to them. I'm just trying to point out that there may be disadvantages to changing now. -- I Am What I Am And That's All What I Yam (Popeye) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
On Wed, May 11, 2011 at 3:45 PM, sebb seb...@gmail.com wrote: However, if a breaking API change is needed, then the package name/Maven ids will *have* to be changed. That's not different from a new major release in commons. If you anticipate the necessity of binary changes, consider creating a maintenance branch and a new branch anyways. Depending on incubator code is akin to depending on alpha code, i.e. the user should be prepared for API instability. Why so? In contrary, I'd suggest to have the early release based on a stable branch for that very reason. -- I Am What I Am And That's All What I Yam (Popeye) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
Hi Paul! yes I agree, according to Joerg's suggestion, version should be 4.0-incubating-SNAPSHOT. @Joerg: absolutely right, thanks for your help!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 3:41 PM, Paul Benedict pbened...@apache.org wrote: Would you guys be willing to start at 4.0-SNAPSHOT so there's a direct continuation of versioning? Just a novel thought since it might help others to see it's not a re-invention of OGNL, per se, but the continuation of it. On Wed, May 11, 2011 at 8:38 AM, Gary Gregory garydgreg...@gmail.com wrote: On May 11, 2011, at 9:36, Jochen Wiedmann jochen.wiedm...@gmail.com wrote: On Wed, May 11, 2011 at 2:28 PM, sebb seb...@gmail.com wrote: I'd be inclined to keep the current package name and Maven ids during (most of) incubation. Disagreed. Changing package names etc. should be the first steps in incubation. As should be the publication of an early release with the new package names. This allows end users to pick up as soon as possible while still be upwards compatible. +1 Gary If you don't do that, then users might prefer to wait until the major change is done. -- I Am What I Am And That's All What I Yam (Popeye) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] startup questions
I agree and moreover I hate whenever I try to add a maven dependency through Intellij Idea and I see 3 different major version, realizing that the small version is the latter. On 11 May 2011 15:41, Paul Benedict pbened...@apache.org wrote: Would you guys be willing to start at 4.0-SNAPSHOT so there's a direct continuation of versioning? Just a novel thought since it might help others to see it's not a re-invention of OGNL, per se, but the continuation of it. -- Maurizio Cucchiara - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[OGNL] Please insert Jira issue in commit log
All OGNL-ers Can you please insert the Jira issue you are working on when you commit? This way, Jira links commits to the issues. Thanks Antonio
Re: svn commit: r1101883 - /incubator/ognl/trunk/pom.xml
2011/5/11 ol...@apache.org +pluginManagement + plugins +plugin + groupIdorg.apache.maven.plugins/groupId + artifactIdmaven-idea-plugin/artifactId + version2.2/version +/plugin + /plugins +/pluginManagement Why so? Do you really need to link idea plugin to a specific version? Antonio
[continuum] BUILD FAILURE: Apache Commons - Commons DBCP - Default Maven 2 Build Definition (Java 1.6)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8206projectId=73 Build statistics: State: Failed Previous State: Failed Started at: Wed 11 May 2011 14:26:42 + Finished at: Wed 11 May 2011 14:27:42 + Total time: 59s Build Trigger: Schedule Build Number: 24 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: No files changed Dependencies Changes: org.apache.commons:commons-pool2:2.0-SNAPSHOT Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.6) Test Summary: Tests: 443 Failures: 1 Errors: 0 Success Rate: 99 Total time: 45.457996 Test Failures: TestManagedDataSourceInTx testAutoCommitBehavior : junit.framework.AssertionFailedError junit.framework.AssertionFailedError: Auto-commit should be disabled at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at junit.framework.Assert.assertFalse(Assert.java:34) at org.apache.commons.dbcp2.managed.TestManagedDataSourceInTx.testAutoCommitBehavior(TestManagedDataSourceInTx.java:246) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101516 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericObjectPool.java PooledObject.java PooledObjectState.java
On 5/11/11 3:30 AM, Mark Thomas wrote: On 11/05/2011 03:26, Phil Steitz wrote: On 5/10/11 8:48 AM, ma...@apache.org wrote: Author: markt Date: Tue May 10 15:48:22 2011 New Revision: 1101516 URL: http://svn.apache.org/viewvc?rev=1101516view=rev Log: Move to using LinkedBlockingDeque for the queue of idle objects. Definitely simpler, cleaner code, but seems there will be no easy way to enable fairness and some badly unfair stuff can happen when clients get instances under maintenance. In theory, an unlucky client could wait forever. Do we have any data on how unfair LinkedBlockingDeque can be? No. I suspect it will be as bad as the old non-fair DBCP implementation. ArrayBlockingQueue is an alternative that does support fairness; but then I guess we lose LIFO/FIFO control and probably performance. Losing LIFO/FIFO is a non-starter in my view. Any ideas how we could get fairness, or at least some control over fairness to work? My best ideas so far was to copy jdbc-pool's approach and wrap the Deque and provide fair locking in the wrapper. Another thing to think about is whether clients are better off waiting for the state change on instances under maintenance than getting back in line for the next available instance. (I now see the fairness TODO in TestGOP :) It depends how busy the pool is. If there are other idle instances, getting back in line will be fine. If the pool is exhausted, better to wait for the instance currently being tested. Also depends on which kind of maintenance is happening when the client arrives (validation or expiry testing) and how fast validation is. On reflection, it should be possible to allow borrowing to over-ride an in-progress eviction test. That should always be the fastest solution. I thought about that too; but it would be tricky to do. Depends on at what point the borrower arrives during the maintenance visit. If the instance is actually in process of being destroyed or tested, would be dicey to try to break in. Have to be very careful with the locks if we implement this. Phil Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101883 - /incubator/ognl/trunk/pom.xml
nope. But it's defined in the parent without any version so maven 3 check metadata to know the version. It's just to prevent non usefull http requests :-) when building. 2011/5/11 Antonio Petrelli antonio.petre...@gmail.com: 2011/5/11 ol...@apache.org + pluginManagement + plugins + plugin + groupIdorg.apache.maven.plugins/groupId + artifactIdmaven-idea-plugin/artifactId + version2.2/version + /plugin + /plugins + /pluginManagement Why so? Do you really need to link idea plugin to a specific version? Antonio -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101516 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericObjectPool.java PooledObject.java PooledObjectState.java
On 5/11/11 5:42 AM, Mark Thomas wrote: On 11/05/2011 11:31, Mark Thomas wrote: On 11/05/2011 04:34, Phil Steitz wrote: On 5/10/11 7:26 PM, Phil Steitz wrote: On 5/10/11 8:48 AM, ma...@apache.org wrote: Author: markt Date: Tue May 10 15:48:22 2011 New Revision: 1101516 URL: http://svn.apache.org/viewvc?rev=1101516view=rev Log: Move to using LinkedBlockingDeque for the queue of idle objects. Definitely simpler, cleaner code, but seems there will be no easy way to enable fairness and some badly unfair stuff can happen when clients get instances under maintenance. In theory, an unlucky client could wait forever. Do we have any data on how unfair LinkedBlockingDeque can be? ArrayBlockingQueue is an alternative that does support fairness; but then I guess we lose LIFO/FIFO control and probably performance. Any ideas how we could get fairness, or at least some control over fairness to work? Another thing to think about is whether clients are better off waiting for the state change on instances under maintenance than getting back in line for the next available instance. (I now see the fairness TODO in TestGOP :) After looking quickly at the Harmony code for LinkedBlockingDeque, we may be able to solve both the 1.6 problem and fairness by bringing that source in and just making the ReentrantLock that it uses configurable to be either fair or not (as ArrayBlockingQueue does). Might be naive, but might work. I like it. A lot. Great idea. Better still, it is faster than whatever Oracle wrote for Java 6 :) With this in place, DBCP is slightly faster than jdbc-pool for jdbc-pools checkout thread tests. This is only two microbenchmarks (there are lots of other tests where jdbc-pool is faster but I haven't optimized DBCP for those yet) but it is a promising sign. I just need to tidy up the code before I check it in. Great! I also now have [performance] set up to run pool2 tests directly. I have just started testing. I will post results as I get them and also for [dbcp] with the new pool. Don't forget to re-enable the fairness unit test once that is working. Phil Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101883 - /incubator/ognl/trunk/pom.xml
2011/5/11 Olivier Lamy ol...@apache.org nope. But it's defined in the parent without any version so maven 3 check metadata to know the version. It's just to prevent non usefull http requests :-) when building. So the question is: why is it present in the parent pom? :-D Thanks for the clarification Antonio
Re: svn commit: r1101912 - in /commons/proper/pool/trunk/src: java/org/apache/commons/pool2/impl/ test/org/apache/commons/pool2/impl/
On 5/11/11 7:59 AM, ma...@apache.org wrote:
Author: markt
Date: Wed May 11 14:59:52 2011
New Revision: 1101912
URL: http://svn.apache.org/viewvc?rev=1101912view=rev
Log:
More clean-up
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java
Do we still even use this class? Why not just delete it?
Phil
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackObjectPoolFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestStackObjectPoolFactory.java
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java?rev=1101912r1=1101911r2=1101912view=diff
==
---
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java
(original)
+++
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java
Wed May 11 14:59:52 2011
@@ -1113,7 +1113,7 @@ class CursorableLinkedListE implements
}
}
-public class Cursor extends ListIter implements ListIteratorE {
+public class Cursor extends ListIter {
boolean _valid = false;
Cursor(int index) {
@@ -1208,7 +1208,7 @@ class CursorableLinkedListE implements
}
-class CursorableSubListE extends CursorableLinkedListE implements
ListE {
+class CursorableSubListE extends CursorableLinkedListE {
private static final long serialVersionUID = 1L;
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java?rev=1101912r1=1101911r2=1101912view=diff
==
---
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
(original)
+++
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/SoftReferenceObjectPool.java
Wed May 11 14:59:52 2011
@@ -41,7 +41,7 @@ import org.apache.commons.pool2.Poolable
* @version $Revision$ $Date$
* @since Pool 1.0
*/
-public class SoftReferenceObjectPoolT extends BaseObjectPoolT implements
ObjectPoolT {
+public class SoftReferenceObjectPoolT extends BaseObjectPoolT {
/**
* Create a codeSoftReferenceObjectPool/code without a factory.
* {@link #setFactory(PoolableObjectFactory) setFactory} should be called
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
URL:
http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java?rev=1101912r1=1101911r2=1101912view=diff
==
---
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
(original)
+++
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
Wed May 11 14:59:52 2011
@@ -24,7 +24,6 @@ import java.util.NoSuchElementException;
import java.util.Stack;
import org.apache.commons.pool2.BaseKeyedObjectPool;
-import org.apache.commons.pool2.KeyedObjectPool;
import org.apache.commons.pool2.KeyedPoolableObjectFactory;
import org.apache.commons.pool2.PoolUtils;
@@ -50,7 +49,7 @@ import org.apache.commons.pool2.PoolUtil
* @see Stack
* @since Pool 1.0
*/
-public class StackKeyedObjectPoolK,V extends BaseKeyedObjectPoolK,V
implements KeyedObjectPoolK,V {
+public class StackKeyedObjectPoolK,V extends BaseKeyedObjectPoolK,V {
/**
* Create a new pool using no factory.
* Clients must first set the {@link #setFactory factory} or
@@ -148,7 +147,7 @@ public class StackKeyedObjectPoolK,V e
assertOpen();
StackV stack = _pools.get(key);
if(null == stack) {
-stack = new Stack();
+stack = new StackV();
stack.ensureCapacity( _initSleepingCapacity _maxSleeping ?
_maxSleeping : _initSleepingCapacity);
_pools.put(key,stack);
}
@@ -581,7 +580,7 @@ public class StackKeyedObjectPoolK,V e
* @return the _activeCount
* @since 1.5.5
*/
-public Map getActiveCount() {
+public MapK,Integer getActiveCount() {
return _activeCount;
}
Modified:
commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackObjectPoolFactory.java
URL:
Re: svn commit: r1101912 - in /commons/proper/pool/trunk/src: java/org/apache/commons/pool2/impl/ test/org/apache/commons/pool2/impl/
On 11/05/2011 16:04, Phil Steitz wrote: On 5/11/11 7:59 AM, ma...@apache.org wrote: Author: markt Date: Wed May 11 14:59:52 2011 New Revision: 1101912 URL: http://svn.apache.org/viewvc?rev=1101912view=rev Log: More clean-up Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java Do we still even use this class? Why not just delete it? GKOP is using it. It will go once I re-write GKOP. For now, I am just trying to clear all the Eclipse warnings for pool2 so it is easier to see when I do something stupid. At the moment, warnings are buried amongst lots of noise. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1101912 - in /commons/proper/pool/trunk/src: java/org/apache/commons/pool2/impl/ test/org/apache/commons/pool2/impl/
On 5/11/11 8:07 AM, Mark Thomas wrote: On 11/05/2011 16:04, Phil Steitz wrote: On 5/11/11 7:59 AM, ma...@apache.org wrote: Author: markt Date: Wed May 11 14:59:52 2011 New Revision: 1101912 URL: http://svn.apache.org/viewvc?rev=1101912view=rev Log: More clean-up Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/CursorableLinkedList.java Do we still even use this class? Why not just delete it? GKOP is using it. It will go once I re-write GKOP. Sorry, forgot about that :) For now, I am just trying to clear all the Eclipse warnings for pool2 so it is easier to see when I do something stupid. At the moment, warnings are buried amongst lots of noise. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
+1. If there is another RC, please add a code coverage report. Shouldn't code coverage be part of the parent POM? Gary Looks good on: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows On Wed, May 11, 2011 at 5:57 AM, sebb seb...@gmail.com wrote: On 11 May 2011 10:02, Luc Maisonobe luc.maison...@free.fr wrote: Le 10/05/2011 16:13, sebb a écrit : This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it +1 I just noticed you didn't put yourself in the developers section of the pom file. With all the work you have done, you should get some credit. Thanks, but I don't want to add my name to it. SVN history and changes anyway show which code I've updated. Luc [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Thank you, Gary http://garygregory.wordpress.com/ http://garygregory.com/ http://people.apache.org/~ggregory/ http://twitter.com/GaryGregory
[continuum] BUILD FAILURE: Apache Commons - Commons DBCP - Default Maven 2 Build Definition (Java 1.6)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=8210projectId=73 Build statistics: State: Failed Previous State: Failed Started at: Wed 11 May 2011 15:26:52 + Finished at: Wed 11 May 2011 15:27:52 + Total time: 59s Build Trigger: Schedule Build Number: 24 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version 1.6.0_24 Java(TM) SE Runtime Environment (build 1.6.0_24-b07) Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_24 Java home: /usr/lib/jvm/java-6-sun-1.6.0.24/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: linux version: 2.6.32-31-server arch: amd64 Family: unix SCM Changes: No files changed Dependencies Changes: org.apache.commons:commons-pool2:2.0-SNAPSHOT Build Definition: POM filename: pom.xml Goals: clean install Arguments: --batch-mode Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Default Maven 2 Build Definition (Java 1.6) Test Summary: Tests: 443 Failures: 1 Errors: 0 Success Rate: 99 Total time: 44.918995 Test Failures: TestManagedDataSourceInTx testAutoCommitBehavior : junit.framework.AssertionFailedError junit.framework.AssertionFailedError: Auto-commit should be disabled at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at junit.framework.Assert.assertFalse(Assert.java:34) at org.apache.commons.dbcp2.managed.TestManagedDataSourceInTx.testAutoCommitBehavior(TestManagedDataSourceInTx.java:246) - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] Please insert Jira issue in commit log
Yup sorry I have missed some. Note I have setup the jenkins build to update jira if you use the pattern [jiraId] /Olivier 2011/5/11 Antonio Petrelli antonio.petre...@gmail.com: All OGNL-ers Can you please insert the Jira issue you are working on when you commit? This way, Jira links commits to the issues. Thanks Antonio - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] Please insert Jira issue in commit log
Salut Olivier, I noticed it while receiving JIRA notifications, it *rocks* (and please teach me how you did it! :D) Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 5:31 PM, Olivier Lamy ol...@apache.org wrote: Yup sorry I have missed some. Note I have setup the jenkins build to update jira if you use the pattern [jiraId] /Olivier 2011/5/11 Antonio Petrelli antonio.petre...@gmail.com: All OGNL-ers Can you please insert the Jira issue you are working on when you commit? This way, Jira links commits to the issues. Thanks Antonio - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] Please insert Jira issue in commit log
Docs are here : https://wiki.jenkins-ci.org/display/JENKINS/JIRA+Plugin 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier, I noticed it while receiving JIRA notifications, it *rocks* (and please teach me how you did it! :D) Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 5:31 PM, Olivier Lamy ol...@apache.org wrote: Yup sorry I have missed some. Note I have setup the jenkins build to update jira if you use the pattern [jiraId] /Olivier 2011/5/11 Antonio Petrelli antonio.petre...@gmail.com: All OGNL-ers Can you please insert the Jira issue you are working on when you commit? This way, Jira links commits to the issues. Thanks Antonio - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[jci] preparing for jci 1.1 release
Torsten, I have moved my code base from my old version of jci 1.1 to the trunk and everything looks good. I did have trouble building the trunk, because the fam module is not included in the module list. I have opened JCI-66 to address that. I will take a look at 1.0/1.1 compatibility later this week. -Christian - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [OGNL] Please insert Jira issue in commit log
Merci beaucoup!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 6:06 PM, Olivier Lamy ol...@apache.org wrote: Docs are here : https://wiki.jenkins-ci.org/display/JENKINS/JIRA+Plugin 2011/5/11 Simone Tripodi simonetrip...@apache.org: Salut Olivier, I noticed it while receiving JIRA notifications, it *rocks* (and please teach me how you did it! :D) Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, May 11, 2011 at 5:31 PM, Olivier Lamy ol...@apache.org wrote: Yup sorry I have missed some. Note I have setup the jenkins build to update jira if you use the pattern [jiraId] /Olivier 2011/5/11 Antonio Petrelli antonio.petre...@gmail.com: All OGNL-ers Can you please insert the Jira issue you are working on when you commit? This way, Jira links commits to the issues. Thanks Antonio - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Olivier Lamy http://twitter.com/olamy http://www.linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
On 11 May 2011 16:15, Gary Gregory garydgreg...@gmail.com wrote: +1. If there is another RC, please add a code coverage report. Shouldn't code coverage be part of the parent POM? I suggest you file a JIRA so that does not get forgotten. Gary Looks good on: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows On Wed, May 11, 2011 at 5:57 AM, sebb seb...@gmail.com wrote: On 11 May 2011 10:02, Luc Maisonobe luc.maison...@free.fr wrote: Le 10/05/2011 16:13, sebb a écrit : This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it +1 I just noticed you didn't put yourself in the developers section of the pom file. With all the work you have done, you should get some credit. Thanks, but I don't want to add my name to it. SVN history and changes anyway show which code I've updated. Luc [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Thank you, Gary http://garygregory.wordpress.com/ http://garygregory.com/ http://people.apache.org/~ggregory/ http://twitter.com/GaryGregory - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
feedparser little bugfix
Hi,
I've fixed a bug in org.apache.commons.feedparser.MetaFeedParser.java to
allow correct date parsing in case of presence of white spaces before or
after the date string.
try {
//ok. Support dc:date
//String v = state.current.getChildText( name, ns );
String v = state.current.getChild( name, ns
).getTextTrim(); // fix
if ( v != null ) {
Date d = null;
if ( ISO8601 ) {
d = ISO8601DateParser.parse( v );
} else {
d = RFC822DateParser.parse( v );
}
listener.onCreated( state, d );
listener.onCreatedEnd();
return true;
}
} catch ( Throwable t ) {
// ignore the exception, so we can just move on
}
return false;
}
Best regards
Diego Peroni
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: feedparser little bugfix
On 11 May 2011 17:08, Diego Peroni diegoper...@vodafone.it wrote:
Hi,
I've fixed a bug in org.apache.commons.feedparser.MetaFeedParser.java to
allow correct date parsing in case of presence of white spaces before or
after the date string.
Bugs should normally be reported via JIRA issues please.
http://commons.apache.org/dormant/feedparser/issue-tracking.html
This means they are less likely to be forgotten.
try {
//ok. Support dc:date
//String v = state.current.getChildText( name, ns );
String v = state.current.getChild( name, ns ).getTextTrim(); //
fix
if ( v != null ) {
Date d = null;
if ( ISO8601 ) {
d = ISO8601DateParser.parse( v );
} else {
d = RFC822DateParser.parse( v );
}
listener.onCreated( state, d );
listener.onCreatedEnd();
return true;
}
} catch ( Throwable t ) {
// ignore the exception, so we can just move on
}
return false;
}
Best regards
Diego Peroni
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look good. Minor nit: When I build the site on my local machine I get 64 findbugs errors. These are not shown on the staged site. According to my local findbugs report 572 classes have been checked while the report on the published site only has 200 classes. I only had a short glance at these errors, but they do not seem to be too problematic. So +1 Oliver Am 10.05.2011 16:13, schrieb sebb: This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
On 11 May 2011 21:07, Oliver Heger oliver.he...@oliver-heger.de wrote: Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look good. Minor nit: When I build the site on my local machine I get 64 findbugs errors. These are not shown on the staged site. According to my local findbugs report 572 classes have been checked while the report on the published site only has 200 classes. I only had a short glance at these errors, but they do not seem to be too problematic. There are 200 classes in target/classes (this includes examples). There are 52 classes under target/test-classes - these are not included in the Findbugs configuration. The other 320 classes perhaps come from running Clover? So +1 Oliver Am 10.05.2011 16:13, schrieb sebb: This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Commons NET 3.0` based on RC1
Am 11.05.2011 22:26, schrieb sebb: On 11 May 2011 21:07, Oliver Hegeroliver.he...@oliver-heger.de wrote: Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look good. Minor nit: When I build the site on my local machine I get 64 findbugs errors. These are not shown on the staged site. According to my local findbugs report 572 classes have been checked while the report on the published site only has 200 classes. I only had a short glance at these errors, but they do not seem to be too problematic. There are 200 classes in target/classes (this includes examples). There are 52 classes under target/test-classes - these are not included in the Findbugs configuration. The other 320 classes perhaps come from running Clover? No idea where they come from. I also have only 202 classes under target/classes. However, the findbugs errors are reported in regular source classes. Oliver So +1 Oliver Am 10.05.2011 16:13, schrieb sebb: This is a vote to release Apache Commons NET 3.0 based on RC1. [ ] +1 release it [ ] +0 go ahead I don't care [ ] -1 no, do not release it because... tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/ (r1101459) site: http://people.apache.org/~sebb/NET_3_0_RC1/ The Javadocs (1.4.1) link does not work, nor does the download link. These will be fixed once the site is deployed. Archives (Maven and non-Maven) have been uploaded to: https://repository.apache.org/content/repositories/orgapachecommons-001/ Vote will remain open for at least 72 hours. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1102086 - in /incubator/ognl/trunk/src/java/org/apache/commons/ognl: ASTChain.java ASTCtor.java ASTList.java ASTMap.java ASTMethod.java ASTSequence.java ASTStaticMethod.java Expressio
Salut Olivier!!!
since AST* classes are generated by JavaCC, I suggest you to don't pay
so much attention on fixing this stuff, sorry for not having warned
before :(
Indeed, build process has to be reviewed in a way to include the
JavaCC plugin and remove generated classes from SCM.
I'll write a more detailed report tomorrow when I find spare time, now
off to bed, it has been a long day and tomorrow morning I'm waking up
at 6 o' clock :P
Thanks for your hard work!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Wed, May 11, 2011 at 10:56 PM, ol...@apache.org wrote:
Author: olamy
Date: Wed May 11 20:56:14 2011
New Revision: 1102086
URL: http://svn.apache.org/viewvc?rev=1102086view=rev
Log:
use StringBuilder rather than + operand for String concat
Modified:
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTChain.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTCtor.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTList.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTMap.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTMethod.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTSequence.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTStaticMethod.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ExpressionNode.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/NumericExpression.java
incubator/ognl/trunk/src/java/org/apache/commons/ognl/ParseException.java
Modified: incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTChain.java
URL:
http://svn.apache.org/viewvc/incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTChain.java?rev=1102086r1=1102085r2=1102086view=diff
==
--- incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTChain.java
(original)
+++ incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTChain.java Wed
May 11 20:56:14 2011
@@ -258,19 +258,19 @@ public class ASTChain extends SimpleNode
public String toString()
{
- String result = ;
+ StringBuilder result = new StringBuilder();
if ((_children != null) (_children.length 0)) {
for(int i = 0; i _children.length; i++) {
if (i 0) {
if (!(_children[i] instanceof ASTProperty) ||
!((ASTProperty) _children[i]).isIndexedAccess()) {
- result = result + .;
+ result.append(.);
}
}
- result += _children[i].toString();
+ result.append(_children[i].toString());
}
}
- return result;
+ return result.toString();
}
public String toGetSourceString(OgnlContext context, Object target)
Modified: incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTCtor.java
URL:
http://svn.apache.org/viewvc/incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTCtor.java?rev=1102086r1=1102085r2=1102086view=diff
==
--- incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTCtor.java
(original)
+++ incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTCtor.java Wed
May 11 20:56:14 2011
@@ -129,27 +129,27 @@ public class ASTCtor extends SimpleNode
public String toString()
{
- String result = new + className;
+ StringBuilder result = new StringBuilder(new ).append(className);
if (isArray) {
if (_children[0] instanceof ASTConst) {
- result = result + [ + _children[0] + ];
+ result.append([).append(_children[0]).append(]);
} else {
- result = result + [] + _children[0];
+ result.append([] ).append(_children[0]);
}
} else {
- result = result + (;
+ result.append(();
if ((_children != null) (_children.length 0)) {
for(int i = 0; i _children.length; i++) {
if (i 0) {
- result = result + , ;
+ result.append(, );
}
- result = result + _children[i];
+ result.append(_children[i]);
}
}
- result = result + );
+ result.append());
}
- return result;
+ return result.toString();
}
public String toGetSourceString(OgnlContext context, Object target)
Modified: incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTList.java
URL:
http://svn.apache.org/viewvc/incubator/ognl/trunk/src/java/org/apache/commons/ognl/ASTList.java?rev=1102086r1=1102085r2=1102086view=diff
==
---
Re: svn commit: r1102086 - in /incubator/ognl/trunk/src/java/org/apache/commons/ognl: ASTChain.java ASTCtor.java ASTList.java ASTMap.java ASTMethod.java ASTSequence.java ASTStaticMethod.java Expressio
On 11 May 2011 22:14, Simone Tripodi simonetrip...@apache.org wrote: Salut Olivier!!! since AST* classes are generated by JavaCC, I suggest you to don't pay so much attention on fixing this stuff, sorry for not having warned before :( Indeed, build process has to be reviewed in a way to include the JavaCC plugin and remove generated classes from SCM. Have a look at the JEXL pom - that uses JavaCC. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 249 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-scxml-test : Apache Commons Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -WARNING- Overriding Maven settings: [/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml] -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/scxml/pom.xml -INFO- Project Reports in: /srv/gump/public/workspace/apache-commons/scxml/target/surefire-reports The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/gump_work/build_apache-commons_commons-scxml-test.html Work Name: build_apache-commons_commons-scxml-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 secs Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml test [Working Directory: /srv/gump/public/workspace/apache-commons/scxml] M2_HOME: /opt/maven2 - --- T E S T S --- Running org.apache.commons.scxml.invoke.InvokeTestSuite Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.471 sec Running org.apache.commons.scxml.test.TestingTestSuite Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec Running org.apache.commons.scxml.env.EnvTestSuite Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.16 sec Running org.apache.commons.scxml.SCXMLTestSuite Tests run: 71, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.917 sec FAILURE! Running org.apache.commons.scxml.issues.IssuesTestSuite Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec Running org.apache.commons.scxml.model.ModelTestSuite Tests run: 78, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.198 sec FAILURE! Running org.apache.commons.scxml.env.faces.EnvFacesTestSuite Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running org.apache.commons.scxml.semantics.SemanticsTestSuite Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.commons.scxml.env.jsp.EnvJspTestSuite Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.052 sec Running org.apache.commons.scxml.env.jexl.EnvJexlTestSuite Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec Running org.apache.commons.scxml.env.servlet.EnvServletTestSuite Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.scxml.io.IOTestSuite Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.334 sec Results : Failed tests: testNamespacePrefixedXPathsEL(org.apache.commons.scxml.NamespacePrefixedXPathsTest) testDatamodelSimultaneousJsp(org.apache.commons.scxml.model.DatamodelTest) Tests run: 228, Failures: 2, Errors: 0, Skipped: 0 [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] There are test failures. Please refer to /srv/gump/public/workspace/apache-commons/scxml/target/surefire-reports for the individual test results. [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 17 seconds [INFO] Finished at: Thu May 12 04:46:00 UTC 2011 [INFO] Final Memory: 25M/61M [INFO] - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/rss.xml - Atom: http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 1312052011, vmgump.apache.org:vmgump:1312052011 Gump E-mail Identifier (unique within
Re: feedparser little bugfix
Bear in mind however that feedparser is in 'Dormant' (meaning not
being worked on). I doubt it's likely to become active again.
Hen
On Wed, May 11, 2011 at 9:55 AM, sebb seb...@gmail.com wrote:
On 11 May 2011 17:08, Diego Peroni diegoper...@vodafone.it wrote:
Hi,
I've fixed a bug in org.apache.commons.feedparser.MetaFeedParser.java to
allow correct date parsing in case of presence of white spaces before or
after the date string.
Bugs should normally be reported via JIRA issues please.
http://commons.apache.org/dormant/feedparser/issue-tracking.html
This means they are less likely to be forgotten.
try {
//ok. Support dc:date
//String v = state.current.getChildText( name, ns );
String v = state.current.getChild( name, ns ).getTextTrim(); //
fix
if ( v != null ) {
Date d = null;
if ( ISO8601 ) {
d = ISO8601DateParser.parse( v );
} else {
d = RFC822DateParser.parse( v );
}
listener.onCreated( state, d );
listener.onCreatedEnd();
return true;
}
} catch ( Throwable t ) {
// ignore the exception, so we can just move on
}
return false;
}
Best regards
Diego Peroni
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 71 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-proxy-test : Apache Commons Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -WARNING- Overriding Maven settings: [/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml] -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/proxy/pom.xml -INFO- Project Reports in: /srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/gump_work/build_apache-commons_commons-proxy-test.html Work Name: build_apache-commons_commons-proxy-test (Type: Build) Work ended in a state of : Failed Elapsed: 11 secs Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml test [Working Directory: /srv/gump/public/workspace/apache-commons/proxy] M2_HOME: /opt/maven2 - Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.factory.util.TestMethodSignature Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.provider.TestConstantProvider Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec Running org.apache.commons.proxy.interceptor.TestFilteredInterceptor Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.045 sec Running org.apache.commons.proxy.interceptor.filter.TestPatternFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Running org.apache.commons.proxy.interceptor.TestSerializingInterceptor Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec Running org.apache.commons.proxy.interceptor.TestInterceptorChain Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running org.apache.commons.proxy.invoker.TestNullInvoker Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec Running org.apache.commons.proxy.provider.remoting.TestBurlapProvider Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec Running org.apache.commons.proxy.exception.TestDelegateProviderException Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running org.apache.commons.proxy.invoker.TestChainInvoker Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory Tests run: 37, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.158 sec Running org.apache.commons.proxy.exception.TestProxyFactoryException Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.interceptor.filter.TestReturnTypeFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec Running org.apache.commons.proxy.provider.TestBeanProvider Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec Results : Tests in error: testInvalidHandlerName(org.apache.commons.proxy.invoker.TestXmlRpcInvoker) Tests run: 179, Failures: 0, Errors: 1, Skipped: 0 [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] There are test failures. Please refer to /srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports for the individual test results. [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 10 seconds [INFO] Finished at: Thu May 12 05:38:56 UTC 2011 [INFO] Final Memory: 24M/58M [INFO] - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/rss.xml - Atom:
