Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0 based on RC3
Hello. Le dim. 15 août 2021 à 03:54, Matt Juntunen a écrit : > > We have completed initial development work on Apache Commons Geometry, > so I would like to release Apache Commons Geometry (full distribution) > 1.0. > > Apache Commons Geometry (full distribution) 1.0 RC3 is available for > review here: > https://dist.apache.org/repos/dist/dev/commons/geometry/1.0-RC3 > (svn revision 49503) Build environment: $ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64/ mvn --version Apache Maven 3.6.0 Maven home: /usr/share/maven Java version: 1.8.0_292, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.19.0-16-amd64", arch: "amd64", family: "unix" Tag checked $ git tag -v commons-geometry-1.0-beta1-rc3 object c47308d13c371652d9798037b390676c13564e48 [...] Primary key fingerprint: 7DD5 3AEF EDF1 C3D3 92B5 1EBE 346F 4FCE CFB7 0B1A Checksums OK. Javadoc warnings: ---CUT--- 1 warning [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-core/src/main/java/org/apache/commons/geometry/core/partitioning/bsp/AbstractBSPTree.java:178: warning - #DEFAULT_TREE_STRING_MAX_DEPTH (referenced by @value tag) is an unknown reference. [...] 2 warnings [WARNING] Javadoc Warnings [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/mesh/SimpleTriangleMesh.java:454: warning - Tag @link: reference not found: Precision.DoubleEquivalence [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/shape/Sphere.java:172: warning - Tag @link: reference not found: RegionBSPTree3D.PartitionedRegionBuilder3D [...] 1 warning [WARNING] Javadoc Warnings [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/twod/GreatCircles.java:109: warning - Tag @see: can't find fromPoints(Point2S, Point2S, org.apache.commons.geometry.core.precision.Precision.DoubleEquivalence) in org.apache.commons.geometry.spherical.twod.GreatCircles [...] 6 warnings [WARNING] Javadoc Warnings [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/internal/CharReadBuffer.java:211: warning - #EOF (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/internal/CharReadBuffer.java:131: warning - #EOF (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/internal/CharReadBuffer.java:162: warning - #EOF (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/internal/CharReadBuffer.java:211: warning - #EOF (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/utils/AbstractTextFormatWriter.java:63: warning - #DEFAULT_LINE_SEPARATOR (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-core/src/main/java/org/apache/commons/geometry/io/core/internal/CharReadBuffer.java:211: warning - #EOF (referenced by @value tag) is an unknown reference. [...] 11 warnings [WARNING] Javadoc Warnings [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-euclidean/src/main/java/org/apache/commons/geometry/io/euclidean/threed/obj/ObjBoundaryWriteHandler3D.java:82: warning - #DEFAULT_LINE_SEPARATOR (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-euclidean/src/main/java/org/apache/commons/geometry/io/euclidean/threed/obj/ObjBoundaryWriteHandler3D.java:114: warning - #DEFAULT_MESH_BUFFER_BATCH_SIZE (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-euclidean/src/main/java/org/apache/commons/geometry/io/euclidean/threed/obj/ObjBoundaryWriteHandler3D.java:124: warning - #DEFAULT_MESH_BUFFER_BATCH_SIZE (referenced by @value tag) is an unknown reference. [WARNING] /home/gilles/devel/java/apache/release_check/commons-geometry-1.0-rc3/commons-geometry-io-euclidean/src/main/java/org/apache/comm
Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0 based on RC3
Hi Matt, Another partial review here as I found a potential issue: In core: core.partitioning.bsp.AbstractBSPTree The inner class 'AbstractNode, N extends AbstractNode>' has a depth property and a depth() method so is flagged by PMD. No real issue here but the depth() method does lazy loading of the depth if it is unknown (i.e. -1). However if the parent is null then this will repeat each time as the value is never computed and remains at -1. This applies to the root of the tree. In this case the depth method is documented as returning 0 but it will return -1. Any children will have their depth incorrect by 1. Is this a bug? I found elsewhere that the depth is set to 0 in the makeRoot() method. So perhaps this never manifests in your code. However since the class is public it can be overridden and perhaps used differently where the depth would be -1 for a root node. Alex --- Builds from the tag with: mvn clean verify *Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)* Maven home: /usr/local/apache-maven-3.6.3 Java version: 11.0.12, vendor: Eclipse Foundation, runtime: /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "11.5", arch: "x86_64", family: "mac" Builds from the source zip using: mvn clean verify site site:stage *Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)* Maven home: /usr/local/apache-maven-3.6.3 Java version: 1.8.0_301, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_301.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" NOTICE.txt contains 2021. Test coverage is great at nearly 100%. There are a few lines that do not get executed in the spherical.twod package for some edge cases. No issues with Spotbugs. No major issues with PMD. Most of the issues should be easy to address, others can be ignored (god class, complexity rules). You have some public method getters returning boolean that start 'getXXX' rather than 'isXXX'. If this code style is consistent through the project then you can disable BooleanGetMethodName. It is found at least here: io/euclidean/threed/obj/AbstractObjPolygonReader.java io/euclidean/threed/obj/PolygonObjParser.java Releasing an API with a mix of getXXX and isXXX is not desirable. You have a few AvoidLiteralsInConditions when comparing double values to 0.0. You can get rid of these by using 0 in the condition or updating the rule to allow 0.0 as a magic number (untested but it should work). There are many private classes with private constructors or members that are used from outside the class. These can be made package private which should be more performant. This should use a locale for string conversion (e.g. Locale.ROOT): io/core/BoundaryIOManager.html#L484 Since this is used internally just for map keys it is not a blocker. User Guide: The equals() vs eq() section should highlight if -0.0 is equal to 0.0 (which is a recurrent issue with the IEEE float format depending on the context). The final code example should put a space after the '//' in this line: Point2S ptA = a.intersection(b); //(pi, pi/2)
Re: [MATH][DESIGN] Design Discussion for Genetic Algorithm Library
Le dim. 15 août 2021 à 15:48, Avijit Basak a écrit : > > Hi > > As mentioned earlier I need to use descriptive statistics in > *genetics* module as part of *math4* release. This will be required for > checking convergence status, probability generation. This can also be used > for streaming current population conditions to interested listeners. > Currently, we have a DescriptiveStatistics class as part of math4.legacy > module. Is there any plan to develop a new statistics module like neuralnet > and genetics? Not exactly: Refactored statistics utilities should find a home in the the new "Commons Statistics" component.[1] > If not what is the way to proceed forward. Kindly guide me in > this regard. There are several ways forward: 1. You contribute to start work on a "commons-statistics-descriptive" maven module in the component mentioned above. ["Commons Math" can depend on that component's modules.] 2. You make modifications to the GA functionality inside the current "o.a.c.m.legacy.genetics" package. [I'd still advise that we define interfaces to whatever functionality (like descriptive statistics) should ultimately be implemented somewhere else.] 3. You create a new "commons-math-ga" module that does not depend on the "commons-math-legacy" module. [That would imply creating an "internal" package (where you can copy anything you need) whose contents will not be part of the official API (i.e. users must not rely on it being stable across even minor releases).] Regards, Gilles [1] https://commons.apache.org/proper/commons-statistics - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [MATH][DESIGN] Design Discussion for Genetic Algorithm Library
Hi As mentioned earlier I need to use descriptive statistics in *genetics* module as part of *math4* release. This will be required for checking convergence status, probability generation. This can also be used for streaming current population conditions to interested listeners. Currently, we have a DescriptiveStatistics class as part of math4.legacy module. Is there any plan to develop a new statistics module like neuralnet and genetics? If not what is the way to proceed forward. Kindly guide me in this regard. Thanks & Regards --Avijit Basak On Sun, 8 Aug 2021 at 19:14, Gilles Sadowski wrote: > Hello. > > Le dim. 8 août 2021 à 07:22, Avijit Basak a > écrit : > > > > Hi All > > > > I have started to work in genetic module. > > Great! > > > I want to push the new > > module as part of a new feature branch "*feature/MATH-1563*". Changes > > include mostly the existing code and modfication due to the new Exception > > class. I have encountered the following error which indicates my Github > Id " > > *avijitbasak*" is not permitted to check-in code in the repository. > > Indeed, not all GitHub users are allowed to modify an ASF's project > repository. ;-) > > > Could > > anyone kindly grant me access to the repository. Let me know if I need to > > do anything else regarding this. > > Only ASF committers[1] are given write access. > For a contributor who is not (yet) a committer, the (nowadays[2]) usual way > to suggest changes is through GitHub pull requests (i.e. you have to > "clone" > the repository into your projects' GH space and modify there). > > Regards, > Gilles > > [1] https://www.apache.org/foundation/how-it-works.html#roles > [2] The alternative is uploading patches to the issue-tracking system: > https://commons.apache.org/patches.html > > > [...] > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- Avijit Basak
[NOTICE] - Moving and Upgrading of Buildbot Jobs
Hi All. This NOTICE goes out via BCC to all affected projects and to the main bui...@apache.org mailing list. Please have replies CC the builds list. https://ci.apache.org is currently on version 0.8 and is to be turned off soon. https://ci2.apache.org is version 3.2 and is the direct replacement. If you project has Buildbot jobs they are listed here: https://cwiki.apache.org/confluence/display/INFRA/Buildbot+0.8+-%3E+3.2+Migration Infra will perform the migration for you over the next 2 weeks. Starting Monday. Your $project.conf code will be updated to be compatible with Buildbot 3.2 (from 0.8) Unless you state otherwise - your config will be moved to a new SVN [1] or GIT [2] area depending on whether you primarily use SVN or GIT. [1] - https://svn.apache.org/repos/infra/infrastructure/buildbot2 [2] - https://github.com/apache/infrastructure-bb2 An INFRA ticket will be created for each project migration and your dev list will be kept in the loop. For those of you with nightly builds that use ci.apache.org/projects/* - please note that this service is deprecated and will NOT be available going forward. Instead, your jobs should be changed to upload to https://nightlies.apache.org/$project/* instead. Please request if you want your existing content migrated over otherwise we will not do so. After migration: Once everybody is off of the old Buildbot 0.8 - we will change ci.apache.org to point to the new 3.2 instance. We will also put in a redirect for ci.apache.org/projects/$project/* to point to your new location at nightlies.apache.org/$project/* Please let us know if you have any questions. Either Drew Foulks or myself will perform your migration. Kind Regards. -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
Re: [VOTE] Release Apache Commons Pool 2.11.1 based on RC1
[x] +1 Release these artifacts Building OK from tag, with `clean test install` targets. Building OK from tag, with `site:site` targets Site reports look good. Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: /opt/apache-maven-3.8.1 Java version: 1.8.0_275, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac" Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: /opt/apache-maven-3.8.1 Java version: 16, vendor: Oracle Corporation, runtime: /Users/abernal/Library/Java/JavaVirtualMachines/openjdk-16/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: “Mac" Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: /opt/apache-maven-3.8.1 Java version: 11.0.5, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-11.0.5.jdk/Contents/Home Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: “mac" System Version: macOS 11.5.1 (20G80) Kernel Version: Darwin 20.6.0 Arturo Bernal arturobern...@yahoo.com > On 14 Aug 2021, at 20:32, Matt Sicker wrote: > > +1 > > Verified signatures and builds via a few JDKs: > > Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f) > Maven home: /usr/local/Cellar/maven/3.8.2/libexec > Java version: 11.0.10, vendor: Oracle Corporation, runtime: > /usr/local/Cellar/openjdk@11/11.0.10/libexec/openjdk.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac" > > Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f) > Maven home: /usr/local/Cellar/maven/3.8.2/libexec > Java version: 16.0.2, vendor: Homebrew, runtime: > /usr/local/Cellar/openjdk/16.0.2/libexec/openjdk.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac" > > Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f) > Maven home: /usr/local/Cellar/maven/3.8.2/libexec > Java version: 17-ea, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "11.4", arch: "x86_64", family: "mac" > > On Sat, Aug 14, 2021 at 9:13 AM Gary Gregory wrote: >> >> We have fixed a few regression bugs since Apache Commons Pool 2.11.0 >> was released and performed some internal cleanups, so I would like to >> release Apache Commons Pool 2.11.1. >> >> Apache Commons Pool 2.11.1 RC1 is available for review here: >>https://dist.apache.org/repos/dist/dev/commons/pool/2.11.1-RC1 >> (svn revision 49499) >> >> The Git tag commons-pool-2.11.1-RC1 commit for this RC is >> abb1a0797b406566f0214c688871ab7e8fdc2601 which you can browse here: >> >> https://gitbox.apache.org/repos/asf?p=commons-pool.git;a=commit;h=abb1a0797b406566f0214c688871ab7e8fdc2601 >> You may checkout this tag using: >>git clone https://gitbox.apache.org/repos/asf/commons-pool.git >> --branch commons-pool-2.11.1-RC1 commons-pool-2.11.1-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1563/org/apache/commons/commons-pool2/2.11.1/ >> >> These are the artifacts and their hashes: >> >> #Release SHA-512s >> #Sat Aug 14 09:59:47 EDT 2021 >> commons-pool2-2.11.1-bin.tar.gz=04da8f6ab10df0d3bf8d458ae9c8810c55f99dd6ad5e1a98ed084adbdc09c99114985cc4311c0f3e336c01a7e3569d9311712a8a8e5144fab94a17d5b33c7dbc >> commons-pool2-2.11.1-bin.zip=b6a4fdf8bf0368372ca57d741542e842339ff6f2a5ba452b1179e9a6cf139224169100593be166d655d0d1d04be596822fc72a0086b9d585421db628d1898091 >> commons-pool2-2.11.1-javadoc.jar=cff2a69aa7b2864fb813adce2ff8c05a89a5e2d979bc8f213f2cc987f99ef9b4f0050ef91d9ecb5270fa17e42afc77f292b5725a7419b46bf60eacad3286f771 >> commons-pool2-2.11.1-sources.jar=e7b2d88c3e17d7be9e0c39215912516381ef46d141f2f17797bbcfc01da61b41d549f91767e856a32c00e227e78e4d23fe02f23903b3a470656f0a24175a973b >> commons-pool2-2.11.1-src.tar.gz=5550418757f6614e00af54aa9483c46a25b2f92f207c90c6dbea0269dd318a80f55a62c7348076bd7719fc948b778a35c952d4f92e7a43e8b1d0bc76e06e92a0 >> commons-pool2-2.11.1-src.zip=bc75da13acb020096b871b461fd4b9112917cd3b3c3bc0e45cd74b808796ce6f89863aafffcec025ee07d9ac04e4d4f738977220bbb1107f24621011cfede708 >> commons-pool2-2.11.1-test-sources.jar=ba3ef9fcbb8b25cb18de9b28322fe888c3b1e78cb845787f667c691b7ad0f7d25314c2eaceca542a50e77c0e0960be0344fef6501ddef55c3a3e66a966c57e6b >> commons-pool2-2.11.1-tests.jar=1fbdfda9ecd8917e18c06d9a48dd5d139449b8c9ae3b64fc1655f642d27853d73989edea9630e9bd50466afba91b9adc29138a0fcb996eb05ffd30d506112236 >> >> >> I have tested this with >> mvn -V -Prelease -Ptest-deploy -P jacoco -P
