[daemon] : fixing some general stuff
Hi All, I'm going through apache daemon code and trying to fix the stuff breaking with below maven options, also would like to know if some more checks can be added since this repo contains lot of C code. mvn clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc couple of things I'd like to discuss and get opinion. #1. TESTS: No test cases present, adding some could be a good add [at least for java code], not idea about C code. #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE LICENSE but I found they already have GPLv3 in them, shall we replace them, or we need consent ? src/native/unix/support/config.sub src/native/unix/support/config.guess src/native/unix/native/.indent.pro #3. CLIRR : building good. #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them down one by one, no big deal. #5 FINDBUG: 4 bugs, no big deal. #6. JAVADOC: Few bugs, again no big deal. Regards, Amey - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [daemon] : fixing some general stuff
Hello, I think the autoconf related files are generated by GNU tools and cannot be re-licensed. They are not in the binary packages but they do contaminate the source archives. It is not yet mentioned in the NOTICE file but I guess there is a ASF wide regulation for those build scripts. Does anybody know? Thanks for looking at the issues, would be good if you commit smaller batches more often, since there is generally some more interest in the project currently. If you want I can help with the Javadoc warnings? Gruss Bernd -- http://bernd.eckenfels.net From: Amey Jadiye Sent: Sunday, July 9, 2017 4:00:08 PM To: Commons Developers List Subject: [daemon] : fixing some general stuff Hi All, I'm going through apache daemon code and trying to fix the stuff breaking with below maven options, also would like to know if some more checks can be added since this repo contains lot of C code. mvn clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc couple of things I'd like to discuss and get opinion. #1. TESTS: No test cases present, adding some could be a good add [at least for java code], not idea about C code. #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE LICENSE but I found they already have GPLv3 in them, shall we replace them, or we need consent ? src/native/unix/support/config.sub src/native/unix/support/config.guess src/native/unix/native/.indent.pro #3. CLIRR : building good. #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them down one by one, no big deal. #5 FINDBUG: 4 bugs, no big deal. #6. JAVADOC: Few bugs, again no big deal. Regards, Amey - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [daemon] : fixing some general stuff
On 9 July 2017 15:00:08 BST, Amey Jadiye wrote: >#2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE >LICENSE >but I found they already have GPLv3 in them, shall we replace them, or >we >need consent ? >src/native/unix/support/config.sub >src/native/unix/support/config.guess >src/native/unix/native/.indent.pro Leave them alone. Exclude them from RAT. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [daemon] : fixing some general stuff
Thanks Bernd, I had plan B for those crying rat, will put those files to exclusion of checking. I can take care of checkstyle, findbug, javadoc. I'm more interested about test cases now. do we have any options around C code coverage with maven [ java code coverage is easy though], OR even is that required? Regards, Amey On Sun, Jul 9, 2017, 9:26 PM Bernd Eckenfels wrote: > Hello, > > I think the autoconf related files are generated by GNU tools and cannot > be re-licensed. They are not in the binary packages but they do contaminate > the source archives. It is not yet mentioned in the NOTICE file but I guess > there is a ASF wide regulation for those build scripts. Does anybody know? > > Thanks for looking at the issues, would be good if you commit smaller > batches more often, since there is generally some more interest in the > project currently. If you want I can help with the Javadoc warnings? > > Gruss > Bernd > -- > http://bernd.eckenfels.net > > From: Amey Jadiye > Sent: Sunday, July 9, 2017 4:00:08 PM > To: Commons Developers List > Subject: [daemon] : fixing some general stuff > > Hi All, > > I'm going through apache daemon code and trying to fix the stuff breaking > with below maven options, also would like to know if some more checks can > be added since this repo contains lot of C code. > > mvn clean verify apache-rat:check clirr:check checkstyle:check > findbugs:check javadoc:javadoc > > couple of things I'd like to discuss and get opinion. > > #1. TESTS: No test cases present, adding some could be a good add [at least > for java code], not idea about C code. > > #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE LICENSE > but I found they already have GPLv3 in them, shall we replace them, or we > need consent ? > src/native/unix/support/config.sub > src/native/unix/support/config.guess > src/native/unix/native/.indent.pro > > #3. CLIRR : building good. > > #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them down one > by one, no big deal. > > #5 FINDBUG: 4 bugs, no big deal. > > #6. JAVADOC: Few bugs, again no big deal. > > Regards, > Amey > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org >
Re: [daemon] : fixing some general stuff
Hi Bernd/Mark/All, I have raised PR to cover this, would you mind just take a look ? https://github.com/apache/commons-daemon/pull/3 So far I have fixed rat, findbug. I will push javadoc and checkstyle sometime tomorrow. Regards, Amey On Sun, Jul 9, 2017 at 9:34 PM, Amey Jadiye wrote: > Thanks Bernd, > > I had plan B for those crying rat, will put those files to exclusion of > checking. > > I can take care of checkstyle, findbug, javadoc. > > I'm more interested about test cases now. do we have any options around C > code coverage with maven [ java code coverage is easy though], OR even is > that required? > > Regards, > Amey > > > On Sun, Jul 9, 2017, 9:26 PM Bernd Eckenfels > wrote: > >> Hello, >> >> I think the autoconf related files are generated by GNU tools and cannot >> be re-licensed. They are not in the binary packages but they do contaminate >> the source archives. It is not yet mentioned in the NOTICE file but I guess >> there is a ASF wide regulation for those build scripts. Does anybody know? >> >> Thanks for looking at the issues, would be good if you commit smaller >> batches more often, since there is generally some more interest in the >> project currently. If you want I can help with the Javadoc warnings? >> >> Gruss >> Bernd >> -- >> http://bernd.eckenfels.net >> ________ >> From: Amey Jadiye >> Sent: Sunday, July 9, 2017 4:00:08 PM >> To: Commons Developers List >> Subject: [daemon] : fixing some general stuff >> >> Hi All, >> >> I'm going through apache daemon code and trying to fix the stuff breaking >> with below maven options, also would like to know if some more checks can >> be added since this repo contains lot of C code. >> >> mvn clean verify apache-rat:check clirr:check checkstyle:check >> findbugs:check javadoc:javadoc >> >> couple of things I'd like to discuss and get opinion. >> >> #1. TESTS: No test cases present, adding some could be a good add [at >> least >> for java code], not idea about C code. >> >> #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE >> LICENSE >> but I found they already have GPLv3 in them, shall we replace them, or we >> need consent ? >> src/native/unix/support/config.sub >> src/native/unix/support/config.guess >> src/native/unix/native/.indent.pro >> >> #3. CLIRR : building good. >> >> #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them down >> one >> by one, no big deal. >> >> #5 FINDBUG: 4 bugs, no big deal. >> >> #6. JAVADOC: Few bugs, again no big deal. >> >> Regards, >> Amey >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [daemon] : fixing some general stuff
Hi All, Its was quite tedious task but I have fixed almost all errors from the commons daemon from maven perspective and below default goals running clean, I would appreciate if someone take look at PR. https://github.com/apache/commons-daemon/pull/3 mvn clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc checkstyle:check :- 178 Errors, corrected all of them. javadoc:javadoc :- 20+ Error, corrected all of them. apache-rat:check :- 4 Errors, placed file in rat exclusion. findbugs:check :- 4 Errors, corrected all. clirr:check :- This was running good. for the junit test cases additions will open another jira to track. Regards, Amey On Mon, Jul 10, 2017 at 12:34 AM, Amey Jadiye wrote: > Hi Bernd/Mark/All, > > I have raised PR to cover this, would you mind just take a look ? > https://github.com/apache/commons-daemon/pull/3 > So far I have fixed rat, findbug. I will push javadoc and checkstyle > sometime tomorrow. > > Regards, > Amey > > On Sun, Jul 9, 2017 at 9:34 PM, Amey Jadiye wrote: > >> Thanks Bernd, >> >> I had plan B for those crying rat, will put those files to exclusion of >> checking. >> >> I can take care of checkstyle, findbug, javadoc. >> >> I'm more interested about test cases now. do we have any options around C >> code coverage with maven [ java code coverage is easy though], OR even is >> that required? >> >> Regards, >> Amey >> >> >> On Sun, Jul 9, 2017, 9:26 PM Bernd Eckenfels >> wrote: >> >>> Hello, >>> >>> I think the autoconf related files are generated by GNU tools and cannot >>> be re-licensed. They are not in the binary packages but they do contaminate >>> the source archives. It is not yet mentioned in the NOTICE file but I guess >>> there is a ASF wide regulation for those build scripts. Does anybody know? >>> >>> Thanks for looking at the issues, would be good if you commit smaller >>> batches more often, since there is generally some more interest in the >>> project currently. If you want I can help with the Javadoc warnings? >>> >>> Gruss >>> Bernd >>> -- >>> http://bernd.eckenfels.net >>> >>> From: Amey Jadiye >>> Sent: Sunday, July 9, 2017 4:00:08 PM >>> To: Commons Developers List >>> Subject: [daemon] : fixing some general stuff >>> >>> Hi All, >>> >>> I'm going through apache daemon code and trying to fix the stuff breaking >>> with below maven options, also would like to know if some more checks can >>> be added since this repo contains lot of C code. >>> >>> mvn clean verify apache-rat:check clirr:check checkstyle:check >>> findbugs:check javadoc:javadoc >>> >>> couple of things I'd like to discuss and get opinion. >>> >>> #1. TESTS: No test cases present, adding some could be a good add [at >>> least >>> for java code], not idea about C code. >>> >>> #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE >>> LICENSE >>> but I found they already have GPLv3 in them, shall we replace them, or we >>> need consent ? >>> src/native/unix/support/config.sub >>> src/native/unix/support/config.guess >>> src/native/unix/native/.indent.pro >>> >>> #3. CLIRR : building good. >>> >>> #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them down >>> one >>> by one, no big deal. >>> >>> #5 FINDBUG: 4 bugs, no big deal. >>> >>> #6. JAVADOC: Few bugs, again no big deal. >>> >>> Regards, >>> Amey >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> > > > -- > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [daemon] : fixing some general stuff
If maintainers are not around, can someone please review this ? Regards, Amey On Tue, Jul 11, 2017 at 11:51 PM, Amey Jadiye wrote: > Hi All, > > Its was quite tedious task but I have fixed almost all errors from the > commons daemon from maven perspective and below default goals running > clean, I would appreciate if someone take look at PR. > https://github.com/apache/commons-daemon/pull/3 > > mvn clean verify apache-rat:check clirr:check checkstyle:check > findbugs:check javadoc:javadoc > > checkstyle:check :- 178 Errors, corrected all of them. > javadoc:javadoc :- 20+ Error, corrected all of them. > apache-rat:check :- 4 Errors, placed file in rat exclusion. > findbugs:check :- 4 Errors, corrected all. > clirr:check :- This was running good. > > > for the junit test cases additions will open another jira to track. > > Regards, > Amey > > > > > On Mon, Jul 10, 2017 at 12:34 AM, Amey Jadiye > wrote: > >> Hi Bernd/Mark/All, >> >> I have raised PR to cover this, would you mind just take a look ? >> https://github.com/apache/commons-daemon/pull/3 >> So far I have fixed rat, findbug. I will push javadoc and checkstyle >> sometime tomorrow. >> >> Regards, >> Amey >> >> On Sun, Jul 9, 2017 at 9:34 PM, Amey Jadiye wrote: >> >>> Thanks Bernd, >>> >>> I had plan B for those crying rat, will put those files to exclusion of >>> checking. >>> >>> I can take care of checkstyle, findbug, javadoc. >>> >>> I'm more interested about test cases now. do we have any options around >>> C code coverage with maven [ java code coverage is easy though], OR even is >>> that required? >>> >>> Regards, >>> Amey >>> >>> >>> On Sun, Jul 9, 2017, 9:26 PM Bernd Eckenfels >>> wrote: >>> >>>> Hello, >>>> >>>> I think the autoconf related files are generated by GNU tools and >>>> cannot be re-licensed. They are not in the binary packages but they do >>>> contaminate the source archives. It is not yet mentioned in the NOTICE file >>>> but I guess there is a ASF wide regulation for those build scripts. Does >>>> anybody know? >>>> >>>> Thanks for looking at the issues, would be good if you commit smaller >>>> batches more often, since there is generally some more interest in the >>>> project currently. If you want I can help with the Javadoc warnings? >>>> >>>> Gruss >>>> Bernd >>>> -- >>>> http://bernd.eckenfels.net >>>> >>>> From: Amey Jadiye >>>> Sent: Sunday, July 9, 2017 4:00:08 PM >>>> To: Commons Developers List >>>> Subject: [daemon] : fixing some general stuff >>>> >>>> Hi All, >>>> >>>> I'm going through apache daemon code and trying to fix the stuff >>>> breaking >>>> with below maven options, also would like to know if some more checks >>>> can >>>> be added since this repo contains lot of C code. >>>> >>>> mvn clean verify apache-rat:check clirr:check checkstyle:check >>>> findbugs:check javadoc:javadoc >>>> >>>> couple of things I'd like to discuss and get opinion. >>>> >>>> #1. TESTS: No test cases present, adding some could be a good add [at >>>> least >>>> for java code], not idea about C code. >>>> >>>> #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE >>>> LICENSE >>>> but I found they already have GPLv3 in them, shall we replace them, or >>>> we >>>> need consent ? >>>> src/native/unix/support/config.sub >>>> src/native/unix/support/config.guess >>>> src/native/unix/native/.indent.pro >>>> >>>> #3. CLIRR : building good. >>>> >>>> #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them down >>>> one >>>> by one, no big deal. >>>> >>>> #5 FINDBUG: 4 bugs, no big deal. >>>> >>>> #6. JAVADOC: Few bugs, again no big deal. >>>> >>>> Regards, >>>> Amey >>>> >>>> - >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>> >> >> >> -- >> >> - >> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > > -- > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [daemon] : fixing some general stuff
Reviewed. Gary On Thu, Jul 13, 2017 at 12:01 PM, Amey Jadiye wrote: > If maintainers are not around, can someone please review this ? > > Regards, > Amey > > On Tue, Jul 11, 2017 at 11:51 PM, Amey Jadiye > wrote: > > > Hi All, > > > > Its was quite tedious task but I have fixed almost all errors from the > > commons daemon from maven perspective and below default goals running > > clean, I would appreciate if someone take look at PR. > > https://github.com/apache/commons-daemon/pull/3 > > > > mvn clean verify apache-rat:check clirr:check checkstyle:check > > findbugs:check javadoc:javadoc > > > > checkstyle:check :- 178 Errors, corrected all of them. > > javadoc:javadoc :- 20+ Error, corrected all of them. > > apache-rat:check :- 4 Errors, placed file in rat exclusion. > > findbugs:check :- 4 Errors, corrected all. > > clirr:check :- This was running good. > > > > > > for the junit test cases additions will open another jira to track. > > > > Regards, > > Amey > > > > > > > > > > On Mon, Jul 10, 2017 at 12:34 AM, Amey Jadiye > > wrote: > > > >> Hi Bernd/Mark/All, > >> > >> I have raised PR to cover this, would you mind just take a look ? > >> https://github.com/apache/commons-daemon/pull/3 > >> So far I have fixed rat, findbug. I will push javadoc and checkstyle > >> sometime tomorrow. > >> > >> Regards, > >> Amey > >> > >> On Sun, Jul 9, 2017 at 9:34 PM, Amey Jadiye > wrote: > >> > >>> Thanks Bernd, > >>> > >>> I had plan B for those crying rat, will put those files to exclusion of > >>> checking. > >>> > >>> I can take care of checkstyle, findbug, javadoc. > >>> > >>> I'm more interested about test cases now. do we have any options around > >>> C code coverage with maven [ java code coverage is easy though], OR > even is > >>> that required? > >>> > >>> Regards, > >>> Amey > >>> > >>> > >>> On Sun, Jul 9, 2017, 9:26 PM Bernd Eckenfels > >>> wrote: > >>> > >>>> Hello, > >>>> > >>>> I think the autoconf related files are generated by GNU tools and > >>>> cannot be re-licensed. They are not in the binary packages but they do > >>>> contaminate the source archives. It is not yet mentioned in the > NOTICE file > >>>> but I guess there is a ASF wide regulation for those build scripts. > Does > >>>> anybody know? > >>>> > >>>> Thanks for looking at the issues, would be good if you commit smaller > >>>> batches more often, since there is generally some more interest in the > >>>> project currently. If you want I can help with the Javadoc warnings? > >>>> > >>>> Gruss > >>>> Bernd > >>>> -- > >>>> http://bernd.eckenfels.net > >>>> > >>>> From: Amey Jadiye > >>>> Sent: Sunday, July 9, 2017 4:00:08 PM > >>>> To: Commons Developers List > >>>> Subject: [daemon] : fixing some general stuff > >>>> > >>>> Hi All, > >>>> > >>>> I'm going through apache daemon code and trying to fix the stuff > >>>> breaking > >>>> with below maven options, also would like to know if some more checks > >>>> can > >>>> be added since this repo contains lot of C code. > >>>> > >>>> mvn clean verify apache-rat:check clirr:check checkstyle:check > >>>> findbugs:check javadoc:javadoc > >>>> > >>>> couple of things I'd like to discuss and get opinion. > >>>> > >>>> #1. TESTS: No test cases present, adding some could be a good add [at > >>>> least > >>>> for java code], not idea about C code. > >>>> > >>>> #2. RAT : apache-rat is crying for 4 files, it is ok to add APACHE > >>>> LICENSE > >>>> but I found they already have GPLv3 in them, shall we replace them, or > >>>> we > >>>> need consent ? > >>>> src/native/unix/support/config.sub > >>>> src/native/unix/support/config.guess > >>>> src/native/unix/native/.indent.pro > >>>> > >>>> #3. CLIRR : building good. > >>>> > >>>> #4. CHECKSTYLE: Hell lot of mess, 170+ errors, but I can take them > down > >>>> one > >>>> by one, no big deal. > >>>> > >>>> #5 FINDBUG: 4 bugs, no big deal. > >>>> > >>>> #6. JAVADOC: Few bugs, again no big deal. > >>>> > >>>> Regards, > >>>> Amey > >>>> > >>>> - > >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>>> For additional commands, e-mail: dev-h...@commons.apache.org > >>>> > >>> > >> > >> > >> -- > >> > >> - > >> > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > > > > > > > > -- > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > -- > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org >