Re: [commons-graph] branch master updated: Travis CI configuration.
Oh. Then I guess work in this thread is already done. Oh wait. You might need this: https://github.com/apache/commons-graph/pull/2 Gilles Sadowski 于2020年6月13日周六 上午10:11写道： > 2020-06-13 4:05 UTC+02:00, Xeno Amess : > >> This discussion requires another thread. > > > > Well I don't think so, as I think this thread aims for making travis-ci > can > > pass. > > No; this thread was about setting up Travis (as asked by Amey). > > > [...] > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [commons-graph] branch master updated: Travis CI configuration.
2020-06-13 4:05 UTC+02:00, Xeno Amess : >> This discussion requires another thread. > > Well I don't think so, as I think this thread aims for making travis-ci can > pass. No; this thread was about setting up Travis (as asked by Amey). > [...] - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [commons-graph] branch master updated: Travis CI configuration.
> This discussion requires another thread. Well I don't think so, as I think this thread aims for making travis-ci can pass. And test failures are the reason why it cannot pass ci for now. I don't see the value in creating another thread. Btw: I tested (if my memory are correct, as I didn't make a log for it) the latest commit (fail) , the first commit at year 2012(fail), the first commit of the repo(pass), the first commit of year2011month10(fail), the first commit of year2011month7(fail), and I tried every version from year2011month7 back, and finally I get the last commit that can pass all junit tests be 967b9bed79f51040597d68ef98512a24b0e94e41m ,which is just 3 hours after the repo created. Btw2: Is it a usual thing in commons, for a repo's branch master can never pass its own junit tests for years? I'm new here, knowing nearly nothing about commons, and become very confused. Btw3: And do the users of this repo know about this? Gilles Sadowski 于2020年6月13日周六 上午9:52写道： > 2020-06-13 1:43 UTC+02:00, Xeno Amess : > > Done. > > Environment win10, jdk8. > > Due to the binary search, the last pr in this repo who can pass all junit > > tests is commit 967b9bed79f51040597d68ef98512a24b0e94e41 , which is at > > 6/11/2011,10:43PM > > Suggest revert all changes after that time point, and track them one by > > one. > > This discussion requires another thread. > > Regards, > Gilles > > > A project which can never pass its own junit tests is > kindof.confusing. > > And me myself will never consider about using it. > > > > > > > > Xeno Amess 于2020年6月13日周六 上午7:27写道： > > > >> Two failures and one error actually. > >> I will try to fetch the latest commit who CAN pass junit test, using > >> binary search. > >> Will send mail when I finish. > >> > >> Gilles Sadowski 于2020年6月13日周六 上午6:21写道： > >> > >>> Hi. > >>> > >>> 2020-06-12 21:43 UTC+02:00, Amey Jadiye : > >>> > On Fri, Jun 12, 2020 at 4:40 PM Gilles Sadowski < > gillese...@gmail.com> > >>> > wrote: > >>> > > >>> >> 2020-06-12 12:32 UTC+02:00, Xeno Amess : > >>> >> > Hi. > >>> >> > I see the current travis-ci scripts. > >>> >> > Do we really care only jdk8? > >>> >> > Should we also add at some other jdk versions, at least adding > >>> >> > openjdk11, > >>> >> > as it is a stable version? > >>> >> > Or this repo has some known bug on jdk11? > >>> >> > > >>> >> > >>> >> Before refining, we should get[1] a first build: > >>> >> https://travis-ci.org/github/apache/commons-graph > >>> > > >>> > +1 > >>> > maybe you can check and merge my one upgrade PR to check this. > >>> > https://github.com/apache/commons-graph/pull/1 > >>> > >>> I've merged the changes to see that Travis is set up, > >>> even though some unit tests are in error: Please have > >>> a look. > >>> > >>> Thanks, > >>> Gilles > >>> > >>> > > >>> > I don't see it on Travis though, maybe because I raised it before > >>> > travis > >>> > setup. > >>> > > >>> > Regards, > >>> > Amey > >>> > > >>> >> > >>> >> > >>> >> Gilles > >>> >> > >>> >> [1] https://issues.apache.org/jira/browse/INFRA-20413 > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [commons-graph] branch master updated: Travis CI configuration.
2020-06-13 1:43 UTC+02:00, Xeno Amess : > Done. > Environment win10, jdk8. > Due to the binary search, the last pr in this repo who can pass all junit > tests is commit 967b9bed79f51040597d68ef98512a24b0e94e41 , which is at > 6/11/2011,10:43PM > Suggest revert all changes after that time point, and track them one by > one. This discussion requires another thread. Regards, Gilles > A project which can never pass its own junit tests is kindof.confusing. > And me myself will never consider about using it. > > > > Xeno Amess 于2020年6月13日周六 上午7:27写道： > >> Two failures and one error actually. >> I will try to fetch the latest commit who CAN pass junit test, using >> binary search. >> Will send mail when I finish. >> >> Gilles Sadowski 于2020年6月13日周六 上午6:21写道： >> >>> Hi. >>> >>> 2020-06-12 21:43 UTC+02:00, Amey Jadiye : >>> > On Fri, Jun 12, 2020 at 4:40 PM Gilles Sadowski >>> > wrote: >>> > >>> >> 2020-06-12 12:32 UTC+02:00, Xeno Amess : >>> >> > Hi. >>> >> > I see the current travis-ci scripts. >>> >> > Do we really care only jdk8? >>> >> > Should we also add at some other jdk versions, at least adding >>> >> > openjdk11, >>> >> > as it is a stable version? >>> >> > Or this repo has some known bug on jdk11? >>> >> > >>> >> >>> >> Before refining, we should get[1] a first build: >>> >> https://travis-ci.org/github/apache/commons-graph >>> > >>> > +1 >>> > maybe you can check and merge my one upgrade PR to check this. >>> > https://github.com/apache/commons-graph/pull/1 >>> >>> I've merged the changes to see that Travis is set up, >>> even though some unit tests are in error: Please have >>> a look. >>> >>> Thanks, >>> Gilles >>> >>> > >>> > I don't see it on Travis though, maybe because I raised it before >>> > travis >>> > setup. >>> > >>> > Regards, >>> > Amey >>> > >>> >> >>> >> >>> >> Gilles >>> >> >>> >> [1] https://issues.apache.org/jira/browse/INFRA-20413 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [commons-graph] branch master updated: Travis CI configuration.
Done. Environment win10, jdk8. Due to the binary search, the last pr in this repo who can pass all junit tests is commit 967b9bed79f51040597d68ef98512a24b0e94e41 , which is at 6/11/2011,10:43PM Suggest revert all changes after that time point, and track them one by one. A project which can never pass its own junit tests is kindof.confusing. And me myself will never consider about using it. Xeno Amess 于2020年6月13日周六 上午7:27写道： > Two failures and one error actually. > I will try to fetch the latest commit who CAN pass junit test, using > binary search. > Will send mail when I finish. > > Gilles Sadowski 于2020年6月13日周六 上午6:21写道： > >> Hi. >> >> 2020-06-12 21:43 UTC+02:00, Amey Jadiye : >> > On Fri, Jun 12, 2020 at 4:40 PM Gilles Sadowski >> > wrote: >> > >> >> 2020-06-12 12:32 UTC+02:00, Xeno Amess : >> >> > Hi. >> >> > I see the current travis-ci scripts. >> >> > Do we really care only jdk8? >> >> > Should we also add at some other jdk versions, at least adding >> >> > openjdk11, >> >> > as it is a stable version? >> >> > Or this repo has some known bug on jdk11? >> >> > >> >> >> >> Before refining, we should get[1] a first build: >> >> https://travis-ci.org/github/apache/commons-graph >> > >> > +1 >> > maybe you can check and merge my one upgrade PR to check this. >> > https://github.com/apache/commons-graph/pull/1 >> >> I've merged the changes to see that Travis is set up, >> even though some unit tests are in error: Please have >> a look. >> >> Thanks, >> Gilles >> >> > >> > I don't see it on Travis though, maybe because I raised it before travis >> > setup. >> > >> > Regards, >> > Amey >> > >> >> >> >> >> >> Gilles >> >> >> >> [1] https://issues.apache.org/jira/browse/INFRA-20413 >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>
Re: [commons-graph] branch master updated: Travis CI configuration.
Two failures and one error actually. I will try to fetch the latest commit who CAN pass junit test, using binary search. Will send mail when I finish. Gilles Sadowski 于2020年6月13日周六 上午6:21写道： > Hi. > > 2020-06-12 21:43 UTC+02:00, Amey Jadiye : > > On Fri, Jun 12, 2020 at 4:40 PM Gilles Sadowski > > wrote: > > > >> 2020-06-12 12:32 UTC+02:00, Xeno Amess : > >> > Hi. > >> > I see the current travis-ci scripts. > >> > Do we really care only jdk8? > >> > Should we also add at some other jdk versions, at least adding > >> > openjdk11, > >> > as it is a stable version? > >> > Or this repo has some known bug on jdk11? > >> > > >> > >> Before refining, we should get[1] a first build: > >> https://travis-ci.org/github/apache/commons-graph > > > > +1 > > maybe you can check and merge my one upgrade PR to check this. > > https://github.com/apache/commons-graph/pull/1 > > I've merged the changes to see that Travis is set up, > even though some unit tests are in error: Please have > a look. > > Thanks, > Gilles > > > > > I don't see it on Travis though, maybe because I raised it before travis > > setup. > > > > Regards, > > Amey > > > >> > >> > >> Gilles > >> > >> [1] https://issues.apache.org/jira/browse/INFRA-20413 > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [commons-graph] branch master updated: Travis CI configuration.
Hi. 2020-06-12 21:43 UTC+02:00, Amey Jadiye : > On Fri, Jun 12, 2020 at 4:40 PM Gilles Sadowski > wrote: > >> 2020-06-12 12:32 UTC+02:00, Xeno Amess : >> > Hi. >> > I see the current travis-ci scripts. >> > Do we really care only jdk8? >> > Should we also add at some other jdk versions, at least adding >> > openjdk11, >> > as it is a stable version? >> > Or this repo has some known bug on jdk11? >> > >> >> Before refining, we should get[1] a first build: >> https://travis-ci.org/github/apache/commons-graph > > +1 > maybe you can check and merge my one upgrade PR to check this. > https://github.com/apache/commons-graph/pull/1 I've merged the changes to see that Travis is set up, even though some unit tests are in error: Please have a look. Thanks, Gilles > > I don't see it on Travis though, maybe because I raised it before travis > setup. > > Regards, > Amey > >> >> >> Gilles >> >> [1] https://issues.apache.org/jira/browse/INFRA-20413 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [commons-graph] branch master updated: Travis CI configuration.
On Fri, Jun 12, 2020 at 4:40 PM Gilles Sadowski wrote: > 2020-06-12 12:32 UTC+02:00, Xeno Amess : > > Hi. > > I see the current travis-ci scripts. > > Do we really care only jdk8? > > Should we also add at some other jdk versions, at least adding openjdk11, > > as it is a stable version? > > Or this repo has some known bug on jdk11? > > > > Before refining, we should get[1] a first build: > https://travis-ci.org/github/apache/commons-graph +1 maybe you can check and merge my one upgrade PR to check this. https://github.com/apache/commons-graph/pull/1 I don't see it on Travis though, maybe because I raised it before travis setup. Regards, Amey > > > Gilles > > [1] https://issues.apache.org/jira/browse/INFRA-20413 > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [commons-graph] branch master updated: Travis CI configuration.
On Fri, 12 Jun 2020 at 12:10, Gilles Sadowski wrote: > 2020-06-12 12:32 UTC+02:00, Xeno Amess : > > Hi. > > I see the current travis-ci scripts. > > Do we really care only jdk8? > > Should we also add at some other jdk versions, at least adding openjdk11, > > as it is a stable version? > > Or this repo has some known bug on jdk11? > > > > Before refining, we should get[1] a first build: > https://travis-ci.org/github/apache/commons-graph > > Gilles > > [1] https://issues.apache.org/jira/browse/INFRA-20413 Thanks for that. I was just drafting a similar request. I think I have enabled coveralls (I seemed to have permissions). I cannot do Travis CI. > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [commons-graph] branch master updated: Travis CI configuration.
2020-06-12 12:32 UTC+02:00, Xeno Amess : > Hi. > I see the current travis-ci scripts. > Do we really care only jdk8? > Should we also add at some other jdk versions, at least adding openjdk11, > as it is a stable version? > Or this repo has some known bug on jdk11? > Before refining, we should get[1] a first build: https://travis-ci.org/github/apache/commons-graph Gilles [1] https://issues.apache.org/jira/browse/INFRA-20413 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [commons-graph] branch master updated: Travis CI configuration.
On Fri, 12 Jun 2020 at 11:33, Xeno Amess wrote: > Hi. > I see the current travis-ci scripts. > Do we really care only jdk8? > Should we also add at some other jdk versions, at least adding openjdk11, > as it is a stable version? > Or this repo has some known bug on jdk11? > Targeting the LTS java versions would be ideal. Note that this is a project recently promoted from the sandbox. It requires work to modernise it and at present the focus is on maven modularisation. This script is a preliminary config to get started. Currently the project is not recognised by travis or coveralls. I've attempted to activate coveralls which I appear to have permissions to do [1]. I cannot add the project to Travis CI. When the project has been reorganised and is fully integrated into the gitbox/github environment any contributions would be welcome. [1] https://coveralls.io/github/apache/commons-graph
Re: [commons-graph] branch master updated: Travis CI configuration.
Hi. I see the current travis-ci scripts. Do we really care only jdk8? Should we also add at some other jdk versions, at least adding openjdk11, as it is a stable version? Or this repo has some known bug on jdk11?
Re: [commons-graph] branch master updated: Travis CI configuration.
Hi. 2020-06-11 23:54 UTC+02:00, Alex Herbert : > > >> On 11 Jun 2020, at 18:07, er...@apache.org wrote: >> >> This is an automated email from the ASF dual-hosted git repository. >> >> erans pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/commons-graph.git >> >> >> The following commit(s) were added to refs/heads/master by this push: >> new b14766b Travis CI configuration. >> b14766b is described below >> >> commit b14766be60b3722007d19d015bc383e3d83d11b8 >> Author: Gilles Sadowski >> AuthorDate: Thu Jun 11 19:06:35 2020 +0200 >> >>Travis CI configuration. >> --- >> .travis.yml | 33 + >> 1 file changed, 33 insertions(+) >> >> diff --git a/.travis.yml b/.travis.yml >> new file mode 100644 >> index 000..709f9ba >> --- /dev/null >> +++ b/.travis.yml >> @@ -0,0 +1,33 @@ >> +# Licensed to the Apache Software Foundation (ASF) under one or more >> +# contributor license agreements. See the NOTICE file distributed with >> +# this work for additional information regarding copyright ownership. >> +# The ASF licenses this file to You under the Apache License, Version >> 2.0 >> +# (the "License"); you may not use this file except in compliance with >> +# the License. You may obtain a copy of the License at >> +# >> +# http://www.apache.org/licenses/LICENSE-2.0 >> +# >> +# Unless required by applicable law or agreed to in writing, software >> +# distributed under the License is distributed on an "AS IS" BASIS, >> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or >> implied. >> +# See the License for the specific language governing permissions and >> +# limitations under the License. >> + >> +language: java >> +cache: >> + directories: >> +- $HOME/.m2 >> +jdk: >> + - openjdk8 >> + >> +# The default build is so verbose the travis log file can exceed the >> allowed limit. >> +# Run a custom install that hides all the Maven ‘Downloading’ messages. >> +install: >> + - mvn install -Dmaven.javadoc.skip=true -V -B >> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn >> + >> +script: >> + - mvn >> + - mvn verify apache-rat:check checkstyle:check > > I assume this is copied from [numbers]. Indeed. > In that case maven is called a > second time to run the examples profile for only the examples modules that > are not included in the default goal. > > Here the second called to mvn is redundant I thought so, but was not sure which one to remove. :-} > as you are not targeting a > specific profile and module. This is assuming that [graph] adds the same > checks to the default maven goal in the pom.xml. I assume that Amey will sort this out for every POM in the "modularization" branch (that still misses a Travis config). > > So: > > 1. Check the default goal in the pom includes what you want (test, various > checks, javadoc build, etc) I suggested that Amey uses a maintained component as a model for updating all the POMs in the "modularization" branch. > 2. Remove the second ‘mvn’ call in the ‘script:' target above Sure. Unless he eventually adds a commons-graph-examples module (?). Best regards, Gilles > >> + >> +after_success: >> + - mvn jacoco:report coveralls:report >> > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [commons-graph] branch master updated: Travis CI configuration.
> On 11 Jun 2020, at 18:07, er...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > erans pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-graph.git > > > The following commit(s) were added to refs/heads/master by this push: > new b14766b Travis CI configuration. > b14766b is described below > > commit b14766be60b3722007d19d015bc383e3d83d11b8 > Author: Gilles Sadowski > AuthorDate: Thu Jun 11 19:06:35 2020 +0200 > >Travis CI configuration. > --- > .travis.yml | 33 + > 1 file changed, 33 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > new file mode 100644 > index 000..709f9ba > --- /dev/null > +++ b/.travis.yml > @@ -0,0 +1,33 @@ > +# Licensed to the Apache Software Foundation (ASF) under one or more > +# contributor license agreements. See the NOTICE file distributed with > +# this work for additional information regarding copyright ownership. > +# The ASF licenses this file to You under the Apache License, Version 2.0 > +# (the "License"); you may not use this file except in compliance with > +# the License. You may obtain a copy of the License at > +# > +# http://www.apache.org/licenses/LICENSE-2.0 > +# > +# Unless required by applicable law or agreed to in writing, software > +# distributed under the License is distributed on an "AS IS" BASIS, > +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +# See the License for the specific language governing permissions and > +# limitations under the License. > + > +language: java > +cache: > + directories: > +- $HOME/.m2 > +jdk: > + - openjdk8 > + > +# The default build is so verbose the travis log file can exceed the allowed > limit. > +# Run a custom install that hides all the Maven ‘Downloading’ messages. > +install: > + - mvn install -Dmaven.javadoc.skip=true -V -B > -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn > + > +script: > + - mvn > + - mvn verify apache-rat:check checkstyle:check I assume this is copied from [numbers]. In that case maven is called a second time to run the examples profile for only the examples modules that are not included in the default goal. Here the second called to mvn is redundant as you are not targeting a specific profile and module. This is assuming that [graph] adds the same checks to the default maven goal in the pom.xml. So: 1. Check the default goal in the pom includes what you want (test, various checks, javadoc build, etc) 2. Remove the second ‘mvn’ call in the ‘script:' target above > + > +after_success: > + - mvn jacoco:report coveralls:report > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
