Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/

2012-02-17 Thread Ralph Goers 
I'm confused as to why you are having to fix so many checkstyle issues. I had 
thought I had them down to just a couple of classes.  In fact, putting the 
curly brace on the next line should cause a checkstyle error. Are you using the 
checktyle configuration that is in the project which is used to build the 
checkstyle report for the web site?

Ralph

On Feb 16, 2012, at 12:38 PM, ggreg...@apache.org wrote:

 Author: ggregory
 Date: Thu Feb 16 20:38:04 2012
 New Revision: 1245166
 
 URL: http://svn.apache.org/viewvc?rev=1245166view=rev
 Log:
 Fix Checkstyle issues.
 
 Modified:

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/DefaultFileContent.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/http/HttpFileNameParser.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/https/HttpsFileNameParser.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystem.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileSystem.java

 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/Messages.java
 
 Modified: 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
 URL: 
 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java?rev=1245166r1=1245165r2=1245166view=diff
 ==
 --- 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
  (original)
 +++ 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
  Thu Feb 16 20:38:04 2012
 @@ -454,7 +454,8 @@ public abstract class AbstractFileName i
  * @see #getType()
  * @see FileType#FILE
  */
 -public boolean isFile() throws FileSystemException {
 +public boolean isFile() throws FileSystemException
 +{
 // Use equals instead of == to avoid any class loader worries.
 return FileType.FILE.equals(this.getType());
 }
 
 Modified: 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
 URL: 
 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java?rev=1245166r1=1245165r2=1245166view=diff
 ==
 --- 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
  (original)
 +++ 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
  Thu Feb 16 20:38:04 2012
 @@ -518,7 +518,8 @@ public abstract class AbstractFileObject
  * @see #getType()
  * @see FileType#FILE
  */
 -public boolean isFile() throws FileSystemException {
 +public boolean isFile() throws FileSystemException
 +{
 // Use equals instead of == to avoid any class loader worries.
 return FileType.FILE.equals(this.getType());
 }
 @@ -531,7 +532,8 @@ public abstract class AbstractFileObject
  * @see #getType()
  * @see FileType#FOLDER
  */
 -public boolean isFolder() throws FileSystemException {
 +public boolean isFolder() throws FileSystemException
 +{
 // Use equals instead of == to avoid any class loader worries.
 return FileType.FOLDER.equals(this.getType());
 }
 @@ -623,7 +625,8 @@ public abstract class AbstractFileObject
 try
 {
 return listFiles(Selectors.SELECT_ALL).iterator();
 -} catch (FileSystemException e)
 +}
 +catch (FileSystemException e)
 {
 throw new IllegalStateException(e);
 }
 @@ -929,7 +932,7 @@ public abstract class AbstractFileObject
 }
 
 /**
 - * Deletes this file, and all children matching the {@code selector}
 + * Deletes this file, and all children matching the {@code selector}.
  *
  * @param selector The FileSelector.
  * @return the number of deleted files.
 @@ -1079,11 +1082,12 @@ public abstract class AbstractFileObject
 }

Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/

2012-02-17 Thread Gary Gregory 
On Fri, Feb 17, 2012 at 11:33 AM, Ralph Goers ralph.go...@dslextreme.comwrote:

 I'm confused as to why you are having to fix so many checkstyle issues. I
 had thought I had them down to just a couple of classes.  In fact, putting
 the curly brace on the next line should cause a checkstyle error. Are you
 using the checktyle configuration that is in the project which is used to
 build the checkstyle report for the web site?


Yes, all I am doing it: m3 site.

I do not like the stype of { on a line by iteself but all of VFS is coded
that way.

Gary



 Ralph

 On Feb 16, 2012, at 12:38 PM, ggreg...@apache.org wrote:

  Author: ggregory
  Date: Thu Feb 16 20:38:04 2012
  New Revision: 1245166
 
  URL: http://svn.apache.org/viewvc?rev=1245166view=rev
  Log:
  Fix Checkstyle issues.
 
  Modified:
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/DefaultFileContent.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/http/HttpFileNameParser.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/https/HttpsFileNameParser.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystem.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileSystem.java
 
  
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/Messages.java
 
  Modified:
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
  URL:
 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java?rev=1245166r1=1245165r2=1245166view=diff
 
 ==
  ---
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
 (original)
  +++
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
 Thu Feb 16 20:38:04 2012
  @@ -454,7 +454,8 @@ public abstract class AbstractFileName i
   * @see #getType()
   * @see FileType#FILE
   */
  -public boolean isFile() throws FileSystemException {
  +public boolean isFile() throws FileSystemException
  +{
  // Use equals instead of == to avoid any class loader worries.
  return FileType.FILE.equals(this.getType());
  }
 
  Modified:
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
  URL:
 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java?rev=1245166r1=1245165r2=1245166view=diff
 
 ==
  ---
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
 (original)
  +++
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
 Thu Feb 16 20:38:04 2012
  @@ -518,7 +518,8 @@ public abstract class AbstractFileObject
   * @see #getType()
   * @see FileType#FILE
   */
  -public boolean isFile() throws FileSystemException {
  +public boolean isFile() throws FileSystemException
  +{
  // Use equals instead of == to avoid any class loader worries.
  return FileType.FILE.equals(this.getType());
  }
  @@ -531,7 +532,8 @@ public abstract class AbstractFileObject
   * @see #getType()
   * @see FileType#FOLDER
   */
  -public boolean isFolder() throws FileSystemException {
  +public boolean isFolder() throws FileSystemException
  +{
  // Use equals instead of == to avoid any class loader worries.
  return FileType.FOLDER.equals(this.getType());
  }
  @@ -623,7 +625,8 @@ public abstract class AbstractFileObject
  try
  {
  return listFiles(Selectors.SELECT_ALL).iterator();
  -} catch (FileSystemException e)
  +}
  +catch (FileSystemException e)
  {
  throw new IllegalStateException(e);
  }
  @@ -929,7 +932,7 @@ public abstract class AbstractFileObject
  }
 
  /**
  - * Deletes this file, and all children matching the

Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/

2012-02-17 Thread Gary Gregory 
On Fri, Feb 17, 2012 at 4:12 PM, Ralph Goers ralph.go...@dslextreme.comwrote:

 Really?  I've gotten so used to putting the '{' at the end of the line
 that I assumed VFS was that way.


I'm happy to change the style to what we both seem to consider normal but I
am not sure what the rest of the community feels like...

Gary



 Ralph

 On Feb 17, 2012, at 1:05 PM, Gary Gregory wrote:

  On Fri, Feb 17, 2012 at 11:33 AM, Ralph Goers 
 ralph.go...@dslextreme.comwrote:
 
  I'm confused as to why you are having to fix so many checkstyle issues.
 I
  had thought I had them down to just a couple of classes.  In fact,
 putting
  the curly brace on the next line should cause a checkstyle error. Are
 you
  using the checktyle configuration that is in the project which is used
 to
  build the checkstyle report for the web site?
 
 
  Yes, all I am doing it: m3 site.
 
  I do not like the stype of { on a line by iteself but all of VFS is coded
  that way.
 
  Gary
 
 
 
  Ralph
 
  On Feb 16, 2012, at 12:38 PM, ggreg...@apache.org wrote:
 
  Author: ggregory
  Date: Thu Feb 16 20:38:04 2012
  New Revision: 1245166
 
  URL: http://svn.apache.org/viewvc?rev=1245166view=rev
  Log:
  Fix Checkstyle issues.
 
  Modified:
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/DefaultFileContent.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/http/HttpFileNameParser.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/https/HttpsFileNameParser.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpClientFactory.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystem.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/tar/TarFileSystem.java
 
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/Messages.java
 
  Modified:
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
  URL:
 
 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java?rev=1245166r1=1245165r2=1245166view=diff
 
 
 ==
  ---
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
  (original)
  +++
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileName.java
  Thu Feb 16 20:38:04 2012
  @@ -454,7 +454,8 @@ public abstract class AbstractFileName i
  * @see #getType()
  * @see FileType#FILE
  */
  -public boolean isFile() throws FileSystemException {
  +public boolean isFile() throws FileSystemException
  +{
 // Use equals instead of == to avoid any class loader worries.
 return FileType.FILE.equals(this.getType());
 }
 
  Modified:
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
  URL:
 
 http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java?rev=1245166r1=1245165r2=1245166view=diff
 
 
 ==
  ---
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
  (original)
  +++
 
 commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
  Thu Feb 16 20:38:04 2012
  @@ -518,7 +518,8 @@ public abstract class AbstractFileObject
  * @see #getType()
  * @see FileType#FILE
  */
  -public boolean isFile() throws FileSystemException {
  +public boolean isFile() throws FileSystemException
  +{
 // Use equals instead of == to avoid any class loader worries.
 return FileType.FILE.equals(this.getType());
 }
  @@ -531,7 +532,8 @@ public abstract class AbstractFileObject
  * @see #getType()
  * @see FileType#FOLDER
  */
  -public boolean isFolder() throws FileSystemException {
  +public boolean isFolder() throws FileSystemException
  +{
 // Use equals instead of == to avoid any class loader worries.
 return FileType.FOLDER.equals(this.getType());
 }
  @@ -623,7 +625,8 @@ public abstract class

Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/

2012-02-17 Thread Ralph Goers 

On Feb 17, 2012, at 1:09 PM, Gary Gregory wrote:

 This is off topic on for this thread but I'll take all the help I can get
 to move VFS to a new release :)
 
 I am happy with the fact that the build is now self sufficient WRT testing,
 embedded servers are used to test HTTP and so on.
 
 There are a lot of Clirr errors due to new features which makes me wonder
 if the next release should not be a 2.1 but a 3.0 with a package name
 change.
 

What new features and did they really break the API? I'd really hate to go to 
3.0 after just getting 2.0 out.

We really should start planning for the Java 7 variant of VFS.  That will 
require its own branch.  I don't have a huge need for that at the moment (my 
employer has no plans to move to Java 7 yet), but it would be interesting to do.

Ralph


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/

2012-02-17 Thread Gary Gregory 
On Fri, Feb 17, 2012 at 5:03 PM, Ralph Goers ralph.go...@dslextreme.comwrote:


 On Feb 17, 2012, at 1:09 PM, Gary Gregory wrote:

  This is off topic on for this thread but I'll take all the help I can get
  to move VFS to a new release :)
 
  I am happy with the fact that the build is now self sufficient WRT
 testing,
  embedded servers are used to test HTTP and so on.
 
  There are a lot of Clirr errors due to new features which makes me
 wonder
  if the next release should not be a 2.1 but a 3.0 with a package name
  change.
 

 What new features and did they really break the API? I'd really hate to go
 to 3.0 after just getting 2.0 out.


They would really be me :)

I looked at how we use VFS in our software at work and saw a lot of code
that I felt should be in VFS, features like:

- Ask a FileObject simple questions like isFile() and isFolder() .
- Do a bulk operation like FileObject.deleteAll().
- Write FileContents to different kinds of objects like FileObject,
FileContent and OutputStream.
- and other stuff and trickles down from that.

Gary


 We really should start planning for the Java 7 variant of VFS.  That will
 require its own branch.  I don't have a huge need for that at the moment
 (my employer has no plans to move to Java 7 yet), but it would be
 interesting to do.

 Ralph


 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/

2012-02-17 Thread Ralph Goers 

On Feb 17, 2012, at 2:16 PM, Gary Gregory wrote:

 On Fri, Feb 17, 2012 at 5:03 PM, Ralph Goers 
 ralph.go...@dslextreme.comwrote:
 
 
 What new features and did they really break the API? I'd really hate to go
 to 3.0 after just getting 2.0 out.
 
 
 They would really be me :)

By they I didn't mean who but what.

 
 I looked at how we use VFS in our software at work and saw a lot of code
 that I felt should be in VFS, features like:
 
 - Ask a FileObject simple questions like isFile() and isFolder() .
 - Do a bulk operation like FileObject.deleteAll().
 - Write FileContents to different kinds of objects like FileObject,
 FileContent and OutputStream.
 - and other stuff and trickles down from that.

So these were changes to the interface that will break any external providers 
but not impact callers?  I guess I could look at clirr but as I recall some of 
these were convenience methods. I'm wondering if they couldn't be done in such 
a way that they don't break compatibility (i.e. a new class with static helper 
methods, a wrapper object that adds the new methods, etc).

Ralph


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org