[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71231047 Note that your commit messages should be of the form: `CB-8182 Add ...` or `CB-8182 Port ...` instead of `CB-8182 - add ...` Please use backticks around `d8` and `mime`. Please use backticks ('`') instead of single quotes (') for commands / identifiers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] 3.7.0 Android Platform release
The vote has now closed. The results are: Positive Binding Votes: 7 Joe Bowser Sergey Grebnov Parashuram N Brian LeRoux Marcel Kinard Jesse MacFadyen Andrew Grieve Negative Binding Votes: 0 The vote has passed. I will publish to dist and npm. On Thu Jan 22 2015 at 5:32:28 PM Andrew Grieve agri...@chromium.org wrote: +1 - Created test project from archive (with cli and via bin/create) and ensured it built via ant gradle. On Thu, Jan 22, 2015 at 7:46 PM, Jesse purplecabb...@gmail.com wrote: +1 - ran coho verify-archive - ran coho verify-tags = Tag hash verified. @purplecabbage risingj.com On Thu, Jan 22, 2015 at 12:52 PM, Marcel Kinard cmarc...@gmail.com wrote: +1 * ran coho audit-license-headers * confirmed signature and hash with coho verify-archive * confirmed tags with coho verify-tags * installed app via createmobilespec and ran automated plugin tests with acceptable number of failures On Jan 21, 2015, at 12:09 PM, Joe Bowser bows...@gmail.com wrote: Please review and vote on this 3.7.0 Android Platform Release. Release issue: https://issues.apache.org/jira/browse/CB-8335 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8335/ The packages were published from their corresponding git tags: cordova-android: 3.7.0 (f3885692d9) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/ release-voting.md Voting will go on for a minimum of 72 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran hello world Note: This is the first time we've done an independent platform release, and as much as I'd like this thing to go out, it'd be good to smooth-out this release process while we're here. I've added my signing key to cordova-dist for verification. Please keep adding feedback on this in the discuss thread. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-8113 cordova-plugin-vibr...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71231461 Why can't you just make `cordova serve` work with `cordova-browser`/`cordova run`? I really don't want to have a fork of `cordova serve`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-8243 cordova-docs documentation tran...
GitHub user sosahvictor opened a pull request: https://github.com/apache/cordova-docs/pull/262 CB-8243 cordova-docs documentation translation: cordova-docs CB-8243 cordova-docs documentation translation: cordova-docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/sosahvictor/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/262.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #262 commit 4ceb16a7768369eabc9bf974f27212249cc11863 Author: Victor Sosa victo...@mx1.ibm.com Date: 2014-10-20T15:35:29Z CB-7700 cordova-docs documentation translation: cordova-docs commit b8ff44311c4918180ca73f3c50f084158a21b7cf Author: Victor Sosa victo...@mx1.ibm.com Date: 2014-10-20T16:44:40Z CB-7700 cordova-docs documentation translation: cordova-docs commit e60efe0381c04795dfae02f708155beca7fc0323 Author: Victor Sosa victo...@mx1.ibm.com Date: 2014-10-20T17:11:59Z CB-7700 cordova-docs documentation translation: cordova-docs commit 3f8dcce338191fafc1ad18974e0deb76887e31cd Author: Victor Sosa victo...@mx1.ibm.com Date: 2014-10-20T17:53:52Z CB-7700 cordova-docs documentation translation: cordova-docs commit dfe524311a522087fb0609f9826843e2e08460eb Author: Victor Sosa sosah.vic...@gmail.com Date: 2014-11-04T18:31:46Z CB-7936 cordova-docs documentation translation: cordova-docs commit 4ffcb22bc1fd351247e4354769899cbb60932356 Author: Victor Sosa sosah.vic...@gmail.com Date: 2015-01-23T16:30:13Z CB-8243 cordova-docs documentation translation: cordova-docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71222792 ok, one last final thing: * Please amend the commit message to not have the `:` after the `CB-8206` (I'm fairly confident this is documented in our instructions). Then, someone can push this to cordova-browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71228160 @jsoref Updated the commit message. Please review and help merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8330 Added new unit tests
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: firefoxos cordova.js !lastName
Hey Axel, It would be really helpful if you could file this as an issue and we can bring it to the attention of our ffos committers. Cheers, -Steve On Fri, Jan 23, 2015 at 5:43 AM, axel.nenn...@telekom.de wrote: Hi, I am using inappbrowser (0.5.5-dev) in a project on ios, android and firefoxos. https://github.com/apache/cordova-plugin-inappbrowser The firefoxos version of the app reports two errors in the console log. Cordova.js:466 getElementByID called with empty id (or similar) Cordova.js:1171 - - In line 1171 this is cause by lastName being null. https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L1171 The value of moduleName at that time is InAppBrowserProxy. I fixed this by inserting in line 1172: If (!lastName) continue; In line 466 key is null or undefined. https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L466 I have no idea why this happens on FirefoxOS but not on the other platforms. My current guess is that https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L203 does not get digested on FirefoxOS as on the other platforms. I did not create a new issue -Axel Cordova version: 4.1.2 ~/.cordova/lib/npm_cache/cordova-firefoxos/3.6.3
Re: So...can we merge 4.0.x into master yet?
Not sure what the JB fiasco is, but merging SGTM. We can always work off of 3.7.x if we end up needing another 3.x release. On Fri, Jan 23, 2015 at 1:51 PM, Joe Bowser bows...@gmail.com wrote: Hey So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I think we should talk about getting 4.0.x merged into master and out the door. I know there's that CookeManager thing that breaks the File Transfer plugin that we have to deal with, and I'm wondering if we can actually get some tests for that before we do the merge. I really want 4.0.x to be in mainline and be our priority so that we can get it out by the end of January. Also, once we get 4.0.x, we need to talk about WebViews and how we deal with the whole Jellybean fiasco, but I think we need to take one step at a time and get 4.0.x out. Thoughts? Joe
So...can we merge 4.0.x into master yet?
Hey So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I think we should talk about getting 4.0.x merged into master and out the door. I know there's that CookeManager thing that breaks the File Transfer plugin that we have to deal with, and I'm wondering if we can actually get some tests for that before we do the merge. I really want 4.0.x to be in mainline and be our priority so that we can get it out by the end of January. Also, once we get 4.0.x, we need to talk about WebViews and how we deal with the whole Jellybean fiasco, but I think we need to take one step at a time and get 4.0.x out. Thoughts? Joe
[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/23 [INFRA-8588] Fixed a bug for ASF Buildbot, and a bug for Windows. Fixed a bug causing errors in Apache Buildbot. Improved cleanup method to work on Windows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic INFRA-8588 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 7764f0ac6ddc5398cb1e06761d28b903ee9dddb7 Author: Dmitry Blotsky dblot...@microsoft.com Date: 2015-01-23T22:42:55Z [INFRA-8588] Fixed bug for ASF Buildbot. Made build cleanup step work on Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23488149 --- Diff: cordova-lib/src/cordova/util.js --- @@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions; exports.addModuleProperty = addModuleProperty; exports.getOrigWorkingDirectory = getOrigWorkingDirectory; exports.fixRelativePath = fixRelativePath; +exports.getPlatformDetailsFromDir = getPlatformDetailsFromDir; --- End diff -- moved cloning code to new module: https://github.com/MSOpenTech/cordova-lib/commit/9d267df1b389ef1f70dcbca4292e1ffd6641e895 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23488114 --- Diff: cordova-lib/src/cordova/util.js --- @@ -262,3 +270,81 @@ function addModuleProperty(module, symbol, modulePath, opt_wrap, opt_obj) { }); } } + +function resolvePath(pPath) { --- End diff -- Fixed in: https://github.com/MSOpenTech/cordova-lib/commit/9d267df1b389ef1f70dcbca4292e1ffd6641e895 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[cordova-android] Commit related to CB-8317 brings issue reported in CB-7371
Hello team, Recently tested cordova-android, master branch, and I found out that this commit: ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ccceaeaca2d72fb9708100ab2f70adb903a27d66 brings back the issue about app crash after language is changed, by allowing to load an url with 'about:blank' value, triggered by the app recreation on during onResume/OnDestroy events. See https://issues.apache.org/jira/browse/CB-7371 for more details about that crash. Tested on LG G2, Android 4.4.2 -- Regards, Martin Gonzalez
Odd EOL in files in newly cloned repo
Hello community I'm cloning a repository in Apache Cordova (cordova-docs) and as soon as I check out the repo in my laptop, I check the status of the repo with *git status*. Oddly, I get some image files as modified (the ones under cordova-docs/templates folder). Looking around in internet I found this thread in SO where a person recommends to modify the .gitattributes file in the repository to change the EOL of the files to LF. I need to say here that I'm using Ubuntu 12.04. http://stackoverflow.com/questions/12205846/git-shows-random-files-as-modified-after-clone-cant-discard-them My question, has someone else have had this problem before? How you fixed the problem? is it recommended to commit the changes in .gitattributes? Appreciate your input to solve this problem -- Victor Adrian Sosa Herrera IBM Software Engineer Guadalajara, Jalisco
Re: Odd EOL in files in newly cloned repo
Odd. There appears to be an issue with how these files were checked in. Normally only text files have this issue, which is corrected by setting: git config core.autocrlf true on windows machines. We may need to check in the corrected version. @purplecabbage risingj.com On Fri, Jan 23, 2015 at 12:57 PM, Victor Sosa sosah.vic...@gmail.com wrote: Hello community I'm cloning a repository in Apache Cordova (cordova-docs) and as soon as I check out the repo in my laptop, I check the status of the repo with *git status*. Oddly, I get some image files as modified (the ones under cordova-docs/templates folder). Looking around in internet I found this thread in SO where a person recommends to modify the .gitattributes file in the repository to change the EOL of the files to LF. I need to say here that I'm using Ubuntu 12.04. http://stackoverflow.com/questions/12205846/git-shows-random-files-as-modified-after-clone-cant-discard-them My question, has someone else have had this problem before? How you fixed the problem? is it recommended to commit the changes in .gitattributes? Appreciate your input to solve this problem -- Victor Adrian Sosa Herrera IBM Software Engineer Guadalajara, Jalisco
firefoxos cordova.js !lastName
Hi, I am using inappbrowser (0.5.5-dev) in a project on ios, android and firefoxos. https://github.com/apache/cordova-plugin-inappbrowser The firefoxos version of the app reports two errors in the console log. Cordova.js:466 getElementByID called with empty id (or similar) Cordova.js:1171 - - In line 1171 this is cause by lastName being null. https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L1171 The value of moduleName at that time is InAppBrowserProxy. I fixed this by inserting in line 1172: If (!lastName) continue; In line 466 key is null or undefined. https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L466 I have no idea why this happens on FirefoxOS but not on the other platforms. My current guess is that https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L203 does not get digested on FirefoxOS as on the other platforms. I did not create a new issue -Axel Cordova version: 4.1.2 ~/.cordova/lib/npm_cache/cordova-firefoxos/3.6.3
[GitHub] cordova-lib pull request: CB-6973 enable JSHint for spec-cordova
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-lib/pull/154 CB-6973 enable JSHint for spec-cordova This change enables jshint for spec-cordova meaning that `npm run jshint` will not only check `src` folder but `spec-cordova` too. I've also fixed all the JSHint issues for the spec-cordova. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-6973 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit 2d1a2849ef70ffed2a056e18f679a2926e0a8a5d Author: Murat Sutunc mura...@microsoft.com Date: 2015-01-24T00:40:25Z CB-6973 enable JSHint for spec-cordova --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6973 Improving JSHint for src folder
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Cordova issue 8080 - After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog
Hello My name is Andrea Tino. I am a Microsoft Developer in the Microsoft Dynamics NAV Team. Recently we started using Cordova for building our apps. All our tests fail We moved to Cordova 3.6.3 from 3.4.0 and from there all our tests (more than 200) started failing. After investigating on possible causes, we could identify the problem as part of a Cordova checkin: https://github.com/apache/cordova-android/commit/aab47bd4532bfe8707d745638eb5695ac543c681. Looks like prompt() is causing the problem. However the checkin I reported lacks changes to cordova.js that were supposed to be included there but that have been checked-in later in https://github.com/apache/cordova-android/commit/ec47274fbd91d2f0b658da64f5d4d4dd6600f625. So to repro the problem you need both checkins. The issue in JIRA documents details very good in comments: https://issues.apache.org/jira/browse/CB-8080 Need for a fix We assessed that trying to fix this here would be costly for us. The feature introduced spans across several areas of Cordova, thus high chances of breaking something. Also the feature is a security related one which we cannot revert. We need the Cordova Team to fix this problem which has been causing our test infrastructure to be broken for more than a month so far. We could also assess we are not the only one experiencing this issue whose repro is still not clear. After an initial discussion with Andrew Grieve, we decided to try broadening the audience in order to move Cordova Team's attention on this problem which we consider quite serious. Could you please prioritize the issue in your bug-fixing plan? How much time would it require for fixing this problem? Thank you for your availability -Andrea Tino [Description: MSFT_logo] Andrea Tino Software Development Engineer Microsoft Development Center Copenhagen Microsoft Dynamics NAV Mobile: +45 29229860 E-Mail: andrea.t...@microsoft.commailto:andrea.t...@microsoft.com
Re: Monthly Hangouts - Jan 2015 Edition
Thanks Parashuram for coordinating. On Thu, Jan 22, 2015 at 8:04 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Wanted to bump up the thread about the Cordova hangouts. A lot of people have responded, and looks like the following times are candidates. - Monday 26 Jan 2015, 1:00pm EST (1 conflict) - Thu 29 Jan 2015 2:00 PM EST (1 conflict) We could finalize this tomorrow, and if you have not already added yourself to the doodle, please do at - http://doodle.com/a3kr2kek4a5spxpr. -Original Message- Sent: Tuesday, January 20, 2015 1:07 PM To: dev Subject: Re: Monthly Hangouts - Jan 2015 Edition Here is the Doodle - http://doodle.com/a3kr2kek4a5spxpr. Please mark your availability. I added this for the next week, guessing that it would be super hard to finalize this week. If next week does not work, we could make do this in Feb. - ADMIN STUFF P.S: If anyone wants to administer the poll to change the time, or add additional days, here is the admin link. http://doodle.com/a3kr2kek4a5spxpr6c9pf857/admin#admin. DO NOT use this link for scheduling, only use it to make changes or administer the doodle. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 20, 2015 1:07 PM To: dev Subject: Re: Monthly Hangouts - Jan 2015 Edition There's no account. (don't think doodle requires sign-up) On Tue, Jan 20, 2015 at 3:33 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Hi, It has been a while since we had a hangouts, and a lot of folks have suggested that there are topics that could use a hangout. Thanks Michael for creating the agenda doc. https://docs.google.com/document/d/1h4KKT0oc70BE57eJ7Bmn4c-at7dH20g0KxTKvlyvIZU/edit?usp=sharing Do we have an official account where we set up the doodle? If not, I could set up a doodle for this. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Github user mmocny commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71210975 I reviewed this in a previous iteration, and the latest changes look fine. Since this feature does not exist yet anyway, and I'm not too concerned about inline updates to browser platform, I think this is more than ready to ship. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Github user mmocny commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71210993 ..Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...
Github user mmocny commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71211172 (Josh I'll let you have the last word on landing, you have been running this) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Cordova issue 8080 - After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog
Andrea, Some folks in the developer division may be able to help out here. I'll connect you with our Cordova contributors. -Chuck From: Andrea Tino [mailto:andrea.t...@microsoft.com] Sent: Friday, January 23, 2015 12:10 AM To: dev@cordova.apache.org Cc: Vincent Nicolas; Michael Helligsø Svinth Subject: Cordova issue 8080 - After migrating to 3.6.3 from 3.4.0, Appium (Android) tests fail because of open dialog Hello My name is Andrea Tino. I am a Microsoft Developer in the Microsoft Dynamics NAV Team. Recently we started using Cordova for building our apps. All our tests fail We moved to Cordova 3.6.3 from 3.4.0 and from there all our tests (more than 200) started failing. After investigating on possible causes, we could identify the problem as part of a Cordova checkin: https://github.com/apache/cordova-android/commit/aab47bd4532bfe8707d745638eb5695ac543c681. Looks like prompt() is causing the problem. However the checkin I reported lacks changes to cordova.js that were supposed to be included there but that have been checked-in later in https://github.com/apache/cordova-android/commit/ec47274fbd91d2f0b658da64f5d4d4dd6600f625. So to repro the problem you need both checkins. The issue in JIRA documents details very good in comments: https://issues.apache.org/jira/browse/CB-8080 Need for a fix We assessed that trying to fix this here would be costly for us. The feature introduced spans across several areas of Cordova, thus high chances of breaking something. Also the feature is a security related one which we cannot revert. We need the Cordova Team to fix this problem which has been causing our test infrastructure to be broken for more than a month so far. We could also assess we are not the only one experiencing this issue whose repro is still not clear. After an initial discussion with Andrew Grieve, we decided to try broadening the audience in order to move Cordova Team's attention on this problem which we consider quite serious. Could you please prioritize the issue in your bug-fixing plan? How much time would it require for fixing this problem? Thank you for your availability -Andrea Tino [Description: MSFT_logo] Andrea Tino Software Development Engineer Microsoft Development Center Copenhagen Microsoft Dynamics NAV Mobile: +45 29229860 E-Mail: andrea.t...@microsoft.commailto:andrea.t...@microsoft.com