[GitHub] cordova-ios pull request: CB-9013: Fix listing of multiple devices...
Github user gpetrov commented on the pull request: https://github.com/apache/cordova-ios/pull/140#issuecomment-101184870 @shazron is different issue indeed, the other is about the emulators. Mine is about the connected devices list. Created: https://issues.apache.org/jira/browse/CB-9013 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: SHA512 does not match
I saw this issue before as well - related to apache server which sets Content-Type header to application/x-gzip (for .sha files) - there was even some JIRA issue opened for this. Additional possible workarounds for Windows: 1. Use curl: curl https://dist.apache.org/repos/dist/dev/cordova/CB-8959/cordova-plugin-vibration-1.1.0.tgz.sha cordova-plugin-vibration-1.1.0.tgz.sha 2. Use svn to fetch dev dist packages Thx! Sergey -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Tuesday, May 12, 2015 11:00 AM To: dev@cordova.apache.org Subject: RE: SHA512 does not match Hi Murat. This issue (not matching SHA512) is happening because your downloaded .sha file is compressed for some reason. Try to decompress it using, for example, 7zip. Regards, Alexander Sorokin -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Tuesday, May 12, 2015 3:20 To: dev@cordova.apache.org Subject: RE: [VOTE] cordova-plugin-vibration release Sorry to hijack this thread but this is my first time verifying a release and I've some questions before signing off.. 1) I was looking at the coho docs but wasn't able to figure out how to download a release from dist/dev. Any tips? 2) For now I've manually copied the tgz files from the dist.apache and ran my validation. I've ran into the following issue, is it expected? C:\Users\muratsu\Desktop\plugincoho verify-archive cordova-plugin-vibration-1.1.0.tgz Running from c:\dev ./ = Executing: gpg --verify C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz.asc C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz gpg: Signature made 05/07/15 17:24:14 Pacific Daylight Time using RSA key ID FFCA68BE gpg: Good signature from Steve Gill (code signing key) ste...@apache.org [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: EBAC 6409 FA2F 2FCF A42C 1080 3843 B8F9 FFCA 68BE ./ = Computing MD5 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz ./ = Computing SHA512 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz SHA512 does not match. Other than this issue, changes look good to me. +1 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: SHA512 does not match
Thanks Alexander! I can confirm that this worked for me. On a mac, I renamed cordova-plugin-vibration-1.1.0.tgz.sha - cordova-plugin-vibration-1.1.0.tgz.sha.zip then double clicked it in Finder. Primary key fingerprint: EBAC 6409 FA2F 2FCF A42C 1080 3843 B8F9 FFCA 68BE *./* = Computing MD5 for: /Repos/cordova/tempVibeVote/cordova-plugin-vibration-1.1.0.tgz *./* = Computing SHA512 for: /Repos/cordova/tempVibeVote/cordova-plugin-vibration-1.1.0.tgz *./* = /Repos/cordova/tempVibeVote/cordova-plugin-vibration-1.1.0.tgz signature and hashes verified. *./* = Verified 1 signatures and hashes. @purplecabbage risingj.com On Tue, May 12, 2015 at 12:59 AM, Alexander Sorokin (Akvelon) v-als...@microsoft.com wrote: Hi Murat. This issue (not matching SHA512) is happening because your downloaded .sha file is compressed for some reason. Try to decompress it using, for example, 7zip. Regards, Alexander Sorokin -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Tuesday, May 12, 2015 3:20 To: dev@cordova.apache.org Subject: RE: [VOTE] cordova-plugin-vibration release Sorry to hijack this thread but this is my first time verifying a release and I've some questions before signing off.. 1) I was looking at the coho docs but wasn't able to figure out how to download a release from dist/dev. Any tips? 2) For now I've manually copied the tgz files from the dist.apache and ran my validation. I've ran into the following issue, is it expected? C:\Users\muratsu\Desktop\plugincoho verify-archive cordova-plugin-vibration-1.1.0.tgz Running from c:\dev ./ = Executing: gpg --verify C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz.asc C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz gpg: Signature made 05/07/15 17:24:14 Pacific Daylight Time using RSA key ID FFCA68BE gpg: Good signature from Steve Gill (code signing key) ste...@apache.org [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: EBAC 6409 FA2F 2FCF A42C 1080 3843 B8F9 FFCA 68BE ./ = Computing MD5 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz ./ = Computing SHA512 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz SHA512 does not match. Other than this issue, changes look good to me. +1 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases
I vote +1 * Verified blank app can be successfully built and run (Android, Windows, WP8) * Ran autotests * Verified compatibility with core plugins Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 12, 2015 3:12 AM To: dev@cordova.apache.org Subject: Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases bump. On Fri, May 8, 2015 at 5:11 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on these releases by replying to this email (and keep discussion on the DISCUSS thread) These releases are just including an updated snapshot of cordova.js so it works with ripple again. Release issue: https://issues.apache.org/jira/browse/CB-8997 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8997 The package was published from its corresponding git tag: cordova-android: 4.0.1 (6b7eaf2386) cordova-wp8: 3.8.1 (0a099394ab) cordova-windows: 3.8.2 (eb4e7125e0) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#4.0.1 cordova platform add https://github.com/apache/cordova-wp8#3.8.1cordova platform add https://github.com/apache/cordova-windows#3.8.2 Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: SHA512 does not match
Hi Murat. This issue (not matching SHA512) is happening because your downloaded .sha file is compressed for some reason. Try to decompress it using, for example, 7zip. Regards, Alexander Sorokin -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Tuesday, May 12, 2015 3:20 To: dev@cordova.apache.org Subject: RE: [VOTE] cordova-plugin-vibration release Sorry to hijack this thread but this is my first time verifying a release and I've some questions before signing off.. 1) I was looking at the coho docs but wasn't able to figure out how to download a release from dist/dev. Any tips? 2) For now I've manually copied the tgz files from the dist.apache and ran my validation. I've ran into the following issue, is it expected? C:\Users\muratsu\Desktop\plugincoho verify-archive cordova-plugin-vibration-1.1.0.tgz Running from c:\dev ./ = Executing: gpg --verify C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz.asc C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz gpg: Signature made 05/07/15 17:24:14 Pacific Daylight Time using RSA key ID FFCA68BE gpg: Good signature from Steve Gill (code signing key) ste...@apache.org [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: EBAC 6409 FA2F 2FCF A42C 1080 3843 B8F9 FFCA 68BE ./ = Computing MD5 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz ./ = Computing SHA512 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz SHA512 does not match. Other than this issue, changes look good to me. +1 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101361898 Status can be 0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova 5.0 user feedback - move to npm whitelist plugin
if you use --copy-from and the template doesn't already have a config.xml, then the default config.xml will be used. I wouldn't expect what you describe if your template already had a config.xml On Tue, May 12, 2015 at 10:46 AM, Raymond Camden raymondcam...@gmail.com wrote: So query - I thought the whitelist plugin was being added because it was in the default Cordova sample config.xml - but when I built a new project and used --copy-from, it *also* installed the plugin. So is it just *always* added? On Tue, May 12, 2015 at 9:21 AM, Andrew Grieve agri...@chromium.org wrote: On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to npm whitelist plugin (1) older versions of our docs point to plugins.cordova.io for plugin documentation. We haven't pointed people to github for plugin docs. Those docs are accurate with the ID of the plugin. Adding a section to the readme about needing cordova 5+ isn't a bad idea. [NK] There are places that this is not true. http://cordova.apache.org/docs/en/4.0.0/guide_support_index.md.html#Platform%20Support . The plan is to switch our tools to grab from npm first and CPR second. I believe we discussed doing this around the time CPR goes read only. Giving IDE's and people using older versions a chance to upgrade. We can publish updated plugins to CPR, but it is going to be quite a bit of work. I created old-id branches for our core plugins that revert the commits changing the ID and the commits where I change internal plugin references from org.apache.cordova.* to cordova-plugin-*. It was a fairly large change. The reason for the major jump was the plugin id change. I'd recommend them sticking the versioning they are on instead of copying the version of the npm series. The major version bump wasn't due to a change in functionality in the plugins themselves. If we want to release updated plugins to CPR, someone will need to do the work to cherry-pick the new commits into old-id and do a separate vote for them. [NK] I understand this is a lot of work. Alternatlively, shall we change the behavior of the CLI to use npm first - even for old ids - perhaps, as part of 5.1 tools release? There is not much value in old Ids causing stale, old version of plugin getting downloaded from CPR. (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will auto include the whitelist plugin due to the hello world config.xml including it as a dependency. I think we need to document it more and make more noise within the community about it. iOS 4.0 will also require the whitelist plugin when it gets released. The more prepared we are, the better. As for re-enabling network access by default, I wasn't really part of the original thread so I will leave it to the people who were to discuss that further. [NK] I agree that making more noise is the right short term move to help people upgrading to 5.0 realize this. I still believe that network access should be enabled in the platform by default without any plugins. For controlling network access, devs should either use CSP or a whitelist plugin that gets the chance to override the networking behavior. Andrew, Michael, and Ian are most familiar with the decision around this. http://markmail.org/search/?q=Android%27s+new+Whitelist+Plugins#query:Android%27s%20new%20Whitelist%20Plugins+page:1+mid:z2r2sj5e3kvrnqv6+state:results Additionally, on prepare, platforms should see the use of access tags and encourage users to use one of the whitelist plugins if they have not already done so. I agree that needing the new whitelist plugin to make network calls is unfortunate. I know Ian really wanted everything to secure by default, and having network access via a plugin means you can update the plugin separately if there are bugs. I think it might be a bit late to change things now though. Better to just stick with it rather than changing things again and again. On Thu, May 7, 2015 at 8:55 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: There is a bunch of confusion with Cordova 5.0 users because of these two changes: 1. Move to npm for plugins (There have been multiple PRs trying to update plugin docs to reference the old id instead of the new one - because people are still using the old version of the CLI) 2. No network access in Android 4.0 without whitelist plugin: - https://issues.apache.org/jira/browse/CB-8969 - http://stackoverflow.com/questions/29735597/cordova-5-0-0-android-app- can-not-connect-to-internet-using-android-4-0-0 -
[DISCUSS] Cordova-Windows Release
Does anyone have a reason to delay a cordova-windows platform release? Any outstanding patches to land? I'm looking to merge Windows 10 support into main and release 4.0.0. If not, I will start a release tomorrow. Thanks, -Rob
RE: [DISCUSS] Cordova-Windows Release
+1 to merging Cordova-windows10 in master. I don't think it breaks anything existing, and windows10 support seems to be enabled only via flags or cli args. I think merging it into master will make developing windows 10 easier. -Original Message- From: Rob Paveza [mailto:rob.pav...@microsoft.com] Sent: Tuesday, May 12, 2015 11:39 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-Windows Release Does anyone have a reason to delay a cordova-windows platform release? Any outstanding patches to land? I'm looking to merge Windows 10 support into main and release 4.0.0. If not, I will start a release tomorrow. Thanks, -Rob - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101383321 yes, it is a breaking change. That is why it is a 4.0.0 change. Plugin authors need to use engine tags, and we need to make sure they work. Personally, if I was writing a WP8.1 app, I would use cordova-wp8 and upgrade stuff. Having a C# wrapper around a html/js presentation will still be appealing to many. I would not expect cordova-wp8 to wither and die anytime soon. @purplecabbage risingj.com On Tue, May 12, 2015 at 11:33 AM, Nikhil Khandelwal notificati...@github.com wrote: @purplecabbage https://github.com/purplecabbage I'm really concerned with this switch for WP8 as it is breaking in nature. It changes how the Cordova WP8 JSON APIs behave and will cause a fair number of plugins to break. All plugins that break will have to make updates to support the new WP8 platform, and hence can't be used with the older version (3.x) of the WP8 platform. I would propose we don't make this disruptive change for WP8 which is a platform with limited runway as WP8.1+ should be using the Windows platform. WP8 should ideally be on life support and not making disruptive breaking changes that affect the plugin ecosystem. We should consider an incremental fix for file transfer and other plugins that need better support for JSON parsing instead of changing the platform itself: apache/cordova-plugin-file-transfer#72 https://github.com/apache/cordova-plugin-file-transfer/pull/72 â Reply to this email directly or view it on GitHub https://github.com/apache/cordova-wp8/pull/79#issuecomment-101378234. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Sergey Grebnov Tim Barham The vote has passed. I will publish to dist npm now. On Tue, May 12, 2015 at 6:23 AM, Tim Barham tim.bar...@microsoft.com wrote: I vote +1 * Verified archive sigs and hashes ('coho verify-archive'). * Verified tag sha1s ('coho verify-tags'). * Verified can build and run blank app for each platform. * Verified tests were green (windows and wp8). * Verified android platform now works in Ripple. Thanks, Tim From: Sergey Grebnov (Akvelon) v-seg...@microsoft.com Sent: Tuesday, May 12, 2015 5:27 PM To: dev@cordova.apache.org Subject: RE: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases I vote +1 * Verified blank app can be successfully built and run (Android, Windows, WP8) * Ran autotests * Verified compatibility with core plugins Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 12, 2015 3:12 AM To: dev@cordova.apache.org Subject: Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases bump. On Fri, May 8, 2015 at 5:11 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on these releases by replying to this email (and keep discussion on the DISCUSS thread) These releases are just including an updated snapshot of cordova.js so it works with ripple again. Release issue: https://issues.apache.org/jira/browse/CB-8997 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8997 The package was published from its corresponding git tag: cordova-android: 4.0.1 (6b7eaf2386) cordova-wp8: 3.8.1 (0a099394ab) cordova-windows: 3.8.2 (eb4e7125e0) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#4.0.1 cordova platform add https://github.com/apache/cordova-wp8#3.8.1 cordova platform add https://github.com/apache/cordova-windows#3.8.2 Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101388610 If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72). I understand Newtonsoft JSON is a better API and is more efficient. Another alternative is for WP8 to provide new set of JSON APIs based on Newtonsoft JSON - The plugins that take dependency on these new APIs will have to use the engine tag and drop support for older versions of WP8. The older APIs will remain unchanged and a lot of plugins that are no longer maintained can continue to work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/75#discussion_r30174837 --- Diff: template/cordova/lib/build.js --- @@ -32,88 +33,175 @@ var projFiles = { win: 'CordovaApp.Windows.jsproj', win80: 'CordovaApp.Windows80.jsproj' }; -// parsed nopt arguments -var args; -// build type (Release vs Debug) -var buildType; -// target chip architectures to build for -var buildArchs; -// MSBuild Tools available on this development machine -var msbuild; // builds cordova-windows application with parameters provided. // See 'help' function for args list module.exports.run = function run (argv) { +// MSBuild Tools available on this development machine +var msbuild; + if (!utils.isCordovaProject(ROOT)){ return Q.reject('Could not find project at ' + ROOT); } -try { -// thows exception if something goes wrong -parseAndValidateArgs(argv); -} catch (error) { -return Q.reject(error); -} +return Q.all([parseAndValidateArgs(argv), MSBuildTools.findAvailableVersion()]) +.spread(function(buildConfig, msbuildTools) { +// update platform as per configuration settings +prepare.applyPlatformConfig(buildConfig); -// update platform as per configuration settings -prepare.applyPlatformConfig(); - -return MSBuildTools.findAvailableVersion().then( -function(msbuildTools) { msbuild = msbuildTools; console.log('MSBuildToolsPath: ' + msbuild.path); -return buildTargets(); +return buildTargets(msbuild, buildConfig); +}, function(error) { +return Q.reject(error); }); }; // help/usage function module.exports.help = function help() { console.log(''); -console.log('Usage: build [ --debug | --release ] [--archs=\list of architectures...\] [--phone | --win]'); -console.log('--help: Displays this dialog.'); -console.log('--debug : Builds project in debug mode. (Default)'); -console.log('--release : Builds project in release mode.'); -console.log('-r: Shortcut :: builds project in release mode.'); -console.log('--archs : Builds project binaries for specific chip architectures (`anycpu`, `arm`, `x86`, `x64`).'); +console.log('Usage: build [--debug | --release] [--archs=list of architectures...]'); +console.log(' [--phone | --win] [--packageCertificateKeyFile=key path]'); +console.log(' [--packageThumbprint=thumbprint] [--publisherId]'); +console.log(' [--buildConfig=file path]'); +console.log('--help : Displays this dialog.'); +console.log('--debug : Builds project in debug mode. (Default).'); +console.log('--release : Builds project in release mode.'); +console.log('-r : (shortcut) Builds project in release mode.'); +console.log('--archs : Builds project binaries for specific chip'); +console.log(' architectures (`anycpu`, `arm`, `x86`, `x64`).'); console.log('--phone, --win'); -console.log(' : Specifies, what type of project to build'); +console.log(': Specifies, what type of project to build.'); +console.log('--packageCertificateKeyFile : Builds the project using provided certificate.'); +console.log('--packageThumbprint : Thumbprint associated with the certificate.'); +console.log('--publisherId : Sets publisher id field in manifest.'); +console.log('--buildConfig : Sets build settings from configuration file.'); +console.log(''); console.log('examples:'); console.log('build '); console.log('build --debug'); console.log('build --release'); console.log('build --release --archs=arm x86'); +console.log('build --packageCertificateKeyFile=CordovaApp_TemporaryKey.pfx'); +console.log('build --buildConfig=build.json'); --- End diff -- As I mentioned earlier - providing an example with the publisher Id might be useful since publisher id has a very specific syntax. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101378234 @purplecabbage I'm really concerned with this switch for WP8 as it is breaking in nature. It changes how the Cordova WP8 JSON APIs behave and will cause a fair number of plugins to break. All plugins that break will have to make updates to support the new WP8 platform, and hence can't be used with the older version (3.x) of the WP8 platform. I would propose we don't make this disruptive change for WP8 which is a platform with limited runway as WP8.1+ should be using the Windows platform. WP8 should ideally be on life support and not making disruptive breaking changes that affect the plugin ecosystem. We should consider an incremental fix for file transfer and other plugins that need better support for JSON parsing instead of changing the platform itself: https://github.com/apache/cordova-plugin-file-transfer/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9016: Added template-packaged WinJS re...
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-js/pull/111 CB-9016: Added template-packaged WinJS reference for Windows 10 support. Windows 10 no longer has a Framework Reference for WinJS, instead we include it in the project template (since we guarantee that at least WinJS Promises and ALM events will be present). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-js CB-9016 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/111.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #111 commit 900772c740c6acd4b9205492caac5f9584928fa4 Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-05-12T18:34:56Z Added template-packaged WinJS reference for Windows 10 support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
That sounds like a very reasonable approach. So we'll revert the changes to JSONHelper.cs + leave NewtonsoftJSON lib in and plugin developers can use it if they prefer. Sound good? Yes, currently PG-Build supports only cordova-wp8. Windows Universal (8.1) is in the works. @purplecabbage risingj.com On Tue, May 12, 2015 at 12:31 PM, brodybits g...@git.apache.org wrote: Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101394601 If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72). I understand Newtonsoft JSON is a better API and is more efficient. The only real trouble spot I have seen is in the PluginResult class, in case a plugin returns an arbitrary data type (such as a byte array). To solve this, we can modify the PluginResult to use an internal function that uses `DataContractJsonSerializer` (along with a `StreamReader`) to convert the plugin result to JSON. I am happy to issue a PR for this if you need it. Of course, to be absolutely safe, we could revert the changes to `template/cordovalib/JSON/JsonHelper.cs` but keep the Newtonsoft JSON library for those plugins that want to use it. IMHO, it should be safe for this project to use the Newtonsoft JsonConvert functions in all cases except for PluginResult.cs. And finally document it for the plugin authors. An extreme solution would be to rename (or remove) the functions in JsonHelper.cs and change the order of the parameters in the PluginResult() constructor, in order to *force* the plugin authors to review and update their code. I would not expect cordova-wp8 to wither and die anytime soon. In addition, it is my understanding is that cordova-wp8 is (still) needed to support Windows Phone in PhoneGap build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Windows Release
+1 The less branches we maintain the better. @purplecabbage risingj.com On Tue, May 12, 2015 at 11:44 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 to merging Cordova-windows10 in master. I don't think it breaks anything existing, and windows10 support seems to be enabled only via flags or cli args. I think merging it into master will make developing windows 10 easier. -Original Message- From: Rob Paveza [mailto:rob.pav...@microsoft.com] Sent: Tuesday, May 12, 2015 11:39 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-Windows Release Does anyone have a reason to delay a cordova-windows platform release? Any outstanding patches to land? I'm looking to merge Windows 10 support into main and release 4.0.0. If not, I will start a release tomorrow. Thanks, -Rob - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user brodybits commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-101394601 If we can avoid the breaking change it would be better and in this case we have a solution that works well to avoid it (apache/cordova-plugin-file-transfer#72). I understand Newtonsoft JSON is a better API and is more efficient. The only real trouble spot I have seen is in the PluginResult class, in case a plugin returns an arbitrary data type (such as a byte array). To solve this, we can modify the PluginResult to use an internal function that uses `DataContractJsonSerializer` (along with a `StreamReader`) to convert the plugin result to JSON. I am happy to issue a PR for this if you need it. Of course, to be absolutely safe, we could revert the changes to `template/cordovalib/JSON/JsonHelper.cs` but keep the Newtonsoft JSON library for those plugins that want to use it. IMHO, it should be safe for this project to use the Newtonsoft JsonConvert functions in all cases except for PluginResult.cs. And finally document it for the plugin authors. An extreme solution would be to rename (or remove) the functions in JsonHelper.cs and change the order of the parameters in the PluginResult() constructor, in order to *force* the plugin authors to review and update their code. I would not expect cordova-wp8 to wither and die anytime soon. In addition, it is my understanding is that cordova-wp8 is (still) needed to support Windows Phone in PhoneGap build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9013: Fix listing of multiple devices...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/75#issuecomment-101421281 +1 and yeah, showing at least one valid publisher Id would be great. I would recommend you also add a comment with a passing value whenever you write something like: (CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|(OID\\.(0|[1-9][0-9]*)(\\.(0|[1-9][0-9]*))+))= ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] cordova-plugin-vibration release
The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Jesse MacFadyen Shazron Abdullah Murat Sutunc The vote has passed. I will move it over to dist and publish to npm On Mon, May 11, 2015 at 5:20 PM, Murat Sutunc mura...@microsoft.com wrote: Sorry to hijack this thread but this is my first time verifying a release and I've some questions before signing off.. 1) I was looking at the coho docs but wasn't able to figure out how to download a release from dist/dev. Any tips? 2) For now I've manually copied the tgz files from the dist.apache and ran my validation. I've ran into the following issue, is it expected? C:\Users\muratsu\Desktop\plugincoho verify-archive cordova-plugin-vibration-1.1.0.tgz Running from c:\dev ./ = Executing: gpg --verify C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz.asc C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz gpg: Signature made 05/07/15 17:24:14 Pacific Daylight Time using RSA key ID FFCA68BE gpg: Good signature from Steve Gill (code signing key) ste...@apache.org [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: EBAC 6409 FA2F 2FCF A42C 1080 3843 B8F9 FFCA 68BE ./ = Computing MD5 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz ./ = Computing SHA512 for: C:\Users\muratsu\Desktop\plugin\cordova-plugin-vibration-1.1.0.tgz SHA512 does not match. Other than this issue, changes look good to me. +1 -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Monday, May 11, 2015 4:45 PM To: dev@cordova.apache.org Subject: Re: [VOTE] cordova-plugin-vibration release +1 On Mon, May 11, 2015 at 11:53 AM, Jesse purplecabb...@gmail.com wrote: +1 verify-archive checked that my most recent changes were present @purplecabbage risingj.com On Mon, May 11, 2015 at 10:46 AM, Steven Gill stevengil...@gmail.com wrote: Bump On Thu, May 7, 2015 at 5:31 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of cordova-plugin-vibration release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-8959 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8959/ The packages were published from their corresponding git tags: cordova-plugin-vibration: 1.1.0 (81729f0f5c) Upon a successful vote I will upload the archives to dist/ and upload it to npm. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-votin g.md Voting will go on for a minimum of 48 hours. I vote +1: - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCE] Platform and plugin releases
Platforms released: cordova-windows@3.8.2 cordova-wp8@3.8.1 cordova-android@4.0.1 Plugins released: cordova-plugin-camera@1.1.0 cordova-plugin-device-motion@1.1.0 cordova-plugin-dialogs@1.1.0 cordova-plugin-file-transfer@1.1.0 cordova-plugin-vibration@1.1.0 Everything has been published to npm.
[GitHub] cordova-windows pull request: CB-8946: Added the WindowsToastCapa...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101424430 Merged, making it check explicitly for `undefined` and `null`, as per Jesse's note that 0 is a valid return value, and `if(condition)` wasn't sufficient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8856 Fix 'Id' attr is invalid whe...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8486 Support for signing and buil...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/75#issuecomment-101407929 Looks great, otherwise - let's get it in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101426677 Looks good! @purplecabbage risingj.com On Tue, May 12, 2015 at 2:18 PM, Dmitry Blotsky notificati...@github.com wrote: Merged, making it check explicitly for undefined and null, as per Jesse's note that 0 is a valid return value, and if(condition) wasn't sufficient. â Reply to this email directly or view it on GitHub https://github.com/apache/cordova-js/pull/110#issuecomment-101424430. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Update index.html
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/78#issuecomment-101426531 index.html is a resource that comes from https://github.com/apache/cordova-app-hello-world This cannot be patched here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782 As long as this doesn't negatively impact other platforms, merge away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Cordova-Windows Release
Jesse, where have we landed on the issue of the local-notifications plugin change? It seems to me that whatever change we make isn't particularly relevant to other platforms. Since Windows Cordova apps are entirely in JS, the solution has to be in JS. Why focus on it being an event-based change, instead of a persistent property? From the app developer perspective, the additional event is entirely duplicative (from an API perspective), but the new event you proposed never fires for Android or iOS until it gets implemented. What I had proposed (cordova.env) is just empty on those environments until it got implemented. -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, May 12, 2015 11:49 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-Windows Release +1 The less branches we maintain the better. @purplecabbage risingj.com On Tue, May 12, 2015 at 11:44 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 to merging Cordova-windows10 in master. I don't think it breaks anything existing, and windows10 support seems to be enabled only via flags or cli args. I think merging it into master will make developing windows 10 easier. -Original Message- From: Rob Paveza [mailto:rob.pav...@microsoft.com] Sent: Tuesday, May 12, 2015 11:39 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-Windows Release Does anyone have a reason to delay a cordova-windows platform release? Any outstanding patches to land? I'm looking to merge Windows 10 support into main and release 4.0.0. If not, I will start a release tomorrow. Thanks, -Rob - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/76 CB-9015: Merge windows10 support to Master This change merges the Windows 10 support from the 'windows10' branch into master. I've also gone through and tidied up a couple of the places where there had been some inconsistencies. This is tied with a cordova-js and a cordova-docs change, which have the related updates for Windows 10 support as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-9015 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit 653b7d1ff1f8b80cb53c7e2d8606da1dfddffda5 Author: Parashuram n.parashu...@yahoo.co.in Date: 2015-04-28T03:10:14Z Added info about Windows 10 support in README commit 0d2387d95433c62b9efdbc509a627ed7277283b4 Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-04-23T23:26:40Z CB-8923 Add support for Windows 10 platform github: closes #70 commit 89745f525e13b4f60882e6f7a1ea3e96e94b8744 Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-04-28T22:34:13Z Bugfix: Win10 - Fast fail on Hardware access commit 32d459c0f6e380878620a39518cc37768470b339 Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-05-01T18:10:27Z Reverted change to version which added pascal casing based on CR feedback commit eddc8f7bf74400bbbfed3344c49987d835ab10ce Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-05-02T06:54:28Z fix merge conflict commit e3071ff79a3c63459a3b9876f13bc73f586f16e5 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-05-05T20:02:38Z Fix bad commit that broke run.js commit 18e368d774e777648fc0334ad622060e5ce14504 Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-05-12T21:37:22Z Merge branch 'master' of https://github.com/apache/cordova-windows into windows10 Conflicts: template/cordova/lib/prepare.js commit 48ced3f0f1f86d1882b373cc43936ab2867dfdce Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-05-12T21:43:13Z CB-9015: Merge Windows 10 support back to master, also reverted change that had changed windows-target-version preference to pascal case. While this had functionally been reverted previously, documentation and unit tests hadn't been modified to address that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/110#issuecomment-101466299 ultimately this was a failure of our use of jshint. The original check of (undef != null) was fine, but jshint considered it an error ... which led to a fix which caused a real error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] WP8 mobilespec failing to get created (CB-9021)
On the flip side, if we do not update cordova-js with the latest on its master, we would have found this bug CB-8996 much later Yeah, true. Ultimately I would like to see the entire matrix of possibilities. cordova-wp8@npm-published-version + cordova-js@master cordova-wp8@master cordova-wp8@master + cordova-js@master ... multiply by all platforms Some things we would expect to fail, others not. I also would prefer we run individual plugin tests, but that gets messy real fast. Should the code for cordova-lib be updated to strip out '-dev' suffix? Yes. I never liked having a version suffix, I never understood why we needed it. I would prefer we discuss removing it entirely instead of working around it. Am I missing something? @purplecabbage risingj.com On Tue, May 12, 2015 at 4:44 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: On the flip side, if we do not update cordova-js with the latest on its master, we would have found this bug https://issues.apache.org/jira/browse/CB-8996 much later - only when the cordova.js would have merged to the platform repo - which I believe happens only around the time of a release? Here's the real failure: Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin doesn't support this project's cordova-wp8 version. cordova-wp8: 4.0.0-dev, failed version requirement: =4.0.0 Looks like cordova-lib's version comparison using semver, which does not recognize 'dev' in the version of WP8 and fails: if ( semver.satisfies(engine.currentVersion, engine.minVersion) || engine.currentVersion === null ) { // engine ok! } else { var msg = 'Plugin doesn\'t support this project\'s ' + engine.name + ' version. ' + engine.name + ': ' + engine.currentVersion + ', failed version requirement: ' + engine.minVersion; return Q.reject(new CordovaError(msg)); } Should the code for cordova-lib be updated to strip out '-dev' suffix? -Nikhil -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, May 12, 2015 4:30 PM To: dev@cordova.apache.org Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021) I am not entirely sure what the best approach is, personally I would just expect it to build with the cordova.js installed by the version. There is no guarantee that platforms and cordova-js are in sync at any given time. Maybe we should put this behind a flag and have the CI run it both with and without ... not sure. @purplecabbage risingj.com On Tue, May 12, 2015 at 3:56 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Mobilespec builds it by design, I think, to use the latest version of cordova.js. Is that undesired behaviour? We're always using the master version of cordova-wp8 in periodic CI builds. Kindly, Dmitry On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote: What version of cordova-wp8 are you testing? The failure seems like is doing what it should ... cordova-wp8@4.0.0 should not be able to install cordova-plugin-file-transfer@4.0.0 Also, why is createmobilespec always building cordova-js? I would expect this to sporadically break. @purplecabbage risingj.com On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] WP8 mobilespec failing to get created (CB-9021)
I am not entirely sure what the best approach is, personally I would just expect it to build with the cordova.js installed by the version. There is no guarantee that platforms and cordova-js are in sync at any given time. Maybe we should put this behind a flag and have the CI run it both with and without ... not sure. @purplecabbage risingj.com On Tue, May 12, 2015 at 3:56 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Mobilespec builds it by design, I think, to use the latest version of cordova.js. Is that undesired behaviour? We're always using the master version of cordova-wp8 in periodic CI builds. Kindly, Dmitry On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote: What version of cordova-wp8 are you testing? The failure seems like is doing what it should ... cordova-wp8@4.0.0 should not be able to install cordova-plugin-file-transfer@4.0.0 Also, why is createmobilespec always building cordova-js? I would expect this to sporadically break. @purplecabbage risingj.com On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9023 Add support to specify a build c...
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-lib/pull/215 CB-9023 Add support to specify a build config file. If none is specified `bui⦠â¦ld.json` in the project root is used as a default You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib buildConfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #215 commit f4348a0fa7b2ffa14b8fc75074c3e42863ec0276 Author: Nikhil Khandelwal nikhi...@microsoft.com Date: 2015-03-31T20:48:32Z Add support to specify a build config file. If none is specified `build.json` in the project root is used as a default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Small fix on index.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[CI] Windows build restored
Thanks to all who participated in fixing it! Latest Windows mobilespec run passed: http://ci.apache.org/builders/cordova-windows/builds/1457 Kindly, Dmitry
Re: [DISCUSS] Should pinned platforms allow for patch updates?
+1 on loosening the grip on platform pinning On Tue, May 12, 2015 at 3:21 PM, Steven Gill stevengil...@gmail.com wrote: I am totally on board with --save flag saving '^1.2.3' in config.xml since it mimics the behavior of npm --save. No need to change anything. The more I think about it, the more I think we should loosen our grips on platform pinning. As long as we are being semver compliant for all of our platforms, we shouldn't run into issues. I like the idea of changing our pins to `^1.2.3` so it respects major only. It would grab the newest released version of the platform with the same major. This would only impact new projects or projects that are adding a platform for the first time. Existing projects would still have to cordova platform rm PLATFORM and cordova platform add PLATFORM to get the latest platform. One of the reasons we originally wanted to keep pinning was so we could easily help users when they tell us what version of Cordova they are having problems with. With the ability to add whatever version of platforms via `cordova platform add windows@VERSION`, knowing the cli version doesn't give us the details we want. Users can get installed platform versions with `cordova platform ls`. If we make this change, we should review our fetch/cache logic to see if it would grab the latest if an older version exists). We seem to have a fairly good track record with newer platform versions working with older CLI versions. Everytime we do a tools release, we could update the pinned versions to the latest released ones/newest version cli was tested with at release time. For platform releases, we would have to test it with the oldest version of the CLI that could potentially pull it down. What do others think? On Tue, May 12, 2015 at 6:36 AM, Tim Barham tim.bar...@microsoft.com wrote: ?Currently our pinned platforms are all in the form 1.2.3, which I expect means we'll always get that exact version. Should we instead use the form 1.2.x to allow for patches without having to do a tools release? BTW... When you add a platform, and we use the pinned version of, say, '1.2.3', if you use the '--save' flag, we'll save it to config.xml as '^1.2.3', like npm currently doe (in other words... 'allow any backwardly compatible version'). This means adding the platform later could end up with a later version (even with the minor version greater than 2 in this example). Perhaps we need to be consistent here - if we change pinned version to use the form '1.2.x', then should we save exactly that to config.xml? Or alternatively should we use the form '^1.2.3' for our pinned version, which will introduce a lot more variation, but will be more consistent with how semver and npm work? Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-8752 Adds docs for hooks functionali...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9004 Russian translation
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-8960 Add docs for AppendUserAgent, O...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-8486 docs for windows packaging
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9006 Fix Russian headers correctly
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] WP8 mobilespec failing to get created (CB-9021)
Mobilespec builds it by design, I think, to use the latest version of cordova.js. Is that undesired behaviour? We're always using the master version of cordova-wp8 in periodic CI builds. Kindly, Dmitry On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote: What version of cordova-wp8 are you testing? The failure seems like is doing what it should ... cordova-wp8@4.0.0 should not be able to install cordova-plugin-file-transfer@4.0.0 Also, why is createmobilespec always building cordova-js? I would expect this to sporadically break. @purplecabbage risingj.com On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/94 CB-8879 fix stripe issue with correct aspect ratio This fixes the stripe issue we had on windows phone 8+. The fix was to set up resolutions with a common aspect ratio. Default aspect ratio is 1.78 (hd). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-8879 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit 4710faa91d86e46df1d66c24080b55cd8d86d459 Author: Murat Sutunc sut...@gmail.com Date: 2015-05-12T00:09:43Z CB-8879 fix stripe issue with correct aspect ratio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Should pinned platforms allow for patch updates?
For platform releases, we would have to test it with the oldest version of the CLI that could potentially pull it down. This one worries me a bit in terms of the testing burden and the version matrix that we will need to support. Totally in favor of having patch versions be available right away without requiring a tools release. Thanks, Nikhil -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Tuesday, May 12, 2015 3:38 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Should pinned platforms allow for patch updates? +1 on loosening the grip on platform pinning On Tue, May 12, 2015 at 3:21 PM, Steven Gill stevengil...@gmail.com wrote: I am totally on board with --save flag saving '^1.2.3' in config.xml since it mimics the behavior of npm --save. No need to change anything. The more I think about it, the more I think we should loosen our grips on platform pinning. As long as we are being semver compliant for all of our platforms, we shouldn't run into issues. I like the idea of changing our pins to `^1.2.3` so it respects major only. It would grab the newest released version of the platform with the same major. This would only impact new projects or projects that are adding a platform for the first time. Existing projects would still have to cordova platform rm PLATFORM and cordova platform add PLATFORM to get the latest platform. One of the reasons we originally wanted to keep pinning was so we could easily help users when they tell us what version of Cordova they are having problems with. With the ability to add whatever version of platforms via `cordova platform add windows@VERSION`, knowing the cli version doesn't give us the details we want. Users can get installed platform versions with `cordova platform ls`. If we make this change, we should review our fetch/cache logic to see if it would grab the latest if an older version exists). We seem to have a fairly good track record with newer platform versions working with older CLI versions. Everytime we do a tools release, we could update the pinned versions to the latest released ones/newest version cli was tested with at release time. For platform releases, we would have to test it with the oldest version of the CLI that could potentially pull it down. What do others think? On Tue, May 12, 2015 at 6:36 AM, Tim Barham tim.bar...@microsoft.com wrote: ?Currently our pinned platforms are all in the form 1.2.3, which I expect means we'll always get that exact version. Should we instead use the form 1.2.x to allow for patches without having to do a tools release? BTW... When you add a platform, and we use the pinned version of, say, '1.2.3', if you use the '--save' flag, we'll save it to config.xml as '^1.2.3', like npm currently doe (in other words... 'allow any backwardly compatible version'). This means adding the platform later could end up with a later version (even with the minor version greater than 2 in this example). Perhaps we need to be consistent here - if we change pinned version to use the form '1.2.x', then should we save exactly that to config.xml? Or alternatively should we use the form '^1.2.3' for our pinned version, which will introduce a lot more variation, but will be more consistent with how semver and npm work? Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[CI] WP8 mobilespec failing to get created (CB-9021)
Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry
RE: [CI] WP8 mobilespec failing to get created (CB-9021)
On the flip side, if we do not update cordova-js with the latest on its master, we would have found this bug https://issues.apache.org/jira/browse/CB-8996 much later - only when the cordova.js would have merged to the platform repo - which I believe happens only around the time of a release? Here's the real failure: Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin doesn't support this project's cordova-wp8 version. cordova-wp8: 4.0.0-dev, failed version requirement: =4.0.0 Looks like cordova-lib's version comparison using semver, which does not recognize 'dev' in the version of WP8 and fails: if ( semver.satisfies(engine.currentVersion, engine.minVersion) || engine.currentVersion === null ) { // engine ok! } else { var msg = 'Plugin doesn\'t support this project\'s ' + engine.name + ' version. ' + engine.name + ': ' + engine.currentVersion + ', failed version requirement: ' + engine.minVersion; return Q.reject(new CordovaError(msg)); } Should the code for cordova-lib be updated to strip out '-dev' suffix? -Nikhil -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, May 12, 2015 4:30 PM To: dev@cordova.apache.org Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021) I am not entirely sure what the best approach is, personally I would just expect it to build with the cordova.js installed by the version. There is no guarantee that platforms and cordova-js are in sync at any given time. Maybe we should put this behind a flag and have the CI run it both with and without ... not sure. @purplecabbage risingj.com On Tue, May 12, 2015 at 3:56 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Mobilespec builds it by design, I think, to use the latest version of cordova.js. Is that undesired behaviour? We're always using the master version of cordova-wp8 in periodic CI builds. Kindly, Dmitry On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote: What version of cordova-wp8 are you testing? The failure seems like is doing what it should ... cordova-wp8@4.0.0 should not be able to install cordova-plugin-file-transfer@4.0.0 Also, why is createmobilespec always building cordova-js? I would expect this to sporadically break. @purplecabbage risingj.com On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] WP8 mobilespec failing to get created (CB-9021)
What version of cordova-wp8 are you testing? The failure seems like is doing what it should ... cordova-wp8@4.0.0 should not be able to install cordova-plugin-file-transfer@4.0.0 Also, why is createmobilespec always building cordova-js? I would expect this to sporadically break. @purplecabbage risingj.com On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi all, Mobilespec is failing to get created on WP8 because there is an issue with dependencies in package.json. I’ve created a JIRA: https://issues.apache.org/jira/browse/CB-9021. Kindly, Dmitry
Re: [DISCUSS] Should pinned platforms allow for patch updates?
I am totally on board with --save flag saving '^1.2.3' in config.xml since it mimics the behavior of npm --save. No need to change anything. The more I think about it, the more I think we should loosen our grips on platform pinning. As long as we are being semver compliant for all of our platforms, we shouldn't run into issues. I like the idea of changing our pins to `^1.2.3` so it respects major only. It would grab the newest released version of the platform with the same major. This would only impact new projects or projects that are adding a platform for the first time. Existing projects would still have to cordova platform rm PLATFORM and cordova platform add PLATFORM to get the latest platform. One of the reasons we originally wanted to keep pinning was so we could easily help users when they tell us what version of Cordova they are having problems with. With the ability to add whatever version of platforms via `cordova platform add windows@VERSION`, knowing the cli version doesn't give us the details we want. Users can get installed platform versions with `cordova platform ls`. If we make this change, we should review our fetch/cache logic to see if it would grab the latest if an older version exists). We seem to have a fairly good track record with newer platform versions working with older CLI versions. Everytime we do a tools release, we could update the pinned versions to the latest released ones/newest version cli was tested with at release time. For platform releases, we would have to test it with the oldest version of the CLI that could potentially pull it down. What do others think? On Tue, May 12, 2015 at 6:36 AM, Tim Barham tim.bar...@microsoft.com wrote: ?Currently our pinned platforms are all in the form 1.2.3, which I expect means we'll always get that exact version. Should we instead use the form 1.2.x to allow for patches without having to do a tools release? BTW... When you add a platform, and we use the pinned version of, say, '1.2.3', if you use the '--save' flag, we'll save it to config.xml as '^1.2.3', like npm currently doe (in other words... 'allow any backwardly compatible version'). This means adding the platform later could end up with a later version (even with the minor version greater than 2 in this example). Perhaps we need to be consistent here - if we change pinned version to use the form '1.2.x', then should we save exactly that to config.xml? Or alternatively should we use the form '^1.2.3' for our pinned version, which will introduce a lot more variation, but will be more consistent with how semver and npm work? Thanks! Tim
[ios-deploy] version 1.6.0 released
Release notes: https://github.com/phonegap/ios-deploy/releases/tag/1.6.0 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova 5.0 user feedback - move to npm whitelist plugin
On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to npm whitelist plugin (1) older versions of our docs point to plugins.cordova.io for plugin documentation. We haven't pointed people to github for plugin docs. Those docs are accurate with the ID of the plugin. Adding a section to the readme about needing cordova 5+ isn't a bad idea. [NK] There are places that this is not true. http://cordova.apache.org/docs/en/4.0.0/guide_support_index.md.html#Platform%20Support . The plan is to switch our tools to grab from npm first and CPR second. I believe we discussed doing this around the time CPR goes read only. Giving IDE's and people using older versions a chance to upgrade. We can publish updated plugins to CPR, but it is going to be quite a bit of work. I created old-id branches for our core plugins that revert the commits changing the ID and the commits where I change internal plugin references from org.apache.cordova.* to cordova-plugin-*. It was a fairly large change. The reason for the major jump was the plugin id change. I'd recommend them sticking the versioning they are on instead of copying the version of the npm series. The major version bump wasn't due to a change in functionality in the plugins themselves. If we want to release updated plugins to CPR, someone will need to do the work to cherry-pick the new commits into old-id and do a separate vote for them. [NK] I understand this is a lot of work. Alternatlively, shall we change the behavior of the CLI to use npm first - even for old ids - perhaps, as part of 5.1 tools release? There is not much value in old Ids causing stale, old version of plugin getting downloaded from CPR. (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will auto include the whitelist plugin due to the hello world config.xml including it as a dependency. I think we need to document it more and make more noise within the community about it. iOS 4.0 will also require the whitelist plugin when it gets released. The more prepared we are, the better. As for re-enabling network access by default, I wasn't really part of the original thread so I will leave it to the people who were to discuss that further. [NK] I agree that making more noise is the right short term move to help people upgrading to 5.0 realize this. I still believe that network access should be enabled in the platform by default without any plugins. For controlling network access, devs should either use CSP or a whitelist plugin that gets the chance to override the networking behavior. Andrew, Michael, and Ian are most familiar with the decision around this. http://markmail.org/search/?q=Android%27s+new+Whitelist+Plugins#query:Android%27s%20new%20Whitelist%20Plugins+page:1+mid:z2r2sj5e3kvrnqv6+state:results Additionally, on prepare, platforms should see the use of access tags and encourage users to use one of the whitelist plugins if they have not already done so. I agree that needing the new whitelist plugin to make network calls is unfortunate. I know Ian really wanted everything to secure by default, and having network access via a plugin means you can update the plugin separately if there are bugs. I think it might be a bit late to change things now though. Better to just stick with it rather than changing things again and again. On Thu, May 7, 2015 at 8:55 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: There is a bunch of confusion with Cordova 5.0 users because of these two changes: 1. Move to npm for plugins (There have been multiple PRs trying to update plugin docs to reference the old id instead of the new one - because people are still using the old version of the CLI) 2. No network access in Android 4.0 without whitelist plugin: - https://issues.apache.org/jira/browse/CB-8969 - http://stackoverflow.com/questions/29735597/cordova-5-0-0-android-app- can-not-connect-to-internet-using-android-4-0-0 - http://stackoverflow.com/questions/30060534/ajax-requests-fail-after-u pgrading-to-cordova-5-0-cordova-android4-0 I think for the (1), I suggest we do the following: 1. Update the plugin documentation that the old id can be used for older CLI versions. 2. Either update the CPM with 1.0 versions of the plugins or have the CLI get core plugins from npm first then CPR even with the old id. Using the old id because they were hardcoded in IDEs etc, devs are getting older version of the plugins. For (2), I think we should re-visit making whitelist part of the Android platform again or some other way of enabling network access by default. No network access (XHR) for a platform by
[GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-js/pull/110 CB-8996 (Windows) Fixed invalid null comparison https://issues.apache.org/jira/browse/CB-8996 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-js CB-8996 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/110.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #110 commit aeb23a9270e2a276d8d6e1a408c8e8f37f9c58d5 Author: alsorokin alexander.soro...@akvelon.com Date: 2015-05-12T13:32:02Z CB-8996 (Windows) Fixed invalid null comparison --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [CI] Windows Build Still Broken
Hi Dmitry, It turned out to be a regression in cordova-js caused by this commit: https://github.com/apache/cordova-js/commit/867fcac79d82823b356a771ce5aaf52e057a2319#diff-94c2e7d53ca6fc7837eddee66fdf4a52R64 I've fixed it and created a PR: https://github.com/apache/cordova-js/pull/110 Thanks, Alexander Sorokin -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Monday, May 11, 2015 21:20 To: dev@cordova.apache.org Subject: [CI] Windows Build Still Broken Hi all, The Windows build is still broken due to CB-8999. Has mobilespec been running for anyone else on Windows? Alex Sorokin noted that the bug is due to the deviceready event not being fired, and pointed out that this happens on mobilespec, but not on the helloworld app. Would anyone like to volunteer to take the JIRA? If nobody responds in the next 6 hours, I’ll take it. Kindly, DmitryB�CB��[��X��ܚX�KK[XZ[ �]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[ �]�Z[�ܙݘK�\X�K�ܙ�B
[DISCUSS] Should pinned platforms allow for patch updates?
?Currently our pinned platforms are all in the form 1.2.3, which I expect means we'll always get that exact version. Should we instead use the form 1.2.x to allow for patches without having to do a tools release? BTW... When you add a platform, and we use the pinned version of, say, '1.2.3', if you use the '--save' flag, we'll save it to config.xml as '^1.2.3', like npm currently doe (in other words... 'allow any backwardly compatible version'). This means adding the platform later could end up with a later version (even with the minor version greater than 2 in this example). Perhaps we need to be consistent here - if we change pinned version to use the form '1.2.x', then should we save exactly that to config.xml? Or alternatively should we use the form '^1.2.3' for our pinned version, which will introduce a lot more variation, but will be more consistent with how semver and npm work? Thanks! Tim
Re: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release
Hey a question about 'coho verify-tags' - this is the first time I've used it. Anyone else here using it with a standard Windows command window? There is no way to enter an EOF, which is required to trigger it to parse the tags/hashes you've provided (I ended up hacking the source a bit to get it to work). From: Steven Gill stevengil...@gmail.com Sent: Saturday, May 9, 2015 8:01 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release Release issue: https://issues.apache.org/jira/browse/CB-8997 Going to get this out today. I think the pinned platform discussion should get its own thread. If I recall correctly, it was done so it would be easier to identify which platforms are working with which tool versions. If we are staying true to semver though, having the patch version be variable seems fine to me. On Wed, May 6, 2015 at 3:28 PM, Tim Barham tim.bar...@microsoft.com wrote: Sounds good to me. Once this is done, will we need to do a tools release to update pinned platforms (which makes me wonder - should we set the version of pinned platforms to something like 4.0.x so we don't need to update tools when we do a platform patch release)? From: Steven Gill stevengil...@gmail.com Sent: Thursday, May 7, 2015 5:00 AM To: dev@cordova.apache.org Subject: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release Need to do patch releases for these three platforms with updated cordova.js files due to bug with ripple https://issues.apache.org/jira/browse/RIPPLE-82 . I will do it on the respective release branches and not master so new changes won't make it into these releases. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases
I vote +1 * Verified archive sigs and hashes ('coho verify-archive'). * Verified tag sha1s ('coho verify-tags'). * Verified can build and run blank app for each platform. * Verified tests were green (windows and wp8). * Verified android platform now works in Ripple. Thanks, Tim From: Sergey Grebnov (Akvelon) v-seg...@microsoft.com Sent: Tuesday, May 12, 2015 5:27 PM To: dev@cordova.apache.org Subject: RE: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases I vote +1 * Verified blank app can be successfully built and run (Android, Windows, WP8) * Ran autotests * Verified compatibility with core plugins Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, May 12, 2015 3:12 AM To: dev@cordova.apache.org Subject: Re: [Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases bump. On Fri, May 8, 2015 at 5:11 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on these releases by replying to this email (and keep discussion on the DISCUSS thread) These releases are just including an updated snapshot of cordova.js so it works with ripple again. Release issue: https://issues.apache.org/jira/browse/CB-8997 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8997 The package was published from its corresponding git tag: cordova-android: 4.0.1 (6b7eaf2386) cordova-wp8: 3.8.1 (0a099394ab) cordova-windows: 3.8.2 (eb4e7125e0) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#4.0.1 cordova platform add https://github.com/apache/cordova-wp8#3.8.1cordova platform add https://github.com/apache/cordova-windows#3.8.2 Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova 5.0 user feedback - move to npm whitelist plugin
So query - I thought the whitelist plugin was being added because it was in the default Cordova sample config.xml - but when I built a new project and used --copy-from, it *also* installed the plugin. So is it just *always* added? On Tue, May 12, 2015 at 9:21 AM, Andrew Grieve agri...@chromium.org wrote: On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to npm whitelist plugin (1) older versions of our docs point to plugins.cordova.io for plugin documentation. We haven't pointed people to github for plugin docs. Those docs are accurate with the ID of the plugin. Adding a section to the readme about needing cordova 5+ isn't a bad idea. [NK] There are places that this is not true. http://cordova.apache.org/docs/en/4.0.0/guide_support_index.md.html#Platform%20Support . The plan is to switch our tools to grab from npm first and CPR second. I believe we discussed doing this around the time CPR goes read only. Giving IDE's and people using older versions a chance to upgrade. We can publish updated plugins to CPR, but it is going to be quite a bit of work. I created old-id branches for our core plugins that revert the commits changing the ID and the commits where I change internal plugin references from org.apache.cordova.* to cordova-plugin-*. It was a fairly large change. The reason for the major jump was the plugin id change. I'd recommend them sticking the versioning they are on instead of copying the version of the npm series. The major version bump wasn't due to a change in functionality in the plugins themselves. If we want to release updated plugins to CPR, someone will need to do the work to cherry-pick the new commits into old-id and do a separate vote for them. [NK] I understand this is a lot of work. Alternatlively, shall we change the behavior of the CLI to use npm first - even for old ids - perhaps, as part of 5.1 tools release? There is not much value in old Ids causing stale, old version of plugin getting downloaded from CPR. (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will auto include the whitelist plugin due to the hello world config.xml including it as a dependency. I think we need to document it more and make more noise within the community about it. iOS 4.0 will also require the whitelist plugin when it gets released. The more prepared we are, the better. As for re-enabling network access by default, I wasn't really part of the original thread so I will leave it to the people who were to discuss that further. [NK] I agree that making more noise is the right short term move to help people upgrading to 5.0 realize this. I still believe that network access should be enabled in the platform by default without any plugins. For controlling network access, devs should either use CSP or a whitelist plugin that gets the chance to override the networking behavior. Andrew, Michael, and Ian are most familiar with the decision around this. http://markmail.org/search/?q=Android%27s+new+Whitelist+Plugins#query:Android%27s%20new%20Whitelist%20Plugins+page:1+mid:z2r2sj5e3kvrnqv6+state:results Additionally, on prepare, platforms should see the use of access tags and encourage users to use one of the whitelist plugins if they have not already done so. I agree that needing the new whitelist plugin to make network calls is unfortunate. I know Ian really wanted everything to secure by default, and having network access via a plugin means you can update the plugin separately if there are bugs. I think it might be a bit late to change things now though. Better to just stick with it rather than changing things again and again. On Thu, May 7, 2015 at 8:55 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: There is a bunch of confusion with Cordova 5.0 users because of these two changes: 1. Move to npm for plugins (There have been multiple PRs trying to update plugin docs to reference the old id instead of the new one - because people are still using the old version of the CLI) 2. No network access in Android 4.0 without whitelist plugin: - https://issues.apache.org/jira/browse/CB-8969 - http://stackoverflow.com/questions/29735597/cordova-5-0-0-android-app- can-not-connect-to-internet-using-android-4-0-0 - http://stackoverflow.com/questions/30060534/ajax-requests-fail-after-u pgrading-to-cordova-5-0-cordova-android4-0 I think for the (1), I suggest we do the following: 1. Update the plugin documentation that the old id can be used for older CLI versions. 2. Either update the CPM with 1.0 versions of the plugins or have the CLI get core plugins from npm first then CPR even with the
[GitHub] cordova-plugin-media pull request: iOS play audio in background
Github user gerwinbrunner commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-101324760 Hi, is anybody able to pick this up and create a fix for this? It seems to be quite an issue and a lot of people are experiencing this problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org