[GitHub] cordova-lib pull request: CB-9436 Removes `require-tr` bundle tran...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/275#discussion_r36097029
--- Diff: cordova-lib/src/plugman/prepare-browserify.js ---
@@ -21,7 +21,7 @@
var platform_modules = require('../platforms/platforms'),
path = require('path'),
-through= require('through2'),
+aliasify = require('aliasify'),
--- End diff --
Should the 'through2' dependency be removed from package.json?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-127279861 @dblotsky, rebased and tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Is it possible to create Android Widget for Cordova Android App
Hi, It will be great if anyone can point me to steps for creating Android Widget for Cordova Application. I would like to know if its possible or not. If not then is there any plan to have that feature in nearby future. Thanks Regards Piyush Khare piyush.khar...@gmail.com +91-9900911091, +91-9889484112
[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/57#issuecomment-127279922 @dblotsky, rebased and tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update index.md
GitHub user maxdeepfield opened a pull request: https://github.com/apache/cordova-docs/pull/301 Update index.md some typo fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/maxdeepfield/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/301.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #301 commit a3e37a0475d589910e25fed5b7d39543a9195e8c Author: Max Deepfield maxdeepfi...@absolutefreakout.com Date: 2015-08-03T15:57:20Z Update index.md some typo fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: New Contributor - Introduction
Welcome Arun Go Wolfpack !! I also did my masters at NCSU You can start here: http://wiki.apache.org/cordova/ContributorWorkflow also committer workflow might be interesting for you since you are going to dedicate time https://github.com/apache/cordova-coho/blob/master/docs/committer-workflow.md Let use know what area you want to focus, and we can point you to the correct repo, we have many to contribute On Sun, Aug 2, 2015 at 8:07 PM Arun Purushothaman engraru...@gmail.com wrote: Hello, My name is Arun Purushothaman and I am interested in contributing to the Apache Software Foundation. A little bit of my background: I am currently working in Oracle as a Software engineer and I write code day in, day out. I write mobile applications using Oracle Mobile Application Framework which in turn uses Apache Cordova to render the UI. That is how I fell in love with the Apache Cordova libraries. In my day to day job, I deal with Java, Javascript, HTML and CSS. I also have a Master's degree in Computer Science from North Carolina State University and a bachelor's degree in Electrical Engineering from B.M.S. College of Engineering, Bangalore, India. I plan to contribute on a regular basis to Apache Cordova project by fixing bugs/ developing enhancements. And above all I look forward to meet some of the great minds working on this wonderful project. Looking forward for working with you guys! -- Best Wishes, Arun Purushothaman
Re: [Vote] 4.1.1 Android Release
Steve I think it's even better since the update affects cli. On Mon, Aug 3, 2015 at 5:26 PM Steven Gill stevengil...@gmail.com wrote: one more vote please! Carlos, I will definitely tweet it and mention it in the tools release blog post. -Steve On Sat, Aug 1, 2015 at 5:46 AM, Carlos Santana csantan...@gmail.com wrote: Thanks Steve, I was in the middle of updating the script when I saw this :-) I vote +1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` * Re-created archives to ensure contents match release candidate * Verify issue CB-9428 (master)$ cordova platform update ../../vote-android411/package/ Updating android project... Updating minSdkVersion from 10 to 14 in AndroidManifest.xml Android project updated with cordova-android@4.1.1 Hello Cordova builds and runs with 4.1.1 Might want to consider a blog post or tweet for those lost soles that did cordova platform update :-). Also not miss the drumb bit on continues releases On Fri, Jul 31, 2015 at 8:01 PM Steven Gill stevengil...@gmail.com wrote: Please review and vote on this 4.1.1 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9437 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9437 The package was published from its corresponding git tag: cordova-android: 4.1.1 (6cda55b35f) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#4.1.1 I'm probably going to skip the blog post as this update was just getting cordova platform update android to update the minSDKVersion to 14 if it was lower. See https://issues.apache.org/jira/browse/CB-9428 Upon a successful vote I will upload the archive to dist/, and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured continuous build was green when repo was tagged
[GitHub] cordova-ubuntu pull request: CB-8965 Copy cordova-js-src directory...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request:
Github user muratsu commented on the pull request: https://github.com/apache/cordova-lib/commit/52ef1c586d3e3b2bb4b7447408a01c00c668cc74#commitcomment-12506160 In cordova-lib/spec-cordova/save.spec.js: In cordova-lib/spec-cordova/save.spec.js on line 491: `except(err.message).toBe(null);` more concise? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/124#discussion_r36151389
--- Diff: tasks/lib/bundle-browserify.js ---
@@ -19,53 +19,63 @@
var fs = require('fs');
var path = require('path');
var browserify = require('browserify');
-var require_tr = require('./require-tr');
var root = path.join(__dirname, '..', '..');
var pkgJson = require('../../package.json');
var collectFiles = require('./collect-files');
var copyProps= require('./copy-props');
-module.exports = function bundle(platform, debug, commitId,
platformVersion) {
-require_tr.platform = platform;
-// FIXME: need to find a way to void ignore missing
-var b = browserify({debug: debug});
-// XXX plugin_list is not present at this stage
-b.ignore(path.join(root, 'src', 'common', 'plugin_list'));
+module.exports = function bundle(platform, debug, commitId,
platformVersion, platformPath) {
+platformPath = fs.existsSync(platformPath)
fs.existsSync(path.join(platformPath, 'cordova-js-src')) ?
+path.join(platformPath, 'cordova-js-src') :
+path.resolve(root, 'src', 'legacy-exec', platform);
-b.transform(require_tr.transform, {'platform': platform});
+var platformDirname = platform === 'amazon-fireos' ? 'android' :
platform;
--- End diff --
hahaha smart
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9436 Removes `require-tr` bundle tran...
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/275#issuecomment-127452233
Vladimir! This is a much needed refactor and it looks great! Thank you! The
previous spaghetti code was becoming hard to manage and understand.
Things I like:
* Using `cordova_plugins.js` in the browserify build and removing
`cordova_requires`
* Adding the module name field in `cordova_plugins.js` for each module.
* Using browserify expose to map `cordova/plugin_list` to
`cordova_plugins.js`. (Didn't even know about expose)
* Great find with aliasify! Much cleaner way to handle the bad legacy
requires in plugins compared to using requiresTr.
Quick Question without digging to deep:
* Wondering why you had to add require('codrdova/init') to the bundle?
https://github.com/MSOpenTech/cordova-lib/commit/510516135ef41b735b2e610c1b8d95fc77bd571e#diff-28a16640f3807e6ee2300ea7ce8c2f1dR196.
How was that getting added previously?
I think you fixed all of the remaining bugs with your changes.
@surajpindoria will continue to test on all of the devices we have here to see
if we can find bugs.
I am going to dive deeper into your cordova.js changes now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user rgecy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/111#issuecomment-127426047 How do I unsubscribe from this plugin list. I do not want to get emails on every update. On Aug 3, 2015 6:48 PM, asfgit notificati...@github.com wrote: Closed #111 https://github.com/apache/cordova-plugin-camera/pull/111 via ee5cfe8 https://github.com/apache/cordova-plugin-camera/commit/ee5cfe89a594ba8a86ca36fe67e7a040cc3d5e17 . â Reply to this email directly or view it on GitHub https://github.com/apache/cordova-plugin-camera/pull/111#event-372512038 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-firefoxos pull request: CB-8965 Copy cordova-js-src to pla...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-js/pull/124#discussion_r36151308
--- Diff: tasks/lib/packager-browserify.js ---
@@ -46,25 +37,13 @@ module.exports = function generate(platform,
useWindowsLineEndings, platformVers
outReleaseFile = path.join('pkg', 'cordova.' + platform + '.js');
outReleaseFileStream = fs.createWriteStream(outReleaseFile);
-var symbolList = null;
-var addSymbolList = through.obj(function(row, enc, next) {
-if(symbolList === null) {
-symbolList = requireTr.getModules(platform);
-this.push(util.format('var symbolList = %s;\n%s\n',
JSON.stringify(symbolList, null, 4), row));
-} else {
-this.push(row);
-}
-next();
-});
-
-libraryRelease.pipeline.get('wrap').push(addSymbolList);
-
// write license header
writeLicenseHeader(outReleaseFileStream, platform, commitId,
platformVersion);
-releaseBundle = libraryRelease.bundle();
-
-releaseBundle.pipe(outReleaseFileStream);
+bundle(platform, false, commitId, platformVersion, platformPath)
+ .add(path.resolve(__dirname, '..', '..',
'src/scripts/bootstrap.js'))
--- End diff --
You add bootstrap.js here which has require('cordova/init') in it. But you
also manually add require('cordova/init') in the form of init.js when adding
plugins using cordova prepare --browserify.
https://github.com/MSOpenTech/cordova-lib/commit/510516135ef41b735b2e610c1b8d95fc77bd571e#diff-28a16640f3807e6ee2300ea7ce8c2f1dR196
Are they both needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update index.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-blackberry pull request: CB-8965 Copy cordova-js-src direc...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-blackberry pull request: Icons outside www
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Correct image resolution selec...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9278: Tests to prevent future regress...
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/276 CB-9278: Tests to prevent future regressions while restoring multiple platforms Tests to prevent future regressions while restoring multiple platforms. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9278-Tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/276.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #276 commit 52ef1c586d3e3b2bb4b7447408a01c00c668cc74 Author: Omar Mefire omef...@gmail.com Date: 2015-08-04T00:37:04Z CB-9278: Tests to prevent future regressions while restoring multiple platforms --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9278: Tests to prevent future regress...
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/276#issuecomment-127442176 @muratsu, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Try to use realpath filename i...
Github user schreyers commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/99#issuecomment-127485107 Hi Nantunes, Did you manage to use the realpath filename and if so which version of the plugin is it in is this in? There is a current bug which means images get uploaded as duplicates because of the file name still being modified.jpg for all the edited images. https://stackoverflow.com/questions/30438483/cordova-image-upload-duplicate-issue# I have recently re-added the plugin but I still get the issue that edited images are called modified.jpg. Thanks, Jon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/111#issuecomment-127409849 Sorry didn't see your comment earlier. In terms of perf, I think this the usage of `if/else` vs `switch` is not really important here. Since we're only executing it once, the perf difference is not going to be noticable either case. Readability is a bit more subjective - I don't have a preference in this case. I tend to use switches only when I have fall-through cases. I wasn't familiar with `switch(true)` pattern. It seemed like an anti-pattern to me at first but looks like it is a common pattern in dynamic languages. I'll revert it back to switch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 4.1.1 Android Release
one more vote please! Carlos, I will definitely tweet it and mention it in the tools release blog post. -Steve On Sat, Aug 1, 2015 at 5:46 AM, Carlos Santana csantan...@gmail.com wrote: Thanks Steve, I was in the middle of updating the script when I saw this :-) I vote +1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` * Re-created archives to ensure contents match release candidate * Verify issue CB-9428 (master)$ cordova platform update ../../vote-android411/package/ Updating android project... Updating minSdkVersion from 10 to 14 in AndroidManifest.xml Android project updated with cordova-android@4.1.1 Hello Cordova builds and runs with 4.1.1 Might want to consider a blog post or tweet for those lost soles that did cordova platform update :-). Also not miss the drumb bit on continues releases On Fri, Jul 31, 2015 at 8:01 PM Steven Gill stevengil...@gmail.com wrote: Please review and vote on this 4.1.1 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9437 The archive has been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9437 The package was published from its corresponding git tag: cordova-android: 4.1.1 (6cda55b35f) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-android#4.1.1 I'm probably going to skip the blog post as this update was just getting cordova platform update android to update the minSDKVersion to 14 if it was lower. See https://issues.apache.org/jira/browse/CB-9428 Upon a successful vote I will upload the archive to dist/, and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured continuous build was green when repo was tagged
[GitHub] cordova-windows pull request: CB-8965 Copy cordova-js-src director...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8965 Copy cordova-js-src director...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] CI Hardware
Yes, the machine can be behind a firewall. The slaves initiate all the conversations: they connect to the master, they request work from it, and they report results back to it. I don’t think we can do the last point though: slaves get work whenever it’s available, not on any schedule of their own. Why do you need them to only do work a few times per day? Kindly, Dmitry On Aug 1, 2015, at 4:09 AM, Carlos Santana csantan...@gmail.commailto:csantan...@gmail.com wrote: No progress we are at end of release right now. Maybe next month I might have an update, I'm trying to see if I can added to the test plan of our Q4 release You said that machine can be behind firewall? Our machines can go out but can't be reach from the outside. Is there a way to configure to check for new content once a day run tests and then report out? - Carlos Sent from my iPhone On Jul 31, 2015, at 10:58 PM, Dmitry Blotsky dblot...@microsoft.commailto:dblot...@microsoft.com wrote: Ping, folks. What’s the progress? @Jesse @Carlos @Joe? Kindly, Dmitry On Jul 17, 2015, at 4:08 PM, Dmitry Blotsky dblot...@microsoft.commailto:dblot...@microsoft.com wrote: Hi all, As per the hangout, please respond to this thread with machines and devices you can hook up to the CI. Also please list relevant info like hardware capabilities of the machines and devices. For example, our hardware is as follows: - cordova-windows-slave - 8GB RAM - Core i7 ~2.5GHz - Windows 8.1 - Devices: - Android 19 Emulator - Windows Phone 8 Emulator - Windows Phone 8.1 Emulator - Windows 8.1 Device (the machine itself) - cordova-ios-slave - 8GB RAM - OS X Yosemite - Devices: - iPhone 5s Simulator - Android 19 Emulator Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.orgmailto:dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.orgmailto:dev-h...@cordova.apache.org B‹CB•È [œÝXœØÜšX™KK[XZ[ˆ]‹][œÝXœØÜšX™PÛܙݘK˜\XÚK›Ü™ÃB‘›ÜˆY][Û˜[ÛÛ[X[™ ËK[XZ[ˆ]‹Z[ ÛܙݘK˜\XÚK›Ü™ÃB - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.orgmailto:dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.orgmailto:dev-h...@cordova.apache.org
RE: [DISCUSS] cordova-ios 3.9.0 release
I've moved release package to cordova-dist, but can NOT publish it to npm due to insufficient rights. Could someone grant me w/ write access (sgrebnov, https://www.npmjs.com/package/cordova-ios) or publish the package(cordova-dist/platforms/cordova-ios-3.9.0.tgz)? Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Thursday, July 30, 2015 12:19 PM To: 'dev@cordova.apache.org' dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Release blog post for review: https://github.com/cordova/apache-blog-posts/pull/42 Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Monday, July 27, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Please review prepared release branch[1] and release notes[2]. Does anyone have any reason to delay a cordova-ios platform release? Any outstanding patches to land? If not, I will start the release voting tomorrow. [1] https://github.com/apache/cordova-ios/commits/3.9.x [2] https://github.com/apache/cordova-ios/commit/a89fe4ed3550527eea51d6b2015e42d6398c9733 Thx! Sergey -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, July 17, 2015 7:27 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release +1. Yes, let's do it. Thanks, Shaz! Let me know if I can help here - though I still don’t have good judgement on iOS on what should go out and what should not. Thanks, Nikhil -Original Message- From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] Sent: Thursday, July 16, 2015 11:27 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-ios 3.9.0 release +1 2015-07-17 6:24 GMT+02:00 Carlos Santana csantan...@gmail.com: +1 I think MS mentioned they wanted to cherry pick the signing using build.json On Thu, Jul 16, 2015 at 7:25 PM Shazron shaz...@gmail.com wrote: From the hangout today someone mentioned fixes that need to go out, 4.x was holding this back (and won't be ready at least not within the next 4 wks). I'll be away for the next few weeks so I can't help out on this. I'd say branch off 3.8.x and cherry-pick commits in. Thoughts? B�CB�� [��X��ܚX�KK[XZ[ �]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[� �K[XZ[ �]�Z[ �ܙݘK�\X�K�ܙ�B
Re: [CI] Medic Update
Good idea. Will add that. As far as I know, it’s 0.12.x, where I’m not yet certain about the “x. On Aug 1, 2015, at 12:03 AM, Jesse purplecabb...@gmail.com wrote: What version of node are the windows build environments running? Was this updated recently? Can we get a `node -v` added to the log output? My team is hiring! @purplecabbage risingj.com On Fri, Jul 31, 2015 at 8:07 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, TL;DR: Please contribute to the CI device fleet. Also is nobody testing on Windows? These past two week’s updates regarding CI: - Windows runs are *all* crashing; who is looking into this? - per-commit builds are still waiting on Apache Infra (INFRA-9979) - per-PR builds are in the same bucket as above (INFRA-9243, INFRA-9811, INFRA-9678) Test status (for succeeding builds): 1 on Android on Windows 1 on Android on OS X 0 on WP8 24 on iOS Calls to action: - fix the Windows crashes - connect slaves as per [DISCUSS] CI Hardware” thread Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Vote] 3.9.0 iOS Release
The vote has now closed. The results are: Positive Binding Votes: 3 - Steven Gill - Vladimir Kotikov - Sergey Grebnov Negative Binding Votes: 0 The vote has passed. Thanks, Sergey -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Thursday, July 30, 2015 9:24 AM To: dev@cordova.apache.org Subject: RE: [Vote] 3.9.0 iOS Release I vote +1 * Verified archives via `coho verify-archive` * Verified that blank app creates correctly with platform * Verified that blank app can be successfully ran and built * Ran smoke testing of mobilespec app (ran autotests) --- Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, 30 July, 2015 2:57 To: dev@cordova.apache.org Subject: Re: [Vote] 3.9.0 iOS Release +1 Ran coho verify Created cordova project, added device plugin. Had to update ios-sim to 4.0 so I could run cordova run ios. Got a nice message telling me to do that. Cordova requirements is a nice command. On Tue, Jul 28, 2015 at 4:06 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Please review and vote on this 3.9.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9406 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9406 The package was published from its corresponding git tag: cordova-ios: 3.9.0 (209c1e9e02) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-ios#3.9.0 Blog post to review will be sent by separate email to Discuss thread. Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting .md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Performed manual smoke testing: platform could be added and built -Sergey Grebnov - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: New Contributor - Introduction
Hello Carlos, I am glad to be welcomed by a Wolfpack family member! \m/ I have already set up my git repositories and I was able to build my first hello world application using cordova last night. So far everything is very smooth and easy (kudos to the documentation team!) I would like to contribute more towards Cordova-Android project. I cloned this git://git.apache.org/cordova-android.git git repository. Also if you can point me to some simple bugs that I can fix to get my feet wet that would be great! Also any tips/pointers/orientation for a newbie will be highly appreciated. And I was curious to know if you guys happen to have any local meet-up groups ( I live in Orlando, FL) Looking forward to work with you guys! On Mon, Aug 3, 2015 at 10:47 AM, Carlos Santana csantan...@gmail.com wrote: Welcome Arun Go Wolfpack !! I also did my masters at NCSU You can start here: http://wiki.apache.org/cordova/ContributorWorkflow also committer workflow might be interesting for you since you are going to dedicate time https://github.com/apache/cordova-coho/blob/master/docs/committer-workflow.md Let use know what area you want to focus, and we can point you to the correct repo, we have many to contribute On Sun, Aug 2, 2015 at 8:07 PM Arun Purushothaman engraru...@gmail.com wrote: Hello, My name is Arun Purushothaman and I am interested in contributing to the Apache Software Foundation. A little bit of my background: I am currently working in Oracle as a Software engineer and I write code day in, day out. I write mobile applications using Oracle Mobile Application Framework which in turn uses Apache Cordova to render the UI. That is how I fell in love with the Apache Cordova libraries. In my day to day job, I deal with Java, Javascript, HTML and CSS. I also have a Master's degree in Computer Science from North Carolina State University and a bachelor's degree in Electrical Engineering from B.M.S. College of Engineering, Bangalore, India. I plan to contribute on a regular basis to Apache Cordova project by fixing bugs/ developing enhancements. And above all I look forward to meet some of the great minds working on this wonderful project. Looking forward for working with you guys! -- Best Wishes, Arun Purushothaman -- Best Wishes, Arun Purushothaman
[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...
Github user muratsu closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] cordova-ios 3.9.0 release
Added sgrebnov as an owner of cordova-ios npm package. On Mon, Aug 3, 2015 at 4:41 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I've moved release package to cordova-dist, but can NOT publish it to npm due to insufficient rights. Could someone grant me w/ write access (sgrebnov, https://www.npmjs.com/package/cordova-ios) or publish the package(cordova-dist/platforms/cordova-ios-3.9.0.tgz)? Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Thursday, July 30, 2015 12:19 PM To: 'dev@cordova.apache.org' dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Release blog post for review: https://github.com/cordova/apache-blog-posts/pull/42 Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Monday, July 27, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Please review prepared release branch[1] and release notes[2]. Does anyone have any reason to delay a cordova-ios platform release? Any outstanding patches to land? If not, I will start the release voting tomorrow. [1] https://github.com/apache/cordova-ios/commits/3.9.x [2] https://github.com/apache/cordova-ios/commit/a89fe4ed3550527eea51d6b2015e42d6398c9733 Thx! Sergey -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, July 17, 2015 7:27 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release +1. Yes, let's do it. Thanks, Shaz! Let me know if I can help here - though I still don’t have good judgement on iOS on what should go out and what should not. Thanks, Nikhil -Original Message- From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] Sent: Thursday, July 16, 2015 11:27 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-ios 3.9.0 release +1 2015-07-17 6:24 GMT+02:00 Carlos Santana csantan...@gmail.com: +1 I think MS mentioned they wanted to cherry pick the signing using build.json On Thu, Jul 16, 2015 at 7:25 PM Shazron shaz...@gmail.com wrote: From the hangout today someone mentioned fixes that need to go out, 4.x was holding this back (and won't be ready at least not within the next 4 wks). I'll be away for the next few weeks so I can't help out on this. I'd say branch off 3.8.x and cherry-pick commits in. Thoughts? B�CB� � [��X��ܚX�K K[XZ[ � ]�][��X��ܚX�P �ܙ ݘK�\ X� K�ܙ�B��܈ Y ] [ۘ[ ��[X[� � K[XZ[ � ]�Z [ �ܙ ݘK�\ X� K�ܙ�B
RE: [DISCUSS] cordova-ios 3.9.0 release
Thank you Shazron - published cordova-ios@3.9.0 to npm. Thx! Sergey -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Monday, August 3, 2015 8:35 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-ios 3.9.0 release Added sgrebnov as an owner of cordova-ios npm package. On Mon, Aug 3, 2015 at 4:41 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I've moved release package to cordova-dist, but can NOT publish it to npm due to insufficient rights. Could someone grant me w/ write access (sgrebnov, https://www.npmjs.com/package/cordova-ios) or publish the package(cordova-dist/platforms/cordova-ios-3.9.0.tgz)? Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Thursday, July 30, 2015 12:19 PM To: 'dev@cordova.apache.org' dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Release blog post for review: https://github.com/cordova/apache-blog-posts/pull/42 Thx! Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Monday, July 27, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release Please review prepared release branch[1] and release notes[2]. Does anyone have any reason to delay a cordova-ios platform release? Any outstanding patches to land? If not, I will start the release voting tomorrow. [1] https://github.com/apache/cordova-ios/commits/3.9.x [2] https://github.com/apache/cordova-ios/commit/a89fe4ed3550527eea51d6b20 15e42d6398c9733 Thx! Sergey -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, July 17, 2015 7:27 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-ios 3.9.0 release +1. Yes, let's do it. Thanks, Shaz! Let me know if I can help here - though I still don’t have good judgement on iOS on what should go out and what should not. Thanks, Nikhil -Original Message- From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] Sent: Thursday, July 16, 2015 11:27 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-ios 3.9.0 release +1 2015-07-17 6:24 GMT+02:00 Carlos Santana csantan...@gmail.com: +1 I think MS mentioned they wanted to cherry pick the signing using build.json On Thu, Jul 16, 2015 at 7:25 PM Shazron shaz...@gmail.com wrote: From the hangout today someone mentioned fixes that need to go out, 4.x was holding this back (and won't be ready at least not within the next 4 wks). I'll be away for the next few weeks so I can't help out on this. I'd say branch off 3.8.x and cherry-pick commits in. Thoughts? B CB [ X ܚX K K[XZ[ ] ][ X ܚX P ܙ ݘK \ X K ܙ B ܈ Y ] [ۘ[[X[ K[XZ[ ] Z [ܙ ݘK \ X K ܙ B
Record Audio using on Browser platform
Is there a way to record audio on the browser platform (for any browser)? I couldn't figure it out if there was. It looks like Media browser plugin is hard coded to through an error (even on Chrome). Thanks, Chris
[GitHub] cordova-plugin-dialogs pull request: CB-9347 - fix to allow to sta...
Github user initialxy commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-127353615 Awesome, thanks @jcesarmobile, much appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [windows] added supprt ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [windows] added supprt ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/70#issuecomment-127234412 tested and merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/111 CB-9443 Pick correct maxResolution According to MSDN docs we're currently not picking the correct maxResolution for images: https://msdn.microsoft.com/en-us/library/windows/apps/windows.media.capture.cameracaptureuimaxphotoresolution.aspx You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-9443 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/111.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #111 commit f60324e71bc0a894d91d83387533b2c274c1b908 Author: Murat Sutunc sut...@gmail.com Date: 2015-08-03T19:57:58Z CB-9443 Pick correct maxResolution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36129853
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
// decide which max pixels should be supported by targetWidth or
targetHeight.
var maxRes = null;
var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
+var totalPixels = targetWidth * targetHeight;
switch (true) {
--- End diff --
As long as you're refactoring the numbers, let's also turn this from
`switch (true)` into `if`/`else`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130273
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
// decide which max pixels should be supported by targetWidth or
targetHeight.
var maxRes = null;
var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
+var totalPixels = targetWidth * targetHeight;
switch (true) {
--- End diff --
didn't notice `switch (true)` was just correcting the case params but wow -
haha. definetely turning this to a `if/else`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130435
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
// decide which max pixels should be supported by targetWidth or
targetHeight.
var maxRes = null;
var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
+var totalPixels = targetWidth * targetHeight;
switch (true) {
-case (targetWidth = 1280 || targetHeight = 960) :
-cameraCaptureUI.photoSettings.maxResolution = UIMaxRes.large3M;
+case (totalPixels = 320 * 240):
+cameraCaptureUI.photoSettings.maxResolution =
UIMaxRes.verySmallQvga;
break;
-case (targetWidth = 1024 || targetHeight = 768) :
-maxRes = UIMaxRes.mediumXga;
+case (totalPixels = 640 * 480):
+maxRes = UIMaxRes.smallVga;
break;
-case(targetWidth = 800 || targetHeight = 600) :
+case (totalPixels = 1024 * 768):
maxRes = UIMaxRes.mediumXga;
break;
-case (targetWidth = 640 || targetHeight = 480) :
-maxRes = UIMaxRes.smallVga;
+case (totalPixels = 3 * 1000 * 1000):
+maxRes = UIMaxRes.large3M;
break;
-case(targetWidth = 320 || targetHeight = 240) :
-maxRes = UIMaxRes.verySmallQvga;
+case (totalPixels = 5 * 1000 * 1000):
+maxRes = UIMaxRes.veryLarge5M;
break;
default :
maxRes = UIMaxRes.highestAvailable;
--- End diff --
Add `break;` after this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9443 Pick correct maxResolu...
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/111#discussion_r36130954
--- Diff: src/windows/CameraProxy.js ---
@@ -696,21 +696,22 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
// decide which max pixels should be supported by targetWidth or
targetHeight.
var maxRes = null;
var UIMaxRes = WMCapture.CameraCaptureUIMaxPhotoResolution;
+var totalPixels = targetWidth * targetHeight;
switch (true) {
-case (targetWidth = 1280 || targetHeight = 960) :
-cameraCaptureUI.photoSettings.maxResolution = UIMaxRes.large3M;
+case (totalPixels = 320 * 240):
+cameraCaptureUI.photoSettings.maxResolution =
UIMaxRes.verySmallQvga;
break;
-case (targetWidth = 1024 || targetHeight = 768) :
-maxRes = UIMaxRes.mediumXga;
+case (totalPixels = 640 * 480):
+maxRes = UIMaxRes.smallVga;
break;
-case(targetWidth = 800 || targetHeight = 600) :
+case (totalPixels = 1024 * 768):
maxRes = UIMaxRes.mediumXga;
break;
-case (targetWidth = 640 || targetHeight = 480) :
-maxRes = UIMaxRes.smallVga;
+case (totalPixels = 3 * 1000 * 1000):
+maxRes = UIMaxRes.large3M;
break;
-case(targetWidth = 320 || targetHeight = 240) :
-maxRes = UIMaxRes.verySmallQvga;
+case (totalPixels = 5 * 1000 * 1000):
+maxRes = UIMaxRes.veryLarge5M;
break;
default :
maxRes = UIMaxRes.highestAvailable;
--- End diff --
switch(true) is faster, + Personally, I find it easier to read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
