[GitHub] cordova-lib pull request: CB-9598 Switching to use `cordova-common...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/311#discussion_r41231011
--- Diff: cordova-lib/package.json ---
@@ -40,14 +38,19 @@
"tar": "1.0.2",
"underscore": "1.7.0",
"unorm": "1.3.3",
-"valid-identifier": "0.0.1",
-"xcode": "0.8.0"
+"valid-identifier": "0.0.1"
},
+ "bundledDependencies": [
+"cordova-common"
+ ],
"devDependencies": {
"istanbul": "^0.3.4",
"jasmine-node": "1.14.5",
"jshint": "2.5.8",
-"rewire": "2.1.3"
+"rewire": "2.1.3",
+"osenv": "0.1.0",
--- End diff --
why are thee dev dependecies now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/313#issuecomment-145759968 @stevengill, looks good :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DOCS] doc or docs subfolder?
doc folder comes from the Crowdin translation. I believe this was created in main repository mainly as side-effect of same CrowdIn config file for main docs and plugins. As far as I aware these translation files was not popularized, althrough I try translate them, since having our repository rules translated is potentially good for translations efforts. It was present prior translation, but if we rename it to something more meaningful and change CrowdIn settings to not create this folder 2015-10-06 11:18 GMT+06:00 Shazron : > Sorry - that commit does not tell me anything. In that commit I see > files added to "doc" and I see files added to "docs". > > But perusing the files now I see why I was confused: "doc" is the > translation for the README for the repo itself; docs is for the actual > documentation files. > > On Mon, Oct 5, 2015 at 7:05 PM, Carlos Santana > wrote: > > It's docs > > > https://github.com/apache/cordova-docs/commit/89be0380ba2a80ccfde1d28387b4ed228e10a9f8 > > > > > > On Mon, Oct 5, 2015 at 6:08 PM Shazron wrote: > > > >> https://github.com/apache/cordova-docs > >> > >> I think "doc" is a remnant of a prior re-factor and can be removed, > maybe? > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] cordova-serve 0.2.0 release
Haha yeah - just ping the people in your company directory Carlos for some advice :) Maybe they can even update the licenses just for you ;) On Mon, Oct 5, 2015 at 7:43 PM, Carlos Santana wrote: > Also express is sponsored by StrongLoop which I heard recently got acquired > by a big company where a bunch of cool engineer work at ;-p > > On Mon, Oct 5, 2015 at 10:38 PM Carlos Santana wrote: > >> Yeah, that was my question since I was aware of the heavy list of packages >> use by express was wondering any red flags that license check catch and >> what was the outcome of further investigation. >> >> I just also did a quick review and no red flags I saw. But again i'm not a >> lawyer :-) >> >> >> On Mon, Oct 5, 2015 at 10:30 PM Tim Barham >> wrote: >> >>> Oh, regarding the legal aspect... >>> >>> I can 'coho check-license', and didn't encounter any issues. It flagged >>> two packages under express: >>> >>> * 'ms' (a millisecond conversion utility) which has no license file or >>> license entry in package.json, but on investigation is released under the >>> MIT license (in the README). >>> * 'inherits', which is released under the ISC license (which a lot of our >>> dependencies are - we just haven't added it to the acceptable license list). >>> >>> So I feel ok about that aspect. Most of those 43 modules are actually, >>> technically, part of Express (or very closely related to it). >>> >>> Tim >>> >>> -Original Message- >>> From: Tim Barham >>> Sent: Monday, October 5, 2015 7:15 PM >>> To: 'dev@cordova.apache.org' >>> Subject: RE: [DISCUSS] cordova-serve 0.2.0 release >>> >>> Yeah... This is a philosophy of the Express guys - they keep packages >>> really small, and have more packages. Basically, their philosophy is that >>> each package should only define one discrete piece of functionality, in a >>> single source file. As soon as that file gets too big or there is a feeling >>> that functionality should be extracted into another file, that becomes >>> another package. >>> >>> This results in a lot of packages, but they're all really tiny. Do we >>> consider that (the number of packages) a problem? >>> >>> -Original Message- >>> From: Carlos Santana [mailto:csantan...@gmail.com] >>> Sent: Monday, October 5, 2015 6:54 PM >>> To: dev@cordova.apache.org >>> Subject: Re: [DISCUSS] cordova-serve 0.2.0 release >>> >>> Tim you realize that by bringing in "express" as a dependency to cordova >>> cli you are bringing a 43 other npm packages? >>> >>> Did you or your team did a quick assessment on how healthy legally >>> speaking on the complete set of dependencies? >>> ⛄ $ npm install express 1>/dev/null && find node_modules/express | grep >>> package.json | wc -l >>> 43 >>> >>> I would also be concern about size, we had problems in the past where >>> dependencies includes fixtures and this added considerable file size to >>> cordova-cli I check and it's small 1.7mb, so no problem there. >>> >>> ⛄ $ du -sh node_modules/express/ >>> 1.7M node_modules/express/ >>> >>> >>> On Mon, Oct 5, 2015 at 1:29 PM Steven Gill >>> wrote: >>> >>> > I'd rather we bump the major and get out of 0.x.x land. >>> > On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: >>> > >>> > > If the version is 0.x.x, then bumping the minor version is treated >>> > > as a breaking change (by npm/semver) - the idea is that until >>> > > version 1.0.0, things are still in flux. >>> > > >>> > > That said, I'm happy to call it 1.0.0 if that's preferable. >>> > > >>> > > -Original Message- >>> > > From: Steven Gill [mailto:stevengil...@gmail.com] >>> > > Sent: Monday, October 5, 2015 9:01 AM >>> > > To: dev@cordova.apache.org >>> > > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release >>> > > >>> > > Why not 1.0.0 if it is breaking >>> > > On Oct 4, 2015 5:22 PM, "Tim Barham" >>> wrote: >>> > > >>> > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to >>> > > > cordova-serve - previously it had essentially been a direct port >>> > > > of what was in cordova-lib's 'serve' command and cordova-browser, >>> > > > with a couple of hooks to customize functionality. Yesterday's PR >>> > > > changes it to use ExpressJS for the grunt-work (which simplifies >>> > > > the code a lot), and removes those hooks in favor of the ability >>> > > > to attach Express middleware (a breaking change, which will >>> > > > require the next release to be bumped to 0.2.0). If anyone who has >>> > > > an opinion about this could take a look and provide feedback, >>> that'd be great. >>> > > > >>> > > > Once I've merged it, I'd like to start a vote thread for an >>> > > > updated release of cordova-serve containing this change for a >>> > > > couple of >>> > reasons: >>> > > > >>> > > > * I have the corresponding changes for cordova-browser and >>> > > > cordova-lib ready to go, but I can't get them in until we release >>> > > > the updated cordova-serve module. >>> > > > * I have another module that uses cordova-serve that I'd like to
Re: [DOCS] doc or docs subfolder?
Sorry - that commit does not tell me anything. In that commit I see files added to "doc" and I see files added to "docs". But perusing the files now I see why I was confused: "doc" is the translation for the README for the repo itself; docs is for the actual documentation files. On Mon, Oct 5, 2015 at 7:05 PM, Carlos Santana wrote: > It's docs > https://github.com/apache/cordova-docs/commit/89be0380ba2a80ccfde1d28387b4ed228e10a9f8 > > > On Mon, Oct 5, 2015 at 6:08 PM Shazron wrote: > >> https://github.com/apache/cordova-docs >> >> I think "doc" is a remnant of a prior re-factor and can be removed, maybe? >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145742256 No problem :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145741933 Great, thanks. I love express, just wanted to be sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145741275 It only impacts the `cordova run browser` command (which already runs on a local node server) - it has no impact on how users might deploy their app when targeting the browser platform. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-145737064 How does this impact the cordova-browser platform? Do browser targeting apps now depend on express and node on the server? Or can they be deployed as static sites? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Think twice before adding an npm dependency
I can ask the StrongLoop for their legal clearance and be done with it :-) On Mon, Oct 5, 2015 at 10:41 PM Tim Barham wrote: > > Now we are planning to add express as new npm dependency to cordova-cli, > > brining with it 43 npm packages for us to clear on the next release of > our > > product. > > Heh, sorry about that :). At least the good news is they all have well > documented licenses (apart from the one where you have to look in the > README file). > > Tim >
Re: [DISCUSS] cordova-serve 0.2.0 release
Also express is sponsored by StrongLoop which I heard recently got acquired by a big company where a bunch of cool engineer work at ;-p On Mon, Oct 5, 2015 at 10:38 PM Carlos Santana wrote: > Yeah, that was my question since I was aware of the heavy list of packages > use by express was wondering any red flags that license check catch and > what was the outcome of further investigation. > > I just also did a quick review and no red flags I saw. But again i'm not a > lawyer :-) > > > On Mon, Oct 5, 2015 at 10:30 PM Tim Barham > wrote: > >> Oh, regarding the legal aspect... >> >> I can 'coho check-license', and didn't encounter any issues. It flagged >> two packages under express: >> >> * 'ms' (a millisecond conversion utility) which has no license file or >> license entry in package.json, but on investigation is released under the >> MIT license (in the README). >> * 'inherits', which is released under the ISC license (which a lot of our >> dependencies are - we just haven't added it to the acceptable license list). >> >> So I feel ok about that aspect. Most of those 43 modules are actually, >> technically, part of Express (or very closely related to it). >> >> Tim >> >> -Original Message- >> From: Tim Barham >> Sent: Monday, October 5, 2015 7:15 PM >> To: 'dev@cordova.apache.org' >> Subject: RE: [DISCUSS] cordova-serve 0.2.0 release >> >> Yeah... This is a philosophy of the Express guys - they keep packages >> really small, and have more packages. Basically, their philosophy is that >> each package should only define one discrete piece of functionality, in a >> single source file. As soon as that file gets too big or there is a feeling >> that functionality should be extracted into another file, that becomes >> another package. >> >> This results in a lot of packages, but they're all really tiny. Do we >> consider that (the number of packages) a problem? >> >> -Original Message- >> From: Carlos Santana [mailto:csantan...@gmail.com] >> Sent: Monday, October 5, 2015 6:54 PM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] cordova-serve 0.2.0 release >> >> Tim you realize that by bringing in "express" as a dependency to cordova >> cli you are bringing a 43 other npm packages? >> >> Did you or your team did a quick assessment on how healthy legally >> speaking on the complete set of dependencies? >> ⛄ $ npm install express 1>/dev/null && find node_modules/express | grep >> package.json | wc -l >> 43 >> >> I would also be concern about size, we had problems in the past where >> dependencies includes fixtures and this added considerable file size to >> cordova-cli I check and it's small 1.7mb, so no problem there. >> >> ⛄ $ du -sh node_modules/express/ >> 1.7M node_modules/express/ >> >> >> On Mon, Oct 5, 2015 at 1:29 PM Steven Gill >> wrote: >> >> > I'd rather we bump the major and get out of 0.x.x land. >> > On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: >> > >> > > If the version is 0.x.x, then bumping the minor version is treated >> > > as a breaking change (by npm/semver) - the idea is that until >> > > version 1.0.0, things are still in flux. >> > > >> > > That said, I'm happy to call it 1.0.0 if that's preferable. >> > > >> > > -Original Message- >> > > From: Steven Gill [mailto:stevengil...@gmail.com] >> > > Sent: Monday, October 5, 2015 9:01 AM >> > > To: dev@cordova.apache.org >> > > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release >> > > >> > > Why not 1.0.0 if it is breaking >> > > On Oct 4, 2015 5:22 PM, "Tim Barham" >> wrote: >> > > >> > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to >> > > > cordova-serve - previously it had essentially been a direct port >> > > > of what was in cordova-lib's 'serve' command and cordova-browser, >> > > > with a couple of hooks to customize functionality. Yesterday's PR >> > > > changes it to use ExpressJS for the grunt-work (which simplifies >> > > > the code a lot), and removes those hooks in favor of the ability >> > > > to attach Express middleware (a breaking change, which will >> > > > require the next release to be bumped to 0.2.0). If anyone who has >> > > > an opinion about this could take a look and provide feedback, >> that'd be great. >> > > > >> > > > Once I've merged it, I'd like to start a vote thread for an >> > > > updated release of cordova-serve containing this change for a >> > > > couple of >> > reasons: >> > > > >> > > > * I have the corresponding changes for cordova-browser and >> > > > cordova-lib ready to go, but I can't get them in until we release >> > > > the updated cordova-serve module. >> > > > * I have another module that uses cordova-serve that I'd like to >> > > > switch over to the ExpressJS version. >> > > > >> > > > Thanks! >> > > > >> > > > Tim >> > > > >> > > > >> > > > -- >> > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > > > For additional commands, e-mail: dev-h...@c
RE: [DISCUSS] Think twice before adding an npm dependency
> Now we are planning to add express as new npm dependency to cordova-cli, > brining with it 43 npm packages for us to clear on the next release of our > product. Heh, sorry about that :). At least the good news is they all have well documented licenses (apart from the one where you have to look in the README file). Tim
Re: [DISCUSS] cordova-serve 0.2.0 release
Yeah, that was my question since I was aware of the heavy list of packages use by express was wondering any red flags that license check catch and what was the outcome of further investigation. I just also did a quick review and no red flags I saw. But again i'm not a lawyer :-) On Mon, Oct 5, 2015 at 10:30 PM Tim Barham wrote: > Oh, regarding the legal aspect... > > I can 'coho check-license', and didn't encounter any issues. It flagged > two packages under express: > > * 'ms' (a millisecond conversion utility) which has no license file or > license entry in package.json, but on investigation is released under the > MIT license (in the README). > * 'inherits', which is released under the ISC license (which a lot of our > dependencies are - we just haven't added it to the acceptable license list). > > So I feel ok about that aspect. Most of those 43 modules are actually, > technically, part of Express (or very closely related to it). > > Tim > > -Original Message- > From: Tim Barham > Sent: Monday, October 5, 2015 7:15 PM > To: 'dev@cordova.apache.org' > Subject: RE: [DISCUSS] cordova-serve 0.2.0 release > > Yeah... This is a philosophy of the Express guys - they keep packages > really small, and have more packages. Basically, their philosophy is that > each package should only define one discrete piece of functionality, in a > single source file. As soon as that file gets too big or there is a feeling > that functionality should be extracted into another file, that becomes > another package. > > This results in a lot of packages, but they're all really tiny. Do we > consider that (the number of packages) a problem? > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Monday, October 5, 2015 6:54 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release > > Tim you realize that by bringing in "express" as a dependency to cordova > cli you are bringing a 43 other npm packages? > > Did you or your team did a quick assessment on how healthy legally > speaking on the complete set of dependencies? > ⛄ $ npm install express 1>/dev/null && find node_modules/express | grep > package.json | wc -l > 43 > > I would also be concern about size, we had problems in the past where > dependencies includes fixtures and this added considerable file size to > cordova-cli I check and it's small 1.7mb, so no problem there. > > ⛄ $ du -sh node_modules/express/ > 1.7M node_modules/express/ > > > On Mon, Oct 5, 2015 at 1:29 PM Steven Gill wrote: > > > I'd rather we bump the major and get out of 0.x.x land. > > On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: > > > > > If the version is 0.x.x, then bumping the minor version is treated > > > as a breaking change (by npm/semver) - the idea is that until > > > version 1.0.0, things are still in flux. > > > > > > That said, I'm happy to call it 1.0.0 if that's preferable. > > > > > > -Original Message- > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > Sent: Monday, October 5, 2015 9:01 AM > > > To: dev@cordova.apache.org > > > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release > > > > > > Why not 1.0.0 if it is breaking > > > On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > > > > > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to > > > > cordova-serve - previously it had essentially been a direct port > > > > of what was in cordova-lib's 'serve' command and cordova-browser, > > > > with a couple of hooks to customize functionality. Yesterday's PR > > > > changes it to use ExpressJS for the grunt-work (which simplifies > > > > the code a lot), and removes those hooks in favor of the ability > > > > to attach Express middleware (a breaking change, which will > > > > require the next release to be bumped to 0.2.0). If anyone who has > > > > an opinion about this could take a look and provide feedback, that'd > be great. > > > > > > > > Once I've merged it, I'd like to start a vote thread for an > > > > updated release of cordova-serve containing this change for a > > > > couple of > > reasons: > > > > > > > > * I have the corresponding changes for cordova-browser and > > > > cordova-lib ready to go, but I can't get them in until we release > > > > the updated cordova-serve module. > > > > * I have another module that uses cordova-serve that I'd like to > > > > switch over to the ExpressJS version. > > > > > > > > Thanks! > > > > > > > > Tim > > > > > > > > > > > > -- > > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > >
RE: [DISCUSS] cordova-serve 0.2.0 release
Oh, regarding the legal aspect... I can 'coho check-license', and didn't encounter any issues. It flagged two packages under express: * 'ms' (a millisecond conversion utility) which has no license file or license entry in package.json, but on investigation is released under the MIT license (in the README). * 'inherits', which is released under the ISC license (which a lot of our dependencies are - we just haven't added it to the acceptable license list). So I feel ok about that aspect. Most of those 43 modules are actually, technically, part of Express (or very closely related to it). Tim -Original Message- From: Tim Barham Sent: Monday, October 5, 2015 7:15 PM To: 'dev@cordova.apache.org' Subject: RE: [DISCUSS] cordova-serve 0.2.0 release Yeah... This is a philosophy of the Express guys - they keep packages really small, and have more packages. Basically, their philosophy is that each package should only define one discrete piece of functionality, in a single source file. As soon as that file gets too big or there is a feeling that functionality should be extracted into another file, that becomes another package. This results in a lot of packages, but they're all really tiny. Do we consider that (the number of packages) a problem? -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Monday, October 5, 2015 6:54 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-serve 0.2.0 release Tim you realize that by bringing in "express" as a dependency to cordova cli you are bringing a 43 other npm packages? Did you or your team did a quick assessment on how healthy legally speaking on the complete set of dependencies? ⛄ $ npm install express 1>/dev/null && find node_modules/express | grep package.json | wc -l 43 I would also be concern about size, we had problems in the past where dependencies includes fixtures and this added considerable file size to cordova-cli I check and it's small 1.7mb, so no problem there. ⛄ $ du -sh node_modules/express/ 1.7M node_modules/express/ On Mon, Oct 5, 2015 at 1:29 PM Steven Gill wrote: > I'd rather we bump the major and get out of 0.x.x land. > On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: > > > If the version is 0.x.x, then bumping the minor version is treated > > as a breaking change (by npm/semver) - the idea is that until > > version 1.0.0, things are still in flux. > > > > That said, I'm happy to call it 1.0.0 if that's preferable. > > > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Monday, October 5, 2015 9:01 AM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release > > > > Why not 1.0.0 if it is breaking > > On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > > > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to > > > cordova-serve - previously it had essentially been a direct port > > > of what was in cordova-lib's 'serve' command and cordova-browser, > > > with a couple of hooks to customize functionality. Yesterday's PR > > > changes it to use ExpressJS for the grunt-work (which simplifies > > > the code a lot), and removes those hooks in favor of the ability > > > to attach Express middleware (a breaking change, which will > > > require the next release to be bumped to 0.2.0). If anyone who has > > > an opinion about this could take a look and provide feedback, that'd be > > > great. > > > > > > Once I've merged it, I'd like to start a vote thread for an > > > updated release of cordova-serve containing this change for a > > > couple of > reasons: > > > > > > * I have the corresponding changes for cordova-browser and > > > cordova-lib ready to go, but I can't get them in until we release > > > the updated cordova-serve module. > > > * I have another module that uses cordova-serve that I'd like to > > > switch over to the ExpressJS version. > > > > > > Thanks! > > > > > > Tim > > > > > > > > > -- > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > >
Re: Merging latest pull requests into Master today
I did a quick on review with my limited on android native skills :-) 1. I think the file plugin is missing the engine tag, I saw the other's had the plugin.xml with the engine tag added 2. Don't understand why cordova-android is concern with geolocation permissions, it's like the web view checks and delegate geolocation permissions to the geolocation plugin? Other than that looks, once merged will give it a test run On Mon, Oct 5, 2015 at 1:32 PM Joe Bowser wrote: > I was screwing up the scope, sorry. > > We should be initializing it with the permissions in the constructor. The > purpose of it is for the Java API. So, if we have a plugin dependency that > needs to access the permissions of the parent plugin somehow, they can just > request the permissions instead of cueing every permission individually. > > On Mon, Oct 5, 2015 at 10:26 AM, Nikhil Khandelwal > > wrote: > > > Sorry for not responding earlier. I like where this is going. I have a > > bunch of comments on the PRs. > > > > I have some confusion around how CordovaPlugin has a protected field > > 'permissions' and what a derived CordovaPlugin is supposed to do with it. > > None of our core plugins seem to use it. > > > > Thanks, > > Nikhil > > > > -Original Message- > > From: Joe Bowser [mailto:bows...@gmail.com] > > Sent: Monday, October 5, 2015 9:05 AM > > To: dev > > Subject: Merging latest pull requests into Master today > > > > Hey > > > > I'm going to pull the 5.0.x proposed pull requests into Master today. > Can > > anyone take a look at them before I do this. I'm going to wait until > after > > 1 PM to do it, so if you can check out the new pull requests and comment > > on them before then, that would be greatly appreciated, otherwise I'm > going > > to assume all is good and merge them into the master. > > > > You've been warned. ;) > > > > Joe > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > >
RE: [DISCUSS] cordova-serve 0.2.0 release
Yeah... This is a philosophy of the Express guys - they keep packages really small, and have more packages. Basically, their philosophy is that each package should only define one discrete piece of functionality, in a single source file. As soon as that file gets too big or there is a feeling that functionality should be extracted into another file, that becomes another package. This results in a lot of packages, but they're all really tiny. Do we consider that (the number of packages) a problem? -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Monday, October 5, 2015 6:54 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-serve 0.2.0 release Tim you realize that by bringing in "express" as a dependency to cordova cli you are bringing a 43 other npm packages? Did you or your team did a quick assessment on how healthy legally speaking on the complete set of dependencies? ⛄ $ npm install express 1>/dev/null && find node_modules/express | grep package.json | wc -l 43 I would also be concern about size, we had problems in the past where dependencies includes fixtures and this added considerable file size to cordova-cli I check and it's small 1.7mb, so no problem there. ⛄ $ du -sh node_modules/express/ 1.7M node_modules/express/ On Mon, Oct 5, 2015 at 1:29 PM Steven Gill wrote: > I'd rather we bump the major and get out of 0.x.x land. > On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: > > > If the version is 0.x.x, then bumping the minor version is treated > > as a breaking change (by npm/semver) - the idea is that until > > version 1.0.0, things are still in flux. > > > > That said, I'm happy to call it 1.0.0 if that's preferable. > > > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Monday, October 5, 2015 9:01 AM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release > > > > Why not 1.0.0 if it is breaking > > On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > > > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to > > > cordova-serve - previously it had essentially been a direct port > > > of what was in cordova-lib's 'serve' command and cordova-browser, > > > with a couple of hooks to customize functionality. Yesterday's PR > > > changes it to use ExpressJS for the grunt-work (which simplifies > > > the code a lot), and removes those hooks in favor of the ability > > > to attach Express middleware (a breaking change, which will > > > require the next release to be bumped to 0.2.0). If anyone who has > > > an opinion about this could take a look and provide feedback, that'd be > > > great. > > > > > > Once I've merged it, I'd like to start a vote thread for an > > > updated release of cordova-serve containing this change for a > > > couple of > reasons: > > > > > > * I have the corresponding changes for cordova-browser and > > > cordova-lib ready to go, but I can't get them in until we release > > > the updated cordova-serve module. > > > * I have another module that uses cordova-serve that I'd like to > > > switch over to the ExpressJS version. > > > > > > Thanks! > > > > > > Tim > > > > > > > > > -- > > > --- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > >
Re: [DOCS] doc or docs subfolder?
It's docs https://github.com/apache/cordova-docs/commit/89be0380ba2a80ccfde1d28387b4ed228e10a9f8 On Mon, Oct 5, 2015 at 6:08 PM Shazron wrote: > https://github.com/apache/cordova-docs > > I think "doc" is a remnant of a prior re-factor and can be removed, maybe? > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Think twice before adding an npm dependency
Sorry for all the typos, I blame Siri dictation taking ;-p On Mon, Oct 5, 2015 at 9:47 PM Carlos Santana wrote: > Hi I wanted to share some insight about the experience we had when we try > to include the cordova cli, plugins, and platform with our IBM product > MobileFirst Platform Foundation (ealier know as Worklight). > > Version 7.1 that we released in Aug/2015, was the first time we shipped > the cordova cli, and the nodejs related files with the product. > > One aspect of doing this was legal clearance, we didn't have any issues > with the code author by the Cordova project, were we found we needed some > assistance ws with the npm dependencies that cordova-cli, cordova-lib, and > platforms depended on. > > I'm attaching the license info for all the packages we needed to clear by > IBM legal team, this took time but was not that bad because only one > package was red flagged. > > If someone is planning to re-distribute cordova then I hope it can benefit > you. > > The reason that it took time is because some packages didn't have a a > license easy to find, other didn't have a license, so legal team needed to > contact package owner. > > Edna Morales was the one involved working with Edna, she did a great > dealing with all no so fun legal requirements. > > Here is an example of some packages that was not clear about their > license: commander 0.5.2; connect 1.8.5; and cookie-signature 0.0.1. But > Edna figured it out that some were devDependencies, and others were MIT > > I wan to discuss some more at the F2F on how do we make it easier to ship > cordova with a third party product, or if not shipping telling customer to > go ahead to get cordova on their own and give them some type of confidence > that cordova doesn't have any legal problems to download and install to > later integrate our ibm product. > > One would assume that Cordova being under Apache, there should not be so > many headches and so much legal work to re-distribute. > > With this I'm not saying that we never depend on 3rd party open source, or > that don't refresh those dependencies. Some of the npm libraries that we > use are good to depend on like 'q', 'shelljs', 'glob', 'npm', but others > have a large dependency graph with questionable dependencies underneath > > Now we are planning to add express as new npm dependency to cordova-cli, > brining with it 43 npm packages for us to clear on the next release of our > product. Not complaining but want you to be aware that when you add one > dependency you bring along all the dependency tree with it and the impact > that this causes downstream. > > I'm writing this email with a positive tone to make project better, foster > open source, and to bring in to perspective some items that some of you > might already be aware and some other might not be aware. > > Sorry for the long email, but by know you should already know me well :-) > >
Re: Understanding the Cordova developer better - Cordova developer survey
survey looks great, yes I agree let's send it now to see how much data we collect by F2F time frame. On Mon, Oct 5, 2015 at 9:22 PM Parashuram N wrote: > Looks like the URL had a dot at the end. Here is the URL that worked for me > > https://apachecordovabot.typeform.com/to/BCc5co > > -Original Message- > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] > Sent: Monday, October 5, 2015 3:21 PM > To: dev@cordova.apache.org > Subject: RE: Understanding the Cordova developer better - Cordova > developer survey > > Thanks for all the input! Here's the final public facing URL: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fapachecordovabot.typeform.com%2fto%2fBCc5co.&data=01%7c01%7cpanarasi%40microsoft.com%7c86396d50c82d42e0359b08d2cdd34a0d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=9k5%2b3HCFfW%2fCVjQMMmPBSy71bM3lWMQJQifwyhF5dTs%3d > > It will be great to get some of this data before the F2F meeting. Let's > all tweet about it, post it on slack etc. > > In couple of days we can see if we can want to make more tweaks to this > and then put out a v2 on the cordova website as a banner. > > -Nikhil > > -Original Message- > From: Andrey Kurdumov [mailto:kant2...@googlemail.com] > Sent: Saturday, October 3, 2015 10:42 PM > To: dev@cordova.apache.org > Subject: Re: Understanding the Cordova developer better - Cordova > developer survey > > Would be good separate 4.a question "Documentation for the Cordova > platforms and CLI" on two separate questions. > Since I have different opinion on both of CLI and platform docs. CLI I > would range on the 8 or 9 9 (nobody perfect), but platform docs are closer > to 4 (need significant improvements) for me. > Both are very strong feeling, and I have to or average results, or select > which part is more important for me. > > 2015-10-04 11:04 GMT+06:00 Carlos Santana : > > > Yeah I like "released" > > > > Yeah no need to get usage info on this survey now. > > > > - Carlos > > Sent from my iPhone 6s > > > > > On Oct 4, 2015, at 12:51 AM, Jesse wrote: > > > > > > Great feedback, you're right, I was thinking totally app-store-centric. > > > How about 'released' instead of 'published'? > > > > > > I'm not sure if usage info is relevant here, it is interesting no > > > doubt, but I think the goal of this survey was to get info on making > > > the app developer experience better. There is a multitude of > > > non-cordova factors that affect usage; (price, design, app type, > > > market competition, ... ) Personally I think usage stats are > > > probably more relevant in the app showcase pages, or in another usage > targeted survey. > > > > > > > > > > > > > > > My team is hiring! > > > @purplecabbage > > > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data= > > > 01%7c01%7cnikhilkh%40microsoft.com%7ca0dc759ec823485986cc08d2cc7e942 > > > 7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ygxQ5M9xh2NY%2fGKr5eM > > > EdWpaHVPZ5RrMFs6s6F0Yos4%3d > > > > > >> On Sat, Oct 3, 2015 at 3:40 AM, Carlos Santana > > >> > > wrote: > > >> > > >> For the question on how many published, don't know if it will be > > >> good to use a different word than "published". I personally > > >> associate that with > > a > > >> App Store on quick read > > >> > > >> Most of our customers don't published their apps to a store, they > > >> have them in production internally because they are business to > > >> employee or business to business. > > >> > > >> What about using "apps currently in production" or "apps currently > > >> being actively user by users" or another term to be inclusive of > > >> apps not > > being > > >> distributed by public store > > >> > > >> Another question, how many users using your app in a monthly basis? > > >> Is that important to know how many users is the app being used by? > > >> Like I > > have > > >> one app but that one app being downloaded 1,000 monthly and used by > > 50,000 > > >> users :-) > > >> > > >> - Carlos > > >> Sent from my iPhone 6s > > >> > > >>> On Oct 3, 2015, at 3:34 AM, Jesse wrote: > > >>> > > >>> I was able to update the survey. > > >>> > > >>> 1. I made some minor grammatical corrections and added some missing > '?' > > >>> 2. Moved the 'What do you love/hate about cordova to the end" > > >>> 3. And added my plugins question. Which ones do you use? > > >>> 4. Also added Dave's 'would you recommend Cordova' question. > > >>> > > >>> Conceptually, I am having trouble with this one: > > >>> How far along are you in the development of your Cordova app? > > >>> I added a 'How many cordova apps have you published?' question as > > >>> I > > think > > >>> it more relevant. Unfortunately we cannot make 'How far along ..' > > >>> conditional on 'How-many' being <1 because we are using the free > > version. > > >>> > > >>> I *expect* that we will see roughly half of respondents have > > >>> published > > >> more > > >>> than 1 app, which would make the 'How far along...' question moot, > > >>> but > > I > >
Re: [DISCUSS] cordova-serve 0.2.0 release
Tim you realize that by bringing in "express" as a dependency to cordova cli you are bringing a 43 other npm packages? Did you or your team did a quick assessment on how healthy legally speaking on the complete set of dependencies? ⛄ $ npm install express 1>/dev/null && find node_modules/express | grep package.json | wc -l 43 I would also be concern about size, we had problems in the past where dependencies includes fixtures and this added considerable file size to cordova-cli I check and it's small 1.7mb, so no problem there. ⛄ $ du -sh node_modules/express/ 1.7M node_modules/express/ On Mon, Oct 5, 2015 at 1:29 PM Steven Gill wrote: > I'd rather we bump the major and get out of 0.x.x land. > On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: > > > If the version is 0.x.x, then bumping the minor version is treated as a > > breaking change (by npm/semver) - the idea is that until version 1.0.0, > > things are still in flux. > > > > That said, I'm happy to call it 1.0.0 if that's preferable. > > > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Monday, October 5, 2015 9:01 AM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release > > > > Why not 1.0.0 if it is breaking > > On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > > > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to > > > cordova-serve - previously it had essentially been a direct port of > > > what was in cordova-lib's 'serve' command and cordova-browser, with a > > > couple of hooks to customize functionality. Yesterday's PR changes it > > > to use ExpressJS for the grunt-work (which simplifies the code a lot), > > > and removes those hooks in favor of the ability to attach Express > > > middleware (a breaking change, which will require the next release to > > > be bumped to 0.2.0). If anyone who has an opinion about this could > > > take a look and provide feedback, that'd be great. > > > > > > Once I've merged it, I'd like to start a vote thread for an updated > > > release of cordova-serve containing this change for a couple of > reasons: > > > > > > * I have the corresponding changes for cordova-browser and cordova-lib > > > ready to go, but I can't get them in until we release the updated > > > cordova-serve module. > > > * I have another module that uses cordova-serve that I'd like to > > > switch over to the ExpressJS version. > > > > > > Thanks! > > > > > > Tim > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > >
RE: Understanding the Cordova developer better - Cordova developer survey
Looks like the URL had a dot at the end. Here is the URL that worked for me https://apachecordovabot.typeform.com/to/BCc5co -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Monday, October 5, 2015 3:21 PM To: dev@cordova.apache.org Subject: RE: Understanding the Cordova developer better - Cordova developer survey Thanks for all the input! Here's the final public facing URL: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fapachecordovabot.typeform.com%2fto%2fBCc5co.&data=01%7c01%7cpanarasi%40microsoft.com%7c86396d50c82d42e0359b08d2cdd34a0d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=9k5%2b3HCFfW%2fCVjQMMmPBSy71bM3lWMQJQifwyhF5dTs%3d It will be great to get some of this data before the F2F meeting. Let's all tweet about it, post it on slack etc. In couple of days we can see if we can want to make more tweaks to this and then put out a v2 on the cordova website as a banner. -Nikhil -Original Message- From: Andrey Kurdumov [mailto:kant2...@googlemail.com] Sent: Saturday, October 3, 2015 10:42 PM To: dev@cordova.apache.org Subject: Re: Understanding the Cordova developer better - Cordova developer survey Would be good separate 4.a question "Documentation for the Cordova platforms and CLI" on two separate questions. Since I have different opinion on both of CLI and platform docs. CLI I would range on the 8 or 9 9 (nobody perfect), but platform docs are closer to 4 (need significant improvements) for me. Both are very strong feeling, and I have to or average results, or select which part is more important for me. 2015-10-04 11:04 GMT+06:00 Carlos Santana : > Yeah I like "released" > > Yeah no need to get usage info on this survey now. > > - Carlos > Sent from my iPhone 6s > > > On Oct 4, 2015, at 12:51 AM, Jesse wrote: > > > > Great feedback, you're right, I was thinking totally app-store-centric. > > How about 'released' instead of 'published'? > > > > I'm not sure if usage info is relevant here, it is interesting no > > doubt, but I think the goal of this survey was to get info on making > > the app developer experience better. There is a multitude of > > non-cordova factors that affect usage; (price, design, app type, > > market competition, ... ) Personally I think usage stats are > > probably more relevant in the app showcase pages, or in another usage > > targeted survey. > > > > > > > > > > My team is hiring! > > @purplecabbage > > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data= > > 01%7c01%7cnikhilkh%40microsoft.com%7ca0dc759ec823485986cc08d2cc7e942 > > 7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ygxQ5M9xh2NY%2fGKr5eM > > EdWpaHVPZ5RrMFs6s6F0Yos4%3d > > > >> On Sat, Oct 3, 2015 at 3:40 AM, Carlos Santana > >> > wrote: > >> > >> For the question on how many published, don't know if it will be > >> good to use a different word than "published". I personally > >> associate that with > a > >> App Store on quick read > >> > >> Most of our customers don't published their apps to a store, they > >> have them in production internally because they are business to > >> employee or business to business. > >> > >> What about using "apps currently in production" or "apps currently > >> being actively user by users" or another term to be inclusive of > >> apps not > being > >> distributed by public store > >> > >> Another question, how many users using your app in a monthly basis? > >> Is that important to know how many users is the app being used by? > >> Like I > have > >> one app but that one app being downloaded 1,000 monthly and used by > 50,000 > >> users :-) > >> > >> - Carlos > >> Sent from my iPhone 6s > >> > >>> On Oct 3, 2015, at 3:34 AM, Jesse wrote: > >>> > >>> I was able to update the survey. > >>> > >>> 1. I made some minor grammatical corrections and added some missing '?' > >>> 2. Moved the 'What do you love/hate about cordova to the end" > >>> 3. And added my plugins question. Which ones do you use? > >>> 4. Also added Dave's 'would you recommend Cordova' question. > >>> > >>> Conceptually, I am having trouble with this one: > >>> How far along are you in the development of your Cordova app? > >>> I added a 'How many cordova apps have you published?' question as > >>> I > think > >>> it more relevant. Unfortunately we cannot make 'How far along ..' > >>> conditional on 'How-many' being <1 because we are using the free > version. > >>> > >>> I *expect* that we will see roughly half of respondents have > >>> published > >> more > >>> than 1 app, which would make the 'How far along...' question moot, > >>> but > I > >>> could be wrong. > >>> > >>> > >>> > >>> > >>> My team is hiring! > >>> @purplecabbage > >>> https://na01.safelinks.protection.outlook.com/?url=risingj.com&dat > >>> a=01%7c01%7cnikhilkh%40microsoft.com%7ca0dc759ec823485986cc08d2cc7 > >>> e9427%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ygxQ5M9xh2NY%2f > >>> GKr5eMEdWpaHVPZ5RrMFs6s6F0Yos4%3d > >>> > >>>
[GitHub] cordova-plugin-splashscreen pull request: add JIRA issue tracker l...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8875 execute entire c...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: iOS : Fix for screen not...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8875 FadeSplashScreen...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/313#issuecomment-145705106 @vladimir-kotikov switched to warnings and added some verbose output. Also added a conversion step to fetch.js as it was needed in there since cordova-lib calls fetch instead of install. I originally had my ID conversion code in registry.js, but this lead to some failing checks in the code for what ID was expected and what was actually retrieved. i think it is all good now. Let me know if you have other thoughts before I merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] 1.0.0 cordova-serve release
Please review and vote on this 1.0.0 release of cordova-serve by replying to this email (and keep discussion on the DISCUSS thread). Release issue: https://issues.apache.org/jira/browse/CB-9748 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9748/ SHA512: 640896b34d9019383a5efa52a6afeefa31bdcd6bc9f672c44361411954710499872955ead6b433f8b16e66ff9b617a1c63e5aa64b400f8c2323be4d1eb08b25e The package was published from its corresponding git tag: cordova-lib: serve-1.0.0 (213d9870da) It has been published to npm with an 'rc' tag, so you can test it as follows: 1. Test its usage by the browser platform (needs updated browser platform): * Add the browser platform to a Cordova project using 'cordova platform add browser@MSOpenTech/cordova-browser#use-cordova-serve-express' * Try 'cordova run browser' - it should work as expected, and you can confirm you are using 1.0.0 by checking that the console output includes color and compression type listed in output (typically '(gzip)') should be gray (where-as with 0.1.3 it was default color). 2. Test its usage by the 'cordova serve' command: * Assuming you run cordova-lib from local repo, you'll need to add msopentech/cordova-lib as a remote, and grab the 'use-cordova-serve-express' branch. * Run 'npm install cordova-serve' in cordova-lib/cordova-lib - it should grab the 1.0.0 version from npm. * In a Cordova project directory, run 'cordova serve' * In a browser, navigate to the URL output by 'cordova serve' (typically 'http://localhost:8000'). * Click on one of the platform links - it should work as expected, and you can confirm you are using 1.0.0 by checking that the console output includes color and compression type in output is gray, not default color. Upon a successful vote I will upload the archive to dist/, tag it 'latest' on NPM, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran 'coho audit-license-headers'. * Ran 'coho check-license' to ensure all dependencies and sub-dependencies have Apache-compatible licenses. * Tested 'cordova run browser' and 'cordova serve' with a sample app. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8875 FadeSplashScreen...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/62 CB-8875 FadeSplashScreen was not fading fixes some weak/strong self identity + confidence issues You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-splashscreen CB-8875 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit fb0764c528444a665dc611535935d784135ae808 Author: Jesse MacFadyen Date: 2015-10-05T23:34:49Z CB-8875 FadeSplashScreen was not fading --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9569 - Support and
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request:
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/commit/932ad578589d1c825fa57f330dafd3092f193e3c#commitcomment-13603467 Hey @vladimir-kotikov - you should probably bump version in master to `5.3.3-dev`, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Understanding the Cordova developer better - Cordova developer survey
Thanks for all the input! Here's the final public facing URL: https://apachecordovabot.typeform.com/to/BCc5co. It will be great to get some of this data before the F2F meeting. Let's all tweet about it, post it on slack etc. In couple of days we can see if we can want to make more tweaks to this and then put out a v2 on the cordova website as a banner. -Nikhil -Original Message- From: Andrey Kurdumov [mailto:kant2...@googlemail.com] Sent: Saturday, October 3, 2015 10:42 PM To: dev@cordova.apache.org Subject: Re: Understanding the Cordova developer better - Cordova developer survey Would be good separate 4.a question "Documentation for the Cordova platforms and CLI" on two separate questions. Since I have different opinion on both of CLI and platform docs. CLI I would range on the 8 or 9 9 (nobody perfect), but platform docs are closer to 4 (need significant improvements) for me. Both are very strong feeling, and I have to or average results, or select which part is more important for me. 2015-10-04 11:04 GMT+06:00 Carlos Santana : > Yeah I like "released" > > Yeah no need to get usage info on this survey now. > > - Carlos > Sent from my iPhone 6s > > > On Oct 4, 2015, at 12:51 AM, Jesse wrote: > > > > Great feedback, you're right, I was thinking totally app-store-centric. > > How about 'released' instead of 'published'? > > > > I'm not sure if usage info is relevant here, it is interesting no > > doubt, but I think the goal of this survey was to get info on making > > the app developer experience better. There is a multitude of > > non-cordova factors that affect usage; (price, design, app type, > > market competition, ... ) Personally I think usage stats are > > probably more relevant in the app showcase pages, or in another usage > > targeted survey. > > > > > > > > > > My team is hiring! > > @purplecabbage > > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data= > > 01%7c01%7cnikhilkh%40microsoft.com%7ca0dc759ec823485986cc08d2cc7e942 > > 7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ygxQ5M9xh2NY%2fGKr5eM > > EdWpaHVPZ5RrMFs6s6F0Yos4%3d > > > >> On Sat, Oct 3, 2015 at 3:40 AM, Carlos Santana > >> > wrote: > >> > >> For the question on how many published, don't know if it will be > >> good to use a different word than "published". I personally > >> associate that with > a > >> App Store on quick read > >> > >> Most of our customers don't published their apps to a store, they > >> have them in production internally because they are business to > >> employee or business to business. > >> > >> What about using "apps currently in production" or "apps currently > >> being actively user by users" or another term to be inclusive of > >> apps not > being > >> distributed by public store > >> > >> Another question, how many users using your app in a monthly basis? > >> Is that important to know how many users is the app being used by? > >> Like I > have > >> one app but that one app being downloaded 1,000 monthly and used by > 50,000 > >> users :-) > >> > >> - Carlos > >> Sent from my iPhone 6s > >> > >>> On Oct 3, 2015, at 3:34 AM, Jesse wrote: > >>> > >>> I was able to update the survey. > >>> > >>> 1. I made some minor grammatical corrections and added some missing '?' > >>> 2. Moved the 'What do you love/hate about cordova to the end" > >>> 3. And added my plugins question. Which ones do you use? > >>> 4. Also added Dave's 'would you recommend Cordova' question. > >>> > >>> Conceptually, I am having trouble with this one: > >>> How far along are you in the development of your Cordova app? > >>> I added a 'How many cordova apps have you published?' question as > >>> I > think > >>> it more relevant. Unfortunately we cannot make 'How far along ..' > >>> conditional on 'How-many' being <1 because we are using the free > version. > >>> > >>> I *expect* that we will see roughly half of respondents have > >>> published > >> more > >>> than 1 app, which would make the 'How far along...' question moot, > >>> but > I > >>> could be wrong. > >>> > >>> > >>> > >>> > >>> My team is hiring! > >>> @purplecabbage > >>> https://na01.safelinks.protection.outlook.com/?url=risingj.com&dat > >>> a=01%7c01%7cnikhilkh%40microsoft.com%7ca0dc759ec823485986cc08d2cc7 > >>> e9427%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ygxQ5M9xh2NY%2f > >>> GKr5eMEdWpaHVPZ5RrMFs6s6F0Yos4%3d > >>> > >>> On Thu, Oct 1, 2015 at 11:46 AM, Parashuram N > >>> > >>> wrote: > >>> > Sure, I guess we will have to create a new account and put the > >> credentials > in SVN, right ? > > > > > > On 10/1/15, 11:43 AM, "Jesse" wrote: > > > > So, I was not able to log in and make the changes. > > Can we change the typeform account login to not use google SSO? > > > > > > My team is hiring! > > @purplecabbage > > >> > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01 > %7c01%7cpanarasi%40microsoft.com%7c0bfbaed69
[GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41204416
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
yield repoutil.forEachRepo(repos, function*(repo) {
+if(isWin) {
--- End diff --
Thanks for the clarification @daserge
On Mac by default using git from XCode Tools, both of the settings
core.autocrlf and core.eol are not set at all, so I would think let's leave
this check only for Win as you have it here, go ahead and merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[DOCS] doc or docs subfolder?
https://github.com/apache/cordova-docs I think "doc" is a remnant of a prior re-factor and can be removed, maybe? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[iOS ATS] CB-9569 - Support and tag translation to Application Transport Security (ATS) Info.plist directives
Merging soon, unless there are comments. https://github.com/apache/cordova-lib/pull/312 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9747 Fix Android Parser
GitHub user ogoguel opened a pull request: https://github.com/apache/cordova-lib/pull/315 CB-9747 Fix Android Parser Fix parser error if the activity name refers a full package class, instead of just the class Added tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/ogoguel/cordova-lib CB-9747-tentative Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/315.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #315 commit 5ca3588c4fb8fa35915bdb644a2ba71454bd20f3 Author: Olivier Goguel Date: 2015-10-05T19:45:49Z CB-9747 commit 7c6d2f41a9f9f9c21866623073c146e84c6f520a Author: Olivier Goguel Date: 2015-10-05T21:25:53Z CB-9747 added tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9569 - Support and
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/312#issuecomment-145671308 Hmm one problem that I can see is, this assumes the last item to "clobber" the ATS entry is the last one standing. There is no merge strategy. For example: ``` https://*.google.com /> https://google.com /> ``` We would only pick up the last item there, were subdomains are *not* allowed. We can't possibly decipher the intent of the user here, it is up to the user to write a coherent whitelist policy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41180911
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
yield repoutil.forEachRepo(repos, function*(repo) {
+if(isWin) {
--- End diff --
@csantanapr, git does not seem to change eols to CRLF on OS X given that
`core.autocrlf=false` and/or `core.eol=crlf`. It probably could be changed by
[.gitattributes only (text
eol=crlf)](https://help.github.com/articles/dealing-with-line-endings/).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Merging latest pull requests into Master today
I was screwing up the scope, sorry. We should be initializing it with the permissions in the constructor. The purpose of it is for the Java API. So, if we have a plugin dependency that needs to access the permissions of the parent plugin somehow, they can just request the permissions instead of cueing every permission individually. On Mon, Oct 5, 2015 at 10:26 AM, Nikhil Khandelwal wrote: > Sorry for not responding earlier. I like where this is going. I have a > bunch of comments on the PRs. > > I have some confusion around how CordovaPlugin has a protected field > 'permissions' and what a derived CordovaPlugin is supposed to do with it. > None of our core plugins seem to use it. > > Thanks, > Nikhil > > -Original Message- > From: Joe Bowser [mailto:bows...@gmail.com] > Sent: Monday, October 5, 2015 9:05 AM > To: dev > Subject: Merging latest pull requests into Master today > > Hey > > I'm going to pull the 5.0.x proposed pull requests into Master today. Can > anyone take a look at them before I do this. I'm going to wait until after > 1 PM to do it, so if you can check out the new pull requests and comment > on them before then, that would be greatly appreciated, otherwise I'm going > to assume all is good and merge them into the master. > > You've been warned. ;) > > Joe > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org >
RE: [DISCUSS] cordova-serve 0.2.0 release
I'd rather we bump the major and get out of 0.x.x land. On Oct 5, 2015 9:58 AM, "Tim Barham" wrote: > If the version is 0.x.x, then bumping the minor version is treated as a > breaking change (by npm/semver) - the idea is that until version 1.0.0, > things are still in flux. > > That said, I'm happy to call it 1.0.0 if that's preferable. > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Monday, October 5, 2015 9:01 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] cordova-serve 0.2.0 release > > Why not 1.0.0 if it is breaking > On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > > > Hi all... Yesterday I submitted a PR that was a bit of a rework to > > cordova-serve - previously it had essentially been a direct port of > > what was in cordova-lib's 'serve' command and cordova-browser, with a > > couple of hooks to customize functionality. Yesterday's PR changes it > > to use ExpressJS for the grunt-work (which simplifies the code a lot), > > and removes those hooks in favor of the ability to attach Express > > middleware (a breaking change, which will require the next release to > > be bumped to 0.2.0). If anyone who has an opinion about this could > > take a look and provide feedback, that'd be great. > > > > Once I've merged it, I'd like to start a vote thread for an updated > > release of cordova-serve containing this change for a couple of reasons: > > > > * I have the corresponding changes for cordova-browser and cordova-lib > > ready to go, but I can't get them in until we release the updated > > cordova-serve module. > > * I have another module that uses cordova-serve that I'd like to > > switch over to the ExpressJS version. > > > > Thanks! > > > > Tim > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org >
RE: Merging latest pull requests into Master today
Sorry for not responding earlier. I like where this is going. I have a bunch of comments on the PRs. I have some confusion around how CordovaPlugin has a protected field 'permissions' and what a derived CordovaPlugin is supposed to do with it. None of our core plugins seem to use it. Thanks, Nikhil -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Monday, October 5, 2015 9:05 AM To: dev Subject: Merging latest pull requests into Master today Hey I'm going to pull the 5.0.x proposed pull requests into Master today. Can anyone take a look at them before I do this. I'm going to wait until after 1 PM to do it, so if you can check out the new pull requests and comment on them before then, that would be greatly appreciated, otherwise I'm going to assume all is good and merge them into the master. You've been warned. ;) Joe - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/223#discussion_r41171305 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -40,6 +42,7 @@ Licensed to the Apache Software Foundation (ASF) under one public CordovaInterface cordova; protected CordovaPreferences preferences; private String serviceName; +protected String [] permissions; --- End diff -- Each of the core plugins are creating their own version of this field either on the instance or `static`. This can be quite confusing. How would you explain to a plugin developer - what they are expected to do with this field. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/223#discussion_r41170824 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -40,6 +42,7 @@ Licensed to the Apache Software Foundation (ASF) under one public CordovaInterface cordova; protected CordovaPreferences preferences; private String serviceName; +protected String [] permissions; --- End diff -- I feel this is somewhat confusing. What is the derived plugin supposed to with this field? I do not see any of the core plugins doing anything with this field. Did I miss something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Adding permissions, giving read ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/135#discussion_r41170122
--- Diff: src/android/FileUtils.java ---
@@ -65,9 +69,27 @@ Licensed to the Apache Software Foundation (ASF) under
one
public static int TYPE_MISMATCH_ERR = 11;
public static int PATH_EXISTS_ERR = 12;
+/*
+ * Permission callback codes
+ */
+
+public static final int READ_PERM = 0;
+public static final int WRITE_PERM = 1;
+
public static int UNKNOWN_ERR = 1000;
private boolean configured = false;
+private String lastRawArgs;
+
+private CallbackContext callback;
+
+/*
+ * We need both read and write when accessing the storage, I think.
+ */
+
+private String [] permissions = {
--- End diff --
this is unused - why not just remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170726
--- Diff: src/android/AudioHandler.java ---
@@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under
one
private int origVolumeStream = -1;
private CallbackContext messageChannel;
+
+public static String [] permissions = {
Manifest.permission.RECORD_AUDIO, Manifest.permission.WRITE_EXTERNAL_STORAGE};
--- End diff --
These fields below should ideally be private
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170559
--- Diff: src/android/AudioHandler.java ---
@@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under
one
private int origVolumeStream = -1;
private CallbackContext messageChannel;
+
+public static String [] permissions = {
Manifest.permission.RECORD_AUDIO, Manifest.permission.WRITE_EXTERNAL_STORAGE};
+public static int RECORD_AUDIO = 0;
+public static int WRITE_EXTERNAL_STORAGE = 1;
+
+public static final int PERMISSION_DENIED_ERROR = 20;
--- End diff --
Does the magic number need to be documented? I'm not very familiar with
error handling and how Cordova deals with error codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/78#discussion_r41170319 --- Diff: src/android/ContactManager.java --- @@ -48,13 +54,38 @@ Licensed to the Apache Software Foundation (ASF) under one public static final int NOT_SUPPORTED_ERROR = 5; public static final int PERMISSION_DENIED_ERROR = 20; private static final int CONTACT_PICKER_RESULT = 1000; +public static String [] permissions; --- End diff -- Unused variable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/53#discussion_r41169794
--- Diff: src/android/Geolocation.java ---
@@ -0,0 +1,97 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+
+package org.apache.cordova.geolocation;
+
+import android.content.pm.PackageManager;
+import android.Manifest;
+import android.os.Build;
+
+import org.apache.cordova.CallbackContext;
+import org.apache.cordova.CordovaArgs;
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.PluginResult;
+import org.apache.cordova.LOG;
+import org.json.JSONArray;
+import org.json.JSONException;
+
+import javax.security.auth.callback.Callback;
+
+public class Geolocation extends CordovaPlugin {
+
+String TAG = "GeolocationPlugin";
+CallbackContext context;
+
+String [] permissions = { Manifest.permission.ACCESS_COARSE_LOCATION,
Manifest.permission.ACCESS_FINE_LOCATION };
--- End diff --
So this `permissions` is different than the base class `permissions`
protected field. Why does the base class even have a protected field? Should
Geolocation plugin set the base classes version of the field in the constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/53#discussion_r41169177
--- Diff: src/android/Geolocation.java ---
@@ -0,0 +1,97 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */
+
+
+package org.apache.cordova.geolocation;
+
+import android.content.pm.PackageManager;
+import android.Manifest;
+import android.os.Build;
+
+import org.apache.cordova.CallbackContext;
+import org.apache.cordova.CordovaArgs;
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.PluginResult;
+import org.apache.cordova.LOG;
+import org.json.JSONArray;
+import org.json.JSONException;
+
+import javax.security.auth.callback.Callback;
+
+public class Geolocation extends CordovaPlugin {
+
+String TAG = "GeolocationPlugin";
+CallbackContext context;
+
+String [] permissions = { Manifest.permission.ACCESS_COARSE_LOCATION,
Manifest.permission.ACCESS_FINE_LOCATION };
+
+
+public boolean execute(String action, JSONArray args, CallbackContext
callbackContext) throws JSONException {
+context = callbackContext;
+if(action.equals("getPermission"))
+{
+if(hasPermisssion())
+{
+PluginResult r = new PluginResult(PluginResult.Status.OK);
+context.sendPluginResult(r);
+return true;
+}
+else {
+cordova.requestPermissions(this, 0, permissions);
+}
+return true;
+}
+return false;
+}
+
+
+public void onRequestPermissionResult(int requestCode, String[]
permissions,
+ int[] grantResults) throws
JSONException
+{
+PluginResult result;
+for(int r:grantResults)
+{
+if(r == PackageManager.PERMISSION_DENIED)
+{
+LOG.d(TAG, "Permission Denied!");
+result = new
PluginResult(PluginResult.Status.ILLEGAL_ACCESS_EXCEPTION);
+context.sendPluginResult(result);
+return;
+}
+}
+result = new PluginResult(PluginResult.Status.OK);
+context.sendPluginResult(result);
+}
+
+public boolean hasPermisssion() {
--- End diff --
Why override it here? The base class has the same implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] cordova-serve 0.2.0 release
If the version is 0.x.x, then bumping the minor version is treated as a breaking change (by npm/semver) - the idea is that until version 1.0.0, things are still in flux. That said, I'm happy to call it 1.0.0 if that's preferable. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, October 5, 2015 9:01 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] cordova-serve 0.2.0 release Why not 1.0.0 if it is breaking On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > Hi all... Yesterday I submitted a PR that was a bit of a rework to > cordova-serve - previously it had essentially been a direct port of > what was in cordova-lib's 'serve' command and cordova-browser, with a > couple of hooks to customize functionality. Yesterday's PR changes it > to use ExpressJS for the grunt-work (which simplifies the code a lot), > and removes those hooks in favor of the ability to attach Express > middleware (a breaking change, which will require the next release to > be bumped to 0.2.0). If anyone who has an opinion about this could > take a look and provide feedback, that'd be great. > > Once I've merged it, I'd like to start a vote thread for an updated > release of cordova-serve containing this change for a couple of reasons: > > * I have the corresponding changes for cordova-browser and cordova-lib > ready to go, but I can't get them in until we release the updated > cordova-serve module. > * I have another module that uses cordova-serve that I'd like to > switch over to the ExpressJS version. > > Thanks! > > Tim > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/223#discussion_r41164437 --- Diff: framework/src/org/apache/cordova/CordovaInterface.java --- @@ -69,4 +69,20 @@ Licensed to the Apache Software Foundation (ASF) under one * Returns a shared thread pool that can be used for background tasks. */ public ExecutorService getThreadPool(); + +/** + * Sends a permission request to the activity for one permission. + */ +public void requestPermission(CordovaPlugin plugin, int requestCode, String permission); + +/** + * Sends a permission request to the activity for a group of permissions + */ +public void requestPermissions(CordovaPlugin plugin, int requestCode, String [] permissions); --- End diff -- Thanks for making the change! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Merging latest pull requests into Master today
Hey I'm going to pull the 5.0.x proposed pull requests into Master today. Can anyone take a look at them before I do this. I'm going to wait until after 1 PM to do it, so if you can check out the new pull requests and comment on them before then, that would be greatly appreciated, otherwise I'm going to assume all is good and merge them into the master. You've been warned. ;) Joe
Re: [DISCUSS] cordova-serve 0.2.0 release
Why not 1.0.0 if it is breaking On Oct 4, 2015 5:22 PM, "Tim Barham" wrote: > Hi all... Yesterday I submitted a PR that was a bit of a rework to > cordova-serve - previously it had essentially been a direct port of what > was in cordova-lib's 'serve' command and cordova-browser, with a couple of > hooks to customize functionality. Yesterday's PR changes it to use > ExpressJS for the grunt-work (which simplifies the code a lot), and removes > those hooks in favor of the ability to attach Express middleware (a > breaking change, which will require the next release to be bumped to > 0.2.0). If anyone who has an opinion about this could take a look and > provide feedback, that'd be great. > > Once I've merged it, I'd like to start a vote thread for an updated > release of cordova-serve containing this change for a couple of reasons: > > * I have the corresponding changes for cordova-browser and cordova-lib > ready to go, but I can't get them in until we release the updated > cordova-serve module. > * I have another module that uses cordova-serve that I'd like to switch > over to the ExpressJS version. > > Thanks! > > Tim > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[GitHub] cordova-plugin-network-information pull request: Fix checks that a...
GitHub user pstoll opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/35 Fix checks that always evaluate to true. The compiler in Xcode [Version 7.0 (7A220)] warned on these lines that they always evaluate to true. Sure enough, taking the address of an object is always non-null. Fix this to test that these objects are non-null. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pstoll/cordova-plugin-network-information CB-9702 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 5aac2609ceafcdcb0a746dd54bb21899a2f90a7a Author: Perry Stoll Date: 2015-10-05T14:51:02Z These notifications are objects so their address always evaluates to true. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova Face to Face Meeting
I’m new here, and I don’t know how these meetings usually work, but I thought it might make sense to structure the sessions around questions instead of smaller topics. This way, we can get a more open discussion going and talk about these topics within a larger context. Some of the questions I would be interested in discussing are: - How can we improve the development experience? - What can we learn from the React Native developer experience? - Replacing 'white screen of death' with an error reporting screen - Adding a development/debugger menu - How can we make platform installation easier? - Improve requirements checking and error messages - Install SDKs with one command (TACO) - How can we improve the plugin ecosystem? - Plugin dependencies and version constraints - Validated platforms and plugins (TACO) - Improving native dependencies (CocoaPods for iOS?) - What can we learn from the React Native plugin API? - How can we better support hybrid apps? - Is the distinction between the CLI vs. platform-centered workflow still valid? - What is needed to allow customizing native (Xcode/Gradle/...) projects when using the CLI? - Can we share tools or plugins with React Native? - What do integrators need from Cordova? - PlatformApi refactoring - Standardized logging and error/progress reporting > On 03 Oct 2015, at 00:11, Carlos Santana wrote: > > Joe updated the Agenda with topics, I added more topics. > > I put my name on all of them, at this time is just proposals. > > Please add more as you think is appropriate > > https://github.com/cordova/cordova-discuss/blob/master/proposals/Face2Face-Oct15.md > > > > On Fri, Oct 2, 2015 at 4:50 PM Parashuram N wrote: > >> @Joe - I think we should do that too. I think we do need to do that >> session. At the moment, there are 2 time slots when we could have >> "breakout" sessions, I think this could be on the first day. Can you update >> the agenda with this as a breakout session please ? >> >> -Original Message- >> From: Joe Bowser [mailto:bows...@gmail.com] >> Sent: Friday, October 2, 2015 1:47 PM >> To: dev >> Subject: Re: Cordova Face to Face Meeting >> >> Is it possible to have PMC/Committer only sessions? There's some stuff >> that I want to make sure we cover w.r.t. how to deal with Apache Security >> policy, but I'm pretty sure if you're not a PMC/Committer, it'd have almost >> no value to anyone else unless they're really into the fine details of how >> the sausage gets made and how we get screen out the sausage links that >> contain nasty bits. >> >> Also, we should probably have a Cordova workflow discussion, since I'm >> getting the impression that a lot of people don't even know how to work on >> Cordova itself, or that we do it all differently. >> >> On Fri, Oct 2, 2015 at 1:38 PM, Homer, Tony wrote: >> >>> I think this would be a great way to spur discussion about shared >> concerns. >>> It would be great if we could identify some opportunities to make >>> changes that would be beneficial for downstream distributors. >>> >>> I can certainly provide a quick survey of what we do in Intel XDK. >>> >>> >>> Tony >>> >>> On 10/2/15, 4:36 PM, "Nikhil Khandelwal" wrote: >>> +1 to Martijn/Carlos mentioned. Please send PRs to the agenda +document here with your thoughts and agenda items >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu >>> b.com%2fcordova%2fcordova-discuss%2fblob%2fmaster%2fproposals%2fFace2F >>> ace&data=01%7c01%7cpanarasi%40microsoft.com%7c701024943b444795468008d2 >>> cb6aad06%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=h%2f0meNJdvsJsQL >>> %2fvzZyBfHk55DkGyNIPBDYFPe7PjLM%3d -https://na01.safelinks.protection.outlook.com/?url=Oct15.md&data=01% 7c01%7cpanarasi%40microsoft.com%7c701024943b444795468008d2cb6aad06%7c 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0x%2fzxTYkXewiHGP22O24exkD Bex6Mbkc628eXHOLvTI%3d#topics-for-breakout-sessions-and-people-intere sted-in-it I will do the same by the beginning of next week. -Nikhil -Original Message- From: Parashuram N [mailto:panar...@microsoft.com] Sent: Friday, October 2, 2015 1:14 PM To: dev@cordova.apache.org Subject: RE: Cordova Face to Face Meeting Hey, Here is another topic I thought I would propose for the Cordova face to face meeting. Apart from working on Cordova, most of us also use Cordova to build tools for our IDEs, or build applications with Cordova. I thought this would also be an interesting place to see demos of how people are using Cordova in their tools of applications. For example, I would like to see how Cordova is used in things like Intel XDK, Phonegap desktop, Worklight, etc. This would also help us understand how the changes we make in Cordova impacts our customers. What do you guys think ? W
[GitHub] cordova-plugin-splashscreen pull request: iOS : Fix for screen not...
Github user idpaterson commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/56#issuecomment-145523163 [The above code](#issuecomment-132235333) has been working for us in production, I can submit a pull request but I'm not quite clear enough on the scope of the original UI-off-the-main-thread issue in order to properly justify in JIRA that the change does not introduce regression issues. I'll try my best. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9598 Switching to use `cordova-common...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/311#issuecomment-145505359 @nikhilkh, please review once more. The failing tests was fixed. ConfigChanges also was reworked in 2e11c52 as per [conversation on dev thread](http://callback.markmail.org/thread/pmtqf6e5yxvmvt7w) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: iOS : Fix for screen not...
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/56#issuecomment-145501931 any decision on this? would be a real plus to have back in the plugin! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-145500663 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fix crash and add new feature
GitHub user coderReview opened a pull request: https://github.com/apache/cordova-plugin-file/pull/136 Fix crash and add new feature 1- Fix crash when modified date is null (NullPointerException) 2- Added mime-type to Metadata (in Android when Content filesystem is used is the only way to know which file type is being handled. You can merge this pull request into a Git repository by running: $ git pull https://github.com/coderReview/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/136.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #136 commit 5f8608fab099bf90ea95134142c7c07badcd9fa5 Author: Paulo Vitor Magacho da Silva Date: 2015-10-05T11:06:58Z Fix NullPointerException commit fdc11e80aa02e6cf3a3a91a18d02da91164dd49a Author: Paulo Vitor Magacho da Silva Date: 2015-10-05T11:07:17Z Added mime type to Metadata --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9745 Camera plugin docs sho...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/129 CB-9745 Camera plugin docs should be generated from the source Moved the docs to jsdoc comments in the code, removed redundancy. Moved Quirks and extra examples to errata sections of the docs TEMPLATE.md, linked the jsdoc comments to these sections. Added dependencies to common plugin docs template and husky (precommit hook to regen the docs automatically). Added gen-docs command to re-generate the docs. Extended TOC manually [to include classes containing only one member](https://github.com/jsdoc2md/jsdoc-to-markdown/issues/34) (CameraPopoverHandle and CameraPopoverOptions). Extended the docs via DMD template to include "Installation", "How to contribute" and "Docs are generated" warning. [Jira issue](https://issues.apache.org/jira/browse/CB-9745) [cordova-discuss PR](https://github.com/cordova/cordova-discuss/pull/16) This version does not include source links (the patch is going through legal approval). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-9745 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 commit 6cbd5cfab308ded5abdc5781a202a416e821a572 Author: daserge Date: 2015-10-05T10:48:19Z CB-9745 Camera plugin docs should be generated from the source Moved docs to jsdocs comments in the code, removed redundancy. Moved Quirks and extra examples to errata sections of the docs TEMPLATE.md, linked the jsdoc comments to these sections. Added dependencies to common plugin docs template and husky (precommit hook to regen the docs automatically). Added gen-docs command to re-generate the docs. Extended TOC manually [to include classes containing only one member](https://github.com/jsdoc2md/jsdoc-to-markdown/issues/34) (CameraPopoverHandle and CameraPopoverOptions). Extended the docs via DMD template to include "Installation", "How to contribute" and "Docs are generated" warning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121964
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -142,8 +143,17 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
var pluginInfo = pluginInfoProvider.get(depPluginDir);
// TODO: Should remove dependencies in a separate step, since
dependencies depend on platform.
var deps = pluginInfo.getDependencies();
+var deps_path;
deps.forEach(function (d) {
-if (toDelete.indexOf(d.id) === -1) {
+var splitVersion = d.id.split('@');
+deps_path = path.join(plugin_dir, '..', splitVersion[0]);
+if (!fs.existsSync(deps_path)) {
+var newId = pluginMapper[splitVersion[0]];
+if (newId && toDelete.indexOf(newId) === -1) {
+ toDelete.push(newId);
--- End diff --
IMHO it makes sense to add verbose message here to show to user what's
happened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121974
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -256,6 +266,15 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir, plugin
promise = promiseutil.Q_chainmap(danglers, function(dangler) {
var dependent_path = path.join(plugins_dir, dangler);
+//try to convert ID if old-id path doesn't exist.
+if (!fs.existsSync(dependent_path)) {
+var splitVersion = dangler.split('@');
+var newId = pluginMapper[splitVersion[0]];
+if(newId) {
+dependent_path = path.join(plugins_dir, newId);
--- End diff --
Same here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121721
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -404,6 +418,20 @@ function installDependencies(install, dependencies,
options) {
return dependencies.reduce(function(soFar, dep) {
return soFar.then(
function() {
+// Split @Version from the plugin id if it exists.
+var splitVersion = dep.id.split('@');
+//Check if a mapping exists for the plugin id
+//if it does, convert id to new name id
+var newId = pluginMapper[splitVersion[0]];
+if(newId) {
+events.emit('log', 'Notice: ' + dep.id + ' has been
automatically converted to ' + newId + ' and fetched from npm. This is due to
our old plugins registry shutting down.');
--- End diff --
Shouldn't this be emitted with `warn` level to encourage users to switch to
new plugin id instead of relying on plugin mapper?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9589 auto convert IDs to new style ID...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121704
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,6 +80,19 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir,
var current_stack = new action_stack();
+// Split @Version from the plugin id if it exists.
+var splitVersion = id.split('@');
+//Check if a mapping exists for the plugin id
+//if it does, convert id to new name id
+var newId = pluginMapper[splitVersion[0]];
+if(newId) {
+events.emit('log', 'Notice: ' + id + ' has been automatically
converted to ' + newId + ' and fetched from npm. This is due to our old plugins
registry shutting down.');
--- End diff --
Shouldn't this be emitted with `warn` level to encourage users to switch to
new plugin id instead of relying on plugin mapper?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
