[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-cli/pull/236#issuecomment-192151135
  
Hi @nikhilkh 
Thanks for reviewing.
I changed all 5 pull requests (CLI, LIB, android, ios, windows) to 
accommodate your comments using --force.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-192122950
  
@nikhilkh, I'm investigating it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#issuecomment-192119659
  
@sarangan12, probably we should also include `` in 
the example configuration (according to 
[cordova-windows/.../prepare.js](https://github.com/apache/cordova-windows/blob/92a298a3189ce8ce9fe6973b49dbdc777835a62b/template/cordova/lib/prepare.js#L338)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/236#discussion_r54992890
  
--- Diff: doc/plugin.txt ---
@@ -20,7 +20,10 @@ Manage project plugins
 --browserify ... Compile plugin JS at build time 
using 
  browserify instead of runtime.
 
-remove | [...] . Remove plugins with the given 
IDs/name.
+--force-copying-src  forces copying source files from 
the plugin even if the same
+ file already exists in the target 
directory.
+
+remove | [...] . Remove plugins with the given 
IDs/name.
--- End diff --

Indentation issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10673 added --force-copying-src optio...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/236#discussion_r54992862
  
--- Diff: doc/plugin.txt ---
@@ -20,7 +20,10 @@ Manage project plugins
 --browserify ... Compile plugin JS at build time 
using 
  browserify instead of runtime.
 
-remove | [...] . Remove plugins with the given 
IDs/name.
+--force-copying-src  forces copying source files from 
the plugin even if the same
--- End diff --

I would just name this option --force. This needs to be documented here: 
https://github.com/apache/cordova-cli/blob/master/doc/readme.md#cordova-plugin-command


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54992597
  
--- Diff: README.md ---
@@ -166,9 +217,10 @@ screen is meant to be visible before your app has 
started, that would seem to
 defeat the purpose of the splash screen.  Providing some configuration in
 `config.xml` will automatically `show` the splash screen immediately after 
your
 app launch and before it has fully started and received the `deviceready`
-event. See [Icons and Splash 
Screens](http://cordova.apache.org/docs/en/edge/config_ref_images.md.html)
+event. See [Icons and Splash Screens][Icons and Splash Screens]
--- End diff --

Your change adds the docs here - so you need not even reference this page - 
correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix Crash on Android 6.0 for p...

[vishalkardode]

GitHub user vishalkardode opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/189

Fix Crash on Android 6.0 for permissions

Removed check `fileWillBeModified` before requesting runtime Permissions.
When you don't specify image height / width for picker, plugin does not ask 
for `READ_EXTERNAL_STORAGE `permission and results in crash while file 
selection.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vishalkardode/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #189


commit 9a9fd25ef992677aaaf6180b1d5bab72b90e9289
Author: Vishal Kardode 
Date:   2016-03-04T05:40:38Z

Fix Crash on Android 6.0 for permissions

Removed check `fileWillBeModified` before requesting runtime Permissions.
When you don't specify image height / width for picker, plugin does not ask 
for READ_EXTERNAL_STORAGE permission and results in crash while file selection.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/235#issuecomment-192109284
  
What about the Travis CI failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#issuecomment-192107322
  
@daserge to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/270#issuecomment-192091647
  
LGTM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-192078564
  
@adamduren any word on the README update? It just needs to be a short blurb 
pointing to the [Android lifecycle 
guide](http://cordova.apache.org/docs/en/latest/guide/platforms/android/lifecycle.html)
 really. Looking at the javascript code for this plugin, I don't really think 
there is any need for anything else. We just need to list the quirk and point 
to the documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10632: Fixing jasmine tes...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10632: Fixing jasmine tes...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/106#issuecomment-192062637
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10632: Fixing jasmine tes...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/106#issuecomment-192051740
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10632: Fixing jasmine tes...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/106#issuecomment-192045714
  
@dblotsky @rakatyal to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54975679
  
--- Diff: README.md ---
@@ -166,9 +217,10 @@ screen is meant to be visible before your app has 
started, that would seem to
 defeat the purpose of the splash screen.  Providing some configuration in
 `config.xml` will automatically `show` the splash screen immediately after 
your
 app launch and before it has fully started and received the `deviceready`
-event. See [Icons and Splash 
Screens](http://cordova.apache.org/docs/en/edge/config_ref_images.md.html)
+event. See [Icons and Splash Screens][Icons and Splash Screens]
 for more information on doing this configuration. For this reason, it is
 unlikely you need to call `navigator.splashscreen.show()` to make the 
splash
 screen visible for app startup.
 
 [Apache Cordova issue tracker]: 
https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20Splashscreen%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC
+[Icons and Splash Screens]: 
http://cordova.apache.org/docs/en/edge/config_ref_images.md.html
--- End diff --

The edge version doesn't exist, BTW.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54975230
  
--- Diff: README.md ---
@@ -166,9 +217,10 @@ screen is meant to be visible before your app has 
started, that would seem to
 defeat the purpose of the splash screen.  Providing some configuration in
 `config.xml` will automatically `show` the splash screen immediately after 
your
 app launch and before it has fully started and received the `deviceready`
-event. See [Icons and Splash 
Screens](http://cordova.apache.org/docs/en/edge/config_ref_images.md.html)
+event. See [Icons and Splash Screens][Icons and Splash Screens]
 for more information on doing this configuration. For this reason, it is
 unlikely you need to call `navigator.splashscreen.show()` to make the 
splash
 screen visible for app startup.
 
 [Apache Cordova issue tracker]: 
https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20Splashscreen%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC
+[Icons and Splash Screens]: 
http://cordova.apache.org/docs/en/edge/config_ref_images.md.html
--- End diff --

Why do we use the edge version and not the latest?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54975200
  
--- Diff: README.md ---
@@ -70,7 +121,7 @@ In your `config.xml`, you need to add the following 
preferences:
 
 
 
-Where foo is the name of the splashscreen file, preferably a 9 patch file. 
Make sure to add your splashcreen files to your res/xml directory under the 
appropriate folders. The second parameter represents how long the splashscreen 
will appear in milliseconds. It defaults to 3000 ms. See [Icons and Splash 
Screens](http://cordova.apache.org/docs/en/edge/config_ref_images.md.html)
+Where foo is the name of the splashscreen file, preferably a 9 patch file. 
Make sure to add your splashcreen files to your res/xml directory under the 
appropriate folders. The second parameter represents how long the splashscreen 
will appear in milliseconds. It defaults to 3000 ms. See [Icons and Splash 
Screens][Icons and Splash Screens]
--- End diff --

We have renamed it to 'Use Icons' so consider using the same title. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-ios/pull/198#issuecomment-192039192
  
Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

[stevengill]

Github user stevengill closed the pull request at:

https://github.com/apache/cordova-ios/pull/198


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54974693
  
--- Diff: README.md ---
@@ -44,6 +44,57 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 - Windows
 - Browser
 
+## Example Configuration
+In the top-level `config.xml` file (not the one in `platforms`), add 
configuration elements like those specified here.
+
+Please notice that the value of the "src" attribute is relative to the 
project directory and not to the www directory. You can name the source image 
whatever you like. The internal name in the app is determined by Cordova.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
--- End diff --

Please rename it to windows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Hamronize CFBudleIndtifier

[Mefire O .]

I’m in favor of keeping the prefixes,
as some people might want to target both iOS and OS X and therefore might need 
to use different versions independently of each other.
Removing them makes that scenario harder to handle.

Thanks,
Omar Mefire

On Mar 3, 2016, at 4:23 PM, Shazron 
> wrote:

I sometimes have to use a different version for the android or iOS app, so

[GitHub] cordova-docs pull request: Document CDVSystemSchemesOverride prefe...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-docs/pull/538#issuecomment-192037731
  
This was removed and is not relevant anymore. 

https://github.com/apache/cordova-ios/commit/3964a50b0ed01ca9822c2c6e30cd3a8514b45504

system schemes are now handled by the  tag


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/536#discussion_r54973380
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -189,7 +189,7 @@ platform. See [Customize icons topic](images.html) for 
more information.
 
 
 ## engine
-   Specifies what platform to restore during a prepare. For more details, 
see the [Platforms & Plugins Version 
Management](../platform_plugin_versioning_ref/index.html).
+   Specifies what platform to restore during a prepare. For more details, 
see the [Platforms & Plugins Version 
Management](../platform_plugin_versioning_ref/index.html#platform-versioning).
--- End diff --

The TOC tile should really be renamed "Manage platforms and plugins"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/198#issuecomment-192035749
  
This PR didn't close even though the commits are in. Might have to do a 
future empty commit to close this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/536#discussion_r54972830
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -199,6 +199,18 @@ platform. See [Customize icons topic](images.html) for 
more information.
Examples:
 
 
+
+## plugin
+   Specifies what plugin to restore during a prepare. For more details, 
see the [Platforms & Plugins Version 
Management](../platform_plugin_versioning_ref/index.html#plugin-versioning).
+
+   Attributes(type) | Description
+   - | 
+   name(string) | *Required*  Name of the plugin to be restored
+   spec(string) | *Required*  Version of the plugin to be restored
--- End diff --

Spec is not the `version` - correct? I describe it in detail here: 
https://cordova.apache.org/docs/en/dev/cordova-cli/index.html#plugin-spec


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Hamronize CFBudleIndtifier

[Shazron]

My concern with removing the prefix is, and I'm not sure exactly what
Apple's policy is, that the Mac App Store and iOS App Store might
require unique bundle ids for apps. So if you had the same bundle id
for the MAS and the iOS App Store, they might reject it.

On Tue, Feb 23, 2016 at 7:31 PM, Steven Gill  wrote:
> Oops. My +1 was for removing them in this case. But I don't have a issue
> with keeping them either. Let's see what Shaz says when he manages to feel
> better. He has been sick the last few days.
> On Feb 23, 2016 6:39 PM, "Tobias Bocanegra"  wrote:
>
>> On Tue, Feb 23, 2016 at 4:16 PM, Steven Gill 
>> wrote:
>> > +1
>>
>> +1 to what? keep the prefixes or remove them? :-))
>>
>> regards, toby
>>
>> >
>> > On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez <
>> jcesarmob...@gmail.com
>> >> wrote:
>> >
>> >> +1 to prefixed versions
>> >>
>> >> I always use the same bundle identifier/package name for the same app,
>> but
>> >> I sometimes have to use a different version for the android or iOS app,
>> so
>> >> it's better if I can set them directly from the config.xml and not use a
>> >> hook.
>> >>
>> >>
>> >> 2016-02-23 7:54 GMT+01:00 Tobias Bocanegra :
>> >>
>> >> > Hi,
>> >> >
>> >> > he current commons code uses ios-CFBundleVersion and
>> >> > ios-CFBundleIdentifier: [0], [1]
>> >> >
>> >> > Now with OSX in the game there could be similar new attributes
>> >> > osx-CFBundleVersion and osx-CFBundleIdentifier or we could deprecate
>> >> > the ios-* ones and just use their plain names without prefix.
>> >> >
>> >> > suggest:
>> >> > - use CFBundleVersion and CFBundleIdentifier for iOS and OSX platform.
>> >> > - deprecate ios-CFBundleVersion and ios-CFBundleIdentifier
>> >> >
>> >> > drawback:
>> >> >   using the un-prefixed attribute names would prevent a project of
>> >> > having different versions/identifiers for the ios and osx platforms.
>> >> > if one wants to evolve them separately, he would then need to use some
>> >> > hooks to tweak the config.xml.
>> >> >
>> >> > counter argument:
>> >> >   windows and android also use prefixed versions, so maybe its better
>> >> > to keep this pattern consistent.
>> >> >
>> >> > see [2].
>> >> >
>> >> > regards, toby
>> >> >
>> >> > [0]
>> >> >
>> >>
>> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
>> >> > [1]
>> >> >
>> >>
>> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
>> >> > [2] https://issues.apache.org/jira/browse/CB-10603
>> >> >
>> >> > -
>> >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> >> > For additional commands, e-mail: dev-h...@cordova.apache.org
>> >> >
>> >> >
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Remote site plugin

[Shazron]

In config.xml,
http://mysite.com; />
http://mysite.com; />

... does not work for you?

Also, ErrorUrl support:
https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;a=blobdiff;f=docs/en/edge/guide/platforms/ios/config.md;h=6b05869c4eec7418dee7fe8e16089ea6474d3a35;hp=e0e0a73fd0a85cb5dce2ba35df75c105ad243e69;hb=83a113c;hpb=281dc5f7c5911f9474241c3f79eb25cc9ae65c08


On Wed, Feb 17, 2016 at 11:28 AM, Brad Reynolds  wrote:
> We built a Cordova app that wraps a remote site.  The only HTML page
> bundled in our app redirects to our remote site on load.  I was new to
> Cordova at the time and was looking for the fastest way possible to get the
> app out the door.  To do so I modified the generated iOS and Android
> projects with the hooks I felt I needed in order to inject Cordova
> components and plugins into the remote site.  It seems to be working for us
> and has been accepted by both app stores.
>
> I'd like to package up the modifications for this as a plugin as we plan to
> build other apps in the same manner.  I've been familiarizing myself with
> the plugin architecture and am not sure if what I need is exposed on both
> platforms and thus this email to the dev list.  I'm looking for guidance on
> how to implement the hooks I've listed below as a plugin.  The end goal is
> to inject the Cordova components and plugins and allow the user to retry
> loading the site upon error.  Below are details of the changes I made.  I'm
> going to keep digging on my own but any direction would be greatly
> appreciated.
>
> Thanks,
> Brad Reynolds
>
> ## iOS
>
> iOS was pretty simple to get up and running.  The generated
> MainViewController had page life cycle methods that I was able to easily
> hook into and inject Cordova.
>
> ### MainViewController.m Changes:
>
> 1. Implemented `webViewDidFinishLoad:(UIWebView *)theWebView` to inject
> Cordova components.
>
> To allow the user to retry reloading the current page upon failure:
>
> 1. Implemented `webView:(UIWebView *)theWebView
> didFailLoadWithError:(NSError *)error`.
>
> ## Android
>
> Android was more difficult or at least I had to look for something other
> than page events.  The end result was I used Android's
> `@JavascriptInterface` mechanism to make a JS object available that would
> inject Cordova into the current page.  As a result all loaded pages needed
> to look for this object and invoke an initialization function on it.
>
> 1. Subclassed SystemWebViewEngine and added config.xml entry to use our
> engine.
> 2. Subclassed SystemWebView and returned from our engine.
> 3. Within our SystemWebView subclass added a JavascriptInterface providing
> a hook back into Android. When invoked this told the Adroid code it was
> time to inject Cordova.
>
> To allow the user to retry reloading the current page:
>
> 1. Implemented MainActivity.onReceivedError(...).

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10784: CDVContactsPicker ...

[coryjthompson]

GitHub user coryjthompson opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/107

CB-10784: CDVContactsPicker finish animating before callback

https://issues.apache.org/jira/browse/CB-10784

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coryjthompson/cordova-plugin-contacts master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #107


commit a75d1198d01980b37d112ae515223812513b10d6
Author: Cory Thompson 
Date:   2016-03-03T23:52:28Z

CDVContactsPicker finish automating before callback




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 4.0.1 OSX Release

[Steven Gill]

Please review and vote on this 4.0.1 OSX Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10779

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10779

The package was published from its corresponding git tag:
cordova-osx: 4.0.1 (a8e7d75aaa)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-osx#4.0.1

Upon a successful vote I will upload the archive to dist/ and publish it to npm.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobilespec & built hello world

DISCUSS cordova-paramedic

[Jesse]

Nikhil and team have expressed interest in using cordova-paramedic for more
of our cordova CI work. This is approach that I explored last year but
ultimately dropped because I couldn't keep up with changes needed to keep
it running as a CI. The main issue I had was that TravisCI could only build
for iOS OR Android, and could not do both.  Similarily, AppVeyor could do
Windows OR Android, but not both.  This lead to tests that looked as if
they had passed, even though changes had been committed to untested
platforms. Given that there is more interest, we can probably find a way to
push through these issues, and have true github integration so we can see
if a pull request is failing tests. I was also not able to get the WP8
emulator running in a CI environment, although this is now not a much of a
concern as it is deprecated. Some stuff is also harder to test in a CI
emulator/simulator, like camera, where some user interaction is needed.

Currently cordova-paramedic is managed through my own repo, although Apache
licenced. This was so that I could iterate quickly, and publish to npm
without going through voting procedures. Given that others will be
committing, I have asked infra to create a new repo [1] for it to live in.
This way we can all commit without legal hurdles.



[1] https://issues.apache.org/jira/browse/INFRA-11371

@purplecabbage
risingj.com

Re: Discuss: Moving current 'dev' documentation to 6.x

[Shazron]

+1

On Thu, Mar 3, 2016 at 3:15 PM, Raghav Katyal  wrote:
> Hi everyone!
>
> I am planning to move the current dev version of our documentation to 
> 6.x(latest) version. We have done a significant amount of work to improve our 
> documentation and I have also written a blog post summarizing them. Please 
> review them if you would like.
>
> Blog PR: https://github.com/apache/cordova-docs/pull/527/files
> Docs PR: https://github.com/apache/cordova-docs/pull/537
>
> -Raghav

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[sarangan12]

Github user sarangan12 commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54966856
  
--- Diff: README.md ---
@@ -21,7 +21,7 @@
 
 # cordova-plugin-splashscreen
 
-This plugin displays and hides a splash screen during application launch.
+This plugin is required to work with plugins. This plugin displays and 
hides a splash screen during application launch.
--- End diff --

Ouch... Changed it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[infil00p]

Github user infil00p commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/270#discussion_r54966810
  
--- Diff: bin/templates/project/build.gradle ---
@@ -86,6 +86,7 @@ ext {
 }
 
 // PLUGIN GRADLE EXTENSIONS START
+apply from: "cordova-plugin-crosswalk-webview/app-xwalk.gradle"
--- End diff --

Yeah, saw it, added two commits to this PR addressing that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: Reorganizing and rewor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/536#discussion_r54966658
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -252,11 +266,15 @@ platform. See [Customize icons topic](images.html) 
for more information.
UIWebViewDecelerationSpeed(string) | *Default: normal*  Allowed 
values: normal, fast  ==iOS==  This property controls the 
deceleration speed of momentum scrolling. normal is the default speed for most 
native apps, and fast is the default for Mobile Safari.
WebSecurity(string) | *Default: enable*  ==BlackBerry==  Set 
to disable to override web security settings, allowing access to remote content 
from unknown sources. This preference is intended as a development convenience 
only, so remove it before packaging the app for distribution. For the released 
app, all URIs should be known and whitelisted using the  element, 
described in the Domain Whitelist Guide.
WindowSize(string) | *Default: auto*  ==OS X **4.0.0**==  
Sets the size of the application window.  Accepts the format `WxH` for a 
specific width and height or the special values `auto` and `fullscreen`. The 
latter will open a borderless window spanning the entire desktop area. Please 
note, that this is different from the _normal_ OS X fullscreen mode, which 
would never span multiple displays.  **Note**: The global cordova 
`fullscreen` preference has no effect in OS X.
+   WindowsDefaultUriPrefix(string) | ==Windows==  Allowed values: 
`ms-appx://`, `ms-appx-web://`   Identifies whether you want your app to 
target the local context or remote context as its startup URI. When building 
for Windows 10, the default is the remote context (`ms-appx-web://`).  In 
order to have a local-mode application that is not impacted by Remote Mode 
capability restrictions, you must set this preference to `ms-appx://` and not 
declare any `` elements with remote URIs. The local mode is the default 
for Windows 8.1
+   WindowsStoreDisplayName(string) | ==Windows==  A friendly name for 
the publisher that can be displayed to users. 
+   WindowsStoreIdentityName(string) | ==Windows==  Identity name used 
for Windows store. The identity is defines a globally unique identifier for a 
package. A package identity is represented as a tuple of attributes of the 
package. See the [identity page on the package manifest schema 
reference](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx) 
for further details.
--- End diff --

The identity defines a ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10737 Fetching now errors out on inv...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/525


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Discuss: Moving current 'dev' documentation to 6.x

[Steven Gill]

Looks great! Awesome job Raghav and everyone else who was involved in this
initiative! Big improvement!

On Thu, Mar 3, 2016 at 3:15 PM, Raghav Katyal 
wrote:

> Hi everyone!
>
> I am planning to move the current dev version of our documentation to
> 6.x(latest) version. We have done a significant amount of work to improve
> our documentation and I have also written a blog post summarizing them.
> Please review them if you would like.
>
> Blog PR: https://github.com/apache/cordova-docs/pull/527/files
> Docs PR: https://github.com/apache/cordova-docs/pull/537
>
> -Raghav
>

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/270#discussion_r54966478
  
--- Diff: bin/templates/project/build.gradle ---
@@ -86,6 +86,7 @@ ext {
 }
 
 // PLUGIN GRADLE EXTENSIONS START
+apply from: "cordova-plugin-crosswalk-webview/app-xwalk.gradle"
--- End diff --

Alright, I think that lines 249 and 250 might have been added in as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/536#discussion_r54966370
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -189,7 +189,7 @@ platform. See [Customize icons topic](images.html) for 
more information.
 
 
 ## engine
-   Specifies what platform to restore during a prepare. For more details, 
see the [Platforms & Plugins Version 
Management](../platform_plugin_versioning_ref/index.html).
+   Specifies what platform to restore during a prepare. For more details, 
see the [Platforms & Plugins Version 
Management](../platform_plugin_versioning_ref/index.html#platform-versioning).
--- End diff --

Can we rename the link to the updated title: "Manage versions and 
platforms"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10744 Fixing fragment link handling

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/526


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[infil00p]

Github user infil00p commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/270#discussion_r54966373
  
--- Diff: bin/templates/project/build.gradle ---
@@ -86,6 +86,7 @@ ext {
 }
 
 // PLUGIN GRADLE EXTENSIONS START
+apply from: "cordova-plugin-crosswalk-webview/app-xwalk.gradle"
--- End diff --

Nope, I'll remove it and redo the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Document CDVSystemSchemesOverride prefe...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-docs/pull/538

Document CDVSystemSchemesOverride preference for iOS



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-docs 
iOSPrefs_CDVSystemSchemesOverride

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #538


commit fd998a3269089f7a437135205f0032df22a2bfff
Author: Omar Mefire 
Date:   2016-03-03T23:18:52Z

Document CDVSystemSchemesOverride preference for iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10720 Fixed spelling, capit...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/186


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: CB-10720 Minor spelling/forma...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-console/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Reverse-engineering GitHub's slugifying...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/532


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Discuss: Moving current 'dev' documentation to 6.x

[Raghav Katyal]

Hi everyone!

I am planning to move the current dev version of our documentation to 
6.x(latest) version. We have done a significant amount of work to improve our 
documentation and I have also written a blog post summarizing them. Please 
review them if you would like.

Blog PR: https://github.com/apache/cordova-docs/pull/527/files
Docs PR: https://github.com/apache/cordova-docs/pull/537

-Raghav

Re: Globalization and Splashscreen plugins release

[Shazron]

Put up a new DISCUSS thread for a new Plugins release

On Thu, Mar 3, 2016 at 12:28 PM, Edna Y Morales  wrote:
>
> Hi,
>
> There are some fixes we are wanting to get released for
> cordova-plugin-globalization and cordova-plugin-splashscreen. Any thoughts
> on when we can do the next release for these?
>
> Thanks,
> Edna Morales

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/90#discussion_r54964638
  
--- Diff: README.md ---
@@ -21,7 +21,7 @@
 
 # cordova-plugin-splashscreen
 
-This plugin displays and hides a splash screen during application launch.
+This plugin is required to work with plugins. This plugin displays and 
hides a splash screen during application launch.
--- End diff --

Did you mean to say "This plugin is required to work with splash screens"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/534#discussion_r54964102
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -245,6 +244,9 @@ platform. See [Customize icons topic](images.html) for 
more information.
PopupBlocker(string) | *Default: enable*  ==BlackBerry==  
Enables the popup blocker, which prevents calls to window.open(). By default, 
popups display in a child browser window. Setting the preference to enable 
prevents it from displaying at all.
SetFullscreen(boolean) | *Default: false*  ==Android==  Same 
as the Fullscreen parameter in the global configuration of this xml file. This 
Android-specific element is deprecated in favor of the global Fullscreen 
element, and will be removed in a future version.
ShowTitle(boolean) | *Default: false*  ==Android==  Show the 
title at the top of the screen.
+   SplashScreen(string) | *Default: splash*  ==Android==  The 
name of the file minus its extension in the ```res/drawable``` directory. 
Various assets must share this common name in various subdirectories.
--- End diff --

We do not document SplashScreen config properties as they are considered 
part of the SplashScreen plugin - even though the code is part of each 
platform. We should probably mention one of them here without providing details 
(so as not to duplicate the docs) and say that splashscreen plugin is required 
for them to work and they are documented there!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/534#discussion_r54963846
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -211,9 +211,8 @@ platform. See [Customize icons topic](images.html) for 
more information.
android-maxSdkVersion(integer) | *Default: Not Specified*  
==Android==  Sets the `maxSdkVersion` attribute of the `` tag in 
the project's `AndroidManifest.xml` (see [here][uses-sdk]).
android-minSdkVersion(integer) | *Default: Dependent on cordova-android 
Version*  ==Android==  Sets the `minSdkVersion` attribute of the 
`` tag in the project's `AndroidManifest.xml` (see [here][uses-sdk]).
android-targetSdkVersion(integer) | *Default: Dependent on 
cordova-android Version*  ==Android==  Sets the `targetSdkVersion` 
attribute of the `` tag in the project's `AndroidManifest.xml` (see 
[here][uses-sdk]).
-   AppendUserAgent(string) | ==Android==  If set, the value will 
append to the end of old UserAgent of webview. When using with 
OverrideUserAgent, this value will be ignored.
-   AppendUserAgent(string) | ==iOS==  If set, the value will append 
to the end of old UserAgent of webview. When using with OverrideUserAgent, this 
value will be ignored.
-   BackgroundColor(string) | ==Android== ==BlackBerry== ==Windows==  
Supports a four-byte hex value, with the first byte representing the alpha 
channel, and standard RGB values for the following three bytes.
+   AppendUserAgent(string) | ==Android== ==iOS==  If set, the value 
will append to the end of old UserAgent of webview. When using with 
OverrideUserAgent, this value will be ignored.
+   BackgroundColor(string) | ==Android== ==BlackBerry== ==Windows==  
Supports a four-byte hex value, with the first byte representing the alpha 
channel, and standard RGB values for the following three bytes.  For 
Windows, it is a three-byte hexadecimal number preceded by "#" or a named color.
--- End diff --

Should we comment that the alpha channel byte is dropped by Cordova windows 
build automatically?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Moving dev to 6.x

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/537

Moving dev to 6.x



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #537


commit 6b8428d215b2433edfa28776162269995f098370
Author: Raghav Katyal 
Date:   2016-03-03T22:58:34Z

Moving dev to 6.x




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Fix a number of documentation ...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/528#discussion_r54963229
  
--- Diff: www/docs/en/dev/config_ref/images.md ---
@@ -42,79 +45,107 @@ density   | *Optional*  Specified icon 
density (Android Specific)
 
 The following configuration can be used to define single default icon
 which will be used for all platforms.
-
-
-
+```xml
+
+```
 For each platform you can also define a pixel-perfect icons set to fit
 different screen resolutions.
 
 ##Android
-
- 
-  
-  
-  
-  
- 
+```xml
+
+
+
+
+
+
+
+
+
+```
+###See Also
+- [Android icon guide](https://www.google.com/design/spec/style/icons.html)
+- [Android - Supporting multiple 
screens](http://developer.android.com/guide/practices/screens_support.html)
--- End diff --

It's easier to see them all in the same place at the bottom, but it doesn't 
make much of a difference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/270#discussion_r54962742
  
--- Diff: bin/templates/project/build.gradle ---
@@ -86,6 +86,7 @@ ext {
 }
 
 // PLUGIN GRADLE EXTENSIONS START
+apply from: "cordova-plugin-crosswalk-webview/app-xwalk.gradle"
--- End diff --

Is this import intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10688:Cordova Plugin ...

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/90

CB-10688:Cordova Plugin Splashscreen Readme must have examples

Adding examples to the splashscreen readme. 

@rakatyal @nikhilkh @dblotsky Can you review and merge this PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-plugin-splashscreen 
CB-10688

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #90


commit d21554b41e65c7b427f699a06e70b90fd8a0fec2
Author: Sarangan Rajamanickam 
Date:   2016-03-03T22:25:02Z

CB-10688:Cordova Plugin Splashscreen Readme must have examples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/534#discussion_r54962124
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -60,7 +60,7 @@ platform. See [Customize icons topic](images.html) for 
more information.
versionCode(string) | ==Android==  Alternative version for 
Android. For further details, see [Android 
versioning](http://developer.android.com/tools/publishing/versioning.html)
ios-CFBundleVersion(string) |  ==iOS==  Alternative version for 
iOS. For further details, see [iOS 
versioning](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
osx-CFBundleVersion(string) |  ==OS X==  Alternative version for 
OS X. For further details, see [OS X 
versioning](https://developer.apple.com/library/prerelease/mac/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
-   packageVersion(string) |   ==Windows==  Alternative version for 
Windows. For futher details, see [Windows 
versioning](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx)
+   windows-packageVersion(string) |   ==Windows==  Alternative 
version for Windows. For futher details, see [Windows 
versioning](https://msdn.microsoft.com/en-us/library/windows/apps/br211441.aspx)
--- End diff --

The example below also needs an update. Also, we should really have one 
`widget` element with the attribute - as that's how people should use this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding OS X platform guide to TOC

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/535


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-192000348
  
@rakatyal , could you please help review this ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-docs/pull/536

CB-10760: Document plugin element



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-docs CB-10760

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/536.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #536


commit 24543029a5924746135090014d818b68b9816e2b
Author: Omar Mefire 
Date:   2016-03-03T20:10:52Z

Documenting some missing prefs: WindowsStoreIdentityName, 
WindowsStoreDisplayName, WindowsStorePublisherName, BackgroundColor, 
WindowsToastCapable

commit b1919d86560e9b06f596cf35c50271906f1af3f2
Author: Omar Mefire 
Date:   2016-03-03T20:47:00Z

Adding Examples for previously missing Windows Config Preferences

commit 942bb375bfe4700d63770ea72d4abf43bba0b138
Author: Omar Mefire 
Date:   2016-03-03T22:38:38Z

CB-10760: Documenting the 'plugin' element




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] CB-8976, CB-8453 and is there anyone building multiple APKs

[Joe Bowser]

OK, because I'm paranoid about this one due to the backlash I think it
could get, here's a pull request:
https://github.com/apache/cordova-android/pull/270

Can people review it and let me know if this makes sense? Then we can merge
it in.

On Thu, Mar 3, 2016 at 12:23 PM, Joe Bowser  wrote:

> OK, Last call on this.
>
> I'm deleting a bunch of the code that's not related to Crosswalk.  That
> said, it's going to make this obsolete:
>
> https://software.intel.com/en-us/xdk/articles/android-and-crosswalk-cordova-version-code-issues
>
> We're not going to do the stupid minSDK mapping anymore because it's
> counter to the philosophy of the Cordova project, and it should have never
> been done to begin with.  However, we're keeping the modification to the
> version codes if you're using Crosswalk.
>
> So, if you're releasing without crosswalk, and you set your version code
> to 1, here's what's going to happen:
> android-release.apk = Version Code 1
>
> If you're releasing WITH CROSSWALK, here's what's going to happen:
> android-armv7-release.apk = Version Code 12
> android-x86-release.apk = Version Code 14
>
> If you add Crosswalk to a project somewhere along the line, know that
> you're going to have to multiply your version code by 10.  I hope this
> doesn't go past maxInt, but it's the only way I can think of to give
> developers back the control they lost with the earlier version code issues.
>
> If this breaks your stuff, or causes you to have a massive problem (i.e.
> You're at version 12, and you somehow have a collision with your Crosswalk
> version because you didn't set your sdk version), please let me know now.
>
> On Wed, Mar 2, 2016 at 2:39 PM, Joe Bowser  wrote:
>
>>
>>
>> On Wed, Mar 2, 2016 at 2:34 PM, Carlos Santana 
>> wrote:
>>
>>> What do you mean by a manual step to set the architecture?
>>>
>>> meaning that "cordova build" will build one apk by default
>>>
>>>
>> Yes, right now if I set the version code to 1 and do a crosswalk build, I
>> would get the following version codes and APKs:
>> android-armv6-release.apk - Version Code 12
>> android-x86-release.apk - Version Code 14
>>
>>
>>> But if they want a specific architecture or multiple built they can do
>>> via
>>> extra argument to "cordova build"
>>>
>>> Like cordova build -- --x86 --arm
>>>
>>>
>> I don't think we should do multiple at all.  I think we should build just
>> one.
>>
>> So, if you do this cordova build release --arch=arm
>>
>> You get only
>>
>> android-armv6-release.apk - Version Code 1
>>
>> And then to get the other one you have change the version code to 2 and
>> do this:
>>
>> cordova build release --arch=x86
>>
>> android-x86-release.apk - Version Code 2
>>
>>
>>
>>> This is similar for windows platform where user control targets and build
>>> via extra flags to build command, or not even related?
>>>
>>>
>> Yes, this issue is open because we're copying how Windows does things.  I
>> don't know why we're doing a multiple APK build, except that Crosswalk is
>> an Intel thing, maybe?
>>
>>
>>>
>>>
>>>
>>> On Wed, Mar 2, 2016 at 5:17 PM Joe Bowser  wrote:
>>>
>>> > On Wed, Mar 2, 2016 at 2:02 PM, Carlos Santana 
>>> > wrote:
>>> >
>>> > > Avoiding a large APK is kind of a good feature to have, to build
>>> small
>>> > apk
>>> > > targeted to specific architecture.
>>> > >
>>> > > What's your proposal ? Maybe I missed it
>>> > >
>>> > >
>>> > Step 1. Remove the code that changes version codes but has nothing to
>>> do
>>> > with architecture and get users to specify the Android Version Code in
>>> the
>>> > config.xml like so:
>>> > >> version="0.0.1"
>>> > xmlns="http://www.w3.org/ns/widgets; xmlns:cdv="
>>> > http://cordova.apache.org/ns/1.0;>
>>> >
>>> >
>>> > > You said to remove multiple apk generation or have multiple apk
>>> > generation
>>> > > being don in a different way to handle the versionCode per
>>> architecture?
>>> > >
>>> > >
>>> > Yeah, for the short term, I think multiplying by 10, and reserving the
>>> last
>>> > spot to denote x86 or arm isn't an awful solution, but it's far from
>>> > ideal.  If we can turn off multiple APK generation and add the ability
>>> to
>>> > set an architecture, then this would turn into a manual step for the
>>> > developer to take advantage of, and they can decide if version 11 is
>>> arm
>>> > and version 12 is x86, but I'm not sure if developers are able to
>>> handle
>>> > that or want it abstracted, which is why I'm asking.
>>> >
>>> >
>>> > >
>>> > > On Wed, Mar 2, 2016 at 4:41 PM Joe Bowser  wrote:
>>> > >
>>> > > > On Wed, Mar 2, 2016 at 1:26 PM, Carlos Santana <
>>> csantan...@gmail.com>
>>> > > > wrote:
>>> > > >
>>> > > > > If it's not well documented how this multiple APKs suppose to
>>> work
>>> > and
>>> > > > use.
>>> > > > > then I would say the impact is low
>>> > > > >
>>> > > >
>>> > > > I disagree, since people using Crosswalk 

[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...

[infil00p]

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/270

CB-8976: Removing the auto-version for non-Crosswalk applications

Discussed this on the mailing list, going to try to not just toss this over 
the fence.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android 
remove_auto_version_code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #270


commit 71547c8368a9b9cd72ed152dfa42d76f2eaa7eef
Author: Joe Bowser 
Date:   2016-03-03T22:18:30Z

CB-8976: Removing the auto-version for non-Crosswalk applications




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding OS X platform guide to TOC

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/535#issuecomment-191959034
  
LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding OS X platform guide to TOC

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/535#issuecomment-191955381
  
I think you are missing some hyphens


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding OS X platform guide to TOC

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/535

Adding OS X platform guide to TOC



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-osx

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #535


commit aef9237fe74ee101bc6ba6b3b8c501733ecdd914
Author: Raghav Katyal 
Date:   2016-03-03T20:41:49Z

Adding OS X platform guide to TOC




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10632: Fixing jasmine tes...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/106

CB-10632: Fixing jasmine test contact removal

This is related to the flaky tests that have been failing in the 
android-win CI. As the jasmine tests execute, they create contacts and 
occasionally fail to remove them. When that happens, the created contacts will 
never be removed and all of the tests that depend on those contacts not 
existing will fail until someone manually deletes the contacts on the emulator. 
This PR does not fix the test flakiness issue, but does fix the issue of the 
tests being permanently broken by a single failure. It also makes it so that 
the removal failures will actually be reported by jasmine where they were not 
previously so that we can hopefully pinpoint the real issue and fix the flaky 
test in a later PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-10632

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 85a16a8bdb82098891dfe8e13996aebf44f72d77
Author: riknoll 
Date:   2016-03-03T20:13:29Z

CB-10632: Fixing jasmine test contact removal




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Globalization and Splashscreen plugins release

[Edna Y Morales]

Hi,

There are some fixes we are wanting to get released for
cordova-plugin-globalization and cordova-plugin-splashscreen. Any thoughts
on when we can do the next release for these?

Thanks,
Edna Morales

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-docs/pull/534

Documenting some missing prefs: WindowsStoreIdentityName, WindowsStor…

…eDisplayName, WindowsStorePublisherName, BackgroundColor, 
WindowsToastCapable

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-docs MissingConfigPrefs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #534


commit e8e153071e1ab8b63ccfcb7cd51ecc50aae3bf99
Author: Omar Mefire 
Date:   2016-03-03T20:10:52Z

Documenting some missing prefs: WindowsStoreIdentityName, 
WindowsStoreDisplayName, WindowsStorePublisherName, BackgroundColor, 
WindowsToastCapable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] CB-8976, CB-8453 and is there anyone building multiple APKs

[Joe Bowser]

OK, Last call on this.

I'm deleting a bunch of the code that's not related to Crosswalk.  That
said, it's going to make this obsolete:
https://software.intel.com/en-us/xdk/articles/android-and-crosswalk-cordova-version-code-issues

We're not going to do the stupid minSDK mapping anymore because it's
counter to the philosophy of the Cordova project, and it should have never
been done to begin with.  However, we're keeping the modification to the
version codes if you're using Crosswalk.

So, if you're releasing without crosswalk, and you set your version code to
1, here's what's going to happen:
android-release.apk = Version Code 1

If you're releasing WITH CROSSWALK, here's what's going to happen:
android-armv7-release.apk = Version Code 12
android-x86-release.apk = Version Code 14

If you add Crosswalk to a project somewhere along the line, know that
you're going to have to multiply your version code by 10.  I hope this
doesn't go past maxInt, but it's the only way I can think of to give
developers back the control they lost with the earlier version code issues.

If this breaks your stuff, or causes you to have a massive problem (i.e.
You're at version 12, and you somehow have a collision with your Crosswalk
version because you didn't set your sdk version), please let me know now.

On Wed, Mar 2, 2016 at 2:39 PM, Joe Bowser  wrote:

>
>
> On Wed, Mar 2, 2016 at 2:34 PM, Carlos Santana 
> wrote:
>
>> What do you mean by a manual step to set the architecture?
>>
>> meaning that "cordova build" will build one apk by default
>>
>>
> Yes, right now if I set the version code to 1 and do a crosswalk build, I
> would get the following version codes and APKs:
> android-armv6-release.apk - Version Code 12
> android-x86-release.apk - Version Code 14
>
>
>> But if they want a specific architecture or multiple built they can do via
>> extra argument to "cordova build"
>>
>> Like cordova build -- --x86 --arm
>>
>>
> I don't think we should do multiple at all.  I think we should build just
> one.
>
> So, if you do this cordova build release --arch=arm
>
> You get only
>
> android-armv6-release.apk - Version Code 1
>
> And then to get the other one you have change the version code to 2 and do
> this:
>
> cordova build release --arch=x86
>
> android-x86-release.apk - Version Code 2
>
>
>
>> This is similar for windows platform where user control targets and build
>> via extra flags to build command, or not even related?
>>
>>
> Yes, this issue is open because we're copying how Windows does things.  I
> don't know why we're doing a multiple APK build, except that Crosswalk is
> an Intel thing, maybe?
>
>
>>
>>
>>
>> On Wed, Mar 2, 2016 at 5:17 PM Joe Bowser  wrote:
>>
>> > On Wed, Mar 2, 2016 at 2:02 PM, Carlos Santana 
>> > wrote:
>> >
>> > > Avoiding a large APK is kind of a good feature to have, to build small
>> > apk
>> > > targeted to specific architecture.
>> > >
>> > > What's your proposal ? Maybe I missed it
>> > >
>> > >
>> > Step 1. Remove the code that changes version codes but has nothing to do
>> > with architecture and get users to specify the Android Version Code in
>> the
>> > config.xml like so:
>> > > > xmlns="http://www.w3.org/ns/widgets; xmlns:cdv="
>> > http://cordova.apache.org/ns/1.0;>
>> >
>> >
>> > > You said to remove multiple apk generation or have multiple apk
>> > generation
>> > > being don in a different way to handle the versionCode per
>> architecture?
>> > >
>> > >
>> > Yeah, for the short term, I think multiplying by 10, and reserving the
>> last
>> > spot to denote x86 or arm isn't an awful solution, but it's far from
>> > ideal.  If we can turn off multiple APK generation and add the ability
>> to
>> > set an architecture, then this would turn into a manual step for the
>> > developer to take advantage of, and they can decide if version 11 is arm
>> > and version 12 is x86, but I'm not sure if developers are able to handle
>> > that or want it abstracted, which is why I'm asking.
>> >
>> >
>> > >
>> > > On Wed, Mar 2, 2016 at 4:41 PM Joe Bowser  wrote:
>> > >
>> > > > On Wed, Mar 2, 2016 at 1:26 PM, Carlos Santana <
>> csantan...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > If it's not well documented how this multiple APKs suppose to work
>> > and
>> > > > use.
>> > > > > then I would say the impact is low
>> > > > >
>> > > >
>> > > > I disagree, since people using Crosswalk are expecting that
>> behaviour
>> > by
>> > > > default right now.  We don't have to built multiple APKs with
>> Crosswalk
>> > > > but bundling both the X86 and the ARM libraries makes the APK 48 MB.
>> > > >
>> > > >
>> > > > > If it's not part of the build.json in --buildConfig spec [1]  then
>> > also
>> > > > low
>> > > > > impact.
>> > > > >
>> > > > >
>> > > > I would agree if build.json was universally adopted as the way to do
>> > > > things, and there wasn't multiple ways people were building
>> 

[GitHub] cordova-android pull request: CB-10710 Respect plugman's www optio...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-android/pull/267#issuecomment-191943555
  
Okay, those steps passed for me on OS X.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-191936337
  
@TimBarham updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r54933484
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project. The cordovaDependencies object in the package.json's 
engines
+ * entry takes the form of an object that maps plugin versions to a series 
of
+ * constraints and semver ranges. For example:
+ *
+ * { plugin-version: { constraint: semver-range, ...}, ...}
+ *
+ * Constraint can be a plugin, platform, or cordova version. Plugin-version
+ * can be either a single version (e.g. 3.0.0) or an upper bound (e.g. 
<3.0.0)
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+pluginList.forEach(function(plugin) {
+pluginMap[plugin.id] = plugin.version;
+});
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+events.emit('verbose', 'No plugin engine info found or not using 
registry, falling back to latest or pinned version');
+return Q(null);
+}
+}
+
+function findVersion(versions, version) {
+var cleanedVersion = semver.clean(version);
+for(var i = 0; i < versions.length; i++) {
+if(semver.clean(versions[i]) === cleanedVersion) {
+return versions[i];
+}
+}
+return null;
+}
+
+/*
+ * The engine entry maps plugin versions to constraints like so:
+ *  {
+ *  '1.0.0' : { 'cordova': '<5.0.0' },
+ *  '<2.0.0': {
+ *  'cordova': '>=5.0.0',
+ *  'cordova-ios': '~5.0.0',
+ *  'cordova-plugin-camera': '~5.0.0'
+ *  },
+ *  '3.0.0' : { 'cordova-ios': '>5.0.0' }
+ *  }
+ *
+ * See cordova-spec/plugin_fetch.spec.js for test cases and examples
+ */
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+// Filters out pre-release versions
+var latest = semver.maxSatisfying(allVersions, '>=0.0.0');
+
+var versions = [];
+var upperBound = null;
+var upperBoundRange = null;
+
+for(var version in engine) {
+if(semver.valid(semver.clean(version)) && !semver.gt(version, 
latest)) {
+versions.push(version);
+} else {
+// Check if this is an upperbound; validRange() handles 
whitespace
+var cleanedRange = semver.validRange(version);
+if(cleanedRange && UPPER_BOUND_REGEX.exec(cleanedRange)) {
+// We only care about the highest upper bound that our 
project does not support
+if(getFailedRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion).length !== 0) {
+var maxMatchingUpperBound = cleanedRange.substring(1);
+if (maxMatchingUpperBound && (!upperBound || 
semver.gt(maxMatchingUpperBound, upperBound))) {
+upperBound = maxMatchingUpperBound;
+upperBoundRange = version;
+}
+}
+}
+}
+}
+
--- End diff --

The way I envisioned it, the following cases are semantically the same:

```
cordovaDependencies: 

[GitHub] cordova-docs pull request: CB-10762: Fix the link in Icons page

[sarangan12]

Github user sarangan12 closed the pull request at:

https://github.com/apache/cordova-docs/pull/533


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

[gaelenh]

Github user gaelenh commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191897320
  
Based on @ghenry22's comment, I took a different approach to fixing the 
bug.  I changed the url validation to happen earlier (in create) so that the 
audioFile.resourceURL pointed to the proper location of a resource.  I then 
switched create to use the resourceURL from the audioFile object rather than 
the one passed into the method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cannot add/find cordova-ios 4.1.0

[Alexis Kofman]

Yep I meant android@5.1.1, sorry for the mistake.
Deleting the cache ~/.cordova/lib/npm_cache works for me ! Thx.

On Thu, Mar 3, 2016 at 6:57 PM, Carlos Santana  wrote:

> Like I said it depends of the cache timeout
>
> I also used latest and I got 4.0.1 not 4.1.0, because the .cache.json
> lastest=4.0.1 and already had it in downloaded in the cache.
>
>
> On Thu, Mar 3, 2016 at 12:44 PM julio cesar sanchez <
> jcesarmob...@gmail.com>
> wrote:
>
> > I got 4.1.0 using @latest
> >
> > 2016-03-03 18:22 GMT+01:00 Carlos Santana :
> >
> > > Filed a bug [1]
> > >
> > > Take into account that in future we will be using external npm in
> Cordova
> > > CLI, and not have our own copy of the npm cache.
> > >
> > > https://issues.apache.org/jira/browse/CB-10770
> > >
> > >
> > > I guess for now we can wait 24 hours, before tweeting/blog until bug is
> > > fix.
> > >
> > >
> > >
> > > On Thu, Mar 3, 2016 at 12:06 PM Carlos Santana 
> > > wrote:
> > >
> > > > I took a quick look, I have a guess on what's going on
> > > >
> > > > People should just wait 24 hours and try again, or use platform add
> by
> > > > path or git
> > > > Or delete the cache ~/.cordova/lib/npm_cache
> > > >
> > > > We configure the npm cache config [1] with cache-min = 3600 *24,
> > meaning
> > > > 24 hours
> > > > if .cache.json [2] is not older than 24 hours npm will not try the
> > > network
> > > >
> > > > Also I think there is bug since there is no catch/fail when calling
> npm
> > > > cache add
> > > >
> > > > [1]:
> > > >
> > >
> >
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L153
> > > > [2]: ~/.cordova/lib/npm_cache/
> > registry.npmjs.org/cordova-ios/.cache.json
> > > > [3]:
> > > >
> > >
> >
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L158
> > > >
> > > >
> > > > On Thu, Mar 3, 2016 at 11:32 AM So, Byoungro 
> > > > wrote:
> > > >
> > > >> Alexis,
> > > >> ios@5.1.1 does not exist.
> > > >> You can find the available versions here.
> > > >> https://github.com/apache/cordova-ios/releases
> > > >> If you need the latest Android version, do the following:
> > > >> cordova platform add android@5.1.1
> > > >>
> > > >> Zarko,
> > > >> I have no issue with adding ios@4.1.0.
> > > >> You may want to check your connection and proxy configuration.
> > > >> NPM registry could be down temporarily.
> > > >>
> > > >> Byoungro So
> > > >> SSG / DPD / Mobile Computing and Compilers
> > > >> Intel Corporation
> > > >>
> > > >> From: "Pridham, Marcus"  > >> marcus.prid...@sap.com>>
> > > >> Reply-To: "dev@cordova.apache.org" <
> > > >> dev@cordova.apache.org>
> > > >> Date: Thursday, March 3, 2016 at 7:19 AM
> > > >> To: "dev@cordova.apache.org" <
> > > >> dev@cordova.apache.org>
> > > >> Subject: Re: Cannot add/find cordova-ios 4.1.0
> > > >>
> > > >> Deleting the ~/.cordova folder fixes the issue for me.
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> On 3/3/16, 4:56 AM, "Alexis Kofman"   > > >> alexis.kof...@gmail.com>> wrote:
> > > >>
> > > >> Hello guys !
> > > >>
> > > >> Same here with the last Android version :
> > > >>
> > > >> $ cordova platform add ios@5.1.1
> > > >> Error: Failed to fetch platform ios@5.1.1
> > > >> Probably this is either a connection problem, or platform spec is
> > > >> incorrect.
> > > >> Check your connection and platform name/version/URL.
> > > >> Error: version not found: cordova-ios@5.1.1 cordova-ios@5.1.1>
> > > >>
> > > >>
> > > >>
> > > >> On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski  > > >> > wrote:
> > > >>
> > > >> Using cordova 6.0.0
> > > >>
> > > >> cordova create test_ios && cd test_ios && cordova platform add
> > ios@4.1.0
> > > >> 
> > > >>
> > > >> yields
> > > >>
> > > >> Creating a new cordova project.
> > > >> Error: Failed to fetch platform ios@4.1.0
> > > >> Probably this is either a connection problem, or platform spec is
> > > >> incorrect.
> > > >> Check your connection and platform name/version/URL.
> > > >> Error: version not found: cordova-ios@4.1.0 cordova-ios@4.1.0>
> > > >>
> > > >>
> > > >> I thought cordova-ios 4.1.0 was released!?
> > > >>
> > > >> https://www.npmjs.com/package/cordova-ios
> > > >>
> > > >>
> > > >>
> -
> > > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > >> dev-unsubscr...@cordova.apache.org>
> > > >> For additional commands, e-mail: dev-h...@cordova.apache.org
>  > > >> dev-h...@cordova.apache.org>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> Alexis Kofman
> > > >>
> > > >>
> > > >>
> 

[GitHub] cordova-docs pull request: CB-10762: Fix the link in Icons page

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/533#issuecomment-191894632
  
This has already been merged by Nikhil's PR. Please close this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information pull request: CB-10763: Remove ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-network-information/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10764: Remove emoji i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/89


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10414: Adding focus handler...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/188


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding blog post for docs improvement

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/527


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10414: Adding focus handler...

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/188#issuecomment-191889805
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10764: Remove emoji i...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/89#issuecomment-191889175
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information pull request: CB-10763: Remove ...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/39#issuecomment-191888986
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cannot add/find cordova-ios 4.1.0

[Carlos Santana]

Like I said it depends of the cache timeout

I also used latest and I got 4.0.1 not 4.1.0, because the .cache.json
lastest=4.0.1 and already had it in downloaded in the cache.


On Thu, Mar 3, 2016 at 12:44 PM julio cesar sanchez 
wrote:

> I got 4.1.0 using @latest
>
> 2016-03-03 18:22 GMT+01:00 Carlos Santana :
>
> > Filed a bug [1]
> >
> > Take into account that in future we will be using external npm in Cordova
> > CLI, and not have our own copy of the npm cache.
> >
> > https://issues.apache.org/jira/browse/CB-10770
> >
> >
> > I guess for now we can wait 24 hours, before tweeting/blog until bug is
> > fix.
> >
> >
> >
> > On Thu, Mar 3, 2016 at 12:06 PM Carlos Santana 
> > wrote:
> >
> > > I took a quick look, I have a guess on what's going on
> > >
> > > People should just wait 24 hours and try again, or use platform add by
> > > path or git
> > > Or delete the cache ~/.cordova/lib/npm_cache
> > >
> > > We configure the npm cache config [1] with cache-min = 3600 *24,
> meaning
> > > 24 hours
> > > if .cache.json [2] is not older than 24 hours npm will not try the
> > network
> > >
> > > Also I think there is bug since there is no catch/fail when calling npm
> > > cache add
> > >
> > > [1]:
> > >
> >
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L153
> > > [2]: ~/.cordova/lib/npm_cache/
> registry.npmjs.org/cordova-ios/.cache.json
> > > [3]:
> > >
> >
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L158
> > >
> > >
> > > On Thu, Mar 3, 2016 at 11:32 AM So, Byoungro 
> > > wrote:
> > >
> > >> Alexis,
> > >> ios@5.1.1 does not exist.
> > >> You can find the available versions here.
> > >> https://github.com/apache/cordova-ios/releases
> > >> If you need the latest Android version, do the following:
> > >> cordova platform add android@5.1.1
> > >>
> > >> Zarko,
> > >> I have no issue with adding ios@4.1.0.
> > >> You may want to check your connection and proxy configuration.
> > >> NPM registry could be down temporarily.
> > >>
> > >> Byoungro So
> > >> SSG / DPD / Mobile Computing and Compilers
> > >> Intel Corporation
> > >>
> > >> From: "Pridham, Marcus"  >> marcus.prid...@sap.com>>
> > >> Reply-To: "dev@cordova.apache.org" <
> > >> dev@cordova.apache.org>
> > >> Date: Thursday, March 3, 2016 at 7:19 AM
> > >> To: "dev@cordova.apache.org" <
> > >> dev@cordova.apache.org>
> > >> Subject: Re: Cannot add/find cordova-ios 4.1.0
> > >>
> > >> Deleting the ~/.cordova folder fixes the issue for me.
> > >>
> > >>
> > >>
> > >>
> > >> On 3/3/16, 4:56 AM, "Alexis Kofman"  >> alexis.kof...@gmail.com>> wrote:
> > >>
> > >> Hello guys !
> > >>
> > >> Same here with the last Android version :
> > >>
> > >> $ cordova platform add ios@5.1.1
> > >> Error: Failed to fetch platform ios@5.1.1
> > >> Probably this is either a connection problem, or platform spec is
> > >> incorrect.
> > >> Check your connection and platform name/version/URL.
> > >> Error: version not found: cordova-ios@5.1.1
> > >>
> > >>
> > >>
> > >> On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski  > >> > wrote:
> > >>
> > >> Using cordova 6.0.0
> > >>
> > >> cordova create test_ios && cd test_ios && cordova platform add
> ios@4.1.0
> > >> 
> > >>
> > >> yields
> > >>
> > >> Creating a new cordova project.
> > >> Error: Failed to fetch platform ios@4.1.0
> > >> Probably this is either a connection problem, or platform spec is
> > >> incorrect.
> > >> Check your connection and platform name/version/URL.
> > >> Error: version not found: cordova-ios@4.1.0
> > >>
> > >>
> > >> I thought cordova-ios 4.1.0 was released!?
> > >>
> > >> https://www.npmjs.com/package/cordova-ios
> > >>
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> dev-unsubscr...@cordova.apache.org>
> > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> dev-h...@cordova.apache.org>
> > >>
> > >>
> > >>
> > >>
> > >> --
> > >> Alexis Kofman
> > >>
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >> For additional commands, e-mail: dev-h...@cordova.apache.org
> > >>
> > >
> >
>

Re: Cannot add/find cordova-ios 4.1.0

[julio cesar sanchez]

I got 4.1.0 using @latest

2016-03-03 18:22 GMT+01:00 Carlos Santana :

> Filed a bug [1]
>
> Take into account that in future we will be using external npm in Cordova
> CLI, and not have our own copy of the npm cache.
>
> https://issues.apache.org/jira/browse/CB-10770
>
>
> I guess for now we can wait 24 hours, before tweeting/blog until bug is
> fix.
>
>
>
> On Thu, Mar 3, 2016 at 12:06 PM Carlos Santana 
> wrote:
>
> > I took a quick look, I have a guess on what's going on
> >
> > People should just wait 24 hours and try again, or use platform add by
> > path or git
> > Or delete the cache ~/.cordova/lib/npm_cache
> >
> > We configure the npm cache config [1] with cache-min = 3600 *24, meaning
> > 24 hours
> > if .cache.json [2] is not older than 24 hours npm will not try the
> network
> >
> > Also I think there is bug since there is no catch/fail when calling npm
> > cache add
> >
> > [1]:
> >
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L153
> > [2]: ~/.cordova/lib/npm_cache/registry.npmjs.org/cordova-ios/.cache.json
> > [3]:
> >
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L158
> >
> >
> > On Thu, Mar 3, 2016 at 11:32 AM So, Byoungro 
> > wrote:
> >
> >> Alexis,
> >> ios@5.1.1 does not exist.
> >> You can find the available versions here.
> >> https://github.com/apache/cordova-ios/releases
> >> If you need the latest Android version, do the following:
> >> cordova platform add android@5.1.1
> >>
> >> Zarko,
> >> I have no issue with adding ios@4.1.0.
> >> You may want to check your connection and proxy configuration.
> >> NPM registry could be down temporarily.
> >>
> >> Byoungro So
> >> SSG / DPD / Mobile Computing and Compilers
> >> Intel Corporation
> >>
> >> From: "Pridham, Marcus" > marcus.prid...@sap.com>>
> >> Reply-To: "dev@cordova.apache.org" <
> >> dev@cordova.apache.org>
> >> Date: Thursday, March 3, 2016 at 7:19 AM
> >> To: "dev@cordova.apache.org" <
> >> dev@cordova.apache.org>
> >> Subject: Re: Cannot add/find cordova-ios 4.1.0
> >>
> >> Deleting the ~/.cordova folder fixes the issue for me.
> >>
> >>
> >>
> >>
> >> On 3/3/16, 4:56 AM, "Alexis Kofman" > alexis.kof...@gmail.com>> wrote:
> >>
> >> Hello guys !
> >>
> >> Same here with the last Android version :
> >>
> >> $ cordova platform add ios@5.1.1
> >> Error: Failed to fetch platform ios@5.1.1
> >> Probably this is either a connection problem, or platform spec is
> >> incorrect.
> >> Check your connection and platform name/version/URL.
> >> Error: version not found: cordova-ios@5.1.1
> >>
> >>
> >>
> >> On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski  >> > wrote:
> >>
> >> Using cordova 6.0.0
> >>
> >> cordova create test_ios && cd test_ios && cordova platform add ios@4.1.0
> >> 
> >>
> >> yields
> >>
> >> Creating a new cordova project.
> >> Error: Failed to fetch platform ios@4.1.0
> >> Probably this is either a connection problem, or platform spec is
> >> incorrect.
> >> Check your connection and platform name/version/URL.
> >> Error: version not found: cordova-ios@4.1.0
> >>
> >>
> >> I thought cordova-ios 4.1.0 was released!?
> >>
> >> https://www.npmjs.com/package/cordova-ios
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> dev-unsubscr...@cordova.apache.org>
> >> For additional commands, e-mail: dev-h...@cordova.apache.org >> dev-h...@cordova.apache.org>
> >>
> >>
> >>
> >>
> >> --
> >> Alexis Kofman
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >
>

Re: Cannot add/find cordova-ios 4.1.0

[Carlos Santana]

Filed a bug [1]

Take into account that in future we will be using external npm in Cordova
CLI, and not have our own copy of the npm cache.

https://issues.apache.org/jira/browse/CB-10770


I guess for now we can wait 24 hours, before tweeting/blog until bug is fix.



On Thu, Mar 3, 2016 at 12:06 PM Carlos Santana  wrote:

> I took a quick look, I have a guess on what's going on
>
> People should just wait 24 hours and try again, or use platform add by
> path or git
> Or delete the cache ~/.cordova/lib/npm_cache
>
> We configure the npm cache config [1] with cache-min = 3600 *24, meaning
> 24 hours
> if .cache.json [2] is not older than 24 hours npm will not try the network
>
> Also I think there is bug since there is no catch/fail when calling npm
> cache add
>
> [1]:
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L153
> [2]: ~/.cordova/lib/npm_cache/registry.npmjs.org/cordova-ios/.cache.json
> [3]:
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L158
>
>
> On Thu, Mar 3, 2016 at 11:32 AM So, Byoungro 
> wrote:
>
>> Alexis,
>> ios@5.1.1 does not exist.
>> You can find the available versions here.
>> https://github.com/apache/cordova-ios/releases
>> If you need the latest Android version, do the following:
>> cordova platform add android@5.1.1
>>
>> Zarko,
>> I have no issue with adding ios@4.1.0.
>> You may want to check your connection and proxy configuration.
>> NPM registry could be down temporarily.
>>
>> Byoungro So
>> SSG / DPD / Mobile Computing and Compilers
>> Intel Corporation
>>
>> From: "Pridham, Marcus"  marcus.prid...@sap.com>>
>> Reply-To: "dev@cordova.apache.org" <
>> dev@cordova.apache.org>
>> Date: Thursday, March 3, 2016 at 7:19 AM
>> To: "dev@cordova.apache.org" <
>> dev@cordova.apache.org>
>> Subject: Re: Cannot add/find cordova-ios 4.1.0
>>
>> Deleting the ~/.cordova folder fixes the issue for me.
>>
>>
>>
>>
>> On 3/3/16, 4:56 AM, "Alexis Kofman"  alexis.kof...@gmail.com>> wrote:
>>
>> Hello guys !
>>
>> Same here with the last Android version :
>>
>> $ cordova platform add ios@5.1.1
>> Error: Failed to fetch platform ios@5.1.1
>> Probably this is either a connection problem, or platform spec is
>> incorrect.
>> Check your connection and platform name/version/URL.
>> Error: version not found: cordova-ios@5.1.1
>>
>>
>>
>> On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski > > wrote:
>>
>> Using cordova 6.0.0
>>
>> cordova create test_ios && cd test_ios && cordova platform add ios@4.1.0
>> 
>>
>> yields
>>
>> Creating a new cordova project.
>> Error: Failed to fetch platform ios@4.1.0
>> Probably this is either a connection problem, or platform spec is
>> incorrect.
>> Check your connection and platform name/version/URL.
>> Error: version not found: cordova-ios@4.1.0
>>
>>
>> I thought cordova-ios 4.1.0 was released!?
>>
>> https://www.npmjs.com/package/cordova-ios
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org> dev-unsubscr...@cordova.apache.org>
>> For additional commands, e-mail: dev-h...@cordova.apache.org> dev-h...@cordova.apache.org>
>>
>>
>>
>>
>> --
>> Alexis Kofman
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>

Re: Cannot add/find cordova-ios 4.1.0

[Carlos Santana]

I took a quick look, I have a guess on what's going on

People should just wait 24 hours and try again, or use platform add by path
or git
Or delete the cache ~/.cordova/lib/npm_cache

We configure the npm cache config [1] with cache-min = 3600 *24, meaning 24
hours
if .cache.json [2] is not older than 24 hours npm will not try the network

Also I think there is bug since there is no catch/fail when calling npm
cache add

[1]:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L153
[2]: ~/.cordova/lib/npm_cache/registry.npmjs.org/cordova-ios/.cache.json
[3]:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L158


On Thu, Mar 3, 2016 at 11:32 AM So, Byoungro  wrote:

> Alexis,
> ios@5.1.1 does not exist.
> You can find the available versions here.
> https://github.com/apache/cordova-ios/releases
> If you need the latest Android version, do the following:
> cordova platform add android@5.1.1
>
> Zarko,
> I have no issue with adding ios@4.1.0.
> You may want to check your connection and proxy configuration.
> NPM registry could be down temporarily.
>
> Byoungro So
> SSG / DPD / Mobile Computing and Compilers
> Intel Corporation
>
> From: "Pridham, Marcus" >
> Reply-To: "dev@cordova.apache.org" <
> dev@cordova.apache.org>
> Date: Thursday, March 3, 2016 at 7:19 AM
> To: "dev@cordova.apache.org" <
> dev@cordova.apache.org>
> Subject: Re: Cannot add/find cordova-ios 4.1.0
>
> Deleting the ~/.cordova folder fixes the issue for me.
>
>
>
>
> On 3/3/16, 4:56 AM, "Alexis Kofman" > wrote:
>
> Hello guys !
>
> Same here with the last Android version :
>
> $ cordova platform add ios@5.1.1
> Error: Failed to fetch platform ios@5.1.1
> Probably this is either a connection problem, or platform spec is
> incorrect.
> Check your connection and platform name/version/URL.
> Error: version not found: cordova-ios@5.1.1
>
>
>
> On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski  > wrote:
>
> Using cordova 6.0.0
>
> cordova create test_ios && cd test_ios && cordova platform add ios@4.1.0
> 
>
> yields
>
> Creating a new cordova project.
> Error: Failed to fetch platform ios@4.1.0
> Probably this is either a connection problem, or platform spec is
> incorrect.
> Check your connection and platform name/version/URL.
> Error: version not found: cordova-ios@4.1.0
>
>
> I thought cordova-ios 4.1.0 was released!?
>
> https://www.npmjs.com/package/cordova-ios
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org dev-unsubscr...@cordova.apache.org>
> For additional commands, e-mail: dev-h...@cordova.apache.org dev-h...@cordova.apache.org>
>
>
>
>
> --
> Alexis Kofman
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

Re: Cannot add/find cordova-ios 4.1.0

[So, Byoungro]

Alexis,
ios@5.1.1 does not exist.
You can find the available versions 
here.https://github.com/apache/cordova-ios/releases
If you need the latest Android version, do the following:
cordova platform add android@5.1.1

Zarko,
I have no issue with adding ios@4.1.0.
You may want to check your connection and proxy configuration.
NPM registry could be down temporarily.

Byoungro So
SSG / DPD / Mobile Computing and Compilers
Intel Corporation

From: "Pridham, Marcus" >
Reply-To: "dev@cordova.apache.org" 
>
Date: Thursday, March 3, 2016 at 7:19 AM
To: "dev@cordova.apache.org" 
>
Subject: Re: Cannot add/find cordova-ios 4.1.0

Deleting the ~/.cordova folder fixes the issue for me.




On 3/3/16, 4:56 AM, "Alexis Kofman" 
> wrote:

Hello guys !

Same here with the last Android version :

$ cordova platform add ios@5.1.1
Error: Failed to fetch platform ios@5.1.1
Probably this is either a connection problem, or platform spec is incorrect.
Check your connection and platform name/version/URL.
Error: version not found: cordova-ios@5.1.1



On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski 
> wrote:

Using cordova 6.0.0

cordova create test_ios && cd test_ios && cordova platform add 
ios@4.1.0

yields

Creating a new cordova project.
Error: Failed to fetch platform ios@4.1.0
Probably this is either a connection problem, or platform spec is
incorrect.
Check your connection and platform name/version/URL.
Error: version not found: cordova-ios@4.1.0


I thought cordova-ios 4.1.0 was released!?

https://www.npmjs.com/package/cordova-ios


-
To unsubscribe, e-mail: 
dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: 
dev-h...@cordova.apache.org




--
Alexis Kofman


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Personal Introduction: Jerroyd Moore

[Homer, Tony]

Hi Jerroyd :)

>>an extensive board game collection and more Steam games than I have time to 
>>play
Nice, I had no idea!
I haven't been playing much lately, but my most recent plays are Code 777, 
Patchwork, King of Tokyo and Machi Koro.
On Steam, my most recent plays are Slime Rancher and Crypt of the NecroDancer.

All pretty hardcore stuff, amirite?  ;)
Not Steam, but I'm looking forward to picking up Twilight Princess HD for WiiU 
tomorrow!

Tony

On 3/3/16, 1:41 AM, "Steven Gill"  wrote:

>Welcome Jerroyd!
>
>Make sure to join us on slack! Sign up at slack.cordova.io.
>
>Let us know if you have any question!
>
>-Steve
>
>On Wed, Mar 2, 2016 at 9:53 PM, Nikhil Khandelwal 
>wrote:
>
>> Welcome! Looking forward to your contributions!
>>
>> -Nikhil
>>
>> -Original Message-
>> From: So, Byoungro [mailto:byoungro...@intel.com]
>> Sent: Wednesday, March 2, 2016 8:16 PM
>> To: dev@cordova.apache.org
>> Subject: Re: Personal Introduction: Jerroyd Moore
>>
>> Welcome on board, Jerroyd.
>>
>> Byoungro So
>> SSG / DPD / Mobile Computing and Compilers Intel Corporation
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On 3/2/16, 2:03 PM, "Carlos Santana"  wrote:
>>
>> >Welcome Jerroyd !
>> >
>> >
>> >On Wed, Mar 2, 2016 at 4:56 PM Jerroyd Moore 
>> wrote:
>> >
>> >> Hello Apache Cordova!
>> >>
>> >> I am a member of the HTML5 Tools Team at Intel. My main
>> >> responsibilities include managing the backend build system, including
>> >> the tools that build cordova applications for windows platforms. I
>> >> used to dabble in HTML5 apps, but am moving away from user
>> >> application development and more into a devops role.
>> >>
>> >> I live and work in San Francisco, CA. When I'm not working, I spend
>> >> my time snowboarding, camping, watching broadway performances. I also
>> >> have an extensive board game collection and more Steam games than I
>> >> have time to play.
>> >>
>> >> Nice to meet you!
>> >> --Jerroyd
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>

Re: Cannot add/find cordova-ios 4.1.0

[Pridham, Marcus]

Deleting the ~/.cordova folder fixes the issue for me.




On 3/3/16, 4:56 AM, "Alexis Kofman"  wrote:

>Hello guys !
>
>Same here with the last Android version :
>
>$ cordova platform add ios@5.1.1
>Error: Failed to fetch platform ios@5.1.1
>Probably this is either a connection problem, or platform spec is incorrect.
>Check your connection and platform name/version/URL.
>Error: version not found: cordova-ios@5.1.1
>
>
>
>On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski  wrote:
>
>> Using cordova 6.0.0
>>
>> cordova create test_ios && cd test_ios && cordova platform add ios@4.1.0
>>
>> yields
>>
>> Creating a new cordova project.
>> Error: Failed to fetch platform ios@4.1.0
>> Probably this is either a connection problem, or platform spec is
>> incorrect.
>> Check your connection and platform name/version/URL.
>> Error: version not found: cordova-ios@4.1.0
>>
>>
>> I thought cordova-ios 4.1.0 was released!?
>>
>> https://www.npmjs.com/package/cordova-ios
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>
>
>-- 
>Alexis Kofman

[GitHub] cordova-android pull request: CB-10768 Use cordova-common.superspa...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-android/pull/269

CB-10768 Use cordova-common.superspawn in GradleBuilder

[Jira issue](https://issues.apache.org/jira/browse/CB-10768)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10768

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #269


commit f9be9793b65dd69c142f6367a77b70268a64292d
Author: daserge 
Date:   2016-03-03T13:29:54Z

CB-10768 Use cordova-common.superspawn in GradleBuilder




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/268#issuecomment-191713646
  
@vladimir-kotikov, could you please take a look once more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10749 Use cordova-common.CordovaL...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-android/pull/268

CB-10749 Use cordova-common.CordovaLogger in cordova-android

[Jira issue](https://issues.apache.org/jira/browse/CB-10749)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10749

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #268


commit fc5e05549871241d66c2a037a3bec3083e007518
Author: daserge 
Date:   2016-03-01T13:58:44Z

CB-10749 Use cordova-common.CordovaLogger in cordova-android




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: properly uses the fileK...

[jayeshjain24]

Github user jayeshjain24 commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/15#issuecomment-191690622
  
I always get bytesent as 0. Any idea??

```Array ( [file] => Array ( [name] => cdv_photo_018.jpg [type] => 
image/jpg [tmp_name] => tmp/dadqweda [error] => 0 [size] => 0 )```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cannot add/find cordova-ios 4.1.0

[Alexis Kofman]

Hello guys !

Same here with the last Android version :

$ cordova platform add ios@5.1.1
Error: Failed to fetch platform ios@5.1.1
Probably this is either a connection problem, or platform spec is incorrect.
Check your connection and platform name/version/URL.
Error: version not found: cordova-ios@5.1.1



On Thu, Mar 3, 2016 at 10:45 AM, Zarko Hristovski  wrote:

> Using cordova 6.0.0
>
> cordova create test_ios && cd test_ios && cordova platform add ios@4.1.0
>
> yields
>
> Creating a new cordova project.
> Error: Failed to fetch platform ios@4.1.0
> Probably this is either a connection problem, or platform spec is
> incorrect.
> Check your connection and platform name/version/URL.
> Error: version not found: cordova-ios@4.1.0
>
>
> I thought cordova-ios 4.1.0 was released!?
>
> https://www.npmjs.com/package/cordova-ios
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


-- 
Alexis Kofman

Cannot add/find cordova-ios 4.1.0

[Zarko Hristovski]

Using cordova 6.0.0

cordova create test_ios && cd test_ios && cordova platform add ios@4.1.0

yields

Creating a new cordova project.
Error: Failed to fetch platform ios@4.1.0
Probably this is either a connection problem, or platform spec is 
incorrect.

Check your connection and platform name/version/URL.
Error: version not found: cordova-ios@4.1.0


I thought cordova-ios 4.1.0 was released!?

https://www.npmjs.com/package/cordova-ios


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/402#issuecomment-191657982
  
@bso-intel, LGTM apart from one comment. It also would be great if you add 
a test for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/402#discussion_r54849930
  
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -71,7 +71,8 @@ module.exports = function installPlugin(platform, 
project_dir, id, plugins_dir,
 project_dir = cordovaUtil.convertToRealPathSafe(project_dir);
 plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir);
 options = options || {};
-options.is_top_level = true;
+if (options.is_top_level === undefined)
--- End diff --

Maybe use `options.hasOwnProperty`? What if it's set to `null` for example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ...

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191648550
  
The avPlayer.play code is there for playing from remote sources as a 
stream, it will only be triggered if the source starts with http or https.

If the file is local an avPlayer object is not created and avaudioplayer is 
used through the audiofile object.  You can see the play statement for this 
being triggered in the follow code block underneath this change.

This change will break streaming playback from what I can see.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org