date:20160319

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/410#issuecomment-198858128
  
@mikaelkindborg thank you for submitting your app to the showcase! Sorry 
that it took us so long to address your PR. The Cordova developer community had 
a discussion that you can view [here][thread], and it was decided that the app 
showcase ought to be closed for submissions. Please however feel free to email 
dev@cordova.apache.org if you have any questions or concerns regarding this 
decision.

[thread]: http://markmail.org/message/xww4r34spb72h7r6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added Klipfolio to showcase apps

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/419#issuecomment-198858135
  
@elijahe thank you for submitting your app to the showcase! Sorry that it 
took us so long to address your PR. The Cordova developer community had a 
discussion that you can view [here][thread], and it was decided that the app 
showcase ought to be closed for submissions. Please however feel free to email 
dev@cordova.apache.org if you have any questions or concerns regarding this 
decision.

[thread]: http://markmail.org/message/xww4r34spb72h7r6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding DailyCost app to showcase

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/407#issuecomment-198858121
  
@guopengliang thank you for submitting your app to the showcase! Sorry that 
it took us so long to address your PR. The Cordova developer community had a 
discussion that you can view [here][thread], and it was decided that the app 
showcase ought to be closed for submissions. Please however feel free to email 
dev@cordova.apache.org if you have any questions or concerns regarding this 
decision.

[thread]: http://markmail.org/message/xww4r34spb72h7r6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Add Schweepes Connect to showcase

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/449#issuecomment-198858138
  
@RianHitori thank you for submitting your app to the showcase! Sorry that 
it took us so long to address your PR. The Cordova developer community had a 
discussion that you can view [here][thread], and it was decided that the app 
showcase ought to be closed for submissions. Please however feel free to email 
dev@cordova.apache.org if you have any questions or concerns regarding this 
decision.

[thread]: http://markmail.org/message/xww4r34spb72h7r6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding Justiça Facil to the showcase

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/403#issuecomment-198858117
  
@gagustavo thank you for submitting your app to the showcase! Sorry that it 
took us so long to address your PR. The Cordova developer community had a 
discussion that you can view [here][thread], and it was decided that the app 
showcase ought to be closed for submissions. Please however feel free to email 
dev@cordova.apache.org if you have any questions or concerns regarding this 
decision.

[thread]: http://markmail.org/message/xww4r34spb72h7r6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fix for CB-10822 : Plugin Media...

2016-03-19 Thread ThillaiganeshChan

GitHub user ThillaiganeshChan opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/87

Fix for CB-10822 : Plugin Media - "cordova-plugin-media" 2.2.0 seem hâ¦

â¦ave a "position" bug with mediaSound.getCurrentPosition method.

Added a Check for Recorder also in 'getCurrentPositionAudio'

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accenture/cordova-plugin-media 
CB-10822cordova-plugin-media

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit 4deef091a3fe55f20d929a103d71d4c1747e5ab3
Author: Thillaiganesh, C 
Date:   2016-03-18T10:24:53Z

Fix for CB-10822 : Plugin Media - "cordova-plugin-media" 2.2.0 seem have a 
"position" bug with mediaSound.getCurrentPosition method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56601156
  
--- Diff: src/android/FileUtils.java ---
@@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMis
 }
 }, lastRawArgs, callback);
 break;
-case WRITE_PERM:
+case PERM_DIR:
+threadhelper( new FileOp( ){
+public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
+String dirname = args.getString(0);
+
+String path = args.getString(1);
+JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), true);
+callback.success(obj);
+}
+}, lastRawArgs, callback);
+break;
+case WRITE_ACTION:
--- End diff --

Sorry, I meant that `WRITE` should be renamed to `WRITE_ACTION`, but 
`WRITE_PERM` can stay what it was before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

Github user shazron commented on the pull request:

https://github.com/apache/cordova-lib/pull/411#issuecomment-197555600
  
The truncated AppVeyor message says "AppVeyor was unable to build 
non-mergeable pull request", which is odd since there are no conflicts (as 
reported by Github)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10912: update ios-sim to 5.0.7 to fix...

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/208#issuecomment-198854215
  
I could reliably reproduce the "Invalid Device State" problem from here: 
https://github.com/phonegap/simctl/issues/9

and the fix resolves that problem (from starting the Simulator) in that 
test case. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10680 Expose isFirstAttempt API i...

2016-03-19 Thread infil00p

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/262#issuecomment-197461655
  
Can we get a test attached to this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Better syntax highlighting

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/560#issuecomment-198472751
  
Jira is [CB-10907](https://issues.apache.org/jira/browse/CB-10907)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update about easing of Apple IOS restri...

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/501#issuecomment-197477488
  
Thanks for the feedback, @shazron! @karandeepmalik please take a look at 
Shazron's comments when you have a moment. I don't know how to best reword the 
content, so I'll leave it to you. Also: sorry, we've reorganized the docs a bit 
since the PR was created. After you make any changes please move them to the 
`www/docs/en/dev/guide/platforms/ios/index.md` file. We now take "snapshots" of 
`/dev/` and copy it to `/6.x/`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: CI Build Status 03/14

2016-03-19 Thread Dmitry Blotsky

Good catch! Looks like a typo.

Kindly,
Dmitry

-Original Message-
From: Tobias Bocanegra [mailto:tri...@apache.org] 
Sent: Tuesday, March 15, 2016 6:59 PM
To: dev@cordova.apache.org
Subject: Re: CI Build Status 03/14

Hi,

'cordova-osx' is a bit misleading here. as the bug is for:
'cordova-android-osx'.

regards, toby

On Wed, Mar 16, 2016 at 12:14 AM, Raghav Katyal  wrote:
> Hi everyone!
>
> Here's the latest status for our continuous integration (CI) machinery, 
> broken down by builders:
>
> BuildersStatus
>  Issues
> Cordova-osx  Warning  
>Plugin Contact Tests failures (CB-10881) - 100%
> Cordova-android-win Warning   
>   Media Plugin Test Failures (CB-10740)  - 60%
> Cordova-ios   Warning 
> Flaky media tests (CB-10783) - 15%
> Cordova-windows-phone-8.1 Success
> Cordova-windows-store-8.1   Success   
>  Flaky file transfer tests failures (CB-10409) - 10%
>
> High priority issues:
>
>
>   *   CB-10881: Plugin contact tests failures on cordova-osx
>   *   CB-10783: Flaky media test failures on cordova-ios
>   *   CB-10409: Flaky file transfer test failures on cordova-windows-store-8.1
>
> As always, you can check out all of the issues found by the CI by querying 
> for the "found-by-ci" label in JIRA. Issues related to the CI or the plugin 
> tests themselves are marked as "Test" and those that are actual bugs are 
> marked as "Bug".
>
> -Raghav
>
>
>
> Sent from 
> Outlook

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

2016-03-19 Thread stevengill

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/411#issuecomment-197549676
  
LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10866: Adding engine ...

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-198467454
  
@stevengill that old engine info wasn't doing anything, right? I'm good to 
remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/273#issuecomment-197348065
  
@dpolivy, I've sent #276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

2016-03-19 Thread kostkobv

Github user kostkobv commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-197350848
  
@omefire I've used the last version of plugin with your changes merged 
within but it's still don't work - I'm still getting the same exception 
("AVPlayerItem cannot service a seek request with a completion handler until 
its status is AVPlayerItemStatusReadyToPlay.") which cause the app crash when 
I'm trying to play sound.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

2016-03-19 Thread sgrebnov

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197379532
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8582 Obscure INSTALL_FAILED_VERSI...

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-android/pull/278

CB-8582 Obscure INSTALL_FAILED_VERSION_DOWNGRADE error when installinâ¦

â¦g app

[Jira issue](https://issues.apache.org/jira/browse/CB-8582)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-8582

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit 93cb264fd8e7840c1f68551a6d0e6b7851e2cc72
Author: daserge 
Date:   2016-03-16T14:55:08Z

CB-8582 Obscure INSTALL_FAILED_VERSION_DOWNGRADE error when installing app




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197445134
  
@sgrebnov `fn.toString` is also a pretty nasty pattern. Adding buttons for 
manual tests is literally what manual tests are. We control both the tests and 
the UI. Why is that a bad thing? This is one of those cases where applying the 
DRY (Don't Repeat Yourself) principle doesn't make things much better and makes 
the code a lot harder to maintain. Just modify the test app. That way we can 
also test it manually without Appium.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197417802
  
One last small comment. LGTM otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [ALL PLATFORMS][cordova-common] Platform specific preferences overridden by global preferences

2016-03-19 Thread Shazron

Looks like both pull requests have been reviewed and given the thumbs
up. I'll pull them in soon.

On Wed, Mar 16, 2016 at 2:38 PM, Carlos Santana  wrote:
> changes are OK
>
> On Wed, Mar 16, 2016 at 5:05 PM Shazron  wrote:
>
>> Pull requests sent, with tests:
>>
>> 1. https://github.com/apache/cordova-lib/pull/411
>>
>> 2. https://github.com/apache/cordova-lib/pull/412
>>
>> On Wed, Mar 16, 2016 at 11:13 AM, Nikhil Khandelwal
>>  wrote:
>> > Thanks for the heads up. Good find! (1) sounds pretty bad - correct me
>> if I'm wrong, to fix this, we need to do the following:
>> > - fix it in cordova-common, release
>> > - bundle those changes to all platforms & release all of them.
>> >
>> > We need tests for this scenario also.
>> >
>> > Shaz: Are you planning to take all the tasks above? Some of us could
>> likely help.
>> >
>> > -Nikhil
>> >
>> > -Original Message-
>> > From: Shazron [mailto:shaz...@gmail.com]
>> > Sent: Wednesday, March 16, 2016 10:32 AM
>> > To: dev@cordova.apache.org
>> > Subject: [ALL PLATFORMS][cordova-common] Platform specific preferences
>> overridden by global preferences
>> >
>> > Some code changes I want to highlight that I want changing, in
>> cordova-common:
>> >
>> > 1.
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10694&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ynROJ1IjgLWqIcLk9AYH9%2fzlQTn%2fbVooUcyWk5iG12Q%3d
>> >
>> > Platform specific preferences are "overriden" by global preferences,
>> because when the merged config.xml file (root config.xml merge with
>> platform config.xml), the global preferences are written last always, so
>> they clobber any previous declaration. The change is to write platform
>> preferences last:
>> >
>> >
>> https://github.com/apache/cordova-lib/blob/a3285602b88f4e40f08c178b8b26c918c91d0dce/cordova-common/src/util/xml-helpers.js#L212-L217
>> >
>> > 2.
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9264&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uKrVMPdcY2zBnYiGrTASEoKAlGoanmcdd6ME0BIlPd4%3d
>> >
>> > This is not as critical as #1 above, since it's just a build artifact
>> thing.This is just to remove duplicate entries in the merged config.xml.
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>> >
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197407826
  
Sorry, I wasn't aware of the current process. Reapplied changes to `dev` 
version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-19 Thread sgrebnov

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197526519
  
@dblotsky  We don't have manual tests - we have buttons demonstrating api 
calls (for both api classes - with and without user interaction), there are no 
validation logic there.

There are two options how we can proceed IMO (i'm fine with both of them):
1. Made them as real tests (as you mentioned above so you can run them w/o 
appium). I actually support idea to be able to run tests manually if needed. 
Where do you think should be validation logic in this case (appium side or 
client app side)? Should we create separate button for each option/combination 
for Camera tests for example, or use switches/etc. Also manual api code writes  
results to divs/dom elements so we will have to bring extra complexity to tests 
to find/parse results from dom elements before validation.
2. Don't use those buttons at all (same reason why unit tests don't rely on 
calling buttons) - calling single cordova function from appium and getting 
callback result is simple. This may lead to more clean/readable code and tests 
definitions and simplify tests maintenance.

Agree regarding `fn.toString()`, but there is a special function for this - 
you can execute function in browser context from appium.
http://webdriver.io/api/protocol/execute.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10894 Add supports-screens config...

2016-03-19 Thread akofman

Github user akofman commented on the pull request:

https://github.com/apache/cordova-android/pull/280#issuecomment-198109318
  
I already have one, do you want me to send it to you by e-mail ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56600287
  
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException, 
IOException {
 else if (action.equals("getDirectory")) {
 threadhelper( new FileOp( ){
 public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
-String dirname=args.getString(0);
-String path=args.getString(1);
-JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), true);
-callbackContext.success(obj);
+String dirname = args.getString(0);
+String path = args.getString(1);
+String nativeURL = 
resolveLocalFileSystemURI(dirname).getString("nativeURL");
+boolean containsCreate = 
args.toString().contains("\"create\":true");
+
+if(containsCreate && needPermission(nativeURL, WRITE)) 
{
+getPermissionDir(WRITE);
+}
+else if(!containsCreate && needPermission(nativeURL, 
READ)) {
+getPermissionDir(READ);
+}
+else {
+JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), true);
+callbackContext.success(obj);
+}
 }
 }, rawArgs, callbackContext);
 }
 else if (action.equals("getFile")) {
 threadhelper( new FileOp( ){
 public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
-String dirname=args.getString(0);
-/*
- * If we don't have the package name in the path, 
we're reading and writing to places we need permission for
- */
-
if(dirname.contains(cordova.getActivity().getPackageName()) ||
-hasReadPermission()) {
-String path = args.getString(1);
-JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), false);
-callbackContext.success(obj);
+String dirname = args.getString(0);
+String path = args.getString(1);
+String nativeURL = 
resolveLocalFileSystemURI(dirname).getString("nativeURL");
+boolean containsCreate = 
args.toString().contains("\"create\":true");
+
+if(containsCreate && needPermission(nativeURL, WRITE)) 
{
+getPermissionFile(WRITE);
+}
+else if(!containsCreate && needPermission(nativeURL, 
READ)) {
+getPermissionFile(READ);
--- End diff --

This code is similar to the `WRITE` case, so it might be better to factor 
out them both into a function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/276#discussion_r56594805
  
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget, 
buildResults) {
 if (err) reject(new CordovaError('Error executing 
"' + command + '": ' + stderr));
 // adb does not return an error code even if 
installation fails. Instead it puts a specific
 // message to stdout, so we have to use RegExp 
matching to detect installation failure.
-else if (/Failure/.test(stdout)) reject(new 
CordovaError('Failed to install apk to emulator: ' + stdout));
-else resolve(stdout);
+else if (/Failure/.test(stdout)) {
+if 
(stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) {
+stdout += 'Sign the build using \'-- 
--keystore\' or \'--buildConfig\'' +
+' or sign and deploy the unsigned apk 
manually using Android tools.';
+}
+
+reject(new CordovaError('Failed to install apk 
to emulator: ' + stdout));
+} else resolve(stdout);
--- End diff --

Created a JIRA: https://issues.apache.org/jira/browse/CB-10903


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/159#discussion_r56635687
  
--- Diff: spec/unit/Prepare.Win10.spec.js ---
@@ -380,3 +383,79 @@ describe('A Windows 10 project should apply the uap: 
namespace prefix to certain
 expect(testResults.location).toBe('DeviceCapability');
 });
 });
+
+describe('copyIcons method', function () {
+var copyImages = prepare.__get__('copyImages');
+
+var PROJECT = '/some/path';
+
+function createMockConfig(images) {
+var result = jasmine.createSpyObj('config', ['getIcons', 
'getSplashScreens']);
+result.getIcons.andReturn(images);
+result.getSplashScreens.andReturn([]);
+
+return result;
+}
+
+beforeEach(function () {
+spyOn(shell, 'cp');
+});
+
+it('should guess target filename based on icon size', function () {
+var images = [
+{src: 'res/Windows/Square44x44Logo_100.png', width: '44', 
height: '44' },
+{src: 'res/Windows/Square44x44Logo_240.png', width: '106', 
height: '106' }
+];
+
+var config = createMockConfig(images);
+
+copyImages(config, PROJECT);
+
+expect(shell.cp).toHaveBeenCalledWith('-f', 
path.normalize('res/Windows/Square44x44Logo_100.png'), path.join(PROJECT, 
'images/Square44x44Logo.scale-100.png'));
+expect(shell.cp).toHaveBeenCalledWith('-f', 
path.normalize('res/Windows/Square44x44Logo_240.png'), path.join(PROJECT, 
'images/Square44x44Logo.scale-240.png'));
+});
+
+it('should ignore unknown icon sizes and emit a warning', function () {
+var config = createMockConfig([
+{src: 'res/Windows/UnknownImage.png', width: '999', height: 
'999' },
+]);
+
+var warnSpy = jasmine.createSpy('warn');
+events.on('warn', warnSpy);
+copyImages(config, PROJECT);
+expect(shell.cp).not.toHaveBeenCalled();
+expect(warnSpy.calls[0].args[0]).toMatch('image is skipped');
+});
+
+describe('when "target" attribute is specified for the image', 
function () {
+it('should copy all images with the same base name and extension 
to destination dir', function () {
+var matchingFiles = [
+'res/Windows/Square44x44.scale-100.png',
+'res/Windows/Square44x44.targetsize-16.png',
+'res/Windows/Square44x44.scale-150_targetsize-16.png',
+'res/Windows/Square44x44.targetsize-16_scale-200.png',
--- End diff --

From 
[doc](https://msdn.microsoft.com/en-us/library/windows/apps/hh965372.aspx) the 
syntax is:

> The dotted segment in the file just before the file extension is 
considered a token that indicates qualifiers. Multiple qualifiers are separated 
by an underscore, and qualifiers are traditionally specified with their name 
and value

It's not very clear what happens if the last segment doesn't match any 
qualifier or has some incorrect qualifier name/value, so i preferred not to 
perform any validation here.

Also i've just checked and it seems that MSBuild already does some basic 
validation and emits a warning in this case

```
e:\PROJECTS\Temp\foo
Î» cordova build windows
Building project: 
e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj
Configuration : debug
Platform  : anycpu
MakePRI : warning 0xdef00520: Invalid qualifier: DIMENSION-240 
[e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj]
MakePRI : warning 0xdef00520: Invalid qualifier: SCALE-FOO 
[e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj]
MakePRI : warning 0xdef00520: Invalid qualifier: SCALE-240_DIMENSION-FOO 
[e:\PROJECTS\Temp\foo\platforms\windows\CordovaApp.Windows.jsproj]
```

the build succeeds though, and the resultant package contains improperly 
named files, so i think we could rely on MSBuild here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] Cordova common 1.1.1 release

Please review and vote on this cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10911

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10911/

The packages were published from their corresponding git tags:
cordova-lib: common-1.1.1 (80b70040bb)

Upon a successful vote I will upload the archives to dist/, publish
them to NPM, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* linked with cordova-lib and cordova-cli and ran npm test.

Re: [DISCUSS] Tools Release

hmm, sounds like a reasonable solution. Right now we only reinstall plugins
saved in config.xml (which prepare does). But it makes sense to reinstall
all plugins installed.

Let me know when you have a PR.

On Wed, Mar 16, 2016 at 11:02 AM, Mefire O.  wrote:

> I'd like to propose we get in a fix for CB-10775 during this release:
> https://issues.apache.org/jira/browse/CB-10775
>
> It is breaking lots of people, and I have a fix that will solve this
> problem temporarily until we get the more permanent 'cordova platform rm,
> platform add' solution in.
>
> It involves making changes to cordova-lib, to reinstall plugins recorded
> in , after their deletion by the platform (cordova-ios).
>
> If we agree this should go in, I can have something working by end of day,
> today.
>
> Thanks,
> Omar Mefire
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Monday, March 14, 2016 6:00 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release
>
> Sounds good.
> I'm working on this [1] it should be done by then to pick it up
>
> [1]:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10808&data=01%7c01%7commenjik%40microsoft.com%7c0eb62e0d48e74f71ab8208d34c089010%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=AwCI%2f5sbxcxI0kpS%2fJI4D%2bvtdMBMfhexWW2EOCGrfhU%3d
>
>
> On Sun, Mar 13, 2016 at 6:09 PM Steven Gill 
> wrote:
>
> > I'm planning on starting a tools release on Wed. Let me know if you
> > need me to look at anything.
> >
> > -Steve
> >
>

Re: [DISCUSS] Tools Release

2016-03-19 Thread Mefire O .

PR: https://github.com/apache/cordova-lib/pull/413

Occasionally, there is this issue that crops up, looks like there's a race 
condition between the cordova-lib code and the cordova-ios code.
As a result, I will close this PR and we can proceed with the release.
Anyone else is welcome to carry out further investigations, if interested.

Sorry, everyone.

Thanks,
Omar Mefire

On Mar 17, 2016, at 12:36 PM, Mefire O. 
mailto:ommen...@microsoft.com>> wrote:

PR issued: https://github.com/apache/cordova-lib/pull/413


Thanks,
Omar Mefire

On Mar 16, 2016, at 12:45 PM, Steven Gill 
mailto:stevengil...@gmail.com>>
 wrote:

hmm, sounds like a reasonable solution. Right now we only reinstall plugins
saved in config.xml (which prepare does). But it makes sense to reinstall
all plugins installed.

Let me know when you have a PR.

On Wed, Mar 16, 2016 at 11:02 AM, Mefire O. 
mailto:ommen...@microsoft.com>>
 wrote:

I'd like to propose we get in a fix for CB-10775 during this release:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10775&data=01%7c01%7commenjik%40microsoft.com%7c946d776dac834e2e388d08d34dd3962f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0Mx2AXdn9TjMyV8h7CFnVsOkcqVCL2zr8ifWjdn%2fvo4%3d

It is breaking lots of people, and I have a fix that will solve this
problem temporarily until we get the more permanent 'cordova platform rm,
platform add' solution in.

It involves making changes to cordova-lib, to reinstall plugins recorded
in , after their deletion by the platform (cordova-ios).

If we agree this should go in, I can have something working by end of day,
today.

Thanks,
Omar Mefire

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Monday, March 14, 2016 6:00 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release

Sounds good.
I'm working on this [1] it should be done by then to pick it up

[1]:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10808&data=01%7c01%7commenjik%40microsoft.com%7c0eb62e0d48e74f71ab8208d34c089010%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=AwCI%2f5sbxcxI0kpS%2fJI4D%2bvtdMBMfhexWW2EOCGrfhU%3d


On Sun, Mar 13, 2016 at 6:09 PM Steven Gill 
wrote:

I'm planning on starting a tools release on Wed. Let me know if you
need me to look at anything.

-Steve

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-19 Thread stevengill

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/412#issuecomment-197550412
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/276#discussion_r56474441
  
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget, 
buildResults) {
 if (err) reject(new CordovaError('Error executing 
"' + command + '": ' + stderr));
 // adb does not return an error code even if 
installation fails. Instead it puts a specific
 // message to stdout, so we have to use RegExp 
matching to detect installation failure.
-else if (/Failure/.test(stdout)) reject(new 
CordovaError('Failed to install apk to emulator: ' + stdout));
-else resolve(stdout);
+else if (/Failure/.test(stdout)) {
+if 
(stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) {
+stdout += 'Sign the build using \'-- 
--keystore\' or \'--buildConfig\'' +
+' or sign and deploy the unsigned apk 
manually using Android tools.';
+}
+
+reject(new CordovaError('Failed to install apk 
to emulator: ' + stdout));
+} else resolve(stdout);
--- End diff --

That would be great, thanks - I don't have enough context unfortunately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: 5.1.x fullscreen no immersive

2016-03-19 Thread infil00p

Github user infil00p commented on the pull request:

https://github.com/apache/cordova-android/pull/271#issuecomment-197461335
  
Can you clean up this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

Github user vladimir-kotikov closed the pull request at:

https://github.com/apache/cordova-windows/pull/159


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios release

2016-03-19 Thread Edna Y Morales


Ok sounds good

Thanks,
Edna Morales



From:   Carlos Santana 
To: dev@cordova.apache.org
Date:   03/17/2016 04:48 PM
Subject:Re: [DISCUSS] cordova-ios release



I agree Steve

- Carlos
@csantanapr

> On Mar 17, 2016, at 4:17 PM, Steven Gill  wrote:
>
> Lets do a common release first and then follow that up with patch ios
> release
>
>> On Thu, Mar 17, 2016 at 11:24 AM, Shazron  wrote:
>>
>> I would say patch release. I had some items I wanted in the next
>> release (labeled cordova-ios-4.1.1), but that shouldn't hold up
>> releasing often, keep the train running...
>>
>> Ideally it should be accompanied with the patches I did yesterday for
>> cordova-common (since cordova-common is bundled in to cordova-ios),
>> but those bugs only really affect cordova-cli functionality
>>
>> On Thu, Mar 17, 2016 at 11:09 AM, Edna Y Morales 
>> wrote:
>>>
>>> Hi,
>>>
>>> We are interested in a cordova-ios release, specifically for this jira
>>> item: https://issues.apache.org/jira/browse/CB-10773
>>>
>>> Is there any opposition to this or any reason to wait? Steve would it
>> make
>>> sense to wait for a cordova-common release to happen first, before
doing
>>> the cordova-ios release?
>>>
>>> Would it be a patch release or a minor release?
>>>
>>> Thanks,
>>> Edna Morales
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request: fix(vibrateWithPattern): fu...

2016-03-19 Thread 5im0n

GitHub user 5im0n opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/45

fix(vibrateWithPattern): function doesn't update the pattern variableâ¦

I use constants in my application for my vibration pattern.

Each time I use the function `vibrateWithPattern` it add a zero to my 
constant.
That's why it's preferable do not update the parameter of the function.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/5im0n/cordova-plugin-vibration master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #45






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10894 Add supports-screens config...

Github user shazron commented on the pull request:

https://github.com/apache/cordova-android/pull/280#issuecomment-198114802
  
CLA verified for Alexis Kofman: http://people.apache.org/unlistedclas.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-lib/pull/411

CB-10694 - Platform-specific configuration preferences don't override 
global settings

Includes jasmine test.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-lib CB-10694

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/411.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #411


commit 11d1380537da46639c6dbbe8d32bcd3fa03e9ad8
Author: Shazron Abdullah 
Date:   2016-03-16T17:42:23Z

CB-10694 - Platform-specific configuration preferences don't override 
global settings

Includes jasmine test.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Does Cordova have a problem making developers happy?

I don't entirely agree with this, since usually we do respond.  We don't
just accept things that get thrown at us, which I think is the expectation.

I think we need to make sure we come to some resolution and actually solve
the problem in a timely manner.  We've had both extremes of discussing a
problem to death and cowboy coding, and neither extreme works well.

As for getting there, I have no idea.  Any thoughts?

On Fri, Mar 18, 2016, 2:23 PM Raghav Katyal  wrote:

> I guess responding to JIRA quickly and acting on contributors' PRs could
> be candidates for improvement.
>
> -Original Message-
> From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> Sent: Friday, March 18, 2016 11:18 AM
> To: dev@cordova.apache.org
> Subject: Re: Does Cordova have a problem making developers happy?
>
> I have been guilty of not spending too much time on stackoverflow
> answering questions. It’s on my TODO list. For those who have, what are
> there general themes of improvement here that will make a huge impact?
>
> I remember Julio summarized this last year [1] and I believe we have made
> progress on a lot of these – docs, PATH setup. Though the impact of our
> docs work is yet to be seen – we just did a big update in terms of
> organization [2]. There’s probably more to be done in terms of docs –
> tutorials, examples for plugin API usage, integration with other tools like
> gulp, browserify etc. What are other good candidates for improvement?
>
> I found it interesting that our own survey [3] in October had somewhat
> high Net promoter score (NPS).
>
> [1]
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail-archives.apache.org%2fmod_mbox%2fcordova-dev%2f201504.mbox%2f%253CetPan.552c9004.643c9869.b8b8%40Kerris-MacBook-Pro.local%253E&data=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=dPkMBS3I8mA7uqmezeLaxknf4ujYsmymcco50y9piYg%3d
> [2]
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordova.apache.org%2fannouncements%2f2016%2f03%2f03%2fdocs-improvement.html&data=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fYJCb131SFY%2bAA0RS2cxrDyf3m74EAHSGPuhd6oR7xo%3d
> [3]
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fapachecordovabot.typeform.com%2freport%2fBCc5co%2fJQLG&data=01%7c01%7crakatyal%40microsoft.com%7c1371f56d47e84d4fb7c808d34f59b0e9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=eH8cPNyXnPD2ltm%2bKbFfLCq4ifGQeBItD5rAXbgSOhg%3d
>
> On 3/17/16, 5:55 PM, "Carlos Santana"  wrote:
>
> >I agree Joe
> >
> >It's easy to create a stackoverflow subscription that emails you once a
> >day.
> >
> >I have one that covers "cordova" "worklight" "mobilefirst"
> >
> >I tried to answer what I can, but reading it daily which is not every
> >day that I get something probably most every other day with a few.
> >
> >At least reading all the new questions gives me a sense on what people
> >are having problems on.
> >
> >
> >
> >On Thu, Mar 17, 2016 at 8:46 PM Joe Bowser  wrote:
> >
> >> BTW: The last one was a joke.  But in all honesty, we should all
> >> spend a bit more time on Stack seeing what's going on there with our
> >> respective products/distributions.
> >>
> >> On Thu, Mar 17, 2016 at 5:43 PM, Joe Bowser  wrote:
> >>
> >> >
> >> >
> >> > On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva
> >> > 
> >> > wrote:
> >> >
> >> >> Keep in mind that the answers are limited to the technologies that
> >> >> Stack Overflow chooses to offer in their list of options. They have
> an "other"
> >> >> option with a text box, but people's answers are largely driven by
> >> >> the checkbox options.
> >> >>
> >> >>
> >> > So, we somehow pissed off the Stack Overflow guys???
> >> >
> >> >
> >> >
> >> >>
> >> >>
> >> >> Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for
> >> >> Apache Cordova rsa...@microsoft.com
> >> >> 425 706 5270 office
> >> >> 206 612 5079 mobile
> >> >>
> >> >> -Original Message-
> >> >> From: Joe Bowser [mailto:bows...@gmail.com]
> >> >> Sent: Thursday, March 17, 2016 5:21 PM
> >> >> To: dev 
> >> >> Subject: Re: Does Cordova have a problem making developers happy?
> >> >>
> >> >> On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva
> >> >> 
> >> >> wrote:
> >> >>
> >> >> > As I told some of my co-workers today:
> >> >> >
> >> >> > If you read the fine print, the actual statistic is “% of
> >> >> > developers who are developing with the language or tech but have
> >> >> > not expressed interest in continuing to do so.” Clearly, it’s
> >> >> > not a good list to be on, but developer behavior also doesn’t
> reflect their stated intent.
> >> >> > NPM Stats show the number of Cordova downloads has actually
> >> >> > doubled since the same time last year.
> >> >> >
> >> >> > Again, I don’t think this is a good list to appear on… I’m just
> >> >> > not sure what to make of it given developer behavior.
> >> >> >
> >> >>
>

Re: Does Cordova have a problem making developers happy?

On Thu, Mar 17, 2016 at 5:03 PM, Jesse  wrote:

> Never trust people's answers when you ask them what they like! They are
> almost always wrong, and will tell you what they think they like, or think
> they will seem cooler if they liked.
>
>
+1

It's interesting that CoffeeScript is on this list and that it passed
Cordova in most dreaded.  I also wonder what would happen if we went on the
WordPress mailing list and talked about how people were so unhappy with
WordPress.


>
> > On Mar 17, 2016, at 5:04 AM, julio cesar sanchez 
> wrote:
> >
> > 2016 survey is out
> >
> > Most Dreaded technologies:
> >
> > Visual Basic79.5%
> > WordPress  74.3%
> > Matlab 72.8%
> > Sharepoint  72.1%
> > CoffeeScript71.0%
> > LAMP  68.7%
> > Cordova  66.9%
> > Salesforce   65.4%
> > Other   61.5%
> > Perl 61.3%
> > SQL Server & SQL 60.3%
> > Objective-C 60.2%
> >
> >
> https://stackoverflow.com/research/developer-survey-2016#technology-most-loved-dreaded-and-wanted
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/553#issuecomment-197645372
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: 5.1.x fullscreen no immersive

Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/271#issuecomment-197740753
  
@oratthumzap, you should rebase your commit on master so that only relevant 
changes are shown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Does Cordova have a problem making developers happy?

On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva  wrote:

> As I told some of my co-workers today:
>
> If you read the fine print, the actual statistic is “% of developers who
> are developing with the language or tech but have not expressed interest in
> continuing to do so.” Clearly, it’s not a good list to be on, but developer
> behavior also doesn’t reflect their stated intent. NPM Stats show the
> number of Cordova downloads has actually doubled since the same time last
> year.
>
> Again, I don’t think this is a good list to appear on… I’m just not sure
> what to make of it given developer behavior.
>

I'd rather be on that list instead of not be on any list.  I'd be more
concerned with the fact that we're on the "Losers" section of the trending
tech with a 7% decrease in the number of questions, which indicate that
people either have no problems (not very likely) or are just giving up.  I
haven't been answering questions on Stack for a while, mostly because
they're using some third party framework like ionic or something else.

I also find it interesting that people are hating on Cordova, and not
PhoneGap, Ionic, Taco or the other distributions.


>
>
> Ryan J. Salva  |  Principal PM Manager
> Visual Studio Tools for Apache Cordova
> rsa...@microsoft.com
> 425 706 5270 office
> 206 612 5079 mobile
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 17, 2016 5:08 PM
> To: dev 
> Subject: Re: Does Cordova have a problem making developers happy?
>
> On Thu, Mar 17, 2016 at 5:03 PM, Jesse  wrote:
>
> > Never trust people's answers when you ask them what they like! They
> > are almost always wrong, and will tell you what they think they like,
> > or think they will seem cooler if they liked.
> >
> >
> +1
>
> It's interesting that CoffeeScript is on this list and that it passed
> Cordova in most dreaded.  I also wonder what would happen if we went on the
> WordPress mailing list and talked about how people were so unhappy with
> WordPress.
>
>
> >
> > > On Mar 17, 2016, at 5:04 AM, julio cesar sanchez
> > > 
> > wrote:
> > >
> > > 2016 survey is out
> > >
> > > Most Dreaded technologies:
> > >
> > > Visual Basic79.5%
> > > WordPress  74.3%
> > > Matlab 72.8%
> > > Sharepoint  72.1%
> > > CoffeeScript71.0%
> > > LAMP  68.7%
> > > Cordova  66.9%
> > > Salesforce   65.4%
> > > Other   61.5%
> > > Perl 61.3%
> > > SQL Server & SQL 60.3%
> > > Objective-C 60.2%
> > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fstack
> > overflow.com%2fresearch%2fdeveloper-survey-2016%23technology-most-love
> > d-dreaded-and-wanted&data=01%7c01%7crsalva%40microsoft.com%7c342aabb95
> > ca84607ba2608d34ec16bfe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=x
> > SvTHrkLQ7Z4Z7CTctZ4rjFxaznfrPKVjqCkMzcUIpk%3d
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/557#issuecomment-197585138
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

GitHub user vladimir-kotikov reopened a pull request:

https://github.com/apache/cordova-windows/pull/159

CB-10622 Support any MRT qualifiers for Windows icons

JIRA [CB-10622](https://issues.apache.org/jira/browse/CB-10622)

This PR fixes copying MRT images with qualifiers other that `scale-*`
This is an alternative for #149 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10622

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #159


commit eecfb1b03e616942cd7ccb38225258daea60f1cf
Author: Vladimir Kotikov 
Date:   2016-03-14T12:24:15Z

CB-10622 Support any MRT qualifiers for Windows icons




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Does Cordova have a problem making developers happy?

On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva  wrote:

> Keep in mind that the answers are limited to the technologies that Stack
> Overflow chooses to offer in their list of options. They have an "other"
> option with a text box, but people's answers are largely driven by the
> checkbox options.
>
>
So, we somehow pissed off the Stack Overflow guys???



>
>
> Ryan J. Salva  |  Principal PM Manager
> Visual Studio Tools for Apache Cordova
> rsa...@microsoft.com
> 425 706 5270 office
> 206 612 5079 mobile
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Thursday, March 17, 2016 5:21 PM
> To: dev 
> Subject: Re: Does Cordova have a problem making developers happy?
>
> On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva 
> wrote:
>
> > As I told some of my co-workers today:
> >
> > If you read the fine print, the actual statistic is “% of developers
> > who are developing with the language or tech but have not expressed
> > interest in continuing to do so.” Clearly, it’s not a good list to be
> > on, but developer behavior also doesn’t reflect their stated intent.
> > NPM Stats show the number of Cordova downloads has actually doubled
> > since the same time last year.
> >
> > Again, I don’t think this is a good list to appear on… I’m just not
> > sure what to make of it given developer behavior.
> >
>
> I'd rather be on that list instead of not be on any list.  I'd be more
> concerned with the fact that we're on the "Losers" section of the trending
> tech with a 7% decrease in the number of questions, which indicate that
> people either have no problems (not very likely) or are just giving up.  I
> haven't been answering questions on Stack for a while, mostly because
> they're using some third party framework like ionic or something else.
>
> I also find it interesting that people are hating on Cordova, and not
> PhoneGap, Ionic, Taco or the other distributions.
>
>
> >
> >
> > Ryan J. Salva  |  Principal PM Manager Visual Studio Tools for Apache
> > Cordova rsa...@microsoft.com
> > 425 706 5270 office
> > 206 612 5079 mobile
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Thursday, March 17, 2016 5:08 PM
> > To: dev 
> > Subject: Re: Does Cordova have a problem making developers happy?
> >
> > On Thu, Mar 17, 2016 at 5:03 PM, Jesse  wrote:
> >
> > > Never trust people's answers when you ask them what they like! They
> > > are almost always wrong, and will tell you what they think they
> > > like, or think they will seem cooler if they liked.
> > >
> > >
> > +1
> >
> > It's interesting that CoffeeScript is on this list and that it passed
> > Cordova in most dreaded.  I also wonder what would happen if we went
> > on the WordPress mailing list and talked about how people were so
> > unhappy with WordPress.
> >
> >
> > >
> > > > On Mar 17, 2016, at 5:04 AM, julio cesar sanchez
> > > > 
> > > wrote:
> > > >
> > > > 2016 survey is out
> > > >
> > > > Most Dreaded technologies:
> > > >
> > > > Visual Basic79.5%
> > > > WordPress  74.3%
> > > > Matlab 72.8%
> > > > Sharepoint  72.1%
> > > > CoffeeScript71.0%
> > > > LAMP  68.7%
> > > > Cordova  66.9%
> > > > Salesforce   65.4%
> > > > Other   61.5%
> > > > Perl 61.3%
> > > > SQL Server & SQL 60.3%
> > > > Objective-C 60.2%
> > > >
> > > >
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fsta
> > > ck
> > > overflow.com%2fresearch%2fdeveloper-survey-2016%23technology-most-lo
> > > ve
> > > d-dreaded-and-wanted&data=01%7c01%7crsalva%40microsoft.com%7c342aabb
> > > 95
> > > ca84607ba2608d34ec16bfe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata
> > > =x SvTHrkLQ7Z4Z7CTctZ4rjFxaznfrPKVjqCkMzcUIpk%3d
> > >
> > > 
> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

[GitHub] cordova-windows pull request: CB-10888 Enable coverage reports col...

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/161

CB-10888 Enable coverage reports collection via codecov



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10888

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #161


commit e8b239a29d86118cfbf38a7a1df15c43137ed0bd
Author: Vladimir Kotikov 
Date:   2016-03-16T13:40:52Z

CB-10888 Enable coverage reports collection via codecov




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Tools Release

Tools release issue: https://issues.apache.org/jira/browse/CB-10902


On Thu, Mar 17, 2016 at 1:18 PM, Mefire O.  wrote:

> PR: https://github.com/apache/cordova-lib/pull/413
>
> Occasionally, there is this issue that crops up, looks like there's a race
> condition between the cordova-lib code and the cordova-ios code.
> As a result, I will close this PR and we can proceed with the release.
> Anyone else is welcome to carry out further investigations, if interested.
>
> Sorry, everyone.
>
> Thanks,
> Omar Mefire
>
> On Mar 17, 2016, at 12:36 PM, Mefire O.  ommen...@microsoft.com>> wrote:
>
> PR issued: https://github.com/apache/cordova-lib/pull/413
>
>
> Thanks,
> Omar Mefire
>
> On Mar 16, 2016, at 12:45 PM, Steven Gill  stevengil...@gmail.com>> wrote:
>
> hmm, sounds like a reasonable solution. Right now we only reinstall plugins
> saved in config.xml (which prepare does). But it makes sense to reinstall
> all plugins installed.
>
> Let me know when you have a PR.
>
> On Wed, Mar 16, 2016 at 11:02 AM, Mefire O.  > wrote:
>
> I'd like to propose we get in a fix for CB-10775 during this release:
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10775&data=01%7c01%7commenjik%40microsoft.com%7c946d776dac834e2e388d08d34dd3962f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0Mx2AXdn9TjMyV8h7CFnVsOkcqVCL2zr8ifWjdn%2fvo4%3d
>
> It is breaking lots of people, and I have a fix that will solve this
> problem temporarily until we get the more permanent 'cordova platform rm,
> platform add' solution in.
>
> It involves making changes to cordova-lib, to reinstall plugins recorded
> in , after their deletion by the platform (cordova-ios).
>
> If we agree this should go in, I can have something working by end of day,
> today.
>
> Thanks,
> Omar Mefire
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Monday, March 14, 2016 6:00 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Tools Release
>
> Sounds good.
> I'm working on this [1] it should be done by then to pick it up
>
> [1]:
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10808&data=01%7c01%7commenjik%40microsoft.com%7c0eb62e0d48e74f71ab8208d34c089010%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=AwCI%2f5sbxcxI0kpS%2fJI4D%2bvtdMBMfhexWW2EOCGrfhU%3d
>
>
> On Sun, Mar 13, 2016 at 6:09 PM Steven Gill 
> wrote:
>
> I'm planning on starting a tools release on Wed. Let me know if you
> need me to look at anything.
>
> -Steve
>
>
>
>
>

[Vote] Tools Release March 18, 2016

Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10902

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10902/

The packages were published from their corresponding git tags:

cordova-js: 4.1.4 (1482f4b4d1)
cordova-lib: 6.1.0 (31b58d0c34)
cordova-plugman: 1.2.0 (3426b27f17)
cordova-cli: 6.1.0 (7b52ffccfb)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran through testing section at
https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test

Re: [DISCUSS] cordova-ios release

2016-03-19 Thread Carlos Santana

I agree Steve 

- Carlos
@csantanapr

> On Mar 17, 2016, at 4:17 PM, Steven Gill  wrote:
> 
> Lets do a common release first and then follow that up with patch ios
> release
> 
>> On Thu, Mar 17, 2016 at 11:24 AM, Shazron  wrote:
>> 
>> I would say patch release. I had some items I wanted in the next
>> release (labeled cordova-ios-4.1.1), but that shouldn't hold up
>> releasing often, keep the train running...
>> 
>> Ideally it should be accompanied with the patches I did yesterday for
>> cordova-common (since cordova-common is bundled in to cordova-ios),
>> but those bugs only really affect cordova-cli functionality
>> 
>> On Thu, Mar 17, 2016 at 11:09 AM, Edna Y Morales 
>> wrote:
>>> 
>>> Hi,
>>> 
>>> We are interested in a cordova-ios release, specifically for this jira
>>> item: https://issues.apache.org/jira/browse/CB-10773
>>> 
>>> Is there any opposition to this or any reason to wait? Steve would it
>> make
>>> sense to wait for a cordova-common release to happen first, before doing
>>> the cordova-ios release?
>>> 
>>> Would it be a patch release or a minor release?
>>> 
>>> Thanks,
>>> Edna Morales
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: 5.1.x fullscreen no immersive

2016-03-19 Thread oratthumzap

Github user oratthumzap commented on the pull request:

https://github.com/apache/cordova-android/pull/271#issuecomment-197736415
  
@infil00p, do you want me to refactor the code or remove the pull request 
altogether?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-weinre pull request: Support IE Mobile

2016-03-19 Thread pmuellr

Github user pmuellr commented on the pull request:

https://github.com/apache/cordova-weinre/pull/14#issuecomment-197292090
  
@sgrebnov I believe you added this bit of code way back when; anything else 
we need to look out for here? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Better syntax highlighting

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/560#issuecomment-198162246
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Tools Release

2016-03-19 Thread Mefire O .

I'd like to propose we get in a fix for CB-10775 during this release: 
https://issues.apache.org/jira/browse/CB-10775

It is breaking lots of people, and I have a fix that will solve this problem 
temporarily until we get the more permanent 'cordova platform rm, platform add' 
solution in.

It involves making changes to cordova-lib, to reinstall plugins recorded in 
, after their deletion by the platform (cordova-ios).

If we agree this should go in, I can have something working by end of day, 
today.

Thanks,
Omar Mefire

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Monday, March 14, 2016 6:00 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Tools Release

Sounds good.
I'm working on this [1] it should be done by then to pick it up

[1]: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10808&data=01%7c01%7commenjik%40microsoft.com%7c0eb62e0d48e74f71ab8208d34c089010%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=AwCI%2f5sbxcxI0kpS%2fJI4D%2bvtdMBMfhexWW2EOCGrfhU%3d

On Sun, Mar 13, 2016 at 6:09 PM Steven Gill  wrote:

> I'm planning on starting a tools release on Wed. Let me know if you 
> need me to look at anything.
>
> -Steve
>

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-android/pull/276

CB-10600 'cordova run android --release' does not use signed and zip-â¦

â¦aligned version of APK

De-prioritize unsigned builds
Adds an actionable hint for INSTALL_PARSE_FAILED_NO_CERTIFICATES error
Removes filtering by architecture when not specified

[Jira issue](https://issues.apache.org/jira/browse/CB-10600)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10600

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #276


commit 004c60320b7bbdd23b1b46ae461285eb9337b82c
Author: daserge 
Date:   2016-03-16T13:54:06Z

CB-10600 'cordova run android --release' does not use signed and 
zip-aligned version of APK

De-prioritize unsigned builds
Adds an actionable hint for INSTALL_PARSE_FAILED_NO_CERTIFICATES error
Removes filtering by architecture when not specified




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579806
  
--- Diff: src/android/FileUtils.java ---
@@ -1124,6 +1172,18 @@ public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMis
 }
 }, lastRawArgs, callback);
 break;
+case READ_PERM_DIR:
+case WRITE_PERM_DIR:
+threadhelper( new FileOp( ){
+public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
+String dirname=args.getString(0);
--- End diff --

Nitpick: spaces around `=`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/276#discussion_r56434511
  
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget, 
buildResults) {
 if (err) reject(new CordovaError('Error executing 
"' + command + '": ' + stderr));
 // adb does not return an error code even if 
installation fails. Instead it puts a specific
 // message to stdout, so we have to use RegExp 
matching to detect installation failure.
-else if (/Failure/.test(stdout)) reject(new 
CordovaError('Failed to install apk to emulator: ' + stdout));
-else resolve(stdout);
+else if (/Failure/.test(stdout)) {
+if 
(stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) {
+stdout += 'Sign the build using \'-- 
--keystore\' or \'--buildConfig\'' +
+' or sign and deploy the unsigned apk 
manually using Android tools.';
+}
+
+reject(new CordovaError('Failed to install apk 
to emulator: ' + stdout));
+} else resolve(stdout);
--- End diff --

Cool. Thanks for explaining. Do you have the context on this task in order 
to file a JIRA? If not, I'll read up and file it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-lib/pull/412

CB-9264 - Duplicate entries in config.xml



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-lib CB-9264

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #412






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197525596
  
Testing this now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/553


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10888 Enable coverage reports col...

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-android/pull/277

CB-10888 Enable coverage reports collection via codecov



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10888

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #277


commit 9f1aedb56d261b762392183a5174b80c62ec1cc9
Author: Vladimir Kotikov 
Date:   2016-03-16T14:42:01Z

CB-10888 Enable coverage reports collection via codecov




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Better syntax highlighting

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/560

Better syntax highlighting

Switching from prettify to rouge!

Good changes:
* Way nicer looking code blocks that we can easily edit the CSS for
* No more inline code highlighting (aka less colorful blog posts)
* Better performance probably?
* I fixed a lot of random broken markdown across the site

Bad changes:
* Language detection is not longer automatic so we need to use GFM fenced 
code blocks (which I already did)

I highly recommend that you add `?w=1` to the URL when viewing changes in 
this PR (removes whitespace changes)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs syntax-highlighting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #560


commit da85fd20b955d8d17253e2be95b8689d4cc5aa88
Author: Richard Knoll 
Date:   2016-03-17T00:51:28Z

Replacing prettify.js with rouge for syntax highlighting

commit a65e8109a34b3ca68545fde45029d8430298b3a8
Author: Richard Knoll 
Date:   2016-03-18T00:49:17Z

Converted all markdown code blocks in dev to GFM fenced blocks




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10912: update ios-sim to 5.0.7 to fix...

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/208#issuecomment-198740174
  
Using ios-sim 5.0.7 didn't solve the problem:
- https://ci.apache.org/builders/cordova-ios/builds/2098
- 
https://ci.apache.org/builders/cordova-ios/builds/2098/steps/running-tests/logs/stdio


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10888 Enable coverage reports col...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/161


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Buildbot: buildslave cordova-osx-slave was lost

2016-03-19 Thread buildbot

The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away

It last disconnected at Wed Mar 16 19:55:15 2016 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky 
'.

Sincerely,
 The Buildbot
 https://ci.apache.org/

https://ci.apache.org/buildslaves/cordova-osx-slave

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/553#discussion_r56441986
  
--- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
@@ -44,13 +44,12 @@ For each corresponding native interface, see the list 
at the end of
 this section.
 
 In addition to these instructions, when preparing to write a plugin it
-is best to look over
-[existing plugins](http://cordova.apache.org/contribute)
+is best to look over [existing 
plugins](http://cordova.apache.org/contribute)
 for guidance.
 
 ## Building a Plugin
 
-Application developers use the CLI's [plugin add 
command](../../../cordova-cli/index.html#cordova-plugin-add-command) to add a 
plugin to a project. The
--- End diff --

@nikhilkh this heading doesn't exist in the master cordova-cli reference. I 
assumed you meant `cordova-plugin-command`. Is that correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/558


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10912: update ios-sim to 5.0.7 to fix...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/208


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10912: update ios-sim to 5.0.7 to fix...

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-ios/pull/208

CB-10912: update ios-sim to 5.0.7 to fix 'Invalid Device State' errors

This issue seems to have been introduced by a change in simctl, which 
ios-sim relies on:


https://github.com/phonegap/simctl/commit/34426c719130a73b83af65f50a11a46267a5ad0b

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-ios CB-10912

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #208


commit 048e5ce0d3ef0a570bfe592707308f875b8cc62b
Author: Omar Mefire 
Date:   2016-03-19T15:12:42Z

CB-10912: update ios-sim to 5.0.7 to fix 'Invalid Device State' errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-19 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56606932
  
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,11 @@ Licensed to the Apache Software Foundation (ASF) under 
one
  * Permission callback codes
  */
 
-public static final int READ_PERM = 0;
-public static final int WRITE_PERM = 1;
+public static final int PERM_FILE = 0;
+public static final int WRITE_ACTION = 1;
+public static final int PERM_DIR = 2;
+public static final int WRITE = 3;
+public static final int READ = 4;
--- End diff --

WRITE_ACTION corresponds to the handler for the write api call. READ and 
WRITE corresponds to the permission being asked for. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10822 CB-10833 Deduplicate platform-a...

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/414

CB-10822 CB-10833 Deduplicate platform-agnostic code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10833

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #414


commit bd0bc47d71ffe807c5a77428d9e8d120cbf0f350
Author: Vladimir Kotikov 
Date:   2016-03-10T11:03:11Z

CB-10822 Manage plugins/modules metadata using PlatformJson

commit cca86eb10532a92930d71bbf4d7eb69de877cc42
Author: Vladimir Kotikov 
Date:   2016-03-09T19:26:05Z

CB-10833 Deduplicate common logic for plugin installation/uninstallation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

2016-03-19 Thread limebreaker

Github user limebreaker commented on the pull request:

https://github.com/apache/cordova-windows/pull/149#issuecomment-198710562
  
Hello, could it be that the target attr. in:

 is actually completely ignored as  I always get no img.target in line 360:
 var images = 
config.getIcons('windows').concat(config.getSplashScreens('windows')); and 
therefor always "The following image is skipped due to unsupported size".

It seems that the config.getIcons never parses and adds the target 
attribute. The only way to get it work for me is using  width & height 
attribute.  Running win 8.1 cordova 6.0.0 , windows 4.3.1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: updated testing section in tools releas...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/195#issuecomment-197422268
  
LGTM. Thanks for improving testing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

Github user dblotsky closed the pull request at:

https://github.com/apache/cordova-docs/pull/551


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [ALL PLATFORMS][cordova-common] Platform specific preferences overridden by global preferences

2016-03-19 Thread Carlos Santana

changes are OK

On Wed, Mar 16, 2016 at 5:05 PM Shazron  wrote:

> Pull requests sent, with tests:
>
> 1. https://github.com/apache/cordova-lib/pull/411
>
> 2. https://github.com/apache/cordova-lib/pull/412
>
> On Wed, Mar 16, 2016 at 11:13 AM, Nikhil Khandelwal
>  wrote:
> > Thanks for the heads up. Good find! (1) sounds pretty bad - correct me
> if I'm wrong, to fix this, we need to do the following:
> > - fix it in cordova-common, release
> > - bundle those changes to all platforms & release all of them.
> >
> > We need tests for this scenario also.
> >
> > Shaz: Are you planning to take all the tasks above? Some of us could
> likely help.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Shazron [mailto:shaz...@gmail.com]
> > Sent: Wednesday, March 16, 2016 10:32 AM
> > To: dev@cordova.apache.org
> > Subject: [ALL PLATFORMS][cordova-common] Platform specific preferences
> overridden by global preferences
> >
> > Some code changes I want to highlight that I want changing, in
> cordova-common:
> >
> > 1.
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10694&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ynROJ1IjgLWqIcLk9AYH9%2fzlQTn%2fbVooUcyWk5iG12Q%3d
> >
> > Platform specific preferences are "overriden" by global preferences,
> because when the merged config.xml file (root config.xml merge with
> platform config.xml), the global preferences are written last always, so
> they clobber any previous declaration. The change is to write platform
> preferences last:
> >
> >
> https://github.com/apache/cordova-lib/blob/a3285602b88f4e40f08c178b8b26c918c91d0dce/cordova-common/src/util/xml-helpers.js#L212-L217
> >
> > 2.
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9264&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uKrVMPdcY2zBnYiGrTASEoKAlGoanmcdd6ME0BIlPd4%3d
> >
> > This is not as critical as #1 above, since it's just a build artifact
> thing.This is just to remove duplicate entries in the merged config.xml.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

2016-03-19 Thread csantanapr

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-lib/pull/412#issuecomment-197559090
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10888 Enable coverage reports collect...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/206


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/558#issuecomment-197387971
  
I noticed you are modifying 6.x version of the document - it's not a good 
idea to do so as dev gets copied to 6.x periodically and these edits will be 
lost unless both are updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

2016-03-19 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56607030
  
--- Diff: src/android/FileUtils.java ---
@@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMis
 }
 }, lastRawArgs, callback);
 break;
-case WRITE_PERM:
+case PERM_DIR:
+threadhelper( new FileOp( ){
+public void run(JSONArray args) throws 
FileExistsException, IOException, TypeMismatchException, EncodingException, 
JSONException {
+String dirname = args.getString(0);
+
+String path = args.getString(1);
+JSONObject obj = getFile(dirname, path, 
args.optJSONObject(2), true);
+callback.success(obj);
+}
+}, lastRawArgs, callback);
+break;
+case WRITE_ACTION:
--- End diff --

I like this convention better since this differentiates the calls for 
'FILE' and 'DIR'. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-weinre pull request: Support IE Mobile

2016-03-19 Thread ChickenMythic

Github user ChickenMythic commented on the pull request:

https://github.com/apache/cordova-weinre/pull/14#issuecomment-197308612
  
Thank you.

You're right for WindowsPhone (for example), Visual Studio is well suited 
to debuggued webviews but it actually requires to use Visual Studio itself. Our 
web dev work on Unix machines and use Weinre for remote debugging. This way 
they can debug the same webview piece of code executed on different webview 
from different mobile platforms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/557


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...

2016-03-19 Thread ktop

GitHub user ktop opened a pull request:

https://github.com/apache/cordova-android/pull/283

CB-10897 Refactor URI Parsing for Whitelist

Fix for CB-10897. 

I moved out the code that parses the 'origin' from the whitelist to a 
separate function so that it can also be used to parse the URLs that request 
access instead of using Android's Uri class parse function. Android's Uri parse 
function does not parse 'host' the same way that Cordova parses the host in 
origin for whitelist, so host ends up being null and the comparison fails. 
Using the same parsing methods is the way to go to give accurate comparisons of 
URLs to those in the whitelist. 

Also, I can have specific non http/https URLs in my whitelist now. 
Something like this works now without the wildcard:


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktop/cordova-android CB-10897

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit 26662acada6f44a83c11c1e13faa8fea3a959720
Author: Karen Tran 
Date:   2016-03-18T18:45:57Z

CB-10897 Refactor URI Parsing for Whitelist




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Buildbot: buildslave cordova-osx-slave was lost

2016-03-19 Thread Dmitry Blotsky

Rebooted the machine because the iOS simulator was goofing up and people 
suggested that rebooting helped resolve the same type of goofing for them. Look 
at me: neglecting to do root cause analysis all day, er'ry day.

Kindly,
Dmitry

-Original Message-
From: build...@apache.org [mailto:build...@apache.org] 
Sent: Wednesday, March 16, 2016 1:00 PM
To: dev@cordova.apache.org
Subject: Buildbot: buildslave cordova-osx-slave was lost

The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away

It last disconnected at Wed Mar 16 19:55:15 2016 (buildmaster-local time)

The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky 
 '.

Sincerely,
 The Buildbot
 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.apache.org%2f&data=01%7c01%7cdblotsky%40microsoft.com%7cc1f91f1db2c8443a87aa08d34dd59a6d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=niVDOsB5%2f7vWKKP9zi%2fwwixJrl8Kc5nX5Owcj6pZG2o%3d

https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.apache.org%2fbuildslaves%2fcordova-osx-slave&data=01%7c01%7cdblotsky%40microsoft.com%7cc1f91f1db2c8443a87aa08d34dd59a6d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=EvwH2npWowa9z1syz4H%2fr7EYnJ8rzkj0ETMIchgdXlg%3d

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10833 Reuse plugin installation l...

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-android/pull/282

CB-10833 Reuse plugin installation logic from cordova-common

DO NOT MERGE

This PR is for demo purpose only and shows how the platform code will look 
like after plugin adding/removal functionality is moved into `cordova-common`.  
See apache/cordova-lib#414 for required changes in `cordova-lib`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10833

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #282


commit 71460ecf7b8108b569b9d716b1410c23cea65382
Author: Vladimir Kotikov 
Date:   2016-03-09T14:46:07Z

CB-10822 Deduplicate plugin_metadata logic to cordova-common

commit 20cbaed5e30dc4bda13f7823555c2dd08b780d0b
Author: Vladimir Kotikov 
Date:   2016-03-10T11:14:42Z

Upgrade to latest common from CB-10822

commit 15ad9327a82ee009fe6c33acea1199fdf34432b3
Author: Vladimir Kotikov 
Date:   2016-03-10T08:35:18Z

Update platform to use PluginManager from common

commit 435acfe926f593f111cd68550b2bef83fe5a051c
Author: Vladimir Kotikov 
Date:   2016-03-10T09:12:19Z

Upgrade cordova-common

commit e1cf50fd8d0737d71b21eb82c1abbeee508f29d7
Author: Vladimir Kotikov 
Date:   2016-03-10T10:02:13Z

Instantiate munger and platformJson when needed only

commit e3e4eb741bb114ac93f404dca2f692bb255a9beb
Author: Vladimir Kotikov 
Date:   2016-03-10T11:49:21Z

Upgrade cordova-common




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56599180
  
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,11 @@ Licensed to the Apache Software Foundation (ASF) under 
one
  * Permission callback codes
  */
 
-public static final int READ_PERM = 0;
-public static final int WRITE_PERM = 1;
+public static final int PERM_FILE = 0;
+public static final int WRITE_ACTION = 1;
+public static final int PERM_DIR = 2;
+public static final int WRITE = 3;
+public static final int READ = 4;
--- End diff --

What's the difference between `WRITE` and `WRITE_ACTION`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/411#issuecomment-197557719
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197549101

@adamduren I've tested this and the save/restore stuff appears to work
great! There is an issue, however, with the results that are returned in the
resume event. They need to be wrapped in `MediaFile` objects before use. This
was also an issue in the Contacts plugin where they needed to be wrapped in a
`Contact` object and the solution was to just provide an example of how to do
that in the README (see
[here](https://github.com/apache/cordova-plugin-contacts#android-quirks)). In
this plugin it is a little bit trickier because we need to decide how to expose
the `MediaFile` object creation. Currently, it just happens in the `exec`
callback
[here](https://github.com/apache/cordova-plugin-media-capture/blob/0867898701c9f5478448bfc0f46d6ae14008/www/capture.js#L34)
without a public API. Thoughts? Maybe we should add a `MediaFile` constructor
that encapsulates that `exec` callback? That at least would not be a breaking
change.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ALL PLATFORMS][cordova-common] Platform specific preferences overridden by global preferences

2016-03-19 Thread Shazron

Some code changes I want to highlight that I want changing, in cordova-common:

1. https://issues.apache.org/jira/browse/CB-10694

Platform specific preferences are "overriden" by global preferences,
because when the merged config.xml file (root config.xml merge with
platform config.xml), the global preferences are written last always,
so they clobber any previous declaration. The change is to write
platform preferences last:

https://github.com/apache/cordova-lib/blob/a3285602b88f4e40f08c178b8b26c918c91d0dce/cordova-common/src/util/xml-helpers.js#L212-L217

2. https://issues.apache.org/jira/browse/CB-9264

This is not as critical as #1 above, since it's just a build artifact
thing.This is just to remove duplicate entries in the merged
config.xml.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10775: cordova-ios update fix:

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/413#issuecomment-198065158
  
Occasionally, there is this issue that pops up:
```
cp: no such file or directory: 
/Users/omefire/Projects/tt/platforms/ios/Hello Cordova/.gitignore

grep: no such file or directory: 
/Users/omefire/Projects/tt/platforms/ios/Hello Cordova.xcodeproj/project.pbxproj

sed: no such file or directory: 
/Users/omefire/Projects/tt/platforms/ios/Hello Cordova.xcodeproj/project.pbxproj

Error: Subproject: CordovaLib/CordovaLib.xcodeproj entry not found in 
project file
```
Looks like there's a race condition between the cordova-lib code and the 
cordova-ios code.

As a result, I will close this PR.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/412#issuecomment-197606599
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/276#discussion_r56369539
  
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget, 
buildResults) {
 if (err) reject(new CordovaError('Error executing 
"' + command + '": ' + stderr));
 // adb does not return an error code even if 
installation fails. Instead it puts a specific
 // message to stdout, so we have to use RegExp 
matching to detect installation failure.
-else if (/Failure/.test(stdout)) reject(new 
CordovaError('Failed to install apk to emulator: ' + stdout));
-else resolve(stdout);
+else if (/Failure/.test(stdout)) {
+if 
(stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) {
+stdout += 'Sign the build using \'-- 
--keystore\' or \'--buildConfig\'' +
+' or sign and deploy the unsigned apk 
manually using Android tools.';
+}
+
+reject(new CordovaError('Failed to install apk 
to emulator: ' + stdout));
+} else resolve(stdout);
--- End diff --

Does it make sense to de-duplicate this error string since it also occurs 
in `Adb.js`, or would that be too cumbersome?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10837 Support platform-specific o...

Github user omefire commented on the pull request:

https://github.com/apache/cordova-android/pull/281#issuecomment-198428878
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/559#discussion_r56738586
  
--- Diff: www/_posts/2016-03-16-new-plugin-fetching.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Richard Knoll
+url: https://github.com/riknoll
+title:  "Upcoming Changes to Plugin Fetching"
+categories: announcements
+tags: news
+---
+
+The Cordova 6.0.0 release introduced the pinning of core plugin
+versions in cordova-lib.
+
+We are happy to announce that one of the new features in the upcoming
+Cordova 6.1.0 release is a general API that allows any plugin to guide
+the CLI in choosing a compatible plugin release to fetch for a given 
project.
+This moves the plugin dependency information out of cordova-lib so that it
+can update independently of the Cordova tools and support third-party 
plugins
+outside of core. Our hope is that this feature will improve Cordova's 
plugin
+ecosystem and reduce some of the frustration that Cordova developers face 
when
+adding a new plugin to a project.
+
+
+
+The new API allows for plugin developers to give a mapping of plugin
+releases to project requirements in their `package.json`. When an app 
developer
+adds a plugin to their Cordova project, cordova-lib will examine their
+installed plugins, platforms, and cordova-lib version and decide which
+version of the plugin to fetch based on the provided mapping.
+If the project does not fulfill the requirements for the latest release of 
the
+plugin, the CLI will print warnings indicating the problems and fetch the
+latest release of the plugin that is compatible.
+
+This API may eventually replace the [engines 
element](http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine)
 in `plugin.xml`.
--- End diff --

Sure!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/411#issuecomment-197556043
  
Yeah, that is weird. Probably not an issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

2016-03-19 Thread dpolivy

Github user dpolivy commented on the pull request:

https://github.com/apache/cordova-android/pull/273#issuecomment-197424352
  
@daserge Thanks! I will close this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...

2016-03-19 Thread abarranco

Github user abarranco commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-197310054
  
I've been 2 days debugging my project when i figured out that this was 
actually a problem. When i tried to download images from http with 301 
response, file transfer downloaded that response and not followed the new url 
to get the final resource via https. Exactly what restouffer says. I think the 
plugin should allow to download the real resource. I am thinking this could be 
a security issue as well??. The url suggested in the 301 response will go 
trought the whitelist plugin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Snapshotting dev to 6.x.