[GitHub] cordova-coho pull request: Create jenkins-access.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-11185 - add '--non-interactive --tru...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Added common, fetch and serve to tools ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Added common, fetch and serve to tools ...

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/119

Added common, fetch and serve to tools release process



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-53

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #119


commit bd9815d7dc4c7ce4e82eeb2917b1545e3e415507
Author: Steve Gill 
Date:   2016-05-13T06:43:04Z

Added common, fetch and serve to tools release process




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] Tools Release

[Steven Gill]

Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11260

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11260/

The packages were published from their corresponding git tags:

cordova-lib: fetch-1.0.0 (c7583807a0)
cordova-lib: common-1.3.0 (c7583807a0)
cordova-lib: 6.2.0 (c7583807a0)
cordova-plugman: 1.3.0 (e780c58232)
cordova-cli: 6.2.0 (91038deff9)

Upon a successful vote I will upload the archives to dist/, publish
them to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Built mobile-spec and tested on Android
* Ran npm test in all tool repos

[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...

[stewshka]

Github user stewshka commented on the pull request:


https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-218947372
  
My visual studio complains that the "engines" item must have an object as 
its value.
But when I paste your code, i get a complain that the "cordovaDependencies" 
file must have a string as its value.
woudnt this be the solution?
```
  "engines": {
"cordova-android": ">=4.0.0"
  },
```

Documentation: https://docs.npmjs.com/files/package.json#engines
Please fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218930850
  
@riknoll I just removed a big chunk of the whitespace changes that were 
done by Android Studio. I find myself having to manually copy changes from my 
editor into a seperate text editor to commit, because there are so many 
indentation problems in this file. :-(  This is what led to the missing 
function earlier today.
I will need to do another pull request in the future to specifically to 
address indentation, spelling errors, and function documentation that is wrong. 
I was trying to fix so much. Sorry!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-coho/pull/116#issuecomment-218924426
  
LGTM otherwise


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10139 browser: Respect targ...

[kicken]

Github user kicken commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/210#issuecomment-218919902
  
@nikhilkh Nothing in particular.  My main target is a mobile app, but I 
happen to do a lot of preliminary testing in google chrome's device mode using 
the browser platform. Since I may eventually release a website to equivalent of 
the app, I figured I may as well try and re-use as much as I can so I 
occasionally try the app in normal browser mode and fix it up if it doesn't 
take too much effort.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-7904 Built nightly releases using co...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-coho/pull/116#discussion_r63115159
  
--- Diff: src/nightly.js ---
@@ -66,38 +82,19 @@ module.exports = function*(argv) {
 yield gitutil.resetFromOrigin();
 })
 
-//get SHAS from platforms
+// Get SHAS from repos
 var SHAJSON = yield retrieveSha(repos);
 
-//save SHAJSON in cordova-cli repo
-yield repoutil.forEachRepo([cli], function*() {
-//need to get the path to cordova-cli using executil
-var cordovaclidir = process.cwd();
-fs.writeFileSync((path.join(cordovaclidir, 'shas.json')), 
JSON.stringify(SHAJSON, null, 4), 'utf8', function(err) {
-if (err) return console.log (err);
-});
-
-});
-
-//Update platform references at 
cordova-lib/src/cordova/platformsConfig.json
-var cordovalibdir;
-yield repoutil.forEachRepo([cordovaLib], function*() {
-//need to get the path to cordova-lib using executil
-cordovalibdir = process.cwd();
-});
-
-yield updatePlatformsFile(path.join(cordovalibdir, 
'src/cordova/platformsConfig.json'), SHAJSON);
-
-
 var currentDate = new Date();
 var nightlyVersion = '-nightly.' + currentDate.getFullYear() + '.' +
-currentDate.getMonth() + '.' + 
currentDate.getDate();
+pad(currentDate.getMonth() + 1) + '.' + 
pad(currentDate.getDate());
 var cordovaLibVersion;
 //update package.json version for cli + lib, update lib reference for 
cli
 yield repoutil.forEachRepo([cordovaLib, cli], function*(repo) {
 var dir = process.cwd();
 var packageJSON = require(dir+'/package.json');
-packageJSON.version = versionutil.removeDev(packageJSON.version) + 
nightlyVersion;
+packageJSON.version = versionutil.removeDev(packageJSON.version) + 
nightlyVersion +
+'+' + SHAJSON[repo.id];
--- End diff --

should this use short SHA instead of the full SHA. Shorter makes it easier 
to read etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova tools release

[Nikhil Khandelwal]

We'll need a cordova-ios release to make that happen. However, cordova-ios has 
a recent regression that needs to be fixed before we make a release: 
https://github.com/apache/cordova-ios/commit/cab0baa0f7c4d789171b0147da41a85471660c85

-Nikhil

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Thursday, May 12, 2016 2:02 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova tools release

Do we fully support node6 now?
If we do might be good to highlight in blog post

- Carlos
@csantanapr

> On May 12, 2016, at 5:00 PM, Steven Gill  wrote:
> 
> Excellent! I shall proceed.
> 
> The website will also get updated when I do the release blog post.
> 
> Cheers,
> -Steve
> 
>> On Thu, May 12, 2016 at 12:52 PM, Mefire O.  wrote:
>> 
>> Hey Steve,
>> Telemetry has been merged in!
>> We can move forward with the release process.
>> 
>> We'll also have to initiate a docs/website release, as they host our 
>> privacy policy.
>> Raghav will help with that.
>> 
>> Thanks for your patience, All.
>> 
>> Thanks,
>> Omar Mefire
>> 
>> -Original Message-
>> From: Mefire O. [mailto:ommen...@microsoft.com]
>> Sent: Tuesday, May 10, 2016 5:25 PM
>> To: dev@cordova.apache.org
>> Subject: RE: [DISCUSS] Cordova tools release
>> 
>> I expect it to be merged in by tomorrow EOD or day Thursday morning.
>> If it's still not merged in by then, I wouldn't want to hold the 
>> release any longer.
>> 
>> Thanks,
>> Omar Mefire
>> 
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Tuesday, May 10, 2016 2:39 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Cordova tools release
>> 
>> When do you expect to merge it in?
>> 
>>> On Tue, May 10, 2016 at 2:19 PM, Mefire O.  wrote:
>>> 
>>> I'd like to get the telemetry feature out with this release.
>>> 
>>> Thanks,
>>> Omar Mefire
>>> 
>>> -Original Message-
>>> From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
>>> Sent: Tuesday, May 10, 2016 12:47 AM
>>> To: dev@cordova.apache.org
>>> Subject: RE: [DISCUSS] Cordova tools release
>>> 
>>> +1
>>> 
>>> Thanks for handling cordova-common release - there is probably not 
>>> much sense in releasing it separately (as I was planning initially) 
>>> when other components also need to be released.
>>> 
>>> -
>>> Best regards, Vladimir
>>> 
>>> -Original Message-
>>> From: julio cesar sanchez [mailto:jcesarmob...@gmail.com]
>>> Sent: Tuesday, May 10, 2016 1:14 AM
>>> To: dev@cordova.apache.org
>>> Subject: Re: [DISCUSS] Cordova tools release
>>> 
>>> +1
>>> 
>>> El martes, 10 de mayo de 2016, Shazron  escribió:
>>> 
 +1
 
 On Mon, May 9, 2016 at 12:32 PM, Steven Gill 
 > wrote:
 
> Any objections or concerns?
> 
> Doing a cli, lib, plugman, common and fetch release.
> 
> -Steve
>>> 
>>> 
>>> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/439#issuecomment-218911859
  
@stevengill  done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/439


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/439#issuecomment-218910842
  
Passed! Lets merge this in @riknoll :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218908787
  
@JEGardner apologies, this is a pretty big change and I haven't had an 
opportunity to review/test it. I'll try and take a look at it this week. In the 
mean time, @swbradshaw there are a lot of whitespace changes here, can you try 
and remove those? They make the code tough to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

[JEGardner]

Github user JEGardner commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218907133
  
@riknoll any chance we could get this merged so we can use the official 
repo and not a fork? Seems like a pretty important bug to fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-lib/pull/439#issuecomment-218906307
  
Travis taking forever

On Thu, May 12, 2016 at 2:34 PM, Richard Knoll 
wrote:

> I'll merge whenever the Travis build finishes
>
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
> 
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218898614
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93/


**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/93//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218896610
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10139 browser: Respect targ...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/210#issuecomment-218896661
  
@kicken These are great changes - I'm curious what are you using the 
browser platform's camera implementation for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Camera permissions added

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/98#issuecomment-218894709
  
WebRTC usage is not related to camera plugin. You should perhaps use a hook 
to add the permission to your manifest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10370: Added option useGeol...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/153#issuecomment-218893492
  
This code has some merge conflicts. It makes sense to move away from a 
preference and use an option. Also, now the docs for plugin-camera are 
generated using jsdoc comments. It's best to close this PR and re-create a new 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218893182
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92/


**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=ios/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=ios/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=ios/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/92//label=windows-slave,platformName=android/artifact/)
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/439#issuecomment-218892839
  
I'll merge whenever the Travis build finishes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-11232:

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-medic/pull/103#issuecomment-218892354
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/439#issuecomment-218892010
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218891497
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Improving Windows build output and v...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-windows/pull/176#issuecomment-21889
  
@jasongin removed the word please pretty much everywhere


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218887906
  
Cordova CI Build has one or more failures. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/91/


**Results**
1. [Windows 8.1 Store]( 
$BUILD_URLlabel=windows-slave,platformName=windows-8.1-store/) - [Console 
Output]( $BUILD_URLlabel=windows-slave,platformName=windows-8.1-store/console) 
- [Test Results]( 
$BUILD_URLlabel=windows-slave,platformName=windows-8.1-store/testReport/) - 
[Device Logs]( 
$BUILD_URLlabel=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
$BUILD_URL80/label=windows-slave,platformName=windows-10-store/) - [Console 
Output]( $BUILD_URLlabel=windows-slave,platformName=windows-10-store/console) - 
[Test Results]( 
$BUILD_URLlabel=windows-slave,platformName=windows-10-store/testReport/) - 
[Device Logs]( 
$BUILD_URLlabel=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
$BUILD_URLlabel=windows-slave,platformName=windows-8.1-phone/) - [Console 
Output]( $BUILD_URLlabel=windows-slave,platformName=windows-8.1-phone/console) 
- [Test Results]( 
$BUILD_URLlabel=windows-slave,platformName=windows-8.1-phone/testReport/) - 
[Device Logs]( 
$BUILD_URLlabel=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( $BUILD_URLlabel=mac-slave,platformName=ios/) - [Console Output]( 
$BUILD_URLlabel=mac-slave,platformName=ios/console) - [Test Results]( 
$BUILD_URLlabel=mac-slave,platformName=ios/testReport/) - [Build Artifacts]( 
$BUILD_URLlabel=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( $BUILD_URLlabel=mac-slave,platformName=android/) - 
[Console Output]( $BUILD_URLlabel=mac-slave,platformName=android/console) - 
[Test Results]( $BUILD_URLlabel=mac-slave,platformName=android/testReport/) - 
[Build Artifacts]( $BUILD_URLlabel=mac-slave,platformName=android/artifact/)
6. [Android Windows]( $BUILD_URLlabel=windows-slave,platformName=android/) 
- [Console Output]( $BUILD_URLlabel=windows-slave,platformName=android/console) 
- [Test Results]( 
$BUILD_URLlabel=windows-slave,platformName=android/testReport/) - [Device 
Logs]( $BUILD_URLlabel=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-lib/pull/439#issuecomment-218885704
  
:shipit:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218885454
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/439#discussion_r63097000
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -286,7 +286,7 @@ module.exports = function plugin(command, targets, 
opts) {
 var configXml = new 
ConfigParser(configPath);
 configXml.removePlugin(target);
 configXml.write();
-events.emit('results', 'config.xml 
entry for ' +target+ ' is removed');
+events.emit('results', 'config.xml 
entry for plugin ' + target + ' was removed');
--- End diff --

@jasongin updated! Switched it to use log


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: Reorganized the config files and split...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/105


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova tools release

[Carlos Santana]

Do we fully support node6 now?
If we do might be good to highlight in blog post

- Carlos
@csantanapr

> On May 12, 2016, at 5:00 PM, Steven Gill  wrote:
> 
> Excellent! I shall proceed.
> 
> The website will also get updated when I do the release blog post.
> 
> Cheers,
> -Steve
> 
>> On Thu, May 12, 2016 at 12:52 PM, Mefire O.  wrote:
>> 
>> Hey Steve,
>> Telemetry has been merged in!
>> We can move forward with the release process.
>> 
>> We'll also have to initiate a docs/website release, as they host our
>> privacy policy.
>> Raghav will help with that.
>> 
>> Thanks for your patience, All.
>> 
>> Thanks,
>> Omar Mefire
>> 
>> -Original Message-
>> From: Mefire O. [mailto:ommen...@microsoft.com]
>> Sent: Tuesday, May 10, 2016 5:25 PM
>> To: dev@cordova.apache.org
>> Subject: RE: [DISCUSS] Cordova tools release
>> 
>> I expect it to be merged in by tomorrow EOD or day Thursday morning.
>> If it's still not merged in by then, I wouldn't want to hold the release
>> any longer.
>> 
>> Thanks,
>> Omar Mefire
>> 
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Tuesday, May 10, 2016 2:39 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Cordova tools release
>> 
>> When do you expect to merge it in?
>> 
>>> On Tue, May 10, 2016 at 2:19 PM, Mefire O.  wrote:
>>> 
>>> I'd like to get the telemetry feature out with this release.
>>> 
>>> Thanks,
>>> Omar Mefire
>>> 
>>> -Original Message-
>>> From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
>>> Sent: Tuesday, May 10, 2016 12:47 AM
>>> To: dev@cordova.apache.org
>>> Subject: RE: [DISCUSS] Cordova tools release
>>> 
>>> +1
>>> 
>>> Thanks for handling cordova-common release - there is probably not
>>> much sense in releasing it separately (as I was planning initially)
>>> when other components also need to be released.
>>> 
>>> -
>>> Best regards, Vladimir
>>> 
>>> -Original Message-
>>> From: julio cesar sanchez [mailto:jcesarmob...@gmail.com]
>>> Sent: Tuesday, May 10, 2016 1:14 AM
>>> To: dev@cordova.apache.org
>>> Subject: Re: [DISCUSS] Cordova tools release
>>> 
>>> +1
>>> 
>>> El martes, 10 de mayo de 2016, Shazron  escribió:
>>> 
 +1
 
 On Mon, May 9, 2016 at 12:32 PM, Steven Gill >>> > wrote:
 
> Any objections or concerns?
> 
> Doing a cli, lib, plugman, common and fetch release.
> 
> -Steve
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: Reorganized the config files and split...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/105#issuecomment-218884515
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova tools release

[Steven Gill]

Excellent! I shall proceed.

The website will also get updated when I do the release blog post.

Cheers,
-Steve

On Thu, May 12, 2016 at 12:52 PM, Mefire O.  wrote:

> Hey Steve,
> Telemetry has been merged in!
> We can move forward with the release process.
>
> We'll also have to initiate a docs/website release, as they host our
> privacy policy.
> Raghav will help with that.
>
> Thanks for your patience, All.
>
> Thanks,
> Omar Mefire
>
> -Original Message-
> From: Mefire O. [mailto:ommen...@microsoft.com]
> Sent: Tuesday, May 10, 2016 5:25 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Cordova tools release
>
> I expect it to be merged in by tomorrow EOD or day Thursday morning.
> If it's still not merged in by then, I wouldn't want to hold the release
> any longer.
>
> Thanks,
> Omar Mefire
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Tuesday, May 10, 2016 2:39 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova tools release
>
> When do you expect to merge it in?
>
> On Tue, May 10, 2016 at 2:19 PM, Mefire O.  wrote:
>
> > I'd like to get the telemetry feature out with this release.
> >
> > Thanks,
> > Omar Mefire
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Tuesday, May 10, 2016 12:47 AM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Cordova tools release
> >
> > +1
> >
> > Thanks for handling cordova-common release - there is probably not
> > much sense in releasing it separately (as I was planning initially)
> > when other components also need to be released.
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: julio cesar sanchez [mailto:jcesarmob...@gmail.com]
> > Sent: Tuesday, May 10, 2016 1:14 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova tools release
> >
> > +1
> >
> > El martes, 10 de mayo de 2016, Shazron  escribió:
> >
> > > +1
> > >
> > > On Mon, May 9, 2016 at 12:32 PM, Steven Gill  > > > wrote:
> > >
> > > > Any objections or concerns?
> > > >
> > > > Doing a cli, lib, plugman, common and fetch release.
> > > >
> > > > -Steve
> > > >
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

[GitHub] cordova-medic pull request: Reorganized the config files and split...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-medic/pull/105#issuecomment-218884348
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: Reorganized the config files and split...

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-medic/pull/105

Reorganized the config files and split them for periodic and pr

@rakatyal @riknoll @omefire @nikhilkh Can you please review and merge this 
PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-medic UpdatedConfigs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105


commit e9cad54836fc18c0d088f95952deb9b5971f7679
Author: Sarangan Rajamanickam 
Date:   2016-05-12T20:57:27Z

Reorganized the config files and split them for periodic and pr




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Improving Windows build output and v...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-windows/pull/176#issuecomment-218882039
  
:shipit:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Improving Windows build output and v...

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/176#discussion_r63094515
  
--- Diff: template/cordova/lib/build.js ---
@@ -171,11 +171,11 @@ function parseAndValidateArgs(options) {
 
 // Validate args
 if (options.debug && options.release) {
-throw new CordovaError('Only one of "debug"/"release" options 
should be specified');
+throw new CordovaError('Cannot specify "debug" and "release" 
options together. Please only use one');
--- End diff --

Nit: Error messages generally shouldn't say "please". I think you can omit 
this sentence anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: Improving Android build output and v...

[jasongin]

Github user jasongin commented on the pull request:

https://github.com/apache/cordova-android/pull/305#issuecomment-218880614
  
:shipit:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Improving prepare and build output

[jasongin]

Github user jasongin commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/439#discussion_r63092520
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -286,7 +286,7 @@ module.exports = function plugin(command, targets, 
opts) {
 var configXml = new 
ConfigParser(configPath);
 configXml.removePlugin(target);
 configXml.write();
-events.emit('results', 'config.xml 
entry for ' +target+ ' is removed');
+events.emit('results', 'config.xml 
entry for plugin ' + target + ' was removed');
--- End diff --

What is the 'results' channel??

There is a similar log line for removing a platform from config.xml, only 
it comes before the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova tools release

[Mefire O .]

Hey Steve,
Telemetry has been merged in!
We can move forward with the release process.

We'll also have to initiate a docs/website release, as they host our privacy 
policy.
Raghav will help with that.

Thanks for your patience, All.

Thanks,
Omar Mefire

-Original Message-
From: Mefire O. [mailto:ommen...@microsoft.com] 
Sent: Tuesday, May 10, 2016 5:25 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova tools release

I expect it to be merged in by tomorrow EOD or day Thursday morning.
If it's still not merged in by then, I wouldn't want to hold the release any 
longer.

Thanks,
Omar Mefire

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, May 10, 2016 2:39 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova tools release

When do you expect to merge it in?

On Tue, May 10, 2016 at 2:19 PM, Mefire O.  wrote:

> I'd like to get the telemetry feature out with this release.
>
> Thanks,
> Omar Mefire
>
> -Original Message-
> From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> Sent: Tuesday, May 10, 2016 12:47 AM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Cordova tools release
>
> +1
>
> Thanks for handling cordova-common release - there is probably not 
> much sense in releasing it separately (as I was planning initially) 
> when other components also need to be released.
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: julio cesar sanchez [mailto:jcesarmob...@gmail.com]
> Sent: Tuesday, May 10, 2016 1:14 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova tools release
>
> +1
>
> El martes, 10 de mayo de 2016, Shazron  escribió:
>
> > +1
> >
> > On Mon, May 9, 2016 at 12:32 PM, Steven Gill  > > wrote:
> >
> > > Any objections or concerns?
> > >
> > > Doing a cli, lib, plugman, common and fetch release.
> > >
> > > -Steve
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/247


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218863809
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=mac-slave,platformName=android/artifact/)
5. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/90//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218861698
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218861888
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218852418
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-phone/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=mac-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=mac-slave,platformName=android/artifact/)
5. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=android/testReport/)
 - [Device Logs]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/88//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218849898
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218849660
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-phone/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=mac-slave,platformName=android/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=mac-slave,platformName=android/artifact/)
5. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/87//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218847802
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

[swbradshaw]

Github user swbradshaw commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218847324
  
@JEGardner Well, that's embarrassing. Check it out now and it should work 
for you. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218846731
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-phone/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=mac-slave,platformName=android/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=mac-slave,platformName=android/artifact/)
5. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/86//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218844251
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[cordova-qa]

Github user cordova-qa commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218843937
  
Cordova CI Build has completed successfully. 

**Dashboard** - 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85/

**Results**
1. [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//80/label=windows-slave,platformName=windows-10-store/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-10-store/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-10-store/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-phone/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-phone/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-phone/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [Android Mac]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=mac-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=mac-slave,platformName=android/)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=mac-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=mac-slave,platformName=android/artifact/)
5. [Android Windows]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=android/)
 - [Console Output]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=android/console)
 - [Test Results]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=android/testReport/)
 - [Build Artifacts]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-console/85//label=windows-slave,platformName=android/artifact/)

 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: Dummy Entry

[sarangan12]

Github user sarangan12 commented on the pull request:


https://github.com/apache/cordova-plugin-console/pull/18#issuecomment-218841092
  
Let there be tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63068878
  
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node:true, bitwise:true, undef:true, trailing:true, 
quotmark:true,
+  indent:4, unused:vars, latedef:nofunc,
+  laxcomma:true
+*/
+
+
+
+// For further details on telemetry, see:
+// https://github.com/cordova/cordova-discuss/pull/43
+
+var Q = require('q');
+
+// Google Analytics tracking code
+var GA_TRACKING_CODE = 'UA-64283057-7';
+
+var pkg = require('../package.json');
+var Insight = require('insight');
+var insight = new Insight({
+trackingCode: GA_TRACKING_CODE,
+pkg: pkg
+});
+
+/**
+ * Returns true if the user opted in, and false otherwise
+ */
+function showPrompt() {
+
+var deferred = Q.defer();
+
+var msg = "May Cordova anonymously report usage statistics to improve 
the tool over time?";
+insight.askPermission(msg, function (unused, optIn) {
+var EOL = require('os').EOL;
+if (optIn) {
+console.log(EOL + "Thanks for opting into telemetry to help us 
improve cordova.");
--- End diff --

Updated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63066803
  
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node:true, bitwise:true, undef:true, trailing:true, 
quotmark:true,
+  indent:4, unused:vars, latedef:nofunc,
+  laxcomma:true
+*/
+
+
+
+// For further details on telemetry, see:
+// https://github.com/cordova/cordova-discuss/pull/43
+
+var Q = require('q');
+
+// Google Analytics tracking code
+var GA_TRACKING_CODE = 'UA-64283057-7';
+
+var pkg = require('../package.json');
+var Insight = require('insight');
+var insight = new Insight({
+trackingCode: GA_TRACKING_CODE,
+pkg: pkg
+});
+
+/**
+ * Returns true if the user opted in, and false otherwise
+ */
+function showPrompt() {
+
+var deferred = Q.defer();
+
+var msg = "May Cordova anonymously report usage statistics to improve 
the tool over time?";
+insight.askPermission(msg, function (unused, optIn) {
+var EOL = require('os').EOL;
+if (optIn) {
+console.log(EOL + "Thanks for opting into telemetry to help us 
improve cordova.");
--- End diff --

We can derive this percentage, noo ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63066442
  
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
 Global Commands
 create . Create a project
 help ... Get help for a command
+telemetry .. Turn telemetry collection on or 
off
--- End diff --

Yes, I've already updated it. thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63066156
  
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
 Global Commands
 create . Create a project
 help ... Get help for a command
+telemetry .. Turn telemetry collection on or 
off
--- End diff --

They live in doc/readme.md.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218834713
  
Sounds good to me to proceed then, it was a random idea


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63065751
  
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
 Global Commands
 create . Create a project
 help ... Get help for a command
+telemetry .. Turn telemetry collection on or 
off
--- End diff --

Hmm, I thought it was generated from these files. Anyway, it's been updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update SQLite plugin details

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/600


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Improving Windows build output and v...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-windows/pull/176

Improving Windows build output and verbose logging

Improving grammar, consistency of language, detail, etc. for verbose and 
regular output. Also made to more closely match the output of the Android 
platform (see also https://github.com/apache/cordova-android/pull/305).

Part of the ongoing effort mentioned in 
https://github.com/apache/cordova-lib/pull/439

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows better-output

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #176


commit 1b197e920ef359ee00124b170fb3c04dbefa
Author: Richard Knoll 
Date:   2016-05-12T00:38:18Z

Beginnings of output improvement




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...

[rakatyal]

Github user rakatyal commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/101#issuecomment-218829510
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218826259
  
I first wanted to go that route, but I then realized doing it in CLI 
minimizes polluting LIB for a functionality that's not intended to be used by 
downstream tools. It seems cleaner to handle it here, as mentioned by 
@purplecabbage 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

[macdonst]

Github user macdonst commented on the pull request:

https://github.com/apache/cordova-lib/pull/432#issuecomment-218824969
  
@stevengill it was working pretty good last I checked. With the config.xml 
stuff in it should be ready to go. I've earmarked some time tomorrow to do my 
testing. cc: @ktop 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Enable thirdparty cookie...

[bradleyjames]

Github user bradleyjames commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/165#issuecomment-218823372
  
Looks like this is enabling them by default, right?  Being an app owner I'd 
prefer to be in control of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63056874
  
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+/* jshint node:true, bitwise:true, undef:true, trailing:true, 
quotmark:true,
+  indent:4, unused:vars, latedef:nofunc,
+  laxcomma:true
+*/
+
+
+
+// For further details on telemetry, see:
+// https://github.com/cordova/cordova-discuss/pull/43
+
+var Q = require('q');
+
+// Google Analytics tracking code
+var GA_TRACKING_CODE = 'UA-64283057-7';
+
+var pkg = require('../package.json');
+var Insight = require('insight');
+var insight = new Insight({
+trackingCode: GA_TRACKING_CODE,
+pkg: pkg
+});
+
+/**
+ * Returns true if the user opted in, and false otherwise
+ */
+function showPrompt() {
+
+var deferred = Q.defer();
+
+var msg = "May Cordova anonymously report usage statistics to improve 
the tool over time?";
+insight.askPermission(msg, function (unused, optIn) {
+var EOL = require('os').EOL;
+if (optIn) {
+console.log(EOL + "Thanks for opting into telemetry to help us 
improve cordova.");
--- End diff --

Perhaps we should log opt-ins too. It will help us determine opt-in % 
easily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/247#discussion_r63056532
  
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
 Global Commands
 create . Create a project
 help ... Get help for a command
+telemetry .. Turn telemetry collection on or 
off
--- End diff --

The CLI reference docs need an update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-5195][CB-4078]: correctOri...

[JEGardner]

Github user JEGardner commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218812059
  
This didn't compile for me.

See error:


:compileArmv7DebugJavaWithJavac/Users/jackg/Sites/bibendum/plonk/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:931:
 error: cannot find symbol
rotate = 
exifToDegrees(exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, 
ExifInterface.ORIENTATION_UNDEFINED));
 ^
  symbol:   method exifToDegrees(int)
  location: class CameraLauncher
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 
/Users/jackg/Sites/bibendum/plonk/platforms/android/src/org/apache/cordova/file/AssetFilesystem.java
 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileArmv7DebugJavaWithJavac'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218808479
  
Other CLIs that use lib (as a lib) would not want this code. Off by default 
is interesting, but I think this is cleaner, and it's done. 

> On May 12, 2016, at 3:12 AM, Carlos Santana  
wrote:
> 
> I have one question, maybe I missed it in discussion why is this 
implemented in CLI and not LIB
> 
> I think it make more sense to implement in the top level of API entry 
points in LIB like create platform plugin etc.
> 
> In LIB will be disable by default
> CLI will call API with new parameter to enable telemetry 
> CLI telemetry will
> Be enable by default and CLI will offer user a CLI flag and env to 
disable telemetry
> 
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Enable thirdparty cookie...

[cmeredith]

Github user cmeredith commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/165#issuecomment-218802239
  
+1 and THANK YOU! Fix works perfectly!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/101#issuecomment-218784365
  
@rakatyal, addressed, please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-labs/pull/13#issuecomment-218773090
  
@riknoll, could you please update the server so that 
https://github.com/apache/cordova-plugin-file-transfer/pull/141 could be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-labs/pull/13#issuecomment-218772052
  
Merged in 
https://github.com/apache/cordova-labs/commit/b10c5dbe731a30eb4f5af93631684eccd18c45f4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-10974 Cordova file transfer Content-...

[daserge]

Github user daserge closed the pull request at:

https://github.com/apache/cordova-labs/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-11156 Change default ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/99


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-11156 Change default FadeSplashSc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/170


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Telemetry

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-cli/pull/247#issuecomment-218715695
  
I have one question, maybe I missed it in discussion why is this 
implemented in CLI and not LIB

I think it make more sense to implement in the top level of API entry 
points in LIB like create platform plugin etc. 

In LIB will be disable by default
CLI will call API with new parameter to enable telemetry 
CLI telemetry will
Be enable by default and CLI will offer user a CLI flag and env to disable 
telemetry 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-11250 Fix CLI tests verifying the ver...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/249


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update SQLite plugin details

[brodybits]

Github user brodybits commented on the pull request:

https://github.com/apache/cordova-docs/pull/600#issuecomment-218708663
  
The updates look good to me, thanks!

FYI I dropped the Cordova engine constraint on Cordova-sqlite-storage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

[david-barth-canonical]

Github user david-barth-canonical closed the pull request at:

https://github.com/apache/cordova-plugin-battery-status/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/35

CB-11256 (was Fix due to Qt SystemInfo API updates)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-plugin-battery-status 
fix-systeminfo-api-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 515b4ca6e9d9bafe378874968081b3f3f9dd7cb3
Author: Alexandre Abreu 
Date:   2016-05-09T16:10:50Z

Fix due to Qt SystemInfo API updates




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova Monthly Hangouts

[Shazron]

+1

On Wed, May 11, 2016 at 12:50 PM, Steven Gill 
wrote:

> A hangout sounds good. We need to pick a date and time. Should I send out a
> doodle?
>
> For me personally, I won't be able to attend until the first week of June
> due to PGDAY EU travels.
>
> On Tue, May 10, 2016 at 11:55 AM, Parashuram N 
> wrote:
>
> > It has been a while since all of us met, so I was wondering if it would
> > help to do a Cordova Monthly hangout ? I also understand that we have
> > Phonegap day EU this month, and maybe we could use that timeframe to get
> > more folks involved in the hangout ? For the rest of us who could not
> > attend Phonegap day EU, we could do the hangount. It may also help other
> > community members see how we do hangouts, and may be a way to encourage
> > them to participate even more ?
> >
> > I was thinking that we could discuss some of the following topics
> >
> >
> > 1.   Cordova Telemetry work that Mefire is working on - driving that
> > to a Closure, and ensuring that all developers and toolsmiths are good
> with
> > the proposal and the data we collect
> >
> > 2.   Talk about our Bug Tirage bar, look at ways to reduce
> outstanding
> > bug count and look at the work around running tests on every PR
> >
> > 3.   Follow up on the idea of a Cordova Roadmap
> >
> > Any other ideas ? I could start a Cordova discuss.
> >
>

[GitHub] cordova-plugin-file-transfer pull request: Insert Content-Type to ...

[Belkar]

Github user Belkar commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/139#issuecomment-218685783
  
Could you please merge this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org