[GitHub] cordova-plugin-battery-status issue #38: CB-11256: (ubuntu) Qt API change br...
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/38 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #174: CB-3360 Fix Oxide version & support ...
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/174 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #610: CB 11328 - Ubuntu platform documentation upd...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/610 CB 11328 - Ubuntu platform documentation update Update the platform guide to reflect the status as of cordova-ubuntu@4.3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs CB-11328 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/610.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #610 commit 013903be2af809d47c5b64dbd1232c61dbbdd06f Author: David Barth Date: 2016-06-01T16:00:23Z update plugin support information for Ubuntu commit b5d73b795a4d3167359bdd4324410b9684a2 Author: David Barth Date: 2016-06-01T16:00:54Z Update of the Ubuntu platform guide commit a7390bcb5194e394f41fdb07653fcbb7d7115600 Author: David Barth Date: 2016-06-01T16:07:00Z typos commit 725248cf5bd023a043360fad4e75534592721c11 Author: David Barth Date: 2016-06-02T09:30:47Z add details on debugging and publishing an app for Ubuntu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Cordova Ubuntu 4.3.4 release announceme...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/607 Cordova Ubuntu 4.3.4 release announcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs cordova-ubuntu-4.3.4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/607.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #607 commit 159a63941af3c12fe52c77cb876b67e2109965b4 Author: David Barth Date: 2016-05-26T14:08:08Z Cordova Ubuntu 4.3.4 release announcement --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-docs/pull/497#issuecomment-221223223 Yeah, probably. I'll redo an announcement for 4.3.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-docs/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/35 CB-11256 (was Fix due to Qt SystemInfo API updates) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-plugin-battery-status fix-systeminfo-api-update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 515b4ca6e9d9bafe378874968081b3f3f9dd7cb3 Author: Alexandre Abreu Date: 2016-05-09T16:10:50Z Fix due to Qt SystemInfo API updates --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/438 Fix plugin platform_www & cordova_plugins.json copy You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-lib fix-cordova-plugins-copy Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/438.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #438 commit b6ad96ffd5ef88b3c3d5fb5a0a689ae1a40cc8df Author: Alexandre Abreu Date: 2016-05-09T13:21:23Z Fix plugin platform_www & cordova_plugins.json copy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/497 Add Cordova Ubuntu 4.3.3 blog post Blog post to announce cordova-ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-docs cordova-ubuntu-4.3.3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/497.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #497 commit caafe227cc02b6a0b33187054f43f41c2adba716 Author: David Barth Date: 2016-02-09T16:17:13Z Add Cordova Ubuntu 4.3.3 blog post --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/21 Set of fixes for Cordova-Ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ubuntu/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 8136602f23a004cf5dc7c80aeffbc4d7ca8f6159 Author: Peter Bakondy Date: 2016-01-20T10:07:54Z fix typo commit 31ba4b18ca7c8abac37962ecfa0cd310bc4a3288 Author: david-barth-canonical Date: 2016-01-20T11:02:03Z Merge pull request #7 from pbakondy/master fix typo commit 0c2c3e222d9e2b2928d92fa2dc8fafb0bb89f1a3 Author: Alexandre Abreu Date: 2016-01-26T16:25:39Z Fix reliance on deprecated Oxide's onLoadingChanged signal commit 876674b37167524dbd0ad9100e45504d5632dff8 Author: david-barth-canonical Date: 2016-01-26T18:47:47Z Merge pull request #8 from AlexandreAbreu/fix-loading-changed Fix reliance on deprecated Oxide's onLoadingChanged signal commit af17a8628613d70368cbf5e53f48e732f12c9cb2 Author: Alexandre Abreu Date: 2016-01-26T21:17:25Z Fix debugging enabled flag & remove webkit specific bit commit 827212f339cc75ec25b1078c7355f3152763bbfa Author: david-barth-canonical Date: 2016-01-27T08:42:30Z Merge pull request #9 from AlexandreAbreu/fix-devtools Fix debugging enabled flag & remove webkit specific bit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.2 blog post
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/452 Add Cordova Ubuntu 4.3.2 blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs cordova-ubuntu-4.3.2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/452.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #452 commit cc5aa1e7ed2ae9c3f3e51e2af98f5f045dd3ee03 Author: David Barth Date: 2016-01-08T10:41:33Z Add Cordova Ubuntu 4.3.2 blog post --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: CB-10119 - Can't install click chroot...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/20 CB-10119 - Can't install click chroot 14.10 Fix for CB-10119, switching the default framework to 15.04 Also a fix for check_reqs which was referencing a function that has been removed since. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu 4.3.2-pre Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ubuntu/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 9a10c78bb75ec7c5a9175d960803f4c265ae92ef Author: David Barth Date: 2015-11-19T08:30:04Z Set VERSION to 4.4.0-dev (via coho) commit 178832e268b6cb66f16e02ce718063692d6893b3 Author: David Barth Date: 2015-11-19T15:31:24Z fix for update script commit 4efeff2c275709ff617c8d68c05ab5a187f24f91 Author: David Barth Date: 2015-11-19T15:31:24Z add www sub-directory to let the unit tests run properly (cherry picked from commit 0f97fd32eaadcc03e918c9598205125ec215b492) commit 2700423ec06c146800e1c58c1bda770320b3b1f3 Author: David Barth Date: 2015-11-24T10:57:58Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-ubuntu commit d9456a90e1b2824b0059ceecaff65b3b316e20cd Author: Alexandre Abreu Date: 2015-12-07T21:30:55Z Fix nodejs deps install which refers to an invalid ubuntu deps check function commit 418947792d573812a3056092221f39ea99dfddf6 Author: David Barth Date: 2015-12-09T13:44:40Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-ubuntu commit 15141640f16ae94657de652d1a478c0a571b8e46 Author: David Barth Date: 2015-12-11T16:00:12Z CB-10119 - default framework upgraded to 15.04 commit cc2cec984b188269f7a0d2fa4dfb487a36124d6c Author: David Barth Date: 2015-12-11T16:07:24Z update RELEASENOTES commit e854a04b553767e0f6625ba61e83e90a64f5bc97 Author: david-barth-canonical Date: 2015-12-11T16:17:10Z Merge pull request #6 from AlexandreAbreu/fix-build-ubuntu-deps Fix nodejs deps install which refers to an invalid ubuntu deps check ⦠commit 70c5c51eec3cdcbb90948d3509a143f058b501d2 Author: David Barth Date: 2015-12-11T16:19:23Z update RELEASENOTES --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...
Github user david-barth-canonical commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/349#discussion_r46569876
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
}).join('');
}
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+ var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+ if (platform) {
+ var param =
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+ if (param && param.attrib) {
+ class_name = param.attrib.value;
+ return class_name;
+ }
+ }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+ match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
+if (match && match.length > 0)
+ class_name = match[0].substr(15);
+ else
+class_name = toCamelCase(class_name);
+}
+
+return class_name;
+}
--- End diff --
There is a new PR at https://github.com/apache/cordova-lib/pull/349 with
your suggested fixes. Thanks for the review.
On Thu, Dec 3, 2015 at 12:45 AM, Tim Barham
wrote:
> In cordova-lib/src/plugman/platforms/ubuntu.js
> <https://github.com/apache/cordova-lib/pull/349#discussion_r46494465>:
>
> > +// fallback to guess work, based on the plugin package name
> > +
> > +if (plugin_id.match(/\.[^.]+$/)) {
> > +// old-style plugin name
> > +class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
> > +class_name = toCamelCase(class_name);
> > +} else {
> > + match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
> > +if (match && match.length > 0)
> > + class_name = match[0].substr(15);
> > + else
> > +class_name = toCamelCase(class_name);
> > +}
> > +
> > +return class_name;
> > +}
>
> Thanks @david-barth-canonical <https://github.com/david-barth-canonical>!
> Some comments:
>
>- Generally the Cordova codebase uses curly braces even around single
>line blocks.
>- There are some tabs in there that should be converted to spaces.
>- The match variable needs a var.
>- Should be calling toCamelCase() for the scenario where we match
>cordova-plugin-...
>- Where we don't match cordova-plugin-..., class_name is not defined
>(should be using plugin_id).
>- Since we will always end up calling toCamelCase(), the logic for the
>second half of this method can be simplified to:
>
> // fallback to guess work, based on the plugin package name
> if (plugin_id.match(/\.[^.]+$/)) {
> // old-style plugin name
> class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
> } else {
> var match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
> if (match && match.length > 0) {
> class_name = match[0].substr(15);
> } else {
> class_name = plugin_id;
> }
> }
>
> return toCamelCase(class_name);
>
> Also, since the original PR has been merged, can you recreate this as a
> new PR which will just include the changes in your last commit (and
changes
> in response to feedback, of course).
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-lib/pull/349/files#r46494465>.
>
---
If your project is set up for it, you can reply to this email and have your
repl
[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...
Github user david-barth-canonical commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/294#discussion_r46471716
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
}).join('');
}
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+ var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+ if (platform) {
+ var param =
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+ if (param && param.attrib) {
+ class_name = param.attrib.value;
+ return class_name;
+ }
+ }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+class_name =
plugin_id.match(/cordova\-plugin\-([\w\-]+)$/)[0].substr(15);
--- End diff --
Thanks! I updated the branch to take that into account. I was forcing
plugins to upgrade to adding their class name to the XML file, but there is a
more gradual way ;)
If that PR can't be re-opened I opened
https://github.com/apache/cordova-lib/pull/349 . Otherwise feel free to close
this other one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/349 Cb 9590 - Ubuntu support for the new plugin naming convention Re-opening the pull request with hopefully a better fix that can handle all situations. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9590 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #349 commit 187711dd7fb7cd21e9ea276239b2e8b87a9e1ee6 Author: David Barth Date: 2015-09-01T17:40:35Z Ubuntu support for the new plugin naming convention commit afde15c7e6748dfedbdd9816df199c14f2f7596e Author: David Barth Date: 2015-09-04T11:41:13Z more robust class name detection commit 1ae6a8631a92f58020c3b0139931d784843c281e Author: David Barth Date: 2015-11-03T17:13:49Z take plugin class name from the plugin.xml to avoid class name guess work commit 1bbf544f3f3cff709d9ee1618b585d4c57e8e62c Author: David Barth Date: 2015-11-19T17:00:35Z happier jshint commit 877404bbcb2d84cbb9cade8e692396237cc586f3 Author: David Barth Date: 2015-12-02T20:18:28Z don't crash when parsing general plugin names --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9618 - Icon parameter should not be r...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/347 Cb 9618 - Icon parameter should not be relative to the www directory on Ubuntu This patch fixes a long standing issue, whereby the icon parameter in the app manifest was prefixed with a www directory while it is not in other parts of the tools or runtime. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9618 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #347 commit 4aa92493c36fef07415a0d0e6690464b2d21bd51 Author: David Barth Date: 2015-09-07T15:38:27Z change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore commit 67d2950d6106eaba031ece18b45cf4f8dea96f21 Author: David Barth Date: 2015-09-23T10:50:05Z sync icon path lookup with the code in the manifest generation commit 704c13d8616be9036bbcce25238ecd1a3f6731b1 Author: David Barth Date: 2015-10-02T13:38:36Z don't add a leading www to the icon path when generating the desktop file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: Cordova-Ubuntu Platform Release 4.3.1...
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-ubuntu/pull/19
Cordova-Ubuntu Platform Release 4.3.1
From the RELEASENOTES.md
* default icon name www/img/logo.png
* add defaut icon parameter to config.xml
* use QUrl::fromLocalFile()
* set mainUrl when the file exists
* fix critical issue introduced by general URL support changes earlier
* check if content src points to a url or local file
* fix typo
* better info msg
* don't check deps at create time and propose to auto-install once at build
time; this is for the native/desktop build
See release preparation logs at
https://issues.apache.org/jira/browse/CB-10030
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu 4.3.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ubuntu/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
commit d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
Author: Alberto Mardegan
Date: 2015-10-08T06:36:31Z
build: fix mechanism for additional dependencies
Instead of expecting plugins to store their configuration files in
a "configs/" directory, read the dependencies from the config.xml file.
The reason why the old method does not work is that the
element of the plugin.xml file doesn't support a "target-dir" attribute.
By using the element, instead, we don't need to do any
changes to cordova lib, and all the plugin configuration can now be
stored in the plugin.xml file.
Example:
["signond", "libsignon-qt5"]
["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]
commit 576fca86f5bc51df285ad5b3a94332039bf75161
Author: David Barth
Date: 2015-09-30T16:20:19Z
add defaut icon parameter to config.xml
commit 7a5ac6dbc046bb9fd75c5de313723ee90907f7d6
Author: david-barth-canonical
Date: 2015-10-27T11:24:55Z
Merge pull request #1 from mardy/additional-dependencies
build: fix mechanism for additional plugin dependencies
commit 33f61c7fb7d2370c907beec51a604026b62a57ea
Author: David Barth
Date: 2015-10-28T14:30:39Z
default icon name www/img/logo.png
commit aaf201b289119f498866b4dbc16e6c581b15c2ac
Author: David Barth
Date: 2015-11-12T16:42:04Z
Merge branch 'master' of
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu
commit 75819c8186476c7d7534e6e19c6faebecd7fc9cd
Author: David Barth
Date: 2015-09-30T14:51:05Z
check if content src points to a url or local file
commit 86e994affa1d7406295952bfac2d2af634485d2c
Author: David Barth
Date: 2015-11-12T15:07:06Z
fix critical issue introduced by general URL support changes earlier
commit ac27c286c124776c2c4b938ccf86f2beaa20ac7e
Author: David Barth
Date: 2015-11-12T16:02:26Z
set mainUrl when the file exists
commit 6fe31e7cb0568bee263cdf4c39c829f9e9bf4c97
Author: David Barth
Date: 2015-10-28T18:50:38Z
don't check deps at create time and propose to auto-install once at build
time; this is for the native/desktop build
commit 8eeea8d71dabfa43bbaab240ecf666d1e89efa88
Author: David Barth
Date: 2015-11-12T15:06:16Z
better info msg
commit eea201221e2cc2cdaef06a9187f4c7f0a8af754d
Author: David Barth
Date: 2015-11-18T10:29:12Z
Merge remote-tracking branch 'apache/master'
commit 91f655d03047583919582e841fb51c1f0df1ff63
Author: David Barth
Date: 2015-11-18T11:19:02Z
Set VERSION to 4.4.0-dev (via coho)
commit 63d740326f2191de3bf568a06d8013395733ca2c
Author: David Barth
Date: 2015-11-18T11:19:04Z
Update JS snapshot to version 4.4.0-dev (via coho)
commit 6630211fd507766176b2f1a1ba9a7619339a486a
Author: David Barth
Date: 2015-11-18T13:51:34Z
fix typo
commit 51f8f3ce5204beb731d0ea8c708c9c0c533232c1
Author: david-barth-canonical
Date: 2015-11-18T13:52:56Z
Merge pull request #4 from cordova-ubuntu/CB-9868
Cb 9868 - Should propose to install missing Ubuntu dependencies on platform
add
commit cf5bbb6343aab3f0662550554c580bc464dc95d2
Author: David Barth
Date: 2015-11-18T13:56:36Z
use QUrl::fromLocalFile()
commit e4a3c9e363b9d0ecda7536cc9b18342e3dfa1ab3
Author: david-barth-canonical
Date: 2015-11-18T13:57:26Z
Merge pull request #3 from cordova-ubuntu/CB-9694
Cb 9694 - Add support for HTTP urls
commit 346d43905e1fe498d74f374e0b6cb1c10e0aa5d9
Author: david-barth-canonical
Date: 2015-11-18T13:57:44Z
Merge pull request #2 from cordova-ubuntu/CB-9806
Cb 9806 - Add icon to project defaults
commit 5cca7ca72c65882053266d22023fb7a9cf8194a1
Author: David
[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls
GitHub user david-barth-canonical opened a pull request:
https://github.com/apache/cordova-ubuntu/pull/18
Cb 9694 - Add support for HTTP urls
The cordova-ubuntu container currently does not support loading the app
from a network URL, only local file URLs. This prevents features like
livereloading to work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB-9694
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ubuntu/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
commit d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
Author: Alberto Mardegan
Date: 2015-10-08T06:36:31Z
build: fix mechanism for additional dependencies
Instead of expecting plugins to store their configuration files in
a "configs/" directory, read the dependencies from the config.xml file.
The reason why the old method does not work is that the
element of the plugin.xml file doesn't support a "target-dir" attribute.
By using the element, instead, we don't need to do any
changes to cordova lib, and all the plugin configuration can now be
stored in the plugin.xml file.
Example:
["signond", "libsignon-qt5"]
["signond-dev:ARCH", "libsignon-qt5-dev:ARCH"]
commit 7a5ac6dbc046bb9fd75c5de313723ee90907f7d6
Author: david-barth-canonical
Date: 2015-10-27T11:24:55Z
Merge pull request #1 from mardy/additional-dependencies
build: fix mechanism for additional plugin dependencies
commit aaf201b289119f498866b4dbc16e6c581b15c2ac
Author: David Barth
Date: 2015-11-12T16:42:04Z
Merge branch 'master' of
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu
commit 43e1c34f377d888599968cd42ee06751de09568b
Author: David Barth
Date: 2015-09-30T14:51:05Z
check if content src points to a url or local file
commit 429971412c5903665942861552f3906a1f31ba71
Author: David Barth
Date: 2015-11-12T15:07:06Z
fix critical issue introduced by general URL support changes earlier
commit 606cc331d5dc9410906ef3ddc7818555005834f0
Author: David Barth
Date: 2015-11-12T16:02:26Z
set mainUrl when the file exists
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: check if content src points to a url ...
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772 I have update the pull request to add support for taking the class name from the plugin.xml file. For plugins using one of the 2 existing naming conventions, we can fallback to "guess work", otherwise new plugins using arbitrary names can just specify the 'package-ubuntu' parameter (like iOS or Android) to specify the class name directly. I decided to go ahead and keep on adding code to the cordova-lib for now, but will start adding support for that preparation step in cordova-ubuntu direclty. In 2 steps, I imagine we can migrate core plugins to using the new parameter and deprecate the specific code from the ubuntu/install stage in cordova-lib eventually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...
Github user david-barth-canonical commented on the pull request:
https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166
ok, i understand the problem now. In particular, the code to guess the
classname is nice, but other platforms resort to encapsulating this
information into the plugin.xml file which is safer.
We have some new code in cordova-ubuntu to handle dependencies, so I wonder
how much of that logic needs to be updated in cordova-lib, rather than
directly in cordova-ubuntu? See mardy's new branch
https://github.com/mardy/cordova-ubuntu/commit/d3a674f2a07ab269bfb2e2acaa60dc2ab25c4d50
On Thu, Oct 15, 2015 at 6:26 PM, Tim Barham
wrote:
> @david-barth-canonical <https://github.com/david-barth-canonical> - I
> think @stevengill <https://github.com/stevengill>'s point is that the
> intent of your change is to strip the cordova-plugin from the start of
> the plugin name to generate the class name, to get the equivalent of the
> old functionality. That logic won't work with plugins that don't start
with
> cordova-plugin-. Perhaps an alternative would be to look for -plugin- in
> the name, and take everything after that (?otherwise just use the whole
> name).
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-lib/pull/294#issuecomment-148444797>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/16 add defaut icon parameter to config.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB-9806 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ubuntu/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 576fca86f5bc51df285ad5b3a94332039bf75161 Author: David Barth Date: 2015-09-30T16:20:19Z add defaut icon parameter to config.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148342742 It does work on my system at least. I run this branch along with my other 3 pull requests, but I don't think they have an influence on the plugin installation process. dbarth@thinkmac:~/devel/wily/cordova/demo$ cordova -d plugin add phonegap-plugin-push no version specified, retrieving version from config.xml Calling plugman.fetch on plugin "phonegap-plugin-push" Fetching plugin "phonegap-plugin-push" via npm Copying plugin "/home/dbarth/.npm/phonegap-plugin-push/1.3.0/package" => "/home/dbarth/devel/wily/cordova/demo/plugins/phonegap-plugin-push" Calling plugman.install on plugin "/home/dbarth/devel/wily/cordova/demo/plugins/phonegap-plugin-push" for platform "ubuntu Installing "phonegap-plugin-push" for ubuntu Running command: /home/dbarth/devel/wily/cordova/demo/platforms/ubuntu/cordova/version Command finished with error code 0: /home/dbarth/devel/wily/cordova/demo/platforms/ubuntu/cordova/version cordova has been detected as using a development branch. Attemping to install anyways. Install start for "phonegap-plugin-push" on ubuntu. Beginning processing of action stack for ubuntu project... Action stack processing complete. Install complete for phonegap-plugin-push on ubuntu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: check if content src points to a url ...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/14 check if content src points to a url or local file You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB-9694 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ubuntu/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit aa53b6652f56fbfcbc824140aee6457174316c15 Author: David Barth Date: 2015-09-30T14:51:05Z check if content src points to a url or local file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: icon parameter should not be relative to...
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241 Yes, makes sense. Icon management needs more tweaks, but this way it will work better already Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: icon parameter should not be relative to...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/299 icon parameter should not be relative to the www directory on Ubuntu You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9618 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/299.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #299 commit 4aa92493c36fef07415a0d0e6690464b2d21bd51 Author: David Barth Date: 2015-09-07T15:38:27Z change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9618
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9618
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/298 Cb 9618 Patch to change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9618 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #298 commit 187711dd7fb7cd21e9ea276239b2e8b87a9e1ee6 Author: David Barth Date: 2015-09-01T17:40:35Z Ubuntu support for the new plugin naming convention commit afde15c7e6748dfedbdd9816df199c14f2f7596e Author: David Barth Date: 2015-09-04T11:41:13Z more robust class name detection commit dcd77f3778a9755c7bd826a70eb084527fdcb028 Author: David Barth Date: 2015-09-07T15:23:22Z change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-138310314 It does work both with old style plugin names, like "org.apache.cordova.battery-status" and new style names "cordova-plugin-media-capture". I can add and build a demo application with the 2 of those here on my system. The facebookconnect plugin failed compilation in my tests, but it seems more due to the absence of ubuntu platform support code. If there are still issues, can you give an example or a log of where it fails? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/294 CB-9590 - Ubuntu support for the new plugin naming convention This patch allows ubuntu users to add plugins using the new naming convention and build properly. This also leaves support in place for the old style plugin names, during the transition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9590 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/294.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #294 commit 187711dd7fb7cd21e9ea276239b2e8b87a9e1ee6 Author: David Barth Date: 2015-09-01T17:40:35Z Ubuntu support for the new plugin naming convention --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
