[VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
Please review and vote on the following packages for release by replying to this email (and keep discussion on the DISCUSS thread): - cordova-eslint v4.0.0 - cordova-app-hello-world v6.0.0 The archives has been published to the dist/dev: - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ <https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/ <https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/> The packages was published from its corresponding git tag: cordova-eslint: 4.0.0 (d0f055c8f8) cordova-app-hello-world: 6.0.0 (8430b5cfe9) Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Ensured the continuous build was green when repo was tagged * Ran `npm test` * Ran `npm audit` * Ran `cordova create`
[ANNOUNCE] cordova-plugin-geolocation, cordova-create, cordova-app-hello-world released!
Tweet: https://twitter.com/apachecordova/status/783739548962390016 Blog: http://cordova.apache.org/news/2016/10/04/small-releases.html
Re: [GitHub] cordova-app-hello-world pull request: CB-6185 Spelling: explicitly
I can't find the other emails which should have been generated for this pull request. https://issues.apache.org/jira/browse/CB-6185 Anyone know why it wasn't automatically closed by Github.com? [https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452]ASF subversion and git services<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jira-bot> added a comment - 12/Mar/14 17:01 Commit c5d5db79d1c51a9fd2d5080556b3b4c2ef1a76e4 in cordova-app-hello-world's branch refs/heads/master from Josh Soref<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jsoref> [ https://git-wip-us.apache.org/repos/asf?p=cordova-app-hello-world.git;h=c5d5db7 ] CB-6185<https://issues.apache.org/jira/browse/CB-6185> Spelling: explicitly github: close #7 <https://issues.apache.org/jira/browse/CB-6185#> <https://issues.apache.org/jira/browse/CB-6185?focusedCommentId=13932367&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13932367> [https://issues.apache.org/jira/secure/useravatar?size=xsmall&ownerId=cmarcelk&avatarId=16144]Marcel Kinard<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cmarcelk> added a comment - 12/Mar/14 17:01 Pull request merged. <https://issues.apache.org/jira/browse/CB-6185#> <https://issues.apache.org/jira/browse/CB-6185?focusedCommentId=13934983&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13934983> [https://issues.apache.org/jira/secure/useravatar?size=xsmall&avatarId=10452]ASF GitHub Bot<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added a comment - 8 minutes ago Github user bryanhiggins commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/7#issuecomment-37645634 This has already been merged Sent from my BlackBerry 10 smartphone on the Bell network. From: AnneTheAgile Sent: Tuesday, March 11, 2014 5:17 PM To: dev@cordova.apache.org Reply To: dev@cordova.apache.org Subject: [GitHub] cordova-app-hello-world pull request: CB-6185 Spelling: explicitly Github user AnneTheAgile commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/7#issuecomment-37351154 This should be component Documentation. The patch is; - // function, we must explicity call 'app.receivedEvent(...);' + // function, we must explicitly call 'app.receivedEvent(...);' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
Please review and vote on this 3.5.0 cordova-js, cordova-mobile-spec & cordova-app-hello-world Releases. Release issue: https://issues.apache.org/jira/browse/CB-6586 Repos ready to be released have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-6586/final The packages were published from the corresponding git tags: cordova-js: 3.5.0 (adac080201) cordova-mobile-spec: 3.5.0 (001c40) cordova-app-hello-world: 3.5.0 (9e10bc2d28) Upon a successful vote I will upload the archives to dist/, publish them to NPM (where applicable), and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Verified archive * Ensured continuous build was green when repos were tagged
[DISCUSS] cordova-eslint 4.0.0 major & cordova-app-hello-world 6.0.0 major Release
Does anyone have any reason to delay a major release for the following packages? - cordova-eslint@4.0.0 - cordova-app-hello-world@6.0.0 Any additional outstanding changes to land? If not, I will proceed with the release by tomorrow. == Changes == - https://github.com/apache/cordova-eslint/compare/rel/3.0.0...master <https://github.com/apache/cordova-eslint/compare/rel/3.0.0...master> - https://github.com/apache/cordova-app-hello-world/compare/rel/5.0.0...master <https://github.com/apache/cordova-app-hello-world/compare/rel/5.0.0...master>
Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
+1 - ran coho verify-archive - review of commits - CI green On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: > Please review and vote on the following packages for release by replying > to this email (and keep discussion on the DISCUSS thread): > > - cordova-eslint v4.0.0 > - cordova-app-hello-world v6.0.0 > > The archives has been published to the dist/dev: > > - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < > https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> > - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/ < > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/> > > The packages was published from its corresponding git tag: > > cordova-eslint: 4.0.0 (d0f055c8f8) > cordova-app-hello-world: 6.0.0 (8430b5cfe9) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and sub-dependencies > have Apache-compatible licenses > * Ensured the continuous build was green when repo was tagged > * Ran `npm test` > * Ran `npm audit` > * Ran `cordova create`
Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
I vote +1 I checked: - hash and signature - tags - no audit issues - releasenotes - local tests pass - no license header issues On October 29, 2021, Jesse wrote: > +1 > > - ran coho verify-archive > - review of commits > - CI green > > > On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: > > > Please review and vote on the following packages for release by > replying > > to this email (and keep discussion on the DISCUSS thread): > > > > - cordova-eslint v4.0.0 > > - cordova-app-hello-world v6.0.0 > > > > The archives has been published to the dist/dev: > > > > - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < > > https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> > > - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- > 6.0.0/ < > > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- > 6.0.0/> > > > > The packages was published from its corresponding git tag: > > > > cordova-eslint: 4.0.0 (d0f055c8f8) > > cordova-app-hello-world: 6.0.0 (8430b5cfe9) > > > > Upon a successful vote I will upload the archive to dist/, publish > it to > > npm, and post the blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release- > voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and sub- > dependencies > > have Apache-compatible licenses > > * Ensured the continuous build was green when repo was tagged > > * Ran `npm test` > > * Ran `npm audit` > > * Ran `cordova create`
Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Jesse MacFadyen * Niklas Merz Negative Binding Votes: 0 The vote has passed. Thanks everyone! > On Oct 29, 2021, at 3:33 PM, Niklas Merz wrote: > > I vote +1 > > I checked: > > - hash and signature > - tags > - no audit issues > - releasenotes > - local tests pass > - no license header issues > > On October 29, 2021, Jesse wrote: >> +1 >> >> - ran coho verify-archive >> - review of commits >> - CI green >> >> >> On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: >> >>> Please review and vote on the following packages for release by >> replying >>> to this email (and keep discussion on the DISCUSS thread): >>> >>> - cordova-eslint v4.0.0 >>> - cordova-app-hello-world v6.0.0 >>> >>> The archives has been published to the dist/dev: >>> >>> - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < >>> https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> >>> - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- >> 6.0.0/ < >>> https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- >> 6.0.0/> >>> >>> The packages was published from its corresponding git tag: >>> >>> cordova-eslint: 4.0.0 (d0f055c8f8) >>> cordova-app-hello-world: 6.0.0 (8430b5cfe9) >>> >>> Upon a successful vote I will upload the archive to dist/, publish >> it to >>> npm, and post the blog post. >>> >>> Voting guidelines: >>> https://github.com/apache/cordova-coho/blob/master/docs/release- >> voting.md >>> >>> Voting will go on for a minimum of 48 hours. >>> >>> I vote +1: >>> >>> * Ran coho audit-license-headers over the relevant repos >>> * Ran coho check-license to ensure all dependencies and sub- >> dependencies >>> have Apache-compatible licenses >>> * Ensured the continuous build was green when repo was tagged >>> * Ran `npm test` >>> * Ran `npm audit` >>> * Ran `cordova create` - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DRAFT] release blog post for create, app-hello-world and geolocation plugin.
https://github.com/apache/cordova-docs/pull/647
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
Bump. Not sure if this needs to be voted + released on. Thoughts? We don't need to put any of this on dist. On Wed, May 14, 2014 at 1:26 PM, Steven Gill wrote: > Please review and vote on this 3.5.0 cordova-js, cordova-mobile-spec & > cordova-app-hello-world Releases. > > Release issue: https://issues.apache.org/jira/browse/CB-6586 > > Repos ready to be released have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-6586/final > > The packages were published from the corresponding git tags: > cordova-js: 3.5.0 (adac080201) > cordova-mobile-spec: 3.5.0 (001c40) > cordova-app-hello-world: 3.5.0 (9e10bc2d28) > > Upon a successful vote I will upload the archives to dist/, publish them > to NPM (where applicable), and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Verified archive > * Ensured continuous build was green when repos were tagged >
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
cordova-app-hello-world gets dynamically fetched via git when a new project is created, so IMHO it does get distributed even though it’s not the usual channel. So I’d suggest that the distribution process should apply for it (vote + post to dist). cordova-mobile-spec isn’t used by anyone except Cordova developers, so it makes sense to not distribute nor vote on that. The output artifacts of cordova-js are replicated in the platforms, so I could see an argument being made that it’s already covered in the platforms. On May 21, 2014, at 3:35 PM, Steven Gill wrote: > Bump. Not sure if this needs to be voted + released on. Thoughts? We don't > need to put any of this on dist.
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
+1 for cordova-app-hello-world, then :) On Wed, May 21, 2014 at 3:53 PM, Marcel Kinard wrote: > cordova-app-hello-world gets dynamically fetched via git when a new > project is created, so IMHO it does get distributed even though it’s not > the usual channel. So I’d suggest that the distribution process should > apply for it (vote + post to dist). > > cordova-mobile-spec isn’t used by anyone except Cordova developers, so it > makes sense to not distribute nor vote on that. > > The output artifacts of cordova-js are replicated in the platforms, so I > could see an argument being made that it’s already covered in the platforms. > > On May 21, 2014, at 3:35 PM, Steven Gill wrote: > > > Bump. Not sure if this needs to be voted + released on. Thoughts? We > don't > > need to put any of this on dist. > >
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
+1 for cordova-app-hello-world only no need for cordova-js and cordova-mobile-spec as Marcel's comments. On Wed, May 21, 2014 at 4:01 PM, Ian Clelland wrote: > +1 for cordova-app-hello-world, then :) > > > On Wed, May 21, 2014 at 3:53 PM, Marcel Kinard wrote: > > > cordova-app-hello-world gets dynamically fetched via git when a new > > project is created, so IMHO it does get distributed even though it’s not > > the usual channel. So I’d suggest that the distribution process should > > apply for it (vote + post to dist). > > > > cordova-mobile-spec isn’t used by anyone except Cordova developers, so it > > makes sense to not distribute nor vote on that. > > > > The output artifacts of cordova-js are replicated in the platforms, so I > > could see an argument being made that it’s already covered in the > platforms. > > > > On May 21, 2014, at 3:35 PM, Steven Gill wrote: > > > > > Bump. Not sure if this needs to be voted + released on. Thoughts? We > > don't > > > need to put any of this on dist. > > > > > -- Carlos Santana
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
I agree! I'm going to take those +1s as votes for app-hello-world On May 21, 2014 1:27 PM, "Carlos Santana" wrote: > +1 for cordova-app-hello-world only > no need for cordova-js and cordova-mobile-spec as Marcel's comments. > > > > On Wed, May 21, 2014 at 4:01 PM, Ian Clelland >wrote: > > > +1 for cordova-app-hello-world, then :) > > > > > > On Wed, May 21, 2014 at 3:53 PM, Marcel Kinard > wrote: > > > > > cordova-app-hello-world gets dynamically fetched via git when a new > > > project is created, so IMHO it does get distributed even though it's > not > > > the usual channel. So I'd suggest that the distribution process should > > > apply for it (vote + post to dist). > > > > > > cordova-mobile-spec isn't used by anyone except Cordova developers, so > it > > > makes sense to not distribute nor vote on that. > > > > > > The output artifacts of cordova-js are replicated in the platforms, so > I > > > could see an argument being made that it's already covered in the > > platforms. > > > > > > On May 21, 2014, at 3:35 PM, Steven Gill > wrote: > > > > > > > Bump. Not sure if this needs to be voted + released on. Thoughts? We > > > don't > > > > need to put any of this on dist. > > > > > > > > > > > > -- > Carlos Santana > >
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
+1 for app-hello-world. Verified hashes, signatures, and content. On May 21, 2014, at 4:46 PM, Steven Gill wrote: > I agree! > > I'm going to take those +1s as votes for app-hello-world
Re: [Vote] 3.5.0 cordova-js, cordova-mobile-spec, & cordova-app-hello-world Release
The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Marcel Kinard Carlos Santana Ian Clelland Negative Binding Votes: 0 The vote has passed. On Wed, May 21, 2014 at 1:59 PM, Marcel Kinard wrote: > +1 for app-hello-world. Verified hashes, signatures, and content. > > On May 21, 2014, at 4:46 PM, Steven Gill wrote: > > > I agree! > > > > I'm going to take those +1s as votes for app-hello-world >
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101026209 @timwindsor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/10 CB-9009 default CSP needs to include 8472 for blackberry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-app-hello-world cb_9009 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit fac9f1c19744e25fdc45b993ff1b53ea4f54cc1c Author: Josh Soref Date: 2015-05-11T19:30:15Z CB-9009 default CSP needs to include 8472 for blackberry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101032363 Works for me - required for use of any plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782 As long as this doesn't negatively impact other platforms, merge away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514 Is this required for development time experience or every app needs access to localhost port 8472 to run on the phone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's just magically intercepted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128833712 -1 hum this looks very ugly in the template. I don't like to have this in the default template. people might think that is a security whole. In another platform like android, not picking android then that port will be expose, it will not get intercepted because is not blackberry some options: 1. bb plugin to implement plugin hook, this is a new type of hook that plugins can implement If this is only required for BlackBerry, then the plugin for blackberry can implement a plugin hook to edit the index.html during after_prepare. it can parse the index.html look for the tag and if http://locahost:8472 doesn't exist then added. 2. the cordova.js for blackberry dynamically edits the csp tag in the dom when cordova.js runs before setting up the plugin update the csp meta, I don't know if this is too late to change since index.html is already parsed, if this is not an option then take a look at option 1 above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128835312 @jengee you don't have to get tired of update the template every time, you can implement a user land cordova hook after_prepare [1] [2] you can have a simple nodejs script or any other type of script, and parse the index.html after being copy to the platform/**/www/ and and check if csp is missing the value that you want "http://localhost:8247"; and added there. having an arbitrary localhost port open in csp, present for a common template will raise an eye brow of concerns for people using it in other platforms than blackberry. [1] http://cordova.apache.org/docs/en/edge/guide_appdev_hooks_index.md.html#Hooks%20Guide [2] http://photokandy.tumblr.com/post/47426024187/cordova-cli-simple-hooks-and-merges --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128885973 Adding this to index.html should be a blackberry build step, I would expect this to only exist in the platform's www folder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-130459377 Thanks everyone - I've got a potential solution that we're testing here. We can close this request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/14 CB-9712 CLI 5.3 breaks with node 3.3.3 Added `index.js` so that the module can be required and resolved. [Jira issue](https://issues.apache.org/jira/browse/CB-9712) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-app-hello-world CB-9712 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit bca1753d09b4d23fc59d1ed35ad4a76028d56fa8 Author: daserge Date: 2015-10-06T10:33:52Z CB-9712 CLI 5.3 breaks with node 3.3.3 Added blank index.js so that module can be required and resolved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user omefire commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146660710 I think we should also update package.json to explicitly mention the entry point (index.js) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user daserge commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146835675 @omefire, thank you for review, I've addressed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146869382 LGTM :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user omefire commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146967713 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/15 CB-10522: Event binding in Hello World is misleading The current event binding in the Hello World example is slightly misleading. So, fixing it. @nikhilkh @dblotsky @riknoll @rkatyal Can you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-app-hello-world CB-10522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit a17a3d289a6e1428a34068040563d998faf63fc0 Author: Sarangan Rajamanickam Date: 2016-02-05T19:25:34Z CB-10522: Event binding in Hello World is misleading Fixing the Hello World example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181630866 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181659458 @axemclion Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181673845 Will this also be going out as an email to the dev@ list? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181674386 @dblotsky yes. Definitely needs dev list approval. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user axemclion commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52264119 --- Diff: www/js/index.js --- @@ -19,22 +19,20 @@ var app = { // Application Constructor initialize: function() { -this.bindEvents(); -}, -// Bind Event Listeners -// -// Bind any events that are required on startup. Common events are: -// 'load', 'deviceready', 'offline', and 'online'. -bindEvents: function() { document.addEventListener('deviceready', this.onDeviceReady, false); --- End diff -- Do we wanna do a this.onDeviceReady.bind(this) here ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52271030 --- Diff: www/js/index.js --- @@ -19,22 +19,20 @@ var app = { // Application Constructor initialize: function() { -this.bindEvents(); -}, -// Bind Event Listeners -// -// Bind any events that are required on startup. Common events are: -// 'load', 'deviceready', 'offline', and 'online'. -bindEvents: function() { document.addEventListener('deviceready', this.onDeviceReady, false); --- End diff -- Any variables in `app`'s scope are already in `onDeviceReady`'s scope. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-183448308 @axemclion Can you check now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184856505 LGTM. That third layer of binding always seemed confusing. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184885794 Cool, seems like we've reached a consensus. Merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...
GitHub user brianleroux reopened a pull request: https://github.com/apache/cordova-app-hello-world/pull/5 updated with feedback from cordova crew You can merge this pull request into a Git repository by running: $ git pull https://github.com/brianleroux/cordova-app-hello-world simplified Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 15a22e7745e6719293ebc03182ac0d05b14eefb7 Author: brianleroux Date: 2013-12-09T02:19:04Z distilling to essence of hello world commit 8a069d2e3a7f55775e8f0bf6331ca03ba092a20c Author: brianleroux Date: 2013-12-09T23:51:21Z tweaks from feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...
Github user brianleroux closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...
Github user brianleroux closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10 magic port... Steve Gill commented on the pull request: > As long as this doesn't negatively impact other platforms, merge away. The only downside is that if someone manages to have another application running on that port on a non blackberry platform, and if someone writes a buggy application which can be taken over, then that buggy application could talk to the other application w/ that port on that non blackberry platform it's pretty obscure, but... Are people OK with this? The section we're changing has a bunch of platform specific notes, it seems like it's really asking for a pre-processor of some sort to magically stitch up this field... Does anyone have an alternative proposal? If not, I'm planning to merge my PR on Monday. smime.p7s Description: S/MIME cryptographic signature
Re: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Can we use a plugin hook to modify the csp in the bb10 start html page? localhost is not defined on most platforms afaik, so it may be less of an issue. @purplecabbage risingj.com On Wed, May 13, 2015 at 1:00 PM, Josh Soref wrote: > > https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 > 9782 > > Problem: > As is, today, Cordova projects created w/ the default cordova hello-world > template which have any plugins won't work on BlackBerry 10 at-all > > My fix is to add a CSP whitelist for the BlackBerry 10 magic port... > > Steve Gill commented on the pull request: > > As long as this doesn't negatively impact other platforms, merge > away. > > The only downside is that if someone manages to have another application > running on that port on a non blackberry platform, > and if someone writes a buggy application which can be taken over, > then that buggy application could talk to the other application w/ that > port > on that non blackberry platform > > it's pretty obscure, but... > > Are people OK with this? > > The section we're changing has a bunch of platform specific notes, it seems > like it's really asking for a pre-processor of some sort to magically > stitch > up this field... > > > Does anyone have an alternative proposal? If not, I'm planning to merge my > PR on Monday. >
[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/18 CB-12684 : added package.json to default hello world app ### Platforms affected ### What does this PR do? Added package.json to default hello world app. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-app-hello-world CB-12684 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit c61f6a54efe754d5e4177131aa388d4027b5d419 Author: Audrey So Date: 2017-04-21T23:20:51Z CB-12684 : added package.json to default hello world app --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-app-hello-world/pull/18#discussion_r113055741 --- Diff: template_src/package.json --- @@ -0,0 +1,11 @@ +{ + "name": "hellocordova", --- End diff -- actually, can we change the name to `io.cordova.hellocordova` and add a new field called `displayName` that equals `HelloCordova` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #19: CB-12397 fix .gitignore for plugin...
GitHub user brodybits opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/19 CB-12397 fix .gitignore for plugins & platforms ### Platforms affected All ### What does this PR do? Add `plugins` and `platforms` to `.gitignore` to resolve [Apache Cordova CB-12397](https://issues.apache.org/jira/browse/CB-12397), now working if properly integrated with apache/cordova-create#8 (workaround solution to [Apache Cordova CB-12397](https://issues.apache.org/jira/browse/CB-12397) in `cordova-create`). ### What testing has been done on this change? As described in <https://github.com/apache/cordova-create/pull/8>: tested using local installation of <https://github.com/brodybits/cordova-cli/tree/cb-12397-devtest1>. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. **NOT RELEVANT in this PR:** - ~~Added automated test coverage as appropriate for this change.~~ You can merge this pull request into a Git repository by running: $ git pull https://github.com/brodybits/cordova-app-hello-world cb-12397 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit f7c85137256e050856e8fe9341ed3b2ba0c319f1 Author: Christopher J. Brody Date: 2017-05-09T13:11:49Z CB-12397 fix .gitignore for plugins & platforms --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/16 CB-11412 Update templates to designate template source dir You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-app-hello-world master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 513d01060ebc31d660cbae5ac21642a9e90386a1 Author: carynbear Date: 2016-06-15T20:15:14Z CB-11412 Update templates to designate template source dir --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets update version in the default config.xml to be 1.0.0 instead of 0.0.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets not add a `package.json` to template_src for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 LGTM otherwise :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user carynbear commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 @stevengill removed package.json from template_src, changed config.xml version to 1.0.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
This came up in the context of whitelist discussion, but wanted to bring it to everyones attention. JIRA: https://issues.apache.org/jira/browse/CB-8597 We would like the default app to support installing the whitelist plugin automatically using the new plugin auto-restore feature (If you disagree, discuss on the whitelist thread, that is not the topic of this post). However, the cordova-lib create script cannot support this feature right now anyway (that is the topic of this post). I've outlined in the JIRA how we could fix that (open to feedback). TLDR; --copy-from already supports this, so lets just vastly simplify cordova-lib create.js to just always do a --copy-from (or --link-to), and change cordova-cli to provide the default --copy-from=./node_modules/cordova-app-hello-world. This also implies we can remove our last use of lazy_load from cordova-lib (minus explicit git clones or platforms/plugins), and npm all the things! It also means a semver MAJOR change to cordova-lib that downstreams directly using cordova-lib's create will need to adjust to. Thoughts? -Michal
[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/17 CB-11938 updated csp to include content: for img-src You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-app-hello-world master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
+1. So on board with this. I'll take a look at your Jira issue later on today. On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: > This came up in the context of whitelist discussion, but wanted to bring it > to everyones attention. > > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > We would like the default app to support installing the whitelist plugin > automatically using the new plugin auto-restore feature (If you disagree, > discuss on the whitelist thread, that is not the topic of this post). > > However, the cordova-lib create script cannot support this feature right > now anyway (that is the topic of this post). I've outlined in the JIRA how > we could fix that (open to feedback). > > TLDR; --copy-from already supports this, so lets just vastly simplify > cordova-lib create.js to just always do a --copy-from (or --link-to), and > change cordova-cli to provide the default > --copy-from=./node_modules/cordova-app-hello-world. > > This also implies we can remove our last use of lazy_load from cordova-lib > (minus explicit git clones or platforms/plugins), and npm all the things! > > It also means a semver MAJOR change to cordova-lib that downstreams > directly using cordova-lib's create will need to adjust to. > > Thoughts? > > -Michal >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
+1 Does this affect the ability to use an individual platform? ie. cordova-ios/bin/create ... Will platform create scripts need to change? @purplecabbage risingj.com On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: > This came up in the context of whitelist discussion, but wanted to bring it > to everyones attention. > > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > We would like the default app to support installing the whitelist plugin > automatically using the new plugin auto-restore feature (If you disagree, > discuss on the whitelist thread, that is not the topic of this post). > > However, the cordova-lib create script cannot support this feature right > now anyway (that is the topic of this post). I've outlined in the JIRA how > we could fix that (open to feedback). > > TLDR; --copy-from already supports this, so lets just vastly simplify > cordova-lib create.js to just always do a --copy-from (or --link-to), and > change cordova-cli to provide the default > --copy-from=./node_modules/cordova-app-hello-world. > > This also implies we can remove our last use of lazy_load from cordova-lib > (minus explicit git clones or platforms/plugins), and npm all the things! > > It also means a semver MAJOR change to cordova-lib that downstreams > directly using cordova-lib's create will need to adjust to. > > Thoughts? > > -Michal >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Jesse, I think not. The platform scripts just copy the bundled www/ (its already included with the platform). This is only for the top-level project www/ of a cordova-cli project. I guess, though, that we could consider changing the platform create scripts to import config.xml's, since they currently do not. This may be difficult given that the format is different even though the name is the same (platform vs project config). -Michal On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > +1 > Does this affect the ability to use an individual platform? > ie. cordova-ios/bin/create ... > Will platform create scripts need to change? > > > > @purplecabbage > risingj.com > > On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: > > > This came up in the context of whitelist discussion, but wanted to bring > it > > to everyones attention. > > > > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > > > We would like the default app to support installing the whitelist plugin > > automatically using the new plugin auto-restore feature (If you disagree, > > discuss on the whitelist thread, that is not the topic of this post). > > > > However, the cordova-lib create script cannot support this feature right > > now anyway (that is the topic of this post). I've outlined in the JIRA > how > > we could fix that (open to feedback). > > > > TLDR; --copy-from already supports this, so lets just vastly simplify > > cordova-lib create.js to just always do a --copy-from (or --link-to), and > > change cordova-cli to provide the default > > --copy-from=./node_modules/cordova-app-hello-world. > > > > This also implies we can remove our last use of lazy_load from > cordova-lib > > (minus explicit git clones or platforms/plugins), and npm all the things! > > > > It also means a semver MAJOR change to cordova-lib that downstreams > > directly using cordova-lib's create will need to adjust to. > > > > Thoughts? > > > > -Michal > > >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Pushed first attempt to remote branches: - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world - https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world Cleaning up cordova-lib is strictly required, though I think we should still take the opportunity to do so. On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > Jesse, I think not. The platform scripts just copy the bundled www/ (its > already included with the platform). > > This is only for the top-level project www/ of a cordova-cli project. > > I guess, though, that we could consider changing the platform create > scripts to import config.xml's, since they currently do not. This may be > difficult given that the format is different even though the name is the > same (platform vs project config). > > -Michal > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > >> +1 >> Does this affect the ability to use an individual platform? >> ie. cordova-ios/bin/create ... >> Will platform create scripts need to change? >> >> >> >> @purplecabbage >> risingj.com >> >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: >> >> > This came up in the context of whitelist discussion, but wanted to >> bring it >> > to everyones attention. >> > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 >> > >> > We would like the default app to support installing the whitelist plugin >> > automatically using the new plugin auto-restore feature (If you >> disagree, >> > discuss on the whitelist thread, that is not the topic of this post). >> > >> > However, the cordova-lib create script cannot support this feature right >> > now anyway (that is the topic of this post). I've outlined in the JIRA >> how >> > we could fix that (open to feedback). >> > >> > TLDR; --copy-from already supports this, so lets just vastly simplify >> > cordova-lib create.js to just always do a --copy-from (or --link-to), >> and >> > change cordova-cli to provide the default >> > --copy-from=./node_modules/cordova-app-hello-world. >> > >> > This also implies we can remove our last use of lazy_load from >> cordova-lib >> > (minus explicit git clones or platforms/plugins), and npm all the >> things! >> > >> > It also means a semver MAJOR change to cordova-lib that downstreams >> > directly using cordova-lib's create will need to adjust to. >> > >> > Thoughts? >> > >> > -Michal >> > >> > >
RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
I like moving this to npm because Apache Git as a distribution mechanism for the hello world app has been less reliable than desirable in the past. Thanks, Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Tuesday, March 3, 2015 12:08 PM To: Michal Mocny Cc: dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Pushed first attempt to remote branches: - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world - https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world Cleaning up cordova-lib is strictly required, though I think we should still take the opportunity to do so. On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > Jesse, I think not. The platform scripts just copy the bundled www/ > (its already included with the platform). > > This is only for the top-level project www/ of a cordova-cli project. > > I guess, though, that we could consider changing the platform create > scripts to import config.xml's, since they currently do not. This may > be difficult given that the format is different even though the name > is the same (platform vs project config). > > -Michal > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > >> +1 >> Does this affect the ability to use an individual platform? >> ie. cordova-ios/bin/create ... >> Will platform create scripts need to change? >> >> >> >> @purplecabbage >> risingj.com >> >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: >> >> > This came up in the context of whitelist discussion, but wanted to >> bring it >> > to everyones attention. >> > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 >> > >> > We would like the default app to support installing the whitelist >> > plugin automatically using the new plugin auto-restore feature (If >> > you >> disagree, >> > discuss on the whitelist thread, that is not the topic of this post). >> > >> > However, the cordova-lib create script cannot support this feature >> > right now anyway (that is the topic of this post). I've outlined >> > in the JIRA >> how >> > we could fix that (open to feedback). >> > >> > TLDR; --copy-from already supports this, so lets just vastly >> > simplify cordova-lib create.js to just always do a --copy-from (or >> > --link-to), >> and >> > change cordova-cli to provide the default >> > --copy-from=./node_modules/cordova-app-hello-world. >> > >> > This also implies we can remove our last use of lazy_load from >> cordova-lib >> > (minus explicit git clones or platforms/plugins), and npm all the >> things! >> > >> > It also means a semver MAJOR change to cordova-lib that downstreams >> > directly using cordova-lib's create will need to adjust to. >> > >> > Thoughts? >> > >> > -Michal >> > >> > >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if you develop a downstream distribution that uses cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this out and see if it works for you. I will do so for cca. Please forward this to anyone on your team responsible for this work! -Michal On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal wrote: > I like moving this to npm because Apache Git as a distribution mechanism > for the hello world app has been less reliable than desirable in the past. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Tuesday, March 3, 2015 12:08 PM > To: Michal Mocny > Cc: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Pushed first attempt to remote branches: > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > - > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world > > Cleaning up cordova-lib is strictly required, though I think we should > still take the opportunity to do so. > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > (its already included with the platform). > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > I guess, though, that we could consider changing the platform create > > scripts to import config.xml's, since they currently do not. This may > > be difficult given that the format is different even though the name > > is the same (platform vs project config). > > > > -Michal > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > > > >> +1 > >> Does this affect the ability to use an individual platform? > >> ie. cordova-ios/bin/create ... > >> Will platform create scripts need to change? > >> > >> > >> > >> @purplecabbage > >> risingj.com > >> > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > wrote: > >> > >> > This came up in the context of whitelist discussion, but wanted to > >> bring it > >> > to everyones attention. > >> > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > >> > > >> > We would like the default app to support installing the whitelist > >> > plugin automatically using the new plugin auto-restore feature (If > >> > you > >> disagree, > >> > discuss on the whitelist thread, that is not the topic of this post). > >> > > >> > However, the cordova-lib create script cannot support this feature > >> > right now anyway (that is the topic of this post). I've outlined > >> > in the JIRA > >> how > >> > we could fix that (open to feedback). > >> > > >> > TLDR; --copy-from already supports this, so lets just vastly > >> > simplify cordova-lib create.js to just always do a --copy-from (or > >> > --link-to), > >> and > >> > change cordova-cli to provide the default > >> > --copy-from=./node_modules/cordova-app-hello-world. > >> > > >> > This also implies we can remove our last use of lazy_load from > >> cordova-lib > >> > (minus explicit git clones or platforms/plugins), and npm all the > >> things! > >> > > >> > It also means a semver MAJOR change to cordova-lib that downstreams > >> > directly using cordova-lib's create will need to adjust to. > >> > > >> > Thoughts? > >> > > >> > -Michal > >> > > >> > > > > >
RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Michal: I'm new to this area - can you please elaborate why this change could potentially break downstream distributions? IS there an API change? -Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Thursday, March 5, 2015 1:12 PM To: dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if you develop a downstream distribution that uses cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this out and see if it works for you. I will do so for cca. Please forward this to anyone on your team responsible for this work! -Michal On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal wrote: > I like moving this to npm because Apache Git as a distribution > mechanism for the hello world app has been less reliable than desirable in > the past. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Tuesday, March 3, 2015 12:08 PM > To: Michal Mocny > Cc: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Pushed first attempt to remote branches: > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > - > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > ello-world > > Cleaning up cordova-lib is strictly required, though I think we should > still take the opportunity to do so. > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > (its already included with the platform). > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > I guess, though, that we could consider changing the platform create > > scripts to import config.xml's, since they currently do not. This > > may be difficult given that the format is different even though the > > name is the same (platform vs project config). > > > > -Michal > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > > > >> +1 > >> Does this affect the ability to use an individual platform? > >> ie. cordova-ios/bin/create ... > >> Will platform create scripts need to change? > >> > >> > >> > >> @purplecabbage > >> risingj.com > >> > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > wrote: > >> > >> > This came up in the context of whitelist discussion, but wanted > >> > to > >> bring it > >> > to everyones attention. > >> > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > >> > > >> > We would like the default app to support installing the whitelist > >> > plugin automatically using the new plugin auto-restore feature > >> > (If you > >> disagree, > >> > discuss on the whitelist thread, that is not the topic of this post). > >> > > >> > However, the cordova-lib create script cannot support this > >> > feature right now anyway (that is the topic of this post). I've > >> > outlined in the JIRA > >> how > >> > we could fix that (open to feedback). > >> > > >> > TLDR; --copy-from already supports this, so lets just vastly > >> > simplify cordova-lib create.js to just always do a --copy-from > >> > (or --link-to), > >> and > >> > change cordova-cli to provide the default > >> > --copy-from=./node_modules/cordova-app-hello-world. > >> > > >> > This also implies we can remove our last use of lazy_load from > >> cordova-lib > >> > (minus explicit git clones or platforms/plugins), and npm all the > >> things! > >> > > >> > It also means a semver MAJOR change to cordova-lib that > >> > downstreams directly using cordova-lib's create will need to adjust to. > >> > > >> > Thoughts? > >> > > >> > -Michal > >> > > >> > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
The current breaking change is that you cannot create a new project using cordova-lib directly, without providing a project template to import from. cordova-cli works as it always has, and will provide the app-hello-world as a default if you do not use --copy-from / --link-to. However, writing that explanation out now, I realize I could just change cordova-lib to be the one to depend on cordova-app-hello-world and do the defaulting there, and not break compatibility. I think I originally envisioned the cordova-lib script to be more "primitive", but its already doing a tremendous amount of input handling and backwards compat workarounds. Probably I can just make this adjustment. -Michal On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal wrote: > Michal: I'm new to this area - can you please elaborate why this change > could potentially break downstream distributions? IS there an API change? > > -Nikhil > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Thursday, March 5, 2015 1:12 PM > To: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Alight, remote branches (named copy-from-app-hello-world) are created for > cordova-lib, cordova-cli, and cordova-app-hello-world. > > There are still 2 failing cordova-lib tests, but I'm working to resolve > that. My actual end-to-end tests appear to be working with all use cases. > > Please, please: if you develop a downstream distribution that uses > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this > out and see if it works for you. I will do so for cca. Please forward > this to anyone on your team responsible for this work! > > -Michal > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal > wrote: > > > I like moving this to npm because Apache Git as a distribution > > mechanism for the hello world app has been less reliable than desirable > in the past. > > > > Thanks, > > Nikhil > > > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Tuesday, March 3, 2015 12:08 PM > > To: Michal Mocny > > Cc: dev > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > adding as dependency of cordova-lib > > > > Pushed first attempt to remote branches: > > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > > - > > > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > > ello-world > > > > Cleaning up cordova-lib is strictly required, though I think we should > > still take the opportunity to do so. > > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny > wrote: > > > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > > (its already included with the platform). > > > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > > > I guess, though, that we could consider changing the platform create > > > scripts to import config.xml's, since they currently do not. This > > > may be difficult given that the format is different even though the > > > name is the same (platform vs project config). > > > > > > -Michal > > > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > > > > > >> +1 > > >> Does this affect the ability to use an individual platform? > > >> ie. cordova-ios/bin/create ... > > >> Will platform create scripts need to change? > > >> > > >> > > >> > > >> @purplecabbage > > >> risingj.com > > >> > > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > > wrote: > > >> > > >> > This came up in the context of whitelist discussion, but wanted > > >> > to > > >> bring it > > >> > to everyones attention. > > >> > > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > >> > > > >> > We would like the default app to support installing the whitelist > > >> > plugin automatically using the new plugin auto-restore feature > > >> > (If you > > >> disagree, > > >> > discuss on the whitelist thread, that is not the topic of this > post). > > >> > > > >> > However, the cordova-lib create script cannot support this > > >> > feature right
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Can we move the config.xml template out of cordova-lib/templates and into app-hello-world as a part of this? On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny wrote: > The current breaking change is that you cannot create a new project using > cordova-lib directly, without providing a project template to import from. > cordova-cli works as it always has, and will provide the app-hello-world > as a default if you do not use --copy-from / --link-to. > > However, writing that explanation out now, I realize I could just change > cordova-lib to be the one to depend on cordova-app-hello-world and do the > defaulting there, and not break compatibility. I think I originally > envisioned the cordova-lib script to be more "primitive", but its already > doing a tremendous amount of input handling and backwards compat > workarounds. Probably I can just make this adjustment. > > -Michal > > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal > wrote: > > > Michal: I'm new to this area - can you please elaborate why this change > > could potentially break downstream distributions? IS there an API change? > > > > -Nikhil > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Thursday, March 5, 2015 1:12 PM > > To: dev > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > adding as dependency of cordova-lib > > > > Alight, remote branches (named copy-from-app-hello-world) are created for > > cordova-lib, cordova-cli, and cordova-app-hello-world. > > > > There are still 2 failing cordova-lib tests, but I'm working to resolve > > that. My actual end-to-end tests appear to be working with all use > cases. > > > > Please, please: if you develop a downstream distribution that uses > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this > > out and see if it works for you. I will do so for cca. Please forward > > this to anyone on your team responsible for this work! > > > > -Michal > > > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < > nikhi...@microsoft.com> > > wrote: > > > > > I like moving this to npm because Apache Git as a distribution > > > mechanism for the hello world app has been less reliable than desirable > > in the past. > > > > > > Thanks, > > > Nikhil > > > > > > > > > -Original Message- > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > > Mocny > > > Sent: Tuesday, March 3, 2015 12:08 PM > > > To: Michal Mocny > > > Cc: dev > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > > adding as dependency of cordova-lib > > > > > > Pushed first attempt to remote branches: > > > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > > > - > > > > > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > > > ello-world > > > > > > Cleaning up cordova-lib is strictly required, though I think we should > > > still take the opportunity to do so. > > > > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny > > wrote: > > > > > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > > > (its already included with the platform). > > > > > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > > > > > I guess, though, that we could consider changing the platform create > > > > scripts to import config.xml's, since they currently do not. This > > > > may be difficult given that the format is different even though the > > > > name is the same (platform vs project config). > > > > > > > > -Michal > > > > > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse > wrote: > > > > > > > >> +1 > > > >> Does this affect the ability to use an individual platform? > > > >> ie. cordova-ios/bin/create ... > > > >> Will platform create scripts need to change? > > > >> > > > >> > > > >> > > > >> @purplecabbage > > > >> risingj.com > > > >> > > > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > > > wrote: > > > >> > > > >> > This came up in the context of whitelist discussion, but wanted
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
I wanted to originally, but you can --copy-from a www/ only (no config.xml), and then we need a template. If I change cordova-lib to depend on app-hello-world then we can remove it. Another reason to do so. -Michal On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve wrote: > Can we move the config.xml template out of cordova-lib/templates and into > app-hello-world as a part of this? > > On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny wrote: > > > The current breaking change is that you cannot create a new project using > > cordova-lib directly, without providing a project template to import > from. > > cordova-cli works as it always has, and will provide the app-hello-world > > as a default if you do not use --copy-from / --link-to. > > > > However, writing that explanation out now, I realize I could just change > > cordova-lib to be the one to depend on cordova-app-hello-world and do the > > defaulting there, and not break compatibility. I think I originally > > envisioned the cordova-lib script to be more "primitive", but its already > > doing a tremendous amount of input handling and backwards compat > > workarounds. Probably I can just make this adjustment. > > > > -Michal > > > > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < > nikhi...@microsoft.com> > > wrote: > > > > > Michal: I'm new to this area - can you please elaborate why this > change > > > could potentially break downstream distributions? IS there an API > change? > > > > > > -Nikhil > > > > > > -Original Message- > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > > Mocny > > > Sent: Thursday, March 5, 2015 1:12 PM > > > To: dev > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > > adding as dependency of cordova-lib > > > > > > Alight, remote branches (named copy-from-app-hello-world) are created > for > > > cordova-lib, cordova-cli, and cordova-app-hello-world. > > > > > > There are still 2 failing cordova-lib tests, but I'm working to resolve > > > that. My actual end-to-end tests appear to be working with all use > > cases. > > > > > > Please, please: if you develop a downstream distribution that uses > > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try > this > > > out and see if it works for you. I will do so for cca. Please forward > > > this to anyone on your team responsible for this work! > > > > > > -Michal > > > > > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < > > nikhi...@microsoft.com> > > > wrote: > > > > > > > I like moving this to npm because Apache Git as a distribution > > > > mechanism for the hello world app has been less reliable than > desirable > > > in the past. > > > > > > > > Thanks, > > > > Nikhil > > > > > > > > > > > > -Original Message- > > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of > Michal > > > > Mocny > > > > Sent: Tuesday, March 3, 2015 12:08 PM > > > > To: Michal Mocny > > > > Cc: dev > > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > > > adding as dependency of cordova-lib > > > > > > > > Pushed first attempt to remote branches: > > > > - > https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > > > > - > > > > > > > > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > > > > ello-world > > > > > > > > Cleaning up cordova-lib is strictly required, though I think we > should > > > > still take the opportunity to do so. > > > > > > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny > > > wrote: > > > > > > > > > Jesse, I think not. The platform scripts just copy the bundled > www/ > > > > > (its already included with the platform). > > > > > > > > > > This is only for the top-level project www/ of a cordova-cli > project. > > > > > > > > > > I guess, though, that we could consider changing the platform > create > > > > > scripts to import config.xml's, since they currently do not. This > > > > > may be difficult given that the format is different even though the
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Updated as described. Now you no longer need to use the branch of cordova-cli, so I'm pretty sure this is 100% compat. Huzzah. On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny wrote: > I wanted to originally, but you can --copy-from a www/ only (no > config.xml), and then we need a template. If I change cordova-lib to > depend on app-hello-world then we can remove it. Another reason to do so. > > -Michal > > On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve > wrote: > >> Can we move the config.xml template out of cordova-lib/templates and into >> app-hello-world as a part of this? >> >> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny wrote: >> >> > The current breaking change is that you cannot create a new project >> using >> > cordova-lib directly, without providing a project template to import >> from. >> > cordova-cli works as it always has, and will provide the >> app-hello-world >> > as a default if you do not use --copy-from / --link-to. >> > >> > However, writing that explanation out now, I realize I could just change >> > cordova-lib to be the one to depend on cordova-app-hello-world and do >> the >> > defaulting there, and not break compatibility. I think I originally >> > envisioned the cordova-lib script to be more "primitive", but its >> already >> > doing a tremendous amount of input handling and backwards compat >> > workarounds. Probably I can just make this adjustment. >> > >> > -Michal >> > >> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >> nikhi...@microsoft.com> >> > wrote: >> > >> > > Michal: I'm new to this area - can you please elaborate why this >> change >> > > could potentially break downstream distributions? IS there an API >> change? >> > > >> > > -Nikhil >> > > >> > > -----Original Message- >> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >> Michal >> > > Mocny >> > > Sent: Thursday, March 5, 2015 1:12 PM >> > > To: dev >> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >> > > adding as dependency of cordova-lib >> > > >> > > Alight, remote branches (named copy-from-app-hello-world) are created >> for >> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >> > > >> > > There are still 2 failing cordova-lib tests, but I'm working to >> resolve >> > > that. My actual end-to-end tests appear to be working with all use >> > cases. >> > > >> > > Please, please: if you develop a downstream distribution that uses >> > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try >> this >> > > out and see if it works for you. I will do so for cca. Please >> forward >> > > this to anyone on your team responsible for this work! >> > > >> > > -Michal >> > > >> > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < >> > nikhi...@microsoft.com> >> > > wrote: >> > > >> > > > I like moving this to npm because Apache Git as a distribution >> > > > mechanism for the hello world app has been less reliable than >> desirable >> > > in the past. >> > > > >> > > > Thanks, >> > > > Nikhil >> > > > >> > > > >> > > > -Original Message- >> > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >> Michal >> > > > Mocny >> > > > Sent: Tuesday, March 3, 2015 12:08 PM >> > > > To: Michal Mocny >> > > > Cc: dev >> > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >> > > > adding as dependency of cordova-lib >> > > > >> > > > Pushed first attempt to remote branches: >> > > > - >> https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world >> > > > - >> > > > >> > > > >> https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h >> > > > ello-world >> > > > >> > > > Cleaning up cordova-lib is strictly required, though I think we >> should >> > > > still take the opportunity to do so. >> > > > >> > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mo
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
(Sorry for all the messages) Fixed all the remaining breaks, and now all tests pass without modification and cordova-cli doesn't need changes. However, there is a new npm dependency on cordova-app-hello-word from cordova-lib. We will need to release that to npm before publishing the next tools release. Steve/Andrew, I will attempt to update coho etc, but I'm not sure of all the places to update release instructions for this new thing, nor am I sure of all the licensing requirements. Care to advise / help? Thanks! -Michal On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny wrote: > Updated as described. > > Now you no longer need to use the branch of cordova-cli, so I'm pretty > sure this is 100% compat. Huzzah. > > On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny wrote: > >> I wanted to originally, but you can --copy-from a www/ only (no >> config.xml), and then we need a template. If I change cordova-lib to >> depend on app-hello-world then we can remove it. Another reason to do so. >> >> -Michal >> >> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >> wrote: >> >>> Can we move the config.xml template out of cordova-lib/templates and into >>> app-hello-world as a part of this? >>> >>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>> wrote: >>> >>> > The current breaking change is that you cannot create a new project >>> using >>> > cordova-lib directly, without providing a project template to import >>> from. >>> > cordova-cli works as it always has, and will provide the >>> app-hello-world >>> > as a default if you do not use --copy-from / --link-to. >>> > >>> > However, writing that explanation out now, I realize I could just >>> change >>> > cordova-lib to be the one to depend on cordova-app-hello-world and do >>> the >>> > defaulting there, and not break compatibility. I think I originally >>> > envisioned the cordova-lib script to be more "primitive", but its >>> already >>> > doing a tremendous amount of input handling and backwards compat >>> > workarounds. Probably I can just make this adjustment. >>> > >>> > -Michal >>> > >>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>> nikhi...@microsoft.com> >>> > wrote: >>> > >>> > > Michal: I'm new to this area - can you please elaborate why this >>> change >>> > > could potentially break downstream distributions? IS there an API >>> change? >>> > > >>> > > -Nikhil >>> > > >>> > > -Original Message- >>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >>> Michal >>> > > Mocny >>> > > Sent: Thursday, March 5, 2015 1:12 PM >>> > > To: dev >>> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >>> > > adding as dependency of cordova-lib >>> > > >>> > > Alight, remote branches (named copy-from-app-hello-world) are >>> created for >>> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >>> > > >>> > > There are still 2 failing cordova-lib tests, but I'm working to >>> resolve >>> > > that. My actual end-to-end tests appear to be working with all use >>> > cases. >>> > > >>> > > Please, please: if you develop a downstream distribution that uses >>> > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try >>> this >>> > > out and see if it works for you. I will do so for cca. Please >>> forward >>> > > this to anyone on your team responsible for this work! >>> > > >>> > > -Michal >>> > > >>> > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < >>> > nikhi...@microsoft.com> >>> > > wrote: >>> > > >>> > > > I like moving this to npm because Apache Git as a distribution >>> > > > mechanism for the hello world app has been less reliable than >>> desirable >>> > > in the past. >>> > > > >>> > > > Thanks, >>> > > > Nikhil >>> > > > >>> > > > >>> > > > -Original Message- >>> > > > From: mmo...@google.com [mailto:mmo...@google.com] On Beh
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Sure. I can make the changes to release process + coho for it. I imagine it won't be released often, so it might be best give app-hello-world its own release process instead of tying it into tools, platforms or plugins release. On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > (Sorry for all the messages) > > Fixed all the remaining breaks, and now all tests pass without > modification and cordova-cli doesn't need changes. > > However, there is a new npm dependency on cordova-app-hello-word from > cordova-lib. We will need to release that to npm before publishing the > next tools release. > > Steve/Andrew, I will attempt to update coho etc, but I'm not sure of all > the places to update release instructions for this new thing, nor am I sure > of all the licensing requirements. Care to advise / help? > > Thanks! > -Michal > > On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny wrote: > >> Updated as described. >> >> Now you no longer need to use the branch of cordova-cli, so I'm pretty >> sure this is 100% compat. Huzzah. >> >> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny >> wrote: >> >>> I wanted to originally, but you can --copy-from a www/ only (no >>> config.xml), and then we need a template. If I change cordova-lib to >>> depend on app-hello-world then we can remove it. Another reason to do so. >>> >>> -Michal >>> >>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >>> wrote: >>> >>>> Can we move the config.xml template out of cordova-lib/templates and >>>> into >>>> app-hello-world as a part of this? >>>> >>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>>> wrote: >>>> >>>> > The current breaking change is that you cannot create a new project >>>> using >>>> > cordova-lib directly, without providing a project template to import >>>> from. >>>> > cordova-cli works as it always has, and will provide the >>>> app-hello-world >>>> > as a default if you do not use --copy-from / --link-to. >>>> > >>>> > However, writing that explanation out now, I realize I could just >>>> change >>>> > cordova-lib to be the one to depend on cordova-app-hello-world and do >>>> the >>>> > defaulting there, and not break compatibility. I think I originally >>>> > envisioned the cordova-lib script to be more "primitive", but its >>>> already >>>> > doing a tremendous amount of input handling and backwards compat >>>> > workarounds. Probably I can just make this adjustment. >>>> > >>>> > -Michal >>>> > >>>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>>> nikhi...@microsoft.com> >>>> > wrote: >>>> > >>>> > > Michal: I'm new to this area - can you please elaborate why this >>>> change >>>> > > could potentially break downstream distributions? IS there an API >>>> change? >>>> > > >>>> > > -Nikhil >>>> > > >>>> > > -Original Message- >>>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >>>> Michal >>>> > > Mocny >>>> > > Sent: Thursday, March 5, 2015 1:12 PM >>>> > > To: dev >>>> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >>>> > > adding as dependency of cordova-lib >>>> > > >>>> > > Alight, remote branches (named copy-from-app-hello-world) are >>>> created for >>>> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >>>> > > >>>> > > There are still 2 failing cordova-lib tests, but I'm working to >>>> resolve >>>> > > that. My actual end-to-end tests appear to be working with all use >>>> > cases. >>>> > > >>>> > > Please, please: if you develop a downstream distribution that uses >>>> > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try >>>> this >>>> > > out and see if it works for you. I will do so for cca. Please >>>> forward >>>> > > this to anyone on your team responsible for this work! >>>> > > >>>> > > -Michal >>>>
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Agreed. Everything is upstream on the branch. The package.json wasn't fully thought out, so please peak at it. Ping me if you need anything, I'll rebase cordova-lib and move to master when you are done. Thanks Steve. On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill wrote: > Sure. I can make the changes to release process + coho for it. > > I imagine it won't be released often, so it might be best give > app-hello-world its own release process instead of tying it into tools, > platforms or plugins release. > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > >> (Sorry for all the messages) >> >> Fixed all the remaining breaks, and now all tests pass without >> modification and cordova-cli doesn't need changes. >> >> However, there is a new npm dependency on cordova-app-hello-word from >> cordova-lib. We will need to release that to npm before publishing the >> next tools release. >> >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of all >> the places to update release instructions for this new thing, nor am I sure >> of all the licensing requirements. Care to advise / help? >> >> Thanks! >> -Michal >> >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny >> wrote: >> >>> Updated as described. >>> >>> Now you no longer need to use the branch of cordova-cli, so I'm pretty >>> sure this is 100% compat. Huzzah. >>> >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny >>> wrote: >>> >>>> I wanted to originally, but you can --copy-from a www/ only (no >>>> config.xml), and then we need a template. If I change cordova-lib to >>>> depend on app-hello-world then we can remove it. Another reason to do so. >>>> >>>> -Michal >>>> >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >>>> wrote: >>>> >>>>> Can we move the config.xml template out of cordova-lib/templates and >>>>> into >>>>> app-hello-world as a part of this? >>>>> >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>>>> wrote: >>>>> >>>>> > The current breaking change is that you cannot create a new project >>>>> using >>>>> > cordova-lib directly, without providing a project template to import >>>>> from. >>>>> > cordova-cli works as it always has, and will provide the >>>>> app-hello-world >>>>> > as a default if you do not use --copy-from / --link-to. >>>>> > >>>>> > However, writing that explanation out now, I realize I could just >>>>> change >>>>> > cordova-lib to be the one to depend on cordova-app-hello-world and >>>>> do the >>>>> > defaulting there, and not break compatibility. I think I originally >>>>> > envisioned the cordova-lib script to be more "primitive", but its >>>>> already >>>>> > doing a tremendous amount of input handling and backwards compat >>>>> > workarounds. Probably I can just make this adjustment. >>>>> > >>>>> > -Michal >>>>> > >>>>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>>>> nikhi...@microsoft.com> >>>>> > wrote: >>>>> > >>>>> > > Michal: I'm new to this area - can you please elaborate why this >>>>> change >>>>> > > could potentially break downstream distributions? IS there an API >>>>> change? >>>>> > > >>>>> > > -Nikhil >>>>> > > >>>>> > > -Original Message- >>>>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >>>>> Michal >>>>> > > Mocny >>>>> > > Sent: Thursday, March 5, 2015 1:12 PM >>>>> > > To: dev >>>>> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm >>>>> and >>>>> > > adding as dependency of cordova-lib >>>>> > > >>>>> > > Alight, remote branches (named copy-from-app-hello-world) are >>>>> created for >>>>> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >>>>> > > >>>>> > > There are still 2 failing cordov
RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Thanks for making the change to make it compatible. I took a brief look at your changes and they look good. Thanks, Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Friday, March 6, 2015 1:12 PM To: Steven Gill Cc: Michal Mocny; Andrew Grieve; dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Agreed. Everything is upstream on the branch. The package.json wasn't fully thought out, so please peak at it. Ping me if you need anything, I'll rebase cordova-lib and move to master when you are done. Thanks Steve. On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill wrote: > Sure. I can make the changes to release process + coho for it. > > I imagine it won't be released often, so it might be best give > app-hello-world its own release process instead of tying it into > tools, platforms or plugins release. > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > >> (Sorry for all the messages) >> >> Fixed all the remaining breaks, and now all tests pass without >> modification and cordova-cli doesn't need changes. >> >> However, there is a new npm dependency on cordova-app-hello-word from >> cordova-lib. We will need to release that to npm before publishing >> the next tools release. >> >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of >> all the places to update release instructions for this new thing, nor >> am I sure of all the licensing requirements. Care to advise / help? >> >> Thanks! >> -Michal >> >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny >> wrote: >> >>> Updated as described. >>> >>> Now you no longer need to use the branch of cordova-cli, so I'm >>> pretty sure this is 100% compat. Huzzah. >>> >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny >>> wrote: >>> >>>> I wanted to originally, but you can --copy-from a www/ only (no >>>> config.xml), and then we need a template. If I change cordova-lib >>>> to depend on app-hello-world then we can remove it. Another reason to do >>>> so. >>>> >>>> -Michal >>>> >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >>>> >>>> wrote: >>>> >>>>> Can we move the config.xml template out of cordova-lib/templates >>>>> and into app-hello-world as a part of this? >>>>> >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>>>> wrote: >>>>> >>>>> > The current breaking change is that you cannot create a new >>>>> > project >>>>> using >>>>> > cordova-lib directly, without providing a project template to >>>>> > import >>>>> from. >>>>> > cordova-cli works as it always has, and will provide the >>>>> app-hello-world >>>>> > as a default if you do not use --copy-from / --link-to. >>>>> > >>>>> > However, writing that explanation out now, I realize I could >>>>> > just >>>>> change >>>>> > cordova-lib to be the one to depend on cordova-app-hello-world >>>>> > and >>>>> do the >>>>> > defaulting there, and not break compatibility. I think I >>>>> > originally envisioned the cordova-lib script to be more >>>>> > "primitive", but its >>>>> already >>>>> > doing a tremendous amount of input handling and backwards compat >>>>> > workarounds. Probably I can just make this adjustment. >>>>> > >>>>> > -Michal >>>>> > >>>>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>>>> nikhi...@microsoft.com> >>>>> > wrote: >>>>> > >>>>> > > Michal: I'm new to this area - can you please elaborate why >>>>> > > this >>>>> change >>>>> > > could potentially break downstream distributions? IS there an >>>>> > > API >>>>> change? >>>>> > > >>>>> > > -Nikhil >>>>> > > >>>>> > > -Original Message- >>>>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf >>>>> > > Of >>>>
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Release steps: https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md I will have to run through a release to see if I got it all right. Okay, I'm going to merge the copy-from-app-hello-world branch into master and start a vote thread! Lets hold off on merging the cordova-lib changes into master until cordova-app-hello-world gets released. This way we won't have failures on master according to travis. Sound good? On Fri, Mar 6, 2015 at 4:30 PM, Nikhil Khandelwal wrote: > Thanks for making the change to make it compatible. I took a brief look at > your changes and they look good. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Friday, March 6, 2015 1:12 PM > To: Steven Gill > Cc: Michal Mocny; Andrew Grieve; dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Agreed. > > Everything is upstream on the branch. The package.json wasn't fully > thought out, so please peak at it. Ping me if you need anything, I'll > rebase cordova-lib and move to master when you are done. > > Thanks Steve. > > On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill > wrote: > > > Sure. I can make the changes to release process + coho for it. > > > > I imagine it won't be released often, so it might be best give > > app-hello-world its own release process instead of tying it into > > tools, platforms or plugins release. > > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > > > >> (Sorry for all the messages) > >> > >> Fixed all the remaining breaks, and now all tests pass without > >> modification and cordova-cli doesn't need changes. > >> > >> However, there is a new npm dependency on cordova-app-hello-word from > >> cordova-lib. We will need to release that to npm before publishing > >> the next tools release. > >> > >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of > >> all the places to update release instructions for this new thing, nor > >> am I sure of all the licensing requirements. Care to advise / help? > >> > >> Thanks! > >> -Michal > >> > >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny > >> wrote: > >> > >>> Updated as described. > >>> > >>> Now you no longer need to use the branch of cordova-cli, so I'm > >>> pretty sure this is 100% compat. Huzzah. > >>> > >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny > >>> wrote: > >>> > >>>> I wanted to originally, but you can --copy-from a www/ only (no > >>>> config.xml), and then we need a template. If I change cordova-lib > >>>> to depend on app-hello-world then we can remove it. Another reason > to do so. > >>>> > >>>> -Michal > >>>> > >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve > >>>> > >>>> wrote: > >>>> > >>>>> Can we move the config.xml template out of cordova-lib/templates > >>>>> and into app-hello-world as a part of this? > >>>>> > >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny > >>>>> wrote: > >>>>> > >>>>> > The current breaking change is that you cannot create a new > >>>>> > project > >>>>> using > >>>>> > cordova-lib directly, without providing a project template to > >>>>> > import > >>>>> from. > >>>>> > cordova-cli works as it always has, and will provide the > >>>>> app-hello-world > >>>>> > as a default if you do not use --copy-from / --link-to. > >>>>> > > >>>>> > However, writing that explanation out now, I realize I could > >>>>> > just > >>>>> change > >>>>> > cordova-lib to be the one to depend on cordova-app-hello-world > >>>>> > and > >>>>> do the > >>>>> > defaulting there, and not break compatibility. I think I > >>>>> > originally envisioned the cordova-lib script to be more > >>>>> > "primitive", but its > >>>>> already > >>>>> > doing a tremendous amount of input handling and backwards comp
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Perfect. Thanks Steve. On Mon, Mar 9, 2015 at 7:46 PM, Steven Gill wrote: > Release steps: > > https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md > > I will have to run through a release to see if I got it all right. > > Okay, I'm going to merge the copy-from-app-hello-world branch into master > and start a vote thread! Lets hold off on merging the cordova-lib changes > into master until cordova-app-hello-world gets released. This way we won't > have failures on master according to travis. > > Sound good? > > On Fri, Mar 6, 2015 at 4:30 PM, Nikhil Khandelwal > wrote: > > > Thanks for making the change to make it compatible. I took a brief look > at > > your changes and they look good. > > > > Thanks, > > Nikhil > > > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Friday, March 6, 2015 1:12 PM > > To: Steven Gill > > Cc: Michal Mocny; Andrew Grieve; dev > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > adding as dependency of cordova-lib > > > > Agreed. > > > > Everything is upstream on the branch. The package.json wasn't fully > > thought out, so please peak at it. Ping me if you need anything, I'll > > rebase cordova-lib and move to master when you are done. > > > > Thanks Steve. > > > > On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill > > wrote: > > > > > Sure. I can make the changes to release process + coho for it. > > > > > > I imagine it won't be released often, so it might be best give > > > app-hello-world its own release process instead of tying it into > > > tools, platforms or plugins release. > > > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > > > > > >> (Sorry for all the messages) > > >> > > >> Fixed all the remaining breaks, and now all tests pass without > > >> modification and cordova-cli doesn't need changes. > > >> > > >> However, there is a new npm dependency on cordova-app-hello-word from > > >> cordova-lib. We will need to release that to npm before publishing > > >> the next tools release. > > >> > > >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of > > >> all the places to update release instructions for this new thing, nor > > >> am I sure of all the licensing requirements. Care to advise / help? > > >> > > >> Thanks! > > >> -Michal > > >> > > >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny > > >> wrote: > > >> > > >>> Updated as described. > > >>> > > >>> Now you no longer need to use the branch of cordova-cli, so I'm > > >>> pretty sure this is 100% compat. Huzzah. > > >>> > > >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny > > >>> wrote: > > >>> > > >>>> I wanted to originally, but you can --copy-from a www/ only (no > > >>>> config.xml), and then we need a template. If I change cordova-lib > > >>>> to depend on app-hello-world then we can remove it. Another reason > > to do so. > > >>>> > > >>>> -Michal > > >>>> > > >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve > > >>>> > > >>>> wrote: > > >>>> > > >>>>> Can we move the config.xml template out of cordova-lib/templates > > >>>>> and into app-hello-world as a part of this? > > >>>>> > > >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny > > >>>>> wrote: > > >>>>> > > >>>>> > The current breaking change is that you cannot create a new > > >>>>> > project > > >>>>> using > > >>>>> > cordova-lib directly, without providing a project template to > > >>>>> > import > > >>>>> from. > > >>>>> > cordova-cli works as it always has, and will provide the > > >>>>> app-hello-world > > >>>>> > as a default if you do not use --copy-from / --link-to. > > >>>>> > > > >>>>> > However, writing that explanation out now, I realize I could
[jira] [Created] (CB-2297) database cannot be opened error in Andorid log in official Hello World sample
Rudolf Kuczi created CB-2297: Summary: database cannot be opened error in Andorid log in official Hello World sample Key: CB-2297 URL: https://issues.apache.org/jira/browse/CB-2297 Project: Apache Cordova Issue Type: Bug Components: Android, App Hello World Affects Versions: 2.1.0 Environment: official Hello World sample, official Adobe PhoneGap build service, official Android emulator using 4.0.3 x86 system image, LG Optimus 2x (P-990) Reporter: Rudolf Kuczi Assignee: Joe Bowser Priority: Minor By building then official Hello World sample (https://github.com/phonegap/phonegap-start) using Adobe PhoneGap build I receive the following error in Android log: 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = 14, msg = cannot open file at line 29848 of [c7c6050ef0], db=/data/data/com.phonegap.hello_world/databases/webview.db 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = 14, msg = os_unix.c:29848: (2) open(/CachedGeoposition.db) - , db=/data/data/com.phonegap.hello_world/databases/webview.db This app doesn' even touch the database. I have another simple app working with window.database reporting the same error but actually functioning. I'm reporting this because I'm unsure If it can convert to a real issue when writing an app actually and intensively using window.database. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-2297) database cannot be opened error in Android log in official Hello World sample
[ https://issues.apache.org/jira/browse/CB-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rudolf Kuczi updated CB-2297: - Description: By building then official Hello World sample (https://github.com/phonegap/phonegap-start) using Adobe PhoneGap build I receive the following error in Android log: 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = 14, msg = cannot open file at line 29848 of [c7c6050ef0], db=/data/data/com.phonegap.hello_world/databases/webview.db 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = 14, msg = os_unix.c:29848: (2) open(/CachedGeoposition.db) - , db=/data/data/com.phonegap.hello_world/databases/webview.db However the Hello World app is totally functional. This app doesn' even touch the database. I have another simple app working with window.database reporting the same error but actually functioning. I'm reporting this because I'm unsure If it can convert to a real issue when writing an app actually and intensively using window.database. was: By building then official Hello World sample (https://github.com/phonegap/phonegap-start) using Adobe PhoneGap build I receive the following error in Android log: 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = 14, msg = cannot open file at line 29848 of [c7c6050ef0], db=/data/data/com.phonegap.hello_world/databases/webview.db 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = 14, msg = os_unix.c:29848: (2) open(/CachedGeoposition.db) - , db=/data/data/com.phonegap.hello_world/databases/webview.db This app doesn' even touch the database. I have another simple app working with window.database reporting the same error but actually functioning. I'm reporting this because I'm unsure If it can convert to a real issue when writing an app actually and intensively using window.database. > database cannot be opened error in Android log in official Hello World sample > - > > Key: CB-2297 > URL: https://issues.apache.org/jira/browse/CB-2297 > Project: Apache Cordova > Issue Type: Bug > Components: Android, App Hello World > Affects Versions: 2.1.0 > Environment: official Hello World sample, official Adobe PhoneGap > build service, official Android emulator using 4.0.3 x86 system image, LG > Optimus 2x (P-990) >Reporter: Rudolf Kuczi >Assignee: Joe Bowser >Priority: Minor > Labels: newbie > > By building then official Hello World sample > (https://github.com/phonegap/phonegap-start) using Adobe PhoneGap build I > receive the following error in Android log: > 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = > 14, msg = cannot open file at line 29848 of [c7c6050ef0], > db=/data/data/com.phonegap.hello_world/databases/webview.db > 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = > 14, msg = os_unix.c:29848: (2) open(/CachedGeoposition.db) - , > db=/data/data/com.phonegap.hello_world/databases/webview.db > However the Hello World app is totally functional. > This app doesn' even touch the database. > I have another simple app working with window.database reporting the same > error but actually functioning. > I'm reporting this because I'm unsure If it can convert to a real issue when > writing an app actually and intensively using window.database. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-2297) database cannot be opened error in Android log in official Hello World sample
[ https://issues.apache.org/jira/browse/CB-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rudolf Kuczi updated CB-2297: - Summary: database cannot be opened error in Android log in official Hello World sample (was: database cannot be opened error in Andorid log in official Hello World sample) > database cannot be opened error in Android log in official Hello World sample > - > > Key: CB-2297 > URL: https://issues.apache.org/jira/browse/CB-2297 > Project: Apache Cordova > Issue Type: Bug > Components: Android, App Hello World >Affects Versions: 2.1.0 > Environment: official Hello World sample, official Adobe PhoneGap > build service, official Android emulator using 4.0.3 x86 system image, LG > Optimus 2x (P-990) >Reporter: Rudolf Kuczi >Assignee: Joe Bowser >Priority: Minor > Labels: newbie > > By building then official Hello World sample > (https://github.com/phonegap/phonegap-start) using Adobe PhoneGap build I > receive the following error in Android log: > 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = > 14, msg = cannot open file at line 29848 of [c7c6050ef0], > db=/data/data/com.phonegap.hello_world/databases/webview.db > 01-26 16:09:07.320: I/SqliteDatabaseCpp(16717): sqlite returned: error code = > 14, msg = os_unix.c:29848: (2) open(/CachedGeoposition.db) - , > db=/data/data/com.phonegap.hello_world/databases/webview.db > This app doesn' even touch the database. > I have another simple app working with window.database reporting the same > error but actually functioning. > I'm reporting this because I'm unsure If it can convert to a real issue when > writing an app actually and intensively using window.database. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[GitHub] [cordova] totalpave deleted a comment on the discussion: Problem on running apk downloading from whatsapp or google drive, says app not installed, adb and cordova run works, its just an hello
GitHub user totalpave deleted a comment on the discussion: Problem on running apk downloading from whatsapp or google drive, says app not installed, adb and cordova run works, its just an helloworld This is standard Android OS behaviour. By default, only a select few apps can install apps on the device, which is usually Google Play Store and generally the phone manufacturer's app store (e.g. Samsung Galaxy Store). Apps can also be installed to developer devices (phones with USB debugging enabled) via ADB, which is the channel that Cordova uses to install apps onto the device. This is something that needs to be explicitly enabled by the user. If you manually transfer the APK to your device, you must allow the source app that accepted the APK to install APKs on the device. This can be done by going to `Settings -> Security -> Install unknown apps`. On older android versions, install unknown apps is a simple target that was disabled by default, and enabling it will allow you to install APks from untrusted sources. Newer android versions will go into a subscreen where you enable access for specific apps to allow APKs to be installed from specific sources. E.g. if you download an APK from Google Drive, then you must enable `Allow from this source` on the Google Drive app to install APKs obtained from the Drive app. None of these methods is a recommended way of publishing your app if you can help it. Your end users must jump through a lot of security hoops to install your app this fashion. The play stores often have a certain standard that your app must uphere too, which indirectly gives users some sense of trust when they install your app through official play stores. GitHub link: https://github.com/apache/cordova/discussions/419#discussioncomment-6317711 This is an automatically sent email for dev@cordova.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org