[GitHub] cordova-plugin-test-framework pull request: CB-8973: Changed the f...
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/12 CB-8973: Changed the functionality of making the log appear and disappear When the log appears, it appears over the content area, which means (for example) on the Manual Tests page, some tests are impossible to see. This change alters the log show/hide implementation, such that instead of modifying the #log class list, it modifies the body class list, and the #middle and #log elements adjust their appearances based on having body.expanded-log selector. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8973 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit e547f2f18c908c1471fa807c1e9439c401fee0cf Author: Rob Paveza rob.pav...@microsoft.com Date: 2015-05-06T23:36:23Z CB-8973: Changed the functionality of making the log appear and disappear from modifying the #log class list, to modifying the body class list, and having the #middle and #log elements adjust their appearances based on having body.expanded-log selector. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8870 Medic test failure display and...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8870 Medic test failure display and...
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/51 CB-8870 Medic test failure display and some fixes Fixing windows debug script path. Making builds store the master's hostname. Adding test number display to build steps. Adding --path parameter to medic-check. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB-8870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 24a187d6d40e795fc28236dd099723382bf4ec8a Author: Dmitry Blotsky dmitry.blot...@gmail.com Date: 2015-04-30T23:37:37Z CB-8870 Fixing windows debug script path. Making builds store the master's hostname. Adding test number display to build steps. Adding --path parameter to medic-check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Medic Test Matrix
Hi list, What are the changes what we would like made to the test/build matrix on Medic? Crosswalk is one that’s come up. Ant/Gradle and device/emulator are others. Once we get a good overview of the scenarios we want for testing, we can split up the builds accordingly. Kindly, Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...
GitHub user ktop opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/124 CB-8727 Fix failing WebSQL test on Android 5.1 - scrollByLines is an unknown function in Android 5.1 - removed because it causes the exception and does not affect the test itself You can merge this pull request into a Git repository by running: $ git pull https://github.com/ktop/cordova-mobile-spec master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit 921c2c0c15c1a1a04ceb85949fdb0bf950992714 Author: Karen Tran ktop...@gmail.com Date: 2015-03-22T04:19:06Z CB-8727 Fix failing WebSQL test on Android 5.1 commit 49f7c962debb0da874521c5ee410b17d02fa9694 Author: Karen Tran ktop...@gmail.com Date: 2015-03-22T04:19:06Z CB-8727 Fix failing WebSQL test on Android 5.1 - scrollByLines is an unknown funtion in Android 5.1 - removed because it causes the exception and does not affect the test itself commit 9edf897f9a533f09b742b15660ba264ff96a0b97 Author: Karen Tran ktop...@gmail.com Date: 2015-03-22T04:52:57Z Merge branch 'master' of https://github.com/ktop/cordova-mobile-spec --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Test PR for github / JIRA i...
GitHub user agrieve opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/2 Test PR for github / JIRA integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/agrieve/cordova-plugin-whitelist patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-whitelist/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit 546604953c6056d60bb1420f1fb105ada7b97e5c Author: agrieve agri...@chromium.org Date: 2015-03-13T17:11:40Z Test PR for github / JIRA integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Test PR for github / JIRA i...
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/2#issuecomment-79145875 Test CB-4789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Test PR for github / JIRA i...
Github user agrieve closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8528 Update test fr...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Android JUnit Refactor Deletes Test for CVE
Ah, just saw this after responding to the other thread. It was an accident. On Wed, Feb 11, 2015 at 4:48 PM, Joe Bowser bows...@gmail.com wrote: Responding via private list because this is about a security issue. Andrew, your refactor deleted a very important JUnit test, the SabotagedActivity test is very important for a past CVE where intents could be randomly sent to Cordova and executed remotely. I want to know why this code was deleted, and what will be done to reproduce this test case. I think that you deleting this use case opens us up to serious regressions that could put us at risk, and I would like your justification for that. Joe
[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810379 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810268 @nikhilkh, addressed CR notes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24069058
--- Diff: www/medic.js ---
@@ -35,30 +35,27 @@ exports.log = function() {
};
exports.load = function (callback) {
- var xhr = new XMLHttpRequest();
- xhr.open(GET, ../medic.json, true);
- xhr.onload = function() {
-if (xhr.readyState == 4 (xhr.status == 0 || xhr.status == 200)) {
- var cfg = JSON.parse(xhr.responseText);
- exports.logurl = cfg.couchdb || cfg.logurl;
- exports.enabled = true;
- exports.sha = cfg.sha;
- console.log('Loaded Medic Config: logurl=' + exports.logurl);
-}
-callback();
- }
- xhr.onerror = function() {
- callback();
- }
+ var jsonMedic = null;
try {
+// attempt to synchronously load medic config
+var xhr = new XMLHttpRequest();
+xhr.open(GET, ../medic.json, false);
xhr.send(null);
- }
- catch(ex) {
-// some platforms throw on a file not found
+jsonMedic = xhr.responseText;
+ } catch (ex) { }
+
+ // config is available
+ if (jsonMedic) {
+exports.logurl = JSON.parse(jsonMedic).logurl;
--- End diff --
Ops, I'll fix this shortly. Thx @nikhilkh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24058292
--- Diff: www/medic.js ---
@@ -35,30 +35,27 @@ exports.log = function() {
};
exports.load = function (callback) {
- var xhr = new XMLHttpRequest();
- xhr.open(GET, ../medic.json, true);
- xhr.onload = function() {
-if (xhr.readyState == 4 (xhr.status == 0 || xhr.status == 200)) {
- var cfg = JSON.parse(xhr.responseText);
- exports.logurl = cfg.couchdb || cfg.logurl;
- exports.enabled = true;
- exports.sha = cfg.sha;
- console.log('Loaded Medic Config: logurl=' + exports.logurl);
-}
-callback();
- }
- xhr.onerror = function() {
- callback();
- }
+ var jsonMedic = null;
try {
+// attempt to synchronously load medic config
+var xhr = new XMLHttpRequest();
+xhr.open(GET, ../medic.json, false);
xhr.send(null);
- }
- catch(ex) {
-// some platforms throw on a file not found
+jsonMedic = xhr.responseText;
+ } catch (ex) { }
+
+ // config is available
+ if (jsonMedic) {
+exports.logurl = JSON.parse(jsonMedic).logurl;
--- End diff --
There is an issue here - earlier code was doing this: exports.logurl =
cfg.couchdb || cfg.logurl
while you are only using logurl. In fact, this breaks our medic server
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10 CB-8385 Ensure plugin-test-framework trigger tests only once https://issues.apache.org/jira/browse/CB-8385 Simplified medic config loading logic by making it synch = prevent calling callback function several times You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8385 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit bb277ac5d5ac675ecc2ff91f6414a17ae0f45442 Author: sgrebnov v-seg...@microsoft.com Date: 2015-01-30T14:18:06Z CB-8385 Ensure plugin-test-framework trigger tests only once --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8388 Prevent Window...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Cordova android native test
Hi all, Recently tested cordova-android master branch and found out a commit that it's triggering an issue that it got solved a while ago indirectly. Info: CB-8317 ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ccceaeaca2d72fb9708100ab2f70adb903a27d66 breaks: CB-7371 To avoid future regressions, Joe suggest to create a native test that would recreate the conditions to verify that the issue is not present. Here's the deal, the current Cordova Native test suite, with the app itself, I can't recreate it, MainTestActivity class doesn't get affect at all, although with a cordova project that uses a single activity it can be recreate easily. If I go to any of the other activities and recreate it, that activity gets destroyed and gets back to the first one(MainTestActivity). The only way to recreate the problem using that test suite is by using Error URL (errorurl class) test, which triggers a destroy of the previous activity caused by not locate the html resource in the path provided. In that specific test, in that activity and after the previous activity is closed, in there I can perform the manual test and recreate the problem. I've added the code to change the configuration and perform a recreation in that specific test, but that would mean, that it can't go back to the previous one where all other test live. Another would be call the activity to perform config changes, pause the main, and get back to it, apply the configuration in that one and then trigger the recreation onResume, by listening the configuration changes, or adding a broadcastreceiver. Test sample project with a single activity: --Change the config --Triger recreation. Expected: it should recreate the activity Result (current master): it crash the app. steps to recreate manually: 1.- Create a project 2.- platform add cordova-android (master) 3.- build deploy 4.- once launched, minimize it go to settings 5.- Select another language, and then resume the app, by using the home button. At that point crashes Does anybody have any idea, to perform such as test without having to kill the main activity? any other ideas about how to recreate the scenario? Thanks devs. -- Regards, Martin Gonzalez
[GitHub] cordova-plugin-test-framework pull request: CB-8388 Prevent Window...
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/9 CB-8388 Prevent Windows app from crashing on test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 395d3458a45b162a5aa0278d7fd4d2b322a1ad51 Author: Nikhil Khandelwal nikhi...@microsoft.com Date: 2015-01-30T16:42:32Z CB-8388 Prevent Windows app from crashing on test failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Creating PR to test against travis / app...
Github user agrieve closed the pull request at: https://github.com/apache/cordova-lib/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-70243782 ping @clelland PTAL, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8295 Enable CSP for...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968802
--- Diff: www/main.js ---
@@ -215,6 +237,12 @@ function createEnablerList() {
enablerList.appendChild(checkButtonBar);
+ header.appendChild(headerPrefix);
+ header.appendChild(enabledCount);
+ header.appendChild(totalCount);
+ header.appendChild(headerSuffix);
--- End diff --
This seems needlessly complex. Why not just a single text element, and we
set the whole Running X of Y text each time? We already append the '/' to
the first span and we aren't using any fancy data binding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/6#discussion_r22968690
--- Diff: www/main.js ---
@@ -225,6 +253,43 @@ function createEnablerList() {
/**/
+function updateTotalTestCount(totalCount) {
+ var label = document.getElementById('test-total-count');
+
+ label.setAttribute('count', totalCount);
+ label.innerText = totalCount;
+}
+
+/**/
+
+function updateEnabledTestCount(enabledCount) {
+
+ var enabledLabel = document.getElementById('test-enabled-count');
+
+ if (!enabledCount) {
+// Determine how many tests are currently enabled
+var cdvtests =
cordova.require('org.apache.cordova.test-framework.cdvtests');
+var enabled = 0;
+iterateAutoTests(cdvtests, function(api, testModule) {
+ if (testModule.getEnabled()) {
+enabled++;
+ }
+});
+enabledCount = enabled;
+ }
+
+ // Compare enabled count vs the total to show if all tests are to be run
+ var totalCount =
document.getElementById('test-total-count').getAttribute('count');
--- End diff --
Why use an attribute on the tag and not just a javascript variable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8295 Enable CSP for...
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/8 CB-8295 Enable CSP for mobile spec - Uses a javascript include file (provided by mobile spec app) to document.write a CSP tag on page - If hosted outside of mobile spec, that app must provide similar injection script - Change index page to remove inline script (to comply with CSP) Relates to apache/cordova-mobile-spec#115 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpchase/cordova-plugin-test-framework CB-8295 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit f6ed190a58f9c77734da7debe1e2472811b57d01 Author: Jason Chase jasonpch...@gmail.com Date: 2015-01-14T15:30:09Z CB-8295 Enable CSP for mobile spec - Uses a javascript include file (provided by mobile spec app) to document.write a CSP tag on page - If hosted outside of mobile spec, that app must provide similar injection script - Change index page to remove inline script (to comply with CSP) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8302 Added `npm test` script
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-js/pull/101 CB-8302 Added `npm test` script JIRA item: https://issues.apache.org/jira/browse/CB-8302 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-js CB-8302 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 commit 3e94f083f4a40b22fd5cabde38bf8a74a7e195d3 Author: alsorokin alexander.soro...@akvelon.com Date: 2015-01-13T14:32:42Z CB-8302 Added `npm test` script --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: How to test the cordova-android 4.0 by mobile spec
Thank you very much, I will follow this issue by CB-8280. Another things about JUnit tests, I pulled cordova-android 4.0 branch, and running Unit test in /test directory, but there are compiled error as below, and I want reuse the Unit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Friday, January 09, 2015 5:06 AM To: Andrew Grieve Cc: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec Created issue for the splashscreen: https://issues.apache.org/jira/browse/CB-8280 On Thu, Jan 8, 2015 at 1:28 PM, Andrew Grieve agri...@chromium.org wrote: Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser bows...@gmail.com wrote: That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are relatively minor, but can become huge w.r.t. docs and test coverage. On Thu Jan 08 2015 at 8:52:53 AM Michal Mocny mmo...@chromium.org wrote: It should be, but given that its on a branch (fewer passing eyeballs), the pace of changes on 4.0.x, and that the failing test in question is a manual test, things are easily overlooked. Thanks for bringing it up. Once 3.7 ships and 4.0 moves to master for next major release, I expect the tests will get more eyeballs. On Wed, Jan 7, 2015 at 8:28 PM, Fu, Junwei junwei...@intel.com wrote: Thank you very much, it's fine after update your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, January 08, 2015 2:00 AM To: Andrew Grieve Cc: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-69277448 ping @clelland Could you please help me review this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: How to test the cordova-android 4.0 by mobile spec
Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser bows...@gmail.com wrote: That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are relatively minor, but can become huge w.r.t. docs and test coverage. On Thu Jan 08 2015 at 8:52:53 AM Michal Mocny mmo...@chromium.org wrote: It should be, but given that its on a branch (fewer passing eyeballs), the pace of changes on 4.0.x, and that the failing test in question is a manual test, things are easily overlooked. Thanks for bringing it up. Once 3.7 ships and 4.0 moves to master for next major release, I expect the tests will get more eyeballs. On Wed, Jan 7, 2015 at 8:28 PM, Fu, Junwei junwei...@intel.com wrote: Thank you very much, it's fine after update your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, January 08, 2015 2:00 AM To: Andrew Grieve Cc: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are relatively minor, but can become huge w.r.t. docs and test coverage. On Thu Jan 08 2015 at 8:52:53 AM Michal Mocny mmo...@chromium.org wrote: It should be, but given that its on a branch (fewer passing eyeballs), the pace of changes on 4.0.x, and that the failing test in question is a manual test, things are easily overlooked. Thanks for bringing it up. Once 3.7 ships and 4.0 moves to master for next major release, I expect the tests will get more eyeballs. On Wed, Jan 7, 2015 at 8:28 PM, Fu, Junwei junwei...@intel.com wrote: Thank you very much, it's fine after update your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, January 08, 2015 2:00 AM To: Andrew Grieve Cc: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
Created issue for the splashscreen: https://issues.apache.org/jira/browse/CB-8280 On Thu, Jan 8, 2015 at 1:28 PM, Andrew Grieve agri...@chromium.org wrote: Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser bows...@gmail.com wrote: That said, the tests failing should be filed as an issue. I think this is related to Andrew's recent refactor of the Splashscreen, removing it from the core platform. These changes are relatively minor, but can become huge w.r.t. docs and test coverage. On Thu Jan 08 2015 at 8:52:53 AM Michal Mocny mmo...@chromium.org wrote: It should be, but given that its on a branch (fewer passing eyeballs), the pace of changes on 4.0.x, and that the failing test in question is a manual test, things are easily overlooked. Thanks for bringing it up. Once 3.7 ships and 4.0 moves to master for next major release, I expect the tests will get more eyeballs. On Wed, Jan 7, 2015 at 8:28 PM, Fu, Junwei junwei...@intel.com wrote: Thank you very much, it's fine after update your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, January 08, 2015 2:00 AM To: Andrew Grieve Cc: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
RE: How to test the cordova-android 4.0 by mobile spec
Thank you very much, it's fine after update your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, January 08, 2015 2:00 AM To: Andrew Grieve Cc: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js exec() will always work (but still leave the class name as CoreAndroid) On Tue, Jan 6, 2015 at 10:06 PM, Fu, Junwei junwei...@intel.com wrote: Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
How to test the cordova-android 4.0 by mobile spec
Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
Re: How to test the cordova-android 4.0 by mobile spec
I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
RE: How to test the cordova-android 4.0 by mobile spec
I update the latest cordova-android 4.0.x, cordova-mobile-spec and cordova-js, the key event test cases still failed, and the cordova version is still MSTEST, not 4.0. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, January 07, 2015 10:30 AM To: dev Subject: Re: How to test the cordova-android 4.0 by mobile spec I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: How to test the cordova-android 4.0 by mobile spec
Yes, I set up mobilespec following https://github.com/apache/cordova-mobile-spec . -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri...@chromium.org wrote: I've just been checkout out 4.0.x branch of cordova-android, then running the script. I think the script requires that cordova-mobile-spec, cordova-android, and cordova-js all be sibling directories. On Tue, Jan 6, 2015 at 7:58 PM, Joe Bowser bows...@gmail.com wrote: I haven't been able to get mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause of the key event test failing. On Tue, Jan 6, 2015 at 3:47 AM, Fu, Junwei junwei...@intel.com wrote: Hi, Because There are no cordova-mobile-spec 4.0 branch, so I used cordova-mobile-spec master branch to test cordova-android 4.0, but the key event test cases failed. And the splash screen test cases failed with cordova-mobile-spec 3.6 branch, I don't know how to test the cordova-android 4.0 by mobile spec. Thanks, Junwei.
[GitHub] cordova-cli pull request: CB-8129 Add test coverage report generat...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8129 Add test coverage report generat...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8129 Add test coverage report generati...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-lib/pull/132 CB-7863 Fixed broken test run on Windows 8.1 Alternative fix for https://issues.apache.org/jira/browse/CB-7863 Seems the cause of fatal error under Windows was in synchronous calls to prepare-browserify that is asynchronous in its nature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-7863 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit 8ce89a68db09ba106fa55da64a9de5e4dd16da53 Author: alsorokin alexander.soro...@akvelon.com Date: 2014-12-17T15:37:21Z CB-7863 Fixed broken test run on Windows 8.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/140#issuecomment-67446387 Could someone help me to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
GitHub user fujunwei opened a pull request: https://github.com/apache/cordova-android/pull/140 Make JUnit tests to test pluggable webview The JUnit tests can only test Android webView now, the XWalk is a pluggable webView, we want to reuse the tests to test the pluggable webView after install cordova-crosswalk-engine plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fujunwei/cordova-android pluggable_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit aee0822dec701417df22e0af366326a25ccf82df Author: fujunwei junwei...@intel.com Date: 2014-12-17T01:13:43Z Make JUnit tests to test pluggable webview The JUnit tests can only test Android webView now, the XWalk is a pluggable webView, we want to reuse the tests to test the pluggable webView after install cordova-crosswalk-engine plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949451
--- Diff: test/src/org/apache/cordova/test/SabotagedActivity.java ---
@@ -33,10 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under
one
import android.util.Log;
public class SabotagedActivity extends CordovaActivity {
-
--- End diff --
no necessary removal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949465
--- Diff: test/src/org/apache/cordova/test/backgroundcolor.java ---
@@ -33,5 +33,4 @@ public void onCreate(Bundle savedInstanceState) {
super.loadUrl(file:///android_asset/www/backgroundcolor/index.html);
}
-
--- End diff --
no necessary line removing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949468
--- Diff: test/src/org/apache/cordova/test/errorurl.java ---
@@ -22,12 +22,14 @@ Licensed to the Apache Software Foundation (ASF) under
one
import org.apache.cordova.*;
public class errorurl extends CordovaActivity {
+public CordovaWebView cordovaWebView;
+
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
preferences.set(errorUrl,
file:///android_asset/www/htmlnotfound/error.html);
super.loadUrl(file:///android_asset/www/htmlnotfound/index.html);
+
+cordovaWebView = this.appView;
}
-
-
}
--- End diff --
ditto.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949530
--- Diff: test/src/org/apache/cordova/test/splashscreen.java ---
@@ -30,6 +32,8 @@ public void onCreate(Bundle savedInstanceState) {
// Show splashscreen
preferences.set(splashscreen, sandy);
-super.loadUrl(file:///android_asset/www/splashscreen/index.html,
2000);
+super.loadUrl(file:///android_asset/www/splashscreen/index.html);
--- End diff --
why remove the 2000 timeout?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8129 Add test coverage report generat...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/131 CB-8129 Add test coverage report generation to core cordova tools This implements [CB-8129](https://issues.apache.org/jira/browse/CB-8129) and adds `npm run cover` command that generates a test coverage report under `coverage` directory and prints coverage summary to console. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8129 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #131 commit dc149e0befdc86e2b8ff9dd5416b5ae45bea9a89 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-12-05T13:52:30Z CB-8129 Adds 'npm run cover' command to generate tests coverage report commit 80358fda170a6473421ec6daa7c9e950a59f572c Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-12-09T08:05:03Z Updates README with description of npm commands for this package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-8129 Add test coverage report generat...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-cli/pull/198 CB-8129 Add test coverage report generation to core cordova tools This implements [CB-8129](https://issues.apache.org/jira/browse/CB-8129) and adds `npm run cover` command that generates a test coverage report under `coverage` directory and prints coverage summary to console. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli CB-8129 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #198 commit 3afab318bfcf976b3add8db24cd1fb0fac7cb4d5 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-12-15T07:54:05Z CB-8129 Adds 'npm run cover' command to generate tests coverage report --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8129 Add test coverage report generat...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/131#issuecomment-67004121 This seems to break the tests on Windows. Not sure why. But the ios parser spec fails on a bunch of mismatches between back and forward slashes in file paths. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8129 Add test coverage report generat...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/131#issuecomment-67006185 Just tried to run `npm run jasmine` on latest master and got same errors. It seems that tests are broken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8070 MedicReporter ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-8070 MedicReporter ...
GitHub user MariaBukharina opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/7 CB-8070 MedicReporter incompatible with medic couch db structure. https://issues.apache.org/jira/browse/CB-8070 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8070 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit 357b89932cf13e0bc035e36cfb65116f98bd6d2a Author: maria.bukharina maria.bukhar...@akvelon.com Date: 2014-11-25T09:46:23Z CB-8070 MedicReporter from plugin-test-framework incompatible with medic couch db structure. It's fixed. commit 80225da9beef00cbf96c5eeaf944737b722e76b4 Author: maria.bukharina maria.bukhar...@akvelon.com Date: 2014-11-25T09:50:46Z Fixed minor formatting bugs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-8029 test 1-based indexing...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-8029 test 1-based indexing...
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/41 CB-8029 test 1-based indexing for confirm Added to the expected results -- remember to check 1-based indexing in the confirm manual tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-dialogs CB-8029 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit 86b4e25a38c082ddcae1534bfb4f39f8f3819e00 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-11-17T19:51:11Z CB-8029 test 1-based indexing for confirm Added to the expected results -- remember to check 1-based indexing in the confirm manual tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
mobilespec 3.6.3 contact test case failing and JIRA raised
Hello Devs,
Please can you look at the below mail. I am constantly getting
contact.save()(already existing contact) method test failure.
If I apply the patch as mentioned in JIRA
https://issues.apache.org/jira/browse/CB-5308 pickContacts API fails.
But without the patch conact.save()(already existing contact) method always
fails.
I observed that the query to retrieve the contact which already exists
RAWCONTACTS_ID is used
This is implemented in onActivityResult() in ContactManager.java
if (requestCode == CONTACT_PICKER_RESULT) {
if (resultCode == Activity.RESULT_OK) {
String contactId = intent.getData().getLastPathSegment();
// to populate contact data we require Raw Contact ID
// so we do look up for contact raw id first
Cursor c =
this.cordova.getActivity().getContentResolver().query(RawContacts.CONTENT_URI,
new String[] {RawContacts._ID},
RawContacts.CONTACT_ID + = + contactId, null, null);
The patch suggested in https://issues.apache.org/jira/browse/CB-5308 also
suggests the same.
Can you please suggest if the patch is valid or not and if the JIRA will be
taken up to resolve?
Thanks and Regards
Pavan Joshi
-Original Message-
From: Joshi, Pavankumar [mailto:jos...@fast.au.fujitsu.com]
Sent: Monday, 27 October 2014 1:51 PM
To: dev@cordova.apache.org
Subject: FW: mobilespec 3.6.3 contact test case failing and JIRA raised
Hello Devs
Can you please look into the issue and let us know what is the solution for the
problem mentioned.
Thanks and Regards
Pavan Joshi
-Original Message-
From: Joshi, Pavankumar [mailto:jos...@fast.au.fujitsu.com]
Sent: Thursday, 16 October 2014 10:07 AM
To: dev@cordova.apache.org
Subject: mobilespec 3.6.3 contact test case failing and JIRA raised
Hello devs,
Currently I am testing mobilespec 3.6.3 on Android 4.4.3 device and found that
a test casecontacts.spec.21 fails. When I looked into the issue there was a JIRA
https://issues.apache.org/jira/browse/CB-5308 raised for the similar issue.
When I incorporated the changes suggested by Toda Shingo in the JIRA the test
case is working fine.
The error Is Contact.save() call failure callback even if contact data is
successfully saved on device. The JIRA is unassigned and unresolved.
Please can you have a look at the JIRA and let us know if there is a problem
with contacts plugin.
Regards
Pavan Joshi
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-lib/pull/112#issuecomment-61049460 I think that AppVeyor broken tests related to the https://issues.apache.org/jira/browse/CB-7722. Initially I think that issue related to https://issues.apache.org/jira/browse/CB-7721, but looks like we have two separate issue here. 1. shelljs bug (?) which prevent me from even running test suite. 2. Issue with tests on Windows 8.1 x64 where tests reported as failed. For item 2 I probably have to create separate issue in JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-lib/pull/112#issuecomment-61050070 just want to clarify - without that patch, running `npm test` crashed and report error. With that fix I have `npm test` running and it is produced similar results as AppVeyor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/112#issuecomment-61009185 Unfortunately, it looks like appveyor is reporting that tests are failing ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
FW: mobilespec 3.6.3 contact test case failing and JIRA raised
Hello Devs Can you please look into the issue and let us know what is the solution for the problem mentioned. Thanks and Regards Pavan Joshi -Original Message- From: Joshi, Pavankumar [mailto:jos...@fast.au.fujitsu.com] Sent: Thursday, 16 October 2014 10:07 AM To: dev@cordova.apache.org Subject: mobilespec 3.6.3 contact test case failing and JIRA raised Hello devs, Currently I am testing mobilespec 3.6.3 on Android 4.4.3 device and found that a test casecontacts.spec.21 fails. When I looked into the issue there was a JIRA https://issues.apache.org/jira/browse/CB-5308 raised for the similar issue. When I incorporated the changes suggested by Toda Shingo in the JIRA the test case is working fine. The error Is Contact.save() call failure callback even if contact data is successfully saved on device. The JIRA is unassigned and unresolved. Please can you have a look at the JIRA and let us know if there is a problem with contacts plugin. Regards Pavan Joshi - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-lib/pull/112 CB-7863 Fixed broken test run on Windows 8.1 Replace shelljs.rm with calls to fs-extra.removeSync You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-lib CB-7863 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #112 commit 00a8a6f5cd96e888c03f3b1ba9c4f17ea43c2938 Author: Andrey Kurdyumov kant2...@gmail.com Date: 2014-10-24T09:29:43Z Fixed broken test run on Windows 8.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
FW: mobilespec 3.6.3 contact test case failing and JIRA raised
Hello devs, Can you kindly look into the issue. I applied the patch mentioned in the JIRA, but when I wrote a test case in Android for pickContact method the test case crashed. Hence I believe it is better that you suggest a solution for fixing the failing contacts.spec.21 test case. Currently I am running mobilespec 3.6.3 on Android 4.4.3 device. The test case fails saying the Async callback could not be invoked and times out Thanks in advance, Thanks and Regards Pavan Joshi -Original Message- From: Joshi, Pavankumar [mailto:jos...@fast.au.fujitsu.com] Sent: Thursday, 16 October 2014 10:07 AM To: dev@cordova.apache.org Subject: mobilespec 3.6.3 contact test case failing and JIRA raised Hello devs, Currently I am testing mobilespec 3.6.3 on Android 4.4.3 device and found that a test casecontacts.spec.21 fails. When I looked into the issue there was a JIRA https://issues.apache.org/jira/browse/CB-5308 raised for the similar issue. When I incorporated the changes suggested by Toda Shingo in the JIRA the test case is working fine. The error Is Contact.save() call failure callback even if contact data is successfully saved on device. The JIRA is unassigned and unresolved. Please can you have a look at the JIRA and let us know if there is a problem with contacts plugin. Regards Pavan Joshi - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Test Devices and Coverage
Hi Devs, A few JIRAs have been raised for test cases e.g. https://issues.apache.org/jira/browse/CB-7797 Expected 'LocalState\num 1\num 2/' to contain '/num%201/num%202/'. Can anyone confirm which devices the core and plugin tests were run on? The blog at https://gist.github.com/cfjedimaster/b689cbf528cddaa2391a indicates that the latest plugins have been tested with the latest platforms. Also a number of APIs have been added without test cases. Are there any reports on coverage? Thanks Angela Java Mobile Developer
Re: Whitelist Test case failing in Mobilespec 3.6.3
I submitted a pull request to fix this test case, but it has not been
merged in yet. Although now it has merge conflicts that I need to resolve
before it can get pulled in.
https://github.com/apache/cordova-mobile-spec/pull/107
Thanks,
Edna Morales
From: Joshi, Pavankumar jos...@fast.au.fujitsu.com
To: dev@cordova.apache.org dev@cordova.apache.org
Date: 10/14/2014 09:12 PM
Subject:Whitelist Test case failing in Mobilespec 3.6.3
Hello devs,
I am currently testing mobilespec 3.6.3 and I found a test case failing in
whitelist.
The test case is written like
itShouldMatch('file:///foo.html', [ ]);
As I understand that a new whitelist URL file:///foo.html
file:///\\foo.html is added and then tested for the pattern []. The API
whitelist.isUrlWhiteListed(url); returns false which means that blank
patterns are not allowed.
But the test cases expects the return value to be true. Hence the test case
fails.
Now is it the mistake of the test case or the API? What should I do to make
this test case pass?
Please can you tell me where is an explanation about Whitelist match and
test API explained and what does a pattern stand for?
Thanks in advance
Thanks and Regards
Pavan Joshi
Re: Whitelist Test case failing in Mobilespec 3.6.3
Actually it looks like it was already fixed on master. But the issue was
with the test case itself.
Thanks,
Edna Morales
From: Edna Y Morales/Durham/IBM@IBMUS
To: dev@cordova.apache.org
Date: 10/15/2014 09:13 AM
Subject:Re: Whitelist Test case failing in Mobilespec 3.6.3
I submitted a pull request to fix this test case, but it has not been
merged in yet. Although now it has merge conflicts that I need to resolve
before it can get pulled in.
https://github.com/apache/cordova-mobile-spec/pull/107
Thanks,
Edna Morales
Joshi, Pavankumar ---10/14/2014 09:12:52 PM---Hello devs, I am currently
testing mobilespec 3.6.3 and I found a test case failing in whitelist.
From: Joshi, Pavankumar jos...@fast.au.fujitsu.com
To: dev@cordova.apache.org dev@cordova.apache.org
Date: 10/14/2014 09:12 PM
Subject: Whitelist Test case failing in Mobilespec 3.6.3
Hello devs,
I am currently testing mobilespec 3.6.3 and I found a test case failing in
whitelist.
The test case is written like
itShouldMatch('file:///foo.html', [ ]);
As I understand that a new whitelist URL file:///foo.html
file:///\\foo.html is added and then tested for the pattern []. The API
whitelist.isUrlWhiteListed(url); returns false which means that blank
patterns are not allowed.
But the test cases expects the return value to be true. Hence the test case
fails.
Now is it the mistake of the test case or the API? What should I do to make
this test case pass?
Please can you tell me where is an explanation about Whitelist match and
test API explained and what does a pattern stand for?
Thanks in advance
Thanks and Regards
Pavan Joshi
mobilespec 3.6.3 contact test case failing and JIRA raised
Hello devs, Currently I am testing mobilespec 3.6.3 on Android 4.4.3 device and found that a test casecontacts.spec.21 fails. When I looked into the issue there was a JIRA https://issues.apache.org/jira/browse/CB-5308 raised for the similar issue. When I incorporated the changes suggested by Toda Shingo in the JIRA the test case is working fine. The error Is Contact.save() call failure callback even if contact data is successfully saved on device. The JIRA is unassigned and unresolved. Please can you have a look at the JIRA and let us know if there is a problem with contacts plugin. Regards Pavan Joshi
Whitelist Test case failing in Mobilespec 3.6.3
Hello devs,
I am currently testing mobilespec 3.6.3 and I found a test case failing in
whitelist.
The test case is written like
itShouldMatch('file:///foo.html', [ ]);
As I understand that a new whitelist URL file:///foo.htmlfile:///\\foo.html
is added and then tested for the pattern []. The API
whitelist.isUrlWhiteListed(url); returns false which means that blank patterns
are not allowed.
But the test cases expects the return value to be true. Hence the test case
fails.
Now is it the mistake of the test case or the API? What should I do to make
this test case pass?
Please can you tell me where is an explanation about Whitelist match and
test API explained and what does a pattern stand for?
Thanks in advance
Thanks and Regards
Pavan Joshi
[GitHub] cordova-ios pull request: CB-7493 Adds test-build command to packa...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: [CB-2412] Adding manual test for...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: [CB-1933] Added a test for confi...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-test-framework pull request: CB-7459 Add header to ...
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/6 CB-7459 Add header to show number of enabled plugin tests It is not obvious if all/how many plugin tests are being run, given that: - Individual plugin tests can be enabled/disabled by the user - The enabled settings are remembered across app runs (even if the user forgets) - The UI widgets to enable/disable individual plugins is hidden in a collapsed section by default, so are not visible To aid the user, a header has been added to explicitly show the total number of tests, and how many are enabled (e.g. All vs. N/M). You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpchase/cordova-plugin-test-framework CB-7459-part2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit 1456ebc984e93ddd7b708aa8f00ebeae32d4eea7 Author: Jason Chase jasonpch...@gmail.com Date: 2014-09-15T13:55:50Z CB-7459 Add header to show number of enabled plugin tests It is not obvious if all/how many plugin tests are being run, given that: - Individual plugin tests can be enabled/disabled by the user - The enabled settings are remembered across app runs (even if the user forgets) - The UI widgets to enable/disable individual plugins is hidden in a collapsed section by default, so are not visible To aid the user, a header has been added to explicitly show the total number of tests, and how many are enabled (e.g. All vs. N/M). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-android pull request: CB-7493 Adds test-build command to p...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-ios pull request: CB-7493 Adds test-build command to packa...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/103 CB-7493 Adds test-build command to package.json Fix for https://issues.apache.org/jira/browse/CB-7493 \+ bonus - travis configuration file. Succesful build log: https://travis-ci.org/vladimir-kotikov/cordova-ios You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-7493 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit cfdc9cc56beef91527aab8a2f5e8223b46e5b29b Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-09-09T13:06:15Z CB-7493 Adds test-build command to package.json --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-test-framework pull request: CB-7459 Allow automati...
Github user clambertus commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/4#issuecomment-55138873 test jira integration comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-test-framework pull request: CB-7459 Allow automati...
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/4#issuecomment-55140469 Wow this is good, Thanks Jason. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-test-framework pull request: Updated test-framework...
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/5 Updated test-framework docs Updated information about tests being stored as nested plugins, and changed 'test' directory to 'tests'. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-test-framework fixdocs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit dfac7397f8f13a0ca57acd882fd04506c03713a0 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-09-10T18:29:42Z Updated test-framework docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-test-framework pull request: Updated test-framework...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-android pull request: CB-7493 Adds test-build command to p...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/119 CB-7493 Adds test-build command to package.json Fix for https://issues.apache.org/jira/browse/CB-7493 \+ bonus - travis configuration file. Succesful build log: https://travis-ci.org/vladimir-kotikov/cordova-android You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-android CB-7493 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #119 commit d52ca93ba64a79422e65ddeaef633e2c21f38bdb Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-09-09T05:59:34Z CB-7493 Adds test-build command to package.json --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
File test failures (was: Re: [Testing] No content to speak of)
Martin, can you post the spec test output somewhere? (Or anyone who can replicate this on a windows phone device -- I don't have a test environment set up for that yet, but I'm slowly working at it) I've checked the code again from my side, and I can't see where or how it's failing, so the mobile-spec output would be pretty helpful at this point. Thanks, Ian On Wed, Aug 27, 2014 at 9:11 AM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Agree, over android it looks good, however running the tests over Windows Phone, the final count is 13 new fails. Specs failing: 9, 9.5, 10, 11, 15, 24, 82, 110, 116, 121, 122, 123, 124. 2014-08-26 11:20 GMT-05:00 Marcel Kinard cmarc...@gmail.com: Thanks, Ian! On Android 4.4, I'm now getting no failures with the all the automatic tests (new-style plugin tests and old-style non-plugin tests). Now to start poking at the manual tests... On Aug 26, 2014, at 11:27 AM, Ian Clelland iclell...@chromium.org wrote: The other issue should be resolved now, but if someone with a WP8 device can test it out as well, it'd be appreciated. -- Regards, Martin Gonzalez
Re: File test failures (was: Re: [Testing] No content to speak of)
Sure thing, give me a couple of minutes. 2014-08-27 9:55 GMT-05:00 Ian Clelland iclell...@chromium.org: Martin, can you post the spec test output somewhere? (Or anyone who can replicate this on a windows phone device -- I don't have a test environment set up for that yet, but I'm slowly working at it) I've checked the code again from my side, and I can't see where or how it's failing, so the mobile-spec output would be pretty helpful at this point. Thanks, Ian On Wed, Aug 27, 2014 at 9:11 AM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Agree, over android it looks good, however running the tests over Windows Phone, the final count is 13 new fails. Specs failing: 9, 9.5, 10, 11, 15, 24, 82, 110, 116, 121, 122, 123, 124. 2014-08-26 11:20 GMT-05:00 Marcel Kinard cmarc...@gmail.com: Thanks, Ian! On Android 4.4, I'm now getting no failures with the all the automatic tests (new-style plugin tests and old-style non-plugin tests). Now to start poking at the manual tests... On Aug 26, 2014, at 11:27 AM, Ian Clelland iclell...@chromium.org wrote: The other issue should be resolved now, but if someone with a WP8 device can test it out as well, it'd be appreciated. -- Regards, Martin Gonzalez -- Regards, Martin Gonzalez
Re: File test failures (was: Re: [Testing] No content to speak of)
Done, Jasmine report has been attached to https://issues.apache.org/jira/browse/CB-7375. Please look at the listed spec failing, there are other failures over windows phone, but those were before of any of this changes. 2014-08-27 10:43 GMT-05:00 Martin Gonzalez martin.c.glez.g...@gmail.com: Sure thing, give me a couple of minutes. 2014-08-27 9:55 GMT-05:00 Ian Clelland iclell...@chromium.org: Martin, can you post the spec test output somewhere? (Or anyone who can replicate this on a windows phone device -- I don't have a test environment set up for that yet, but I'm slowly working at it) I've checked the code again from my side, and I can't see where or how it's failing, so the mobile-spec output would be pretty helpful at this point. Thanks, Ian On Wed, Aug 27, 2014 at 9:11 AM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Agree, over android it looks good, however running the tests over Windows Phone, the final count is 13 new fails. Specs failing: 9, 9.5, 10, 11, 15, 24, 82, 110, 116, 121, 122, 123, 124. 2014-08-26 11:20 GMT-05:00 Marcel Kinard cmarc...@gmail.com: Thanks, Ian! On Android 4.4, I'm now getting no failures with the all the automatic tests (new-style plugin tests and old-style non-plugin tests). Now to start poking at the manual tests... On Aug 26, 2014, at 11:27 AM, Ian Clelland iclell...@chromium.org wrote: The other issue should be resolved now, but if someone with a WP8 device can test it out as well, it'd be appreciated. -- Regards, Martin Gonzalez -- Regards, Martin Gonzalez -- Regards, Martin Gonzalez
[GitHub] cordova-blackberry pull request: CB-7250 test/cordova/integration/...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-blackberry pull request: CB-7250 test/cordova/integration/...
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/174 CB-7250 test/cordova/integration/target use private home This prevents the test from destroying blackberry10.json You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-blackberry cb_7250 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-blackberry/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 commit faf0735070efb3cf3369c32f2b9dde732e8c4dee Author: Josh Soref jso...@blackberry.com Date: 2014-08-15T15:49:55Z CB-7250 test/cordova/integration/target use private home This prevents the test from destroying blackberry10.json --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-blackberry pull request: CB-7250 test/cordova/integration/...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/174#issuecomment-52322030 r? @bryanhiggins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...
Github user mmocny commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/41#issuecomment-52351394 Looks good, but I didn't test on windows. Additionally, we should write define/it helpers that accept a list of platforms to include/exclude so that we don't have to handle this inline. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/41 Add missing test, skip some specs on wp Added in a few things that were added to mobile-spec after tests were initially ported: -new find method spec -specs which require manual user confirmation on wp are skipped You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-plugin-contacts skipOnWindows Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit ceed0b783aa0179bfdafe7003e481f493cd4ec84 Author: Staci Cooper smcoo...@us.ibm.com Date: 2014-08-14T19:51:59Z Add missing test, skip some specs on wp Added in a few things that were added to mobile-spec after tests were initially ported: -new find method spec -specs which require manual user confirmation on wp are skipped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: CB-6466 Created mobile-spec test
Github user stacic closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: CB-6466 Created mobile-spec test
Github user stacic commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/58#issuecomment-51940760 Yep, this needs to get added to plugin tests instead. I'll close this one and add a new PR to file-transfer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: Fix CB-7115: Add manual test for...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-contacts pull request: CB-7148 Ported contacts test...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-globalization pull request: Port globalization test...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
