Re: GSoc Code Merged Into Branch

2013-12-14 Thread Robert Burrell Donkin

On 12/10/13 07:15, Manuel Suárez Sánchez wrote:

Hi Robert,

After quite a battle, hopefully everything has now been committed onto the

branch. Please dive in and take a look, if you have a few spare cycles.



I look it and all are right.


Great :-)

Unless anyone jumps in, I'll take a look at merging this into trunk 
sometime soonish...


Robert



Re: Is it OK to commit to trunk?

2013-11-26 Thread Robert Burrell Donkin

On 11/26/13 20:58, Dennis Lundberg wrote:

All done!


Great :-)


On Tue, Nov 26, 2013 at 8:21 PM, Dennis Lundberg denn...@apache.org wrote:

Seems I spoke to soon...
I need to fix the failing tests first.

On Tue, Nov 26, 2013 at 8:19 PM, Dennis Lundberg denn...@apache.org wrote:

Hi Robert


Hi Dennis


All my changes have been checked into trunk now.
Feel free to merge when you have the time and strength for it.


I'm feeling good ATM, currently 375/555 commits into the merger of the 
GitHub code into the branch :-)



Give me a shout if you run into conflicts because of my changes.


Great I will do

I aspire to having the GSoc code in the subversion branch by the end of 
the week, so hopefully I'll be merging in your changes at the weekend :-)


Robert


Re: Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-09-03 Thread Robert Burrell Donkin

On 09/01/13 20:55, P. Ottlinger wrote:

Hi,

Am 01.09.2013 21:53, schrieb Robert Burrell Donkin:

http://svn.apache.org/repos/asf/creadur/rat/branches/apache-rat-project-0.10-website/
(unless anyone jumps in with a better name)


I'd propose 0.10-cms to make it clearer that it's just a cms-thing but
not a 'general' webpage?


Yes

Robert


Re: Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-09-03 Thread Robert Burrell Donkin

On 09/03/13 19:47, sebb wrote:

On 3 September 2013 19:34, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:

On 08/20/13 22:33, sebb wrote:

snip


I think the only thing that could be improved is to generate the
website from the 0.10 tag.



Hopefully this should be done now

If anyone has a few cycles, please give it a check...


The website header says Version: 0.11-SNAPSHOT
I don't understand that if it was created from the 0.10 branch.
I've just checked and the pom version is 0.10 as expected.


The commit messages into staging have 0.10

There's a commit message from staging into production

When I refresh, sometimes the production site says 0.10 and sometimes 
0.11-SNAPSHOT, so perhaps the production site hasn't completely 
synchronized yet...



Is there anything else that needs doing before issuing the announcement...?


Regenerate the website so it agrees with the release?


I'd like to give the production website a chance to sync before trying 
again :-/



I checked a mirror and it had the files.

However the Browse download area is pointing to the old area.


The 0.10 should have this fixed


Also the jars don't seem to be present on Maven Central - did you
publish the Nexus staging area?


IIRC, yes

I've checked in staging, and the rat release is no longer there

The release seems to be available from Apache

https://repository.apache.org/content/repositories/releases/org/apache/rat/apache-rat/0.10/

and is listed by

http://mvnrepository.com/artifact/org.apache.rat/apache-rat-core/0.10

Any particular jars that seem to be missing...?

Robert


Re: Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-09-03 Thread Robert Burrell Donkin

On 09/01/13 21:00, sebb wrote:

On 1 September 2013 20:53, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:

On 09/01/13 19:42, Robert Burrell Donkin wrote:


On 08/20/13 22:33, sebb wrote:

snip


I think the only thing that could be improved is to generate the
website from the 0.10 tag.

The website should reflect the current GA release, not trunk, which
does not correspond with a release.

The Maven guys complained about this, and on this point I agree with
them.



Sounds like a good plan.



The 0.10 tag misses the updated download page,


We should try and remember to fix that for the next release ...


How about using a parameter to substitute the current version during the 
build...?


Robert




Re: Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-09-03 Thread Robert Burrell Donkin

On 08/20/13 22:33, sebb wrote:

snip


I think the only thing that could be improved is to generate the
website from the 0.10 tag.


Hopefully this should be done now

If anyone has a few cycles, please give it a check...

Is there anything else that needs doing before issuing the announcement...?

Robert


Re: Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-09-01 Thread Robert Burrell Donkin

On 09/01/13 19:42, Robert Burrell Donkin wrote:

On 08/20/13 22:33, sebb wrote:

snip


I think the only thing that could be improved is to generate the
website from the 0.10 tag.

The website should reflect the current GA release, not trunk, which
does not correspond with a release.

The Maven guys complained about this, and on this point I agree with
them.


Sounds like a good plan.


The 0.10 tag misses the updated download page, so we'll probably need to 
take a small branch from


http://svn.apache.org/repos/asf/creadur/rat/tags/apache-rat-project-0.10/

perhaps something like

http://svn.apache.org/repos/asf/creadur/rat/branches/apache-rat-project-0.10-website/

(unless anyone jumps in with a better name)

Robert



Re: Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-08-20 Thread Robert Burrell Donkin

On 08/18/13 21:11, Robert Burrell Donkin wrote:

On 08/17/13 21:09, Robert Burrell Donkin wrote:

Thanks for everyone who reviewed and voted. If anyone can spot any
mistakes, please jump in before Noon tomorrow, Sunday August 18[1].


No one has spotted a mistake with the count, so I've committed the
compressed archives into https://dist.apache.org/repos/dist/

Tomorrow (after giving the mirrors a chance to sync), the next step for
me will be to update the download page and archive Apache Rat 0.9 (from
https://dist.apache.org/repos/dist/).


The download page http://creadur.apache.org/rat/download_rat.cgi should 
now be pointed at Apache Rat 0.10 and Apache Rat 0.9 should now be 
archived. (If anyone has a few spare cycles, please take a quick look)


Unless I've forgotten anything else, I think we're just about ready for 
the announcements.


Robert



Apache Rat 0.10 Promoted [WAS Re: [RESULT][VOTE] Release Apache Rat 0.10]

2013-08-18 Thread Robert Burrell Donkin

On 08/17/13 21:09, Robert Burrell Donkin wrote:

Thanks for everyone who reviewed and voted. If anyone can spot any
mistakes, please jump in before Noon tomorrow, Sunday August 18[1].


No one has spotted a mistake with the count, so I've committed the 
compressed archives into https://dist.apache.org/repos/dist/


Tomorrow (after giving the mirrors a chance to sync), the next step for 
me will be to update the download page and archive Apache Rat 0.9 (from 
https://dist.apache.org/repos/dist/).


Robert



[RESULT][VOTE] Release Apache Rat 0.10

2013-08-17 Thread Robert Burrell Donkin

I count:

+1's
 Robert Burrell Donkin (binding)
 Phil Ottlinger (not binding)
 sebb (binding)
 Dennis Lundberg (binding)

Thanks for everyone who reviewed and voted. If anyone can spot any 
mistakes, please jump in before Noon tomorrow, Sunday August 18[1].


Unless a problem is found with this tally then this candidate will 
become the official Apache Rat 0.10 release. Then I will then move the 
compressed archives to the Creadur distribution directory and promote 
the remaining jars to the main Nexus repository.


Robert
[1] http://www.timeanddate.com/worldclock/fixedtime.html?iso=20130818T12


Re: [RAT] Pipelines...

2013-08-15 Thread Robert Burrell Donkin

On 08/05/13 15:47, Marshall Schor wrote:

snip


It may be overkill ( :-) ), however, the Apache UIMA project has this very idea
of enabling assembly of components in a pipeline, and passing a thing (called
the CAS - Common Annotation Structure/System) to each annotator component,
which may add arbitrary metadata info to the CAS.

For intro, see the getting started parts of the documentation at 
uima.apache.org.


Quite possibly overkill but interesting :-)

Thanks for the link, Marshall, and glad to see UIMA seems to be going 
strong :-)


Robert


[RAT] Pipelines...

2013-08-05 Thread Robert Burrell Donkin

Essentially, Rat is simple.

A source (perhaps a file system or a compressed archive) is walked, 
producing documents. Each document (perhaps a file in a file system, or 
a resources in an archive) flows through a pipeline - a series of 
processing steps, enriching with various meta-data. An end point 
collates the data.


It seems to me that the current code fails to express this

...

At the moment, IDocumentAnalyser[1] is implemented by most steps in the 
pipeline (and other stuff too), wired together in a potentially flexible 
fashion. This now seems over-engineered to me.


I think a concrete Pipeline would be more obvious, with controlled 
extension points at each step of the processing.


Opinions...?
Objections...?

Robert
[1] 
http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/document/IDocumentAnalyser.java?view=markup


Apache Rat 0.10 Release Candidate Staged for Review [WAS Re: Apache Rat 0.1 Release Candidate Staged for Review]

2013-08-04 Thread Robert Burrell Donkin

Doh!

On 08/04/13 20:18, Robert Burrell Donkin wrote:

I've cut and uploaded a Apache Rat 0.1 release candidate to the Nexus

^^
This of course should be Apache Rat 0.10

Apologies

Robert


RAT: IHeaderMatcher Design

2013-07-12 Thread Robert Burrell Donkin
Rat spends a lot of effort parsing textual documents, looking for 
headers and boilerplate text. There's an extension point (of sorts) for 
the searches that can be performed, provided by IHeaderMatcher[1].


This interface has a few TODOs in. It's used by pushing the text in one 
line at a time, after doing some pre-processing. As the TODO indicates, 
this may not the most elegant design.


As an extension point, IHeaderMatcher has the advantage of flexibility. 
It would be possible to plug in radically different implementations. It 
turns out, though, that few clever new implementations have emerge. All 
implementations seem to do is check for license headers.


One disadvantage of this arrangement is that it pushes some of the 
parsing outwards toward supposedly pluggable implementations. This means 
that adding new licenses means adding a partial parser.


I wonder whether it might be more intuitive (as well as opening 
potential for faster parsing) to use immutable domain objects for 
licenses and so on, making them data rather than processors.


Opinions...? Alternatives...?

Robert

[1]
/**
* Resets this matches.
* Subsequent calls to {@link #match} will accumulate new text.
*/
public void reset();

/**
* Matches the text accumulated to licenses.
* TODO probably a poor design choice - hope to fix later
* @param subject TODO
* @param line next line of text, not null
* @return TODO
*/
public boolean match(Document subject, String line) throws 
RatHeaderAnalysisException;


http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-core/src/main/java/org/apache/rat/analysis/IHeaderMatcher.java?revision=1396305view=markup


Re: RAT: tidied up source/binary archives

2013-07-10 Thread Robert Burrell Donkin

On 07/10/13 14:21, sebb wrote:

snip


Just wondering whether the index.apt.vm files from CLI and Ant-tasks
could be converted into stand-alone text files that could be
incorporated into the binary archive?


Potentially...


This would be better for offline use.
At present the documentation is only on the web-site.


Agreed

I think it might be better to edit them into text for this release, 
enabling an earlier release. We would then have time to consider a more 
elegant solution a little later...


Robert


Re: RAT: tidied up source/binary archives

2013-07-09 Thread Robert Burrell Donkin

On 07/08/13 23:09, sebb wrote:

The binary archive now contains only the CLI/Ant bundled jar plus NL
and README.

I removed all the other jars, but it would be easy enough to copy the
binary jars from the other modules (core, ant, plugin) if it was
thought useful.

The source archives are also created by the apache-rat (CLI) module.

I disabled the default source zip provided by the Apache POM as it's not useful.

Hopefully that will suit end-users better.

The command I used was:

mvn package -Papache-release

Comments welcome!


I like it :-)

Thanks


Provided that the new archive contents are acceptable, I think the
only other job needed is to review the website, and then I hope we're
ready for a release.


Great

Robert


Re: [GSOC] Rat: Past, Present and Future

2013-07-09 Thread Robert Burrell Donkin

On 07/08/13 21:41, sebb wrote:

On 8 July 2013 20:46, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:


snip


2. analyse this model against policies, building a strongly-typed, immutable
report model


Won't that require lots of memory?


Not sure about lots (the state required should be relatively small) but 
yes, more



At present the source can be forgotten as soon as a match occurs.


Perhaps

An architecture where each document flowed through the system is likely 
to be more efficient and easier to parallelism.


However, I think that the current streaming design isn't particularly 
intuitive or obvious. I would be happy to retain an improved streaming 
design.


Robert


Re: RAT: dependency NL files

2013-07-08 Thread Robert Burrell Donkin

On 07/08/13 19:51, sebb wrote:

The apache-rat module which creates the distributions contains Notice
and License files for all the Commons dependencies.

I think these are now unnecessary, as they are the same as for RAT itself.


Quite possibly...


Commons Compress 1.5 no longer has any 3rd party notices in the NOTICE file


:-)

If the binary distribution just contains one shaded artefact then the 
composite notice should be enough, I think


Robert


[GSOC] Rat: Past, Present and Future

2013-07-08 Thread Robert Burrell Donkin

The Past

(Here's my perspective on the history of Rat, as I recall it now. 
Hopefully it isn't too controversial. Please feel free to jump in with 
clarifications...)


Rat arose from an itch of mine, and I coded the core of Rat as an 
experimental project, playing around with some unconventional 
architectural ideas. With hindsight, once other people wanted to start 
using it too, I really should have just sat down and completely 
rewritten the core code. By not doing so, I inflicted a world of 
craziness and pain on the community and ecology which sprang up around 
Rat. But by then, it had become hard to fix as higher quality peripheral 
code sprang up around it. Apologies.


The Present
---
Thanks to Manuel Suárez Sánchez and GSOC, we have an opportunity to 
adopt a more sane and sensible core design with good test coverage that 
will be easier and more enjoyable to maintain and comprehend going forward.


AIUI Google likes to be able to access a copy of the GSOC code, so I've 
suggested that Manuel codes on GitHub 
(https://github.com/elnuma/creadur-rat). Hopefully, this should allow 
people with GitHub forks (mine is 
https://github.com/itstechupnorth/creadur-rat) to pull in Manuel's code 
and give encouragement and advice. Apache has recorded an ICLA for 
Manuel, so when we're ready we should be able to start patching in pull 
requests.


The Future
--
(Bit of a strawman - hopefully the community - including Manuel - will 
dive in with suggestions and we'll be able to gain consensus on a design 
direction...)


...

I wonder whether it would be simpler and more conventional to factor out 
three phases:


1. scan the source, building a strongly-typed, immutable domain model
2. analyse this model against policies, building a strongly-typed, 
immutable report model

3. use the report to output descriptive text or XML, or errors and warnings

I also think that Rat would benefit from

* using more conventional dependency injection (see, for example, 
http://www.martinfowler.com/articles/injection.html) replacing the 
static methods that litter the code

* immutable domain objects with builders

Opinions...? Improvements...? Objections...? Alternatives...?

Robert


Re: [GSOC] Rat: Past, Present and Future

2013-07-08 Thread Robert Burrell Donkin

On 07/08/13 21:10, P. Ottlinger wrote:

snip


I would prefer more configuration options to use Rat on projects that
are not Apache2-licensed only. This could be done when all configuration
objects have interfaces and user-specific implementations can be
injected or chosen as defaults.


+1


Apart from the stuff you mentioned I'd prefer to inject the
configuration as well to not pollute pom.xml files with that - currently
it's quite a pain to use the tool since you have to configure rat twice.


+1

Robert



Re: Setting Up Release Directory...?

2013-07-06 Thread Robert Burrell Donkin

On 06/20/13 03:54, David Crossley wrote:

Good stuff Seb. I removed the old Incubator release, etc.


Thanks

Robert



Ready to Announce The Release ...? [WAS Re: Setting Up Release Directory...?]

2013-07-06 Thread Robert Burrell Donkin

On 06/19/13 14:38, sebb wrote:

snip


Sorry about the repeated checkins; I think it's all OK now.


Great :)

Am I safe to announce the release now...?

Robert



Re: Standardise Maven layout for assembly descriptors

2013-07-06 Thread Robert Burrell Donkin

On 07/02/13 20:41, P. Ottlinger wrote:

Am 27.06.2013 13:25, schrieb sebb:

Unless I hear otherwise, I propose to standardise the location (and
fix the pom).


+1


+1

Thanks

Robert


Re: Your Gump Build(s)

2013-07-06 Thread Robert Burrell Donkin

On 06/25/13 19:43, P. Ottlinger wrote:

Hi *,

Am 24.06.2013 15:20, schrieb Stefan Bodewig:

Before we re-enable emails we'd like to know whether you are still
interested in the service Gump provides, so please tell us. :-)


+1

Why not - since I don't know any details about the infrastructure I'd
propose to just enable the gump builds with notifications to the dev-list.


+1


Is there a Jenkins-CI infrastructure available?


Yes

And build-bot

(IIRC gump was originally developed to give early warning about future 
incompatibilities, specializing in build everything against the latest 
of all its Apache dependencies.)


Unless someone beats me to it, I'll poke around and try to find out the 
current state of play...


Robert



Rat 0.9 Release...

2013-05-09 Thread Robert Burrell Donkin
This being the first Creadur release as a TLP, there's quite a lot of 
infrastructure set-up which still needs to be completed...


I'm thinking of starting to outlined an release page now, which can be 
finished once the infrastructure work is complete.


Opinions?

Some other projects make the documentation for their releases available 
online. I like this idea, and we could do this by generating the 0.9 
documentation and committing it to the website CMS.


Opinions? Suggestions?

Robert


Moving Rat On From 0.9

2013-05-09 Thread Robert Burrell Donkin
I've been treading water recently, hoping to polish off the 0.9 release 
before starting to work again on the code base. This hasn't happened 
yet, so perhaps it's time to get moving again...


Opinions?

Robert


Re: RAT maven plugin: exclude not working

2013-05-09 Thread Robert Burrell Donkin

On 05/08/13 17:25, Erik-Lân Do Dinh wrote:

Hi Robert and Phil,


Hi Erik


thank you for your responses.


And thanks for your post - feedback from users is essential


There won't be any JIRA issue because I found out the error's on my side ;)
I ran maven from eclipse directly with goal rat:check instead of e.g.
verify; that's why it wasn't picking up any configuration options I
specified.


I wonder whether improving the logging in this area would be worthwhile...


Now I've bound rat:check to the verify phase and it uses the exclusions
I specified.


I'm considering about writing this up in the FAQ...

Opinions...?

Robert


[WAS [RESULT][VOTE] Release Apache Rat 0.9]

2013-04-23 Thread Robert Burrell Donkin

On 04/21/13 21:19, Robert Burrell Donkin wrote:

snip


I've deleted the tarballs then promoted orgapachecreadur-039. This is
the first release for Creadur, so I'll need to pick up the graduation
tasks associated with the first release and set up distribution
directories next...


The distribution directory hasn't been created yet[1] and I lack the 
required karma. I've opened an INFRA[2] but if anyone has any tips, 
please jump in :-)


Robert
[1] http://www.apache.org/dev/release-publishing.html#distribution_dist
[2] https://issues.apache.org/jira/browse/INFRA-6194


Re: [RESULT][VOTE] Release Apache Rat 0.9

2013-04-21 Thread Robert Burrell Donkin

On 04/17/13 20:15, Robert Burrell Donkin wrote:

snip


Given that I do not distribute the tarballs through Maven Central, I count:

+0 Phil Ottlinger (non-binding)
+1 Stefan Bodewig (binding)
+1 Robert Burrell Donkin (binding)
+1 Jochen Wiedmann (binding)

By my count, this approves orgapachecreadur-039 for promotion.


I've deleted the tarballs then promoted orgapachecreadur-039. This is 
the first release for Creadur, so I'll need to pick up the graduation 
tasks associated with the first release and set up distribution 
directories next...


Robert



[RESULT][VOTE] Release Apache Rat 0.9

2013-04-17 Thread Robert Burrell Donkin

On 03/31/13 13:59, Robert Burrell Donkin wrote:

The candidate staged at
https://repository.apache.org/content/repositories/orgapachecreadur-039/
(orgapachecreadur-039) is ready for review. Please download, check and
then cast your vote (see [1]).

Release votes are by majority approval. All are welcome and indeed
encouraged to vote, but only PMCers are binding on Apache. (See [2])

At least three binding +1's are required to promote this candidate to an
official Apache release.


I'm going to tally this VOTE now. It's been a little messy so please 
jump in and correct any mistakes I've made...


Given that I do not distribute the tarballs through Maven Central, I count:

+0 Phil Ottlinger (non-binding)
+1 Stefan Bodewig (binding)
+1 Robert Burrell Donkin (binding)
+1 Jochen Wiedmann (binding)

By my count, this approves orgapachecreadur-039 for promotion. If anyone 
has any objections or questions, please jump in before Saturday.


Robert



Re: PatternSyntaxException when trying rat -E

2013-04-07 Thread Robert Burrell Donkin

On 04/05/13 04:09, sebb wrote:

On 4 April 2013 20:42, Peter Hartmann mailbox@gmail.com wrote:


snip


It looks like Apache RAT 0.8 uses standard Java wildcard regex file
matching, whereas the original RAT used a different set of wildcard
meta-characters - more like the syntax used by Maven and Ant.

The intended wildcard support does not appear to be documented anywhere, so
it's not clear whether the change is intentional or not.


I'm not sure this is intentional either :-/


I've always found the Maven and Ant syntax styles more intuitive than 
the Java standard.


I'd be happy to support more than one wildcard syntax (provided we 
document them :-)


Robert



Re: [VOTE] Release Apache Rat 0.9

2013-04-07 Thread Robert Burrell Donkin

On 04/03/13 20:37, Jochen Wiedmann wrote:

I'm +1 for publishing the site as it is. No problems with such small
archives going to Maven Central.


(Just for the record) are you still +1 if I publish the tar-balls to 
www.apache.org/dist (as Stefan asks) ...?


Robert



Re: [VOTE] Release Apache Rat 0.9

2013-04-02 Thread Robert Burrell Donkin

On 04/02/13 05:31, Stefan Bodewig wrote:

On 2013-03-31, Robert Burrell Donkin wrote:


The candidate staged at
https://repository.apache.org/content/repositories/orgapachecreadur-039/
(orgapachecreadur-039) is ready for review. Please download, check and
then cast your vote (see [1]).


Do you intend to move the distribution tarballs to www.apache.org/dev?
Can't recall whether we are already using svnpubsub for releases.

Personally I'm not fond of putting the tarballs into Maven central at
all but haven't found a way to avoid it myself either (I usually remove
them manually before closing the staging repository).


Sounds like a good plan

(For 0.10, I'd like to reconsider our distributions...)

Robert


Re: [whisker][tentacles] Read Only Git Mirrors

2013-04-01 Thread Robert Burrell Donkin

On 03/29/13 09:19, Robert Burrell Donkin wrote:

Rat has a read only git mirror[1] but we haven't set up mirrors for
tentacles and whisker. I'm wondering whether this would be worthwhile...


Not sure how worthwhile these mirrors but I'm interested to find out. 
Any other opinions on this?


Robert



[tentacles] Interfaces and Abstract Classes

2013-04-01 Thread Robert Burrell Donkin
For open source libraries, I think it worthwhile to invest extra effort 
to maintain binary compatibility. So, (when creating libraries in Java) 
I model interfaces as a empty abstract classes, allowing more 
evolutionary freedom without breaking binary compatibility.


For application code, I think that it more obvious to model an interface 
with an interface. When in this mode, I lean towards prefixing with 'I' 
(rather than suffixing or prefixing implementations with Impl or Default).


I see tentacles as an application, so I lean towards conventional 
application coding style and am less concerned about being able to 
maintain binary compatibility going forward.


Opinions? Objections?

Robert


Re: [VOTE] Release Apache Rat 0.9

2013-03-31 Thread Robert Burrell Donkin

Here's my +1

On 03/31/13 13:59, Robert Burrell Donkin wrote:

--8--
[X] +1 Release orgapachecreadur-039 as Apache Rat 0.9
[ ] +0 In favour of release but have not checked release
[ ] -0 Lean against release
[ ] -1 Do not release orgapachecreadur-039 as Apache Rat 0.9
--8--




[VOTE] Release Apache Rat 0.9

2013-03-31 Thread Robert Burrell Donkin
The candidate staged at 
https://repository.apache.org/content/repositories/orgapachecreadur-039/ 
(orgapachecreadur-039) is ready for review. Please download, check and 
then cast your vote (see [1]).


Release votes are by majority approval. All are welcome and indeed 
encouraged to vote, but only PMCers are binding on Apache. (See [2])


At least three binding +1's are required to promote this candidate to an 
official Apache release.


I will tally this vote no earlier than 1500 Sunday April 7 UTC [3]

Robert
[1] http://www.apache.org/dev/release.html#approving-a-release
[2] http://www.apache.org/foundation/voting.html
[3] http://www.timeanddate.com/worldclock/fixedtime.html?iso=20130407T15

--8--
[ ] +1 Release orgapachecreadur-039 as Apache Rat 0.9
[ ] +0 In favour of release but have not checked release
[ ] -0 Lean against release
[ ] -1 Do not release orgapachecreadur-039 as Apache Rat 0.9 
--8--


Re: Staging Another Candidate for Rat 0.9 [WAS Re: Issue with orgapachecreadur-019]

2013-03-30 Thread Robert Burrell Donkin

On 03/29/13 08:58, Robert Burrell Donkin wrote:

On 03/28/13 10:17, Robert Burrell Donkin wrote:

On 03/26/13 20:37, sebb wrote:


snip


Not sure you need to worry about the files escaping from the staging
repo - that's part of the point, they are not yet published files.
So long as you delete the repo they won't be published.


Yes, now that the repo has been dropped, escape is unlikely

I'm comfortable with either trying a 0.9 again or cutting a 0.9.1

Is there consensus that trying again to cut a 0.9 release would be the
best approach?


Assuming no one jumps in sometime soon, I'll assume lazy consensus[1]
for staging a second Apache Rat 0.9 candidate.


Okay - I plan to cut a second Apache Rat 0.9 candidate now

Robert



orgapachecreadur-039 [Re: Staging Another Candidate for Rat 0.9]

2013-03-30 Thread Robert Burrell Donkin

On 03/30/13 09:27, Robert Burrell Donkin wrote:

On 03/29/13 08:58, Robert Burrell Donkin wrote:

On 03/28/13 10:17, Robert Burrell Donkin wrote:

On 03/26/13 20:37, sebb wrote:


snip


Not sure you need to worry about the files escaping from the staging
repo - that's part of the point, they are not yet published files.
So long as you delete the repo they won't be published.


Yes, now that the repo has been dropped, escape is unlikely

I'm comfortable with either trying a 0.9 again or cutting a 0.9.1

Is there consensus that trying again to cut a 0.9 release would be the
best approach?


Assuming no one jumps in sometime soon, I'll assume lazy consensus[1]
for staging a second Apache Rat 0.9 candidate.


Okay - I plan to cut a second Apache Rat 0.9 candidate now


Done

https://repository.apache.org/content/repositories/orgapachecreadur-039/

Please feel free to take a look. I'll have a poke around, and if it 
looks okay I'll move towards a VOTE tomorrow.


Robert


Staging Another Candidate for Rat 0.9 [WAS Re: Issue with orgapachecreadur-019]

2013-03-29 Thread Robert Burrell Donkin

On 03/28/13 10:17, Robert Burrell Donkin wrote:

On 03/26/13 20:37, sebb wrote:

On 26 March 2013 12:18, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:


snip


I'm less sure about the best approach to numbering this new
candidate. (In
the past, I've cut release candidates first. Even with a staging
repository
this would have been sensible.) I lean towards 0.9.1, eliminating any
risk
that two signed 0.9 could escape into the wild.

Opinions? Objections? Suggestions?


Not sure you need to worry about the files escaping from the staging
repo - that's part of the point, they are not yet published files.
So long as you delete the repo they won't be published.


Yes, now that the repo has been dropped, escape is unlikely

I'm comfortable with either trying a 0.9 again or cutting a 0.9.1

Is there consensus that trying again to cut a 0.9 release would be the
best approach?


Assuming no one jumps in sometime soon, I'll assume lazy consensus[1] 
for staging a second Apache Rat 0.9 candidate.


Robert
[1] http://community.apache.org/committers/consensusBuilding.html


Re: [tentacles] assertions

2013-03-29 Thread Robert Burrell Donkin

On 03/28/13 18:00, David Blevins wrote:

snip


And I wrote the stinking code.


I feel the same about the original Rat code base :-) And those design 
experiments still hurt Rat today...


So with Tentacles, probably worthwhile tidying up and cleaning up before 
pushing onwards


snip


Feel free to hack it up.


:-)


Side note, wow I didn't know anyone but be had ever used tentacles :)


I have some scripts which do similar stuff, so having Tentacles here has 
given me the impetus to start working on better solutions :-)


I've been wondering whether Tentacles might be a good GSOC project for a 
student who's interested more in solving human problems than hard core 
technical coding. Perhaps run as a Agile project, weekly sprints going 
back to people in the Incubator and other projects for new features. 
Opinions welcomed :-)


Robert


Re: [tentacles] Continuous Integration...?

2013-03-29 Thread Robert Burrell Donkin

On 03/25/13 11:47, Robert Burrell Donkin wrote:

I can't see a continuous integration build for tentacles yet (please
jump and correct me if I'm mistaken). Might be a good time to add a
buildbot and/or jenkins build.


Unless another jumps in sometime soon, I'll sort some CI stuff out...

Robert



Re: [tentacles] JIRA...?

2013-03-29 Thread Robert Burrell Donkin

On 03/24/13 09:29, Robert Burrell Donkin wrote:

I can't see[1] a JIRA project for tentacles[2]. Perhaps it's time we
created one.


I think this would be a good idea. Unless anyone jumps in, I'll sort 
something out


Robert


[whisker][tentacles] Read Only Git Mirrors

2013-03-29 Thread Robert Burrell Donkin
Rat has a read only git mirror[1] but we haven't set up mirrors for 
tentacles and whisker. I'm wondering whether this would be worthwhile...


Opinions? Objections? Suggestions?

Robert
[1] http://git.apache.org/


Re: Issue with orgapachecreadur-019 [WAS Re: Staging Apache Rat 0.9]

2013-03-28 Thread Robert Burrell Donkin

On 03/26/13 20:37, sebb wrote:

On 26 March 2013 12:18, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:


snip


I'm less sure about the best approach to numbering this new candidate. (In
the past, I've cut release candidates first. Even with a staging repository
this would have been sensible.) I lean towards 0.9.1, eliminating any risk
that two signed 0.9 could escape into the wild.

Opinions? Objections? Suggestions?


Not sure you need to worry about the files escaping from the staging
repo - that's part of the point, they are not yet published files.
So long as you delete the repo they won't be published.


Yes, now that the repo has been dropped, escape is unlikely

I'm comfortable with either trying a 0.9 again or cutting a 0.9.1

Is there consensus that trying again to cut a 0.9 release would be the 
best approach?


Robert


Re: Issue with orgapachecreadur-019 [WAS Re: Staging Apache Rat 0.9]

2013-03-28 Thread Robert Burrell Donkin

On 03/28/13 10:17, Robert Burrell Donkin wrote:

On 03/26/13 20:37, sebb wrote:

On 26 March 2013 12:18, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:


snip


I'm less sure about the best approach to numbering this new
candidate. (In
the past, I've cut release candidates first. Even with a staging
repository
this would have been sensible.) I lean towards 0.9.1, eliminating any
risk
that two signed 0.9 could escape into the wild.

Opinions? Objections? Suggestions?


Not sure you need to worry about the files escaping from the staging
repo - that's part of the point, they are not yet published files.
So long as you delete the repo they won't be published.


Yes, now that the repo has been dropped, escape is unlikely

I'm comfortable with either trying a 0.9 again or cutting a 0.9.1

Is there consensus that trying again to cut a 0.9 release would be the
best approach?


A good fix turned out to be fiddle, so I committed a workaround[1] for 
the issue. I'm ready to try staging another candidate.


Robert
[1] http://svn.apache.org/viewvc?view=revisionrevision=1462047




[tentacles] assertions

2013-03-26 Thread Robert Burrell Donkin
Tentacles is a little unusual in using Java assertions. When assertions 
are off, then [1] no longer works as expected (rather than running with 
debugging checks off).


For applications in runnable jars, I think using assertions to allow 
debugging is a cool idea - controlling logging levels is sometimes 
tricky in this situation. However - by the principle of least surprise - 
when on the golden path, I think tentacles should function correctly 
whether assertions are on or off.


Opinions?

Robert
[1] 
http://svn.apache.org/viewvc/creadur/tentacles/trunk/src/main/java/org/apache/creadur/tentacles/Files.java?revision=1355691view=markup


Issue with orgapachecreadur-019 [WAS Re: Staging Apache Rat 0.9]

2013-03-26 Thread Robert Burrell Donkin

On 03/24/13 18:21, Robert Burrell Donkin wrote:

On 03/24/13 09:26, Robert Burrell Donkin wrote:

On 03/23/13 11:39, Robert Burrell Donkin wrote:

Unless anyone jumps in sometime soon with an issue with the latest[1]
snapshot[2], following the guidelines[3] I hope to cut a 0.9 and upload
it to the staging repository.


Hopefully we have lazy consensus on this. I hope to cut this later today.


After a little bit of a battle, I've pushed to staging[1]. Before I move
on to a VOTE, I hope to take a look using tentacles


Unfortunately, I didn't check that the build for the apache-rat runnable 
uber-jar uses the maven-shade plugin :-( This means that the jar is 
missing NOTICE files for the Apache Licensed dependencies included 
within the jar. Apologies.


All the dependences involved are Apache Software Foundation releases. 
Unless anyone spots something, I can't see this mistake posing a legal 
risk to downstream users.


So, unless anyone jumps in, I'll just go ahead to fix the issue in 
trunk, delete the staging repository and then think about cut another 
candidate.


I'm less sure about the best approach to numbering this new candidate. 
(In the past, I've cut release candidates first. Even with a staging 
repository this would have been sensible.) I lean towards 0.9.1, 
eliminating any risk that two signed 0.9 could escape into the wild.


Opinions? Objections? Suggestions?

Robert


Re: Issue with orgapachecreadur-019 [WAS Re: Staging Apache Rat 0.9]

2013-03-26 Thread Robert Burrell Donkin

On 03/26/13 12:18, Robert Burrell Donkin wrote:

snip


Unfortunately, I didn't check that the build for the apache-rat runnable
uber-jar uses the maven-shade plugin :-( This means that the jar is
missing NOTICE files for the Apache Licensed dependencies included
within the jar. Apologies.


The reason why we don't use the shade plugin is that it requires Maven 
3. I'll try a less elegant work around...


Robert


[tentacles] Running Tentacles

2013-03-25 Thread Robert Burrell Donkin
I'm hoping to use tentacles to help review the Rat release but I'm 
having some problems running the jar. Unless anyone jumps in, I'll 
probably just jump in and fix them.


I've also been wondering about integration tests. In the past, I've 
found that it's easy to break a build which creates a runnable jar. It 
should be reasonable straightforward to run some basic smoke tests using 
Maven. Even a test as simple as running help without reporting an error 
might be useful.


Opinions welcomed :-)

Robert


[tentacles] Continuous Integration...?

2013-03-25 Thread Robert Burrell Donkin
I can't see a continuous integration build for tentacles yet (please 
jump and correct me if I'm mistaken). Might be a good time to add a 
buildbot and/or jenkins build.


Opinions? Objections? Suggestions?

Robert


Re: [tentacles] Running Tentacles

2013-03-25 Thread Robert Burrell Donkin

On 03/25/13 11:38, Robert Burrell Donkin wrote:

I'm hoping to use tentacles to help review the Rat release but I'm
having some problems running the jar. Unless anyone jumps in, I'll
probably just jump in and fix them.


Turns out that the jar that has the main class is one the 
'with-dependencies'. I'll correct the documentation in due course, but I 
was wondering:


* whether this is the best name (would apache-tentacles-app.jar, 
apache-tentacles-run.jar be more expressive? not sure...)
* whether it would be worthwhile to switching now to a more powerful 
plugin (shade[1] rather than assembly)


Opinions? Objections? Suggestions?

Robert
[1] http://maven.apache.org/plugins/maven-shade-plugin/


[tentacles] Factoring Out Nested Classes?

2013-03-25 Thread Robert Burrell Donkin
Tentacles uses a lot of nested classes. I tend to prefer to keep one 
class per file where possible (makes merging changes easier, for 
example) but I wanted to check whether there were any objections to me 
factoring out these classes - or whether anyone knows a reason why this 
might be a bad idea...?


Robert


Re: Staging Apache Rat 0.9

2013-03-24 Thread Robert Burrell Donkin

On 03/23/13 11:39, Robert Burrell Donkin wrote:

Unless anyone jumps in sometime soon with an issue with the latest[1]
snapshot[2], following the guidelines[3] I hope to cut a 0.9 and upload
it to the staging repository.


Hopefully we have lazy consensus on this. I hope to cut this later today.

Robert


[tentacles] JIRA...?

2013-03-24 Thread Robert Burrell Donkin
I can't see[1] a JIRA project for tentacles[2]. Perhaps it's time we 
created one.


Opinions? Objections? Suggestions?

Robert
[1] https://issues.apache.org/jira/secure/BrowseProjects.jspa#11060
[2] Tentacles helps when reviewing releases consisting of many artifacts 
uploaded to a repository


Staging Apache Rat 0.9

2013-03-23 Thread Robert Burrell Donkin
Unless anyone jumps in sometime soon with an issue with the latest[1] 
snapshot[2], following the guidelines[3] I hope to cut a 0.9 and upload 
it to the staging repository.


Once this is done I'll ask the community to review the release and vote. 
Everyone is encouraged to vote. Before the uploaded artefact can be 
blessed as a official Apache Software Foundation (ASF) release, at least 
three binding +1 votes and more +1 votes than -1 votes are needed (see 
[4] and [5] for more information). Votes from PMCers are bind the ASF.


(PMCers often add 'binding' to help tally the vote. Sometimes people add 
'non-binding'. Both are optional :-)


For more information on the way Apache project conduct themselves, 
browse [6]


Robert

[1] 0.9-20130323.083323
[2] 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/

[3] http://www.apache.org/dev/publishing-maven-artifacts.html#staging-maven
[4] http://www.apache.org/foundation/glossary.html#MajorityApproval
[5] www.apache.org/dev/release.html#distribute-raw-artifact
[6] http://community.apache.org/committers/index.html


GSoc2013 Ideas

2013-03-23 Thread Robert Burrell Donkin
With a little bit of luck, I hope to have enough typing time (outside 
work) and stability this summer to think about mentoring GSoc. If I 
submit some project ideas later today then we may not be too late.


Ideas:

* Refactor Apache Rat Core [1]
* License Lexicon [2]
* More Tentacles [3]
* Port Rat [4]

Opinions? Objections? Improvements?

If anyone else wants to dive in with new ideas, that would be very much 
appreciated - or just dive in and create them in JIRA.


For more information see:

http://www.google-melange.com/gsoc/homepage/google/gsoc2013
http://community.apache.org/guide-to-being-a-mentor.html
http://s.apache.org/gsoc2013ideas
http://community.apache.org/gsoc.html

Apologies for picking this up so late :-/

Robert

[1] Refactor Apache Rat Core

The base code for Apache Rat has issues which lead to a high bar for 
contribution:


* based on an experimental streaming architecture
* hard to understand
* poorly covered by edge-to-edge tests

For a student interested in agile test-first approaches and object 
oriented design, driving a new core with a conventional OOP design would 
be an interesting introduction to open source and would reduce the 
barriers to contribution.


[2] License Lexicon

Both Rat and Whiskers lack a comprehensive library and consistent 
terminology for licenses. This project would both compile a set of 
meta-data, plus support libraries which could be reused both by these 
projects and more widely. Collate comprehensive license meta-data, 
beginning with all OSI approved open source licenses and working 
outwards to include other common binary only licenses including:


* descriptions of common source boilerplates
* generation and recognition templates
* consistent language, both machine and human readable

This is most suitable for students whose interests focus more in 
semantics than coding. For students interested in text parsing, this 
data could be used to create fast parsers. For students interested in 
technology law, the semantics could be extend to include relationships 
between licenses. For students more interested in informatics, there 
would be an opportunity to work on a comprehensive collection. For all 
students, an opportunity to showcase communication skills.


[3] More Tentacles

Many open source projects at Apache face the problem that one release 
contains many libraries. Reviewing all these libraries without automated 
assistance takes time and is error prone. Tentacles builds on Rat to 
provide this assistance. This project will be organised in an agile 
fashion around a number of short sprints with direction determined by 
users in the Apache Incubator and elsewhere.


This is most suitable for a students who is interested in the wider 
process of developing software well fitting to the needs of users using 
an Agile process. Focus is essential for an open ended project like 
this, and adopting an Agile approach is well suited to ensuring success.


[4] Port Rat

Today, Apache Rat supports only Java. Ports to other other languages and 
build systems would help increase adoption beyond the Java community 
here at Apache.


* New languages eg Python, Ruby, JavaScript, CoffeeScript
* New build systems eg buildr

For a student interested in using a variety of languages, perhaps one 
language or build system per week.


[jira] [Created] (RAT-130) GSOC Port Apache Rat to New Languages, Integrate With New Build Systems

2013-03-23 Thread Robert Burrell Donkin (JIRA)
Robert Burrell Donkin created RAT-130:
-

 Summary: GSOC Port Apache Rat to New Languages, Integrate With New 
Build Systems 
 Key: RAT-130
 URL: https://issues.apache.org/jira/browse/RAT-130
 Project: Apache Rat
  Issue Type: Wish
Reporter: Robert Burrell Donkin


Apache Rat helps projects audit and comprehend the licenses qualities of the 
software they ship.

Today, Apache Rat is coded in Java and integrates with Apache Maven and Apache 
Ant (as well as the command line). Ports to other other languages and build 
systems would help increase adoption.

This would be an ideal project for a student interested in using a variety of 
languages (for example Ruby, Python, JavaScript and CoffeeScript) perhaps 
porting to a new language or build system each week.The exact scope of schedule 
would be negotiable.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (RAT-131) GSOC Refactor Apache Rat Core to a Classic Object Oriented Design

2013-03-23 Thread Robert Burrell Donkin (JIRA)
Robert Burrell Donkin created RAT-131:
-

 Summary: GSOC Refactor Apache Rat Core to a Classic Object 
Oriented Design
 Key: RAT-131
 URL: https://issues.apache.org/jira/browse/RAT-131
 Project: Apache Rat
  Issue Type: Wish
Reporter: Robert Burrell Donkin


The core code for Apache Rat has difficulties which lead to a high bar for 
contributions:

* based on an experimental streaming architecture
* hard to understand
* poorly covered by edge-to-edge tests

Replace this by a conventional object-oriented design with clear model based on 
the domain.

A good opportunity for a student interested in Agile, test-first approaches and 
domain-driven design with a good sense of object-oriented design to showcase 
their skills and learn about open source development. The emphasis would be on 
high quality, test-driven code driving a clear, well documented design,  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (RAT-132) GSOC License Lexicon

2013-03-23 Thread Robert Burrell Donkin (JIRA)
Robert Burrell Donkin created RAT-132:
-

 Summary: GSOC License Lexicon
 Key: RAT-132
 URL: https://issues.apache.org/jira/browse/RAT-132
 Project: Apache Rat
  Issue Type: Wish
Reporter: Robert Burrell Donkin


Apache Rat and Apache Whiskers are tools which help people to audit and 
comprehend licenses within releases. 

Both Rat and Whiskers lack both a comprehensive library and consistent 
terminology for licenses: a license lexicon. Though this ticket is raised under 
Rat, a successful GSOC would hopefully lead to the development of an 
independent product.

This GSOC project would both compile a set of meta-data, plus perhaps support 
libraries which could be reused both by these projects and more widely. Collate 
comprehensive license meta-data, beginning with all OSI approved open source 
licenses and working outwards to include other common binary only licenses. 
This meta-data might include:

* descriptions of common source boilerplates
* generation and recognition templates
* consistent language, both machine and human readable

This is most suitable for students whose interests focus more in semantics than 
coding. The scope and direction are negotiable.

For students interested in text parsing, this meta-data could be used to create 
fast parsers. For students interested in technology law, the semantics could be 
extend to include relationships between licenses. For students more interested 
in informatics, there would be an opportunity to work on a comprehensive 
collection. For all students, this is an opportunity to showcase communication 
skills. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Nexus Access Requested for Apache Rat

2013-03-17 Thread Robert Burrell Donkin
I've opened a ticket[1] requesting the access we need to Nexus to 
release Rat. If I've made any mistakes, please jump in. (Feel free to 
fix if you have karma.)


Robert

[1] https://issues.apache.org/jira/browse/INFRA-6005


Re: Upgrade to latest Apache Parent pom...?

2013-03-16 Thread Robert Burrell Donkin

On 03/11/13 18:46, sebb wrote:

On 11 March 2013 11:51, Robert Burrell Donkin
robertburrelldon...@blueyonder.co.uk wrote:

Rat currently inherits from an older version (9) of the Apache parent
pom[1]. This inheritance supplies lots of suitable defaults. Unless anyone
thinks this might be a poor plan, probably a good idea to upgrade to the
latest version[2] before cutting the release.

Opinions?


The current version fixes the following:

[MPOM-32] Apache POM 10 forces all child projects to generate the
project info reports

This was why Commons stuck to using version 9 until recently; perhaps
RAT did too.

Commons has now updated to the current version, and I've not seen
reports of any problems.

So I say go for it.


Committed :-)

I've regenerated the subsites[1][2], and they look okay to me. Please 
jump if anyone finds any issues (new or old ;-)...


Robert
[1] http://creadur.apache.org/whisker/
[2] http://creadur.apache.org/rat/



Re: Upgrade to latest Apache Parent pom...?

2013-03-14 Thread Robert Burrell Donkin

On 03/11/13 23:17, sebb wrote:

On 11 March 2013 21:05, P. Ottlinger pottlin...@aiki-it.de wrote:

Hi,

Am 11.03.2013 12:51, schrieb Robert Burrell Donkin:

Opinions?


+1
Go for it.

Should we raise the version of Java as well?



No.

That's completely different, as it affects end users directly.
The version of Java should only be increased if necessary to support
essential new features.
Otherwise it just prevents the code from running on some user systems
for no good reason.


For build tools like Apache Rat, I think that it's important to allow 
existing users to upgrade as easily as possible.


Robert



Website Refresh

2013-03-02 Thread Robert Burrell Donkin


I've tweaking and published the Rat subsite[2] and the main creadur 
site[1] now that ApacheCon NA is over. If anyone has a few moment to 
spare, please take a look so we can feed any improvements back into the 
0.9 release candidate.


(Unless anyone jumps in, I'll try to cut an RC sometime soon)

The maven scm publish process seems much smoother now (though still 
slow). Perhaps we should roll this out to the rest of the suite (Whisker 
and Tentacles). Opinions? Objections?


Robert

[1] http://creadur.apache.org/
[2] http://creadur.apache.org/rat/


[jira] [Closed] (RAT-127) Print report file location in error message

2013-03-01 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin closed RAT-127.
-


 Print report file location in error message
 ---

 Key: RAT-127
 URL: https://issues.apache.org/jira/browse/RAT-127
 Project: Apache Rat
  Issue Type: Wish
  Components: maven
Affects Versions: 0.8
 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse
Reporter: Bernd Eckenfels
Assignee: Robert Burrell Donkin
Priority: Minor
  Labels: maven, ux
 Fix For: 0.9

 Attachments: rat127.patch


 When running the RAT 0.8 maven plugin from command line (no POM entry for the 
 plugin) it will print a short error message how many violations it found, but 
 this message could be enhanced by pointing to the report file:
 C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml 
 org.apache.rat:apache-rat-plugin:check
 ...
 [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ proj ---
 ...
 [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check 
 (default-cli) on project proj: Too many unapproved licenses: 26 - [Help 1]
 Better:
 [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.8:check 
 (default-cli) on project proj: Too many unapproved licenses: 26. See 
 target/rat.txt

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository

2013-02-26 Thread Robert Burrell Donkin (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587516#comment-13587516
 ] 

Robert Burrell Donkin commented on RAT-126:
---

Executing a freshly built 0.9-SNAPSHOT from the command line also indicates 
that there are no excludes:

$ mvn org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check
[INFO] Scanning for projects...
[INFO] 
[INFO] 
[INFO] Building some-project 1.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- apache-rat-plugin:0.9-SNAPSHOT:check (default-cli) @ some-project ---
[INFO] No excludes
[INFO] Rat check: Summary of files. Unapproved: 3 unknown: 3 generated: 0 
approved: 0 licence.
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 2.673s
[INFO] Finished at: Tue Feb 26 20:38:26 GMT 2013
[INFO] Final Memory: 6M/245M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check (default-cli) on project 
some-project: Too many files with unapproved license: 3 See RAT report in: 
/opt/development/2012/kata/temp/some-project/target/rat.txt - [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException


 Default excludes do not ignore .git/ repository
 ---

 Key: RAT-126
 URL: https://issues.apache.org/jira/browse/RAT-126
 Project: Apache Rat
  Issue Type: Bug
  Components: maven
Affects Versions: 0.8
 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse
Reporter: Bernd Eckenfels
Priority: Minor

 When running the RAT 0.8 maven plugin from command line (no POM entry for the 
 plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin 
 will not by default exclude the repository dotdir.
 C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml 
 org.apache.rat:apache-rat-plugin:check
 ...
 [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp ---
 [INFO] No excludes
 ...
 The excludes should eighter be contained in the eclipse defaults or have its 
 own dotfile or scm category. A workaround would be to specify the excludes, 
 unfortunatelly there seems to be no expression associated with the exclude 
 property of the mojo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository

2013-02-26 Thread Robert Burrell Donkin (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587583#comment-13587583
 ] 

Robert Burrell Donkin commented on RAT-126:
---

The 'No excludes' message is quite confusing. I've improved this message and 
added extra debug logging. 

For me, mvn org.apache.rat:apache-rat-plugin:0.9-SNAPSHOT:check now ignores the 
.git/ directory, via plexus DirectoryScanner.DEFAULTEXCLUDES. I'm using mvn 
3.0.5.

So, I think this might be fixed. Please retest once the release candidate is 
available.



 Default excludes do not ignore .git/ repository
 ---

 Key: RAT-126
 URL: https://issues.apache.org/jira/browse/RAT-126
 Project: Apache Rat
  Issue Type: Bug
  Components: maven
Affects Versions: 0.8
 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse
Reporter: Bernd Eckenfels
Priority: Minor

 When running the RAT 0.8 maven plugin from command line (no POM entry for the 
 plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin 
 will not by default exclude the repository dotdir.
 C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml 
 org.apache.rat:apache-rat-plugin:check
 ...
 [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp ---
 [INFO] No excludes
 ...
 The excludes should eighter be contained in the eclipse defaults or have its 
 own dotfile or scm category. A workaround would be to specify the excludes, 
 unfortunatelly there seems to be no expression associated with the exclude 
 property of the mojo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line

2013-02-26 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin resolved RAT-125.
---

Resolution: Fixed

 Support applied ASL20 license headers, including checking for required 
 copyright header line
 

 Key: RAT-125
 URL: https://issues.apache.org/jira/browse/RAT-125
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.9
Reporter: Ate Douma
Assignee: Robert Burrell Donkin
 Fix For: 0.9

 Attachments: RAT-125.patch


 While checking on an ASL20 license header itself is supported by Apache Rat 
 (duh), properly checking an applied ASL20 license (for usage *outside* the 
 ASF) isn't supported yet.
 I've created an AppliedApacheSoftwareLicense20 check which does check this, 
 using the http://apache.org/licenses/LICENSE-2.0.html#apply template as 
 template (duh).
 This header matcher itself extends a more generic CopyrightHeader matcher, 
 which only takes care of the copyright header line validation, using a regex 
 pattern + configurable copyright owner.
 As an example the following configuration:
   plugin
 groupIdorg.apache.rat/groupId
 artifactIdapache-rat-plugin/artifactId
 version0.9-SNAPSHOT/version
 configuration
   licenses
 license 
 implementation=org.apache.rat.analysis.license.AppliedApacheSoftwareLicense20
   copyrightOwnerFooBar \(www\.foobar\.com\)/copyrightOwner
 /license
   /licenses
 /configuration
   /plugin
  
 will properly match a license header like:
Copyright 2012 FooBar (www.foobar.com)
Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an AS IS BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
  
 I'll attach a patch with the two header matchers + unit tests shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Closed] (RAT-125) Support applied ASL20 license headers, including checking for required copyright header line

2013-02-26 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin closed RAT-125.
-


Thanks for the patch

 Support applied ASL20 license headers, including checking for required 
 copyright header line
 

 Key: RAT-125
 URL: https://issues.apache.org/jira/browse/RAT-125
 Project: Apache Rat
  Issue Type: Improvement
Affects Versions: 0.9
Reporter: Ate Douma
Assignee: Robert Burrell Donkin
 Fix For: 0.9

 Attachments: RAT-125.patch


 While checking on an ASL20 license header itself is supported by Apache Rat 
 (duh), properly checking an applied ASL20 license (for usage *outside* the 
 ASF) isn't supported yet.
 I've created an AppliedApacheSoftwareLicense20 check which does check this, 
 using the http://apache.org/licenses/LICENSE-2.0.html#apply template as 
 template (duh).
 This header matcher itself extends a more generic CopyrightHeader matcher, 
 which only takes care of the copyright header line validation, using a regex 
 pattern + configurable copyright owner.
 As an example the following configuration:
   plugin
 groupIdorg.apache.rat/groupId
 artifactIdapache-rat-plugin/artifactId
 version0.9-SNAPSHOT/version
 configuration
   licenses
 license 
 implementation=org.apache.rat.analysis.license.AppliedApacheSoftwareLicense20
   copyrightOwnerFooBar \(www\.foobar\.com\)/copyrightOwner
 /license
   /licenses
 /configuration
   /plugin
  
 will properly match a license header like:
Copyright 2012 FooBar (www.foobar.com)
Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an AS IS BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
  
 I'll attach a patch with the two header matchers + unit tests shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Prepare Apache Rat 0.9...? [WAS Re: Last Orders for Rat 0.9]

2013-02-26 Thread Robert Burrell Donkin

On 02/18/13 21:47, Ate Douma wrote:

On 02/17/2013 12:18 PM, Robert Burrell Donkin wrote:

On 01/03/13 15:08, Ate Douma wrote:

snip


As you might have noticed, I've just created issue RAT-125 with an
enhancement which would be great if it could still be picked up before
the 0.9 release :)


Any other last minute requests...?


Nope, but getting RAT-125 applied would be great.


Applied :-)

I'd be happy to volunteer to act as release manager for Apache Rat 0.9 
based on trunk unless anyone else wants to jump in...


...I was thinking along the lines of updating the rat sub-site then 
cutting a release candidate straight from trunk but I don't have strong 
preferences. Opinions welcomed on current best practice :-)


Robert


[jira] [Commented] (RAT-126) Default excludes do not ignore .git/ repository

2013-02-19 Thread Robert Burrell Donkin (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581561#comment-13581561
 ] 

Robert Burrell Donkin commented on RAT-126:
---

Hi Bernd

We're pushing towards releasing Apache Rat 0.9 very soon. If you could supply a 
patch including appropriate tests, we might be able to squeeze a fix in. 
Otherwise, it will probably need to wait until 0.10 (though I hope we'll be 
able to release more often in the new future).

Robert

 Default excludes do not ignore .git/ repository
 ---

 Key: RAT-126
 URL: https://issues.apache.org/jira/browse/RAT-126
 Project: Apache Rat
  Issue Type: Bug
  Components: maven
Affects Versions: 0.8
 Environment: Windows 7, Maven 3.0.4, Oracle JDK 1.7.0_11, Eclipse
Reporter: Bernd Eckenfels
Priority: Minor

 When running the RAT 0.8 maven plugin from command line (no POM entry for the 
 plugin) in a Eclipse+Maven project which is checked out from .git/ the plugin 
 will not by default exclude the repository dotdir.
 C:\ws\proj\ws\apache-maven-3.0.4\bin\mvn -s ..\empty.xml 
 org.apache.rat:apache-rat-plugin:check
 ...
 [INFO] --- apache-rat-plugin:0.8:check (default-cli) @ et-otp ---
 [INFO] No excludes
 ...
 The excludes should eighter be contained in the eclipse defaults or have its 
 own dotfile or scm category. A workaround would be to specify the excludes, 
 unfortunatelly there seems to be no expression associated with the exclude 
 property of the mojo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Last Orders for Rat 0.9 [WAS Re: Prepare to Release Apache Rat 0.9...?]

2013-02-17 Thread Robert Burrell Donkin

On 01/03/13 15:08, Ate Douma wrote:

snip


As you might have noticed, I've just created issue RAT-125 with an
enhancement which would be great if it could still be picked up before
the 0.9 release :)


Any other last minute requests...?

Robert


Prepare to Release Apache Rat 0.9...?

2012-12-02 Thread Robert Burrell Donkin
I think we're just about ready to start preparing to release Rat. Please 
jump in now if there's any other work that needs to be done before we 
can think about a new release.


Unless anyone else want to jump in, I'd be happy to act as release 
manager for Apache Rat 0.9


Should we push ahead with Apache Rat 0.9...?

Robert


Improved Site Publication Documentation [WAS Re: Switch to maven-scm-publish-plugin]

2012-11-21 Thread Robert Burrell Donkin

On 11/18/12 19:33, Dennis Lundberg wrote:

On 2012-11-18 11:01, Robert Burrell Donkin wrote:


snip


Any objections to me switching the rat build to use
maven-scm-publish-plugin for site generation and updating the
documentation?


No objections from me. Go ahead.


documented here:

  http://creadur.apache.org/rat/site-publish.html

feedback welcomed :-)

Robert


Switch to maven-scm-publish-plugin [WAS Re: Maven SCM Publish Plugin] ...?

2012-11-18 Thread Robert Burrell Donkin

On 11/17/12 21:30, Olivier Lamy wrote:

2012/11/17 Robert Burrell Donkinrobertburrelldon...@blueyonder.co.uk:


snip


On 11/04/12 16:52, Dennis Lundberg wrote:

There is a plugin called Maven SCM Publish Plugin [1], of which
version 1.0-beta-2 has just been released. The purpose of it is to
publish a Maven generated site to any supported SCM, such as the ASF
new
svnpubsub model for publishing sites. I haven't tried it myself yet.

[1] http://maven.apache.org/plugins/maven-scm-publish-plugin/


snip


Even if some tuning is still needed, the plugin seems an improvement to the
process described in the current documentation[2].


Any objections to me switching the rat build to use 
maven-scm-publish-plugin for site generation and updating the documentation?


Robert


[jira] [Resolved] (RAT-123) Improve Rat Core Documentation

2012-11-07 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin resolved RAT-123.
---

Resolution: Fixed

Reworked main page

 Improve Rat Core Documentation
 --

 Key: RAT-123
 URL: https://issues.apache.org/jira/browse/RAT-123
 Project: Apache Rat
  Issue Type: Bug
Affects Versions: 0.8
Reporter: Robert Burrell Donkin
Assignee: Robert Burrell Donkin

 As noted[1], the documentation for the core module is poor. Good idea to 
 improve it before the next release.
 [1] 
 http://mail-archives.apache.org/mod_mbox/creadur-dev/201210.mbox/%3C507C74EF.8040603%40apache.org%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (RAT-98) Maven RAT report does not document skipped files

2012-11-06 Thread Robert Burrell Donkin (JIRA)

[ 
https://issues.apache.org/jira/browse/RAT-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491746#comment-13491746
 ] 

Robert Burrell Donkin commented on RAT-98:
--

+1

 Maven RAT report does not document skipped files
 

 Key: RAT-98
 URL: https://issues.apache.org/jira/browse/RAT-98
 Project: Apache Rat
  Issue Type: Bug
Reporter: Sebb

 The Maven RAT report should document which files have been skipped using the 
 exclude option.
 Either by listing the configuration details, or better by listing the file 
 names with a marker, e.g. EX to show they were deliberately skipped.
 Note: this only refers to files listed in exclude entries, not files which 
 are excluded by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (WHISKER-11) Support configuration which adds sources links into LICENSE

2012-11-06 Thread Robert Burrell Donkin (JIRA)
Robert Burrell Donkin created WHISKER-11:


 Summary: Support configuration which adds sources links into 
LICENSE
 Key: WHISKER-11
 URL: https://issues.apache.org/jira/browse/WHISKER-11
 Project: Apache Whisker
  Issue Type: Bug
Reporter: Robert Burrell Donkin
Assignee: Robert Burrell Donkin


Adding source links into LICENSE is not necessary from a legal perspective but 
is a nice way to credit included software. Add a configuration setting for 
Whisker to control this feature.

http://mail-archives.apache.org/mod_mbox/creadur-dev/201211.mbox/%3C5092DD11.4070404%40blueyonder.co.uk%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: Include Source URLs in Generated LICENSE...?

2012-11-06 Thread Robert Burrell Donkin

On 11/01/12 20:35, Robert Burrell Donkin wrote:

On 11/01/12 14:02, sebb wrote:


snip


OK, in that case I have no objections.


Good :-)

I've been wondering about the right approach to configuration

IMHO the meta-data should be kept separately from configuration-data

For Maven, the plugin configuration would be a natural it. On the
command line, I lean towards more arguments.


I've create a JIRA[1] and hope to take a look later this week unless 
someone jumps in first...


Robert
[1] https://issues.apache.org/jira/browse/WHISKER-11


[jira] [Commented] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice

2012-11-05 Thread Robert Burrell Donkin (JIRA)

[ 
https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490903#comment-13490903
 ] 

Robert Burrell Donkin commented on WHISKER-10:
--

Added a new integration test using the full descriptor, and then removed the 
copyright notices without harm to the resources.

Chip confirms that this potential issue doesn't seem to effect the current 
codebase.

[1] 
http://mail-archives.apache.org/mod_mbox/creadur-dev/201211.mbox/%3CCA%2B96GG5BtWqjkVTzCC8zGazCfvxwGZP9B7TK5-LYosVA_DBa-g%40mail.gmail.com%3E

 Investigate Whether with-license issues are skipped without copyright-notice
 

 Key: WHISKER-10
 URL: https://issues.apache.org/jira/browse/WHISKER-10
 Project: Apache Whisker
  Issue Type: Bug
Reporter: Robert Burrell Donkin
Assignee: Robert Burrell Donkin

 In some circumstances, it seems necessary to add copyright-notice elements 
 before with-license elements are printed correctly. Create tests to prove 
 whether this is still the case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Release Rat ...? [WAS Re: [DISCUSS] Minimum version of Maven to use the Rat plugin]

2012-11-04 Thread Robert Burrell Donkin

On 09/23/12 21:29, Dennis Lundberg wrote:

Hi


(Just trying to pick up where we are on this...)


In RAT-78 there is a request to upgrade to a newer version of Doxia.
That is a reasonable request given the fact that the current version we
are using is 1.0-alpha-8 which is *really* old.


+1


Now, in order to decide which version of Doxia to use we need to first
define the minimum version of Maven we want to support. Currently our
plugin requires Maven 2.0.6 which came out in 2007. Over in Maven land
we currently target Maven 2.2.1 as the minimum version for our plugins.

The reason for this question is because different versions of Maven
comes with different versions of Doxia. This is an unfortunate hard
connection between the two, but starting with Maven 3 there are no
longer any direct dependencies on Doxia in Maven core. See this wiki
page for some history in the matter:

http://docs.codehaus.org/display/MAVEN/Doxia+Release+Plan

We really only have two choices:

1. Require Maven 2.0.11 and use Doxia 1.0.x

2. Require Maven 2.1.0+, which in reality means Maven 2.2.1 due to
technical reasons I won't go into here, and use Doxia 1.1+

Unless anyone has strong objections I plan on going with option 2 here.


+1

AIUI Dennis has applied [1] and [2] (thanks :-)

Does it make sense to start working towards a new release...?

Robert

[1] https://issues.apache.org/jira/browse/RAT-78
[2] https://issues.apache.org/jira/browse/RAT-119


Re: Include Source URLs in Generated LICENSE...?

2012-11-03 Thread Robert Burrell Donkin

On 11/01/12 14:02, sebb wrote:

On 1 November 2012 13:16, Chip Childerschip.child...@sungard.com  wrote:


snip


The documentation [1] is a little confusing,


I've added more content to [1] and to the FAQs on this topic. Is covered 
well enough now? Improvements? Corrections?


Robert


[1] http://creadur.apache.org/whisker/meta-data.html#Source_Links


[jira] [Commented] (WHISKER-10) Investigate Whether with-license issues are skipped without copyright-notice

2012-11-03 Thread Robert Burrell Donkin (JIRA)

[ 
https://issues.apache.org/jira/browse/WHISKER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490072#comment-13490072
 ] 

Robert Burrell Donkin commented on WHISKER-10:
--

As expected, removing the primary copyright notice removes just the generated 
copyright claim

 Investigate Whether with-license issues are skipped without copyright-notice
 

 Key: WHISKER-10
 URL: https://issues.apache.org/jira/browse/WHISKER-10
 Project: Apache Whisker
  Issue Type: Bug
Reporter: Robert Burrell Donkin
Assignee: Robert Burrell Donkin

 In some circumstances, it seems necessary to add copyright-notice elements 
 before with-license elements are printed correctly. Create tests to prove 
 whether this is still the case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (WHISKER-9) Improve Source Element Documentation

2012-11-01 Thread Robert Burrell Donkin (JIRA)
Robert Burrell Donkin created WHISKER-9:
---

 Summary: Improve Source Element Documentation
 Key: WHISKER-9
 URL: https://issues.apache.org/jira/browse/WHISKER-9
 Project: Apache Whisker
  Issue Type: Bug
Reporter: Robert Burrell Donkin
Assignee: Robert Burrell Donkin


The source element document 
(http://creadur.apache.org/whisker/meta-data.html#Source_Links) is too brief 
and technical, adding up to confusion. Improve that section, add an example to 
the main documentation and link to it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


JIRA - Any Idea Why Commits Aren't Showing Up...?

2012-10-30 Thread Robert Burrell Donkin

Commits from whisker don't seem to be showing up in JIRA[1]

Is there a configuration I need to set somewhere...?

Robert
[1] https://issues.apache.org/jira/browse/WHISKER


[jira] [Created] (WHISKER-7) Document When Copyright Notice Is Appropriate

2012-10-30 Thread Robert Burrell Donkin (JIRA)
Robert Burrell Donkin created WHISKER-7:
---

 Summary: Document When Copyright Notice Is Appropriate 
 Key: WHISKER-7
 URL: https://issues.apache.org/jira/browse/WHISKER-7
 Project: Apache Whisker
  Issue Type: Bug
Reporter: Robert Burrell Donkin
Assignee: Robert Burrell Donkin


copyright-notice is intended to help licenses such as the MIT License where a 
copyright claim is conventionally included right at the top of the license 
text. 

Other licences (such as Apache License, Version 2) are slient on copyright 
claims or use a NOTICE to contain collective copyright claims. For primary 
licenses of this sort, to ensure that the copyright claims end up in the NOTICE 
(where they belong) these claims need to be included in the notice sections.

This wasn't very well explain and is confusing. Documentation needs to be 
improved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: [jira] [Commented] (WHISKER-3) The license.vm template makes too many assumptions about skipping licensing details for the primary org and license type.

2012-10-29 Thread Robert Burrell Donkin

On 10/29/12 13:46, Chip Childers wrote:

On Sun, Oct 28, 2012 at 3:48 PM, Robert Burrell Donkin


snip


Thanks a ton Robert.  Please do let me know if I can be of any assistance!


I'm not sure why my commits aren't showing up in JIRA - probably some 
sort of misconfiguration...


Robert


Re: Various dev questions :-)

2012-09-29 Thread Robert Burrell Donkin

Hi Olivier

On 09/29/12 14:41, Olivier Lamy wrote:

Great.
FYI I have created https://issues.apache.org/jira/browse/INFRA-5328
BTW this doesn't prevent applying
https://issues.apache.org/jira/browse/RAT-122 :-) (which is agrregated
patch of RAT-120/121/122)


Thanks :-)


2012/9/27 Jochen Wiedmannjochen.wiedm...@gmail.com:

If you are interested in working that way, I'd be happy to serve as a
recipient for pull requests.


Great :-)

snip

We should probably adopt a style and reformat before the next release.


* I don't see any git mirroring (if you want I can ask for a git
mirroring). I have started working a bit and provided some patches
(but in fact it's a kind of aggregated patch at the end). It's a pain
to revert stuff locally especially when you add files ! So at least
with using git I could create feature branch locally and provide
patches only related to 1 jira entry.


I'll take a look into how to make this happen...

Robert


[jira] [Assigned] (RAT-122) Maven Plugin: field to ignore errors and continue the build

2012-09-29 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin reassigned RAT-122:
-

Assignee: Robert Burrell Donkin

 Maven Plugin: field to ignore errors and continue the build
 ---

 Key: RAT-122
 URL: https://issues.apache.org/jira/browse/RAT-122
 Project: Apache Rat
  Issue Type: Bug
  Components: maven
Reporter: Olivier Lamy (*$^¨%`£)
Assignee: Robert Burrell Donkin
 Attachments: RAT-122




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (RAT-120) fix some maven warning and upgrade some dependencies.

2012-09-29 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin updated RAT-120:
--

Fix Version/s: 0.9

 fix some maven warning and upgrade some dependencies.
 -

 Key: RAT-120
 URL: https://issues.apache.org/jira/browse/RAT-120
 Project: Apache Rat
  Issue Type: Bug
  Components: maven
Affects Versions: 0.9
Reporter: Olivier Lamy (*$^¨%`£)
Assignee: Robert Burrell Donkin
 Fix For: 0.9

 Attachments: RAT-120




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (RAT-122) Maven Plugin: field to ignore errors and continue the build

2012-09-29 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin updated RAT-122:
--

Fix Version/s: 0.9

 Maven Plugin: field to ignore errors and continue the build
 ---

 Key: RAT-122
 URL: https://issues.apache.org/jira/browse/RAT-122
 Project: Apache Rat
  Issue Type: Bug
  Components: maven
Reporter: Olivier Lamy (*$^¨%`£)
Assignee: Robert Burrell Donkin
 Fix For: 0.9

 Attachments: RAT-122




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: [DISCUSS] Minimum version of Maven to use the Rat plugin

2012-09-26 Thread Robert Burrell Donkin

On 09/24/12 12:35, P. Ottlinger wrote:

Hi,

Am 23.09.2012 22:29, schrieb Dennis Lundberg:

2. Require Maven 2.1.0+, which in reality means Maven 2.2.1 due to
technical reasons I won't go into here, and use Doxia 1.1+


+1 - no problem with modern environments.


+1

Robert



Re: Issue with the Whisker CLI

2012-08-18 Thread Robert Burrell Donkin

On 08/16/12 15:30, Chip Childers wrote:

Hi all,

I've found an issue with the Whisker CLI command line parsing logic,
which the diff below resolves.  Basically, as it stands in trunk
today, the CLI is only able to run the help function, since the parse
method isn't being provided the full list of possible options.


yes :-/


We're trying to setup Whisker for the CloudStack project, and I was
hoping to use the CLI for development of the required metadata files.


There's a quick way to do this in the code base, but I don't think it's 
been tooled for any interface. I may post more on this a little later...



Is there a specific method you would like me to follow to get this fix
(or something more appropriate) into the codebase?


Patches on the mailing list are old skool but still cool :-)

(JIRA is more typical these days)

I'll try to find an suitable integration testing framework to stop this 
sort of regression in future...


Robert


-chip


Index: apache-whisker-cli/src/main/java/org/apache/creadur/whisker/cli/Main.java
===
--- apache-whisker-cli/src/main/java/org/apache/creadur/whisker/cli/Main.java   
(revision
1373827)
+++ apache-whisker-cli/src/main/java/org/apache/creadur/whisker/cli/Main.java   
(working
copy)
@@ -188,9 +188,13 @@
   */
  private boolean printHelp(String[] args) throws ParseException {
  final CommandLineOption help = CommandLineOption.PRINT_HELP;
-return help.isSetOn(
-parser().parse(new Options().addOption(
-help.create()), args));
+try {
+   return help.isSetOn(
+   parser().parse(new Options().addOption(
+   help.create()), args));
+} catch (ParseException e) {
+   return false;
+}
  }

  /**




Re: buildbot success in ASF Buildbot on whisker-trunk

2012-08-16 Thread Robert Burrell Donkin

On 08/15/12 04:00, Gavin McDonald wrote:

I re-ran the test with 'mvn3 clean install' and it now passes.

This fixes https://issues.apache.org/jira/browse/INFRA-4819


Thanks :-)

Robert


Re: Question about using Rat and the potential to create accepted exceptions

2012-08-13 Thread Robert Burrell Donkin

On 08/13/12 08:31, David Crossley wrote:

Robert Burrell Donkin wrote:



BTW

1. We're pushing towards the first release of Whisker - this tool helps
with generating composite legal documents (LICENSE and NOTICE etc) and
verifying that the contents of a distribution (as opposed to source
code) are accounted for licensing-wise. If this sounds like something
that you might be interested, please jump in - we'd be very happy to
understand more potential use cases :-)


That could be helpful for Forrest. I have a tool that i wrote
specifically for the Forrest situation, called licer which
correlates the licenses of packaged dependencies.


Sounds interesting :-)


I should try to verify the results with Whisker.


There are a few loose ends that need to be tidied up with verification, 
so might be worth waiting until 0.1 has been cut (James uses Whisker to 
generate LICENSE and NOTICE, so this is more fully tooled.)


Robert


Re: Creadur Website Update

2012-07-14 Thread Robert Burrell Donkin

On 07/12/12 11:11, Maheshika Goonetilleke wrote:

snip


Hi Robert


Hi Maheshika


Well done with updating the web site.


Thanks for the encouragement :-)


However I think still there is no
introduction of tentacles.


True


As in what it is used for. RAT and Whiskers give
such information as well.


I'm focussing on Whisker ATM, pushing towards a 0.1 release but maybe 
I'll be able to find some time in the next few weeks. If you find out 
more about tentacles before then, it'd be great if you could 
contribution some documentation. (We're still trying to work the 
wrinkles out of the CMS, so feel free to attach suggestions to a JIRA...)


(A general comment: I've known coders who have worried about writing 
documentation - but often in past, this turned out to be a matter of 
confidence. With a little encouragement, they turned out to be really 
rather good :-)


Robert




Creadur Website Update

2012-07-05 Thread Robert Burrell Donkin
After a bit of a struggle, hopefully now our website and subsites 
([2]-[5]) are in line with the Apache branding guidelines. Please take a 
look, and jump in if there's anything missing...


Robert
[1] http://www.apache.org/foundation/marks/pmcs.html
[2] http://creadur.apache.org
[3] http://creadur.apache.org/rat/
[4] http://creadur.apache.org/tentacles/
[5] http://creadur.apache.org/whisker/


[jira] [Resolved] (RAT-117) Tentacles uses a snapshot dependency that is not in mvn central - build failure

2012-06-30 Thread Robert Burrell Donkin (JIRA)

 [ 
https://issues.apache.org/jira/browse/RAT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Burrell Donkin resolved RAT-117.
---

Resolution: Fixed

Applied. Many thanks for supplying the patch.

 Tentacles uses a snapshot dependency that is not in mvn central - build 
 failure
 ---

 Key: RAT-117
 URL: https://issues.apache.org/jira/browse/RAT-117
 Project: Apache Rat
  Issue Type: Bug
 Environment: hirsch:~/Desktop/s/creadur/tentacles/trunk$ svn info
 Pfad: .
 URL: http://svn.apache.org/repos/asf/creadur/tentacles/trunk
 Basis des Projektarchivs: http://svn.apache.org/repos/asf
 UUID des Projektarchivs: 13f79535-47bb-0310-9956-ffa450edef68
 Revision: 1351441
 Knotentyp: Verzeichnis
 Plan: normal
 Letzter Autor: dblevins
 Letzte geänderte Rev: 1232283
 Letztes Änderungsdatum: 2012-01-17 04:07:20 +0100 (Di, 17. Jan 2012)
 hirsch:~/Desktop/s/creadur/tentacles/trunk$
Reporter: Hugo Hirsch
Assignee: Robert Burrell Donkin
  Labels: build, maven
 Attachments: RAT117-pom.xml.patch


 Tentacles uses a snapshot dependency that results in build failures on a 
 default mvn setup (mvn 3.0.4).
 Patch in pom.xml is:
 @@ -67,7 +67,8 @@
  dependency
groupIdorg.codehaus.swizzle/groupId
artifactIdswizzle-stream/artifactId
 -  version1.6.2-SNAPSHOT/version
 +  !--version1.6.2-SNAPSHOT/version--
 +  version1.6.1/version
  /dependency
  
  dependency

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: [URGENT] Whisker Example missing in the web site.

2012-06-27 Thread Robert Burrell Donkin

On 06/26/12 09:41, Maheshika Goonetilleke wrote:

Hi All


Hi Maheshika


The whisker examples for maven plugin [1] is unavailable.

[1]
http://creadur.apache.org/whisker/apache-whisker-plugin4maven/index.html


So it is. Not sure why the generation isn't working. I expect to have 
time this weekend to have a look (unless someone else jumps in before then)



Please advice how to use whisker as an maven plugin in our project.


The smoke test[1] might be a good place to start looking if you want to 
start before I get a chance to take a look...


Robert

[1] 
http://svn.apache.org/repos/asf/creadur/whisker/trunk/apache-whisker-plugin4maven/src/it/smoke4generate/pom.xml


JIRA for Tentacles [WAS Re: Build Failure : Apache Tentacles Whisker]

2012-06-24 Thread Robert Burrell Donkin

On 06/18/12 20:12, Hugo Hirsch wrote:

*Apache Tentacles*
Your problem with tentacles seems to be related to a 'snapshot'
dependency. A proposed patch is filed via
https://issues.apache.org/jira/browse/RAT-117


Tentacles is missing an issue tracker. Any objections to me asking infra 
to set up JIRA...?


Robert



  1   2   >