[GitHub] [cxf] jimma merged pull request #1000: CXF-8714: Migration path for Swagger v1.x
jimma merged PR #1000: URL: https://github.com/apache/cxf/pull/1000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] CXF 3.5.x and beyond
I already created a branch for the pre-removal and merged this osgi removal change to the main branch . For these test failures and skipped modules, I'll have a look and fill a JIRA for them after I resolve the grizzly jakarta upgrade : https://issues.apache.org/jira/browse/CXF-8716. @Andriy Redko Do you remember why we skipped the maven-plugins/wadl2java-plugin and systests/wsdl_maven/codegen ? I remembered we analyzed this before , but I can't find the discussion log. On Wed, Sep 28, 2022 at 4:30 PM Colm O hEigeartaigh wrote: > Hi, > > No objection from me either. Apart from OSGi, could we make sure that > all the gaps are recorded in JIRA? > > * Test failures in cxf-rt-mp-client - > https://issues.apache.org/jira/browse/CXF-8758 > * Test failures in > cxf-systests-transports-undertow,cxf-systests-jaxws (websocket > related) - https://issues.apache.org/jira/browse/CXF-8717 > * org.apache.cxf.jms.testsuite.testcases.SoapJmsSpecTest.testGzip is > failing in the jms transport systests - JIRA? > * ./systests/container-integration/grizzly skipped - > https://issues.apache.org/jira/browse/CXF-8716 > * jaxrs systests skipped - JIRA? > * systests/wsdl_maven/codegen skipped - JIRA? > * maven-plugins/wadl2java-plugin - JIRA? > * maven-plugins/java2swagger-plugin - JIRA? > > Colm. > > On Wed, Sep 28, 2022 at 2:45 AM Andrey Redko wrote: > > > > Hi Jim, > > > > No objections from my side, thank you. > > > > Best Regards, > > Andriy Redko > > > > On Tue, Sep 27, 2022, 9:31 PM Jim Ma wrote: > >> > >> Hi all, > >> If there is no objection, I will create a branch > "osgi-pre-removal-v4.0" to record the changes before the osgi and karaf > removal, then > >> merge the this PR https://github.com/apache/cxf/pull/999 to the main > branch. > >> > >> Thanks, > >> Jim > >> > >> On Thu, Sep 22, 2022 at 9:06 PM Andrey Redko wrote: > >>> > >>> This is great, thanks Jim, I will also take a look shortly. Thanks! > >>> > >>> Best Regards, > >>> Andriy Redko > >>> > >>> On Wed, Sep 21, 2022, 1:02 AM Jim Ma wrote: > > Hi All, > I tried to remove the osgi and karaf from CXF with this draft PR : > https://github.com/apache/cxf/pull/999. > This mainly removed the osgi code,test, examples and dependency, but > for some class like SpringBus which deeply coupled with osgi: > > https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/bus/spring/SpringBus.java#L133-L142 > I added the comment "//uncomment this when osgi comes back" to mark > these commented lines for osgi. With the branch created before > this change is merged to main, I am sure this will make it easy to > bring the osgi and karaf back when the Jakarta support is ready in the > future. > > Please help review this PR. If you have any comment or question, > please let me know. > > Thanks, > Jim > > > On Sat, Sep 10, 2022 at 4:05 AM Andriy Redko > wrote: > > > > Hi Jim, > > > > That is correct, I am working on > https://issues.apache.org/jira/browse/CXF-8717 as part of > > Jetty 11 migration, the Atmosphere implementation seems to be fine. > Thanks. > > > > Best Regards, > > Andriy Redko > > > > > > JM> Thanks for the update, Andiry. You already did a lot of work on > third party > > JM> jakarta support ! > > > > JM> Just to understand the CXF Jakarta support work status, are > these issues we > > JM> can start without waiting for the dependency release ? > > JM> https://issues.apache.org/jira/browse/CXF-8716 > > JM> https://issues.apache.org/jira/browse/CXF-8717 > > JM> https://issues.apache.org/jira/browse/CXF-8719 > > > > > > > > JM> On Thu, Sep 8, 2022 at 8:04 PM Andriy Redko > wrote: > > > > >> Hi Jim, > > >> > > >> Yeah, we may need some time, I am also finalizing work on the > Wiremock ( > > >> https://github.com/wiremock/wiremock/pull/1942), > > >> we use it in tests extensively. One of the largest efforts is > migration to > > >> Jetty 11, I have started on that already but > > >> have difficulties with WebSockets migration, it needs rework and > that is > > >> my focus at the moment. The Swagger 1.x we have > > >> to drop I believe, I don't see roadmap on Jakarta support there. > > >> > > >> Thanks! > > >> > > >> Best Regards, > > >> Andriy Redko > > >> > > >> JM> Hi Andriy, > > >> JM> It looks like we still have to wait for the other dependency > jakarta > > >> JM> support available, like brave's new release to include this > change : > > >> JM> https://github.com/openzipkin/brave/pull/1344. Do you see > any other > > >> JM> dependencies that haven't been released yet except OSGI and > Karaf ? > > >> > > >> JM> Thanks, > > >> JM> Jim > > >> > > >> > > >> JM> On Wed, Sep 7, 2022 at 8:11 PM Jim Ma > wrote: > > >> > > >> >> Thanks for the inform
[GitHub] [cxf] jimma merged pull request #999: Remove osgi, blueprint and karaf from CXF
jimma merged PR #999: URL: https://github.com/apache/cxf/pull/999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] coheigea commented on pull request #1000: CXF-8714: Migration path for Swagger v1.x
coheigea commented on PR #1000: URL: https://github.com/apache/cxf/pull/1000#issuecomment-1260607938 LGTM, need to rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cxf] coheigea commented on pull request #954: CXF-8712 One-off issue with retries
coheigea commented on PR #954: URL: https://github.com/apache/cxf/pull/954#issuecomment-1260606560 @reta What's the status of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] CXF 3.5.x and beyond
Hi, No objection from me either. Apart from OSGi, could we make sure that all the gaps are recorded in JIRA? * Test failures in cxf-rt-mp-client - https://issues.apache.org/jira/browse/CXF-8758 * Test failures in cxf-systests-transports-undertow,cxf-systests-jaxws (websocket related) - https://issues.apache.org/jira/browse/CXF-8717 * org.apache.cxf.jms.testsuite.testcases.SoapJmsSpecTest.testGzip is failing in the jms transport systests - JIRA? * ./systests/container-integration/grizzly skipped - https://issues.apache.org/jira/browse/CXF-8716 * jaxrs systests skipped - JIRA? * systests/wsdl_maven/codegen skipped - JIRA? * maven-plugins/wadl2java-plugin - JIRA? * maven-plugins/java2swagger-plugin - JIRA? Colm. On Wed, Sep 28, 2022 at 2:45 AM Andrey Redko wrote: > > Hi Jim, > > No objections from my side, thank you. > > Best Regards, > Andriy Redko > > On Tue, Sep 27, 2022, 9:31 PM Jim Ma wrote: >> >> Hi all, >> If there is no objection, I will create a branch "osgi-pre-removal-v4.0" to >> record the changes before the osgi and karaf removal, then >> merge the this PR https://github.com/apache/cxf/pull/999 to the main branch. >> >> Thanks, >> Jim >> >> On Thu, Sep 22, 2022 at 9:06 PM Andrey Redko wrote: >>> >>> This is great, thanks Jim, I will also take a look shortly. Thanks! >>> >>> Best Regards, >>> Andriy Redko >>> >>> On Wed, Sep 21, 2022, 1:02 AM Jim Ma wrote: Hi All, I tried to remove the osgi and karaf from CXF with this draft PR : https://github.com/apache/cxf/pull/999. This mainly removed the osgi code,test, examples and dependency, but for some class like SpringBus which deeply coupled with osgi: https://github.com/apache/cxf/blob/main/core/src/main/java/org/apache/cxf/bus/spring/SpringBus.java#L133-L142 I added the comment "//uncomment this when osgi comes back" to mark these commented lines for osgi. With the branch created before this change is merged to main, I am sure this will make it easy to bring the osgi and karaf back when the Jakarta support is ready in the future. Please help review this PR. If you have any comment or question, please let me know. Thanks, Jim On Sat, Sep 10, 2022 at 4:05 AM Andriy Redko wrote: > > Hi Jim, > > That is correct, I am working on > https://issues.apache.org/jira/browse/CXF-8717 as part of > Jetty 11 migration, the Atmosphere implementation seems to be fine. > Thanks. > > Best Regards, > Andriy Redko > > > JM> Thanks for the update, Andiry. You already did a lot of work on third > party > JM> jakarta support ! > > JM> Just to understand the CXF Jakarta support work status, are these > issues we > JM> can start without waiting for the dependency release ? > JM> https://issues.apache.org/jira/browse/CXF-8716 > JM> https://issues.apache.org/jira/browse/CXF-8717 > JM> https://issues.apache.org/jira/browse/CXF-8719 > > > > JM> On Thu, Sep 8, 2022 at 8:04 PM Andriy Redko wrote: > > >> Hi Jim, > >> > >> Yeah, we may need some time, I am also finalizing work on the Wiremock > >> ( > >> https://github.com/wiremock/wiremock/pull/1942), > >> we use it in tests extensively. One of the largest efforts is > >> migration to > >> Jetty 11, I have started on that already but > >> have difficulties with WebSockets migration, it needs rework and that > >> is > >> my focus at the moment. The Swagger 1.x we have > >> to drop I believe, I don't see roadmap on Jakarta support there. > >> > >> Thanks! > >> > >> Best Regards, > >> Andriy Redko > >> > >> JM> Hi Andriy, > >> JM> It looks like we still have to wait for the other dependency > >> jakarta > >> JM> support available, like brave's new release to include this change > >> : > >> JM> https://github.com/openzipkin/brave/pull/1344. Do you see any > >> other > >> JM> dependencies that haven't been released yet except OSGI and Karaf ? > >> > >> JM> Thanks, > >> JM> Jim > >> > >> > >> JM> On Wed, Sep 7, 2022 at 8:11 PM Jim Ma wrote: > >> > >> >> Thanks for the informative input, Freeman. > >> >> IMO, If we want to decouple OSGI/Karaf, the 4.0 major release is a > >> >> good > >> >> chance to do this job. When OSGI/Karaf jakarta release is ready, > >> >> We can look at bringing this back with more improvement and refactor > >> work > >> >> to make it loosely coupled with core code. > >> >> > >> >> On Wed, Sep 7, 2022 at 5:34 AM Freeman Fang > >> >> wrote: > >> >> > >> >>> Hi Jim, > >> >>> > >> >>> Sorry for the late reply, just back from vacation. > >> >>> > >> >>> About the OSGi part, the main problem is that the OSGi R9 spec > >> >>> which > >> will > >> >>> support
