Re: Message data structure merge heads up
On Thu, Aug 12, 2010 at 3:06 AM, Emmanuel Lécharny wrote: > On 8/12/10 1:50 AM, Alex Karasulu wrote: > >> On Thu, Aug 12, 2010 at 2:40 AM, Emmanuel Lecharny> >wrote: >> >> What exactly is cleaner? >> > Cleaner => less class, less conversion from class X to class Y. > > If we consider a request sent from a client using the clinet API to the > server, here are the conversion we are doing atm : > > client -> AddRequest (API class) creation ---> converted to AddRequestCodec > ---> converted to byte[] ---> > ( -- network -- ) ---> converted to AddRequestCodec ---> converted to > AddRequestImpl (internal structure used in the server ---> Add processing > ---> AddResponseImpl creation ---> conversion to AddResponseCodec ---> > converted to byte[] ---> > ( -- network -- ) ---> converted to AddResponseCodec ---> converted the > AddResponse (Cient API class) ! > > Ahh OKIE you're 100% right about cleaner without this freaking mess. > As we can see, there are mandatory conversions (from message to byte[] or > byte[] to message), but every message ---> message conversion are totaly a > waste of time, CPU and code. > > I'm "cleaning" this. > > Excellent thanks Em. > > > What I am afraid of is that this might be a bit >> more personal perspective. >> > Nope. This has been discussed lately, and it's a decision we took in order > to be able to modify the client API, as we can't transform the lookup() > method to make it returning an Entry, just because of those spurious > classes. > > Yep yep I was not completely aware of exactly what you meant. Now I'm on the same page. Thanks for taking the time to update me. God bless you for undertaking this boring and dirty task. > Anyway, this is a 5 years old task whch has been postponed for ever, and > august is a good period to do such modifications. > > Heh yeah nothing happens in Aug. > Also is this being done in a branch so the net >> affect on the API can be evaluated? >> > Of course ! Follow the commits ... > > Excellent thanks again! -- Alex Karasulu My Blog :: http://www.jroller.com/akarasulu/ Apache Directory Server :: http://directory.apache.org Apache MINA :: http://mina.apache.org To set up a meeting with me: http://tungle.me/AlexKarasulu
[jira] Resolved: (DIRSTUDIO-686) Improvements in Attribute wizard page
[ https://issues.apache.org/jira/browse/DIRSTUDIO-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kasun Lakpriya resolved DIRSTUDIO-686. -- Resolution: Fixed Resolved : http://code.google.com/p/dirstudio-ldap-tooling/source/detail?r=117 > Improvements in Attribute wizard page > - > > Key: DIRSTUDIO-686 > URL: https://issues.apache.org/jira/browse/DIRSTUDIO-686 > Project: Directory Studio > Issue Type: Improvement > Components: studio-persistence-tooling >Reporter: Stefan Seelmann > > Attribute list should be sorted by attribute name to make it easier to find > attributes. > All attributes that are defined in the selected entry should be pre-selected. > The objectClass attribute should be filtered out because this attribute is > managed by the DAO. > The table should have a scroll bar. Currently if I choose an intetOrgPerson > entry with many attributes not all attributes are displayed and I'm not able > to scroll. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Documentation -> docbook ?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/10 22:24, Alex Karasulu wrote: > This might be a bit off topic yet tangentially related but do any of you > guys know of a good WYSIWIG docbook editor that really, I mean really, works > right? IIRC, at some point docbook support was added to open office but it > had some quirks. Anyone know if that improved as well? Just saw this [1], but I haven't tested it yet (anyway I can't say much as I'm not a docbook guru ...). Exists for Windows/Linux/MacOSX [1] http://www.syntext.com/products/serna-free/ -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkxkA9wACgkQ2lZVCB08qHEadQCbBidnzzqo19mGAgxuYj+KTyNr aK4AniDnyTkTG9MvbOx8Gk/GuDdDujv4 =zglA -END PGP SIGNATURE-
Re: Message data structure merge heads up
Gentlemen, I've been exploring and working my way through getting the Subversion checkout and Maven builds working reliably so that I'm comfortable with that process. I've been working on two different systems (I have a day job). My home system is Fedora Core 13 Linux with the Sun JDK 1.6_20, Subversion, Maven 2.2.1, and Eclipse 3.6 installed. On this system I had little trouble following the steps suggested: 1) Checkout trunk-with-dependencies 2) "mvn clean install -DskipTests" 3) "mvn eclipse:eclipse" I was able to import that projects into Eclipse without difficulty after the above steps. Back at a command prompt I tried running the following to make sure everything was working. 4) "mvn test" Only one test "testSaslGssapiBind" is failing, and, looking at the test code, it appears that the author doesn't expect this one to work yet. At my day job I have a Windows XP SP-3 with Sun JDK 1.6_17, Maven 2.2.1, Subversion, and Eclipse 3.6 installed. Access to the Internet from this system is restricted to using an HTTP proxy that requires NTLM authentication. I've had a bit of a struggle getting Maven and Subversion working through this but finally seem to have it (except for m2Eclipse which still seems unable to access anything through the proxy). I have noticed though that the proxy is either overloaded or just plain unreliable. I did finally succeed in getting a clean checkout, however. Again the same three steps mentioned above were completed successfully (despite the erratic operation of the proxy server). When I tried "mvn test", however, I got several failures. One of the failures, "testSaslGssapiBind", is the same as on Linux. For now I'm assuming this is a known problem that is being worked on. Using Eclipse to investigate each of the others I've discovered that two of them are related to Windows's use of the "\" character as the path separator and one is related to incorrect handling of "escaping" of characters in filenames. I'm developing fixes for these issues now and will post suggested patches after I complete testing. The only remaining test failure, is "testSearchUTF8" in "ClientSearchRequestTest" which is not throwing the expected Exception. I haven't investigated this one yet but plan to when time is available. Thanks for the guidance. Richard Feezel . This is an e-mail from General Dynamics Land Systems. It is for the intended recipient only and may contain confidential and privileged information. No one else may read, print, store, copy, forward or act in reliance on it or its attachments. If you are not the intended recipient, please return this message to the sender and delete the message and any attachments from your computer. Your cooperation is appreciated.
[jira] Commented: (DIRSTUDIO-686) Improvements in Attribute wizard page
[ https://issues.apache.org/jira/browse/DIRSTUDIO-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897768#action_12897768 ] Pierre-Arnaud Marcelot commented on DIRSTUDIO-686: -- I looked at your code Kasun and I saw you were using the interface 'ICheckStateProvider'. This interface has been introduced in Eclipse 3.5 and Studio's plugins are to be compatible with Eclipse versions >= 3.3. By using this interface you Studio will not be compatible with Eclipse 3.3 and 3.4 anymore. You weren't probably aware of that requirement and I'll let Stefan decide if this requirement is part of the GSoC project. I also came across this interface and started using it, until I realized I simply couldn't, because of our Eclipse version requirement. > Improvements in Attribute wizard page > - > > Key: DIRSTUDIO-686 > URL: https://issues.apache.org/jira/browse/DIRSTUDIO-686 > Project: Directory Studio > Issue Type: Improvement > Components: studio-persistence-tooling >Reporter: Stefan Seelmann > > Attribute list should be sorted by attribute name to make it easier to find > attributes. > All attributes that are defined in the selected entry should be pre-selected. > The objectClass attribute should be filtered out because this attribute is > managed by the DAO. > The table should have a scroll bar. Currently if I choose an intetOrgPerson > entry with many attributes not all attributes are displayed and I'm not able > to scroll. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Documentation -> docbook ?
On 8/12/10 4:23 PM, Felix Knecht wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/11/10 22:24, Alex Karasulu wrote: This might be a bit off topic yet tangentially related but do any of you guys know of a good WYSIWIG docbook editor that really, I mean really, works right? IIRC, at some point docbook support was added to open office but it had some quirks. Anyone know if that improved as well? Just saw this [1], but I haven't tested it yet (anyway I can't say much as I'm not a docbook guru ...). Exists for Windows/Linux/MacOSX [1] http://www.syntext.com/products/serna-free/ Will test it. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com
[jira] Commented: (DIRSTUDIO-686) Improvements in Attribute wizard page
[ https://issues.apache.org/jira/browse/DIRSTUDIO-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897775#action_12897775 ] Kasun Lakpriya commented on DIRSTUDIO-686: -- Thanks Pierre-Arnauld for the information about this requirement and sure let's get some idea from Stefan as well and see what we are going to. Mean time I will look in to a way that how we are going to implement this. > Improvements in Attribute wizard page > - > > Key: DIRSTUDIO-686 > URL: https://issues.apache.org/jira/browse/DIRSTUDIO-686 > Project: Directory Studio > Issue Type: Improvement > Components: studio-persistence-tooling >Reporter: Stefan Seelmann > > Attribute list should be sorted by attribute name to make it easier to find > attributes. > All attributes that are defined in the selected entry should be pre-selected. > The objectClass attribute should be filtered out because this attribute is > managed by the DAO. > The table should have a scroll bar. Currently if I choose an intetOrgPerson > entry with many attributes not all attributes are displayed and I'm not able > to scroll. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Message data structure merge heads up
On 8/12/10 4:24 PM, feez...@gdls.com wrote: Gentlemen, Hi, My home system is Fedora Core 13 Linux with the Sun JDK 1.6_20, Subversion, Maven 2.2.1, and Eclipse 3.6 installed. Perfect. Back at a command prompt I tried running the following to make sure everything was working. 4) "mvn test" Only one test "testSaslGssapiBind" is failing, and, looking at the test code, it appears that the author doesn't expect this one to work yet. Strange. All the tests are passing on our linux machines. Have you tried mvn clean install -Dintegration ? At my day job I have a Windows XP SP-3 with Sun JDK 1.6_17, Maven 2.2.1, Subversion, and Eclipse 3.6 installed. Access to the Internet from this system is restricted to using an HTTP proxy that requires NTLM authentication. Thanks a lot, M$ ... Again the same three steps mentioned above were completed successfully (despite the erratic operation of the proxy server). When I tried "mvn test", however, I got several failures. One of the failures, "testSaslGssapiBind", is the same as on Linux. For now I'm assuming this is a known problem that is being worked on. Using Eclipse to investigate each of the others I've discovered that two of them are related to Windows's use of the "\" character as the path separator and one is related to incorrect handling of "escaping" of characters in filenames. I'm developing fixes for these issues now and will post suggested patches after I complete testing. Great ! We don't use W$ at all, so it's likely we have some tests failure if we are not cautious enough. That's the price to pay for being efficient... The only remaining test failure, is "testSearchUTF8" in "ClientSearchRequestTest" which is not throwing the expected Exception. I haven't investigated this one yet but plan to when time is available. H... I don't find this class. In which module did you found it ? -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com
[jira] Commented: (DIRSTUDIO-686) Improvements in Attribute wizard page
[ https://issues.apache.org/jira/browse/DIRSTUDIO-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897822#action_12897822 ] Stefan Seelmann commented on DIRSTUDIO-686: --- Thanks Pierre-Arnaud for checking this. In fact I suggested Kasun to use the ICheckStateProvider. Since I'm using my new computer I didn't install old Eclipse versions and hence didn't setup older target environments. I'd say it's ok to use the ICheckStateProvider for the GSoC project. But if we move the code to Apache SVN we have to to fix this issue. > Improvements in Attribute wizard page > - > > Key: DIRSTUDIO-686 > URL: https://issues.apache.org/jira/browse/DIRSTUDIO-686 > Project: Directory Studio > Issue Type: Improvement > Components: studio-persistence-tooling >Reporter: Stefan Seelmann > > Attribute list should be sorted by attribute name to make it easier to find > attributes. > All attributes that are defined in the selected entry should be pre-selected. > The objectClass attribute should be filtered out because this attribute is > managed by the DAO. > The table should have a scroll bar. Currently if I choose an intetOrgPerson > entry with many attributes not all attributes are displayed and I'm not able > to scroll. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Message data structure merge heads up, take 2
Hi guys, it's going faster than I was expecting. 40% of the messages have been merged (almost all the response though, and the resquest are a bit more complex, especially the SearchRequest) It resulted in some code shrinking : - trunk contains 351 355 slocs - branch contains 328 119 slocs This is 23 236 less slocs ! I also expect the performance to be slightly better... We will see ... -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com
Re: Message data structure merge heads up, take 2
On Thu, Aug 12, 2010 at 11:41 PM, Emmanuel Lécharny wrote: > Hi guys, > > it's going faster than I was expecting. > > 40% of the messages have been merged (almost all the response though, and > the resquest are a bit more complex, especially the SearchRequest) > > It resulted in some code shrinking : > - trunk contains 351 355 slocs > - branch contains 328 119 slocs > > This is 23 236 less slocs ! great, a lot if code shredding ;) > > I also expect the performance to be slightly better... for sure IMO > > We will see ... thanks Emmanuel Kiran Ayyagari
SsaslGssapiBind test failure problem identified
On Thu, Aug 12, 2010 at 10:51 AM, Emmanuel Lecharny wrote: > On 8/12/10 4:24 PM, feez...@gdls.com wrote: > >> Gentlemen, >> > Hi, > > My home system is Fedora Core 13 Linux with the Sun JDK 1.6_20, >> Subversion, Maven 2.2.1, and Eclipse 3.6 installed. >> > Perfect. > > Back at a command prompt I tried running the following to make sure >> everything was working. >> >> 4) "mvn test" >> >> Only one test "testSaslGssapiBind" is failing, and, looking at the test >> code, it appears that the author doesn't expect this one to work yet. >> > Strange. All the tests are passing on our linux machines. > > Have you tried mvn clean install -Dintegration ? I have not tried that. I don't know how that differs from not specifying "integration". However, after looking at the error I was getting which indicated that the LDAP service principle wasn't being found I set "sun.security.krb5.debug" to "true". This didn't help much so I put a breakpoint in the TGS service code and stepped through it. The service principle being requested is "ldap/ richard.feezel@example.com" rather than "ldap/localh...@example.com". I'm guessing the switch is being made in the sun code for some reason, probably in some obscure way related to the configuration of my machine (which is named "richard.feezel.net"). I just discovered the source of the problem... In my etc/hosts file, on the 127.0.0.1 line the name richard.feezel.net was listed first. I moved "localhost" to be the first name on the line and the error is gone. > At my day job I have a Windows XP SP-3 with Sun JDK 1.6_17, Maven 2.2.1, >> Subversion, and Eclipse 3.6 installed. >> >> Access to the Internet from this system is restricted to using an HTTP >> proxy that requires NTLM authentication. >> > Thanks a lot, M$ ... > It's an on-going source of frustration. > > > Again the same three steps mentioned above were completed successfully >> (despite the erratic operation of the proxy server). >> >> When I tried "mvn test", however, I got several failures. >> >> One of the failures, "testSaslGssapiBind", is the same as on Linux. For >> now I'm assuming this is a known problem that is being worked on. >> >> Using Eclipse to investigate each of the others I've discovered that two >> of them are related to Windows's use of the "\" character as the path >> separator and one is related to incorrect handling of "escaping" of >> characters in filenames. I'm developing fixes for these issues now and >> will post suggested patches after I complete testing. >> > Great ! We don't use W$ at all, so it's likely we have some tests failure > if we are not cautious enough. That's the price to pay for being > efficient... I realized after writing this morning that there are other tests failing as well on XP. Yesterday I had only been running "mvn test" in the trunk/apacheds directory. When run in the "trunk" directory there are other problems. I will investigate the errors on Windows as I have time but it won't be a priority. > The only remaining test failure, is "testSearchUTF8" in >> "ClientSearchRequestTest" which is not throwing the expected Exception. I >> haven't investigated this one yet but plan to when time is available. >> > > H... I don't find this class. In which module did you found it ? It's in "ldap-client-test" -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > > Thanks once again for responding to the queries of a stumbling beginner. -- Richard M Feezel rfee...@gmail.com
