[jira] [Commented] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki

2016-12-02 Thread Liang Xie (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717659#comment-15717659
 ] 

Liang Xie commented on DL-79:
-

yeh, that would be great, here is the pr: 
https://github.com/apache/incubator-distributedlog/pull/50

> Add Eclipse-based Apache Formatter to DL Wiki
> -
>
> Key: DL-79
> URL: https://issues.apache.org/jira/browse/DL-79
> Project: DistributedLog
>  Issue Type: Wish
>  Components: documentation
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Attachments: DL_formatter.xml
>
>
> From 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we 
> saw several text suggestions, it would be nice if we have a importable ide 
> formatter file like HDFS/HBase/... projects, here is a ref jira: 
> https://issues.apache.org/jira/browse/HBASE-3678



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (DL-83) Add javadoc to website

2016-12-02 Thread Sijie Guo (JIRA)
Sijie Guo created DL-83:
---

 Summary: Add javadoc to website
 Key: DL-83
 URL: https://issues.apache.org/jira/browse/DL-83
 Project: DistributedLog
  Issue Type: Task
  Components: documentation, website
Reporter: Sijie Guo
 Fix For: 0.4.0


We need to host javadoc on website.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-distributedlog pull request #50: DL eclipse formatter file

2016-12-02 Thread xieliang
GitHub user xieliang opened a pull request:

https://github.com/apache/incubator-distributedlog/pull/50

DL eclipse formatter file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xieliang/incubator-distributedlog DL-79

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-distributedlog/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 39ace032a90692231641c57044704c8a7b6a6751
Author: xieliang 
Date:   2016-12-03T07:50:50Z

DL eclipse formatter file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717645#comment-15717645
 ] 

Hudson commented on DL-80:
--

SUCCESS: Integrated in Jenkins build distributedlog-nightly-build #136 (See 
[https://builds.apache.org/job/distributedlog-nightly-build/136/])
DL-80: synchronized getLogRecordSetWriter() (sijie: rev 
2a677d15aa8fd2284df125b1ee8be9e8ca8b8437)
* (edit) 
distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogMultiStreamWriter.java


> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Fix For: 0.4.0
>
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DL-49) Support building project with scala 2.10 and 2.11

2016-12-02 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717644#comment-15717644
 ] 

Hudson commented on DL-49:
--

SUCCESS: Integrated in Jenkins build distributedlog-nightly-build #136 (See 
[https://builds.apache.org/job/distributedlog-nightly-build/136/])
DL-49: Support building project with scala 2.10 and 2.11 (sijie: rev 
f03249dfbfa976a851377645c24cc5c3ff30bd74)
* (edit) 
distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/AtomicWriter.java
* (add) scripts/change-scala-version.sh
* (edit) .travis.yml
* (edit) distributedlog-core/pom.xml
* (edit) 
distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/ConsoleProxyMultiWriter.java
* (edit) 
distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/ConsoleProxyWriter.java
* (edit) 
distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/RecordGenerator.java
* (edit) 
distributedlog-tutorials/distributedlog-messaging/src/main/java/com/twitter/distributedlog/messaging/ConsoleProxyPartitionedMultiWriter.java
* (edit) 
distributedlog-tutorials/distributedlog-messaging/src/main/java/com/twitter/distributedlog/messaging/ConsoleProxyRRMultiWriter.java


> Support building project with scala 2.10 and 2.11
> -
>
> Key: DL-49
> URL: https://issues.apache.org/jira/browse/DL-49
> Project: DistributedLog
>  Issue Type: Bug
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.5.0
>
>
> support build the project with either scala 2.10 and scala 2.11



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-distributedlog pull request #49: Blacklist branches on travis

2016-12-02 Thread sijie
GitHub user sijie opened a pull request:

https://github.com/apache/incubator-distributedlog/pull/49

Blacklist branches on travis



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sijie/incubator-distributedlog 
sijie/fix_travis_build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-distributedlog/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit 8e429480460d34712cafd4986c6f64826a3c3dbf
Author: Sijie Guo 
Date:   2016-12-03T07:30:02Z

Blacklist branches on travis




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (DL-49) Support building project with scala 2.10 and 2.11

2016-12-02 Thread Sijie Guo (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-49.
-
   Resolution: Fixed
Fix Version/s: (was: 0.4.0)
   0.5.0

Issue resolved by merging pull request 22
  [https://github.com/apache/incubator-distributedlog/pull/22]

  {noformat}
  commit f03249dfbfa976a851377645c24cc5c3ff30bd74
Author: Sijie Guo 
AuthorDate: Fri Dec 2 22:45:43 2016 -0800
Commit: Sijie Guo 
CommitDate: Fri Dec 2 22:45:43 2016 -0800

DL-49: Support building project with scala 2.10 and 2.11

Author: Sijie Guo 
Author: Sijie Guo 

Reviewers: Franck Cuny 

Closes #22 from sijie/sijie/support_scala_2.10_and_2.11

  {noformat}
  

> Support building project with scala 2.10 and 2.11
> -
>
> Key: DL-49
> URL: https://issues.apache.org/jira/browse/DL-49
> Project: DistributedLog
>  Issue Type: Bug
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.5.0
>
>
> support build the project with either scala 2.10 and scala 2.11



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DL-49) Support building project with scala 2.10 and 2.11

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717563#comment-15717563
 ] 

ASF GitHub Bot commented on DL-49:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/22


> Support building project with scala 2.10 and 2.11
> -
>
> Key: DL-49
> URL: https://issues.apache.org/jira/browse/DL-49
> Project: DistributedLog
>  Issue Type: Bug
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.5.0
>
>
> support build the project with either scala 2.10 and scala 2.11



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-distributedlog pull request #22: DL-49: Support building project w...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


incubator-distributedlog git commit: DL-49: Support building project with scala 2.10 and 2.11

2016-12-02 Thread sijie
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master e4dce21cb -> f03249dfb


DL-49: Support building project with scala 2.10 and 2.11

Author: Sijie Guo 
Author: Sijie Guo 

Reviewers: Franck Cuny 

Closes #22 from sijie/sijie/support_scala_2.10_and_2.11


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/f03249df
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/f03249df
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/f03249df

Branch: refs/heads/master
Commit: f03249dfbfa976a851377645c24cc5c3ff30bd74
Parents: e4dce21
Author: Sijie Guo 
Authored: Fri Dec 2 22:45:43 2016 -0800
Committer: Sijie Guo 
Committed: Fri Dec 2 22:45:43 2016 -0800

--
 .travis.yml |  5 ++
 distributedlog-core/pom.xml |  4 -
 .../distributedlog/basic/AtomicWriter.java  |  4 +-
 .../basic/ConsoleProxyMultiWriter.java  |  4 +-
 .../basic/ConsoleProxyWriter.java   |  4 +-
 .../distributedlog/basic/RecordGenerator.java   |  4 +-
 .../ConsoleProxyPartitionedMultiWriter.java |  4 +-
 .../messaging/ConsoleProxyRRMultiWriter.java|  4 +-
 scripts/change-scala-version.sh | 92 
 9 files changed, 109 insertions(+), 16 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/f03249df/.travis.yml
--
diff --git a/.travis.yml b/.travis.yml
index 7c177fc..eb91334 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,11 +19,16 @@ matrix:
   include:
 - os: osx
   osx_image: xcode8
+  env: SCALA_VERSION="2.10"
+- os: osx
+  osx_image: xcode8
+  env: SCALA_VERSION="2.11"
 
 before_install:
   - echo "MAVEN_OPTS='-Xmx3072m -XX:MaxPermSize=512m'" > ~/.mavenrc
 
 script:
+  - travis_retry ./scripts/change-scala-version.sh $SCALA_VERSION
   - travis_retry mvn --batch-mode clean apache-rat:check
   - travis_retry mvn --batch-mode clean install findbugs:check -DskipTests=true
 

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/f03249df/distributedlog-core/pom.xml
--
diff --git a/distributedlog-core/pom.xml b/distributedlog-core/pom.xml
index c7a0431..20d3139 100644
--- a/distributedlog-core/pom.xml
+++ b/distributedlog-core/pom.xml
@@ -39,10 +39,6 @@
   org.slf4j
   slf4j-log4j12
 
-
-  com.twitter
-  finagle-core_2.11
-
   
 
 

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/f03249df/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/AtomicWriter.java
--
diff --git 
a/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/AtomicWriter.java
 
b/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/AtomicWriter.java
index 92f5d46..1f9cc9e 100644
--- 
a/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/AtomicWriter.java
+++ 
b/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/AtomicWriter.java
@@ -24,7 +24,7 @@ import com.twitter.distributedlog.io.CompressionCodec.Type;
 import com.twitter.distributedlog.service.DistributedLogClient;
 import com.twitter.distributedlog.service.DistributedLogClientBuilder;
 import com.twitter.distributedlog.util.FutureUtils;
-import com.twitter.finagle.thrift.ClientId;
+import com.twitter.finagle.thrift.ClientId$;
 import com.twitter.util.Future;
 import com.twitter.util.FutureEventListener;
 import com.twitter.util.Promise;
@@ -53,7 +53,7 @@ public class AtomicWriter {
 System.arraycopy(args, 2, messages, 0, messages.length);
 
 DistributedLogClient client = DistributedLogClientBuilder.newBuilder()
-.clientId(ClientId.apply("atomic-writer"))
+.clientId(ClientId$.MODULE$.apply("atomic-writer"))
 .name("atomic-writer")
 .thriftmux(true)
 .finagleNameStr(finagleNameStr)

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/f03249df/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/ConsoleProxyMultiWriter.java
--
diff --git 
a/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitter/distributedlog/basic/ConsoleProxyMultiWriter.java
 
b/distributedlog-tutorials/distributedlog-basic/src/main/java/com/twitt

[jira] [Commented] (DL-49) Support building project with scala 2.10 and 2.11

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717392#comment-15717392
 ] 

ASF GitHub Bot commented on DL-49:
--

Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/22
  
merged latest master and wait for travis ci build to complete


> Support building project with scala 2.10 and 2.11
> -
>
> Key: DL-49
> URL: https://issues.apache.org/jira/browse/DL-49
> Project: DistributedLog
>  Issue Type: Bug
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.4.0
>
>
> support build the project with either scala 2.10 and scala 2.11



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-distributedlog issue #22: DL-49: Support building project with sca...

2016-12-02 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/22
  
merged latest master and wait for travis ci build to complete


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-distributedlog pull request #47: The CONFIG.ini file has no purpos...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


incubator-distributedlog git commit: The CONFIG.ini file has no purpose outside of Twitter

2016-12-02 Thread sijie
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master a546e6207 -> e4dce21cb


The CONFIG.ini file has no purpose outside of Twitter

Author: Franck Cuny 

Reviewers: Sijie Guo 

Closes #47 from franckcuny/fcuny/cleanup


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/e4dce21c
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/e4dce21c
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/e4dce21c

Branch: refs/heads/master
Commit: e4dce21cb06bf0778bff4c0ba912a8f7f2541717
Parents: a546e62
Author: Franck Cuny 
Authored: Fri Dec 2 20:41:37 2016 -0800
Committer: Sijie Guo 
Committed: Fri Dec 2 20:41:37 2016 -0800

--
 CONFIG.ini | 3 ---
 README.md  | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/e4dce21c/CONFIG.ini
--
diff --git a/CONFIG.ini b/CONFIG.ini
deleted file mode 100644
index 93b1a6c..000
--- a/CONFIG.ini
+++ /dev/null
@@ -1,3 +0,0 @@
-[docbird]
-project_name = DistributedLog
-project_type = service

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/e4dce21c/README.md
--
diff --git a/README.md b/README.md
index ee323b4..3c68ba9 100644
--- a/README.md
+++ b/README.md
@@ -85,7 +85,7 @@ For filing bugs, suggesting improvements, or requesting new 
features, help us ou
 
 ### Need Help?
 
-[Subscribe](dev-subscr...@distributedlog.incubator.apache.org) or 
[mail](dev@distributedlog.incubator.apache.org) the 
[dev@distributedlog.incubator.apache.org](dev@distributedlog.incubator.apache.org)
 list - Ask questions, find answers, join developement discussions and also 
help other users.
+[Subscribe](mailto:dev-subscr...@distributedlog.incubator.apache.org) or 
[mail](mailto:dev@distributedlog.incubator.apache.org) the 
[dev@distributedlog.incubator.apache.org](mailto:dev@distributedlog.incubator.apache.org)
 list - Ask questions, find answers, join developement discussions and also 
help other users.
 
 ## Contributing
 



[jira] [Commented] (DL-82) Automatically build and update the website

2016-12-02 Thread Sijie Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717382#comment-15717382
 ] 

Sijie Guo commented on DL-82:
-

/cc [~franckcuny]

> Automatically build and update the website
> --
>
> Key: DL-82
> URL: https://issues.apache.org/jira/browse/DL-82
> Project: DistributedLog
>  Issue Type: Task
>  Components: website
>Reporter: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> We need a way to automatically update the website - for example, if the pr 
> contains changes to website/documentation, the merge-pr.py script should 
> build the website and merge them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (DL-82) Automatically build and update the website

2016-12-02 Thread Sijie Guo (JIRA)
Sijie Guo created DL-82:
---

 Summary: Automatically build and update the website
 Key: DL-82
 URL: https://issues.apache.org/jira/browse/DL-82
 Project: DistributedLog
  Issue Type: Task
  Components: website
Reporter: Sijie Guo
 Fix For: 0.5.0


We need a way to automatically update the website - for example, if the pr 
contains changes to website/documentation, the merge-pr.py script should build 
the website and merge them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DL-82) Automatically build and update the website

2016-12-02 Thread Sijie Guo (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo updated DL-82:

Priority: Blocker  (was: Major)

> Automatically build and update the website
> --
>
> Key: DL-82
> URL: https://issues.apache.org/jira/browse/DL-82
> Project: DistributedLog
>  Issue Type: Task
>  Components: website
>Reporter: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> We need a way to automatically update the website - for example, if the pr 
> contains changes to website/documentation, the merge-pr.py script should 
> build the website and merge them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DL-82) Automatically build and update the website

2016-12-02 Thread Sijie Guo (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo updated DL-82:

Fix Version/s: (was: 0.5.0)
   0.4.0

> Automatically build and update the website
> --
>
> Key: DL-82
> URL: https://issues.apache.org/jira/browse/DL-82
> Project: DistributedLog
>  Issue Type: Task
>  Components: website
>Reporter: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> We need a way to automatically update the website - for example, if the pr 
> contains changes to website/documentation, the merge-pr.py script should 
> build the website and merge them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [DISCUSSION] First Release

2016-12-02 Thread Sijie Guo
FYI.

https://issues.apache.org/jira/browse/DL-81 is created for tracking
building the process.

https://issues.apache.org/jira/browse/INFRA-13024 and
https://issues.apache.org/jira/browse/INFRA-13023 for setting the dists for
DL.

- Sijie

On Fri, Dec 2, 2016 at 8:05 PM, Sijie Guo  wrote:

> Thank you for all the feedbacks. I will drive the release for this
> version. So that we can have all the procedures documented in the wiki.
>
> I created the wiki page here for documenting the procedure: https://cwiki.
> apache.org/confluence/display/DL/Preparing+DistributedLog+Releases
>
> - Sijie
>
>
> On Mon, Nov 21, 2016 at 7:10 PM, Jia Zhai  wrote:
>
>> +1
>> Great to know the commitment of merge twitter's branch. Looking forward to
>> see bookkeeper 4.5.
>>
>> On Mon, Nov 21, 2016 at 6:36 PM, Flavio Junqueira  wrote:
>>
>> > It does make sense, Sijie, thanks for the update.
>> >
>> > -Flavio
>> >
>> > > On 17 Nov 2016, at 05:12, Sijie Guo  wrote:
>> > >
>> > > Flavio,
>> > >
>> > > I totally agreed that not using an official Apache  version is not
>> great
>> > > for the community. We had a bookkeeper meetup last night. We've
>> discussed
>> > > the current situation with the community. We came to a commitment to
>> > merge
>> > > Twitter's branch back into bookkeeper 4.5. After that we won't
>> maintain
>> > our
>> > > own branch and switch to 4.5.
>> > >
>> > > Hope this make sense.
>> > >
>> > > Sijie
>> > >
>> > > On Nov 16, 2016 8:04 PM, "Flavio Junqueira"  wrote:
>> > >
>> > > It isn't great that DistributedLog is not using the Apache BookKeeper
>> > > release. Essentially anyone using DistributedLog today needs to use
>> the
>> > > Twitter branch of BookKeeper, which has diverged from Apache
>> BookKeeper.
>> > > I'm sure the changes in the Twitter branch are all great, but I'd be
>> more
>> > > comfortable being able to rely on the Apache BookKeeper releases,
>> which
>> > are
>> > > community driven.
>> > >
>> > > I'm not going to block the release on this alone because it is
>> important
>> > > for this project to get a first release out soon, but we need to fix
>> > DL-2.
>> > >
>> > > -Flavio
>> > >
>> > >> On 15 Nov 2016, at 19:02, Leigh Stewart > >
>> > > wrote:
>> > >>
>> > >> +1
>> > >>
>> > >> On Tue, Nov 15, 2016 at 7:01 PM, Franck Cuny 
>> > > wrote:
>> > >>
>> > >>> +1 and I agree to not make DL-2 a blocker.
>> > >>>
>> > >>> On Tue, Nov 15, 2016 at 2:02 AM, Xi Liu 
>> wrote:
>> > >>>
>> >  +1 especially on DL-23.
>> > 
>> >  - Xi
>> > 
>> >  On Sat, Nov 12, 2016 at 2:22 AM, Khurrum Nasim <
>> > khurrumnas...@gmail.com>
>> >  wrote:
>> > 
>> > > +1 (non-binding)
>> > >
>> > > I am also interested in participating.
>> > >
>> > > - kn
>> > >
>> > > On Tue, Nov 8, 2016 at 11:08 PM, Sijie Guo 
>> wrote:
>> > >
>> > >> I'd like to start the discussion about the first release. There
>> are
>> > > still a
>> > >> few discussions and pull requests outstanding. I think we need to
>> > >>> pick
>> > > up a
>> > >> few items and cut the first release and then iterate from there.
>> > Here
>> >  is
>> > > a
>> > >> list of items that I think we should include:
>> > >>
>> > >> - DL-4 : Repackaging
>> > > namespace
>> > >> to org.apache (the pull request is out and under reviewing)
>> > >> - DL-49 : support
>> > scala
>> > > 2.10
>> > >> and 2.11 (the review is done, need to be merged)
>> > >> - DL-23 : Move DL
>> to
>> >  depend
>> > >> on
>> > >> central maven repo. The main blocker is about the libthrift
>> version,
>> > > which
>> > >> is only hosted at twtter's maven repo. There is a pull request
>> out.
>> > >>
>> > >> I am kind of thinking to not make DL-2
>> > >>  (using the official
>> > >> bookkeeper
>> > >> version) the blocker for the first release. We can cut a new
>> release
>> >  once
>> > >> that change is ready. So to decouple the release procedure
>> between
>> > DL
>> >  and
>> > >> BK.
>> > >>
>> > >> Please feel free to add any jiras that you believe it should be
>> >  included
>> > > in
>> > >> the first release.
>> > >>
>> > >> Also, is there anyone interested in being the release manager for
>> > >>> first
>> > >> release?
>> > >>
>> > >> - Sijie
>> > >>
>> > >
>> > 
>> > >>>
>> > >>>
>> > >>>
>> > >>> --
>> > >>> -franck
>> > >>>
>> >
>> >
>>
>
>


[jira] [Updated] (DL-81) Build the distributedlog release procedure

2016-12-02 Thread Sijie Guo (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo updated DL-81:

Priority: Blocker  (was: Major)

> Build the distributedlog release procedure
> --
>
> Key: DL-81
> URL: https://issues.apache.org/jira/browse/DL-81
> Project: DistributedLog
>  Issue Type: Task
>  Components: documentation
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> this is the ticket to track building the release procedure for distributedlog



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (DL-81) Build the distributedlog release procedure

2016-12-02 Thread Sijie Guo (JIRA)
Sijie Guo created DL-81:
---

 Summary: Build the distributedlog release procedure
 Key: DL-81
 URL: https://issues.apache.org/jira/browse/DL-81
 Project: DistributedLog
  Issue Type: Task
  Components: documentation
Reporter: Sijie Guo
Assignee: Sijie Guo
 Fix For: 0.4.0


this is the ticket to track building the release procedure for distributedlog



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [DISCUSSION] First Release

2016-12-02 Thread Sijie Guo
Thank you for all the feedbacks. I will drive the release for this version.
So that we can have all the procedures documented in the wiki.

I created the wiki page here for documenting the procedure:
https://cwiki.apache.org/confluence/display/DL/Preparing+DistributedLog+Releases

- Sijie

On Mon, Nov 21, 2016 at 7:10 PM, Jia Zhai  wrote:

> +1
> Great to know the commitment of merge twitter's branch. Looking forward to
> see bookkeeper 4.5.
>
> On Mon, Nov 21, 2016 at 6:36 PM, Flavio Junqueira  wrote:
>
> > It does make sense, Sijie, thanks for the update.
> >
> > -Flavio
> >
> > > On 17 Nov 2016, at 05:12, Sijie Guo  wrote:
> > >
> > > Flavio,
> > >
> > > I totally agreed that not using an official Apache  version is not
> great
> > > for the community. We had a bookkeeper meetup last night. We've
> discussed
> > > the current situation with the community. We came to a commitment to
> > merge
> > > Twitter's branch back into bookkeeper 4.5. After that we won't maintain
> > our
> > > own branch and switch to 4.5.
> > >
> > > Hope this make sense.
> > >
> > > Sijie
> > >
> > > On Nov 16, 2016 8:04 PM, "Flavio Junqueira"  wrote:
> > >
> > > It isn't great that DistributedLog is not using the Apache BookKeeper
> > > release. Essentially anyone using DistributedLog today needs to use the
> > > Twitter branch of BookKeeper, which has diverged from Apache
> BookKeeper.
> > > I'm sure the changes in the Twitter branch are all great, but I'd be
> more
> > > comfortable being able to rely on the Apache BookKeeper releases, which
> > are
> > > community driven.
> > >
> > > I'm not going to block the release on this alone because it is
> important
> > > for this project to get a first release out soon, but we need to fix
> > DL-2.
> > >
> > > -Flavio
> > >
> > >> On 15 Nov 2016, at 19:02, Leigh Stewart  >
> > > wrote:
> > >>
> > >> +1
> > >>
> > >> On Tue, Nov 15, 2016 at 7:01 PM, Franck Cuny 
> > > wrote:
> > >>
> > >>> +1 and I agree to not make DL-2 a blocker.
> > >>>
> > >>> On Tue, Nov 15, 2016 at 2:02 AM, Xi Liu 
> wrote:
> > >>>
> >  +1 especially on DL-23.
> > 
> >  - Xi
> > 
> >  On Sat, Nov 12, 2016 at 2:22 AM, Khurrum Nasim <
> > khurrumnas...@gmail.com>
> >  wrote:
> > 
> > > +1 (non-binding)
> > >
> > > I am also interested in participating.
> > >
> > > - kn
> > >
> > > On Tue, Nov 8, 2016 at 11:08 PM, Sijie Guo 
> wrote:
> > >
> > >> I'd like to start the discussion about the first release. There
> are
> > > still a
> > >> few discussions and pull requests outstanding. I think we need to
> > >>> pick
> > > up a
> > >> few items and cut the first release and then iterate from there.
> > Here
> >  is
> > > a
> > >> list of items that I think we should include:
> > >>
> > >> - DL-4 : Repackaging
> > > namespace
> > >> to org.apache (the pull request is out and under reviewing)
> > >> - DL-49 : support
> > scala
> > > 2.10
> > >> and 2.11 (the review is done, need to be merged)
> > >> - DL-23 : Move DL to
> >  depend
> > >> on
> > >> central maven repo. The main blocker is about the libthrift
> version,
> > > which
> > >> is only hosted at twtter's maven repo. There is a pull request
> out.
> > >>
> > >> I am kind of thinking to not make DL-2
> > >>  (using the official
> > >> bookkeeper
> > >> version) the blocker for the first release. We can cut a new
> release
> >  once
> > >> that change is ready. So to decouple the release procedure between
> > DL
> >  and
> > >> BK.
> > >>
> > >> Please feel free to add any jiras that you believe it should be
> >  included
> > > in
> > >> the first release.
> > >>
> > >> Also, is there anyone interested in being the release manager for
> > >>> first
> > >> release?
> > >>
> > >> - Sijie
> > >>
> > >
> > 
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> -franck
> > >>>
> >
> >
>


[GitHub] incubator-distributedlog pull request #46: Update a couple of scripts

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (DL-4) Repackage the source under apache namespace

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717305#comment-15717305
 ] 

ASF GitHub Bot commented on DL-4:
-

Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/41
  
@leighst @khurrumnasimm I would like to put this as last change to merge 
for the first apache release. since we might have quite a few changes to merge 
based on current package name.

@khurrumnasimm do you have any script for repacking this?


> Repackage the source under apache namespace
> ---
>
> Key: DL-4
> URL: https://issues.apache.org/jira/browse/DL-4
> Project: DistributedLog
>  Issue Type: Task
>Reporter: Sijie Guo
>Assignee: Sijie Guo
> Fix For: 0.4.0
>
>
> Per http://incubator.apache.org/guides/mentor.html#initial-clean-up, it is 
> recommended but not mandated.
> Create a ticket for tracking the discussion. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


incubator-distributedlog git commit: Update a couple of scripts

2016-12-02 Thread sijie
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master 2a677d15a -> a546e6207


Update a couple of scripts

Mostly style.

Author: Franck Cuny 
Author: Leigh Stewart 
Author: Khurrum Nasim 

Reviewers: Sijie Guo 

Closes #46 from franckcuny/fcuny/update-scripts and squashes the following 
commits:

50c16ec [Franck Cuny] Rename a variable in one of the shell script.
924ba7e [Franck Cuny] Run `git rev-parse` only once when building the bundle.
f1d3b3f [Franck Cuny] Remove more duplicated shell scripts.
90ce66f [Franck Cuny] Do not duplicate code for the 'bundle' script.
13987ea [Franck Cuny] Build cobertura report only on master for successful 
builds
525ec9a [Khurrum Nasim] Fix deadlock on BKSyncLogReaderDLSN
23c9190 [Leigh Stewart] Add documentation for distributedlog-benchmark
85aa8a7 [Franck Cuny] Make the shell style more consistent.
4f81ba2 [Franck Cuny] Rely on git to find the root directory.


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/a546e620
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/a546e620
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/a546e620

Branch: refs/heads/master
Commit: a546e62076ff34d48c2cbf6a4b803d789e4b5466
Parents: 2a677d1
Author: Franck Cuny 
Authored: Fri Dec 2 19:53:39 2016 -0800
Committer: Sijie Guo 
Committed: Fri Dec 2 19:53:39 2016 -0800

--
 distributedlog-benchmark/bin/bundle |  17 +--
 distributedlog-benchmark/bin/dbench | 134 ---
 distributedlog-core/bin/dlog| 160 ++-
 distributedlog-service/bin/bundle   |  17 +--
 distributedlog-service/bin/dlog | 179 ---
 scripts/bundle  |  45 
 scripts/common.sh   | 126 ++
 scripts/runner  | 148 +
 scripts/snapshot|  18 ++--
 9 files changed, 305 insertions(+), 539 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/a546e620/distributedlog-benchmark/bin/bundle
--
diff --git a/distributedlog-benchmark/bin/bundle 
b/distributedlog-benchmark/bin/bundle
index 353f438..838f74d 100755
--- a/distributedlog-benchmark/bin/bundle
+++ b/distributedlog-benchmark/bin/bundle
@@ -18,19 +18,8 @@
 # * limitations under the License.
 # */
 
-BASEDIR=$(dirname "$0")
-DISTRIBUTEDLOG_ROOT="${BASEDIR}/../.."
-
 set -e
-shopt -s dotglob
 
-cd ${DISTRIBUTEDLOG_ROOT}
-rm -rf distributedlog-benchmark/lib
-rm -rf dist/distributedlog-benchmark*
-mkdir -p dist/distributedlog-benchmark/{conf,lib}
-mvn clean install -Ptwitter-ostrich-provider -pl distributedlog-benchmark -am 
-DskipTests
-cp -rf distributedlog-benchmark/conf/* dist/distributedlog-benchmark/conf
-cp -rf distributedlog-benchmark/lib/* dist/distributedlog-benchmark/lib
-cp -rf distributedlog-benchmark/target/distributedlog-benchmark-*.jar 
dist/distributedlog-benchmark
-cd dist
-zip -r distributedlog-benchmark.zip distributedlog-benchmark >/dev/null
+DLOG_ROOT=$(git rev-parse --show-toplevel)
+
+bash "${DLOG_ROOT}"/scripts/bundle benchmark

http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/a546e620/distributedlog-benchmark/bin/dbench
--
diff --git a/distributedlog-benchmark/bin/dbench 
b/distributedlog-benchmark/bin/dbench
index b84e133..42dd5b0 100755
--- a/distributedlog-benchmark/bin/dbench
+++ b/distributedlog-benchmark/bin/dbench
@@ -18,59 +18,13 @@
 # * limitations under the License.
 # */
 
-# check if net.ipv6.bindv6only is set to 1
-bindv6only=$(/sbin/sysctl -n net.ipv6.bindv6only 2> /dev/null)
-if [ -n "$bindv6only" ] && [ "$bindv6only" -eq "1" ]
-then
-  echo "Error: \"net.ipv6.bindv6only\" is set to 1 - Java networking could be 
broken"
-  echo "For more info (the following page also applies to dlog): 
http://wiki.apache.org/hadoop/HadoopIPv6";
-  exit 1
-fi
+set -e
 
-# See the following page for extensive details on setting
-# up the JVM to accept JMX remote management:
-# http://java.sun.com/javase/6/docs/technotes/guides/management/agent.html
-# by default we allow local JMX connections
-if [ "x$JMXLOCALONLY" = "x" ]
-then
-JMXLOCALONLY=false
-fi
+DLOG_ROOT=$(git rev-parse --show-toplevel)
 
-if [ "x$JMXDISABLE" = "x" ]
-then
-echo "JMX enabled by default" >&2
-# for some reason these two options are necessary on jdk6 on Ubuntu
-#   accord to the docs they are not necessary, but otw jconsole cannot
-#   do a local attach
-JMX_ARGS="-Dcom.sun.management.jmxremote 
-Dcom.sun.management.jmxremote.local.only=$JMXLOCALONLY"
-else
-echo "JMX d

[GitHub] incubator-distributedlog issue #41: DL-4: Repackage the source under apache ...

2016-12-02 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/41
  
@leighst @khurrumnasimm I would like to put this as last change to merge 
for the first apache release. since we might have quite a few changes to merge 
based on current package name.

@khurrumnasimm do you have any script for repacking this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki

2016-12-02 Thread Sijie Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717301#comment-15717301
 ] 

Sijie Guo commented on DL-79:
-

[~xieliang007] looks good to me. I saw HBASE put the file under src/dev-support 
directory. shall we do the similar thing here?

> Add Eclipse-based Apache Formatter to DL Wiki
> -
>
> Key: DL-79
> URL: https://issues.apache.org/jira/browse/DL-79
> Project: DistributedLog
>  Issue Type: Wish
>  Components: documentation
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Attachments: DL_formatter.xml
>
>
> From 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we 
> saw several text suggestions, it would be nice if we have a importable ide 
> formatter file like HDFS/HBase/... projects, here is a ref jira: 
> https://issues.apache.org/jira/browse/HBASE-3678



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717293#comment-15717293
 ] 

ASF GitHub Bot commented on DL-80:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/48


> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread Sijie Guo (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sijie Guo resolved DL-80.
-
   Resolution: Fixed
Fix Version/s: 0.4.0

[~xieliang007] thank you for your contribution.

> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Fix For: 0.4.0
>
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717290#comment-15717290
 ] 

ASF GitHub Bot commented on DL-80:
--

Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/48
  
LGTM +1


> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-distributedlog pull request #48: DL-80 : synchronized getLogRecord...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


incubator-distributedlog git commit: DL-80: synchronized getLogRecordSetWriter()

2016-12-02 Thread sijie
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master e611ef9e8 -> 2a677d15a


DL-80: synchronized getLogRecordSetWriter()

see jira's comments

Author: xieliang 

Reviewers: Sijie Guo 

Closes #48 from xieliang/DL-80


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/2a677d15
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/2a677d15
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/2a677d15

Branch: refs/heads/master
Commit: 2a677d15aa8fd2284df125b1ee8be9e8ca8b8437
Parents: e611ef9
Author: xieliang 
Authored: Fri Dec 2 19:45:02 2016 -0800
Committer: Sijie Guo 
Committed: Fri Dec 2 19:45:02 2016 -0800

--
 .../distributedlog/client/DistributedLogMultiStreamWriter.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/2a677d15/distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogMultiStreamWriter.java
--
diff --git 
a/distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogMultiStreamWriter.java
 
b/distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogMultiStreamWriter.java
index fa3dceb..eac8f9d 100644
--- 
a/distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogMultiStreamWriter.java
+++ 
b/distributedlog-client/src/main/java/com/twitter/distributedlog/client/DistributedLogMultiStreamWriter.java
@@ -401,7 +401,7 @@ public class DistributedLogMultiStreamWriter implements 
Runnable {
 return streams.get(streamId);
 }
 
-LogRecordSet.Writer getLogRecordSetWriter() {
+synchronized LogRecordSet.Writer getLogRecordSetWriter() {
 return recordSetWriter;
 }
 



[GitHub] incubator-distributedlog issue #48: DL-80 : synchronized getLogRecordSetWrit...

2016-12-02 Thread sijie
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/48
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Assigned] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread Liang Xie (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liang Xie reassigned DL-80:
---

Assignee: Liang Xie

> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki

2016-12-02 Thread Liang Xie (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liang Xie updated DL-79:

Attachment: DL_formatter.xml

attached is a formatter file against DL wiki

> Add Eclipse-based Apache Formatter to DL Wiki
> -
>
> Key: DL-79
> URL: https://issues.apache.org/jira/browse/DL-79
> Project: DistributedLog
>  Issue Type: Wish
>  Components: documentation
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Attachments: DL_formatter.xml
>
>
> From 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we 
> saw several text suggestions, it would be nice if we have a importable ide 
> formatter file like HDFS/HBase/... projects, here is a ref jira: 
> https://issues.apache.org/jira/browse/HBASE-3678



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki

2016-12-02 Thread Liang Xie (JIRA)

 [ 
https://issues.apache.org/jira/browse/DL-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Liang Xie reassigned DL-79:
---

Assignee: Liang Xie

> Add Eclipse-based Apache Formatter to DL Wiki
> -
>
> Key: DL-79
> URL: https://issues.apache.org/jira/browse/DL-79
> Project: DistributedLog
>  Issue Type: Wish
>  Components: documentation
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>Assignee: Liang Xie
>
> From 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we 
> saw several text suggestions, it would be nice if we have a importable ide 
> formatter file like HDFS/HBase/... projects, here is a ref jira: 
> https://issues.apache.org/jira/browse/HBASE-3678



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Some errors in building DL, help

2016-12-02 Thread Sijie Guo
On Thu, Dec 1, 2016 at 10:18 PM, Jiecxy <253441...@qq.com> wrote:

> I fixed it, I forgot to download the pom file of these library …  so it
> still missed many libraries.
>

Glad that you fixed it.


> Actually, I'm always use the VPN and I can access the website by the
> browser,


Interesting. Are you able to ping maven.twttr.com in bash?


> but I can’t configure maven with my proxy settings properly, it uses the
> socks5 and have the encryption type of aes-256-cfb, how can I indicate this
> in the setting?
>
> I tried like this:
>
>   my-proxy
>   true
>   socks5
>   my.host
>   3633
>   
>   password
>   aes-256-cfb
> 
>

I am sorry. I am not very familiar with the encryption setting.

>
> but failed, any idea?
> I appreciate your help.
>
> Xiaoyuan
>
> > 在 2016年12月2日,01:19,Sijie Guo  写道:
> >
> > That's my suspect too.
> >
> > Xiaoyuan,
> >
> > The maven might be hanging connecting to maven.twttr.com. Is your web
> > browser using any proxy settings to access maven.twttr.com?
> >
> > You might try to configure your maven to use same proxy settings if it
> > can't connect to maven.twttr.com.
> >
> > https://maven.apache.org/guides/mini/guide-proxies.html
> >
> > - Sijie
> >
> > On Thu, Dec 1, 2016 at 7:49 AM, Jia Zhai  wrote:
> >
> >> Hi Xiaoyuan,
> >> Seems this is the network access issue in China, You could have a try if
> >> you could access http://www.twitter.com/.  Usually we need use VPN to
> get
> >> access .
> >>
> >> Regards.
> >> -Jia
> >>
> >> On Thu, Dec 1, 2016 at 9:10 PM, Xiaoyuan Chen <253441...@qq.com> wrote:
> >>
> >>> Hi guys,
> >>>
> >>>
> >>>  I downloaded the source code from here, the 0.3.51-RC1:
> >>> http://distributedlog.incubator.apache.org/docs/latest/start/download
> >>>  Like you said, I run the cmd:
> >>>mvn clean package -DskipTests
> >>>
> >>>
> >>>  First problem: It got stuck in the process of trying to get the
> library
> >>> : libthrift-0.5.0-1, always keeping retrying, like this:
> >>>Downloading: http://maven.twttr.com/org/
> >> apache/thrift/libthrift/0.5.0-
> >>> 1/libthrift-0.5.0-1.pom
> >>>
> >>>
> >>>  I don't know whether it's the problem of twitter or not. I'm sure
> there
> >>> is no problem with my network. Fine, I installed this library manually,
> >>> download from here:
> >>>http://mvnrepository.com/artifact/org.apache.thrift/
> >> libthrift/0.5.0-1
> >>>
> >>>
> >>>  Ok, same problem again, It can't find the library : stats-util-0.0.58,
> >>> installed manually too
> >>>Downloading: http://maven.twttr.com/com/
> >> twitter/common/stats-util/0.0.
> >>> 58/stats-util-0.0.58.pom
> >>>
> >>>
> >>>  BUT , second problem,
> >>>distributedlog-0.3.51-RC1/distributedlog-core/src/main/
> >>> java/com/twitter/distributedlog/rate/SampledMovingAverageRate.java:
> >> [20,32]
> >>>  it can't find the class Rate from com.twitter.common.stats, I check
> the
> >>> library stats-util-0.0.58 , there is no class Rate in it indeed, AND I
> >> find
> >>> it in the library stats-0.0.58.jar, weird, so I change the dependency
> to
> >>> it, BUT it ended up in the same error, but it just can't resolve the
> >> method
> >>> Rate.of(...).
> >>>
> >>>
> >>>  That's it, how can I fix it? I need help. By the way, how can I import
> >>> this project to the idea?
> >>>
> >>>
> >>> Thanks
> >>
>
>
>
>


[jira] [Commented] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714403#comment-15714403
 ] 

ASF GitHub Bot commented on DL-80:
--

GitHub user xieliang opened a pull request:

https://github.com/apache/incubator-distributedlog/pull/48

DL-80 : synchronized getLogRecordSetWriter()

see jira's comments

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xieliang/incubator-distributedlog DL-80

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-distributedlog/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit fc999fb57be8bc38390a5d1771ec8974e5fb54f3
Author: xieliang 
Date:   2016-12-02T07:50:20Z

synchronized getLogRecordSetWriter()




> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] incubator-distributedlog pull request #48: DL-80 : synchronized getLogRecord...

2016-12-02 Thread xieliang
GitHub user xieliang opened a pull request:

https://github.com/apache/incubator-distributedlog/pull/48

DL-80 : synchronized getLogRecordSetWriter()

see jira's comments

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xieliang/incubator-distributedlog DL-80

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-distributedlog/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit fc999fb57be8bc38390a5d1771ec8974e5fb54f3
Author: xieliang 
Date:   2016-12-02T07:50:20Z

synchronized getLogRecordSetWriter()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (DL-80) recordSetWriter has multi-thread issue

2016-12-02 Thread Sijie Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/DL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714386#comment-15714386
 ] 

Sijie Guo commented on DL-80:
-

[~xieliang007] nice catch. Are you interested in contributing a fix?

> recordSetWriter has multi-thread issue
> --
>
> Key: DL-80
> URL: https://issues.apache.org/jira/browse/DL-80
> Project: DistributedLog
>  Issue Type: Bug
>  Components: distributedlog-client
>Affects Versions: 0.4.0
>Reporter: Liang Xie
>
> Reading code, found there's a minor issue in DistributedLogMultiStreamWriter 
> class. Currenty only flush()&write() have *synchronized*, but 
> getLogRecordSetWriter miss the protection. so it would be possible get an 
> obsolete writer just after flush() happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)