Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread Xi Liu 
On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:

> Glad to see 0.4 will be release soon :)
> I could not find tutorials package from link[2], it should be released
> as well, please correct me if i am wrong.
> I can pass this command with current git master code: "mvn clean
> apache-rat:check package findbugs:check -DskipTests", but failed with
> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> dist.apache.org, the error msg:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> on project distributedlog-service: Failed to create assembly: Error
> adding file to archive:
> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
>

I also saw this issue.


>
> And none of you saw this : DL-181, it can be reproduced on my local
> box always w/o patched,  weird...
>
> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread Sijie Guo 
On Mon, Jan 9, 2017 at 5:32 PM, Sijie Guo  wrote:

> Thank you for your suggestion, Khurrum. Comment inline. I'd like to
> collect more feedbacks and then cut another RC.
>
>
> On Mon, Jan 9, 2017 at 11:43 AM, Khurrum Nasim 
> wrote:
>
>> Thanks Sijie for working on this. A couple of comments:
>>
>> - do we need to publish artifacts for both scala 2.10 and 2.11 (probably
>> also 2.12)? as DL uses some scala libraries as the dependencies.
>>
>
> Ah, ah, good catch. We need to publish both 2.10 and 2.11.
>
>
>> - the source jar is also missing. do we need it? it is usually useful to
>> have a source jar so that people who uses any IDE tool can easily navigate
>> to the source code.
>>
>
> It is a good suggestion. We don't have source maven plugin configured. We
> need to configure that.
>

Create https://issues.apache.org/jira/browse/DL-183 for generating the
source jar.

>
>
>
>
>>
>> - KN
>>
>> On Sun, Jan 8, 2017 at 8:04 PM, Sijie Guo  wrote:
>>
>> > Hi all,
>> >
>> > Please review and vote on the release candidate #1 for the version
>> 0.4.0,
>> > as follows:
>> >
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> >
>> > * JIRA release notes [1],
>> > * the official Apache source release to be deployed to
>> dist.apache.org
>> > [2],
>> > * all artifacts to be deployed to the Maven Central Repository [3],
>> > * source code tag "v0.4.0-RC1" [4],
>> > * website pull request listing the release [5] and publishing the
>> API
>> > reference manual.
>> >
>> > A simple instruction for validation the source and binary packages.
>> >
>> > - source package: run "*./scripts/integration/smoketest.sh*" after
>> > building
>> > the package with "*mvn clean apache-rat:check package findbugs:check
>> > -DskipTests*"
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PPMC affirmative votes.
>> >
>> > Thanks,
>> > Sijie
>> >
>> > [1]
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > projectId=12320620=12337980
>> > [2]
>> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
>> > incubating/
>> > [3]
>> > https://repository.apache.org/content/repositories/
>> > orgapachedistributedlog-1001/
>> > [4]
>> > https://github.com/apache/incubator-distributedlog/tree/
>> > v0.4.0-incubating-RC1
>> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>> >
>>
>
>

[GitHub] incubator-distributedlog pull request #111: Fix the script to make sure bina...

2017-01-09 Thread sijie 
GitHub user sijie opened a pull request:

https://github.com/apache/incubator-distributedlog/pull/111

Fix the script to make sure binary package can execute scripts correctly

- fix the release jar path
- copy the common script to each modules otherwise the built package won't 
be able to execute
- change the type of runner and copy the runner script to each tutorial 
module

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sijie/incubator-distributedlog 
sijie/copy_all_scripts_to_modules

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-distributedlog/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 79adb6234dee1279e56cc0b12c849a5f5cedfbb8
Author: Sijie Guo 
Date:   2017-01-09T01:54:49Z

Fix the script to make sure binary package can execute scripts correctly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread Sijie Guo 
On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:

> Glad to see 0.4 will be release soon :)
> I could not find tutorials package from link[2], it should be released
> as well, please correct me if i am wrong.
>

I was thinking it might be necessary to release tutorials as a separated
bin package. since they are tutorials, people can download the src package
and build from there. A service binary package for deployment and a
benchmark binary package for benchmarking are probably enough.

But I am open to release tutorials as a separated binary package. Not sure
how does other apache project do. I'd like to see other people's opinions.


> I can pass this command with current git master code: "mvn clean
> apache-rat:check package findbugs:check -DskipTests", but failed with
> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> dist.apache.org, the error msg:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> on project distributedlog-service: Failed to create assembly: Error
> adding file to archive:
> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
>
>
Ah, nice catch.

I think the src/assemble/bin.xml and src/assemble/src.xml have inconsistent
settings.

the bin.xml is looking for README.md


  ../README.md
  /
  644


however, the src.xml doesn't include README.md in the source package.

  
**/README



> And none of you saw this : DL-181, it can be reproduced on my local
> box always w/o patched,  weird...
>
>
I think I fixed that before. It is probably not pushed to master but in the
release branch. I merged your change to both master and
release-0.4.0-incubating branch. so it should be okay now.


> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread Sijie Guo 
On Mon, Jan 9, 2017 at 11:07 PM, Sijie Guo  wrote:

>
>
> On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:
>
>> Glad to see 0.4 will be release soon :)
>> I could not find tutorials package from link[2], it should be released
>> as well, please correct me if i am wrong.
>>
>
> I was thinking it might be necessary to release tutorials as a separated
> bin package. since they are tutorials, people can download the src package
> and build from there. A service binary package for deployment and a
> benchmark binary package for benchmarking are probably enough.
>
> But I am open to release tutorials as a separated binary package. Not sure
> how does other apache project do. I'd like to see other people's opinions.
>
>
>> I can pass this command with current git master code: "mvn clean
>> apache-rat:check package findbugs:check -DskipTests", but failed with
>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
>> dist.apache.org, the error msg:
>>
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
>> on project distributedlog-service: Failed to create assembly: Error
>> adding file to archive:
>> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
>> isn't a file. -> [Help 1]
>>
>>
> Ah, nice catch.
>
> I think the src/assemble/bin.xml and src/assemble/src.xml have
> inconsistent settings.
>
> the bin.xml is looking for README.md
>
> 
>   ../README.md
>   /
>   644
> 
>
> however, the src.xml doesn't include README.md in the source package.
>
>   
> **/README
>

Created https://issues.apache.org/jira/browse/DL-182 .

Liang, do you want to help fix it?


>
>
>
>> And none of you saw this : DL-181, it can be reproduced on my local
>> box always w/o patched,  weird...
>>
>>
> I think I fixed that before. It is probably not pushed to master but in
> the release branch. I merged your change to both master and
> release-0.4.0-incubating branch. so it should be okay now.
>
>
>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>> > Hi all,
>> >
>> > Please review and vote on the release candidate #1 for the version
>> 0.4.0,
>> > as follows:
>> >
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> >
>> > * JIRA release notes [1],
>> > * the official Apache source release to be deployed to
>> dist.apache.org
>> > [2],
>> > * all artifacts to be deployed to the Maven Central Repository [3],
>> > * source code tag "v0.4.0-RC1" [4],
>> > * website pull request listing the release [5] and publishing the
>> API
>> > reference manual.
>> >
>> > A simple instruction for validation the source and binary packages.
>> >
>> > - source package: run "*./scripts/integration/smoketest.sh*" after
>> building
>> > the package with "*mvn clean apache-rat:check package findbugs:check
>> > -DskipTests*"
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PPMC affirmative votes.
>> >
>> > Thanks,
>> > Sijie
>> >
>> > [1]
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12320620=12337980
>> > [2]
>> > https://dist.apache.org/repos/dist/dev/incubator/distributed
>> log/0.4.0-incubating/
>> > [3]
>> > https://repository.apache.org/content/repositories/orgapache
>> distributedlog-1001/
>> > [4]
>> > https://github.com/apache/incubator-distributedlog/tree/v0.
>> 4.0-incubating-RC1
>> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>>
>
>

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread Sijie Guo 
yeah, you need a clean repo before running apache-rat:check in master.

On Mon, Jan 9, 2017 at 9:01 PM, liang xie  wrote:

> Master issue gone now after checking rat.txt and removing the log
> files generated by privious tests.
>
> On Tue, Jan 10, 2017 at 12:05 PM, liang xie  wrote:
> > oops, "mvn clean apache-rat:check package findbugs:check -DskipTests"
> > failed at the latest master code with another diff err msg:
> > Failed to execute goal org.apache.rat:apache-rat-plugin:0.7:check
> > (default-cli) on project distributedlog-service: Too many unapproved
> > licenses: 5
> >
> >
> > On Tue, Jan 10, 2017 at 12:00 PM, liang xie 
> wrote:
> >> Glad to see 0.4 will be release soon :)
> >> I could not find tutorials package from link[2], it should be released
> >> as well, please correct me if i am wrong.
> >> I can pass this command with current git master code: "mvn clean
> >> apache-rat:check package findbugs:check -DskipTests", but failed with
> >> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> >> dist.apache.org, the error msg:
> >>
> >> [ERROR] Failed to execute goal
> >> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> >> on project distributedlog-service: Failed to create assembly: Error
> >> adding file to archive:
> >> /tmp/distributedlog-0.4.0-incubating/distributedlog-
> service/../README.md
> >> isn't a file. -> [Help 1]
> >>
> >> And none of you saw this : DL-181, it can be reproduced on my local
> >> box always w/o patched,  weird...
> >>
> >> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> >>> Hi all,
> >>>
> >>> Please review and vote on the release candidate #1 for the version
> 0.4.0,
> >>> as follows:
> >>>
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>
> >>> The complete staging area is available for your review, which includes:
> >>>
> >>> * JIRA release notes [1],
> >>> * the official Apache source release to be deployed to
> dist.apache.org
> >>> [2],
> >>> * all artifacts to be deployed to the Maven Central Repository [3],
> >>> * source code tag "v0.4.0-RC1" [4],
> >>> * website pull request listing the release [5] and publishing the
> API
> >>> reference manual.
> >>>
> >>> A simple instruction for validation the source and binary packages.
> >>>
> >>> - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> >>> the package with "*mvn clean apache-rat:check package findbugs:check
> >>> -DskipTests*"
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by majority
> >>> approval, with at least 3 PPMC affirmative votes.
> >>>
> >>> Thanks,
> >>> Sijie
> >>>
> >>> [1]
> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> >>> [2]
> >>> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> >>> [3]
> >>> https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> >>> [4]
> >>> https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> >>> [5] https://github.com/apache/incubator-distributedlog/pull/109
>

[GitHub] incubator-distributedlog issue #110: DL-181 : avoid starting failure due to ...

2017-01-09 Thread sijie 
Github user sijie commented on the issue:

https://github.com/apache/incubator-distributedlog/pull/110
  
merged to master and also cherry-pick it to release-0.4.0-incubating branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-distributedlog git commit: DL-181: avoid starting failure due to call Optional.get() on an absent value

2017-01-09 Thread sijie 
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/release-0.4.0-incubating 2f467e4c2 -> 3c979e672


DL-181: avoid starting failure due to call Optional.get() on an absent value

see original JIRA for the detailed error msg

Author: xieliang 

Reviewers: Sijie Guo 

Closes #110 from xieliang/DL-181-startingProxyFailed

(cherry picked from commit 0c6e7949718abf5c30c150ffd045a8b765373cd6)
Signed-off-by: Sijie Guo 


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/3c979e67
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/3c979e67
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/3c979e67

Branch: refs/heads/release-0.4.0-incubating
Commit: 3c979e6724d9a5139f7d28db611aa7efa464bb32
Parents: 2f467e4
Author: xieliang 
Authored: Mon Jan 9 22:47:09 2017 -0800
Committer: Sijie Guo 
Committed: Mon Jan 9 22:48:49 2017 -0800

--
 .../org/apache/distributedlog/service/DistributedLogServer.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/3c979e67/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
--
diff --git 
a/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
 
b/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
index d37612a..81e476b 100644
--- 
a/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
+++ 
b/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
@@ -186,8 +186,8 @@ public class DistributedLogServer {
 }
 Class loadAppraiserClass = 
Class.forName(loadAppraiserClassStr.or(DEFAULT_LOAD_APPRIASER));
 LoadAppraiser loadAppraiser = (LoadAppraiser) 
ReflectionUtils.newInstance(loadAppraiserClass);
-logger.info("Supplied load appraiser class is " + loadAppraiserClass
-+ " Instantiated " + loadAppraiser.getClass().getCanonicalName());
+logger.info("Load appraiser class is " + loadAppraiserClassStr.or("not 
specified.") + " Instantiated "
++ loadAppraiser.getClass().getCanonicalName());
 
 StreamConfigProvider streamConfProvider =
 getStreamConfigProvider(dlConf, converter);

[GitHub] incubator-distributedlog pull request #110: DL-181 : avoid starting failure ...

2017-01-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-distributedlog/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

incubator-distributedlog git commit: DL-181: avoid starting failure due to call Optional.get() on an absent value

2017-01-09 Thread sijie 
Repository: incubator-distributedlog
Updated Branches:
  refs/heads/master 8bb9cc004 -> 0c6e79497


DL-181: avoid starting failure due to call Optional.get() on an absent value

see original JIRA for the detailed error msg

Author: xieliang 

Reviewers: Sijie Guo 

Closes #110 from xieliang/DL-181-startingProxyFailed


Project: http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/commit/0c6e7949
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/tree/0c6e7949
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/diff/0c6e7949

Branch: refs/heads/master
Commit: 0c6e7949718abf5c30c150ffd045a8b765373cd6
Parents: 8bb9cc0
Author: xieliang 
Authored: Mon Jan 9 22:47:09 2017 -0800
Committer: Sijie Guo 
Committed: Mon Jan 9 22:47:09 2017 -0800

--
 .../org/apache/distributedlog/service/DistributedLogServer.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-distributedlog/blob/0c6e7949/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
--
diff --git 
a/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
 
b/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
index 7887445..81e476b 100644
--- 
a/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
+++ 
b/distributedlog-service/src/main/java/org/apache/distributedlog/service/DistributedLogServer.java
@@ -186,8 +186,8 @@ public class DistributedLogServer {
 }
 Class loadAppraiserClass = 
Class.forName(loadAppraiserClassStr.or(DEFAULT_LOAD_APPRIASER));
 LoadAppraiser loadAppraiser = (LoadAppraiser) 
ReflectionUtils.newInstance(loadAppraiserClass);
-logger.info("Supplied load appraiser class is " + 
loadAppraiserClassStr.get()
-+ " Instantiated " + loadAppraiser.getClass().getCanonicalName());
+logger.info("Load appraiser class is " + loadAppraiserClassStr.or("not 
specified.") + " Instantiated "
++ loadAppraiser.getClass().getCanonicalName());
 
 StreamConfigProvider streamConfProvider =
 getStreamConfigProvider(dlConf, converter);

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread liang xie 
Glad to see 0.4 will be release soon :)
I could not find tutorials package from link[2], it should be released
as well, please correct me if i am wrong.
I can pass this command with current git master code: "mvn clean
apache-rat:check package findbugs:check -DskipTests", but failed with
from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
dist.apache.org, the error msg:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
on project distributedlog-service: Failed to create assembly: Error
adding file to archive:
/tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
isn't a file. -> [Help 1]

And none of you saw this : DL-181, it can be reproduced on my local
box always w/o patched,  weird...

On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> Hi all,
>
> Please review and vote on the release candidate #1 for the version 0.4.0,
> as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
>
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * source code tag "v0.4.0-RC1" [4],
> * website pull request listing the release [5] and publishing the API
> reference manual.
>
> A simple instruction for validation the source and binary packages.
>
> - source package: run "*./scripts/integration/smoketest.sh*" after building
> the package with "*mvn clean apache-rat:check package findbugs:check
> -DskipTests*"
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PPMC affirmative votes.
>
> Thanks,
> Sijie
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320620=12337980
> [2]
> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-incubating/
> [3]
> https://repository.apache.org/content/repositories/orgapachedistributedlog-1001/
> [4]
> https://github.com/apache/incubator-distributedlog/tree/v0.4.0-incubating-RC1
> [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

2017-01-09 Thread Sijie Guo 
Thank you for your suggestion, Khurrum. Comment inline. I'd like to collect
more feedbacks and then cut another RC.


On Mon, Jan 9, 2017 at 11:43 AM, Khurrum Nasim 
wrote:

> Thanks Sijie for working on this. A couple of comments:
>
> - do we need to publish artifacts for both scala 2.10 and 2.11 (probably
> also 2.12)? as DL uses some scala libraries as the dependencies.
>

Ah, ah, good catch. We need to publish both 2.10 and 2.11.


> - the source jar is also missing. do we need it? it is usually useful to
> have a source jar so that people who uses any IDE tool can easily navigate
> to the source code.
>

It is a good suggestion. We don't have source maven plugin configured. We
need to configure that.




>
> - KN
>
> On Sun, Jan 8, 2017 at 8:04 PM, Sijie Guo  wrote:
>
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> > building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12320620=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> > incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> > orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> > v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
> >
>

[GitHub] incubator-distributedlog pull request #110: DL-181 : avoid starting failure ...

2017-01-09 Thread xieliang 
GitHub user xieliang opened a pull request:

https://github.com/apache/incubator-distributedlog/pull/110

DL-181 : avoid starting failure due to call Optional.get() on an absent 
value

see original JIRA for the detailed error msg

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xieliang/incubator-distributedlog 
DL-181-startingProxyFailed

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-distributedlog/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #110


commit ca27983b0c2fb6056f87311766e048325c1fc09a
Author: xieliang 
Date:   2017-01-09T10:33:08Z

avoid starting failure due to call Optional.get() on an absent value




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---