[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/605


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/605#discussion_r82496282
  
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -392,5 +392,7 @@ export DRILL_HOME
 export DRILL_CONF_DIR
 export DRILL_LOG_DIR
 export CP
-export JAVA_HOME
+# DRILL-4870: Don't export JAVA_HOME. Java can find it just fine from the 
java
+# command. If we attempt to work out out, we do so incorrectly for the Mac.
--- End diff --

+1. Looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

https://github.com/apache/drill/pull/605#discussion_r82495596
  
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -392,5 +392,7 @@ export DRILL_HOME
 export DRILL_CONF_DIR
 export DRILL_LOG_DIR
 export CP
-export JAVA_HOME
+# DRILL-4870: Don't export JAVA_HOME. Java can find it just fine from the 
java
+# command. If we attempt to work out out, we do so incorrectly for the Mac.
--- End diff --

Yikes! Fixed the typo.

Changed the reference to JAVA_HOME to a reference relative to java, which 
we must already know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/605#discussion_r82488367
  
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -392,5 +392,7 @@ export DRILL_HOME
 export DRILL_CONF_DIR
 export DRILL_LOG_DIR
 export CP
-export JAVA_HOME
+# DRILL-4870: Don't export JAVA_HOME. Java can find it just fine from the 
java
+# command. If we attempt to work out out, we do so incorrectly for the Mac.
--- End diff --

typo? 'work out out'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/605#discussion_r82488363
  
--- Diff: distribution/src/resources/drill-config.sh ---
@@ -392,5 +392,7 @@ export DRILL_HOME
 export DRILL_CONF_DIR
 export DRILL_LOG_DIR
 export CP
-export JAVA_HOME
--- End diff --

In drillbit.sh, we refer to JAVA_HOME with this '$JAVA_HOME/bin/jstack', is 
that piece of code still working after we do not export JAVA_HOME here?
Maybe it is better we limit the impact of not exporting JAVA_HOME to MAC 
and keep the same behavior on Linux(and other OSes)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #605: DRILL-4870 drill-config.sh sets JAVA_HOME incorrect...

[paul-rogers]

GitHub user paul-rogers opened a pull request:

https://github.com/apache/drill/pull/605

DRILL-4870 drill-config.sh sets JAVA_HOME incorrectly for the Mac

Recent script revisions uncommented a line to export the Drill-computed 
JAVA_HOME. Turns out, we should not do this; we should allow Java to figure it 
out as the location differs depending on platform. This change comments out 
that export line to restore the pre-1.8 functionality.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-rogers/drill DRILL-4870

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #605


commit 164a29d92011722f6234ed442e62919048d45fb4
Author: Paul Rogers 
Date:   2016-10-07T20:53:38Z

DRILL-4870 drill-config.sh sets JAVA_HOME incorrectly for the Mac




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---