date:20181205

Ian,

Thanks for guiding me. I am on it.

Regards
Imteyaz


On 6 Dec 2018 11:49 a.m., "Ian Luo"  wrote:

Hi Khan,

Feel free to start from any module to enhance the existing JavaDoc and
comments, and submit the pull request when you feel it's ready. I am so
glad that there's native speaker willing to join this effort :)

Thanks,
-Ian.


On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan  wrote:

> I have just started documenting module 'dubbo-filter',  below are example
> of mine, this is just to make sure I am in align with the documentation
> style
>
> /**
>  * CacheFilter is a core component of dubbo.Enabling cache key
> of service,method,consumer or provider dubbo will cache method return
> value.
>  * Along with cache key we need to configure cache type. Dubbo default
> implemented cache types are
>  * lur
>  * threadlocal
>  * jcache
>  * expiring
>  *
>  * 
>  *   e.g. 1)dubbo:service cache="lru" /
>  *2)dubbo:service / dubbo:method name="method2"
> cache="threadlocal" / dubbo:service/
>  *3)dubbo:provider cache="expiring" /
>  *4)dubbo:consumer cache="jcache" /
>  *
>  *If cache type is defined in method level then method level type will
> get precedence. According to above provided
>  *example, if service has two method, method1 and method2, method2
> will have cache type as threadlocal where others will
>  *be backed by lru
>  *
>  *
>  * @see org.apache.dubbo.rpc.Filter
>  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
>  * @see org.apache.dubbo.cache.support.lru.LruCache
>  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
>  * @see org.apache.dubbo.cache.support.jcache.JCache
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
>  *
>  */
> @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> Constants.CACHE_KEY)
> public class CacheFilter implements Filter {
>
> 
>
> .
>
> }
>
>
> On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan 
> wrote:
>
> > Just to make sure I have not misunderstood what mentioned earlier by
> > 'Filter' is 'dubbo-filter' correct?
> >
> > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > wrote:
> >
> >> Thanks a lot for the start, much appreciated.
> >>
> >>
> >>
> >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> >>
> >>> In addition, we strongly encourage open discussion.
> >>> You can post your comments on a Filter directly here. There will be
> some
> >>> people who know more about dubbo to review and discuss.
> >>>
> >>> Of course, any problem can be raised here. We will answer as soon as
> >>> possible.
> >>>
> >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> >>>
> >>> > very sorry. I have some work now, so I didn't respond to your email
> in
> >>> > time.
> >>> > I am very willing to help you with the completion of the comments.
If
> >>> you
> >>> > are a newbie, I suggest you start with a simple logic.
> >>> > Which parts of the logic are relatively simple? At present, I think
> >>> that
> >>> > our filter-related implementation is relatively simple (such as
> >>> > ActiveLimitFilter). You don't know the principle of dubbo at all,
and
> >>> you
> >>> > can understand the code and complete the comments more easily. You
> can
> >>> > start with the Filter related class and complete some of the
> comments.
> >>> >
> >>> > When you think that you know enough about dubbo, you can do some
core
> >>> > module comments, such as protocol-related comments.
> >>> >
> >>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >>> >
> >>> >> Hi All,
> >>> >>Trust you all are doing well. I am new to this community or even
> >>> new to
> >>> >> any open source development community. Had a chance to go through
> one
> >>> of
> >>> >> the dubbo github issue #2884('We need more code comments'), which
> was
> >>> >> marked as 'good first issue'. So thought it could be a good start
> for
> >>> me
> >>> >> to
> >>> >> start from here, but being new to open source and also to dubbo I
am
> >>> very
> >>> >> nervous from where and how to start. I will be great if team can
> help
> >>> me
> >>> >> and guide me too to assist you in any way I can.
> >>> >>
> >>> >> Regards
> >>> >> Imteyaz
> >>> >>
> >>> >
> >>>
> >>
>

Re: [DISCUSS] Next Dubbo meetup

Another concern is that Jan 19th is only two weeks before the Chinese New
Year.
I am not sure it is a proper time, if we can make one week easier, would
that be possible to get more users to attend?

On Thu, Dec 6, 2018 at 11:51 AM 王蓉(涂南)  wrote:

> sorry for the unannounced change.
> Yes, it is expected.
>
> You guys can keep voting via http://alibabadeveloper.mikecrm.com/7hZFeTl.
>
>
> --
> 发件人：Huxing Zhang 
> 发送时间：2018年12月6日(星期四) 11:13
> 收件人：dev 
> 主 题：Re: [DISCUSS] Next Dubbo meetup
>
> I noticed the vote url has been changed to
> http://alibabadeveloper.mikecrm.com/7hZFeTl, is this expected?
>
> On Wed, Dec 5, 2018 at 1:48 PM 王蓉(涂南)  wrote:
>
> > guys, do remember to vote via this link
> >
> >  ‍http://sc-meetup.mikecrm.com/7hZFeTl
> >
> > Deadline for this ballot is Dec.14.
> >
> >
> > --
> > 发件人：Huxing Zhang 
> > 发送时间：2018年12月4日(星期二) 22:07
> > 收件人：dev 
> > 主 题：Re: [DISCUSS] Next Dubbo meetup
> >
> > In the link[1] provided, there are 3 options:
> >
> > * Nanjing
> > * Guangzhou
> > * Other
> >
> > I prefer to a new city where we haven't been there before.
> > According to a survey, the number of users who is using Dubbo in
> Guangzhou
> > ranks 5th in China, only secondary to Beijing, Shanghai, Shenzhen,
> > Hangzhou.
> > So I am going to vote +1 for Guangzhou. :)
> >
> > [1] http://sc-meetup.mikecrm.com/7hZFeTl
> >
> > On Tue, Dec 4, 2018 at 4:08 PM 王蓉(涂南)  wrote:
> >
> > > Hi guys,
> > >
> > > I'm Amber, organizer of Dubbo meetup.
> > >
> > > Since 2018, Dubbo community has been touring around China!
> > > We have been to Beijing, Chengdu, Shenzhen, Shanghai, and Hangzhou.
> > > More than 30K developers have either come to the meetup or watched our
> > > live streaming videos.
> > > What a wonderful journey!
> > >
> > > Now you got to choose where our 2019 first meetup is going to be held!
> > > We're planning to hold another meetup on Jan 19th.
> > > Let us know your thoughts!
> > >
> > > Ballot here ‍http://sc-meetup.mikecrm.com/7hZFeTl
> > > Deadline for this ballot is Dec.14.
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
> > --
> > Best Regards！
> > Huxing
> >
>
> --
> Best Regards！
> Huxing
>

Re: About the comments coverage of the code

On Thu, Dec 6, 2018 at 2:05 PM Ian Luo  wrote:
>
> Xiaobo,
>
> Pls. convert all your articles into markdown format first, and share us
> your repository on GitHub.

I'd rather recommend to send pull request one by one. In this way, the
contribution can be measured so that the contributor can become a
committer in some day.

>
> Thanks,
> -Ian.
>
>
> On Thu, Dec 6, 2018 at 2:02 PM Ian Luo  wrote:
>
> > Xiaobo,
> >
> > I think this is a good proposal. Pls. create a new section 'source code
> > guide' under docs, and let's build it together.
> >
> > Thanks,
> > -Ian.
> >
> >
> > On Wed, Dec 5, 2018 at 8:57 PM 田 小波  wrote:
> >
> >> Hi community,
> >>
> >> I noticed that people in the WeChat group said that Dubbo's comments are
> >> too few and unfriendly to beginners. I just wrote some source analysis
> >> articles about Dubbo in the past. I have a lot of comments and analysis on
> >> the Dubbo source in the article. I think these articles can help beginners
> >> learn Dubbo. The list of articles is as follows:
> >>
> >> 时间  文章
> >> 2018-10-01  Dubbo 源码分析 - SPI 机制<
> >> https://www.cnblogs.com/nuun/p/9758682.html>
> >> 2018-10-13  Dubbo 源码分析 - 自适应拓展原理<
> >> https://www.cnblogs.com/nuun/p/9788319.html>
> >> 2018-10-31  Dubbo 源码分析 - 服务导出<
> >> https://www.cnblogs.com/nuun/p/9887190.html>
> >> 2018-11-12  Dubbo 源码分析 - 服务引用<
> >> https://www.cnblogs.com/nuun/p/9950361.html>
> >> 2018-11-17  Dubbo 源码分析 - 集群容错之 Directory<
> >> https://www.cnblogs.com/nuun/p/9980247.html>
> >> 2018-11-20  Dubbo 源码分析 - 集群容错之 Router<
> >> https://www.cnblogs.com/nuun/p/9991413.html>
> >> 2018-11-24  Dubbo 源码分析 - 集群容错之 Cluster<
> >> https://www.cnblogs.com/nuun/p/10018429.html>
> >> 2018-11-29  Dubbo 源码分析 - 集群容错之 LoadBalance<
> >> https://www.cnblogs.com/nuun/p/10041964.html>
> >> 未完成 Dubbo 源码分析 - 并发模型
> >> 未完成 Dubbo 源码分析 - 编解码
> >>
> >> If you are interested, you can review it. If you feel good, I can submit
> >> these articles to dubbo-website. If you feel that writing is not good, you
> >> are welcome to give some advice.
> >>
> >> 我注意到有人在微信群里说 Dubbo 的注释太少，对初学者不友好。我正好在过去一段时间内写了一些关于 Dubbo 的源码分析文章，我在文章中对
> >> Dubbo 源码进行了大量的注释和分析，我觉得这些文章可以帮助初学者学习 Dubbo。大家如果有兴趣，可以进行
> >> review。如果觉得还不错，我可以将这些文章提交给 dubbo-website。如果觉得写的不好，也欢迎多多指教。
> >>
> >> Regards
> >> Xiaobo
> >>
> >> 在 2018年12月5日，下午1:56，Ian Luo  写道：
> >>
> >> What I suggest is to revisit and enhance the existing javadoc/comments
> >> before consider to add more:
> >> 1. Enhance JavaDoc for all API. For this part, we may need some helps from
> >> native speakers
> >> 2. Revisit the current existing comments, and make it easier to understand
> >>
> >> Just my two cents,
> >> -Ian.
> >>
> >> On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu  wrote:
> >>
> >> Recently dubbo held an offline meetup. When discussing with many
> >> participants, many people have suggested that dubbo has very few comments.
> >>
> >> Comments are very important for us to understand the code. If our comments
> >> are few, it is very unfriendly for new developers.
> >>
> >> I created a new issue[1] to track this. We need more developers to
> >> contribute notes. I will continue to follow up on this matter.
> >>
> >> [1] https://github.com/apache/incubator-dubbo/issues/2884
> >>
> >>
> >>



-- 
Best Regards！
Huxing

Re: Wanted to assist dubbo community on issue #2884

2018-12-05 Thread Ian Luo

Hi Khan,

Feel free to start from any module to enhance the existing JavaDoc and
comments, and submit the pull request when you feel it's ready. I am so
glad that there's native speaker willing to join this effort :)

Thanks,
-Ian.


On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan  wrote:

> I have just started documenting module 'dubbo-filter',  below are example
> of mine, this is just to make sure I am in align with the documentation
> style
>
> /**
>  * CacheFilter is a core component of dubbo.Enabling cache key
> of service,method,consumer or provider dubbo will cache method return
> value.
>  * Along with cache key we need to configure cache type. Dubbo default
> implemented cache types are
>  * lur
>  * threadlocal
>  * jcache
>  * expiring
>  *
>  * 
>  *   e.g. 1)dubbo:service cache="lru" /
>  *2)dubbo:service / dubbo:method name="method2"
> cache="threadlocal" / dubbo:service/
>  *3)dubbo:provider cache="expiring" /
>  *4)dubbo:consumer cache="jcache" /
>  *
>  *If cache type is defined in method level then method level type will
> get precedence. According to above provided
>  *example, if service has two method, method1 and method2, method2
> will have cache type as threadlocal where others will
>  *be backed by lru
>  *
>  *
>  * @see org.apache.dubbo.rpc.Filter
>  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
>  * @see org.apache.dubbo.cache.support.lru.LruCache
>  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
>  * @see org.apache.dubbo.cache.support.jcache.JCache
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
>  *
>  */
> @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> Constants.CACHE_KEY)
> public class CacheFilter implements Filter {
>
> 
>
> .
>
> }
>
>
> On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan 
> wrote:
>
> > Just to make sure I have not misunderstood what mentioned earlier by
> > 'Filter' is 'dubbo-filter' correct?
> >
> > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > wrote:
> >
> >> Thanks a lot for the start, much appreciated.
> >>
> >>
> >>
> >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> >>
> >>> In addition, we strongly encourage open discussion.
> >>> You can post your comments on a Filter directly here. There will be
> some
> >>> people who know more about dubbo to review and discuss.
> >>>
> >>> Of course, any problem can be raised here. We will answer as soon as
> >>> possible.
> >>>
> >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> >>>
> >>> > very sorry. I have some work now, so I didn't respond to your email
> in
> >>> > time.
> >>> > I am very willing to help you with the completion of the comments. If
> >>> you
> >>> > are a newbie, I suggest you start with a simple logic.
> >>> > Which parts of the logic are relatively simple? At present, I think
> >>> that
> >>> > our filter-related implementation is relatively simple (such as
> >>> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
> >>> you
> >>> > can understand the code and complete the comments more easily. You
> can
> >>> > start with the Filter related class and complete some of the
> comments.
> >>> >
> >>> > When you think that you know enough about dubbo, you can do some core
> >>> > module comments, such as protocol-related comments.
> >>> >
> >>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >>> >
> >>> >> Hi All,
> >>> >>Trust you all are doing well. I am new to this community or even
> >>> new to
> >>> >> any open source development community. Had a chance to go through
> one
> >>> of
> >>> >> the dubbo github issue #2884('We need more code comments'), which
> was
> >>> >> marked as 'good first issue'. So thought it could be a good start
> for
> >>> me
> >>> >> to
> >>> >> start from here, but being new to open source and also to dubbo I am
> >>> very
> >>> >> nervous from where and how to start. I will be great if team can
> help
> >>> me
> >>> >> and guide me too to assist you in any way I can.
> >>> >>
> >>> >> Regards
> >>> >> Imteyaz
> >>> >>
> >>> >
> >>>
> >>
>

Re: About the comments coverage of the code

2018-12-05 Thread Ian Luo

Xiaobo,

Pls. convert all your articles into markdown format first, and share us
your repository on GitHub.

Thanks,
-Ian.


On Thu, Dec 6, 2018 at 2:02 PM Ian Luo  wrote:

> Xiaobo,
>
> I think this is a good proposal. Pls. create a new section 'source code
> guide' under docs, and let's build it together.
>
> Thanks,
> -Ian.
>
>
> On Wed, Dec 5, 2018 at 8:57 PM 田 小波  wrote:
>
>> Hi community,
>>
>> I noticed that people in the WeChat group said that Dubbo's comments are
>> too few and unfriendly to beginners. I just wrote some source analysis
>> articles about Dubbo in the past. I have a lot of comments and analysis on
>> the Dubbo source in the article. I think these articles can help beginners
>> learn Dubbo. The list of articles is as follows:
>>
>> 时间  文章
>> 2018-10-01  Dubbo 源码分析 - SPI 机制<
>> https://www.cnblogs.com/nuun/p/9758682.html>
>> 2018-10-13  Dubbo 源码分析 - 自适应拓展原理<
>> https://www.cnblogs.com/nuun/p/9788319.html>
>> 2018-10-31  Dubbo 源码分析 - 服务导出<
>> https://www.cnblogs.com/nuun/p/9887190.html>
>> 2018-11-12  Dubbo 源码分析 - 服务引用<
>> https://www.cnblogs.com/nuun/p/9950361.html>
>> 2018-11-17  Dubbo 源码分析 - 集群容错之 Directory<
>> https://www.cnblogs.com/nuun/p/9980247.html>
>> 2018-11-20  Dubbo 源码分析 - 集群容错之 Router<
>> https://www.cnblogs.com/nuun/p/9991413.html>
>> 2018-11-24  Dubbo 源码分析 - 集群容错之 Cluster<
>> https://www.cnblogs.com/nuun/p/10018429.html>
>> 2018-11-29  Dubbo 源码分析 - 集群容错之 LoadBalance<
>> https://www.cnblogs.com/nuun/p/10041964.html>
>> 未完成 Dubbo 源码分析 - 并发模型
>> 未完成 Dubbo 源码分析 - 编解码
>>
>> If you are interested, you can review it. If you feel good, I can submit
>> these articles to dubbo-website. If you feel that writing is not good, you
>> are welcome to give some advice.
>>
>> 我注意到有人在微信群里说 Dubbo 的注释太少，对初学者不友好。我正好在过去一段时间内写了一些关于 Dubbo 的源码分析文章，我在文章中对
>> Dubbo 源码进行了大量的注释和分析，我觉得这些文章可以帮助初学者学习 Dubbo。大家如果有兴趣，可以进行
>> review。如果觉得还不错，我可以将这些文章提交给 dubbo-website。如果觉得写的不好，也欢迎多多指教。
>>
>> Regards
>> Xiaobo
>>
>> 在 2018年12月5日，下午1:56，Ian Luo  写道：
>>
>> What I suggest is to revisit and enhance the existing javadoc/comments
>> before consider to add more:
>> 1. Enhance JavaDoc for all API. For this part, we may need some helps from
>> native speakers
>> 2. Revisit the current existing comments, and make it easier to understand
>>
>> Just my two cents,
>> -Ian.
>>
>> On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu  wrote:
>>
>> Recently dubbo held an offline meetup. When discussing with many
>> participants, many people have suggested that dubbo has very few comments.
>>
>> Comments are very important for us to understand the code. If our comments
>> are few, it is very unfriendly for new developers.
>>
>> I created a new issue[1] to track this. We need more developers to
>> contribute notes. I will continue to follow up on this matter.
>>
>> [1] https://github.com/apache/incubator-dubbo/issues/2884
>>
>>
>>

Re: About the comments coverage of the code

2018-12-05 Thread Ian Luo

Xiaobo,

I think this is a good proposal. Pls. create a new section 'source code
guide' under docs, and let's build it together.

Thanks,
-Ian.


On Wed, Dec 5, 2018 at 8:57 PM 田 小波  wrote:

> Hi community,
>
> I noticed that people in the WeChat group said that Dubbo's comments are
> too few and unfriendly to beginners. I just wrote some source analysis
> articles about Dubbo in the past. I have a lot of comments and analysis on
> the Dubbo source in the article. I think these articles can help beginners
> learn Dubbo. The list of articles is as follows:
>
> 时间  文章
> 2018-10-01  Dubbo 源码分析 - SPI 机制<
> https://www.cnblogs.com/nuun/p/9758682.html>
> 2018-10-13  Dubbo 源码分析 - 自适应拓展原理<
> https://www.cnblogs.com/nuun/p/9788319.html>
> 2018-10-31  Dubbo 源码分析 - 服务导出<
> https://www.cnblogs.com/nuun/p/9887190.html>
> 2018-11-12  Dubbo 源码分析 - 服务引用<
> https://www.cnblogs.com/nuun/p/9950361.html>
> 2018-11-17  Dubbo 源码分析 - 集群容错之 Directory<
> https://www.cnblogs.com/nuun/p/9980247.html>
> 2018-11-20  Dubbo 源码分析 - 集群容错之 Router<
> https://www.cnblogs.com/nuun/p/9991413.html>
> 2018-11-24  Dubbo 源码分析 - 集群容错之 Cluster<
> https://www.cnblogs.com/nuun/p/10018429.html>
> 2018-11-29  Dubbo 源码分析 - 集群容错之 LoadBalance<
> https://www.cnblogs.com/nuun/p/10041964.html>
> 未完成 Dubbo 源码分析 - 并发模型
> 未完成 Dubbo 源码分析 - 编解码
>
> If you are interested, you can review it. If you feel good, I can submit
> these articles to dubbo-website. If you feel that writing is not good, you
> are welcome to give some advice.
>
> 我注意到有人在微信群里说 Dubbo 的注释太少，对初学者不友好。我正好在过去一段时间内写了一些关于 Dubbo 的源码分析文章，我在文章中对
> Dubbo 源码进行了大量的注释和分析，我觉得这些文章可以帮助初学者学习 Dubbo。大家如果有兴趣，可以进行
> review。如果觉得还不错，我可以将这些文章提交给 dubbo-website。如果觉得写的不好，也欢迎多多指教。
>
> Regards
> Xiaobo
>
> 在 2018年12月5日，下午1:56，Ian Luo  写道：
>
> What I suggest is to revisit and enhance the existing javadoc/comments
> before consider to add more:
> 1. Enhance JavaDoc for all API. For this part, we may need some helps from
> native speakers
> 2. Revisit the current existing comments, and make it easier to understand
>
> Just my two cents,
> -Ian.
>
> On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu  wrote:
>
> Recently dubbo held an offline meetup. When discussing with many
> participants, many people have suggested that dubbo has very few comments.
>
> Comments are very important for us to understand the code. If our comments
> are few, it is very unfriendly for new developers.
>
> I created a new issue[1] to track this. We need more developers to
> contribute notes. I will continue to follow up on this matter.
>
> [1] https://github.com/apache/incubator-dubbo/issues/2884
>
>
>

回复：[DISCUSS] Next Dubbo meetup

2018-12-05 Thread 王蓉(涂南)

sorry for the unannounced change.
Yes, it is expected.

You guys can keep voting via http://alibabadeveloper.mikecrm.com/7hZFeTl.


--
发件人：Huxing Zhang 
发送时间：2018年12月6日(星期四) 11:13
收件人：dev 
主　题：Re: [DISCUSS] Next Dubbo meetup

I noticed the vote url has been changed to
http://alibabadeveloper.mikecrm.com/7hZFeTl, is this expected?

On Wed, Dec 5, 2018 at 1:48 PM 王蓉(涂南)  wrote:

> guys, do remember to vote via this link
>
>  ‍http://sc-meetup.mikecrm.com/7hZFeTl
>
> Deadline for this ballot is Dec.14.
>
>
> --
> 发件人：Huxing Zhang 
> 发送时间：2018年12月4日(星期二) 22:07
> 收件人：dev 
> 主 题：Re: [DISCUSS] Next Dubbo meetup
>
> In the link[1] provided, there are 3 options:
>
> * Nanjing
> * Guangzhou
> * Other
>
> I prefer to a new city where we haven't been there before.
> According to a survey, the number of users who is using Dubbo in Guangzhou
> ranks 5th in China, only secondary to Beijing, Shanghai, Shenzhen,
> Hangzhou.
> So I am going to vote +1 for Guangzhou. :)
>
> [1] http://sc-meetup.mikecrm.com/7hZFeTl
>
> On Tue, Dec 4, 2018 at 4:08 PM 王蓉(涂南)  wrote:
>
> > Hi guys,
> >
> > I'm Amber, organizer of Dubbo meetup.
> >
> > Since 2018, Dubbo community has been touring around China!
> > We have been to Beijing, Chengdu, Shenzhen, Shanghai, and Hangzhou.
> > More than 30K developers have either come to the meetup or watched our
> > live streaming videos.
> > What a wonderful journey!
> >
> > Now you got to choose where our 2019 first meetup is going to be held!
> > We're planning to hold another meetup on Jan 19th.
> > Let us know your thoughts!
> >
> > Ballot here ‍http://sc-meetup.mikecrm.com/7hZFeTl
> > Deadline for this ballot is Dec.14.
> >
> > --
> > Best Regards！
> > Huxing
> >
>
> --
> Best Regards！
> Huxing
>

Re: [DISCUSS] Next Dubbo meetup

I noticed the vote url has been changed to
http://alibabadeveloper.mikecrm.com/7hZFeTl, is this expected?

On Wed, Dec 5, 2018 at 1:48 PM 王蓉(涂南)  wrote:

> guys, do remember to vote via this link
>
>  ‍http://sc-meetup.mikecrm.com/7hZFeTl
>
> Deadline for this ballot is Dec.14.
>
>
> --
> 发件人：Huxing Zhang 
> 发送时间：2018年12月4日(星期二) 22:07
> 收件人：dev 
> 主 题：Re: [DISCUSS] Next Dubbo meetup
>
> In the link[1] provided, there are 3 options:
>
> * Nanjing
> * Guangzhou
> * Other
>
> I prefer to a new city where we haven't been there before.
> According to a survey, the number of users who is using Dubbo in Guangzhou
> ranks 5th in China, only secondary to Beijing, Shanghai, Shenzhen,
> Hangzhou.
> So I am going to vote +1 for Guangzhou. :)
>
> [1] http://sc-meetup.mikecrm.com/7hZFeTl
>
> On Tue, Dec 4, 2018 at 4:08 PM 王蓉(涂南)  wrote:
>
> > Hi guys,
> >
> > I'm Amber, organizer of Dubbo meetup.
> >
> > Since 2018, Dubbo community has been touring around China!
> > We have been to Beijing, Chengdu, Shenzhen, Shanghai, and Hangzhou.
> > More than 30K developers have either come to the meetup or watched our
> > live streaming videos.
> > What a wonderful journey!
> >
> > Now you got to choose where our 2019 first meetup is going to be held!
> > We're planning to hold another meetup on Jan 19th.
> > Let us know your thoughts!
> >
> > Ballot here ‍http://sc-meetup.mikecrm.com/7hZFeTl
> > Deadline for this ballot is Dec.14.
> >
> > --
> > Best Regards！
> > Huxing
> >
>
> --
> Best Regards！
> Huxing
>

Re: Wanted to learn from you starting with issue #2884

This looks like a duplicate thread. Let's focus on the other thread.
On Wed, Dec 5, 2018 at 8:35 PM Imteyaz Khan  wrote:
>
> Hi All,
>Trust you all are doing well. I am new to this community or even new to
> any open source development community. Had a chance to go through one of
> the dubbo github issue #2884('We need more code comments'), which was
> marked as 'good first issue'. So thought it could be a good start for me to
> start from here, but being new to open source and also new to dubbo, I am
> bit nervous also excited to know from where and how to start. It will be
> great if team can help me and guide me too to assist you in any way I can.
>
> Regards
> Imteyaz



-- 
Best Regards！
Huxing

Re: About the comments coverage of the code

On Wed, Dec 5, 2018 at 8:57 PM 田 小波  wrote:
>
> Hi community,
>
> I noticed that people in the WeChat group said that Dubbo's comments are too 
> few and unfriendly to beginners. I just wrote some source analysis articles 
> about Dubbo in the past. I have a lot of comments and analysis on the Dubbo 
> source in the article. I think these articles can help beginners learn Dubbo. 
> The list of articles is as follows:

Would you please add your comments into Dubbo's source code by sending
pull request?
This can help more people to understand.

>
> 时间  文章
> 2018-10-01  Dubbo 源码分析 - SPI 
> 机制
> 2018-10-13  Dubbo 源码分析 - 
> 自适应拓展原理
> 2018-10-31  Dubbo 源码分析 - 
> 服务导出
> 2018-11-12  Dubbo 源码分析 - 
> 服务引用
> 2018-11-17  Dubbo 源码分析 - 集群容错之 
> Directory
> 2018-11-20  Dubbo 源码分析 - 集群容错之 
> Router
> 2018-11-24  Dubbo 源码分析 - 集群容错之 
> Cluster
> 2018-11-29  Dubbo 源码分析 - 集群容错之 
> LoadBalance
> 未完成 Dubbo 源码分析 - 并发模型
> 未完成 Dubbo 源码分析 - 编解码
>
> If you are interested, you can review it. If you feel good, I can submit 
> these articles to dubbo-website. If you feel that writing is not good, you 
> are welcome to give some advice.

Any contribution is welcome, if you could put your articles to Dubbo
website as serial of blog posts, that would be really nice. Or you can
enhance the current documentation with your article.


>
> 我注意到有人在微信群里说 Dubbo 的注释太少，对初学者不友好。我正好在过去一段时间内写了一些关于 Dubbo 的源码分析文章，我在文章中对 Dubbo 
> 源码进行了大量的注释和分析，我觉得这些文章可以帮助初学者学习 Dubbo。大家如果有兴趣，可以进行 review。如果觉得还不错，我可以将这些文章提交给 
> dubbo-website。如果觉得写的不好，也欢迎多多指教。
>
> Regards
> Xiaobo
>
> 在 2018年12月5日，下午1:56，Ian Luo  写道：
>
> What I suggest is to revisit and enhance the existing javadoc/comments
> before consider to add more:
> 1. Enhance JavaDoc for all API. For this part, we may need some helps from
> native speakers
> 2. Revisit the current existing comments, and make it easier to understand
>
> Just my two cents,
> -Ian.
>
> On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu  wrote:
>
> Recently dubbo held an offline meetup. When discussing with many
> participants, many people have suggested that dubbo has very few comments.
>
> Comments are very important for us to understand the code. If our comments
> are few, it is very unfriendly for new developers.
>
> I created a new issue[1] to track this. We need more developers to
> contribute notes. I will continue to follow up on this matter.
>
> [1] https://github.com/apache/incubator-dubbo/issues/2884
>
>


-- 
Best Regards！
Huxing

Re: Wanted to assist dubbo community on issue #2884

Hi,

I think you can start submitting pr.
Some formats in the mail are not displayed neatly. A better way is to look
at the specific effects in the code after submitting the PR.

Great start. :)

Huxing Zhang  于2018年12月6日周四 上午10:07写道：

> Hi,
>
> On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan 
> wrote:
> >
> > I have just started documenting module 'dubbo-filter',  below are example
> > of mine, this is just to make sure I am in align with the documentation
> > style
>
> Looks good! Please go head and send the pull request!
>
> >
> > /**
> >  * CacheFilter is a core component of dubbo.Enabling cache key
> > of service,method,consumer or provider dubbo will cache method return
> > value.
> >  * Along with cache key we need to configure cache type. Dubbo default
> > implemented cache types are
> >  * lur
> >  * threadlocal
> >  * jcache
> >  * expiring
> >  *
> >  * 
> >  *   e.g. 1)dubbo:service cache="lru" /
> >  *2)dubbo:service / dubbo:method name="method2"
> > cache="threadlocal" / dubbo:service/
> >  *3)dubbo:provider cache="expiring" /
> >  *4)dubbo:consumer cache="jcache" /
> >  *
> >  *If cache type is defined in method level then method level type will
> > get precedence. According to above provided
> >  *example, if service has two method, method1 and method2, method2
> > will have cache type as threadlocal where others will
> >  *be backed by lru
> >  *
> >  *
> >  * @see org.apache.dubbo.rpc.Filter
> >  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
> >  * @see org.apache.dubbo.cache.support.lru.LruCache
> >  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
> >  * @see org.apache.dubbo.cache.support.jcache.JCache
> >  * @see
> org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
> >  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
> >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
> >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
> >  *
> >  */
> > @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> > Constants.CACHE_KEY)
> > public class CacheFilter implements Filter {
> >
> > 
> >
> > .
> >
> > }
> >
> >
> > On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan 
> wrote:
> >
> > > Just to make sure I have not misunderstood what mentioned earlier by
> > > 'Filter' is 'dubbo-filter' correct?
> > >
> > > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > > wrote:
> > >
> > >> Thanks a lot for the start, much appreciated.
> > >>
> > >>
> > >>
> > >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> > >>
> > >>> In addition, we strongly encourage open discussion.
> > >>> You can post your comments on a Filter directly here. There will be
> some
> > >>> people who know more about dubbo to review and discuss.
> > >>>
> > >>> Of course, any problem can be raised here. We will answer as soon as
> > >>> possible.
> > >>>
> > >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> > >>>
> > >>> > very sorry. I have some work now, so I didn't respond to your
> email in
> > >>> > time.
> > >>> > I am very willing to help you with the completion of the comments.
> If
> > >>> you
> > >>> > are a newbie, I suggest you start with a simple logic.
> > >>> > Which parts of the logic are relatively simple? At present, I think
> > >>> that
> > >>> > our filter-related implementation is relatively simple (such as
> > >>> > ActiveLimitFilter). You don't know the principle of dubbo at all,
> and
> > >>> you
> > >>> > can understand the code and complete the comments more easily. You
> can
> > >>> > start with the Filter related class and complete some of the
> comments.
> > >>> >
> > >>> > When you think that you know enough about dubbo, you can do some
> core
> > >>> > module comments, such as protocol-related comments.
> > >>> >
> > >>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> > >>> >
> > >>> >> Hi All,
> > >>> >>Trust you all are doing well. I am new to this community or
> even
> > >>> new to
> > >>> >> any open source development community. Had a chance to go through
> one
> > >>> of
> > >>> >> the dubbo github issue #2884('We need more code comments'), which
> was
> > >>> >> marked as 'good first issue'. So thought it could be a good start
> for
> > >>> me
> > >>> >> to
> > >>> >> start from here, but being new to open source and also to dubbo I
> am
> > >>> very
> > >>> >> nervous from where and how to start. I will be great if team can
> help
> > >>> me
> > >>> >> and guide me too to assist you in any way I can.
> > >>> >>
> > >>> >> Regards
> > >>> >> Imteyaz
> > >>> >>
> > >>> >
> > >>>
> > >>
>
>
>
> --
> Best Regards！
> Huxing
>

Re: Wanted to assist dubbo community on issue #2884

Hi,

On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan  wrote:
>
> I have just started documenting module 'dubbo-filter',  below are example
> of mine, this is just to make sure I am in align with the documentation
> style

Looks good! Please go head and send the pull request!

>
> /**
>  * CacheFilter is a core component of dubbo.Enabling cache key
> of service,method,consumer or provider dubbo will cache method return
> value.
>  * Along with cache key we need to configure cache type. Dubbo default
> implemented cache types are
>  * lur
>  * threadlocal
>  * jcache
>  * expiring
>  *
>  * 
>  *   e.g. 1)dubbo:service cache="lru" /
>  *2)dubbo:service / dubbo:method name="method2"
> cache="threadlocal" / dubbo:service/
>  *3)dubbo:provider cache="expiring" /
>  *4)dubbo:consumer cache="jcache" /
>  *
>  *If cache type is defined in method level then method level type will
> get precedence. According to above provided
>  *example, if service has two method, method1 and method2, method2
> will have cache type as threadlocal where others will
>  *be backed by lru
>  *
>  *
>  * @see org.apache.dubbo.rpc.Filter
>  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
>  * @see org.apache.dubbo.cache.support.lru.LruCache
>  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
>  * @see org.apache.dubbo.cache.support.jcache.JCache
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
>  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
>  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
>  *
>  */
> @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> Constants.CACHE_KEY)
> public class CacheFilter implements Filter {
>
> 
>
> .
>
> }
>
>
> On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan  wrote:
>
> > Just to make sure I have not misunderstood what mentioned earlier by
> > 'Filter' is 'dubbo-filter' correct?
> >
> > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > wrote:
> >
> >> Thanks a lot for the start, much appreciated.
> >>
> >>
> >>
> >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> >>
> >>> In addition, we strongly encourage open discussion.
> >>> You can post your comments on a Filter directly here. There will be some
> >>> people who know more about dubbo to review and discuss.
> >>>
> >>> Of course, any problem can be raised here. We will answer as soon as
> >>> possible.
> >>>
> >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> >>>
> >>> > very sorry. I have some work now, so I didn't respond to your email in
> >>> > time.
> >>> > I am very willing to help you with the completion of the comments. If
> >>> you
> >>> > are a newbie, I suggest you start with a simple logic.
> >>> > Which parts of the logic are relatively simple? At present, I think
> >>> that
> >>> > our filter-related implementation is relatively simple (such as
> >>> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
> >>> you
> >>> > can understand the code and complete the comments more easily. You can
> >>> > start with the Filter related class and complete some of the comments.
> >>> >
> >>> > When you think that you know enough about dubbo, you can do some core
> >>> > module comments, such as protocol-related comments.
> >>> >
> >>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >>> >
> >>> >> Hi All,
> >>> >>Trust you all are doing well. I am new to this community or even
> >>> new to
> >>> >> any open source development community. Had a chance to go through one
> >>> of
> >>> >> the dubbo github issue #2884('We need more code comments'), which was
> >>> >> marked as 'good first issue'. So thought it could be a good start for
> >>> me
> >>> >> to
> >>> >> start from here, but being new to open source and also to dubbo I am
> >>> very
> >>> >> nervous from where and how to start. I will be great if team can help
> >>> me
> >>> >> and guide me too to assist you in any way I can.
> >>> >>
> >>> >> Regards
> >>> >> Imteyaz
> >>> >>
> >>> >
> >>>
> >>



-- 
Best Regards！
Huxing

Re: Wanted to assist dubbo community on issue #2884

I mean all of the impl of Filter.
Some of are not in dubbo-filter module.
U can directly find all of the Filter impl

Imteyaz Khan  于2018年12月5日周三 下午10:51写道：

> Just to make sure I have not misunderstood what mentioned earlier by
> 'Filter' is 'dubbo-filter' correct?
>
> On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> wrote:
>
> > Thanks a lot for the start, much appreciated.
> >
> >
> >
> > On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> >
> >> In addition, we strongly encourage open discussion.
> >> You can post your comments on a Filter directly here. There will be some
> >> people who know more about dubbo to review and discuss.
> >>
> >> Of course, any problem can be raised here. We will answer as soon as
> >> possible.
> >>
> >> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> >>
> >> > very sorry. I have some work now, so I didn't respond to your email in
> >> > time.
> >> > I am very willing to help you with the completion of the comments. If
> >> you
> >> > are a newbie, I suggest you start with a simple logic.
> >> > Which parts of the logic are relatively simple? At present, I think
> that
> >> > our filter-related implementation is relatively simple (such as
> >> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
> >> you
> >> > can understand the code and complete the comments more easily. You can
> >> > start with the Filter related class and complete some of the comments.
> >> >
> >> > When you think that you know enough about dubbo, you can do some core
> >> > module comments, such as protocol-related comments.
> >> >
> >> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >> >
> >> >> Hi All,
> >> >>Trust you all are doing well. I am new to this community or even
> >> new to
> >> >> any open source development community. Had a chance to go through one
> >> of
> >> >> the dubbo github issue #2884('We need more code comments'), which was
> >> >> marked as 'good first issue'. So thought it could be a good start for
> >> me
> >> >> to
> >> >> start from here, but being new to open source and also to dubbo I am
> >> very
> >> >> nervous from where and how to start. I will be great if team can help
> >> me
> >> >> and guide me too to assist you in any way I can.
> >> >>
> >> >> Regards
> >> >> Imteyaz
> >> >>
> >> >
> >>
> >
>

Re: Wanted to assist dubbo community on issue #2884

I have just started documenting module 'dubbo-filter',  below are example
of mine, this is just to make sure I am in align with the documentation
style

/**
 * CacheFilter is a core component of dubbo.Enabling cache key
of service,method,consumer or provider dubbo will cache method return
value.
 * Along with cache key we need to configure cache type. Dubbo default
implemented cache types are
 * lur
 * threadlocal
 * jcache
 * expiring
 *
 * 
 *   e.g. 1)dubbo:service cache="lru" /
 *2)dubbo:service / dubbo:method name="method2"
cache="threadlocal" / dubbo:service/
 *3)dubbo:provider cache="expiring" /
 *4)dubbo:consumer cache="jcache" /
 *
 *If cache type is defined in method level then method level type will
get precedence. According to above provided
 *example, if service has two method, method1 and method2, method2
will have cache type as threadlocal where others will
 *be backed by lru
 *
 *
 * @see org.apache.dubbo.rpc.Filter
 * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
 * @see org.apache.dubbo.cache.support.lru.LruCache
 * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
 * @see org.apache.dubbo.cache.support.jcache.JCache
 * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
 * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
 * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
 * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
 *
 */
@Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
Constants.CACHE_KEY)
public class CacheFilter implements Filter {

.

}

On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan  wrote:

> Just to make sure I have not misunderstood what mentioned earlier by
> 'Filter' is 'dubbo-filter' correct?
>
> On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> wrote:
>
>> Thanks a lot for the start, much appreciated.
>>
>>
>>
>> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
>>
>>> In addition, we strongly encourage open discussion.
>>> You can post your comments on a Filter directly here. There will be some
>>> people who know more about dubbo to review and discuss.
>>>
>>> Of course, any problem can be raised here. We will answer as soon as
>>> possible.
>>>
>>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
>>>
>>> > very sorry. I have some work now, so I didn't respond to your email in
>>> > time.
>>> > I am very willing to help you with the completion of the comments. If
>>> you
>>> > are a newbie, I suggest you start with a simple logic.
>>> > Which parts of the logic are relatively simple? At present, I think
>>> that
>>> > our filter-related implementation is relatively simple (such as
>>> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
>>> you
>>> > can understand the code and complete the comments more easily. You can
>>> > start with the Filter related class and complete some of the comments.
>>> >
>>> > When you think that you know enough about dubbo, you can do some core
>>> > module comments, such as protocol-related comments.
>>> >
>>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
>>> >
>>> >> Hi All,
>>> >>Trust you all are doing well. I am new to this community or even
>>> new to
>>> >> any open source development community. Had a chance to go through one
>>> of
>>> >> the dubbo github issue #2884('We need more code comments'), which was
>>> >> marked as 'good first issue'. So thought it could be a good start for
>>> me
>>> >> to
>>> >> start from here, but being new to open source and also to dubbo I am
>>> very
>>> >> nervous from where and how to start. I will be great if team can help
>>> me
>>> >> and guide me too to assist you in any way I can.
>>> >>
>>> >> Regards
>>> >> Imteyaz
>>> >>
>>> >
>>>
>>

Re: Wanted to assist dubbo community on issue #2884

Just to make sure I have not misunderstood what mentioned earlier by
'Filter' is 'dubbo-filter' correct?

On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan  wrote:

> Thanks a lot for the start, much appreciated.
>
>
>
> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
>
>> In addition, we strongly encourage open discussion.
>> You can post your comments on a Filter directly here. There will be some
>> people who know more about dubbo to review and discuss.
>>
>> Of course, any problem can be raised here. We will answer as soon as
>> possible.
>>
>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
>>
>> > very sorry. I have some work now, so I didn't respond to your email in
>> > time.
>> > I am very willing to help you with the completion of the comments. If
>> you
>> > are a newbie, I suggest you start with a simple logic.
>> > Which parts of the logic are relatively simple? At present, I think that
>> > our filter-related implementation is relatively simple (such as
>> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
>> you
>> > can understand the code and complete the comments more easily. You can
>> > start with the Filter related class and complete some of the comments.
>> >
>> > When you think that you know enough about dubbo, you can do some core
>> > module comments, such as protocol-related comments.
>> >
>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
>> >
>> >> Hi All,
>> >>Trust you all are doing well. I am new to this community or even
>> new to
>> >> any open source development community. Had a chance to go through one
>> of
>> >> the dubbo github issue #2884('We need more code comments'), which was
>> >> marked as 'good first issue'. So thought it could be a good start for
>> me
>> >> to
>> >> start from here, but being new to open source and also to dubbo I am
>> very
>> >> nervous from where and how to start. I will be great if team can help
>> me
>> >> and guide me too to assist you in any way I can.
>> >>
>> >> Regards
>> >> Imteyaz
>> >>
>> >
>>
>

Re: Wanted to assist dubbo community on issue #2884

Thanks a lot for the start, much appreciated.



On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:

> In addition, we strongly encourage open discussion.
> You can post your comments on a Filter directly here. There will be some
> people who know more about dubbo to review and discuss.
>
> Of course, any problem can be raised here. We will answer as soon as
> possible.
>
> yuhang xiu  于2018年12月5日周三 下午8:58写道：
>
> > very sorry. I have some work now, so I didn't respond to your email in
> > time.
> > I am very willing to help you with the completion of the comments. If you
> > are a newbie, I suggest you start with a simple logic.
> > Which parts of the logic are relatively simple? At present, I think that
> > our filter-related implementation is relatively simple (such as
> > ActiveLimitFilter). You don't know the principle of dubbo at all, and you
> > can understand the code and complete the comments more easily. You can
> > start with the Filter related class and complete some of the comments.
> >
> > When you think that you know enough about dubbo, you can do some core
> > module comments, such as protocol-related comments.
> >
> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >
> >> Hi All,
> >>Trust you all are doing well. I am new to this community or even new
> to
> >> any open source development community. Had a chance to go through one of
> >> the dubbo github issue #2884('We need more code comments'), which was
> >> marked as 'good first issue'. So thought it could be a good start for me
> >> to
> >> start from here, but being new to open source and also to dubbo I am
> very
> >> nervous from where and how to start. I will be great if team can help me
> >> and guide me too to assist you in any way I can.
> >>
> >> Regards
> >> Imteyaz
> >>
> >
>

Re: Wanted to assist dubbo community on issue #2884

In addition, we strongly encourage open discussion.
You can post your comments on a Filter directly here. There will be some
people who know more about dubbo to review and discuss.

Of course, any problem can be raised here. We will answer as soon as
possible.

yuhang xiu  于2018年12月5日周三 下午8:58写道：

> very sorry. I have some work now, so I didn't respond to your email in
> time.
> I am very willing to help you with the completion of the comments. If you
> are a newbie, I suggest you start with a simple logic.
> Which parts of the logic are relatively simple? At present, I think that
> our filter-related implementation is relatively simple (such as
> ActiveLimitFilter). You don't know the principle of dubbo at all, and you
> can understand the code and complete the comments more easily. You can
> start with the Filter related class and complete some of the comments.
>
> When you think that you know enough about dubbo, you can do some core
> module comments, such as protocol-related comments.
>
> Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
>
>> Hi All,
>>Trust you all are doing well. I am new to this community or even new to
>> any open source development community. Had a chance to go through one of
>> the dubbo github issue #2884('We need more code comments'), which was
>> marked as 'good first issue'. So thought it could be a good start for me
>> to
>> start from here, but being new to open source and also to dubbo I am very
>> nervous from where and how to start. I will be great if team can help me
>> and guide me too to assist you in any way I can.
>>
>> Regards
>> Imteyaz
>>
>

Re: Wanted to assist dubbo community on issue #2884

very sorry. I have some work now, so I didn't respond to your email in time.
I am very willing to help you with the completion of the comments. If you
are a newbie, I suggest you start with a simple logic.
Which parts of the logic are relatively simple? At present, I think that
our filter-related implementation is relatively simple (such as
ActiveLimitFilter). You don't know the principle of dubbo at all, and you
can understand the code and complete the comments more easily. You can
start with the Filter related class and complete some of the comments.

When you think that you know enough about dubbo, you can do some core
module comments, such as protocol-related comments.

Imteyaz Khan  于2018年12月5日周三 下午3:05写道：

> Hi All,
>Trust you all are doing well. I am new to this community or even new to
> any open source development community. Had a chance to go through one of
> the dubbo github issue #2884('We need more code comments'), which was
> marked as 'good first issue'. So thought it could be a good start for me to
> start from here, but being new to open source and also to dubbo I am very
> nervous from where and how to start. I will be great if team can help me
> and guide me too to assist you in any way I can.
>
> Regards
> Imteyaz
>

Re: About the comments coverage of the code

2018-12-05 Thread 田小波

Hi community,

I noticed that people in the WeChat group said that Dubbo's comments are too
few and unfriendly to beginners. I just wrote some source analysis articles
about Dubbo in the past. I have a lot of comments and analysis on the Dubbo
source in the article. I think these articles can help beginners learn Dubbo.
The list of articles is as follows:

时间 文章
2018-10-01 Dubbo 源码分析 - SPI
机制
2018-10-13 Dubbo 源码分析 -
自适应拓展原理
2018-10-31 Dubbo 源码分析 -
服务导出
2018-11-12 Dubbo 源码分析 -
服务引用
2018-11-17 Dubbo 源码分析 - 集群容错之
Directory
2018-11-20 Dubbo 源码分析 - 集群容错之
Router
2018-11-24 Dubbo 源码分析 - 集群容错之
Cluster
2018-11-29 Dubbo 源码分析 - 集群容错之
LoadBalance
未完成 Dubbo 源码分析 - 并发模型
未完成 Dubbo 源码分析 - 编解码

If you are interested, you can review it. If you feel good, I can submit these
articles to dubbo-website. If you feel that writing is not good, you are
welcome to give some advice.

我注意到有人在微信群里说 Dubbo 的注释太少，对初学者不友好。我正好在过去一段时间内写了一些关于 Dubbo 的源码分析文章，我在文章中对 Dubbo
源码进行了大量的注释和分析，我觉得这些文章可以帮助初学者学习 Dubbo。大家如果有兴趣，可以进行 review。如果觉得还不错，我可以将这些文章提交给
dubbo-website。如果觉得写的不好，也欢迎多多指教。

Regards
Xiaobo

在 2018年12月5日，下午1:56，Ian Luo 写道：

What I suggest is to revisit and enhance the existing javadoc/comments
before consider to add more:
1. Enhance JavaDoc for all API. For this part, we may need some helps from
native speakers
2. Revisit the current existing comments, and make it easier to understand

Just my two cents,
-Ian.

On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu wrote:

Recently dubbo held an offline meetup. When discussing with many
participants, many people have suggested that dubbo has very few comments.

Comments are very important for us to understand the code. If our comments
are few, it is very unfriendly for new developers.

I created a new issue[1] to track this. We need more developers to
contribute notes. I will continue to follow up on this matter.

[1] https://github.com/apache/incubator-dubbo/issues/2884

Wanted to learn from you starting with issue #2884