Re: Define the next generation Dubbo - Dubbo 3.0

[yuhang xiu]

hi, jun

That sounds good. Looking forward to more information and details in the
future. :)


Jun Liu  于2020年10月23日周五 下午10:10写道：

> Hi, Community
>
> We have discussed Dubbo 3.0 several times in the community, but at this
> moment we still haven't formed a very clear plan and goal, not to mention a
> clear Roadmap. Even though I noticed that the community's attention to
> Dubbo3 is still rising, and community developers have been developing some
> of the Dubbo new features in various forms, and these should be part of the
> upcoming Dubbo 3.0.
> Based on my understanding of the community discussions, I have concluded
> the following points. I hope that this time everyone interested can share
> ideas on the following topics. I will make a summary at the end of this
> thread on behalf of the community. Hopefully we can finally create a Dubbo
> 3.0 Roadmap.
> • Cloud Native. These includes:
> • RPC protocol over HTTP/2, which is much more friendly to
> mesh, proxy, and mobile devices.
> • Supporting Kubernetes native service discovery.
> • Proxyless Mesh as an altervative to Sidecar based mesh.
> • Adapting to all kinds of Cloud Native concepts and projects.
> • Support large scale clusters with millions of instances
>  • New Service Discovery model with less push and storage
> costs.
>  • Enriched Traffic Management rules.
>  • Intelligent Load Balance strategies that can automatically
> distribute traffics among instances based on load.
> • Easy to use
>  • Interface based programming and governance.
>  • Integration with famous RPC frameworks like gRPC to provide
> out of box usage.
>
> Jun
>
>

Re: [VOTE]: Release Apache Dubbo 2.7.4.1 [RC1]

[yuhang xiu]

+1

I checked:
- can compile from source
- unit test success


victory  于2019年10月25日周五 下午3:01写道：

> Hi,
>
> +1 binding
>
> I checked:
> - signatures and hashes fine
> - no unexpected binary files
> - can compile from source
> - unit test success
>
>
> From: victory
> Official Account: GeekVictory
>
> Ian Luo  于2019年10月25日周五 上午11:31写道：
>
> > I checked the following items. I vote +1 to this release.
> >
> > [v]  Are release files in correct location?
> > [v] Are the digital signature and hashes correct?
> > [v] Do LICENSE and NOTICE files exists?
> > [v] Is the LICENSE and NOTICE text correct?
> > [v] Is the NOTICE year correct?
> > [x] Un-included software dependencies are not mentioned in LICENSE or
> > NOTICE?
> > [x] License information is not mentioned in NOTICE?
> > [v] Is there any 3rd party code contained inside the release? If so:
> >   [v] Does the software have a compatible license?
> >   [v] Are all software licenses mentioned in LICENSE?
> >   [v] Is the full text of the licenses (or pointers to it) in LICENSE?
> >   Is any of this code Apache licensed? Do they have NOTICE files? If so:
> > [v] Have relevant parts of those NOTICE files been added to this
> NOTICE
> > file?
> > [v] Do all source files have ASF headers?
> > [v] Do the contents of the release match with what's tagged in version
> > control?
> > [x] Are there any unexpected binary files in the release?
> > [v] Can you compile from source? Are the instruction clear?
> >
> > Is the issue minor?
> > [ ] Yes [ ] No [ ] Unsure
> >
> > Could it possibly be fixed in the next release?
> > [ ] Yes [ ] No [ ] Unsure
> >
> > I vote with:
> > [v] +1 release the software
> > [ ] +0 not sure if it should be released
> > [ ] -1 don’t release the software because...
> >
> > Thanks,
> > -Ian.
> >
> > On Tue, Oct 22, 2019 at 8:54 PM Jun Liu  wrote:
> >
> > > Hello Dubbo Community,
> > >
> > > This is a call for vote to release Apache Dubbo version 2.7.4.1.
> > >
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/2.7.4.1/
> > >
> > > The staging repo:
> > > https://repository.apache.org/content/repositories/orgapachedubbo-1046
> > >
> > > Git tag for the release:
> > > https://github.com/apache/dubbo/tree/dubbo-2.7.4.1
> > >
> > > Hash for the release tag:
> > > 7957e268fbdf8cb214c8205f57f778e388366f48
> > >
> > > Release Notes:
> > > https://github.com/apache/dubbo/blob/dubbo-2.7.4.1/CHANGES.md#2741
> > >
> > > The artifacts have been signed with Key: 28681CB1, which can be
> > > found in the keys file:
> > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > > The vote will be open for at least 72 hours or until necessary number
> of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Dubbo Team
> > >
> >
>
>
> --
>
> Best Regard!
> cvitory
>

Re: [VOTE]: Release Apache dubbo-go-hessian2 v1.3.0 RC1

[yuhang xiu]

+1

[ ]  Are release files in correct location?
[ ] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[ ] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[ ] License information is not mentioned in NOTICE?
[ ] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[ ] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

Is the issue minor?
[ ] Yes [ ] No [ ] Unsure

Could it possibly be fixed in the next release?
[ ] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because...

Xinge Gao  于2019年10月25日周五 下午3:30写道：

> +1 (non-binding)
>
> Chih Hsing  于2019年10月25日周五 下午3:16写道：
>
> > +1 (non-binding)
> >
> > Ian Luo  于2019年10月25日周五 上午10:48写道：
> >
> > > I checked the following items. I vote +1 to this release.
> > >
> > > [v]  Are release files in correct location?
> > > [v] Are the digital signature and hashes correct?
> > > [v] Do LICENSE and NOTICE files exists?
> > > [v] Is the LICENSE and NOTICE text correct?
> > > [v] Is the NOTICE year correct?
> > > [x] Un-included software dependencies are not mentioned in LICENSE or
> > > NOTICE?
> > > [x] License information is not mentioned in NOTICE?
> > > [x] Is there any 3rd party code contained inside the release? If so:
> > >   [ ] Does the software have a compatible license?
> > >   [ ] Are all software licenses mentioned in LICENSE?
> > >   [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
> > >   Is any of this code Apache licensed? Do they have NOTICE files? If
> so:
> > > [ ] Have relevant parts of those NOTICE files been added to this
> > NOTICE
> > > file?
> > > [ ] Do all source files have ASF headers?
> > > [v] Do the contents of the release match with what's tagged in version
> > > control?
> > > [x] Are there any unexpected binary files in the release?
> > > [v] Can you compile from source? Are the instruction clear?
> > >
> > > Is the issue minor?
> > > [ ] Yes [ ] No [ ] Unsure
> > >
> > > Could it possibly be fixed in the next release?
> > > [ ] Yes [ ] No [ ] Unsure
> > >
> > > I vote with:
> > > [v] +1 release the software
> > > [ ] +0 not sure if it should be released
> > > [ ] -1 don’t release the software because...
> > >
> > > Thanks,
> > > -Ian.
> > >
> > >
> > > On Tue, Oct 22, 2019 at 10:40 AM 望哥  wrote:
> > >
> > > > Hello Dubbo/Dubbogo Community,
> > > >
> > > >  This is a call for vote to release Apache dubbo-go-hessian2 version
> > > v1.3.0
> > > > RC1.
> > > >
> > > >  The release candidates:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.3.0-rc1/
> > > >  Git tag for the release:
> > > > https://github.com/apache/dubbo-go-hessian2/tree/v1.3.0
> > > >  Hash for the release tag: 0ef010e9ccf4fea50b122e43ba2c0ba62a260fcb
> > > >  Release Notes:
> > > > https://github.com/apache/dubbo-go-hessian2/blob/v1.3.0/CHANGE.md
> > > >  The artifacts have been signed with Key :7DB68550D366E4C0, which can
> > be
> > > > found in the keys file:
> > > >  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > > >
> > > >  The vote will be open for at least 72 hours or until necessary
> number
> > of
> > > > votes are reached.
> > > >
> > > >  Please vote accordingly:
> > > >  [ ] +1 approve
> > > >  [ ] +0 no opinion
> > > >  [ ] -1 disapprove with the reason
> > > >
> > > >  Thanks,
> > > >  The Apache Dubbo-go Team
> > > >
> > >
> >
>

Re: [VOTE] Accept RitterHou/python-dubbo donation

[yuhang xiu]

+1 accept
Dubbo's ecology continues to expand. :)

Ian Luo  于2019年9月24日周二 上午10:53写道：

> Hi All,
>
> This is a formal vote to bring RitterHou/python-dubbo[1], which is donated
> by Qianmi, to Apache Dubbo project.
>
> Please vote:
>
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
>
> [1] https://github.com/RitterHou/python-dubbo
>

Re: [VOTE] Accept dubbogo/hessian2 donation

[yuhang xiu]

+1 accept

Ian Luo  于2019年7月8日周一 上午10:26写道：

> +1 Accept
>
> On Thu, Jul 4, 2019 at 11:20 AM Stocks Alex 
> wrote:
>
> > 1
> >
> >  原始邮件
> > 发件人: Huxing Zhang
> > 收件人: dev
> > 发送时间: 2019年7月4日(周四) 10:00
> > 主题: [VOTE] Accept dubbogo/hessian2 donation
> >
> >
> > Hi All,
> >
> > This is a formal vote to bring dubbogo/hessian2[1], which is depended
> > by dubbo-go, to Apache Dubbo project.
> >
> > Please vote:
> >
> > [ ] +1 Accept
> > [ ] +0 No Opinion
> > [ ] -1 Reject because...
> >
> > [1] https://github.com/dubbogo/hessian2
> >
> > --
> > Best Regards！
> > Huxing
> >
> >
>

Re: [VOTE] Accept dubbogo/hessian2 donation

[yuhang xiu]

+1 accept

Ian Luo  于2019年7月8日周一 上午10:23写道：

> +1
>
> On Thu, Jul 4, 2019 at 7:22 PM Zonghai Shang  wrote:
>
> > +1 Accept
> >
> >
> > -yiji
> >
> > 华 钟明  于2019年7月4日周四 上午11:54写道：
> >
> > > +1 Accept
> > >
> > > Best Regards！
> > > Zhongming Hua
> > >
> > >
> > > 在 2019/7/4 上午11:23，“Xin Wang” 写入:
> > >
> > > +1 Accept
> > >
> > > Huxing Zhang  于2019年7月4日周四 上午10:00写道：
> > >
> > > > Hi All,
> > > >
> > > > This is a formal vote to bring dubbogo/hessian2[1], which is
> > depended
> > > > by dubbo-go, to Apache Dubbo project.
> > > >
> > > > Please vote:
> > > >
> > > > [ ] +1 Accept
> > > > [ ] +0 No Opinion
> > > > [ ] -1 Reject because...
> > > >
> > > > [1] https://github.com/dubbogo/hessian2
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
> > >
> >
>

Re: About jprofile license for opensource project

[yuhang xiu]

Hi, everyone.

It seems that we have no other opinions on the license of Jprofile.

I will start the two things above.

In addition, after communicating with Jprofile, they will provide a license
for all Committer to use.

Regarding the maintenance of this license, I think it should not appear in
any public place, it should be maintained by PMCs, and any Committer that
needs to use it needs to apply on the dev list. This is a security measure
used to ensure that this license is not overused.

What do you think?

yuhang xiu  于2019年7月4日周四 上午10:24写道：

> Hi,
>
> I took a look at this guide. It seems that we need to do a few things:
>
> 1. Agree with the PMCs to confirm that we are using Jprofile and agree to
> add the official link to Jprofile.
> 2. Add a thanks page to the current official website[1]. I personally
> think that we should also thank Intellij Idea for supporting the project.
>
> By the way, after we have done the above, how do we go through the last
> step mentioned in the guide?
>
> > Project Thanks Pages should include a closing overview paragraph that
> links to the formal Sponsorship and Donations/Contributing web pages at the
> ASF level.
>
> [1] http://dubbo.apache.org/en-us/
>
> Shane Curcuru  于2019年7月3日周三 下午10:05写道：
>
>> Justin Mclean wrote on 2019-7-3 4:47AM EDT:
>> > Hi,
>> >
>> >> I think it will be good to have free jprofile license for open source.
>> >
>> > Looking here [1] they require a link on the web site. That should be OK
>> as long as it not seen as an endorsement and that link goes on a support or
>> thanks page. [2]
>>
>> Apache Brand Management has a specific page for how projects should
>> include these kinds of corporate links, which should be easy to follow:
>>
>>   http://www.apache.org/foundation/marks/linking
>>
>> >> It sounds more like a legal question, are we able to do it?
>> >
>> > IMO Yes.
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1. https://www.ej-technologies.com/buy/jprofiler/openSource/enter
>> > 2. https://www.apache.org/foundation/marks/responsibility#independent
>>
>> --
>>
>> - Shane
>>   Legal Affairs Committee
>>   The Apache Software Foundation
>>
>

Re:

[yuhang xiu]

Hi, Roman

thank you for your reply. If this does not cause legal problems, I intend
to follow the apache process to allow Dubbo to support Jprofile.

After that, I will resend an email to discuss support for Jprofile at the
Apache level.

What do u think?


Roman Shaposhnik  于2019年7月5日周五 上午8:06写道：

> Hi Huxing!
>
> it is ok for you to use it (provided you comply with their terms).
>
> I like your idea of an ASF-wide use, but for that I'd recommend
> reaching out to fundrais...@apache.org since they recently had a very
> similar conversation with JetBrains
>
> Thanks,
> Roman.
>
> On Mon, Jul 1, 2019 at 8:13 PM Huxing Zhang  wrote:
> >
> > + legal-discuss
> >
> > move the discussion to dev@dubbo.apache.org
> >
> > Not sure if ASF already has cooperation with JProfiler or not. If not
> > I suggest to do it in ASF level so that other Apache projects can
> > benefit as well.
> >
> >
> > On Mon, Jul 1, 2019 at 9:22 PM yuhang xiu  wrote:
> > >
> > > Hi, members.
> > >
> > > I recently used jprofile[1] to troubleshoot some performance issues.
> Since jprofile is more expensive, I am still applying for trial eligibility.
> > >
> > > But the good news is that jprofile officially supports open source
> projects. We can use Dubbo to apply for some free licenses. In exchange, we
> need to give jprofile's official website link on Dubbo's official website.
> > >
> > > After I communicated with them, they said that they could give us
> license and distributed according to the current number of contributors
> (207, currently).
> > >
> > > Can we receive these licenses?
> > >
> > > [1] https://www.ej-technologies.com/products/jprofiler/overview.html
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
> > -
> > To unsubscribe, e-mail: legal-discuss-unsubscr...@apache.org
> > For additional commands, e-mail: legal-discuss-h...@apache.org
> >
>

Re: About jprofile license for opensource project

[yuhang xiu]

Hi,

I took a look at this guide. It seems that we need to do a few things:

1. Agree with the PMCs to confirm that we are using Jprofile and agree to
add the official link to Jprofile.
2. Add a thanks page to the current official website[1]. I personally think
that we should also thank Intellij Idea for supporting the project.

By the way, after we have done the above, how do we go through the last
step mentioned in the guide?

> Project Thanks Pages should include a closing overview paragraph that
links to the formal Sponsorship and Donations/Contributing web pages at the
ASF level.

[1] http://dubbo.apache.org/en-us/

Shane Curcuru  于2019年7月3日周三 下午10:05写道：

> Justin Mclean wrote on 2019-7-3 4:47AM EDT:
> > Hi,
> >
> >> I think it will be good to have free jprofile license for open source.
> >
> > Looking here [1] they require a link on the web site. That should be OK
> as long as it not seen as an endorsement and that link goes on a support or
> thanks page. [2]
>
> Apache Brand Management has a specific page for how projects should
> include these kinds of corporate links, which should be easy to follow:
>
>   http://www.apache.org/foundation/marks/linking
>
> >> It sounds more like a legal question, are we able to do it?
> >
> > IMO Yes.
> >
> > Thanks,
> > Justin
> >
> > 1. https://www.ej-technologies.com/buy/jprofiler/openSource/enter
> > 2. https://www.apache.org/foundation/marks/responsibility#independent
>
> --
>
> - Shane
>   Legal Affairs Committee
>   The Apache Software Foundation
>

Re: [ANN] Welcome new committer: Shunyu Lei

[yuhang xiu]

Welcome,

I am very happy that you can be a member of the community and hope that you
can continue to contribute dubbo.
:)

Huxing Zhang  于2019年6月12日周三 下午3:52写道：

> Hi Community,
>
> On behalf of the Dubbo PMC, I am pleased to announce that
> Shunyu Lei[1], a.k.a leishunyu, has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Shunyu, would you please briefly introduce yourself to the community?
>
> [1] https://github.com/leishunyu
>
> --
> Best Regards！
> Huxing
>

Re: [ANN] Welcome new committer: Xiaoxiang Zhai

[yuhang xiu]

Welcome!
Thx for your valuable contribution for dubbo!

Huxing Zhang  于2019年5月29日周三 下午12:40写道：

> Congratulations and welcome!
>
> On Wed, May 29, 2019 at 10:16 AM Minxuan Zhuang 
> wrote:
> >
> > Hi Community,
> >
> > On behalf of the Dubbo PMC, I am pleased to announce that Xiaoxiang
> > Zhai[1], has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Xiaoxiang, would you please briefly introduce yourself to the community?
> >
> > [1] https://github.com/zhaixiaoxiang
>
>
>
> --
> Best Regards！
> Huxing
>

Re: [ANN] Apache Dubbo as a Top-level project

[yuhang xiu]

Congratulations!

A big step forward.

田 小波  于2019年5月21日周二 上午11:18写道：

> Congratulations !
>
>

Re: 200 contributors for Dubbo

[yuhang xiu]

Hi,

Exciting news!

The future will definitely be better. Let us move on together!

Huxing Zhang  于2019年5月17日周五 下午5:37写道：

> Hi All,
>
> It is very glad to see that dubbo[1] project has reached 200 contributors!
> Thanks to all the contributors, and looking forward to more!
>
> [1] https://github.com/apache/incubator-dubbo
> --
> Best Regards！
> Huxing
>

Re: Projects Can Apply Individually for Google Season of Docs

[yuhang xiu]

Hi,huxing

It looks like a good choice.

But from the point of view [1], seems like the technical writer will try to
improve the doc of the entire project?

It seems that we need to make two materials:

   1. A brief introduction to dubbo as u said (tell them what dubbo is)
   2. An official doc template (tell them how to begin writing)



[1] https://cwiki.apache.org/confluence/display/COMDEV/Season+of+Docs+2019

Huxing Zhang  于2019年4月22日周一 下午5:43写道：

> Hi,
>
> I am thinking of the following ideas:
> - Add documentation of how Dubbo work with registry center like etcd,
> consul, following the zookeeper documentation[1]
> - Add documentation of how to use various load balancing strategies,
> like Random, Consistent Hashing, etc. , based on [2]
>
> Not quite sure how the tech writer know about Dubbo, I am thinking of
> writing some introduction to the features that is commonly known.
>
> How do you think?
>
> [1]  http://dubbo.apache.org/en-us/blog/dubbo-zk.html
> [2]  http://dubbo.apache.org/en-us/docs/user/demos/loadbalance.html
>
> On Mon, Apr 22, 2019 at 4:38 PM Huxing Zhang  wrote:
> >
> > Hi,
> >
> > Sorry for catching this late. The deadline is April 23, 2019 at 20:00
> UTC.
> > To participate this event, we need to record some ideas by filling
> > this form[1], and 2 mentors.
> > I am trying to add some ideas.
> > If you have any ideas, please let me know.
> >
> > [1]
> https://cwiki.apache.org/confluence/display/COMDEV/Season+of+Docs+2019
> >
> >
> >
> > On Thu, Apr 4, 2019 at 9:55 AM Huxing Zhang  wrote:
> > >
> > > Hi,
> > >
> > > I looks like we have to apply for GSoD by ourselves. I am planning to
> > > take a look at it next week.
> > >
> > > On Thu, Apr 4, 2019 at 4:55 AM  wrote:
> > > >
> > > > Hi All
> > > >
> > > > Initially the ASF as an organisation was planning to apply as a
> > > > mentoring organisation for Google Season of Docs on behalf of all
> Apache
> > > > projects but if accepted the maximum number of technical writers we
> > > > could allocated is two. Two technical writers would probably not be
> > > > enough to cover the potential demand from all our projects
> interested in
> > > > participating.
> > > >
> > > > We've received feedback from Google that individual projects can
> apply.
> > > > I will withdraw the ASF application so that any Apache project
> > > > interested can apply individually for Season of Docs and so have the
> > > > potential of being allocated a technical writer.
> > > >
> > > > Applications for Season of Docs is open now and closes on 23^rd April
> > > > 2019. If your project would like to apply then please see the
> following
> > > > link:
> > > >
> > > > https://developers.google.com/season-of-docs/docs/get-started/
> > > >
> > > > Good luck everyone!
> > > >
> > > > Thanks
> > > > Sharan
> > > >
> > > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
>
>
>
> --
> Best Regards！
> Huxing
>

Re: [VOTE] Apache Dubbo graduation to Top Level Project

[yuhang xiu]

+1 to graduate as a TLP.

Jerrick Zhu  于2019年4月19日周五 上午9:01写道：

> +1 to graduate as a TLP.
>
> Huxing Zhang  于2019年4月18日周四 下午8:24写道：
>
> > Hi All,
> >
> > After a discussion in the Apache Dubbo community on the dev mailing
> > list[1], choosing PMC chair[2], forming the PMC members[3], completing
> > the maturity model[4], and discussing the resolution proposal[5], I
> > would like to call a vote for Apache Dubbo graduating to a top level
> > project.
> >
> > Please vote on the proposal to graduate Dubbo as TLP to submit to the
> > Incubator PMC.
> >
> > Vote:
> > [ ] +1 - Recommend graduation of Apache Dubbo as a TLP
> > [ ] -1 - Do not recommend graduation of Apache Dubbo because ….
> >
> > The VOTE is open for a minimum of 72 hours.
> >
> > [1]
> >
> https://lists.apache.org/thread.html/767da61f249789f09665a52a241e3b352d168fec051ee7dd1dd7c20b@%3Cdev.dubbo.apache.org%3E
> > [2]
> >
> https://lists.apache.org/thread.html/537a7a88ab19ffee31c0b642ff6239372aa063985846febe2ad11d91@%3Cdev.dubbo.apache.org%3E
> > [3]
> >
> https://lists.apache.org/thread.html/b7218b3b441f7a96e1d339e1eeea60e8bba9b06295e73b56659524c0@%3Cdev.dubbo.apache.org%3E
> > [4]
> >
> https://github.com/apache/incubator-dubbo/wiki/Apache-Maturity-Model-Assessment-for-Dubbo
> > [5]
> >
> https://lists.apache.org/thread.html/2b9fb2c565656308dcce5281c5352da41d5aabc56020af084c6888d3@%3Cdev.dubbo.apache.org%3E
> >
> > -
> > Establish the Apache Dubbo Project
> >
> > WHEREAS, the Board of Directors deems it to be in the best interests of
> > the Foundation and consistent with the Foundation's purpose to establish
> > a Project Management Committee charged with the creation and maintenance
> > of open-source software, for distribution at no charge to the public,
> > related to a high-performance, lightweight, java based RPC framework.
> >
> > NOW, THEREFORE, BE IT RESOLVED, that a Project Management Committee
> > (PMC), to be known as the "Apache Dubbo Project", be and hereby is
> > established pursuant to Bylaws of the Foundation; and be it further
> >
> > RESOLVED, that the Apache Dubbo Project be and hereby is responsible for
> > the creation and maintenance of software related to a high-performance,
> > lightweight, java based RPC framework; and be it further
> >
> > RESOLVED, that the office of "Vice President, Apache Dubbo" be and
> > hereby is created, the person holding such office to serve at the
> > direction of the Board of Directors as the chair of the Apache Dubbo
> > Project, and to have primary responsibility for management of the
> > projects within the scope of responsibility of the Apache Dubbo Project;
> > and be it further
> >
> > RESOLVED, that the persons listed immediately below be and hereby are
> > appointed to serve as the initial members of the Apache Dubbo Project:
> >
> >  * Huxing Zhang   
> >  * Ian Luo
> >  * Jun Liu
> >  * Justin Mclean  
> >  * Kimm King  
> >  * Liang Zhang
> >  * Liujie Qin 
> >  * Mercy Ma   
> >  * Minxuan Zhuang 
> >  * Shang Zonghai  
> >  * Von Gosling
> >  * Xin Wang   
> >  * Yong Zhu   
> >  * Yuhang Xiu 
> >  * YunKun Huang   
> >
> > NOW, THEREFORE, BE IT FURTHER RESOLVED, that Ian Luo be appointed to the
> > office of Vice President, Apache Dubbo, to serve in accordance with and
> > subject to the direction of the Board of Directors and the Bylaws of the
> > Foundation until death, resignation, retirement, removal or
> > disqualification, or until a successor is appointed; and be it further
> >
> > RESOLVED, that the Apache Dubbo Project be and hereby is tasked with the
> > migration and rationalization of the Apache Incubator Dubbo podling; and
> > be it further
> >
> > RESOLVED, that all responsibilities pertaining to the Apache Incubator
> > Dubbo podling encumbered upon the Apache Incubator PMC are hereafter
> > discharged.
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: Adding Dubbo Ecosystem page to official website

[yuhang xiu]

Hi,

I glanced at the ui design.
I think it's great, it can't be better. Looking forward to it.

Huxing Zhang  于2019年4月11日周四 下午3:36写道：

> Hi All,
>
> It looks like the UI design has been uploaded for preview.
> It will be appreciated if the community could take a look and give
> some feedback.
>
> https://github.com/apache/incubator-dubbo-website/issues/351
>
> On Thu, Apr 4, 2019 at 12:43 PM Huxing Zhang  wrote:
> >
> > Hi All,
> >
> > I just drafted a prototype of Dubbo ecosystem page, which can be
> > viewed in this issue [1], you can also check it here [2].
> > Any feedback is appreciated.
> >
> > [1] https://github.com/apache/incubator-dubbo-website/issues/351
> > [2]
> https://org.modao.cc/app/BGSpumvvJuhcFzwMF01oDjZNvjPos1q#screen=s4FBC5FC7A51551147526681
> >
> > On Thu, Feb 28, 2019 at 5:28 PM 秦金卫  wrote:
> > >
> > > I think We can break down the task to a several guys to do
> > > At 2019-02-28 16:50:35, "Huxing Zhang"  wrote:
> > > >Hi Community,
> > > >
> > > >As I proposed before[1], I'd like to add a dedicate web page to
> > > >introduce the Dubbo ecosystem and its components.
> > > >
> > > >I am working on a prototype, and will sent out for review once
> completed.
> > > >
> > > >What need to be included in the Ecosystem is a topic remains to be
> discussed.
> > > >
> > > >[1]
> https://lists.apache.org/thread.html/57cd51ca23008c7b60b318dc798fd43a150b840b81d08f8b340a3a01@%3Cdev.dubbo.apache.org%3E
> > > >
> > > >--
> > > >Best Regards！
> > > >Huxing
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
>
>
>
> --
> Best Regards！
> Huxing
>

Re: About polish code related pr

[yuhang xiu]

Hi,

Ok, then I am willing to obey the opinions of the majority.

But I still keep my opinion. If I find that this kind of behavior will
cause some problems, then it is not too late for me to raise this question
again.

Let's continue to do as we do now. Keep moving forward.
:)

Ian Luo  于2019年4月10日周三 下午4:23写道：

> Agree with YunKun's idea to enhance checkstyle rule in order to keep code
> style consistent. In fact, we do have a code style guideline [1] for Idea's
> user to import, is it sufficient?
>
> Thanks,
> -Ian.
>
> 1.
>
> https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md#code-style
>
> On Wed, Apr 10, 2019 at 1:23 PM YunKun Huang  wrote:
>
> > I think there should have a rule for polish.
> >
> > For example PR:https://github.com/apache/incubator-dubbo/pull/3651
> > If polish is necessary, I suggest also add a checkstyle rule for it.
> >
> > But for what kind of rule need apply, it need discuss first. for example,
> > is it acceptable for single-line statements without braces etc..
> >
> > On 2019/04/09 06:01:13, Huxing Zhang  wrote:
> > > Hi,
> > >
> > > I agree with Ian. I think small patches to polish code is acceptable.
> > > People these days are getting busy, and might not have large amount of
> > > time to contribute.
> > > Meanwhile, the it is easy to review. Large size pull request can be
> > > hard to review.
> > >
> > > On Tue, Apr 9, 2019 at 10:31 AM yuhang xiu  wrote:
> > > >
> > > > Hi, all
> > > >
> > > > Recently I found out that we have merged some pull requests for the
> > polish
> > > > code.
> > > >
> > > > I personally do not advocate small-scale polish code, such as this pr
> > [1].
> > > > We can't see the improvement clearly.
> > > >
> > > > I think that for this pr, we should put it in a large-scale polish
> > code, or
> > > > bugfix and feature-related pr, rather than separate.
> > > >
> > > > It's important to note that I am not denying the importance of the
> > polish
> > > > code. I just think that these prs will disrupt our commits record.
> > > >
> > > > I have encountered this problem in the flink community. The flink
> > community
> > > > does not accept small-scale polish code pr. They suggested that this
> > change
> > > > should be placed in other prs.
> > > >
> > > > What do you think about this?
> > > >
> > > > [1] https://github.com/apache/incubator-dubbo/pull/3820/files
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
>

About polish code related pr

[yuhang xiu]

Hi, all

Recently I found out that we have merged some pull requests for the polish
code.

I personally do not advocate small-scale polish code, such as this pr [1].
We can't see the improvement clearly.

I think that for this pr, we should put it in a large-scale polish code, or
bugfix and feature-related pr, rather than separate.

It's important to note that I am not denying the importance of the polish
code. I just think that these prs will disrupt our commits record.

I have encountered this problem in the flink community. The flink community
does not accept small-scale polish code pr. They suggested that this change
should be placed in other prs.

What do you think about this?

[1] https://github.com/apache/incubator-dubbo/pull/3820/files

Re: [IMPORTANT][PPMC] Invitation to be Dubbo PMC member

[yuhang xiu]

YES

Jun Liu  于2019年4月9日周二 上午10:16写道：

> YES
>
> Jun
>
> > On Apr 9, 2019, at 10:12 AM, Huxing Zhang  wrote:
> >
> > Dear Dubbo PPMC members,
> >
> > (bcc to all PPMC members)
> >
> > The Dubbo community is discussing the graduation of Dubbo to be a Top
> > Level project of Apache Software Foundation in the dev mailing list.
> > As one of the steps towards graduation, the community needs to set up
> > list of Project Management Committees (PMC) members after graduation,
> > which will be included in the graduation resolution.
> >
> > The role of the PMC is included as follows[1]:
> >
> > The role of the PMC from a Foundation perspective is oversight. The
> > main role of the PMC is not code and not coding - but to ensure that
> > all legal issues are addressed, that procedure is followed, and that
> > each and every release is the product of the community as a whole.
> > That is key to our litigation protection mechanisms.
> >
> > Secondly the role of the PMC is to further the long term development
> > and health of the community as a whole, and to ensure that balanced
> > and wide scale peer review and collaboration does happen. Within the
> > ASF we worry about any community which centers around a few
> > individuals who are working virtually uncontested. We believe that
> > this is detrimental to quality, stability, and robustness of both code
> > and long term social structures.
> >
> > If you are willing to be a PMC member after graduation, please respond
> > YES to this thread by replying to dev@dubbo.apache.org no later than
> > 2019-04-12 (Friday).
> > If you are not subscribing the private list, please remember to
> > subscribe to the private@ list.
> >
> >
> > [1] http://www.apache.org/foundation/how-it-works.html#pmc
> > --
> > Best Regards！
> > Huxing
>
>

For Issue 3785

[yuhang xiu]

Hi,beiwei

I recently saw an issue[1].
It seems that you changed the `dynamic` attribute to false in the previous
pr. Is it a special meaning to set it to the default false?

If not, perhaps we should set `dynamic` to true to ensure that the new and
old versions have the same logic.


[1] https://github.com/apache/incubator-dubbo/issues/3785

Re: [ANN] Welcome new committer: Imteyaz Khan

[yuhang xiu]

Thank you for your contribution khan, I really like your review.
:)


Taosheng, Wei  于2019年4月1日周一 上午10:21写道：

> Congraduations :)
>
>
>
>
> -- Original --
> From: Huxing Zhang 
> Date: Mon,Apr 1,2019 10:19 AM
> To: dev 
> Subject: Re: [ANN] Welcome new committer: Imteyaz Khan
>
>
>
> Hi Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Imteyaz Khan,
> a.k.a. khanimteyaz[1], has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Imteyaz, would you please briefly introduce yourself to the community?
>
> [1] https://github.com/khanimteyaz
> --
> Best Regards！
> Huxing

Re: Pull request merged without approval

[yuhang xiu]

agree. I think this is a very good way to help us standardize the pr merge.

YunKun Huang  于2019年3月20日周三 上午11:41写道：

> Agree, we should have at least one approval before merging
>
> On 2019/03/20 03:00:51, Huxing Zhang  wrote:
> > Hi,
> >
> >
> > On Wed, Mar 20, 2019 at 10:55 AM YunKun Huang 
> wrote:
> > >
> > >
> > > I guess you are talking about "Require pull request reviews before
> merging" feature [1]
> >
> > Cool! That is what I want.
> > I am +1 to support enabling this and set the number of required approval
> to 1.
> > How do others think?
> >
> > >
> > > [1]
> https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
> > >
> > > On 2019/03/20 02:39:43, Huxing Zhang  wrote:
> > > > Hi,
> > > >
> > > > This pull request[1] is merged without any comments, or following any
> > > > review process.
> > > > Any ideas how to avoid this?
> > > > Can Github support the feature that disable the merge button until  a
> > > > committer has approved the pull request?
> > > >
> > > > [1] https://github.com/apache/incubator-dubbo/pull/3693
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: Re: need to revisit pull request 3549 in 2.7.2

[yuhang xiu]

Sorry about that..

I mean `hi xu`. Wrong name of this statement..

yuhang xiu  于2019年3月15日周五 下午4:33写道：

> Hi jun,
>
> Not a problem.
>
> It’s just that we need to pay more attention in the future.
>
> :)
>
> kezhenxu94  于2019年3月15日周五 下午4:31写道：
>
>> Hi,
>>
>>
>> > - The one who merged this pull request, just merge this pull request
>> >  without saying anything. I am not sure he mis-understand the
>> >  STATUS/READY-TO-MERGE label or not. But I think if read the context
>> >  through, one should be more cautious to merge that pull request.
>>
>>
>> I'm so sorry it was me who merged that pull request.
>> I had read through the context(actually I reviewed although I did not
>> comment)
>> and indeed I've misunderstood the STATUS/READY-TO-MERGE label,
>> and I suggest put more detail about the labels in the committer guide[1]
>> to avoid later committers making the same mistakes.
>>
>>
>> Sorry again for making such mistake, I'll revert it if needed.
>>
>>
>>
>>
>> 1.
>> http://dubbo.apache.org/en-us/docs/developers/committer-guide/label-an-issue-guide_dev.html
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> At 2019-03-15 16:28:16, "yuhang xiu"  wrote:
>> >Hi, huxing.
>> >
>> >Great advice. In the previous review process, I also ignored some issues.
>> >
>> >Maybe we need a new label such as: `need-more-review`. When we need more
>> >reviews, we can mark this pr to remind other committers to review it.
>> >
>> >In addition, I think we need to clarify the meaning of `READY-TO-MERGE`.
>> I
>> >think there is only one case where we will use this label, which is the
>> >request that is approved, but this pr has not passed ci.
>> >
>> >In this pr merger, there are some problems, and we need to pay more
>> >attention in the future.
>> >
>> >Huxing Zhang  于2019年3月15日周五 下午4:03写道：
>> >
>> >> Hi,
>> >>
>> >> Looking at the reviewing process of the pull request, I can see some
>> >> issues here:
>> >> - No one has officially approved the pull request before it getting
>> >> merged. By saying officially I mean this[2], which I've mentioned in
>> >> another thread.
>> >> - One of the reviewer has marked the milestone as 2.7.2, but applied
>> >> it with a label called STATUS/READY-TO-MERGE. These two activities
>> >> look contradictory but according to the context he's meaning I guess
>> >> is to put some more time to it.
>> >> - The one who merged this pull request, just merge this pull request
>> >> without saying anything. I am not sure he mis-understand the
>> >> STATUS/READY-TO-MERGE label or not. But I think if read the context
>> >> through, one should be more cautious to merge that pull request.
>> >>
>> >> What I think can improve it:
>> >> - Every pull request must be approved officially by at least one of
>> >> the committer. (Comments such as LGTM does not mean official
>> >> approval.)
>> >> - If you feel uncertain about a pull request, please comment (see step
>> >> 6 in [2]) that you need more review to come in to review or request
>> >> review from others directly
>> >> - If you want to merge the pull request, you must read through all the
>> >> context.
>> >>
>> >> How do you think?
>> >>
>> >> [1] https://github.com/apache/incubator-dubbo/pull/3549
>> >> [2]
>> >>
>> https://help.github.com/en/articles/approving-a-pull-request-with-required-reviews
>> >>
>> >> On Thu, Mar 14, 2019 at 10:03 PM Ian Luo  wrote:
>> >> >
>> >> > Folks,
>> >> >
>> >> > I think we need to revisit pull request 3549 in 2.7.2. In my opinion,
>> >> > fluent api need to be carefully resigned.
>> >> >
>> >> > What do you think?
>> >> >
>> >> > Thanks,
>> >> > -Ian.
>> >>
>> >>
>> >>
>> >> --
>> >> Best Regards！
>> >> Huxing
>> >>
>>
>

Re: Re: need to revisit pull request 3549 in 2.7.2

[yuhang xiu]

Hi jun,

Not a problem.

It’s just that we need to pay more attention in the future.

:)

kezhenxu94  于2019年3月15日周五 下午4:31写道：

> Hi,
>
>
> > - The one who merged this pull request, just merge this pull request
> >  without saying anything. I am not sure he mis-understand the
> >  STATUS/READY-TO-MERGE label or not. But I think if read the context
> >  through, one should be more cautious to merge that pull request.
>
>
> I'm so sorry it was me who merged that pull request.
> I had read through the context(actually I reviewed although I did not
> comment)
> and indeed I've misunderstood the STATUS/READY-TO-MERGE label,
> and I suggest put more detail about the labels in the committer guide[1]
> to avoid later committers making the same mistakes.
>
>
> Sorry again for making such mistake, I'll revert it if needed.
>
>
>
>
> 1.
> http://dubbo.apache.org/en-us/docs/developers/committer-guide/label-an-issue-guide_dev.html
>
>
>
>
>
>
>
>
>
>
> At 2019-03-15 16:28:16, "yuhang xiu"  wrote:
> >Hi, huxing.
> >
> >Great advice. In the previous review process, I also ignored some issues.
> >
> >Maybe we need a new label such as: `need-more-review`. When we need more
> >reviews, we can mark this pr to remind other committers to review it.
> >
> >In addition, I think we need to clarify the meaning of `READY-TO-MERGE`. I
> >think there is only one case where we will use this label, which is the
> >request that is approved, but this pr has not passed ci.
> >
> >In this pr merger, there are some problems, and we need to pay more
> >attention in the future.
> >
> >Huxing Zhang  于2019年3月15日周五 下午4:03写道：
> >
> >> Hi,
> >>
> >> Looking at the reviewing process of the pull request, I can see some
> >> issues here:
> >> - No one has officially approved the pull request before it getting
> >> merged. By saying officially I mean this[2], which I've mentioned in
> >> another thread.
> >> - One of the reviewer has marked the milestone as 2.7.2, but applied
> >> it with a label called STATUS/READY-TO-MERGE. These two activities
> >> look contradictory but according to the context he's meaning I guess
> >> is to put some more time to it.
> >> - The one who merged this pull request, just merge this pull request
> >> without saying anything. I am not sure he mis-understand the
> >> STATUS/READY-TO-MERGE label or not. But I think if read the context
> >> through, one should be more cautious to merge that pull request.
> >>
> >> What I think can improve it:
> >> - Every pull request must be approved officially by at least one of
> >> the committer. (Comments such as LGTM does not mean official
> >> approval.)
> >> - If you feel uncertain about a pull request, please comment (see step
> >> 6 in [2]) that you need more review to come in to review or request
> >> review from others directly
> >> - If you want to merge the pull request, you must read through all the
> >> context.
> >>
> >> How do you think?
> >>
> >> [1] https://github.com/apache/incubator-dubbo/pull/3549
> >> [2]
> >>
> https://help.github.com/en/articles/approving-a-pull-request-with-required-reviews
> >>
> >> On Thu, Mar 14, 2019 at 10:03 PM Ian Luo  wrote:
> >> >
> >> > Folks,
> >> >
> >> > I think we need to revisit pull request 3549 in 2.7.2. In my opinion,
> >> > fluent api need to be carefully resigned.
> >> >
> >> > What do you think?
> >> >
> >> > Thanks,
> >> > -Ian.
> >>
> >>
> >>
> >> --
> >> Best Regards！
> >> Huxing
> >>
>

Re: need to revisit pull request 3549 in 2.7.2

[yuhang xiu]

Hi, huxing.

Great advice. In the previous review process, I also ignored some issues.

Maybe we need a new label such as: `need-more-review`. When we need more
reviews, we can mark this pr to remind other committers to review it.

In addition, I think we need to clarify the meaning of `READY-TO-MERGE`. I
think there is only one case where we will use this label, which is the
request that is approved, but this pr has not passed ci.

In this pr merger, there are some problems, and we need to pay more
attention in the future.

Huxing Zhang  于2019年3月15日周五 下午4:03写道：

> Hi,
>
> Looking at the reviewing process of the pull request, I can see some
> issues here:
> - No one has officially approved the pull request before it getting
> merged. By saying officially I mean this[2], which I've mentioned in
> another thread.
> - One of the reviewer has marked the milestone as 2.7.2, but applied
> it with a label called STATUS/READY-TO-MERGE. These two activities
> look contradictory but according to the context he's meaning I guess
> is to put some more time to it.
> - The one who merged this pull request, just merge this pull request
> without saying anything. I am not sure he mis-understand the
> STATUS/READY-TO-MERGE label or not. But I think if read the context
> through, one should be more cautious to merge that pull request.
>
> What I think can improve it:
> - Every pull request must be approved officially by at least one of
> the committer. (Comments such as LGTM does not mean official
> approval.)
> - If you feel uncertain about a pull request, please comment (see step
> 6 in [2]) that you need more review to come in to review or request
> review from others directly
> - If you want to merge the pull request, you must read through all the
> context.
>
> How do you think?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3549
> [2]
> https://help.github.com/en/articles/approving-a-pull-request-with-required-reviews
>
> On Thu, Mar 14, 2019 at 10:03 PM Ian Luo  wrote:
> >
> > Folks,
> >
> > I think we need to revisit pull request 3549 in 2.7.2. In my opinion,
> > fluent api need to be carefully resigned.
> >
> > What do you think?
> >
> > Thanks,
> > -Ian.
>
>
>
> --
> Best Regards！
> Huxing
>

Re: need to revisit pull request 3549 in 2.7.2

[yuhang xiu]

Hi,
+1

This pr is very big. I also left some comments under it. This feature
should be considered more clearly.

jun liu  于2019年3月15日周五 上午10:54写道：

> Hi,
>
> +1
>
> I think we should revert this merge and postpone to 2.7.2, it has not been
> fully discussed yet.
>
> Jun
>
> > On Mar 14, 2019, at 10:02 PM, Ian Luo  wrote:
> >
> > Folks,
> >
> > I think we need to revisit pull request 3549 in 2.7.2. In my opinion,
> > fluent api need to be carefully resigned.
> >
> > What do you think?
> >
> > Thanks,
> > -Ian.
>
>

Re: Nanjing Meetup Registration is Opening

[yuhang xiu]

Thanks for your great work, looking forward to this meetup.
Hope everything goes well.
:)

chenwei qi  于2019年3月12日周二 下午2:47写道：

> Dear all,
>
> The Apache Dubbo Meetup will be held in Nanjing on March. 23, 2019, and the
> schedule of the meetup is as below:
>
> 9:30-11:30 End User Discussion
> 13:00-13:40 Check in
> 13:40-14:20 Introduction and Demo about the new Feature of Dubbo 2.7
> 14:20-15:00 What's the Dubbo Spring Cloud?
> 15:00-15:40 Dubbo2.js: from 0 to 1
> 15:40-16:10 Coffee Break
> 16:10-16:50 Fescar's Exploration in Microservice Consistency
> 16:50-17:30 Dubbo's practice in Whale Cloud
> 17:30-18:00 Q&A
>
> Registrate meetup:http://hdxu.cn/0oIt7
>
> If you cannot attend the meetup offline, welcome to attend online. The stre
> am: https://yq.aliyun.com/live/908
>
> Hope to see you in the meetup.
>
> Baike
>

Re: Is 2.5.x still being supported?

[yuhang xiu]

+1

Ian Luo  于2019年3月8日周五 上午10:42写道：

> +1 to announce EOL of 2.5.x as soon as possible.
>
> On Thu, Mar 7, 2019 at 6:04 PM jun liu  wrote:
>
> > > IMO, we should consider announce the end of life in the near future,
> > > say 1 year, and only support critical bug fix or security fix,
> >
> > In fact, 2.5.x has been out of the community’s daily maintenance for a
> > while. And I think few users are still staying on this branch, this can
> be
> > told from the PRs and issues reported as really few issues were related
> to
> > 2.5.x in the past 5-6 months.
> >
> > I think we should announce EOL plan ASAP and 3 months official buffer
> > period would be enough.
> >
> > Jun
> >
> > > On Mar 7, 2019, at 4:49 PM, Huxing Zhang  wrote:
> > >
> > > Hi,
> > >
> > > I see someone send a pull request to 2.5.x branch[1].
> > > My question is that is 2.5.x branch still being supported?
> > > IMO, we should consider announce the end of life in the near future,
> > > say 1 year, and only support critical bug fix or security fix, while
> > > that we should provide a migration guide for user to upgrade from
> > > 2.5.x to 2.6.x or 2.7.x.
> > >
> > > What do you think?
> > >
> > > [1] https://github.com/apache/incubator-dubbo/pull/3565
> > >
> > > --
> > > Best Regards！
> > > Huxing
> >
> >
>

Re: Pull request review rules

[yuhang xiu]

Hi, all

In my opinion, both suggestions are good.
But what I need to remind is that we should have at least one deadline to
prevent a pr from being suspended for a long time.

Thx.

Ian Luo  于2019年3月8日周五 上午10:41写道：

> I think we don't need such a complex rule at all. More reviewers on it,
> more confidence it will give the author. I think there's a chance for
> reviewers more than one looking into one pull request because this pull
> request may look interesting to them. I don't worry too much since
> eventually they will reach a consensus and the pull request get merged by
> one of the reviewers. What I suggest is to make the rule simple, no pull
> request can be merged unless it's reviewed one reviewer at least.
>
> Thanks,
> -Ian.
>
>
> On Fri, Mar 8, 2019 at 10:37 AM Ian Luo  wrote:
>
> > I think we don't need such a complex rule at all. More reviewers on it,
> > more confidence it will give the author. I think there's a chance for
> > reviewers more than one looking into one pull request because this pull
> > request may look interesting
> >
> > On Thu, Mar 7, 2019 at 5:04 PM Huxing Zhang  wrote:
> >
> >> Hi,
> >>
> >> When I am looking at the pull request, I found a pull request[1] got
> >> approved by 2 of our reviewers(committers), but still not getting
> >> merged.
> >>
> >> I am thinking why it is like this. Should we set up community rules
> >> for thing like this?
> >> For example, if a pull request has got at least N approval from
> >> committers, it can be merged, where N can be discussed. The more
> >> approval it need, the longer process it will take.
> >>
> >> For large size pull requests, the reviewer can request another one to
> >> help on it.
> >>
> >> I would suggest to keep it small, N=1.  Even the reviewer fails to
> >> identify the issues, it can be fixed by sending another pull request.
> >>
> >> How do you think?
> >>
> >> [1] https://github.com/apache/incubator-dubbo/pull/3536
> >>
> >> --
> >> Best Regards！
> >> Huxing
> >>
> >
>

[Discussion] There are so much threadpool, can we merge some threadpool into one threadpool?

[yuhang xiu]

Hi, all

I noticed that @cvictory made a very good issue[1], I think we can have
more discussion, so I brought it here:

There are so much threadpool that manage only one thread , and this thread
is idle. The threadpool as follow:

*
org.apache.dubbo.metadata.support.AbstractMetadataReport#reportCacheExecutor
for asyn write metadata.
* The HashedWheelTimer is used in Registry retry task.
* Configcenter listen the config changed, and the callback will excuted by
a dependency Executor.


There are so much situation that we will use threadpool. I think can we
merge this threadpool to make the threadpool is used by much more situation.

Also we should move some timer task to HashedWheelTimer?

[1] https://github.com/apache/incubator-dubbo/issues/3616

Re: [DISCUSS] Dubbo on Stackoverflow

[yuhang xiu]

Hi, huxing

Personally think that we should support Stack Overflow.
Maybe we need some users who are active on Stack Overflow to answer dubbo
related questions.

There are some problems on Stack Overflow, and some of them have not been
replied [1].

[1] https://stackoverflow.com/search?page=1&tab=Relevance&q=dubbo

Huxing Zhang  于2019年3月4日周一 下午4:48写道：

> Hi community,
>
> Someone raised an issue asking why there is no support on
> Stackoverflow[1]. Do you think we should support that?
>
> I'd prefer to use GitHub issues/dev mailing list to ask user
> questions. Because of the users have already get used to that.
> Officially adding a new channel may increase the burden of the
> community.
>
> [1] https://github.com/apache/incubator-dubbo/issues/3442
>
> --
> Best Regards！
> Huxing
>

Re: [DISCUSSION] Idea about making Filter totally asynchronous and event-driven.

[yuhang xiu]

Hi,

About compatibility issues.

The current version will enter onResponse due to all requests (correct or
incorrect). If we modify the code, the correct response enters onResponse,
the error response enters onError, and onResponse will only process the
correct request if the user does not modify the Filter code.

Is this a problem that we should consider?

Ian Luo  于2019年3月3日周日 下午10:49写道：

> Jun,
>
> In your new proposed interface, how could we construct a filter chain? Say,
> how could filter-a process further a value processed by filter-b?
>
> Thanks,
> -Ian.
>
>
> On Fri, Mar 1, 2019 at 5:44 PM jun liu  wrote:
>
> > Hi,
> >
> > I am thinking of the possibility of changing the current Filter
> definition
> > model to make it totally asynchronous and event-driven. Here’s the
> detailed
> > proposal[1]. It’s only a immature idea at present so I am not sure fi
> it’s
> > good to have this change yet, especially from the user’s side.
> >
> > In short, the new Filter would look like:
> >
> > public interface Filter {
> >void onSend(Invocation invocation) {
> >  // before invoke, throw exception to terminate
> > }
> >
> >void onResponse(Result result, Invoker invoker, Invocation
> > invocation) {
> > // biz return successfully
> > }
> >
> >void onError(Throwable e) throws RpcException{
> > // biz throw exception
> > }
> > }
> >
> > 1. https://github.com/apache/incubator-dubbo/issues/3585
> >
> > Jun
> >
> >
>

Re: Etcd support in 2.7.x

[yuhang xiu]

good news!

I remember that yiji is familiar with etcd3, and he may give us some advice.

YunKun Huang  于2019年2月27日周三 上午11:54写道：

> +1
> good to have official support for etcd.
>
> From my personal experience, etcd is common and many companies already
> have it in their IT infrastructure.
>
> On 2019/02/26 15:00:34, Huxing Zhang  wrote:
> > Hi,
> >
> > Since Dubbo 2.7, the registry metadata and configuration metadata has
> > been split, which make Dubbo easier to support more popular projects
> > like nacos, etcd, and consul
> >
> > I am planning to work on the etcd support for 2.7.x including:
> > - simplified registry url
> > - etcd as configuration center
> > - etcd as metadata report
> >
> > Hopefully will get it done before 2.7.1 release :)
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: self introduction

[yuhang xiu]

By the way, if you are using github to submit pr for the first time, you
can find some useful information from this link:
http://dubbo.apache.org/en-us/docs/developers/contributor-guide/new-contributor-guide_dev.html

yuhang xiu  于2019年2月22日周五 下午1:57写道：

> Hi, Daniela
>
> Welcome to dubbo community!
>
> If you have any questions, you can ask here and we will answer them as
> soon as possible.
>
> I saw that you claimed an issue and looked forward to your pull request! I
> will pay attention to it.
>
> Thx
>
> Daniela Morais  于2019年2月22日周五 下午1:20写道：
>
>> Hello,
>>
>> My name is Daniela and I'm a software engineer from Sao Paulo! As a Java
>> enthusiast, I've used Apache's Projects for years such as Tomcat, Ant, and
>> Maven and I always wanted to contribute. I've been developing microservices
>> with Spring Boot so I thought that Dubbo will be a great opportunity to
>> start to contribute.
>>
>> I'm studying CS and I read some issues in Jira about GSoC 2019 (
>> https://issues.apache.org/jira/browse/DUBBO-33 <
>> https://issues.apache.org/jira/browse/DUBBO-33>) and I want to improve
>> my acknowledgment in those technologies (reactive architecture, load
>> balancer, service mesh etc.) also.
>>
>> I’d like to contribute a small commit so I look forward to working on
>> this issue: https://github.com/apache/incubator-dubbo/issues/2984 <
>> https://github.com/apache/incubator-dubbo/issues/2984>
>>
>> Thanks
>> --
>>
>> Daniela Morais
>> Computer Science student at University Of Campinas@danielammorais
>> danielammorais.com <http://www.danielammorais.com>
>>
>>

Re: self introduction

[yuhang xiu]

Hi, Daniela

Welcome to dubbo community!

If you have any questions, you can ask here and we will answer them as soon
as possible.

I saw that you claimed an issue and looked forward to your pull request! I
will pay attention to it.

Thx

Daniela Morais  于2019年2月22日周五 下午1:20写道：

> Hello,
>
> My name is Daniela and I'm a software engineer from Sao Paulo! As a Java
> enthusiast, I've used Apache's Projects for years such as Tomcat, Ant, and
> Maven and I always wanted to contribute. I've been developing microservices
> with Spring Boot so I thought that Dubbo will be a great opportunity to
> start to contribute.
>
> I'm studying CS and I read some issues in Jira about GSoC 2019 (
> https://issues.apache.org/jira/browse/DUBBO-33 <
> https://issues.apache.org/jira/browse/DUBBO-33>) and I want to improve my
> acknowledgment in those technologies (reactive architecture, load balancer,
> service mesh etc.) also.
>
> I’d like to contribute a small commit so I look forward to working on this
> issue: https://github.com/apache/incubator-dubbo/issues/2984 <
> https://github.com/apache/incubator-dubbo/issues/2984>
>
> Thanks
> --
>
> Daniela Morais
> Computer Science student at University Of Campinas@danielammorais
> danielammorais.com 
>
>

Re: Filter problems in async way

[yuhang xiu]

Hi,ian

Several reasons:
1. It seems that the attachment is based on the convention. We need to put
the information other than the rpc parameter into the attachment. We need
to ensure that the information and the temporary information (start in the
timeoutFilter) do not overlap.
2. The attachment field may be null. This allows us to make some additional
judgments and processing before we can use the attachment field:

if (invocation.getAttachments() != null) {
long start = System.currentTimeMillis();
invocation.getAttachments().put(TIMEOUT_FILTER_START_TIME,
String.valueOf(start));
} else {
if (invocation instanceof RpcInvocation) {
RpcInvocation invc = (RpcInvocation) invocation;
long start = System.currentTimeMillis();
invc.setAttachment(TIMEOUT_FILTER_START_TIME,
String.valueOf(start));
}
}

I am still thinking about this issue recently. It seems that the extra
tempAttachment needs to increase the cost of the transmission.
So I have some hesitation about using tempAttachment. How do you think
about this problem?

Ian Luo  于2019年2月18日周一 下午6:26写道：

> Yuhang,
>
> Why it's a bad idea to use invocation#attachments to store the temp data?
>
> Thanks,
> -Ian.
>
>
> On Fri, Feb 15, 2019 at 2:55 PM yuhang xiu  wrote:
>
> > Hi, everyone
> >
> > Recently, I found that dubbo does not handle the data generated during
> the
> > call process when it is asynchronous.
> >
> > For example, in TimeoutFilter, we used invocation#attachments to hold the
> > data that needs to be passed (start time in TimeoutFilter). But I don't
> > think this way is good, although using Invocation.attachments to pass
> data
> > does not pollute RpcContext.
> >
> > Perhaps a better way is to add a temporary attachment to the Invocation
> > that only maintains the temporary data generated during the call.
> >
> > In addition, I found that we still have a few Filters that are currently
> > problematic in asynchronous scenarios, such as:
> >
> > * ActiveLimitFilter
> > * TraceFilter
> >
> > We should determine a plan as soon as possible and then proceed to fix
> > these Filters.
> >
>

Re: how to deal with two pull requests to solve the same issue

[yuhang xiu]

Totally agree with huxing.
In addition, we may be able to remind the authors of the two prs that their
pr is repeated.
This will let them review the code and leave a comment. In some cases,
perhaps one of them will close their pr directly.

Huxing Zhang  于2019年2月18日周一 下午5:28写道：

> Hi,
>
> I remember I've seen this kind of issue before.
>
> From my point of view, I prefer the following precedence:
> - check the implementation, the code quality requirement should be
> satisfied.
> - if the quality looks more or less the same, I usually check if
> he/she is the first time contributor. I think we should be more
> generous to new comers.
>

Can't agree more. We should involve more people. Getting more people to
contribute to dubbo is very important for the dubbo community, and we
should give this opportunity to newcomer.


> - if the above condition is not met, I tend to use FIFO based on the
> creation time of the pull request.
>
> This is my personal opinion, let's see what others might think.
>
> To avoid this issue, I do recommend people to leave a comment before
> start contributing.
>
> On Mon, Feb 18, 2019 at 2:03 PM Minxuan Zhuang 
> wrote:
> >
> > Hi Community,
> >If two pull requests are aiming  to solve the same issue, how to
> choose
> > from them?
>
>
>
> --
> Best Regards！
> Huxing
>

Filter problems in async way

[yuhang xiu]

Hi, everyone

Recently, I found that dubbo does not handle the data generated during the
call process when it is asynchronous.

For example, in TimeoutFilter, we used invocation#attachments to hold the
data that needs to be passed (start time in TimeoutFilter). But I don't
think this way is good, although using Invocation.attachments to pass data
does not pollute RpcContext.

Perhaps a better way is to add a temporary attachment to the Invocation
that only maintains the temporary data generated during the call.

In addition, I found that we still have a few Filters that are currently
problematic in asynchronous scenarios, such as:

* ActiveLimitFilter
* TraceFilter

We should determine a plan as soon as possible and then proceed to fix
these Filters.

Re: [ANN] Welcome new committer: Xiaojie Li

[yuhang xiu]

congratulate! welcome!

Thank you for your great contribution!
:)

Huxing Zhang  于2019年2月14日周四 下午2:24写道：

> Hi Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Xiaojie Li,
> a.k.a. lixiaojiee[1], has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Xiaojie, would you please briefly introduce yourself to the community?
>
> [1] https://github.com/lixiaojiee
>
> --
> Best Regards！
> Huxing
>

Re: [Discuss] About Clean Code Plan

[yuhang xiu]

Hi, @lizhen

Your pr seems to have some problems, so I have already commented below and
explained that please resubmit a pr. If you can solve this problem directly
on your branch, you can tell me, of course I will reopen your pr. But
before that, I didn't think that reviewing 30,000 lines of code was
necessary, and your pr could not be merged before you solved the problem,
so I turned it off.

Also, if you need to discuss anything, use an issue to track instead of
using pr to track, even if your pr is your purpose. That is a better
approach.

LiZhenNet  于2019年1月29日周二 上午10:58写道：

> I don't know why he showed that the entire file was modified, even though
> he only modified one line. You can check it.
>
> yuhang xiu  于2019年1月29日周二 上午10:43写道：
>
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet  于2019年1月29日周二 上午10:29写道：
> >
> > > Yes, we can create a project to manage it, and we can talk about it.
> > like:
> > > Should we used Diamond Operator replace  explicit type? Use Lambda?
> > > Let's discuss the two pull requests above instead of closed it
> > immediately.
> > >
> > >
> > >
> > >
> > >
> > > Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> > >
> > > > Hi,
> > > >
> > > > Nice suggestion!
> > > >
> > > > Shall we can create a project to manage it?
> > > >
> > > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> > > wrote:
> > > > >
> > > > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > > unused
> > > > > methods ,unused logic , nonstandard naming  in the code. And there
> > are
> > > > some
> > > > > code that can use the new features of java to make the code more
> > > concise
> > > > > and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > > > easy
> > > > > to find and fixed because of the tips of the idea .We should do it
> > > before
> > > > > completing the incubation.
> > > >
> > > >
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
> >
>

Re: [Discuss] About Clean Code Plan

[yuhang xiu]

Your pr has modified more than 30,000 lines of code, and most of them are
modifications of the entire file.
What is the meaning of your pr? Why do I need to keep it open?

If you need to discuss, issues and mailing lists are good choices, why do
you need to discuss pr?

Who can review this pr[1] and tell me what this pr is going to do?

[1] https://github.com/apache/incubator-dubbo/pull/3371

LiZhenNet  于2019年1月29日周二 上午10:29写道：

> Yes, we can create a project to manage it, and we can talk about it. like:
> Should we used Diamond Operator replace  explicit type? Use Lambda?
> Let's discuss the two pull requests above instead of closed it immediately.
>
>
>
>
>
> Huxing Zhang  于2019年1月29日周二 上午9:58写道：
>
> > Hi,
> >
> > Nice suggestion!
> >
> > Shall we can create a project to manage it?
> >
> > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> wrote:
> > >
> > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> unused
> > > methods ,unused logic , nonstandard naming  in the code. And there are
> > some
> > > code that can use the new features of java to make the code more
> concise
> > > and understandable. like Lambda , Diamond Operator and so on.These are
> > easy
> > > to find and fixed because of the tips of the idea .We should do it
> before
> > > completing the incubation.
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: [ANN] Welcome new committer: Xianjun Ke

[yuhang xiu]

Hi, xianjun, I think your review is great and gives a lot of valuable
advice.
Congratulations on becoming a committer!

Huxing Zhang  于2019年1月25日周五 上午11:40写道：

> Hi Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Xianjun Ke,
> a.k.a. kexianjun[1], has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Xianjun, would you please briefly introduce yourself to the community?
>
> [1] https://github.com/kexianjun
>
> --
> Best Regards！
> Huxing
>

Re: [Discuss] The Timer Design in Dubbo from 2.6 to 2.7

[yuhang xiu]

Yesterday I received a reply from the netty community:

just because we usually want to be on the same thread as the EventLoop of
> the Channel. that said there is nothing wrong about the HashedWheelTimer.


It seems that netty does not use HashedWheelTimer not because of its own
problems.

I think we can safely continue to use HashedWheelTimer. However, we still
need to pay attention to the fact that if there is a large delay in the
task, we need to use or even give up using HashedWheelTimer, and the task
that seems to be blocked is not suitable.

Thx for jingfeng's question. Very valuable.
:)

Jason Joo  于2019年1月24日周四 上午10:44写道：

> hi, moe
>
> This is the main differences:
>
> ScheduledThreadPoolExecutor
>
> O(log N) for adding new task
> O(1) per each timer tick (but tick per each task, so N overall)
> O(log N) cancelling the task
> lock per each tick/task
> HashedWheelTimer
>
> O(1) adding new task
> O(m) per each timer tick (m ~ N/C where C > 512 approx), so ~C ticks
> overall
> O(m) for cancelling a task
> lock per bucket of tasks (on each tick)
>
>
> best regards,
>
> Jason
>
> > On Jan 24, 2019, at 10:09, 徐靖峰  wrote:
> >
> > Hi, Jason，a nice opinion.
> >
> > I have noticed that this issue[1] in Github encourage  the change from
> Schedule to HashedWheelTimer, but didn’t give a vert detailed reason.
> >
> > Is HashedWheelTimer really an unquestionable choice?
> >
> > [1] https://github.com/apache/incubator-dubbo/issues/1371 <
> https://github.com/apache/incubator-dubbo/issues/1371>
> >
> >> 在 2019年1月24日，上午9:53，Jason Joo  写道：
> >>
> >> Maybe because the main scenario dubbo faces is persistent connection.
> >> For persistent connections the most frequent thing is ticking.
> >>
> >> ScheduledThreadPoolExecutor is O(1)*connections compared to O(C) in
> HashedWheelTimer when ticking.
> >> Considering connections is far less then C ScheduledThreadPoolExecutor
> maybe more efficient in my opinion.
> >>
> >> best regards,
> >>
> >> Jason
> >
>
>

Re: [Discuss] The Timer Design in Dubbo from 2.6 to 2.7

[yuhang xiu]

hi，all

回复一下关于引入timer的问题。关于第一个问题，是为了解决defaultFuture的timeout问题，其实这个问题在issue[1]里说的很清楚了，就是为了解决无效的遍历。
对比老的实现即可发现，老的遍历做了非常多的无用功，而timer可以更精确的控制超时。

关于netty为什么不使用的问题，我这里提交了一个issue[2]。

所有的其他讨论我认为应该在netty回复我们以后。

在使用场景上，dubbo确实有需求，在多级时间轮上，这个在引入的时候我也做过调查，并不是必须的，只要我们控制好timer的大小即可。
关于timer的逻辑耦合在抽象类，我其实没弄懂你的意思，timer当然可重用，你是想说timertask能否重用的问题么？timertask的抽象我们也可以通用（目前这里是有抽象空间的），另外timertask作为执行单元，task执行的效果不一样，当然不存在能否重用的问题，这个感觉就是schedulethreadpool执行的每个runnable都基本不太能复用是一个道理。

[1] https://github.com/apache/incubator-dubbo/issues/1371
[2] https://github.com/netty/netty/issues/8774


徐靖峰  于2019年1月24日周四 上午10:09写道：

> Hi, Jason，a nice opinion.
>
> I have noticed that this issue[1] in Github encourage  the change from
> Schedule to HashedWheelTimer, but didn’t give a vert detailed reason.
>
> Is HashedWheelTimer really an unquestionable choice?
>
> [1] https://github.com/apache/incubator-dubbo/issues/1371 <
> https://github.com/apache/incubator-dubbo/issues/1371>
>
> > 在 2019年1月24日，上午9:53，Jason Joo  写道：
> >
> > Maybe because the main scenario dubbo faces is persistent connection.
> > For persistent connections the most frequent thing is ticking.
> >
> > ScheduledThreadPoolExecutor is O(1)*connections compared to O(C) in
> HashedWheelTimer when ticking.
> > Considering connections is far less then C ScheduledThreadPoolExecutor
> maybe more efficient in my opinion.
> >
> > best regards,
> >
> > Jason
>
>

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

[yuhang xiu]

Hi, jingfeng,

I saw beiwei merge your pr, nice work!

However, I think we still need to consider two things.

Since we are using a shared timer, this timer will not be closed when a
client is closed.
In this case, we need to control our tasks without unlimited growth. My
current practice is to create a mapping between client and task. When our
client is closed, we can find the corresponding task and cancel them. The
canceled task will not be re-inserted into the timer.

The other thing, I modified the size of the shared timer. In the old
version, since each client uses a timer alone, the size of the timer is
only 16, and now it is changed to 128 to reduce the hash conflict.

My pr is here:
https://github.com/apache/incubator-dubbo/pull/3299

Would u pls have a look?

徐靖峰  于2019年1月15日周二 下午2:49写道：

> Hi folks，
>
> Here is my suggestion to improve Dubbo’s HeartBeat Design.
>
> - The design of the two-way heartbeat is unnecessary, compatible with the
> existing logic, allowing the client to send a one-way heartbeat when the
> connection is idle, and the server periodically detects the connection
> availability. Timed time to ensure: client timeout * 3 ≈ server timeout
> - Remove the timing tasks for reconnection and disconnection. Dubbo can
> judge whether the heartbeat request fails to respond. You can learn from
> the design of the improved scheme, maintain a mark of the number of
> heartbeat failures at the connection level, and successfully respond to any
> failures. Clear the mark; continuous heartbeat failure. The client
> initiates a reconnection. This can reduce an unnecessary timer, and any
> polling method is not elegant.
>
> I've described more details in my blog, about Dubbo's existing heartbeat
> program, its shortcomings, and the advantages of replacing it with a new
> solution, as well as some forward thinking, welcome to discuss.
>
> bolg：https://www.cnkirito.moe/heartbeat-design/ <
> http://www.cnkirito.moe/heartbeat-design/>
>
> ---
>
> Hi 乡亲们：
>
> 我给现有 Dubbo 的心跳方案改进提了两条建议
>
> - 双向心跳的设计是不必要的，兼容现有的逻辑，可以让客户端在连接空闲时发送单向心跳，服务端定时检测连接可用性。定时时间尽量保证：客户端超时时间 *
> 3 ≈ 服务端超时时间
> - 去除处理重连和断连的定时任务，Dubbo
> 可以判断心跳请求是否响应失败，可以借鉴改进方案的设计，在连接级别维护一个心跳失败次数的标记，任意响应成功，清除标记；连续心跳失败 n
> 次，客户端发起重连。这样可以减少一个不必要的定时器，任何轮询的方式，都是不优雅的。
>
> 我的博客中描述了更多的细节，关于 Dubbo 现有的心跳方案，它的不足之处，以及替换成新的方案的优势，以及一些展望思考，欢迎讨论。
>
> 博客地址：https://www.cnkirito.moe/heartbeat-design/

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[yuhang xiu]

awesome.
Looking forward to dubbo 2.7.
I just looked at the milestones of 2.7. It looks like there is no problem.


Huxing Zhang  于2019年1月17日周四 上午10:42写道：

> Hi All,
>
> I am seeing that all the issue has been cleaned for the 2.7.0 milestone.
> It looks like all the things have been settled, I am planning to tag
> the 2.7.0 release today.
>
> dubbo-ops and dubbo-spring-boot-project should be released after Dubbo
> 2.7.0 release.
>
> On Wed, Jan 16, 2019 at 5:02 PM jun liu  wrote:
> >
> > > There is no need to shade gson into dubbo.jar, just need depency gson
> > > library.
> > >
> > > I have fixed it . https://github.com/apache/incubator-dubbo/pull/3246
> 
> > Agree.
> >
> > Well done,  merged.
> >
> > Jun
> >
> > > On Jan 16, 2019, at 4:15 PM, victory  wrote:
> > >
> > > There is no need to shade gson into dubbo.jar, just need depency gson
> > > library.
> > >
> > > I have fixed it . https://github.com/apache/incubator-dubbo/pull/3246
> > >
> > > Ian Luo  于2019年1月16日周三 下午2:34写道：
> > >
> > >> We should not shade gson binaries into dubbo all in one jar file, even
> > >> though there's no license issue. It is simply we should not do this,
> > >> instead, we should make sure dubbo all in one jar should have a
> transitive
> > >> dependency to gson library.
> > >>
> > >> I noticed it's caused
> by'com.google.code.gson:gson' in
> > >> dubbo-all/pom.xml. We should fix it.
> > >>
> > >> Thanks,
> > >> -Ian.
> > >>
> > >>
> > >> On Tue, Jan 15, 2019 at 5:16 PM jun liu  wrote:
> > >>
> > >>> I noticed that a third-party source code ‘com.google <
> http://com.google/
> > >>> .gson.*’
> > >>> has been compiled into the convenient maven binary jar of 2.7.0 -
> > >>> dubbo-2.7.0.jar :
> > >>>
> > >>> .
> > >>> ├── META-INF
> > >>> │   ├── DEPENDENCIES
> > >>> │   ├── LICENSE
> > >>> │   ├── MANIFEST.MF
> > >>> │   ├── NOTICE
> > >>> │   ├── assembly
> > >>> │   │   └── bin
> > >>> │   ├── compat
> > >>> │   │   └── dubbo.xsd
> > >>> │   ├── dubbo
> > >>> │   │   └── internal
> > >>> │   ├── dubbo.xsd
> > >>> │   ├── maven
> > >>> │   │   ├── com.alibaba
> > >>> │   │   ├── com.google.code.gson
> > >>> │   │   └── org.apache.dubbo
> > >>> │   ├── spring.handlers
> > >>> │   └── spring.schemas
> > >>> ├── com
> > >>> │   ├── alibaba
> > >>> │   │   ├── com
> > >>> │   │   └── dubbo
> > >>> │   └── google
> > >>> │   └── gson
> > >>> └── org
> > >>>└── apache
> > >>>└── dubbo
> > >>>
> > >>>
> > >>> Since this binary jar (dubbo-2.7.0.jar) will be included in the
> Apache
> > >>> Binary Release, should we update the LICENSE or NOTICE file in the
> Binary
> > >>> Release to announce the existence of these binary files?
> > >>>
> > >>> BTW, ‘com.google .gson’ is declared to be unde
> > >> Apache
> > >>> License 2.0.
> > >>>
> > >>> You can directly download the latest SNAPSHOT release of
> 2.7.0-SNAPSHOT
> > >> in
> > >>> here[1] and unzip and check the contents to better understand what I
> am
> > >>> trying to describe here.
> > >>>
> > >>> 1.
> > >>>
> > >>
> https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/dubbo/2.7.0-SNAPSHOT/
> > >>>
> > >>> Jun
> > >>>
> >  On Jan 13, 2019, at 5:58 PM, Huxing Zhang 
> wrote:
> > 
> >  Hi Jun,
> > 
> >  Could you summarize the current status of the 2.7-release branch?
> >  I see there are still several enhancement on this branch.
> > 
> >  As this is the first time to prepare for a release for me, I am
> trying
> >  to walk through the release steps[1].
> >  I might try to deploy snapshot to maven repository.
> > 
> >  Once we feel it is ready to do the release, I will start the formal
> >  release process.
> > 
> > 
> >  [1]
> http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html
> > 
> > 
> >  --
> >  Best Regards！
> >  Huxing
> > 
> >  On Mon, Jan 7, 2019 at 1:48 PM jun liu  wrote:
> > >
> > >>>
> > >>> Nice work!
> > >>>
> > >>> I think we should let the community to participate more in the
> > >> release
> > >>> process, for example,
> > >>> 1. check out a release branch called 2.7.0-release
> > >>> 2. encourage people to check it out, test it and report if there
> is
> > >>> any regressions, bugs or issues.
> > >>> 3. while we are doing the test, we can start going through the
> ASF
> > >>> release process locally, once we think it is ready to start a
> formal
> > >>> release note, it can be done very quickly.
> > >>>
> > >>> By the way, we need decide the release manager of 2.7.0 release.
> Is
> > >>> there anyone who volunteer to do that?
> > >
> > > Sorry, I missed this mail.
> > > * 2.7.0-release has been created
> > > * we've froze the codebase, test is underway.
> > >
> > >> I'd like to be the release manager if no one is claiming it.
> > >
> > > Great, I can he

Re: Next steps of projects in Dubbo group

[yuhang xiu]

Agree.

Awesome extension.
Another thing, I noticed that @ningyu provides a dubbo-jmeter test tool, do
we need to transfer it to ASF as well?

https://github.com/dubbo/jmeter-plugins-dubbo

Huxing Zhang  于2019年1月15日周二 上午10:12写道：

> Hi,
>
> Recently I am doing the maven release process, I found the following
> snapshots has been deploy to maven snapshot repo:
>
> dubbo-registry-etcd3
> dubbo-rpc-native-thrift
>
> However the source codes are still in the Dubbo group, which IMO
> should be transferred to ASF, which matches the proposal in my
> previous thread, WDYT?
>
> [1]
> https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/
>
> On Thu, Jan 10, 2019 at 5:26 PM Huxing Zhang  wrote:
> >
> > Hi All,
> >
> > I think we need to decide the next steps of projects in Dubbo[1]
> > group. I'd divided them by 4 categories:
> >
> > ### Dubbo RPC extension modules
> >
> > I think they are can be merge back into the core repository for the
> > purpose of easier release management and concentrate the
> > users/contributors.
> >
> > They are:
> > * dubbo-rpc-native-thrift maintained by Xin Wang, our PPMC
> > * dubbo-registry-etcd maintained by Zonghai Shang, our PPMC
> > * dubbo-async-processor maintained by Jun Liu, our PPMC
> > * dubbo-registry-nacos maintained by Mercy Ma, our PPMC
> > * dubbo-configcenter-archaius an empty project, since Netflix no
> > longer maintains it, I propose to drop this project
> > * dubbo-serialization-gson maintained by Ian Luo, our PPMC
> > * dubbo-serialization-fst empty project, already merged into core
> > repo, ok to drop it
> > * dubbo-serialization-native-hessian, maintained by Ian Luo, our PPMC
> > * dubbo-rpc-jms, maintained by Kimm King, our committer
> > * dubbo-rpc-xmlrpc, maintained by Kimm King, our committer
> >
> > ### Multiple-language SDK
> >
> > Most of the projects are maintained by external developers, I am not
> > quite sure how we can deal with them, maybe we need to discussed with
> > them, about whether we want to donate code to ASF.
> >
> > They are:
> > * dubbo-php-framework php client + server  This project has already
> > signed SGA to donate to ASF
> > * dubbo2.js Node.js client
> > * dubbo-client-py python client
> > * egg-dubbo-rpc dubbo rpc plugin for egg Node.js framework
> > * dubbo-remoting-js dubbo protocol implementation of egg Node.js framwork
> >
> > There are also 2 Node.js implementations, are they going to be merged
> > or not? That's another question.
> >
> > ### Integration
> >
> > * dubbo-sentinel-support provides sentinel support, maintained by
> > * dubbo-kubernetes  provides kubernates support, still work in
> > progress, maintained by our committer Jeff Lv
> > * dubbo-integration empty project, not quite sure what it does, we can
> > leave it there
> > * dubbo-spring-cloud-project empty project, it can be dropped
> >
> > ### Tools & Others
> >
> > * initializr forked from Spring initializr, should be no IP issues, I
> > think we can leave it there
> > * dubbo-spring-boot-demo This can be merge into dubbo-samples
> > * dubbo-benchmark benchmark project, maintained by Ian Luo, our PPMC,
> > I think we can move to Apache
> > * dubbo-logo logo files, suggest to move to ASF
> > * jmeter-plugins-dubbo, should be no IP issues, I think we can leave it
> there
> > * hessian-lite, a modified version of hessian separated from the core
> > repository, suggest to move to ASF as a standalone project
> >
> > How do you folks think?
> >
> > [1] https://github.com/dubbo
> >
> > --
> > Best Regards！
> > Huxing
>
>
>
> --
> Best Regards！
> Huxing
>

Re: Propose to add [End User Discussion] in Dubbo Guangzhou Meetup

[yuhang xiu]

Hi,

I have participated in the meetup of hangzhou, we have a questioning
session in the gap between each topic. When I participated in the meetup,
many people were very active, and many people in each questioning session
wanted to ask questions. But in general, in order to control the time of
the meetup, the chances of asking questions are limited. For those who want
to ask questions but have no chance, I think it makes sense to collect them
for discussion.

As for the results of the discussion, I personally feel that we need to
summarize, especially the recommended part, which is very important, from
dubbo's design to coding specifications, any suggestions are wanted.

Finally, the discussion session should not be a Q&A session. We should need
to control the whole process, it is best not to become a participant to ask
questions, only PMCs or committer answers. A more open environment is
better.

Mercy Ma  于2019年1月14日周一 下午5:22写道：

> Hi,
>
> > Another way is just using Random selection for fairness.
>
> I think this meetup very close to us, and suggest we can choose the most
> active attendees whose number may be between 10 to 20 approximately.
>
> Kind regards,
> Mercy
>
> On Mon, Jan 14, 2019 at 4:29 PM Huxing Zhang  wrote:
>
> > Hi,
> >
> > On Mon, Jan 14, 2019 at 2:37 PM chenwei qi 
> wrote:
> > >
> > > Hi guys,
> > >
> > >
> > > Normally there will be about 200-300 attendees at Dubbo Meetup. Despite
> > the
> > > fact that we have Q&A during each session, we have very limited two-way
> > > communication between the attendees and the Dubbo Community.
> >
> > I've been to the Hangzhou meetup before, I feel that in such a place
> > with so many people there, it is very difficult to collect requirement
> > to users.
> >
> > >
> > >
> > > Do you think we can have an [End User Discussion] at Guangzhou Meetup,
> so
> > > we can have deeper communication and get more feedback from Dubbo
> users?
> >
> > +1
> >
> > We need a place where we can have talk deeply with the users, like:
> > - How they use Dubbo
> > - What problems did they face
> > - What should be improved for Dubbo
> > - How to integrate Dubbo with other micro-service components
> >
> > The question here are:
> >
> > - how long will it be?
> > I think 1-2 hours looks good to me.
> > - how many user should be invited?
> > I think 20-30 people is enough, as you proposed before.
> > - who will be talking to the users?
> > I am suggesting the PMCs/committers, and other presenters that present
> > at this meetup, plus the event organizers (If they wish to)
> > Please count me in.
> > - how to choose such users?
> > From the information provided by user registration[1](this form should
> > be discussed on the list next time), what I can think is:
> > a) the daily average Dubbo RPC invocations in production system in
> > their company.
> > We may choose from different scales, small scale, middle scale, large
> > scale, each represents a layer of users
> > b) how long are they using Dubbo?
> > We may choose from fresh users, senior users, expertise, etc.
> > - how to notify them?
> > SMS, email?
> >
> > Please add your expected criteria as well.
> >
> > Another way is just using Random selection for fairness.
> >
> > How do others think?
> >
> > We need to make the decision ASAP since it is very close to the event.
> >
> >
> > [1] http://www.huodongxing.com/event/8472393517111
> >
> > >
> > >
> > > Yours,
> > >
> > > Baike
> >
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

[yuhang xiu]

hi, @jun alpha

I agree.
If netty can do more precise heartbeat control, we can integrate its design
in our heartbeat. Would you like to try it?

Jun Alpha  于2019年1月9日周三 下午9:21写道：

> Hi,I left a comment in this issue[1],I think it's worth to learn from
> netty's heartbeat mechanism.
>
> [1]  https://github.com/apache/incubator-dubbo/issues/3151
>
> Ian Luo  于2019年1月7日周一 下午10:47写道：
>
> > Thanks
> >
> > On Mon, Jan 7, 2019 at 2:50 PM yuhang xiu  wrote:
> >
> > > Hi, I left some comments in this issue[1]
> > >
> > > Thanks to beiwei for reminding. I forgot that we have some non-netty
> > > servers. In this case, I personally prefer all heartbeats to use the
> same
> > > set of mechanisms to guarantee. But we can learn from netty's heartbeat
> > > mechanism to ensure more accurate heartbeat control.
> > >
> > > [1] https://github.com/apache/incubator-dubbo/issues/3151
> > >
> > > Ian Luo  于2019年1月7日周一 下午1:09写道：
> > >
> > > > It is an interesting topic. It is worthy to give it a try when Dubbo
> > uses
> > > > Netty, but pls. keep in mind that Dubbo has the ability to use other
> > > > servers. I am not sure whether this suggestion will introduce
> > unnecessary
> > > > complexity.
> > > >
> > > > JingFeng, would you mind to file an issue and give it a try if you
> have
> > > > time?
> > > >
> > > > Thanks,
> > > > -Ian.
> > > >
> > > >
> > > > On Mon, Jan 7, 2019 at 11:03 AM 徐靖峰 <250577...@qq.com> wrote:
> > > >
> > > > > Hi all
> > > > >
> > > > > 现状：
> > > > >
> > > > > Dubbo
> > > > >
> > > >
> > >
> >
> 在应用层面发送心跳包保证连接的可用性，使用了定时器的设计，在客户端和服务端分别设置一个定时器，发送心跳，当发现连接断开时，客户端负责重连，服务端负责
> > > > > close。使用定时器并不是一个好的设计，在忙通信时，心跳是不必要的。建议使用 Netty 的
> > > > > IdleStateHandler，仅仅在检测到空闲连接时发送心跳。
> > > > >
> > > > > 修改建议：
> > > > >
> > > > > 使用 IdleStateHandler 代替 Timer 发送心跳
> > > > > 关闭 ChannelOption.SO_KEEPALIVE，网络层面的 TCP 断连需要在机器级别设置，默认是 2
> > > > > 小时，几乎没有必要存在，却发出了无必要的 TCP 探测包，仅仅依赖于应用层的心跳来给连接保活即可。
> > > > > For now:
> > > > >
> > > > > Dubbo sends a heartbeat packet at the application level to ensure
> the
> > > > > availability of the connection. A timer is set on the client and
> the
> > > > server
> > > > > to send a heartbeat. When the connection is found to be
> disconnected,
> > > the
> > > > > client is responsible for reconnection and the server is
> responsible
> > > for
> > > > > close. Using a timer is not a good design, and the heartbeat is
> > > > unnecessary
> > > > > when communicating busy. It is recommended to use Netty's
> > > > IdleStateHandler
> > > > > to send a heartbeat only when an idle connection is detected.
> > > > >
> > > > > Proposed changes:
> > > > >
> > > > > Send heartbeats using IdleStateHandler instead of Timer
> > > > > Close ChannelOption.SO_KEEPALIVE, TCP disconnection at the network
> > > level
> > > > > needs to be set at the machine level. The default is 2 hours. There
> > is
> > > > > almost no need to exist, but an unnecessary TCP probe packet is
> > issued.
> > > > It
> > > > > only depends on the heartbeat of the application layer to keep the
> > > > > connection alive. Just fine.
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: About Issue 3038

[yuhang xiu]

Hi, @guodong

Seems like we have a same issue[1] submitted by @yiji
Pls check and close your issue if these two issues are with the same thing.
If necessary, we can reopen the old one to discuss.

[1] https://github.com/apache/incubator-dubbo/issues/2766

Guodong  于2019年1月9日周三 下午5:23写道：

> Ok! @beiwei30 pls look it
> https://github.com/apache/incubator-dubbo/issues/3177
>
> Ian Luo  于2019年1月9日周三 下午4:26写道：
>
> > Guodong,
> >
> > Would you mind to file an issue against your findings and suggestions?
> You
> > could either assign it to me (@beiwei30) or Zhen (@LiZhenNet).
> >
> > Thanks,
> > -Ian.
> >
> >
> >
> > On Wed, Jan 9, 2019 at 12:01 PM zgd  wrote:
> >
> > > 建议：
> > > 当存在重载方法时：
> > > 1、如果重载方法参数长度不同，则可以正常匹配
> > > 2、当存在重载方法参数长度相同时，给用户提示，必须传入class参数
> > > Google Translation:
> > > Suggest:
> > > When there is an overloaded method:
> > > As shown in Figure 1, if the overload method parameters have different
> > > lengths, they can match normally.
> > > 2, when there are overloaded method parameters with the same length,
> > prompt
> > > the user, you must pass in the class parameters
> > >
> > > 章国东  于2019年1月9日周三 上午11:48写道：
> > >
> > > > 新版本还是有问题，在没有传递class参数时，重载还是会调错方法
> > > > ((JSONObject) arg).toJavaObject(type);
> > > > 这句话不管属性是否匹配，都能转换成功，没有太大的意义。
> > > > 我在DemoService添加一个方法
> > > > String getPerson(Yee yee);
> > > >
> > > > public class Yee implements Serializable {
> > > > private String address;
> > > >
> > > > public String getAddress() {
> > > > return address;
> > > > }
> > > >
> > > > public void setAddress(String address) {
> > > > this.address = address;
> > > > }
> > > > }
> > > >
> > > > UT:
> > > > @Test
> > > > public void testInvokeMultiJsonParamMethod2() throws
> > > RemotingException
> > > > {
> > > > mockChannel = mock(Channel.class);
> > > >
> > >  given(mockChannel.getAttribute("telnet.service")).willReturn(null);
> > > >
> > > > given(mockChannel.getLocalAddress()).willReturn(NetUtils.toAddress("
> > > > 127.0.0.1:"));
> > > >
> > > > given(mockChannel.getRemoteAddress()).willReturn(NetUtils.toAddress("
> > > > 127.0.0.1:20886"));
> > > >
> > > > ProviderModel providerModel = new
> > > >
> > ProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService",
> > > > new DemoServiceImpl(), DemoService.class);
> > > >
> > > >
> > >
> >
> ApplicationModel.initProviderModel("org.apache.dubbo.rpc.protocol.dubbo.support.DemoService",
> > > > providerModel);
> > > > String param = "{\"address\":\"Dubbo\"}";
> > > > String result = invoke.telnet(mockChannel, "getPerson(" +
> > param +
> > > > ")");
> > > > assertTrue(result.contains("result: \"Dubbo"));
> > > > }
> > > > 无法测试成功，他会调用String getPerson(Man man);方法
> > > >
> > > > LiZhenNet  于2019年1月9日周三 上午11:24写道：
> > > >
> > > >> Yes ，I have added UT to cover this。
> > > >>
> > > >> Ian Luo  于2019年1月9日周三 上午10:57写道：
> > > >>
> > > >> > I see. I have not considered the overridden scenario carefully.
> > Thanks
> > > >> for
> > > >> > your clarification. BTW, do we have the corresponding unit test to
> > > cover
> > > >> > this?
> > > >> >
> > > >> > Thanks,
> > > >> > -Ian.
> > > >> >
> > > >> >
> > > >> > On Tue, Jan 8, 2019 at 5:50 PM LiZhenNet 
> > > wrote:
> > > >> >
> > > >> > > @beiwei30
> > > >> > >
> > > >> > > I think your suggestion maybe not right, I have added a comment
> > > >> ，please
> > > >> > > take a  look.
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>

Re: issue for aync invoke

[yuhang xiu]

agree. Maybe I didn't fully understand what he meant before.
The way dubbo's current filter does depend on the user's understanding of
the new asynchronous approach.

By the way, when I just checked the code, I suspect that our TimeoutFilter
might not work properly in an asynchronous scenario, @jun liu, would you
like to check it out?
I have submitted a pr[1] to try to fix it, please let me know if there is a
problem with my understanding.

[1] https://github.com/apache/incubator-dubbo/pull/3174

jun liu  于2019年1月9日周三 上午11:11写道：

> Hi, Yuneng
>
> Thanks for reporting.
>
> > for async invoke :
> > i get a default value of the specific return type when i access result
> > value through Result.getValue before.
> > but now i would block and get the real value from the server.
>
> I noticed the same issue you raised yesterday on Github. I think it’s a
> bug that we should fix before 2.7.0 release, we cannot expect all legacy
> Filters reimplemented in the new async way, they may exist and work
> together for a really long time at the same time. I will take care of this
> issue.
>
> By the way, we have been discussing about the defects of current async
> implementation and possible solutions[1][2], it would be great if you can
> shine your great thoughts on it.
>
> 1. https://github.com/apache/incubator-dubbo/pull/3095 <
> https://github.com/apache/incubator-dubbo/pull/3095>
> 2. https://github.com/apache/incubator-dubbo/issues/3113
>
> Jun
>
> > On Jan 8, 2019, at 6:02 PM, yuneng xie  wrote:
> >
> > Hi All,
> > i noticed that we got some great "async feature" introduced in , and
> also i
> > observed different behavior when i invoke in async way.
> >
> > for async invoke :
> > i get a default value of the specific return type when i access result
> > value through Result.getValue before.
> > but now i would block and get the real value from the server.
> >
> > is this desired or a bug?
>
>

Re: [Proposal] A proposal to use IdleStateHandler to replace using Timer to send HeartBeat.

[yuhang xiu]

Hi, I left some comments in this issue[1]

Thanks to beiwei for reminding. I forgot that we have some non-netty
servers. In this case, I personally prefer all heartbeats to use the same
set of mechanisms to guarantee. But we can learn from netty's heartbeat
mechanism to ensure more accurate heartbeat control.

[1] https://github.com/apache/incubator-dubbo/issues/3151

Ian Luo  于2019年1月7日周一 下午1:09写道：

> It is an interesting topic. It is worthy to give it a try when Dubbo uses
> Netty, but pls. keep in mind that Dubbo has the ability to use other
> servers. I am not sure whether this suggestion will introduce unnecessary
> complexity.
>
> JingFeng, would you mind to file an issue and give it a try if you have
> time?
>
> Thanks,
> -Ian.
>
>
> On Mon, Jan 7, 2019 at 11:03 AM 徐靖峰 <250577...@qq.com> wrote:
>
> > Hi all
> >
> > 现状：
> >
> > Dubbo
> >
> 在应用层面发送心跳包保证连接的可用性，使用了定时器的设计，在客户端和服务端分别设置一个定时器，发送心跳，当发现连接断开时，客户端负责重连，服务端负责
> > close。使用定时器并不是一个好的设计，在忙通信时，心跳是不必要的。建议使用 Netty 的
> > IdleStateHandler，仅仅在检测到空闲连接时发送心跳。
> >
> > 修改建议：
> >
> > 使用 IdleStateHandler 代替 Timer 发送心跳
> > 关闭 ChannelOption.SO_KEEPALIVE，网络层面的 TCP 断连需要在机器级别设置，默认是 2
> > 小时，几乎没有必要存在，却发出了无必要的 TCP 探测包，仅仅依赖于应用层的心跳来给连接保活即可。
> > For now:
> >
> > Dubbo sends a heartbeat packet at the application level to ensure the
> > availability of the connection. A timer is set on the client and the
> server
> > to send a heartbeat. When the connection is found to be disconnected, the
> > client is responsible for reconnection and the server is responsible for
> > close. Using a timer is not a good design, and the heartbeat is
> unnecessary
> > when communicating busy. It is recommended to use Netty's
> IdleStateHandler
> > to send a heartbeat only when an idle connection is detected.
> >
> > Proposed changes:
> >
> > Send heartbeats using IdleStateHandler instead of Timer
> > Close ChannelOption.SO_KEEPALIVE, TCP disconnection at the network level
> > needs to be set at the machine level. The default is 2 hours. There is
> > almost no need to exist, but an unnecessary TCP probe packet is issued.
> It
> > only depends on the heartbeat of the application layer to keep the
> > connection alive. Just fine.
> >
> >
>

Re: slow on pull request and issue

[yuhang xiu]

Hi, all

Recently we have completed the phased tasks and I will have more time to
continue our community work.

Working on this now:
https://github.com/apache/incubator-dubbo/pull/3090

LiZhenNet  于2019年1月3日周四 下午6:33写道：

> I agree ， Currently the community relies on the committer from  alibaba
>
>
> Huxing Zhang  于2019年1月3日周四 上午11:27写道：
>
> > Hi,
> >
> > I've noticed that the response time is slow for Dubbo's core
> > repository, including reviewing pull request, issue triage and issue
> > cleanup, it seems that not everyone has enough time to deal with
> > things like this.
> >
> > My idea is to identify the active contributors of the community, and
> > invite to become a committer, let more people come in and help. In
> > addition, we should also use robot to help us.
> >
> > The problem is how to find such people, I think it can be collected by
> > the data, such as GitHub activities, how often do they participate in
> > the discussion, how often do they participate in the review code.
> >
> > Furthermore, I think that people who often send pull requests, and
> > those who often participate in the community, may be two types of
> > people. The former requires large amount of  time, and the latter can
> > participate using their fragmented time.
> >
> > For example, if I want to send a pr, I need to understand an issue,
> > fix, test, which takes a lot of time. However,  leaving a message on
> > the issue, labelling an issue, or closing the issue, these tasks can
> > be done small granularity.
> >
> > Maybe we know a lot about the first type of people, but we need to
> > identify and discover the second type of people and let them come in
> > to help manage the community.
> >
> >
> >
> >
> 最近Dubbo的仓库，响应比较慢，包括pr的review，issue的分类和清理，似乎没有人处理。我的想法是发展一部分活跃的contributor成为committer，让更多的人参与进来一起帮忙。另外机器人也要参与进来。现在的问题是要找到这样的人，我觉得可以通过数据反映出来，比如GitHub上经常参加讨论的，经常参与review代码的。
> >
> > 另外我觉得经常提pull request的人，和经常参与社区的人，可能是两类人，前者对时间的的颗粒度要求很高，后者对时间颗粒度的要求度低。
> >
> > 比如我要提一个pr，需要理解一个issue,
> > 修复，测试，需要花较大的时间，而在issue上留个言，打个label，close下issue，对时间的要求相对较低。
> >
> > 我们对第一类人的了解是比较多的，但需要识别和发现第二类人，让他们进来帮助管理社区。
> >
> > On Sat, Dec 29, 2018 at 5:13 PM Ian Luo  wrote:
> > >
> > > Hello folks,
> > >
> > > I'd like to apologize first since recently we are slow on issue and
> pull
> > > request. We are very busy on ramping up Dubbo 2.7.0 which is expected
> to
> > be
> > > public available soon. I hope we could come back in one or two weeks so
> > > depending on how soon we could finish. The code review for dubbo 2.7.0
> > > release is happening now on Github pull request. Feel free to join us
> to
> > > raise issue or submit pull request against the recent code changes on
> the
> > > master branch.
> > >
> > > You are also very welcomed to interact on other issues and pull
> requests
> > > irrelevant to release 2.7.0. They are piling up and we can do nothing
> > right
> > > now :)
> > >
> > > I really hope we can ramp up release 2.7.0 very soon, and your
> > > comments/efforts are appreciated. After that, I plan to continue the
> > > discussion on release 3.0.
> > >
> > > Cheers,
> > > -Ian.
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: slow on pull request and issue

[yuhang xiu]

Hi, community
I personally encountered problems similar to @beiwei.
Before New Year's Day, I had a lot of work to do. There is not much time in
the last week to solve problems in the community.

My work will start to be easier next week, and I will fix it next week:
1. doc related pr @majinkai
2. @khan's related PR about AccessLogFilter.
3. Some code review for 2.7.0


Ian Luo  于2018年12月29日周六 下午5:13写道：

> Hello folks,
>
> I'd like to apologize first since recently we are slow on issue and pull
> request. We are very busy on ramping up Dubbo 2.7.0 which is expected to be
> public available soon. I hope we could come back in one or two weeks so
> depending on how soon we could finish. The code review for dubbo 2.7.0
> release is happening now on Github pull request. Feel free to join us to
> raise issue or submit pull request against the recent code changes on the
> master branch.
>
> You are also very welcomed to interact on other issues and pull requests
> irrelevant to release 2.7.0. They are piling up and we can do nothing right
> now :)
>
> I really hope we can ramp up release 2.7.0 very soon, and your
> comments/efforts are appreciated. After that, I plan to continue the
> discussion on release 3.0.
>
> Cheers,
> -Ian.
>

Re: AccessLogFilter simple date format instance creation change PR

[yuhang xiu]

Hi, @beiwei @khan

There have been a lot of things in recent work.
After the end of New Year's Day, I believe that there will be more time to
work in the community, I am very sorry.

I will dispose of this PR next week. @khan
:)

Ian Luo  于2018年12月29日周六 上午11:14写道：

> I took a glance at the latest change. It looks good to me since we avoid of
> using thread-local and new instance for every incoming request, instead one
> singleton date formatter runs in one single thread, which I totally agree
> with.
>
> Let's wait for Yuhang's review comments :)
>
> -Ian.
>
>
> On Sat, Dec 29, 2018 at 12:11 AM Imteyaz Khan 
> wrote:
>
> > Due to my own confusion and bad I found I found my PR is containing more
> > commits and more file modification other than mine. So avoid the
> confusion
> > I created new PR and close the old one. This PR containing the all the
> > review comments from old PR. Please review mine this PR
> > <https://github.com/apache/incubator-dubbo/pull/3090>
> >
> >
> > https://github.com/apache/incubator-dubbo/pull/3090
> >
> > Sorry for the inconvenience caused.
> >
> >
> > On Thu, Dec 27, 2018 at 3:24 PM yuhang xiu  wrote:
> >
> > > Hi,
> > >
> > > I simply checked your pr and I agree with you. I will review it.
> > > Nice work!
> > >
> > > Imteyaz Khan  于2018年12月27日周四 下午5:35写道：
> > >
> > > > Hi All,
> > > >   I have raised a separate PR for the same issue 3026.
> > > >
> > > > https://github.com/apache/incubator-dubbo/pull/3080
> > > >
> > > > As my old PR was containing may commits of others and reviewer would
> > like
> > > > me to clear those commits and I tried hard to achieve the same but
> > failed
> > > > so landed up creating new PR
> > > > <https://github.com/apache/incubator-dubbo/pull/3080>.
> > > >
> > > > Please note :: older PR
> > > > <https://github.com/apache/incubator-dubbo/pull/3027> 3027 has been
> > > closed
> > > > but all the comments are applicable here.
> > > >
> > > > On Thu, Dec 20, 2018 at 5:35 PM Imteyaz Khan  >
> > > > wrote:
> > > >
> > > > > Hi All,
> > > > >   I have raised a PR <
> > > > https://github.com/apache/incubator-dubbo/pull/3027>for
> > > > > issue 3026 <https://github.com/apache/incubator-dubbo/issues/3026
> >.
> > In
> > > > > this PR , I am reducing the  number of SimpleDateFormat object
> > creation
> > > > > from each log message to per thread wise and reusing it. Please
> > review
> > > > it.
> > > > >
> > > > > https://github.com/apache/incubator-dubbo/pull/3027
> > > > >
> > > >
> > >
> >
>

Re: AccessLogFilter simple date format instance creation change PR

[yuhang xiu]

Hi,

I simply checked your pr and I agree with you. I will review it.
Nice work!

Imteyaz Khan  于2018年12月27日周四 下午5:35写道：

> Hi All,
>   I have raised a separate PR for the same issue 3026.
>
> https://github.com/apache/incubator-dubbo/pull/3080
>
> As my old PR was containing may commits of others and reviewer would like
> me to clear those commits and I tried hard to achieve the same but failed
> so landed up creating new PR
> .
>
> Please note :: older PR
>  3027 has been closed
> but all the comments are applicable here.
>
> On Thu, Dec 20, 2018 at 5:35 PM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >   I have raised a PR <
> https://github.com/apache/incubator-dubbo/pull/3027>for
> > issue 3026 . In
> > this PR , I am reducing the  number of SimpleDateFormat object creation
> > from each log message to per thread wise and reusing it. Please review
> it.
> >
> > https://github.com/apache/incubator-dubbo/pull/3027
> >
>

[DISCUSS] We need more advice about pr 2964

[yuhang xiu]

Hi, all

Recently I found a pr about repairing issue 2881[1] submitted by @cvictory.
Currently due to the merger of dubbox, dubbo has the ability to register
classes to kryo(fst) at startup. In a distributed scenario, kryo's
serialization approach can cause problems. @cvictory is currently
submitting a solution[2] to fix this problem, which I personally think is a
very good way, but we need more advice.

Anyone willing to help review it?

[1] https://github.com/apache/incubator-dubbo/issues/2881
[2] https://github.com/apache/incubator-dubbo/pull/2964

Re: [DISCUSSION] Call for ideas and suggestions on v2.7.0 designs and implementations.

[yuhang xiu]

Hi, all

I also found out that the master ci has failed.
This caused some misunderstanding for me to deal with a pending pr[1].
After observing the log, I found that the issue[2] with @xin wang feedback
is the same problem.
Since the ci of the module of the cluster has passed and the code is well,
I will merge the pr first.

[1] https://github.com/apache/incubator-dubbo/pull/2822
[2] https://github.com/apache/incubator-dubbo/issues/3052

jun liu  于2018年12月24日周一 下午5:27写道：

> > Now the travis ci of master branch faile， I create an issue
> > https://github.com/apache/incubator-dubbo/issues/3052
> > Please take a look at it
>
> Thanks, I noticed too, I’ll take care of it.
>
> Jun
>
> > On Dec 24, 2018, at 5:25 PM, Xin Wang  wrote:
> >
> > hi, Jun
> >
> > Now the travis ci of master branch faile， I create an issue
> > https://github.com/apache/incubator-dubbo/issues/3052
> > Please take a look at it
> >
> > Xin Wang  于2018年12月24日周一 下午4:38写道：
> >
> >>> I have just merged dev-metadata branch into master, from now on, the
> >> master branch will work as the develop and release codebase of v2.7.0.
> >> Branch dev-metadata does not need to be kept anymore, I will delete
> >> dev-metadata later today if there’re no more PRs come to it.
> >>
> >> Great work, looking forward to the new features!
> >>
> >> jun liu  于2018年12月24日周一 下午4:33写道：
> >>
> >>> Hi, All
> >>>
> >>> I have just merged dev-metadata branch into master, from now on, the
> >>> master branch will work as the develop and release codebase of v2.7.0.
> >>> Branch dev-metadata does not need to be kept anymore, I will delete
> >>> dev-metadata later today if there’re no more PRs come to it.
> >>>
> >>> Jun
> >>>
>  On Dec 21, 2018, at 11:37 AM, jun liu  wrote:
> 
>  Two more things to mention:
> 
>  1. I am thinking of merge this dev-metadata branch back to the master.
> >>> Both these two branches have the same version 2.7.0-SNAPSHOT and they
> >>> together consist of v2.7’s release candidates. While they are evolving
> at
> >>> the same time concurrently, conflicts keep happening. I have been kept
> >>> merging the master branch to dev-metadata to try to avoid conflicts to
> the
> >>> most extend during the development of dev-metadata. Now, since the
> changes
> >>> in dev-metadata are stable enough, at least it won’t be a block for the
> >>> development in master (which is also the biggest concern why we created
> >>> this new branch), I think it’s time for us to merge the changes back
> and
> >>> work on the unified master branch.
> 
>  2. Is there any plan for the release of OPS? Most of the new features
> >>> introduced in v2.7 are service governance related abilities and most
> users
> >>> have get used to using Dubbo OPS to do interoperability with their
> Dubbo
> >>> services. Thus I think it would be great if an OPS version supporting
> these
> >>> features can be released at the same time as v2.7 or slightly after it
> .
>  @Minxuan @Majinkai, I know you guys are working on OPS project, any
> >>> news to update?
> 
>  Jun
> 
> > On Dec 21, 2018, at 10:35 AM, jun liu  >>> ken.lj...@gmail.com>> wrote:
> >
> >> 1. Prioritization of centralized configuration
> >
> > Now, the centralized configuration or externalized configuration is
> >>> implemented to has the highest priority by default. For flexible
> concerns,
> >>> a switch is designed and opened to users so that they can override the
> >>> default value, for example, you can use the following JVM property to
> give
> >>> centralized configuration a lower priority than the local one:
> >>> dubbo.configCenter.highestPriority=false.
> >
> >> 2. The logic of the route is more complicated, and the compatibility
> >>> with
> >> the original low version is guaranteed.
> >
> > When saying of complexity, I guess you mainly refer to the routing
> >>> module, because this module is one of the most evident parts that has
> >>> changed in this version and is also newly introduced. Its main purpose
> is
> >>> to improve the performance of the runtime. After all, there will be
> some
> >>> performance loss when routing is executed for address filtering every
> time
> >>> an RPC is executed.
> > However, I agree we should be really careful about this cache part
> >>> since it works as an crucial path on the RPC wire. Some possible
> drawbacks
> >>> I can come up with it now are: excessive resource usage, priority
> guarantee
> >>> of routers in chain, etc. I think we can discuss more about the
> technical
> >>> details of this part, give it more test and then decide whether to
> release
> >>> it this time or wait until it’s mature enough.
> >
> >> 3.Tag routing has been modified, how is the compatibility with the
> >>> original?
> >
> > It has full backward compatibility with the original implementation
> >>> with only the supporting of of DynamicConfiguration added.
> >
> >> 4. How does the Environmen

Re: about issues-2425

[yuhang xiu]

Hello, yeling,

I checked the code of the old version.
Since the current retry process will execute failed.remove(invocation);
anyway, this will cause our retry to be done only once. I think this is a
bug in the current failback.

I have given a few reviews about your pr. I need you to improve your ut
now, I don't think it is rigorous at the moment. The other parts I think
are correct. I will merge it after you perfect your ut.

This is your first pr, expecting you more PR. :)

你好，yeling，

我查看了老版本的代码。
由于目前重试过程之后，无论如何都会执行failed.remove(invocation);，这会导致我们的重试无论如何只会进行一次。我认为这是目前failback的一个bug。

关于你的pr，我已经给出了几次review。目前需要你完善一下你的ut，我认为目前并不严谨。其他的部分我认为是正确的。在你完善你的ut之后我会merge它。

这是你的第一个pr，期待你更多的PR。:)

yeling  于2018年12月21日周五 下午10:22写道：

> FailbackClusterInvoker should limit the size of failed invocations
> issues:https://github.com/apache/incubator-dubbo/issues/2425
>
>
> In the FailbackClusterInvoker class, the failed member variable does not
> control the size, which may cause memory leaks. When reading the source
> code, I found some problems:
>
> 1. When a timed task is executed, just one invoke request fails and is
> added directly to the queue. This will cause the newly failed task to
> execute immediately, which does not meet the previous expectations. In
> theory, the invoke request is executed once in five seconds.
>
> 2. The addFailed (Invocation invocation, AbstractCluster Invoker
> invoker) method passes in the Cluster itself.
>
> Look at some of the code for retry:
>try {
> invoker.invoke(invocation);
> failed.remove(invocation);
> } catch (Throwable e) {
> logger.error("Failed retry to invoke method " +
> invocation.getMethodName() + ", waiting again.", e);
> }
> Since invoker is Cluster here, the specific implementation here is Failback
> Cluster Invoker. Look at the doInvoke part of the code:
>
> protected Result doInvoke(Invocation invocation, List>
> invokers, LoadBalance loadbalance) throws RpcException {
> try {
> checkInvokers(invokers, invocation);
> Invoker invoker = select(loadbalance, invocation, invokers,
> null);
> return invoker.invoke(invocation);
> } catch (Throwable e) {
> logger.error("Failback to invoke method " +
> invocation.getMethodName() + ", wait for retry in background. Ignored
> exception: "+ e.getMessage() + ", ", e);
> addFailed(invocation, this);
> return new RpcResult(); // ignore
> }
> Obviously normally, there is a catch Throwable that is caught once and
> never goes into retry code. I understand that we don't want such a design.
>
> I have made some optimization and improvement on this.
> 1. Use the time wheel to solve the problem of task execution and ensure
> that the failed task is not executed immediately, but after 5 seconds.
> 2. Set the configurable number of failbackTasks tasks (default 100) and the
> number of retries (default 3)
> 3. The retry logic does not start with FailbackCluster Invoker, but follows
> the following strategy
>
> Invoker < T > retryInvoker = select (load balance, invocation, invokers,
> lastInvokers);
> RetryInvoker. invoke (invocation);
>
> test case:
> FailbackCluster InvokerTest. testRetryFailed
> I have submitted PR
> https://github.com/apache/incubator-dubbo/pull/2822
> 在FailbackClusterInvoker类中，成员变量failed没有控制容量，可能会引起内存泄露。在阅读源码时，发现有一些问题：
> 1.当定时任务在执行时，正好一个invoke请求失败，会直接加入到队列中，这会导致刚失败的任务会立即执行，不符合之前的预期，理论上的5秒执行一次。
> 2.addFailed(Invocation invocation, AbstractClusterInvoker
> invoker)方法传入的是Cluster本身。
> 看下重试的部分代码：
>   try {
> invoker.invoke(invocation);
> failed.remove(invocation);
> } catch (Throwable e) {
> logger.error("Failed retry to invoke method " +
> invocation.getMethodName() + ", waiting again.", e);
> }
>
> 由于invoker这里是Cluster，这里具体实现是FailbackClusterInvoker，看下doInvoke部分代码：
>  protected Result doInvoke(Invocation invocation, List>
> invokers, LoadBalance loadbalance) throws RpcException {
> try {
> checkInvokers(invokers, invocation);
> Invoker invoker = select(loadbalance, invocation, invokers,
> null);
> return invoker.invoke(invocation);
> } catch (Throwable e) {
> logger.error("Failback to invoke method " +
> invocation.getMethodName() + ", wait for retry in background. Ignored
> exception: "+ e.getMessage() + ", ", e);
> addFailed(invocation, this);
> return new RpcResult(); // ignore
> }
> 很明显正常情况下，是又一次被捕获异常，永远走不进重试代码中的catch Throwable，我的理解任务，这并不是想要这样的设计。
>
> 我对此做了一些优化和改造：
> 1.使用时间轮来解决任务执行的问题，确保失败的任务不是马上执行，而是5秒后；
> 2.设置可配置的failbackTasks任务数(默认100)和复用retries重试次数(默认3)
> 3.重试逻辑不从FailbackClusterInvoker开始执行，而是如下策略
> Invoker retryInvoker = select(loadbalance, invocation, invokers,
> lastInvokers);
> retryInvoker.invoke(invocation);
>
> 测试用例
> FailbackClusterInvokerTest.testRetryFailed
>

Re: [ANN] New PPMC member: Yuhang Xiu

[yuhang xiu]

Hi,

Thank u all.
:)

Huxing Zhang  于2018年12月20日周四 下午4:49写道：

> Congratulations!
>
> On Thu, Dec 20, 2018 at 4:37 PM Xin Wang  wrote:
> >
> > Hi Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Yuhang Xiu[1]
> > has been voted in as a new Dubbo PPMC member.
> >
> > Please join me to say congratulations to him!
> >
> > [1] https://github.com/carryxyh
> > --
> > Best Regards！
> >
> > Xin Wang
>
>
>
> --
> Best Regards！
> Huxing
>

Re: About the comments coverage of the code

[yuhang xiu]

Hi, huxing

I agree with what you said, we don't need to strictly follow some kind of
guidance.

But I think we need a very detailed doc. And this doc is based on code, and
may be more oriented to developers.
So we need to let them know the role of a class or a method clearly when we
only look at the doc.
I'd like take a look at these doc prs and give some suggestions.

Regarding the goal, I think we can increase the doc coverage rate to 45%
first, and increase the coverage by about 20% first.
:)

Huxing Zhang  于2018年12月20日周四 上午10:20写道：

> Hi，
>
> On Wed, Dec 19, 2018 at 8:48 PM yuhang xiu  wrote:
> >
> > Hi, all
> >
> > Recently I have seen a few pr about doc. Several of them have been
> merged.
> > I think we have two issues to discuss:
> > 1. What kind of comments should we add?
> > 2. We need to define a goal.
> >
> > Regarding question one, I personally think that we should:
> > 1. Explain each param of the method
> > 2. Explain the special usage of some classes. For example, when adding
> the
> > doc of SerializableClassRegistry, we need to doc that this class only
> works
> > when using fst and kryo serialization.
> > 3. We need to use @link or @code for the association when the class
> > (method) is associated with other classes (methods).
>
> Perhaps following some guide like [1] and [2]. But I don't think we
> should follow it strictly.
> If using IDE like Intellij IDEA, you can easily create customized
> Javadoc template[3], with some boilerplate content like params, return
> values.
>
> >
> > Regarding question two, I don't have a idea. Perhaps doc coverage is 40%
> is
> > a good choice. What do you think?
>
> Do you mean the average doc coverage,  acoording to [4], I see there
> is an average of 28.8% java coverage, setting the goal of average
> coverage to 40%~50% looks good to me. We can do it step by step :)
>
> [1] https://www.baeldung.com/javadoc
> [2]
> https://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide
> [3]
> https://stackoverflow.com/questions/17607925/how-configure-intellij-idea-javadoc-templates
> [4] https://github.com/apache/incubator-dubbo/issues/2884
>
> >
> >
> > yuhang xiu  于2018年12月18日周二 下午4:21写道：
> >
> > > Hello, Dave.
> > >
> > > (2) Have any committers reached out to the users who had trouble with
> code
> > >> comments to confirm these efforts will meet their concerns?
> > >>
> > >
> > > I used to talk to them, but I forgot to ask them about what kind of
> docs
> > > are better.
> > >
> > > But don't worry, I still have their contact details.
> > > I will communicate with them and hope that they will bring their
> opinions
> > > here to better work for developers who add comments.
> > >
>
>
>
> --
> Best Regards！
> Huxing
>

Re: About Router:Version compatibility issues below JDK1.8

[yuhang xiu]

The code on the master only supports jdk1.8 and above.
So this does not cause compatibility issues.
:)

雷舜宇  于2018年12月20日周四 上午10:13写道：

> Previously submitted a PR, modified the compatibility of the Router's sort.
> Before the merge, the committer discussed the default method of adding
> jdk1.8 to the Router Interface. Is this a compatibility issue with the
> lower version of JDK? What do you think?
>
> 之前提交了一个PR,修改了Router的sort的兼容性问题,合并前跟commiter讨论了下将Router
> Interface中添加了jdk1.8的default method,这样是否会低版本JDK的兼容问题?你们怎么看呢
>

Re: About the comments coverage of the code

[yuhang xiu]

Hi, all

Recently I have seen a few pr about doc. Several of them have been merged.
I think we have two issues to discuss:
1. What kind of comments should we add?
2. We need to define a goal.

Regarding question one, I personally think that we should:
1. Explain each param of the method
2. Explain the special usage of some classes. For example, when adding the
doc of SerializableClassRegistry, we need to doc that this class only works
when using fst and kryo serialization.
3. We need to use @link or @code for the association when the class
(method) is associated with other classes (methods).

Regarding question two, I don't have a idea. Perhaps doc coverage is 40% is
a good choice. What do you think?


yuhang xiu  于2018年12月18日周二 下午4:21写道：

> Hello, Dave.
>
> (2) Have any committers reached out to the users who had trouble with code
>> comments to confirm these efforts will meet their concerns?
>>
>
> I used to talk to them, but I forgot to ask them about what kind of docs
> are better.
>
> But don't worry, I still have their contact details.
> I will communicate with them and hope that they will bring their opinions
> here to better work for developers who add comments.
>

Re: The issues of [Enhance the test coverage] project are here waiting for you

[yuhang xiu]

It’s great.

It seems that we have reached the goal and I agree to close the project.

Xin Wang  于2018年12月19日周三 下午8:23写道：

> Hi all
> It's been a long time since I started this project. I am very
> pleased to announce that the test coverage of Dubbo is now 64%.
> We have achieved the goal of stage 1: unit test coverage > 60%.
>
> A lot of people submitted prs, the contributors and the number of their prs
> are as follows:
>
>YunKun Huang (@htynkn) 5
>Ian Luo (@beiwei30) 3
>Kimm King (@kimming)   2
>Xin Wang (@lovepoem) 1
>Zonghai Shang (@zonghaishang) 1
>Song Kun   (@satansk)1
>xialongfei (@stoneapple) 1
>钟剑 (@DeadLion)1
>Yang Tao(@whanice)   1
>Qin Yulin (@qinnnyul)  1
>Yong Zhu (diecui1202) 1
>
>Thank you very much for your contribution.
> Now there are two issues( issues 1690 [1] and  issue 1692 [2] )  left , and
> then the project will be completed. If anybody want to take part in, please
> leave a message on these issues?
> Thank you !
>
> [1] https://github.com/apache/incubator-dubbo/issues/1690
> [2] https://github.com/apache/incubator-dubbo/issues/1692
>
> Xin Wang  于2018年4月27日周五 上午10:24写道：
>
> > Hi,all
> >   In order to enhance the test coverage, now the project is started:
> > https://github.com/apache/incubator-dubbo/projects/1,
> > you can also see the related issues in the other entrance page:
> > https://github.com/apache/incubator-dubbo/issues/1702
> >   The test coverage guide is here:
> > https://github.com/apache/incubator-dubbo/wiki/Test-coverage-guide
> >
> >   Welcome everyone to join in，you can comment on the issue that
> you're
> > interest with.
> >
> > Xin Wang
> > lovep...@hotmail.com
> >
> >
> >
> >
>

Re: Use longObjectMap to increase performance

[yuhang xiu]

Hi, @jing feng

I think we can do a test with the implementation of netty as an example.
There is an IntObjectHashMapBenchmark in netty, @jing feng Can you help me
to see the specific implementation and effect?

I certainly agree with what you said, staying the same before the
investigation, which is why we did not start submitting pr or modifying the
code.

Regarding the two scenarios you said, I personally think that we will
discuss it after we have finished the test. Thank you very much for your
advice on how to do benchmarking. I think you can discuss it with @stormyu
here and improve the benchmark.

And after that, we will discuss which maps we can replace and need to
replace.


徐靖峰 <250577...@qq.com> 于2018年12月19日周三 上午11:19写道：

>
> LongObjectHashMap and IntObjectHashMap 无论是 netty 的实现还是像 JCtool, hppc
> 这样实现，据我所知，并不是为了快而诞生的，他们突出的一个特性是相比 HashMap 节约了内存的使用量，并且可能在解决 Hash 冲突方面做了一些优化，
>
> > A hash map implementation of LongObjectMap <
> https://netty.io/4.1/api/io/netty/util/collection/LongObjectMap.html>
> that uses open addressing for keys. To minimize the memory footprint, this
> class uses open addressing rather than chaining. Collisions are resolved
> using linear probing. Deletions implement compaction, so cost of remove can
> approach O(N) for full maps, which makes a small loadFactor recommended.
>
> 线性探测和链表的方式解决 Hash 冲突其实本质上是一种 trade off，在不同场景下可以说各有优势，但在实际使用场景下，比如
> Dubbo，这两者的差距我觉得很难考量，或者请允许我猜测，他们的差距是微乎其微的。我个人建议是负责测试同学不能仅仅评测单机下的
> micro-benchmark ，而是要在实际场景中测试两者的差距，包括 qps
> 和内存使用量，这工作我觉得是很大的。毕竟我们引入了第三方的依赖，需要有足够的数据佐证这样的改动是有意义的，否则，我在 benchmark
> 之前，会认为这样的 trade off 是我倾向于保持原样，使用原有的 HashMap。
>
> 1. Dubbo 场景中大量的 Map，这里的 Long 主要是 requestId，在并发请求中，需要快速 put,
> get , remove ，应该还是需要 focus 在并发性能方面，而非内存占用，所以 synchronized LongObjectHashMap
> 意义不是很大。
> 2. 数据需要长期存在于内存中的场景，LongObjectHashMap 有其存在的意义，例如 dubbo
> 的一些服务元数据，方法信息等等，他们不需要频繁变更，却需要长期占据内存，这比较适合使用新增的 Map 数据结构。
>
> 我的观点是主要围绕上述两点去展开工作。
>
> 另外，如果想要替换 ConcurrentHashMap，可以测评下 JCtools 的并发 Map，据称是比 jdk 更强。
>
> Last, 这样的 issue 非常有意义，我会持续跟进
> 
>
> English：pls copy the above Chinese issue to google translation ，forgive my
> laziness, hhh.
>
> > 在 2018年12月19日，上午11:04，yuhang xiu  写道：
> >
> > Hi, jingfeng,
> >
> > I think we should have a benchmark about the sync long object map and
> > concurrent map.
> > Personally think the concurrent map is better, but we should have a
> > benchmark about this two cases.
> >
> > Another thing, maybe my description is problematic, we are going to
> replace
> > longobjectmap and other maps such as intobjectmap. Not just
> longobjectmap.
> > There also has some intobjectmap in dubbo.
> > After the performance, @stormyu will give us that which map can be
> replaced.
> >
> > And the longobjectmap and intobjectmap has many impls (not just in
> netty).
> > Could u give some ideas about this?
>
>

Re: Use longObjectMap to increase performance

[yuhang xiu]

Hi, jingfeng,

I think we should have a benchmark about the sync long object map and
concurrent map.
Personally think the concurrent map is better, but we should have a
benchmark about this two cases.

Another thing, maybe my description is problematic, we are going to replace
longobjectmap and other maps such as intobjectmap. Not just longobjectmap.
There also has some intobjectmap in dubbo.
After the performance, @stormyu will give us that which map can be replaced.

And the longobjectmap and intobjectmap has many impls (not just in netty).
Could u give some ideas about this?

Re: About the comments coverage of the code

[yuhang xiu]

Hello, Dave.

(2) Have any committers reached out to the users who had trouble with code
> comments to confirm these efforts will meet their concerns?
>

I used to talk to them, but I forgot to ask them about what kind of docs
are better.

But don't worry, I still have their contact details.
I will communicate with them and hope that they will bring their opinions
here to better work for developers who add comments.

Re: About the comments coverage of the code

[yuhang xiu]

Hi, all
I have now divided the work according to the module, and have established
the issue,
their number is from https://github.com/apache/incubator-dubbo/issues/2991,
to issue 3002.
They have all been labeled with help wanted and good first issue. Let us
see who is willing to complete these tasks.


The other thing, I personally think that we should mainly let the
annotations cover the master branch and cover the 2.6.x branch if the code
changes little.
Because we have completed many new functions on the master branch,
some are not compatible with the 2.6.x branch, we need to check the code on
the 2.6.x branch during the review.
If the comments can be shared, we need to remind the submitter. Let them
submit the comments to the 2.6.x branch as well.
What do you think?

yuhang xiu  于2018年12月11日周二 上午10:02写道：

> Ok, huxing
> I'd like take some time to do this.
>
> Huxing Zhang  于2018年12月10日周一 下午11:43写道：
>
>> On Mon, Dec 10, 2018 at 7:14 PM yuhang xiu  wrote:
>> >
>> > Hi,
>> > @zhuzi  @shunyumaple
>> > You are welcome to claim a new job.
>> >
>> > We currently have a project, but I have not yet divided it. I think we
>> need
>> > a discussion about how to divide tasks.
>> > @huxing @beiwei Can you give some advice? I personally think that you
>> can
>> > divide by module
>>
>> +1 Using module looks good to me.
>>
>> > but the work of a module can be done by multiple people,
>>
>> If there is multiple contributors working on the same module, we can
>> even break it down by package name.
>> We can do this only when it happen.
>>
>> > as long as there is no conflict.
>> >
>> >
>> >
>> > 竹子  于2018年12月10日周一 下午2:34写道：
>> >
>> > > 我现在正在补全dubboprotocal的注释 竹子 邮箱zhuzi.w...@gmail.com 签名由 网易邮箱大师 定制 On
>> > > 12/10/2018 14:28, yuhang xiu wrote: very nice. If there is any
>> progress,
>> > > you can tell us here. 雷舜宇  于2018年12月10日周一
>> > > 下午12:03写道： > I said that I am currently doing the service-completed
>> > > comments completion > work. If there is a problem, I will exchange
>> this on
>> > > the mailing list. > > 田 小波 
>> 于2018年12月10日周一
>> > > 上午10:03写道： > > > OK, I will submit a PR tomorrow. > > > > > 在
>> > > 2018年12月9日，下午4:50，Ian Luo  写道： > > > > > > I will
>> take
>> > > a look, and talk to you on pull request. > > > > > > -Ian. > > > > >
>> > On
>> > > Fri, Dec 7, 2018 at 6:11 PM 田 小波  >
>> wrote: >
>> > > > > > > >> Ian: > > >> I will make some simple changes to these
>> articles
>> > > and submit them to > > >> dubbo-website. Limited to personal
>> abilities, if
>> > > there are any > mistakes > > in > > >> the article, please help to
>> modify
>> > > and improve. > > >> > > >> 我会对这些文章做一些简单的修改，然后将这些文章提交给 > >
>> > > dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。 > > >> > > >> Thanks!
>> > > >>
>> > > Xiaobo > > >> > > >>> Pls. go ahead to submit your articles: > > >>>
>> > >
>> > > >>> Then we can involve other peoples in the community to join the >
>> > > effort. > > >>> > > >>> What do you think? > > >>> > > >>> Thanks, >
>> > >>>
>> > > -Ian. > > >> > > > > >
>>
>>
>>
>> --
>> Best Regards！
>> Huxing
>>
>

Re: Telnet optimization suggest

[yuhang xiu]

Welcome!

Do u have some ideas about telnet?

IMO, this way is very good:

list:
[1] listUser(Integer id)
[2] listUser(String name)

When we use invoke, we can do like this:
invoke 1 params

There has a line number or id or sth else with one invokable method. This
can make this clear.

李振  于2018年12月17日周一 下午7:52写道：

> >
> > I will try to fix it。
>

Re: Telnet optimization suggest

[yuhang xiu]

Hi, about overloading, here is an issue to track:
https://github.com/apache/incubator-dubbo/issues/2766

Regarding the group problem, it is currently impossible to execute a
service under a specific group. This is a point that can be optimized.
Would u have some ideas?

yeling  于2018年12月17日周一 下午6:18写道：

> Hi,
>
>
> When we use dubbo, we use telnet more or less. Some cases were found to be
> unavailable:
>
>
> 1. When my interface implements multiple services, and all of them are
> exposed, using the Dubbo parameter group, at this time, under the telnet
> command, I can not choose the service I want to invoke.
>
>
> 2. When a single service is implemented, if the method name is the same,
> the parameter condition is a parameter constant. For example, one interface
> have two methods:
>
> String sayHello ((int id)
>
> String sayHello (String name)
>
>
> Calling sayHello (String name) cannot be called, listUser (String name);
> throw java.lang.NumberFormatException
>
>
> Hi,
>
> 当我们在使用dubbo时，或多或少会用到telnet。发现有一些情况无法使用：
>
> 1.当我的接口实现的服务有多个，并且都暴露了，使用了dubbo参数group，此时，在telnet命令下，无法选择我想要的服务进行invoke。
>
> 2.当单个实现的服务，如果方法名一样，参数条件是一个参数常量时。比如：接口有2个方法
>
> String sayHello((int id)
>
> String sayHello(String name)
>
> 调用sayHello(String name)方法时，抛出java.lang.NumberFormatException.
>

Re: Re: Use longObjectMap to increase performance

[yuhang xiu]

Ok,
If u have questions, pls bring them here.
Looking forward to your contributions.

stormyu  于2018年12月13日周四 上午10:33写道：

> >Hi, all
> >I think so, I will start investigating the performance gap between the
> two >and send a performance report. Then I will sort out the map we need to
> replace.
> At 2018-12-13 10:22:20, "yuhang xiu"  wrote:
> >Hi, all
> >Recently, @y1317427691 claimed this part of the work on github, he will
> >start in the near future.
> >According to my personal assumptions, we need to investigate the
> >performance of longobjectmap first, and then start to sort out the map we
> >need to replace.
> >What do you think?
> >
> >
> >Huxing Zhang  于2018年12月7日周五 上午11:15写道：
> >
> >> On Tue, Dec 4, 2018 at 9:43 PM Huxing Zhang  wrote:
> >> >
> >> > Hi,
> >> >
> >> > On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu  wrote:
> >> > >
> >> > > Hi, community
> >> > > At present, there are many Map type maps in dubbo.
> When
> >> using
> >> > > this kind of map, jdk performs automatic package.
> >> > >
> >> > > We can use longObjectMap(or intObjectMap or sth else) to replace
> these
> >> maps
> >> > > and add some performance.
> >> >
> >> > Do you have some benchmark result for this?
> >> >
> >> > >
> >> > > Similarly, I have opened an issue[1] to track the progress. Of
> course,
> >> I
> >> > > will still find a new person to complete the work, we will comb and
> >> replace
> >> > > these maps together. I have found a person. We will start the
> >> organizing
> >> > > work and the program, and will be synchronized to the mailing list
> and
> >> > > issue. (
> >> > > He still has some work at the moment, so the discussion may be
> delayed
> >> for
> >> > > a few days)
> >> >
> >> > Can he be on the mailing list to discuss this?
> >> >
> >> > >
> >> > > By the way, there are a few pr content that is simple, I think we
> can
> >> do a
> >> > > review and merge them. The issue list is here:
> >> > > https://github.com/apache/incubator-dubbo/pull/2831
> >> > > https://github.com/apache/incubator-dubbo/pull/2809
> >>
> >> I have finished the following two prs:
> >>
> >> https://github.com/apache/incubator-dubbo/pull/2802
> >> https://github.com/apache/incubator-dubbo/pull/2788
> >>
> >>
> >>
> >> > >
> >> > > Can someone take a look?
> >> >
> >> > I saw your comments on some of the pull request.
> >> > I can take some of them this week.
> >> >
> >> > >
> >> > > [1]https://github.com/apache/incubator-dubbo/issues/2882
> >> >
> >> >
> >> >
> >> > --
> >> > Best Regards！
> >> > Huxing
> >>
> >>
> >>
> >> --
> >> Best Regards！
> >> Huxing
> >>
>

Re: Use longObjectMap to increase performance

[yuhang xiu]

Hi, all
Recently, @y1317427691 claimed this part of the work on github, he will
start in the near future.
According to my personal assumptions, we need to investigate the
performance of longobjectmap first, and then start to sort out the map we
need to replace.
What do you think?


Huxing Zhang  于2018年12月7日周五 上午11:15写道：

> On Tue, Dec 4, 2018 at 9:43 PM Huxing Zhang  wrote:
> >
> > Hi,
> >
> > On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu  wrote:
> > >
> > > Hi, community
> > > At present, there are many Map type maps in dubbo. When
> using
> > > this kind of map, jdk performs automatic package.
> > >
> > > We can use longObjectMap(or intObjectMap or sth else) to replace these
> maps
> > > and add some performance.
> >
> > Do you have some benchmark result for this?
> >
> > >
> > > Similarly, I have opened an issue[1] to track the progress. Of course,
> I
> > > will still find a new person to complete the work, we will comb and
> replace
> > > these maps together. I have found a person. We will start the
> organizing
> > > work and the program, and will be synchronized to the mailing list and
> > > issue. (
> > > He still has some work at the moment, so the discussion may be delayed
> for
> > > a few days)
> >
> > Can he be on the mailing list to discuss this?
> >
> > >
> > > By the way, there are a few pr content that is simple, I think we can
> do a
> > > review and merge them. The issue list is here:
> > > https://github.com/apache/incubator-dubbo/pull/2831
> > > https://github.com/apache/incubator-dubbo/pull/2809
>
> I have finished the following two prs:
>
> https://github.com/apache/incubator-dubbo/pull/2802
> https://github.com/apache/incubator-dubbo/pull/2788
>
>
>
> > >
> > > Can someone take a look?
> >
> > I saw your comments on some of the pull request.
> > I can take some of them this week.
> >
> > >
> > > [1]https://github.com/apache/incubator-dubbo/issues/2882
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
>
>
>
> --
> Best Regards！
> Huxing
>

Re: [Integration] Dubbo integrates with Nacos as a registry

[yuhang xiu]

Nice work, @khan

I saw that you helped us to review a lot of PR, welcome you to make more
contributions, I am looking forward to it.
:)

Imteyaz Khan  于2018年12月12日周三 下午4:00写道：

> Sure, I will do that.
>
> Regards
> Imteyaz
>
> On 12 Dec 2018 1:13 p.m., "Mercy"  wrote:
>
> > Hi, Imteyaz,
> >
> > Of course, thanks in advance, you could get source code from
> > https://github.com/dubbo/dubbo-registry-nacos, and discuss with
> commutity
> > in issues.
> >
> >
> > Kind regards,
> > Mercy Ma
> >
> > 在 2018/12/12 下午2:50, Imteyaz Khan 写道:
> >
> >> Mercy Ma,
> >> Is there any way I can assist you on this task? This one can help me
> >> to
> >> learn bit more about dubbo.
> >>
> >> Regards
> >> Imteyaz
> >>
> >> On Tue, Dec 11, 2018 at 3:09 PM Huxing Zhang  wrote:
> >>
> >> Good job!
> >>>
> >>> With the separation between registration center and configuration
> >>> center in Dubbo 2.7, it allows Dubbo to be able to have more choices
> >>> of service discovery except ZooKeeper, for example, Nacos, consul,
> >>> etcd, and third party configuration center such as Apollo[1].
> >>>
> >>> [1] https://github.com/ctripcorp/apollo
> >>>
> >>> On Tue, Dec 11, 2018 at 4:29 PM Mercy Ma 
> wrote:
> >>>
>  Hi, community,
> 
>  I'm working at integration between Dubbo and Nacos. Nacos <
> 
> >>> https://nacos.io>
> >>>
>  is an easy-to-use dynamic service discovery, configuration and service
>  management platform for building cloud native applications, it has
> been
>  integrated into Spring Cloud Alibaba
>   as
> the
>  service registration and discovery component. Like the ZooKeeper,
> Nacos
>  will be used as a Dubbo registry.
> 
> 
>  Kind regards,
>  Mercy Ma
>  --
>  GMail: mercybl...@gmail.com
>  Weibo/Wechat: mercyblitz 
>  Blog:  *https://mercyblitz.github.io/
>  *
> 
> >>>
> >>>
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>>
> >
>

Re: About the comments coverage of the code

[yuhang xiu]

Ok, huxing
I'd like take some time to do this.

Huxing Zhang  于2018年12月10日周一 下午11:43写道：

> On Mon, Dec 10, 2018 at 7:14 PM yuhang xiu  wrote:
> >
> > Hi,
> > @zhuzi  @shunyumaple
> > You are welcome to claim a new job.
> >
> > We currently have a project, but I have not yet divided it. I think we
> need
> > a discussion about how to divide tasks.
> > @huxing @beiwei Can you give some advice? I personally think that you can
> > divide by module
>
> +1 Using module looks good to me.
>
> > but the work of a module can be done by multiple people,
>
> If there is multiple contributors working on the same module, we can
> even break it down by package name.
> We can do this only when it happen.
>
> > as long as there is no conflict.
> >
> >
> >
> > 竹子  于2018年12月10日周一 下午2:34写道：
> >
> > > 我现在正在补全dubboprotocal的注释 竹子 邮箱zhuzi.w...@gmail.com 签名由 网易邮箱大师 定制 On
> > > 12/10/2018 14:28, yuhang xiu wrote: very nice. If there is any
> progress,
> > > you can tell us here. 雷舜宇  于2018年12月10日周一
> > > 下午12:03写道： > I said that I am currently doing the service-completed
> > > comments completion > work. If there is a problem, I will exchange
> this on
> > > the mailing list. > > 田 小波  于2018年12月10日周一
> > > 上午10:03写道： > > > OK, I will submit a PR tomorrow. > > > > > 在
> > > 2018年12月9日，下午4:50，Ian Luo  写道： > > > > > > I will
> take
> > > a look, and talk to you on pull request. > > > > > > -Ian. > > > > > >
> On
> > > Fri, Dec 7, 2018 at 6:11 PM 田 小波  >
> wrote: >
> > > > > > > >> Ian: > > >> I will make some simple changes to these
> articles
> > > and submit them to > > >> dubbo-website. Limited to personal
> abilities, if
> > > there are any > mistakes > > in > > >> the article, please help to
> modify
> > > and improve. > > >> > > >> 我会对这些文章做一些简单的修改，然后将这些文章提交给 > >
> > > dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。 > > >> > > >> Thanks! >
> > >>
> > > Xiaobo > > >> > > >>> Pls. go ahead to submit your articles: > > >>> >
> >
> > > >>> Then we can involve other peoples in the community to join the >
> > > effort. > > >>> > > >>> What do you think? > > >>> > > >>> Thanks, > >
> >>>
> > > -Ian. > > >> > > > > >
>
>
>
> --
> Best Regards！
> Huxing
>

Re: Repeated content in dubbo 2.6.4's internal content

[yuhang xiu]

Hi,
@jerrick zhu @beiwei

I am very sorry that I did not spend a lot of time on this issue last week.
I will take the time to verify this issue this week.
This issue is still being tracked.

Ian Luo  于2018年11月29日周四 上午10:08写道：

> Great. In this week I didn't have much time on dubbo project. I should have
> some extra bandwidth after this week.
>
> Thanks,
> -Ian.
>
> On Wed, Nov 28, 2018 at 4:12 PM yuhang xiu  wrote:
>
> > Awesome.
> > I will also take some time to look at our submission record to find the
> > problem.
> >
> > Ian Luo  于2018年11月28日周三 下午3:50写道：
> >
> > > I filed issue#2842 [1] to track it.
> > >
> > > -Ian,
> > >
> > > 1. https://github.com/apache/incubator-dubbo/issues/2842
> > >
> > >
> > > On Wed, Nov 28, 2018 at 3:47 PM Ian Luo  wrote:
> > >
> > > > This issue is worthy a separated issue. I will file it.
> > > >
> > > > -Ian.
> > > >
> > > > On Wed, Nov 28, 2018 at 10:13 AM yuhang xiu 
> > wrote:
> > > >
> > > >> Hi, community
> > > >>
> > > >> Recently, a user commit a issue[1] about that the dubbo.internal's
> > files
> > > >> has repeated content like this:
> > > >>
> > > >> netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
> > > >> netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
> > > >> mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
> > > >>
> > grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter
> > > >>
> > > >> netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
> > > >> netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
> > > >> mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
> > > >>
> > grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter
> > > >>
> > > >> netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
> > > >> netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
> > > >> mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
> > > >>
> > grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter
> > > >>
> > > >> All of them has repeated for three times. Can someone help to have a
> > > look?
> > > >>
> > > >> [1] https://github.com/apache/incubator-dubbo/issues/2828
> > > >>
> > > >
> > >
> >
>

Re: About the comments coverage of the code

[yuhang xiu]

Hi,
@zhuzi  @shunyumaple
You are welcome to claim a new job.

We currently have a project, but I have not yet divided it. I think we need
a discussion about how to divide tasks.
@huxing @beiwei Can you give some advice? I personally think that you can
divide by module, but the work of a module can be done by multiple people,
as long as there is no conflict.



竹子  于2018年12月10日周一 下午2:34写道：

> 我现在正在补全dubboprotocal的注释 竹子 邮箱zhuzi.w...@gmail.com 签名由 网易邮箱大师 定制 On
> 12/10/2018 14:28, yuhang xiu wrote: very nice. If there is any progress,
> you can tell us here. 雷舜宇  于2018年12月10日周一
> 下午12:03写道： > I said that I am currently doing the service-completed
> comments completion > work. If there is a problem, I will exchange this on
> the mailing list. > > 田 小波  于2018年12月10日周一
> 上午10:03写道： > > > OK, I will submit a PR tomorrow. > > > > > 在
> 2018年12月9日，下午4:50，Ian Luo  写道： > > > > > > I will take
> a look, and talk to you on pull request. > > > > > > -Ian. > > > > > > On
> Fri, Dec 7, 2018 at 6:11 PM 田 小波  > wrote: >
> > > > > >> Ian: > > >> I will make some simple changes to these articles
> and submit them to > > >> dubbo-website. Limited to personal abilities, if
> there are any > mistakes > > in > > >> the article, please help to modify
> and improve. > > >> > > >> 我会对这些文章做一些简单的修改，然后将这些文章提交给 > >
> dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。 > > >> > > >> Thanks! > > >>
> Xiaobo > > >> > > >>> Pls. go ahead to submit your articles: > > >>> > >
> >>> Then we can involve other peoples in the community to join the >
> effort. > > >>> > > >>> What do you think? > > >>> > > >>> Thanks, > > >>>
> -Ian. > > >> > > > > >

Re: About the comments coverage of the code

[yuhang xiu]

very nice.
If there is any progress, you can tell us here.

雷舜宇  于2018年12月10日周一 下午12:03写道：

> I said that I am currently doing the service-completed comments completion
> work. If there is a problem, I will exchange this on the mailing list.
>
> 田 小波  于2018年12月10日周一 上午10:03写道：
>
> > OK, I will submit a PR tomorrow.
> >
> > > 在 2018年12月9日，下午4:50，Ian Luo  写道：
> > >
> > > I will take a look, and talk to you on pull request.
> > >
> > > -Ian.
> > >
> > > On Fri, Dec 7, 2018 at 6:11 PM 田 小波 
> wrote:
> > >
> > >> Ian:
> > >> I will make some simple changes to these articles and submit them to
> > >> dubbo-website. Limited to personal abilities, if there are any
> mistakes
> > in
> > >> the article, please help to modify and improve.
> > >>
> > >> 我会对这些文章做一些简单的修改，然后将这些文章提交给
> > dubbo-website。限于个人能力，如果文章中有错误不妥之处，还请大家帮忙修改和完善。
> > >>
> > >> Thanks!
> > >> Xiaobo
> > >>
> > >>> Pls. go ahead to submit your articles:
> > >>>
> > >>> Then we can involve other peoples in the community to join the
> effort.
> > >>>
> > >>> What do you think?
> > >>>
> > >>> Thanks,
> > >>> -Ian.
> > >>
> >
> >
>

Re: New contributors for community

[yuhang xiu]

@lizhen

Ummm.. I didn't recognize you and didn't know your name.
After this, we can recognize others. :)

竹子  于2018年12月7日周五 下午5:53写道：

> 大家好，我是饭点科技有限公司的竹子。从接触dubbo以来，特别喜欢这个框架。最近研究底层源码也有很多的收获。希望能在dubbo开源社区里贡献自己的力量和获得更多的成长
> 竹子 邮箱zhuzi.w...@gmail.com 签名由 网易邮箱大师 定制 On 12/07/2018 17:11, 李振 wrote: I
> has just talked to you in wechat yesterday . 😿 yuhang xiu <
> carry...@gmail.com> 于2018年12月7日周五 下午5:07写道： > they are my friends. I
> didn't know you before, so there is no way to > contact you. > > But
> welcome to dubbo. Next time I will distribute the issue directly on the >
> mailing list. You can participate in the discussion directly here. > > 李振 <
> lizhenco...@gmail.com> 于2018年12月7日周五 下午4:55写道： > > > You forget me .I
> want to contribute to the community too. > > You can assign some issues to
> me . > > > > yuhang xiu  于2018年12月7日周五 下午4:49写道： > >
> > > > 社区的各位大家好。 > > > > > >
> 前几天，我发送了一封邮件，关于我会分发一些issue给一些对dubbo有兴趣的新人，让他们参与到dubbo中，从而更好的建设整个社区。 > > > >
> > > 在早些时候，我分发了四个issue给四个新人，他们分别是下面四个PR的作者： > > >
> https://github.com/apache/incubator-dubbo/pull/2831 > > >
> https://github.com/apache/incubator-dubbo/pull/2893 > > >
> https://github.com/apache/incubator-dubbo/pull/2822 > > >
> https://github.com/apache/incubator-dubbo/pull/2848 > > > > > >
> 其中有两个的pr已经被merge，另外两个还在等待review和处理。 > > > > > >
> 他们四位来自同一个公司，现在我很高兴向大家介绍其中的三位：@huaifeng @zhuzi @yeling。 > > > > > >
> 以后我们的所有讨论都会从线下的IM移动到邮件列表。这是他们第一次来到这里，@huaifeng @zhuzi @yeling > >
> 你们愿意介绍一下自己么？ > > > > > > 顺便说一句，还有一位新人的手头还有一些紧急的工作，所以还没有订阅我们的邮件列表。@huaifeng
> @zhuzi @yeling > > > 你们愿意帮助他们订阅邮件列表并且把他们带到这里来么？ > > > > > > > > > > > >
> 
> > > > > > > Hello everyone in the community. > > > > > > A few days ago, I
> sent an email about I will distribute some issues to > > > newcomers who
> are interested in dubbo and let them participate in dubbo > > to > > >
> better build the entire community. > > > > > > Earlier, I circulated a four
> issue to the four newcomers, they are PR > > > author of the following
> four: > > > Https://github.com/apache/incubator-dubbo/pull/2831 > > >
> Https://github.com/apache/incubator-dubbo/pull/2893 > > >
> Https://github.com/apache/incubator-dubbo/pull/2822 > > >
> Https://github.com/apache/incubator-dubbo/pull/2848 > > > > > > Two of
> the prs have been merged, and the other two are still waiting > for > > >
> review and processing. > > > > > > The four of them are from the same
> company, and now I am very happy to > > > introduce three of them:
> @huaifeng @zhuzi @yeling. > > > > > > All of our discussions in the future
> will move from the offline IM to > the > > > mailing list. This is the
> first time they both came here, @huaifeng > > @zhuzi > > > @yeling Are you
> willing to introduce yourself? > > > > > > By the way, there is a newcomer
> who has some urgent work on hand, so I > > > haven't subscribed to our
> mailing list yet. @huaifeng @zhuzi @yeling > Are > > > you willing to help
> them subscribe to the mailing list and bring them > > here? > > > > > >

Re: New contributors for community

[yuhang xiu]

hi，

之前我们之间的沟通一般通过一些IM，这并不是apache提倡的，之前你们并没有参与到dubbo社区中，所以一直没有订阅邮件列表。

以后我们的讨论都会更加公开，我们的交流不再限于几个人，而是要把讨论放到邮件列表里。

另外一件事，如果大家的英语不是很好，我们非常推荐使用google翻译，然后加上英文一起发送出来。

目前社区在完善代码的doc。我认为我们可以一起完成这个部分。当我完成模块划分后，我会通知大家并且认领任务。

期待你们更多的贡献。



Hi,

Before we communicated with some IM, this is not advocated by apache.
Before you did not participate in the dubbo community, so you have never
subscribed to the mailing list.

In the future, our discussion will be more open. Our communication is no
longer limited to a few people, but we will put the discussion on the
mailing list.

Another thing, if everyone's English is not very good, we highly recommend
using google translation, and then send it together with English.

The community is currently improving the doc of the code. I think we can
complete this part together. When I complete the module division, I will
notify everyone and claim the task.

I look forward to your more contributions.


雷舜宇  于2018年12月7日周五 下午5:20写道：

> 社区的各位小伙伴,大家好
> 我是来自饭点儿科技有限公司的怀风
> 很高兴加入dubbo社区,我平时的爱好很多 ,唱歌,旅行,玩玩尤克里里之类的,也经常混迹于各大同性交友网站(github之类的)
> 有幸为开源社区做贡献是我的荣幸,也希望跟着大家一起学习成长,希望以后能多多参与du bbo的各项社区活动
> 同时也更多地为社区做贡献,希望大家以后多多😀🤗指教
>
> 286772912 <286772...@qq.com> 于2018年12月7日周五 下午5:11写道：
>
> > 大家好，我是野菱（yeling），来自饭点儿科技有限公司。我平时爱好音乐，篮球，逛github，^_^。
> > 有幸接触dubbo分布式框架，在阅读源码的时候，灵活的扩展机制让人佩服，很高兴加入dubbo社区，希望以后能多多参与dubbo的各项社区活动。
> > 初来乍到，还有许多的知识向大家学习，还望以后的时间多多指教。~
> >
> >
> > -- Original --
> > From: yuhang xiu carry...@gmail.com
> > Date: Fri,Dec 7,2018 4:49 PM
> > To: dev dev@dubbo.apache.org
> > Subject: Re: New contributors for community
> >
> > 社区的各位大家好。
> >
> > 前几天，我发送了一封邮件，关于我会分发一些issue给一些对dubbo有兴趣的新人，让他们参与到dubbo中，从而更好的建设整个社区。
> >
> > 在早些时候，我分发了四个issue给四个新人，他们分别是下面四个PR的作者：
> > https://github.com/apache/incubator-dubbo/pull/2831
> > https://github.com/apache/incubator-dubbo/pull/2893
> > https://github.com/apache/incubator-dubbo/pull/2822
> > https://github.com/apache/incubator-dubbo/pull/2848
> >
> > 其中有两个的pr已经被merge，另外两个还在等待review和处理。
> >
> > 他们四位来自同一个公司，现在我很高兴向大家介绍其中的三位：@huaifeng @zhuzi @yeling。
> >
> > 以后我们的所有讨论都会从线下的IM移动到邮件列表。这是他们第一次来到这里，@huaifeng @zhuzi @yeling
> 你们愿意介绍一下自己么？
> >
> > 顺便说一句，还有一位新人的手头还有一些紧急的工作，所以还没有订阅我们的邮件列表。@huaifeng @zhuzi @yeling
> > 你们愿意帮助他们订阅邮件列表并且把他们带到这里来么？
> >
> >
> >
> 
> >
> > Hello everyone in the community.
> >
> > A few days ago, I sent an email about I will distribute some issues to
> > newcomers who are interested in dubbo and let them participate in dubbo
> to
> > better build the entire community.
> >
> > Earlier, I circulated a four issue to the four newcomers, they are PR
> > author of the following four:
> > Https://github.com/apache/incubator-dubbo/pull/2831
> > Https://github.com/apache/incubator-dubbo/pull/2893
> > Https://github.com/apache/incubator-dubbo/pull/2822
> > Https://github.com/apache/incubator-dubbo/pull/2848
> >
> > Two of the prs have been merged, and the other two are still waiting for
> > review and processing.
> >
> > The four of them are from the same company, and now I am very happy to
> > introduce three of them: @huaifeng @zhuzi @yeling.
> >
> > All of our discussions in the future will move from the offline IM to the
> > mailing list. This is the first time they both came here, @huaifeng
> @zhuzi
> > @yeling Are you willing to introduce yourself?
> >
> > By the way, there is a newcomer who has some urgent work on hand, so I
> > haven't subscribed to our mailing list yet. @huaifeng @zhuzi @yeling Are
> > you willing to help them subscribe to the mailing list and bring them
> here?
>

Re: New contributors for community

[yuhang xiu]

they are my friends. I didn't know you before, so there is no way to
contact you.

But welcome to dubbo. Next time I will distribute the issue directly on the
mailing list. You can participate in the discussion directly here.

李振  于2018年12月7日周五 下午4:55写道：

> You forget me .I want to contribute to the community too.
> You can assign some issues to me .
>
> yuhang xiu  于2018年12月7日周五 下午4:49写道：
>
> > 社区的各位大家好。
> >
> > 前几天，我发送了一封邮件，关于我会分发一些issue给一些对dubbo有兴趣的新人，让他们参与到dubbo中，从而更好的建设整个社区。
> >
> > 在早些时候，我分发了四个issue给四个新人，他们分别是下面四个PR的作者：
> > https://github.com/apache/incubator-dubbo/pull/2831
> > https://github.com/apache/incubator-dubbo/pull/2893
> > https://github.com/apache/incubator-dubbo/pull/2822
> > https://github.com/apache/incubator-dubbo/pull/2848
> >
> > 其中有两个的pr已经被merge，另外两个还在等待review和处理。
> >
> > 他们四位来自同一个公司，现在我很高兴向大家介绍其中的三位：@huaifeng @zhuzi @yeling。
> >
> > 以后我们的所有讨论都会从线下的IM移动到邮件列表。这是他们第一次来到这里，@huaifeng @zhuzi @yeling
> 你们愿意介绍一下自己么？
> >
> > 顺便说一句，还有一位新人的手头还有一些紧急的工作，所以还没有订阅我们的邮件列表。@huaifeng @zhuzi @yeling
> > 你们愿意帮助他们订阅邮件列表并且把他们带到这里来么？
> >
> >
> >
> 
> >
> > Hello everyone in the community.
> >
> > A few days ago, I sent an email about I will distribute some issues to
> > newcomers who are interested in dubbo and let them participate in dubbo
> to
> > better build the entire community.
> >
> > Earlier, I circulated a four issue to the four newcomers, they are PR
> > author of the following four:
> > Https://github.com/apache/incubator-dubbo/pull/2831
> > Https://github.com/apache/incubator-dubbo/pull/2893
> > Https://github.com/apache/incubator-dubbo/pull/2822
> > Https://github.com/apache/incubator-dubbo/pull/2848
> >
> > Two of the prs have been merged, and the other two are still waiting for
> > review and processing.
> >
> > The four of them are from the same company, and now I am very happy to
> > introduce three of them: @huaifeng @zhuzi @yeling.
> >
> > All of our discussions in the future will move from the offline IM to the
> > mailing list. This is the first time they both came here, @huaifeng
> @zhuzi
> > @yeling Are you willing to introduce yourself?
> >
> > By the way, there is a newcomer who has some urgent work on hand, so I
> > haven't subscribed to our mailing list yet. @huaifeng @zhuzi @yeling Are
> > you willing to help them subscribe to the mailing list and bring them
> here?
> >
>

New contributors for community

[yuhang xiu]

社区的各位大家好。

前几天，我发送了一封邮件，关于我会分发一些issue给一些对dubbo有兴趣的新人，让他们参与到dubbo中，从而更好的建设整个社区。

在早些时候，我分发了四个issue给四个新人，他们分别是下面四个PR的作者：
https://github.com/apache/incubator-dubbo/pull/2831
https://github.com/apache/incubator-dubbo/pull/2893
https://github.com/apache/incubator-dubbo/pull/2822
https://github.com/apache/incubator-dubbo/pull/2848

其中有两个的pr已经被merge，另外两个还在等待review和处理。

他们四位来自同一个公司，现在我很高兴向大家介绍其中的三位：@huaifeng @zhuzi @yeling。

以后我们的所有讨论都会从线下的IM移动到邮件列表。这是他们第一次来到这里，@huaifeng @zhuzi @yeling 你们愿意介绍一下自己么？

顺便说一句，还有一位新人的手头还有一些紧急的工作，所以还没有订阅我们的邮件列表。@huaifeng @zhuzi @yeling
你们愿意帮助他们订阅邮件列表并且把他们带到这里来么？



Hello everyone in the community.

A few days ago, I sent an email about I will distribute some issues to
newcomers who are interested in dubbo and let them participate in dubbo to
better build the entire community.

Earlier, I circulated a four issue to the four newcomers, they are PR
author of the following four:
Https://github.com/apache/incubator-dubbo/pull/2831
Https://github.com/apache/incubator-dubbo/pull/2893
Https://github.com/apache/incubator-dubbo/pull/2822
Https://github.com/apache/incubator-dubbo/pull/2848

Two of the prs have been merged, and the other two are still waiting for
review and processing.

The four of them are from the same company, and now I am very happy to
introduce three of them: @huaifeng @zhuzi @yeling.

All of our discussions in the future will move from the offline IM to the
mailing list. This is the first time they both came here, @huaifeng @zhuzi
@yeling Are you willing to introduce yourself?

By the way, there is a newcomer who has some urgent work on hand, so I
haven't subscribed to our mailing list yet. @huaifeng @zhuzi @yeling Are
you willing to help them subscribe to the mailing list and bring them here?

Re: [DISCUSS] A robot for Dubbo to help the community collaboration

[yuhang xiu]

Great, this robot is very interesting.

Netty also has a similar robot[1] that can control whether or not to
perform unit tests (some pr can be judged that we won't accept them during
the review phase), I think we can also try this.
Another feature. It will leave a comment said: 'Can one of the admins
verify this patch?' in a pull request.

It is very interesting. If we have one, I absolutely agree.
But I don't know how it works. It seems that it is no different from a
normal github user.

:)

[1] https://github.com/netty-bot

Huxing Zhang  于2018年12月6日周四 下午4:10写道：

> Hi,
>
> Recently I‘ve chatted with the maintainer of the pouch[1] project, one
> of the interesting thing I learned is that they are using a robot[2]
> to help the collaboration of the community. Typically it can:
>
> * issue/pull request triage (write access)
> * weeklyreport auto generating via a filed issue (read access)
> * some doc auto generation for project via pull request (read access)
> * friendly notice for pull request's status change (read access)
>
> I especially like the idea of auto generate a weekly report, and
> automatically remind the author of pull request that your it needs to
> be rebased.
>
> The issue triage feature is looks great but unfortunately it need
> write access, which is not allowed by ASF.
>
> However, I think it is worth to keep an eye on and maybe try it out.
>
> Thoughts?
>
> [1] https://github.com/alibaba/pouch/
> [2] https://github.com/pouchcontainer/pouchrobot
>
> --
> Best Regards！
> Huxing
>

Re: Wanted to assist dubbo community on issue #2884

[yuhang xiu]

Hi,

I think you can start submitting pr.
Some formats in the mail are not displayed neatly. A better way is to look
at the specific effects in the code after submitting the PR.

Great start. :)

Huxing Zhang  于2018年12月6日周四 上午10:07写道：

> Hi,
>
> On Thu, Dec 6, 2018 at 4:14 AM Imteyaz Khan 
> wrote:
> >
> > I have just started documenting module 'dubbo-filter',  below are example
> > of mine, this is just to make sure I am in align with the documentation
> > style
>
> Looks good! Please go head and send the pull request!
>
> >
> > /**
> >  * CacheFilter is a core component of dubbo.Enabling cache key
> > of service,method,consumer or provider dubbo will cache method return
> > value.
> >  * Along with cache key we need to configure cache type. Dubbo default
> > implemented cache types are
> >  * lur
> >  * threadlocal
> >  * jcache
> >  * expiring
> >  *
> >  * 
> >  *   e.g. 1)<dubbo:service cache="lru" />
> >  *2)<dubbo:service /> <dubbo:method name="method2"
> > cache="threadlocal" /> <dubbo:service/>
> >  *3)<dubbo:provider cache="expiring" />
> >  *4)<dubbo:consumer cache="jcache" />
> >  *
> >  *If cache type is defined in method level then method level type will
> > get precedence. According to above provided
> >  *example, if service has two method, method1 and method2, method2
> > will have cache type as threadlocal where others will
> >  *be backed by lru
> >  *
> >  *
> >  * @see org.apache.dubbo.rpc.Filter
> >  * @see org.apache.dubbo.cache.support.lru.LruCacheFactory
> >  * @see org.apache.dubbo.cache.support.lru.LruCache
> >  * @see org.apache.dubbo.cache.support.jcache.JCacheFactory
> >  * @see org.apache.dubbo.cache.support.jcache.JCache
> >  * @see
> org.apache.dubbo.cache.support.threadlocal.ThreadLocalCacheFactory
> >  * @see org.apache.dubbo.cache.support.threadlocal.ThreadLocalCache
> >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCacheFactory
> >  * @see org.apache.dubbo.cache.support.expiring.ExpiringCache
> >  *
> >  */
> > @Activate(group = {Constants.CONSUMER, Constants.PROVIDER}, value =
> > Constants.CACHE_KEY)
> > public class CacheFilter implements Filter {
> >
> > 
> >
> > .
> >
> > }
> >
> >
> > On Wed, Dec 5, 2018 at 8:20 PM Imteyaz Khan 
> wrote:
> >
> > > Just to make sure I have not misunderstood what mentioned earlier by
> > > 'Filter' is 'dubbo-filter' correct?
> > >
> > > On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> > > wrote:
> > >
> > >> Thanks a lot for the start, much appreciated.
> > >>
> > >>
> > >>
> > >> On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> > >>
> > >>> In addition, we strongly encourage open discussion.
> > >>> You can post your comments on a Filter directly here. There will be
> some
> > >>> people who know more about dubbo to review and discuss.
> > >>>
> > >>> Of course, any problem can be raised here. We will answer as soon as
> > >>> possible.
> > >>>
> > >>> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> > >>>
> > >>> > very sorry. I have some work now, so I didn't respond to your
> email in
> > >>> > time.
> > >>> > I am very willing to help you with the completion of the comments.
> If
> > >>> you
> > >>> > are a newbie, I suggest you start with a simple logic.
> > >>> > Which parts of the logic are relatively simple? At present, I think
> > >>> that
> > >>> > our filter-related implementation is relatively simple (such as
> > >>> > ActiveLimitFilter). You don't know the principle of dubbo at all,
> and
> > >>> you
> > >>> > can understand the code and complete the comments more easily. You
> can
> > >>> > start with the Filter related class and complete some of the
> comments.
> > >>> >
> > >>> > When you think that you know enough about dubbo, you can do some
> core
> > >>> > module comments, such as protocol-related comments.
> > >>> >
> > >>> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> > >>> >
> > >>> >> Hi All,
> > >>> >>Trust you all are doing well. I am new to this community or
> even
> > >>> new to
> > >>> >> any open source development community. Had a chance to go through
> one
> > >>> of
> > >>> >> the dubbo github issue #2884('We need more code comments'), which
> was
> > >>> >> marked as 'good first issue'. So thought it could be a good start
> for
> > >>> me
> > >>> >> to
> > >>> >> start from here, but being new to open source and also to dubbo I
> am
> > >>> very
> > >>> >> nervous from where and how to start. I will be great if team can
> help
> > >>> me
> > >>> >> and guide me too to assist you in any way I can.
> > >>> >>
> > >>> >> Regards
> > >>> >> Imteyaz
> > >>> >>
> > >>> >
> > >>>
> > >>
>
>
>
> --
> Best Regards！
> Huxing
>

Re: Wanted to assist dubbo community on issue #2884

[yuhang xiu]

I mean all of the impl of Filter.
Some of are not in dubbo-filter module.
U can directly find all of the Filter impl

Imteyaz Khan  于2018年12月5日周三 下午10:51写道：

> Just to make sure I have not misunderstood what mentioned earlier by
> 'Filter' is 'dubbo-filter' correct?
>
> On Wed, Dec 5, 2018 at 7:00 PM Imteyaz Khan 
> wrote:
>
> > Thanks a lot for the start, much appreciated.
> >
> >
> >
> > On Wed, Dec 5, 2018 at 6:31 PM yuhang xiu  wrote:
> >
> >> In addition, we strongly encourage open discussion.
> >> You can post your comments on a Filter directly here. There will be some
> >> people who know more about dubbo to review and discuss.
> >>
> >> Of course, any problem can be raised here. We will answer as soon as
> >> possible.
> >>
> >> yuhang xiu  于2018年12月5日周三 下午8:58写道：
> >>
> >> > very sorry. I have some work now, so I didn't respond to your email in
> >> > time.
> >> > I am very willing to help you with the completion of the comments. If
> >> you
> >> > are a newbie, I suggest you start with a simple logic.
> >> > Which parts of the logic are relatively simple? At present, I think
> that
> >> > our filter-related implementation is relatively simple (such as
> >> > ActiveLimitFilter). You don't know the principle of dubbo at all, and
> >> you
> >> > can understand the code and complete the comments more easily. You can
> >> > start with the Filter related class and complete some of the comments.
> >> >
> >> > When you think that you know enough about dubbo, you can do some core
> >> > module comments, such as protocol-related comments.
> >> >
> >> > Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
> >> >
> >> >> Hi All,
> >> >>Trust you all are doing well. I am new to this community or even
> >> new to
> >> >> any open source development community. Had a chance to go through one
> >> of
> >> >> the dubbo github issue #2884('We need more code comments'), which was
> >> >> marked as 'good first issue'. So thought it could be a good start for
> >> me
> >> >> to
> >> >> start from here, but being new to open source and also to dubbo I am
> >> very
> >> >> nervous from where and how to start. I will be great if team can help
> >> me
> >> >> and guide me too to assist you in any way I can.
> >> >>
> >> >> Regards
> >> >> Imteyaz
> >> >>
> >> >
> >>
> >
>

Re: Wanted to assist dubbo community on issue #2884

[yuhang xiu]

In addition, we strongly encourage open discussion.
You can post your comments on a Filter directly here. There will be some
people who know more about dubbo to review and discuss.

Of course, any problem can be raised here. We will answer as soon as
possible.

yuhang xiu  于2018年12月5日周三 下午8:58写道：

> very sorry. I have some work now, so I didn't respond to your email in
> time.
> I am very willing to help you with the completion of the comments. If you
> are a newbie, I suggest you start with a simple logic.
> Which parts of the logic are relatively simple? At present, I think that
> our filter-related implementation is relatively simple (such as
> ActiveLimitFilter). You don't know the principle of dubbo at all, and you
> can understand the code and complete the comments more easily. You can
> start with the Filter related class and complete some of the comments.
>
> When you think that you know enough about dubbo, you can do some core
> module comments, such as protocol-related comments.
>
> Imteyaz Khan  于2018年12月5日周三 下午3:05写道：
>
>> Hi All,
>>Trust you all are doing well. I am new to this community or even new to
>> any open source development community. Had a chance to go through one of
>> the dubbo github issue #2884('We need more code comments'), which was
>> marked as 'good first issue'. So thought it could be a good start for me
>> to
>> start from here, but being new to open source and also to dubbo I am very
>> nervous from where and how to start. I will be great if team can help me
>> and guide me too to assist you in any way I can.
>>
>> Regards
>> Imteyaz
>>
>

Re: Wanted to assist dubbo community on issue #2884

[yuhang xiu]

very sorry. I have some work now, so I didn't respond to your email in time.
I am very willing to help you with the completion of the comments. If you
are a newbie, I suggest you start with a simple logic.
Which parts of the logic are relatively simple? At present, I think that
our filter-related implementation is relatively simple (such as
ActiveLimitFilter). You don't know the principle of dubbo at all, and you
can understand the code and complete the comments more easily. You can
start with the Filter related class and complete some of the comments.

When you think that you know enough about dubbo, you can do some core
module comments, such as protocol-related comments.

Imteyaz Khan  于2018年12月5日周三 下午3:05写道：

> Hi All,
>Trust you all are doing well. I am new to this community or even new to
> any open source development community. Had a chance to go through one of
> the dubbo github issue #2884('We need more code comments'), which was
> marked as 'good first issue'. So thought it could be a good start for me to
> start from here, but being new to open source and also to dubbo I am very
> nervous from where and how to start. I will be great if team can help me
> and guide me too to assist you in any way I can.
>
> Regards
> Imteyaz
>

Re: Use longObjectMap to increase performance

[yuhang xiu]

Hi, huxing

> Hi, community
> > At present, there are many Map type maps in dubbo. When
> using
> > this kind of map, jdk performs automatic package.
> >
> > We can use longObjectMap(or intObjectMap or sth else) to replace these
> maps
> > and add some performance.
>
> Do you have some benchmark result for this?
>


not yet.
However, I have personally reviewed some of the benchmark information.
Don't worry, we will give our benchmark when submitting PR.


 Can he be on the mailing list to discuss this?



of course. All the exchanges will come here.  Apache way.  :)


I saw your comments on some of the pull request.
> I can take some of them this week.



That is great.

Huxing Zhang  于2018年12月4日周二 下午9:43写道：

> Hi,
>
> On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu  wrote:
> >
> > Hi, community
> > At present, there are many Map type maps in dubbo. When
> using
> > this kind of map, jdk performs automatic package.
> >
> > We can use longObjectMap(or intObjectMap or sth else) to replace these
> maps
> > and add some performance.
>
> Do you have some benchmark result for this?
>
> >
> > Similarly, I have opened an issue[1] to track the progress. Of course, I
> > will still find a new person to complete the work, we will comb and
> replace
> > these maps together. I have found a person. We will start the organizing
> > work and the program, and will be synchronized to the mailing list and
> > issue. (
> > He still has some work at the moment, so the discussion may be delayed
> for
> > a few days)
>
> Can he be on the mailing list to discuss this?
>
> >
> > By the way, there are a few pr content that is simple, I think we can do
> a
> > review and merge them. The issue list is here:
> > https://github.com/apache/incubator-dubbo/pull/2831
> > https://github.com/apache/incubator-dubbo/pull/2809
> > https://github.com/apache/incubator-dubbo/pull/2802
> > https://github.com/apache/incubator-dubbo/pull/2788
> >
> > Can someone take a look?
>
> I saw your comments on some of the pull request.
> I can take some of them this week.
>
> >
> > [1]https://github.com/apache/incubator-dubbo/issues/2882
>
>
>
> --
> Best Regards！
> Huxing
>

Re: About the comments coverage of the code

[yuhang xiu]

Agree with u,

I am willing to try to split them.
The split level has not been determined yet, we need some discussion.

Huxing Zhang  于2018年12月4日周二 下午9:50写道：

> Agree.
>
> I saw someone from India who would like to contribute in this issue.
> We need to break them down to small tasks.
>
> Maybe separate them by modules or something smaller and manage them by
> Github Project?
>
> On Tue, Dec 4, 2018 at 5:10 PM yuhang xiu  wrote:
> >
> > Recently dubbo held an offline meetup. When discussing with many
> > participants, many people have suggested that dubbo has very few
> comments.
> >
> > Comments are very important for us to understand the code. If our
> comments
> > are few, it is very unfriendly for new developers.
> >
> > I created a new issue[1] to track this. We need more developers to
> > contribute notes. I will continue to follow up on this matter.
> >
> > [1] https://github.com/apache/incubator-dubbo/issues/2884
>
>
>
> --
> Best Regards！
> Huxing
>

About the comments coverage of the code

[yuhang xiu]

Recently dubbo held an offline meetup. When discussing with many
participants, many people have suggested that dubbo has very few comments.

Comments are very important for us to understand the code. If our comments
are few, it is very unfriendly for new developers.

I created a new issue[1] to track this. We need more developers to
contribute notes. I will continue to follow up on this matter.

[1] https://github.com/apache/incubator-dubbo/issues/2884

Use longObjectMap to increase performance

[yuhang xiu]

Hi, community
At present, there are many Map type maps in dubbo. When using
this kind of map, jdk performs automatic package.

We can use longObjectMap(or intObjectMap or sth else) to replace these maps
and add some performance.

Similarly, I have opened an issue[1] to track the progress. Of course, I
will still find a new person to complete the work, we will comb and replace
these maps together. I have found a person. We will start the organizing
work and the program, and will be synchronized to the mailing list and
issue. (
He still has some work at the moment, so the discussion may be delayed for
a few days)

By the way, there are a few pr content that is simple, I think we can do a
review and merge them. The issue list is here:
https://github.com/apache/incubator-dubbo/pull/2831
https://github.com/apache/incubator-dubbo/pull/2809
https://github.com/apache/incubator-dubbo/pull/2802
https://github.com/apache/incubator-dubbo/pull/2788

Can someone take a look?

[1]https://github.com/apache/incubator-dubbo/issues/2882

Re: Repeated content in dubbo 2.6.4's internal content

[yuhang xiu]

Awesome.
I will also take some time to look at our submission record to find the
problem.

Ian Luo  于2018年11月28日周三 下午3:50写道：

> I filed issue#2842 [1] to track it.
>
> -Ian,
>
> 1. https://github.com/apache/incubator-dubbo/issues/2842
>
>
> On Wed, Nov 28, 2018 at 3:47 PM Ian Luo  wrote:
>
> > This issue is worthy a separated issue. I will file it.
> >
> > -Ian.
> >
> > On Wed, Nov 28, 2018 at 10:13 AM yuhang xiu  wrote:
> >
> >> Hi, community
> >>
> >> Recently, a user commit a issue[1] about that the dubbo.internal's files
> >> has repeated content like this:
> >>
> >> netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
> >> netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
> >> mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
> >> grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter
> >>
> >> netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
> >> netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
> >> mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
> >> grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter
> >>
> >> netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
> >> netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
> >> mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
> >> grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter
> >>
> >> All of them has repeated for three times. Can someone help to have a
> look?
> >>
> >> [1] https://github.com/apache/incubator-dubbo/issues/2828
> >>
> >
>

Repeated content in dubbo 2.6.4's internal content

[yuhang xiu]

Hi, community

Recently, a user commit a issue[1] about that the dubbo.internal's files
has repeated content like this:

netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter

netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter

netty=com.alibaba.dubbo.remoting.transport.netty.NettyTransporter
netty4=com.alibaba.dubbo.remoting.transport.netty4.NettyTransporter
mina=com.alibaba.dubbo.remoting.transport.mina.MinaTransporter
grizzly=com.alibaba.dubbo.remoting.transport.grizzly.GrizzlyTransporter

All of them has repeated for three times. Can someone help to have a look?

[1] https://github.com/apache/incubator-dubbo/issues/2828

Re: Fix issue 2425 and bring a new contributor

[yuhang xiu]

Hi,
I am very willing to synchronize the latest progress.
I have already distributed two issues to newcomers. So far I have seen
their pull request[1][2] on github and left my review comment. I think we
still need more reviews.

The other thing, when the PR has been submitted, I will bring them to the
mailing list as soon as possible. Currently these two newcomers are
interested in subscribing to the mailing list and participating in the
discussion. Soon we will welcome these two newcomers.

[1] https://github.com/apache/incubator-dubbo/pull/2831
[2] https://github.com/apache/incubator-dubbo/pull/2822

yuhang xiu  于2018年11月23日周五 下午3:22写道：

> I agree.
>
> He will try to subscribe to our mailing list next week. I will introduce
> him to you after he comes here. :)
>
> Ian Luo  于2018年11月23日周五 下午3:18写道：
>
>> Good job, pls. encourage them to look into 'help wanted' and 'good first
>> issue' issues. Even they are not willing to join mailing list to discuss,
>> I
>> think it is still helpful if they can subscribe and act as a watcher for
>> now.
>>
>> On the other hand, we ourselves should discuss more both here and on
>> GitHub
>> issue.
>>
>> Thanks,
>> -Ian.
>>
>>
>> On Fri, Nov 23, 2018 at 12:17 PM yuhang xiu  wrote:
>>
>> > Yes. This is also one of my future work. Let them have the idea of
>> `apache
>> > way`.
>> > I'll try my best. At the latest next week, I can bring at least the
>> > submitter of the pr which fix issue 2425 here. :)
>> >
>> > 田 小波  于2018年11月23日周五 下午12:03写道：
>> >
>> > > Maybe domestic developers are not used to discuss by mailing list,
>> most
>> > of
>> > > them prefer QQ and WeChat group. The mailing list is a new thing for
>> most
>> > > the developers, they may not do know what is it, and how to use.
>> > >
>> > > > 在 2018年11月23日，上午11:58，yuhang xiu  写道：
>> > > >
>> > > > Hi huxing,
>> > > >
>> > > > Some people are less willing to be interrupted by some mails.
>> > > > Some people think that github is enough. Currently they have not
>> > > > participated in the dubbo community, so I personally understand that
>> > they
>> > > > still can't understand the value of the mailing list.
>> > > >
>> > > > My personal plan is to get involved in the community first, and then
>> > > bring
>> > > > them here.
>> > > >
>> > > > By the way, pr[1] has already been submitted to github, and I am
>> very
>> > > glad
>> > > > that our discussion in a few days is fruitful. For him, this must
>> be a
>> > > new
>> > > > experience.
>> > > >
>> > > > [1] https://github.com/apache/incubator-dubbo/pull/2822
>> > > >
>> > > > Thx
>> > > >
>> > > > Huxing Zhang  于2018年11月23日周五 上午11:39写道：
>> > > >
>> > > >> On Fri, Nov 23, 2018 at 11:32 AM yuhang xiu 
>> > wrote:
>> > > >>>
>> > > >>> Hi, community
>> > > >>>
>> > > >>> Recently I tried to distribute some simple issue fixes to
>> newcomers
>> > who
>> > > >>> have not contributed to dubbo to cultivate their passion for
>> > > >> participating
>> > > >>> in the dubbo community.
>> > > >>>
>> > > >>> I have passed a newcomer and handed him the issue of issue 2425,
>> > > >> discussed
>> > > >>> the solution with him and directed him to the fork repository and
>> > > submit
>> > > >>> the pr.
>> > > >>>
>> > > >>> Some of them don't have a deep understanding of dubbo, but they
>> like
>> > > >> dubbo
>> > > >>> and are willing to participate in open source work. I have
>> organized
>> > a
>> > > >>> group of several people at the moment. This is good news, I will
>> > > collect
>> > > >>> some relatively simple issues in the future and encourage them to
>> fix
>> > > >> them.
>> > > >>> On issue 2425, we will soon receive a new PR from a new
>> contributor.
>> > > >>
>> > > >> Good to hear that!
>> > > >>
>> > > >>>
>> > > >>> Another unhealthy news is that I have not yet convinced them to
>> > > >> participate
>> > > >>> in the discussion of the mailing list. :(
>> > > >>> But I will never give up. :)
>> > > >>
>> > > >> May I ask why they are not coming to mailing list?
>> > > >> I'd like to help if you can give more background information.
>> > > >>
>> > > >>>
>> > > >>> If we can pass the issue 2425 pr, I will definitely introduce this
>> > new
>> > > >>> contributor on the mailing list, I think that would be a good
>> > > opportunity
>> > > >>> for him to participate in the discussion of the mailing list. :)
>> > > >>>
>> > > >>> Thx.
>> > > >>
>> > > >>
>> > > >>
>> > > >> --
>> > > >> Best Regards！
>> > > >> Huxing
>> > > >>
>> > >
>> > >
>> >
>>
>

Re: [ANNOUNCE] Apache Dubbo(incubating) 2.6.5 has been released

[yuhang xiu]

Since 2.6.5 has been released, I will close the issue[1] which lists the
related change.

[1] https://github.com/apache/incubator-dubbo/issues/2663

victory  于2018年11月23日周五 下午5:01写道：

> Thanks for your feedback. I must study English now.
> I will modify the wrong word.
>
> 田 小波  于2018年11月23日周五 下午3:33写道：
>
> > Hi, the release note contains some spelling error. As follow:
> >
> >
> > The "Reactor" should be modified to “Refactor".
> >
> > 在 2018年11月23日，下午3:28，yuhang xiu  写道：
> >
> > Nice work.
> > Let us move on.
> >
> > victory  于2018年11月23日周五 下午3:23写道：
> >
> > Hi, community,
> >
> > I am pleased to announce that the 2.6.5 version has just been released.
> > Both the source release[1] and the maven binary release[2] are available
> > now, you can also find the detailed release notes in here[3] or quickly
> > check the important changes I list below:
> >
> > Enhancements / Features：
> > - Reactor the generation rule for @Service Bean name
> > [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> > - Introduce a new Spring ApplicationEvent for ServiceBean exporting
> > [#2251](https://github.com/apache/incubator-dubbo/issues/2251)
> > - [Enhancement] the algorithm of load issue on Windows.
> > [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> > - add javadoc to dubbo-all module good first issue.
> > [#2600](https://github.com/apache/incubator-dubbo/issues/2600)
> > - [Enhancement] Reactor the generation rule for @Service Bean name
> > type/enhancement
> > [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> > - Optimize LeastActiveLoadBalance and add weight test case.
> > [#2540](https://github.com/apache/incubator-dubbo/issues/2540)
> > - Smooth Round Robin selection.
> > [#2578](https://github.com/apache/incubator-dubbo/issues/2578)
> > [#2647](https://github.com/apache/incubator-dubbo/pull/2647)
> > - [Enhancement] Resolve the placeholders for sub-properties.
> > [#2297](https://github.com/apache/incubator-dubbo/issues/2297)
> > - Add ability to turn off SPI auto injection, special support for
> > generic Object type injection.
> > [#2681](https://github.com/apache/incubator-dubbo/pull/2681)
> >
> > Bugfixes：
> > - @Service(register=false) is not work.
> > [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> > - Our customized serialization id exceeds the maximum limit, now it
> > cannot work on 2.6.2 anymore.
> > [#1903](https://github.com/apache/incubator-dubbo/issues/1903)
> > - Consumer throws RpcException after RegistryDirectory notify in high
> > QPS. [#2016](https://github.com/apache/incubator-dubbo/issues/2016)
> > - Annotation @Reference can't support to export a service with a sync
> > one and an async one .
> > [#2194](https://github.com/apache/incubator-dubbo/issues/2194)
> > -
> >
> >
> `org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
> > has a bug. [#2522](https://github.com/apache/incubator-dubbo/issues/2522
> )
> > - 2.6.x Spring Event & Bugfix.
> > [#2256](https://github.com/apache/incubator-dubbo/issues/2256)
> > - Fix incorrect descriptions for dubbo-serialization module.
> > [#2665](https://github.com/apache/incubator-dubbo/issues/2665)
> > - A empty directory
> > dubbo-config/dubbo-config-spring/src/test/resources/work after package
> > source tgz. [#2560](
> https://github.com/apache/incubator-dubbo/issues/2560)
> > - Fixed 2.6.x branch a minor issue with doConnect not using
> > getConnectTimeout() in NettyClient.  (*No issue*).
> > [#2622](https://github.com/apache/incubator-dubbo/pull/2622)
> > - Bean name of @service annotated class does not resolve placeholder.
> > [#1755](https://github.com/apache/incubator-dubbo/issues/1755)
> >
> >
> >
> > Normally, you can smoothly upgrade to the new version from any version
> > before 2.6.5 without having to do too many changes to your apps and
> without
> > having to worry about any incompatible problems.
> > If you have any usage questions, or have problems when upgrading or find
> > any problems about enhancements included in this release, please don’t
> > hesitate to let us know by sending feedback to this mailing list or
> filing
> > an issue on github[4].
> >
> > 1. https://dist.apache.org/repos/dist/release/incubator/dubbo/2.6.5/
> > <https://dist.apache.org/repos/dist/release/incubator/dubbo/2.6.4/>
> > 2. http://central.maven.org/maven2/com/alibaba/
> > 3. https://github.com/apache/incubator-dubbo/releases
> > 4. https://github.com/apache/incubator-dubbo/issues
> >
> >
> > Best Regard!
> > cvictory
> >
> >
> >
>
> --
>
> Best Regard!
> cvitory
>

Re: [ANNOUNCE] Apache Dubbo(incubating) 2.6.5 has been released

[yuhang xiu]

Nice work.
Let us move on.

victory  于2018年11月23日周五 下午3:23写道：

> Hi, community,
>
> I am pleased to announce that the 2.6.5 version has just been released.
> Both the source release[1] and the maven binary release[2] are available
> now, you can also find the detailed release notes in here[3] or quickly
> check the important changes I list below:
>
> Enhancements / Features：
> - Reactor the generation rule for @Service Bean name
> [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> - Introduce a new Spring ApplicationEvent for ServiceBean exporting
> [#2251](https://github.com/apache/incubator-dubbo/issues/2251)
> - [Enhancement] the algorithm of load issue on Windows.
> [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> - add javadoc to dubbo-all module good first issue.
> [#2600](https://github.com/apache/incubator-dubbo/issues/2600)
> - [Enhancement] Reactor the generation rule for @Service Bean name
> type/enhancement
> [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> - Optimize LeastActiveLoadBalance and add weight test case.
> [#2540](https://github.com/apache/incubator-dubbo/issues/2540)
> - Smooth Round Robin selection.
> [#2578](https://github.com/apache/incubator-dubbo/issues/2578)
> [#2647](https://github.com/apache/incubator-dubbo/pull/2647)
> - [Enhancement] Resolve the placeholders for sub-properties.
> [#2297](https://github.com/apache/incubator-dubbo/issues/2297)
> - Add ability to turn off SPI auto injection, special support for
> generic Object type injection.
> [#2681](https://github.com/apache/incubator-dubbo/pull/2681)
>
> Bugfixes：
> - @Service(register=false) is not work.
> [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> - Our customized serialization id exceeds the maximum limit, now it
> cannot work on 2.6.2 anymore.
> [#1903](https://github.com/apache/incubator-dubbo/issues/1903)
> - Consumer throws RpcException after RegistryDirectory notify in high
> QPS. [#2016](https://github.com/apache/incubator-dubbo/issues/2016)
> - Annotation @Reference can't support to export a service with a sync
> one and an async one .
> [#2194](https://github.com/apache/incubator-dubbo/issues/2194)
> -
> `org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
> has a bug. [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
> - 2.6.x Spring Event & Bugfix.
> [#2256](https://github.com/apache/incubator-dubbo/issues/2256)
> - Fix incorrect descriptions for dubbo-serialization module.
> [#2665](https://github.com/apache/incubator-dubbo/issues/2665)
> - A empty directory
> dubbo-config/dubbo-config-spring/src/test/resources/work after package
> source tgz. [#2560](https://github.com/apache/incubator-dubbo/issues/2560)
> - Fixed 2.6.x branch a minor issue with doConnect not using
> getConnectTimeout() in NettyClient.  (*No issue*).
> [#2622](https://github.com/apache/incubator-dubbo/pull/2622)
> - Bean name of @service annotated class does not resolve placeholder.
> [#1755](https://github.com/apache/incubator-dubbo/issues/1755)
>
>
>
> Normally, you can smoothly upgrade to the new version from any version
> before 2.6.5 without having to do too many changes to your apps and without
> having to worry about any incompatible problems.
> If you have any usage questions, or have problems when upgrading or find
> any problems about enhancements included in this release, please don’t
> hesitate to let us know by sending feedback to this mailing list or filing
> an issue on github[4].
>
> 1. https://dist.apache.org/repos/dist/release/incubator/dubbo/2.6.5/
> 
> 2. http://central.maven.org/maven2/com/alibaba/
> 3. https://github.com/apache/incubator-dubbo/releases
> 4. https://github.com/apache/incubator-dubbo/issues
>
>
> Best Regard!
> cvictory
>

Re: Fix issue 2425 and bring a new contributor

[yuhang xiu]

I agree.

He will try to subscribe to our mailing list next week. I will introduce
him to you after he comes here. :)

Ian Luo  于2018年11月23日周五 下午3:18写道：

> Good job, pls. encourage them to look into 'help wanted' and 'good first
> issue' issues. Even they are not willing to join mailing list to discuss, I
> think it is still helpful if they can subscribe and act as a watcher for
> now.
>
> On the other hand, we ourselves should discuss more both here and on GitHub
> issue.
>
> Thanks,
> -Ian.
>
>
> On Fri, Nov 23, 2018 at 12:17 PM yuhang xiu  wrote:
>
> > Yes. This is also one of my future work. Let them have the idea of
> `apache
> > way`.
> > I'll try my best. At the latest next week, I can bring at least the
> > submitter of the pr which fix issue 2425 here. :)
> >
> > 田 小波  于2018年11月23日周五 下午12:03写道：
> >
> > > Maybe domestic developers are not used to discuss by mailing list, most
> > of
> > > them prefer QQ and WeChat group. The mailing list is a new thing for
> most
> > > the developers, they may not do know what is it, and how to use.
> > >
> > > > 在 2018年11月23日，上午11:58，yuhang xiu  写道：
> > > >
> > > > Hi huxing,
> > > >
> > > > Some people are less willing to be interrupted by some mails.
> > > > Some people think that github is enough. Currently they have not
> > > > participated in the dubbo community, so I personally understand that
> > they
> > > > still can't understand the value of the mailing list.
> > > >
> > > > My personal plan is to get involved in the community first, and then
> > > bring
> > > > them here.
> > > >
> > > > By the way, pr[1] has already been submitted to github, and I am very
> > > glad
> > > > that our discussion in a few days is fruitful. For him, this must be
> a
> > > new
> > > > experience.
> > > >
> > > > [1] https://github.com/apache/incubator-dubbo/pull/2822
> > > >
> > > > Thx
> > > >
> > > > Huxing Zhang  于2018年11月23日周五 上午11:39写道：
> > > >
> > > >> On Fri, Nov 23, 2018 at 11:32 AM yuhang xiu 
> > wrote:
> > > >>>
> > > >>> Hi, community
> > > >>>
> > > >>> Recently I tried to distribute some simple issue fixes to newcomers
> > who
> > > >>> have not contributed to dubbo to cultivate their passion for
> > > >> participating
> > > >>> in the dubbo community.
> > > >>>
> > > >>> I have passed a newcomer and handed him the issue of issue 2425,
> > > >> discussed
> > > >>> the solution with him and directed him to the fork repository and
> > > submit
> > > >>> the pr.
> > > >>>
> > > >>> Some of them don't have a deep understanding of dubbo, but they
> like
> > > >> dubbo
> > > >>> and are willing to participate in open source work. I have
> organized
> > a
> > > >>> group of several people at the moment. This is good news, I will
> > > collect
> > > >>> some relatively simple issues in the future and encourage them to
> fix
> > > >> them.
> > > >>> On issue 2425, we will soon receive a new PR from a new
> contributor.
> > > >>
> > > >> Good to hear that!
> > > >>
> > > >>>
> > > >>> Another unhealthy news is that I have not yet convinced them to
> > > >> participate
> > > >>> in the discussion of the mailing list. :(
> > > >>> But I will never give up. :)
> > > >>
> > > >> May I ask why they are not coming to mailing list?
> > > >> I'd like to help if you can give more background information.
> > > >>
> > > >>>
> > > >>> If we can pass the issue 2425 pr, I will definitely introduce this
> > new
> > > >>> contributor on the mailing list, I think that would be a good
> > > opportunity
> > > >>> for him to participate in the discussion of the mailing list. :)
> > > >>>
> > > >>> Thx.
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> Best Regards！
> > > >> Huxing
> > > >>
> > >
> > >
> >
>

Re: Fix issue 2425 and bring a new contributor

[yuhang xiu]

Yes. This is also one of my future work. Let them have the idea of `apache
way`.
I'll try my best. At the latest next week, I can bring at least the
submitter of the pr which fix issue 2425 here. :)

田 小波  于2018年11月23日周五 下午12:03写道：

> Maybe domestic developers are not used to discuss by mailing list, most of
> them prefer QQ and WeChat group. The mailing list is a new thing for most
> the developers, they may not do know what is it, and how to use.
>
> > 在 2018年11月23日，上午11:58，yuhang xiu  写道：
> >
> > Hi huxing,
> >
> > Some people are less willing to be interrupted by some mails.
> > Some people think that github is enough. Currently they have not
> > participated in the dubbo community, so I personally understand that they
> > still can't understand the value of the mailing list.
> >
> > My personal plan is to get involved in the community first, and then
> bring
> > them here.
> >
> > By the way, pr[1] has already been submitted to github, and I am very
> glad
> > that our discussion in a few days is fruitful. For him, this must be a
> new
> > experience.
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/2822
> >
> > Thx
> >
> > Huxing Zhang  于2018年11月23日周五 上午11:39写道：
> >
> >> On Fri, Nov 23, 2018 at 11:32 AM yuhang xiu  wrote:
> >>>
> >>> Hi, community
> >>>
> >>> Recently I tried to distribute some simple issue fixes to newcomers who
> >>> have not contributed to dubbo to cultivate their passion for
> >> participating
> >>> in the dubbo community.
> >>>
> >>> I have passed a newcomer and handed him the issue of issue 2425,
> >> discussed
> >>> the solution with him and directed him to the fork repository and
> submit
> >>> the pr.
> >>>
> >>> Some of them don't have a deep understanding of dubbo, but they like
> >> dubbo
> >>> and are willing to participate in open source work. I have organized a
> >>> group of several people at the moment. This is good news, I will
> collect
> >>> some relatively simple issues in the future and encourage them to fix
> >> them.
> >>> On issue 2425, we will soon receive a new PR from a new contributor.
> >>
> >> Good to hear that!
> >>
> >>>
> >>> Another unhealthy news is that I have not yet convinced them to
> >> participate
> >>> in the discussion of the mailing list. :(
> >>> But I will never give up. :)
> >>
> >> May I ask why they are not coming to mailing list?
> >> I'd like to help if you can give more background information.
> >>
> >>>
> >>> If we can pass the issue 2425 pr, I will definitely introduce this new
> >>> contributor on the mailing list, I think that would be a good
> opportunity
> >>> for him to participate in the discussion of the mailing list. :)
> >>>
> >>> Thx.
> >>
> >>
> >>
> >> --
> >> Best Regards！
> >> Huxing
> >>
>
>

Re: Fix issue 2425 and bring a new contributor

[yuhang xiu]

Hi huxing,

Some people are less willing to be interrupted by some mails.
Some people think that github is enough. Currently they have not
participated in the dubbo community, so I personally understand that they
still can't understand the value of the mailing list.

My personal plan is to get involved in the community first, and then bring
them here.

By the way, pr[1] has already been submitted to github, and I am very glad
that our discussion in a few days is fruitful. For him, this must be a new
experience.

[1] https://github.com/apache/incubator-dubbo/pull/2822

Thx

Huxing Zhang  于2018年11月23日周五 上午11:39写道：

> On Fri, Nov 23, 2018 at 11:32 AM yuhang xiu  wrote:
> >
> > Hi, community
> >
> > Recently I tried to distribute some simple issue fixes to newcomers who
> > have not contributed to dubbo to cultivate their passion for
> participating
> > in the dubbo community.
> >
> > I have passed a newcomer and handed him the issue of issue 2425,
> discussed
> > the solution with him and directed him to the fork repository and submit
> > the pr.
> >
> > Some of them don't have a deep understanding of dubbo, but they like
> dubbo
> > and are willing to participate in open source work. I have organized a
> > group of several people at the moment. This is good news, I will collect
> > some relatively simple issues in the future and encourage them to fix
> them.
> > On issue 2425, we will soon receive a new PR from a new contributor.
>
> Good to hear that!
>
> >
> > Another unhealthy news is that I have not yet convinced them to
> participate
> > in the discussion of the mailing list. :(
> > But I will never give up. :)
>
> May I ask why they are not coming to mailing list?
> I'd like to help if you can give more background information.
>
> >
> > If we can pass the issue 2425 pr, I will definitely introduce this new
> > contributor on the mailing list, I think that would be a good opportunity
> > for him to participate in the discussion of the mailing list. :)
> >
> > Thx.
>
>
>
> --
> Best Regards！
> Huxing
>

Fix issue 2425 and bring a new contributor

[yuhang xiu]

Hi, community

Recently I tried to distribute some simple issue fixes to newcomers who
have not contributed to dubbo to cultivate their passion for participating
in the dubbo community.

I have passed a newcomer and handed him the issue of issue 2425, discussed
the solution with him and directed him to the fork repository and submit
the pr.

Some of them don't have a deep understanding of dubbo, but they like dubbo
and are willing to participate in open source work. I have organized a
group of several people at the moment. This is good news, I will collect
some relatively simple issues in the future and encourage them to fix them.
On issue 2425, we will soon receive a new PR from a new contributor.

Another unhealthy news is that I have not yet convinced them to participate
in the discussion of the mailing list. :(
But I will never give up. :)

If we can pass the issue 2425 pr, I will definitely introduce this new
contributor on the mailing list, I think that would be a good opportunity
for him to participate in the discussion of the mailing list. :)

Thx.

Re: The impact of the test sequence on the results

[yuhang xiu]

Of course, I will go see it later.
Thx a lot.

Ian Luo  于2018年11月22日周四 上午10:41写道：

> Yuhang,
>
> I reviewed PR2807 and PR 2815, and left my comments on GitHub. Would you
> mind take a look?
>
> Thanks,
> -Ian.
>
>
> On Thu, Nov 22, 2018 at 10:24 AM Ian Luo  wrote:
>
> > Great job. I will review it today.
> >
> > Thanks,
> > -Ian.
> >
> > On Thu, Nov 22, 2018 at 10:13 AM yuhang xiu  wrote:
> >
> >> Recently I saw several PR issues regarding the sequential execution of
> >> repairing UTs.
> >>
> >> It seems that some of our test scenarios will fail in certain orders.
> For
> >> one of the PRs I have already mastered the master[1]. There are also two
> >> PR[2][3] repair methods I think I need more people to review.
> >>
> >> [1] https://github.com/apache/incubator-dubbo/pull/2797
> >> [2] https://github.com/apache/incubator-dubbo/pull/2807
> >> [3] https://github.com/apache/incubator-dubbo/pull/2815
> >>
> >
>