[GitHub] incubator-eagle pull request #626: EAGLE-675 : AlertEngine: don't host long-...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/626 EAGLE-675 : AlertEngine: don't host long-live curator framework for s⦠â¦chedule Author: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/626.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #626 commit 715a8f7a5f02fc7fb59af3816f1711a65b2150ab Author: Ralph, Su <suliang...@gmail.com> Date: 2016-11-08T12:31:57Z EAGLE-675 : AlertEngine: don't host long-live curator framework for schedule Author: ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #625: EAGLE-746 : PolicyValidation is insuffici...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/625 EAGLE-746 : PolicyValidation is insufficient, and will cause blocking⦠⦠for extended handler Author: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/625.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #625 commit 34c69a9314ebecd9f71def46c6f72774e1084f84 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-11-08T11:45:49Z EAGLE-746 : PolicyValidation is insufficient, and will cause blocking for extended handler Author: ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #614: EAGLE-743: fix a bug in streamRouter
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/614#discussion_r86731136 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/java/org/apache/eagle/alert/engine/router/TestStreamRouterBolt.java --- @@ -0,0 +1,150 @@ +package org.apache.eagle.alert.engine.router; --- End diff -- need apache license header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #577: [EAGLE-694] alert engine could not reduce...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/577#discussion_r85476879
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-coordinator/src/main/java/org/apache/eagle/alert/coordinator/provider/ScheduleContextBuilder.java
---
@@ -224,7 +224,8 @@ private void
clearMonitoredStreams(List monitoredStreams) {
} else {
StreamWorkSlotQueue queue =
queueMap.get(assignment.getQueueId());
if (queue == null
-||
policies.get(assignment.getPolicyName()).getParallelismHint() >
queue.getQueueSize()) {
+||
policies.get(assignment.getPolicyName()).getParallelismHint() >
queue.getQueueSize()
--- End diff --
use != ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #566: EAGLE-683: Improve metadata store perform...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/566#discussion_r85466419
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/main/java/org/apache/eagle/alert/metadata/impl/MongoMetadataDaoImpl.java
---
@@ -89,10 +92,37 @@
@Inject
public MongoMetadataDaoImpl(Config config) {
this.connection = config.getString("connection");
+this.cappedSize = config.hasPath("cappedSize") ?
config.getInt("cappedSize") : 0;
--- End diff --
cappedSize default as 0? why not set it some reasonable value, and i saw
this is set as size in byte. should it be better to control the size in
document number. please check the maxDocuments in CreateCollectionOptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #566: EAGLE-683: Improve metadata store perform...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/566#discussion_r85466631
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/main/java/org/apache/eagle/alert/metadata/impl/MongoMetadataDaoImpl.java
---
@@ -127,41 +157,41 @@ private void init() {
BsonDocument doc1 = new BsonDocument();
IndexOptions io1 = new
IndexOptions().background(true).name("versionIndex");
doc1.append("version", new BsonInt32(1));
-scheduleStates = db.getCollection("schedule_specs");
+scheduleStates = getCollection("schedule_specs");
scheduleStates.createIndex(doc1, io1);
-spoutSpecs = db.getCollection("spoutSpecs");
+spoutSpecs = getCollection("spoutSpecs");
{
IndexOptions ioInternal = new
IndexOptions().background(true).name("topologyIdIndex");
BsonDocument docInternal = new BsonDocument();
docInternal.append("topologyId", new BsonInt32(1));
spoutSpecs.createIndex(docInternal, ioInternal);
}
-alertSpecs = db.getCollection("alertSpecs");
+alertSpecs = getCollection("alertSpecs");
{
IndexOptions ioInternal = new
IndexOptions().background(true).name("topologyNameIndex");
BsonDocument docInternal = new BsonDocument();
docInternal.append("topologyName", new BsonInt32(1));
alertSpecs.createIndex(docInternal, ioInternal);
}
-groupSpecs = db.getCollection("groupSpecs");
+groupSpecs = getCollection("groupSpecs");
--- End diff --
The getCollection method will make all the collection as capped. Capped
should only apply for collections that related to schedule specs that listed on
the jira. Please make sure the impact of the code change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #556: EAGLE-670: make kafka publisher configurable and...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/556 The convention here: we will have these properties as part of publishment and need to avoid "." in key, since mongo store doesn't support "." in key, use "_" instead. There would be many configuration for kafka, let us focus on above properties, and request.required.acks one in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #548: EAGLE-660 : Stream delete mongo implement...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/548 EAGLE-660 : Stream delete mongo implementation is not working The streamDefiniton use streamId instead of name, while the delete stream use "name" to find and delete, this cause the delete stream failed. Add and update stream is ok. Reporter: Li, Garrett Author: Li, Garrett Reviewer: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/548.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #548 commit fd3966d0405cb96ae356301d121dc6f0810f1e5b Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-21T09:04:59Z EAGLE-660 : Stream delete mongo implementation is not working Reporter: Li, Garrett Author: Li, Garrett Reviewer: ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #547: EAGLE-660: Stream delete mongo implementation is...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/547 close this one, will create another pr for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #512: [EAGLE-622] : fix the datasource name to topic n...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/512 Fix the unit test to assert topic name instead of datasource name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #512: [EAGLE-622] : fix the datasource name to ...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/512 [EAGLE-622] : fix the datasource name to topic name caused unit test ⦠Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- â¦failure Author: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/512.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #510: [EAGLE-620]: AlertEngine: SpoutWrapper ar...
GitHub user RalphSu opened a pull request:
https://github.com/apache/incubator-eagle/pull/510
[EAGLE-620]: AlertEngine: SpoutWrapper are sending duplicated message
An event of stream id "ncAlertOutputStream" will be send three times given
below spec:
process.network.alerts: [
{
topicName: "network_aggregate_alert_output_datasource",
streamId: "ncAlertOutputStream",
groupingStrategies: [
{
partition: {
streamId: "ncAlertOutputStream",
type: "GROUPBY",
columns: [
"entity"
]
},
numTotalParticipatingRouterBolts: 4,
startSequence: 0,
totalTargetBoltIds: [
"streamRouterBolt0",
"streamRouterBolt1",
"streamRouterBolt2",
"streamRouterBolt3"
]
}
]
},
{
topicName: "network_aggregate_alert_output_datasource",
streamId: "sherlockAlertOutputStream",
groupingStrategies: [
{
partition: {
streamId: "sherlockAlertOutputStream",
type: "GROUPBY",
columns: [
"entity"
]
},
numTotalParticipatingRouterBolts: 4,
startSequence: 0,
totalTargetBoltIds: [
"streamRouterBolt0",
"streamRouterBolt1",
"streamRouterBolt2",
"streamRouterBolt3"
]
}
]
},
{
topicName: "network_aggregate_alert_output_datasource",
streamId: "correlatedAlertStream",
groupingStrategies: [
{
partition: {
streamId: "correlatedAlertStream",
type: "GROUPBY",
columns: [
"linkedSwitch"
]
},
numTotalParticipatingRouterBolts: 4,
startSequence: 0,
totalTargetBoltIds: [
"streamRouterBolt0",
"streamRouterBolt1",
"streamRouterBolt2",
"streamRouterBolt3"
]
}
]
}
],
The root cause is in SpoutOutputCollectorWrapper.emit() the streamId of
group strategy is not compared with the given stream event.
Author: ralphsu
This closes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RalphSu/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/510.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #510
commit 04f5572342560951737b2ed68e28e2ab3f59a08f
Author: Ralph, Su <suliang...@gmail.com>
Date: 2016-10-14T09:30:27Z
[EAGLE-620]: AlertEngine: SpoutWrapper are sending duplicated message
Author: ralphsu
This closes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #475: [EAGLE-590]: AlertEngine: the kafka_spout...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/475 [EAGLE-590]: AlertEngine: the kafka_spout might be dropped by metadat⦠Fix the kafka_spout metadata missing caused npe issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #475 commit c100d84cd75cfd0d5c382ecdeedfa1d23e4d5568 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-05T18:13:56Z [EAGLE-590]: AlertEngine: the kafka_spout might be dropped by metadata update when system ack a tupe --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #474: [EAGLE-589] : PR 472 incorrect merge of p...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/474 [EAGLE-589] : PR 472 incorrect merge of pr 471 Due to last commit, there is incorrect merge which get out of awareness. Do this fix PR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/474.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #474 commit 6d39a4cc998465ab0dd3d0701733521b26b91509 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-04T21:29:51Z [EAGLE-589] : PR 472 incorrect merge of pr 471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #473: [EAGLE-588] : AlertEngine : Not to Use co...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/473 [EAGLE-588] : AlertEngine : Not to Use commons3 stringutil.isnoneblank Author: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/473.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #473 commit 9c91525929f8571bff9479046a1c91c6dd0e5494 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-04T20:01:38Z [EAGLE-588] : AlertEngine : Not to Use commons3 stringutil.isnoneblank Author: ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #472: [EAGLE-587]: AlertEngine : simplify state...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/472 [EAGLE-587]: AlertEngine : simplify state-based dedup to have only deupvalue for given dedup key AlertEngine : simplify state-based dedup to have only deupvalue for given dedup key You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/472.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #472 commit 7c8966db5371dfc1978919e7d6250b6c760b6b09 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-04T15:21:20Z [EAGLE-587]: AlertEngine : simplify state-based dedup to have only deupvalue for given dedup key Author: ralphsu commit 1c59e49f6fa120d4fa3d0d2337e54b4f978176d2 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-04T15:34:26Z Merge branch 'master' of https://github.com/apache/incubator-eagle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #471: [EAGLE-586]: AlertEngine: multiple routin...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/471 [EAGLE-586]: AlertEngine: multiple routing of alerts is broken becaus⦠â¦e of event not copied Quick fix in publish plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/471.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #471 commit 5ec9ff9bf69cc42d46fe904cccee3866606407cf Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-03T21:12:37Z [EAGLE-586]: AlertEngine: multiple routing of alerts is broken because of event not copied --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #470: [EAGLE-585] : AlertEngine: create metadata valid...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/470 Fix to provide validate api in coordinator resource. There are some dependency missing cause check skipped: not able to check extension validity since extension code might only available in runtime topology. This fix basically do the inter-reference check and policy QL validity check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #470: [EAGLE-585] : AlertEngine: create metadat...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/470 [EAGLE-585] : AlertEngine: create metadata validation api Author: ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/470.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #470 commit f686b37720fe6191644f289f9fc5190efb24d554 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-10-02T16:07:12Z [EAGLE-585] : AlertEngine: create metadata validation api Author: ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #467: fix spoutSpecs load met invalid FieldName(Dot) e...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/467 This is for https://issues.apache.org/jira/browse/EAGLE-580. Please update the title according to eagle community convention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #458: [EAGLE-573]: NPE when apply change of EAG...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/458 [EAGLE-573]: NPE when apply change of EAGLE-569 Fix by do npe check in concurret case. Author : ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/458.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #458 commit ed757ba563699b24574f3a3dd6c127d5db7634db Author: Ralph, Su <suliang...@gmail.com> Date: 2016-09-28T00:22:43Z [EAGLE-573]: NPE when apply change of EAGLE-569 Author : ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #457: [EAGLE-569]: AlertPublishImpl: Concurrency : Inp...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/457 Fix to use copy way to refresh metadata changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #457: [EAGLE-569]: AlertPublishImpl: Concurrenc...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/457 [EAGLE-569]: AlertPublishImpl: Concurrency : Inplace change metadata ⦠Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). ---> â¦cause concurrent modification issue Author : ralphsu You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/457.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #456: EAGLE-567: Enhance Slack publish format
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/456 https://issues.apache.org/jira/browse/EAGLE-570 for continue refactor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #454: [EAGLE-566] add dedup fields into publishment co...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/454 https://issues.apache.org/jira/browse/EAGLE-566. This PR fixes the incorrect implement of equal() and hashcode(), which cause the alertPublisherBolt not able to detect config change. Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #456: EAGLE-567: Enhance Slack publish format
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/456 We could need to refactor here, not to have these check in here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #452: update joiner from storm to google library
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/452 The default deduplicator is using org.apache.storm.guava.base to implement toString(). Suggest to remove use of storm packaged library which is versioned in storm and not easy to upgrade. PR merge to use com.googe.guava. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #428: EAGLE-531: Dedup alerts according to state chang...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/428 ut failed. org.apache.eagle.alert.engine.publisher.dedup.DefaultDeduplicatorTest.testNormal - Please make sure correctly load config before test, call ConfigFactory.invalidateCaches() org.apache.eagle.alert.engine.router.TestAlertPublisherBolt.testCustomFieldDedupEvent - changed interface of dedup interface, the assert null failed, please revise org.apache.eagle.alert.engine.router.TestAlertPublisherBolt.testEmptyCustomFieldDedupEvent - changed interface of dedup interface, the assert null failed, please revise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #407: DataNode Usage Metric added in JMX Collector
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/407 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #357: [EAGLE-472] Fix HBase unit test
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/357 still see hbase test failure due to misconfiguration. develop is supress hbase tests. once fixed, pls reenable them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/355#discussion_r75072462 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/utils/SingletonExecutor.java --- @@ -0,0 +1,32 @@ +package org.apache.eagle.alert.engine.utils; + +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; + +/** + * @author mizeng + * @version v1.0 + * @description TODO --- End diff -- Remove TODO/FIXME if unnecessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/355#discussion_r75072403 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/utils/SingletonExecutor.java --- @@ -0,0 +1,32 @@ +package org.apache.eagle.alert.engine.utils; --- End diff -- Need apache license. Other wise this should mvn failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #337: EAGLE-464 : init draft impelmentation of multipl...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/337 merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #337: EAGLE-464 : init draft impelmentation of ...
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74900271 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java --- @@ -35,6 +35,7 @@ private StreamDefinition schema; private String createdBy; private long createdTime; +private boolean isDuplicate = false; --- End diff -- Looks this is only for test verification. Could we avoid add non-required method in stream event, instead use check the statistic info in deduplicator for test verify? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899312
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/test/resources/router/publishments.json
---
@@ -0,0 +1,23 @@
+[
+{
+ "name":"test-stream-output",
+
"type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher",
+ "policyIds": [
+ "perfmon_cpu_host_check", "perfmon_cpu_pool_check"
+ ],
+ "properties": {
+ "subject":"UMP Test Alert",
--- End diff --
should be eagle test alert in "subject"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899163
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws
Exception {
if(event == null) {
return;
}
+
+if
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --
what does this equals here for? For test only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74898917 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java --- @@ -32,6 +32,7 @@ private String type; private List policyIds; private String dedupIntervalMin; +private List customDedupFields; --- End diff -- dedupFields? looks custom is redundant here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #344: EAGLE-421: JMX Metric APP use new applica...
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #344: EAGLE-421: JMX Metric APP use new application fr...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/344 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #213: EAGLE-135 Run Eagle on Spark Streaming
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/213 Branch-0.4 already released. And we have major change in v0.5. Looks this PR deprecated to me. Can we abandon and close this one? @yonzhang @haoch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #344: EAGLE-421: JMX Metric APP use new applica...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/344 EAGLE-421: JMX Metric APP use new application framework Remove the topology code since JMX app could be done in new alert engine directly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit 1517c132658408952e790e27565496b9587da06b Author: Ralph, Su <suliang...@gmail.com> Date: 2016-08-15T03:28:56Z EAGLE-421: JMX Metric APP use new application framework Remove the topology code since JMX app could be done in new alert engine directly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #337: init draft impelmentation of multiple sta...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/337 init draft impelmentation of multiple state check Init draft to provide alert on state, add a state definition in policy metadata. Move input/output stream into definition Assume the intermediate stream defined in system stream definition Chain the siddhi definition, use index to identify the next handler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle statecheck Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/337.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #337 commit 9599a296522f496da7cb7637ba0fa5e97bb77165 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-08-12T07:25:54Z init draft impelmentation of multiple state check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #336: Alert State check
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #330: EAGLE-450: Alert check meta confliction
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/330 +1 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #336: Alert State check
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/336 Alert State check Init draft to provide alert on state, add a state definition in policy metadata. 1. Move input/output stream into definition 2. Assume the intermediate stream defined in system stream definition 3. Chain the siddhi definition, use index to identify the next handler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle statecheck Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit 341816d48657ef79252b41c46df4b0b4a10d14dc Author: Zhao, Qingwen <qingwz...@ebay.com> Date: 2016-05-30T07:01:29Z EAGLE-304 Enable Advanced dedup configuration in policy definition https://github.com/apache/incubator-eagle/pull/205 Author: Zhao, Qingwen & Jiang, jilin Reviewer: Chen, Hao Closes: #205 commit 614c118ef3d739cccb18bdeed0bbdb58b757649f Author: Ralph, Su <suliang...@gmail.com> Date: 2016-06-01T05:59:41Z EAGLE-324 Init branch-v0.5 commit 656dd2305754e5ed0d19f36008c11276ca4010a1 Author: Chen, Hao <h...@apache.org> Date: 2016-06-01T15:23:40Z Branch 0.5 fix license Author: Ralph, Su <suliang...@gmail.com> Author: Hao Chen <h...@apache.org> Closes #212 from haoch/branch-0.5-fix-license. commit 737e5a2d50c9d479d6810bfb7562e54a2d0dfb47 Author: Hao Chen <h...@apache.org> Date: 2016-06-02T07:06:33Z [EAGLE-325] Initialize next-gen alert engine code on branch-0.5 Author: Hao Chen <h...@apache.org> Closes #214 from haoch/EAGLE-325. commit 8dc70df42f917c58f2fca131ec45c418be68c055 Author: Hao Chen <h...@apache.org> Date: 2016-06-02T07:34:00Z [EAGLE-324][maven-release-plugin] Initialize v0.5.0-incubating-SNAPSHOT commit 1d51f826c735096aa3c4cc1eb16362359c1d3b29 Author: Hao Chen <h...@apache.org> Date: 2016-06-02T10:23:12Z [EAGLE-324] Add MetadataResource and exclude *.out in rat checking commit 9850801123d408194ffbd84cd215344c15fd3240 Author: Hao Chen <h...@apache.org> Date: 2016-06-04T07:14:49Z [EAGLE-325] Combine multiple web resource into centralized service and remove useless codec interface Author: Hao Chen <h...@apache.org> Closes #219 from haoch/refactor-war. commit 9d16f213c991a816b4cf89732a51243b871b0c5a Author: Hao Chen <h...@apache.org> Date: 2016-06-07T06:09:49Z [EAGLE-329] Dependency incompatibility bug among jersey, asm and extcos under Java 8 https://issues.apache.org/jira/browse/EAGLE-329 Author: Hao Chen <h...@apache.org> Closes #226 from haoch/EAGLE-329. commit eef4930c3b9cac7d8c596af684ba098ec2b2229d Author: yonzhang <yonzhang2...@gmail.com> Date: 2016-06-09T23:20:59Z EAGLE-331 ingestion+alert engine preview ingestion + alert engine preview https://issues.apache.org/jira/browse/EAGLE-331 Author: @yonzhang2012 <yonzhang2...@apache.org> Reviewer: @haoch <h...@apache.org> Closes: #229 commit 8b646715edbe8f0e3a4a2d926c10e4a942117085 Author: yonzhang <yonzhang2...@gmail.com> Date: 2016-06-10T01:31:58Z EAGLE-334 clean user profile code clean user profile code in Eagle 0.5 and redesign in Eagle 0.6 Author: @yonzhang2012 <yonzhang2...@apache.org> Reviewer: Closes: #233 commit 7f6269cd913a2d31f45eba4e791b223011cfec0d Author: yonzhang <yonzhang2...@gmail.com> Date: 2016-06-12T18:50:36Z EAGLE-338 fix topology-assembly build issue because of module name change fix topology-assembly build issue because of module name change Author: @yonzhang2012 <yonzhang2...@gmail.com> Closes #236 commit f857cbe42a351157d00204345b96105f798b534c Author: Zhao, Qingwen <qingwz...@ebay.com> Date: 2016-06-27T09:05:27Z EAGLE-349 Add batch processing api for metadata https://issues.apache.org/jira/browse/EAGLE-349 Author: Zhao, Qingwen <qingwz...@ebay.com> Closes #247 commit fe50912574dfe2126da0154b8544d81022126acc Author: yonzhang <yonzhang2...@gmail.com> Date: 2016-07-05T18:10:45Z EAGLE-276 eagle support for mr & spark history job monitoring mr & spark job history monitoring Author: @wujinhu <jinh...@ebay.com> Reviewer: @yonzhang <yonzhang2...@apache.org> Closes: #217 commit 72a1501c3ff645d93067b4fd9907f8183c2763b6 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-07-07T00:53:16Z Rebase code base Author: Ralph, Su <suliang...@gmail.com>
[GitHub] incubator-eagle issue #328: EAGLE-440: Alert mongodb storage refine
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/328 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #322: [EAGLE-435] make coordiantor schedule ope...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/322#discussion_r74366625
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-coordinator/src/main/java/org/apache/eagle/alert/coordinator/Coordinator.java
---
@@ -98,28 +103,58 @@ public Coordinator(Config config, ConfigBusProducer
producer, IMetadataServiceCl
}
public synchronized ScheduleState schedule(ScheduleOption option) {
-Stopwatch watch = Stopwatch.createStarted();
-IScheduleContext context = new
ScheduleContextBuilder(client).buildContext();
-TopologyMgmtService mgmtService = new TopologyMgmtService();
-IPolicyScheduler scheduler =
PolicySchedulerFactory.createScheduler();
-
-scheduler.init(context, mgmtService);
-ScheduleState state = scheduler.schedule(option);
-
-long scheduleTime = watch.elapsed(TimeUnit.MILLISECONDS);
-state.setScheduleTimeMillis((int) scheduleTime);// hardcode to
integer
-watch.reset();
-watch.start();
-
-// persist & notify
-postSchedule(client, state, producer);
-
-watch.stop();
-long postTime = watch.elapsed(TimeUnit.MILLISECONDS);
-LOG.info("Schedule result, schedule time {} ms, post schedule time
{} ms !", scheduleTime, postTime);
-
-currentState = state;
-return state;
+ ScheduleZkState scheduleZkState = new ScheduleZkState();
+ ExclusiveExecutor.Runnable exclusiveRunnable = new
ExclusiveExecutor.Runnable() {
+ @Override
+ public void run() throws Exception {
+ scheduleZkState.scheduleAcquired = true;
+
+ while (!scheduleZkState.scheduleCompleted) {
+
Thread.sleep(ACQUIRE_LOCK_WAIT_INTERVAL_MS);
+ }
+ }
+ };
+ ExclusiveExecutor.execute(GREEDY_SCHEDULER_ZK_PATH,
exclusiveRunnable);
+ int waitMaxTimes = 0;
+ while (waitMaxTimes < ACQUIRE_LOCK_MAX_RETRIES_TIMES) { //about
3 minutes waiting
+ if (!scheduleZkState.scheduleAcquired) {
+ waitMaxTimes ++;
+ try {
+
Thread.sleep(ACQUIRE_LOCK_WAIT_INTERVAL_MS);
+ } catch (InterruptedException e) {}
+ continue;
+ }
+
+ ScheduleState state = null;
+ try {
+ Stopwatch watch = Stopwatch.createStarted();
+ IScheduleContext context = new
ScheduleContextBuilder(client).buildContext();
+ TopologyMgmtService mgmtService = new
TopologyMgmtService();
+ IPolicyScheduler scheduler =
PolicySchedulerFactory.createScheduler();
+
+ scheduler.init(context, mgmtService);
+ state = scheduler.schedule(option);
+
+ long scheduleTime =
watch.elapsed(TimeUnit.MILLISECONDS);
+ state.setScheduleTimeMillis((int) scheduleTime);//
hardcode to integer
+ watch.reset();
+ watch.start();
+
+ // persist & notify
+ postSchedule(client, state, producer);
+
+ watch.stop();
+ long postTime = watch.elapsed(TimeUnit.MILLISECONDS);
+ LOG.info("Schedule result, schedule time {} ms, post
schedule time {} ms !", scheduleTime, postTime);
+
+ currentState = state;
+ } finally {
+ //schedule completed
+ scheduleZkState.scheduleCompleted = true;
+ }
+ return state;
+ }
+ throw new LockWebApplicationException("Acquire greedy scheduler
lock failed, please retry later");
--- End diff --
Just the "scheduler lock" is enough?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #324: EAGLE-440: Alert mongodb storage refine
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/324#discussion_r74361599
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/main/java/org/apache/eagle/alert/metadata/impl/MongoMetadataDaoImpl.java
---
@@ -285,6 +318,21 @@ public OpResult removePublishmentType(String pubType) {
return remove(publishmentType, pubType);
}
+private OpResult addOne(MongoCollection collection, T t)
{
+OpResult result = new OpResult();
+try {
+String json = mapper.writeValueAsString(t);
+collection.insertOne(Document.parse(json));
+result.code = 200;
+result.message = "add state succeed!";
+} catch (Exception e) {
+result.code = 400;
+result.message = e.getMessage();
+LOG.error("", e);
--- End diff --
better to have meaningful message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #317: [EAGLE-435] make coordiantor schedule operation ...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/317 Looks only fix the listener wise. The intension is to guarantee all the schedule.build(), not only the listener. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #317: [EAGLE-435] make coordiantor schedule operation ...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/317 Looks only fix the listener wise. The intension is to guarantee all the schedule.build(), not only the listener. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #318: [EAGLE-439] Introduce policy enable/disab...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/318#discussion_r74170914
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java
---
@@ -191,6 +200,10 @@ public String toString() {
return String.format("{type=\"%s\",value=\"%s\"",type,value);
}
}
+
+public static enum PolicyStatus {
+ enabled, disabled
--- End diff --
captilized enum values to follow the code style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #316: [EAGLE-438] Multiple Inputs for Hadoop JMX Colle...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/316 otherwise, looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #316: [EAGLE-438] Multiple Inputs for Hadoop JM...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/316#discussion_r74164639
--- Diff: eagle-external/hadoop_jmx_collector/config-sample.json ---
@@ -12,18 +12,35 @@
"https":false
}
},
- "input": {
-"component": "namenode",
-"port": "50070",
-"https": false
- },
+ "inputs": [
+ {
+"component": "namenode",
+"host": "127.0.0.1",
+"port": "50070",
+"https": false,
+"kafka_topic": "nn_jmx_metric_sandbox"
+ },
+ {
+"component": "resourcemanager",
+"host": "127.0.0.1",
+"port": "8088",
+"https": false,
+"kafka_topic": "rm_jmx_metric_sandbox"
+ },
+ {
+"component": "datanode",
+"host": "127.0.0.1",
--- End diff --
let's use place holder like what we do in PR312, use
server.eagle.apache.org. So that developer could simply use /etc/resolv.conf
when there is different endpoint he want to change (etc, hdp sandbox)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #312: Hbase monitoring metadata browse API in n...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/312#discussion_r74022788
--- Diff: eagle-server/src/main/resources/application.conf ---
@@ -42,6 +42,7 @@
"metadata":{
"store":
"org.apache.eagle.metadata.service.memory.MemoryMetadataStore"
},
+ "connection":"jdbc:mysql://server.eagle.apache.org:3306/eagle",
--- End diff --
Suggest use nest {}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #276: Updated code to support Druid Sum/Count Query
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/276 @zombieJ , could you help merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #299: fix policy change listener daemon not working is...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/299 Looks this PR contains commits not merged well. Could we use another pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #284: EAGLE-401: StreamRouterBolt and PublishBo...
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #273: EAGLE-394 : fix NPE and broken test
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #273: EAGLE-394 : fix NPE and broken test
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #273: EAGLE-394 : fix NPE and broken test
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/273 Quick(might be hurry) JIRA/Open fix to the exception found. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #273: develop : fix NPE and broken test
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/273 develop : fix NPE and broken test 1. avoid mismatch metadata caused serialize/deserialize NPE issue 2. fix broken test in remote branch after merge You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #273 commit 97196bff6e97c9dcd43defde56d180a43e99b456 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-07-25T07:31:14Z avoid mismatch metadata caused serialize/deserialize NPE issue commit 7028f7d916d7e599455b030d9422ad405c42a26b Author: Ralph, Su <suliang...@gmail.com> Date: 2016-07-25T07:32:10Z Merge remote-tracking branch 'apache/develop' into develop commit 22322d4991ca212ec8d9d421edce3aea3ef211e2 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-07-25T07:46:11Z fix broken test in remote branch after merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #271: EAGLE-384: Alert Engine BugFix and Improv...
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #271: EAGLE-384: Alert Engine BugFix and Improv...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/271 EAGLE-384: Alert Engine BugFix and Improvements 1. Add schedule time in schedule state 2. Add publishment.toString() 3. Add cooridnator test for poicy update 4. Refine logging 5. Avoid explicite IP expose 6. Ignore test cases that are empty 7. Add *.orig in apache rate exclusion 8. Ignore all EmbedHbase cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/271.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #271 commit 6e2a2dc1dd6d6fd0adba96de107e1c773fb08efd Author: Ralph, Su <suliang...@gmail.com> Date: 2016-07-21T03:35:32Z 1. Add schedule time in schedule state 2. Add publishment.toString() 3. Add cooridnator test for poicy update 4. Refine logging 5. Avoid explicite IP expose 6. Ignore test cases that are empty 7. Add *.orig in apache rate exclusion 8. Ignore all EmbedHbase cases --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #250: Rebase code base
Github user RalphSu closed the pull request at: https://github.com/apache/incubator-eagle/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #250: Rebase code base
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/250#discussion_r69704458 --- Diff: pom.xml --- @@ -292,8 +293,17 @@ 1.10.19 2.2 2.2.0 + +1.3.1 + + +0.7.1 --- End diff -- Alert -service is able to be packaged as dropwizard jar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #250: Rebase code base
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/250 Rebase code base You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #250 commit 329711581d6cc7f8f9e73f3b91bc98246e9a8874 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-07-05T12:14:20Z migrate code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #217: EAGLE-276 eagle support for mr & spark history j...
Github user RalphSu commented on the issue: https://github.com/apache/incubator-eagle/pull/217 For such big feature contribution, please help raise your consideration/requirement/implementation in dev DL for discussion first. It could also help committers to do the review with direction. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-324 Init branch-v0.5
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/210 Init commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-324 Init branch-v0.5
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/210 EAGLE-324 Init branch-v0.5 EAGLE-324 Init branch-v0.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle branch-0.5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 commit fb00fa3650bde3484a77c2fff8d0c15e70bfa9b7 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-06-01T05:45:51Z remove alert commit 75a8265c6ea2b26fd542de7e103a7235feb935c0 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-06-01T05:50:39Z EAGLE-324: Init branch-v0.5 Author: ralphsu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-309: Add code formatter templa...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/199#issuecomment-222615631 Close this one, sine the fix is merge into branch-0.4. This PR is fixed and not valid now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-309: Add code formatter templa...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/199 EAGLE-309: Add code formatter template Add eclipse formatter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #199 commit 3304114440312aaf9fbe504d19ecb8dd1bce2eff Author: Ralph, Su <suliang...@gmail.com> Date: 2016-05-25T10:07:20Z EAGLE-309: Add code formatter template --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-300 set debug-log dumping comp...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/192#issuecomment-220195509 +1 keep log neat is very useful for troubleshooting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-275 Eagle email alert bug: $el...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/165#issuecomment-214234256 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-271 Topology management in rem...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/160#issuecomment-213301484 Big PR. it's good to me unless the config item name. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-271 Topology management in rem...
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/160#discussion_r60699439 --- Diff: eagle-assembly/src/main/conf/eagle-scheduler.conf --- @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +### scheduler propertise +appCommandLoaderInterval = 1 +appHealthCheckInterval = 5 --- End diff -- Better to have unit in name of config when relate to time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: Eagle-213 Updates fail for MySql
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/136#issuecomment-206112949 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-207 Management page add tips
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/131#issuecomment-200227032 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/108#issuecomment-191681816 +1 Unit runs ok for me. Be careful this would be incompatible for existing deployment if one already deployed. The one who already load the format of old version, will need a. Drop the old metadata that have the concept of datasource b. Recreate the metadata (for hadoop cases, re-run the sh files to create them) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: Eagle -168 - AlertEmail Initializati...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/101#issuecomment-187479574 Merged, with a fix of the assembly.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-165: Add more jmx metric cases
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/95 EAGLE-165: Add more jmx metric cases https://issues.apache.org/jira/browse/EAGLE-165 1. Add capacity use policy 2. Fix to package hadoop metric project into independent jar. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle datanodecountpolicy Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit fbb889e6ffe6b8b1804005ba5408d0286cd6ffc3 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-02-18T15:33:04Z update data node count policy commit 00b2637c427e05c4e1035007e3b3fa872061f43f Author: Ralph, Su <suliang...@gmail.com> Date: 2016-02-20T06:04:11Z have the hadoop assembly commit f658703786da86ddc28384477a6b23af68faafd7 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-02-20T07:17:45Z add capacity used policy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: [EAGLE-61] Supports HA and secured c...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/40#issuecomment-186980580 Can you help rebase you code with latest master? There are some conflict when i pull with latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: [EAGLE-61] Supports HA and secured c...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/40#issuecomment-186979133 Looks good +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: tutorial for setting up the developm...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/94#issuecomment-185749158 Excellent documentation. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-148: Master build failure due ...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/80 EAGLE-148: Master build failure due to siddhi ql test https://issues.apache.org/jira/browse/EAGLE-148 Fix to ignore the case first. Another fix to this test will be provided You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle EAGLE-148 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit cbeb174a49f80f2a19ba5da9fdb4ec61a780 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-02-03T04:28:42Z EAGLE-148: Master build failure due to siddhi ql test https://issues.apache.org/jira/browse/EAGLE-148 Fix to ignore the case first. Another fix to this test will be provided --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/71#discussion_r51576194 --- Diff: eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/dao/PolicyDefinitionDAO.java --- @@ -21,6 +21,7 @@ import java.util.Map; import org.apache.eagle.alert.entity.AbstractPolicyDefinitionEntity; +import org.apache.eagle.alert.entity.AlertDefinitionAPIEntity; --- End diff -- Why need to have AlertDefinitionAPIEntity in PolicyDefinitionDAO? Ideally PolicyDefinitionDAO suppose not knowing any the specific subtype of AbstractPolicyDefinitionEntity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/71#discussion_r51575914
--- Diff:
eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/dao/AlertDefinitionDAOImpl.java
---
@@ -83,4 +85,27 @@ public AlertDefinitionDAOImpl(EagleServiceConnector
connector){
}
return map;
}
+
+ @Override
+ public void updatePolicyDetails(AlertDefinitionAPIEntity entity,
boolean markdownEnabled, String markdownReason) {
+ IEagleServiceClient client = new
EagleServiceClientImpl(connector);
+
+ List entityList = new ArrayList<>();
+ entity.setMarkdownReason(null != markdownReason ?
markdownReason : "");
+ entity.setMarkdownEnabled(markdownEnabled);
+ entityList.add(entity);
+
+ try {
+ client.create(entityList,
Constants.ALERT_DEFINITION_SERVICE_ENDPOINT_NAME);
+ } catch (IOException | EagleServiceClientException exception) {
+ LOG.error("Exception in updating markdown for policy in
HBase", exception.getMessage());
--- End diff --
Please make sure not only the message is logged, but also the stack, you
might want to pass the exception object to LOG here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/71#discussion_r51577341 --- Diff: eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/dao/PolicyDefinitionEntityDAOImpl.java --- @@ -17,14 +17,17 @@ package org.apache.eagle.policy.dao; import org.apache.eagle.alert.entity.AbstractPolicyDefinitionEntity; +import org.apache.eagle.alert.entity.AlertDefinitionAPIEntity; --- End diff -- And the generic template parameter T is introduced for the purpose. I think we don't need to direct reference to AlertDefinitionAPIEntity here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-95 DAM HDFS topology fails to ...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/71#issuecomment-176549583 @yonzhang @murkrishn The AlertDefinitionDAOImpl could be replaced by PolicyDefinitionDAOImpl. The last time refactor doesn't remove alertdefinition dao impl. I filed https://issues.apache.org/jira/browse/EAGLE-142 to do this. For this pull request, you might go ahead and leave it there, i will clean up it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-81 Notification Plugin Framewo...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/76#issuecomment-175927655 Eagle already have a class scanning lib. You might want to check the EntityRepositoryScanner for the current usage. We might keep stick to one scanning library --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-136 : Setup hadoop metric appl...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/68 EAGLE-136 : Setup hadoop metric application https://issues.apache.org/jira/browse/EAGLE-136 1. Add eagle-hadoopo-metrics project 2. Add NameNodeLagMonitor app 3. Fix eagle core to remove eagleAlertContext injection 4. Fix the failed JDBC unit test (by comment out) You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle hadoop-metric Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit 22b29565b087fb39d9f403ac86eeaea4debac6b7 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-13T02:24:52Z init commit for hadoop-metric commit aa3a4cfa56365849a83b4fc6169b139219949b9e Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-17T11:33:47Z second metric commit commit 6c7c75e8ff06b86f19a4550b81c0ebba7e06f9ae Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-17T11:33:54Z Merge branch 'master' of https://github.com/apache/incubator-eagle into hadoop-metric commit d12e7629526174dc6f7d08fb08ecd6b48384d314 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-17T14:51:02Z add NameNodeLag sql case commit 17a62a03788a2a4f3ffa27697bddd7c8c73c8a10 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-17T14:55:40Z use query call back that used in the alert executor commit 16750d16907b79b7b8e4e4faabdc6cf4071f1eea Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-18T08:48:30Z add more case commit 31a9e8c926efefd8646185e6ab31a0bb519b4589 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-19T11:40:21Z add topology init shell commit 9ffecf064964e71dee7e06ddb24eaf87b2082a1d Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-19T14:40:31Z Make #1 case alert commit a462cb40452406a73403881b9904be2e5e78ecb0 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-20T07:40:32Z add test for simple aggregate executor commit 659ab4987528863e862b01b911716e43bc298f87 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-21T08:09:20Z Fix to avoid inject eagleAlertContext into cep ql commit 7e1151b362edf53e7541049c3fde9f2be5ac463c Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-21T08:44:28Z merge with latest master and pass all UTs commit 911f493e9ffe5a5db6442a00ccb30eb41e409b32 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-21T08:53:12Z Fix to remove sensitive information commit 13071e2a7671e829b58f65f186599a41133c6bbd Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-21T08:55:56Z correct mail host --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-128 : Fix unit test failure
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/64#issuecomment-171894042 i was considering add streamname into the stream definition for further handling, but revert back. This line was not reverted. Yes, this is a feature breaking for all event evaluation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-79 Provide basic aggregation
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/52#issuecomment-170452146 Add aggregate purely on single user given QL support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-97 Enable GC Log monitoring
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/50#issuecomment-169282790 Looks good. And UT runs ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-79 Provide basic aggregation
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/52 EAGLE-79 Provide basic aggregation https://issues.apache.org/jira/browse/EAGLE-79 1. Support aggregation api 2. Support persist Api 3. Refactor AlertExecutor to be policy wide. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle aggregation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit c8c8408ec7e02b1eb92b89770cc9838bb14dcf86 Author: Su <suliang...@gmail.com> Date: 2015-12-15T07:54:11Z EAGLE-88: Eagle web-service should have status url https://issues.apache.org/jira/browse/EAGLE-88 Clear the dependency to make dev able to start eagle-service with mvn tomcat7:run Add template monitor resource which returns OK for external monitoring commit e520e473542ae2a3eb95a5474ef38ce76f442336 Author: Su <suliang...@gmail.com> Date: 2015-12-15T08:22:23Z version as maven property commit 6fc745a4e1e27d93049275f170df25a544c5ed45 Author: Su <suliang...@gmail.com> Date: 2015-12-15T08:26:12Z add more scala templates commit d9edf6c6f882ba9f1a0f3d97a1c04e45daf91444 Author: Su <suliang...@gmail.com> Date: 2015-12-15T08:29:04Z remove author info commit 9331dda314497701c27548aae4de381594840aeb Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-17T08:26:48Z refactor the policy executor framework commit 3bdfb40299672ebf51e73adf12fc4d6ba0a056a4 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-17T09:08:53Z refactor the dao implementation commit b754be8d368a6bc976702b992e1f53e7ef0831e1 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-18T02:41:04Z merge with latest relase commit a42457eea4b5f9d9aca263368b9e28466358470f Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-18T09:26:29Z complete the executor abstraction commit cf7e8b4f825b1061ca5cb511f3376aaa1d3de00e Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-21T04:21:26Z add test for expansion commit f5532bf4d7ce408aefd7ecda43546139455c2a89 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-21T06:25:54Z merge with latest code commit 5018cdbbb0df40db0d3f310ffe7b9142df266e78 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-21T06:45:08Z rename the definition entity commit edc7ecf78b796bafbca007b403d4f242889427c7 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-21T09:45:18Z add test for aggregation commit bf686fb3a468754969801ef27ecea67c085108a3 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-21T10:13:50Z add more tests commit fc93c3b761fe24a74a72463fe433e9b447bd485a Author: ralphsu <suliang...@gmail.com> Date: 2015-12-24T05:43:37Z Update README.md commit 36848ef0ddf8f348e3f2d979cbc54f2c94ef03af Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-24T08:51:50Z rename analyze to aggregate commit 8130f808eae9a2cc95b295f9dd899d2efb724f54 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-28T07:42:51Z rename the analyze to aggregate commit 1f53b8a8a413287a0aacf67fc441cfd19cbd9c80 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-28T07:43:30Z Merge branch 'master' of https://github.com/RalphSu/incubator-eagle into aggergation commit 3f25cc256b862df20dae78558df78dbf6aa31046 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-28T09:52:26Z add persist executor commit c714a8e572aa66ba5f21ba3fd35a00bf0e37db9a Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-28T13:00:25Z refactor commit 9d71417c7efd44ae05a8b0a244ecc959045f4ff7 Author: Ralph, Su <suliang...@gmail.com> Date: 2015-12-29T11:05:27Z compiled OK commit 931437e28aa1dc5b6283fa6b805be251ad1a0676 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-03T07:19:22Z rename the package back commit 85994e73fc5276d77a46c238690583181f671992 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-04T01:43:54Z add comments for executor commit 985047045e9e27329d02bae3cd7a31f0c698ad16 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-04T03:46:36Z merge with latest code commit 76de45f751b00dd205c675d228ad0e3fab070a83 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-04T05:57:49Z fix two unit test failure in local commit ca301afa49906674a8598c64d6f4e5d143f23ec7 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-04T09:57:46Z add test projects commit 2e36c76be5519faf36f5297c9b7bef4380ca9da1 Author: Ralph, Su <suliang...@gmail.com> Date: 2016-01-04T10:51:42Z
[GitHub] incubator-eagle pull request: EAGLE-79 Provide basic aggregation
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/52#discussion_r48814263
--- Diff:
eagle-core/eagle-data-process/eagle-stream-process-api/src/main/java/org/apache/eagle/dataproc/impl/persist/druid/DruidPersistService.java
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.dataproc.impl.persist.druid;
+
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigValue;
+import org.apache.eagle.dataproc.impl.aggregate.entity.AggregateEntity;
+import org.apache.eagle.dataproc.impl.persist.IPersistService;
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.apache.kafka.clients.producer.ProducerRecord;
+import org.apache.kafka.clients.producer.RecordMetadata;
+
+import java.util.*;
+import java.util.concurrent.Future;
+
+/**
+ * TODO : support more general entity input
+ * @since Dec 21, 2015
+ *
+ */
+public class DruidPersistService implements
IPersistService {
--- End diff --
Nice suggestion, kafakpersistservice seems better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request: EAGLE-79 Provide basic aggregation
Github user RalphSu commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/52#discussion_r48814294 --- Diff: eagle-core/eagle-policy/eagle-policy-base/pom.xml --- @@ -0,0 +1,62 @@ + --- End diff -- hm... what does this for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-88 : Eagle web-service should ...
GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/32 EAGLE-88 : Eagle web-service should have status url https://issues.apache.org/jira/browse/EAGLE-88 Clear the dependency to make dev able to start eagle-service with mvn tomcat7:run Add template monitor resource which returns OK for external monitoring You can merge this pull request into a Git repository by running: $ git pull https://github.com/RalphSu/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit c8c8408ec7e02b1eb92b89770cc9838bb14dcf86 Author: Su <suliang...@gmail.com> Date: 2015-12-15T07:54:11Z EAGLE-88: Eagle web-service should have status url https://issues.apache.org/jira/browse/EAGLE-88 Clear the dependency to make dev able to start eagle-service with mvn tomcat7:run Add template monitor resource which returns OK for external monitoring commit e520e473542ae2a3eb95a5474ef38ce76f442336 Author: Su <suliang...@gmail.com> Date: 2015-12-15T08:22:23Z version as maven property commit 6fc745a4e1e27d93049275f170df25a544c5ed45 Author: Su <suliang...@gmail.com> Date: 2015-12-15T08:26:12Z add more scala templates commit d9edf6c6f882ba9f1a0f3d97a1c04e45daf91444 Author: Su <suliang...@gmail.com> Date: 2015-12-15T08:29:04Z remove author info --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/26#issuecomment-164410901 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164414066 Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
