[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508605#comment-15508605 ] ASF GitHub Bot commented on EAGLE-411: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/374 > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445084#comment-15445084 ] ASF GitHub Bot commented on EAGLE-411: -- Github user chitin commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/374#discussion_r76563278 --- Diff: eagle-core/eagle-query/eagle-service-base/pom.xml --- @@ -29,6 +29,10 @@ eagle-service-base jar eagle-service-base + --- End diff -- I hava done it.Thanks. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15444923#comment-15444923 ] ASF GitHub Bot commented on EAGLE-411: -- Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/374#discussion_r76556422 --- Diff: eagle-core/eagle-query/eagle-service-base/pom.xml --- @@ -29,6 +29,10 @@ eagle-service-base jar eagle-service-base + --- End diff -- Pls. move version related properties to top-level pom.xml > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430817#comment-15430817 ] ASF GitHub Bot commented on EAGLE-411: -- Github user baibaichen commented on the issue: https://github.com/apache/incubator-eagle/pull/374 @haoch , I think we need write a new test class instead of modifying TestHBaseLogReader2. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430506#comment-15430506 ] ASF GitHub Bot commented on EAGLE-411: -- Github user chitin closed the pull request at: https://github.com/apache/incubator-eagle/pull/373 > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430409#comment-15430409 ] ASF GitHub Bot commented on EAGLE-411: -- GitHub user chitin opened a pull request: https://github.com/apache/incubator-eagle/pull/373 EAGLE-411 Refactor hbase related unit test cases with mockito EAGLE-411 Refactor hbase related unit test cases with mockito - Mock the action of HBase reading, mock the meanful result of scanner.next(), unit test would not be enslaved to HBase. https://issues.apache.org/jira/browse/EAGLE-411. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chitin/incubator-eagle EAGLE411-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit ad536489eda8adc694e9d27087d971ba8949296d Author: chitinDate: 2016-08-22T09:23:00Z EAGLE-411 Refactor hbase related unit test cases with mockito - Mock the action of HBase reading, mock the meanful result of scanner.next(), unit test would not be enslaved to HBase. https://issues.apache.org/jira/browse/EAGLE-411. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430309#comment-15430309 ] ASF GitHub Bot commented on EAGLE-411: -- Github user chitin closed the pull request at: https://github.com/apache/incubator-eagle/pull/372 > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430308#comment-15430308 ] ASF GitHub Bot commented on EAGLE-411: -- Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/372 Pls. resolve conflicts firstly. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430305#comment-15430305 ] ASF GitHub Bot commented on EAGLE-411: -- Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/372#discussion_r75636528 --- Diff: eagle-core/eagle-query/eagle-service-base/pom.xml --- @@ -28,6 +28,10 @@ eagle-service-base jar eagle-service-base + +1.6.5 + 1.6.5 + --- End diff -- Should put all version declaration only in root pom. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430301#comment-15430301 ] ASF GitHub Bot commented on EAGLE-411: -- GitHub user chitin opened a pull request: https://github.com/apache/incubator-eagle/pull/372 EAGLE-411 Refactor hbase related unit test cases with mockito EAGLE-411 Refactor hbase related unit test cases with mockito - Mock the action of HBase reading, mock the meanful result of scanner.next(), unit test would not be enslaved to HBase. https://issues.apache.org/jira/browse/EAGLE-411. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chitin/incubator-eagle EAGLE411 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #372 commit b8ac17fa76ea97768dab6dc929209439a5860c07 Author: chitinDate: 2016-08-22T08:29:44Z EAGLE-411 Refactor hbase related unit test cases with mockito and mini-hbase --Mock the action of HBase reading, mock the meanful result of scanner.next(), unit test would not be enslaved to HBase. https://issues.apache.org/jira/browse/EAGLE-411. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420606#comment-15420606 ] ASF GitHub Bot commented on EAGLE-411: -- Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/345 Thanks for the contribution, could you please make sure the changes could make other test cases using `EmbeddedHbase ` able to pass? > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420592#comment-15420592 ] ASF GitHub Bot commented on EAGLE-411: -- Github user chitin closed the pull request at: https://github.com/apache/incubator-eagle/pull/345 > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420587#comment-15420587 ] ASF GitHub Bot commented on EAGLE-411: -- GitHub user chitin opened a pull request: https://github.com/apache/incubator-eagle/pull/345 EAGLE-411 Refactor hbase related unit test cases with mockito and min… - Delete "zookeeper.znode.parent" and "hbase.master.ipc.address" in HbaseTestingUtility configuration. - Support the Hbase UT which based the class to pass in meanful time https://issues.apache.org/jira/browse/EAGLE-411 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chitin/incubator-eagle hbasetest-EAGLE411 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 7ba676a117c03c39d0bd1db759574a53a07eb06e Author: chitinDate: 2016-08-15T03:31:42Z EAGLE-411 Refactor hbase related unit test cases with mockito and mini-hbase -Delete "zookeeper.znode.parent" and "hbase.master.ipc.address" in HbaseTestingUtility configuration. -Support the Hbase UT which based the class to pass in meanful time https://issues.apache.org/jira/browse/EAGLE-411 > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413154#comment-15413154 ] Chang chen commented on EAGLE-411: -- [~haoch] Sure > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413012#comment-15413012 ] Hao Chen commented on EAGLE-411: [~baibaichen] could you please let your team start with this ticket about unit test cases? > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: Chang chen > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-411) Refactor hbase related unit test cases with mockito and mini-hbase
[ https://issues.apache.org/jira/browse/EAGLE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408895#comment-15408895 ] Hao Chen commented on EAGLE-411: [~r7raul] , please assign this task to anybody interested in contribution about unit test development. > Refactor hbase related unit test cases with mockito and mini-hbase > -- > > Key: EAGLE-411 > URL: https://issues.apache.org/jira/browse/EAGLE-411 > Project: Eagle > Issue Type: Improvement >Affects Versions: v0.3.0, v0.4.0 >Reporter: Hao Chen >Assignee: JiJun Tang > Labels: unit-test > Fix For: v0.5.0 > > > Current implementation is really not stable which cause unit test like > TestHBaseLogReader2 unable to pass in meanful time, we need a better version. > https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-embed/eagle-embed-hbase/src/main/java/org/apache/eagle/service/hbase/EmbeddedHbase.java > http://blog.cloudera.com/blog/2013/09/how-to-test-hbase-applications-using-popular-tools/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)