[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752188#comment-16752188
]
ASF GitHub Bot commented on FELIX-6034:
---
Github user jbonofre closed the pull request at:
https://github.com/apache/felix/pull/169
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751947#comment-16751947
]
Jean-Baptiste Onofré commented on FELIX-6034:
-
[~rotty3000] so basically, just to be clear, I can live with the requirement
for now (at least in Karaf), but I wonder but other users. If you think it's
worth to keep the requirement, that's fine for me. Please let me know.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751945#comment-16751945
]
Jean-Baptiste Onofré commented on FELIX-6034:
-
[~rotty3000] yes, it's what I did in Karaf shell core, and it works fine.
However I didn't get the purpose of the requirement for two reasons:
1. Karaf shell.core provides the local shell console (based on jline) and wrap
gogo.jline for the Posix commands. It doesn't provide other commands than the
core one.
2. Karaf shell.core starts in first place before other commands, so, the
requirement seems too strict to me as it can start "empty" without any command
yet.
That's why I asked ;)
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751195#comment-16751195
]
Raymond Augé commented on FELIX-6034:
-
Ok guys, you convinced me that it was wrong to add the requirement in a micro
release. Granted. Sorry for the trouble that caused.
But let me explain my thoughts on the requirements for the future:
Gogo is comprised of a love triangle which, without each of the three elements,
is incomplete.
Any combination of runtime, shell, command is useless (I'm not talking about
bundles, I'm talking about feature wise).
However this doesn't mean each bundle cannot be used separately in different
types of deployments or recomposed into less than 3 bundles. The key is
ensuring that a system is complete at runtime in a way that is simple for
developers.
If I may ask a question about Karaf's custom jline (shell), is it that it
provides it's own fundamental commands (command)?
If so, isn't it self satisfying the requirement? The solution is then to simply
provide the capability to indicate self satisfy.
{{Provide-Capability:
org.apache.felix.gogo;org.apache.felix.gogo=command.implementation;version:Version="1.0.0"}}
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750762#comment-16750762
]
Christian Schneider commented on FELIX-6034:
I also agree with JB and Guillaume. We should not add a requirement in a bugfix
release as it is an incompatible change (at least when the resolver is set to
use the effective active requirements).
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750731#comment-16750731
]
Jean-Baptiste Onofré commented on FELIX-6034:
-
Hi guys.
I agree with [~gnt], I'm not sure to understand the purpose of the requirement
in gogo jline. That's why I'm proposing to remove it for now.
>From a Karaf perspective, I can change the shell feature to provide a "fake"
>capability matching the requirement, but I don't see the point too ;)
If you agree, I will merge the PR and cut a new gogo.jline release.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750728#comment-16750728
]
Guillaume Nodet commented on FELIX-6034:
Right, but the other questions remain. What's the purpose of this requirement
if no one is using it ? I don't see the need for this additional and very
specific requirement. In addition to not break compatibility, they should be
semantically correct.
In the case of gogo, the jline and shell bundles to require the runtime, but
that should actually be specified using a service requirement on the
{{CommandProcessor}} which is missing. In a similar way, the commands to
require a shell, but the shell does not require the command bundle.
Those bi-directional links are way too strict and do not represent the reality,
just a possible deployment option.
If you keep the uni-directional link, then, if you want to resolve the command
bundle, you'll end up with the shell and the runtime, which is fine. But if
you want the runtime and use it in a different way, you should not be tied to
the other parts of gogo.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750722#comment-16750722
]
Raymond Augé commented on FELIX-6034:
-
So two releases would have to be made, one micro release to revert, and one
minor version which reads it.
I can start that for jline tomorrow.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750716#comment-16750716
]
Guillaume Nodet commented on FELIX-6034:
The effectiveness is controlled by the {{ResolveContext#isEffective}} method.
What you describe is only the default implementation of the osgi framework at
runtime, not the resolver spec.
If this requirement is _literally disabled for all intents and purposes,_ then
simply removing it should not affect anyone either, but it will allow Karaf to
upgrade until a minor version includes this breaking change.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750715#comment-16750715
]
Raymond Augé commented on FELIX-6034:
-
Furthermore, this is not a service requirement at all, it's a custom namespace
specific to gogo.
The generated requirement clause is:
{{org.apache.felix.gogo;filter:="(&(org.apache.felix.gogo=command.implementation)(version>=1.0.0)(!(version>=2.0.0)))";effective:=active}}
Perhaps Karaf's deployment resolver could limit it's scope to the
{{osgi.service}} namespace, or some such.
This issue will continue to persist with bundles that take advantage of new
OSGi specifications like more sophisticated requirements and capabilities
generated by Bundle headers and their derivatives [1].
[1]https://osgi.org/specification/osgi.core/7.0.0/framework.api.html#org.osgi.annotation.bundle
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750709#comment-16750709
]
Raymond Augé commented on FELIX-6034:
-
> not a mandatory requirement on a capability that only the gogo command
> provides
The requirement is literally disabled for all intents and purposes! The only
specified value for effective is {{resolve}}, any other value means to OSGi
that the requirement is NOT MANDATORY. Please read the core spec about
resolving. This requirement should not affect anyone, except people who opt
into using the non-standard mode of "active". If they do, they should know how
to use it and they should also know how to opt out of using it.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750703#comment-16750703
]
Guillaume Nodet commented on FELIX-6034:
The service requirements are not really used at runtime per se, it's used while
the deployment agent computes the list of required bundles using the osgi
resolver / resources / etc...
>From a versioning pov, the felix bundles should not add new requirements in
>micro releases, even is that's not caught by any semantic versioning check. I
>suggest to revert the change, release a compatible version and add the change
>in new version with at least a minor version increase.
>From a gogo pov, I'm not sure why this requirement has been added. The gogo
>bundles can work independantly, the proof being that Karaf does not use them
>all. Commands are discovered by gogo, so there are not strong requirements to
>be added here. If there is a requirement to be added, it should be a
>requirement on services with a 0..N cardinality, not a mandatory requirement
>on a capability that only the gogo command provides. This really sounds like
>some magic requirements in order to tie bundles together in a usable piece.
>This goes against the reusability of the osgi manifest imho.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750521#comment-16750521
]
David Jencks commented on FELIX-6034:
-
Apparently Karaf does have an opt-out for this, but since no one will use it
there's something wrong. I suspect it's a global opt-out. Perhaps something
more acceptable to karaf devs/users would be some way of either marking a
feature as opt-out or marking a particular feature requirement optional.
Obviously felix is not the correct place to discuss details, but it seems to
keep coming up here.
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750445#comment-16750445
]
Raymond Augé commented on FELIX-6034:
-
Won't this break resolving for everyone except Karaf?
As I explained in another FELIX issue the problem is only with Karaf's use of
{{effective:=active}} at some stage during install validation.
{{effective:=active}} was never meant to be applicable at runtime. If Karaf
didn't do that then things would be good.
Maybe Karaf should have an opt-out for that?
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FELIX-6034) Gogo JLine requirement doesn't allow to embed gogo.jline
[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749575#comment-16749575
]
ASF GitHub Bot commented on FELIX-6034:
---
GitHub user jbonofre opened a pull request:
https://github.com/apache/felix/pull/169
[FELIX-6034] Remove Requirement from Gogo JLine
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/felix FELIX-6034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
commit 0232e90938528333cf1e4a74adf8d372778d8ed5
Author: Paul McCulloch
Date: 2018-10-17T15:34:26Z
FELIX-5968 Posix 'ls' command ignores .. unless -a is specified
FELIX-5968
Posix 'ls' command ignores .. unless -a is specified
commit b8468b585a4d3b806cd0f2305b27c92b10b00473
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:16:14Z
[FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in
Apache Karaf shell
commit 9cabff641bd7cea4b606d0ee3251cd44ba8e289c
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:20:25Z
[FELIX-5963] Use named ExecutorService
commit bdb9fe5c0a84cacf198ffddc48dd14332cbe8125
Author: jbonofre
Date: 2019-01-22T14:36:59Z
[FELIX-5963] This closes #168
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851825
13f79535-47bb-0310-9956-ffa450edef68
commit 960943684003e763669bb662d6c220702602446c
Author: jbonofre
Date: 2019-01-22T14:40:53Z
[FELIX-5968] This closes #158
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851826
13f79535-47bb-0310-9956-ffa450edef68
commit 4a4df4950e045eb7bcebf2c5fc9d8fc8b6cd8b6f
Author: jbonofre
Date: 2019-01-22T14:54:54Z
[FELIX-6030] This closes #167
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851828
13f79535-47bb-0310-9956-ffa450edef68
commit 58c69580de5385b7ebd018f9abe56270779d7b97
Author: Jean-Baptiste Onofré
Date: 2019-01-22T14:06:10Z
[FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix
one
commit 0485eaf87c1237b7ab724cfd67fa1529697558b9
Author: jbonofre
Date: 2019-01-22T16:25:39Z
[FELIX-6033] This closes #166
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851830
13f79535-47bb-0310-9956-ffa450edef68
commit db0db44b5bdb798ae0d309fe0414b390f63552da
Author: Jean-Baptiste Onofré
Date: 2019-01-23T06:52:28Z
[FELIX-6034] Remove Requirement from Gogo JLine
> Gogo JLine requirement doesn't allow to embed gogo.jline
>
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
>Affects Versions: gogo.jline-1.1.2
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
