[DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-09 Thread Piotr Zarzycki
Hi Folks,

This is discussion thread for Apache Flex SDK 4.16.1 RC1.

Thanks,
-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Peter Ent
I'm trying the AppoveSDK.xml script. When I do:

ant -f ApproveSDK.xml -Drelease.version=4.16.1

I get the following:

Buildfile: /Users/pent/Downloads/ApproveSDK.xml

write-out-jars-list:
   [delete] Deleting: /Users/pent/Downloads/jars.txt

install-rat.jar:

install-rat.tasks.jar:

install-rat:

download:
  [get] Getting:
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/las
tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
  [get] To: /Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
  [get] Error opening connection java.io.FileNotFoundException:
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/las
tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
  [get] Error opening connection java.io.FileNotFoundException:
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/las
tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
  [get] Error opening connection java.io.FileNotFoundException:
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/las
tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
  [get] Can't get
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/las
tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz

BUILD FAILED
/Users/pent/Downloads/ApproveSDK.xml:222: Can't get
http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/las
tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz


I can download the 4.16.1-src.tar.gz manually and will test that way.


I tried ant -f ApproveSDK.xml -Drelease.version=4.16.0 and that works, but
its not the correct release.

‹peter


On 11/9/17, 6:14 PM, "Piotr Zarzycki"  wrote:

>Hi Folks,
>
>This is discussion thread for Apache Flex SDK 4.16.1 RC1.
>
>Thanks,
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac38
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX8
>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac38
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX8
>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0>*



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Alex Harui
Peter, looks like you are missing the -Drc=1 parameter.

I guess Piotr was unable to use the releasecandidate.xml scripts because
they would have put the right command-line in the vote thread emails.
IMO, it would be better to get these scripts working so they save
everybody time and hassle.

-Alex

On 11/10/17, 8:22 AM, "Peter Ent"  wrote:

>I'm trying the AppoveSDK.xml script. When I do:
>
>ant -f ApproveSDK.xml -Drelease.version=4.16.1
>
>I get the following:
>
>Buildfile: /Users/pent/Downloads/ApproveSDK.xml
>
>write-out-jars-list:
>   [delete] Deleting: /Users/pent/Downloads/jars.txt
>
>install-rat.jar:
>
>install-rat.tasks.jar:
>
>install-rat:
>
>download:
>  [get] Getting:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
>gpNB6pbnrUkDw%3D&reserved=0
>tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>  [get] To: /Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>  [get] Error opening connection java.io.FileNotFoundException:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
>gpNB6pbnrUkDw%3D&reserved=0
>tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>  [get] Error opening connection java.io.FileNotFoundException:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
>gpNB6pbnrUkDw%3D&reserved=0
>tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>  [get] Error opening connection java.io.FileNotFoundException:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
>gpNB6pbnrUkDw%3D&reserved=0
>tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>  [get] Can't get
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
>gpNB6pbnrUkDw%3D&reserved=0
>tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
>/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>
>BUILD FAILED
>/Users/pent/Downloads/ApproveSDK.xml:222: Can't get
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
>gpNB6pbnrUkDw%3D&reserved=0
>tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
>/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>
>
>I can download the 4.16.1-src.tar.gz manually and will test that way.
>
>
>I tried ant -f ApproveSDK.xml -Drelease.version=4.16.0 and that works, but
>its not the correct release.
>
>‹peter
>
>
>On 11/9/17, 6:14 PM, "Piotr Zarzycki"  wrote:
>
>>Hi Folks,
>>
>>This is discussion thread for Apache Flex SDK 4.16.1 RC1.
>>
>>Thanks,
>>-- 
>>
>>Piotr Zarzycki
>>
>>Patreon: 
>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
>>r
>>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac3
>>8
>>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX
>>8
>>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0
>>>r
>>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac3
>>8
>>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX
>>8
>>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0>*
>



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Piotr Zarzycki
Alex,

In the VOTE thread I see the right command. I've checked many times that
email.

Peter,

Thanks for looking into that. I hope now it will work with Alex's
suggestion.

Piotr

On Fri, Nov 10, 2017, 17:26 Alex Harui  wrote:

> Peter, looks like you are missing the -Drc=1 parameter.
>
> I guess Piotr was unable to use the releasecandidate.xml scripts because
> they would have put the right command-line in the vote thread emails.
> IMO, it would be better to get these scripts working so they save
> everybody time and hassle.
>
> -Alex
>
> On 11/10/17, 8:22 AM, "Peter Ent"  wrote:
>
> >I'm trying the AppoveSDK.xml script. When I do:
> >
> >ant -f ApproveSDK.xml -Drelease.version=4.16.1
> >
> >I get the following:
> >
> >Buildfile: /Users/pent/Downloads/ApproveSDK.xml
> >
> >write-out-jars-list:
> >   [delete] Deleting: /Users/pent/Downloads/jars.txt
> >
> >install-rat.jar:
> >
> >install-rat.tasks.jar:
> >
> >install-rat:
> >
> >download:
> >  [get] Getting:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
> >build.cloudapp.net
> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
> >%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
> >cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
> >gpNB6pbnrUkDw%3D&reserved=0
> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
> >  [get] To: /Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
> >  [get] Error opening connection java.io.FileNotFoundException:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
> >build.cloudapp.net
> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
> >%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
> >cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
> >gpNB6pbnrUkDw%3D&reserved=0
> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
> >  [get] Error opening connection java.io.FileNotFoundException:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
> >build.cloudapp.net
> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
> >%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
> >cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
> >gpNB6pbnrUkDw%3D&reserved=0
> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
> >  [get] Error opening connection java.io.FileNotFoundException:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
> >build.cloudapp.net
> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
> >%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
> >cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
> >gpNB6pbnrUkDw%3D&reserved=0
> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
> >  [get] Can't get
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
> >build.cloudapp.net
> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
> >%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
> >cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
> >gpNB6pbnrUkDw%3D&reserved=0
> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
> >/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
> >
> >BUILD FAILED
> >/Users/pent/Downloads/ApproveSDK.xml:222: Can't get
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
> >build.cloudapp.net
> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
> >%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178de
> >cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQoT
> >gpNB6pbnrUkDw%3D&reserved=0
> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
> >/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
> >
> >
> >I can download the 4.16.1-src.tar.gz manually and will test that way.
> >
> >
> >I tried ant -f ApproveSDK.xml -Drelease.version=4.16.0 and that works, but
> >its not the correct release.
> >
> >‹peter
> >
> >
> >On 11/9/17, 6:14 PM, "Piotr Zarzycki"  wrote:
> >
> >>Hi Folks,
> >>
> >>This is discussion thread for Apache Flex SDK 4.16.1 RC1.
> >>
> >>Thanks,
> >>--
> >>
> >>Piotr Zarzycki
> >>
> >>Patreon:
> >>*
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
> >>r
> >>eon.com
> %2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac3
> >>8
> >>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX
> >>8
> >>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0
> >><
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
> >>r
> >>eon.com
> %2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac3
> >>8
> >>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX
> >>8
> >>9oJVmd4j

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Peter Ent
I had actually tried the -Drc=1, but I mistakenly set the release.version
to 4.16

So close. Script is running.

—peter

On 11/10/17, 11:34 AM, "Piotr Zarzycki"  wrote:

>Alex,
>
>In the VOTE thread I see the right command. I've checked many times that
>email.
>
>Peter,
>
>Thanks for looking into that. I hope now it will work with Alex's
>suggestion.
>
>Piotr
>
>On Fri, Nov 10, 2017, 17:26 Alex Harui  wrote:
>
>> Peter, looks like you are missing the -Drc=1 parameter.
>>
>> I guess Piotr was unable to use the releasecandidate.xml scripts because
>> they would have put the right command-line in the vote thread emails.
>> IMO, it would be better to get these scripts working so they save
>> everybody time and hassle.
>>
>> -Alex
>>
>> On 11/10/17, 8:22 AM, "Peter Ent"  wrote:
>>
>> >I'm trying the AppoveSDK.xml script. When I do:
>> >
>> >ant -f ApproveSDK.xml -Drelease.version=4.16.1
>> >
>> >I get the following:
>> >
>> >Buildfile: /Users/pent/Downloads/ApproveSDK.xml
>> >
>> >write-out-jars-list:
>> >   [delete] Deleting: /Users/pent/Downloads/jars.txt
>> >
>> >install-rat.jar:
>> >
>> >install-rat.tasks.jar:
>> >
>> >install-rat:
>> >
>> >download:
>> >  [get] Getting:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] To: /Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Error opening connection java.io.FileNotFoundException:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Error opening connection java.io.FileNotFoundException:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Error opening connection java.io.FileNotFoundException:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Can't get
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
>> >/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>> >
>> >BUILD FAILED
>> >/Users/pent/Downloads/ApproveSDK.xml:222: Can't get
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
>> >/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>> >
>> >
>> >I can download the 4.16.1-src.tar.gz manually and will test that way.
>> >
>> >
>> >I tried ant -f ApproveSDK.xml -Drelease.version=4.16.0 and that works,
>>but
>> >its not the correct release.
>> >
>> >‹peter
>> >
>> >
>> >On 11/9/17, 6:14 PM, "Piotr Zarzycki" 
>>wrote:
>> >
>> >>Hi Folks,
>> >>
>> >>This is discussion thread for Apache Flex SDK 4.16.1 RC1.
>> >>
>> >>Thanks,
>> >>--
>> >>
>> >>Piotr Zarzycki
>> >>
>> >>Patreon:
>> >>*
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
>> >>r
>> >>eon.com
>> %2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac3

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Alex Harui
Hi Piotr,

Yes, you are right. I looked in the wrong thread.

Sorry about that,
-Alex

On 11/10/17, 8:34 AM, "Piotr Zarzycki"  wrote:

>Alex,
>
>In the VOTE thread I see the right command. I've checked many times that
>email.
>
>Peter,
>
>Thanks for looking into that. I hope now it will work with Alex's
>suggestion.
>
>Piotr
>
>On Fri, Nov 10, 2017, 17:26 Alex Harui  wrote:
>
>> Peter, looks like you are missing the -Drc=1 parameter.
>>
>> I guess Piotr was unable to use the releasecandidate.xml scripts because
>> they would have put the right command-line in the vote thread emails.
>> IMO, it would be better to get these scripts working so they save
>> everybody time and hassle.
>>
>> -Alex
>>
>> On 11/10/17, 8:22 AM, "Peter Ent"  wrote:
>>
>> >I'm trying the AppoveSDK.xml script. When I do:
>> >
>> >ant -f ApproveSDK.xml -Drelease.version=4.16.1
>> >
>> >I get the following:
>> >
>> >Buildfile: /Users/pent/Downloads/ApproveSDK.xml
>> >
>> >write-out-jars-list:
>> >   [delete] Deleting: /Users/pent/Downloads/jars.txt
>> >
>> >install-rat.jar:
>> >
>> >install-rat.tasks.jar:
>> >
>> >install-rat:
>> >
>> >download:
>> >  [get] Getting:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] To: /Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Error opening connection java.io.FileNotFoundException:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Error opening connection java.io.FileNotFoundException:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Error opening connection java.io.FileNotFoundException:
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz
>> >  [get] Can't get
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
>> >/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>> >
>> >BUILD FAILED
>> >/Users/pent/Downloads/ApproveSDK.xml:222: Can't get
>> >
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefle
>>x
>> >build.cloudapp.net
>> %3A8080%2Fjob%2Fflex-sdk_release-candidate%2Flas&data=02
>> 
>>>%7C01%7C%7C8ff3fb4edd424693413508d5285739e9%7Cfa7b1b5a7b34438794aed2c178
>>>de
>> 
>>>cee1%7C0%7C0%7C636459277456439905&sdata=S1jrEyHCZKbH5O%2BZMGoi%2B9UjJPiQ
>>>oT
>> >gpNB6pbnrUkDw%3D&reserved=0
>> >tSuccessfulBuild/artifact/out/apache-flex-sdk-4.16.1-src.tar.gz to
>> >/Users/pent/Downloads/apache-flex-sdk-4.16.1-src.tar.gz
>> >
>> >
>> >I can download the 4.16.1-src.tar.gz manually and will test that way.
>> >
>> >
>> >I tried ant -f ApproveSDK.xml -Drelease.version=4.16.0 and that works,
>>but
>> >its not the correct release.
>> >
>> >‹peter
>> >
>> >
>> >On 11/9/17, 6:14 PM, "Piotr Zarzycki" 
>>wrote:
>> >
>> >>Hi Folks,
>> >>
>> >>This is discussion thread for Apache Flex SDK 4.16.1 RC1.
>> >>
>> >>Thanks,
>> >>--
>> >>
>> >>Piotr Zarzycki
>> >>
>> >>Patreon:
>> >>*
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pat
>> >>r
>> >>eon.com
>> %2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac3
>> >>8
>> 
%7Cfa7b1b5a7b344387

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Peter Ent
After getting the Approval script running and going through the license
files, etc., the whole thing ended with:

osmf-check:


osmf-download:


download-osmf-swc:
  [get] Getting:
https://sourceforge.net/adobe/flexsdk/code/HEAD/tree/trunk/frameworks/libs/
OSMF2_0.swc?format=raw
  [get] To: 
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/in/osmf.swc
  [get] Error getting
https://sourceforge.net/adobe/flexsdk/code/HEAD/tree/trunk/frameworks/libs/
OSMF2_0.swc?format=raw to
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/in/osmf.swc


double-check-file:
 [echo] Need file: ${still_no_file}


get-from-cache-if-needed:


fail-if-not-found:


BUILD FAILED
/Users/pent/Downloads/ApproveSDK.xml:1186: The following error occurred
while executing this line:
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/build.xml:157: The
following error occurred while executing this line:
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/build.xml:100:
The following error occurred while executing this line:
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/downloads.xml:1
05: The following error occurred while executing this line:
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/downloads.xml:1
17: The following error occurred while executing this line:
/Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/downloads.xml:4
22: osmf.swc could not be downloaded or found in cache


I can get to the file in the browser and even download it, so I don't know
what could be wrong.

‹peter

On 11/9/17, 6:14 PM, "Piotr Zarzycki"  wrote:

>Hi Folks,
>
>This is discussion thread for Apache Flex SDK 4.16.1 RC1.
>
>Thanks,
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac38
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX8
>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7ac38
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636458660901245879&sdata=NX8
>9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0>*



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-10 Thread Piotr Zarzycki
Hi Peter,

Somewhere on the dev list there is a thread where problems with downloading
SMF2 is described. It is because sourcfourge changed something in their
policy. The solution was to download following java jars [1] and replace in
your JDK. Let me know if you are using Java 8 or 7 ?

[1]
http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-2133166.html

Piotr


2017-11-10 22:43 GMT+01:00 Peter Ent :

> After getting the Approval script running and going through the license
> files, etc., the whole thing ended with:
>
> osmf-check:
>
>
> osmf-download:
>
>
> download-osmf-swc:
>   [get] Getting:
> https://sourceforge.net/adobe/flexsdk/code/HEAD/tree/trunk/
> frameworks/libs/
> OSMF2_0.swc?format=raw
>   [get] To:
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/in/osmf.swc
>   [get] Error getting
> https://sourceforge.net/adobe/flexsdk/code/HEAD/tree/trunk/
> frameworks/libs/
> OSMF2_0.swc?format=raw to
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/in/osmf.swc
>
>
> double-check-file:
>  [echo] Need file: ${still_no_file}
>
>
> get-from-cache-if-needed:
>
>
> fail-if-not-found:
>
>
> BUILD FAILED
> /Users/pent/Downloads/ApproveSDK.xml:1186: The following error occurred
> while executing this line:
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/build.xml:157: The
> following error occurred while executing this line:
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/build.xml:100:
> The following error occurred while executing this line:
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/
> frameworks/downloads.xml:1
> 05: The following error occurred while executing this line:
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/
> frameworks/downloads.xml:1
> 17: The following error occurred while executing this line:
> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/
> frameworks/downloads.xml:4
> 22: osmf.swc could not be downloaded or found in cache
>
>
> I can get to the file in the browser and even download it, so I don't know
> what could be wrong.
>
> ‹peter
>
> On 11/9/17, 6:14 PM, "Piotr Zarzycki"  wrote:
>
> >Hi Folks,
> >
> >This is discussion thread for Apache Flex SDK 4.16.1 RC1.
> >
> >Thanks,
> >--
> >
> >Piotr Zarzycki
> >
> >Patreon:
> >*https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr
> >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7
> ac38
> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636458660901245879&sdata=NX8
> >9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0
> > https%3A%2F%2Fwww.patr
> >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1b8108d527c7
> ac38
> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636458660901245879&sdata=NX8
> >9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0>*
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-11 Thread Piotr Zarzycki
Hi Om, Peter,

Here you got link to old discussion about your problems with OSMF [1]

[1]
http://apache-flex-development.247.n4.nabble.com/source-forge-downloads-failing-tp59050p59220.html

Thanks, Piotr


2017-11-10 23:02 GMT+01:00 Piotr Zarzycki :

> Hi Peter,
>
> Somewhere on the dev list there is a thread where problems with
> downloading SMF2 is described. It is because sourcfourge changed something
> in their policy. The solution was to download following java jars [1] and
> replace in your JDK. Let me know if you are using Java 8 or 7 ?
>
> [1] http://www.oracle.com/technetwork/java/javase/downloads/jce8-download-
> 2133166.html
>
> Piotr
>
>
> 2017-11-10 22:43 GMT+01:00 Peter Ent :
>
>> After getting the Approval script running and going through the license
>> files, etc., the whole thing ended with:
>>
>> osmf-check:
>>
>>
>> osmf-download:
>>
>>
>> download-osmf-swc:
>>   [get] Getting:
>> https://sourceforge.net/adobe/flexsdk/code/HEAD/tree/trunk/f
>> rameworks/libs/
>> OSMF2_0.swc?format=raw
>> 
>>   [get] To:
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/in/osmf.swc
>>   [get] Error getting
>> https://sourceforge.net/adobe/flexsdk/code/HEAD/tree/trunk/f
>> rameworks/libs/
>> OSMF2_0.swc?format=raw
>> 
>> to
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/in/osmf.swc
>>
>>
>> double-check-file:
>>  [echo] Need file: ${still_no_file}
>>
>>
>> get-from-cache-if-needed:
>>
>>
>> fail-if-not-found:
>>
>>
>> BUILD FAILED
>> /Users/pent/Downloads/ApproveSDK.xml:1186: The following error occurred
>> while executing this line:
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/build.xml:157: The
>> following error occurred while executing this line:
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/
>> build.xml:100:
>> The following error occurred while executing this line:
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/
>> downloads.xml:1
>> 05: The following error occurred while executing this line:
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/
>> downloads.xml:1
>> 17: The following error occurred while executing this line:
>> /Users/pent/Downloads/apache-flex-sdk-4.16.1-src/frameworks/
>> downloads.xml:4
>> 22: osmf.swc could not be downloaded or found in cache
>>
>>
>> I can get to the file in the browser and even download it, so I don't know
>> what could be wrong.
>>
>> ‹peter
>>
>> On 11/9/17, 6:14 PM, "Piotr Zarzycki"  wrote:
>>
>> >Hi Folks,
>> >
>> >This is discussion thread for Apache Flex SDK 4.16.1 RC1.
>> >
>> >Thanks,
>> >--
>> >
>> >Piotr Zarzycki
>> >
>> >Patreon:
>> >*https://na01.safelinks.protection.outlook.com/?url=https%
>> 3A%2F%2Fwww.patr
>> >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1
>> b8108d527c7ac38
>> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364586609012
>> 45879&sdata=NX8
>> >9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0
>> >> 3A%2F%2Fwww.patr
>> >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C8060e3b76f3048bb1
>> b8108d527c7ac38
>> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364586609012
>> 45879&sdata=NX8
>> >9oJVmd4jS2lhmhu%2FL4syVTaYa2MLJ%2BSeXsDJ5AhY%3D&reserved=0>*
>>
>>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>



-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Justin Mclean
Hi,

Looks like the tar.gz file has been packaged / checked out with wrong line 
endings (i.e. dos ones). If you try to run any of the .sh files you get “: 
invalid option” on OSX. you can fix this by running dos2unix on the files but 
their may be other issues because of this.

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Justin Mclean
Hi,

I’m also having issues downloading OSMF when trying t compile the SDK and I do 
have the international crypto set up. However it's only failing on on Java 1.7 
and works on 1.8, on OSX if that helps anyone.

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Piotr Zarzycki
Hi,

I don't understand actually - It was packaged by build.xml script on
Windows 10. Does it make the difference for your OSX ? What do you mean .sh
files ?

Piotr

2017-11-12 11:47 GMT+01:00 Justin Mclean :

> Hi,
>
> Looks like the tar.gz file has been packaged / checked out with wrong line
> endings (i.e. dos ones). If you try to run any of the .sh files you get “:
> invalid option” on OSX. you can fix this by running dos2unix on the files
> but their may be other issues because of this.
>
> Thanks,
> Justin




-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Piotr Zarzycki
Maybe I wasn't clear, but my questions are:
What do I need to do in build.xml script in order to fix that or your
suggestion is to take this file and do something with it ? I haven't change
the type of compression.

Piotr


2017-11-12 12:15 GMT+01:00 Piotr Zarzycki :

> Hi,
>
> I don't understand actually - It was packaged by build.xml script on
> Windows 10. Does it make the difference for your OSX ? What do you mean .sh
> files ?
>
> Piotr
>
> 2017-11-12 11:47 GMT+01:00 Justin Mclean :
>
>> Hi,
>>
>> Looks like the tar.gz file has been packaged / checked out with wrong
>> line endings (i.e. dos ones). If you try to run any of the .sh files you
>> get “: invalid option” on OSX. you can fix this by running dos2unix on the
>> files but their may be other issues because of this.
>>
>> Thanks,
>> Justin
>
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>



-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Justin Mclean
Hi,

> I don't understand actually

.tar.gz source is used on Linux and OSX, the .zip on windows. Linux and OSX use 
different line endings and if you use DOS/windows style line ending in shell 
scripts they will not run

> It was packaged by build.xml script on Windows 10. Does it make the 
> difference for your OSX ? What do you mean .sh
> files ?

The bash script files found in the /ide directory and other places for instance 
running the tests.

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Justin Mclean
Hi,

> What do I need to do in build.xml script in order to fix that or your
> suggestion is to take this file and do something with it ? 

I’ve not build on windows for several years so not 100% sure sorry. When 
building on OSX I’ve not run into the issue.

It may actually be a git setting issue in that you are changing line endings to 
windows on checking out the repo. It’s the autocrlf setting I believe what do 
you have that set to?

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Piotr Zarzycki
Hi,

Ok I got it, but I don't fully understand how changing line endings for
files check outed for sdk repository could change final .tar.gz file. Exact
this file has wrong line endings, or file after unpack have ?

Thanks, Piotr


2017-11-12 12:48 GMT+01:00 Justin Mclean :

> Hi,
>
> > What do I need to do in build.xml script in order to fix that or your
> > suggestion is to take this file and do something with it ?
>
> I’ve not build on windows for several years so not 100% sure sorry. When
> building on OSX I’ve not run into the issue.
>
> It may actually be a git setting issue in that you are changing line
> endings to windows on checking out the repo. It’s the autocrlf setting I
> believe what do you have that set to?
>
> Thanks,
> Justin




-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-12 Thread Justin Mclean
Hi,

> Ok I got it, but I don't fully understand how changing line endings for
> files check outed for sdk repository could change final .tar.gz file. Exact
> this file has wrong line endings, or file after unpack have ?

As I said the bash script contained in the .tar.gz have the wrong line endings.

So do all text files like README, LICENSE, NOTICE, java source files etc etc 
etc but that generally doesn’t cause an issue.

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
I spent some time checking out the release.

The line-ending problem is a non-issue.  Prior releases are set up this
way as well.  The "release" target fixes up the line endings when building
the binary kit.  I think the main build does not so it doesn't inject
changes into the sources in a repo.

What is a problem with the release is that the files do not appear to be
UTF-8 encoded.  Or at least, many non-ASCII characters are not quite right
when the source package is viewed from a mac.  Note that the CI server's
nightly build doesn't seem to have this issue.  I believe this is because
the CI server has the environment variable:

   JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8


One such file is: 

  frameworks/tests/basicTests//spark/views/SortTests.mxml

You can compare the U+5DDD entry.  For me, on my mac it is not the
expected character.  That causes the checkintests to fail to compile.  I
didn't find any key source files that are wrong and could cause trouble
for users, so we could just let it go.

What do others think?
-Alex


On 11/12/17, 3:58 AM, "Piotr Zarzycki"  wrote:

>Hi,
>
>Ok I got it, but I don't fully understand how changing line endings for
>files check outed for sdk repository could change final .tar.gz file.
>Exact
>this file has wrong line endings, or file after unpack have ?
>
>Thanks, Piotr
>
>
>2017-11-12 12:48 GMT+01:00 Justin Mclean :
>
>> Hi,
>>
>> > What do I need to do in build.xml script in order to fix that or your
>> > suggestion is to take this file and do something with it ?
>>
>> I’ve not build on windows for several years so not 100% sure sorry. When
>> building on OSX I’ve not run into the issue.
>>
>> It may actually be a git setting issue in that you are changing line
>> endings to windows on checking out the repo. It’s the autocrlf setting I
>> believe what do you have that set to?
>>
>> Thanks,
>> Justin
>
>
>
>
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C7984b33e692b4fdd4c4108d529c4a6c4
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636460846965406066&sdata=c9l
>IyBHyRDkL3Tq8SpifW4DyyIF9smsaEA4Aerrv%2Fzs%3D&reserved=0
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C7984b33e692b4fdd4c4108d529c4a6c4
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636460846965406066&sdata=c9l
>IyBHyRDkL3Tq8SpifW4DyyIF9smsaEA4Aerrv%2Fzs%3D&reserved=0>*



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

> What is a problem with the release is that the files do not appear to be 
> UTF-8 encoded.  

Which would effect the locale files i.e. the Chinese and Japanese and probably 
French and other european language locales would be broken.

And perhaps some of the keyboard handling code?

Thanks,
Justin



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

> Which would effect the locale files i.e. the Chinese and Japanese and 
> probably French and other european language locales would be broken.

Confirmed it’s an issue and I would also vote -1 binding because of that.

To reproduce just view a DateChooser and you’ll see it has some ? in it’s 
display when using the Chinese and Japanese locales where other characters 
should be.

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
Is the DateChooser problem from your local build of the sources or from
the RC binary artifacts?  I don't doubt that the locale files are not
right, but I would have expected them to be compiled into bundles
correctly on the RM's machine.

-Alex

On 11/13/17, 4:17 PM, "Justin Mclean"  wrote:

>Hi,
>
>> Which would effect the locale files i.e. the Chinese and Japanese and
>>probably French and other european language locales would be broken.
>
>Confirmed it’s an issue and I would also vote -1 binding because of that.
>
>To reproduce just view a DateChooser and you’ll see it has some ? in it’s
>display when using the Chinese and Japanese locales where other
>characters should be.
>
>Thanks,
>Justin



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

> Is the DateChooser problem from your local build of the sources or from
> the RC binary artifacts?

A local built from the compiled source bundled I've not tested the binary yet 
but given it was made from the source release I would expect it to show the 
same issues. Or are you saying that the binary artefact was not made from the 
code in the source release?

Either way it's the source that’s the offical release and it seems unusual to 
release a broken source release even if the binary did work.

Thanks,
Justin



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Hi Justin,

Could you please post screenshot what is wrong cause I don't understand. -
I wanted to compare results of tests between those two RCs.
I will cut another RC, but not because of the issue above, but because I
couldn't run sh script either on my Mac which is not good itself. I would
like to let you know that I build Moonshine IDE sources with the binaries
and it's working perfectly fine.

Thanks, Piotr


2017-11-14 1:17 GMT+01:00 Justin Mclean :

> Hi,
>
> > Which would effect the locale files i.e. the Chinese and Japanese and
> probably French and other european language locales would be broken.
>
> Confirmed it’s an issue and I would also vote -1 binding because of that.
>
> To reproduce just view a DateChooser and you’ll see it has some ? in it’s
> display when using the Chinese and Japanese locales where other characters
> should be.
>
> Thanks,
> Justin




-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

CCed to you just in case it doesn’t show up on the list as it tends to reject 
email with  images.

What it should look like:


What 4.16.1 gives:



There are other similar issues cause by the same issue as well.

Code to replicate:

http://ns.adobe.com/mxml/2009"; 
   xmlns:s="library://ns.adobe.com/flex/spark" 
   xmlns:mx="library://ns.adobe.com/flex/mx">














You need to compile with the right locale i.e. try a not english one.

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
I think I just verified that the binary artifacts are ok regarding the
non-ascii characters.  I think that's because they are correct in the
repo, and were compiled into bundles from that repo source.  I'm not sure
when the files get screwed up.  I think it is when Ant copies the files to
the temp folder to be packaged.  Also, I'm not clear what code page they
are actually in.  I tried using "iconv" on my Mac to convert the files,
but I couldn't find the right source page.

I also ran installer.xml in the binary artifact and found that the scripts
aren't executable.  I looked in the build.xml and installer.xml and do not
see any calls to chmod that would fix that, like there is in the FlexJS
versions of those files.  There are some indications from the archives
that this also has been a problem for as far back as 4.12.

So, my assessment is:
1) the binary artifacts are ok.  No new problems.
2) the source artifacts are not ok.  There might be a workaround if we can
figure out how to convert the code page on those files.
3) Would be nice to fix the executable bit on the scripts, but not a new
problem either.

So, the vast majority of our users may not hit this problem since they
consume the binary artifacts and not the source artifacts.  I'll leave it
up to Piotr as to whether he wants to roll another RC that picks up
changes.  To fix the executable bits, I would recommend looking at how
chmod was used in the FlexJS build.xml and installer.xml.

My 2 cents,
-Alex

On 11/13/17, 10:19 PM, "Piotr Zarzycki"  wrote:

>Hi Justin,
>
>Could you please post screenshot what is wrong cause I don't understand. -
>I wanted to compare results of tests between those two RCs.
>I will cut another RC, but not because of the issue above, but because I
>couldn't run sh script either on my Mac which is not good itself. I would
>like to let you know that I build Moonshine IDE sources with the binaries
>and it's working perfectly fine.
>
>Thanks, Piotr
>
>
>2017-11-14 1:17 GMT+01:00 Justin Mclean :
>
>> Hi,
>>
>> > Which would effect the locale files i.e. the Chinese and Japanese and
>> probably French and other european language locales would be broken.
>>
>> Confirmed it’s an issue and I would also vote -1 binding because of
>>that.
>>
>> To reproduce just view a DateChooser and you’ll see it has some ? in
>>it’s
>> display when using the Chinese and Japanese locales where other
>>characters
>> should be.
>>
>> Thanks,
>> Justin
>
>
>
>
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27bb9f
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462372052361116&sdata=Dc%
>2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27bb9f
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462372052361116&sdata=Dc%
>2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0>*



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui


On 11/13/17, 6:27 PM, "Justin Mclean"  wrote:

>Hi,
>
>> Is the DateChooser problem from your local build of the sources or from
>> the RC binary artifacts?
>
>A local built from the compiled source bundled I've not tested the binary
>yet but given it was made from the source release I would expect it to
>show the same issues. Or are you saying that the binary artefact was not
>made from the code in the source release?

The binaries are not created by first creating the source package,
unpacking it and compiling it.  You were a Flex SDK RM at least once, did
you not understand what you were signing?  The build builds the sources it
got from the repo and assumes that the copy to the temp folder to create
the source package will not modify the files, but it looks like at least
on Windows, Ant will change the character encoding in the copy unless you
use JAVA_TOOL_OPTIONS.  That is something we should figure out how to
prevent in the future, either by documenting how to prevent character
encoding changes or by changing the build script.  And in my tests, the
binary artifact did work correctly.
>
>Either way it's the source that’s the offical release and it seems
>unusual to release a broken source release even if the binary did work.

I was hoping the source files would be valid on Windows, but I just
checked and even there they are not.  I'm guessing that Piotr's default
character encoding for Windows where he lives is different than US
Windows.  I'm not sure there is a workaround to convert those files back
to UTF8 or not.  But given they don't look right in US Windows systems,
unless there is an easy workaround, it might be a good idea to fix this
issue in another RC.

-Alex



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

I would guess that all the issue are git config issues.

git config —list will give you a list of your settings.

> I think I just verified that the binary artifacts are ok regarding the
> non-ascii characters.  I think that's because they are correct in the
> repo, and were compiled into bundles from that repo source.  I'm not sure
> when the files get screwed up. 

When they are checked out I think that’’s happening.

I notice I have in my config:
core.precomposeunicode=false

Re the newline issue I have:
core.autocrlf=false

> I also ran installer.xml in the binary artifact and found that the scripts
> aren't executable.  I looked in the build.xml and installer.xml and do not
> see any calls to chmod that would fix that, like there is in the FlexJS
> versions of those files.  There are some indications from the archives
> that this also has been a problem for as far back as 4.12.

Again git will preserve the execute bit of a file I remember doing this ages 
ago for the .sh files in question

And I think you need this set to preserve it n checkout.
core.filemode=true

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Maxim Solodovnik
.gitattributes file might be created in git repo to unify settings ...

On Tue, Nov 14, 2017 at 1:59 PM, Justin Mclean  wrote:

> Hi,
>
> I would guess that all the issue are git config issues.
>
> git config —list will give you a list of your settings.
>
> > I think I just verified that the binary artifacts are ok regarding the
> > non-ascii characters.  I think that's because they are correct in the
> > repo, and were compiled into bundles from that repo source.  I'm not sure
> > when the files get screwed up.
>
> When they are checked out I think that’’s happening.
>
> I notice I have in my config:
> core.precomposeunicode=false
>
> Re the newline issue I have:
> core.autocrlf=false
>
> > I also ran installer.xml in the binary artifact and found that the
> scripts
> > aren't executable.  I looked in the build.xml and installer.xml and do
> not
> > see any calls to chmod that would fix that, like there is in the FlexJS
> > versions of those files.  There are some indications from the archives
> > that this also has been a problem for as far back as 4.12.
>
> Again git will preserve the execute bit of a file I remember doing this
> ages ago for the .sh files in question
>
> And I think you need this set to preserve it n checkout.
> core.filemode=true
>
> Thanks,
> Justin




-- 
WBR
Maxim aka solomax


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Hi,

I just pushed RC2 [1]. Can you check whether you have the same problem ?

[1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/

Piotr


2017-11-14 7:59 GMT+01:00 Justin Mclean :

> Hi,
>
> I would guess that all the issue are git config issues.
>
> git config —list will give you a list of your settings.
>
> > I think I just verified that the binary artifacts are ok regarding the
> > non-ascii characters.  I think that's because they are correct in the
> > repo, and were compiled into bundles from that repo source.  I'm not sure
> > when the files get screwed up.
>
> When they are checked out I think that’’s happening.
>
> I notice I have in my config:
> core.precomposeunicode=false
>
> Re the newline issue I have:
> core.autocrlf=false
>
> > I also ran installer.xml in the binary artifact and found that the
> scripts
> > aren't executable.  I looked in the build.xml and installer.xml and do
> not
> > see any calls to chmod that would fix that, like there is in the FlexJS
> > versions of those files.  There are some indications from the archives
> > that this also has been a problem for as far back as 4.12.
>
> Again git will preserve the execute bit of a file I remember doing this
> ages ago for the .sh files in question
>
> And I think you need this set to preserve it n checkout.
> core.filemode=true
>
> Thanks,
> Justin




-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Maxim Solodovnik
Just have tried to run `bin/*` files under Ubuntu
Only errors related to missing environment variables are reported

On Tue, Nov 14, 2017 at 2:01 PM, Piotr Zarzycki 
wrote:

> Hi,
>
> I just pushed RC2 [1]. Can you check whether you have the same problem ?
>
> [1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/
>
> Piotr
>
>
> 2017-11-14 7:59 GMT+01:00 Justin Mclean :
>
> > Hi,
> >
> > I would guess that all the issue are git config issues.
> >
> > git config —list will give you a list of your settings.
> >
> > > I think I just verified that the binary artifacts are ok regarding the
> > > non-ascii characters.  I think that's because they are correct in the
> > > repo, and were compiled into bundles from that repo source.  I'm not
> sure
> > > when the files get screwed up.
> >
> > When they are checked out I think that’’s happening.
> >
> > I notice I have in my config:
> > core.precomposeunicode=false
> >
> > Re the newline issue I have:
> > core.autocrlf=false
> >
> > > I also ran installer.xml in the binary artifact and found that the
> > scripts
> > > aren't executable.  I looked in the build.xml and installer.xml and do
> > not
> > > see any calls to chmod that would fix that, like there is in the FlexJS
> > > versions of those files.  There are some indications from the archives
> > > that this also has been a problem for as far back as 4.12.
> >
> > Again git will preserve the execute bit of a file I remember doing this
> > ages ago for the .sh files in question
> >
> > And I think you need this set to preserve it n checkout.
> > core.filemode=true
> >
> > Thanks,
> > Justin
>
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>



-- 
WBR
Maxim aka solomax


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Alex,

I understand what is all about with chmod as it was in FlexJS (not sure
which file should be converted), but I would like to leave it as is now.
Unfortunately I don't understand your last sentence:

"I was hoping the source files would be valid on Windows, but I just
checked and even there they are not.  I'm guessing that Piotr's default
character encoding for Windows where he lives is different than US
Windows.  I'm not sure there is a workaround to convert those files back
to UTF8 or not.  But given they don't look right in US Windows systems,
unless there is an easy workaround, it might be a good idea to fix this
issue in another RC."

I just pushed RC2, where I have checkouted once again whole repository
having all files unchanged in case of line endings. Now sh scripts are
runnable on Mac. I just run also installer.xml and it's working. I will
wait for Justin's look into the pushed RC2 before I officially cut it.

Thanks, Piotr


2017-11-14 7:56 GMT+01:00 Alex Harui :

>
>
> On 11/13/17, 6:27 PM, "Justin Mclean"  wrote:
>
> >Hi,
> >
> >> Is the DateChooser problem from your local build of the sources or from
> >> the RC binary artifacts?
> >
> >A local built from the compiled source bundled I've not tested the binary
> >yet but given it was made from the source release I would expect it to
> >show the same issues. Or are you saying that the binary artefact was not
> >made from the code in the source release?
>
> The binaries are not created by first creating the source package,
> unpacking it and compiling it.  You were a Flex SDK RM at least once, did
> you not understand what you were signing?  The build builds the sources it
> got from the repo and assumes that the copy to the temp folder to create
> the source package will not modify the files, but it looks like at least
> on Windows, Ant will change the character encoding in the copy unless you
> use JAVA_TOOL_OPTIONS.  That is something we should figure out how to
> prevent in the future, either by documenting how to prevent character
> encoding changes or by changing the build script.  And in my tests, the
> binary artifact did work correctly.
> >
> >Either way it's the source that’s the offical release and it seems
> >unusual to release a broken source release even if the binary did work.
>
> I was hoping the source files would be valid on Windows, but I just
> checked and even there they are not.  I'm guessing that Piotr's default
> character encoding for Windows where he lives is different than US
> Windows.  I'm not sure there is a workaround to convert those files back
> to UTF8 or not.  But given they don't look right in US Windows systems,
> unless there is an easy workaround, it might be a good idea to fix this
> issue in another RC.
>
> -Alex
>
>


-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Piotr Zarzycki
Hi Maxim,

Long time no see! :) Thanks for looking into that!

Piotr


2017-11-14 8:15 GMT+01:00 Maxim Solodovnik :

> Just have tried to run `bin/*` files under Ubuntu
> Only errors related to missing environment variables are reported
>
> On Tue, Nov 14, 2017 at 2:01 PM, Piotr Zarzycki  >
> wrote:
>
> > Hi,
> >
> > I just pushed RC2 [1]. Can you check whether you have the same problem ?
> >
> > [1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/
> >
> > Piotr
> >
> >
> > 2017-11-14 7:59 GMT+01:00 Justin Mclean :
> >
> > > Hi,
> > >
> > > I would guess that all the issue are git config issues.
> > >
> > > git config —list will give you a list of your settings.
> > >
> > > > I think I just verified that the binary artifacts are ok regarding
> the
> > > > non-ascii characters.  I think that's because they are correct in the
> > > > repo, and were compiled into bundles from that repo source.  I'm not
> > sure
> > > > when the files get screwed up.
> > >
> > > When they are checked out I think that’’s happening.
> > >
> > > I notice I have in my config:
> > > core.precomposeunicode=false
> > >
> > > Re the newline issue I have:
> > > core.autocrlf=false
> > >
> > > > I also ran installer.xml in the binary artifact and found that the
> > > scripts
> > > > aren't executable.  I looked in the build.xml and installer.xml and
> do
> > > not
> > > > see any calls to chmod that would fix that, like there is in the
> FlexJS
> > > > versions of those files.  There are some indications from the
> archives
> > > > that this also has been a problem for as far back as 4.12.
> > >
> > > Again git will preserve the execute bit of a file I remember doing this
> > > ages ago for the .sh files in question
> > >
> > > And I think you need this set to preserve it n checkout.
> > > core.filemode=true
> > >
> > > Thanks,
> > > Justin
> >
> >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *https://www.patreon.com/piotrzarzycki
> > *
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>



-- 

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
*


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Maxim Solodovnik
I read through almost all emails,
Unfortunately have not much time to contribute more :((

On Tue, Nov 14, 2017 at 2:23 PM, Piotr Zarzycki 
wrote:

> Hi Maxim,
>
> Long time no see! :) Thanks for looking into that!
>
> Piotr
>
>
> 2017-11-14 8:15 GMT+01:00 Maxim Solodovnik :
>
> > Just have tried to run `bin/*` files under Ubuntu
> > Only errors related to missing environment variables are reported
> >
> > On Tue, Nov 14, 2017 at 2:01 PM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com
> > >
> > wrote:
> >
> > > Hi,
> > >
> > > I just pushed RC2 [1]. Can you check whether you have the same problem
> ?
> > >
> > > [1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/
> > >
> > > Piotr
> > >
> > >
> > > 2017-11-14 7:59 GMT+01:00 Justin Mclean :
> > >
> > > > Hi,
> > > >
> > > > I would guess that all the issue are git config issues.
> > > >
> > > > git config —list will give you a list of your settings.
> > > >
> > > > > I think I just verified that the binary artifacts are ok regarding
> > the
> > > > > non-ascii characters.  I think that's because they are correct in
> the
> > > > > repo, and were compiled into bundles from that repo source.  I'm
> not
> > > sure
> > > > > when the files get screwed up.
> > > >
> > > > When they are checked out I think that’’s happening.
> > > >
> > > > I notice I have in my config:
> > > > core.precomposeunicode=false
> > > >
> > > > Re the newline issue I have:
> > > > core.autocrlf=false
> > > >
> > > > > I also ran installer.xml in the binary artifact and found that the
> > > > scripts
> > > > > aren't executable.  I looked in the build.xml and installer.xml and
> > do
> > > > not
> > > > > see any calls to chmod that would fix that, like there is in the
> > FlexJS
> > > > > versions of those files.  There are some indications from the
> > archives
> > > > > that this also has been a problem for as far back as 4.12.
> > > >
> > > > Again git will preserve the execute bit of a file I remember doing
> this
> > > > ages ago for the .sh files in question
> > > >
> > > > And I think you need this set to preserve it n checkout.
> > > > core.filemode=true
> > > >
> > > > Thanks,
> > > > Justin
> > >
> > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *https://www.patreon.com/piotrzarzycki
> > > *
> > >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> *
>



-- 
WBR
Maxim aka solomax


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
If the RC build was run on files that weren't utf-8 encoded, the build
would have failed, since the build runs checkintests and that's where it
first notices the encoding differences.  And then I would expect the
binaries in the RC would be incorrect, which it appears they aren't.

Files are being copied after Git last touches them and I think Ant might
be the culprit.  Piotr can verify by comparing the repo files against what
is in temp after the build.

-Alex

On 11/13/17, 10:59 PM, "Justin Mclean"  wrote:

>Hi,
>
>I would guess that all the issue are git config issues.
>
>git config —list will give you a list of your settings.
>
>> I think I just verified that the binary artifacts are ok regarding the
>> non-ascii characters.  I think that's because they are correct in the
>> repo, and were compiled into bundles from that repo source.  I'm not
>>sure
>> when the files get screwed up.
>
>When they are checked out I think that’’s happening.
>
>I notice I have in my config:
>core.precomposeunicode=false
>
>Re the newline issue I have:
>core.autocrlf=false
>
>> I also ran installer.xml in the binary artifact and found that the
>>scripts
>> aren't executable.  I looked in the build.xml and installer.xml and do
>>not
>> see any calls to chmod that would fix that, like there is in the FlexJS
>> versions of those files.  There are some indications from the archives
>> that this also has been a problem for as far back as 4.12.
>
>Again git will preserve the execute bit of a file I remember doing this
>ages ago for the .sh files in question
>
>And I think you need this set to preserve it n checkout.
>core.filemode=true
>
>Thanks,
>Justin



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

> The binaries are not created by first creating the source package,
> unpacking it and compiling it.  You were a Flex SDK RM at least once, did
> you not understand what you were signing?

Every time I made the release I made it from the source on my local machine on 
a clean tagged branch. I understood 100% what I was signing (for instance see 
[1][2]) and write most of  the scripts to do help make builds [3][4] and 
contributed a lot to the wiki on the instructions on how the build the SDK. [4] 
I was a Flex SDK RM 1/2 dozen times probably more and more than a dozen 
releases in this project.  So I have no idea why you would say “did you not 
understand what you were signing?” and IMO that was uncalled for.

>  I'm not sure there is a workaround to convert those files back
> to UTF8 or not.  

Even if you did find a way it would likely change the md5s and make the 
signatures invalid as converting to UTF8 modifies the file by adding a byte 
order mark at the front of the file.

Thanks,
Justin

1. http://www.apache.org/legal/release-policy.html#owned-controlled-hardware 

2. http://www.apache.org/legal/release-policy.html#compiled-packages 

3. https://github.com/apache/flex-sdk/commits/develop/build 

4. 
https://github.com/apache/flex-sdk/commit/0d69cbea6cea4f70872b8e40436894bcec400adc#diff-b0da275520918e23dd615e2a747528f1
4. 
https://cwiki.apache.org/confluence/display/FLEX/The+SDK+Release+Manager's+Guide
 



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Justin Mclean
Hi,

> I just pushed RC2 [1]. Can you check whether you have the same problem ?
> 
> [1] https://dist.apache.org/repos/dist/dev/flex/sdk/4.16.1/rc2/

Yes I can confirm that the scripts have execute bits.

The files do not have the correct line endings (for instance look at LICENSE)

Re UTF-8 it doesn’t look like the resource files are UTF-8

file --mime frameworks/locale/ja_JP/metadata.properties 
frameworks/locale/ja_JP/metadata.properties: text/plain; charset=unknown-8bit

In the 4.15 release SDK I get:
file --mime frameworks/locale/ja_JP/metadata.properties 
frameworks/locale/ja_JP/metadata.properties: text/plain; charset=utf-8

Thanks,
Justin



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui
Piotr,

If you look at your repo's copy of
frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43 you
should see:

  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);

Note the character before "(U+5DDD)".  It should look like 1 curved line
followed by 2 straight lines.


In the RC1 source package, it looked like this (on Mac):

  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);

Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
(en_US).


I'm wondering, what do you see on your system?  And what do you see in
RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
It could be that on your Windows system, even for RC1 you will see the 1
curved line followed by 2 straight lines.  But I'm pretty sure your Mac
should have the "??" for RC1.  If RC2 has the 1 curved line followed by
two 2 straight lines, then you probably got it right, but I'm more
suspicious of the Ant file manipulation than I am of Git's manipulation of
the files.  

If you don't touch line endings when you pull from Git, you still should
ensure that the Windows .bat files have DOS line endings otherwise they
become hard to read on Windows systems.  I'm not sure the build script is
set up to do that.  It might assume that if you are on Windows, you don't
need to touch the .bat files.

HTH,
-Alex

On 11/13/17, 11:22 PM, "Piotr Zarzycki"  wrote:

>Alex,
>
>I understand what is all about with chmod as it was in FlexJS (not sure
>which file should be converted), but I would like to leave it as is now.
>Unfortunately I don't understand your last sentence:
>
>"I was hoping the source files would be valid on Windows, but I just
>checked and even there they are not.  I'm guessing that Piotr's default
>character encoding for Windows where he lives is different than US
>Windows.  I'm not sure there is a workaround to convert those files back
>to UTF8 or not.  But given they don't look right in US Windows systems,
>unless there is an easy workaround, it might be a good idea to fix this
>issue in another RC."
>
>I just pushed RC2, where I have checkouted once again whole repository
>having all files unchanged in case of line endings. Now sh scripts are
>runnable on Mac. I just run also installer.xml and it's working. I will
>wait for Justin's look into the pushed RC2 before I officially cut it.
>
>Thanks, Piotr
>
>
>2017-11-14 7:56 GMT+01:00 Alex Harui :
>
>>
>>
>> On 11/13/17, 6:27 PM, "Justin Mclean"  wrote:
>>
>> >Hi,
>> >
>> >> Is the DateChooser problem from your local build of the sources or
>>from
>> >> the RC binary artifacts?
>> >
>> >A local built from the compiled source bundled I've not tested the
>>binary
>> >yet but given it was made from the source release I would expect it to
>> >show the same issues. Or are you saying that the binary artefact was
>>not
>> >made from the code in the source release?
>>
>> The binaries are not created by first creating the source package,
>> unpacking it and compiling it.  You were a Flex SDK RM at least once,
>>did
>> you not understand what you were signing?  The build builds the sources
>>it
>> got from the repo and assumes that the copy to the temp folder to create
>> the source package will not modify the files, but it looks like at least
>> on Windows, Ant will change the character encoding in the copy unless
>>you
>> use JAVA_TOOL_OPTIONS.  That is something we should figure out how to
>> prevent in the future, either by documenting how to prevent character
>> encoding changes or by changing the build script.  And in my tests, the
>> binary artifact did work correctly.
>> >
>> >Either way it's the source that’s the offical release and it seems
>> >unusual to release a broken source release even if the binary did work.
>>
>> I was hoping the source files would be valid on Windows, but I just
>> checked and even there they are not.  I'm guessing that Piotr's default
>> character encoding for Windows where he lives is different than US
>> Windows.  I'm not sure there is a workaround to convert those files back
>> to UTF8 or not.  But given they don't look right in US Windows systems,
>> unless there is an easy workaround, it might be a good idea to fix this
>> issue in another RC.
>>
>> -Alex
>>
>>
>
>
>-- 
>
>Piotr Zarzycki
>
>Patreon: 
>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C05fef9a080cd4c323c8b08d52b307cc5
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462409610237907&sdata=Dy2
>BgGtCgZ7r7k%2FricqDFyij5o9KzTSwURSD%2F1un64Q%3D&reserved=0
>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C05fef9a080cd4c323c8b08d52b307cc5
>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462409610237907&sdata=Dy2
>BgGtCgZ7r7k%2FricqDFyij5o9KzTSwURSD%2F1un64Q%3D&reserved=0>*



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-13 Thread Alex Harui


On 11/13/17, 11:34 PM, "Justin Mclean"  wrote:

>Hi,
>
>> The binaries are not created by first creating the source package,
>> unpacking it and compiling it.  You were a Flex SDK RM at least once,
>>did
>> you not understand what you were signing?
>
>Every time I made the release I made it from the source on my local
>machine on a clean tagged branch. I understood 100% what I was signing
>(for instance see [1][2]) and write most of  the scripts to do help make
>builds [3][4] and contributed a lot to the wiki on the instructions on
>how the build the SDK. [4] I was a Flex SDK RM 1/2 dozen times probably
>more and more than a dozen releases in this project.  So I have no idea
>why you would say “did you not understand what you were signing?” and IMO
>that was uncalled for.

Because it sounded like you didn't understand how the build scripts worked.
>
>>  I'm not sure there is a workaround to convert those files back
>> to UTF8 or not. 
>
>Even if you did find a way it would likely change the md5s and make the
>signatures invalid as converting to UTF8 modifies the file by adding a
>byte order mark at the front of the file.

A workaround of converting the files back to UTF8 before compiling would
have nothing to do with md5s and sigs.

-Alex



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread Maxim Solodovnik
I can confirm (using Ubuntu 16.04 latest)

LICENSE file has Windows line endings (which is OK if it was checked-out on
Windows)
both frameworks/locale/ja_JP/metadata.properties
and frameworks/tests/basicTests/spark/views/SortTests.mxml files has
invalid contents (encoding)

I would suggest to create .gitattributes (similar to .gitignore) in case
line endings might be an issue
not sure why UTF-8 files were damaged, there are OK after git clone

On Tue, Nov 14, 2017 at 2:50 PM, Alex Harui 
wrote:

>
>
> On 11/13/17, 11:34 PM, "Justin Mclean"  wrote:
>
> >Hi,
> >
> >> The binaries are not created by first creating the source package,
> >> unpacking it and compiling it.  You were a Flex SDK RM at least once,
> >>did
> >> you not understand what you were signing?
> >
> >Every time I made the release I made it from the source on my local
> >machine on a clean tagged branch. I understood 100% what I was signing
> >(for instance see [1][2]) and write most of  the scripts to do help make
> >builds [3][4] and contributed a lot to the wiki on the instructions on
> >how the build the SDK. [4] I was a Flex SDK RM 1/2 dozen times probably
> >more and more than a dozen releases in this project.  So I have no idea
> >why you would say “did you not understand what you were signing?” and IMO
> >that was uncalled for.
>
> Because it sounded like you didn't understand how the build scripts worked.
> >
> >>  I'm not sure there is a workaround to convert those files back
> >> to UTF8 or not.
> >
> >Even if you did find a way it would likely change the md5s and make the
> >signatures invalid as converting to UTF8 modifies the file by adding a
> >byte order mark at the front of the file.
>
> A workaround of converting the files back to UTF8 before compiling would
> have nothing to do with md5s and sigs.
>
> -Alex
>
>


-- 
WBR
Maxim aka solomax


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread Piotr Zarzycki
Hi Alex,

I'm running out of time for today, but I just look into the:
frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
repository on Windows I see exactly same as you pasted here:

"海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);

But when I unpack on my Windows RC2 sources from zip I see in that file
this one:

[image: Obraz w treści 1]

Can you see screenshot above ?

Thanks, Piotr


2017-11-14 8:47 GMT+01:00 Alex Harui :

> Piotr,
>
> If you look at your repo's copy of
> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43 you
> should see:
>
>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>
> Note the character before "(U+5DDD)".  It should look like 1 curved line
> followed by 2 straight lines.
>
>
> In the RC1 source package, it looked like this (on Mac):
>
>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
>
> Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
> (en_US).
>
>
> I'm wondering, what do you see on your system?  And what do you see in
> RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
> It could be that on your Windows system, even for RC1 you will see the 1
> curved line followed by 2 straight lines.  But I'm pretty sure your Mac
> should have the "??" for RC1.  If RC2 has the 1 curved line followed by
> two 2 straight lines, then you probably got it right, but I'm more
> suspicious of the Ant file manipulation than I am of Git's manipulation of
> the files.
>
> If you don't touch line endings when you pull from Git, you still should
> ensure that the Windows .bat files have DOS line endings otherwise they
> become hard to read on Windows systems.  I'm not sure the build script is
> set up to do that.  It might assume that if you are on Windows, you don't
> need to touch the .bat files.
>
> HTH,
> -Alex
>
> On 11/13/17, 11:22 PM, "Piotr Zarzycki"  wrote:
>
> >Alex,
> >
> >I understand what is all about with chmod as it was in FlexJS (not sure
> >which file should be converted), but I would like to leave it as is now.
> >Unfortunately I don't understand your last sentence:
> >
> >"I was hoping the source files would be valid on Windows, but I just
> >checked and even there they are not.  I'm guessing that Piotr's default
> >character encoding for Windows where he lives is different than US
> >Windows.  I'm not sure there is a workaround to convert those files back
> >to UTF8 or not.  But given they don't look right in US Windows systems,
> >unless there is an easy workaround, it might be a good idea to fix this
> >issue in another RC."
> >
> >I just pushed RC2, where I have checkouted once again whole repository
> >having all files unchanged in case of line endings. Now sh scripts are
> >runnable on Mac. I just run also installer.xml and it's working. I will
> >wait for Justin's look into the pushed RC2 before I officially cut it.
> >
> >Thanks, Piotr
> >
> >
> >2017-11-14 7:56 GMT+01:00 Alex Harui :
> >
> >>
> >>
> >> On 11/13/17, 6:27 PM, "Justin Mclean"  wrote:
> >>
> >> >Hi,
> >> >
> >> >> Is the DateChooser problem from your local build of the sources or
> >>from
> >> >> the RC binary artifacts?
> >> >
> >> >A local built from the compiled source bundled I've not tested the
> >>binary
> >> >yet but given it was made from the source release I would expect it to
> >> >show the same issues. Or are you saying that the binary artefact was
> >>not
> >> >made from the code in the source release?
> >>
> >> The binaries are not created by first creating the source package,
> >> unpacking it and compiling it.  You were a Flex SDK RM at least once,
> >>did
> >> you not understand what you were signing?  The build builds the sources
> >>it
> >> got from the repo and assumes that the copy to the temp folder to create
> >> the source package will not modify the files, but it looks like at least
> >> on Windows, Ant will change the character encoding in the copy unless
> >>you
> >> use JAVA_TOOL_OPTIONS.  That is something we should figure out how to
> >> prevent in the future, either by documenting how to prevent character
> >> encoding changes or by changing the build script.  And in my tests, the
> >> binary artifact did work correctly.
> >> >
> >> >Either way it's the source that’s the offical release and it seems
> >> >unusual to release a broken source release even if the binary did work.
> >>
> >> I was hoping the source files would be valid on Windows, but I just
> >> checked and even there they are not.  I'm guessing that Piotr's default
> >> character encoding for Windows where he lives is different than US
> >> Windows.  I'm not sure there is a workaround to convert those files back
> >> to UTF8 or not.  But given they don't look right in US Windows systems,
> >> unless there is an easy workaround, it might be a good idea to fix this
> >> issue in another RC.
> >>
> >> -Alex
> >>
> >>
> >
> >
> >--
> >
> >Piotr Zarzycki
> >
> >Patreon:
> >*https://na01.safelinks.pro

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread Alex Harui
I couldn't see the screenshot, but I assume it didn't match.  The goal is to 
get it to match.  I still think the issue is the Ant Copy task.  Have you tried 
using the JAVA_TOOL_OPTIONS environment variable?  I know the CI server is 
using it.


-Dfile.encoding=UTF8

Another option you have is to update the build.xml and set the 
outputencoding="utf-8" on all file tasks.  You will know you have it right when 
you can unpack the source package and the characters match up.  Until then, it 
isn't really worth putting out another RC.

Good luck,
-Alex

From: Piotr Zarzycki 
mailto:piotrzarzyck...@gmail.com>>
Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" 
mailto:dev@flex.apache.org>>
Date: Tuesday, November 14, 2017 at 10:06 AM
To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" 
mailto:dev@flex.apache.org>>
Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

Hi Alex,

I'm running out of time for today, but I just look into the: 
frameworks/tests/basicTests/spark/views/SortTests.mxml in my local repository 
on Windows I see exactly same as you pasted here:

"海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);

But when I unpack on my Windows RC2 sources from zip I see in that file this 
one:

[Obraz w treści 1]

Can you see screenshot above ?

Thanks, Piotr


2017-11-14 8:47 GMT+01:00 Alex Harui 
mailto:aha...@adobe.com.invalid>>:
Piotr,

If you look at your repo's copy of
frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43 you
should see:

  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);

Note the character before "(U+5DDD)".  It should look like 1 curved line
followed by 2 straight lines.


In the RC1 source package, it looked like this (on Mac):

  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);

Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
(en_US).


I'm wondering, what do you see on your system?  And what do you see in
RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
It could be that on your Windows system, even for RC1 you will see the 1
curved line followed by 2 straight lines.  But I'm pretty sure your Mac
should have the "??" for RC1.  If RC2 has the 1 curved line followed by
two 2 straight lines, then you probably got it right, but I'm more
suspicious of the Ant file manipulation than I am of Git's manipulation of
the files.

If you don't touch line endings when you pull from Git, you still should
ensure that the Windows .bat files have DOS line endings otherwise they
become hard to read on Windows systems.  I'm not sure the build script is
set up to do that.  It might assume that if you are on Windows, you don't
need to touch the .bat files.

HTH,
-Alex

On 11/13/17, 11:22 PM, "Piotr Zarzycki" 
mailto:piotrzarzyck...@gmail.com>> wrote:

>Alex,
>
>I understand what is all about with chmod as it was in FlexJS (not sure
>which file should be converted), but I would like to leave it as is now.
>Unfortunately I don't understand your last sentence:
>
>"I was hoping the source files would be valid on Windows, but I just
>checked and even there they are not.  I'm guessing that Piotr's default
>character encoding for Windows where he lives is different than US
>Windows.  I'm not sure there is a workaround to convert those files back
>to UTF8 or not.  But given they don't look right in US Windows systems,
>unless there is an easy workaround, it might be a good idea to fix this
>issue in another RC."
>
>I just pushed RC2, where I have checkouted once again whole repository
>having all files unchanged in case of line endings. Now sh scripts are
>runnable on Mac. I just run also installer.xml and it's working. I will
>wait for Justin's look into the pushed RC2 before I officially cut it.
>
>Thanks, Piotr
>
>
>2017-11-14 7:56 GMT+01:00 Alex Harui 
>mailto:aha...@adobe.com.invalid>>:
>
>>
>>
>> On 11/13/17, 6:27 PM, "Justin Mclean" 
>> mailto:justinmcl...@me.com>> wrote:
>>
>> >Hi,
>> >
>> >> Is the DateChooser problem from your local build of the sources or
>>from
>> >> the RC binary artifacts?
>> >
>> >A local built from the compiled source bundled I've not tested the
>>binary
>> >yet but given it was made from the source release I would expect it to
>> >show the same issues. Or are you saying that the binary artefact was
>>not
>> >made from the code in the source release?
>>

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread Par Niclas Hedhman

Alex,
it is called "Open SOURCE" and not "Binary with link to Source" for a reason. 
Apache Software Foundation official only promise SOURCE releases. Any 
convenience binaries are not required/expected. It is not kosher to so called 
release (or make available) any binaries that are not built from an official 
source releases and place them in /dist. That goes against policy and 
infrastructure is likely going to have a strong opinion on the matter, i.e. 
pull the artifacts if found out.

Very simple workflow;
  1. Get your Source Release in order.
  2. Check it and vote
  3. Release it to /dist
  4. Worry about anything else...

Point 4 includes things like "Build binary convenience artifacts from the 
Source release".

HTH
Niclas

On 2017-11-14 14:43, Alex Harui  wrote: 
> I think I just verified that the binary artifacts are ok regarding the
> non-ascii characters.  I think that's because they are correct in the
> repo, and were compiled into bundles from that repo source.  I'm not sure
> when the files get screwed up.  I think it is when Ant copies the files to
> the temp folder to be packaged.  Also, I'm not clear what code page they
> are actually in.  I tried using "iconv" on my Mac to convert the files,
> but I couldn't find the right source page.
> 
> I also ran installer.xml in the binary artifact and found that the scripts
> aren't executable.  I looked in the build.xml and installer.xml and do not
> see any calls to chmod that would fix that, like there is in the FlexJS
> versions of those files.  There are some indications from the archives
> that this also has been a problem for as far back as 4.12.
> 
> So, my assessment is:
> 1) the binary artifacts are ok.  No new problems.
> 2) the source artifacts are not ok.  There might be a workaround if we can
> figure out how to convert the code page on those files.
> 3) Would be nice to fix the executable bit on the scripts, but not a new
> problem either.
> 
> So, the vast majority of our users may not hit this problem since they
> consume the binary artifacts and not the source artifacts.  I'll leave it
> up to Piotr as to whether he wants to roll another RC that picks up
> changes.  To fix the executable bits, I would recommend looking at how
> chmod was used in the FlexJS build.xml and installer.xml.
> 
> My 2 cents,
> -Alex
> 
> On 11/13/17, 10:19 PM, "Piotr Zarzycki"  wrote:
> 
> >Hi Justin,
> >
> >Could you please post screenshot what is wrong cause I don't understand. -
> >I wanted to compare results of tests between those two RCs.
> >I will cut another RC, but not because of the issue above, but because I
> >couldn't run sh script either on my Mac which is not good itself. I would
> >like to let you know that I build Moonshine IDE sources with the binaries
> >and it's working perfectly fine.
> >
> >Thanks, Piotr
> >
> >
> >2017-11-14 1:17 GMT+01:00 Justin Mclean :
> >
> >> Hi,
> >>
> >> > Which would effect the locale files i.e. the Chinese and Japanese and
> >> probably French and other european language locales would be broken.
> >>
> >> Confirmed it’s an issue and I would also vote -1 binding because of
> >>that.
> >>
> >> To reproduce just view a DateChooser and you’ll see it has some ? in
> >>it’s
> >> display when using the Chinese and Japanese locales where other
> >>characters
> >> should be.
> >>
> >> Thanks,
> >> Justin
> >
> >
> >
> >
> >-- 
> >
> >Piotr Zarzycki
> >
> >Patreon: 
> >*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patr
> >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27bb9f
> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462372052361116&sdata=Dc%
> >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0
> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27bb9f
> >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462372052361116&sdata=Dc%
> >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0>*
> 
> 


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread Alex Harui
Niclas,  Where did I say it was "Binary with link to Source?"  Do you
truly understand the issues here or are you just falsely accusing me of
something?  This is the kind of behavior we are supposed to model?  How
about modeling constructive criticism instead.

-Alex

On 11/14/17, 7:50 PM, "Par Niclas Hedhman"  wrote:

>
>Alex,
>it is called "Open SOURCE" and not "Binary with link to Source" for a
>reason. Apache Software Foundation official only promise SOURCE releases.
>Any convenience binaries are not required/expected. It is not kosher to
>so called release (or make available) any binaries that are not built
>from an official source releases and place them in /dist. That goes
>against policy and infrastructure is likely going to have a strong
>opinion on the matter, i.e. pull the artifacts if found out.
>
>Very simple workflow;
>  1. Get your Source Release in order.
>  2. Check it and vote
>  3. Release it to /dist
>  4. Worry about anything else...
>
>Point 4 includes things like "Build binary convenience artifacts from the
>Source release".
>
>HTH
>Niclas
>
>On 2017-11-14 14:43, Alex Harui  wrote:
>> I think I just verified that the binary artifacts are ok regarding the
>> non-ascii characters.  I think that's because they are correct in the
>> repo, and were compiled into bundles from that repo source.  I'm not
>>sure
>> when the files get screwed up.  I think it is when Ant copies the files
>>to
>> the temp folder to be packaged.  Also, I'm not clear what code page they
>> are actually in.  I tried using "iconv" on my Mac to convert the files,
>> but I couldn't find the right source page.
>> 
>> I also ran installer.xml in the binary artifact and found that the
>>scripts
>> aren't executable.  I looked in the build.xml and installer.xml and do
>>not
>> see any calls to chmod that would fix that, like there is in the FlexJS
>> versions of those files.  There are some indications from the archives
>> that this also has been a problem for as far back as 4.12.
>> 
>> So, my assessment is:
>> 1) the binary artifacts are ok.  No new problems.
>> 2) the source artifacts are not ok.  There might be a workaround if we
>>can
>> figure out how to convert the code page on those files.
>> 3) Would be nice to fix the executable bit on the scripts, but not a new
>> problem either.
>> 
>> So, the vast majority of our users may not hit this problem since they
>> consume the binary artifacts and not the source artifacts.  I'll leave
>>it
>> up to Piotr as to whether he wants to roll another RC that picks up
>> changes.  To fix the executable bits, I would recommend looking at how
>> chmod was used in the FlexJS build.xml and installer.xml.
>> 
>> My 2 cents,
>> -Alex
>> 
>> On 11/13/17, 10:19 PM, "Piotr Zarzycki" 
>>wrote:
>> 
>> >Hi Justin,
>> >
>> >Could you please post screenshot what is wrong cause I don't
>>understand. -
>> >I wanted to compare results of tests between those two RCs.
>> >I will cut another RC, but not because of the issue above, but because
>>I
>> >couldn't run sh script either on my Mac which is not good itself. I
>>would
>> >like to let you know that I build Moonshine IDE sources with the
>>binaries
>> >and it's working perfectly fine.
>> >
>> >Thanks, Piotr
>> >
>> >
>> >2017-11-14 1:17 GMT+01:00 Justin Mclean :
>> >
>> >> Hi,
>> >>
>> >> > Which would effect the locale files i.e. the Chinese and Japanese
>>and
>> >> probably French and other european language locales would be broken.
>> >>
>> >> Confirmed it’s an issue and I would also vote -1 binding because of
>> >>that.
>> >>
>> >> To reproduce just view a DateChooser and you’ll see it has some ?
>>in
>> >>it’s
>> >> display when using the Chinese and Japanese locales where other
>> >>characters
>> >> should be.
>> >>
>> >> Thanks,
>> >> Justin
>> >
>> >
>> >
>> >
>> >-- 
>> >
>> >Piotr Zarzycki
>> >
>> >Patreon: 
>> 
>>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa
>>>tr
>> 
>>>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27bb
>>>9f
>> 
>>>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462372052361116&sdata=D
>>>c%
>> >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0
>> 
>>>>>tr
>> 
>>>eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27bb
>>>9f
>> 
>>>%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636462372052361116&sdata=D
>>>c%
>> >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0>*
>> 
>> 



Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread Justin Mclean
Hi,

> Niclas,  Where did I say it was "Binary with link to Source?”

I would assume from your email here:

> So, my assessment is:
> 1) the binary artifacts are ok.  No new problems.
> 2) the source artifacts are not ok.  There might be a workaround if we can
> figure out how to convert the code page on those files.
> 3) Would be nice to fix the executable bit on the scripts, but not a new
> problem either.
> So, the vast majority of our users may not hit this problem since they
> consume the binary artifacts and not the source artifacts.  I'll leave it
> up to Piotr as to whether he wants to roll another RC that picks up
> changes.

i.e. That you were good to release the working binary and broken source 
artefacts together.

I did also raise this as a issue , although perhaps in a less direct way.

> Either way it's the source that’s the offical release and it seems unusual to 
> release a broken source release even if the binary did work.


Given there’s going to be another RC perhaps it would be better to not waste 
energy arguing about this?

Thanks,
Justin

Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-14 Thread OmPrakash Muppirala
On Tue, Nov 14, 2017 at 7:50 PM, Par Niclas Hedhman 
wrote:

>
> Alex,
> it is called "Open SOURCE" and not "Binary with link to Source" for a
> reason. Apache Software Foundation official only promise SOURCE releases.
> Any convenience binaries are not required/expected. It is not kosher to so
> called release (or make available) any binaries that are not built from an
> official source releases and place them in /dist. That goes against policy
> and infrastructure is likely going to have a strong opinion on the matter,
> i.e. pull the artifacts if found out.
>
> Very simple workflow;
>   1. Get your Source Release in order.
>   2. Check it and vote
>   3. Release it to /dist
>   4. Worry about anything else...
>
> Point 4 includes things like "Build binary convenience artifacts from the
> Source release".
>

Niclas,

Apologies if I have missed some context.

Piotr is the release manager here, I am not sure why your email is directed
towards Alex?

Quoting Alex:  "But given they don't look right in US Windows systems, unless
there is an easy workaround, it might be a good idea to fix this issue in
another RC."

As you can see in this thread, we are trying to figure out where the source
package gets messed up and we are trying to fix it.  While your input is
appreciated, I think your tone is a bit confrontational.

Thanks,
Om


>
> HTH
> Niclas
>
> On 2017-11-14 14:43, Alex Harui  wrote:
> > I think I just verified that the binary artifacts are ok regarding the
> > non-ascii characters.  I think that's because they are correct in the
> > repo, and were compiled into bundles from that repo source.  I'm not sure
> > when the files get screwed up.  I think it is when Ant copies the files
> to
> > the temp folder to be packaged.  Also, I'm not clear what code page they
> > are actually in.  I tried using "iconv" on my Mac to convert the files,
> > but I couldn't find the right source page.
> >
> > I also ran installer.xml in the binary artifact and found that the
> scripts
> > aren't executable.  I looked in the build.xml and installer.xml and do
> not
> > see any calls to chmod that would fix that, like there is in the FlexJS
> > versions of those files.  There are some indications from the archives
> > that this also has been a problem for as far back as 4.12.
> >
> > So, my assessment is:
> > 1) the binary artifacts are ok.  No new problems.
> > 2) the source artifacts are not ok.  There might be a workaround if we
> can
> > figure out how to convert the code page on those files.
> > 3) Would be nice to fix the executable bit on the scripts, but not a new
> > problem either.
> >
> > So, the vast majority of our users may not hit this problem since they
> > consume the binary artifacts and not the source artifacts.  I'll leave it
> > up to Piotr as to whether he wants to roll another RC that picks up
> > changes.  To fix the executable bits, I would recommend looking at how
> > chmod was used in the FlexJS build.xml and installer.xml.
> >
> > My 2 cents,
> > -Alex
> >
> > On 11/13/17, 10:19 PM, "Piotr Zarzycki" 
> wrote:
> >
> > >Hi Justin,
> > >
> > >Could you please post screenshot what is wrong cause I don't
> understand. -
> > >I wanted to compare results of tests between those two RCs.
> > >I will cut another RC, but not because of the issue above, but because I
> > >couldn't run sh script either on my Mac which is not good itself. I
> would
> > >like to let you know that I build Moonshine IDE sources with the
> binaries
> > >and it's working perfectly fine.
> > >
> > >Thanks, Piotr
> > >
> > >
> > >2017-11-14 1:17 GMT+01:00 Justin Mclean :
> > >
> > >> Hi,
> > >>
> > >> > Which would effect the locale files i.e. the Chinese and Japanese
> and
> > >> probably French and other european language locales would be broken.
> > >>
> > >> Confirmed it’s an issue and I would also vote -1 binding because of
> > >>that.
> > >>
> > >> To reproduce just view a DateChooser and you’ll see it has some ? in
> > >>it’s
> > >> display when using the Chinese and Japanese locales where other
> > >>characters
> > >> should be.
> > >>
> > >> Thanks,
> > >> Justin
> > >
> > >
> > >
> > >
> > >--
> > >
> > >Piotr Zarzycki
> > >
> > >Patreon:
> > >*https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fwww.patr
> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27
> bb9f
> > >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636462372052361116&sdata=Dc%
> > >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0
> > > https%3A%2F%2Fwww.patr
> > >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27
> bb9f
> > >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636462372052361116&sdata=Dc%
> > >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0>*
> >
> >
>


Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-15 Thread Piotr Zarzycki
Hi Alex,

I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will cut
another RC very soon!

Piotr

2017-11-14 19:26 GMT+01:00 Alex Harui :

> I couldn't see the screenshot, but I assume it didn't match.  The goal is
> to get it to match.  I still think the issue is the Ant Copy task.  Have
> you tried using the JAVA_TOOL_OPTIONS environment variable?  I know the CI
> server is using it.
>
>
> -Dfile.encoding=UTF8
>
> Another option you have is to update the build.xml and set the
> outputencoding="utf-8" on all file tasks.  You will know you have it right
> when you can unpack the source package and the characters match up.  Until
> then, it isn't really worth putting out another RC.
>
> Good luck,
> -Alex
>
> From: Piotr Zarzycki  piotrzarzyck...@gmail.com>>
> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
> dev@flex.apache.org<mailto:dev@flex.apache.org>>
> Date: Tuesday, November 14, 2017 at 10:06 AM
> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>"  <mailto:dev@flex.apache.org>>
> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
>
> Hi Alex,
>
> I'm running out of time for today, but I just look into the:
> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
> repository on Windows I see exactly same as you pasted here:
>
> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>
> But when I unpack on my Windows RC2 sources from zip I see in that file
> this one:
>
> [Obraz w treści 1]
>
> Can you see screenshot above ?
>
> Thanks, Piotr
>
>
> 2017-11-14 8:47 GMT+01:00 Alex Harui  aha...@adobe.com.invalid>>:
> Piotr,
>
> If you look at your repo's copy of
> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43 you
> should see:
>
>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>
> Note the character before "(U+5DDD)".  It should look like 1 curved line
> followed by 2 straight lines.
>
>
> In the RC1 source package, it looked like this (on Mac):
>
>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
>
> Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
> (en_US).
>
>
> I'm wondering, what do you see on your system?  And what do you see in
> RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
> It could be that on your Windows system, even for RC1 you will see the 1
> curved line followed by 2 straight lines.  But I'm pretty sure your Mac
> should have the "??" for RC1.  If RC2 has the 1 curved line followed by
> two 2 straight lines, then you probably got it right, but I'm more
> suspicious of the Ant file manipulation than I am of Git's manipulation of
> the files.
>
> If you don't touch line endings when you pull from Git, you still should
> ensure that the Windows .bat files have DOS line endings otherwise they
> become hard to read on Windows systems.  I'm not sure the build script is
> set up to do that.  It might assume that if you are on Windows, you don't
> need to touch the .bat files.
>
> HTH,
> -Alex
>
> On 11/13/17, 11:22 PM, "Piotr Zarzycki"  piotrzarzyck...@gmail.com>> wrote:
>
> >Alex,
> >
> >I understand what is all about with chmod as it was in FlexJS (not sure
> >which file should be converted), but I would like to leave it as is now.
> >Unfortunately I don't understand your last sentence:
> >
> >"I was hoping the source files would be valid on Windows, but I just
> >checked and even there they are not.  I'm guessing that Piotr's default
> >character encoding for Windows where he lives is different than US
> >Windows.  I'm not sure there is a workaround to convert those files back
> >to UTF8 or not.  But given they don't look right in US Windows systems,
> >unless there is an easy workaround, it might be a good idea to fix this
> >issue in another RC."
> >
> >I just pushed RC2, where I have checkouted once again whole repository
> >having all files unchanged in case of line endings. Now sh scripts are
> >runnable on Mac. I just run also installer.xml and it's working. I will
> >wait for Justin's look into the pushed RC2 before I officially cut it.
> >
> >Thanks, Piotr
> >
> >
> >2017-11-14 7:56 GMT+01:00 Alex Harui  aha...@adobe.com.invalid>>:
> >
> >>
> >&

[CANCEL][DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-15 Thread Piotr Zarzycki
Another RC is coming. Cancel this one.

2017-11-15 9:04 GMT+01:00 Piotr Zarzycki :

> Hi Alex,
>
> I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will cut
> another RC very soon!
>
> Piotr
>
> 2017-11-14 19:26 GMT+01:00 Alex Harui :
>
>> I couldn't see the screenshot, but I assume it didn't match.  The goal is
>> to get it to match.  I still think the issue is the Ant Copy task.  Have
>> you tried using the JAVA_TOOL_OPTIONS environment variable?  I know the CI
>> server is using it.
>>
>>
>> -Dfile.encoding=UTF8
>>
>> Another option you have is to update the build.xml and set the
>> outputencoding="utf-8" on all file tasks.  You will know you have it right
>> when you can unpack the source package and the characters match up.  Until
>> then, it isn't really worth putting out another RC.
>>
>> Good luck,
>> -Alex
>>
>> From: Piotr Zarzycki > piotrzarzyck...@gmail.com>>
>> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
>> dev@flex.apache.org<mailto:dev@flex.apache.org>>
>> Date: Tuesday, November 14, 2017 at 10:06 AM
>> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
>> dev@flex.apache.org<mailto:dev@flex.apache.org>>
>> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
>>
>> Hi Alex,
>>
>> I'm running out of time for today, but I just look into the:
>> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
>> repository on Windows I see exactly same as you pasted here:
>>
>> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>>
>> But when I unpack on my Windows RC2 sources from zip I see in that file
>> this one:
>>
>> [Obraz w treści 1]
>>
>> Can you see screenshot above ?
>>
>> Thanks, Piotr
>>
>>
>> 2017-11-14 8:47 GMT+01:00 Alex Harui > aha...@adobe.com.invalid>>:
>> Piotr,
>>
>> If you look at your repo's copy of
>> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43
>> you
>> should see:
>>
>>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>>
>> Note the character before "(U+5DDD)".  It should look like 1 curved line
>> followed by 2 straight lines.
>>
>>
>> In the RC1 source package, it looked like this (on Mac):
>>
>>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
>>
>> Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
>> (en_US).
>>
>>
>> I'm wondering, what do you see on your system?  And what do you see in
>> RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
>> It could be that on your Windows system, even for RC1 you will see the 1
>> curved line followed by 2 straight lines.  But I'm pretty sure your Mac
>> should have the "??" for RC1.  If RC2 has the 1 curved line followed by
>> two 2 straight lines, then you probably got it right, but I'm more
>> suspicious of the Ant file manipulation than I am of Git's manipulation of
>> the files.
>>
>> If you don't touch line endings when you pull from Git, you still should
>> ensure that the Windows .bat files have DOS line endings otherwise they
>> become hard to read on Windows systems.  I'm not sure the build script is
>> set up to do that.  It might assume that if you are on Windows, you don't
>> need to touch the .bat files.
>>
>> HTH,
>> -Alex
>>
>> On 11/13/17, 11:22 PM, "Piotr Zarzycki" > lto:piotrzarzyck...@gmail.com>> wrote:
>>
>> >Alex,
>> >
>> >I understand what is all about with chmod as it was in FlexJS (not sure
>> >which file should be converted), but I would like to leave it as is now.
>> >Unfortunately I don't understand your last sentence:
>> >
>> >"I was hoping the source files would be valid on Windows, but I just
>> >checked and even there they are not.  I'm guessing that Piotr's default
>> >character encoding for Windows where he lives is different than US
>> >Windows.  I'm not sure there is a workaround to convert those files back
>> >to UTF8 or not.  But given they don't look right in US Windows systems,
>> >unless there is an easy workaround, it might be a g

Re: [CANCEL][DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-15 Thread Maxim Solodovnik
maybe this JAVA_TOOL_OPTIONS can be added to ant build as 
wrote:

> Another RC is coming. Cancel this one.
>
> 2017-11-15 9:04 GMT+01:00 Piotr Zarzycki :
>
> > Hi Alex,
> >
> > I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will cut
> > another RC very soon!
> >
> > Piotr
> >
> > 2017-11-14 19:26 GMT+01:00 Alex Harui :
> >
> >> I couldn't see the screenshot, but I assume it didn't match.  The goal
> is
> >> to get it to match.  I still think the issue is the Ant Copy task.  Have
> >> you tried using the JAVA_TOOL_OPTIONS environment variable?  I know the
> CI
> >> server is using it.
> >>
> >>
> >> -Dfile.encoding=UTF8
> >>
> >> Another option you have is to update the build.xml and set the
> >> outputencoding="utf-8" on all file tasks.  You will know you have it
> right
> >> when you can unpack the source package and the characters match up.
> Until
> >> then, it isn't really worth putting out another RC.
> >>
> >> Good luck,
> >> -Alex
> >>
> >> From: Piotr Zarzycki  >> piotrzarzyck...@gmail.com>>
> >> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
> >> dev@flex.apache.org<mailto:dev@flex.apache.org>>
> >> Date: Tuesday, November 14, 2017 at 10:06 AM
> >> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
> >> dev@flex.apache.org<mailto:dev@flex.apache.org>>
> >> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
> >>
> >> Hi Alex,
> >>
> >> I'm running out of time for today, but I just look into the:
> >> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
> >> repository on Windows I see exactly same as you pasted here:
> >>
> >> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
> >>
> >> But when I unpack on my Windows RC2 sources from zip I see in that file
> >> this one:
> >>
> >> [Obraz w treści 1]
> >>
> >> Can you see screenshot above ?
> >>
> >> Thanks, Piotr
> >>
> >>
> >> 2017-11-14 8:47 GMT+01:00 Alex Harui  >> aha...@adobe.com.invalid>>:
> >> Piotr,
> >>
> >> If you look at your repo's copy of
> >> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43
> >> you
> >> should see:
> >>
> >>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
> >>
> >> Note the character before "(U+5DDD)".  It should look like 1 curved line
> >> followed by 2 straight lines.
> >>
> >>
> >> In the RC1 source package, it looked like this (on Mac):
> >>
> >>   "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
> >>
> >> Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
> >> (en_US).
> >>
> >>
> >> I'm wondering, what do you see on your system?  And what do you see in
> >> RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
> >> It could be that on your Windows system, even for RC1 you will see the 1
> >> curved line followed by 2 straight lines.  But I'm pretty sure your Mac
> >> should have the "??" for RC1.  If RC2 has the 1 curved line followed by
> >> two 2 straight lines, then you probably got it right, but I'm more
> >> suspicious of the Ant file manipulation than I am of Git's manipulation
> of
> >> the files.
> >>
> >> If you don't touch line endings when you pull from Git, you still should
> >> ensure that the Windows .bat files have DOS line endings otherwise they
> >> become hard to read on Windows systems.  I'm not sure the build script
> is
> >> set up to do that.  It might assume that if you are on Windows, you
> don't
> >> need to touch the .bat files.
> >>
> >> HTH,
> >> -Alex
> >>
> >> On 11/13/17, 11:22 PM, "Piotr Zarzycki"  >> lto:piotrzarzyck...@gmail.com>> wrote:
> >>
> >> >Alex,
> >> >
> >> >I understand what is all about with chmod as it was in FlexJS (not sure
> >> >which file should be converted), but I would like to leav

Re: [CANCEL][DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-15 Thread Harbs
+1.

Definitely a good idea if it’ll work.

> On Nov 15, 2017, at 11:18 AM, Maxim Solodovnik  wrote:
> 
> maybe this JAVA_TOOL_OPTIONS can be added to ant build as  
> To avoid such issue in the future?
> 
> On Wed, Nov 15, 2017 at 4:09 PM, Piotr Zarzycki 
> wrote:
> 
>> Another RC is coming. Cancel this one.
>> 
>> 2017-11-15 9:04 GMT+01:00 Piotr Zarzycki :
>> 
>>> Hi Alex,
>>> 
>>> I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will cut
>>> another RC very soon!
>>> 
>>> Piotr
>>> 
>>> 2017-11-14 19:26 GMT+01:00 Alex Harui :
>>> 
>>>> I couldn't see the screenshot, but I assume it didn't match.  The goal
>> is
>>>> to get it to match.  I still think the issue is the Ant Copy task.  Have
>>>> you tried using the JAVA_TOOL_OPTIONS environment variable?  I know the
>> CI
>>>> server is using it.
>>>> 
>>>> 
>>>>-Dfile.encoding=UTF8
>>>> 
>>>> Another option you have is to update the build.xml and set the
>>>> outputencoding="utf-8" on all file tasks.  You will know you have it
>> right
>>>> when you can unpack the source package and the characters match up.
>> Until
>>>> then, it isn't really worth putting out another RC.
>>>> 
>>>> Good luck,
>>>> -Alex
>>>> 
>>>> From: Piotr Zarzycki >>> piotrzarzyck...@gmail.com>>
>>>> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
>>>> dev@flex.apache.org<mailto:dev@flex.apache.org>>
>>>> Date: Tuesday, November 14, 2017 at 10:06 AM
>>>> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
>>>> dev@flex.apache.org<mailto:dev@flex.apache.org>>
>>>> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
>>>> 
>>>> Hi Alex,
>>>> 
>>>> I'm running out of time for today, but I just look into the:
>>>> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
>>>> repository on Windows I see exactly same as you pasted here:
>>>> 
>>>> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>>>> 
>>>> But when I unpack on my Windows RC2 sources from zip I see in that file
>>>> this one:
>>>> 
>>>> [Obraz w treści 1]
>>>> 
>>>> Can you see screenshot above ?
>>>> 
>>>> Thanks, Piotr
>>>> 
>>>> 
>>>> 2017-11-14 8:47 GMT+01:00 Alex Harui >>> aha...@adobe.com.invalid>>:
>>>> Piotr,
>>>> 
>>>> If you look at your repo's copy of
>>>> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line 43
>>>> you
>>>> should see:
>>>> 
>>>>  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>>>> 
>>>> Note the character before "(U+5DDD)".  It should look like 1 curved line
>>>> followed by 2 straight lines.
>>>> 
>>>> 
>>>> In the RC1 source package, it looked like this (on Mac):
>>>> 
>>>>  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
>>>> 
>>>> Note the "??" before "(U+5DDD)".  And it also wasn't right on Windows
>>>> (en_US).
>>>> 
>>>> 
>>>> I'm wondering, what do you see on your system?  And what do you see in
>>>> RC2?  I haven't looked yet, and I'm pretty much out of time for tonight.
>>>> It could be that on your Windows system, even for RC1 you will see the 1
>>>> curved line followed by 2 straight lines.  But I'm pretty sure your Mac
>>>> should have the "??" for RC1.  If RC2 has the 1 curved line followed by
>>>> two 2 straight lines, then you probably got it right, but I'm more
>>>> suspicious of the Ant file manipulation than I am of Git's manipulation
>> of
>>>> the files.
>>>> 
>>>> If you don't touch line endings when you pull from Git, you still should
>>>> ensure that the Windows .bat files have DOS line endings otherwise they
>>>> become hard to read on Windows systems.  I'm not sure the build scri

Re: [CANCEL][DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*

2017-11-15 Thread Alex Harui
Pretty sure it doesn't work without an Ant extension that sets environment
variables, and there used to be pushback against using Ant extensions in
our build scripts.

What should work is setting outputencoding on the Copy and maybe Move
tasks in our scripts.  We just need a volunteer to try it.  I"ll probably
try it on the next Royale release.  I think 4.16.1 was the first Apache
Flex release where the packaging was done on Windows instead of Mac which
is why we ran into this issue.

-Alex

On 11/15/17, 7:09 AM, "Harbs"  wrote:

>+1.
>
>Definitely a good idea if it’ll work.
>
>> On Nov 15, 2017, at 11:18 AM, Maxim Solodovnik 
>>wrote:
>> 
>> maybe this JAVA_TOOL_OPTIONS can be added to ant build as > 
>> To avoid such issue in the future?
>> 
>> On Wed, Nov 15, 2017 at 4:09 PM, Piotr Zarzycki
>>
>> wrote:
>> 
>>> Another RC is coming. Cancel this one.
>>> 
>>> 2017-11-15 9:04 GMT+01:00 Piotr Zarzycki :
>>> 
>>>> Hi Alex,
>>>> 
>>>> I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will
>>>>cut
>>>> another RC very soon!
>>>> 
>>>> Piotr
>>>> 
>>>> 2017-11-14 19:26 GMT+01:00 Alex Harui :
>>>> 
>>>>> I couldn't see the screenshot, but I assume it didn't match.  The
>>>>>goal
>>> is
>>>>> to get it to match.  I still think the issue is the Ant Copy task.
>>>>>Have
>>>>> you tried using the JAVA_TOOL_OPTIONS environment variable?  I know
>>>>>the
>>> CI
>>>>> server is using it.
>>>>> 
>>>>> 
>>>>>-Dfile.encoding=UTF8
>>>>> 
>>>>> Another option you have is to update the build.xml and set the
>>>>> outputencoding="utf-8" on all file tasks.  You will know you have it
>>> right
>>>>> when you can unpack the source package and the characters match up.
>>> Until
>>>>> then, it isn't really worth putting out another RC.
>>>>> 
>>>>> Good luck,
>>>>> -Alex
>>>>> 
>>>>> From: Piotr Zarzycki >>>> piotrzarzyck...@gmail.com>>
>>>>> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
>>>>> dev@flex.apache.org<mailto:dev@flex.apache.org>>
>>>>> Date: Tuesday, November 14, 2017 at 10:06 AM
>>>>> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" <
>>>>> dev@flex.apache.org<mailto:dev@flex.apache.org>>
>>>>> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1*
>>>>> 
>>>>> Hi Alex,
>>>>> 
>>>>> I'm running out of time for today, but I just look into the:
>>>>> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local
>>>>> repository on Windows I see exactly same as you pasted here:
>>>>> 
>>>>> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>>>>> 
>>>>> But when I unpack on my Windows RC2 sources from zip I see in that
>>>>>file
>>>>> this one:
>>>>> 
>>>>> [Obraz w treści 1]
>>>>> 
>>>>> Can you see screenshot above ?
>>>>> 
>>>>> Thanks, Piotr
>>>>> 
>>>>> 
>>>>> 2017-11-14 8:47 GMT+01:00 Alex Harui
>>>>>>>>> aha...@adobe.com.invalid>>:
>>>>> Piotr,
>>>>> 
>>>>> If you look at your repo's copy of
>>>>> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line
>>>>>43
>>>>> you
>>>>> should see:
>>>>> 
>>>>>  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]);
>>>>> 
>>>>> Note the character before "(U+5DDD)".  It should look like 1 curved
>>>>>line
>>>>> followed by 2 straight lines.
>>>>> 
>>>>> 
>>>>> In the RC1 source package, it looked like this (on Mac):
>>>>> 
>>>>>  "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]);
>>>>> 
>>>>> Note the "??" before "(U+5DDD)".  And