[DISCUSS] flex-antTasks: HtmlWrapperTask

2013-12-09 Thread Stephan Plath 
The current version of the Ant html-wrapper task doesn't supports to use 
external files. Instead it only uses its embedded template resources


- /history
  - history.css
  - history.js
  - historyFrame.html
- expressInstall.swf
- index.template.html
- swfobject.js

I added a wrapperFile parameter to the HtmlWrapperTask, so I can use a 
project specific HTML wrapper file. That's fine for me and is working 
faultless.


The question is now: Would it be more reasonable to parameterize the 
entire directory (templateDir) instead of only doing it for the HTML 
template? Or should it be possible to use both - either templateDir or 
wrapperFile?


Thanks, Stephan

Re: [DISCUSS] flex-antTasks: HtmlWrapperTask

2013-12-09 Thread Mr. Rich 
Personally, I've always used ant to automate the wrappers.

Just my 2 cents.
On Dec 9, 2013 4:17 AM, Stephan Plath flex-...@gmx.net wrote:

 The current version of the Ant html-wrapper task doesn't supports to use
 external files. Instead it only uses its embedded template resources

 - /history
   - history.css
   - history.js
   - historyFrame.html
 - expressInstall.swf
 - index.template.html
 - swfobject.js

 I added a wrapperFile parameter to the HtmlWrapperTask, so I can use a
 project specific HTML wrapper file. That's fine for me and is working
 faultless.

 The question is now: Would it be more reasonable to parameterize the
 entire directory (templateDir) instead of only doing it for the HTML
 template? Or should it be possible to use both - either templateDir or
 wrapperFile?

 Thanks, Stephan

Re: [DISCUSS] flex-antTasks: HtmlWrapperTask

2013-12-09 Thread Mr. Rich 
While you're in ant, automate your project assets also.  Setup a main
workspace asset repo, pull files from there.

Another good trick, if you have multiple projects that work together, use
ant to create a main output folder and compile files there.
On Dec 9, 2013 4:17 AM, Stephan Plath flex-...@gmx.net wrote:

 The current version of the Ant html-wrapper task doesn't supports to use
 external files. Instead it only uses its embedded template resources

 - /history
   - history.css
   - history.js
   - historyFrame.html
 - expressInstall.swf
 - index.template.html
 - swfobject.js

 I added a wrapperFile parameter to the HtmlWrapperTask, so I can use a
 project specific HTML wrapper file. That's fine for me and is working
 faultless.

 The question is now: Would it be more reasonable to parameterize the
 entire directory (templateDir) instead of only doing it for the HTML
 template? Or should it be possible to use both - either templateDir or
 wrapperFile?

 Thanks, Stephan

Re: [DISCUSS] flex-antTasks: HtmlWrapperTask

2013-12-09 Thread Stephan Plath 

Am 09.12.2013 15:32, schrieb Mr. Rich:

Personally, I've always used ant to automate the wrappers.


The Flex SDK is released together with 
${FLEX_HOME}/ant/lib/flexTasks.jar which provides the following ant tasks


mxmlc=flex.ant.MxmlcTask
compc=flex.ant.CompcTask
html-wrapper=flex.ant.HtmlWrapperTask
asdoc=flex.ant.AsDocTask

I want to contribute to the HtmlWrapperTask.java with one or two 
properties which enable the definition of external templates instead of 
using the embedded files. This is merely a tiny enhancement and most 
likely or minor interest, but accordingly to the committers wiki section 
and my understanding of it, new features should be discussed before 
committing.


So the questions is just, what others would prefer how the external 
template files should be parameterized or should I just commit the 
changes so they fit my own needs?


Thanks, Stephan

Re: [DISCUSS] flex-antTasks: HtmlWrapperTask

2013-12-09 Thread Alex Harui 
IMO, you are welcome to do more, but as long as you don't break existing
functionality, or make it harder to make improvements later, doing just
what you need is completely acceptable, so I think your current set of
proposed changes is fine.

-Alex

On 12/9/13 8:02 AM, Stephan Plath flex-...@gmx.net wrote:

Am 09.12.2013 15:32, schrieb Mr. Rich:
 Personally, I've always used ant to automate the wrappers.

The Flex SDK is released together with
${FLEX_HOME}/ant/lib/flexTasks.jar which provides the following ant tasks

mxmlc=flex.ant.MxmlcTask
compc=flex.ant.CompcTask
html-wrapper=flex.ant.HtmlWrapperTask
asdoc=flex.ant.AsDocTask

I want to contribute to the HtmlWrapperTask.java with one or two
properties which enable the definition of external templates instead of
using the embedded files. This is merely a tiny enhancement and most
likely or minor interest, but accordingly to the committers wiki section
and my understanding of it, new features should be discussed before
committing.

So the questions is just, what others would prefer how the external
template files should be parameterized or should I just commit the
changes so they fit my own needs?

Thanks, Stephan