Re: [DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-07-09 Thread Wenhao Ji
Thank everyone for participating in this discussion! The improvement
has been accepted now.
Can someone kindly assign this ticket FLINK-22452 [1] to me? I would
like to start to implement this feature.

[1] https://issues.apache.org/jira/browse/FLINK-22452

Thanks,
Wenhao

On Mon, Jun 28, 2021 at 6:32 PM Stephan Ewen  wrote:
>
> Sounds good from my side, please go ahead.
>
> On Fri, Jun 25, 2021 at 5:31 PM Wenhao Ji  wrote:
>>
>> Thanks Stephan and Piotr for your replies. It seems that there is no
>> problem or concern about this feature. If there is no further
>> objection, I will start a vote thread for FLIP-172.
>>
>> Thanks,
>> Wenhao
>>
>> On Wed, Jun 23, 2021 at 3:41 PM Piotr Nowojski  wrote:
>> >
>> > Hi,
>> >
>> > +1 from my side on this idea. I do not see any problems that could be
>> > caused by this change.
>> >
>> > Best,
>> > Piotrek
>> >
>> > śr., 23 cze 2021 o 08:59 Stephan Ewen  napisał(a):
>> >
>> > > The motivation and the proposal sound good to me, +1 from my side.
>> > >
>> > > Would be good to have a quick opinion from someone who worked 
>> > > specifically
>> > > with Kafka, maybe Becket or Piotr?
>> > >
>> > > Best,
>> > > Stephan
>> > >
>> > >
>> > > On Sat, Jun 12, 2021 at 9:50 AM Wenhao Ji  wrote:
>> > >
>> > >> Hi everyone,
>> > >>
>> > >> I would like to open this discussion thread to take about the FLIP-172
>> > >> <
>> > >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-172%3A+Support+custom+transactional.id+prefix+in+FlinkKafkaProducer
>> > >> >,
>> > >> which aims to provide a way to support specifying a custom
>> > >> transactional.id
>> > >> in the FlinkKafkaProducer class.
>> > >>
>> > >> I am looking forwards to your feedback and suggestions!
>> > >>
>> > >> Thanks,
>> > >> Wenhao
>> > >>
>> > >


Re: [DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-06-28 Thread Stephan Ewen
Sounds good from my side, please go ahead.

On Fri, Jun 25, 2021 at 5:31 PM Wenhao Ji  wrote:

> Thanks Stephan and Piotr for your replies. It seems that there is no
> problem or concern about this feature. If there is no further
> objection, I will start a vote thread for FLIP-172.
>
> Thanks,
> Wenhao
>
> On Wed, Jun 23, 2021 at 3:41 PM Piotr Nowojski 
> wrote:
> >
> > Hi,
> >
> > +1 from my side on this idea. I do not see any problems that could be
> > caused by this change.
> >
> > Best,
> > Piotrek
> >
> > śr., 23 cze 2021 o 08:59 Stephan Ewen  napisał(a):
> >
> > > The motivation and the proposal sound good to me, +1 from my side.
> > >
> > > Would be good to have a quick opinion from someone who worked
> specifically
> > > with Kafka, maybe Becket or Piotr?
> > >
> > > Best,
> > > Stephan
> > >
> > >
> > > On Sat, Jun 12, 2021 at 9:50 AM Wenhao Ji 
> wrote:
> > >
> > >> Hi everyone,
> > >>
> > >> I would like to open this discussion thread to take about the FLIP-172
> > >> <
> > >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-172%3A+Support+custom+transactional.id+prefix+in+FlinkKafkaProducer
> > >> >,
> > >> which aims to provide a way to support specifying a custom
> > >> transactional.id
> > >> in the FlinkKafkaProducer class.
> > >>
> > >> I am looking forwards to your feedback and suggestions!
> > >>
> > >> Thanks,
> > >> Wenhao
> > >>
> > >
>


Re: [DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-06-25 Thread Wenhao Ji
Thanks Stephan and Piotr for your replies. It seems that there is no
problem or concern about this feature. If there is no further
objection, I will start a vote thread for FLIP-172.

Thanks,
Wenhao

On Wed, Jun 23, 2021 at 3:41 PM Piotr Nowojski  wrote:
>
> Hi,
>
> +1 from my side on this idea. I do not see any problems that could be
> caused by this change.
>
> Best,
> Piotrek
>
> śr., 23 cze 2021 o 08:59 Stephan Ewen  napisał(a):
>
> > The motivation and the proposal sound good to me, +1 from my side.
> >
> > Would be good to have a quick opinion from someone who worked specifically
> > with Kafka, maybe Becket or Piotr?
> >
> > Best,
> > Stephan
> >
> >
> > On Sat, Jun 12, 2021 at 9:50 AM Wenhao Ji  wrote:
> >
> >> Hi everyone,
> >>
> >> I would like to open this discussion thread to take about the FLIP-172
> >> <
> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-172%3A+Support+custom+transactional.id+prefix+in+FlinkKafkaProducer
> >> >,
> >> which aims to provide a way to support specifying a custom
> >> transactional.id
> >> in the FlinkKafkaProducer class.
> >>
> >> I am looking forwards to your feedback and suggestions!
> >>
> >> Thanks,
> >> Wenhao
> >>
> >


Re: [DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-06-23 Thread Piotr Nowojski
Hi,

+1 from my side on this idea. I do not see any problems that could be
caused by this change.

Best,
Piotrek

śr., 23 cze 2021 o 08:59 Stephan Ewen  napisał(a):

> The motivation and the proposal sound good to me, +1 from my side.
>
> Would be good to have a quick opinion from someone who worked specifically
> with Kafka, maybe Becket or Piotr?
>
> Best,
> Stephan
>
>
> On Sat, Jun 12, 2021 at 9:50 AM Wenhao Ji  wrote:
>
>> Hi everyone,
>>
>> I would like to open this discussion thread to take about the FLIP-172
>> <
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-172%3A+Support+custom+transactional.id+prefix+in+FlinkKafkaProducer
>> >,
>> which aims to provide a way to support specifying a custom
>> transactional.id
>> in the FlinkKafkaProducer class.
>>
>> I am looking forwards to your feedback and suggestions!
>>
>> Thanks,
>> Wenhao
>>
>


Re: [DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-06-22 Thread Stephan Ewen
The motivation and the proposal sound good to me, +1 from my side.

Would be good to have a quick opinion from someone who worked specifically
with Kafka, maybe Becket or Piotr?

Best,
Stephan


On Sat, Jun 12, 2021 at 9:50 AM Wenhao Ji  wrote:

> Hi everyone,
>
> I would like to open this discussion thread to take about the FLIP-172
> <
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-172%3A+Support+custom+transactional.id+prefix+in+FlinkKafkaProducer
> >,
> which aims to provide a way to support specifying a custom
> transactional.id
> in the FlinkKafkaProducer class.
>
> I am looking forwards to your feedback and suggestions!
>
> Thanks,
> Wenhao
>


[DISCUSS] FLIP-172: Support custom transactional.id prefix in FlinkKafkaProducer

2021-06-12 Thread Wenhao Ji
Hi everyone,

I would like to open this discussion thread to take about the FLIP-172
,
which aims to provide a way to support specifying a custom transactional.id
in the FlinkKafkaProducer class.

I am looking forwards to your feedback and suggestions!

Thanks,
Wenhao