Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-07-02 Thread Natea Eshetu Beshada 
@Timo Walther  @Yanquan Lv @Jim Hughes
 Thank you for saying that the FLIP looks good.

@Feng Jin, +1 to what Timo already said above, does that address your
concern?

This FLIP seems to pretty uncontroversial so far so perhaps we can start a
vote soon?  Maybe tomorrow before the 4th of July holiday.

On Mon, Jul 1, 2024 at 12:25 AM Timo Walther  wrote:

> Hi Natea,
>
> the FLIPs looks good to me. Looking for forward to it.
>
> @Feng: TypeInferenceUtil#generateSignature considers parameter names if
> they have been specified. We can further evolve this function (e.g.
> improving the result type information), but this is not part of the
> FLIP. This requires changes in the TypeStrategy interface.
>
> Regards,
> Timo
>
> On 30.06.24 10:18, Feng Jin wrote:
> > Hi, Natea,
> >
> >
> > Thank you for initiating this FLIP.
> >
> > Have you considered displaying parameter names? This would make it easier
> > for users to use named parameters.
> >
> >
> > Best,
> > Feng
> >
> >
> > On Sun, Jun 30, 2024 at 3:49 PM Yanquan Lv  wrote:
> >
> >> Hi, Natea. This FLIP looks good from my side.
> >> I also look forward to showing the return type, as well as auxiliary
> >> information such as comments or usage, although the current
> implementation
> >> does not include this part.
> >>
> >>
> >> Natea Eshetu Beshada  于2024年6月26日周三
> >> 03:01写道：
> >>
> >>> Oh no haha, yes thanks for pointing that out Jim! Of course I make a
> typo
> >>> on an editable format like email :)
> >>>
> >>> On Tue, Jun 25, 2024 at 11:20 AM Jim Hughes
>  >>>
> >>> wrote:
> >>>
>  Hi Natea,
> 
>  Looks good.  As a note, in the title of this email, a number got
> >>> switched!
>  FLIP-456 is about compiled plans for batch operators. :)
> 
>  The link below is correct.
> 
>  Cheers,
> 
>  Jim
> 
>  On Tue, Jun 25, 2024 at 1:29 PM Natea Eshetu Beshada
>   wrote:
> 
> > Hello all,
> >
> > I would like to kickstart the discussion of FLIP-465: Introduce
> >>> DESCRIBE
> > FUNCTION [1].
> >
> > The proposal is to add SQL syntax that would allow users to describe
> >>> the
> > metadata of a given function.
> >
> > I look forward to hearing feedback from the community.
> >
> > [1]
> >
> >
> 
> >>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION
> >
> > Thanks,
> > Natea
> >
> 
> >>>
> >>
> >
>
>

Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-07-01 Thread Timo Walther 

Hi Natea,

the FLIPs looks good to me. Looking for forward to it.

@Feng: TypeInferenceUtil#generateSignature considers parameter names if 
they have been specified. We can further evolve this function (e.g. 
improving the result type information), but this is not part of the 
FLIP. This requires changes in the TypeStrategy interface.


Regards,
Timo

On 30.06.24 10:18, Feng Jin wrote:

Hi, Natea,


Thank you for initiating this FLIP.

Have you considered displaying parameter names? This would make it easier
for users to use named parameters.


Best,
Feng


On Sun, Jun 30, 2024 at 3:49 PM Yanquan Lv  wrote:


Hi, Natea. This FLIP looks good from my side.
I also look forward to showing the return type, as well as auxiliary
information such as comments or usage, although the current implementation
does not include this part.


Natea Eshetu Beshada  于2024年6月26日周三
03:01写道：


Oh no haha, yes thanks for pointing that out Jim! Of course I make a typo
on an editable format like email :)

On Tue, Jun 25, 2024 at 11:20 AM Jim Hughes 
Hi Natea,

Looks good.  As a note, in the title of this email, a number got

switched!

FLIP-456 is about compiled plans for batch operators. :)

The link below is correct.

Cheers,

Jim

On Tue, Jun 25, 2024 at 1:29 PM Natea Eshetu Beshada
 wrote:


Hello all,

I would like to kickstart the discussion of FLIP-465: Introduce

DESCRIBE

FUNCTION [1].

The proposal is to add SQL syntax that would allow users to describe

the

metadata of a given function.

I look forward to hearing feedback from the community.

[1]







https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION


Thanks,
Natea

Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-06-30 Thread Feng Jin 
Hi, Natea,


Thank you for initiating this FLIP.

Have you considered displaying parameter names? This would make it easier
for users to use named parameters.


Best,
Feng


On Sun, Jun 30, 2024 at 3:49 PM Yanquan Lv  wrote:

> Hi, Natea. This FLIP looks good from my side.
> I also look forward to showing the return type, as well as auxiliary
> information such as comments or usage, although the current implementation
> does not include this part.
>
>
> Natea Eshetu Beshada  于2024年6月26日周三
> 03:01写道：
>
> > Oh no haha, yes thanks for pointing that out Jim! Of course I make a typo
> > on an editable format like email :)
> >
> > On Tue, Jun 25, 2024 at 11:20 AM Jim Hughes  >
> > wrote:
> >
> > > Hi Natea,
> > >
> > > Looks good.  As a note, in the title of this email, a number got
> > switched!
> > > FLIP-456 is about compiled plans for batch operators. :)
> > >
> > > The link below is correct.
> > >
> > > Cheers,
> > >
> > > Jim
> > >
> > > On Tue, Jun 25, 2024 at 1:29 PM Natea Eshetu Beshada
> > >  wrote:
> > >
> > > > Hello all,
> > > >
> > > > I would like to kickstart the discussion of FLIP-465: Introduce
> > DESCRIBE
> > > > FUNCTION [1].
> > > >
> > > > The proposal is to add SQL syntax that would allow users to describe
> > the
> > > > metadata of a given function.
> > > >
> > > > I look forward to hearing feedback from the community.
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION
> > > >
> > > > Thanks,
> > > > Natea
> > > >
> > >
> >
>

Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-06-30 Thread Yanquan Lv 
Hi, Natea. This FLIP looks good from my side.
I also look forward to showing the return type, as well as auxiliary
information such as comments or usage, although the current implementation
does not include this part.


Natea Eshetu Beshada  于2024年6月26日周三 03:01写道：

> Oh no haha, yes thanks for pointing that out Jim! Of course I make a typo
> on an editable format like email :)
>
> On Tue, Jun 25, 2024 at 11:20 AM Jim Hughes 
> wrote:
>
> > Hi Natea,
> >
> > Looks good.  As a note, in the title of this email, a number got
> switched!
> > FLIP-456 is about compiled plans for batch operators. :)
> >
> > The link below is correct.
> >
> > Cheers,
> >
> > Jim
> >
> > On Tue, Jun 25, 2024 at 1:29 PM Natea Eshetu Beshada
> >  wrote:
> >
> > > Hello all,
> > >
> > > I would like to kickstart the discussion of FLIP-465: Introduce
> DESCRIBE
> > > FUNCTION [1].
> > >
> > > The proposal is to add SQL syntax that would allow users to describe
> the
> > > metadata of a given function.
> > >
> > > I look forward to hearing feedback from the community.
> > >
> > > [1]
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION
> > >
> > > Thanks,
> > > Natea
> > >
> >
>

Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-06-25 Thread Natea Eshetu Beshada 
Oh no haha, yes thanks for pointing that out Jim! Of course I make a typo
on an editable format like email :)

On Tue, Jun 25, 2024 at 11:20 AM Jim Hughes 
wrote:

> Hi Natea,
>
> Looks good.  As a note, in the title of this email, a number got switched!
> FLIP-456 is about compiled plans for batch operators. :)
>
> The link below is correct.
>
> Cheers,
>
> Jim
>
> On Tue, Jun 25, 2024 at 1:29 PM Natea Eshetu Beshada
>  wrote:
>
> > Hello all,
> >
> > I would like to kickstart the discussion of FLIP-465: Introduce DESCRIBE
> > FUNCTION [1].
> >
> > The proposal is to add SQL syntax that would allow users to describe the
> > metadata of a given function.
> >
> > I look forward to hearing feedback from the community.
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION
> >
> > Thanks,
> > Natea
> >
>

Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-06-25 Thread Jim Hughes 
Hi Natea,

Looks good.  As a note, in the title of this email, a number got switched!
FLIP-456 is about compiled plans for batch operators. :)

The link below is correct.

Cheers,

Jim

On Tue, Jun 25, 2024 at 1:29 PM Natea Eshetu Beshada
 wrote:

> Hello all,
>
> I would like to kickstart the discussion of FLIP-465: Introduce DESCRIBE
> FUNCTION [1].
>
> The proposal is to add SQL syntax that would allow users to describe the
> metadata of a given function.
>
> I look forward to hearing feedback from the community.
>
> [1]
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION
>
> Thanks,
> Natea
>

[DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-06-25 Thread Natea Eshetu Beshada 
Hello all,

I would like to kickstart the discussion of FLIP-465: Introduce DESCRIBE
FUNCTION [1].

The proposal is to add SQL syntax that would allow users to describe the
metadata of a given function.

I look forward to hearing feedback from the community.

[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-465%3A+Introduce+DESCRIBE+FUNCTION

Thanks,
Natea