Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
+1 * Binary and Source distributions checksums and signatures match * LICENSE file accounts for all included Jars in the binary distribution * Sources build and test fine. * Top level files all look good * Jira is clean One slight concern (not a blocker): the tag contains sources in contrib that are not included in the source tar-ball. Since these sources are not used for build, we can do without those for now. Thanks for your hard work Mike! Regards, Arvind Prabhakar On Wed, Jul 11, 2012 at 4:57 AM, Mike Percy wrote: > This is the first release for Apache Flume as a top-level project, > version 1.2.0. We are voting on release candidate rc1. > > *** Please cast your vote within the next 72 hours *** > > The list of fixed issues: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > for the source and binary artifacts can be found at: > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > The tag to be voted on: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > The KEYS file can be found here: > https://svn.apache.org/repos/asf/flume/dist/KEYS > > Changes since rc0: > - Updated LICENSE file > - Updated DEVNOTES file > - Removed DISCLAIMER file from dist.xml and src.xml manifests > - pom.xml file updated with TLP info (FLUME-1359) > - A build fix to prevent multiple servlet-api jars in lib dir >
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
Thank you sir, I appreciate your effort. As I mentioned originally, I do not consider either of those as a blocker - you've already got my +1 :-) Jarcec On Thu, Jul 12, 2012 at 11:34:55AM -0700, Mike Percy wrote: > On Thu, Jul 12, 2012 at 7:04 AM, Jarek Jarcec Cecho wrote: > > > 1) Both tar.gz archives contain same folder. Would be nice if the folder > > would be the same as the archive name minus the suffix. E.g. so that > > archive apache-flume-1.2.0-bin.tar.gz would contain directory > > apache-flume-1.2.0-bin instead of apache-flume-1.2.0. > > > > I looked into changing the build to generate files with this layout, > however I didn't see an easy way with the current setup. I punted on this > to reduce the number of manual steps involved in a release and therefore > reduce the likelihood of making a mistake. > > 2) LICENSE file is the some for both source and binary distribution. As a > > result the source distribution contain license notes to jars that are no > > part of the source release. It's little bit confusing. > > > > I added the following text to the LICENSE file in order to indicate when > the licenses apply, and I checked the changes into trunk to reduce the > manual steps required of the RM during a release: > > "The *compiled* Apache Flume distribution includes the following > sources/binaries. The use of these sources/binaries is subject to the terms > and conditions of their respective licenses." (my emphasis) > > Regards, > Mike signature.asc Description: Digital signature
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
On Thu, Jul 12, 2012 at 7:04 AM, Jarek Jarcec Cecho wrote: > 1) Both tar.gz archives contain same folder. Would be nice if the folder > would be the same as the archive name minus the suffix. E.g. so that > archive apache-flume-1.2.0-bin.tar.gz would contain directory > apache-flume-1.2.0-bin instead of apache-flume-1.2.0. > I looked into changing the build to generate files with this layout, however I didn't see an easy way with the current setup. I punted on this to reduce the number of manual steps involved in a release and therefore reduce the likelihood of making a mistake. 2) LICENSE file is the some for both source and binary distribution. As a > result the source distribution contain license notes to jars that are no > part of the source release. It's little bit confusing. > I added the following text to the LICENSE file in order to indicate when the licenses apply, and I checked the changes into trunk to reduce the manual steps required of the RM during a release: "The *compiled* Apache Flume distribution includes the following sources/binaries. The use of these sources/binaries is subject to the terms and conditions of their respective licenses." (my emphasis) Regards, Mike
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
+1 Downloaded source and binary tarballs, validated all checksums. Verified that all tests pass when building from the source tarball. Verified that all jars in the LICENSE file are accounted for in the binary convenience artifact. Mike On Wed, Jul 11, 2012 at 4:57 AM, Mike Percy wrote: > This is the first release for Apache Flume as a top-level project, > version 1.2.0. We are voting on release candidate rc1. > > *** Please cast your vote within the next 72 hours *** > > The list of fixed issues: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > for the source and binary artifacts can be found at: > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > The tag to be voted on: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > The KEYS file can be found here: > https://svn.apache.org/repos/asf/flume/dist/KEYS > > Changes since rc0: > - Updated LICENSE file > - Updated DEVNOTES file > - Removed DISCLAIMER file from dist.xml and src.xml manifests > - pom.xml file updated with TLP info (FLUME-1359) > - A build fix to prevent multiple servlet-api jars in lib dir > >
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
+1 I just have two minor notes (I do not consider them show stoppers): 1) Both tar.gz archives contain same folder. Would be nice if the folder would be the same as the archive name minus the suffix. E.g. so that archive apache-flume-1.2.0-bin.tar.gz would contain directory apache-flume-1.2.0-bin instead of apache-flume-1.2.0. 2) LICENSE file is the some for both source and binary distribution. As a result the source distribution contain license notes to jars that are no part of the source release. It's little bit confusing. Checklist: * Checked checksums * Source artifact is compilable * Tests are passing * Tested few example configurations * Checked LICENSE, NOTICE, ... Jarcec On Thu, Jul 12, 2012 at 01:26:53AM -0700, Hari Shreedharan wrote: > > > -- > Hari Shreedharan > > > On Thursday, July 12, 2012 at 1:03 AM, Mubarak Seyed wrote: > > > - I am not sure about hbase-0.92.1.jar, could not find it in lib directory, > > dependency is tagged as optional > > > > > > This is so that we can support both Hadoop 1.0 and 2.0. We do not bundle the > hbase jars the same way we don't bundle the Hadoop jars. Hadoop 1.0 and 2.0 > are (mostly) compatible but produce different jars. > > - zookeeper version: 3.4.3 is not stable yet but HBase/AsyncHBase uses only > > ZK client, not sure whether version 3.3.5 matters here. > > > > > > This is pulled in by Asynchbase, not directly by Flume. I think it is ok to > leave it as is. > > > > > > - Source builds correctly. > > - Ran agent from binary - tests looks good. > > > > Thanks. > > -Mubarak > > > > > > > > > > On Jul 11, 2012, at 11:11 PM, Hari Shreedharan > (mailto:hshreedha...@cloudera.com)> wrote: > > > > > +1. > > > > > > * Source artifact builds correctly. > > > * Checksums of both artifacts are accurate. > > > * NOTICE, LICENSE look accurate. > > > * CHANGELOG, RELEASE-NOTES, DEVNOTES and README exist, look ok. > > > * Ran agent from binary artifact - looks good. > > > > > > Thanks for doing this Mike. Great work! > > > > > > > > > Thanks > > > Hari > > > > > > -- > > > Hari Shreedharan > > > > > > > > > On Wednesday, July 11, 2012 at 11:38 AM, Ralph Goers wrote: > > > > > > > +0 > > > > > > > > The bin distribution has a proper notice and license and seems to be > > > > properly signed. I still have no idea why it contains the source since > > > > that is present in the source jar, speaking of which it is also > > > > properly signed and contains the proper notice and license. > > > > > > > > I cannot verify the maven artifacts since they have not been published > > > > to the staging repository. For example, I'm not sure if the Flume build > > > > generates the sources jar for each sub-project, which is what IDE's > > > > would like to have along with the "normal" jar. > > > > > > > > Ralph > > > > > > > > On Jul 11, 2012, at 4:57 AM, Mike Percy wrote: > > > > > > > > > This is the first release for Apache Flume as a top-level project, > > > > > version 1.2.0. We are voting on release candidate rc1. > > > > > > > > > > *** Please cast your vote within the next 72 hours *** > > > > > > > > > > The list of fixed issues: > > > > > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > > > > > > > > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, > > > > > *.sha1) > > > > > for the source and binary artifacts can be found at: > > > > > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > > > > > > > > > The tag to be voted on: > > > > > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > > > > > > > > > The KEYS file can be found here: > > > > > https://svn.apache.org/repos/asf/flume/dist/KEYS > > > > > > > > > > Changes since rc0: > > > > > - Updated LICENSE file > > > > > - Updated DEVNOTES file > > > > > - Removed DISCLAIMER file from dist.xml and src.xml manifests > > > > > - pom.xml file updated with TLP info (FLUME-1359) > > > > > - A build fix to prevent multiple servlet-api jars in lib dir > > > > > > > > > > > > > > > > > > > > > > > > > > > signature.asc Description: Digital signature
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
-- Hari Shreedharan On Thursday, July 12, 2012 at 1:03 AM, Mubarak Seyed wrote: > - I am not sure about hbase-0.92.1.jar, could not find it in lib directory, > dependency is tagged as optional > > This is so that we can support both Hadoop 1.0 and 2.0. We do not bundle the hbase jars the same way we don't bundle the Hadoop jars. Hadoop 1.0 and 2.0 are (mostly) compatible but produce different jars. > - zookeeper version: 3.4.3 is not stable yet but HBase/AsyncHBase uses only > ZK client, not sure whether version 3.3.5 matters here. > > This is pulled in by Asynchbase, not directly by Flume. I think it is ok to leave it as is. > > > - Source builds correctly. > - Ran agent from binary - tests looks good. > > Thanks. > -Mubarak > > > > > On Jul 11, 2012, at 11:11 PM, Hari Shreedharan (mailto:hshreedha...@cloudera.com)> wrote: > > > +1. > > > > * Source artifact builds correctly. > > * Checksums of both artifacts are accurate. > > * NOTICE, LICENSE look accurate. > > * CHANGELOG, RELEASE-NOTES, DEVNOTES and README exist, look ok. > > * Ran agent from binary artifact - looks good. > > > > Thanks for doing this Mike. Great work! > > > > > > Thanks > > Hari > > > > -- > > Hari Shreedharan > > > > > > On Wednesday, July 11, 2012 at 11:38 AM, Ralph Goers wrote: > > > > > +0 > > > > > > The bin distribution has a proper notice and license and seems to be > > > properly signed. I still have no idea why it contains the source since > > > that is present in the source jar, speaking of which it is also properly > > > signed and contains the proper notice and license. > > > > > > I cannot verify the maven artifacts since they have not been published to > > > the staging repository. For example, I'm not sure if the Flume build > > > generates the sources jar for each sub-project, which is what IDE's would > > > like to have along with the "normal" jar. > > > > > > Ralph > > > > > > On Jul 11, 2012, at 4:57 AM, Mike Percy wrote: > > > > > > > This is the first release for Apache Flume as a top-level project, > > > > version 1.2.0. We are voting on release candidate rc1. > > > > > > > > *** Please cast your vote within the next 72 hours *** > > > > > > > > The list of fixed issues: > > > > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > > > > > > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > > > > for the source and binary artifacts can be found at: > > > > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > > > > > > > The tag to be voted on: > > > > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > > > > > > > The KEYS file can be found here: > > > > https://svn.apache.org/repos/asf/flume/dist/KEYS > > > > > > > > Changes since rc0: > > > > - Updated LICENSE file > > > > - Updated DEVNOTES file > > > > - Removed DISCLAIMER file from dist.xml and src.xml manifests > > > > - pom.xml file updated with TLP info (FLUME-1359) > > > > - A build fix to prevent multiple servlet-api jars in lib dir > > > > > > > > > > > > > > > > >
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
- I am not sure about hbase-0.92.1.jar, could not find it in lib directory, dependency is tagged as optional - zookeeper version: 3.4.3 is not stable yet but HBase/AsyncHBase uses only ZK client, not sure whether version 3.3.5 matters here. - Source builds correctly. - Ran agent from binary - tests looks good. Thanks. -Mubarak On Jul 11, 2012, at 11:11 PM, Hari Shreedharan wrote: > +1. > > * Source artifact builds correctly. > * Checksums of both artifacts are accurate. > * NOTICE, LICENSE look accurate. > * CHANGELOG, RELEASE-NOTES, DEVNOTES and README exist, look ok. > * Ran agent from binary artifact - looks good. > > Thanks for doing this Mike. Great work! > > > Thanks > Hari > > -- > Hari Shreedharan > > > On Wednesday, July 11, 2012 at 11:38 AM, Ralph Goers wrote: > >> +0 >> >> The bin distribution has a proper notice and license and seems to be >> properly signed. I still have no idea why it contains the source since that >> is present in the source jar, speaking of which it is also properly signed >> and contains the proper notice and license. >> >> I cannot verify the maven artifacts since they have not been published to >> the staging repository. For example, I'm not sure if the Flume build >> generates the sources jar for each sub-project, which is what IDE's would >> like to have along with the "normal" jar. >> >> Ralph >> >> On Jul 11, 2012, at 4:57 AM, Mike Percy wrote: >> >>> This is the first release for Apache Flume as a top-level project, >>> version 1.2.0. We are voting on release candidate rc1. >>> >>> *** Please cast your vote within the next 72 hours *** >>> >>> The list of fixed issues: >>> https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG >>> >>> The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) >>> for the source and binary artifacts can be found at: >>> https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ >>> >>> The tag to be voted on: >>> https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 >>> >>> The KEYS file can be found here: >>> https://svn.apache.org/repos/asf/flume/dist/KEYS >>> >>> Changes since rc0: >>> - Updated LICENSE file >>> - Updated DEVNOTES file >>> - Removed DISCLAIMER file from dist.xml and src.xml manifests >>> - pom.xml file updated with TLP info (FLUME-1359) >>> - A build fix to prevent multiple servlet-api jars in lib dir >>> >> >> >> > >
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
+1. * Source artifact builds correctly. * Checksums of both artifacts are accurate. * NOTICE, LICENSE look accurate. * CHANGELOG, RELEASE-NOTES, DEVNOTES and README exist, look ok. * Ran agent from binary artifact - looks good. Thanks for doing this Mike. Great work! Thanks Hari -- Hari Shreedharan On Wednesday, July 11, 2012 at 11:38 AM, Ralph Goers wrote: > +0 > > The bin distribution has a proper notice and license and seems to be properly > signed. I still have no idea why it contains the source since that is present > in the source jar, speaking of which it is also properly signed and contains > the proper notice and license. > > I cannot verify the maven artifacts since they have not been published to the > staging repository. For example, I'm not sure if the Flume build generates > the sources jar for each sub-project, which is what IDE's would like to have > along with the "normal" jar. > > Ralph > > On Jul 11, 2012, at 4:57 AM, Mike Percy wrote: > > > This is the first release for Apache Flume as a top-level project, > > version 1.2.0. We are voting on release candidate rc1. > > > > *** Please cast your vote within the next 72 hours *** > > > > The list of fixed issues: > > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > > for the source and binary artifacts can be found at: > > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > > > The tag to be voted on: > > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > > > The KEYS file can be found here: > > https://svn.apache.org/repos/asf/flume/dist/KEYS > > > > Changes since rc0: > > - Updated LICENSE file > > - Updated DEVNOTES file > > - Removed DISCLAIMER file from dist.xml and src.xml manifests > > - pom.xml file updated with TLP info (FLUME-1359) > > - A build fix to prevent multiple servlet-api jars in lib dir > > > > >
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
+0 The bin distribution has a proper notice and license and seems to be properly signed. I still have no idea why it contains the source since that is present in the source jar, speaking of which it is also properly signed and contains the proper notice and license. I cannot verify the maven artifacts since they have not been published to the staging repository. For example, I'm not sure if the Flume build generates the sources jar for each sub-project, which is what IDE's would like to have along with the "normal" jar. Ralph On Jul 11, 2012, at 4:57 AM, Mike Percy wrote: > This is the first release for Apache Flume as a top-level project, > version 1.2.0. We are voting on release candidate rc1. > > *** Please cast your vote within the next 72 hours *** > > The list of fixed issues: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > for the source and binary artifacts can be found at: > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > The tag to be voted on: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > The KEYS file can be found here: > https://svn.apache.org/repos/asf/flume/dist/KEYS > > Changes since rc0: > - Updated LICENSE file > - Updated DEVNOTES file > - Removed DISCLAIMER file from dist.xml and src.xml manifests > - pom.xml file updated with TLP info (FLUME-1359) > - A build fix to prevent multiple servlet-api jars in lib dir
Re: [VOTE] Release Apache Flume version 1.2.0 (rc1)
+1 On Jul 11, 2012, at 1:57 PM, Mike Percy wrote: > This is the first release for Apache Flume as a top-level project, > version 1.2.0. We are voting on release candidate rc1. > > *** Please cast your vote within the next 72 hours *** > > The list of fixed issues: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > for the source and binary artifacts can be found at: > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ > > The tag to be voted on: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 > > The KEYS file can be found here: > https://svn.apache.org/repos/asf/flume/dist/KEYS > > Changes since rc0: > - Updated LICENSE file > - Updated DEVNOTES file > - Removed DISCLAIMER file from dist.xml and src.xml manifests > - pom.xml file updated with TLP info (FLUME-1359) > - A build fix to prevent multiple servlet-api jars in lib dir -- Alexander Alten-Lorenz http://mapredit.blogspot.com German Hadoop LinkedIn Group: http://goo.gl/N8pCF
[VOTE] Release Apache Flume version 1.2.0 (rc1)
This is the first release for Apache Flume as a top-level project, version 1.2.0. We are voting on release candidate rc1. *** Please cast your vote within the next 72 hours *** The list of fixed issues: https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1/CHANGELOG The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) for the source and binary artifacts can be found at: https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc1/ The tag to be voted on: https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc1 The KEYS file can be found here: https://svn.apache.org/repos/asf/flume/dist/KEYS Changes since rc0: - Updated LICENSE file - Updated DEVNOTES file - Removed DISCLAIMER file from dist.xml and src.xml manifests - pom.xml file updated with TLP info (FLUME-1359) - A build fix to prevent multiple servlet-api jars in lib dir
