Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

[nabarun nag]

> On June 13, 2016, 9:33 p.m., Dan Smith wrote:
> > If this is expected behavior, I think this message should be info level or 
> > lower. warning still indicates that something is going wrong.
> 
> Jason Huynh wrote:
> I agree, probably should be info for this.
> 
> nabarun nag wrote:
> I was wondering that the catch block is for general exception ( Exception 
> ex ) which might occur for multiple reaons which may not have been an 
> expected scenario. (The try block had multiple lines of code and i thought 
> that an exception may occur at any point).
> 
> I think that we should have a separate catch block for the expected 
> scenario with the info level message and leave the general exception catch 
> block with the error level log message.
> 
> I might be wrong about this :(
> 
> Dan Smith wrote:
> That seems like a good idea.

After further analysis, I found that there are two checked exceptions which 
were caught by the previous generic catch block. RegionNotFound Exception and 
IndexExistsException. RegionNotFoundException will now be treated as an 
InternalGemFireError and rethrown. However, the IndexExistsException will 
require more detailed analysis. TBD


- nabarun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48661/#review137390
---


On June 13, 2016, 7:33 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48661/
> ---
> 
> (Updated June 13, 2016, 7:33 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * When multiple peers join the cluster conncurrently, only the first one that 
> joins will distribute the index creation and other will try to create the 
> index locally because of the distributed message and then log an error 
> afterwards.
> * This is an expected behaviour and hence should not be logged as error but 
> rather as a warning.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
> 8b9664f 
> 
> Diff: https://reviews.apache.org/r/48661/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48432/#review137430
---


Ship it!




Ship It!

- xiaojian zhou


On June 9, 2016, 6:41 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48432/
> ---
> 
> (Updated June 9, 2016, 6:41 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, 
> Jinmei Liao, Kirk Lund, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding support to measure statistics with suppliers that are sampled
> every sample interval. The suppliers are invoked in a separate thread
> than the stat sampler so that slow suppliers won't screw up all stats.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/Statistics.java 
> d7f45a50af7ce58e0d65bfd6300821b36864cc9b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java
>  83d40559ba652474630d04758696f2e9042910e7 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatSamplerStats.java 
> c70247939a50392e62e264bfb783a37c93a969ae 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsImpl.java 
> 2344d9315ca8b2b31e9eba35a350eca44a9b8bec 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeImpl.java
>  2a29d46dfc260a40b018af5530a4f1e781e72274 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/SampleCollector.java
>  dfb502bb0aa018a11ab26b10a35da2c5be7c10ac 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/LocalStatisticsImplJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest.java
>  bb15ff2ce747a37d87c95931d5e07cbce4ca7be6 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
>  f2946b619c6272539ba00f10a9fb1444cc095231 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DummyStatistics.java
>  a1ea030443f096ba8f0bd8d5fb62a8183f20bcfd 
> 
> Diff: https://reviews.apache.org/r/48432/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: OplogCompactor question

[Darrel Schneider]

It will only run if it can find at least one oplog that is ready for
compaction. Once "getOplogsToBeCompacted()" returns null then a new
compaction task will not be scheduled until a new oplog becomes compactable
(see 
com.gemstone.gemfire.internal.cache.PersistentOplogSet.addToBeCompacted(Oplog)).

The info level messages you see from the compactor should keep telling you
different oplog ids.

On Thu, Jun 9, 2016 at 2:37 PM, robert geiger  wrote:

> Was looking into OplogCompactor due to excessive info level log messages
> and noticed that (1) compaction continuously runs using the disk store task
> thread pool (is re-scheduled with no delay); and (2) info level messages
> are in the nominal (no errors) code path.
>
> It would seem that info level messages should not be in a continuously
> running maintenance thread, or am I missing something here?
>
> Thanks,
> Bob
>
> ___
> Robert Geiger
> Chief Architect, Ampool Inc.
> +1 408-833-4527
>
>

[GitHub] incubator-geode issue #154: GEODE-1470: Upgrade log4j to 2.6

[kjduling]

Github user kjduling commented on the issue:

https://github.com/apache/incubator-geode/pull/154
  
Updated to 2.6.1 and fixed the failing unit tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 48667: GEODE-1544: Fail to initiate final check when network partition occurs

[Jianxia Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48667/
---

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Repository: geode


Description
---

Currently, suspect request is only sent to limited number of members, when 
there are more than 4 members in the distributed system. It is possible that 
the recipients of suspect request is unreachable due to network partition. This 
fix makes sure that the recipients of suspect request are not the suspect 
members. So that these requests will be processed.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java
 078281a 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 f27e0b8 

Diff: https://reviews.apache.org/r/48667/diff/


Testing
---


Thanks,

Jianxia Chen

Re: Review Request 48383: fix IllegalStateException from importNewObject

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/
---

(Updated June 13, 2016, 4:14 p.m.)


Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-1508
https://issues.apache.org/jira/browse/GEODE-1508


Repository: geode


Description (updated)
---

The code in EntryEventImpl that calls importNewObject
is now careful to never call importNewObject with isSerialized false
if isUnretainedNewReferenceOk is false.
The same bug was fixed for importOldObject.
Unit tests have been added for the code in EntryEventImpl
that calls both importNewObject and importOldObject.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
 c4849be2c0863e6badf6eeaf1ccfaaf826d57584 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java
 800527f2927cc775cf89426f12fc6eb6c48f77bb 

Diff: https://reviews.apache.org/r/48383/diff/


Testing
---

precheckin


Thanks,

Darrel Schneider

Re: Review Request 48652: GEODE-1517: Transaction could still proceed after TXManagerImpl is closing during cache close

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48652/#review137422
---


Ship it!




Ship It!

- Darrel Schneider


On June 13, 2016, 9:58 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48652/
> ---
> 
> (Updated June 13, 2016, 9:58 a.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1517
> https://issues.apache.org/jira/browse/GEODE-1517
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Holding the ReentrantLock during TXManagerImpl.close() when closing 
> TXStateProxyImpl. Provent any TXStateProxyImpl to work further.
> Add a test case where it fails without the above fix and passes after the fix.
> 
> Also avoid going through synchronized failover map to check if a 
> TXStateProxyImpl is finished, instead, use its isInProgress() call.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java
>  19e1dea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java
>  2608878 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java
>  1b83ee3 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java
>  ecfc2b0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java
>  ce24947 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java
>  bbbf714 
> 
> Diff: https://reviews.apache.org/r/48652/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 48383: fix IllegalStateException from importNewObject

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/
---

(Updated June 13, 2016, 4:14 p.m.)


Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-1508
https://issues.apache.org/jira/browse/GEODE-1508


Repository: geode


Description (updated)
---

The code in EntryEventImpl that calls importNewObject
is now careful to never call importNewObject with isSerialized false
if isUnretainedNewReferenceOk is true.
The same bug was fixed for importOldObject.
Unit tests have been added for the code in EntryEventImpl
that calls both importNewObject and importOldObject.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
 c4849be2c0863e6badf6eeaf1ccfaaf826d57584 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java
 800527f2927cc775cf89426f12fc6eb6c48f77bb 

Diff: https://reviews.apache.org/r/48383/diff/


Testing
---

precheckin


Thanks,

Darrel Schneider

Review Request 48665: GEODE-1542 shared/unordered tcp/ip connection times out, initiating suspicion

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48665/
---

Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.


Bugs: GEODE-1542
https://issues.apache.org/jira/browse/GEODE-1542


Repository: geode


Description
---

This disables timing out of shared/unordered TcpConduit connections.  We don't 
want them to time out because we are using them to initiate suspect processing 
on other members.

The ticket also pointed out a problem with the "final check" mechanism in the 
health monitor.  I tracked that down to improper use of SocketCreator to create 
the server-socket in GMSHealthMonitor.  It was creating sn SSL socket if SSL is 
enabled but the client-side of the check uses non-SSL sockets.  I changed the 
server to use non-SSL sockets as well since no useful information is sent over 
the final-check TCP/IP connections & they need to be lightweight and fast.

While looking at logs I also found that the heartbeat request sent at the 
beginning of a final-check had a request-ID even though it's not waiting for a 
response.  That causes processing of the response to do more work than 
necessary so I changed it to remove the request-ID from the message.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 f27e0b8d238fd4cda3a81a5d1edf199ebeb1c3c7 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 8dce1a5eb46b26a7b9ecc3e5b538d98e7e9f720e 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/HeartbeatRequestMessage.java
 3c08e3383c2bf8f53cca291825ddb45ef69d0184 
  geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 
367d4a7bbe1334ad393da337030a1d02089cfcaf 
  geode-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 
85e351106285db571ecc3f388bbb11979562c3ed 

Diff: https://reviews.apache.org/r/48665/diff/


Testing
---

precheckin, SSL integration testing.


Thanks,

Bruce Schuchardt

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #339 was SUCCESSFUL (with 1407 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #339 was successful.
---
Scheduled
1409 tests in total.

https://build.spring.io/browse/SGF-NAG-339/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

[Dan Smith]

> On June 13, 2016, 9:33 p.m., Dan Smith wrote:
> > If this is expected behavior, I think this message should be info level or 
> > lower. warning still indicates that something is going wrong.
> 
> Jason Huynh wrote:
> I agree, probably should be info for this.
> 
> nabarun nag wrote:
> I was wondering that the catch block is for general exception ( Exception 
> ex ) which might occur for multiple reaons which may not have been an 
> expected scenario. (The try block had multiple lines of code and i thought 
> that an exception may occur at any point).
> 
> I think that we should have a separate catch block for the expected 
> scenario with the info level message and leave the general exception catch 
> block with the error level log message.
> 
> I might be wrong about this :(

That seems like a good idea.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48661/#review137390
---


On June 13, 2016, 7:33 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48661/
> ---
> 
> (Updated June 13, 2016, 7:33 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * When multiple peers join the cluster conncurrently, only the first one that 
> joins will distribute the index creation and other will try to create the 
> index locally because of the distributed message and then log an error 
> afterwards.
> * This is an expected behaviour and hence should not be logged as error but 
> rather as a warning.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
> 8b9664f 
> 
> Diff: https://reviews.apache.org/r/48661/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

[nabarun nag]

> On June 13, 2016, 9:33 p.m., Dan Smith wrote:
> > If this is expected behavior, I think this message should be info level or 
> > lower. warning still indicates that something is going wrong.
> 
> Jason Huynh wrote:
> I agree, probably should be info for this.

I was wondering that the catch block is for general exception ( Exception ex ) 
which might occur for multiple reaons which may not have been an expected 
scenario. (The try block had multiple lines of code and i thought that an 
exception may occur at any point).

I think that we should have a separate catch block for the expected scenario 
with the info level message and leave the general exception catch block with 
the error level log message.

I might be wrong about this :(


- nabarun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48661/#review137390
---


On June 13, 2016, 7:33 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48661/
> ---
> 
> (Updated June 13, 2016, 7:33 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * When multiple peers join the cluster conncurrently, only the first one that 
> joins will distribute the index creation and other will try to create the 
> index locally because of the distributed message and then log an error 
> afterwards.
> * This is an expected behaviour and hence should not be logged as error but 
> rather as a warning.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
> 8b9664f 
> 
> Diff: https://reviews.apache.org/r/48661/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48661/#review137390
---



If this is expected behavior, I think this message should be info level or 
lower. warning still indicates that something is going wrong.

- Dan Smith


On June 13, 2016, 7:33 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48661/
> ---
> 
> (Updated June 13, 2016, 7:33 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * When multiple peers join the cluster conncurrently, only the first one that 
> joins will distribute the index creation and other will try to create the 
> index locally because of the distributed message and then log an error 
> afterwards.
> * This is an expected behaviour and hence should not be logged as error but 
> rather as a warning.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
> 8b9664f 
> 
> Diff: https://reviews.apache.org/r/48661/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Fwd: Low-hanging fruit - Geode

[Roman Shaposhnik]

FYI.

Thanks,
Roman.


-- Forwarded message --
From: Paul Merlin 
Date: Mon, Jun 13, 2016 at 12:54 AM
Subject: Re: Low-hanging fruit - Geode
To: d...@zest.apache.org


Niclas Hedhman a écrit :
> Hi,
> At ApacheCon I ran into Apache Geode (incubating) people. That is good old
> GemFire, and we can now easily add that to the list of entity stores
> supported, if someone spend 1-2 hours implementing the glue needed.

I pushed a Geode EntityStore along with embedded tests and minimal docs.

It supports both embedded and client-server topologies.

If there's some interest, we could also provide a Geode Cache extension,
extract a Geode Library and so on.

Review Request 48661: GEODE-1543: Changed the log level from error to warn

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48661/
---

Review request for geode, anilkumar gingade, Jason Huynh, Dan Smith, and 
xiaojian zhou.


Repository: geode


Description
---

* When multiple peers join the cluster conncurrently, only the first one that 
joins will distribute the index creation and other will try to create the index 
locally because of the distributed message and then log an error afterwards.
* This is an expected behaviour and hence should not be logged as error but 
rather as a warning.


Diffs
-

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
8b9664f 

Diff: https://reviews.apache.org/r/48661/diff/


Testing
---


Thanks,

nabarun nag

Re: Review Request 48383: fix IllegalStateException from importNewObject

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48383/#review137330
---


Ship it!




The description of the fix is somewhat misleading with regards to the 
conditions for calling importNewObject. For instance the conditional for 
isUnretainedNewReferenceOk() isn't mentioned. 

That said, the code fix looks OK after I referred back to the orignal bug 
report and examined the implementation of the methods called.

- Ken Howe


On June 7, 2016, 11:25 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48383/
> ---
> 
> (Updated June 7, 2016, 11:25 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1508
> https://issues.apache.org/jira/browse/GEODE-1508
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The code in EntryEventImpl that calls importNewObject
> is now careful to never call importNewObject with isSerialized false
> if prefersNewSerialized is true.
> The same bug was fixed for importOldObject.
> Unit tests have been added for the code in EntryEventImpl
> that calls both importNewObject and importOldObject.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
>  c4849be2c0863e6badf6eeaf1ccfaaf826d57584 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java
>  800527f2927cc775cf89426f12fc6eb6c48f77bb 
> 
> Diff: https://reviews.apache.org/r/48383/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 48658: Change from MultiFieldQueryParser to StandardQueryParser

[Jason Huynh]

> On June 13, 2016, 6:08 p.m., Dan Smith wrote:
> > I don't think we want to use the first field as the default field long 
> > term. That's behavior that might be confusing to users, especially since 
> > the order of the fields is not really defined if you pass in a map of 
> > fields->analyzers.

Yeah, I agree, it was more of a place holder until we figure out what our 
default field will be.  I'll be working on adding api's to pass in the default 
field next and then we can figure out what the true default field should be...


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48658/#review137345
---


On June 13, 2016, 5:59 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48658/
> ---
> 
> (Updated June 13, 2016, 5:59 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed tests specific to multi field query parsing
> Currently using the first field as the default field.  Future changes will 
> allow user to pass in a default field.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java
>  62cb65c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java
>  cfd8c32 
> 
> Diff: https://reviews.apache.org/r/48658/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 48431: GEODE-1494: Changing stats list to be a CopyOnWriteArrayList

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48431/#review137346
---


Ship it!




This change looks good. I think your change makes possible a change to 
SampleCollector.sampleResources to no longer call getStatistics (which copies 
the list into an array) but to instead just iterate the list like everyone else 
does. You could make this change yourself or file a ticket to do it in the 
future.

- Darrel Schneider


On June 8, 2016, 11:06 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48431/
> ---
> 
> (Updated June 8, 2016, 11:06 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The statsList used to track Statistics in InternalDistributedSystem was
> managed under a lock. That was problematic, because code that iterates
> on the list needs to hold the lock. If the code invoking callbacks for
> GEODE-1494 was slow, that means the lock would block other stats
> operations.
> 
> Changing this list to a copy on write array list to holding a lock for a
> long period of time.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  af81cc1b770bd323f3977a865ee3280a55146b3c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java
>  886258b0589fd291411d11425b9a06713142a384 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java
>  59305066429c0bb020b7795afec1bfdf260d08b5 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
>  90a26cbada03ea49cd769c83c9538eb7654466ed 
> 
> Diff: https://reviews.apache.org/r/48431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48658: Change from MultiFieldQueryParser to StandardQueryParser

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48658/#review137345
---


Ship it!




I don't think we want to use the first field as the default field long term. 
That's behavior that might be confusing to users, especially since the order of 
the fields is not really defined if you pass in a map of fields->analyzers.

- Dan Smith


On June 13, 2016, 5:59 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48658/
> ---
> 
> (Updated June 13, 2016, 5:59 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed tests specific to multi field query parsing
> Currently using the first field as the default field.  Future changes will 
> allow user to pass in a default field.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java
>  62cb65c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java
>  cfd8c32 
> 
> Diff: https://reviews.apache.org/r/48658/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Review Request 48658: Change from MultiFieldQueryParser to StandardQueryParser

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48658/
---

Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and 
xiaojian zhou.


Repository: geode


Description
---

Removed tests specific to multi field query parsing
Currently using the first field as the default field.  Future changes will 
allow user to pass in a default field.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java
 62cb65c 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java
 cfd8c32 

Diff: https://reviews.apache.org/r/48658/diff/


Testing
---


Thanks,

Jason Huynh

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

[Dan Smith]

> On June 10, 2016, 7:34 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java,
> >  line 55
> > 
> >
> > Is it intentional...We are chaging this from 3 to 30 secs? If its 
> > required we may need to document this and let support know about this...

It hit this whne I was running a bunch of tests. If there is more than a 3 
second pause during startup, the member will fail to start up because later on 
the monitoring and management code tries to use things that should be 
initialized by that point. I increased the timeout to 30 seconds to make it 
less likely for pauses on startup to cause the system to fail to start up due 
to this stat sampler code.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48432/#review137058
---


On June 9, 2016, 6:41 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48432/
> ---
> 
> (Updated June 9, 2016, 6:41 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, 
> Jinmei Liao, Kirk Lund, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding support to measure statistics with suppliers that are sampled
> every sample interval. The suppliers are invoked in a separate thread
> than the stat sampler so that slow suppliers won't screw up all stats.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/com/gemstone/gemfire/Statistics.java 
> d7f45a50af7ce58e0d65bfd6300821b36864cc9b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java
>  83d40559ba652474630d04758696f2e9042910e7 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatSamplerStats.java 
> c70247939a50392e62e264bfb783a37c93a969ae 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsImpl.java 
> 2344d9315ca8b2b31e9eba35a350eca44a9b8bec 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeImpl.java
>  2a29d46dfc260a40b018af5530a4f1e781e72274 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/SampleCollector.java
>  dfb502bb0aa018a11ab26b10a35da2c5be7c10ac 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/LocalStatisticsImplJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest.java
>  bb15ff2ce747a37d87c95931d5e07cbce4ca7be6 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java
>  f2946b619c6272539ba00f10a9fb1444cc095231 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DummyStatistics.java
>  a1ea030443f096ba8f0bd8d5fb62a8183f20bcfd 
> 
> Diff: https://reviews.apache.org/r/48432/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48431: GEODE-1494: Changing stats list to be a CopyOnWriteArrayList

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48431/#review137333
---


Ship it!




Ship It!

- Kirk Lund


On June 8, 2016, 6:06 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48431/
> ---
> 
> (Updated June 8, 2016, 6:06 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The statsList used to track Statistics in InternalDistributedSystem was
> managed under a lock. That was problematic, because code that iterates
> on the list needs to hold the lock. If the code invoking callbacks for
> GEODE-1494 was slow, that means the lock would block other stats
> operations.
> 
> Changing this list to a copy on write array list to holding a lock for a
> long period of time.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  af81cc1b770bd323f3977a865ee3280a55146b3c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/AbstractStatisticsFactory.java
>  886258b0589fd291411d11425b9a06713142a384 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireStatSampler.java
>  59305066429c0bb020b7795afec1bfdf260d08b5 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java 
> ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
>  90a26cbada03ea49cd769c83c9538eb7654466ed 
> 
> Diff: https://reviews.apache.org/r/48431/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 48652: GEODE-1517: Transaction could still proceed after TXManagerImpl is closing during cache close

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48652/
---

Review request for geode, Darrel Schneider and Swapnil Bawaskar.


Bugs: GEODE-1517
https://issues.apache.org/jira/browse/GEODE-1517


Repository: geode


Description
---

Holding the ReentrantLock during TXManagerImpl.close() when closing 
TXStateProxyImpl. Provent any TXStateProxyImpl to work further.
Add a test case where it fails without the above fix and passes after the fix.

Also avoid going through synchronized failover map to check if a 
TXStateProxyImpl is finished, instead, use its isInProgress() call.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java
 19e1dea 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 
2608878 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java
 1b83ee3 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java
 ecfc2b0 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java
 ce24947 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java
 bbbf714 

Diff: https://reviews.apache.org/r/48652/diff/


Testing
---

precheckin


Thanks,

Eric Shu

[GitHub] incubator-geode issue #154: GEODE-1470: Upgrade log4j to 2.6

[kirklund]

Github user kirklund commented on the issue:

https://github.com/apache/incubator-geode/pull/154
  
2.6.1 was released on June 5th, so we should upgrade to 2.6.1 instead of 
2.6.

The following tests fail consistently with both 2.6 and 2.6.1:
* AnalyzeSerializablesJUnitTest.testDataSerializables
* LogWriterAppenderJUnitTest.testAppenderToConfigHandling
* LogWriterAppenderJUnitTest.testLogWriterLevels




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-spark-connector #27

[Apache Jenkins Server]

See 

--
[...truncated 474 lines...]
Download 
https://repo1.maven.org/maven2/org/hibernate/hibernate-annotations/3.5.5-Final/hibernate-annotations-3.5.5-Final.pom
Download 
https://repo1.maven.org/maven2/org/hibernate/hibernate-parent/3.5.5-Final/hibernate-parent-3.5.5-Final.pom
Download 
https://repo1.maven.org/maven2/org/eclipse/persistence/javax.persistence/2.0.0/javax.persistence-2.0.0.pom
Download 
https://repo1.maven.org/maven2/org/hibernate/hibernate-core/3.5.5-Final/hibernate-core-3.5.5-Final.pom
Download 
https://repo1.maven.org/maven2/org/hibernate/hibernate-annotations/3.5.5-Final/hibernate-annotations-3.5.5-Final.jar
Download 
https://repo1.maven.org/maven2/org/eclipse/persistence/javax.persistence/2.0.0/javax.persistence-2.0.0.jar
Download 
https://repo1.maven.org/maven2/org/hibernate/hibernate-core/3.5.5-Final/hibernate-core-3.5.5-Final.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:extensions/geode-modules-hibernate:processResources UP-TO-DATE
:extensions/geode-modules-hibernate:classes
:extensions/geode-modules-hibernate:jar
:extensions/geode-modules-hibernate:javadoc
:extensions/geode-modules-hibernate:javadocJar
:extensions/geode-modules-hibernate:sourcesJar
:extensions/geode-modules-hibernate:signArchives SKIPPED
:extensions/geode-modules-hibernate:assemble
:extensions/geode-modules-assembly:distHibernate
:extensions/geode-modules:javadocJar
:extensions/geode-modules:sourcesJar
:extensions/geode-modules:signArchives SKIPPED
:extensions/geode-modules:assemble
:extensions/geode-modules-tomcat7:compileJava
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-catalina/7.0.30/tomcat-catalina-7.0.30.pom
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-coyote/7.0.30/tomcat-coyote-7.0.30.pom
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-juli/7.0.30/tomcat-juli-7.0.30.pom
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-api/7.0.30/tomcat-api-7.0.30.pom
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-util/7.0.30/tomcat-util-7.0.30.pom
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-catalina/7.0.30/tomcat-catalina-7.0.30.jar
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-coyote/7.0.30/tomcat-coyote-7.0.30.jar
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-juli/7.0.30/tomcat-juli-7.0.30.jar
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-api/7.0.30/tomcat-api-7.0.30.jar
Download 
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-util/7.0.30/tomcat-util-7.0.30.jar
:extensions/geode-modules-tomcat7:processResources UP-TO-DATE
:extensions/geode-modules-tomcat7:classes
:extensions/geode-modules-tomcat7:jar
:extensions/geode-modules-tomcat7:javadoc
:extensions/geode-modules-tomcat7:javadocJar
:extensions/geode-modules-tomcat7:sourcesJar
:extensions/geode-modules-tomcat7:signArchives SKIPPED
:extensions/geode-modules-tomcat7:assemble
:extensions/geode-modules-assembly:distTcServer
:extensions/geode-modules-assembly:distTcServer30
:extensions/geode-modules-assembly:distTomcat
:extensions/geode-modules-assembly:dist
:geode-assembly:compileJava UP-TO-DATE
:geode-assembly:processResources UP-TO-DATE
:geode-assembly:classes UP-TO-DATE
:geode-assembly:defaultCacheConfig
:geode-assembly:defaultDistributionConfig
:geode-assembly:depsJar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-common/6.0.0/lucene-analyzers-common-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-parent/6.0.0/lucene-parent-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-solr-grandparent/6.0.0/lucene-solr-grandparent-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/6.0.0/lucene-core-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/6.0.0/lucene-queries-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/6.0.0/lucene-queryparser-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-analyzers-common/6.0.0/lucene-analyzers-common-6.0.0.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/6.0.0/lucene-core-6.0.0.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queries/6.0.0/lucene-queries-6.0.0.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-queryparser/6.0.0/lucene-queryparser-6.0.0.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-aspects/4.2.4.RELEASE/spring-aspects-4.2.4.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-oxm/4.2.4.RELEASE/spring-oxm-4.2.4.RELEASE.pom
Download 

Jenkins build is back to normal : Geode-nightly #498

[Apache Jenkins Server]

See