Re: M3 status?

2016-07-07 Thread Kirk Lund 
Here are the open branding tickets I'm aware of:

GEODE-1465: Branding: rename JMX endpoints from 'Gemfire' to 'Geode'
GEODE-1466: Branding: rename gemfire.properties file to geode.properties
file
GEODE-1467: Branding: Rename servlet URLs from gemfire to geode
GEODE-1566: Branding: GemFireRedisServer should be renamed as
GeodeRedisServer

No one has taken on 1465/1466/1467 or submitted a PR for any of them so I
believe they will not be in M3.

Grace Meilen submitted a PR fixing GEODE-1566, so we can probably commit
that one tomorrow to be included in M3 after reviewing the test results.

Cheers,
Kirk


On Thu, Jul 7, 2016 at 4:29 PM, Nitin Lamba  wrote:

> Are the remaining branding JIRAs planned in M3? I saw gfsh help fixed [1]
> but others (JMX, REST end-points) are still open.
>
> Thanks,
> Nitin
> [1] http://issues.apache.org/jira/browse/GEODE-985
>
>
> On Thu, Jul 7, 2016 at 1:38 PM, William Markito 
> wrote:
>
> > Thanks for the update Jinmei! Will hold until tomorrow for cutting the
> > branch.  Thanks!
> >
> > On Thu, Jul 7, 2016 at 11:21 AM, Jinmei Liao  wrote:
> >
> > > Hey, Kirk, Grade, Kevin and I are working on this new security feature
> > > that's almost complete which would be nice to be included in M3. Could
> > you
> > > please wait till tomorrow to cut the branch? Thanks!
> > >
> > > On Fri, Jul 1, 2016 at 6:18 PM, William Markito 
> > > wrote:
> > >
> > > > Given the recent changes on develop (*jopt-simple*) I'm planning to
> cut
> > > the
> > > > M3 release branch late next week (Wednesday/Thursday) -  So please
> > speak
> > > up
> > > > if you think otherwise... ;)
> > > >
> > > > Thanks!
> > > >
> > > > On Mon, Jun 27, 2016 at 5:50 PM, Kirk Lund  wrote:
> > > >
> > > > > Grace and I started looking into this today. The forked version of
> > > > > jopt-simple was returning a list of detected options that was being
> > > > > used during auto-complete. She came up with what looks like a good
> > > > > work-around in GFSH code that should be completed and merged to
> > > > > develop this week.
> > > > >
> > > > > -Kirk
> > > > >
> > > > > On Mon, Jun 27, 2016 at 11:14 AM, Swapnil Bawaskar <
> > > sbawas...@pivotal.io
> > > > >
> > > > > wrote:
> > > > > > I have filed https://issues.apache.org/jira/browse/GEODE-1598
> > which
> > > > may
> > > > > > have been caused by fixing GEODE-835.
> > > > > >
> > > > > > In my opinion GEODE-1598 should be fixed before we release M3.
> > > > > >
> > > > > > On Tue, Jun 21, 2016 at 12:04 AM, William Markito <
> > > wmark...@pivotal.io
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Just pushed GEODE-33 [1] for review.
> > > > > >>
> > > > > >> [1]
> > https://github.com/apache/incubator-geode/tree/feature/GEODE-33
> > > > > >>
> > > > > >> On Fri, Jun 17, 2016 at 6:05 PM, Kirk Lund 
> > > wrote:
> > > > > >>
> > > > > >> > Yep, huge thanks to Grace Meilen for finishing up GEODE-835!
> > > > > >> >
> > > > > >> > -Kirk
> > > > > >> >
> > > > > >> > On Friday, June 17, 2016, Swapnil Bawaskar <
> > sbawas...@pivotal.io>
> > > > > wrote:
> > > > > >> >
> > > > > >> > > GEODE-835 has been fixed. Do we have any progress on
> > GEODE-1493?
> > > > > >> > >
> > > > > >> > > On Wed, Jun 15, 2016 at 10:20 AM, Sai Boorlagadda <
> > > > > >> > > sai.boorlaga...@gmail.com 
> > > > > >> > > > wrote:
> > > > > >> > >
> > > > > >> > > > i will give a try fixing GEODE-1493.
> > > > > >> > > >
> > > > > >> > > > Sai
> > > > > >> > > >
> > > > > >> > > > On Wed, Jun 15, 2016 at 10:17 AM, Dan Smith <
> > > dsm...@pivotal.io
> > > > > >> > > > wrote:
> > > > > >> > > >
> > > > > >> > > > > I think we should fix GEODE-1493 for M3 - we shouldn't
> be
> > > > > shipping
> > > > > >> > > > > foldernames from the release manager's filesystem in the
> > > > binary
> > > > > >> > > release.
> > > > > >> > > > I
> > > > > >> > > > > can look into it if no one else is interested.
> > > > > >> > > > >
> > > > > >> > > > > -Dan
> > > > > >> > > > >
> > > > > >> > > > > On Wed, Jun 15, 2016 at 10:04 AM, Darrel Schneider <
> > > > > >> > > > dschnei...@pivotal.io >
> > > > > >> > > > > wrote:
> > > > > >> > > > >
> > > > > >> > > > > > The test failing in GEODE-840 I think is going to be
> > > > > classified
> > > > > >> as
> > > > > >> > > > > "flaky".
> > > > > >> > > > > > It should not hold up the m3 release.
> > > > > >> > > > > >
> > > > > >> > > > > >
> > > > > >> > > > > > On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade <
> > > > > >> > > > aging...@pivotal.io 
> > > > > >> > > > > >
> > > > > >> > > > > > wrote:
> > > > > >> > > > > >
> > > > > >> > > > > > > GEODE-1493
> > > > > >> > > > > > > Its not assigned to anyone...Someone with
> gradle/build
> > > > > >> experience
> > > > > >> > > can
> > > > > >> > > > > > pick
> > > > > >> > > > > > > this upDoesn't seems to be a stopper for M3.
> > > > > >> > > > > > >
> > > > > >> > > > > > > GEODE-835
> > > > > >> > > > > > > In progress, kirk can comment on this.
> > > > > >> > > > > > >
> > > > > >> > > > > >

[GitHub] incubator-geode pull request #191: GEODE-1587: Replaced AtomicInteger with A...

2016-07-07 Thread nabarunnag 
GitHub user nabarunnag opened a pull request:

https://github.com/apache/incubator-geode/pull/191

GEODE-1587: Replaced AtomicInteger with AtomicIntegerFieldUpdater

* Use of AtomicIntegerFieldUpdater decereased the memory overhead 
per entry during index creation

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-1587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit 782ffb61f318d2809117ea76124b5065725b7537
Author: nabarun 
Date:   2016-06-27T17:25:20Z

GEODE-1587: Replaced AtomicInteger with AtomicIntegerFieldUpdater

* Use of AtomicIntegerFieldUpdater decereased the memory overhead 
per entry during index creation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #176: GEODE-1558: Fixing failures due to rebalancing b...

2016-07-07 Thread gesterzhou 
Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/176
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread markito 
Github user markito commented on the issue:

https://github.com/apache/incubator-geode/pull/171
  
@jhuynh1, @gesterzhou , @nabarunnag just included the feedback items.  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49772: CI failure: LuceneQueriesClientDUnitTest.entriesFlushedToIndexAfterWaitForFlushCalled

2016-07-07 Thread xiaojian zhou 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49772/#review141227
---


Ship it!




Ship It!

- xiaojian zhou


On July 7, 2016, 10:39 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49772/
> ---
> 
> (Updated July 7, 2016, 10:39 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test was failing on a negative check to make sure the queue actually had 
> contents.  There were cases where the queue could be drained due to the 
> "slowness"/async pausing of the sender.
> 
> I also moved and rewrote this test out from LuceneQueriesBase as I didn't 
> think we needed to test flushing on multiple base region types.  Not sure if 
> commits stat is the correct one to check.  The docs stat was returning 0.
> 
> Also noticed that the pdx -> jsonstring conversion done in 
> LuceneTestUtilities wasn't actually using the converted jsonstring. Instead 
> we could avoid that entire if statement altogether.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
>  7d7fa3d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
>  e817d3b 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
>  8aca11c 
> 
> Diff: https://reviews.apache.org/r/49772/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread markito 
Github user markito commented on the issue:

https://github.com/apache/incubator-geode/pull/171
  
@gesterzhou Not yet. We can definitely add to the list for 1.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread gesterzhou 
Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/171
  
There's no lucene in example list? 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-geode pull request #171: feature/geode 33

2016-07-07 Thread Karen Miller 
I started from scratch with a clean copy of the the GEODE-33 branch, and
ran the replicated
example.  Everything worked well.

+1


On Thu, Jul 7, 2016 at 4:54 PM, markito  wrote:

> Github user markito commented on a diff in the pull request:
>
>
> https://github.com/apache/incubator-geode/pull/171#discussion_r70007678
>
> --- Diff: geode-examples/replicated/README.md ---
> @@ -0,0 +1,47 @@
> +# Geode replicated region example
> +
> +This is one of the most basic examples.
> +Two servers host a replicated region.
> +The producer puts 50 entries into the replicated region. The consumer
> prints the number of entries in the region.
> +
> +## Steps
> +1. From the ```geode-examples/replicated``` directory, start the
> locator and two servers:
> +
> +$ scripts/startAll.sh
> +
> +2. Run the producer:
> +
> +$ gradle run -Pmain=Producer
> +...
> +...
> +INFO: Done. Inserted 50 entries.
> +
> +3. Run the consumer:
> +
> +$ gradle run -Pmain=Consumer
> +...
> +...
> +INFO: Done. 50 entries available on the server(s).
> +
> +4. Kill one of the servers:
> +
> +$ gfsh
> +...
> +gfsh>connect
> +gfsh>stop server --name=server1
> +gfsh>quit
> +
> +5. Run the consumer a second time, and notice that all the entries
> are still available due to replication:
> +
> +$ gradle run -Pmain=Consumer
> +...
> +...
> +INFO: Done. 50 entries available on the server(s).
> +
> +6. Shutdown the system:
> +
> +$ scripts/stopAll.sh
> +
> +This example is a simple demonstration on basic APIs of Geode, as
> well how to write tests using mocks for Geode applications.
> +
> +TODO: assume jUnit4
> --- End diff --
>
> Oops, let's remove that line... Not needed anymore.  Thanks.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-geode pull request #171: feature/geode 33

2016-07-07 Thread markito 
Github user markito commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/171#discussion_r70007678
  
--- Diff: geode-examples/replicated/README.md ---
@@ -0,0 +1,47 @@
+# Geode replicated region example
+
+This is one of the most basic examples. 
+Two servers host a replicated region.
+The producer puts 50 entries into the replicated region. The consumer 
prints the number of entries in the region.
+
+## Steps
+1. From the ```geode-examples/replicated``` directory, start the locator 
and two servers:
+
+$ scripts/startAll.sh
+
+2. Run the producer:
+
+$ gradle run -Pmain=Producer
+...
+... 
+INFO: Done. Inserted 50 entries.
+
+3. Run the consumer:
+
+$ gradle run -Pmain=Consumer
+...
+...
+INFO: Done. 50 entries available on the server(s).
+
+4. Kill one of the servers:
+
+$ gfsh
+...
+gfsh>connect
+gfsh>stop server --name=server1
+gfsh>quit
+
+5. Run the consumer a second time, and notice that all the entries are 
still available due to replication: 
+
+$ gradle run -Pmain=Consumer
+...
+...
+INFO: Done. 50 entries available on the server(s).
+
+6. Shutdown the system:
+
+$ scripts/stopAll.sh
+
+This example is a simple demonstration on basic APIs of Geode, as well how 
to write tests using mocks for Geode applications.
+
+TODO: assume jUnit4
--- End diff --

Oops, let's remove that line... Not needed anymore.  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread jhuynh1 
Github user jhuynh1 commented on the issue:

https://github.com/apache/incubator-geode/pull/171
  
Some minor improvements/corrections:
1.) remove @author tag from Consumer.java
2.) The test checkIfScriptsAreExecutable runs the same line twice.  I think 
the second line was supposed to check the stop scripts and not the start scripts
3.) In one of the tests, we probably should check that Consumer.NUM_ENTRIES 
is > 0.  Just incase someone accidentally changes it to 0, the tests would pass 
but not really execute what the producer and consumer tests were expecting.
4.) preference/style : Perhaps some of the test names can be slightly more 
descriptive just so we know what the behavior should be.. such as changing 
populateWhenRegionDoesntExist to 
populateWhenRegionDoesNotExistShouldThrowNullPointer?  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #171: feature/geode 33

2016-07-07 Thread nabarunnag 
Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/171#discussion_r70006027
  
--- Diff: geode-examples/replicated/README.md ---
@@ -0,0 +1,47 @@
+# Geode replicated region example
+
+This is one of the most basic examples. 
+Two servers host a replicated region.
+The producer puts 50 entries into the replicated region. The consumer 
prints the number of entries in the region.
+
+## Steps
+1. From the ```geode-examples/replicated``` directory, start the locator 
and two servers:
+
+$ scripts/startAll.sh
+
+2. Run the producer:
+
+$ gradle run -Pmain=Producer
+...
+... 
+INFO: Done. Inserted 50 entries.
+
+3. Run the consumer:
+
+$ gradle run -Pmain=Consumer
+...
+...
+INFO: Done. 50 entries available on the server(s).
+
+4. Kill one of the servers:
+
+$ gfsh
+...
+gfsh>connect
+gfsh>stop server --name=server1
+gfsh>quit
+
+5. Run the consumer a second time, and notice that all the entries are 
still available due to replication: 
+
+$ gradle run -Pmain=Consumer
+...
+...
+INFO: Done. 50 entries available on the server(s).
+
+6. Shutdown the system:
+
+$ scripts/stopAll.sh
+
+This example is a simple demonstration on basic APIs of Geode, as well how 
to write tests using mocks for Geode applications.
+
+TODO: assume jUnit4
--- End diff --

TODO for an assumption rather than a future task may be incorrect  ???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: M3 status?

2016-07-07 Thread Nitin Lamba 
Are the remaining branding JIRAs planned in M3? I saw gfsh help fixed [1]
but others (JMX, REST end-points) are still open.

Thanks,
Nitin
[1] http://issues.apache.org/jira/browse/GEODE-985


On Thu, Jul 7, 2016 at 1:38 PM, William Markito  wrote:

> Thanks for the update Jinmei! Will hold until tomorrow for cutting the
> branch.  Thanks!
>
> On Thu, Jul 7, 2016 at 11:21 AM, Jinmei Liao  wrote:
>
> > Hey, Kirk, Grade, Kevin and I are working on this new security feature
> > that's almost complete which would be nice to be included in M3. Could
> you
> > please wait till tomorrow to cut the branch? Thanks!
> >
> > On Fri, Jul 1, 2016 at 6:18 PM, William Markito 
> > wrote:
> >
> > > Given the recent changes on develop (*jopt-simple*) I'm planning to cut
> > the
> > > M3 release branch late next week (Wednesday/Thursday) -  So please
> speak
> > up
> > > if you think otherwise... ;)
> > >
> > > Thanks!
> > >
> > > On Mon, Jun 27, 2016 at 5:50 PM, Kirk Lund  wrote:
> > >
> > > > Grace and I started looking into this today. The forked version of
> > > > jopt-simple was returning a list of detected options that was being
> > > > used during auto-complete. She came up with what looks like a good
> > > > work-around in GFSH code that should be completed and merged to
> > > > develop this week.
> > > >
> > > > -Kirk
> > > >
> > > > On Mon, Jun 27, 2016 at 11:14 AM, Swapnil Bawaskar <
> > sbawas...@pivotal.io
> > > >
> > > > wrote:
> > > > > I have filed https://issues.apache.org/jira/browse/GEODE-1598
> which
> > > may
> > > > > have been caused by fixing GEODE-835.
> > > > >
> > > > > In my opinion GEODE-1598 should be fixed before we release M3.
> > > > >
> > > > > On Tue, Jun 21, 2016 at 12:04 AM, William Markito <
> > wmark...@pivotal.io
> > > >
> > > > > wrote:
> > > > >
> > > > >> Just pushed GEODE-33 [1] for review.
> > > > >>
> > > > >> [1]
> https://github.com/apache/incubator-geode/tree/feature/GEODE-33
> > > > >>
> > > > >> On Fri, Jun 17, 2016 at 6:05 PM, Kirk Lund 
> > wrote:
> > > > >>
> > > > >> > Yep, huge thanks to Grace Meilen for finishing up GEODE-835!
> > > > >> >
> > > > >> > -Kirk
> > > > >> >
> > > > >> > On Friday, June 17, 2016, Swapnil Bawaskar <
> sbawas...@pivotal.io>
> > > > wrote:
> > > > >> >
> > > > >> > > GEODE-835 has been fixed. Do we have any progress on
> GEODE-1493?
> > > > >> > >
> > > > >> > > On Wed, Jun 15, 2016 at 10:20 AM, Sai Boorlagadda <
> > > > >> > > sai.boorlaga...@gmail.com 
> > > > >> > > > wrote:
> > > > >> > >
> > > > >> > > > i will give a try fixing GEODE-1493.
> > > > >> > > >
> > > > >> > > > Sai
> > > > >> > > >
> > > > >> > > > On Wed, Jun 15, 2016 at 10:17 AM, Dan Smith <
> > dsm...@pivotal.io
> > > > >> > > > wrote:
> > > > >> > > >
> > > > >> > > > > I think we should fix GEODE-1493 for M3 - we shouldn't be
> > > > shipping
> > > > >> > > > > foldernames from the release manager's filesystem in the
> > > binary
> > > > >> > > release.
> > > > >> > > > I
> > > > >> > > > > can look into it if no one else is interested.
> > > > >> > > > >
> > > > >> > > > > -Dan
> > > > >> > > > >
> > > > >> > > > > On Wed, Jun 15, 2016 at 10:04 AM, Darrel Schneider <
> > > > >> > > > dschnei...@pivotal.io >
> > > > >> > > > > wrote:
> > > > >> > > > >
> > > > >> > > > > > The test failing in GEODE-840 I think is going to be
> > > > classified
> > > > >> as
> > > > >> > > > > "flaky".
> > > > >> > > > > > It should not hold up the m3 release.
> > > > >> > > > > >
> > > > >> > > > > >
> > > > >> > > > > > On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade <
> > > > >> > > > aging...@pivotal.io 
> > > > >> > > > > >
> > > > >> > > > > > wrote:
> > > > >> > > > > >
> > > > >> > > > > > > GEODE-1493
> > > > >> > > > > > > Its not assigned to anyone...Someone with gradle/build
> > > > >> experience
> > > > >> > > can
> > > > >> > > > > > pick
> > > > >> > > > > > > this upDoesn't seems to be a stopper for M3.
> > > > >> > > > > > >
> > > > >> > > > > > > GEODE-835
> > > > >> > > > > > > In progress, kirk can comment on this.
> > > > >> > > > > > >
> > > > >> > > > > > > -Anil.
> > > > >> > > > > > >
> > > > >> > > > > > >
> > > > >> > > > > > >
> > > > >> > > > > > > On Wed, Jun 15, 2016 at 9:48 AM, Gregory Chase <
> > > > >> > gch...@pivotal.io
> > > > >> > > >
> > > > >> > > > > > wrote:
> > > > >> > > > > > >
> > > > >> > > > > > > > Should GEODE-33 be broken up into specific tickets?
> > > > >> > > > > > > >
> > > > >> > > > > > > > What do we want examples for?
> > > > >> > > > > > > >
> > > > >> > > > > > > > This might be easier for many of the expert users to
> > > > actually
> > > > >> > > make
> > > > >> > > > > > > > contributions.
> > > > >> > > > > > > >
> > > > >> > > > > > > > -Greg
> > > > >> > > > > > > >
> > > > >> > > > > > > > On Wed, Jun 15, 2016 at 9:40 AM, Anthony Baker <
> > > > >> > > aba...@pivotal.io >
> > > > >> > > > > > > wrote:
> > > > >> > > > > > > >
> > > > >> > > > > > > > > Hi I reviewed the JIRA’s tagged for the M3
> release.
> > > T

Review Request 49772: CI failure: LuceneQueriesClientDUnitTest.entriesFlushedToIndexAfterWaitForFlushCalled

2016-07-07 Thread Jason Huynh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49772/
---

Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

The test was failing on a negative check to make sure the queue actually had 
contents.  There were cases where the queue could be drained due to the 
"slowness"/async pausing of the sender.

I also moved and rewrote this test out from LuceneQueriesBase as I didn't think 
we needed to test flushing on multiple base region types.  Not sure if commits 
stat is the correct one to check.  The docs stat was returning 0.

Also noticed that the pdx -> jsonstring conversion done in LuceneTestUtilities 
wasn't actually using the converted jsonstring. Instead we could avoid that 
entire if statement altogether.


Diffs
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
 7d7fa3d 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
 e817d3b 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
 8aca11c 

Diff: https://reviews.apache.org/r/49772/diff/


Testing
---

geode-lucene:precheckin


Thanks,

Jason Huynh

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #363 has FAILED

2016-07-07 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #363 failed.
---
Scheduled
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-363/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

[GitHub] incubator-geode pull request #173: GEODE-33: clarify GEODE_HOME value

2016-07-07 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: M3 status?

2016-07-07 Thread William Markito 
Thanks for the update Jinmei! Will hold until tomorrow for cutting the
branch.  Thanks!

On Thu, Jul 7, 2016 at 11:21 AM, Jinmei Liao  wrote:

> Hey, Kirk, Grade, Kevin and I are working on this new security feature
> that's almost complete which would be nice to be included in M3. Could you
> please wait till tomorrow to cut the branch? Thanks!
>
> On Fri, Jul 1, 2016 at 6:18 PM, William Markito 
> wrote:
>
> > Given the recent changes on develop (*jopt-simple*) I'm planning to cut
> the
> > M3 release branch late next week (Wednesday/Thursday) -  So please speak
> up
> > if you think otherwise... ;)
> >
> > Thanks!
> >
> > On Mon, Jun 27, 2016 at 5:50 PM, Kirk Lund  wrote:
> >
> > > Grace and I started looking into this today. The forked version of
> > > jopt-simple was returning a list of detected options that was being
> > > used during auto-complete. She came up with what looks like a good
> > > work-around in GFSH code that should be completed and merged to
> > > develop this week.
> > >
> > > -Kirk
> > >
> > > On Mon, Jun 27, 2016 at 11:14 AM, Swapnil Bawaskar <
> sbawas...@pivotal.io
> > >
> > > wrote:
> > > > I have filed https://issues.apache.org/jira/browse/GEODE-1598 which
> > may
> > > > have been caused by fixing GEODE-835.
> > > >
> > > > In my opinion GEODE-1598 should be fixed before we release M3.
> > > >
> > > > On Tue, Jun 21, 2016 at 12:04 AM, William Markito <
> wmark...@pivotal.io
> > >
> > > > wrote:
> > > >
> > > >> Just pushed GEODE-33 [1] for review.
> > > >>
> > > >> [1] https://github.com/apache/incubator-geode/tree/feature/GEODE-33
> > > >>
> > > >> On Fri, Jun 17, 2016 at 6:05 PM, Kirk Lund 
> wrote:
> > > >>
> > > >> > Yep, huge thanks to Grace Meilen for finishing up GEODE-835!
> > > >> >
> > > >> > -Kirk
> > > >> >
> > > >> > On Friday, June 17, 2016, Swapnil Bawaskar 
> > > wrote:
> > > >> >
> > > >> > > GEODE-835 has been fixed. Do we have any progress on GEODE-1493?
> > > >> > >
> > > >> > > On Wed, Jun 15, 2016 at 10:20 AM, Sai Boorlagadda <
> > > >> > > sai.boorlaga...@gmail.com 
> > > >> > > > wrote:
> > > >> > >
> > > >> > > > i will give a try fixing GEODE-1493.
> > > >> > > >
> > > >> > > > Sai
> > > >> > > >
> > > >> > > > On Wed, Jun 15, 2016 at 10:17 AM, Dan Smith <
> dsm...@pivotal.io
> > > >> > > > wrote:
> > > >> > > >
> > > >> > > > > I think we should fix GEODE-1493 for M3 - we shouldn't be
> > > shipping
> > > >> > > > > foldernames from the release manager's filesystem in the
> > binary
> > > >> > > release.
> > > >> > > > I
> > > >> > > > > can look into it if no one else is interested.
> > > >> > > > >
> > > >> > > > > -Dan
> > > >> > > > >
> > > >> > > > > On Wed, Jun 15, 2016 at 10:04 AM, Darrel Schneider <
> > > >> > > > dschnei...@pivotal.io >
> > > >> > > > > wrote:
> > > >> > > > >
> > > >> > > > > > The test failing in GEODE-840 I think is going to be
> > > classified
> > > >> as
> > > >> > > > > "flaky".
> > > >> > > > > > It should not hold up the m3 release.
> > > >> > > > > >
> > > >> > > > > >
> > > >> > > > > > On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade <
> > > >> > > > aging...@pivotal.io 
> > > >> > > > > >
> > > >> > > > > > wrote:
> > > >> > > > > >
> > > >> > > > > > > GEODE-1493
> > > >> > > > > > > Its not assigned to anyone...Someone with gradle/build
> > > >> experience
> > > >> > > can
> > > >> > > > > > pick
> > > >> > > > > > > this upDoesn't seems to be a stopper for M3.
> > > >> > > > > > >
> > > >> > > > > > > GEODE-835
> > > >> > > > > > > In progress, kirk can comment on this.
> > > >> > > > > > >
> > > >> > > > > > > -Anil.
> > > >> > > > > > >
> > > >> > > > > > >
> > > >> > > > > > >
> > > >> > > > > > > On Wed, Jun 15, 2016 at 9:48 AM, Gregory Chase <
> > > >> > gch...@pivotal.io
> > > >> > > >
> > > >> > > > > > wrote:
> > > >> > > > > > >
> > > >> > > > > > > > Should GEODE-33 be broken up into specific tickets?
> > > >> > > > > > > >
> > > >> > > > > > > > What do we want examples for?
> > > >> > > > > > > >
> > > >> > > > > > > > This might be easier for many of the expert users to
> > > actually
> > > >> > > make
> > > >> > > > > > > > contributions.
> > > >> > > > > > > >
> > > >> > > > > > > > -Greg
> > > >> > > > > > > >
> > > >> > > > > > > > On Wed, Jun 15, 2016 at 9:40 AM, Anthony Baker <
> > > >> > > aba...@pivotal.io >
> > > >> > > > > > > wrote:
> > > >> > > > > > > >
> > > >> > > > > > > > > Hi I reviewed the JIRA’s tagged for the M3 release.
> > The
> > > >> good
> > > >> > > > news
> > > >> > > > > is
> > > >> > > > > > > > that
> > > >> > > > > > > > > we’ve fixed 180 issues!  Here are the remaining open
> > > >> issues:
> > > >> > > > > > > > >
> > > >> > > > > > > > > GEODE-33: Project examples
> > > >> > > > > > > > > GEODE-835: joptsimple replacement
> > > >> > > > > > > > > GEODE-840: CI failure in
> > > >> > > > > > > > >
> > > >> > > DistributedAckPersistentRegionCCEOffHeapDUnitTest.testTombstones
> > > >> > > > > > > > > GEODE-1493: gemfire.properties default value for
> > config

Re: M3 status?

2016-07-07 Thread Jinmei Liao 
Hey, Kirk, Grade, Kevin and I are working on this new security feature
that's almost complete which would be nice to be included in M3. Could you
please wait till tomorrow to cut the branch? Thanks!

On Fri, Jul 1, 2016 at 6:18 PM, William Markito  wrote:

> Given the recent changes on develop (*jopt-simple*) I'm planning to cut the
> M3 release branch late next week (Wednesday/Thursday) -  So please speak up
> if you think otherwise... ;)
>
> Thanks!
>
> On Mon, Jun 27, 2016 at 5:50 PM, Kirk Lund  wrote:
>
> > Grace and I started looking into this today. The forked version of
> > jopt-simple was returning a list of detected options that was being
> > used during auto-complete. She came up with what looks like a good
> > work-around in GFSH code that should be completed and merged to
> > develop this week.
> >
> > -Kirk
> >
> > On Mon, Jun 27, 2016 at 11:14 AM, Swapnil Bawaskar  >
> > wrote:
> > > I have filed https://issues.apache.org/jira/browse/GEODE-1598 which
> may
> > > have been caused by fixing GEODE-835.
> > >
> > > In my opinion GEODE-1598 should be fixed before we release M3.
> > >
> > > On Tue, Jun 21, 2016 at 12:04 AM, William Markito  >
> > > wrote:
> > >
> > >> Just pushed GEODE-33 [1] for review.
> > >>
> > >> [1] https://github.com/apache/incubator-geode/tree/feature/GEODE-33
> > >>
> > >> On Fri, Jun 17, 2016 at 6:05 PM, Kirk Lund  wrote:
> > >>
> > >> > Yep, huge thanks to Grace Meilen for finishing up GEODE-835!
> > >> >
> > >> > -Kirk
> > >> >
> > >> > On Friday, June 17, 2016, Swapnil Bawaskar 
> > wrote:
> > >> >
> > >> > > GEODE-835 has been fixed. Do we have any progress on GEODE-1493?
> > >> > >
> > >> > > On Wed, Jun 15, 2016 at 10:20 AM, Sai Boorlagadda <
> > >> > > sai.boorlaga...@gmail.com 
> > >> > > > wrote:
> > >> > >
> > >> > > > i will give a try fixing GEODE-1493.
> > >> > > >
> > >> > > > Sai
> > >> > > >
> > >> > > > On Wed, Jun 15, 2016 at 10:17 AM, Dan Smith  > >> > > > wrote:
> > >> > > >
> > >> > > > > I think we should fix GEODE-1493 for M3 - we shouldn't be
> > shipping
> > >> > > > > foldernames from the release manager's filesystem in the
> binary
> > >> > > release.
> > >> > > > I
> > >> > > > > can look into it if no one else is interested.
> > >> > > > >
> > >> > > > > -Dan
> > >> > > > >
> > >> > > > > On Wed, Jun 15, 2016 at 10:04 AM, Darrel Schneider <
> > >> > > > dschnei...@pivotal.io >
> > >> > > > > wrote:
> > >> > > > >
> > >> > > > > > The test failing in GEODE-840 I think is going to be
> > classified
> > >> as
> > >> > > > > "flaky".
> > >> > > > > > It should not hold up the m3 release.
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade <
> > >> > > > aging...@pivotal.io 
> > >> > > > > >
> > >> > > > > > wrote:
> > >> > > > > >
> > >> > > > > > > GEODE-1493
> > >> > > > > > > Its not assigned to anyone...Someone with gradle/build
> > >> experience
> > >> > > can
> > >> > > > > > pick
> > >> > > > > > > this upDoesn't seems to be a stopper for M3.
> > >> > > > > > >
> > >> > > > > > > GEODE-835
> > >> > > > > > > In progress, kirk can comment on this.
> > >> > > > > > >
> > >> > > > > > > -Anil.
> > >> > > > > > >
> > >> > > > > > >
> > >> > > > > > >
> > >> > > > > > > On Wed, Jun 15, 2016 at 9:48 AM, Gregory Chase <
> > >> > gch...@pivotal.io
> > >> > > >
> > >> > > > > > wrote:
> > >> > > > > > >
> > >> > > > > > > > Should GEODE-33 be broken up into specific tickets?
> > >> > > > > > > >
> > >> > > > > > > > What do we want examples for?
> > >> > > > > > > >
> > >> > > > > > > > This might be easier for many of the expert users to
> > actually
> > >> > > make
> > >> > > > > > > > contributions.
> > >> > > > > > > >
> > >> > > > > > > > -Greg
> > >> > > > > > > >
> > >> > > > > > > > On Wed, Jun 15, 2016 at 9:40 AM, Anthony Baker <
> > >> > > aba...@pivotal.io >
> > >> > > > > > > wrote:
> > >> > > > > > > >
> > >> > > > > > > > > Hi I reviewed the JIRA’s tagged for the M3 release.
> The
> > >> good
> > >> > > > news
> > >> > > > > is
> > >> > > > > > > > that
> > >> > > > > > > > > we’ve fixed 180 issues!  Here are the remaining open
> > >> issues:
> > >> > > > > > > > >
> > >> > > > > > > > > GEODE-33: Project examples
> > >> > > > > > > > > GEODE-835: joptsimple replacement
> > >> > > > > > > > > GEODE-840: CI failure in
> > >> > > > > > > > >
> > >> > > DistributedAckPersistentRegionCCEOffHeapDUnitTest.testTombstones
> > >> > > > > > > > > GEODE-1493: gemfire.properties default value for
> config
> > dir
> > >> > > > > > > > >
> > >> > > > > > > > > Any sense for when these issues will be resolved?
> Which
> > >> ones
> > >> > > are
> > >> > > > > > > > required
> > >> > > > > > > > > for M3?
> > >> > > > > > > > >
> > >> > > > > > > > > Anthony
> > >> > > > > > > > >
> > >> > > > > > > > >
> > >> > > > > > > >
> > >> > > > > > > >
> > >> > > > > > > > --
> > >> > > > > > > > Greg Chase
> > >> > > > > > > >
> > >> > > > > > > > Global Head, Big Data Communities
> > >> > > > > > > > ht

[GitHub] incubator-geode issue #190: Feature/geode 11 gfsh commands

2016-07-07 Thread jinmeiliao 
Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/190
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #190: Feature/geode 11 gfsh commands

2016-07-07 Thread nabarunnag 
Github user nabarunnag commented on the issue:

https://github.com/apache/incubator-geode/pull/190
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #190: Feature/geode 11 gfsh commands

2016-07-07 Thread nabarunnag 
Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/190#discussion_r69954541
  
--- Diff: 
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/cli/LuceneIndexCommandsDUnitTest.java
 ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.gemstone.gemfire.cache.lucene.internal.cli;
+
+import com.gemstone.gemfire.cache.*;
+import com.gemstone.gemfire.cache.lucene.LuceneService;
+import com.gemstone.gemfire.cache.lucene.LuceneServiceProvider;
+import com.gemstone.gemfire.management.cli.Result.Status;
+import com.gemstone.gemfire.management.internal.cli.CommandManager;
+import 
com.gemstone.gemfire.management.internal.cli.commands.CliCommandTestBase;
+import com.gemstone.gemfire.management.internal.cli.result.CommandResult;
+import 
com.gemstone.gemfire.management.internal.cli.util.CommandStringBuilder;
+import com.gemstone.gemfire.test.dunit.*;
+import com.gemstone.gemfire.test.junit.categories.DistributedTest;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import static com.gemstone.gemfire.cache.lucene.test.LuceneTestUtilities.*;
+import static com.gemstone.gemfire.test.dunit.Assert.*;
+
+@Category(DistributedTest.class)
+public class LuceneIndexCommandsDUnitTest extends CliCommandTestBase {
+
+  @Test
+  public void testListIndex() throws Exception {
--- End diff --

I am not sure of this one but should we maintain the test naming convention 
as test()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-07-07 Thread anilkumar gingade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49102/#review141188
---


Fix it, then Ship it!




Ship It!


geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
 


How about adding comment about why we need to proceed even if the processor 
is stopped...This will help in future, if someone introduces the stop check 
back again...


- anilkumar gingade


On July 6, 2016, 8:42 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49102/
> ---
> 
> (Updated July 6, 2016, 8:42 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When closing a sender, the close connection message is sent on the same 
> connection that is used by the ack reader thread.  This causes an issue as 
> two threads are now reading off the same socket concurrently.  The fix is to 
> prevent this from happening but to do so, the input stream needs to be closed 
> (to free up from a socket read()).  
> The dispatcher also needs to shut down before the close connection is sent 
> out or it will spawn off another ack reader thread.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  ce08e8d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
>  07a3be5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
>  ff810ec 
>   
> geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  b178192 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java
>  358ffaf 
> 
> Diff: https://reviews.apache.org/r/49102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode pull request #190: Feature/geode 11 gfsh commands

2016-07-07 Thread nabarunnag 
Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/190#discussion_r69952124
  
--- Diff: 
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/cli/LuceneCliStrings.java
 ---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.gemstone.gemfire.cache.lucene.internal.cli;
+
+public class LuceneCliStrings {
+  public static final String LUCENE_LIST_INDEX = "lucene list indexes";
+  public static final String LUCENE_LIST_INDEX__HELP = "Display the list 
of lucene indexes created for all members.";
--- End diff --

Capitalization of Lucene and Index is bit inconsistent in these strings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #190: Feature/geode 11 gfsh commands

2016-07-07 Thread jhuynh1 
Github user jhuynh1 commented on the issue:

https://github.com/apache/incubator-geode/pull/190
  
+1

nit picky- there is a comment with the word lucene that should probably be 
capitalized.  Other than that looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #176: GEODE-1558: Fixing failures due to rebala...

2016-07-07 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/176


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #190: Feature/geode 11 gfsh commands

2016-07-07 Thread upthewaterspout 
Github user upthewaterspout commented on the issue:

https://github.com/apache/incubator-geode/pull/190
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #176: GEODE-1558: Fixing failures due to rebalancing b...

2016-07-07 Thread boglesby 
Github user boglesby commented on the issue:

https://github.com/apache/incubator-geode/pull/176
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---