Re: Review Request 53442: GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53442/ --- (Updated Nov. 3, 2016, 11:08 p.m.) Review request for geode, Darrel Schneider and Eric Shu. Changes --- Added try/finally clause for lock/unlock of regions Bugs: GEODE-1740 https://issues.apache.org/jira/browse/GEODE-1740 Repository: geode Description --- GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit Diffs (updated) - geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java de05b0d3991254834da94ed97ada9c9247aa69ab geode-core/src/main/java/org/apache/geode/internal/cache/RegionMap.java ee8a84e57b5b72cc801cd2474a51dfd0bd3083f3 geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 99a3b83d931dccd0faec482e42cda7ded18a13e7 geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53442/diff/ Testing --- New unit test ClearTXLockingDUnitTest precheckin Thanks, Scott Jewell
Review Request 53442: GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53442/ --- Review request for geode, Darrel Schneider and Eric Shu. Bugs: GEODE-1740 https://issues.apache.org/jira/browse/GEODE-1740 Repository: geode Description --- GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit Diffs - geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java de05b0d3991254834da94ed97ada9c9247aa69ab geode-core/src/main/java/org/apache/geode/internal/cache/RegionMap.java ee8a84e57b5b72cc801cd2474a51dfd0bd3083f3 geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 99a3b83d931dccd0faec482e42cda7ded18a13e7 geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53442/diff/ Testing --- New unit test ClearTXLockingDUnitTest precheckin Thanks, Scott Jewell
Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/#review154618 --- Ship it! Ship It! - Scott Jewell On Nov. 1, 2016, 11:25 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53355/ > --- > > (Updated Nov. 1, 2016, 11:25 p.m.) > > > Review request for geode, anilkumar gingade and Scott Jewell. > > > Bugs: GEODE-1971 > https://issues.apache.org/jira/browse/GEODE-1971 > > > Repository: geode > > > Description > --- > > shutdownAll now syncs on just the class instead of "this". Since it calls > close which also syncs on the class it is best to get this sync done early > and hold it for the entire shutdown. > Some other methods that were syncing on the class no longer do. They had not > reason for doing so. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > ba4f1f410cef89a276634dadecf46ac80d9c3990 > > Diff: https://reviews.apache.org/r/53355/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 53154: GEODE-2026: fix flaky test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53154/#review153756 --- Ship it! Code looks good. Seems like 30 seconds is one of those things that should normally happen very fast, but occasionally might be hung up for some reason (i.e. GC), so why not wait 200 or something. A longer wait max would not slow the test down, but might miss an occasional GC pause or something. - Scott Jewell On Oct. 24, 2016, 11:19 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53154/ > --- > > (Updated Oct. 24, 2016, 11:19 p.m.) > > > Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken > Howe. > > > Bugs: GEODE-2026 > https://issues.apache.org/jira/browse/GEODE-2026 > > > Repository: geode > > > Description > --- > > The test was initializing a value to a String, > then starting an async thread that would keep > changing it to an int, > it slept for 100ms and then assummed that the async > thread had changed the value to an Integer. > In rare cases the thread never was able to to its first > put so the value was still a String. > > The test now waits for the async thread to change the value > to an Integer instead of doing a 100ms sleep. > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > 5ca3d014b4bac01e239561301666fae5fb0d61ea > > Diff: https://reviews.apache.org/r/53154/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 52468: Add FlakyTest category to tests with open bugs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52468/#review151186 --- Ship it! Ship It! - Scott Jewell On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52468/ > --- > > (Updated Oct. 2, 2016, 12:07 a.m.) > > > Review request for geode. > > > Repository: geode > > > Description > --- > > Annotate test methods with FlakyTest category if there is an open > bug for that test. This will improve the signal/noise ratio for > unit/integration/distributed tests. Flaky tests are still run > as part of precheckin and flakyTest targets. > > > Diffs > - > > > extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsOffHeapDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/CompiledInDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexOperationsOnOverflowRegionDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRQueryRegionCloseDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java > PRE-CREATION > geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/SystemAdminDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/internal/ConsoleDistributionManagerDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionSingleHopDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionFailoverDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionSelectorNoSingleHopDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/Bug36805DUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DurableRegistrationDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/w
Re: Review Request 52228: fix hang introduced by GEODE-1885
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52228/#review150414 --- Ship it! Ship It! - Scott Jewell On Sept. 23, 2016, 10:51 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52228/ > --- > > (Updated Sept. 23, 2016, 10:51 p.m.) > > > Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken > Howe. > > > Bugs: GEODE-1885 > https://issues.apache.org/jira/browse/GEODE-1885 > > > Repository: geode > > > Description > --- > > The fix for GEODE-1885 introduced a hang on off-heap regions. > If a concurrent close/destroy of the region happens while other threads are > modifying it then the thread doing the modification can get stuck in a hot > loop that never terminates. > The hot loop is in AbstractRegionMap when it tests the existing region entry > it finds to see if it can be modified. If the region entry has a value that > says it is removed then the operation spins around and tries again. It > expects the thread that marked it as being removed to also remove it from the > map. The fix for GEODE-1885 can cause a remove to not happen. > So this fix does two things: > 1. On retry remove the existing removed region entry from the map. > 2. putEntryIfAbsent now only releases the current entry if it has an > off-heap reference. This prevents an infinite loop that was caused by the > current thread who just added a new entry with REMOVE_PHASE1 from releasing > it (changing it to REMOVE_PHASE2) because it see that the region is > closed/destroyed. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java > 33e98b6ae8a795c5a7b60aa93c7384750eb9582b > > Diff: https://reviews.apache.org/r/52228/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Review Request 51559: GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51559/ --- Review request for geode, Darrel Schneider and Ken Howe. Repository: geode Description --- GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log Diffs - geode-core/src/test/java/com/gemstone/gemfire/internal/cache/Bug37377DUnitTest.java 0531100a57a5b888576b77b2700271a7abfd324c Diff: https://reviews.apache.org/r/51559/diff/ Testing --- Ran test and it now runs successfully Thanks, Scott Jewell
Re: Review Request 51018: fix diskStats and prStats related to entry count and data size
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51018/#review145677 --- Ship it! Ship It! - Scott Jewell On Aug. 11, 2016, 11:15 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51018/ > --- > > (Updated Aug. 11, 2016, 11:15 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, and Ken Howe. > > > Bugs: GEODE-1714 > https://issues.apache.org/jira/browse/GEODE-1714 > > > Repository: geode > > > Description > --- > > entriesInVM no longer counts entries that have no value in the VM. > Before it was counting invalid entries as being inVM. > Also fixed some code paths that were not updating the PR stats which led to > dataStoreEntriesInUse not being consistent with CachePerfStats entries. > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractLRURegionMap.java > c9b3038f79ae917b04316e89017c84daa4a8d76a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > f3cb3d654087c797de430f448348c3ba66846ac4 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > 98ee7292a3ae75d8d5bc26a7af3d64f34cea55e8 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 46ccd47e96e75a8c4c6f3075b65a2d2447043213 > > geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskRegionDUnitTest.java > a43950edde101c8c28c7773571f6e74b5dfad5fd > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegRecoveryJUnitTest.java > 792f07eb1a8af4a93eb67ad15378fdbf350d218e > > Diff: https://reviews.apache.org/r/51018/diff/ > > > Testing > --- > > precheckin > Also run a bunch of hydra tests that had been failing > > > Thanks, > > Darrel Schneider > >
Review Request 50967: GEODE-599: CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50967/ --- Review request for geode, Darrel Schneider, Eric Shu, and Ken Howe. Repository: geode Description --- **I'LL SQUASH THIS WHEN I PUSH IT UP FOR THE PULL REQUEST** Cache modification lock was being released before operation distribution to other members. This provided a small window in which an operation from another thread could update the region prior to the other members receiving notification (i.e. down leveled) GEODE-599: Flush current operations if region scope is NO_ACK GEODE-599: Cleanup commented code GEODE-599: General code cleanup of ClearRvvLockingDUnitTest GEODE-599: Remove unnecessary region reference from RegionVersionVector commit Merge remote-tracking branch 'origin/develop' into feature/GEODE-599 Merge remote-tracking branch 'origin/develop' into feature/GEODE-599 GEODE-599: Resolve issues with region operations and RVV locking Merge remote-tracking branch 'origin/develop' into feature/GEODE-599 GEODE-599: Add license to ARMLockTestHookAdapter GEODE-599: Remove reference to test class VM from AbstractRegionMap GEODE-599: Remove test class VM from ARM GEODE-599: Refactor ARMLockTestHook interface GEODE-599: Ensure test hook reset after test via finally clause Merge remote-tracking branch 'origin/develop' into feature/GEODE-599 Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 226e1948412a178c2a18a1e0a7d701b331c57e72 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java f1627d38b9d84c673a15c812712ebad297ce87ce geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedClearOperation.java 5526ef01639869b10b0f8e475a6c23f62bdf9a86 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java b42a617fe681700ca0c58f76c88b52535b7692b2 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 46ccd47e96e75a8c4c6f3075b65a2d2447043213 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java 3ad2cc1ff4fb352571bf6073d535fefb5837b12f geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionMap.java 14a2d2f09e2ff83b84080b2df558290a7a47710f geode-core/src/main/java/com/gemstone/gemfire/internal/cache/StateFlushOperation.java 88666898574dfde3a2f7a148144f41f18f56687e geode-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionVector.java 2f024229d72c6259a360b1742fe33dbd8d6a2ab3 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ARMLockTestHookAdapter.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ClearRvvLockingDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50967/diff/ Testing --- Thanks, Scott Jewell
Re: Review Request 50468: fix stat corrupting when async queue full
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50468/#review143641 --- Ship it! Ship It! - Scott Jewell On July 26, 2016, 10:11 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50468/ > --- > > (Updated July 26, 2016, 10:11 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1700 > https://issues.apache.org/jira/browse/GEODE-1700 > > > Repository: geode > > > Description > --- > > A common method is now used for writing async ops to disk. > The same method is now used for both flushing an item that > has been taken out of the queue and for when the queue is > full causing a sync write to be done. > > Also did a minor refactoring to get rid of the "removed" flag. > > > Diffs > - > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > 698e3bd101ccec92833a1feead0a253ae8ce9bf0 > > Diff: https://reviews.apache.org/r/50468/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 49811: add defragmentationsInProgress stat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49811/#review141718 --- Ship it! Ship It! - Scott Jewell On July 8, 2016, 6:22 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49811/ > --- > > (Updated July 8, 2016, 6:22 p.m.) > > > Review request for geode, Scott Jewell and Ken Howe. > > > Bugs: GEODE-1590 > https://issues.apache.org/jira/browse/GEODE-1590 > > > Repository: geode > > > Description > --- > > add defragmentationsInProgress stat > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapMemoryStats.java > 12048140880c7c708a6a498c46e6c0503cbfbc8a > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > 47f25b033d3ff9f646165418a8254fd00ee9a41a > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/NullOffHeapMemoryStats.java > 6a1b2a635ddb9aa86ee2037d070030bcc3f0098f > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java > 90ff3cf593b3803a0f9fb2f81ff35c4adf7a678b > > Diff: https://reviews.apache.org/r/49811/diff/ > > > Testing > --- > > OffHeapStorageJUnitTest > > > Thanks, > > Darrel Schneider > >
Re: Review Request 49713: increase default number of off-heap free lists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49713/#review141038 --- Ship it! Ship It! - Scott Jewell On July 6, 2016, 5:23 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49713/ > --- > > (Updated July 6, 2016, 5:23 p.m.) > > > Review request for geode, Scott Jewell and Ken Howe. > > > Bugs: GEODE-1593 > https://issues.apache.org/jira/browse/GEODE-1593 > > > Repository: geode > > > Description > --- > > increase default number of off-heap free lists > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java > ffd5b0af2190626ceebe7a52abddc2bde943255e > > Diff: https://reviews.apache.org/r/49713/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48189/#review136326 --- Ship it! Page 4 reviewed - looks good - Scott Jewell On June 2, 2016, 10:20 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48189/ > --- > > (Updated June 2, 2016, 10:20 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1464 > https://issues.apache.org/jira/browse/GEODE-1464 > > > Repository: geode > > > Description > --- > > removed internal Delta (only used by sqlf) > removed sqlfDisconnectListener > removed getStringForSQLF > removed sqlfabric.sys-disk-dir system property > removed unInitializedMembers and deferredVolunteerForPrimary > removed sqlf serialization code > removed GemFireUtilLauncher > removed afterValueOverflow > removed preferObject, eager deserialize, and KeyWithRegionContext > removed unused sqlf methods in PartitionedRegion > removed memberUnInitialized > removed sqlf from DiskEntry > removed setCallbackArgument from EntryOperationImpl > removed distributeUpdatedProfileOnHubCreation > removed getEntriesInTxForSqlFabric > removed withRoutingObjects and hasRoutingObjects > removed resetBucketAdvisorParents > rebalance no longer calls GemFireCacheImpl.getInstance comments > removed sqlf log messages > removed sqlf OffHeapIdentifiers > removed SqlfSerializationException from sanctionedSerializables > removed static helper methods from DiskWriteAttributesImpl > removed contextObject from EntryEventImpl > remove serializeCallbackArg from WrappedCallbackArgument since it was always > true > removed getLeaderRegionName and getColocatedRegionName > removed newPutEntryEvent > removed clearLocalPrimaries > removed call to non-existent OSProcess$NativeOSCalls > removed putDML > removed getClassesToSerializers > simplified cleanUpOnImcompleteOp > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java > facbdf2cecd699361c3cc7782a38ab21d436637e > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java > bb36b8023b050f17e2d8e742875c736bcabf7755 > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > 552dbe3e2aeda91a6dbce7d0f27e07c038f683cc > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java > e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e > geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java > 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f > geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java > bd78f5ae78953fab616f2ada870aa1aa920d56f3 > > geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java > 7427f9009dfb732971970a518a2a27adc81c62cd > > geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java > fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 > > geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java > bff592b5ac8dc98f7bcd716910ae4c776fadb358 > geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java > 515b27dcf0ff38ea5f1024f7ba8b7262172c203a > geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java > 258eaf0e683da7ce4025f5cf388574935dcc3bc4 > > geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java > a2711ffee9e7575edeff8cd921a3168883ce9ec8 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java > b65b7addc4d572b262b0a0a8a99ee4a79ac0390f > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java > 25cc818603e5a4f1a0a10f57a2861afb0599bd81 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > 0cbec19408198a5d4fc7f975b43ad4075e29a580 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java > c241c6b7760e0cde59facd7f708c716f563eb2a9 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java > e2482bb5592546d280c6f3fb73f7775e9a174afd > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java > 4a34771388da63a648c6d7763fc39334aa716b38 > > geode-co
Re: Review Request 47796: fix callback arg parameter order
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47796/#review134658 --- Ship it! Ship It! - Scott Jewell On May 24, 2016, 9:47 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47796/ > --- > > (Updated May 24, 2016, 9:47 p.m.) > > > Review request for geode, Scott Jewell and Ken Howe. > > > Bugs: GEODE-1425 > https://issues.apache.org/jira/browse/GEODE-1425 > > > Repository: geode > > > Description > --- > > fix callback arg parameter order > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalDataSet.java > daa7d3fff19d61ce9139a83f8898b598ae07ba06 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/LocalDataSetTest.java > fd813ed66e4dce06185c682bf7b3693921b45d94 > > Diff: https://reviews.apache.org/r/47796/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 47678: Preventing the sequence logger from launching and closing a thread
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47678/#review134643 --- Ship it! Ship It! - Scott Jewell On May 20, 2016, 10:40 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47678/ > --- > > (Updated May 20, 2016, 10:40 p.m.) > > > Review request for geode and Scott Jewell. > > > Repository: geode > > > Description > --- > > The sequence logger code was launching a thread from a static block, even if > it was not enabled. The thread was then immediately dying. Fixing the code to > not launch the thread unless it is enabled, and to not die immediately if it > is. > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/sequencelog/SequenceLoggerImpl.java > 26c944eafbe68ee0f59a90c79d2330db219f3265 > > Diff: https://reviews.apache.org/r/47678/diff/ > > > Testing > --- > > running precheckin > > > Thanks, > > Dan Smith > >
Re: Review Request 47479: GEODE-1296: change conditional in getRawBytes to assert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47479/#review134642 --- Ship it! Ship It! - Scott Jewell On May 17, 2016, 5:22 p.m., Ken Howe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47479/ > --- > > (Updated May 17, 2016, 5:22 p.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Sai > Boorlagadda. > > > Repository: geode > > > Description > --- > > Made suggested change to getRawBytes. Updated correspondiong unit test. > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObject.java > c2066b4a098ffb676ba31d7be244cf74ec9923d0 > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java > 23d72f532843ec0904e78b823a02d43b3cad1c74 > > Diff: https://reviews.apache.org/r/47479/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Ken Howe > >
Re: Review Request 47744: deliver event synchronously if it is rejected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47744/#review134640 --- Ship it! Ship It! - Scott Jewell On May 23, 2016, 10:36 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47744/ > --- > > (Updated May 23, 2016, 10:36 p.m.) > > > Review request for geode, Scott Jewell and Ken Howe. > > > Bugs: GEODE-1428 > https://issues.apache.org/jira/browse/GEODE-1428 > > > Repository: geode > > > Description > --- > > If the event is rejected by the async thread pool then process it > synchronously instead of logging a warning. > > Changed unit test to use close instead of emergencyClose. > Doing this caused an event to be sent after the async thread > pool was shutdown which resulted in a suspect warning without > this fix. > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > d28496cc6e58cf061ce996d45526f3a0bd3ab10f > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GemFireCacheImplTest.java > 7f95cadd68ad218f32129f6369198ae4ed968454 > > Diff: https://reviews.apache.org/r/47744/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 47264: GEODE-1252: modify bits atomically
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47264/#review132769 --- Ship it! Ship It! - Scott Jewell On May 11, 2016, 9:50 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47264/ > --- > > (Updated May 11, 2016, 9:50 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1252 > https://issues.apache.org/jira/browse/GEODE-1252 > > > Repository: geode > > > Description > --- > > The bits field is now modified atomically using a AtomicIntegerFieldUpdater. > Also added unit test for bit methods > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/VersionTag.java > 60e4299d5dfd13803b2e7f8e9b1aab858e8d1982 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/AbstractVersionTagTestBase.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/VMVersionTagTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47264/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 46854: GEODE-1224: Modify BucketRegion.getCloningEnabled to call this.partitionedRegion.getCloningEnabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46854/ --- (Updated May 4, 2016, 6:42 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- Reverted put() and added new putInitial() method Repository: geode Description --- Modified BucketRegion and PRDeltaPropagationDUnitTest Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java d37f025d9dc81b938425c277f33b7138951d2252 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java f5ae0fb37c9347d5ce8fe18bc1d61fdace941c98 geode-core/src/test/java/com/gemstone/gemfire/DeltaTestImpl.java cd824590ada9652db75f4dd94cd2c0dba3cf9b5a geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/PRDeltaPropagationDUnitTest.java e8816f979f1b1627f7540975a7904065735c016d Diff: https://reviews.apache.org/r/46854/diff/ Testing --- precheckin Thanks, Scott Jewell
Re: Review Request 46854: GEODE-1224: Modify BucketRegion.getCloningEnabled to call this.partitionedRegion.getCloningEnabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46854/ --- (Updated May 2, 2016, 4:26 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Repository: geode Description --- Modified BucketRegion and PRDeltaPropagationDUnitTest Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java d37f025d9dc81b938425c277f33b7138951d2252 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java f5ae0fb37c9347d5ce8fe18bc1d61fdace941c98 geode-core/src/test/java/com/gemstone/gemfire/DeltaTestImpl.java cd824590ada9652db75f4dd94cd2c0dba3cf9b5a geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/PRDeltaPropagationDUnitTest.java e8816f979f1b1627f7540975a7904065735c016d Diff: https://reviews.apache.org/r/46854/diff/ Testing (updated) --- precheckin Thanks, Scott Jewell
Review Request 46854: GEODE-1224: Modify BucketRegion.getCloningEnabled to call this.partitionedRegion.getCloningEnabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46854/ --- Review request for geode, Darrel Schneider and Ken Howe. Repository: geode Description --- Modified BucketRegion and PRDeltaPropagationDUnitTest Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java d37f025d9dc81b938425c277f33b7138951d2252 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java f5ae0fb37c9347d5ce8fe18bc1d61fdace941c98 geode-core/src/test/java/com/gemstone/gemfire/DeltaTestImpl.java cd824590ada9652db75f4dd94cd2c0dba3cf9b5a geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/PRDeltaPropagationDUnitTest.java e8816f979f1b1627f7540975a7904065735c016d Diff: https://reviews.apache.org/r/46854/diff/ Testing --- precheckin is currently running Thanks, Scott Jewell
Re: Review Request 46668: putAll and removeAll getEventForPosition no longer marked as retained
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46668/#review130651 --- Ship it! Ship It! - Scott Jewell On April 26, 2016, 12:46 a.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46668/ > --- > > (Updated April 26, 2016, 12:46 a.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1238 > https://issues.apache.org/jira/browse/GEODE-1238 > > > Repository: geode > > > Description > --- > > When fixing GEODE-1238 getEventForPosition was thought to return a retained > offheap reference. So release calls were added. But this is wrong. > getEventForPosition now uses the @Unretained annotation and the release calls > on it have been removed. > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java > 4b4d4d34c892db3e000bc690be785a4040db42a7 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java > 34889aac5501c0186ceb0acfde8fa4fe5ca75bc9 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterProfile.java > 65e7a841cf0c97d241d6e3324923804212a2a3b1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 4360b2a7837844c3b29b8c43a2036656e2183780 > > Diff: https://reviews.apache.org/r/46668/diff/ > > > Testing > --- > > precheckin and hydra tests > > > Thanks, > > Darrel Schneider > >
Review Request 46655: GEODE-1288: Correct entry expiration detection logic error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46655/ --- Review request for geode. Repository: geode Description --- GEODE-1288: Refactor test and extend wait times Diffs - geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java a34b9af070f5567d8aa90b7af63ea39378e04ca2 Diff: https://reviews.apache.org/r/46655/diff/ Testing --- Thanks, Scott Jewell
Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- (Updated April 19, 2016, 9:32 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- GEODE-656: Add protected attribute to test hook methods Repository: geode Description --- Split ReferenceCountHelper into ReferenceCountHelper and ReferenceCountHelperImpl Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing (updated) --- Thanks, Scott Jewell
Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- (Updated April 18, 2016, 7:02 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- GEODE-656: Refactor ReferenceCountHelperImplTest and remove any unused imports Repository: geode Description --- Split ReferenceCountHelper into ReferenceCountHelper and ReferenceCountHelperImpl Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing (updated) --- precheckin Thanks, Scott Jewell
Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- (Updated April 14, 2016, 11:08 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- GEODE-656: Remove saj hook from comment (Scott Alan Jewell) Repository: geode Description --- Split ReferenceCountHelper into ReferenceCountHelper and ReferenceCountHelperImpl Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing (updated) --- Thanks, Scott Jewell
Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- (Updated April 14, 2016, 9:24 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- GEODE-656: Added comments for new test hooks methods Repository: geode Description --- Split ReferenceCountHelper into ReferenceCountHelper and ReferenceCountHelperImpl Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing (updated) --- precheckin Thanks, Scott Jewell
Re: Review Request 46151: possible fix for intermittent failure of testTombstones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46151/#review128951 --- Ship it! Ship It! - Scott Jewell On April 13, 2016, 4:27 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46151/ > --- > > (Updated April 13, 2016, 4:27 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-561, GEODE-582, GEODE-665, GEODE-840, GEODE-861, and GEODE-926 > https://issues.apache.org/jira/browse/GEODE-561 > https://issues.apache.org/jira/browse/GEODE-582 > https://issues.apache.org/jira/browse/GEODE-665 > https://issues.apache.org/jira/browse/GEODE-840 > https://issues.apache.org/jira/browse/GEODE-861 > https://issues.apache.org/jira/browse/GEODE-926 > > > Repository: geode > > > Description > --- > > Test now disables the GC_MEMORY_THRESHOLD in both jvms before the test begins. > This will prevent the sweeper from expiring a smaller batch of tombstones > which could lead to the intermittent failures this test sees. > Also disabled a sleep the test was always doing at the end. > > > Diffs > - > > > geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java > 8f4740c0173e1ea34c814da8b1206de323ce9a9f > > Diff: https://reviews.apache.org/r/46151/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 46060: fix the off-heap leak in netWrite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46060/#review128709 --- Ship it! Ship It! - Scott Jewell On April 11, 2016, 11:05 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46060/ > --- > > (Updated April 11, 2016, 11:05 p.m.) > > > Review request for geode, Scott Jewell, Ken Howe, and Sai Boorlagadda. > > > Bugs: GEODE-1199 > https://issues.apache.org/jira/browse/GEODE-1199 > > > Repository: geode > > > Description > --- > > doNetWrite now calls release when it creates a new EntryEventImpl. > Added a unit test for doNetWrite. > > > Diffs > - > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java > 8224fc2826cb7650a812cef6e04f399000211593 > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46060/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- (Updated April 7, 2016, 11:28 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- GEODE-656: Update ReferenceCountHelperImpl javadoc to refer to static class Repository: geode Description --- Split ReferenceCountHelper into ReferenceCountHelper and ReferenceCountHelperImpl Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing --- Thanks, Scott Jewell
Re: Review Request 45760: GEODE-235 Modify EntryEventImpl toString to include region name and new unit test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45760/ --- (Updated April 5, 2016, 11:27 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Changes --- GEODE-235: Simplify mock of LocalRegion Repository: geode Description --- GEODE-235 Modify EntryEventImpl toString to include region name and new unit test Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java ba9ac1121d4cc41b4f45554e7862b069e5ba4284 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45760/diff/ Testing --- Thanks, Scott Jewell
Re: Review Request 45760: GEODE-235 Modify EntryEventImpl toString to include region name and new unit test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45760/ --- (Updated April 5, 2016, 10:23 p.m.) Review request for geode. Changes --- Remove mockery of SUT and improve name of test Repository: geode Description --- GEODE-235 Modify EntryEventImpl toString to include region name and new unit test Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java ba9ac1121d4cc41b4f45554e7862b069e5ba4284 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45760/diff/ Testing --- Thanks, Scott Jewell
Review Request 45760: GEODE-235 Modify EntryEventImpl toString to include region name and new unit test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45760/ --- Review request for geode. Repository: geode Description --- GEODE-235 Modify EntryEventImpl toString to include region name and new unit test Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java ba9ac1121d4cc41b4f45554e7862b069e5ba4284 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45760/diff/ Testing --- Thanks, Scott Jewell
Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- (Updated April 5, 2016, 5:38 p.m.) Review request for geode, Darrel Schneider and Ken Howe. Repository: geode Description (updated) --- Split ReferenceCountHelper into ReferenceCountHelper and ReferenceCountHelperImpl Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing --- Thanks, Scott Jewell
Review Request 45706: ReferenceCountHelper junit tests for GEODE-656
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45706/ --- Review request for geode. Repository: geode Description --- Delete ReferenceCountHelperJUnitTest2.java - not needed Merge branch 'develop' into feature/GEODE-656 Utilize junit system rules to handle system properties Make ReferenceCountHelper utilize a singleton and remove static block Correct typo in ReferenceCountHelper Modify ReferenceCountHelperJUnitTest to init ReferenceCountHelper instance before and after test New ReferenceCountHelperJUnitTest2 using different system properties Include Before/After to reinit singleton for each test Merge branch 'develop' into feature/GEODE-656 New static ReferenceCountHelper unit test Merge branch 'develop' into feature/GEODE-656 Conflicts: geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java Change reference to SimpleMemoryAllocatorImpl to MemoryAllocatorImpl Add copyright info to ReferenceCountHelper tests Merge branch 'develop' into feature/GEODE-656 Resolve test failures Add powermockignore anno to ReferenceCountHelperJUnitTest Add ExternalResource to ReferenceCountHelperJUnitTest to control log redirection during test Add powermockignore for javax.management classes Add ExternalResource to ReferenceCountHelperImplTest to control logging during test Modify test to verify system.out not being captured when run under jenkins Utilize PowerMockito to verify MemoryAllocatorImpl.debugLog static method Merge branch 'develop' into feature/GEODE-656 Cleanup unused imports in ReferenceCountHelp Merge branch 'develop' into feature/GEODE-656 Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java f6696b035438f4ba2d4157584f0551e2b4ccf02a geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45706/diff/ Testing --- Thanks, Scott Jewell
Re: Review Request 42531: testCreateOffHeapStorage now uses mocks instead of creating a real Cache
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42531/#review115459 --- Ship it! Ship It! - Scott Jewell On Jan. 20, 2016, 6:38 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42531/ > --- > > (Updated Jan. 20, 2016, 6:38 p.m.) > > > Review request for geode, Scott Jewell, Ken Howe, Sai Boorlagadda, and > Swapnil Bawaskar. > > > Bugs: GEODE-798 > https://issues.apache.org/jira/browse/GEODE-798 > > > Repository: geode > > > Description > --- > > testCreateOffHeapStorage now uses mocks. > Also a LocalStatisticsFactory can now be created without starting a sampler. > This allows it to be used a light weight StatisticsFactory compared to > InternalDistributedSystem. > The nice thing compared to a mocked StatisticsFactory is it will still create > functional Statistics instances. > > > Diffs > - > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsFactory.java > 6bd83c02d72854ad70ac81eff17ff22d94e54ad3 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > be27b5e8c5269011ea39a39059666a28ce9f2b6a > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java > 24fb82bc333469347055e1259e743aa6ec1723fc > > Diff: https://reviews.apache.org/r/42531/diff/ > > > Testing > --- > > OffHeapStorageJUnitTest and LocalStaticsFactory unit tests. > > > Thanks, > > Darrel Schneider > >
Re: Review Request 42008: GEODE-701: fix double free in unit test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42008/#review113157 --- Ship it! Ship It! - Scott Jewell On Jan. 7, 2016, 1:03 a.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42008/ > --- > > (Updated Jan. 7, 2016, 1:03 a.m.) > > > Review request for geode, Scott Jewell and Swapnil Bawaskar. > > > Bugs: GEODE-701 > https://issues.apache.org/jira/browse/GEODE-701 > > > Repository: geode > > > Description > --- > > The failure was caused by LifecycleListenerJUnitTest setting > a system property and then not unsetting it when it completed. > testClose now asserts that the system property must be initially > false when it runs. > LifecycleListenerJUnitTest now unsets the property in a finally > block after setting it. > > > Diffs > - > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java > c886e4372559055f1724f9f66cd97d7af73fd41b > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java > 6bc488dc797d0560d7f6a0b7278609abfd78fa7a > > Diff: https://reviews.apache.org/r/42008/diff/ > > > Testing > --- > > Ran LifecycleListenerJUnitTest and SimpleMemoryAllocatorJUnitTest. > > > Thanks, > > Darrel Schneider > >
Re: Review Request 41005: GEODE-626: add unit test coverage for MemoryChunk methods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41005/#review109088 --- Ship it! Ship It! - Scott Jewell On Dec. 5, 2015, 12:45 a.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41005/ > --- > > (Updated Dec. 5, 2015, 12:45 a.m.) > > > Review request for geode, Eric Shu and Scott Jewell. > > > Bugs: GEODE-626 > https://issues.apache.org/jira/browse/GEODE-626 > > > Repository: geode > > > Description > --- > > Added testGetSize and testCopyBytes > > > Diffs > - > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryChunkJUnitTestBase.java > 2e4eabb8d03994093b2a3535bd2aee4ac92ce12f > > Diff: https://reviews.apache.org/r/41005/diff/ > > > Testing > --- > > Ran the new unit tests > > > Thanks, > > Darrel Schneider > >
Re: Review Request 40932: GEODE-622: improve OffHeapStorage unit test coverage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40932/#review109020 --- Ship it! Ship It! - Scott Jewell On Dec. 3, 2015, 10:57 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40932/ > --- > > (Updated Dec. 3, 2015, 10:57 p.m.) > > > Review request for geode, Eric Shu and Scott Jewell. > > > Repository: geode > > > Description > --- > > Improved OffHeapStorage unit test coverage. > > Removed unused OFF_HEAP_TOTAL_SIZE system property. > > > Diffs > - > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > ef584f175579fe3eeb75a1cf25d1dafff911ab4b > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java > 8b61ab0a684d874ecfdf10a6cf9230147065a777 > > Diff: https://reviews.apache.org/r/40932/diff/ > > > Testing > --- > > precheckin > > > Thanks, > > Darrel Schneider > >
