Re: gfsh start server with the --password option

[Swapnil Bawaskar]

Thanks for find these Karen, Can you please file a JIRA for this issue?

On Tue, Nov 15, 2016 at 5:29 PM, Karen Miller <kmil...@pivotal.io> wrote:

> Also, when doing a gfsh connect (not just start server) that specifies user
> and password
> on the command line, if a further command of
>   gfsh history --file=historyfilename
> is executed, the user and password are written in clear text to the history
> file.
>
>
> On Tue, Nov 15, 2016 at 12:31 PM, Jinmei Liao <jil...@pivotal.io> wrote:
>
> > I thought we had code that deals with redacting password in gfsh history,
> > not sure why it's not in effect anymore.
> >
> > On Tue, Nov 15, 2016 at 2:27 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
> > wrote:
> >
> > > When you want to connect to a secure system you can choose not to use
> the
> > > --password option at which point you will be prompted to enter a
> > > username/password.
> > > e.g:
> > > gfsh>connect --locator=localhost[10334]
> > > Connecting to Locator at [host=localhost, port=10334] ..
> > > Connecting to Manager at [host=192.168.1.181, port=1099] ..
> > > username: super-user
> > > password: 
> > >
> > >
> > > On Tue, Nov 15, 2016 at 11:55 AM, Kirk Lund <kl...@apache.org> wrote:
> > >
> > > > There should be redaction in gfsh history. Maybe repeating the
> command
> > > is a
> > > > case that wasn't fully covered? This is a bug we'll need to file and
> > fix.
> > > >
> > > > Clear text in process string is probably not a bug. Users should
> > > implement
> > > > a callback to provide the password instead of providing it as a
> system
> > > > property unless they're ok with it showing in the process string.
> This
> > > may
> > > > need more documentation?
> > > >
> > > > The logs should not contain the clear text password and this would
> be a
> > > bug
> > > > if it does.
> > > >
> > > > -Kirk
> > > >
> > > >
> > > > On Tue, Nov 15, 2016 at 11:08 AM, Karen Miller <kmil...@apache.org>
> > > wrote:
> > > >
> > > > > When specifying user name and password to use as authentication
> > > > credentials
> > > > > with the gfsh start server command, the password is specified in
> the
> > > > clear.
> > > > > I've added a note in the documentation to point this out, but
> > > specifying
> > > > a
> > > > > password
> > > > > in this way leads to further ways the clear text password can be
> > seen.
> > > > >
> > > > > - gfsh history will repeat back the command with the password shown
> > > > > - any user on the box can see the clear text password with 'ps'
> > > > > - (haven't checked if this happens) logs may have the clear text
> > > password
> > > > >
> > > > > Is this an issue?  The history is for a particular user, so not so
> > bad.
> > > > > Logs can use file system permissions to reduce access.  But anyone
> > with
> > > > > access to the box can list the processes.
> > > > >
> > > > > Karen
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Cheers
> >
> > Jinmei
> >
>

Re: gfsh start server with the --password option

[Swapnil Bawaskar]

When you want to connect to a secure system you can choose not to use the
--password option at which point you will be prompted to enter a
username/password.
e.g:
gfsh>connect --locator=localhost[10334]
Connecting to Locator at [host=localhost, port=10334] ..
Connecting to Manager at [host=192.168.1.181, port=1099] ..
username: super-user
password: 


On Tue, Nov 15, 2016 at 11:55 AM, Kirk Lund  wrote:

> There should be redaction in gfsh history. Maybe repeating the command is a
> case that wasn't fully covered? This is a bug we'll need to file and fix.
>
> Clear text in process string is probably not a bug. Users should implement
> a callback to provide the password instead of providing it as a system
> property unless they're ok with it showing in the process string. This may
> need more documentation?
>
> The logs should not contain the clear text password and this would be a bug
> if it does.
>
> -Kirk
>
>
> On Tue, Nov 15, 2016 at 11:08 AM, Karen Miller  wrote:
>
> > When specifying user name and password to use as authentication
> credentials
> > with the gfsh start server command, the password is specified in the
> clear.
> > I've added a note in the documentation to point this out, but specifying
> a
> > password
> > in this way leads to further ways the clear text password can be seen.
> >
> > - gfsh history will repeat back the command with the password shown
> > - any user on the box can see the clear text password with 'ps'
> > - (haven't checked if this happens) logs may have the clear text password
> >
> > Is this an issue?  The history is for a particular user, so not so bad.
> > Logs can use file system permissions to reduce access.  But anyone with
> > access to the box can list the processes.
> >
> > Karen
> >
>

Re: Where should geode example code live

[Swapnil Bawaskar]

+1

On Thu, Nov 10, 2016 at 11:12 AM, Kirk Lund  wrote:

> Yep! Replace "gemfire" with "geode"
>
> On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling  wrote:
>
> > +1
> >
> > Shouldn't that be org.apache.geode.security.examples?
> >
> > On Thu, Nov 10, 2016 at 11:03 AM, Jinmei Liao  wrote:
> >
> > > +1 for both renaming it now and moving it to a separate module going
> > > forward.
> > >
> > > On Thu, Nov 10, 2016 at 10:58 AM, Kirk Lund  wrote:
> > >
> > > > We have some example code that's not in geode-examples.
> > > > geode-core-1.0.0-incubating.jar currently contains this package with
> > > > examples:
> > > >
> > > > org.geode.gemfire.security.templates
> > > >
> > > > Given that template means something a bit different from example, I'd
> > > like
> > > > to rename this package to examples. Is this acceptable?
> > > >
> > > > Going forward, this community needs to spend some considerable effort
> > in
> > > > improving modularity of geode. The geode-core module should contain
> > only
> > > > the bare essentials that are always necessary when using geode.
> > Optional
> > > > features and the like should move to their own modules. Along the
> same
> > > line
> > > > of thought, examples should move to geode-examples or some similar
> > > > sub-module (or even a separate repo). That sub-module should
> generate a
> > > jar
> > > > that can be added to the classpath for purposes of demoing or trying
> > out
> > > > geode (kicking the tires). I'd like the community to come up with
> > > > additional ideas on how to facilitate demoing and also make it easier
> > in
> > > > general to try out geode for the first time.
> > > >
> > > > -Kirk
> > > >
> > >
> > >
> > >
> > > --
> > > Cheers
> > >
> > > Jinmei
> > >
> >
>

Re: Backwards compatibility for 1.1

[Swapnil Bawaskar]

+1 for maintaining backwards compatibility.

On Wed, Nov 2, 2016 at 9:40 AM, Mark Bretl  wrote:

> +1 for backward compatibility with Geode releases.
>
> --Mark
>
> On Wed, Nov 2, 2016 at 8:11 AM, Kenneth Howe  wrote:
>
> > +1 to Dan
> > +1 to Bruce - the distributedTest extensions for backward compatibility
> > would great
> >
> > > On Nov 1, 2016, at 4:11 PM, Bruce Schuchardt 
> > wrote:
> > >
> > > +1
> > >
> > > I still have the backward-compatibility distributedTest extensions that
> > I could contribute.  The extension lets you spawn a VM running an older
> > version and interact with it.  You can even run a unit test in the
> spawned
> > VM.
> > >
> > > I have one test that sets up a server using the current version and
> then
> > spawns a client unit test running under an older version.  The client
> finds
> > the server through the distributedTest locator and runs its tests against
> > the server.
> > >
> > >
> > > Le 11/1/2016 à 4:04 PM, Jianxia Chen a écrit :
> > >> +1
> > >>
> > >> On Tue, Nov 1, 2016 at 4:00 PM, Dan Smith  wrote:
> > >>
> > >>> Hi,
> > >>>
> > >>> We made a lot of changes in 1.0 that broke compatibility with old
> > versions
> > >>> of gemfire for various reasons (package renaming, changing membership
> > >>> system). I just wanted to confirm that starting with 1.1, we're
> > planning on
> > >>> maintaining client/server, peer-to-peer, WAN and disk backwards
> > >>> compatibility with older versions geode as outlined in this wiki
> page:
> > >>>
> > >>> https://cwiki.apache.org/confluence/display/GEODE/Managing+Backward+
> > >>> Compatibility
> > >>> https://cwiki.apache.org/confluence/display/GEODE/
> > >>> Criteria+for+Code+Submissions
> > >>>
> > >>> Now that we have 1.0 out the door, we need to be more careful about
> > >>> introducing changes that might break compatibility if we're going to
> > stick
> > >>> to these guidelines. We also probably should introduce some tests
> that
> > >>> check compatibility with 1.0.
> > >>>
> > >>>
> > >>> -Dan
> > >>>
> > >
> >
> >
>

Re: [CONF] Geode > Release Steps

[Swapnil Bawaskar]

Ok, I am going to replace steps 14 and 15 with:
Work with the community to update the docker image, homebrew, macports, YCSB,
Zeppelin, spring-data-geode.

On Thu, Oct 27, 2016 at 12:00 PM, Anthony Baker <aba...@pivotal.io> wrote:

> Since homebrew and macports are external to ASF I don’t think we should
> call them out in the release steps.  I do think it makes sense to inform
> contributors in other communities (like homebrew, YCSB, Zeppelin, Spring,
> etc) and help them upgrade to new releases.
>
> Anthony
>
>
> > On Oct 27, 2016, at 11:43 AM, Swapnil Bawaskar (Confluence) <
> conflue...@apache.org> wrote:
> >
> >  <https://cwiki.apache.org/
> confluence/display/~swapnil.bawaskar?src=mail
> timestamp=1477593839173=com.
> atlassian.confluence.plugins.confluence-content-
> notifications-plugin%3Apage-edited-notification=
> 8aa980874e36a1eb014e36a2a5663b27> Swapnil Bawaskar edited a page
> >
> >  <https://cwiki.apache.org/confluence/display/GEODE/
> Release+Steps?src=mail=1477593839173&
> src.mail.notification=com.atlassian.confluence.plugins.confluence-content-
> notifications-plugin%3Apage-edited-notification=
> 8aa980874e36a1eb014e36a2a5663b27=view>Release
> Steps <https://cwiki.apache.org/confluence/display/GEODE/
> Release+Steps?src=mail=1477593839173&
> src.mail.notification=com.atlassian.confluence.plugins.confluence-content-
> notifications-plugin%3Apage-edited-notification=
> 8aa980874e36a1eb014e36a2a5663b27=view>
> > ...
> > Send a [DISCUSS] to dev@geode.incubator.apache.org  dev@geode.incubator.apache.org>.
> > Create a release candidate (see below).
> > Send a [VOTE] to dev@geode.incubator.apache.org  dev@geode.incubator.apache.org>.  See the template at Release vote
> template .
> Example <http://mail-archives.apache.org/mod_mbox/incubator-geode-
> dev/201601.mbox/%3cBY2PR10MB0615E804A4F4C0C9D4606339B6D90@BY2PR10MB0615.
> namprd10.prod.outlook.com%3e>.
> > Wait for the vote to complete and send a [RESULT][VOTE] to
> dev@geode.incubator.apache.org <mailto:dev@geode.incubator.apache.org>.
> Example <http://mail-archives.apache.org/mod_mbox/incubator-geode-
> dev/201602.mbox/%3cbac1def2-50fa-4037-b22d-3b7bfdca4...@pivotal.io%3e>:
> > If the vote fails, fix the issues and goto 2.
> > Send a [VOTE] to gene...@incubator.apache.org.  gene...@incubator.apache.org.>Example <http://mail-archives.apache.
> org/mod_mbox/incubator-general/201602.mbox/%3c7AC725D7-ECEC-45FF-95AE-
> bd77d1b18...@pivotal.io%3e>.
> > Wait for the vote to complete (need 3 binding +1 votes) and send a
> [RESULT][VOTE] to gene...@incubator.apache.org. <mailto:general@incubator.
> apache.org.>Example <http://mail-archives.apache.org/mod_mbox/incubator-
> general/201601.mbox/%3cCA+5xAo3fvEDU8BhjqXg9OwxDVT7c0c0R
> cyj_vgpuicqoufg...@mail.gmail.com%3e>.
> > If the vote fails, fix the issues and goto 2.
> > Finalize the release (see below).
> > Mark the JIRA version as released.
> > Wait for the release to propagate to the mirrors (may take 1-2 days).
> > Update the website source (geode-site/website/content/releases/index.html)
> with the download links.
> > Publish javadocs to the incubator website.
> > Build website from sources as described in geode-site/website/README.md.
> > In the generated site, create the directory geode-site/content/releases/
> latest.
> > Obtain a copy of the javadoc directory from the binary build and put it
> in the geode-site/content/releases/latest directory (link from the
> website's Docs landing page points to ../releases/latest/javadoc).
> > Deploy the generated site by checking it into the asf-site branch of the
> apache-geode repo.
> > Build the docker image and upload.  TBD
> > Update Homebrew and macports. TBD
> > Send an [ANNOUNCE] to gene...@incubator.apache.org  gene...@incubator.apache.org>, annou...@apache.org  annou...@apache.org>, dev@geode.incubator.apache.org  dev@geode.incubator.apache.org>, and u...@geode.incubator.apache.org.
> <mailto:u...@geode.incubator.apache.org.>  Example <
> http://mail-archives.apache.org/mod_mbox/incubator-general/201601.mbox/%
> 3c9f324b22-c208-45e6-ad2c-cfd899a93...@hortonworks.com%3e>.
> > ...
> >  resources:view-page-email-adg-footer-item:icon.png> <
> https://cwiki.apache.org/confluence/display/GEODE/
> Release+Steps?src=mail=1477593839173&
> src.mail.notification=com.atlassian.confluence.plugins.confluence-content-
> notifications-plugin%3Apage-edited-notification=
> 8aa980874e36a1eb014e36a2a5663b27=view> View page <
> https://cwiki.apache.org/confluence/display/GEODE/
> Release+Steps?src=mail=1477593839173

Re: [DISCUSS] Graduation

[Swapnil Bawaskar]

+1

On Tuesday, October 25, 2016, Udo Kohlmeyer  wrote:

> +1
>
>
> On 25/10/16 5:43 pm, Joey McAllister wrote:
>
>> +1
>>
>> On Tue, Oct 25, 2016 at 5:42 PM Anthony Baker  wrote:
>>
>> +1
>>>
>>> On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik  wrote:

 Unless somebody objects strongly to my #2 and #3 proposals I'm going
 to kick of this thread on private@.

>>>
>>>
>

[ANNOUNCE] Apache Geode 1.0.0-incubating released

[Swapnil Bawaskar]

The Apache Geode team is proud to announce Apache Geode release
1.0.0-incubating.

Apache Geode (incubating) is a data management platform that provides a
database-like consistency model, reliable transaction processing and a
shared-nothing architecture to maintain very low latency performance with
high concurrency processing.

Download the new release here:
http://geode.incubator.apache.org/releases/

Changes since the last release include renaming packages from
com.gemstone.gemfire to org.apache.geode, bundling docs with the source
distribution, securing the REST API, and 225 other bug fixes and minor
improvements.
See the release notes for more details:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12332343

To get started with Apache Geode check out the Geode in 5 minutes tutorial:
https://cwiki.apache.org/confluence/display/GEODE/Index#Index-
Geodein5minutesGeodein5minutes

To learn more and get involved, please visit our website in join our mailing
lists:
http://geode.incubator.apache.org/

Regards,
The Apache Geode (incubating) team

=
*Disclaimer*

Apache Geode is an effort undergoing incubation at The Apache Software
Foundation (ASF), sponsored by the name of Apache Incubator PMC. Incubation
is required of all newly accepted projects until a further review indicates
that the infrastructure, communications, and decision making process have
stabilized in a manner consistent with other successful ASF projects. While
incubation status is not necessarily a reflection of the completeness or
stability of the code, it does indicate that the project has yet to be
fully endorsed by the ASF.

Re: 2.0 release in JIRA

[Swapnil Bawaskar]

+1

On Tuesday, October 25, 2016, Anthony Baker  wrote:

> +1
>
> > On Oct 25, 2016, at 9:44 AM, Dan Smith >
> wrote:
> >
> > It looks like we already have both a 1.1 and a 2.0 version in JIRA. Do we
> > need that 2.0 version yet? The only things I see assigned to it seem to
> be
> > assigned to it by mistake. Is it ok to delete that version until we're
> > actually working on 2.0?
> >
> > -Dan
>
>

Closing the release in JIRA

[Swapnil Bawaskar]

Hi,
After passing the vote on general@incubator, I closed all the issues in
JIRA that were in RESOLVED state. However, I do not seem to have permission
to close the release label in JIRA
.
Can someone with permission either mark the release as closed OR give me
permission to close the relase?

Thanks!

Re: [GitHub] incubator-geode pull request #266: Add user guide doc to website

[Swapnil Bawaskar]

Hi Joey,
Travis is not configured to work on the asf-site branch, so you can ignore
the failure.

Thanks!
Swapnil.

On Thu, Oct 20, 2016 at 1:44 PM, Joey McAllister 
wrote:

> Hi,
>
> The pull request below is to push the contributed docs content to the
> website. I followed the website instructions, tarballed the web content,
> and moved it to the asf-site branch. Now, the PR is showing a Travis CI
> build fail.
>
> Is that relevant to the asf-site branch? If so, can someone help me parse
> what's failing, so I can fix it?
>
> Thanks!
> Joey
>
> On Thu, Oct 20, 2016 at 1:14 PM joeymcallister  wrote:
>
> > GitHub user joeymcallister opened a pull request:
> >
> > https://github.com/apache/incubator-geode/pull/266
> >
> > Add user guide doc to website
> >
> > Added the user guide built using `geode-docs` and `geode-book` to
> > `geode-site/content/`. Built and reviewed the site locally. Related
> > docs/website changes are in feature/GEODE-2015.
> >
> > You can merge this pull request into a Git repository by running:
> >
> > $ git pull https://github.com/joeymcallister/incubator-geode
> asf-site
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> > https://github.com/apache/incubator-geode/pull/266.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> > This closes #266
> >
> > 
> > commit f717e5138bfc2ee9bedf942c986ad498102e6f8d
> > Author: Joey McAllister 
> > Date:   2016-10-20T20:09:09Z
> >
> > Add user guide doc to website
> >
> > 
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>

[RESULT] [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Swapnil Bawaskar]

gt;
> > > >> > >  Checked SHA, signatures, build/run, sample app and command line
> > > >> testing
> > > >> > > through gfsh.
> > > >> > >
> > > >> > > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund <kl...@pivotal.io>
> > > wrote:
> > > >> > >
> > > >> > > > +1 I think we should target GEODE-2004 and GEODE-1883 for a
> > point
> > > >> > release
> > > >> > > > after 1.0.0
> > > >> > > >
> > > >> > > >
> > > >> > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao <
> jil...@pivotal.io
> > >
> > > >> > wrote:
> > > >> > > >
> > > >> > > > > +0
> > > >> > > > >
> > > >> > > > > This candidate does not include the fix for GEODE-2004 and
> > > >> > GEODE-1883.
> > > >> > > > It's
> > > >> > > > > not a must fix though.
> > > >> > > > >
> > > >> > > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker <
> > > aba...@pivotal.io
> > > >> >
> > > >> > > > wrote:
> > > >> > > > >
> > > >> > > > > > +1
> > > >> > > > > >
> > > >> > > > > > * Verified sha’s
> > > >> > > > > > * Verified signatures
> > > >> > > > > > * Verified tag signature
> > > >> > > > > > * Build and run from src distro
> > > >> > > > > > * Checked src distro for binaries
> > > >> > > > > > * Run some examples from mvn repo
> > > >> > > > > > * Reviewed LICENSE and NOTICE
> > > >> > > > > >
> > > >> > > > > > Anthony
> > > >> > > > > >
> > > >> > > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <
> > > >> > > sbawas...@pivotal.io>
> > > >> > > > > > wrote:
> > > >> > > > > > >
> > > >> > > > > > > All,
> > > >> > > > > > >
> > > >> > > > > > > This is the second release candidate for Apache Geode,
> > > version
> > > >> > > > > > > 1.0.0-incubating. I discarded the first release
> candidate
> > > >> since
> > > >> > my
> > > >> > > > pgp
> > > >> > > > > > > key was missing from the KEYS file.
> > > >> > > > > > > Thanks to all the community members to drive towards
> this
> > > >> > > milestone!
> > > >> > > > > > >
> > > >> > > > > > > It fixes the following issues:
> > > >> > > > > > >
> > > >> > > > > > >https://issues.apache.org/
> jira/secure/ReleaseNote.jspa
> > ?
> > > >> > > > > > projectId=12318420=12332343
> > > >> > > > > > >
> > > >> > > > > > > *** Please download, test and vote by Wednesday, October
> > 19,
> > > >> 0800
> > > >> > > hrs
> > > >> > > > > > > US Pacific.
> > > >> > > > > > >
> > > >> > > > > > > Note that we are voting upon the source (tag):
> > > >> > > > > > >   rel/1.0.0-incubating.RC2
> > > >> > > > > > > <https://git-wip-us.apache.org/repos/asf?p=incubator-
> > > >> > > > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2>
> > > >> > > > > > >
> > > >> > > > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753
> > > >> > > > > > > <https://git-wip-us.apache.org/repos/asf?p=incubator-
> > > >> > > > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1
> > > c975870753>
> > > >> > > > > > >
> > > >> > > > > > > Source and binary files:
> > > >> > > > > > >   https://dist.apache.org/repos/
> > > dist/dev/incubator/geode/1.0.
> > > >> > > > > > 0-incubating.RC2/
> > > >> > > > > > >
> > > >> > > > > > > The documentation on how to install and use Apache Geode
> > are
> > > >> > hosted
> > > >> > > > > > > on pivotal.io:
> > > >> > > > > > >   http://geode.docs.pivotal.io
> > > >> > > > > > >
> > > >> > > > > > > Maven staging repo:
> > > >> > > > > > >   https://repository.apache.org/content/repositories/
> > > >> > > > > > orgapachegeode-1014/
> > > >> > > > > > >
> > > >> > > > > > > Geode's KEYS file containing PGP keys we use to sign the
> > > >> release:
> > > >> > > > > > >   https://github.com/apache/
> incubator-geode/blob/release/
> > > >> > > > > > 1.0.0-incubating/KEYS
> > > >> > > > > > >
> > > >> > > > > > > Release Signed with Key: pub   4096R/18F902DB 2016-04-07
> > > >> > > > > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC
> 18F9
> > > >> 02DB
> > > >> > > > > > >
> > > >> > > > > > > Thanks,
> > > >> > > > > > >
> > > >> > > > > > > Swapnil.
> > > >> > > > > >
> > > >> > > > > >
> > > >> > > > >
> > > >> > > > >
> > > >> > > > > --
> > > >> > > > > Cheers
> > > >> > > > >
> > > >> > > > > Jinmei
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > > --
> > > >> > >
> > > >> > > ~/William
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

[Swapnil Bawaskar]

+1, It would be great to have this by the time we put the vote out on
general@incubator

On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister <jmcallis...@pivotal.io>
wrote:

> Only a very enthusiastic +1. :)
>
> On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker <aba...@pivotal.io> wrote:
>
> > Since the geode docs have now been merged to the develop branch, let’s
> > start hosting them on http://geode.apache.org.  Thoughts?
> >
> > Anthony
> >
> >
> > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
> > wrote:
> >
> >
> > The documentation on how to install and use Apache Geode are hosted
> > on pivotal.io:
> >   http://geode.docs.pivotal.io
> >
> >
> >
>

[VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

[Swapnil Bawaskar]

All,

This is the second release candidate for Apache Geode, version
1.0.0-incubating. I discarded the first release candidate since my pgp
key was missing from the KEYS file.
Thanks to all the community members to drive towards this milestone!

It fixes the following issues:


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12332343

*** Please download, test and vote by Wednesday, October 19, 0800 hrs
US Pacific.

Note that we are voting upon the source (tag):
   rel/1.0.0-incubating.RC2


Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753


Source and binary files:
   https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.RC2/

The documentation on how to install and use Apache Geode are hosted
on pivotal.io:
   http://geode.docs.pivotal.io

Maven staging repo:
   https://repository.apache.org/content/repositories/orgapachegeode-1014/

Geode's KEYS file containing PGP keys we use to sign the release:
   https://github.com/apache/incubator-geode/blob/release/1.0.0-incubating/KEYS

Release Signed with Key: pub   4096R/18F902DB 2016-04-07
Fingerprint: E1B1 ABE3 4753 E7BA 8097  4285 8F8F 2BCC 18F9 02DB

Thanks,

Swapnil.

Re: GEODE-1466: geode.properties

[Swapnil Bawaskar]

How about introducing a new GEMFIRE_FILE_PREFIX attribute that will default
to "geode" while leaving GEMFIRE_PREFIX default to "gemfire"? Is this
something that will work?

On Thu, Oct 13, 2016 at 1:48 PM, Anthony Baker  wrote:

> Hmmm, you would think it would be easier to change a file name :-)
>
> I don’t think we should be pushing destabilizing changes into a release
> branch.  If the changes aren’t ready now we always pick them up for the
> next release.
>
> Anthony
>
> > On Oct 13, 2016, at 1:13 PM, Kirk Lund  wrote:
> >
> > I'm currently working with Jared and we have spent a few days working
> > on GEODE-1466. We've been trying to get geode to the point where it can
> > automatically search for, find and use either geode.properties or
> > gemfire.properties (preferring geode.properties if both are found).
> >
> > We were intending to break this up into three subtasks with the hope of
> > including #1 in Geode 1.0.0 incubating:
> >
> > 1) locating geode.properties and gemfire.properties if user has not
> > specified a specific properties file
> >
> > 2) support specifying geode configuration properties with system
> properties
> > geode. as well as gemfire.
> >
> > ex: -Dgemfire.off-heap-memory-size=40g or -Dgeode.off-heap-memory-size=
> 40g
> >
> > 3) modify all other system properties in geode to support alias of
> gemfire
> > as well as geode where the name of the system property currently contains
> > gemfire
> >
> > ex: -Dgemfire.Query.VERBOSE=true or -Dgeode.Query.VERBOSE=true
> >
> > The community is planning to create the Geode 1.0.0 incubating RC
> tomorrow.
> > The work we have completed so far involves modifying geode to search for
> > both geode.properties and gemfire.properties to use whichever one is
> found.
> > This turns out to be too complex to complete by tomorrow (send me a email
> > directly if you want more detailed info which mostly involves
> > DistributionConfig and ConfigSource).
> >
> > In order to complete this in time, we need to use a different strategy.
> > Instead of looking for geode.properties first and then
> gemfire.properties,
> > we are proposing the following change to DistributionConfig:
> >
> > Change the GEMFIRE_PREFIX = "gemfire." constant to be configurable by a
> > system property and change the default to be "geode." This places a
> greater
> > burden on the user who is migrating from GemFire to Geode but doesn't
> want
> > to rename gemfire.properties or gemfire system properties. By default,
> > Geode would search for geode.properties unless the user specifies a new
> > system property with a different prefix ("gemfire."):
> >
> > String GEMFIRE_PREFIX = PropertiesPrefix.getGemfireOrGeodePrefix();
> >
> > Example of overriding this to be "gemfire.":
> >
> > -DgeodePropertiesPrefix="gemfire."
> > or
> > -DgeodePropertiesPrefix="gemfire"
> >
> > (we'll add the "." for you if you leave it out)
> >
> > Pivotal or other vendors could also alter this prefix as they see fit.
> >
> > There are 453 lines of production code that refer to this GEMFIRE_PREFIX
> > constant. For example, every system property that contains "gemfire." is
> > currently referring to the constant, so they would also be altered to be
> > "geode." by default. The JMX notifications also refer to GEMFIRE_PREFIX
> > such as: GEMFIRE_PREFIX + "distributedsystem.cache.client.joined".
> >
> > Does anyone know if anything referring to GEMFIRE_PREFIX is persisted in
> > some way that would break if we make this change? For example, if we
> > persist any strings built with this constant to a diskstore, then
> recovery
> > from that diskstore would be broken if the prefix value is "geode."
> during
> > recovery of an old diskstore.
> >
> > Also, a user could conceivably override the GEMFIRE_PREFIX in some
> members
> > of a cluster but not others which could break things in unexpected ways.
> >
> > One more note: While reviewing uses of GEMFIRE_PREFIX we noticed that
> > AgentUtil supports "GEMFIRE" (hardcoded) and GEMFIRE_PREFIX+".home" env
> > vars while all of the online docs specify setting GEMFIRE_HOME as an env
> > var. I suspect this is already broken (I will file a ticket), but I think
> > we will also be at risk of breaking additional things that may or may not
> > be immediately detected by precheckin tests. It's also used by
> DtdResolver
> > for the name of a dtd: new File(GEMFIRE_PREFIX + "dtd). We'll continue
> > looking for unusual or risky uses of the constant.
> >
> > Bottom line is making this change is higher risk than not making the
> > change, and there could be some fallout bugs that require fixes and
> > additional release candidates for 1.0.0.
> >
> > Does the community feel this change is desirable for 1.0.0? Or is it
> better
> > to leave it as "gemfire." and move GEODE-1466 to post-1.0.0?
> >
> > Thanks,
> > Kirk
>
>

Re: Using Fix Version on JIRA

[Swapnil Bawaskar]

Hi William, please refer to this thread for how this should work for 1.0:
http://markmail.org/message/lmxtps7clvyphpg2

On Mon, Oct 10, 2016 at 10:02 PM, William Markito 
wrote:

> This may sound like a simple and not really important, but it's key to
> track issues and which release the fix is part of.
>
> It also helps in generating automated release notes through JIRA, such as
> this one [1] from M3.
>
> Since we already created a release branch for 1.0 but there is work still
> on-going in develop I'd like to encourage people to use the Fix Version
> field with even more attention so we don't lose track of where the work has
> been completed.
>
> Any thoughts or ideas on how we can approach this ?
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318420=12335358
>
> --
>
> ~/William
>

Re: Limiting scope for Geode 1.0

[Swapnil Bawaskar]

Some of tests labeled flaky in 8929e93bd129b303aae8f9e1b13daf3c3991d1a4
have since been fixed by Nabarun. I think we should reconcile this revision
with Nabarun's.

On Tue, Oct 4, 2016 at 12:16 PM, Anthony Baker <aba...@pivotal.io> wrote:

> I’d like merge 8929e93bd129b303aae8f9e1b13daf3c3991d1a4 to the release
> branch.  It contains only test changes.  Sound reasonable?
>
> Also in that vein, what do you think about not running flakyTest in the
> Jenkins release job [1].  That would give us a clearer picture of test
> results and quality on the release branch.
>
> We should continue to run flakyTest in the nightly Jenkins job.
>
> Anthony
>
> [1] https://builds.apache.org/job/Geode-release/
>
>
> > On Oct 1, 2016, at 12:30 AM, Swapnil Bawaskar <sbawas...@pivotal.io>
> wrote:
> >
> > Thanks for the offer Anthony,
> > I tagged GEODE-17 / GEODE-1570 to be fixed in 1.0 and I removed the 1.0
> tag
> > from GEODE-1793 so that open JIRA issues for 1.0 [1] should now be
> accurate.
> >
> > I have also cut a branch release/1.0.0-incubating from develop on commit
> > abef045179e5d805cb04bc55a77a82798becdaae for the 1.0 release. Please
> make
> > sure that only issues targeted for 1.0 are fixed on that branch. If you
> are
> > using git flow, use git flow release track 1.0.0-incubating for switching
> > to the new branch.
> >
> >
> > Thanks!
> >
> > [1] https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
> > 20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> > 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >
> > On Fri, Sep 30, 2016 at 11:30 AM, William Markito <wmark...@pivotal.io>
> > wrote:
> >
> >> +1
> >>
> >> On Fri, Sep 30, 2016 at 9:16 AM, Kenneth Howe <kh...@pivotal.io> wrote:
> >>
> >>> +1
> >>>
> >>>> On Sep 29, 2016, at 2:31 PM, Jacob Barrett <jbarr...@pivotal.io>
> >> wrote:
> >>>>
> >>>> +1 for creating branch now to prevent feature creep.
> >>>>
> >>>> On Thu, Sep 29, 2016 at 2:10 PM Kirk Lund <kl...@apache.org> wrote:
> >>>>
> >>>>> I think we should propose creating that release branch sooner (now?)
> >> so
> >>> we
> >>>>> can minimize unplanned changes slipping into 1.0 and destabilizing
> it.
> >>>>>
> >>>>> -Kirk
> >>>>>
> >>>>> On Thursday, September 29, 2016, Anthony Baker <aba...@pivotal.io>
> >>> wrote:
> >>>>>
> >>>>>> Using the gitflow approach, we cut a release/1.0.0 branch to isolate
> >>> the
> >>>>>> release branch from ongoing development.  For past releases we have
> >>>>> waited
> >>>>>> as long as possible to cut the branch to minimize overhead.  Perhaps
> >>> this
> >>>>>> time we should create the branch earlier.
> >>>>>>
> >>>>>> JIRA shows the open issues for 1.0.0 [1] but there are some deltas
> >>>>>> compared to the last release scope email [2].
> >>>>>>
> >>>>>> GEODE-17 / GEODE-1570 was mentioned as a possible candidate for
> 1.0.0
> >>> but
> >>>>>> the Fix Version is not set
> >>>>>> GEODE-1168 was not included in the 1.0.0 scope discussions but Fix
> >>>>> Version
> >>>>>> is set to 1.0.0
> >>>>>> GEODE-1914 is follow on work from the package namespace changes
> >>>>>>
> >>>>>> @Swapnil, does this accurately reflect the scope discussions for
> >> 1.0.0?
> >>>>>> If so, I can update the bugs.
> >>>>>>
> >>>>>> Anthony
> >>>>>>
> >>>>>> [1] https://issues.apache.org/jira/issues/?jql=project%20%
> >>>>>> 3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
> >>>>>> 20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> >>>>>> 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >>>>>>
> >>>>>> [2] http://mail-archives.apache.org/mod_mbox/incubator-geode-
> >>>>>> dev/201609.mbox/%3cCANZq1gBzMTEM_JHzw2YT_
> >>> LZeC5g472XkNCfJhma76xah=Yyq6A@
> >>>>>> mail.gmail.com%3e
> >>>>>>
> >>>>>>
> >>>>>>> On Sep 29, 2016, at 1:02 PM, Kirk Lund <kl...@apache.org
> >>>>> <javascript:;>>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>> What changes are we still waiting on to cut the next RC of Geode
> >> 1.0?
> >>>>>>>
> >>>>>>> Is there a way to create a branch for Geode 1.0 develop that allows
> >>>>> folks
> >>>>>>> to continue working on post-1.0 features or bug fixes without
> >>>>>> destabilizing
> >>>>>>> Geode 1.0? This way, only the necessary changes for Geode 1.0 would
> >> go
> >>>>> to
> >>>>>>> the 1.0 branch?
> >>>>>>>
> >>>>>>> -Kirk
> >>>>>>
> >>>>>>
> >>>>>
> >>>
> >>>
> >>
> >>
> >> --
> >>
> >> ~/William
> >>
>
>

Re: Limiting scope for Geode 1.0

[Swapnil Bawaskar]

This sounds like feature creep, but based on this thread:
http://markmail.org/message/fwfslt2s7yl7mqm4 do we want to target GEODE-1952
<https://issues.apache.org/jira/browse/GEODE-1952> for 1.0?

On Sat, Oct 1, 2016 at 12:30 AM, Swapnil Bawaskar <sbawas...@pivotal.io>
wrote:

> Thanks for the offer Anthony,
> I tagged GEODE-17 / GEODE-1570 to be fixed in 1.0 and I removed the 1.0
> tag from GEODE-1793 so that open JIRA issues for 1.0 [1] should now be
> accurate.
>
> I have also cut a branch release/1.0.0-incubating from develop on commit
> abef045179e5d805cb04bc55a77a82798becdaae for the 1.0 release. Please make
> sure that only issues targeted for 1.0 are fixed on that branch. If you are
> using git flow, use git flow release track 1.0.0-incubating for switching
> to the new branch.
>
>
> Thanks!
>
> [1] https://issues.apache.org/jira/issues/?jql=project%20%3D
> %20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%20AND%
> 20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%
> 20priority%20DESC%2C%20created%20ASC
>
> On Fri, Sep 30, 2016 at 11:30 AM, William Markito <wmark...@pivotal.io>
> wrote:
>
>> +1
>>
>> On Fri, Sep 30, 2016 at 9:16 AM, Kenneth Howe <kh...@pivotal.io> wrote:
>>
>> > +1
>> >
>> > > On Sep 29, 2016, at 2:31 PM, Jacob Barrett <jbarr...@pivotal.io>
>> wrote:
>> > >
>> > > +1 for creating branch now to prevent feature creep.
>> > >
>> > > On Thu, Sep 29, 2016 at 2:10 PM Kirk Lund <kl...@apache.org> wrote:
>> > >
>> > >> I think we should propose creating that release branch sooner (now?)
>> so
>> > we
>> > >> can minimize unplanned changes slipping into 1.0 and destabilizing
>> it.
>> > >>
>> > >> -Kirk
>> > >>
>> > >> On Thursday, September 29, 2016, Anthony Baker <aba...@pivotal.io>
>> > wrote:
>> > >>
>> > >>> Using the gitflow approach, we cut a release/1.0.0 branch to isolate
>> > the
>> > >>> release branch from ongoing development.  For past releases we have
>> > >> waited
>> > >>> as long as possible to cut the branch to minimize overhead.  Perhaps
>> > this
>> > >>> time we should create the branch earlier.
>> > >>>
>> > >>> JIRA shows the open issues for 1.0.0 [1] but there are some deltas
>> > >>> compared to the last release scope email [2].
>> > >>>
>> > >>> GEODE-17 / GEODE-1570 was mentioned as a possible candidate for
>> 1.0.0
>> > but
>> > >>> the Fix Version is not set
>> > >>> GEODE-1168 was not included in the 1.0.0 scope discussions but Fix
>> > >> Version
>> > >>> is set to 1.0.0
>> > >>> GEODE-1914 is follow on work from the package namespace changes
>> > >>>
>> > >>> @Swapnil, does this accurately reflect the scope discussions for
>> 1.0.0?
>> > >>> If so, I can update the bugs.
>> > >>>
>> > >>> Anthony
>> > >>>
>> > >>> [1] https://issues.apache.org/jira/issues/?jql=project%20%
>> > >>> 3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
>> > >>> 20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
>> > >>> 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>> > >>>
>> > >>> [2] http://mail-archives.apache.org/mod_mbox/incubator-geode-
>> > >>> dev/201609.mbox/%3cCANZq1gBzMTEM_JHzw2YT_
>> > LZeC5g472XkNCfJhma76xah=Yyq6A@
>> > >>> mail.gmail.com%3e
>> > >>>
>> > >>>
>> > >>>> On Sep 29, 2016, at 1:02 PM, Kirk Lund <kl...@apache.org
>> > >> <javascript:;>>
>> > >>> wrote:
>> > >>>>
>> > >>>> What changes are we still waiting on to cut the next RC of Geode
>> 1.0?
>> > >>>>
>> > >>>> Is there a way to create a branch for Geode 1.0 develop that allows
>> > >> folks
>> > >>>> to continue working on post-1.0 features or bug fixes without
>> > >>> destabilizing
>> > >>>> Geode 1.0? This way, only the necessary changes for Geode 1.0
>> would go
>> > >> to
>> > >>>> the 1.0 branch?
>> > >>>>
>> > >>>> -Kirk
>> > >>>
>> > >>>
>> > >>
>> >
>> >
>>
>>
>> --
>>
>> ~/William
>>
>
>

Re: CI bugs

[Swapnil Bawaskar]

+1

On Tue, Oct 4, 2016 at 10:58 AM, John Blum  wrote:

> +1
>
> On Tue, Oct 4, 2016 at 10:11 AM, Kirk Lund  wrote:
>
> > Please don't close flaky tickets or remove FlakyTest category unless you
> > know of a specific commit revision that makes some timing changes to the
> > test. Unless you replace all the Thread.sleeps with await() calls it's
> > going to fail again when GC occurs during the test. Just because a test
> > doesn't fail in 30+ runs, doesn't mean it's not flaky.
> >
> > ParallelGatewaySenderOperationsDUnitTest has a bunch of these calls:
> >
> >   Wait.pause(2000);
> >
> > That's pretty much our definition of flaky.
> >
> > ParallelWANStatsDUnitTest is worse because it has even shorter sleeps:
> >
> >   pause(200);
> >
> > I'm replacing the sleeps in the ManagementTestBase tests with Awaitility
> > calls and the tests are dropping from 5 minutes to 30 seconds per dunit
> > class. So that's another huge motivator to get rid of these broken
> sleeps.
> >
> > -Kirk
> >
> >
> > On Sun, Oct 2, 2016 at 7:33 PM, Xiaojian Zhou  wrote:
> >
> > > GEODE-933 and GEODE-977 are not reproducible either after run 30+
> times.
> > So
> > > they are not flaky and can be closed for now.
> > >
> > > On Sat, Oct 1, 2016 at 11:30 PM, Xiaojian Zhou 
> wrote:
> > >
> > > > 1011, 1062, 1066, 1147 have been run 30+ times without reproduce. So
> > it's
> > > > not flaky. I think we can close them. If reproduced someday, we can
> > > > re-open.
> > > >
> > > >
> > > > On Sat, Oct 1, 2016 at 5:09 PM, Anthony Baker 
> > wrote:
> > > >
> > > >> I reviewed a bunch of CI failures today.  I closed out duplicates
> and
> > > >> added the ‘CI’ label to JIRA tickets that were missing it.  I just
> > > posted a
> > > >> big review to add the FlakyTest category to bugs with
> non-reproducible
> > > >> failures—pretty much any CI bug that is currently open.  Your
> comments
> > > are
> > > >> appreciated (I can push a feature branch if that’s easier):
> > > >>
> > > >> https://reviews.apache.org/r/52468/
> > > >>
> > > >> I found several open issues where the flaky category had been
> removed.
> > > >> Can these be marked resolved?
> > > >>
> > > >> GEODE-933
> > > >> GEODE-977
> > > >> GEODE-1011
> > > >> GEODE-1062
> > > >> GEODE-1066
> > > >> GEODE-1147
> > > >>
> > > >> I have a suspicion that the following open issues are actually
> fixed.
> > > >> Any ideas?
> > > >>
> > > >> GEODE-1918
> > > >> GEODE-1333,1334,1335
> > > >>
> > > >>
> > > >> Anthony
> > > >>
> > > >>
> > > >
> > >
> >
>
>
>
> --
> -John
> 503-504-8657
> john.blum10101 (skype)
>

Re: 1.0 release branch

[Swapnil Bawaskar]

Thanks Anthony & Mark.

For 116 issues that matched the filter: "project = GEODE AND status in
(Resolved, Closed) AND fixVersion = EMPTY"
I set the fix version as 1.0.0-incubating.

Going forward please only mark the issues fixed on the release branch with
1.0.0-incubating version.

Thanks!
Swapnil.

On Sat, Oct 1, 2016 at 10:51 AM, Mark Bretl <asf.mbr...@gmail.com> wrote:

> Version 1.1.0-incubating has now been created in JIRA.
>
> --Mark
>
> On Saturday, October 1, 2016, Anthony Baker <aba...@pivotal.io> wrote:
>
> > Thanks Swapnil!
> >
> > I bumped the version on develop to 1.1.0-incubating.  Can someone with
> > JIRA karma could create the corresponding JIRA version?  As we resolve
> > issues on the develop branch we should set the Fix Version as
> > 1.1.0-incubating.
> >
> > I also removed the -SNAPSHOT qualifier from the release/1.0.0-incubating
> > branch.
> >
> > Anthony
> >
> > > On Oct 1, 2016, at 12:39 AM, Swapnil Bawaskar <sbawas...@pivotal.io
> > <javascript:;>> wrote:
> > >
> > > Based on the " Limiting scope for Geode 1.0" thread [1] I have cut a
> > branch
> > > release/1.0.0-incubating from develop on commit
> > > abef045179e5d805cb04bc55a77a82798becdaae for the 1.0 release. Please
> > make
> > > sure that only issues targeted for 1.0 [2] are fixed on that branch. If
> > you
> > > are using git flow, use git flow release track 1.0.0-incubating for
> > > switching to the new branch.
> > >
> > > Thanks!
> > >
> > > [1] http://markmail.org/thread/i57xsje2j7gdgihu
> > > [2] https://issues.apache.org/jira/issues/?jql=project%20%
> > > 3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
> > > 20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> > > 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >
> >
>

1.0 release branch

[Swapnil Bawaskar]

Based on the " Limiting scope for Geode 1.0" thread [1] I have cut a branch
release/1.0.0-incubating from develop on commit
abef045179e5d805cb04bc55a77a82798becdaae for the 1.0 release. Please make
sure that only issues targeted for 1.0 [2] are fixed on that branch. If you
are using git flow, use git flow release track 1.0.0-incubating for
switching to the new branch.

Thanks!

[1] http://markmail.org/thread/i57xsje2j7gdgihu
[2] https://issues.apache.org/jira/issues/?jql=project%20%
3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC

Re: Limiting scope for Geode 1.0

[Swapnil Bawaskar]

Thanks for the offer Anthony,
I tagged GEODE-17 / GEODE-1570 to be fixed in 1.0 and I removed the 1.0 tag
from GEODE-1793 so that open JIRA issues for 1.0 [1] should now be accurate.

I have also cut a branch release/1.0.0-incubating from develop on commit
abef045179e5d805cb04bc55a77a82798becdaae for the 1.0 release. Please make
sure that only issues targeted for 1.0 are fixed on that branch. If you are
using git flow, use git flow release track 1.0.0-incubating for switching
to the new branch.


Thanks!

[1] https://issues.apache.org/jira/issues/?jql=project%20%
3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC

On Fri, Sep 30, 2016 at 11:30 AM, William Markito 
wrote:

> +1
>
> On Fri, Sep 30, 2016 at 9:16 AM, Kenneth Howe  wrote:
>
> > +1
> >
> > > On Sep 29, 2016, at 2:31 PM, Jacob Barrett 
> wrote:
> > >
> > > +1 for creating branch now to prevent feature creep.
> > >
> > > On Thu, Sep 29, 2016 at 2:10 PM Kirk Lund  wrote:
> > >
> > >> I think we should propose creating that release branch sooner (now?)
> so
> > we
> > >> can minimize unplanned changes slipping into 1.0 and destabilizing it.
> > >>
> > >> -Kirk
> > >>
> > >> On Thursday, September 29, 2016, Anthony Baker 
> > wrote:
> > >>
> > >>> Using the gitflow approach, we cut a release/1.0.0 branch to isolate
> > the
> > >>> release branch from ongoing development.  For past releases we have
> > >> waited
> > >>> as long as possible to cut the branch to minimize overhead.  Perhaps
> > this
> > >>> time we should create the branch earlier.
> > >>>
> > >>> JIRA shows the open issues for 1.0.0 [1] but there are some deltas
> > >>> compared to the last release scope email [2].
> > >>>
> > >>> GEODE-17 / GEODE-1570 was mentioned as a possible candidate for 1.0.0
> > but
> > >>> the Fix Version is not set
> > >>> GEODE-1168 was not included in the 1.0.0 scope discussions but Fix
> > >> Version
> > >>> is set to 1.0.0
> > >>> GEODE-1914 is follow on work from the package namespace changes
> > >>>
> > >>> @Swapnil, does this accurately reflect the scope discussions for
> 1.0.0?
> > >>> If so, I can update the bugs.
> > >>>
> > >>> Anthony
> > >>>
> > >>> [1] https://issues.apache.org/jira/issues/?jql=project%20%
> > >>> 3D%20GEODE%20AND%20fixVersion%20%3D%201.0.0-incubating%
> > >>> 20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> > >>> 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > >>>
> > >>> [2] http://mail-archives.apache.org/mod_mbox/incubator-geode-
> > >>> dev/201609.mbox/%3cCANZq1gBzMTEM_JHzw2YT_
> > LZeC5g472XkNCfJhma76xah=Yyq6A@
> > >>> mail.gmail.com%3e
> > >>>
> > >>>
> >  On Sep 29, 2016, at 1:02 PM, Kirk Lund  > >> >
> > >>> wrote:
> > 
> >  What changes are we still waiting on to cut the next RC of Geode
> 1.0?
> > 
> >  Is there a way to create a branch for Geode 1.0 develop that allows
> > >> folks
> >  to continue working on post-1.0 features or bug fixes without
> > >>> destabilizing
> >  Geode 1.0? This way, only the necessary changes for Geode 1.0 would
> go
> > >> to
> >  the 1.0 branch?
> > 
> >  -Kirk
> > >>>
> > >>>
> > >>
> >
> >
>
>
> --
>
> ~/William
>

Re: Previous versions dtds

[Swapnil Bawaskar]

+1

We also unit tests for these:
CacheXml30DUnitTest
CacheXml40DUnitTest
...
and so on. we should bring all the test cases within these
to CacheXml70DUnitTest

On Thu, Sep 29, 2016 at 9:37 AM, Hitesh Khamesra <
hitesh...@yahoo.com.invalid> wrote:

> We have following dtds in geode source code. We were thinking to remove
> previous versions(1.0 to 6.6) of dtds.Please let us know if there is any
> concern on  this.
>
> ./main/resources/org/apache/geode/admin/doc-files/ds4_0.dtd
> ./main/resources/org/apache/geode/admin/doc-files/ds5_0.dtd
> ./main/resources/org/apache/geode/admin/jmx/internal/doc-
> files/mbeans-descriptors.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache3_0.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache4_0.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache4_1.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache5_0.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache5_1.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache5_5.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache5_7.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache5_8.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache6_0.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache6_1.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache6_5.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache6_6.dtd
>
>
> ./main/resources/org/apache/geode/cache/doc-files/cache7_0.dtd
> ./main/resources/org/apache/geode/cache/doc-files/cache8_0.dtd
> ./main/resources/org/apache/geode/statisticsType.dtd
>
> Thanks.HItesh
>
>

Re: jvsd

[Swapnil Bawaskar]

I would vote for including it as an "experimental" feature.

On Thu, Sep 22, 2016 at 4:37 PM, Dave Barnes  wrote:

> Process for handling Experimental docs is still being hammered out. Common
> element among working scenarios is isolation from the body of the User
> Guide proper, so I'll remove the JVSD component from the User Guide's Tools
> and Modules section.
> Could go on the Wiki, could go in an appendix. We'll see what emerges.
> Any favorites among the readers of this thread?
> Silence = "Docs group gets to pick"
>
> On Thu, Sep 22, 2016 at 3:37 PM, John Blum  wrote:
>
> > Truthfully, I don't think this is any different than API features that
> have
> > been annotated with "@Experimental" (e.g. LucenceService
> >  > javadoc/com/gemstone/gemfire/cache/lucene/LuceneService.html>).
> > I.e. nothing is going to stop a user from trying to use a
> > feature/function/tool and searching for relevant information on how to
> use
> > it if they know it exists, either explicitly or implicitly.
> >
> > In fact, I would think it is advantageous if they know it does exist,
> even
> > prior to an official release, so that feedback can be gathered.
> >
> > If it is not to be part of the "official" User Guide, perhaps a Wiki page
> > (other than the specification
> >  > action?pageId=61309918=contextnavpagetreemode>
> > [1])
> > or better yet, a GitHub README page along with the source code if users
> are
> > given access to build and use the tool themselves.
> >
> > If part of the "official" User Guide (under tools), then perhaps a
> > "Experimental" label.
> >
> > Food for thought.
> >
> > -John
> >
> >
> > [1]
> > https://cwiki.apache.org/confluence/pages/viewpage.
> > action?pageId=61309918=contextnavpagetreemode
> >
> >
> > On Thu, Sep 22, 2016 at 3:19 PM, Anthony Baker 
> wrote:
> >
> > > I think that providing documentation for jvsd before it is included in
> > the
> > > source and binary release distributions will only confuse users.  +1
> for
> > > removing.
> > >
> > > Anthony
> > >
> > > > On Sep 22, 2016, at 2:39 PM, Dave Barnes  wrote:
> > > >
> > > > JVSD has appeared in the Geode user manual since M2. See
> > > > http://geode.docs.pivotal.io/docs/tools_modules/jvsd.html.
> > > > Kirk, are you recommending that we remove this?
> > > >
> > > > On Thu, Sep 22, 2016 at 10:57 AM, Kirk Lund 
> wrote:
> > > >
> > > >> I would recommend not mentioning jVSD at all in the Geode 1.0 docs.
> > > Right
> > > >> now it's just a Jira ticket and feature branch. I think the docs
> > should
> > > >> only cover what's in Geode 1.0.
> > > >>
> > > >> If there's some doc or wiki page about proposed future features or
> > > features
> > > >> currently looking for contributors/developers, then that would
> > probably
> > > be
> > > >> an appropriate place to mention jVSD.
> > > >>
> > > >> Thanks,
> > > >> Kirk
> > > >>
> > > >> On Thursday, September 22, 2016, Joey McAllister <
> > > jmcallis...@pivotal.io>
> > > >> wrote:
> > > >>
> > > >>> Bumping this. Any thoughts?
> > > >>>
> > > >>> On Tue, Sep 20, 2016 at 10:50 AM Dave Barnes  > > >>> > wrote:
> > > >>>
> > >  To what degree should jVSD be mentioned in the docs? The current
> > > >> writeup
> > > >>> is
> > >  essentially "go get it if you want it, but be warned that it's not
> > > >> fully
> > >  baked and we don't support it".
> > >  Would that still be the appropriate jVSD policy for 1.0.0?
> > > 
> > >  On Tue, Sep 20, 2016 at 10:42 AM, Dan Smith  > > >>> > wrote:
> > > 
> > > > I don't think we should try to include jVSD in 1.0.0 at this
> point,
> > >  because
> > > > it introduces dependencies that might make the 1.0.0 release more
> > > > complicated such as the MultiAxisChartFX dependency. But I think
> > the
> > >  should
> > > > try to get it to develop sooner rather than later to make it
> easier
> > > >> for
> > > > people to get jVSD and play with it.
> > > >
> > > > -Dan
> > > >
> > > 
> > > >>>
> > > >>
> > >
> > >
> >
> >
> > --
> > -John
> > 503-504-8657
> > john.blum10101 (skype)
> >
>

Review Request 52152: GEODE-1921: Redis adaptor Strings region has incorrect attributes

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52152/
---

Review request for geode.


Repository: geode


Description
---

- renamed them to redis_strings and redis_hll
- made the strings regions and the hll region PARTITION by default
- these regions are no longer internal regions


Diffs
-

  geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 
45d18864ef8b4ee642b553546e86f483bf7bb1f6 
  geode-core/src/test/java/org/apache/geode/redis/RedisServerTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52152/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: M3 is out - New release manager for 1.0 ?

[Swapnil Bawaskar]

For Geode-17:
GEODE-1570 (secure developer REST API) : is in progress, and by the
commits I think its very close to being done.
GEODE-1659 (Prevent misconfiguration of Integrated Security) : has not
been started yet.
 everything else has been completed.

So, can we can say GEODE-1570 is targeted for 1.0?

-Swapnil.

On Tue, Sep 20, 2016 at 9:40 AM, Anthony Baker  wrote:

> >
> > So, my proposal for issues to be targeted for 1.0 is:
> > GEODE-136 Fix possible NullPointerException in Gfsh's 'list regions'
> > command's GetRegionsFunction
> > GEODE-1466 Branding: rename gemfire.properties file to geode.properties
> file
> > GEODE-17 Provide Integrated Security
> > GEODE-37 (package renaming)
> > GEODE-1791 (LICENSE update)
> >
> > Thoughts?
> >
>
> I found a few other minor issues that would be good to address in 1.0.0:
>
> GEODE-1513 (duplicate jar files in wars)
> GEODE-1511 (pom dependencies)
>
> I’ve got review requests out for these changes.
>
> Anthony
>
>

Re: M3 is out - New release manager for 1.0 ?

[Swapnil Bawaskar]

According to this thread[1] the scope for 1.0 was:

http://mail-archives.apache.org/mod_mbox/geode-dev/201605.mbox/%
3CCABKA6No4CQmjuzQ4Q0MY5+Nj4=e08jin8losairuoveuf+t...@mail.gmail.com%3E



GEODE-33-2 Create project examples
GEODE-1331 gfsh.bat on Windows is incorrect
GEODE-1168 geode-dependencies manifest is missing jars that are present in
the lib directory
GEODE-629 Replace use of org.json with Jackson JSON library
GEODE-607 the offheap package needs better unit test coverage
GEODE-136 Fix possible NullPointerException in Gfsh's 'list regions'
command's GetRegionsFunction.
GEODE-1191  HDFS references
GEODE-612Update Jackson version since current version is not on Maven
central

Rebranding tickets targeted for 1.0 were:
GEODE-985 gfsh help text: rebrand for open source
GEODE-1465 Branding: rename JMX endpoints from 'Gemfire' to 'Geode'
GEODE-1466 Branding: rename gemfire.properties file to geode.properties file
GEODE-1467 Branding: Rename servlet URLs from gemfire to geode

>From above, Anthony proposed:
GEODE-37 (package renaming)
GEODE-1791 (LICENSE update)

of these, following issues are still unresolved:
GEODE-1168 geode-dependencies manifest is missing jars that are present in
the lib directory
GEODE-629 Replace use of org.json with Jackson JSON library
GEODE-136 Fix possible NullPointerException in Gfsh's 'list regions'
command's GetRegionsFunction
GEODE-1465 Branding: rename JMX endpoints from 'Gemfire' to 'Geode'
GEODE-1466 Branding: rename gemfire.properties file to geode.properties file

To me, GEODE-1168 and GEODE-629 do not seem "must have" for 1.0. Also,
GEODE-1465 is not immediately user visible, so can be skipped too. However,
I think we should target GEODE-17 for 1.0.

So, my proposal for issues to be targeted for 1.0 is:
GEODE-136 Fix possible NullPointerException in Gfsh's 'list regions'
command's GetRegionsFunction
GEODE-1466 Branding: rename gemfire.properties file to geode.properties file
GEODE-17 Provide Integrated Security
GEODE-37 (package renaming)
GEODE-1791 (LICENSE update)

Thoughts?


On Fri, Sep 9, 2016 at 2:56 PM, Dan Smith <dsm...@pivotal.io> wrote:

> +1 for getting package renaming in 1.0.
>
> It would also be nice if we could get some more examples in 1.0!
>
> -Dan
>
> On Fri, Sep 9, 2016 at 2:27 PM, Anthony Baker <aba...@pivotal.io> wrote:
>
> > Thanks for starting this thread.  There are a few recent conversations on
> > this topic [1][2].
> >
> > My thought is that we should bear down and focus on the issues that help
> > geode become “graduation-ready”.  Here’s a candidate list:
> >
> > v1.0.0-incubating:
> > -
> > GEODE-37 (package renaming)
> > GEODE-1791 (LICENSE update)
> > + some bugs fixes as they come in
> >
> > v1.0.0+
> > -
> > everything else
> >
> >
> > Looking forward to hearing your thoughts!
> >
> > Anthony
> >
> > [1] https://mail-archives.apache.org/mod_mbox/incubator-geode-
> > dev/201609.mbox/%3cef2278f9-a216-4f64-8576-c9d091747...@pivotal.io%3e
> > [2] http://mail-archives.apache.org/mod_mbox/incubator-geode-
> > dev/201609.mbox/%3cCAHEKSULW1J6RWEXqVF_v1Fw9AJimaeXY7gDy5FmjtfkWb2_
> > g...@mail.gmail.com%3e
> >
> > > On Sep 8, 2016, at 4:24 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
> > wrote:
> > >
> > > I can take on this task for 1.0
> > >
> > > On Thu, Sep 8, 2016 at 4:20 PM, William Markito <wmark...@pivotal.io>
> > wrote:
> > >
> > >> With M3 out and all the discussions we're having around what's needed
> > for
> > >> 1.0, I think we should continue the rotation of release managers and
> > get a
> > >> new volunteer for 1.0.
> > >>
> > >> As part of this conversation we should also discuss the scope and
> > roadmap
> > >> for 1.0 and could use the thread [1] for M3 as a starting point.
> > >>
> > >> Here is what got discussed:
> > >>
> > >> -
> > >> Guys, restarting this thread to get a discussion going about M3, 1.0.0
> > and
> > >> next -  As the release manager for M3 here is what I'd like to
> propose.
> > >>
> > >> Any feedback is welcome and let's also reuse this thread to talk a
> > little
> > >> bit about roadmap as well ?
> > >>
> > >> # Current M3 Scope (https://cwiki.apache.org/
> > confluence/display/GEODE/1.0.
> > >> 0-incubating.M3+Release)
> > >>
> > >> GEODE-33
> > >> GEODE-823
> > >> GEODE-835
> > >> GEODE-919
> > >> GEODE-1146
> > >> GEODE-1168
> > >> GEODE-1203
> &

Re: Need help on querying

[Swapnil Bawaskar]

> I think queryResultSetLimit might be a way for TypedJson to cut a collection
short.

Kirk, did you mean queryCollectionsDepth here?

I would like to argue that we do not need queryCollectionsDepth, because
returning only a subset of data without even telling the users that its a
subset, or allowing the users to control the parameter is just wrong.

On Wed, Sep 14, 2016 at 3:04 PM, Anthony Baker  wrote:

> Perhaps a custom jackson serializer for Collections that stops after
> queryCollectionsDepth would do the trick.
>
> Anthony
>
>
> > On Sep 14, 2016, at 2:24 PM, Kirk Lund  wrote:
> >
> > Yep, that method does add " LIMIT X" to the query where X
> > equals queryResultSetLimit.
> >
> > I think queryResultSetLimit might be a way for TypedJson to cut a
> > collection short. It's always 100 and if one of the fields of your value
> > object is a collection then I believe the resulting json will always
> > include up to 100 maximum elements of that collection. This seems to be
> use
> > for it. But it's hardcoded to 100 and not exposed to the user in any way.
> >
> > Thanks,
> > Kirk
> >
> >
> > On Wed, Sep 14, 2016 at 2:15 PM, John Blum  wrote:
> >
> >> Hi Kirk-
> >>
> >> Also, TMK there is no specific API call and/or parameter to limit the
> >> result set of a query, rather it is typically expressed in the OQL
> query as
> >> so...
> >>
> >> SELECT * FROM /Region WHERE  LIMIT X
> >>
> >> Where 'X' is the desired result quantity.
> >>
> >> So, perhaps the question is more of what does the following API call
> >> translate into OQL as...
> >>
> >> QueryDataFunction.queryData(query, members, limit, false,
> >> queryResultSetLimit, queryCollectionsDepth);
> >>
> >> Hope this helps,
> >>
> >> John
> >>
> >>
> >>
> >> On Wed, Sep 14, 2016 at 11:36 AM, Jason Huynh 
> wrote:
> >>
> >>> Hi Kirk,
> >>>
> >>> I am not too familiar with the TypeJson class or how it was being
> used...
> >>> for number 2, I am assuming the queryCollectionsDepth is a specific
> >>> gfsh/function specific to gfsh.  I don't think there is an equivalent
> oql
> >>> keyword or call for that.
> >>>
> >>> -Jason
> >>>
> >>> On Wed, Sep 14, 2016 at 10:11 AM Kirk Lund  wrote:
> >>>
>  I'm trying to remove TypedJson and replace it with Jackson.
> >>> Unfortunately,
>  it appears that some of the behavior for limiting how much data a
> query
>  returns has leaked into the TypedJson class in the form of
>  "queryCollectionsDepth".
> 
>  Both GFSH and Pulse use the following to limit how much a query
> >>> returns...
> 
>   /**
>    * Number of rows queryData operation will return. By default it will
> >>> be
>  1000
>    */
>   private int queryResultSetLimit =
>  ManagementConstants.DEFAULT_QUERY_LIMIT;
> 
>   /**
>    * NUmber of elements to be shown in queryData operation if query
> >>> results
>  contain collections like Map, List etc.
>    */
>   private int queryCollectionsDepth =
>  TypedJson.DEFAULT_COLLECTION_ELEMENT_LIMIT;
> 
>  These are passed into:
> 
>  QueryDataFunction.queryData(query, members, limit, false,
>  queryResultSetLimit, queryCollectionsDepth);
> 
>  1) queryResultSetLimit is fed into the query itself as a LIMIT
> 
>  2) queryCollectionsDepth is apparently fed into TypedJson as some sort
> >> of
>  limit involving depth of recursing a collection -- this should
> probably
>  move into the query in some way.
> 
>  Does anyone understand querying enough to help me move this behavior
> to
>  some proper place such as a querying class? I'm completely unfamiliar
> >>> with
>  the querying code so I'm not sure where to even begin on #2.
> 
>  Thanks,
>  Kirk
> 
> >>>
> >>
> >>
> >>
> >> --
> >> -John
> >> 503-504-8657
> >> john.blum10101 (skype)
> >>
>
>

Re: securing geode components

[Swapnil Bawaskar]

;>>> it
> > >>>>>>>>
> > >>>>>>>>> SecurableChannels or SecurableCommunicationChannels or
> whatever.
> > >>>>>>>>>
> > >>>>>>>>> 3) I'd prefer HTTP be renamed to Web or other non-protocol word
> > --
> > >>>>>>>>>
> > >>>>>>>> HTTP
> > >>>>>
> > >>>>>> is
> > >>>>>>>>
> > >>>>>>>>> a protocol and the names of the other channels are conceptual
> > >>>>>>>>>
> > >>>>>>>> channels
> > >>>>
> > >>>>> rather than a protocol (the others use TCP/IP or RMI but we don't
> > >>>>>>>>>
> > >>>>>>>> label
> > >>>>>
> > >>>>>> them as such). Or am I missing something here?
> > >>>>>>>>>
> > >>>>>>>>> 4) JMX is probably ok. Currently we are using (and securing)
> JMX
> > >>>>>>>>>
> > >>>>>>>> over
> > >>>>
> > >>>>> RMI
> > >>>>>>>
> > >>>>>>>> (javax.management.remote.rmi.RMIConnectorServer). There are
> other
> > >>>>>>>>> connectors for JMX including HTTP (ex: mx4j.tools.adaptor.http.
> > >>>>>>>>>
> > >>>>>>>> HttpAdaptor)
> > >>>>>>>>
> > >>>>>>>>> and SNMP (ex: com.sun.jmx.snmp.daemon.SnmpAdaptorServer). We
> > only
> > >>>>>>>>>
> > >>>>>>>> need
> > >>>>>
> > >>>>>> JMX
> > >>>>>>>>
> > >>>>>>>>> over RMI for now, but would we add those others as new enums to
> > >>>>>>>>> SecurableChannels later if we add anything like that to Geode?
> Or
> > >>>>>>>>>
> > >>>>>>>> would
> > >>>>>
> > >>>>>> we
> > >>>>>>>>
> > >>>>>>>>> try to group those all together under the name JMX? Or decide
> > when
> > >>>>>>>>>
> > >>>>>>>> the
> > >>>>
> > >>>>> time
> > >>>>>>>>
> > >>>>>>>>> comes?
> > >>>>>>>>>
> > >>>>>>>>> I think we should try to steer away from being overly
> controlled
> > >>>>>>>>>
> > >>>>>>>> by
> > >>>
> > >>>> specs
> > >>>>>>>
> > >>>>>>>> especially for reasonable changes. We all follow agile process,
> > >>>>>>>>>
> > >>>>>>>> so a
> > >>>
> > >>>> decision made one iteration could easily be undone or changed in
> > >>>>>>>>>
> > >>>>>>>> the
> > >>>
> > >>>> next
> > >>>>>>>
> > >>>>>>>> iteration and most of us are following weekly iterations.
> > >>>>>>>>>
> > >>>>>>>>> After a release anything exposed in a User API is very
> difficult
> > >>>>>>>>>
> > >>>>>>>> to
> > >>>
> > >>>> change
> > >>>>>>>>
> > >>>>>>>>> due to backwards compatibility constraints. I think we should
> be
> > >>>>>>>>>
> > >>>>>>>> much
> > >>>>
> > >>>>> more
> > >>>>>>>>
> > >>>>>>>>> careful with User APIs in Geode going forward to avoid some of
> > the
> > >>>>>>>>>
> > >>>>>>>> problems
> > >>>>>>>>
> > >>>>>>>>> we have with pre-existing Geode User APIs that we inherited.
> > >>>>>>>>>
> > >>>>>>>>> -Kirk
> > >>>>>>>>>
> > >>>>>>>>> On Thu, Sep 8, 2016 at 2:07 PM, Udo Kohlmeyer <
> > >>>>>>>>>
> > >>>>>>>> ukohlme...@pivotal.io <javascript:;>>
> > >>>>
> > >>>>> wrote:
> > >>>>>>>>
> > >>>>>>>>> As GEODE-420 deals with SSL comms configuration and GEODE-1648
> > >>>>>>>>>>
> > >>>>>>>>> with
> > >>>
> > >>>> Authentication I think we need to be careful in
> > >>>>>>>>>>
> > >>>>>>>>> what
> > >>>
> > >>>> is
> > >>>>
> > >>>>> feasible and what is logical.
> > >>>>>>>>>>
> > >>>>>>>>>> For SSL comms it was decided that the following components are
> > >>>>>>>>>>
> > >>>>>>>>> relevant
> > >>>>>>>
> > >>>>>>>> [1] <https://cwiki.apache.org/confluence/display/GEODE/
> Revised+S
> > >>>>>>>>>> SL+properties>:
> > >>>>>>>>>>
> > >>>>>>>>>> * Locator => The comms channel between Locators + the initial
> > >>>>>>>>>>
> > >>>>>>>>> comms
> > >>>
> > >>>>   channel between clients and locator
> > >>>>>>>>>> * Cluster => Internode comms channel (peer to peer)
> > >>>>>>>>>> * Server => Client-server comms channel
> > >>>>>>>>>> * Gateway => Comms channel between WAN Gateway
> senders/receivers
> > >>>>>>>>>> * HTTP => Any HTTP comms. incl REST and Pulse
> > >>>>>>>>>> * JMX => Any JMX comms
> > >>>>>>>>>>
> > >>>>>>>>>> These components were selected as they seem to be logical
> > >>>>>>>>>>
> > >>>>>>>>> boundaries
> > >>>>
> > >>>>> and
> > >>>>>>>
> > >>>>>>>> communication interfaces.
> > >>>>>>>>>>
> > >>>>>>>>>> I think the specialization of HTTP, for
> > >>>>>>>>>>
> > >>>>>>>>> Authentication
> > >>>>
> > >>>>> are
> > >>>>>>>
> > >>>>>>>> functions of those interfaces:
> > >>>>>>>>>>
> > >>>>>>>>>> * REST-admin
> > >>>>>>>>>> * REST-dev
> > >>>>>>>>>> * Pulse
> > >>>>>>>>>>
> > >>>>>>>>>> I think that comms and functions exposed by those comms should
> > >>>>>>>>>>
> > >>>>>>>>> not
> > >>>
> > >>>> be
> > >>>>
> > >>>>> mixed. I think that securing the comms channel is a factor of
> > >>>>>>>>>>
> > >>>>>>>>> "trust".
> > >>>>>
> > >>>>>> Do I
> > >>>>>>>>
> > >>>>>>>>> implicitly trust the interface/system that I am connected to or
> > >>>>>>>>>>
> > >>>>>>>>> are
> > >>>
> > >>>> connecting to.
> > >>>>>>>>>>
> > >>>>>>>>>> I think concepts like "management" is a concept in function.
> Do
> > I
> > >>>>>>>>>>
> > >>>>>>>>> allow
> > >>>>>>>
> > >>>>>>>> a
> > >>>>>>>>
> > >>>>>>>>> user to access admin API's? The function of management should
> not
> > >>>>>>>>>>
> > >>>>>>>>> determine
> > >>>>>>>>
> > >>>>>>>>> if a system trusts another systems connection. When a new comms
> > >>>>>>>>>>
> > >>>>>>>>> interface
> > >>>>>>>>
> > >>>>>>>>> is added (say messaging), we want to be able to trust that
> comms
> > >>>>>>>>>>
> > >>>>>>>>> channel.
> > >>>>>>>>
> > >>>>>>>>> The "management" function should still work regardless of
> > >>>>>>>>>>
> > >>>>>>>>> interface,
> > >>>>
> > >>>>> be
> > >>>>>>>
> > >>>>>>>> it
> > >>>>>>>>
> > >>>>>>>>> jmx,http/rest,prop tcp,messaging.
> > >>>>>>>>>>
> > >>>>>>>>>> --Udo
> > >>>>>>>>>>
> > >>>>>>>>>> [1]: https://cwiki.apache.org/confluence/display/GEODE/
> > >>>>>>>>>>
> > >>>>>>>>> Revised+SS
> > >>>
> > >>>> L+properties
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> On 9/09/2016 5:49 AM, Swapnil Bawaskar wrote:
> > >>>>>>>>>>
> > >>>>>>>>>> GEODE-1648 and GEODE-420 are both trying to add geode
> properties
> > >>>>>>>>>>>
> > >>>>>>>>>> to
> > >>>>
> > >>>>> secure
> > >>>>>>>>
> > >>>>>>>>> only some components.
> > >>>>>>>>>>> GEODE-1648 is intending to add a property named
> > >>>>>>>>>>> "security-enabled-components" that will allow users to turn
> off
> > >>>>>>>>>>> authentication/authorization for some components
> > >>>>>>>>>>> GEODE-420 is intending to add a property named
> > >>>>>>>>>>>
> > >>>>>>>>>> "ssl-enabled-components"
> > >>>>>>>
> > >>>>>>>> that will allow users to turn off ssl. for either client/server,
> > >>>>>>>>>>> peer-to-peer or wan communication.
> > >>>>>>>>>>>
> > >>>>>>>>>>> Since both deal with security, I think we should have the
> same
> > >>>>>>>>>>>
> > >>>>>>>>>> list
> > >>>>
> > >>>>> of
> > >>>>>>>
> > >>>>>>>> components for these new geode properties. Intent of this thread
> > >>>>>>>>>>>
> > >>>>>>>>>> is
> > >>>>
> > >>>>> to
> > >>>>>>>
> > >>>>>>>> arrive at a consensus on what these components are.
> > >>>>>>>>>>>
> > >>>>>>>>>>> I would like to propose the following components:
> > >>>>>>>>>>> Cluster => stands for peer-to-peer
> > >>>>>>>>>>> Server => client/server and developer rest API
> > >>>>>>>>>>> WAN => gateway sender/receiver
> > >>>>>>>>>>> Management => jmx, admin-rest, pulse
> > >>>>>>>>>>>
> > >>>>>>>>>>> Thanks!
> > >>>>>>>>>>> Swapnil.
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>
> > >>>>>>> --
> > >>>>>>> Cheers
> > >>>>>>>
> > >>>>>>> Jinmei
> > >>>>>>>
> > >>>>>>>
> > >>>>>
> > >>>
> > >>> --
> > >>> -John
> > >>> 503-504-8657
> > >>> john.blum10101 (skype)
> > >>>
> > >>>
> > >
> >
> >
> > --
> > -John
> > 503-504-8657
> > john.blum10101 (skype)
> >
>

Re: M3 is out - New release manager for 1.0 ?

[Swapnil Bawaskar]

I can take on this task for 1.0

On Thu, Sep 8, 2016 at 4:20 PM, William Markito  wrote:

> With M3 out and all the discussions we're having around what's needed for
> 1.0, I think we should continue the rotation of release managers and get a
> new volunteer for 1.0.
>
> As part of this conversation we should also discuss the scope and roadmap
> for 1.0 and could use the thread [1] for M3 as a starting point.
>
> Here is what got discussed:
>
> -
> Guys, restarting this thread to get a discussion going about M3, 1.0.0 and
> next -  As the release manager for M3 here is what I'd like to propose.
>
> Any feedback is welcome and let's also reuse this thread to talk a little
> bit about roadmap as well ?
>
> # Current M3 Scope (https://cwiki.apache.org/confluence/display/GEODE/1.0.
> 0-incubating.M3+Release)
>
> GEODE-33
> GEODE-823
> GEODE-835
> GEODE-919
> GEODE-1146
> GEODE-1168
> GEODE-1203
> GEODE-1259
> GEODE-1278
> GEODE-1293
> GEODE-1316
> GEODE-1256
> GEODE-1267
>
> == Proposed scope & roadmap ==
>
> I'd like to breakdown the release a little bit and already start planning
> the next releases.
>
> # Geode 1.0.0-incubating M3
>
> GEODE-1316 Update @since tags to include GemFire or Geode in the version
> name
> GEODE-1293 Align code and docs for modules
> GEODE-1278 AbstractPeerTXRegionStub should throw
> TransactionDataNodeHasDeparted when remote cache is closed
> GEODE-1267 NOTICE file improvements
> GEODE-1256 Geode website - Unapproved licenses
> GEODE-1203 gfsh connect --use-http reports a ClassNotFoundException
> GEODE-919 GEODE-823 Remove checksums from .asc files (asc.md5, asc.sha1)
> GEODE-835 Replace joptsimple source with a binary dependency
> GEODE-823 RC Feedback: Fix build artifacts
> GEODE-33-1 Create project examples
>
> # Geode 1.0.0-incubating
>
> GEODE-33-2 Create project examples
> GEODE-1331 gfsh.bat on Windows is incorrect
> GEODE-1168 geode-dependencies manifest is missing jars that are present in
> the lib directory
> GEODE-629 Replace use of org.json with Jackson JSON library
> GEODE-607 the offheap package needs better unit test coverage
> GEODE-136 Fix possible NullPointerException in Gfsh's 'list regions'
> command's GetRegionsFunction.
>
> # Geode 1.X.0-incubating
>
> GEODE-17 Provide Integrated Security
> GEODE-11 Lucene Integration
> GEODE-33-3 Create project examples
>
> # Geode 2.0.0-incubating
>
> GEODE-72 Remove deprecated APIs from Geode
> GEODE-37 Package renaming
> -
>
>
> [1] http://markmail.org/message/6roww5yc3xhdpdck
> --
> ~/William
>

Review Request 51349: GEODE-1569: add post authorization processing in JMX and CLI commands

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51349/
---

Review request for geode and Kirk Lund.


Repository: geode


Description
---

changed the Principal to be an Object to be consistent with how
other projects incuding spring-security and Apache shiro use Principal.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java
 b9dd8c00dae296d98d6d88bad0f938dffa89885c 
  geode-core/src/main/java/org/apache/geode/security/SecurityManager.java 
9db4734f14888b7b6c0b54c672d4f0644a5fffa7 
  
geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java
 5948527b3bbcdebf2ece24125593e338e2cd13e0 
  
geode-core/src/test/java/com/gemstone/gemfire/security/SpySecurityManager.java 
31ebde564ba03dfcaa68720c5c640055e832a7c4 

Diff: https://reviews.apache.org/r/51349/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: Swagger UI?

[Swapnil Bawaskar]

with the work done for GEODE-1467, swagger API is now available at:
/geode/docs/index.html

On Tue, Aug 9, 2016 at 11:10 AM, Kevin Duling  wrote:

> I saw that Geode has the annotations for Swagger.  How is the UI launched?
> In projects I've worked with before, it's been deployed under the
> "/swagger-ui" context.
>

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

[Swapnil Bawaskar]

+1

- compiled from source
- started a distributed system with servers from both source and binary
distributions
- exercised a sample application

On Mon, Aug 8, 2016 at 5:00 PM, Darrel Schneider 
wrote:

> +1
>
>
> On Mon, Aug 8, 2016 at 4:51 PM, Michael Stolz  wrote:
>
> > +1
> >
> > All indications are this attempt is correct
> >
> > --
> > Mike Stolz
> > Principal Engineer - Gemfire Product Manager
> > Mobile: 631-835-4771
> > On Aug 8, 2016 6:09 PM, "William Markito"  wrote:
> >
> > > Guys, I'll leave the voting open until tomorrow, but please vote so we
> > can
> > > close and release M3.
> > >
> > > Thanks,
> > >
> > > On Fri, Aug 5, 2016 at 4:24 PM, Anthony Baker 
> wrote:
> > >
> > > > +1
> > > >
> > > > * Verified she’s
> > > > * Verified signatures
> > > > * Verified tag signature
> > > > * Build from tag
> > > > * Build and run from src distro
> > > > * Checked src distro for binaries
> > > > * Run from binary distro
> > > > * Run some examples from mvn repo
> > > >
> > > > Anthony
> > > >
> > > > > On Aug 5, 2016, at 10:34 AM, Jason Huynh 
> wrote:
> > > > >
> > > > > +1
> > > > >
> > > > > - built from source distribution
> > > > > - started locator, server, listed members and created regions in
> gfsh
> > > > from
> > > > > binary
> > > > > - started locator and server from source built gfsh
> > > > >
> > > > >
> > > > > On Fri, Aug 5, 2016 at 9:58 AM Dan Smith 
> wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> Verified
> > > > >> * Successful precheckin run of this release -
> > > > >> https://builds.apache.org/job/
> > > > >> Geode-release/24/  job/Geode-release/24/>
> > > > >> * Signatures
> > > > >> * Basic gfsh commands with binary dist
> > > > >> * Built from source dist
> > > > >> * Basic CRUD test with maven artifacts
> > > > >> * No jars in source dist
> > > > >>
> > > > >> -Dan
> > > > >>
> > > > >> On Thu, Aug 4, 2016 at 6:02 PM, William Markito <
> > wmark...@pivotal.io>
> > > > >> wrote:
> > > > >>
> > > > >>> All,
> > > > >>>
> > > > >>> This is the seventh release candidate Apache Geode, version
> > > > >>> 1.0.0-incubating.M3.
> > > > >>>
> > > > >>> We're including the feedback received in RC6 including a fix
> > > > >>> (83f97ceef52febf92ef7737726548aa0865c1a59) to run REST API
> tests.
> > > > >>>
> > > > >>> Thanks to all the community members to drive towards this
> > milestone!
> > > > >>>
> > > > >>> It fixes the following issues:
> > > > >>>   https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > >>> projectId=12318420=12335358
> > > > >>>
> > > > >>> *** Please download, test and vote by Monday, August 8, 0800 hrs
> US
> > > > >>> Pacific.
> > > > >>>
> > > > >>> Note that we are voting upon the source (tag):
> > > > >>>   rel/v1.0.0-incubating.M3.RC7
> > > > >>>
> > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > >>> t;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7
> > > > >>>  > > > >>> git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M3.RC7>
> > > > >>>
> > > > >>> Commit ID: 83f97ceef52febf92ef7737726548aa0865c1a59
> > > > >>>
> > > > >>> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.gi
> > > > >>> t;a=commit;h=83f97ceef52febf92ef7737726548aa0865c1a59
> > > > >>>
> > > > >>> Source and binary files:
> > > > >>> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0
> > > > >>> -incubating.M3.RC7
> > > > >>>
> > > > >>> For this release the documentation on how to install and use
> Apache
> > > > Geode
> > > > >>> are hosted
> > > > >>> on pivotal.io:
> > > > >>>   http://geode.docs.pivotal.io
> > > > >>>
> > > > >>> Maven staging repo:
> > > > >>> https://repository.apache.org/content/repositories/
> > > orgapachegeode-1011
> > > > >>>
> > > > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > > > >>>   https://github.com/apache/incubator-geode/blob/release/
> > > > >>> 1.0.0-incubating.M3/KEYS
> > > > >>>
> > > > >>> Release Key: pub  4096R/7AAED8BB 2016-07-13
> > > > >>> Fingerprint: 8E06 B711 DB13 3AE7 0CC1  ABDE 6A14 F0BC 7AAE D8BB
> > > > >>>
> > > > >>> Thanks,
> > > > >>>
> > > > >>> --
> > > > >>> ~/William
> > > > >>>
> > > > >>
> > > >
> > > >
> > >
> > >
> > > --
> > >
> > > ~/William
> > >
> >
>

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50242/#review143269
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java
 (line 619)
<https://reviews.apache.org/r/50242/#comment209048>

As implemented this method always returns true. We should consider result 
of basicPut() on line 614 to determine the outcome of the operation.


- Swapnil Bawaskar


On July 22, 2016, 6:26 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50242/
> ---
> 
> (Updated July 22, 2016, 6:26 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1678
> https://issues.apache.org/jira/browse/GEODE-1678
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> During cache close or disconnect, a put into region queue of 
> GatewaySenderEventImpl may fail. The reference hold by the 
> GatewaySenderEventImpl will not be released later. Handle this case by 
> release offheap as necessary.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionQueue.java 
> 5108861 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java
>  85b50a1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java
>  ccdf42a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderEventProcessor.java
>  11502af 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
>  d703c6e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java
>  ba839f4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java
>  57d6e34 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java
>  d57290a 
> 
> Diff: https://reviews.apache.org/r/50242/diff/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Client Cache Behavior after ForcedDisconnectException

[Swapnil Bawaskar]

Hi Avinash,

The testcase you posted is missing createRegionInEachVM(), so I could not
run it.
Can you describe what is the error?

On Mon, Jul 11, 2016 at 7:18 AM, Avinash Dongre 
wrote:

> Hi All,
> I want to understand the  Client-Cache Behavior after for some reason
> server is getting reconnected due to ForcedDisconnectException.
>
> 1. Do I need to create client cache again, and Regions ?
>
> I tried to write following Tests but it is failing , Please help.
>
> private void forcedDisconnectAndReconnectEachVM() {
> new ArrayList<>(Arrays.asList(vm0/*, vm1, vm2*/)).
>   forEach((VM) -> VM.invoke(new SerializableCallable() {
> @Override
> public Object call() throws Exception {
>   GemFireCacheImpl oldCache = (GemFireCacheImpl)
> CacheFactory.getAnyInstance();
>   assertNotNull(oldCache);
>   InternalDistributedSystem distributedSystem =
> (InternalDistributedSystem) oldCache.getDistributedSystem();
>   assertNotNull(distributedSystem);
>
> MembershipManagerHelper.crashDistributedSystem(distributedSystem);
>   return null;
> }
>   }));
>   }
>
> private void updateServerCacheAfterReconnect() {
> new ArrayList<>(Arrays.asList(vm0/*, vm1, vm2*/)).
>   forEach((VM) -> VM.invoke(new SerializableCallable() {
> @Override
> public Object call() throws Exception {
>   Cache cache = CacheFactory.getAnyInstance();
>   cache = cache.getReconnectedCache();
>   return null;
> }
>   }));
>   }
>
> public void testForcedDisconnectException() {
>
> createRegionInEachVM();
>
> ClientCache clientCache = ClientCacheFactory.getAnyInstance();
> ClientRegionFactory crf =
>   clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY);
>
> Region test_pr_region = crf.create("TEST_PR_REGION");
>
> for (int i = 0; i < 10; i++) {
>   test_pr_region.put("Key" + i, "Value" + i);
> }
>
> forcedDisconnectAndReconnectEachVM();
> updateServerCacheAfterReconnect();
> createRegionInEachVM();
>
>
> for (int i = 0; i < 10; i++) {
>   final String s = test_pr_region.get("Key" + i);
>   assertEquals("Value" + i , s);
> }
>   }
>

Re: Geode website tagged with minor Apache branding issue in audit

[Swapnil Bawaskar]

+1
We should replace the Apache Geode logo that fades-in when you scroll the
page (http://i.imgur.com/XA6SvHb.png) with the feather. (Hope this is what
Roman means by "menu bar on the left")

On Sat, Jul 2, 2016 at 6:30 AM, Anthony Baker  wrote:

> ++1 and thanks for the thoughtful feedback.
>
> Anthony
>
> > On Jul 1, 2016, at 6:25 PM, Roman Shaposhnik 
> wrote:
> >
> > IANAD but why not put it into the menu banner on the left?
> >
> > IMHO, this will be a much more visually appealing layout.
> >
> > Thanks,
> > Roman.
> >
> >>>
> >>> Going back to the incubator branding issue, I think Geode should
> >>> incorporate the Incubator logo in its banner at the top of the page,
> with
> >>> the aim of replacing it with one of the Apache feather logos when it
> >>> graduates to a TLP.
> >>>
> >>> Niall
> >>>
>
>

Re: Build failed in Jenkins: Geode-nightly #520

[Swapnil Bawaskar]

I filed https://issues.apache.org/jira/browse/GEODE-1620 for the
unrecognized options issue.

On Tue, Jul 5, 2016 at 10:11 AM, Jinmei Liao  wrote:

> Let's change the test first and then create a jira ticket to have gfsh fail
> on unrecognized options. Thanks!
>
> On Tue, Jul 5, 2016 at 9:57 AM, Kirk Lund  wrote:
>
> > GfshHistoryJUnitTest is now failing after my commit on Friday.
> >
> > The test expects unrecognized options to cause the command to fail.
> >
> > Replacing our forked version of jopt-simple with a released version has
> > caused us to lose the ability to fail any command that contains
> > unrecognized arguments or unrecognized options. The latter could be
> > restored but it currently causes incorrect behavior with auto-complete.
> >
> > I propose changing the test to match the new behavior. My opinion is that
> > this is a better compromise that breaking auto-complete or spending
> further
> > unknown time devising additional workarounds. This is up for discussion
> so
> > please weigh in.
> >
> > -Kirk
> >
> > On Tuesday, July 5, 2016, Anthony Baker  wrote:
> >
> > > Thanks Jinmei!  Can you share with the list the results of your
> > discussion?
> > >
> > > “If it doesn’t happen on the mailing list, it didn’t happen.” [1]
> > > —The Apache Way
> > >
> > > Anthony
> > >
> > > [1] https://community.apache.org/newbiefaq.html
> > >
> > > > On Jul 5, 2016, at 8:50 AM, Jinmei Liao  > > > wrote:
> > > >
> > > > It has something to do with the 7/1 checkin on gfshParser. I'll talk
> to
> > > the
> > > > team about if they want to revert the changes or fix the test if the
> > > change
> > > > is expected.
> > > >
> > > > On Tue, Jul 5, 2016 at 8:28 AM, Jinmei Liao  > > > wrote:
> > > >
> > > >> I'll take a look.
> > > >>
> > > >> On Tue, Jul 5, 2016 at 8:24 AM, Anthony Baker  > > > wrote:
> > > >>
> > > >>> This test is failing pretty regularly.  Any volunteers to take a
> > look?
> > > >>>
> > > >>> Anthony
> > > >>>
> > > >>> On Jul 5, 2016, at 7:20 AM, Apache Jenkins Server <
> > > >>> jenk...@builds.apache.org > wrote:
> > > >>>
> > > >>> geode-core:integrationTest
> > > >>>
> > > >>>
> > >
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest >
> > > >>> testHistoryFileIsCreated FAILED
> > > >>>   org.junit.ComparisonFailure: expected:<[]connect --fake-param...>
> > but
> > > >>> was:<[// [failed] ]connect --fake-param...>
> > > >>>   at org.junit.Assert.assertEquals(Assert.java:115)
> > > >>>   at org.junit.Assert.assertEquals(Assert.java:144)
> > > >>>   at
> > > >>>
> > >
> >
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest.testHistoryFileIsCreated(GfshHistoryJUnitTest.java:75)
> > > >>>
> > > >>>
> > >
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest >
> > > >>> testHistoryFileDoesNotContainPasswords FAILED
> > > >>>   org.junit.ComparisonFailure: expected:<[// [failed] ]connect
> > > >>> --password=*...> but was:<[]connect --password=*...>
> > > >>>   at org.junit.Assert.assertEquals(Assert.java:115)
> > > >>>   at org.junit.Assert.assertEquals(Assert.java:144)
> > > >>>   at
> > > >>>
> > >
> >
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest.testHistoryFileDoesNotContainPasswords(GfshHistoryJUnitTest.java:84)
> > > >>>
> > > >>>
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> Cheers
> > > >>
> > > >> Jinmei
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > Cheers
> > > >
> > > > Jinmei
> > >
> > >
> >
>
>
>
> --
> Cheers
>
> Jinmei
>

Re: update website for WAN, CQ and native client

[Swapnil Bawaskar]

Thanks everyone for chiming in!
These change have been pushed. checkout: http://geode.incubator.apache.org/


On Wed, Jun 22, 2016 at 11:34 AM, Udo Kohlmeyer <ukohlme...@pivotal.io>
wrote:

> +1,
>
> to me "Multi-site" is too rigid. People might forget that this is a
> inter-cluster comms channel. Which would allow them to have many clusters
> running in the same DC, sharing data between them, satisfying the data
> requirements for different systems/applications.
>
>
>
> On 22/06/2016 4:54 AM, Gregory Chase wrote:
>
>> I'm +0 to "Multi-site", but like "multi-cluster" slightly better for two
>> reasons...
>>
>> 1) It comes after "Clustering", showing a ++ more clearly
>> 2) In my opinion its more inclusive of both "multi-site" and also workload
>> partitioning where two clusters might be in the same data center, but have
>> different applications they serve.
>>
>> Thoughts?
>>
>> On Tue, Jun 21, 2016 at 11:49 AM, John Blum <jb...@pivotal.io> wrote:
>>
>> +1
>>>
>>> On Tue, Jun 21, 2016 at 11:43 AM, Swapnil Bawaskar <sbawas...@pivotal.io
>>> >
>>> wrote:
>>>
>>> Take 3: http://i.imgur.com/VUQRw4u.png
>>>> 1. Replaced Redis logo with http://fontawesome.io/icon/plug/
>>>> 2. Changed WAN to Multi-Site.
>>>>
>>>> Thanks!
>>>> Swapnil.
>>>>
>>>> On Sat, Jun 18, 2016 at 7:22 PM, theseusyang <theseusy...@gmail.com>
>>>> wrote:
>>>>
>>>> I agree with Greg, "Multi-Cluster"  is accurated especially for
>>>>> cluster-2-cluster replication in one DC site.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> View this message in context:
>>>>>
>>>>>
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/update-website-for-WAN-CQ-and-native-client-tp6659p6763.html
>>>
>>>> Sent from the Apache Geode (Incubating) Developers Forum mailing list
>>>>> archive at Nabble.com.
>>>>>
>>>>>
>>>
>>> --
>>> -John
>>> 503-504-8657
>>> john.blum10101 (skype)
>>>
>>>
>>
>>
>

Re: [INFO REQUEST] Uploading the podling report

[Swapnil Bawaskar]

Send an email to gene...@incubator.apache.org asking for permissions to the
wiki for uploading the podling report.

On Thu, Jun 30, 2016 at 3:19 PM, Nabarun Nag  wrote:

> Hi,
>
> Thank you all for the reviews.
>
> Can someone please tell me the steps to append the podling report to
> http://wiki.apache.org/incubator/July2016.
>
>
> Regards
> Nabarun Nag
>

Re: M3 status?

[Swapnil Bawaskar]

I have filed https://issues.apache.org/jira/browse/GEODE-1598 which may
have been caused by fixing GEODE-835.

In my opinion GEODE-1598 should be fixed before we release M3.

On Tue, Jun 21, 2016 at 12:04 AM, William Markito <wmark...@pivotal.io>
wrote:

> Just pushed GEODE-33 [1] for review.
>
> [1] https://github.com/apache/incubator-geode/tree/feature/GEODE-33
>
> On Fri, Jun 17, 2016 at 6:05 PM, Kirk Lund <kl...@pivotal.io> wrote:
>
> > Yep, huge thanks to Grace Meilen for finishing up GEODE-835!
> >
> > -Kirk
> >
> > On Friday, June 17, 2016, Swapnil Bawaskar <sbawas...@pivotal.io> wrote:
> >
> > > GEODE-835 has been fixed. Do we have any progress on GEODE-1493?
> > >
> > > On Wed, Jun 15, 2016 at 10:20 AM, Sai Boorlagadda <
> > > sai.boorlaga...@gmail.com <javascript:;>
> > > > wrote:
> > >
> > > > i will give a try fixing GEODE-1493.
> > > >
> > > > Sai
> > > >
> > > > On Wed, Jun 15, 2016 at 10:17 AM, Dan Smith <dsm...@pivotal.io
> > > <javascript:;>> wrote:
> > > >
> > > > > I think we should fix GEODE-1493 for M3 - we shouldn't be shipping
> > > > > foldernames from the release manager's filesystem in the binary
> > > release.
> > > > I
> > > > > can look into it if no one else is interested.
> > > > >
> > > > > -Dan
> > > > >
> > > > > On Wed, Jun 15, 2016 at 10:04 AM, Darrel Schneider <
> > > > dschnei...@pivotal.io <javascript:;>>
> > > > > wrote:
> > > > >
> > > > > > The test failing in GEODE-840 I think is going to be classified
> as
> > > > > "flaky".
> > > > > > It should not hold up the m3 release.
> > > > > >
> > > > > >
> > > > > > On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade <
> > > > aging...@pivotal.io <javascript:;>
> > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > GEODE-1493
> > > > > > > Its not assigned to anyone...Someone with gradle/build
> experience
> > > can
> > > > > > pick
> > > > > > > this upDoesn't seems to be a stopper for M3.
> > > > > > >
> > > > > > > GEODE-835
> > > > > > > In progress, kirk can comment on this.
> > > > > > >
> > > > > > > -Anil.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Jun 15, 2016 at 9:48 AM, Gregory Chase <
> > gch...@pivotal.io
> > > <javascript:;>>
> > > > > > wrote:
> > > > > > >
> > > > > > > > Should GEODE-33 be broken up into specific tickets?
> > > > > > > >
> > > > > > > > What do we want examples for?
> > > > > > > >
> > > > > > > > This might be easier for many of the expert users to actually
> > > make
> > > > > > > > contributions.
> > > > > > > >
> > > > > > > > -Greg
> > > > > > > >
> > > > > > > > On Wed, Jun 15, 2016 at 9:40 AM, Anthony Baker <
> > > aba...@pivotal.io <javascript:;>>
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Hi I reviewed the JIRA’s tagged for the M3 release.  The
> good
> > > > news
> > > > > is
> > > > > > > > that
> > > > > > > > > we’ve fixed 180 issues!  Here are the remaining open
> issues:
> > > > > > > > >
> > > > > > > > > GEODE-33: Project examples
> > > > > > > > > GEODE-835: joptsimple replacement
> > > > > > > > > GEODE-840: CI failure in
> > > > > > > > >
> > > DistributedAckPersistentRegionCCEOffHeapDUnitTest.testTombstones
> > > > > > > > > GEODE-1493: gemfire.properties default value for config dir
> > > > > > > > >
> > > > > > > > > Any sense for when these issues will be resolved?  Which
> ones
> > > are
> > > > > > > > required
> > > > > > > > > for M3?
> > > > > > > > >
> > > > > > > > > Anthony
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Greg Chase
> > > > > > > >
> > > > > > > > Global Head, Big Data Communities
> > > > > > > > http://www.pivotal.io/big-data
> > > > > > > >
> > > > > > > > Pivotal Software
> > > > > > > > http://www.pivotal.io/
> > > > > > > >
> > > > > > > > 650-215-0477
> > > > > > > > @GregChase
> > > > > > > > Blog: http://geekmarketing.biz/
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
>
> ~/William
>

Re: Creating & Destroying Regions programmatically

[Swapnil Bawaskar]

Hi Kevin,
You can use com.gemstone.gemfire.cache.DynamicRegionFactory from the client
to exercise CreateRegion and DestroyRegion.

On Wed, Jun 22, 2016 at 8:43 AM, Kevin Duling  wrote:

> I'm trying to figure out how to exercise the CreateRegion and
> DestoryRegion classes from a client in order to test authorization.  I
> can't figure out what the API would be for a client to trigger the
> cmdExecute() call on the server.
>
> For example, I was able to hit it in ClearRegion by having the client
> execute the Region.clear() method.  Here's a snippet from the unit
> test:
>
> SerializableRunnable clearAuthorized = new SerializableRunnable() {
>   @Override
>   public void run() {
> Cache cache =
> SecurityTestUtils.createCacheClient("authRegionUser", "1234567",
> serverPort, SecurityTestUtils.NO_EXCEPTION);
> final Region region = cache.getRegion(SecurityTestUtils.REGION_NAME);
> region.clear();
> cache.close();
>   }
> };
> client2.invoke(clearAuthorized);
>

Re: update website for WAN, CQ and native client

[Swapnil Bawaskar]

+1
I am convinced.
Made the change: http://i.imgur.com/41w9yWm.png

On Tue, Jun 21, 2016 at 11:54 AM, Gregory Chase <gch...@pivotal.io> wrote:

> I'm +0 to "Multi-site", but like "multi-cluster" slightly better for two
> reasons...
>
> 1) It comes after "Clustering", showing a ++ more clearly
> 2) In my opinion its more inclusive of both "multi-site" and also workload
> partitioning where two clusters might be in the same data center, but have
> different applications they serve.
>
> Thoughts?
>
> On Tue, Jun 21, 2016 at 11:49 AM, John Blum <jb...@pivotal.io> wrote:
>
> > +1
> >
> > On Tue, Jun 21, 2016 at 11:43 AM, Swapnil Bawaskar <sbawas...@pivotal.io
> >
> > wrote:
> >
> > > Take 3: http://i.imgur.com/VUQRw4u.png
> > > 1. Replaced Redis logo with http://fontawesome.io/icon/plug/
> > > 2. Changed WAN to Multi-Site.
> > >
> > > Thanks!
> > > Swapnil.
> > >
> > > On Sat, Jun 18, 2016 at 7:22 PM, theseusyang <theseusy...@gmail.com>
> > > wrote:
> > >
> > > > I agree with Greg, "Multi-Cluster"  is accurated especially for
> > > > cluster-2-cluster replication in one DC site.
> > > >
> > > >
> > > >
> > > > --
> > > > View this message in context:
> > > >
> > >
> >
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/update-website-for-WAN-CQ-and-native-client-tp6659p6763.html
> > > > Sent from the Apache Geode (Incubating) Developers Forum mailing list
> > > > archive at Nabble.com.
> > > >
> > >
> >
> >
> >
> > --
> > -John
> > 503-504-8657
> > john.blum10101 (skype)
> >
>
>
>
> --
> Greg Chase
>
> Global Head, Big Data Communities
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>

Re: update website for WAN, CQ and native client

[Swapnil Bawaskar]

Take 3: http://i.imgur.com/VUQRw4u.png
1. Replaced Redis logo with http://fontawesome.io/icon/plug/
2. Changed WAN to Multi-Site.

Thanks!
Swapnil.

On Sat, Jun 18, 2016 at 7:22 PM, theseusyang  wrote:

> I agree with Greg, "Multi-Cluster"  is accurated especially for
> cluster-2-cluster replication in one DC site.
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/update-website-for-WAN-CQ-and-native-client-tp6659p6763.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>

Re: M3 status?

[Swapnil Bawaskar]

GEODE-835 has been fixed. Do we have any progress on GEODE-1493?

On Wed, Jun 15, 2016 at 10:20 AM, Sai Boorlagadda  wrote:

> i will give a try fixing GEODE-1493.
>
> Sai
>
> On Wed, Jun 15, 2016 at 10:17 AM, Dan Smith  wrote:
>
> > I think we should fix GEODE-1493 for M3 - we shouldn't be shipping
> > foldernames from the release manager's filesystem in the binary release.
> I
> > can look into it if no one else is interested.
> >
> > -Dan
> >
> > On Wed, Jun 15, 2016 at 10:04 AM, Darrel Schneider <
> dschnei...@pivotal.io>
> > wrote:
> >
> > > The test failing in GEODE-840 I think is going to be classified as
> > "flaky".
> > > It should not hold up the m3 release.
> > >
> > >
> > > On Wed, Jun 15, 2016 at 10:02 AM, Anilkumar Gingade <
> aging...@pivotal.io
> > >
> > > wrote:
> > >
> > > > GEODE-1493
> > > > Its not assigned to anyone...Someone with gradle/build experience can
> > > pick
> > > > this upDoesn't seems to be a stopper for M3.
> > > >
> > > > GEODE-835
> > > > In progress, kirk can comment on this.
> > > >
> > > > -Anil.
> > > >
> > > >
> > > >
> > > > On Wed, Jun 15, 2016 at 9:48 AM, Gregory Chase 
> > > wrote:
> > > >
> > > > > Should GEODE-33 be broken up into specific tickets?
> > > > >
> > > > > What do we want examples for?
> > > > >
> > > > > This might be easier for many of the expert users to actually make
> > > > > contributions.
> > > > >
> > > > > -Greg
> > > > >
> > > > > On Wed, Jun 15, 2016 at 9:40 AM, Anthony Baker 
> > > > wrote:
> > > > >
> > > > > > Hi I reviewed the JIRA’s tagged for the M3 release.  The good
> news
> > is
> > > > > that
> > > > > > we’ve fixed 180 issues!  Here are the remaining open issues:
> > > > > >
> > > > > > GEODE-33: Project examples
> > > > > > GEODE-835: joptsimple replacement
> > > > > > GEODE-840: CI failure in
> > > > > > DistributedAckPersistentRegionCCEOffHeapDUnitTest.testTombstones
> > > > > > GEODE-1493: gemfire.properties default value for config dir
> > > > > >
> > > > > > Any sense for when these issues will be resolved?  Which ones are
> > > > > required
> > > > > > for M3?
> > > > > >
> > > > > > Anthony
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Greg Chase
> > > > >
> > > > > Global Head, Big Data Communities
> > > > > http://www.pivotal.io/big-data
> > > > >
> > > > > Pivotal Software
> > > > > http://www.pivotal.io/
> > > > >
> > > > > 650-215-0477
> > > > > @GregChase
> > > > > Blog: http://geekmarketing.biz/
> > > > >
> > > >
> > >
> >
>

Re: update website for WAN, CQ and native client

[Swapnil Bawaskar]

Thanks for the feedback. Here is take 2: http://i.imgur.com/gmsHomO.png

On Thu, Jun 16, 2016 at 10:59 AM, John Blum <jb...@pivotal.io> wrote:

> @Swap-
>
> Perhaps we should mention Geode also supports *Redis* and *Memcached*
> clients (through the respective protocols) as well, though we do not
> develop dedicated clients for either.
>
> Thoughts on how to best represent that?
>
> -John
>
>
> On Thu, Jun 16, 2016 at 5:51 AM, Jacob Barrett <jbarr...@pivotal.io>
> wrote:
>
> > -1
> >
> > I would not mention native clients yet since they aren't anywhere near a
> > state to be built and used.
> > On Thu, Jun 16, 2016 at 5:32 AM yang theseus <theseusy...@gmail.com>
> > wrote:
> >
> > > +1 great!
> > >
> > > 2016-06-16 15:14 GMT+08:00 Gregory Chase <gch...@pivotal.io>:
> > >
> > > > +1
> > > >
> > > > On Wed, Jun 15, 2016 at 11:27 PM, Swapnil Bawaskar <
> > sbawas...@pivotal.io
> > > >
> > > > wrote:
> > > >
> > > > > Hi,
> > > > > WAN and CQ were the major features of M2 release[1]. Also, Native
> > > client
> > > > > has been donated to apache [2]. Considering these new features, I
> > would
> > > > > like to update the geode website [3] <
> > > http://geode.incubator.apache.org/
> > > > >
> > > > > and add these new features as captured in this image [4]
> > > > > <http://i.imgur.com/3Jad68K.png>.
> > > > >
> > > > > Thanks!
> > > > > Swapnil.
> > > > >
> > > > > [1]
> > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12334709
> > > > > [2]
> > > > >
> > > > >
> > > >
> > >
> >
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201605.mbox/%3CCAEwge-ENhF4s_k5Y%3Dh9-mNFANb777j8bNDe4U9jahPYim61pfg%40mail.gmail.com%3E
> > > > > [3] http://geode.incubator.apache.org/
> > > > > [4] http://i.imgur.com/3Jad68K.png
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Greg Chase
> > > >
> > > > Global Head, Big Data Communities
> > > > http://www.pivotal.io/big-data
> > > >
> > > > Pivotal Software
> > > > http://www.pivotal.io/
> > > >
> > > > 650-215-0477
> > > > @GregChase
> > > > Blog: http://geekmarketing.biz/
> > > >
> > >
> >
>
>
>
> --
> -John
> 503-504-8657
> john.blum10101 (skype)
>

update website for WAN, CQ and native client

[Swapnil Bawaskar]

Hi,
WAN and CQ were the major features of M2 release[1]. Also, Native client
has been donated to apache [2]. Considering these new features, I would
like to update the geode website [3] 
and add these new features as captured in this image [4]
.

Thanks!
Swapnil.

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12334709
[2]
http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201605.mbox/%3CCAEwge-ENhF4s_k5Y%3Dh9-mNFANb777j8bNDe4U9jahPYim61pfg%40mail.gmail.com%3E
[3] http://geode.incubator.apache.org/
[4] http://i.imgur.com/3Jad68K.png

Re: add 'ZeroCopy' functions into geode

[Swapnil Bawaskar]

In Geode latest data is in memory and the least recently used data can be
overflowed to disk. Since data coming in from the sockets is the latest
data which needs to kept in memory, I don't think zero copy will be
helpful. On the other hand, when there is a read request for data already
overflown to disk, we could use zero copy to write directly from disk to
the socket.

I think we could make storing data in "off-heap" work while inserting data;
provided there are no callbacks to be invoked.

On Wed, Jun 8, 2016 at 6:50 PM, theseusyang  wrote:

> Hi All,
>
> Because when Geode continue writing Entry into cache , then frequently
> switching Cache Context to Disk File Context, it seriously affect
> performance , cause high-latency response.
>
> Maybe 'Zero Copy' is a referenced solutions, Any body is interested in this
> feature?
>
>
> theseus yang
>
>
>
> --
> View this message in context:
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/add-ZeroCopy-functions-into-geode-tp6513.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48187/#review136005
---


Ship it!




Ship It!

- Swapnil Bawaskar


On June 2, 2016, 9:33 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48187/
> ---
> 
> (Updated June 2, 2016, 9:33 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1491
> https://issues.apache.org/jira/browse/GEODE-1491
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Make sure when checking if a transaction is completed from 
> isHostedTxRecentlyCompleted() method, the rolled back transaction is 
> considered as well.
> Added a unit test that would fail without the fix and pass with the fix.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java
>  df0176d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java
>  9c54587 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/RollbackCommand.java
>  ed7c706 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java
>  a4b8127 
> 
> Diff: https://reviews.apache.org/r/48187/diff/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: [gemfire-mm] Re: Region Permission

[Swapnil Bawaskar]

If I have read permissions on a region, I would expect "describe region" to
work.
I could live with a "permission denied" for "list region", however, it
would be nice to get a list of all regions I have permissions for.

On Thu, May 19, 2016 at 10:44 AM, Michael Stolz  wrote:

> Permission denied is fine if CLUSTER:READ is disallowed.
>
> The regions returned should be those regions he has access to.
>
> Data Administrator should have access to all regions.
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771
> On May 19, 2016 12:22 PM, "Jinmei Liao"  wrote:
>
>> I want to get some clarification on what permission is need to guard the
>> operation of "list regions" and "describe region".
>>
>> Currently anyone that has "CLUSTER:READ" are able to execute those two
>> commands, regardless whether he has "READ/WRITE/MANAGE" permissions to the
>> regions. And if a user only has read permission for a specific region,
>> when
>> he goes to execute "list regions", he will get a "permission denied"
>> message instead of seeing a list of regions that he has access to. Is this
>> the expected behavior? Or a better question is: what is the expected
>> behavior?
>>
>> --
>> Cheers
>>
>> Jinmei
>>
>

Re: Interest in contributing to a bi temporal framework

[Swapnil Bawaskar]

Hi Maarten,

Glad to hear that you found my presentation useful, and that you would like
to contribute to Geode!

In Geode, transactions are not allowed to cross JVM boundary. (They are
replicated, not distributed). This means that you will have to co-locate
your data

such that you will be able to run transactions on it. Given this
restriction, clock skew will never be an issue. Having said that, we want
to support fully distributed transactions in Geode
. To make queries work well
with transactions, I was hoping to implement MVCC as part of this effort.
Supporting bi temporal data in Geode is one more argument for implementing
MVCC.

Looking forward to having more discussions.

-Swapnil.


On Wed, May 18, 2016 at 10:42 AM, Michael Stolz  wrote:

> This is largely handled for us by the Geode Partitioned Region mechanics
> already.
>
> On a Partitioned Region, there is always a notion of a primary server for
> any given key, and some number of secondaries. All writes are always sent
> to the primary node, who locally locks the entry, then stores the data into
> the entry, and then distributes the update to all of the secondary servers.
>
> I expect that some of the implementation of temporal data access will be
> delegated to a CacheWriter or the GemFire Function Execution Service either
> of which will execute only on the primary server for a given entry. They
> can install the current local server-side timestamp into the entry even
> before it is made visible in the cache, and then let the normal Geode
> caching mechanics do all the rest.
>
>
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771
>
> On Tue, May 17, 2016 at 3:28 PM, Maarten Niederer  >
> wrote:
>
> > Hi Mike,
> >
> >
> >
> > All right, I’ll start doing my ‘homework’ in order to get myself
> > familiarized with the Geode codebase.
> >
> >
> >
> > At present I do not wish to learn your ideas as this may cloud my own
> > creative thinking process. So we’ll discuss later on that.
> >
> >
> >
> > Are you having any concrete timelines on this project right now ?
> >
> >
> >
> > Also I’d like to learn your views on my last question, which I will
> > elaborate a bit more.
> >
> >
> >
> > Suppose two transactions (A, B) are executed on two different nodes which
> > have a deviation in system time. Also there is a third process (R) which
> > reads data that is affected by both transactions (which will also
> ‘commit’
> > it’s reads in order to be sure to read a consistent state).
> >
> >
> >
> > In real time the execution order is A à R à B, but due to system time
> > deviation the order of transactions is logged the other way around. As a
> > consequence one can’t reconstruct the read state of R. The only way
> around
> > it, which I can think of given my limited knowledge on distributed
> > transaction, is to take a global lock (which is not an option in my
> > opinion).
> >
> >
> >
> > Can anyone think a better solution than keeping system times as close as
> > possible together and accepting that there may happen conditions which
> > cause
> > that you can’t construct the read state of R?
> >
> >
> >
> > Maarten,
> >
> >
> >
> > I would be interested in spending some cycles thinking through how to
> best
> >
> > implement bi-temporality in Geode. I have implemented bi-temporality
> using
> >
> > several traditional databases, and I have some ideas how to implement
> both
> >
> > time-series and bi-temporal data in Geode, but it would be interesting to
> >
> > have someone who really knows the subject matter well to work with.
> >
> >
> >
> > --
> >
> > Mike Stolz
> >
> > Principal Engineer, GemFire Product Manager
> >
> > Mobile: 631-835-4771
> >
> >
> >
> > On Sun, May 15, 2016 at 6:18 PM, Maarten Niederer <
> >  maar...@burgemeestre.nl>
> >
> > wrote:
> >
> >
> >
> > Hi guys,
> >
> >
> >
> > I'm considering to contribute to the Geode project. My attention is drawn
> >
> > because of the desire to create a bi temporal framework in a distributed
> >
> > database system. This should provide me nice engineering challenges.
> >
> >
> >
> > At my present employer I have worked with and developed an application
> that
> >
> > implements a bi temporal framework within the application layer build on
> >
> > top
> >
> > of an old school RDBMS. I have done a lot development with temporal logic
> >
> > (value time). For example, I've implemented several  SQL operations (e.g.
> >
> > outer joins, group/aggregate) in a temporal way (e.g. find me the
> intervals
> >
> > in time when more developers than managers worked at company X given the
> >
> > temporal data on when people started/stopped working and their
> >
> > professions).
> >
> > Also I've been busy with implementing the procedure 

Re: Geode Portfile for Mac Ports

[Swapnil Bawaskar]

nice!

On Tue, May 17, 2016 at 2:05 PM, Dan Smith  wrote:

> Awesome!
>
> -Dan
>
> On Tue, May 17, 2016 at 1:23 PM, Kevin Duling  wrote:
>
> > Using the geode.rb file for Homebrew as a template, I was able to build a
> > Portfile for macports.org.
> >
> > Does anyone have any feedback before I submit it to the macports repo?
> No
> > code changes were necessary and it is using the same binary image the
> > Homebrew version is.  I've tested it as far as "Geode in 5 minutes" takes
> > you.
> >
> > I classified it under 'databases' as that is where the cassandra port
> > lives.
> >
> > The following is some output from running it.  It properly goes out and
> > locates a mirror to pull the tarball from.
> >
> > kduling@kduling-mbpro:*~/tmp/ports*$ port info geode
> >> geode @1.0.0-incubating.M2 (databases)
> >> Description:  Apache Geode (incubating) is a data management
> >> platform that provides real-time, consistent access to data-intensive
> >> applications throughout widely distributed cloud
> >>   architectures.
> >> Homepage: https://geode.apache.org/
> >> Platforms:darwin
> >> License:  Apache-2
> >
> >
> > kduling@kduling-mbpro:*~/tmp/ports*$ sudo port install geode
> >> --->  Fetching archive for geode
> >> --->  Attempting to fetch
> >> geode-1.0.0-incubating.M2_0.darwin_15.noarch.tbz2 from
> >> http://sea.us.packages.macports.org/macports/packages/geode
> >> --->  Attempting to fetch
> >> geode-1.0.0-incubating.M2_0.darwin_15.noarch.tbz2 from
> >> https://packages.macports.org/geode
> >> --->  Attempting to fetch
> >> geode-1.0.0-incubating.M2_0.darwin_15.noarch.tbz2 from
> >> http://mse.uk.packages.macports.org/sites/packages.macports.org/geode
> >> --->  Fetching distfiles for geode
> >> --->  Verifying checksums for geode
> >> --->  Extracting geode
> >> --->  Configuring geode
> >> --->  Building geode
> >> --->  Staging geode into destroot
> >> --->  Installing geode @1.0.0-incubating.M2_0
> >> --->  Activating geode @1.0.0-incubating.M2_0
> >> Please refer to http://geode.incubator.apache.org/docs/
> >> --->  Cleaning geode
> >> --->  Updating database of binaries
> >>
> >
> >
> >> kduling@kduling-mbpro:*~/tmp/ports*$ gfsh
> >> _ __
> >>/ _/ __/ __/ // /
> >>   / /  __/ /___  /_  / _  /
> >>  / /__/ / /  _/ / // /
> >> /__/_/  /__/_//_/v1.0.0-incubating.M2
> >> Monitor and Manage Apache Geode (incubating)
> >> gfsh>quit
> >> Exiting...
> >>
> >
> >
> >> kduling@kduling-mbpro:*~/tmp/ports*$ which gfsh
> >> /opt/local/bin/gfsh
> >> kduling@kduling-mbpro:*~/tmp/ports*$ sudo port uninstall geode
> >> --->  Deactivating geode @1.0.0-incubating.M2_0
> >> --->  Cleaning geode
> >> --->  Uninstalling geode @1.0.0-incubating.M2_0
> >> --->  Cleaning geode
> >> kduling@kduling-mbpro:*~/tmp/ports*$ which gfsh
> >> kduling@kduling-mbpro:*~/tmp/ports*$
> >
> >
>

Re: [VOTE] RC2: Apache Geode (Incubating) second Milestone release - v1.0.0-incubating.M2

[Swapnil Bawaskar]

+1
provided we add a comment to the jira with the workaround.

On Thu, Apr 14, 2016 at 2:39 PM, Jens Deppe <jde...@pivotal.io> wrote:

> Dan and I spoke about this. Just briefly looking at the issue, it would
> seem that a workaround for anyone seeing this, would be to simply add the
> necessary jar(s) on the classpath. Given that, it's probably not sufficient
> to hold up the release.
>
> --Jens
>
> On Thu, Apr 14, 2016 at 12:40 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
> wrote:
>
> > How do we want to handle regressions?
> > I think we are seeing GEODE-1203
> > <https://issues.apache.org/jira/browse/GEODE-1203> (gfsh connect
> > --use-http
> > reports a ClassNotFoundException) after the changes for bundled jar
> > dependencies. This particular issue has no tests, but it was working in
> M1
> > release. I think we should treat this as a required fix.
> >
> > On Thu, Apr 14, 2016 at 11:02 AM, Xiaojian Zhou <gz...@pivotal.io>
> wrote:
> >
> > > +1
> > >
> > > On Wed, Apr 13, 2016 at 3:55 PM, Dan Smith <dsm...@pivotal.io> wrote:
> > >
> > > > This is second release candidate for Apache Geode, version
> > > > 1.0.0-incubating.M1.
> > > >
> > > > *** Please download, test and vote by Monday, Apr 18, 0800 PST
> > > >
> > > > If you are wondering why you didn't see RC1, it's because I caught a
> > > > mistake after I created the tag but before sending out the vote.
> Thanks
> > > for
> > > > all the hard work going into this milestone!
> > > >
> > > > It fixes the following issues:
> > > >
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12334709
> > > >
> > > > Note that we are voting upon the source (tag):
> > > > rel/v1.0.0-incubating.M2.RC2
> > > >
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
> > > >
> > > > Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
> > > >
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
> > > >
> > > > Source and binary files:
> > > >
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
> > > > <
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/geode
> > > > >
> > > >
> > > > Maven staging repo:
> > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachegeode-1004/
> > > > <
> > https://repository.apache.org/content/repositories/orgapachegeode-1001/
> > > >
> > > >
> > > > Geode's KEYS file containing PGP keys we use to sign the release:
> > > >
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
> > > > Release Key: pub   4096R/A1688D97 2016-01-20
> > > > Fingerprint: 1776 0439 68F0 FD83 62C7  2CCF 444C 1D20 A168 8D97
> > > >
> > > > Thanks,
> > > > Dan Smith
> > > >
> > >
> >
>

Re: [VOTE] RC2: Apache Geode (Incubating) second Milestone release - v1.0.0-incubating.M2

[Swapnil Bawaskar]

How do we want to handle regressions?
I think we are seeing GEODE-1203
 (gfsh connect --use-http
reports a ClassNotFoundException) after the changes for bundled jar
dependencies. This particular issue has no tests, but it was working in M1
release. I think we should treat this as a required fix.

On Thu, Apr 14, 2016 at 11:02 AM, Xiaojian Zhou  wrote:

> +1
>
> On Wed, Apr 13, 2016 at 3:55 PM, Dan Smith  wrote:
>
> > This is second release candidate for Apache Geode, version
> > 1.0.0-incubating.M1.
> >
> > *** Please download, test and vote by Monday, Apr 18, 0800 PST
> >
> > If you are wondering why you didn't see RC1, it's because I caught a
> > mistake after I created the tag but before sending out the vote. Thanks
> for
> > all the hard work going into this milestone!
> >
> > It fixes the following issues:
> >
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12334709
> >
> > Note that we are voting upon the source (tag):
> > rel/v1.0.0-incubating.M2.RC2
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
> >
> > Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
> >
> > Source and binary files:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
> > <
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/geode
> > >
> >
> > Maven staging repo:
> >
> > https://repository.apache.org/content/repositories/orgapachegeode-1004/
> >  >
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
> > Release Key: pub   4096R/A1688D97 2016-01-20
> > Fingerprint: 1776 0439 68F0 FD83 62C7  2CCF 444C 1D20 A168 8D97
> >
> > Thanks,
> > Dan Smith
> >
>

Re: Release branch for M2

[Swapnil Bawaskar]

+1

On Mon, Apr 11, 2016 at 2:13 PM, William Markito 
wrote:

> +1
>
> On Mon, Apr 11, 2016 at 2:06 PM Anthony Baker  wrote:
>
> > Sounds good to me!
> >
> > > On Apr 11, 2016, at 10:18 AM, Dan Smith  wrote:
> > >
> > > All of the issues marked for M2 are now done. I will cut a release
> branch
> > > for M2 today unless there are any objections.
> > >
> >
> > --
> ~/William
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[Swapnil Bawaskar]

I have merged-in my pull requests in the past. So, I think you can too.
Just follow the instructions in "Accepting the Pull-request" section on
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions

On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba  wrote:

> Any takers for merging this in? Don't think I could as I created the pull
> request :)
>
> Thanks,
> Nitin
>
> On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda  wrote:
>
> > Github user sboorlagadda commented on the pull request:
> >
> >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> >
> > +1
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>

Re: Incubator status report on wiki?

[Swapnil Bawaskar]

I have added the April 2016 report:
https://cwiki.apache.org/confluence/display/GEODE/Community+development

On Fri, Apr 8, 2016 at 2:50 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
wrote:

> Sure! I will add it to the geode wiki too.
>
> On Fri, Apr 8, 2016 at 2:29 PM, William Markito <wmark...@pivotal.io>
> wrote:
>
>> Yup, all the reports usually are stored in the Community Development page
>> as well as in the Incubator wiki -
>> https://cwiki.apache.org/confluence/display/GEODE/Community+development
>>
>> On Fri, Apr 8, 2016 at 1:07 PM Greg Chase <gch...@gmail.com> wrote:
>>
>> > Yes please 
>> >
>> > This email encrypted by tiny buttons & fat thumbs, beta voice
>> recognition,
>> > and autocorrect on my iPhone.
>> >
>> > > On Apr 8, 2016, at 1:05 PM, Michael Stolz <mst...@pivotal.io> wrote:
>> > >
>> > > Should the geode incubator status report be posted on the geode wiki
>> > under
>> > > "Incubation Status Reports"?
>> > >
>> > > --
>> > > Mike Stolz
>> > > Principal Engineer, GemFire Product Manager
>> > > Mobile: 631-835-4771
>> >
>> --
>> ~/William
>>
>
>

Re: Incubator status report on wiki?

[Swapnil Bawaskar]

Sure! I will add it to the geode wiki too.

On Fri, Apr 8, 2016 at 2:29 PM, William Markito  wrote:

> Yup, all the reports usually are stored in the Community Development page
> as well as in the Incubator wiki -
> https://cwiki.apache.org/confluence/display/GEODE/Community+development
>
> On Fri, Apr 8, 2016 at 1:07 PM Greg Chase  wrote:
>
> > Yes please 
> >
> > This email encrypted by tiny buttons & fat thumbs, beta voice
> recognition,
> > and autocorrect on my iPhone.
> >
> > > On Apr 8, 2016, at 1:05 PM, Michael Stolz  wrote:
> > >
> > > Should the geode incubator status report be posted on the geode wiki
> > under
> > > "Incubation Status Reports"?
> > >
> > > --
> > > Mike Stolz
> > > Principal Engineer, GemFire Product Manager
> > > Mobile: 631-835-4771
> >
> --
> ~/William
>

Re: Bundled jar dependencies

[Swapnil Bawaskar]

With the latest revision: dd9e5af4b4324e5511d170238f6532217384e15b
I can't even start gfsh. I get this message:

$ ./bin/gfsh
Required (Spring Core) libraries not found in the classpath. gfsh can't
start.

On Fri, Apr 8, 2016 at 11:00 AM, Jinmei Liao  wrote:

> Looks like the error is due to the fact that geode-dependencies.jar and
> gfsh-dependencies.jar includes both spring-core versions in it's classpath,
> and it fails to find ResolvableTypeProvider.java which only exists in the
> later version. I tried turning off the transitive dependency of
> spring-shell, and only include the spring-core-4.2.4.RELEASE in the
> classpath, then the locator started with no errors.
>
> On Fri, Apr 8, 2016 at 10:00 AM, Jinmei Liao  wrote:
>
> > On a similar note, I just did a pull from develop and ran a clean
> > installDist.  When I tried to start a locator in GFSH, I got the
> following
> > error in the log file:
> >
> > [error 2016/04/08 09:53:12.979 PDT locator1 
> > tid=0x27] Jmx manager could not be started because HTTP service failed to
> > start
> >
> > com.gemstone.gemfire.management.ManagementException: HTTP service failed
> > to start
> >
> > at
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:279)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startAgent(ManagementAgent.java:125)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.SystemManagementService.startManager(SystemManagementService.java:475)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.JmxManagerLocator.findJmxManager(JmxManagerLocator.java:104)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.JmxManagerLocator.processRequest(JmxManagerLocator.java:57)
> >
> > at
> >
> com.gemstone.gemfire.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
> >
> > at
> >
> com.gemstone.gemfire.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:386)
> >
> > at
> >
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> >
> > at
> >
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> >
> > at java.lang.Thread.run(Thread.java:745)
> >
> > Caused by: MultiException[java.lang.NoClassDefFoundError:
> > org/springframework/core/ResolvableTypeProvider, java.net.BindException:
> > Address already in use]
> >
> > at org.eclipse.jetty.server.Server.doStart(Server.java:347)
> >
> > at
> >
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.JettyHelper.startJetty(JettyHelper.java:147)
> >
> > at
> >
> com.gemstone.gemfire.management.internal.ManagementAgent.startHttpService(ManagementAgent.java:251)
> >
> > ... 9 more
> >
> > Suppressed: java.net.BindException: Address already in use
> >
> > at sun.nio.ch.Net.bind0(Native Method)
> >
> > at sun.nio.ch.Net.bind(Net.java:433)
> >
> > at sun.nio.ch.Net.bind(Net.java:425)
> >
> > at
> > sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
> >
> > at
> > sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
> >
> > at
> > org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:326)
> >
> > at
> >
> org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
> >
> > at
> >
> org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:244)
> >
> > at
> >
> org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
> >
> > at
> org.eclipse.jetty.server.Server.doStart(Server.java:384)
> >
> > ... 12 more
> >
> > Caused by: java.lang.NoClassDefFoundError:
> > org/springframework/core/ResolvableTypeProvider
> >
> > at java.lang.ClassLoader.defineClass1(Native Method)
> >
> > at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
> >
> > at
> > java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> >
> > at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> >
> > at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
> >
> > at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
> >
> > at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
> >
> > at java.security.AccessController.doPrivileged(Native Method)
> >
> > at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
> >
> > at
> >
> org.eclipse.jetty.webapp.WebAppClassLoader.findClass(WebAppClassLoader.java:549)
> >
> > at
> >
> 

Re: Podling Report Reminder - April 2016

[Swapnil Bawaskar]

Thanks for the feedback Roman, It seems that the wiki is down, I will make
the following changes once the wiki is back.

Three most important issues to address in the move towards graduation:

  1. Rename packages to org.apache
  2. Expanding the community to include contributors and committers outside
 of Pivotal.
  3. Establish a release cadence.


On Wed, Apr 6, 2016 at 6:54 PM, Roman Shaposhnik <ro...@shaposhnik.org>
wrote:

> On Wed, Apr 6, 2016 at 6:14 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
> wrote:
> > Since the report is due today, I went ahead and updated the wiki
> > https://wiki.apache.org/incubator/April2016.
> > Let me know if anything needs to change while I can still change it :)
>
> Swapnil, this is totally fine and in fact appreciated!
>
> One suggest I have is for the sections
>   Three most important issues to address in the move towards graduation
> as a mentor I'd like to see at least a few more releases
> done by the community before it can graduate and, of course,
> community growth (especially around on-boarding folks outsite
> of Pivotal) in general.
>
> I think it'd be fair to add those to the section.
>
> The reset looks great!
>
> Thanks,
> Roman.
>

Re: Podling Report Reminder - April 2016

[Swapnil Bawaskar]

Since the report is due today, I went ahead and updated the wiki
https://wiki.apache.org/incubator/April2016.
Let me know if anything needs to change while I can still change it :)

Thanks!

On Wed, Apr 6, 2016 at 6:01 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
wrote:

> I have incorporated these suggestions (in bold)
>
> How has the community developed since the last report?
> - We have been able to address the “Three most important issues to move
> towards graduation” from the previous report
>   1. We had out first public release
>   2. We Added 4 new committers, one of which is outside Pivotal
>   3. We are about to have a second release, establishing a regular release
> cadence
> - We had a GeodeSummit http://geodesummit.com/
>   - 22 sessions (including Keynote)
>   - Sessions included current use cases as well as integrations with other
> Apache projects
>   - Over 100 attendees
>   - *Received project proposal after the summit.*
> - The Geode Clubhouse hosted a meeting covering A walk through the
> different approaches for caching data in a Spring based application with
> Apache Geode by Luke Shannon
> - The breakdown of JIRA tickets is the following:
>   Q3 / 2015 - 65 created, 19 resolved.
>   Q4 / 2015 - 342 created, 227 resolved.
>   Q1 / 2016 - 438 created, 362 resolved.
>   Q2 / 2016 - 8 created, 12 resolved (As of Apr 4th)
> - There was a total of 123 pull requests on GitHub with 6 still open.
> - The breakdown of the mailing lists messages for January, Feb, March of
> 2016:
>   org.apache.geode.issues 4300
>   org.apache.geode.commits 3731
>   org.apache.geode.dev 2154
>   org.apache.geode.user 294
> - There are now 153 subscribers on the dev and 145 on the user mailing
> lists.
> - Community events:
>   - January 2016:
> -  FOSDEM 2016 in Brussels:
> - Taxi trip analysis (DEBS grand-challenge) with Apache Geode
> (incubating)
> - Big Data meets Fast Data: an scalable hybrid real-time transactional
> and analytics solution
>   - February 2016:
> - Seattle Java User’s Group (Talk about Introduction to Apache Geode)
>
>
>
> *  - March 2016:- Geode Summit in Palo Alto, California- Geode
> meetup in Palo Alto
> (http://www.meetup.com/Pivotal-Open-Source-Hub/events/228983898/
> <http://www.meetup.com/Pivotal-Open-Source-Hub/events/228983898/>)-
> Apache Apex (incubating) meetup featuring Geode integration
> (http://www.meetup.com/Apex-Bay-Area-Chapter/events/228593080/
> <http://www.meetup.com/Apex-Bay-Area-Chapter/events/228593080/>)*
>
> How has the project developed since the last report?
> - Had first release, close to the second release (with 134 out of 138
> issues resolved)
>
>
>
>
>
>
> *- We elected a release manager for the first release and have rotated
> that responsibility for the second release- Had a discussion about how to
> number the releases- Voted on the Release candidates, rejected the first
> but the second release candidate was voted as the final release- The
> community discussed the criteria for becoming a committer and learned the
> correct way of nominating new committers.- JIRA components were refined
> after a discussion on the mailing list.- Consensus was achieved for the
> scope for the releases on the mailing list.- Decision was made not to
> rename the command line tool on the mailing list.*
> - Each commit and pull request is run through CI using Travis CI
> - Removed @author tags
> - First release published to maven central
> - Javadocs hosted on the project website.
>
>
> On Wed, Apr 6, 2016 at 5:32 PM, Sai Boorlagadda <sai.boorlaga...@gmail.com
> > wrote:
>
>> I think "Pluggable storage" is initiated after Geode Summit.
>>
>> On Wed, Apr 6, 2016 at 5:27 PM, Roman Shaposhnik <ro...@shaposhnik.org>
>> wrote:
>>
>> > On Wed, Apr 6, 2016 at 5:22 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
>> > wrote:
>> > > I found the following"Shepherd/Mentor notes" for our previous report
>> > > <https://wiki.apache.org/incubator/January2016>:
>> > >
>> > > For the next report: for me as a mentor (and perhaps for others on
>> > IPMC)
>> > > it is not very insightful to see the number of pull requests or
>> JIRAs
>> > > opened. It isn't what "project development" constitutes in my
>> mind. I
>> > > would like to see more info about how project is getting into
>> Apache
>> > > Way,
>> > > what important discussions are held, what decisions are made
>> through
>> > > community consensus, etc.
>> >
>> > Tha

Re: Podling Report Reminder - April 2016

[Swapnil Bawaskar]

I have incorporated these suggestions (in bold)

How has the community developed since the last report?
- We have been able to address the “Three most important issues to move
towards graduation” from the previous report
  1. We had out first public release
  2. We Added 4 new committers, one of which is outside Pivotal
  3. We are about to have a second release, establishing a regular release
cadence
- We had a GeodeSummit http://geodesummit.com/
  - 22 sessions (including Keynote)
  - Sessions included current use cases as well as integrations with other
Apache projects
  - Over 100 attendees
  - *Received project proposal after the summit.*
- The Geode Clubhouse hosted a meeting covering A walk through the
different approaches for caching data in a Spring based application with
Apache Geode by Luke Shannon
- The breakdown of JIRA tickets is the following:
  Q3 / 2015 - 65 created, 19 resolved.
  Q4 / 2015 - 342 created, 227 resolved.
  Q1 / 2016 - 438 created, 362 resolved.
  Q2 / 2016 - 8 created, 12 resolved (As of Apr 4th)
- There was a total of 123 pull requests on GitHub with 6 still open.
- The breakdown of the mailing lists messages for January, Feb, March of
2016:
  org.apache.geode.issues 4300
  org.apache.geode.commits 3731
  org.apache.geode.dev 2154
  org.apache.geode.user 294
- There are now 153 subscribers on the dev and 145 on the user mailing
lists.
- Community events:
  - January 2016:
-  FOSDEM 2016 in Brussels:
- Taxi trip analysis (DEBS grand-challenge) with Apache Geode
(incubating)
- Big Data meets Fast Data: an scalable hybrid real-time transactional
and analytics solution
  - February 2016:
- Seattle Java User’s Group (Talk about Introduction to Apache Geode)



*  - March 2016:- Geode Summit in Palo Alto, California- Geode
meetup in Palo Alto
(http://www.meetup.com/Pivotal-Open-Source-Hub/events/228983898/
<http://www.meetup.com/Pivotal-Open-Source-Hub/events/228983898/>)-
Apache Apex (incubating) meetup featuring Geode integration
(http://www.meetup.com/Apex-Bay-Area-Chapter/events/228593080/
<http://www.meetup.com/Apex-Bay-Area-Chapter/events/228593080/>)*

How has the project developed since the last report?
- Had first release, close to the second release (with 134 out of 138
issues resolved)






*- We elected a release manager for the first release and have rotated that
responsibility for the second release- Had a discussion about how to number
the releases- Voted on the Release candidates, rejected the first but the
second release candidate was voted as the final release- The community
discussed the criteria for becoming a committer and learned the correct way
of nominating new committers.- JIRA components were refined after a
discussion on the mailing list.- Consensus was achieved for the scope for
the releases on the mailing list.- Decision was made not to rename the
command line tool on the mailing list.*
- Each commit and pull request is run through CI using Travis CI
- Removed @author tags
- First release published to maven central
- Javadocs hosted on the project website.


On Wed, Apr 6, 2016 at 5:32 PM, Sai Boorlagadda <sai.boorlaga...@gmail.com>
wrote:

> I think "Pluggable storage" is initiated after Geode Summit.
>
> On Wed, Apr 6, 2016 at 5:27 PM, Roman Shaposhnik <ro...@shaposhnik.org>
> wrote:
>
> > On Wed, Apr 6, 2016 at 5:22 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
> > wrote:
> > > I found the following"Shepherd/Mentor notes" for our previous report
> > > <https://wiki.apache.org/incubator/January2016>:
> > >
> > > For the next report: for me as a mentor (and perhaps for others on
> > IPMC)
> > > it is not very insightful to see the number of pull requests or
> JIRAs
> > > opened. It isn't what "project development" constitutes in my
> mind. I
> > > would like to see more info about how project is getting into
> Apache
> > > Way,
> > > what important discussions are held, what decisions are made
> through
> > > community consensus, etc.
> >
> > That's a good point, but please don't read it as an excuse to drop that
> > first part of the valuable statistics.
> >
> > > Given the above, I was thinking about appending the following to the
> > report:
> > >
> > > - We elected a release manager for the first release and have rotated
> > that
> > > responsibility for the second release
> > > - Had a discussion about how to number the releases
> > > - Voted on the Release candidates, rejected the first but the second
> > > release candidate was voted as the final release
> > > - The community discussed the criteria for becoming a committer and
> > learned
> > > the correct way of

Re: Podling Report Reminder - April 2016

[Swapnil Bawaskar]

I found the following"Shepherd/Mentor notes" for our previous report
<https://wiki.apache.org/incubator/January2016>:

For the next report: for me as a mentor (and perhaps for others on IPMC)
it is not very insightful to see the number of pull requests or JIRAs
opened. It isn't what "project development" constitutes in my mind. I
would like to see more info about how project is getting into Apache
Way,
what important discussions are held, what decisions are made through
community consensus, etc.

Given the above, I was thinking about appending the following to the report:

- We elected a release manager for the first release and have rotated that
responsibility for the second release
- Had a discussion about how to number the releases
- Voted on the Release candidates, rejected the first but the second
release candidate was voted as the final release
- The community discussed the criteria for becoming a committer and learned
the correct way of nominating new committers.
- JIRA components were refined after a discussion on the mailing list.
- Consensus was achieved for the scope for the releases on the mailing list.
- Decision was made not to rename the command line tool on the mailing list.

Please provide feedback.

Thanks!
Swapnil.


On Tue, Apr 5, 2016 at 8:01 AM, Sai Boorlagadda <sboorlaga...@pivotal.io>
wrote:

> +1 Looks good.
>
> On Tue, Apr 5, 2016 at 7:59 AM, Anthony Baker <aba...@pivotal.io> wrote:
>
> > Just need to replace X subscribers, otherwise +1.
> >
> > Anthony
> >
> >
> > > On Apr 4, 2016, at 2:31 PM, William Markito <wmark...@pivotal.io>
> wrote:
> > >
> > > +1 - Looks good to me, thanks for picking it up Swap!
> > >
> > > On Mon, Apr 4, 2016 at 1:58 PM, Swapnil Bawaskar <sbawas...@pivotal.io
> >
> > > wrote:
> > >
> > >> Hi All,
> > >>
> > >> Please find the Draft report below. I will plug-in the dev and user
> list
> > >> numbers before submitting. Any other feedback welcome.
> > >>
> > >>
> > >> Geode
> > >>
> > >> Apache Geode is a distributed, in-memory database with strong data
> > >> consistency, built to support transactional applications with low
> > latency
> > >> and high concurrency needs.
> > >>
> > >>
> > >> Geode has been incubating since 2015-04-27.
> > >>
> > >>
> > >> Three most important issues to address in the move towards graduation:
> > >>
> > >> 1. Rename packages to org.apache
> > >>
> > >>
> > >> Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to be
> > >>
> > >> aware of?
> > >>
> > >> None
> > >>
> > >>
> > >> How has the community developed since the last report?
> > >>
> > >> - We have been able to address the “Three most important issues to
> move
> > >> towards graduation” from the previous report
> > >>
> > >>  1. We had out first public release
> > >>
> > >>  2. We Added 4 new committers, one of which is outside Pivotal
> > >>
> > >>  3. We are about to have a second release, establishing a regular
> > release
> > >> cadence
> > >>
> > >> - We had a GeodeSummit http://geodesummit.com/
> > >>
> > >>  - 22 sessions (including Keynote)
> > >>
> > >>  - Sessions included current use cases as well as integrations with
> > other
> > >> Apache projects
> > >>
> > >>  - Over 100 attendees
> > >>
> > >> - The Geode Clubhouse hosted a meeting covering A walk through the
> > >> different approaches for caching data in a Spring based application
> with
> > >> Apache Geode by Luke Shannon
> > >>
> > >> - The breakdown of JIRA tickets is the following:
> > >>
> > >>  Q3 / 2015 - 65 created, 19 resolved.
> > >>
> > >>  Q4 / 2015 - 342 created, 227 resolved.
> > >>
> > >>  Q1 / 2016 - 438 created, 362 resolved.
> > >>
> > >>  Q2 / 2016 - 8 created, 12 resolved (As of Apr 4th)
> > >>
> > >> - There was a total of 123 pull requests on GitHub with 6 still open.
> > >>
> > >> - The breakdown of the mailing lists messages for January, Feb, March
> of
> > >> 2016:
> > >>
> > >>  org.apache.geode.issues 4300
> &

Re: [Incubator Wiki] Update of "April2016" by SwapnilBawaskar

[Swapnil Bawaskar]

Sorry about the conflicts! I had resolved them and hit preview, just forgot
the final "save changes" step!

I have now published the report!
https://wiki.apache.org/incubator/April2016

On Tue, Apr 5, 2016 at 6:13 PM, Marvin Humphrey 
wrote:

> On Tue, Apr 5, 2016 at 6:02 PM, John D. Ament 
> wrote:
> > Swapnii,
> >
> > Please correct the edit conflicts.
>
> I took the liberty of reverting the changeset with conflicts, because
> it's easy if you know how but a pain to figure out if you don't.  All
> that's necessary now is to re-add the Geode report.
>
> Marvin Humphrey
>

Re: Broken: apache/incubator-geode#295 (develop - 066a9d5)

[Swapnil Bawaskar]

Since this is a Junit, we should fix this ASAP:
https://issues.apache.org/jira/browse/GEODE-1171


On Mon, Apr 4, 2016 at 3:28 PM, Travis CI  wrote:

> Build Update for apache/incubator-geode
> -
>
> Build: #295
> Status: Broken
>
> Duration: 14 minutes and 45 seconds
> Commit: 066a9d5 (develop)
> Author: Kirk Lund
> Message: GEODE-103: fix usage of isProcessAlive to remove race condition
>
> * also fixes GEODE-1136
>
> View the changeset:
> https://github.com/apache/incubator-geode/compare/2deb31d95f1f...066a9d57a165
>
> View the full build log and details:
> https://travis-ci.org/apache/incubator-geode/builds/120748668
>
> --
>
> You can configure recipients for build notifications in your .travis.yml
> file. See https://docs.travis-ci.com/user/notifications
>
>

Re: [discuss] Install Google Analytics for tracking activity on geode.incubator.apache.org

[Swapnil Bawaskar]

+1
It would be nice to report these stats in the podling report too.

On Fri, Apr 1, 2016 at 10:11 AM, Gregory Chase  wrote:

> Dear Geode contributors,
> In the community marketing world, awareness tracking through analytics such
> as website traffic are very important.
>
> We are currently flying blind on geode.incubator.apache.org.
>
> We don't know answers to questions like:
> How many people are hitting our site
> Whether they are new or returning
> If they are potentially subscribing to email list or downloading software
> Where they are coming from
> What they're most interested in next
>
> I had access to such information from the private Geode Summit site, and
> would really appreciate if we can make this available to the project.
>
> The account access would administered through the project Google account,
> which the PPMC currently manages for social media. Similar to how we handle
> Twitter, access can be granted to interested individuals at their request
> through their personal Google accounts.
>
>  I will also commit to posting public quarterly graphs to dev, or on the
> wiki.
>
> Are there any objections to my installing Google Analytics tracking tags
> into the Geode website, and setting up this account as described?
>
> Regards,
>
> -Greg
>
> --
> Greg Chase
>
> Global Head, Big Data Communities
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>

Re: Review Request 45599: GEODE-1160 TransactionWriter is unexpectedly triggered if updating data entries with using PDX serializer

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45599/#review126908
---


Ship it!




Ship It!

- Swapnil Bawaskar


On April 1, 2016, 7:22 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45599/
> ---
> 
> (Updated April 1, 2016, 7:22 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, 
> and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This inhibits invocation of transaction writers and listners for operations 
> on internal cache Regions.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java
>  1a4d3777fc9efdba813f2215ef9f8deed55bbeef 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEvent.java 
> e686ceae6ac010cc4e04972453cb90a578d7dade 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRmtEvent.java 
> b378c8e5949c6fc310d1cb9fd9634e795c4751cb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 
> 9e8dd18fd5065be1a9b94086732746bd8f770463 
>   
> geode-core/src/test/java/com/gemstone/gemfire/pdx/PdxSerializableDUnitTest.java
>  1e901bc2f12eba2e9ed9ea77e4cb57a97c0beb4c 
> 
> Diff: https://reviews.apache.org/r/45599/diff/
> 
> 
> Testing
> ---
> 
> precheckin including a new test for this problem
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 45180: GEODE-1054: InternalResultSender.setException logging at info level instead of fatal

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45180/#review124909
---


Ship it!




Ship It!

- Swapnil Bawaskar


On March 22, 2016, 10:37 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45180/
> ---
> 
> (Updated March 22, 2016, 10:37 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When a function exception is thrown due to failing, the results senders are 
> currently logging this at a fatal level.  This is not a "catastrophic" error 
> and should be reduced from fatal to either error, warn or even info level.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/DistributedRegionFunctionResultSender.java
>  18106c1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/MemberFunctionResultSender.java
>  30c652c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/PartitionedRegionFunctionResultSender.java
>  813d833 
> 
> Diff: https://reviews.apache.org/r/45180/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 45173: modified the test to count unexpected failures

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45173/#review124901
---


Ship it!




Ship It!

- Swapnil Bawaskar


On March 22, 2016, 10:11 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45173/
> ---
> 
> (Updated March 22, 2016, 10:11 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Bugs: GEODE-1056
> https://issues.apache.org/jira/browse/GEODE-1056
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> modified the test to count unexpected failures
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
>  abf546dd8053db690c829ab1bb6339935e3005fe 
> 
> Diff: https://reviews.apache.org/r/45173/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>

Re: Review Request 45173: modified the test to count unexpected failures

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45173/#review124862
---




geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
 (line 2052)
<https://reviews.apache.org/r/45173/#comment187559>

This does not test if the new member does not recover any primaries at all.

I think we should add an assertion for the number of primaries to be 
between say 8 and 12 on each member.


- Swapnil Bawaskar


On March 22, 2016, 7:13 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45173/
> ---
> 
> (Updated March 22, 2016, 7:13 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Bugs: GEODE-1056
> https://issues.apache.org/jira/browse/GEODE-1056
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> modified the test to count unexpected failures
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java
>  abf546dd8053db690c829ab1bb6339935e3005fe 
> 
> Diff: https://reviews.apache.org/r/45173/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>

Re: Review Request 45077: GEODE-1113 - Redis Adapter region creation performance problems

[Swapnil Bawaskar]

> On March 21, 2016, 11:49 p.m., Swapnil Bawaskar wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java,
> >  line 402
> > <https://reviews.apache.org/r/45077/diff/1/?file=1307404#file1307404line402>
> >
> > The reason we decided to go the gfsh route for creating regions was 
> > that we wanted to work with cluster configuration. With the existing code, 
> > if you did an export-cluster-configuration all the regions created by Redis 
> > adaptor will show up. With the new code, they will not.
> > 
> > To me, the fact that programatically created regions do not show up in 
> > exported cluster configuration is broken.

I have added https://issues.apache.org/jira/browse/GEODE-1119 for fixing the 
programmatically creating regions issue.


- Swapnil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45077/#review124686
---


On March 19, 2016, 8:23 p.m., William Markito wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45077/
> -------
> 
> (Updated March 19, 2016, 8:23 p.m.)
> 
> 
> Review request for geode and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1113
> https://issues.apache.org/jira/browse/GEODE-1113
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1113 - Redis Adapter region creation performance problems
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/redis/ExecutionHandlerContext.java
>  0f4f341 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java
>  dcd83cb 
> 
> Diff: https://reviews.apache.org/r/45077/diff/
> 
> 
> Testing
> ---
> 
> Precheckin.
> redis-benchmark.
> Spring cloud Dataflow tests.
> 
> 
> Thanks,
> 
> William Markito
> 
>

Re: Review Request 45077: GEODE-1113 - Redis Adapter region creation performance problems

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45077/#review124686
---




geode-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java
 (line 400)
<https://reviews.apache.org/r/45077/#comment187312>

The reason we decided to go the gfsh route for creating regions was that we 
wanted to work with cluster configuration. With the existing code, if you did 
an export-cluster-configuration all the regions created by Redis adaptor will 
show up. With the new code, they will not.

To me, the fact that programatically created regions do not show up in 
exported cluster configuration is broken.


- Swapnil Bawaskar


On March 19, 2016, 8:23 p.m., William Markito wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45077/
> ---
> 
> (Updated March 19, 2016, 8:23 p.m.)
> 
> 
> Review request for geode and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1113
> https://issues.apache.org/jira/browse/GEODE-1113
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1113 - Redis Adapter region creation performance problems
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/redis/ExecutionHandlerContext.java
>  0f4f341 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/redis/RegionProvider.java
>  dcd83cb 
> 
> Diff: https://reviews.apache.org/r/45077/diff/
> 
> 
> Testing
> ---
> 
> Precheckin.
> redis-benchmark.
> Spring cloud Dataflow tests.
> 
> 
> Thanks,
> 
> William Markito
> 
>

Re: Review Request 45129: fixed the DUnit failure due to previous fix

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45129/#review124669
---


Ship it!




Ship It!

- Swapnil Bawaskar


On March 21, 2016, 10:08 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45129/
> ---
> 
> (Updated March 21, 2016, 10:08 p.m.)
> 
> 
> Review request for geode and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1109
> https://issues.apache.org/jira/browse/GEODE-1109
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> fixed the DUnit failure due to previous fix
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
>  17529b8faeb18f06bb2d512d424ca268bb73a5b3 
> 
> Diff: https://reviews.apache.org/r/45129/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>

Re: Regarding contribution in Apache geode

[Swapnil Bawaskar]

Hi Pawan,
To subscribe please send a blank email to:
dev list: dev-subscr...@geode.incubator.apache.org
user list: user-subscr...@geode.incubator.apache.org

Please see this for link to archives:
http://geode.incubator.apache.org/community/#mailing-lists

Thanks!
Swapnil.

On Fri, Mar 18, 2016 at 1:28 AM, Pawan Pawar  wrote:

> Hello I am pawan pawar, I want to join the contributors mailing list.
> please add me in your mailing list.
>
> --
> *Thanks & Regards*
> *Pawan Pawar*
> *Mobile: +91 9993585256*
> *Email: pawarem...@gmail.com *
> *Skype: pawarskype*
>

Re: Broken: apache/incubator-geode#116 (feature/GEODE-1050 - 2fd9cc6)

[Swapnil Bawaskar]

Travis CI is a free service provided to open source projects, which unlike
Jenkins is available for external (to Pivotal) contributors.
In any case, I have disabled Travis on all feature branches. Also disabled
for asf-site branch, since it contains our static website.

On Mon, Mar 14, 2016 at 2:39 PM, Kirk Lund <kl...@pivotal.io> wrote:

> I'm already using Jenkins to run check on my feature branches, so I don't
> really get any value from Travis. If it uses AWS or other $ resource, then
> I would suggest not running it automatically on feature branches. Perhaps
> there could be a way to manually initiate it rather than automatically
> running it for all feature branches?
>
> -Kirk
>
>
> On Mon, Mar 14, 2016 at 10:11 AM, Swapnil Bawaskar <sbawas...@pivotal.io>
> wrote:
>
> > Well, Travis runs build (./gradlew check) on pull requests as well as all
> > branches. Do we want to skip running travis on all feature branches?
> >
> > On Mon, Mar 14, 2016 at 9:00 AM, Anthony Baker <aba...@pivotal.io>
> wrote:
> >
> > > Ah, thanks for pointing that out Kirk, I missed the branch.
> > >
> > > I think this is setup so we get test coverage on pull requests.
> > >
> > > Anthony
> > >
> > > > On Mar 14, 2016, at 8:55 AM, Kirk Lund <kl...@pivotal.io> wrote:
> > > >
> > > > That branch isn't quite ready to merge to develop, but I did add a
> > > category
> > > > to that test on Friday.
> > > >
> > > > Is there some reason we're running Travis against feature branches
> that
> > > are
> > > > under active development?
> > > >
> > > > I commit/push in-progress work to facilitate testing on both my Mac
> and
> > > > Linux.
> > > >
> > > > -Kirk
> > > >
> > > > On Monday, March 14, 2016, Anthony Baker <aba...@pivotal.io> wrote:
> > > >
> > > >> :geode-core:checkMissedTestsThe test
> > >
> >
> com.gemstone.gemfire.test.dunit.internal.tests.JUnit4BasicDUnitTest.testInvokeLambdaAsync
> > > does not include a junit category.
> > > >> org.gradle.api.GradleException: The test
> > >
> >
> com.gemstone.gemfire.test.dunit.internal.tests.JUnit4BasicDUnitTest.testInvokeLambdaAsync
> > > does not include a junit category.
> > > >>
> > > >> On Mar 11, 2016, at 1:25 PM, Travis CI <bui...@travis-ci.org
> > > >> <javascript:_e(%7B%7D,'cvml','bui...@travis-ci.org');>> wrote:
> > > >>
> > > >> Build Update for apache/incubator-geode
> > > >> -
> > > >>
> > > >> Build: #116
> > > >> Status: Broken
> > > >>
> > > >> Duration: 16 minutes and 7 seconds
> > > >> Commit: 2fd9cc6 (feature/GEODE-1050)
> > > >> Author: Kirk Lund
> > > >> Message: Remove comments about case methods which only applies to
> > hydra
> > > >> dunit
> > > >>
> > > >> View the changeset:
> > > >>
> > >
> >
> https://github.com/apache/incubator-geode/compare/3543e224c719...2fd9cc687cea
> > > >>
> > > >> View the full build log and details:
> > > >> https://travis-ci.org/apache/incubator-geode/builds/115418416
> > > >>
> > > >> --
> > > >>
> > > >> You can configure recipients for build notifications in your
> > .travis.yml
> > > >> file. See https://docs.travis-ci.com/user/notifications
> > > >>
> > > >>
> > > >>
> > >
> > >
> >
>

Re: Regarding contribution in Apache geode

[Swapnil Bawaskar]

Oops! sending to Pawan this time!

On Fri, Mar 18, 2016 at 9:26 AM, Swapnil Bawaskar <sbawas...@pivotal.io>
wrote:

> Hi Pawan,
> To subscribe please send a blank email to:
> dev list: dev-subscr...@geode.incubator.apache.org
> user list: user-subscr...@geode.incubator.apache.org
>
> Please see this for link to archives:
> http://geode.incubator.apache.org/community/#mailing-lists
>
> Thanks!
> Swapnil.
>
> On Fri, Mar 18, 2016 at 1:28 AM, Pawan Pawar <pawarem...@gmail.com> wrote:
>
>> Hello I am pawan pawar, I want to join the contributors mailing list.
>> please add me in your mailing list.
>>
>> --
>> *Thanks & Regards*
>> *Pawan Pawar*
>> *Mobile: +91 9993585256*
>> *Email: pawarem...@gmail.com <pawarem...@gmail.com>*
>> *Skype: pawarskype*
>>
>
>

Re: Review Request 44821: GEODE-1099: NPE thrown from TXManagerImpl.isDistributed()

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44821/
---

(Updated March 16, 2016, 5:32 p.m.)


Review request for geode, Darrel Schneider and Dan Smith.


Changes
---

Fixing DistTXManagerImplJUnitTest


Repository: geode


Description
---

Use the existing reference to InternalDistributedSystem so as to prevent a NPE.
If the member is indeed being disconnected, a CacheClosed exception is thrown
while trying to send the message.


Diffs (updated)
-

  
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXManagerImplJUnitTest.java
 1df2c452daf79364e1d61138d6f75164cb7b1eda 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplJUnitTest.java
 0467f4fde5c888294dbf197974c62676f3378b37 

Diff: https://reviews.apache.org/r/44821/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Review Request 44821: GEODE-1099: NPE thrown from TXManagerImpl.isDistributed()

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44821/
---

Review request for geode and Darrel Schneider.


Repository: geode


Description
---

Use the existing reference to InternalDistributedSystem so as to prevent a NPE.
If the member is indeed being disconnected, a CacheClosed exception is thrown
while trying to send the message.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 
de49fead8e0188d6b1316e1bc37d05d452cb9de5 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplJUnitTest.java
 a92d4dc52392f86d439bb0b3cafc4cf20cc0732e 

Diff: https://reviews.apache.org/r/44821/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: Broken: apache/incubator-geode#116 (feature/GEODE-1050 - 2fd9cc6)

[Swapnil Bawaskar]

Well, Travis runs build (./gradlew check) on pull requests as well as all
branches. Do we want to skip running travis on all feature branches?

On Mon, Mar 14, 2016 at 9:00 AM, Anthony Baker  wrote:

> Ah, thanks for pointing that out Kirk, I missed the branch.
>
> I think this is setup so we get test coverage on pull requests.
>
> Anthony
>
> > On Mar 14, 2016, at 8:55 AM, Kirk Lund  wrote:
> >
> > That branch isn't quite ready to merge to develop, but I did add a
> category
> > to that test on Friday.
> >
> > Is there some reason we're running Travis against feature branches that
> are
> > under active development?
> >
> > I commit/push in-progress work to facilitate testing on both my Mac and
> > Linux.
> >
> > -Kirk
> >
> > On Monday, March 14, 2016, Anthony Baker  wrote:
> >
> >> :geode-core:checkMissedTestsThe test
> com.gemstone.gemfire.test.dunit.internal.tests.JUnit4BasicDUnitTest.testInvokeLambdaAsync
> does not include a junit category.
> >> org.gradle.api.GradleException: The test
> com.gemstone.gemfire.test.dunit.internal.tests.JUnit4BasicDUnitTest.testInvokeLambdaAsync
> does not include a junit category.
> >>
> >> On Mar 11, 2016, at 1:25 PM, Travis CI  >> > wrote:
> >>
> >> Build Update for apache/incubator-geode
> >> -
> >>
> >> Build: #116
> >> Status: Broken
> >>
> >> Duration: 16 minutes and 7 seconds
> >> Commit: 2fd9cc6 (feature/GEODE-1050)
> >> Author: Kirk Lund
> >> Message: Remove comments about case methods which only applies to hydra
> >> dunit
> >>
> >> View the changeset:
> >>
> https://github.com/apache/incubator-geode/compare/3543e224c719...2fd9cc687cea
> >>
> >> View the full build log and details:
> >> https://travis-ci.org/apache/incubator-geode/builds/115418416
> >>
> >> --
> >>
> >> You can configure recipients for build notifications in your .travis.yml
> >> file. See https://docs.travis-ci.com/user/notifications
> >>
> >>
> >>
>
>

Review Request 44699: GEODE-573: Fix broken image links in javadocs

[Swapnil Bawaskar]

/main/java/com/gemstone/gemfire/internal/cache/doc-files/extensible-hashing.gif
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/jcache-get-flow.fig
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/jcache-get-flow.pdf
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/jcache-put-flow.fig
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/jcache-put-flow.pdf
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/jcache-update-message-flow.fig
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/jcache-update-message-flow.pdf
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/partitioned-regions.fig
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/partitioned-regions.gif
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/properties.html
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/doc-files/region-implementation.fig
 62a20b2557087ff20112b185787b21be34d65816 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/package.html 
cdef772b2ed5012bef214c5cb9d7be09f04316c9 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/doc-files/communication-architecture.fig
 b334ebb91d9f74c68c05921247e75ad6d35cb052 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/doc-files/communication-architecture.gif
 3ecc5c4faed2166d47cb0bf3493de041244e0a2c 
  geode-core/src/main/java/com/gemstone/gemfire/internal/doc-files/cs-maps.fig 
2d615a61f55e1053b012668bfae5a2d80c6942ee 
  geode-core/src/main/java/com/gemstone/gemfire/internal/doc-files/cs-maps.gif 
dce7de3a478cffc3d0338c963ff2c89ed3e9670a 
  geode-core/src/main/java/com/gemstone/gemfire/internal/doc-files/ds-map.fig 
6456b56af1cbfbff0a4704ba5223bf49adfb7c37 
  geode-core/src/main/java/com/gemstone/gemfire/internal/doc-files/ds-map.gif 
a712b52fc3f67544dc794588d65c93292ba8bd5d 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/doc-files/merge-log-files.fig
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/doc-files/merge-log-files.gif
  
  
geode-core/src/main/java/com/gemstone/gemfire/internal/logging/MergeLogFiles.java
 PRE-CREATION 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/util/doc-files/call-stack.fig
 5b052c2bebdd1c780850b40b41507ef8739e9a73 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/util/doc-files/class-loaders.fig
 3ca6d06f90334ca3c2ce7fa0904db6a31008d85b 

Diff: https://reviews.apache.org/r/44699/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: Review Request 44291: Added a test for JTA rollback

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44291/#review121897
---


Ship it!




Ship It!

- Swapnil Bawaskar


On March 3, 2016, 6:10 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44291/
> ---
> 
> (Updated March 3, 2016, 6:10 p.m.)
> 
> 
> Review request for geode and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a test for JTA rollback
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java
>  add43a0457acd065b7f54f35cda754a4e7d8bdaa 
> 
> Diff: https://reviews.apache.org/r/44291/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>

Re: In preparation for Apache Geode - looking for topic leads for Geode Features Discussions

[Swapnil Bawaskar]

I will be happy to lead the Redis adaptor discussion.

On Wed, Mar 2, 2016 at 10:02 PM, Gregory Chase  wrote:

> Dear Apache Geode Contributors,
> I've spoken to a number of you 1:1 and we have enough willing folks to
> create a new series at Geode Summit that we can stream virtually, in the
> same way we run Geode Clubhouse meetings.
>
> The idea is to hold 30 minute deep dive discussions about current, half
> done, and proposed features of Apache Geode.  Any of the specifications on
> the wiki are fair game:
>
> https://cwiki.apache.org/confluence/display/GEODE/Project+Proposals+and+Specifications
>
> If you have any new ideas, we'll consider those as well if you are prepared
> to lead a discussion about it.
>
> If you are leading a discussion, you do not need to be present at Geode
> Summit/  If you would like to attend, I'll arrange for you to get speakers
> pass.  You can also lead virtually since we'll be using Adobe Connect to
> extend the meeting to anyone.
>
> Current ideas and topic leaders, if any include:
>
>- Edin Zulich for current and future off heap storage
>- Sabby Anandan discussing Spring Data Flow and Geode
>- John Blum discussing future of spring data gemfire API
>- Redis to Geode Adaptor (needs leader)
>- Low hanging fruit for new contributors (needs leader)
>
>
> We can start the meetings as early as 1PM and should finish by 4PM PST.
> These would be 30 minute slots, but if they go faster, no big deal.  We
> break until the next scheduled slot.
>
> So this means we can cover 3 more topics in addition to the 3 we have
> leaders for.
>
> Meetings will be recorded, but the end result should be to update the wiki
> specifications, and then call a vote on the newsgroups.
>
> We'll discuss this in real time briefly in tomorrow's Geode Clubhouse
>
> --
> Greg Chase
>
> Global Head, Big Data Communities
> http://www.pivotal.io/big-data
>
> Pivotal Software
> http://www.pivotal.io/
>
> 650-215-0477
> @GregChase
> Blog: http://geekmarketing.biz/
>

Re: Testing pull requests

[Swapnil Bawaskar]

This has been implemented now. Please see
https://issues.apache.org/jira/browse/GEODE-992.

On Fri, Feb 19, 2016 at 4:15 PM, Swapnil Bawaskar <sbawas...@pivotal.io>
wrote:

>
>
> On Fri, Feb 19, 2016 at 12:38 PM, Sai Boorlagadda <sboorlaga...@pivotal.io
> > wrote:
>
>> Does Travis show a status on pull request that these tasks have passed?
>
>
> Yes.
>
>
>> Also can we run 'precheckin' on Travis infrastructure? because most of our
>> PRs are created after 'precheckin' which also covers doc-gen and unit
>> testing.
>>
>
> I don't know if travis infrastructure will allow running tests for 8
> hours. I think we should
> first get started with running the build, and then tweak as necessary.
>
>
>

Build emails from Travis

[Swapnil Bawaskar]

Do we want build emails from travis sent to the dev list?

The default mechanism from the travis site
 is as follows:

By default, a build email is sent to the committer and the author, but only
if they have access to the repository the commit was pushed to. This
prevents forks active on Travis CI from notifying the upstream repository’s
owners when they’re pushing any upstream changes to their fork. It also
prevents build notifications from going to folks not registered on Travis
CI.

The email address is then determined based on the email address in the
commit, but only if it matches one of the email addresses in our database.
We synchronize all your email addresses from GitHub, solely for the purpose
of build notifications.


We can configure travis to send emails to the dev list when the state of
the build changes (from passing to failing OR from failing to passing). No
multiple emails on failing builds.

Thanks!
Swapnil.

Review Request 44036: GEODE-992: Integrate with Travis CI

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44036/
---

Review request for geode, Darrel Schneider and William Markito.


Repository: geode


Description
---

Adding a minimal .travis.yml file for travis integration.


Diffs
-

  .travis.yml PRE-CREATION 

Diff: https://reviews.apache.org/r/44036/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Review Request 43981: GEODE-983: NPE with transactions on PR with overflow

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43981/
---

Review request for geode and Darrel Schneider.


Repository: geode


Description
---

Use a BucketRegion while faulting-in an overflowed value.


Diffs
-

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 
PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/lru/TransactionsWithOverflowTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/43981/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: Testing pull requests

[Swapnil Bawaskar]

On Fri, Feb 19, 2016 at 12:38 PM, Sai Boorlagadda 
wrote:

> Does Travis show a status on pull request that these tasks have passed?


Yes.


> Also can we run 'precheckin' on Travis infrastructure? because most of our
> PRs are created after 'precheckin' which also covers doc-gen and unit
> testing.
>

I don't know if travis infrastructure will allow running tests for 8 hours.
I think we should
first get started with running the build, and then tweak as necessary.

Testing pull requests

[Swapnil Bawaskar]

Hi,

In order to test pull requests, I would like to propose using Travis CI (
https://travis-ci.org/). Travis can run after each checkin and on each pull
request. This will allow us to catch javadoc and unit test issues early
(before the nightly ASF build).

It is really simple to setup Travis, we need to give it permission and
checkin a .travis.yml file.
Other Apache projects using Travis:
1. Groovy: https://github.com/apache/groovy/blob/master/.travis.yml
2. Zeppelin: https://github.com/apache/incubator-zeppelin

Thanks!
Swapnil.

Re: Review Request 43738: GEODE-905: HLL classes should preserve original source header

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43738/
---

(Updated Feb. 18, 2016, 11:22 p.m.)


Review request for geode and Anthony Baker.


Changes
---

Incorporate Anthony's feedback.


Repository: geode


Description
---

Restoring the original headers.

GEODE-905: HLL classes should preserve original source header

Adding NOTICE from stream-lib project for HLL classes.


Diffs (updated)
-

  NOTICE 7989bba4face1ad1eba68febd96b884bcfac377a 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java 
bd0b33cd1ca2d8b7c697fefdade875f01fe4e91f 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/CardinalityMergeException.java
 5fd6b0b04df31272339272298b49fd666b2f5d35 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLog.java 
fa5508d250e590567ae9f9fd4820742bc3558228 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLogPlus.java
 7f04c38bcde16e66cf1659bc563b6774f1303782 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/IBuilder.java 
bff40cd796adf568608545de2d636b9175933f9d 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/ICardinality.java 
1671fe50c75553dc4970729784eaa0e2793550ae 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/MurmurHash.java 
bab802ecec7496d705749860fc75bfd747d1a082 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/RegisterSet.java 
e1a1944d0e47a09317b6219857f911a36ae4173f 

Diff: https://reviews.apache.org/r/43738/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Review Request 43738: GEODE-905: HLL classes should preserve original source header

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43738/
---

Review request for geode and Anthony Baker.


Repository: geode


Description
---

Restoring the original headers.

GEODE-905: HLL classes should preserve original source header

Adding NOTICE from stream-lib project for HLL classes.


Diffs
-

  NOTICE 7989bba4face1ad1eba68febd96b884bcfac377a 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java 
bd0b33cd1ca2d8b7c697fefdade875f01fe4e91f 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/CardinalityMergeException.java
 5fd6b0b04df31272339272298b49fd666b2f5d35 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLog.java 
fa5508d250e590567ae9f9fd4820742bc3558228 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/HyperLogLogPlus.java
 7f04c38bcde16e66cf1659bc563b6774f1303782 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/IBuilder.java 
bff40cd796adf568608545de2d636b9175933f9d 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/ICardinality.java 
1671fe50c75553dc4970729784eaa0e2793550ae 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/MurmurHash.java 
bab802ecec7496d705749860fc75bfd747d1a082 
  gemfire-core/src/main/java/com/gemstone/gemfire/internal/hll/RegisterSet.java 
e1a1944d0e47a09317b6219857f911a36ae4173f 

Diff: https://reviews.apache.org/r/43738/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: License / notice guide

[Swapnil Bawaskar]

This is very helpful, thanks Anthony!


On Wed, Feb 17, 2016 at 9:57 PM, Anthony Baker  wrote:

> Thanks to a lot of really helpful threads on general@ [1][2][3][4] I put
> together a guide on LICENSE / NOTICE for geode [5].  Let me know if
> something is unclear or incorrect.
>
> This should be helpful for the following M2 tasks:
>
> GEODE-906 (Cleanup source headers)
> GEODE-905 (Source headers)
> GEODE-901 (Source headers)
> GEODE-907 (Remove JSON code from pulse)
> GEODE-903 (Copyright date on footer)
> GEODE-914 (NOTICE)
> GEODE-904 (LICENSE)
> GEODE-918 (Add license header to generated pom)
>
> Anthony
>
>
> [1]
> http://mail-archives.apache.org/mod_mbox/incubator-general/201602.mbox/%3c57491fba-fddb-4009-8d00-8f3a9a2b3...@classsoftware.com%3e
> [2]
> http://mail-archives.apache.org/mod_mbox/incubator-general/201602.mbox/%3ca44698bc-a87b-48e5-bdf2-29c1a1814...@classsoftware.com%3e
> [3] https://nifi.apache.org/licensing-guide.html
> [4]
> http://mail-archives.apache.org/mod_mbox/incubator-general/201601.mbox/%3cCADY20s5nLc9zLKoNYf_8W8vf+Q6ri=-utanuaxzgorbysxw...@mail.gmail.com%3e
> [5]
> https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors
>
>

Re: Review Request 43372: GEODE-557: CI failure: MemoryThresholdsOffHeapDUnitTest.testDistributedRegionRemotePutRejectionCacheClose

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43372/#review118498
---


Ship it!




Ship It!

- Swapnil Bawaskar


On Feb. 9, 2016, 7:27 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43372/
> ---
> 
> (Updated Feb. 9, 2016, 7:27 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Set cacheserver port to 'zero' in-order for system to pick-up random port 
> instead of using AvailablePortHelper.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  5c65b1a27ec38d755980c4613d5eaabacf066c38 
> 
> Diff: https://reviews.apache.org/r/43372/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>

Re: [DISCUSS] Next Release Scope - version 1.0.0-incubating.M2

[Swapnil Bawaskar]

I think we should prioritize GEODE-37 (package renaming), so that we don't
break our early users' applications, and GEODE-36 (Rename gfsh) so that we
don't break their scripts.

On Tue, Feb 9, 2016 at 4:03 PM, Dan Smith  wrote:

> This seems like a pretty reasonable list to me. Maybe add in GEODE-818 to
> M2 as well? GEODE-27 talks about cleaning up the pom, but it's more about
> fixing the format. GEODE-818 is about removing uneeded dependencies.
>
> -Dan
>
> On Tue, Feb 9, 2016 at 8:23 AM, Anthony Baker  wrote:
>
> > I walked through JIRA this morning.  There’s a lot of really interesting
> > stuff we should consider for M2.  However, I think we should err on the
> > conservative side given that we already have a lot of work in flight
> (e.g.
> > Pulse, Modules, WAN, CQ, etc) and we don’t want to run too long before
> our
> > next release.  Given the new code additions, I would expect 2-3 RC’s will
> > be needed.
> >
> > I’ve grouped and stack ranked the tickets that seem relevant to M2 below.
> > This is just IMO and I would appreciate community input on this.
> >
> > Tests:
> > GEODE-944 (Test failure when ISP intercepts DNS failure)
> > RC2 test failures from Brian Dunlap [1]
> > - ^ M2 ^ -
> >
> > Security:
> > GEODE-562 (Remove or upgrade commons-collections)
> > - ^ M2 ^ -
> >
> > IP:
> > GEODE-906 (Cleanup source headers)
> > GEODE-905 (Source headers)
> > GEODE-901 (Source headers)
> > GEODE-907 (Remove JSON code from pulse)
> > GEODE-903 (Copyright date on footer)
> > GEODE-914 (NOTICE)
> > GEODE-904 (LICENSE)
> > GEODE-918 (Add license header to generated pom)
> > - ^ M2 ^ - v M3 v -
> > GEODE-835 (remove gemfire-joptsimple)
> > GEODE-629 (JSON parser)
> > GEODE-868 (Autogenerate NOTICE)
> >
> > Maven:
> > GEODE-26 (remove mavenLocal)
> > GEODE-917 (rename artifacts to geode)
> > GEODE-27 (Maven POM)
> > GEODE-946 (maven artifacts)
> > - ^ M2 ^ - v M3 v -
> > GEODE-919 (Don’t checksum signature files)
> >
> > Docs:
> > GEODE-945 (Javadoc warning)
> > GEODE-54 (javadocs)
> > GEODE-887 (README)
> > GEODE-884 (README)
> > GEODE-876 (Add README to binary distro)
> > GEODE-874 (COMPILING / RUNNING)
> > - ^ M2 ^ - v M3 v -
> > GEODE-33 (example code)
> >
> > Other:
> > GEODE-12 (Pulse)
> > - ^ M2 ^ - v M3 v -
> > GEODE-25 (crypto audit)
> > GEODE-786 (Update SDG to 1.7.2)
> > GEODE-543 (Upgrade jline and spring shell)
> > GEODE-57 (Update library versions)
> > GEODE-52 (@author)
> > GEODE-37 (package renaming)
> > GEODE-36 (Rename gfsh)
> >
> >
> > Anthony
> >
> > [1]
> >
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201601.mbox/%3ccafdh8_1cuvs36a7yppjod9b4k1cip_p8kepkxn+wbxe4kzq...@mail.gmail.com%3e
> >
> >
> > > On Feb 5, 2016, at 3:39 PM, Nitin Lamba  wrote:
> > >
> > > Thanks Dan!
> > > We should perhaps discuss this topic in detail during our next Geode
> > Clubhouse.
> > >
> > > @Mike, agree 100% with your prioritization though WAN and CQ have
> > already been merged with develop. So unless any testing/ performance
> issues
> > pop-up, we'll get those included as part of the next milestone release
> > automatically.
> > >
> > > - Nitin
> > >
> > > 
> > > From: Dan Smith 
> > > Sent: Thursday, February 4, 2016 1:46 PM
> > > To: geode
> > > Subject: Re: [DISCUSS] Next Release Scope - version 1.0.0-incubating.M2
> > >
> > > I added the bugs listed above, and a some others, to the M2 wiki page
> so
> > we
> > > don't lose track of them. We can discuss if some of these need to get
> > > pushed out of M2.
> > >
> > > I also created some subtasks for GEODE-823.
> > >
> > > On Mon, Feb 1, 2016 at 7:09 AM, Michael Stolz 
> wrote:
> > >
> > >> I'd like to see the focus on docs and dependencies first.
> > >> Then incorporation of WAN and CQ features.
> > >>
> > >> --
> > >> Mike Stolz
> > >> Principal Engineer, GemFire Product Manager
> > >> Mobile: 631-835-4771
> > >>
> > >> On Fri, Jan 29, 2016 at 12:26 PM, Nitin Lamba 
> wrote:
> > >>
> > >>> Thought of starting a separate thread to discuss next release scope.
> So
> > >>> far we have the following suggestions:
> > >>>
> > >>> Dan:
> > >>> - GEODE-823 - remove gemfire-joptsimple, gemfire-json, rename to
> > geode-,
> > >>> other misc issues
> > >>> - GEODE-818 - clean up dependencies
> > >>> - GEODE-572 - generate public javadocs (part of GEODE-54)
> > >>> - GEODE-33 - create project examples
> > >>>
> > >>> John:
> > >>> - GEODE-27 - fix POM dependencies - related to RC feedback above
> > >>> (GEODE-818)
> > >>>
> > >>> Few left-over from prior discussions:
> > >>>
> > >>> - GEODE-386 - fixing xsd namespace to Apache
> > >>> - GEODE-36 - fixing gfsh cli (Removing GemFire references)
> > >>> - GEODE-37 - package re-naming
> > >>>
> > >>> Some of these are big ticket items so we may have to space these out
> > >>> across 

Re: Review Request 43345: GEODE-909: CI failure: MemoryThresholdsOffHeapDUnitTest.testDisabledThresholds

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43345/#review118324
---


Ship it!




Ship It!

- Swapnil Bawaskar


On Feb. 8, 2016, 11:22 p.m., Sai Boorlagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43345/
> ---
> 
> (Updated Feb. 8, 2016, 11:22 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Set cacheserver port to 'zero' in-order for system to pick-up random port 
> instead of using AvailablePortHelper.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  43b53a3e22bcd49ee10e476164abfafb1a64516b 
> 
> Diff: https://reviews.apache.org/r/43345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>

Review Request 43351: GEODE-602: CI failure: OutOfOffHeapMemoryDUnitTest.testSimpleOutOfOffHeapMemoryMemberDisconnects

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43351/
---

Review request for geode and Darrel Schneider.


Repository: geode


Description
---

Adding InternalDistributedSystem.getAnyInstance() to await() condition that 
waits for 30 seconds.
Also replaced all other waitCriteria() with Avaitility in this test suite.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OutOfOffHeapMemoryDUnitTest.java
 bb6b8e006080da488a7a004702da309bbab3a1d2 

Diff: https://reviews.apache.org/r/43351/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: Review Request 43232: GEODE-915: add FORCE_INVALIDATE_EVENT

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43232/#review117937
---


Ship it!




Ship It!

- Swapnil Bawaskar


On Feb. 5, 2016, 12:35 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43232/
> ---
> 
> (Updated Feb. 5, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, Sai Boorlagadda and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> If the system property gemfire.FORCE_INVALIDATE_EVENT
> if set to true then afterInvalidate on CacheListeners will be called even
> if the entry does not exist or if the entry is already invalid.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  367951958b055ec4d61aa6f248341618a43c79bf 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
>  1c5f321cb24d36858ca6437703bad63a84fbf419 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheListenerTestCase.java
>  9a725e70d3eedc75683c93bf4857e75adc2444af 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/AbstractRegionMapTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43232/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 43227: if wan event retry caused the verstion tag is not created, do not distribute the event

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43227/#review117932
---




gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
 (line 539)
<https://reviews.apache.org/r/43227/#comment179230>

Could you please create a method for checking this condition, so that we 
have to make a change in one place in the future?


- Swapnil Bawaskar


On Feb. 4, 2016, 11:20 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43227/
> ---
> 
> (Updated Feb. 4, 2016, 11:20 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-774
> https://issues.apache.org/jira/browse/GEODE-774
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The GEODE-774's fix is enhanced. It will distribute when concurrentCheck is 
> not enabled. 
> And add junit test for both virtualPut and basicDestroy
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java
>  46c2eb3 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  98e72bd 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  fae381f 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
>  92b585a 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
>  9cf2f13 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  256e293 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/BucketRegionJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43227/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> Following BTs are running:
> legacyDunit/batterytest.bt ;
> smokeTest/batterytest.bt
> newWan/newwanSanity.bt ;
> newWan/newWanRebalance.bt ;
> newWan/newWanEviction.bt
> newWan/dispatcherthreads/queuePersist.bt;
> newWan/dispatcherthreads/newWanDispatcherThreads.bt;
> versioning/newWan/wanVersioning.bt;
> newWan/newWanSenderOperations.bt;
> newWan/wanParallelP2P.bt;
> newWan/newWanSerialParReg.bt;
> newWan/newWanParallelParReg.bt;
> newWan/newWan.bt;
> newWan/newWanBasic.bt;
> newWan/newWanParRegHA.bt
> parReg/parReg.bt
> parReg/parRegHA.bt
> parReg/parRegBridgePersist.bt
> parReg/parRegHABridgePersist.bt
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Re: New committer: Jinmei Liao

[Swapnil Bawaskar]

Welcome!

On Tue, Feb 2, 2016 at 7:27 PM, Kirk Lund  wrote:

> Congratulations Jinmei! Glad to have you on board as a committer!
>
> -Kirk
>
> On Tuesday, February 2, 2016, Anthony Baker  wrote:
>
> > Please welcome Jinmei Liao as a new committer to the Geode project!
> > We appreciate all the patches she has already contributed and are
> > hoping to see many more future contributions.
> >
> > Note: through a logistical mistake Jinmei was not added as a PPMC
> > member.  We should rectify that.
> >
> > Anthony
> >
>

Re: Lambdas in dunits! Time to remove string invoke?

[Swapnil Bawaskar]

+1

Since this is going to be a lot of tests, any ideas on how to split up the
work?

On Tue, Jan 26, 2016 at 2:06 PM, Jinmei Liao  wrote:

> +1
>
> Jinmei
>
> > On Jan 26, 2016, at 2:02 PM, Dan Smith  wrote:
> >
> > I checked in a minor fix to allow you to use a lambda expression in
> > VM.invoke calls with our dunit framework. For example:
> >
> > String result = vm1.invoke(() -> "Hello from vm1!");
> >
> > I think we should replace all of the VM.invoke calls that use strings
> with
> > lambdas instead. That will give us better compile time checks and make it
> > easier navigate in the IDE.
> >
> > This:
> > vm2.invoke(WANTestBase.class, "createReceiver", new Object[] { nyPort });
> >
> > Should become:
> > vm2.invoke(() -> WANTestBase.createReceiver( nyPort ));
> >
> > What do you guys think?
> > -Dan
>

Re: java 1.7 support was([jira] [Commented] (GEODE-479) Bump Java Language level to 1.8)

[Swapnil Bawaskar]

I found this project https://github.com/orfjackal/retrolambda that should
be able to provide backwards compatibility for us. It even has a gradle
plugin.
The project has limited support for default methods and static methods on
interfaces, but I don't think we have any of those.

Does the community think that we should invest in this?

On Mon, Jan 25, 2016 at 11:46 AM, Swapnil Bawaskar <sbawas...@pivotal.io>
wrote:

> Sending to the dev list (to escape mail filters).
>
>
> -- Forwarded message --
> From: Christian Tzolov (JIRA) <j...@apache.org>
> Date: Sat, Jan 23, 2016 at 12:40 PM
> Subject: [jira] [Commented] (GEODE-479) Bump Java Language level to 1.8
> To: iss...@geode.incubator.apache.org
>
>
>
> [
> https://issues.apache.org/jira/browse/GEODE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113956#comment-15113956
> ]
>
> Christian Tzolov commented on GEODE-479:
> 
>
> Apparently my suggestion to use -source 1.8 and -target 1.7 is not
> allowed. Such combination results in "target release 1.7 conflicts with
> default source release 1.8".
> Although the [javac doc|
> http://docs.oracle.com/javase/8/docs/technotes/tools/unix/javac.html] is
> not very clear about this, it seems that  the target >= source is a hard
> constrain.
>
> The second option (e.g. to have a parallel 1.7 compatible build) is not
> possible either as the source code uses 1.8 lambdas.
>
> Any other ideas for backward (java 1.7) support?
>
> > Bump Java Language level to 1.8
> > ---
> >
> > Key: GEODE-479
> > URL: https://issues.apache.org/jira/browse/GEODE-479
> > Project: Geode
> >  Issue Type: Improvement
> >Reporter: William Markito Oliveira
> >Assignee: William Markito Oliveira
> > Fix For: 1.0.0-incubating.M1
> >
> > Attachments: GEODE-479.patch
> >
> >
> > Change sourceCompatibility and targetCompatibility to 1.8 enabling Java
> 8 features in Geode codebase.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
>

Re: Review Request 41836: GEODE-719: Add error logs while cache.xml processing

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41836/
---

(Updated Jan. 22, 2016, 7:22 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

Incorporating Darrel's feedback.


Repository: geode


Description
---

- Catch all Errors and RuntimeExceptions while creating a cache and log
an error level message.
- Display the cache.xml contents before trying to initialize the cache
so that the errors have a better context.
- Converted some exception messages to i18n.


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java
 c39e33a 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java
 45adbd6 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 9d77556 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
2bc2f05 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PoolManagerImpl.java
 35b043f 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java
 780fe18 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml30DUnitTest.java
 adafa69 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml41DUnitTest.java
 5a41d31 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml57DUnitTest.java
 47bb612 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml60DUnitTest.java
 8699a05 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml66DUnitTest.java
 e531405 
  
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml90DUnitTest.java
 7fd2016 

Diff: https://reviews.apache.org/r/41836/diff/


Testing
---


Thanks,

Swapnil Bawaskar

Re: Review Request 42576: unit test DisconnectingOutOfOffHeapMemoryListener

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42576/#review115679
---

Ship it!



gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DisconnectingOutOfOffHeapMemoryListener.java
 (line 21)
<https://reviews.apache.org/r/42576/#comment176690>

Could you please add a one liner javadoc here?


- Swapnil Bawaskar


On Jan. 21, 2016, 5:46 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42576/
> ---
> 
> (Updated Jan. 21, 2016, 5:46 p.m.)
> 
> 
> Review request for geode, Scott Jewell, Ken Howe, Sai Boorlagadda, and 
> Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-814
> https://issues.apache.org/jira/browse/GEODE-814
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added unit test for DisconnectingOutOfOffHeapMemoryListener.
> 
> InternalDistributedSystem is no longer final so that unit tests can mock it. 
> The reason it was made final was because in an older version of the product 
> this class did license checking and we wanted to prevent it from being 
> subclassed.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  8f604b47a5e952ca62cbb2e7afece4750a7de0d3 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DisconnectingOutOfOffHeapMemoryListener.java
>  PRE-CREATION 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java
>  c950134099ac58e6befeeb891a9cecc98a4d4f04 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/DisconnectingOutOfOffHeapMemoryListenerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42576/diff/
> 
> 
> Testing
> ---
> 
> DisconnectingOutOfOffHeapMemoryListenerJUnitTest
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>