[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=337031=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337031 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 31/Oct/19 20:30 Start Date: 31/Oct/19 20:30 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337031) Time Spent: 2h (was: 1h 50m) > Get rid of orc.schema.literal in ORC-ingestion and registration > --- > > Key: GOBBLIN-924 > URL: https://issues.apache.org/jira/browse/GOBBLIN-924 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=335000=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-335000 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 28/Oct/19 16:16 Start Date: 28/Oct/19 16:16 Worklog Time Spent: 10m Work Description: autumnust commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-547024231 > @autumnust I use a pull command which seems introduce all the changes which have been committed during last two days. Just select the last commit should be able to see my change. Sorry for the inconvenience ^^ You can try `pull --rebase` and force a push to your own remote. Should be able to create a clean diff. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 335000) Time Spent: 1h 50m (was: 1h 40m) > Get rid of orc.schema.literal in ORC-ingestion and registration > --- > > Key: GOBBLIN-924 > URL: https://issues.apache.org/jira/browse/GOBBLIN-924 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=334250=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334250 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 25/Oct/19 17:45 Start Date: 25/Oct/19 17:45 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-546447452 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr=h1) Report > Merging [#2780](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2415173b1e428848c5b1c47788a2ad0aaa8ba3bd?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `27.63%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2780 +/- ## - Coverage 45.34% 45.33% -0.02% - Complexity 8858 8861 +3 Files 1894 1894 Lines 7083870874 +36 Branches 7790 7795 +5 + Hits 3212432129 +5 - Misses3574835781 +33 + Partials 2966 2964 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2780?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=) | `63.95% <0%> (-2.72%)` | `12 <0> (ø)` | | | [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh) | `84.81% <100%> (ø)` | `34 <0> (ø)` | :arrow_down: | | [...ro/JsonElementConversionWithAvroSchemaFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbldpdGhBdnJvU2NoZW1hRmFjdG9yeS5qYXZh) | `75% <100%> (ø)` | `5 <0> (ø)` | :arrow_down: | | [...n/converter/avro/JsonElementConversionFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbkZhY3RvcnkuamF2YQ==) | `81.04% <100%> (ø)` | `18 <0> (ø)` | :arrow_down: | | [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `58.28% <40%> (ø)` | `21 <0> (ø)` | :arrow_down: | | [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2780/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | `52.23% <50%> (ø)` | `12 <0> (ø)` | :arrow_down: | |
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=334235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334235 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 25/Oct/19 17:03 Start Date: 25/Oct/19 17:03 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-546433295 @autumnust I use a pull command which seems introduce all the changes which have been committed during last two days. Just select the last commit should be able to see my change. Sorry for the inconvenience ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 334235) Time Spent: 1.5h (was: 1h 20m) > Get rid of orc.schema.literal in ORC-ingestion and registration > --- > > Key: GOBBLIN-924 > URL: https://issues.apache.org/jira/browse/GOBBLIN-924 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333671=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333671
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:58
Start Date: 24/Oct/19 18:58
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338739989
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -152,18 +147,12 @@ public void addSerDeProperties(HiveRegistrationUnit
source, HiveRegistrationUnit
if (source.getOutputFormat().isPresent()) {
target.setOutputFormat(source.getOutputFormat().get());
}
-if (source.getSerDeProps().contains(SCHEMA_LITERAL)) {
- target.setSerDeProp(SCHEMA_LITERAL,
source.getSerDeProps().getProp(SCHEMA_LITERAL));
-}
}
@Override
public void updateSchema(HiveRegistrationUnit existingUnit,
HiveRegistrationUnit newUnit)
throws IOException {
-Preconditions.checkArgument(
-newUnit.getSerDeProps().contains(SCHEMA_LITERAL));
-
-existingUnit.setSerDeProp(SCHEMA_LITERAL,
newUnit.getSerDeProps().getProp(SCHEMA_LITERAL));
+log.debug("Do nothing to update schema since orc.schema.literal is
removed");
Review comment:
I thought logging is the only thing that you did in the method, if that is
the case, there's no need to keep this overriding.
But yes updating `columns` and `column.types` should be the correct
behavior. It actually doesn't matter too much if this method is called anywhere
because it is a public method and there could be usage somewhere we have no way
to control, but still we strive to maintain backward-compatability with correct
behavior.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333671)
Time Spent: 1h 20m (was: 1h 10m)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333645=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333645
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:27
Start Date: 24/Oct/19 18:27
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338725996
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -114,13 +112,10 @@ public HiveOrcSerDeManager(State props)
}
@Override
+ //Unsupported operation since we remove the orc.schema.literal
public boolean haveSameSchema(HiveRegistrationUnit unit1,
HiveRegistrationUnit unit2)
throws IOException {
-if (unit1.getSerDeProps().contains(SCHEMA_LITERAL) &&
unit2.getSerDeProps().contains(SCHEMA_LITERAL)) {
- return
unit1.getSerDeProps().getProp(SCHEMA_LITERAL).equals(unit2.getSerDeProps().getProp(SCHEMA_LITERAL));
-} else {
- return false;
-}
+ throw new UnsupportedOperationException();
Review comment:
Will Address
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333645)
Time Spent: 1h 10m (was: 1h)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333644=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333644
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:27
Start Date: 24/Oct/19 18:27
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338725934
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -152,18 +147,12 @@ public void addSerDeProperties(HiveRegistrationUnit
source, HiveRegistrationUnit
if (source.getOutputFormat().isPresent()) {
target.setOutputFormat(source.getOutputFormat().get());
}
-if (source.getSerDeProps().contains(SCHEMA_LITERAL)) {
- target.setSerDeProp(SCHEMA_LITERAL,
source.getSerDeProps().getProp(SCHEMA_LITERAL));
-}
}
@Override
public void updateSchema(HiveRegistrationUnit existingUnit,
HiveRegistrationUnit newUnit)
throws IOException {
-Preconditions.checkArgument(
-newUnit.getSerDeProps().contains(SCHEMA_LITERAL));
-
-existingUnit.setSerDeProp(SCHEMA_LITERAL,
newUnit.getSerDeProps().getProp(SCHEMA_LITERAL));
+log.debug("Do nothing to update schema since orc.schema.literal is
removed");
Review comment:
Do we want to remove this method? Or we do the update on columns and
column.types? Since I'm not sure whether this method is called in other projects
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333644)
Time Spent: 1h (was: 50m)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333624=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333624
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:04
Start Date: 24/Oct/19 18:04
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338715411
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -261,14 +250,11 @@ private void addSchemaProperties(Path path,
HiveRegistrationUnit hiveUnit)
* org.apache.hadoop.hive.serde.serdeConstants#LIST_COLUMNS and
* org.apache.hadoop.hive.serde.serdeConstants#LIST_COLUMN_TYPES
*
- * Keeping {@link #SCHEMA_LITERAL} will be a nice-to-have thing but not
actually necessary in terms of functionality.
Review comment:
Not an issue, but call out on changing the documentation as well, usually we
forget about that and leads to code smell.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333624)
Time Spent: 0.5h (was: 20m)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333626
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:04
Start Date: 24/Oct/19 18:04
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338714960
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -114,13 +112,10 @@ public HiveOrcSerDeManager(State props)
}
@Override
+ //Unsupported operation since we remove the orc.schema.literal
public boolean haveSameSchema(HiveRegistrationUnit unit1,
HiveRegistrationUnit unit2)
throws IOException {
-if (unit1.getSerDeProps().contains(SCHEMA_LITERAL) &&
unit2.getSerDeProps().contains(SCHEMA_LITERAL)) {
- return
unit1.getSerDeProps().getProp(SCHEMA_LITERAL).equals(unit2.getSerDeProps().getProp(SCHEMA_LITERAL));
-} else {
- return false;
-}
+ throw new UnsupportedOperationException();
Review comment:
Removing `orc.schema.literal` doesn't mean we give up schema metadata,
actually `columns` and `column.types` are still valid and could be used for
schema comparison.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333626)
Time Spent: 50m (was: 40m)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333625=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333625
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:04
Start Date: 24/Oct/19 18:04
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338715064
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -152,18 +147,12 @@ public void addSerDeProperties(HiveRegistrationUnit
source, HiveRegistrationUnit
if (source.getOutputFormat().isPresent()) {
target.setOutputFormat(source.getOutputFormat().get());
}
-if (source.getSerDeProps().contains(SCHEMA_LITERAL)) {
- target.setSerDeProp(SCHEMA_LITERAL,
source.getSerDeProps().getProp(SCHEMA_LITERAL));
-}
}
@Override
public void updateSchema(HiveRegistrationUnit existingUnit,
HiveRegistrationUnit newUnit)
throws IOException {
-Preconditions.checkArgument(
-newUnit.getSerDeProps().contains(SCHEMA_LITERAL));
-
-existingUnit.setSerDeProp(SCHEMA_LITERAL,
newUnit.getSerDeProps().getProp(SCHEMA_LITERAL));
+log.debug("Do nothing to update schema since orc.schema.literal is
removed");
Review comment:
Getting rid of this method override
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333625)
Time Spent: 40m (was: 0.5h)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[ https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333572=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333572 ] ASF GitHub Bot logged work on GOBBLIN-924: -- Author: ASF GitHub Bot Created on: 24/Oct/19 16:33 Start Date: 24/Oct/19 16:33 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-545999828 @autumnust can you take a look at this change? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 333572) Time Spent: 20m (was: 10m) > Get rid of orc.schema.literal in ORC-ingestion and registration > --- > > Key: GOBBLIN-924 > URL: https://issues.apache.org/jira/browse/GOBBLIN-924 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-924) Get rid of orc.schema.literal in ORC-ingestion and registration
[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=332852=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332852
]
ASF GitHub Bot logged work on GOBBLIN-924:
--
Author: ASF GitHub Bot
Created on: 23/Oct/19 20:26
Start Date: 23/Oct/19 20:26
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-924
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Get rid of orc.schema.literal in ORC-ingestion and registration
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test, and test on cluster to make sure new orc partition does not have
the orc.schema.literal property.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 332852)
Remaining Estimate: 0h
Time Spent: 10m
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
