***UNCHECKED*** [jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337563=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337563 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 01/Nov/19 21:26 Start Date: 01/Nov/19 21:26 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337563) Time Spent: 3h 20m (was: 3h 10m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337123=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337123
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 01/Nov/19 00:56
Start Date: 01/Nov/19 00:56
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341419272
##
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
##
@@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
//.. use columns from destination schema
if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
log.info("Generating DDL using source schema");
+ System.out.println("Generating DDL using source schema");
ddl.append(generateAvroToHiveColumnMapping(schema,
Optional.of(hiveColumns), true, dbName + "." + tblName));
+ try {
Review comment:
Yes, at least it's enabled in scoreevent. BTW, can you look at the new pr
for this commit? I have sent you the email. Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337123)
Time Spent: 3h 10m (was: 3h)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337115
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 01/Nov/19 00:26
Start Date: 01/Nov/19 00:26
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341415129
##
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
##
@@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
//.. use columns from destination schema
if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
log.info("Generating DDL using source schema");
+ System.out.println("Generating DDL using source schema");
ddl.append(generateAvroToHiveColumnMapping(schema,
Optional.of(hiveColumns), true, dbName + "." + tblName));
+ try {
Review comment:
Fair enough. Worth to check if the production have schema evolution enabled.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337115)
Time Spent: 2h 50m (was: 2h 40m)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337119=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337119 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 01/Nov/19 00:30 Start Date: 01/Nov/19 00:30 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341415701 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/task/HiveConverterUtils.java ## @@ -151,6 +154,30 @@ public static String generateCreateDuplicateTableDDL( dbName, tblName, inputDbName, inputTblName, tblLocation); } + public static String generateAlterSchemaDML( + String tableName, + Optional optionalDbName, Review comment: +1 for consistency. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337119) Time Spent: 3h (was: 2h 50m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337112=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337112 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 01/Nov/19 00:23 Start Date: 01/Nov/19 00:23 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341414676 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java ## @@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity generatePublishQueries() throws DataConversio Map publishDirectories = publishEntity.getPublishDirectories(); List cleanupQueries = publishEntity.getCleanupQueries(); List cleanupDirectories = publishEntity.getCleanupDirectories(); +Optional avroSchema = Optional.absent(); Review comment: Your call. I am OK with both. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337112) Time Spent: 2h 40m (was: 2.5h) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337111=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337111 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 01/Nov/19 00:23 Start Date: 01/Nov/19 00:23 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341414676 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java ## @@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity generatePublishQueries() throws DataConversio Map publishDirectories = publishEntity.getPublishDirectories(); List cleanupQueries = publishEntity.getCleanupQueries(); List cleanupDirectories = publishEntity.getCleanupDirectories(); +Optional avroSchema = Optional.absent(); Review comment: You call. I am OK with both. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337111) Time Spent: 2.5h (was: 2h 20m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337086=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337086 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 22:49 Start Date: 31/Oct/19 22:49 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791#issuecomment-548599519 @autumnust Here is the new PR, Thx. ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337086) Time Spent: 2h 20m (was: 2h 10m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337073 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 22:02 Start Date: 31/Oct/19 22:02 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791#issuecomment-548577059 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=h1) Report > Merging [#2791](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/f60409ef0b6768bf46ddd137333d8d56981798fc?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `34.37%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2791 +/- ## - Coverage 45.34% 45.33% -0.01% + Complexity 8863 8862 -1 Files 1894 1894 Lines 7087970910 +31 Branches 7795 7799 +4 + Hits 3213732146 +9 - Misses3577835798 +20 - Partials 2964 2966 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh) | `51.59% <0%> (-4.66%)` | `23 <0> (ø)` | | | [...ion/hive/converter/AbstractAvroToOrcConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9jb252ZXJ0ZXIvQWJzdHJhY3RBdnJvVG9PcmNDb252ZXJ0ZXIuamF2YQ==) | `58.36% <100%> (+0.17%)` | `15 <0> (ø)` | :arrow_down: | | [...izer/HiveMaterializerFromEntityQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9tYXRlcmlhbGl6ZXIvSGl2ZU1hdGVyaWFsaXplckZyb21FbnRpdHlRdWVyeUdlbmVyYXRvci5qYXZh) | `89.61% <16.66%> (-6.17%)` | `6 <0> (ø)` | | | [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `67.13% <75%> (+0.12%)` | `84 <1> (+1)` | :arrow_up: | | [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (-7.15%)` | `3% <0%> (-1%)` | | | [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=footer). Last update [f60409e...42a3dbe](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=lastupdated). Read the [comment
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337064 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:30 Start Date: 31/Oct/19 21:30 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791#issuecomment-548577059 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=h1) Report > Merging [#2791](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/f60409ef0b6768bf46ddd137333d8d56981798fc?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `36.36%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2791 +/- ## - Coverage 45.34% 45.33% -0.01% Complexity 8863 8863 Files 1894 1894 Lines 7087970911 +32 Branches 7795 7799 +4 + Hits 3213732148 +11 - Misses3577835799 +21 Partials 2964 2964 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh) | `51.59% <0%> (-4.66%)` | `23 <0> (ø)` | | | [...ion/hive/converter/AbstractAvroToOrcConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9jb252ZXJ0ZXIvQWJzdHJhY3RBdnJvVG9PcmNDb252ZXJ0ZXIuamF2YQ==) | `58.36% <100%> (+0.17%)` | `15 <0> (ø)` | :arrow_down: | | [...izer/HiveMaterializerFromEntityQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9tYXRlcmlhbGl6ZXIvSGl2ZU1hdGVyaWFsaXplckZyb21FbnRpdHlRdWVyeUdlbmVyYXRvci5qYXZh) | `89.61% <16.66%> (-6.17%)` | `6 <0> (ø)` | | | [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `67.2% <76.92%> (+0.19%)` | `84 <1> (+1)` | :arrow_up: | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | | | [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: | | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2791/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr=footer). Last update
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337058=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337058
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 31/Oct/19 21:17
Start Date: 31/Oct/19 21:17
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341369711
##
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
##
@@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
//.. use columns from destination schema
if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
log.info("Generating DDL using source schema");
+ System.out.println("Generating DDL using source schema");
ddl.append(generateAvroToHiveColumnMapping(schema,
Optional.of(hiveColumns), true, dbName + "." + tblName));
+ try {
Review comment:
I want to make sure only when schema evolution is enabled or there is no
existing table, we can set the columns. Because that will overwrite the schema.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337058)
Time Spent: 1h 40m (was: 1.5h)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337059=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337059 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:19 Start Date: 31/Oct/19 21:19 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341370332 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java ## @@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity generatePublishQueries() throws DataConversio Map publishDirectories = publishEntity.getPublishDirectories(); List cleanupQueries = publishEntity.getCleanupQueries(); List cleanupDirectories = publishEntity.getCleanupDirectories(); +Optional avroSchema = Optional.absent(); Review comment: This is not called by Avro2Roc. I add this just to make sure it's consistent with that. But I can remove this one if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337059) Time Spent: 1h 50m (was: 1h 40m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337047=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337047 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:01 Start Date: 31/Oct/19 21:01 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341363858 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java ## @@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity generatePublishQueries() throws DataConversio Map publishDirectories = publishEntity.getPublishDirectories(); List cleanupQueries = publishEntity.getCleanupQueries(); List cleanupDirectories = publishEntity.getCleanupDirectories(); +Optional avroSchema = Optional.absent(); Review comment: I might be wrong but is this method being called through the conversion jobs? By briefly looking at the code base, this `generatePublishQueries` method is only called in `org.apache.gobblin.data.management.conversion.hive.materializer.HiveMaterializer#generatePublishQueries` which is not related to Avro2ORC, just want to confirm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337047) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337045=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337045
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 31/Oct/19 21:01
Start Date: 31/Oct/19 21:01
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341361806
##
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
##
@@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
//.. use columns from destination schema
if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
log.info("Generating DDL using source schema");
+ System.out.println("Generating DDL using source schema");
ddl.append(generateAvroToHiveColumnMapping(schema,
Optional.of(hiveColumns), true, dbName + "." + tblName));
+ try {
Review comment:
Why adding table properties only happens in this branch ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337045)
Time Spent: 1h 10m (was: 1h)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337052=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337052 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:09 Start Date: 31/Oct/19 21:09 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341366880 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/task/HiveConverterUtils.java ## @@ -151,6 +154,30 @@ public static String generateCreateDuplicateTableDDL( dbName, tblName, inputDbName, inputTblName, tblLocation); } + public static String generateAlterSchemaDML( + String tableName, + Optional optionalDbName, Review comment: Since I try to make it consistent with method generateCreateDuplicateTableDDL. In which the dbName is optional. I guess it's for testing. But not so sure about that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337052) Time Spent: 1.5h (was: 1h 20m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337050=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337050 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:08 Start Date: 31/Oct/19 21:08 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341366268 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/converter/AbstractAvroToOrcConverter.java ## @@ -85,6 +86,7 @@ * Subdirectory within destination ORC table directory to publish data */ private static final String PUBLISHED_TABLE_SUBDIRECTORY = "final"; + public static final String OUTPUT_AVRO_SCHEMA_KEY = "output.avro.schema"; Review comment: This one will be access in HiveMaterializerFromEntityQueryGenerator when it try to get the schema. So I set it to be public static. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337050) Time Spent: 1h 20m (was: 1h 10m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337037=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337037 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 20:54 Start Date: 31/Oct/19 20:54 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#issuecomment-548564313 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=h1) Report > Merging [#2790](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/9ee4dcaf66257b6e2926cf1470b16b912cd343ff?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #2790 +/- ## === - Coverage 4.15% 4.15% -0.01% Complexity 746 746 === Files 18941894 Lines 70877 70911 +34 Branches 77937799 +6 === Hits 29462946 - Misses67617 67651 +34 Partials314 314 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ion/hive/converter/AbstractAvroToOrcConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9jb252ZXJ0ZXIvQWJzdHJhY3RBdnJvVG9PcmNDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...izer/HiveMaterializerFromEntityQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9tYXRlcmlhbGl6ZXIvSGl2ZU1hdGVyaWFsaXplckZyb21FbnRpdHlRdWVyeUdlbmVyYXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=footer). Last update [9ee4dca...50639f2](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337037) Time Spent: 40m (was: 0.5h) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 >
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337046=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337046 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:01 Start Date: 31/Oct/19 21:01 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341357961 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/task/HiveConverterUtils.java ## @@ -151,6 +154,30 @@ public static String generateCreateDuplicateTableDDL( dbName, tblName, inputDbName, inputTblName, tblLocation); } + public static String generateAlterSchemaDML( + String tableName, + Optional optionalDbName, Review comment: I am not sure why dbName is optional This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337046) Time Spent: 1h 10m (was: 1h) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337044=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337044
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 31/Oct/19 21:01
Start Date: 31/Oct/19 21:01
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341357486
##
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
##
@@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
//.. use columns from destination schema
if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
log.info("Generating DDL using source schema");
+ System.out.println("Generating DDL using source schema");
Review comment:
Do you still need it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337044)
Time Spent: 1h 10m (was: 1h)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337042=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337042
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 31/Oct/19 21:01
Start Date: 31/Oct/19 21:01
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341358581
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##
@@ -61,8 +61,6 @@
*/
@Slf4j
public class HiveOrcSerDeManager extends HiveSerDeManager {
- // Schema is in the format of TypeDescriptor
- public static final String SCHEMA_LITERAL = "orc.schema.literal";
Review comment:
Do a rebase and push with force option to avoid old commits
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337042)
Time Spent: 1h (was: 50m)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337043=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337043 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:01 Start Date: 31/Oct/19 21:01 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341356298 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/converter/AbstractAvroToOrcConverter.java ## @@ -85,6 +86,7 @@ * Subdirectory within destination ORC table directory to publish data */ private static final String PUBLISHED_TABLE_SUBDIRECTORY = "final"; + public static final String OUTPUT_AVRO_SCHEMA_KEY = "output.avro.schema"; Review comment: Does it need to be public static ? Limit access modifiers so that it won't be accidentally touched by irrelevant constructs in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337043) Time Spent: 1h 10m (was: 1h) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337048=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337048 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 21:01 Start Date: 31/Oct/19 21:01 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341358264 ## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/task/HiveConverterUtils.java ## @@ -151,6 +154,30 @@ public static String generateCreateDuplicateTableDDL( dbName, tblName, inputDbName, inputTblName, tblLocation); } + public static String generateAlterSchemaDML( Review comment: Shall we use `generateAlterSerDePropsDML`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337048) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337035=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337035
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 31/Oct/19 20:46
Start Date: 31/Oct/19 20:46
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2791:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2791
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-941
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Enhance DDL to add column and column.types with case-preserving schema which
would enforce avro2orc output preserving correct casing
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test and test the avroToOrc pipeline to make sure the output preserving
correct casing
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337035)
Time Spent: 0.5h (was: 20m)
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337038=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337038 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 20:55 Start Date: 31/Oct/19 20:55 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#issuecomment-548564313 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=h1) Report > Merging [#2790](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/9ee4dcaf66257b6e2926cf1470b16b912cd343ff?src=pr=desc) will **increase** coverage by `41.17%`. > The diff coverage is `28.57%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2790 +/- ## = + Coverage 4.15% 45.33% +41.17% - Complexity 746 8864 +8118 = Files 1894 1894 Lines 7087770911 +34 Branches 7793 7799+6 = + Hits 294632148+29202 + Misses6761735797-31820 - Partials314 2966 +2652 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=) | `63.95% <0%> (+63.95%)` | `12 <0> (+12)` | :arrow_up: | | [...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh) | `51.59% <0%> (+51.59%)` | `23 <0> (+23)` | :arrow_up: | | [...ion/hive/converter/AbstractAvroToOrcConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9jb252ZXJ0ZXIvQWJzdHJhY3RBdnJvVG9PcmNDb252ZXJ0ZXIuamF2YQ==) | `58.36% <100%> (+58.36%)` | `15 <0> (+15)` | :arrow_up: | | [...izer/HiveMaterializerFromEntityQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9tYXRlcmlhbGl6ZXIvSGl2ZU1hdGVyaWFsaXplckZyb21FbnRpdHlRdWVyeUdlbmVyYXRvci5qYXZh) | `89.61% <16.66%> (+89.61%)` | `6 <0> (+6)` | :arrow_up: | | [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `67.2% <76.92%> (+67.2%)` | `84 <1> (+84)` | :arrow_up: | | [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0% <0%> (ø)` | `2% <0%> (+2%)` | :arrow_up: | | [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.95% <0%> (+0.95%)` | `1% <0%> (+1%)` | :arrow_up: | | [...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2790/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=) | `81.97% <0%> (+1.16%)` | `32% <0%> (ø)` | :arrow_down: | |
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[ https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337034=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337034 ] ASF GitHub Bot logged work on GOBBLIN-941: -- Author: ASF GitHub Bot Created on: 31/Oct/19 20:45 Start Date: 31/Oct/19 20:45 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 337034) Time Spent: 20m (was: 10m) > Enhance DDL to add column and column.types with case-preserving schema > -- > > Key: GOBBLIN-941 > URL: https://issues.apache.org/jira/browse/GOBBLIN-941 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Enhance DDL to add column and column.types with case-preserving schema which > would enforce avro2orc output preserving correct casing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema
[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337022=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337022
]
ASF GitHub Bot logged work on GOBBLIN-941:
--
Author: ASF GitHub Bot
Created on: 31/Oct/19 20:19
Start Date: 31/Oct/19 20:19
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-941] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-941
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Enhance DDL to add column and column.types with case-preserving schema which
would enforce avro2orc output preserving correct casing
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test and test the avroToOrc pipeline to make sure the output preserving
correct casing
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 337022)
Remaining Estimate: 0h
Time Spent: 10m
> Enhance DDL to add column and column.types with case-preserving schema
> --
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
