[GitHub] incubator-griffin pull request #456: [GRIFFIN-213] Custom connector support
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/456#discussion_r234475362 --- Diff: griffin-doc/measure/measure-configuration-guide.md --- @@ -188,7 +188,7 @@ Above lists DQ job configure parameters. - **sinks**: Whitelisted sink types for this job. Note: no sinks will be used, if empty or omitted. ### Data Connector -- **type**: Data connector type, "AVRO", "HIVE", "TEXT-DIR" for batch mode, "KAFKA" for streaming mode. +- **type**: Data connector type: "AVRO", "HIVE", "TEXT-DIR", "CUSTOM" for batch mode; "KAFKA", "CUSTOM" for streaming mode. --- End diff -- do you think about 'ANY' as replacement for 'CUSTOM' **type**: Data connector type, "AVRO", "HIVE", "TEXT-DIR" for batch mode, "KAFKA" for streaming mode, "ANY" for boths. ---
[GitHub] incubator-griffin issue #455: [GRIFFIN-212] Add matchedFraction in streaming...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/455 I'm fine on this change ---
[GitHub] incubator-griffin issue #453: Fixservicetests
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/453 LGTM. it's necessary to rename mock entity class. ---
[GitHub] incubator-griffin issue #452: [GRIFFIN-209] update param util, add UT for pa...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/452 LGTM ---
[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/444 It's long process of discussion and review, but we get a consensus finally and close this change. thanks guys @chemikadze @gavlyukovskiy @guoyuepeng ---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r232269364
--- Diff:
service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java
---
@@ -0,0 +1,50 @@
+package org.apache.griffin.core.event;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.springframework.beans.BeansException;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.context.ApplicationContext;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Configuration
+public class GriffinEventListeners {
+private static final Logger LOGGER = LoggerFactory
+.getLogger(GriffinEventListeners.class);
+
+@Autowired
+private ApplicationContext context;
+@Value("#{'${internal.event.listeners}'.split(',')}")
+private List listeners;
+
+@Bean
+public List getListenersRegistered() {
--- End diff --
good catch @gavlyukovskiy
new revision will follow your suggestion
thanks
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r231352539 --- Diff: service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java --- @@ -0,0 +1,51 @@ +package org.apache.griffin.core.event; + +import java.util.ArrayList; +import java.util.List; + +import org.springframework.beans.BeansException; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.ApplicationContext; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Configuration +@ConfigurationProperties(prefix = "internal.event") --- End diff -- thanks guys I'm gonna remove @ ConfigurationProperties annotation ---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/444#discussion_r230622329 --- Diff: service/src/main/resources/application.properties --- @@ -62,3 +62,5 @@ elasticsearch.scheme=http livy.uri=http://localhost:8998/batches # yarn url yarn.uri=http://localhost:8088 +# griffin event listener +#internal.event.listeners=org.apache.griffin.core.event.JobEventHook --- End diff -- correct, change it as definition in test folder ---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230622132
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -158,17 +162,22 @@ public JobServiceImpl() {
} catch (SchedulerException e) {
LOGGER.error("Failed to get RUNNING jobs.", e);
throw new GriffinException
-.ServiceException("Failed to get RUNNING jobs.", e);
+.ServiceException("Failed to get RUNNING jobs.", e);
}
return dataList;
}
@Override
public AbstractJob addJob(AbstractJob job) throws Exception {
+JobEvent jobEvent = JobEvent.yieldJobEventBeforeCreation(null);
--- End diff --
@Test(expected=UnImplementedException.class), yeah I ever have considered.
but hope not to throw exception in a transaction, so make it empty method.
---
[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/444 summary of comments 1.considering general usage, I do not use 'GriffinJobEventManager' but actually name it 'GriffinEventManager' 2.I keep empty implementation for JobEventHook.onEvent(). because I think it should be done in another change 3.Measure event could follow job event to implement @guoyuepeng @chemikadze ---
[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/444 let me change name to GriffinJobEventManage ---
[GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/444 @guoyuepeng @chemikadze Thanks for your comments on first version of hook implementation. I have completed new implementation, here I simplify hook load, extend event type. if this is good for you, we can do following work based on this. best regards ---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230049250
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -168,7 +175,14 @@ public AbstractJob addJob(AbstractJob job) throws
Exception {
Long measureId = job.getMeasureId();
GriffinMeasure measure = getMeasureIfValid(measureId);
JobOperator op = getJobOperator(measure.getProcessType());
-return op.add(job, measure);
+AbstractJob jobSaved = op.add(job, measure);
+JobEvent jobEvent = new JobEvent(jobSaved);
+eventListeners.forEach(hook -> {
--- End diff --
in local test, if using synchronous call, listener probably led db
transaction failure on condition that listener didn't return.
I think it's better that injection doesn't impact current code flow
@chemikadze @guoyuepeng how do you think about
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047870
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package org.apache.griffin.core.integration;
+
+/**
+ * A semantic event which indicates that a griffin-defined action occurred.
+ * This high-level event is generated by an action (such as an
+ * addJob) when the task-specific action occurs.
+ * The event is passed to every GriffinHook object
+ * that registered to receive such events using configuration.
+ *
+ * @author Eugene Liu
+ * @since 0.3
+ */
+public interface GriffinEvent {
+/**
+ * @return concrete event type
+ */
+String getType();
--- End diff --
ok, let us change to enum as event type, like
Enum type {
job,
measure,
...
}
do you agree?
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047399
--- Diff:
service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java ---
@@ -0,0 +1,69 @@
+package org.apache.griffin.core.job;
+
+import static
org.apache.griffin.core.util.EntityHelper.createGriffinMeasure;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.griffin.core.exception.GriffinException;
+import org.apache.griffin.core.integration.GriffinEvent;
+import org.apache.griffin.core.integration.GriffinHook;
+import org.apache.griffin.core.integration.JobEvent;
+import org.apache.griffin.core.job.entity.BatchJob;
+import org.apache.griffin.core.job.entity.JobDataSegment;
+import org.apache.griffin.core.measure.entity.GriffinMeasure;
+import org.apache.griffin.core.measure.entity.Measure;
+import org.apache.griffin.core.util.EntityHelper;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
+import
org.springframework.boot.test.autoconfigure.orm.jpa.TestEntityManager;
+import org.springframework.context.annotation.ComponentScan;
+import org.springframework.test.context.junit4.SpringRunner;
+import org.springframework.util.Assert;
+
+@RunWith(SpringRunner.class)
+//@TestConfiguration
+//@AutoConfigureTestEntityManager
+@DataJpaTest
+@ComponentScan("org.apache.griffin.core")
+//@SpringBootTest
+//@ContextConfiguration(classes = {JobServiceImpl.class,
SchedulerFactoryBean.class, JobInstanceRepo.class})
+public class EventServiceTest {
+@Autowired
+private JobService jobService;
+
+@Autowired
+private TestEntityManager entityManager;
+
+@Before
+public void setup() throws Exception {
+Class.forName("org.apache.griffin.core.integration.JobEventHook");
+entityManager.clear();
+entityManager.flush();
+setEntityManager();
+}
+
+@Test
+public void testAddJobEvent() throws Exception {
--- End diff --
yes, I try to catch exception to verify. but I don't find way in spring
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047076
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package org.apache.griffin.core.integration;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
+
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
+
+@Configuration
+@ConfigurationProperties(prefix = "internal.event")
+public class GriffinEventListeners {
+private static final Logger LOGGER = LoggerFactory
+.getLogger(GriffinEventListeners.class);
+@Value("${internal.event.listeners}")
+private String listeners;
--- End diff --
let me try spring list
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230046860
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package org.apache.griffin.core.integration;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
+
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
+
+@Configuration
+@ConfigurationProperties(prefix = "internal.event")
+public class GriffinEventListeners {
+private static final Logger LOGGER = LoggerFactory
+.getLogger(GriffinEventListeners.class);
+@Value("${internal.event.listeners}")
+private String listeners;
+
+@Value("${internal.event.scheduler.thread.size}")
+private int threadPoolSize;
+
+@Bean
+public ThreadPoolTaskExecutor getListenersScheduler() {
+ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();
+executor.setCorePoolSize(threadPoolSize);
+executor.setMaxPoolSize(threadPoolSize * 2);
+executor.setThreadNamePrefix("event_listener_task_scheduler");
+executor.initialize();
+
+return executor;
+}
+
+@Bean
+public List getListenersRegistered() {
+ArrayList hookList = new ArrayList<>();
+if (listeners == null || listeners.isEmpty()) {
+LOGGER.info("Disable griffin event listener for service.");
+} else {
+//split list of class name
+Scanner scanner = new Scanner(listeners).useDelimiter(";");
--- End diff --
let me try it
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230046728
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java ---
@@ -0,0 +1,11 @@
+package org.apache.griffin.core.integration;
+
+import org.apache.griffin.core.exception.GriffinException;
+
+public class JobEventHook implements GriffinHook {
+@Override
+public void onEvent(GriffinEvent event) throws GriffinException {
+throw new GriffinException.UnImplementedException(
+"This method needs to be reimplemented by event-consuming
purpose");
--- End diff --
if we think about exporting interface and hope user to implement method
details. we should let it empty or throw a exception tip here
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230045266
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package org.apache.griffin.core.integration;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
+
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.context.properties.ConfigurationProperties;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
+
+@Configuration
+@ConfigurationProperties(prefix = "internal.event")
+public class GriffinEventListeners {
+private static final Logger LOGGER = LoggerFactory
+.getLogger(GriffinEventListeners.class);
+@Value("${internal.event.listeners}")
+private String listeners;
+
+@Value("${internal.event.scheduler.thread.size}")
+private int threadPoolSize;
+
+@Bean
+public ThreadPoolTaskExecutor getListenersScheduler() {
+ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor();
+executor.setCorePoolSize(threadPoolSize);
+executor.setMaxPoolSize(threadPoolSize * 2);
+executor.setThreadNamePrefix("event_listener_task_scheduler");
+executor.initialize();
+
+return executor;
+}
+
+@Bean
+public List getListenersRegistered() {
+ArrayList hookList = new ArrayList<>();
+if (listeners == null || listeners.isEmpty()) {
+LOGGER.info("Disable griffin event listener for service.");
+} else {
+//split list of class name
+Scanner scanner = new Scanner(listeners).useDelimiter(";");
+while (scanner.hasNext()) {
+String hookName = scanner.next();
+try {
+Class cl = (Class)
Class.forName(hookName);
+GriffinHook hook = cl.newInstance();
--- End diff --
I have no feasible/good idea to inject/load external listener now.
so I used java reflection to new listener instance.
let me think about spring inject functionality
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r228040937
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -128,10 +129,22 @@ Licensed to the Apache Software Foundation (ASF)
under one
@Autowired
private StreamingJobOperatorImpl streamingJobOp;
+@Value("${internal.event.listeners}")
--- End diff --
good point, let me change by your suggestion
---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r228040806
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package org.apache.griffin.core.integration;
+
+/**
+ * A semantic event which indicates that a griffin-defined action occurred.
+ * This high-level event is generated by an action (such as an
+ * addJob) when the task-specific action occurs.
+ * The event is passed to every GriffinHook object
+ * that registered to receive such events using configuration.
+ *
+ * @author Eugene Liu
+ * @since 0.3
+ */
+public interface GriffinEvent {
+/**
+ * @return concrete event type
+ */
+String getType();
--- End diff --
yeah, I have considered this.
if we use enum type, probably we have to change its definition after a new
event type is raised.
so I wanna return full qualified class name as correct type name
---
[GitHub] incubator-griffin issue #441: [GRIFFIN-207] LDAP login service improvements
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/441 LGTM ---
[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/444 Define griffin plain-vanilla hook. the purpose of hook is for integration with components outside. Griffin would offer information about internal task status. Task: GRIFFIN-200 You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin hook Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/444.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #444 commit 2fbd30a64c563febe59240b67aae4653e996a522 Author: Eugene Date: 2018-10-22T14:12:38Z Define griffin plain-vanilla hook. the purpose of hook is for integration with components outside. Griffin would offer information about internal task status. Task: GRIFFIN-200 ---
[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226905150 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software Foundation (ASF) under one @Column(name = "\"out\"") private String out; +@JsonInclude(JsonInclude.Include.NON_NULL) --- End diff -- do we have a standard api definition, implicit or explicit depend on what api style exposes to users ---
[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226904188
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,68 @@
+package org.apache.griffin.core.login.ldap;
+
+import javax.net.SocketFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLSocketFactory;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.X509TrustManager;
+import java.io.IOException;
+import java.net.InetAddress;
+import java.net.Socket;
+import java.net.UnknownHostException;
+import java.security.cert.CertificateException;
+import java.security.cert.X509Certificate;
+
+public class SelfSignedSocketFactory extends SocketFactory {
--- End diff --
as a new file, you have to add java doc to describe
---
[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226904191 --- Diff: service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java --- @@ -0,0 +1,68 @@ +package org.apache.griffin.core.login.ldap; --- End diff -- you should add apache license claim here ---
[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226903885 --- Diff: service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java --- @@ -0,0 +1,68 @@ +package org.apache.griffin.core.login.ldap; --- End diff -- you should add license information here ---
[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226903865
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,68 @@
+package org.apache.griffin.core.login.ldap;
+
+import javax.net.SocketFactory;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLSocketFactory;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.X509TrustManager;
+import java.io.IOException;
+import java.net.InetAddress;
+import java.net.Socket;
+import java.net.UnknownHostException;
+import java.security.cert.CertificateException;
+import java.security.cert.X509Certificate;
+
+public class SelfSignedSocketFactory extends SocketFactory {
--- End diff --
as a public class, you have to add java doc to describe
---
[GitHub] incubator-griffin pull request #439: Complement stuffs to docker guide.
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/439 Complement stuffs to docker guide. You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/docker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #439 commit 4c91052a78edd8f9d1c109c3c8253889e84d0487 Author: Eugene Date: 2018-10-15T13:33:52Z Completement stuffs to docker guide. ---
[GitHub] incubator-griffin pull request #432: Fix a little doc bug concerning measure...
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/432#discussion_r225024005 --- Diff: griffin-doc/measure/measure-batch-sample.md --- @@ -18,7 +18,7 @@ under the License. --> # Measure Batch Sample -Measures consists of batch measure and streaming measure. This document is for the batch measure sample. +Griffin measures consist of batch measure and streaming measure, this document merely gives the batch measure sample. --- End diff -- sure. let me do it ---
[GitHub] incubator-griffin pull request #433: Fix a bug in postman script
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/433 Fix a bug in postman script postman collection is not up to date, some APIs don't work well. script has been refreshed in this patch by postman 2.1 standard. Jira task: GRIFFIN-204 You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/postman Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/433.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #433 commit 46bc51526836353cf58e06947d23542415d2e64c Author: Eugene Date: 2018-10-09T13:13:35Z Fix a bug in postman script postman collection is not up to date, some APIs don't work well. script has been refreshed in this patch by postman 2.1 standard. Jira task: GRIFFIN-204 ---
[GitHub] incubator-griffin pull request #432: Fix a little doc bug concerning measure...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/432 Fix a little doc bug concerning measure part. fix linguistic error and improve content You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/measure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/432.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #432 commit 35cf8ccac41a63d46d5c78310d5c6dbf8d1df5b2 Author: Eugene Date: 2018-10-02T14:52:39Z Fix a little doc bug concerning measure part. fix linguistic error and improve content ---
[GitHub] incubator-griffin issue #429: Fix timeout failure in travis CI.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/429 @guoyuepeng @chemikadze I agree to keeping -q parameter, as travis only permit 4M log file size. please see latest update, decrease git pull/clone log output, I think it should be merged with #428 https://github.com/apache/incubator-griffin/pull/429/commits/913c9def8a8eafab187c6a6ae1d436beb80d ---
[GitHub] incubator-griffin issue #428: Increase build silence timeout
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/428 @guoyuepeng @chemikadze travis offers cache feature which prevents from downloading maven dependencies every time. I made pr429 to solve this issue. https://github.com/apache/incubator-griffin/pull/429 ---
[GitHub] incubator-griffin pull request #429: Fix timeout failure in travis CI.
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/429 Fix timeout failure in travis CI. Build times out because no output was received. 'travis_wait mvn clean verify -q' will spawn a process to deal with mvn task -q,--quiet Quiet output - only show errors -q probably leads no output caught by travis, so timeout failure happens refer to: https://docs.travis-ci.com/user/common-build-problems/#limitations-of-travis_wait You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin build/tarvis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/429.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #429 commit c21b9412aaba318a9a23b675d1dd0d43bf5747cb Author: Eugene Date: 2018-10-01T12:18:01Z Fix timeout failure in travis CI. Build times out because no output was received. 'travis_wait mvn clean verify -q' will spawn a process to deal with mvn task -q,--quiet Quiet output - only show errors -q probably leads no output caught by travis, so timeout failure happens refer to: https://docs.travis-ci.com/user/common-build-problems/#limitations-of-travis_wait ---
[GitHub] incubator-griffin pull request #426: Fix code bug.
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/426 Fix code bug. 1.add java method description 2.reformat import statements violating Griffin's code rule https://github.com/apache/incubator-griffin/blob/master/griffin-doc/dev/code-style.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin src/service Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/426.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #426 commit 742ab9cc56abe2b3e29cfb6b3a1714a9643266fc Author: Eugene Date: 2018-09-30T10:47:34Z Fix code bug. 1.add java method description 2.reformat import statements violating Griffin's code rule https://github.com/apache/incubator-griffin/blob/master/griffin-doc/dev/code-style.md ---
[GitHub] incubator-griffin issue #420: Fix doc issue.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/420 retry again, it's fine. Thanks guys ---
[GitHub] incubator-griffin issue #420: Fix doc issue.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/420 --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/apache/logging/log4j/log4j-slf4j-impl/2.7/log4j-slf4j-impl-2.7.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.22/slf4j-log4j12-1.7.22.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] Running org.apache.griffin.core.metric.MetricControllerTest The command "travis_wait mvn clean verify -q" exited with 137. Done. Your build exited with 1. why is travis running not stable ---
[GitHub] incubator-griffin issue #420: Fix doc issue.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/420 @bhlx3lyx7 just update doc description, please review again thanks ---
[GitHub] incubator-griffin issue #420: Fix doc issue.
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/420 Sure, I'll update this PR and keep Distinctness instead of Uniqueness ---
[GitHub] incubator-griffin pull request #420: Fix doc issue.
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/420 Fix doc issue. dsl-guide describes two kinds of rules, Uniqueness and Distinctness. actually they are similiar rule, so we merely keep Uniqueness rule. You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/dsl-guide Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/420.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #420 commit 5e898791c8543e66f820658e5352587795488c3e Author: Eugene Date: 2018-09-21T08:23:30Z Fix doc issue. dsl-guide describes two kinds of rules, Uniqueness and Distinctness. actually they are similiar rule, so we merely keep Uniqueness rule. ---
[GitHub] incubator-griffin issue #416: Fix rest api bug in service component
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/416 @chemikadze I have double checked, release version has been 0.3.0 incubator-griffin/service/src/main/resources/banner.txt. thank for your reminder ---
[GitHub] incubator-griffin pull request #416: Fix rest api bug in service component
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/416 Fix rest api bug in service component GET /api/v1/version returns mistaken release version 0.2.0 instead of 0.3.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin src/service Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit 783f9234e0cad25275280fe16e13eacd3bbd7a15 Author: Eugene Date: 2018-09-17T13:40:43Z Fix rest api bug in service component GET /api/v1/version returns mistaken release version 0.2.0 instead of 0.3.0 ---
[GitHub] incubator-griffin pull request #412: Fix API doc bug and complement some stu...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/412 Fix API doc bug and complement some stuffs You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/412.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #412 commit 52c6608f0561b407b0b1ce1dac5f47ded01f7624 Author: Eugene Date: 2018-09-08T14:06:43Z Fix API doc bug and complement some stuffs ---
[GitHub] incubator-griffin pull request #411: Improve document quality
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/411 Improve document quality Revise docker guide document and append more descriptions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/docker Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #411 commit bbdfcefa859a6eec2eafdee93102c36899c8454b Author: Eugene Date: 2018-09-07T07:37:05Z Improve document quality Revise docker guide document and append more descriptions. ---
[GitHub] incubator-griffin pull request #407: In order to improve readability, comple...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/407 In order to improve readability, complement some stuffs into readme doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/407.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #407 commit 699287c0b8f465eb083926985e058d27ea1f958b Author: Eugene Date: 2018-08-30T13:44:48Z In order to improve readability, complement some stuffs into readme doc ---
[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/384 @guoyuepeng I append guide part about how to enable style-check in maven and idea. I think we can add scala and type script code style rule here as well thanks ---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/388 @guoyuepeng William, I see recent changes still have some violations against basic code style rules. like import statement using * instead of concrete class name, too long code line over 100 characters etc. as a good opensource product, style is first glance of code quality. ---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/388 conflicts have been resolved ---
[GitHub] incubator-griffin issue #388: Fix bugs about code style violation against Gr...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/388 @guoyuepeng William, I'll resolve those conflicts. any question, let me know ---
[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/384 I agree with you @guoyuepeng actually a code style guide is better than code template here. I will revise this patch ---
[GitHub] incubator-griffin pull request #388: Fix bugs about code style violation aga...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/388 Fix bugs about code style violation against Griffin rules You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin wrap Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #388 commit e61a515ce91630cc229e7ddb549b200f7653f000 Author: Eugene Date: 2018-08-07T14:11:32Z Fix bugs about code style violation against Griffin rules ---
[GitHub] incubator-griffin pull request #386: Trim and reformat resource files
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/386 Trim and reformat resource files You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin property Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #386 commit c6757c6f5d2aa72e2f528b6565588f11a46097b8 Author: Eugene Date: 2018-08-05T05:02:38Z Trim and reformat resource files ---
[GitHub] incubator-griffin pull request #385: Fix import violations by Griffin code c...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/385 Fix import violations by Griffin code check rules You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin import Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #385 commit a045c54236f04990ad3b6cc9f46d5384690cab26 Author: Eugene Date: 2018-08-05T04:56:32Z Fix import violations by Griffin code check rules ---
[GitHub] incubator-griffin pull request #384: Initialize java code checks rules for g...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/384 Initialize java code checks rules for griffin this config could be used by maven checkStyle plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #384 commit a3708b6856efc53572aad6a6178697dab5ed718d Author: Eugene Date: 2018-08-05T04:35:03Z Initialize java code checks rules for griffin this config could be used by maven checkStyle plugin ---
[GitHub] incubator-griffin pull request #383: Fix code style violations and improve q...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/383 Fix code style violations and improve quality You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin EnvConfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #383 commit cca13006971182699db6c019c3fd3e187ffe6413 Author: Eugene Date: 2018-08-05T04:26:21Z Fix code style violations and improve quality ---
[GitHub] incubator-griffin issue #380: Fix java import style violations in codes by c...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/380 @guoyuepeng @bhlx3lyx7 please consider to keep same code style and we can do those work step by step ---
[GitHub] incubator-griffin issue #380: Fix java import style violations in codes by c...
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/380 by Griffin's code style rules extends google/sun, we need to reformat import statement. here I have gone thru service packages and cleaned/adjusted all import statements ---
[GitHub] incubator-griffin pull request #380: Fix java import style violations in cod...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/380 Fix java import style violations in codes by code style suggested by s⦠â¦un/google You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin importStyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/380.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #380 commit b90b7dddc9a7d4c066a2efdc90d468ca0cf03857 Author: Eugene Date: 2018-07-31T13:08:52Z Fix java import style violations in codes by codestyle suggested by sun/google ---
[GitHub] incubator-griffin pull request #379: Fix code style bug in MeasureRepo
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/379 Fix code style bug in MeasureRepo You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin MeasureRepo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/379.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #379 commit 68ccfd9c2fa5f0e1d5d99bb94f425ad56fff60e8 Author: Eugene Date: 2018-07-31T06:25:19Z Fix code style bug in MeasureRepo ---
[GitHub] incubator-griffin pull request #378: Fix code bugs and correct code style
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/378 Fix code bugs and correct code style You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin SimpleCORSFilter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/378.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #378 commit ccd8c9cdeaa4c76aeba6976fddbf023e02ba52c3 Author: Eugene Date: 2018-07-30T14:52:11Z Fix code bugs and correct code style ---
[GitHub] incubator-griffin pull request #377: Remove unused method and clean codes
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/377 Remove unused method and clean codes You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin measure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/377.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #377 commit fc55f0af1a8b65f9bf6cece6746ce383cf245857 Author: Eugene Date: 2018-07-30T09:24:58Z Remove unused method and clean codes ---
[GitHub] incubator-griffin pull request #375: Fix code bug and improve code quality
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/375 Fix code bug and improve code quality You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin measure/fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #375 commit d46ec886c4c694d670a564d56afcb425cb0b5528 Author: Eugene Date: 2018-07-26T12:21:44Z Fix code bug and improve code quality ---
[GitHub] incubator-griffin issue #374: Fix bug and improve code quality
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/374 invalidate this change and resubmit again later ---
[GitHub] incubator-griffin pull request #374: Fix bug and improve code quality
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/374 ---
[GitHub] incubator-griffin pull request #374: Fix bug and improve code quality
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/374 Fix bug and improve code quality You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin measure/fix1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/374.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #374 commit 9c0098e7bfe4882c433f577cbfab5df7f4b5b8d1 Author: Eugene Date: 2018-07-05T00:54:19Z add scala static analysis plugin commit b4706eeec31caa869dedb1726eb3de17b0d9c056 Author: Eugene Date: 2018-07-26T12:21:44Z Fix code bug and improve code quality ---
[GitHub] incubator-griffin pull request #372: Fix doc bug and make it more clear and ...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/372 Fix doc bug and make it more clear and understandable You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/fix2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/372.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #372 commit a2f752d5cfe4aa9df47e273505ba4fadb2441b39 Author: Eugene Date: 2018-07-24T14:15:58Z Fix doc bug and make it more clear and understandable ---
[GitHub] incubator-griffin pull request #371: Fix doc bug and improve doc readability
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/371 Fix doc bug and improve doc readability You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/fix1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit c7e80a8438aee3d81e08078832d3809b3c02010b Author: Eugene Date: 2018-07-24T12:11:52Z Fix doc bug and improve doc readability ---
[GitHub] incubator-griffin pull request #368: Fix doc bug and improve readability of ...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/368 Fix doc bug and improve readability of Griffin project introduction You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/fix2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #368 commit 22a00fa1e663f0d667927a7bf86b7be2c3ca75a5 Author: Eugene Date: 2018-07-22T15:17:52Z Fix doc bug and improve readability of Griffin project introduction ---
[GitHub] incubator-griffin pull request #367: Fix doc bugs and improve its quality an...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/367 Fix doc bugs and improve its quality and readability You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin doc/fix1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #367 commit 5cf3d603c809c1972d3ad53bea31fd1bb6bfea4b Author: Eugene Date: 2018-07-22T13:30:49Z Fix doc bugs and improve its quality and readability ---
[GitHub] incubator-griffin pull request #364: Fix bug and refactor ExternalMeasureOpe...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/364 Fix bug and refactor ExternalMeasureOperatorImpl test codes You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin emoit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/364.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #364 commit 228cebc0417356b892bdb149d6865a4f678ce1e6 Author: Eugene Date: 2018-07-16T09:47:43Z Fix bug and refactor ExternalMeasureOperatorImpl test codes ---
[GitHub] incubator-griffin pull request #355: Fix bug and enable new test cases to ve...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/355 Fix bug and enable new test cases to verify GriffinMeasureOperatorImpl You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin bug/fixing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 commit 95cf208eef353a9cbd2531d571d7ce41d89956d5 Author: Eugene Date: 2018-07-10T05:57:20Z Fix unit case bug JobInstanceRepoTest always fails to run due to code bug, fix it here commit 05ae2677945c3a34d02fd9981a525a90df066782 Author: Eugene Date: 2018-07-12T03:04:04Z Merge branch 'master' of https://github.com/apache/incubator-griffin commit ce6e073ba38cbc82ad3da8845748913005b015be Author: Eugene Date: 2018-07-13T03:12:07Z Merge branch 'master' of https://github.com/apache/incubator-griffin commit c3db596009b556aa8c3f403aef4f6373ba87f33a Author: Eugene Date: 2018-07-13T06:02:17Z Refactor fix unit test bug in service commit 1d5dcddfcfe93838c1834866462a7d04a9af7aff Author: Eugene Date: 2018-07-16T09:17:43Z Merge branch 'master' of https://github.com/apache/incubator-griffin commit 257fab5cf90fefb4a107dae99bdc50eb94741913 Author: Eugene Date: 2018-07-16T09:21:35Z Fix bug and refactor GriffinMeasureOperatorImpl test codes ---
[GitHub] incubator-griffin pull request #351: Pr/testcase
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/351 Pr/testcase Refactor codes and fix unit test bug You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin pr/testcase Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/351.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #351 commit 95cf208eef353a9cbd2531d571d7ce41d89956d5 Author: Eugene Date: 2018-07-10T05:57:20Z Fix unit case bug JobInstanceRepoTest always fails to run due to code bug, fix it here commit 05ae2677945c3a34d02fd9981a525a90df066782 Author: Eugene Date: 2018-07-12T03:04:04Z Merge branch 'master' of https://github.com/apache/incubator-griffin commit ce6e073ba38cbc82ad3da8845748913005b015be Author: Eugene Date: 2018-07-13T03:12:07Z Merge branch 'master' of https://github.com/apache/incubator-griffin commit c3db596009b556aa8c3f403aef4f6373ba87f33a Author: Eugene Date: 2018-07-13T06:02:17Z Refactor fix unit test bug in service ---
[GitHub] incubator-griffin pull request #347: Test
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/347 Test You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #347 commit 95cf208eef353a9cbd2531d571d7ce41d89956d5 Author: Eugene Date: 2018-07-10T05:57:20Z Fix unit case bug JobInstanceRepoTest always fails to run due to code bug, fix it here commit 05ae2677945c3a34d02fd9981a525a90df066782 Author: Eugene Date: 2018-07-12T03:04:04Z Merge branch 'master' of https://github.com/apache/incubator-griffin commit bf0f9bfbc440c8c088aa4c3156ce9612617bdd0a Author: Eugene Date: 2018-07-12T06:54:16Z Refactor fix unit test bug in service package ---
[GitHub] incubator-griffin pull request #345: Head option
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/345 Head option You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin headOption Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 4200bfc3b34a0dec54b975aeeba3b53cf290d064 Author: Eugene Date: 2018-07-05T00:54:19Z add scala static analysis plugin commit cd523f423e0e01db29c6457ffd49fd13c86ce84f Author: Eugene Date: 2018-07-11T09:54:44Z Refactor Fix some static analysis errors after integrated with scala codes quality plugin ---
[GitHub] incubator-griffin pull request #342: Fix unit case bug
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/342 Fix unit case bug JobInstanceRepoTest always fails to run due to code bug, fix it here You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/342.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #342 commit 95cf208eef353a9cbd2531d571d7ce41d89956d5 Author: Eugene Date: 2018-07-10T05:57:20Z Fix unit case bug JobInstanceRepoTest always fails to run due to code bug, fix it here ---
[GitHub] incubator-griffin pull request #338: correct minor literal mistakes in doc
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/338 correct minor literal mistakes in doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin l1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #338 commit 0aba27658afcd2b97206bde8301e6f65fbac4ff8 Author: Eugene Date: 2018-07-08T14:53:08Z correct minor literal mistakes in doc ---
[GitHub] incubator-griffin pull request #337: fix a bad practice, Empty interpolated ...
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/337
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("...").s()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin b3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/337.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #337
commit 8f31beb77dfd5a9077eb40a8724a4ed11d379e36
Author: Eugene
Date: 2018-07-05T02:23:09Z
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("...").s()
---
[GitHub] incubator-griffin pull request #332: fix a bad practice
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/332 ---
[GitHub] incubator-griffin issue #332: fix a bad practice
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/332 Hi, @whhe @guoyuepeng I submit a new patch to revise, please review again https://github.com/apache/incubator-griffin/pull/335 ---
[GitHub] incubator-griffin pull request #335: fix a bad practice
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/335 fix a bad practice 1.Format string should use %n rather than \n In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator. 2.use System.lineSeparator() instead of '\n' 3.trim up some extra long code lines You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin bug-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/335.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #335 commit 0d53fb80df3621dd61488a69d7b1f5864419cf5b Author: Eugene Date: 2018-07-02T08:22:46Z fix a bad practice 1.Format string should use %n rather than \n In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator. 2.use System.lineSeparator() instead of '\n' 3.trim up some extra long code lines ---
[GitHub] incubator-griffin issue #332: fix a bad practice
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/332 let me check how many times '\n' was used in codes and make a new patch ---
[GitHub] incubator-griffin pull request #334: fix a bad practice, Empty interpolated ...
GitHub user toyboxman opened a pull request:
https://github.com/apache/incubator-griffin/pull/334
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("cache after replace old df").s()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toyboxman/incubator-griffin bug1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-griffin/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
commit 7b0d39fabf5e6f45c33b572a294acf3e125d95c4
Author: Eugene
Date: 2018-07-03T13:12:18Z
fix a bad practice, Empty interpolated string
String declared as interpolated but has no parameters:
scala.StringContext.apply("cache after replace old df").s()
---
[GitHub] incubator-griffin issue #332: fix a bad practice
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @whhe
I got you here. but I wanna clarify why I change it.
Java Formatter suggests % as special notation character instead of '\'
https://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html
but if you build customized string like statement you mentioned, '\n' is
all right, however line.separator is better.
bulkRequestBody.append("\n");
---
[GitHub] incubator-griffin pull request #331: refactor dead test cases
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/331 ---
[GitHub] incubator-griffin issue #331: refactor dead test cases
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/331 root cause is about spring context association in different testcases, let me remove it and submit again ---
[GitHub] incubator-griffin pull request #333: refactor dead test cases
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/333 refactor dead test cases 1.active KafkaSchemaServiceImplTest and resolve failures You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin testcases-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/333.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #333 commit 15492eb9a8c3f44cdc97632144d31633b0e541b2 Author: Eugene Date: 2018-07-02T07:07:58Z refactor dead test cases 1.active KafkaSchemaServiceImplTest and resolve failures ---
[GitHub] incubator-griffin issue #331: refactor dead test cases
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/331 I don't touch those testcases, just add some test cases for kafka service. I need to check it later ---
[GitHub] incubator-griffin pull request #332: fix a bad practice
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/332 fix a bad practice Format string should use %n rather than \n In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin bugs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #332 commit bd665dbdfed28c175bf7a24991ee050876d2178e Author: Eugene Date: 2018-07-02T08:22:46Z fix a bad practice Format string should use %n rather than \n In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator. ---
[GitHub] incubator-griffin pull request #331: refactor dead test cases
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/331 refactor dead test cases 1.active KafkaSchemaServiceImplTest and resolve failures You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin testcases Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #331 commit c7b02f92334e78448461bf1fed92e52475795ce0 Author: Eugene Date: 2018-07-02T07:07:58Z refactor dead test cases 1.active KafkaSchemaServiceImplTest and resolve failures ---
[GitHub] incubator-griffin pull request #329: fix potential stream resource loss
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/329 ---
[GitHub] incubator-griffin pull request #326: fix potential stream resource loss
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/326 fix potential stream resource loss when BufferedReader is used, it should be closed explicitly You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin pr/bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #326 commit f19a5ec8347dc1b4048fc920a5f91c0b4348dad8 Author: Eugene Date: 2018-06-28T06:51:37Z fix potential stream resource loss when BufferedReader is used, it should be closed explicitly ---
[GitHub] incubator-griffin pull request #325: refactor dead test cases
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/325 refactor dead test cases 1.active KafkaSchemaControllerTest and resolve failures 2.trim and tidy up codes You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin refactor/testcase Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/325.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #325 commit c7980e087e1ae24fcd2e0ee35e1b320d02b4fa04 Author: Eugene Date: 2018-06-27T06:17:40Z refactor dead test cases 1.active KafkaSchemaControllerTest and resolve failures 2.trim and tidy up codes ---
[GitHub] incubator-griffin pull request #324: refactor some java codes including,
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/324 refactor some java codes including, 1.unused system.out statement 2.extra blank line in codes 3.same string constants used in multiple methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin refactor/testcases Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/324.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #324 commit 82a6e369c970ebcf928f65846efcec2cc80d7221 Author: Eugene Date: 2018-06-24T13:22:04Z refactor some java codes including, 1.unused system.out statement 2.extra blank line in codes 3.same string constants used in multiple methods ---
[GitHub] incubator-griffin pull request #323: refactor test codes in service/src/test...
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/323 refactor test codes in service/src/test/java/org/apache/griffin/core/⦠â¦util/PropertiesUtilTest.java 1.remove assert keyword instead of Junit Assert class You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin refactor/testcases Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/323.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #323 commit 1e1b6cb58a311429358044019b329dffc53e6bfa Author: Eugene Date: 2018-06-22T00:53:02Z refactor test codes in service/src/test/java/org/apache/griffin/core/util/PropertiesUtilTest.java 1.remove assert keyword instead of Junit Assert class ---
[GitHub] incubator-griffin pull request #322: Refactor/update cases
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/322 ---
[GitHub] incubator-griffin pull request #322: Refactor/update cases
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/322 Refactor/update cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin refactor/update-cases Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 commit 83c7115f5442c64cfd2f159adf1b17caa68986c9 Author: Eugene Date: 2018-06-20T06:07:40Z update scala maven plugin to lastest verson commit f4cc00a9ab6e4983415087ba6e4fd81fb805bdae Author: Eugene Date: 2018-06-20T07:52:37Z refactor JsonUtilTest codes including: 1.remove unusual assert keyword instead of Assert 2.trim and clean codes commit 7024637f17cc91afea9d8ed6de71d457e2f1aba9 Author: Eugene Date: 2018-06-21T01:26:37Z update scala-maven-plugin to 3.3.1 for compatibility commit b9739119830e72e4698e8a007e1658e71ab5ec80 Author: Eugene Date: 2018-06-21T01:39:43Z Merge branch 'master' of https://github.com/apache/incubator-griffin ---
[GitHub] incubator-griffin pull request #316: update scala maven plugin to lastest ve...
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/316 ---
[GitHub] incubator-griffin issue #316: update scala maven plugin to lastest verson
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/316 sure, you are right. I'm using maven 3.5.3. I have changed to 3.4.1 in latest update, pls review again ---
[GitHub] incubator-griffin pull request #317: Refactor/update cases
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/317 Refactor/update cases refactor JsonUtilTest codes including: 1.remove unusual assert keyword instead of Assert 2.trim and clean codes You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin refactor/update-cases Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #317 commit 83c7115f5442c64cfd2f159adf1b17caa68986c9 Author: Eugene Date: 2018-06-20T06:07:40Z update scala maven plugin to lastest verson commit f4cc00a9ab6e4983415087ba6e4fd81fb805bdae Author: Eugene Date: 2018-06-20T07:52:37Z refactor JsonUtilTest codes including: 1.remove unusual assert keyword instead of Assert 2.trim and clean codes ---
