Re: [RESULT] [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

Thanks for the comment, Stack.

Obviously this didn't happen last week :). I'm going to rebase once more 
and run the dev-tests locally and then plan to commit today.


On 5/19/17 3:29 PM, Stack wrote:

Sounds good Josh. Thanks for heads up on when merge happens.

Regards merge before branch for 2, IIRC, this is pretty well contained so
should not throw-off work like the big patch out on HBASE-14614 branch.

St.Ack

On Fri, May 19, 2017 at 7:30 AM, Josh Elser  wrote:


Calling this VOTE as we have 3 +1's (myself, Ted, and Enis).

Special thanks to Ted, Enis, and Andrew for their reviews along the way.
You all brought up great improvements that made this a better feature.

On a procedural note, I intend to rebase the changeset once more and queue
up the bits to merge into master around EOD (I'm in EST). If there are
others that share the concern Andrew raised about this landing in 2.0 (as
opposed to waiting for a branch-2 or hbase 3.0 branch), please speak up and
we can figure those details. Thanks!

- Josh


Josh Elser wrote:


Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
heHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas

Re: [RESULT] [VOTE] Merge space quota branch (HBASE-16961) into master

[Stack]

Sounds good Josh. Thanks for heads up on when merge happens.

Regards merge before branch for 2, IIRC, this is pretty well contained so
should not throw-off work like the big patch out on HBASE-14614 branch.

St.Ack

On Fri, May 19, 2017 at 7:30 AM, Josh Elser  wrote:

> Calling this VOTE as we have 3 +1's (myself, Ted, and Enis).
>
> Special thanks to Ted, Enis, and Andrew for their reviews along the way.
> You all brought up great improvements that made this a better feature.
>
> On a procedural note, I intend to rebase the changeset once more and queue
> up the bits to merge into master around EOD (I'm in EST). If there are
> others that share the concern Andrew raised about this landing in 2.0 (as
> opposed to waiting for a branch-2 or hbase 3.0 branch), please speak up and
> we can figure those details. Thanks!
>
> - Josh
>
>
> Josh Elser wrote:
>
>> Folks,
>>
>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>> Per the book, this requires 3 binding +1's from other committers to merge.
>>
>> Relevant info for those who want to revisit any topics:
>>
>> DISCUSS on merge[1]
>> Design Doc[2]
>> Staged user manual[3]
>>
>> I'll plan to leave this open for at least 72hrs of the work days
>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>> abstain from voting on my own feature and plan to do so if the votes are
>> otherwise lacking.
>>
>> - Josh
>>
>> [1]
>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>
>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>> heHBase.pdf
>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>>
>

[RESULT] [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

Calling this VOTE as we have 3 +1's (myself, Ted, and Enis).

Special thanks to Ted, Enis, and Andrew for their reviews along the way. 
You all brought up great improvements that made this a better feature.


On a procedural note, I intend to rebase the changeset once more and 
queue up the bits to merge into master around EOD (I'm in EST). If there 
are others that share the concern Andrew raised about this landing in 
2.0 (as opposed to waiting for a branch-2 or hbase 3.0 branch), please 
speak up and we can figure those details. Thanks!


- Josh

Josh Elser wrote:

Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

Since we're struggling to get votes cast (I can only assume due to lack 
of time from individuals since there have been no objections/concerns 
raised).


Here's my +1 too

Josh Elser wrote:

Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Enis Söztutar]

Sorry missed the deadline again, but I've spend some time with the patches
today, and I'll cast my vote as +1 for the merge.

This feature is pretty relevant to multi-tenant, bigger clusters, and is a
good complimentary to existing quotas support.
 - The code is high quality, readable, pluggable and comes with a large
number of unit tests.
 - Comes with shell support, Master UI, and metrics
 - Documentation

Ideally, we can have this in 2.0 (even without  HBASE-17748
), because it is useable
at this point. From my reading of the code, there is no risk to
destabilizing the current code base since almost all of the code is new,
and disabled by default.

Thanks,
Enis

On Thu, May 11, 2017 at 2:50 PM, Josh Elser  wrote:

> As requested (later in this thread), I'll make sure this VOTE stays open
> at least until 2017-05-17 (an extra week). If time continues to be a
> barrier for review/input, please do speak up.
>
>
> Josh Elser wrote:
>
>> Folks,
>>
>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>> Per the book, this requires 3 binding +1's from other committers to merge.
>>
>> Relevant info for those who want to revisit any topics:
>>
>> DISCUSS on merge[1]
>> Design Doc[2]
>> Staged user manual[3]
>>
>> I'll plan to leave this open for at least 72hrs of the work days
>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>> abstain from voting on my own feature and plan to do so if the votes are
>> otherwise lacking.
>>
>> - Josh
>>
>> [1]
>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>
>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>> heHBase.pdf
>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>>
>

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

As requested (later in this thread), I'll make sure this VOTE stays open 
at least until 2017-05-17 (an extra week). If time continues to be a 
barrier for review/input, please do speak up.


Josh Elser wrote:

Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Andrew Purtell]

I mentioned 2.0 if the thought of merging a major change while trying to
stabilize for branching of branch-2 was causing people to hold off casting
a vote. Maybe that is only a concern of mine.


On Tue, May 9, 2017 at 3:29 PM, Josh Elser  wrote:

> I won't pretend to be involved enough in the 2.0 work to give an opinion
> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
> master decides to be at the time I merge).
>
> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
> fine by me. I'm also happy to not immediately merge after this vote
> completes.
>
> Andrew Purtell wrote:
>
>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>> major feature?
>>
>>
>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser  wrote:
>>
>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>>> far.
>>>
>>>
>>> Josh Elser wrote:
>>>
>>> Folks,

 This is a vote to (rebase and) merge the branch HBASE-16961 into master.
 Per the book, this requires 3 binding +1's from other committers to
 merge.

 Relevant info for those who want to revisit any topics:

 DISCUSS on merge[1]
 Design Doc[2]
 Staged user manual[3]

 I'll plan to leave this open for at least 72hrs of the work days
 (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
 abstain from voting on my own feature and plan to do so if the votes are
 otherwise lacking.

 - Josh

 [1]
 https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

 [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
 heHBase.pdf
 [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
 ce-quotas


>>
>>


-- 
Best regards,

   - Andy

If you are given a choice, you believe you have acted freely. - Raymond
Teller (via Peter Watts)

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

Right. 17748 is not in the picture right now.

Happy to leave this open for more time if people would like it. Thanks 
for taking a look!


Enis Söztutar wrote:

Just to be clear, you are proposing the merge without
https://issues.apache.org/jira/browse/HBASE-17748 in place, right?

Enis

On Wed, May 10, 2017 at 4:47 PM, Enis Söztutar  wrote:


I was following the patches up to some extend, but I am not up to date on
the recent stuff. Let me spend some time with the newest code.

I think we can extend the vote to give others some more time as well.

Enis

On Tue, May 9, 2017 at 3:29 PM, Josh Elser  wrote:


I won't pretend to be involved enough in the 2.0 work to give an opinion
:) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
master decides to be at the time I merge).

If the spirit of the voters is to include this in 3.0 and not 2.0, that's
fine by me. I'm also happy to not immediately merge after this vote
completes.


Andrew Purtell wrote:


Would it help to cut a branch for 2.0 before attempting to merge in a new
major feature?


On Tue, May 9, 2017 at 8:41 AM, Josh Elser   wrote:

Reminder: I hope to close this in ~30hrs and there have been no votes so

far.


Josh Elser wrote:

Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into
master.
Per the book, this requires 3 binding +1's from other committers to
merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes
are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
heHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
ce-quotas

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Enis Söztutar]

Just to be clear, you are proposing the merge without
https://issues.apache.org/jira/browse/HBASE-17748 in place, right?

Enis

On Wed, May 10, 2017 at 4:47 PM, Enis Söztutar  wrote:

> I was following the patches up to some extend, but I am not up to date on
> the recent stuff. Let me spend some time with the newest code.
>
> I think we can extend the vote to give others some more time as well.
>
> Enis
>
> On Tue, May 9, 2017 at 3:29 PM, Josh Elser  wrote:
>
>> I won't pretend to be involved enough in the 2.0 work to give an opinion
>> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
>> master decides to be at the time I merge).
>>
>> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
>> fine by me. I'm also happy to not immediately merge after this vote
>> completes.
>>
>>
>> Andrew Purtell wrote:
>>
>>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>>> major feature?
>>>
>>>
>>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser  wrote:
>>>
>>> Reminder: I hope to close this in ~30hrs and there have been no votes so
 far.


 Josh Elser wrote:

 Folks,
>
> This is a vote to (rebase and) merge the branch HBASE-16961 into
> master.
> Per the book, this requires 3 binding +1's from other committers to
> merge.
>
> Relevant info for those who want to revisit any topics:
>
> DISCUSS on merge[1]
> Design Doc[2]
> Staged user manual[3]
>
> I'll plan to leave this open for at least 72hrs of the work days
> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
> abstain from voting on my own feature and plan to do so if the votes
> are
> otherwise lacking.
>
> - Josh
>
> [1]
> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>
> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
> heHBase.pdf
> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
> ce-quotas
>
>
>>>
>>>
>

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Enis Söztutar]

I was following the patches up to some extend, but I am not up to date on
the recent stuff. Let me spend some time with the newest code.

I think we can extend the vote to give others some more time as well.

Enis

On Tue, May 9, 2017 at 3:29 PM, Josh Elser  wrote:

> I won't pretend to be involved enough in the 2.0 work to give an opinion
> :) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 (whatever
> master decides to be at the time I merge).
>
> If the spirit of the voters is to include this in 3.0 and not 2.0, that's
> fine by me. I'm also happy to not immediately merge after this vote
> completes.
>
>
> Andrew Purtell wrote:
>
>> Would it help to cut a branch for 2.0 before attempting to merge in a new
>> major feature?
>>
>>
>> On Tue, May 9, 2017 at 8:41 AM, Josh Elser  wrote:
>>
>> Reminder: I hope to close this in ~30hrs and there have been no votes so
>>> far.
>>>
>>>
>>> Josh Elser wrote:
>>>
>>> Folks,

 This is a vote to (rebase and) merge the branch HBASE-16961 into master.
 Per the book, this requires 3 binding +1's from other committers to
 merge.

 Relevant info for those who want to revisit any topics:

 DISCUSS on merge[1]
 Design Doc[2]
 Staged user manual[3]

 I'll plan to leave this open for at least 72hrs of the work days
 (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
 abstain from voting on my own feature and plan to do so if the votes are
 otherwise lacking.

 - Josh

 [1]
 https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

 [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
 heHBase.pdf
 [3] https://people.apache.org/~elserj/hbase/quotas/book.html#spa
 ce-quotas


>>
>>

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

I won't pretend to be involved enough in the 2.0 work to give an opinion 
:) -- I did say earlier that I'm happy to land this in 2.0 or 3.0 
(whatever master decides to be at the time I merge).


If the spirit of the voters is to include this in 3.0 and not 2.0, 
that's fine by me. I'm also happy to not immediately merge after this 
vote completes.


Andrew Purtell wrote:

Would it help to cut a branch for 2.0 before attempting to merge in a new
major feature?


On Tue, May 9, 2017 at 8:41 AM, Josh Elser  wrote:


Reminder: I hope to close this in ~30hrs and there have been no votes so
far.


Josh Elser wrote:


Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
heHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Andrew Purtell]

Would it help to cut a branch for 2.0 before attempting to merge in a new
major feature?


On Tue, May 9, 2017 at 8:41 AM, Josh Elser  wrote:

> Reminder: I hope to close this in ~30hrs and there have been no votes so
> far.
>
>
> Josh Elser wrote:
>
>> Folks,
>>
>> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
>> Per the book, this requires 3 binding +1's from other committers to merge.
>>
>> Relevant info for those who want to revisit any topics:
>>
>> DISCUSS on merge[1]
>> Design Doc[2]
>> Staged user manual[3]
>>
>> I'll plan to leave this open for at least 72hrs of the work days
>> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
>> abstain from voting on my own feature and plan to do so if the votes are
>> otherwise lacking.
>>
>> - Josh
>>
>> [1]
>> https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
>> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
>>
>> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
>> heHBase.pdf
>> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>>
>


-- 
Best regards,

   - Andy

If you are given a choice, you believe you have acted freely. - Raymond
Teller (via Peter Watts)

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Ted Yu]

+1 on merging this to master branch.

I have reviewed Josh's work for phase 1.
This is an important addition for multi-tenant deployments.

On Fri, May 5, 2017 at 4:24 PM, Josh Elser  wrote:

> Folks,
>
> This is a vote to (rebase and) merge the branch HBASE-16961 into master.
> Per the book, this requires 3 binding +1's from other committers to merge.
>
> Relevant info for those who want to revisit any topics:
>
> DISCUSS on merge[1]
> Design Doc[2]
> Staged user manual[3]
>
> I'll plan to leave this open for at least 72hrs of the work days
> (Wednesday May 10th EOD) in case there are any vetos. I would prefer to
> abstain from voting on my own feature and plan to do so if the votes are
> otherwise lacking.
>
> - Josh
>
> [1] https://lists.apache.org/thread.html/a28c69bff315a791b9f7b94
> 6636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E
> [2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApac
> heHBase.pdf
> [3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>

Re: [VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

Reminder: I hope to close this in ~30hrs and there have been no votes so 
far.


Josh Elser wrote:

Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master.
Per the book, this requires 3 binding +1's from other committers to merge.

Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to
abstain from voting on my own feature and plan to do so if the votes are
otherwise lacking.

- Josh

[1]
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas

[VOTE] Merge space quota branch (HBASE-16961) into master

[Josh Elser]

Folks,

This is a vote to (rebase and) merge the branch HBASE-16961 into master. 
Per the book, this requires 3 binding +1's from other committers to merge.


Relevant info for those who want to revisit any topics:

DISCUSS on merge[1]
Design Doc[2]
Staged user manual[3]

I'll plan to leave this open for at least 72hrs of the work days 
(Wednesday May 10th EOD) in case there are any vetos. I would prefer to 
abstain from voting on my own feature and plan to do so if the votes are 
otherwise lacking.


- Josh

[1] 
https://lists.apache.org/thread.html/a28c69bff315a791b9f7b946636446a60bd2ddc8d5a9f5c11c2bf6f4@%3Cdev.hbase.apache.org%3E

[2] http://home.apache.org/~elserj/hbase/FileSystemQuotasforApacheHBase.pdf
[3] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas