AW: [PATCH] Dynamic locking upcalls in mod_ssl
-Ursprüngliche Nachricht- Von: Sander Temme Gesendet: Freitag, 15. August 2008 07:04 An: dev@httpd.apache.org Betreff: [PATCH] Dynamic locking upcalls in mod_ssl Folks, The following patch against trunk adds dynamic locking callbacks to mod_ssl. OpenSSL uses these in several places, including the CHIL engine that interfaces with the nCipher products. I work at nCipher, and this patch makes the CHIL engine load into a stock, unpatched openssl 0.9.8. I've tested this on Linux (Ubuntu 7.10 w/ OpensSSL 0.9.8e-5ubuntu3.2) and put some load on this on Solaris 10 x86_64 with OpenSSL 0.9.8h. It's not a lot of code, and I don't think it gets in anyone's way. Opinions appreciated, especially on whether I'm doing the right thing with that pool: Two quick comments: 1. Why creating a global pool for dynlockpool? Why can't this be a subpool of the pool passed to ssl_util_thread_setup? 2. I would prefer to name the apr_status_t variables rv instead of r. r is normally reserved for the request :-). Regards Rüdiger
Re: [PATCH] Dynamic locking upcalls in mod_ssl
On Aug 15, 2008, at 12:48 AM, Plüm, Rüdiger, VF-Group wrote: 1. Why creating a global pool for dynlockpool? Why can't this be a subpool of the pool passed to ssl_util_thread_setup? Because that's the pconf pool and gets cleared across the lifetime of some of the mutexes that OpenSSL creates. I tried, and using pconf made the httpd parent hang on shutdown, in a tight loop trying to clear one of its pools... 2. I would prefer to name the apr_status_t variables rv instead of r. r is normally reserved for the request :-). Absolutely. S. -- Sander Temme [EMAIL PROTECTED] PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF smime.p7s Description: S/MIME cryptographic signature
Re: Mpm maintenance thread hook
On Aug 6, 2008, at 5:16 PM, Akins, Brian wrote: On 8/4/08 3:41 PM, Jim Jagielski [EMAIL PROTECTED] wrote: *grin* I've always wondered what usefulness ap_run_monitor(p) FWIW, we use the monitor hook all the time... The usefulness of being passed just a pool is what I was referring to ;)
